Daniel Kiper <dki...@net-space.pl> skriver: > On Fri, Jul 16, 2021 at 05:22:42PM +0100, Dimitri John Ledkov wrote: >> On Wed, Jul 7, 2021 at 2:52 PM Daniel Kiper <dki...@net-space.pl> wrote: >> > >> > On Sun, Jun 13, 2021 at 03:11:51PM +0200, Marius Bakke wrote: >> > > The 'ide-drive' device was removed in QEMU 6.0. >> > >> > Could you add your Signed-off-by? >> > >> > > * tests/ahci_test.in (outfile): s/ide-drive/ide-hd/ >> > >> > Please drop this. >> > >> > > --- >> > > tests/ahci_test.in | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > >> > > diff --git a/tests/ahci_test.in b/tests/ahci_test.in >> > > index 7df560462..d844fe680 100644 >> > > --- a/tests/ahci_test.in >> > > +++ b/tests/ahci_test.in >> > > @@ -41,7 +41,7 @@ echo "hello" > "$outfile" >> > > >> > > tar cf "$imgfile" "$outfile" >> > > >> > > -if [ "$(echo "nativedisk; source '(ahci0)/$outfile';" | "${grubshell}" >> > > --qemu-opts="-drive id=disk,file=$imgfile,if=none -device ahci,id=ahci >> > > -device ide-drive,drive=disk,bus=ahci.0 " | tail -n 1)" != "Hello World" >> > > ]; then >> > > +if [ "$(echo "nativedisk; source '(ahci0)/$outfile';" | "${grubshell}" >> > > --qemu-opts="-drive id=disk,file=$imgfile,if=none -device ahci,id=ahci >> > > -device ide-hd,drive=disk,bus=ahci.0 " | tail -n 1)" != "Hello World" ]; >> > > then >> > >> > Is it possible to check QEMU version here and use correct variant then? >> > >> >> ide-hd has been available for more than 10 years now in qemu, thus >> there shouldn't be any need for backwards compatible names. > > OK, Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> then... > > Marius, I will add your Signed-off-by if you do not object.
Sounds good, thank you!
signature.asc
Description: PGP signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel