Re: How can I submit patch for bug #42944 ?
On Sun, 10/12/14, Andrei Borzenkov wrote: Subject: Re: How can I submit patch for bug #42944 ? To: "Andrei Borzenkov" Cc: "The development of GNU GRUB" , phco...@gmail.com Date: Sunday, October 12, 2014, 12:24 PM В Sat, 11 Oct 2014 12:58:29 +0400 Andrei Borzenkov пишет: > В Sat, 11 Oct 2014 10:44:20 +0200 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > On 10.10.2014 23:23, Colin Watson wrote: > > > On Fri, Oct 10, 2014 at 04:44:39PM +, Rigoberto Corujo wrote: > > >> I attached a patch to bug #42944 and would like to know how I would go about getting it committed to the source tree? > > >> https://savannah.gnu.org/bugs/?42944 > > > > > > I'd suggest attaching the patch to a mail here (not encased in a zip > > > file). It's usually easier to get public review that way. > > > > > I don't like to use EFI timers if we can avoid them, they've been known > > to hang. Attached is a patch to use pmtimer for calibration > > What about systems without ACPI? Does it explicitly exclude them? OK, I stay corrected. Still, this patch adds over 1K to kernel on i386-pc and about 0.5K to common core.img with ext2: -rw-r--r-- 1 bor bor 26848 Oct 12 20:09 /tmp/core.img-pmtimer -rw-r--r-- 1 bor bor 26320 Oct 12 18:50 /tmp/core.img-vanilla -rwxr-xr-x 1 bor bor 29224 Oct 12 20:08 /tmp/kernel.img-pmtimer -rwxr-xr-x 1 bor bor 28060 Oct 12 10:12 /tmp/kernel.img-vanilla I think it's too much for something that so far is needed only on very specific platform. May be we could restrict it to EFI only where size does not matter that much? Attached rebased patch (I briefly checked and it still boots on i386-pc and apparently correctly handles timeouts, but I cannot check other platforms). -Inline Attachment Follows- ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel Thank you very much for the patch. I will test it on Hyper-V Generation 2 and other physical UEFI servers and let you know the results. Regarding the concern that was expressed about SetTimer() sometimes hanging on UEFI systems, the following two files are already using SetTimer(). ./grub-core/kern/arm/efi/init.c ./grub-core/kern/ia64/efi/init.c Is it less likely that the hang occurs on those processors? Thank you, Rigoberto Corujo ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
is there HTTPS in GRUB2?
Hi expert, For network communication, I see that GRUB2 has http module but not https. Is there any intention on creating https module? Has anyone tried to create one? Regards, Madeline ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: How can I submit patch for bug #42944 ?
On Mon, 10/13/14, Rigoberto Corujo wrote: Subject: Re: How can I submit patch for bug #42944 ? To: "Andrei Borzenkov" , "The development of GNU GRUB" Cc: "The development of GNU GRUB" , phco...@gmail.com Date: Monday, October 13, 2014, 12:35 PM On Sun, 10/12/14, Andrei Borzenkov wrote: Subject: Re: How can I submit patch for bug #42944 ? To: "Andrei Borzenkov" Cc: "The development of GNU GRUB" , phco...@gmail.com Date: Sunday, October 12, 2014, 12:24 PM В Sat, 11 Oct 2014 12:58:29 +0400 Andrei Borzenkov пишет: > В Sat, 11 Oct 2014 10:44:20 +0200 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > > > On 10.10.2014 23:23, Colin Watson wrote: > > > On Fri, Oct 10, 2014 at 04:44:39PM +, Rigoberto Corujo wrote: > > >> I attached a patch to bug #42944 and would like to know how I would go about getting it committed to the source tree? > > >> https://savannah.gnu.org/bugs/?42944 > > > > > > I'd suggest attaching the patch to a mail here (not encased in a zip > > > file). It's usually easier to get public review that way. > > > > > I don't like to use EFI timers if we can avoid them, they've been known > > to hang. Attached is a patch to use pmtimer for calibration > > What about systems without ACPI? Does it explicitly exclude them? OK, I stay corrected. Still, this patch adds over 1K to kernel on i386-pc and about 0.5K to common core.img with ext2: -rw-r--r-- 1 bor bor 26848 Oct 12 20:09 /tmp/core.img-pmtimer -rw-r--r-- 1 bor bor 26320 Oct 12 18:50 /tmp/core.img-vanilla -rwxr-xr-x 1 bor bor 29224 Oct 12 20:08 /tmp/kernel.img-pmtimer -rwxr-xr-x 1 bor bor 28060 Oct 12 10:12 /tmp/kernel.img-vanilla I think it's too much for something that so far is needed only on very specific platform. May be we could restrict it to EFI only where size does not matter that much? Attached rebased patch (I briefly checked and it still boots on i386-pc and apparently correctly handles timeouts, but I cannot check other platforms). -Inline Attachment Follows- ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel Thank you very much for the patch. I will test it on Hyper-V Generation 2 and other physical UEFI servers and let you know the results. Regarding the concern that was expressed about SetTimer() sometimes hanging on UEFI systems, the following two files are already using SetTimer(). ./grub-core/kern/arm/efi/init.c ./grub-core/kern/ia64/efi/init.c Is it less likely that the hang occurs on those processors? Thank you, Rigoberto Corujo -- I tried the pmtimer patch on Microsoft Hyper-V Generation 2, as well as a physical UEFI server, and it worked well. Please let me know if this patch is going to be submitted. Thank you, Rigoberto Corujo ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: is there HTTPS in GRUB2?
В Mon, 13 Oct 2014 15:48:47 -0700 Madeline Dor пишет: > Hi expert, > > For network communication, I see that GRUB2 has http module but not https. > Is there any intention on creating https module? Has anyone tried to > create one? > There was discussion recently about using OpenSSL; it could be related. Check archives for it. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
build issue with 631a820: missing initialiser [-Werror=missing-field-initializers]
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Here is how I try to build GRUB (to be used as a coreboot payload): git clone git://git.savannah.gnu.org/grub.git cd grub ./autogen.sh ./configure --with-platform=coreboot make Usually this works, but recently I get this error: loader/i386/pc/linux.c: In function ‘grub_cmd_initrd’: loader/i386/pc/linux.c:391:10: error: missing initialiser [-Werror=missing-field-initializers] loader/i386/pc/linux.c:391:10: error: (near initialisation for ‘initrd_ctx.components’) [-Werror=missing-field-initializers] cc1: all warnings being treated as errors make[3]: *** [loader/i386/pc/linux16_module-linux.o] Error 1 make[3]: Leaving directory `/home/user/libreboot/grub/grub-core' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/user/libreboot/grub/grub-core' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/user/libreboot/grub' make: *** [all] Error 2 I tracked it down to commit 631a82003851ca68bfaf87e12be5c94e14cd2a91. Short of reverting the commit, what is the best way to go about solving this issue? -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJUPI5IAAoJEP9Ft0z50c+Ug64IAMeQEmnQcj82JEBllTh1rAs7 2YT39SxdzUmQK2LG5Lq6yv7Soh3hgVhObHhokGrs8lEgzV4jVELkPnzIrLFG/Mqk akOXQSUlM8ra7ZNwTW5ThlDETqQjkj98T2yL2sDXClBCm/u9FFzN6eybcM0jUIfd pa8rW53B4snG5DOmcmjvo5VQX1Gr7WPYUGPiSuqfqlqePhsiUkea6jzMmkTwhukW oqeyFmNrZ3VIzobhy/4wKmD104/IzLeyaaMBlWOLl4qc9/HSLJhR5i62BaqC2GAS jEjDfO0uvrE7C24St902lBezCPxyB11lhZEU18uy/KA1BY08C2Ie0qmHPmvaGls= =mk/h -END PGP SIGNATURE- ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: build issue with 631a820: missing initialiser [-Werror=missing-field-initializers]
On Tue, Oct 14, 2014 at 6:45 AM, The Gluglug wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Here is how I try to build GRUB (to be used as a coreboot payload): > > git clone git://git.savannah.gnu.org/grub.git > cd grub > ./autogen.sh > ./configure --with-platform=coreboot > make > > Usually this works, but recently I get this error: > > loader/i386/pc/linux.c: In function ‘grub_cmd_initrd’: > loader/i386/pc/linux.c:391:10: error: missing initialiser > [-Werror=missing-field-initializers] > loader/i386/pc/linux.c:391:10: error: (near initialisation for > ‘initrd_ctx.components’) [-Werror=missing-field-initializers] Hmm ... it builds fine here, with gcc 4.8. What compiler and version? > cc1: all warnings being treated as errors > make[3]: *** [loader/i386/pc/linux16_module-linux.o] Error 1 > make[3]: Leaving directory `/home/user/libreboot/grub/grub-core' > make[2]: *** [all] Error 2 > make[2]: Leaving directory `/home/user/libreboot/grub/grub-core' > make[1]: *** [all-recursive] Error 1 > make[1]: Leaving directory `/home/user/libreboot/grub' > make: *** [all] Error 2 > > I tracked it down to commit 631a82003851ca68bfaf87e12be5c94e14cd2a91. > Short of reverting the commit, what is the best way to go about > solving this issue? > > > -BEGIN PGP SIGNATURE- > Version: GnuPG v1.4.11 (GNU/Linux) > > iQEcBAEBAgAGBQJUPI5IAAoJEP9Ft0z50c+Ug64IAMeQEmnQcj82JEBllTh1rAs7 > 2YT39SxdzUmQK2LG5Lq6yv7Soh3hgVhObHhokGrs8lEgzV4jVELkPnzIrLFG/Mqk > akOXQSUlM8ra7ZNwTW5ThlDETqQjkj98T2yL2sDXClBCm/u9FFzN6eybcM0jUIfd > pa8rW53B4snG5DOmcmjvo5VQX1Gr7WPYUGPiSuqfqlqePhsiUkea6jzMmkTwhukW > oqeyFmNrZ3VIzobhy/4wKmD104/IzLeyaaMBlWOLl4qc9/HSLJhR5i62BaqC2GAS > jEjDfO0uvrE7C24St902lBezCPxyB11lhZEU18uy/KA1BY08C2Ie0qmHPmvaGls= > =mk/h > -END PGP SIGNATURE- > > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
Re: build issue with 631a820: missing initialiser [-Werror=missing-field-initializers]
On Mon, Oct 13, 2014 at 10:33 PM, Andrei Borzenkov wrote: > On Tue, Oct 14, 2014 at 6:45 AM, The Gluglug wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Here is how I try to build GRUB (to be used as a coreboot payload): >> >> git clone git://git.savannah.gnu.org/grub.git >> cd grub >> ./autogen.sh >> ./configure --with-platform=coreboot >> make >> >> Usually this works, but recently I get this error: >> >> loader/i386/pc/linux.c: In function 'grub_cmd_initrd': >> loader/i386/pc/linux.c:391:10: error: missing initialiser >> [-Werror=missing-field-initializers] >> loader/i386/pc/linux.c:391:10: error: (near initialisation for >> 'initrd_ctx.components') [-Werror=missing-field-initializers] > > Hmm ... it builds fine here, with gcc 4.8. What compiler and version? Also builds fine for me: gcc (Debian 4.9.1-16) 4.9.1 -Bryan >> cc1: all warnings being treated as errors >> make[3]: *** [loader/i386/pc/linux16_module-linux.o] Error 1 >> make[3]: Leaving directory `/home/user/libreboot/grub/grub-core' >> make[2]: *** [all] Error 2 >> make[2]: Leaving directory `/home/user/libreboot/grub/grub-core' >> make[1]: *** [all-recursive] Error 1 >> make[1]: Leaving directory `/home/user/libreboot/grub' >> make: *** [all] Error 2 >> >> I tracked it down to commit 631a82003851ca68bfaf87e12be5c94e14cd2a91. >> Short of reverting the commit, what is the best way to go about >> solving this issue? >> >> >> -BEGIN PGP SIGNATURE- >> Version: GnuPG v1.4.11 (GNU/Linux) >> >> iQEcBAEBAgAGBQJUPI5IAAoJEP9Ft0z50c+Ug64IAMeQEmnQcj82JEBllTh1rAs7 >> 2YT39SxdzUmQK2LG5Lq6yv7Soh3hgVhObHhokGrs8lEgzV4jVELkPnzIrLFG/Mqk >> akOXQSUlM8ra7ZNwTW5ThlDETqQjkj98T2yL2sDXClBCm/u9FFzN6eybcM0jUIfd >> pa8rW53B4snG5DOmcmjvo5VQX1Gr7WPYUGPiSuqfqlqePhsiUkea6jzMmkTwhukW >> oqeyFmNrZ3VIzobhy/4wKmD104/IzLeyaaMBlWOLl4qc9/HSLJhR5i62BaqC2GAS >> jEjDfO0uvrE7C24St902lBezCPxyB11lhZEU18uy/KA1BY08C2Ie0qmHPmvaGls= >> =mk/h >> -END PGP SIGNATURE- >> >> ___ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel > > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
