-------------------------------------------- On Sun, 10/12/14, Andrei Borzenkov <arvidj...@gmail.com> wrote:
Subject: Re: How can I submit patch for bug #42944 ? To: "Andrei Borzenkov" <arvidj...@gmail.com> Cc: "The development of GNU GRUB" <grub-devel@gnu.org>, phco...@gmail.com Date: Sunday, October 12, 2014, 12:24 PM В Sat, 11 Oct 2014 12:58:29 +0400 Andrei Borzenkov <arvidj...@gmail.com> пишет: > В Sat, 11 Oct 2014 10:44:20 +0200 > Vladimir 'φ-coder/phcoder' Serbinenko <phco...@gmail.com> пишет: > > > On 10.10.2014 23:23, Colin Watson wrote: > > > On Fri, Oct 10, 2014 at 04:44:39PM +0000, Rigoberto Corujo wrote: > > >> I attached a patch to bug #42944 and would like to know how I would go about getting it committed to the source tree? > > >> https://savannah.gnu.org/bugs/?42944 > > > > > > I'd suggest attaching the patch to a mail here (not encased in a zip > > > file). It's usually easier to get public review that way. > > > > > I don't like to use EFI timers if we can avoid them, they've been known > > to hang. Attached is a patch to use pmtimer for calibration > > What about systems without ACPI? Does it explicitly exclude them? OK, I stay corrected. Still, this patch adds over 1K to kernel on i386-pc and about 0.5K to common core.img with ext2: -rw-r--r-- 1 bor bor 26848 Oct 12 20:09 /tmp/core.img-pmtimer -rw-r--r-- 1 bor bor 26320 Oct 12 18:50 /tmp/core.img-vanilla -rwxr-xr-x 1 bor bor 29224 Oct 12 20:08 /tmp/kernel.img-pmtimer -rwxr-xr-x 1 bor bor 28060 Oct 12 10:12 /tmp/kernel.img-vanilla I think it's too much for something that so far is needed only on very specific platform. May be we could restrict it to EFI only where size does not matter that much? Attached rebased patch (I briefly checked and it still boots on i386-pc and apparently correctly handles timeouts, but I cannot check other platforms). -----Inline Attachment Follows----- _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel Thank you very much for the patch. I will test it on Hyper-V Generation 2 and other physical UEFI servers and let you know the results. Regarding the concern that was expressed about SetTimer() sometimes hanging on UEFI systems, the following two files are already using SetTimer(). ./grub-core/kern/arm/efi/init.c ./grub-core/kern/ia64/efi/init.c Is it less likely that the hang occurs on those processors? Thank you, Rigoberto Corujo _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
