Re: BUGS: btrfs multi-device support fixes

2013-10-27 Thread Gene Czarcinski

On 10/27/2013 02:54 AM, Andrey Borzenkov wrote:

В Sat, 26 Oct 2013 16:16:19 -0400
Gene Czarcinski  пишет:


On 10/26/2013 12:27 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:

Rejected, similar patches is in trunk since some time.

Thanks.  I was not aware that the problem had been addressed.  Can you
point me where to look to see what has been addressed?


This is commit 588744d0dc655177d5883bdcb8f72ff5160109ed.
And that sure looks like something I would expect to see from a git 
repository!


Look, I am not stupid but I sure am confused!  The grub2 website 
(http://www.gnu.org/software/grub/) says that all grub2 development done 
through bazaar repository and that you get a copy of the latest grub2 
source with: |

  bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub|
Well, I tried doing that and all I get is an error saying: "bzr: ERROR: 
Not a branch:"


Now fedora has a local git repository for grub2 located here: 
git://pkgs.fedoraproject.org/grub2.git and when I look at what is there 
I see that the updates (when they come in) appear to be in git format.


On other little thing.  I I sent this current message there were TWO bug 
fixes (TWO patch files).  I well believe that the first one was already 
in trunk since I had originally reported that problem in January 2013.  
The reason I reported it again is because it had not been pick up by fedora.


However, there is that second bug fix which I only recently found and 
fixed.  This problem occurs when you have /boot on BTRFS either as a 
separate subvolume or simply as directory under the root subvolume. In 
10_linux, when grub2-probe is call for hint, it returns multi-device 
hints separated by "\n" which completely screws things up.  The patch is:

diff --git a/util/grub-probe.c b/util/grub-probe.c
index a46f0b1..dd5de00 100644
--- a/util/grub-probe.c
+++ b/util/grub-probe.c
@@ -543,7 +543,7 @@ probe (const char *path, char **device_names, char 
delim)

   print_full_name (map, dev);
   printf ("' ");
 }
-  printf ("\n");
+  printf (" "); /* new-line causes problems for multi-device btrfs 
volumes */


   grub_device_close (dev);
   continue;
--



Gene

On 26.10.2013 17:36, Gene Czarcinski wrote:

There are two patches needed in grub2 to support multi-device btrfs
volumes.

This first patch (previously submitted) involves the parameters passed
to grub2-probe.  If not correctly passed, grub2-probe issues an error
message.  The related problem report is:
https://bugzilla.redhat.com/show_bug.cgi?id=890955

The second problem involves having a multi-device btrfs volume with
/boot being on the btrfs volume either as part of the root subvolume or
as a separate subvolume.  The result is an error messare at boot time:
  error: no such device: root.
  hit any key to continue

The solution is to modify grub-probe.c so that " " is issued rather than
"\n" for a hint.   The related problem report is:
https://bugzilla.redhat.com/show_bug.cgi?id=1023161

To minimize problems, the two patches have been attached rather than
provided inline.

Peter, I cc'ed you so you would be aware of these bug reports.  It would
be nice if this was applied to both Fedora 20 and 19.

Gene



___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel



___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel





___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


grub-mkfont/pf2 fonts and licensing question

2013-10-27 Thread Gerard Butler
If I use grub-mkfont on a font to generate a pf2 font file, does it retain the 
same license and distribution rules as the TrueType version of it?  
   ___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: BUGS: btrfs multi-device support fixes

2013-10-27 Thread Andrey Borzenkov
В Sun, 27 Oct 2013 10:47:45 -0400
Gene Czarcinski  пишет:

> On 10/27/2013 02:54 AM, Andrey Borzenkov wrote:
> > В Sat, 26 Oct 2013 16:16:19 -0400
> > Gene Czarcinski  пишет:
> >
> >> On 10/26/2013 12:27 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> >>> Rejected, similar patches is in trunk since some time.
> >> Thanks.  I was not aware that the problem had been addressed.  Can you
> >> point me where to look to see what has been addressed?
> >>
> > This is commit 588744d0dc655177d5883bdcb8f72ff5160109ed.
> And that sure looks like something I would expect to see from a git 
> repository!
> 
> Look, I am not stupid but I sure am confused!  The grub2 website 
> (http://www.gnu.org/software/grub/) says that all grub2 development done 
> through bazaar repository and that you get a copy of the latest grub2 
> source with: |
>bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub|
> Well, I tried doing that and all I get is an error saying: "bzr: ERROR: 
> Not a branch:"
> 

That's where website lags behind. GRUB switched to GIT a while ago. See

https://savannah.gnu.org/git/?group=grub

As for web site - I do not know; Vladimir, who can edit this?

> Now fedora has a local git repository for grub2 located here: 
> git://pkgs.fedoraproject.org/grub2.git and when I look at what is there 
> I see that the updates (when they come in) appear to be in git format.
> 
> On other little thing.  I I sent this current message there were TWO bug 
> fixes (TWO patch files).  I well believe that the first one was already 
> in trunk since I had originally reported that problem in January 2013.  
> The reason I reported it again is because it had not been pick up by fedora.
> 
> However, there is that second bug fix which I only recently found and 
> fixed.  This problem occurs when you have /boot on BTRFS either as a 
> separate subvolume or simply as directory under the root subvolume. In 
> 10_linux, when grub2-probe is call for hint, it returns multi-device 
> hints separated by "\n" which completely screws things up.  The patch is:
> diff --git a/util/grub-probe.c b/util/grub-probe.c
> index a46f0b1..dd5de00 100644
> --- a/util/grub-probe.c
> +++ b/util/grub-probe.c
> @@ -543,7 +543,7 @@ probe (const char *path, char **device_names, char 
> delim)
> print_full_name (map, dev);
> printf ("' ");
>   }
> -  printf ("\n");
> +  printf (" "); /* new-line causes problems for multi-device btrfs 
> volumes */
> 
> grub_device_close (dev);
> continue;


___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


[PATCH] update grub web page with reference to GIT instead of bzr.

2013-10-27 Thread Andrey Borzenkov
В Sun, 27 Oct 2013 19:24:28 +0400
Andrey Borzenkov  пишет:

> 
> That's where website lags behind. GRUB switched to GIT a while ago. See
> 
> https://savannah.gnu.org/git/?group=grub
> 
> As for web site - I do not know; Vladimir, who can edit this?
>

Not sure if I can commit, but - does below look sane? I'm, not sure
whether other branches in GIT need to be mentioned; I guess they are
more or less on "as needed" basis.

Index: grub-download.html
===
RCS file: /web/grub/grub/grub-download.html,v
retrieving revision 1.4
diff -u -p -r1.4 grub-download.html
--- grub-download.html  5 Jan 2012 23:35:41 -   1.4
+++ grub-download.html  27 Oct 2013 15:44:08 -
@@ -44,32 +44,19 @@ site ftp://ftp.gnu.org/gnu/grub
 
 
  All the development is done through a http://bazaar.canonical.com/"; >Bazaar repository.  If you are
+href="http://git-scm.com/"; >GIT repository.  If you are
 interested in the cutting-edge version of GNU GRUB, for example, to test a
 newer version or to add new features, we strongly recommend giving the latest
 repository version a try.  You can obtain the latest GRUB source from the
-Bazaar:
+GIT:
 
-bzr branch 
http://bzr.savannah.gnu.org/r/grub/trunk/grub
+git clone git://git.savannah.gnu.org/grub.git
 
 For developers with write access via ssh, use:
 
-bzr branch 
bzr+ssh://@bzr.savannah.gnu.org/grub/trunk/grub
-
-You can also use scp and rsync if needed.
-
-In the Bazaar repository, a number of other development trees may be found.
-Notably the experimental branch of GRUB is a staging area where less tested (or
-more intrusive) changes are put before they are merged into trunk. 
-
-
-Other branches are listed at the GRUB http://bzr.savannah.gnu.org/r/grub/branches/";>branch index and http://bzr.savannah.gnu.org/r/grub/people/";>individual developer
-repositories.  These branches are not browsable, but can be checked
-out with Bazaar.
-
+git clone 
@git.sv.gnu.org:/srv/git/grub.git
 
+You can also use HTTP if needed.
 
 
 

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: BUGS: btrfs multi-device support fixes

2013-10-27 Thread Bruce Dubbs

Andrey Borzenkov wrote:

В Sun, 27 Oct 2013 10:47:45 -0400
Gene Czarcinski  пишет:


On 10/27/2013 02:54 AM, Andrey Borzenkov wrote:

В Sat, 26 Oct 2013 16:16:19 -0400
Gene Czarcinski  пишет:


On 10/26/2013 12:27 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:

Rejected, similar patches is in trunk since some time.

Thanks.  I was not aware that the problem had been addressed.  Can you
point me where to look to see what has been addressed?


This is commit 588744d0dc655177d5883bdcb8f72ff5160109ed.

And that sure looks like something I would expect to see from a git
repository!

Look, I am not stupid but I sure am confused!  The grub2 website
(http://www.gnu.org/software/grub/) says that all grub2 development done
through bazaar repository and that you get a copy of the latest grub2
source with: |
bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub|
Well, I tried doing that and all I get is an error saying: "bzr: ERROR:
Not a branch:"



That's where website lags behind. GRUB switched to GIT a while ago. See

https://savannah.gnu.org/git/?group=grub

As for web site - I do not know; Vladimir, who can edit this?


I can edit it, but I thought the git site was still under 
development/testing.  Is the url above the best current value?


  -- Bruce



Now fedora has a local git repository for grub2 located here:
git://pkgs.fedoraproject.org/grub2.git and when I look at what is there
I see that the updates (when they come in) appear to be in git format.

On other little thing.  I I sent this current message there were TWO bug
fixes (TWO patch files).  I well believe that the first one was already
in trunk since I had originally reported that problem in January 2013.
The reason I reported it again is because it had not been pick up by fedora.

However, there is that second bug fix which I only recently found and
fixed.  This problem occurs when you have /boot on BTRFS either as a
separate subvolume or simply as directory under the root subvolume. In
10_linux, when grub2-probe is call for hint, it returns multi-device
hints separated by "\n" which completely screws things up.  The patch is:
diff --git a/util/grub-probe.c b/util/grub-probe.c
index a46f0b1..dd5de00 100644
--- a/util/grub-probe.c
+++ b/util/grub-probe.c
@@ -543,7 +543,7 @@ probe (const char *path, char **device_names, char
delim)
 print_full_name (map, dev);
 printf ("' ");
   }
-  printf ("\n");
+  printf (" "); /* new-line causes problems for multi-device btrfs
volumes */

 grub_device_close (dev);
 continue;



___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel





___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: BUGS: btrfs multi-device support fixes

2013-10-27 Thread Andrey Borzenkov
В Sun, 27 Oct 2013 10:51:13 -0500
Bruce Dubbs  пишет:

> >
> > That's where website lags behind. GRUB switched to GIT a while ago. See
> >
> > https://savannah.gnu.org/git/?group=grub
> >
> > As for web site - I do not know; Vladimir, who can edit this?
> 
> I can edit it, but I thought the git site was still under 
> development/testing.

As far as I understood, it is not GIT. BZR repo is simply not there
anymore. 

>  Is the url above the best current value?
> 

See patch I just sent - is it OK for you?

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] update grub web page with reference to GIT instead of bzr.

2013-10-27 Thread Bruce Dubbs

Andrey Borzenkov wrote:

В Sun, 27 Oct 2013 19:24:28 +0400
Andrey Borzenkov  пишет:



That's where website lags behind. GRUB switched to GIT a while ago. See

https://savannah.gnu.org/git/?group=grub

As for web site - I do not know; Vladimir, who can edit this?



Not sure if I can commit, but - does below look sane?


The files are actually maintained via templates and a Makefile to attach 
headers and footers that can be updated easily.  The file that you want 
to change is templates/grub-download.body.


If you do have commit privs, please do not update the html directly.

  -- Bruce

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] update grub web page with reference to GIT instead of bzr.

2013-10-27 Thread Andrey Borzenkov
В Sun, 27 Oct 2013 11:02:09 -0500
Bruce Dubbs  пишет:

> Andrey Borzenkov wrote:
> > В Sun, 27 Oct 2013 19:24:28 +0400
> > Andrey Borzenkov  пишет:
> >
> >>
> >> That's where website lags behind. GRUB switched to GIT a while ago. See
> >>
> >> https://savannah.gnu.org/git/?group=grub
> >>
> >> As for web site - I do not know; Vladimir, who can edit this?
> >>
> >
> > Not sure if I can commit, but - does below look sane?
> 
> The files are actually maintained via templates and a Makefile to attach 
> headers and footers that can be updated easily.  The file that you want 
> to change is templates/grub-download.body.
> 

Usually generated files are not placed under SCM control ... thank you
for the hint.

> If you do have commit privs, please do not update the html directly.
> 

I do not know until I try :) Feel free to commit.

Index: templates/grub-download.body
===
RCS file: /web/grub/grub/templates/grub-download.body,v
retrieving revision 1.1
diff -u -p -r1.1 grub-download.body
--- templates/grub-download.body5 Jan 2012 23:35:45 -   1.1
+++ templates/grub-download.body27 Oct 2013 16:09:34 -
@@ -8,29 +8,18 @@ site ftp://ftp.gnu.org/gnu/grub
 
 
  All the development is done through a http://bazaar.canonical.com/"; >Bazaar repository.  If you are
+href="http://git-scm.com/"; >GIT repository.  If you are
 interested in the cutting-edge version of GNU GRUB, for example, to test a
 newer version or to add new features, we strongly recommend giving the latest
 repository version a try.  You can obtain the latest GRUB source from the
-Bazaar:
+GIT:
 
-bzr branch 
http://bzr.savannah.gnu.org/r/grub/trunk/grub
+git clone git://git.savannah.gnu.org/grub.git
 
 For developers with write access via ssh, use:
 
-bzr branch 
bzr+ssh://@bzr.savannah.gnu.org/grub/trunk/grub
+git clone 
@git.sv.gnu.org:/srv/git/grub.git
 
-You can also use scp and rsync if needed.
-
-In the Bazaar repository, a number of other development trees may be found.
-Notably the experimental branch of GRUB is a staging area where less tested (or
-more intrusive) changes are put before they are merged into trunk. 
-
-
-Other branches are listed at the GRUB http://bzr.savannah.gnu.org/r/grub/branches/";>branch index and http://bzr.savannah.gnu.org/r/grub/people/";>individual developer
-repositories.  These branches are not browsable, but can be checked
-out with Bazaar.
+You can also use HTTP if needed.
 
 [% INCLUDE footer %]

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] update grub web page with reference to GIT instead of bzr.

2013-10-27 Thread Bruce Dubbs

Andrey Borzenkov wrote:

В Sun, 27 Oct 2013 11:02:09 -0500
Bruce Dubbs  пишет:


Andrey Borzenkov wrote:

В Sun, 27 Oct 2013 19:24:28 +0400
Andrey Borzenkov  пишет:



That's where website lags behind. GRUB switched to GIT a while ago. See

https://savannah.gnu.org/git/?group=grub

As for web site - I do not know; Vladimir, who can edit this?



Not sure if I can commit, but - does below look sane?


The files are actually maintained via templates and a Makefile to attach
headers and footers that can be updated easily.  The file that you want
to change is templates/grub-download.body.



Usually generated files are not placed under SCM control ... thank you
for the hint.


That's what I inherited, but the web site works directly off the commits 
so I think it's needed.



If you do have commit privs, please do not update the html directly.



I do not know until I try :) Feel free to commit.


I'll do that, but would like confirmation.  Vladimir, does this look OK 
to you?


  -- Bruce


Index: templates/grub-download.body
===
RCS file: /web/grub/grub/templates/grub-download.body,v
retrieving revision 1.1
diff -u -p -r1.1 grub-download.body
--- templates/grub-download.body5 Jan 2012 23:35:45 -   1.1
+++ templates/grub-download.body27 Oct 2013 16:09:34 -
@@ -8,29 +8,18 @@ site ftp://ftp.gnu.org/gnu/grub
  

   All the development is done through a http://bazaar.canonical.com/"; >Bazaar repository.  If you are
+href="http://git-scm.com/"; >GIT repository.  If you are
  interested in the cutting-edge version of GNU GRUB, for example, to test a
  newer version or to add new features, we strongly recommend giving the latest
  repository version a try.  You can obtain the latest GRUB source from the
-Bazaar:
+GIT:

-bzr branch 
http://bzr.savannah.gnu.org/r/grub/trunk/grub
+git clone git://git.savannah.gnu.org/grub.git

  For developers with write access via ssh, use:

-bzr branch 
bzr+ssh://@bzr.savannah.gnu.org/grub/trunk/grub
+git clone 
@git.sv.gnu.org:/srv/git/grub.git

-You can also use scp and rsync if needed.
-
-In the Bazaar repository, a number of other development trees may be found.
-Notably the experimental branch of GRUB is a staging area where less tested (or
-more intrusive) changes are put before they are merged into trunk.
-
-
-Other branches are listed at the GRUB http://bzr.savannah.gnu.org/r/grub/branches/";>branch index and http://bzr.savannah.gnu.org/r/grub/people/";>individual developer
-repositories.  These branches are not browsable, but can be checked
-out with Bazaar.
+You can also use HTTP if needed.

  [% INCLUDE footer %]

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel





___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] update grub web page with reference to GIT instead of bzr.

2013-10-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko

On 27.10.2013 16:46, Andrey Borzenkov wrote:
> В Sun, 27 Oct 2013 19:24:28 +0400
> Andrey Borzenkov  пишет:
> 
>>
>> That's where website lags behind. GRUB switched to GIT a while ago. See
>>
>> https://savannah.gnu.org/git/?group=grub
>>
>> As for web site - I do not know; Vladimir, who can edit this?
>>
> 
AFAIR everyone who is allowed to commit but remember 2 things:
1) it's in CVS
2) it take a little while to update after upload.
> Not sure if I can commit, but - does below look sane? I'm, not sure
> whether other branches in GIT need to be mentioned; I guess they are
> more or less on "as needed" basis.
The branches multiboot, multiboot2 and grub-legacy are permanent, others
are on the need basis. We keep grub-legacy for copyright tracking
reasons, users are not supposed to use it at all.
> 
> Index: grub-download.html
> ===
> RCS file: /web/grub/grub/grub-download.html,v
> retrieving revision 1.4
> diff -u -p -r1.4 grub-download.html
> --- grub-download.html5 Jan 2012 23:35:41 -   1.4
> +++ grub-download.html27 Oct 2013 15:44:08 -
> @@ -44,32 +44,19 @@ site ftp://ftp.gnu.org/gnu/grub
>  
>  
>   All the development is done through a  -href="http://bazaar.canonical.com/"; >Bazaar repository.  If you are
> +href="http://git-scm.com/"; >GIT repository.  If you are
>  interested in the cutting-edge version of GNU GRUB, for example, to test a
>  newer version or to add new features, we strongly recommend giving the latest
>  repository version a try.  You can obtain the latest GRUB source from the
> -Bazaar:
> +GIT:
>  
> -bzr branch 
> http://bzr.savannah.gnu.org/r/grub/trunk/grub
> +git clone git://git.savannah.gnu.org/grub.git
>  
>  For developers with write access via ssh, use:
>  
> -bzr branch 
> bzr+ssh://@bzr.savannah.gnu.org/grub/trunk/grub
> -
> -You can also use scp and rsync if needed.
> -
> -In the Bazaar repository, a number of other development trees may be 
> found.
> -Notably the experimental branch of GRUB is a staging area where less tested 
> (or
> -more intrusive) changes are put before they are merged into trunk. 
> -
> -
> -Other branches are listed at the GRUB  -href="http://bzr.savannah.gnu.org/r/grub/branches/";>branch index and  -href="http://bzr.savannah.gnu.org/r/grub/people/";>individual developer
> -repositories.  These branches are not browsable, but can be checked
> -out with Bazaar.
> -
> +git clone 
> @git.sv.gnu.org:/srv/git/grub.git
>  
> +You can also use HTTP if needed.
>  
>  
>  
> 




signature.asc
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] update grub web page with reference to GIT instead of bzr.

2013-10-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.10.2013 17:23, Bruce Dubbs wrote:
> 
>>> If you do have commit privs, please do not update the html directly.
>>>
>>
>> I do not know until I try :) Feel free to commit.
> 
> I'll do that, but would like confirmation.  Vladimir, does this look OK
> to you?
Yes, it does. Thanks for taking care of this.



signature.asc
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] update grub web page with reference to GIT instead of bzr.

2013-10-27 Thread Bruce Dubbs

Vladimir 'φ-coder/phcoder' Serbinenko wrote:

On 27.10.2013 17:23, Bruce Dubbs wrote:



If you do have commit privs, please do not update the html directly.



I do not know until I try :) Feel free to commit.


I'll do that, but would like confirmation.  Vladimir, does this look OK
to you?

Yes, it does. Thanks for taking care of this.


OK, updated.

  -- Bruce


___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: BUGS: btrfs multi-device support fixes

2013-10-27 Thread Gene Czarcinski

On 10/27/2013 11:24 AM, Andrey Borzenkov wrote:

В Sun, 27 Oct 2013 10:47:45 -0400
Gene Czarcinski  пишет:


On 10/27/2013 02:54 AM, Andrey Borzenkov wrote:

В Sat, 26 Oct 2013 16:16:19 -0400
Gene Czarcinski  пишет:


On 10/26/2013 12:27 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:

Rejected, similar patches is in trunk since some time.

Thanks.  I was not aware that the problem had been addressed.  Can you
point me where to look to see what has been addressed?


This is commit 588744d0dc655177d5883bdcb8f72ff5160109ed.

And that sure looks like something I would expect to see from a git
repository!

Look, I am not stupid but I sure am confused!  The grub2 website
(http://www.gnu.org/software/grub/) says that all grub2 development done
through bazaar repository and that you get a copy of the latest grub2
source with: |
bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub|
Well, I tried doing that and all I get is an error saying: "bzr: ERROR:
Not a branch:"


That's where website lags behind. GRUB switched to GIT a while ago. See

https://savannah.gnu.org/git/?group=grub
Thank you, thank you.  This helps a great deal.  In a way, I am not 
surprised that you switched to git as I find that most projects I 
contribute to are using git repositories and, personally, I find them 
easy to use.


Concerning the patches I submitted, if I had access to the repository 
before I submitted them, I never would have submitted them.  I would 
also have saved myself a lot of time and effort because right about the 
time this patch was added is about the time I was troubleshooting 
multi-device BTRFS.


Gene


As for web site - I do not know; Vladimir, who can edit this?


Now fedora has a local git repository for grub2 located here:
git://pkgs.fedoraproject.org/grub2.git and when I look at what is there
I see that the updates (when they come in) appear to be in git format.

On other little thing.  I I sent this current message there were TWO bug
fixes (TWO patch files).  I well believe that the first one was already
in trunk since I had originally reported that problem in January 2013.
The reason I reported it again is because it had not been pick up by fedora.

However, there is that second bug fix which I only recently found and
fixed.  This problem occurs when you have /boot on BTRFS either as a
separate subvolume or simply as directory under the root subvolume. In
10_linux, when grub2-probe is call for hint, it returns multi-device
hints separated by "\n" which completely screws things up.  The patch is:
diff --git a/util/grub-probe.c b/util/grub-probe.c
index a46f0b1..dd5de00 100644
--- a/util/grub-probe.c
+++ b/util/grub-probe.c
@@ -543,7 +543,7 @@ probe (const char *path, char **device_names, char
delim)
 print_full_name (map, dev);
 printf ("' ");
   }
-  printf ("\n");
+  printf (" "); /* new-line causes problems for multi-device btrfs
volumes */

 grub_device_close (dev);
 continue;





___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [grub-devel] loongson-2f mini-pc (fuloong) elf image generation.

2013-10-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.10.2013 18:54, Javier Vasquez wrote:
> On Tue, Sep 17, 2013 at 2:33 PM, Javier Vasquez  
> wrote:
>> On Tue, Sep 17, 2013 at 1:27 PM, Vladimir 'φ-coder/phcoder' Serbinenko
>>  wrote:
>>> On 17.09.2013 19:24, Javier Vasquez wrote:
 # stty -F /dev/ttyUSB0 9600 -echo
 # cat /dev/ttyUSB0 > ttyUSB0.txt
>>> It's 115200 not 9600
>>
>> My mistake, the adapter is not a null modem.
>>
>> It'll take me more time then, :-(
> 
> OK, null modem working now, :-)
> 
> Is there a limit of how much dump can be sent?
> 
> In the file where I'm redirecting what comes from ttyUSB0, at some
> point I don't get any additional dump, while the mini-pc went ahead
> way further till hanging at:
> 
> kern/dsik.c:326:  Closing 'ata0'.
> 
> Attached goes the file till the point nothing else got captured.  BTW,
> it's not disk space, caus ethe disk is far from full.
> 
It's because your grub.cfg tells grub to switch to gfxterm.



signature.asc
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: grub-mkfont/pf2 fonts and licensing question

2013-10-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.10.2013 16:01, Gerard Butler wrote:
> If I use grub-mkfont on a font to generate a pf2 font file, does it
> retain the same license and distribution rules as the TrueType version
> of it?
> 
Yes, such format conversions preserve the license.
> 
> ___
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 




signature.asc
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [grub-devel] loongson-2f mini-pc (fuloong) elf image generation.

2013-10-27 Thread Javier Vasquez
> It's because your grub.cfg tells grub to switch to gfxterm.

OK, I'll re-dump removing such call, :-)

Thanks,

-- 
Javier.

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


[PATCH] Add grub-core/kern/disk_common.c to extra_dist

2013-10-27 Thread Andrey Borzenkov

Signed-off-by: Andrey Borzenkov 
---
 ChangeLog   | 7 +++
 Makefile.util.def   | 1 +
 grub-core/Makefile.core.def | 1 +
 3 files changed, 9 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 39541ad..bfa503a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2013-10-14  Andrey Borzenkov 
+
+   *  Makefile.util.def: Add grub-core/kern/disk_common.c to library
+   extra_dist.
+   * grub-core/Makefile.core.def: Add kern/disk_common.c to disk module
+   extra_dist.
+
 2013-10-27  Vladimir Serbinenko  
 
* grub-core/loader/i386/bsd.c (grub_cmd_openbsd): Accept "sd", "cd",
diff --git a/Makefile.util.def b/Makefile.util.def
index 2c38b53..59e3e73 100644
--- a/Makefile.util.def
+++ b/Makefile.util.def
@@ -15,6 +15,7 @@ library = {
   common = grub-core/osdep/getroot.c;
   common = grub-core/osdep/devmapper/getroot.c;
   common = grub-core/osdep/relpath.c;
+  extra_dist = grub-core/kern/disk_common.c;
   extra_dist = grub-core/osdep/unix/relpath.c;
   extra_dist = grub-core/osdep/aros/relpath.c;
   extra_dist = grub-core/osdep/windows/relpath.c;
diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def
index 2fb1cc9..036113b 100644
--- a/grub-core/Makefile.core.def
+++ b/grub-core/Makefile.core.def
@@ -458,6 +458,7 @@ image = {
 module = {
   name = disk;
   common = lib/disk.c;
+  extra_dist = kern/disk_common.c;
 };
 
 module = {
-- 
1.8.1.4


___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [PATCH] Add grub-core/kern/disk_common.c to extra_dist

2013-10-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Go ahead
On 27.10.2013 19:59, Andrey Borzenkov wrote:
> 
> Signed-off-by: Andrey Borzenkov 
> ---
>  ChangeLog   | 7 +++
>  Makefile.util.def   | 1 +
>  grub-core/Makefile.core.def | 1 +
>  3 files changed, 9 insertions(+)
> 
> diff --git a/ChangeLog b/ChangeLog
> index 39541ad..bfa503a 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,10 @@
> +2013-10-14  Andrey Borzenkov 
> +
> + *  Makefile.util.def: Add grub-core/kern/disk_common.c to library
> + extra_dist.
> + * grub-core/Makefile.core.def: Add kern/disk_common.c to disk module
> + extra_dist.
> +
>  2013-10-27  Vladimir Serbinenko  
>  
>   * grub-core/loader/i386/bsd.c (grub_cmd_openbsd): Accept "sd", "cd",
> diff --git a/Makefile.util.def b/Makefile.util.def
> index 2c38b53..59e3e73 100644
> --- a/Makefile.util.def
> +++ b/Makefile.util.def
> @@ -15,6 +15,7 @@ library = {
>common = grub-core/osdep/getroot.c;
>common = grub-core/osdep/devmapper/getroot.c;
>common = grub-core/osdep/relpath.c;
> +  extra_dist = grub-core/kern/disk_common.c;
>extra_dist = grub-core/osdep/unix/relpath.c;
>extra_dist = grub-core/osdep/aros/relpath.c;
>extra_dist = grub-core/osdep/windows/relpath.c;
> diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def
> index 2fb1cc9..036113b 100644
> --- a/grub-core/Makefile.core.def
> +++ b/grub-core/Makefile.core.def
> @@ -458,6 +458,7 @@ image = {
>  module = {
>name = disk;
>common = lib/disk.c;
> +  extra_dist = kern/disk_common.c;
>  };
>  
>  module = {
> 




signature.asc
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [grub-devel] loongson-2f mini-pc (fuloong) elf image generation.

2013-10-27 Thread Aleš Nesrsta

Dne 27.10.2013 19:33, Javier Vasquez napsal(a):
> OK, I'll re-dump removing such call, :-)

Hi Javier,

maybe it is not necessary - at least with your current configuration.
Why:

1.
This:

"...
bus/usb/ehci.c:1772: detect_dev: EHCI STATUS: c004

bus/usb/ehci.c:1774: detect_dev: iobase=0xb4073010, port=0, status=0x1403

bus/usb/ehci.c:1772: detect_dev: EHCI STATUS: c004

bus/usb/ehci.c:1774: detect_dev: iobase=0xb4073010, port=1, status=0x1403
..."

does mean:

On EHCI ports 0 and 1 are connected Low speed devices.
EHCI cannot handle Low and Full speed devices on root ports (by design) 
- it have to be done by companion controller(s), i.e. by OHCI or UHCI 
(or via USB2 hub...).

In your case it should be OHCI.


2.
I don't see loading of OHCI module in debug output !
Do you really have this module included in your image?


I recommend to check and regenerate your GRUB image to be able to load 
OHCI module.
And possibly change order of loading of USB modules - load EHCI as first 
and OHCI as second module. (It is not critical but little bit more 
effective.)


Then try if USB keyboard will work. If not, send new full debug output.

BR,
Ales

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [grub-devel] loongson-2f mini-pc (fuloong) elf image generation.

2013-10-27 Thread Javier Vasquez
On Sun, Oct 27, 2013 at 2:03 PM, Aleš Nesrsta  wrote:
> Dne 27.10.2013 19:33, Javier Vasquez napsal(a):
>
>> OK, I'll re-dump removing such call, :-)
>
> Hi Javier,
>
> maybe it is not necessary - at least with your current configuration.
> Why:
>
> 1.
> This:
>
> "...
> bus/usb/ehci.c:1772: detect_dev: EHCI STATUS: c004
>
> bus/usb/ehci.c:1774: detect_dev: iobase=0xb4073010, port=0, status=0x1403
>
> bus/usb/ehci.c:1772: detect_dev: EHCI STATUS: c004
>
> bus/usb/ehci.c:1774: detect_dev: iobase=0xb4073010, port=1, status=0x1403
> ..."
>
> does mean:
>
> On EHCI ports 0 and 1 are connected Low speed devices.
> EHCI cannot handle Low and Full speed devices on root ports (by design) - it
> have to be done by companion controller(s), i.e. by OHCI or UHCI (or via
> USB2 hub...).
> In your case it should be OHCI.
>
>
> 2.
> I don't see loading of OHCI module in debug output !
> Do you really have this module included in your image?
>
>
> I recommend to check and regenerate your GRUB image to be able to load OHCI
> module.
> And possibly change order of loading of USB modules - load EHCI as first and
> OHCI as second module. (It is not critical but little bit more effective.)
>
> Then try if USB keyboard will work. If not, send new full debug output.
>
> BR,
> Ales


Well, going back to some old e-mails I sent, I'm using the ELF image
generated by grub-install, since when generating it by hand with
grub-mkimage it doesn't even offer the menu, and it does offer the
prompt, but still with NO keyboard.

On the other hand, I believe as part of prior experiments I've already
tried loading ohci after ehci, and that didn't make any difference...

Can you please make a suggestion on how to generate the ELF image?
Notice I included ohci on the prior mkimage attempts, and that didn't
make the keyboard work...

Quoting past e-mail:

+
I just used:

./configure --prefix=/usr --sysconfdir=/etc
make
sudo make install

After installing I removed old grub generated stuff, and ran:

sudo grub-install --boot-directory=/boot --target=mipsel-loongson
--recheck /dev/sda

That automatically generate a /boot/grub.elf image.  Then after
editing /etc/default/grub I ran:

sudo grub-mkconfig -o /boot/grub/grub.cfg

So far so good...  I already have as a /boot/boot.cfg menu entry, one
dedicated to use the grub elf image:

title   Boot with GNU GRUB2
kernel  (wd0,0)/grub.elf
argsconsole=tty no_auto_cmd

When rebooting, and selecting to use the grub.elf image, I get the
grub menu, and apparently it works, cause after the timeout expires it
selects the first grub menu entry, and everything works.  However a
bad thing is that the usb keyboard does not work on the grub menu.

I then tried to manually generate a grub.elf image by running:

sudo grub-mkimage -O mipsel-fuloong-elf -o /boot/grub.elf linux ata
usb_keyboard ohci part_msdos ext2 xfs part_gpt ls halt reboot usbms
usb gzio search lspci help ahci blocklist date elf pata configfile
echo

And the grub.elf generated got worse, cause not only I still didn't
get the usb keyboard to work, but the menu was not loaded, the only
thing available was the grub prompt, which is useless without
keyboard, :-)

I also tried:

sudo grub-mkimage -O mipsel-fuloong-elf -o /boot/grub.elf linux ata
usb_keyboard ohci part_msdos ext2 xfs part_gpt ls halt reboot usbms
gzio search lspci help ahci blocklist date elf pata configfile echo

But that didn't make any difference.
+

Thanks,

-- 
Javier.

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [grub-devel] loongson-2f mini-pc (fuloong) elf image generation.

2013-10-27 Thread Aleš Nesrsta

Dne 27.10.2013 21:19, Javier Vasquez napsal(a):

On the other hand, I believe as part of prior experiments I've already
tried loading ohci after ehci, and that didn't make any difference...


OK, as I wrote, order is not critical.
But it looks like your PC never loaded OHCI module at all.


Can you please make a suggestion on how to generate the ELF image?
It is probably question mainly for the Vladimir or others, I hope 
somebody of them will give some advice to you soon - unfortunately I am 
not expert for GRUB general use or whatever else, specially on non x86 
architectures, I know only few USB specific parts... :-(
The only one thing that I can say is that GRUB did not load and execute 
the OHCI module on your PC - but I don't know what can cause such 
behavior. For the first look it seems like OHCI module is not included 
in your GRUB image or the OHCI module is not correctly built - but I 
cannot say why, sorry.


BR, Ales

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [grub-devel] loongson-2f mini-pc (fuloong) elf image generation.

2013-10-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.10.2013 21:19, Javier Vasquez wrote:
> On Sun, Oct 27, 2013 at 2:03 PM, Aleš Nesrsta  wrote:
>> Dne 27.10.2013 19:33, Javier Vasquez napsal(a):
>>
>>> OK, I'll re-dump removing such call, :-)
>>
>> Hi Javier,
>>
>> maybe it is not necessary - at least with your current configuration.
>> Why:
>>
>> 1.
>> This:
>>
>> "...
>> bus/usb/ehci.c:1772: detect_dev: EHCI STATUS: c004
>>
>> bus/usb/ehci.c:1774: detect_dev: iobase=0xb4073010, port=0, status=0x1403
>>
>> bus/usb/ehci.c:1772: detect_dev: EHCI STATUS: c004
>>
>> bus/usb/ehci.c:1774: detect_dev: iobase=0xb4073010, port=1, status=0x1403
>> ..."
>>
>> does mean:
>>
>> On EHCI ports 0 and 1 are connected Low speed devices.
>> EHCI cannot handle Low and Full speed devices on root ports (by design) - it
>> have to be done by companion controller(s), i.e. by OHCI or UHCI (or via
>> USB2 hub...).
>> In your case it should be OHCI.
>>
>>
>> 2.
>> I don't see loading of OHCI module in debug output !
>> Do you really have this module included in your image?
>>
>>
>> I recommend to check and regenerate your GRUB image to be able to load OHCI
>> module.
>> And possibly change order of loading of USB modules - load EHCI as first and
>> OHCI as second module. (It is not critical but little bit more effective.)
>>
>> Then try if USB keyboard will work. If not, send new full debug output.
>>
>> BR,
>> Ales
> 
> 
> Well, going back to some old e-mails I sent, I'm using the ELF image
> generated by grub-install, since when generating it by hand with
> grub-mkimage it doesn't even offer the menu, and it does offer the
> prompt, but still with NO keyboard.
> 
> On the other hand, I believe as part of prior experiments I've already
> tried loading ohci after ehci, and that didn't make any difference...
> 
> Can you please make a suggestion on how to generate the ELF image?
> Notice I included ohci on the prior mkimage attempts, and that didn't
> make the keyboard work...
> 
> Quoting past e-mail:
> 
> +
> I just used:
> 
> ./configure --prefix=/usr --sysconfdir=/etc
> make
> sudo make install
> 
> After installing I removed old grub generated stuff, and ran:
> 
> sudo grub-install --boot-directory=/boot --target=mipsel-loongson
> --recheck /dev/sda
> 
Add --modules="ehci ohci usb_keyboard"
> That automatically generate a /boot/grub.elf image.  Then after
> editing /etc/default/grub I ran:
> 
> sudo grub-mkconfig -o /boot/grub/grub.cfg
> 
> So far so good...  I already have as a /boot/boot.cfg menu entry, one
> dedicated to use the grub elf image:
> 
> title   Boot with GNU GRUB2
> kernel  (wd0,0)/grub.elf
> argsconsole=tty no_auto_cmd
> 
> When rebooting, and selecting to use the grub.elf image, I get the
> grub menu, and apparently it works, cause after the timeout expires it
> selects the first grub menu entry, and everything works.  However a
> bad thing is that the usb keyboard does not work on the grub menu.
> 
> I then tried to manually generate a grub.elf image by running:
> 
> sudo grub-mkimage -O mipsel-fuloong-elf -o /boot/grub.elf linux ata
> usb_keyboard ohci part_msdos ext2 xfs part_gpt ls halt reboot usbms
> usb gzio search lspci help ahci blocklist date elf pata configfile
> echo
> 
> And the grub.elf generated got worse, cause not only I still didn't
> get the usb keyboard to work, but the menu was not loaded, the only
> thing available was the grub prompt, which is useless without
> keyboard, :-)
> 
> I also tried:
> 
> sudo grub-mkimage -O mipsel-fuloong-elf -o /boot/grub.elf linux ata
> usb_keyboard ohci part_msdos ext2 xfs part_gpt ls halt reboot usbms
> gzio search lspci help ahci blocklist date elf pata configfile echo
> 
> But that didn't make any difference.
> +
> 
> Thanks,
> 




signature.asc
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [grub-devel] loongson-2f mini-pc (fuloong) elf image generation.

2013-10-27 Thread Javier Vasquez
>> ...
>> sudo grub-install --boot-directory=/boot --target=mipsel-loongson
>> --recheck /dev/sda
>>
> Add --modules="ehci ohci usb_keyboard"
>>
>> ...

OK, I'll do it, however, please notice that without that, the image is
already including ohci, and that my manual attempt also included it,
as well as usb_keyboard, :-)

I "echoed" what gets executed finally, by modifying grub-install, and it's:


/usr/bin/grub-mkimage -c /boot/grub/mipsel-loongson/load.cfg -d
/usr/lib/grub/mipsel-loongson -O mipsel-loongson-elf
--output=/boot/grub/mipsel-loongson/core.elf --prefix=/grub pata ahci
ohci usbms ext2 part_msdos search_fs_uuid


Notice all those modules, except by search_fs_uuid, are included in
the prior manual attempts also, and instead of that one, "search" was
included instead.

I'll let you know soon, :-)

Thanks,

-- 
Javier.

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [grub-devel] loongson-2f mini-pc (fuloong) elf image generation.

2013-10-27 Thread Javier Vasquez
On Sun, Oct 27, 2013 at 4:18 PM, Javier Vasquez  wrote:
>>> ...
>>> sudo grub-install --boot-directory=/boot --target=mipsel-loongson
>>> --recheck /dev/sda
>>>
>> Add --modules="ehci ohci usb_keyboard"
>>>
>>> ...
>
> OK, I'll do it, however, please notice that without that, the image is
> already including ohci, and that my manual attempt also included it,
> as well as usb_keyboard, :-)
>
> I "echoed" what gets executed finally, by modifying grub-install, and it's:
>
> 
> /usr/bin/grub-mkimage -c /boot/grub/mipsel-loongson/load.cfg -d
> /usr/lib/grub/mipsel-loongson -O mipsel-loongson-elf
> --output=/boot/grub/mipsel-loongson/core.elf --prefix=/grub pata ahci
> ohci usbms ext2 part_msdos search_fs_uuid
> 
>
> Notice all those modules, except by search_fs_uuid, are included in
> the prior manual attempts also, and instead of that one, "search" was
> included instead.
>
> I'll let you know soon, :-)


Not a surprise to me, but it didn't work :-(

I'll generate dump...


-- 
Javier.

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [grub-devel] loongson-2f mini-pc (fuloong) elf image generation.

2013-10-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 27.10.2013 21:03, Aleš Nesrsta wrote:
> 
> 
> 2.
> I don't see loading of OHCI module in debug output !
> Do you really have this module included in your image?
I have to second this: OHCI module if loaded and there is at least one
PCI device available it will show "pciid = %x" message.
Can you modify grub_real_dprintf in misc.c to:
if (!debug)
  debug = "all";

So we can be sure that the message wasn't simply lost due to late
setting of debug variable.
Did I already give you my image to try out?



signature.asc
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: [grub-devel] loongson-2f mini-pc (fuloong) elf image generation.

2013-10-27 Thread Javier Vasquez
On Sun, Oct 27, 2013 at 4:51 PM, Javier Vasquez  wrote:
> On Sun, Oct 27, 2013 at 4:43 PM, Vladimir 'φ-coder/phcoder' Serbinenko
>  wrote:
>> On 27.10.2013 21:03, Aleš Nesrsta wrote:
>>>
>>>
>>> ...
>> I have to second this: OHCI module if loaded and there is at least one
>> PCI device available it will show "pciid = %x" message.
>> Can you modify grub_real_dprintf in misc.c to:
>> if (!debug)
>>   debug = "all";
>>
>> So we can be sure that the message wasn't simply lost due to late
>> setting of debug variable.
>> Did I already give you my image to try out?
>
>
> Attached goes the new dump.
>
> OK, I will try recompiling.
>
> And you never shared your image.  I've been generating mine all along.
>  At some point you mentioned sending one, but you never did, :-)  Any
> ways, I'd say we need the ability to generate it any ways, but I can
> always try yours...
.

Failed to compile on me, not due to the change.  Perhaps next weekend, :-(

Thanks,

-- 
Javier.

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


Re: booting btrfs

2013-10-27 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 16.10.2013 05:37, Chris Murphy wrote:
> 
> On Oct 15, 2013, at 8:50 PM, Andrey Borzenkov  wrote:
> 
>> В Mon, 14 Oct 2013 14:20:14 -0600
>> Chris Murphy  пишет:
>>
>>>
 Is there a way to detect that mountinfo gives garbage and somehow get
 where the real root points?
>>>
>>> I don't know. I've asked on linux-btrfs@. Instead of rebooting, I merely 
>>> tried mounting without options after changing the default subvolume to a 
>>> nested subvolume (one attempt subvolume in a subvolume, another a subvolume 
>>> in a directory): in both cases /proc/self/mountinfo reports / as the root, 
>>> not the full path or ID of the subvolume actually mounted.
>>>
>>> Somehow it seems like the mountinfo root field should return a block device 
>>> and full path to the mounted subvolume or its ID. Currently it seems like a 
>>> problem.
>>>
>>
>> To quote one of btrfs developer (I had unrelated discussion on openSUSE
>> list):
>>
>> --><--
>> This is a known problem, on my todo list, with a few non-working
>> solutions.
>>
>> If you mount via subvol=/subvol then /proc/self/mountinfo will show
>> 'subvol' as the mounted subvolume (4th column)
>>
>> 4 19 0:17 /subvol /mnt/ rw,relatime - btrfs /dev/sda15 rw,space_cache
>>
>> but if the subvolume is set-default and then implicitly mounted,
>> mountinfo will not show that (that's the bug).
> 
> If mounted with subvolid= the same thing happens. Mountinfo doesn't show the 
> subvolume name, it's just /. It's also a problem understanding from mountinfo 
> all of the devices that make up a btrfs volume. This can be learned from 
> btrfsprogs.
>> --><--
>>
>> That said, information can be obtained also using different means
>> (btrfs utility or directly btrfs IOCTL). The question is to which
>> extent we want to depend on existence of btrfsprogs.
> 
> Yeah at the moment if I use subvolid= to mount, I then have no idea how to 
> find out what subvolume is mounted. As far as I know btrfsprogs doesn't a way 
> to determine what subvols are mounted. It must be inferred (by mountpoint or 
> by contents of the mountpoint).
> 
> Anyway, as for support for subvolid in GRUB, I still think it would be nice 
> as it's shorter than full paths. But this is not an enhancement hill I'm 
> willing to die on by any means.
> 
I changed in trunk to make / refer to real root and modified
grub-mkrelpath to follow the same convention, even if disk is mounted
with subvolid.



signature.asc
Description: OpenPGP digital signature
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel