Contributing to GCC

[Krzesimir Nowak]

Hello.

My name is Krzesimir Nowak and I'd like to try my hand at contributing
to gcc in my free time.

To start learning a workflow I started with something easy - 42014. Is
testcase for this fix necessary (it would be checking preprocessor
output)? Is sending a patch created by "git format-patch" for review
with git-send-email to gcc-patches acceptable (or even better - git
patches with cover letter)?

Thanks.

Re: Contributing to GCC

[Thomas Schwinge]

Hi!

On Fri, 17 Oct 2014 09:12:07 +0200, Krzesimir Nowak  wrote:
> My name is Krzesimir Nowak and I'd like to try my hand at contributing
> to gcc in my free time.

Great, and welcome!

> To start learning a workflow I started with something easy - 42014.

As this is one of the issues listed on
, I assume you've already seen this,
and other pages, such as .

> Is
> testcase for this fix necessary (it would be checking preprocessor
> output)?

Yes.  Please see the previous discussion about one aspect of PR42014,
.

> Is sending a patch created by "git format-patch" for review
> with git-send-email to gcc-patches acceptable (or even better - git
> patches with cover letter)?

A lot of contributors send in-line patches in their emails, but using
"modern" tools, such as Git, is certainly fine, too.


Grüße,
 Thomas


pgpUpHyOPkaP6.pgp
Description: PGP signature

Re: Contributing to GCC

[Krzesimir Nowak]

2014-10-17 9:31 GMT+02:00 Thomas Schwinge :
> Hi!
>
> On Fri, 17 Oct 2014 09:12:07 +0200, Krzesimir Nowak  wrote:
>> My name is Krzesimir Nowak and I'd like to try my hand at contributing
>> to gcc in my free time.
>
> Great, and welcome!
>
>> To start learning a workflow I started with something easy - 42014.
>
> As this is one of the issues listed on
> , I assume you've already seen this,
> and other pages, such as .
>

Yes, exactly.

>> Is
>> testcase for this fix necessary (it would be checking preprocessor
>> output)?
>
> Yes.  Please see the previous discussion about one aspect of PR42014,
> .
>

Ok, thanks.

>> Is sending a patch created by "git format-patch" for review
>> with git-send-email to gcc-patches acceptable (or even better - git
>> patches with cover letter)?
>
> A lot of contributors send in-line patches in their emails, but using
> "modern" tools, such as Git, is certainly fine, too.
>

I was asking, because, in the beginning at least, somebody will have
to commit the patch to trunk for me. I don't know if svn understands
git patches.

>
> Grüße,
>  Thomas

Re: Contributing to GCC

[Marek Polacek]

On Fri, Oct 17, 2014 at 09:55:28AM +0200, Krzesimir Nowak wrote:
> I was asking, because, in the beginning at least, somebody will have
> to commit the patch to trunk for me. I don't know if svn understands
> git patches.

No worries about that, we'll just apply the patch manually.

Marek

Re: Contributing to GCC

[Krzesimir Nowak]

2014-10-17 10:00 GMT+02:00 Marek Polacek :
> On Fri, Oct 17, 2014 at 09:55:28AM +0200, Krzesimir Nowak wrote:
>> I was asking, because, in the beginning at least, somebody will have
>> to commit the patch to trunk for me. I don't know if svn understands
>> git patches.
>
> No worries about that, we'll just apply the patch manually.

Ok, thanks.

>
> Marek