2014-10-17 9:31 GMT+02:00 Thomas Schwinge <tho...@codesourcery.com>: > Hi! > > On Fri, 17 Oct 2014 09:12:07 +0200, Krzesimir Nowak <qdl...@gmail.com> wrote: >> My name is Krzesimir Nowak and I'd like to try my hand at contributing >> to gcc in my free time. > > Great, and welcome! > >> To start learning a workflow I started with something easy - 42014. > > As this is one of the issues listed on > <https://gcc.gnu.org/wiki/EasyHacks>, I assume you've already seen this, > and other pages, such as <https://gcc.gnu.org/wiki/GettingStarted>. >
Yes, exactly. >> Is >> testcase for this fix necessary (it would be checking preprocessor >> output)? > > Yes. Please see the previous discussion about one aspect of PR42014, > <http://news.gmane.org/find-root.php?message_id=%3C1727363575.9580702.1368168907851.JavaMail.root%40redhat.com%3E>. > Ok, thanks. >> Is sending a patch created by "git format-patch" for review >> with git-send-email to gcc-patches acceptable (or even better - git >> patches with cover letter)? > > A lot of contributors send in-line patches in their emails, but using > "modern" tools, such as Git, is certainly fine, too. > I was asking, because, in the beginning at least, somebody will have to commit the patch to trunk for me. I don't know if svn understands git patches. > > Grüße, > Thomas
