[PATCH] staging:lustre: fix "space required after that ', '" error in cl_page.c

2015-07-09 Thread anders . fridlund 
From: Anders Fridlund 

This is a patch to the cl_page.c file that fixes a
"space required after that ','" error found by the checkpatch.pl tool.

Signed-off-by: Anders Fridlund 
---
 drivers/staging/lustre/lustre/obdclass/cl_page.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c 
b/drivers/staging/lustre/lustre/obdclass/cl_page.c
index a7f3032..282ae73 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_page.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_page.c
@@ -1425,7 +1425,7 @@ void cl_page_clip(const struct lu_env *env, struct 
cl_page *pg,
CL_PAGE_HEADER(D_TRACE, env, pg, "%d %d\n", from, to);
CL_PAGE_INVOID(env, pg, CL_PAGE_OP(cpo_clip),
   (const struct lu_env *,
-   const struct cl_page_slice *,int, int),
+   const struct cl_page_slice *, int, int),
   from, to);
 }
 EXPORT_SYMBOL(cl_page_clip);
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: sm750fb: ddk750_dvi.h: Fix brace coding style issue

2015-07-09 Thread anders . fridlund 
From: Anders Fridlund 

This is a patch to the ddk750_dvi.h file that fixes up a brace error
found by the checkpatch.pl tool

Signed-off-by: Anders Fridlund 
---
 drivers/staging/sm750fb/ddk750_dvi.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_dvi.h 
b/drivers/staging/sm750fb/ddk750_dvi.h
index 83bbd6d..e1d4c9a 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.h
+++ b/drivers/staging/sm750fb/ddk750_dvi.h
@@ -26,8 +26,7 @@ typedef unsigned char (*PFN_DVICTRL_CHECKINTERRUPT)(void);
 typedef void (*PFN_DVICTRL_CLEARINTERRUPT)(void);
 
 /* Structure to hold all the function pointer to the DVI Controller. */
-typedef struct _dvi_ctrl_device_t
-{
+typedef struct _dvi_ctrl_device_t {
PFN_DVICTRL_INITpfnInit;
PFN_DVICTRL_RESETCHIP   pfnResetChip;
PFN_DVICTRL_GETCHIPSTRING   pfnGetChipString;
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: sm750fb: ddk750_dvi.h: Fix brace coding style issue

2015-07-09 Thread Anders Fridlund 
Sorry, for that. Do I need to re-submit the patch(es), or should I
only change it for future patches?

Cheers,
Anders Fridlund

On Fri, Jul 10, 2015 at 7:33 AM, Sudip Mukherjee
 wrote:
> On Thu, Jul 09, 2015 at 02:45:22PM +0200, anders.fridl...@gmail.com wrote:
>> From: Anders Fridlund 
> same comment that I gave to your another patch.
> "No need to mention this From: here. Please fix your .gitconfig so that
> git send-email will put your name in the email From: header."
>
> regards
> sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

2015-08-19 Thread Anders Fridlund 
Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
with NULL in the assignment.

Signed-off-by: Anders Fridlund 
---
 drivers/staging/most/aim-network/networking.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/aim-network/networking.c 
b/drivers/staging/most/aim-network/networking.c
index c8ab239..a1e1bce 100644
--- a/drivers/staging/most/aim-network/networking.c
+++ b/drivers/staging/most/aim-network/networking.c
@@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context 
*nd)
 
unregister_netdev(nd->dev);
free_netdev(nd->dev);
-   nd->dev = 0;
+   nd->dev = NULL;
 }
 
 static struct net_dev_context *get_net_dev_context(
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

2015-08-29 Thread Anders Fridlund 
Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
with NULL in the assignment.

Signed-off-by: Anders Fridlund 
---
 drivers/staging/most/aim-network/networking.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/aim-network/networking.c 
b/drivers/staging/most/aim-network/networking.c
index c8ab239..a1e1bce 100644
--- a/drivers/staging/most/aim-network/networking.c
+++ b/drivers/staging/most/aim-network/networking.c
@@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct net_dev_context 
*nd)
 
unregister_netdev(nd->dev);
free_netdev(nd->dev);
-   nd->dev = 0;
+   nd->dev = NULL;
 }
 
 static struct net_dev_context *get_net_dev_context(
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: most: Use NULL instead of 0 in assignment of pointer

2015-09-05 Thread Anders Fridlund 
I resent it since no one responded to it for 10 days. From what I came
to understand that is the common practice. If that is not the case I'm
sorry (and please let me know so I don't do it again).

Cheers,
Anders Fridlund

On Thu, Sep 3, 2015 at 6:41 PM, Greg KH  wrote:
> On Sat, Aug 29, 2015 at 01:53:49PM +0200, Anders Fridlund wrote:
>> Fix sparse warning 'Using plain integer as NULL pointer' by replacing 0
>> with NULL in the assignment.
>>
>> Signed-off-by: Anders Fridlund 
>> ---
>>  drivers/staging/most/aim-network/networking.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/most/aim-network/networking.c 
>> b/drivers/staging/most/aim-network/networking.c
>> index c8ab239..a1e1bce 100644
>> --- a/drivers/staging/most/aim-network/networking.c
>> +++ b/drivers/staging/most/aim-network/networking.c
>> @@ -295,7 +295,7 @@ static void most_net_rm_netdev_safe(struct 
>> net_dev_context *nd)
>>
>>   unregister_netdev(nd->dev);
>>   free_netdev(nd->dev);
>> - nd->dev = 0;
>> + nd->dev = NULL;
>>  }
>>
>>  static struct net_dev_context *get_net_dev_context(
>> --
>> 1.9.1
>
> Why did you resend this patch again?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: lustre: ptlrpc: include ptlrpc_internal.h

2015-09-07 Thread Anders Fridlund 
Remove sparse warning "symbol 'sptlrpc_plain_init' was not declared"
by including ptlrpc_internal.h, which includes sptlrpc_plain_init.

Signed-off-by: Anders Fridlund 
---
 drivers/staging/lustre/lustre/ptlrpc/sec_plain.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_plain.c 
b/drivers/staging/lustre/lustre/ptlrpc/sec_plain.c
index a243db6..d905b77 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/sec_plain.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/sec_plain.c
@@ -46,6 +46,7 @@
 #include "../include/obd_class.h"
 #include "../include/lustre_net.h"
 #include "../include/lustre_sec.h"
+#include "ptlrpc_internal.h"
 
 struct plain_sec {
struct ptlrpc_sec   pls_base;
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel