Re: [PATCH 09/11] staging: cxt1e1: musycc.c: Return negative error codes
On Fri, Sep 27, 2013 at 09:36:36AM +0530, Sachin Kamat wrote: > Return negative error codes as is followed in the rest of the > kernel. > This doesn't apply to linux-next (Sep 26) for some reason that I can't figure out. The first chunk fails. Btw, the caller eventually flips any stray positive returns to negative using the mkret() function. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 09/11] staging: cxt1e1: musycc.c: Return negative error codes
On Fri, Sep 27, 2013 at 10:09:50AM +0300, Dan Carpenter wrote: > On Fri, Sep 27, 2013 at 09:36:36AM +0530, Sachin Kamat wrote: > > Return negative error codes as is followed in the rest of the > > kernel. > > > > This doesn't apply to linux-next (Sep 26) for some reason that I can't > figure out. The first chunk fails. > Never mind. Sorry for the noise. The problem was on my end. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/51] DMA mask changes
On Thu, Sep 26, 2013 at 10:23:08PM +0200, Rafał Miłecki wrote: > 2013/9/19 Russell King - ARM Linux : > > This email is only being sent to the mailing lists in question, not to > > anyone personally. The list of individuals is far to great to do that. > > I'm hoping no mailing lists reject the patches based on the number of > > recipients. > > Huh, I think it was enough to send only 3 patches to the b43-dev@. Like: > [PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks > [PATCH 14/51] DMA-API: net: b43: (...) > [PATCH 15/51] DMA-API: net: b43legacy: (...) > ;) > > I believe Joe has some nice script for doing it that way. When fixing > some coding style / formatting, he sends only related patches to the > given ML. If I did that, then the mailing lists would not get the first patch, because almost none of the lists would be referred to by patch 1. Moreover, people complain when they don't have access to the full patch series - they assume patches are missing for some reason, and they ask for the rest of the series. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/1] staging: dgnc: Remove KERNEL_VERSION check
This check is not required. Signed-off-by: Sachin Kamat Cc: Lidza Louina --- drivers/staging/dgnc/dgnc_kcompat.h |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_kcompat.h b/drivers/staging/dgnc/dgnc_kcompat.h index ed85152..eaec7e6 100644 --- a/drivers/staging/dgnc/dgnc_kcompat.h +++ b/drivers/staging/dgnc/dgnc_kcompat.h @@ -28,11 +28,6 @@ #ifndef __DGNC_KCOMPAT_H #define __DGNC_KCOMPAT_H -# ifndef KERNEL_VERSION -# define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c)) -# endif - - #if !defined(TTY_FLIPBUF_SIZE) # define TTY_FLIPBUF_SIZE 512 #endif -- 1.7.9.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup
On Wed, 25 Sep 2013, Joseph Salisbury wrote: > After further testing reverting the following commit does in fact > resolve the bug: > > commit b1a1442a23776756b254b69786848a94d92445ba > Author: Jiri Kosina > Date: Mon Jun 3 11:27:48 2013 +0200 > > HID: core: fix reporting of raw events > > Reverting this commit in v3.12-rc2 prevents the system from locking up, > which happens when connecting a bluetooth trackpad. > > Jiri, do you think we should revert this patch, or is there some further > debugging/data collecting you would like to do? Hi Joseph, in this mail: Message-ID: <5241992e.3090...@canonical.com> Date: Tue, 24 Sep 2013 09:52:46 -0400 you said that reverting this commit doesn't prevent the lockups, so I am rather confused ... ? Thanks, -- Jiri Kosina SUSE Labs ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/1] staging: dgnc: Remove KERNEL_VERSION check
On Fri, Sep 27, 2013 at 5:50 AM, Sachin Kamat wrote: > This check is not required. > > Signed-off-by: Sachin Kamat > Cc: Lidza Louina > --- > drivers/staging/dgnc/dgnc_kcompat.h |5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_kcompat.h > b/drivers/staging/dgnc/dgnc_kcompat.h > index ed85152..eaec7e6 100644 > --- a/drivers/staging/dgnc/dgnc_kcompat.h > +++ b/drivers/staging/dgnc/dgnc_kcompat.h > @@ -28,11 +28,6 @@ > #ifndef __DGNC_KCOMPAT_H > #define __DGNC_KCOMPAT_H > > -# ifndef KERNEL_VERSION > -# define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c)) > -# endif > - > - > #if !defined(TTY_FLIPBUF_SIZE) > # define TTY_FLIPBUF_SIZE 512 > #endif > -- > 1.7.9.5 > This looks great. Thanks. :) Lidza ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: sm7xxfb: fixed line break coding style issues
Fixed coding style issues.
Signed-off-by: Martin Berglund
---
drivers/staging/sm7xxfb/sm7xxfb.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
index 8add64b..57d8145 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -259,8 +259,7 @@ static int smtc_setcolreg(unsigned regno, unsigned red,
unsigned green,
if (sfb->fb.var.bits_per_pixel == 16) {
u32 *pal = sfb->fb.pseudo_palette;
val = chan_to_field(red, &sfb->fb.var.red);
- val |= chan_to_field(green, \
- &sfb->fb.var.green);
+ val |= chan_to_field(green, &sfb->fb.var.green);
val |= chan_to_field(blue, &sfb->fb.var.blue);
#ifdef __BIG_ENDIAN
pal[regno] =
@@ -274,8 +273,7 @@ static int smtc_setcolreg(unsigned regno, unsigned red,
unsigned green,
} else {
u32 *pal = sfb->fb.pseudo_palette;
val = chan_to_field(red, &sfb->fb.var.red);
- val |= chan_to_field(green, \
- &sfb->fb.var.green);
+ val |= chan_to_field(green, &sfb->fb.var.green);
val |= chan_to_field(blue, &sfb->fb.var.blue);
#ifdef __BIG_ENDIAN
val =
@@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
/* init SEQ register SR30 - SR75 */
for (i = 0; i < SIZE_SR30_SR75; i++)
- if (((i + 0x30) != 0x62) \
- && ((i + 0x30) != 0x6a) \
- && ((i + 0x30) != 0x6b))
+ if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a)
+ && ((i + 0x30) != 0x6b))
smtc_seqw(i + 0x30,
VGAMode[j].Init_SR30_SR75[i]);
--
1.8.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues
On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote: > @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb) > > /* init SEQ register SR30 - SR75 */ > for (i = 0; i < SIZE_SR30_SR75; i++) > - if (((i + 0x30) != 0x62) \ > - && ((i + 0x30) != 0x6a) \ > - && ((i + 0x30) != 0x6b)) > + if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a) > + && ((i + 0x30) != 0x6b)) The prefered way would be to align this like this: if ((i + 0x30) != 0x62 && (i + 0x30) != 0x6a && (i + 0x30) != 0x6b) regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup
On 09/27/2013 06:50 AM, Jiri Kosina wrote: > On Wed, 25 Sep 2013, Joseph Salisbury wrote: > >> After further testing reverting the following commit does in fact >> resolve the bug: >> >> commit b1a1442a23776756b254b69786848a94d92445ba >> Author: Jiri Kosina >> Date: Mon Jun 3 11:27:48 2013 +0200 >> >> HID: core: fix reporting of raw events >> >> Reverting this commit in v3.12-rc2 prevents the system from locking up, >> which happens when connecting a bluetooth trackpad. >> >> Jiri, do you think we should revert this patch, or is there some further >> debugging/data collecting you would like to do? > Hi Joseph, > > in this mail: > > Message-ID: <5241992e.3090...@canonical.com> > Date: Tue, 24 Sep 2013 09:52:46 -0400 > > you said that reverting this commit doesn't prevent the lockups, so I am > rather confused ... ? > > Thanks, > The testing was invalid. Reverting commit b1a1442 does resolve the bug and stop the lockups. Thanks, Joe ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency from the hypervisor
On Tue, Sep 03, K. Y. Srinivasan wrote:
> Hyper-V supports a mechanism for retrieving the local APIC frequency.Use this
> and bypass
> the calibration code in the kernel. This would allow us to boot the Linux
> kernel as a
> "modern VM" on Hyper-V where many of the legacy devices (such as PIT) are not
> emulated.
> + if (ms_hyperv.features & HV_X64_MSR_APIC_FREQUENCY_AVAILABLE) {
> + /*
> + * Get the APIC frequency.
> + */
> + rdmsrl(HV_X64_MSR_APIC_FREQUENCY, hv_lapic_frequency);
> + hv_lapic_frequency /= HZ;
This leads to build errors on 32bit:
linux-3.12-rc2/arch/x86/kernel/cpu/mshyperv.c:88: undefined reference to
`__udivdi3'
Up to now I have only tested on 64bit, sorry for that.
Olaf
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup
On Fri, Sep 27, 2013 at 10:42:10AM -0400, Joseph Salisbury wrote: > On 09/27/2013 06:50 AM, Jiri Kosina wrote: > > On Wed, 25 Sep 2013, Joseph Salisbury wrote: > > > >> After further testing reverting the following commit does in fact > >> resolve the bug: > >> > >> commit b1a1442a23776756b254b69786848a94d92445ba > >> Author: Jiri Kosina > >> Date: Mon Jun 3 11:27:48 2013 +0200 > >> > >> HID: core: fix reporting of raw events > >> > >> Reverting this commit in v3.12-rc2 prevents the system from locking up, > >> which happens when connecting a bluetooth trackpad. > >> > >> Jiri, do you think we should revert this patch, or is there some further > >> debugging/data collecting you would like to do? > > Hi Joseph, > > > > in this mail: > > > > Message-ID: <5241992e.3090...@canonical.com> > > Date: Tue, 24 Sep 2013 09:52:46 -0400 > > > > you said that reverting this commit doesn't prevent the lockups, so I am > > rather confused ... ? > > > > Thanks, > > > The testing was invalid. Reverting commit b1a1442 does resolve the bug > and stop the lockups. > It looks like magicmouse_raw_event() returns 1 on success and 0 on failure. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency from the hypervisor
On Fri, Sep 27, KY Srinivasan wrote: > > This leads to build errors on 32bit: > > > > linux-3.12-rc2/arch/x86/kernel/cpu/mshyperv.c:88: undefined reference to > > `__udivdi3' > > > > Up to now I have only tested on 64bit, sorry for that. > > Thanks Olaf. I am travelling currently; I will fix it when I get back (early > next week). This change seems to fix it: -+ hv_lapic_frequency /= HZ; ++ div_u64(hv_lapic_frequency, HZ); Olaf ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency from the hypervisor
> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Friday, September 27, 2013 8:33 AM > To: KY Srinivasan > Cc: x...@kernel.org; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com; > t...@linutronix.de; h...@zytor.com; jbeul...@suse.com; b...@alien8.de > Subject: Re: [PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency > from the hypervisor > > On Fri, Sep 27, KY Srinivasan wrote: > > > > This leads to build errors on 32bit: > > > > > > linux-3.12-rc2/arch/x86/kernel/cpu/mshyperv.c:88: undefined reference to > > > `__udivdi3' > > > > > > Up to now I have only tested on 64bit, sorry for that. > > > > Thanks Olaf. I am travelling currently; I will fix it when I get back > > (early next > week). > > This change seems to fix it: > > -+ hv_lapic_frequency /= HZ; > ++ div_u64(hv_lapic_frequency, HZ); Thanks Olaf. Could you submit the patch. Regards, K. Y ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues
On Fri, Sep 27, 2013 at 05:39:11PM +0200, Martin Berglund wrote: > On Fri, Sep 27, 2013 at 03:27:29PM +0300, Dan Carpenter wrote: > > On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote: > > > @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb) > > > > > > /* init SEQ register SR30 - SR75 */ > > > for (i = 0; i < SIZE_SR30_SR75; i++) > > > - if (((i + 0x30) != 0x62) \ > > > - && ((i + 0x30) != 0x6a) \ > > > - && ((i + 0x30) != 0x6b)) > > > + if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a) > > > + && ((i + 0x30) != 0x6b)) > > > > The prefered way would be to align this like this: > > > > if ((i + 0x30) != 0x62 && > > (i + 0x30) != 0x6a && > > (i + 0x30) != 0x6b) > > > > regards, > > dan carpenter > > > > New patch. Looks nice, but could you resend it in a way that can be a applied? Take your original patch and change the subject to: [PATCH v2] Staging: sm7xxfb: fixed line break coding style issues Add "v2: minor style change" under the --- line. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues
On Fri, Sep 27, 2013 at 03:27:29PM +0300, Dan Carpenter wrote:
> On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote:
> > @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
> >
> > /* init SEQ register SR30 - SR75 */
> > for (i = 0; i < SIZE_SR30_SR75; i++)
> > - if (((i + 0x30) != 0x62) \
> > - && ((i + 0x30) != 0x6a) \
> > - && ((i + 0x30) != 0x6b))
> > + if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a)
> > + && ((i + 0x30) != 0x6b))
>
> The prefered way would be to align this like this:
>
> if ((i + 0x30) != 0x62 &&
> (i + 0x30) != 0x6a &&
> (i + 0x30) != 0x6b)
>
> regards,
> dan carpenter
>
New patch.
Signed-off-by: Martin Berglund
---
drivers/staging/sm7xxfb/sm7xxfb.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
index 8add64b..8ba0097 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -259,8 +259,7 @@ static int smtc_setcolreg(unsigned regno, unsigned red,
unsigned green,
if (sfb->fb.var.bits_per_pixel == 16) {
u32 *pal = sfb->fb.pseudo_palette;
val = chan_to_field(red, &sfb->fb.var.red);
- val |= chan_to_field(green, \
- &sfb->fb.var.green);
+ val |= chan_to_field(green, &sfb->fb.var.green);
val |= chan_to_field(blue, &sfb->fb.var.blue);
#ifdef __BIG_ENDIAN
pal[regno] =
@@ -274,8 +273,7 @@ static int smtc_setcolreg(unsigned regno, unsigned red,
unsigned green,
} else {
u32 *pal = sfb->fb.pseudo_palette;
val = chan_to_field(red, &sfb->fb.var.red);
- val |= chan_to_field(green, \
- &sfb->fb.var.green);
+ val |= chan_to_field(green, &sfb->fb.var.green);
val |= chan_to_field(blue, &sfb->fb.var.blue);
#ifdef __BIG_ENDIAN
val =
@@ -508,9 +506,9 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
/* init SEQ register SR30 - SR75 */
for (i = 0; i < SIZE_SR30_SR75; i++)
- if (((i + 0x30) != 0x62) \
- && ((i + 0x30) != 0x6a) \
- && ((i + 0x30) != 0x6b))
+ if ((i + 0x30) != 0x62 &&
+ (i + 0x30) != 0x6a &&
+ (i + 0x30) != 0x6b)
smtc_seqw(i + 0x30,
VGAMode[j].Init_SR30_SR75[i]);
--
1.8.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues
On Fri, Sep 27, 2013 at 05:39:11PM +0200, Martin Berglund wrote: > On Fri, Sep 27, 2013 at 03:27:29PM +0300, Dan Carpenter wrote: > > On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote: > > > @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb) > > > > > > /* init SEQ register SR30 - SR75 */ > > > for (i = 0; i < SIZE_SR30_SR75; i++) > > > - if (((i + 0x30) != 0x62) \ > > > - && ((i + 0x30) != 0x6a) \ > > > - && ((i + 0x30) != 0x6b)) > > > + if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a) > > > + && ((i + 0x30) != 0x6b)) > > > > The prefered way would be to align this like this: > > > > if ((i + 0x30) != 0x62 && > > (i + 0x30) != 0x6a && > > (i + 0x30) != 0x6b) > > > > regards, > > dan carpenter > > > > New patch. > > Signed-off-by: Martin Berglund Can you please resend this in a format I can apply it in, without needing to edit the patch body by hand? I deal with thousands of patches every month, and if I have to edit them all, that cuts down my ability to apply them greatly. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency from the hypervisor
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Friday, September 27, 2013 8:10 AM
> To: KY Srinivasan
> Cc: x...@kernel.org; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; a...@canonical.com; jasow...@redhat.com;
> t...@linutronix.de; h...@zytor.com; jbeul...@suse.com; b...@alien8.de
> Subject: Re: [PATCH V2 1/1] X86: Hyper-V: Get the local APIC timer frequency
> from the hypervisor
>
> On Tue, Sep 03, K. Y. Srinivasan wrote:
>
> > Hyper-V supports a mechanism for retrieving the local APIC frequency.Use
> > this
> and bypass
> > the calibration code in the kernel. This would allow us to boot the Linux
> > kernel
> as a
> > "modern VM" on Hyper-V where many of the legacy devices (such as PIT) are
> not emulated.
>
> > + if (ms_hyperv.features & HV_X64_MSR_APIC_FREQUENCY_AVAILABLE) {
> > + /*
> > +* Get the APIC frequency.
> > +*/
> > + rdmsrl(HV_X64_MSR_APIC_FREQUENCY, hv_lapic_frequency);
> > + hv_lapic_frequency /= HZ;
>
> This leads to build errors on 32bit:
>
> linux-3.12-rc2/arch/x86/kernel/cpu/mshyperv.c:88: undefined reference to
> `__udivdi3'
>
> Up to now I have only tested on 64bit, sorry for that.
Thanks Olaf. I am travelling currently; I will fix it when I get back (early
next week).
K. Y
>
>
> Olaf
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup
On Fri, Sep 27, 2013 at 06:24:12PM +0300, Dan Carpenter wrote:
>
> It looks like magicmouse_raw_event() returns 1 on success and 0 on
> failure.
Fixing the return codes is a good idea but it won't fix the oops.
What's the point of returning 1 and 0? In the current code no one
cares and both are treated the same.
Also if we decide to fix this instead of reverting the we could do this
cleanup as well:
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index b8470b1..868ebaa 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1417,10 +1417,8 @@ int hid_input_report(struct hid_device *hid, int type,
u8 *data, int size, int i
if (hdrv && hdrv->raw_event && hid_match_report(hid, report)) {
ret = hdrv->raw_event(hid, report, data, size);
- if (ret < 0) {
- ret = ret < 0 ? ret : 0;
+ if (ret < 0)
goto unlock;
- }
}
ret = hid_report_raw_event(hid, type, data, size, interrupt);
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] Staging: sm7xxfb: fixed line break coding style issues
Fixed coding style issues.
Signed-off-by: Martin Berglund
---
v2: minor style change as suggested by Dan.
drivers/staging/sm7xxfb/sm7xxfb.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
index 8add64b..8ba0097 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -259,8 +259,7 @@ static int smtc_setcolreg(unsigned regno, unsigned red,
unsigned green,
if (sfb->fb.var.bits_per_pixel == 16) {
u32 *pal = sfb->fb.pseudo_palette;
val = chan_to_field(red, &sfb->fb.var.red);
- val |= chan_to_field(green, \
- &sfb->fb.var.green);
+ val |= chan_to_field(green, &sfb->fb.var.green);
val |= chan_to_field(blue, &sfb->fb.var.blue);
#ifdef __BIG_ENDIAN
pal[regno] =
@@ -274,8 +273,7 @@ static int smtc_setcolreg(unsigned regno, unsigned red,
unsigned green,
} else {
u32 *pal = sfb->fb.pseudo_palette;
val = chan_to_field(red, &sfb->fb.var.red);
- val |= chan_to_field(green, \
- &sfb->fb.var.green);
+ val |= chan_to_field(green, &sfb->fb.var.green);
val |= chan_to_field(blue, &sfb->fb.var.blue);
#ifdef __BIG_ENDIAN
val =
@@ -508,9 +506,9 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
/* init SEQ register SR30 - SR75 */
for (i = 0; i < SIZE_SR30_SR75; i++)
- if (((i + 0x30) != 0x62) \
- && ((i + 0x30) != 0x6a) \
- && ((i + 0x30) != 0x6b))
+ if ((i + 0x30) != 0x62 &&
+ (i + 0x30) != 0x6a &&
+ (i + 0x30) != 0x6b)
smtc_seqw(i + 0x30,
VGAMode[j].Init_SR30_SR75[i]);
--
1.8.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Reworking dm-writeboost [was: Re: staging: Add dm-writeboost]
On Wed, Sep 25 2013 at 9:47pm -0400, Akira Hayakawa wrote: > Hi, Mike > > The monolithic source code (3.2k) > is nicely splitted into almost 20 *.c files > according to the functionality and > data strucutures in OOP style. > > The aim of this posting > is to share how the splitting looks like. > > I believe that > at least reading the *.h files > can convince you the splitting is clear. > > The code is now tainted with > almost 20 version switch macros > and WB* debug macros > but I will clean them up > for sending patch. > > Again, > the latest code can be cloned by > git clone https://github.com/akiradeveloper/dm-writeboost.git > > I will make few updates to the source codes on this weekend > so please track it to follow the latest version. > Below is only the snapshot. > > Akira > > -- Summary -- > 33 Makefile > 10 bigarray.h > 19 cache-alloc.h > 10 defer-barrier.h > 8 dirty-sync.h > 8 flush-daemon.h > 10 format-cache.h > 24 handle-io.h > 16 hashtable.h > 18 migrate-daemon.h > 7 migrate-modulator.h > 12 queue-flush-job.h > 8 rambuf.h > 13 recover.h > 18 segment.h > 8 superblock-recorder.h > 9 target.h > 30 util.h > 384 writeboost.h > 99 bigarray.c > 192 cache-alloc.c > 36 defer-barrier.c > 33 dirty-sync.c > 85 flush-daemon.c > 234 format-cache.c > 553 handle-io.c > 109 hashtable.c > 345 migrate-daemon.c > 41 migrate-modulator.c > 169 queue-flush-job.c > 52 rambuf.c > 308 recover.c > 118 segment.c > 61 superblock-recorder.c > 376 target.c > 126 util.c Unfortunately I think you went too far with all these different small files, I was hoping to see 2 or 3 .c files and a couple .h files. Maybe fold all the daemon code into a 1 .c and 1 .h ? The core of the writeboost target in dm-writeboost-target.c ? And fold all the other data structures into a 1 .c and 1 .h ? When folding these files together feel free to use dividers in the code like dm-thin.c and dm-cache-target.c do, e.g.: /*-*/ Mike ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging/olpc: fix dependencies to fix build errors
From: Randy Dunlap Fix build errors when GPIO_CS5535=m and FB_OLPC_DCON=y by preventing that kconfig combination. These build errors are caused by having a kconfig bool symbol (FB_OLPC_DCON_1) that depend on a tristate symbol (GPIO_CS5535), but when the tristate symbol is =m, the bool symbol is =y. drivers/built-in.o: In function `dcon_read_status_xo_1': olpc_dcon_xo_1.c:(.text+0x359531): undefined reference to `cs5535_gpio_set' drivers/built-in.o: In function `dcon_wiggle_xo_1': olpc_dcon_xo_1.c:(.text+0x35959f): undefined reference to `cs5535_gpio_set' olpc_dcon_xo_1.c:(.text+0x359610): undefined reference to `cs5535_gpio_clear' drivers/built-in.o:olpc_dcon_xo_1.c:(.text+0x3596a1): more undefined references to `cs5535_gpio_clear' follow drivers/built-in.o: In function `dcon_wiggle_xo_1': olpc_dcon_xo_1.c:(.text+0x359708): undefined reference to `cs5535_gpio_set' drivers/built-in.o: In function `dcon_init_xo_1': olpc_dcon_xo_1.c:(.text+0x35989b): undefined reference to `cs5535_gpio_clear' olpc_dcon_xo_1.c:(.text+0x3598b5): undefined reference to `cs5535_gpio_isset' olpc_dcon_xo_1.c:(.text+0x359963): undefined reference to `cs5535_gpio_setup_event' olpc_dcon_xo_1.c:(.text+0x359980): undefined reference to `cs5535_gpio_set_irq' olpc_dcon_xo_1.c:(.text+0x359a36): undefined reference to `cs5535_gpio_set' Signed-off-by: Randy Dunlap Cc: Daniel Drake Cc: Jens Frederich --- This build problem has been around for a long time and is not specific to mmotm. drivers/staging/olpc_dcon/Kconfig |1 + 1 file changed, 1 insertion(+) --- mmotm-2013-0926-1615.orig/drivers/staging/olpc_dcon/Kconfig +++ mmotm-2013-0926-1615/drivers/staging/olpc_dcon/Kconfig @@ -1,6 +1,7 @@ config FB_OLPC_DCON tristate "One Laptop Per Child Display CONtroller support" depends on OLPC && FB + depends on (GPIO_CS5535 || GPIO_CS5535=n) select I2C select BACKLIGHT_CLASS_DEVICE ---help--- ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
