Re: [PATCH v2 0/3] ARM: OMAP1: ams-delta: Complete driver gpiod migration

2018-07-19 Thread Gregory CLEMENT
Hi Janusz,
 
 On mer., juil. 18 2018, Janusz Krzysztofik  wrote:

> This is a follow up of initial submission of a series consisted of 
> 6 changes, 3 of which have been already applied or reworkeed.
>
> V2 changelog:
> [PATCH 1/6] ARM: OMAP1: ams-delta: add GPIO lookup tables
>   - already in mainline, commit 68e62a15a914
> [PATCH 2/6] Input: ams_delta_serio: use GPIO lookup table
>   - reworked and submitted as a series, already in linux-omap,
> commit 68e62a15a914 ("ARM: OMAP1: ams-delta: drop GPIO lookup
> table for serio device") followed by 9 more
> [PATCH 3/6] ASoC: ams_delta: use GPIO lookup table
>   - already in mainline, commit d65777d1a2cd
> [PATCH 4/6] fbdev: omapfb: lcd_ams_delta: use GPIO lookup table
>   - resubmitting as [PATCH v2 1/3 v2]
>   v2: Remove problematic error code conversion no longer
>   needed if used on top of commit d08605a64e67 ("ARM: OMAP1:
>   ams-delta: move late devices back to init_machine")
>   and commit 8853daf3b4ac ("gpiolib: Defer on non-DT
>   find_chip_by_name() failure") already in linux-next
> [PATCH 5/6] mtd: rawnand: ams-delta: use GPIO lookup table
>   - resubmitting as [PATCH v2 2/3 v4]
>   v2: Fix handling of devm_gpiod_get_optional() return values -
>   thanks to Andy Shevchenko.
>   v3: Remove problematic error code conversion no longer needed
>   if used on top of commit d08605a64e67 ("ARM: OMAP1:
>   ams-delta: move late devices back to init_machine") and
>   commit 8853daf3b4ac ("gpiolib: Defer on non-DT
>   find_chip_by_name() failure") already in linux-next - thanks
>   to Boris Brezillon
>   v4: fix style issue - thanks to Boris Brezillon
> [PATCH 6/6] ARM: OMAP1: ams-delta: make board header file local to
>   mach-omap1
>   - resending as [PATCH v2 3/3]
>
> Dependency on commit 8853daf3b4ac ("gpiolib: Defer on non-DT
> find_chip_by_name() failure") is not critical - it is not needed for
> clean build or run, it only prevents from potential future changes to
> driver initializaton order during device_initcall.
>
> I'm submitting the three patches in series because the last one depends
> on the other two.

I think that being in CC in this series is a mistake as I don't see
anything related what I have done in this series.

Gregory

>
> Thanks,
> Janusz
>

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH 3/3] ARM: dts: cubox: add LCD controller and TDA998x configuration

2018-07-19 Thread Gregory CLEMENT
Hi Russell,
 
 On mar., juil. 10 2018, Russell King  wrote:

> Add DT configuration for the HDMI display output on the Dove Cubox.
> This adds support for the LCD0 controller which is connected to a
> TDA19988 HDMI encoder.
>
> Signed-off-by: Russell King 
> ---
>  arch/arm/boot/dts/dove-cubox.dts | 43 
> 
>  1 file changed, 43 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts 
> b/arch/arm/boot/dts/dove-cubox.dts
> index 580e3cbcfbf7..f6dd56f63d09 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -67,6 +67,25 @@
>   gpu-subsystem {
>   status = "okay";
>   };
> +
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + display_reserved: framebuffer {
> + compatible = "marvell,dove-framebuffer";

I didn't find the binding documentation associated to
"marvell,dove-framebuffer".

Could you point me on the accurate file?


> + size = <0x0200>;
> + alignment = <0x0200>;
> + no-map;
> + };
> + };
> +
> + display-subsystem {
> + compatible = "marvell,dove-display-subsystem";

Same for this one.

Thanks,

Gregory

> + memory-region = <&display_reserved>;
> + ports = <&lcd0_port>;
> + };
>  };
>  
>  &uart0 { status = "okay"; };
> @@ -117,6 +136,30 @@
>   silabs,pll-master;
>   };
>   };
> +
> + tda998x: hdmi-encoder {
> + compatible = "nxp,tda998x";
> + reg = <0x70>;
> + video-ports = <0x234501>;
> + interrupts-extended = <&gpio0 27 IRQ_TYPE_LEVEL_LOW>;
> +
> + port {
> + tda998x_video: endpoint {
> + remote-endpoint = <&lcd0_rgb>;
> + };
> + };
> + };
> +};
> +
> +&lcd0 {
> + status = "okay";
> + clocks = <&si5351 0>;
> + clock-names = "ext_ref_clk1";
> + lcd0_port: port {
> + lcd0_rgb: endpoint {
> + remote-endpoint = <&tda998x_video>;
> + };
> + };
>  };
>  
>  &sdio0 {
> -- 
> 2.7.4
>

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH v2 13/14] ARM: dts: dove: add DT GPU support

2015-12-14 Thread Gregory CLEMENT
Hi Lucas,

 On lun., déc. 14 2015, Lucas Stach  wrote:

> Dove maintainers,
>
> can you please tell me if you prefer the DT changes to go along with the
> rest of the etnaviv series through the DRM tree, or plan on picking this
> separate?

I prefer to take the DT change in the mvebu tree. I was waiting for
acknowledgment on this series from the DRM maintainers to be sure that
the binding was OK. However, the fact that Rob Herring already acked the
binding is a good point for me.

Gregory


>
> Regards,
> Lucas
>
> Am Mittwoch, den 09.12.2015, 12:48 +0100 schrieb Lucas Stach:
>> From: Russell King 
>> 
>> Add DT support for the Vivante GC600 GPU on Marvell Dove platforms.
>> These nodes default to being disabled unless a platform decides they
>> should be enabled.
>> 
>> Signed-off-by: Russell King 
>> Signed-off-by: Lucas Stach 
>> ---
>>  arch/arm/boot/dts/dove.dtsi | 16 
>>  1 file changed, 16 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
>> index cd58c2e62757..ea1d999ca7a7 100644
>> --- a/arch/arm/boot/dts/dove.dtsi
>> +++ b/arch/arm/boot/dts/dove.dtsi
>> @@ -33,6 +33,12 @@
>>  marvell,tauros2-cache-features = <0>;
>>  };
>>  
>> +gpu-subsystem {
>> +compatible = "marvell,dove-gpu-subsystem";
>> +cores = <&gpu>;
>> +status = "disabled";
>> +};
>> +
>>  i2c-mux {
>>  compatible = "i2c-mux-pinctrl";
>>  #address-cells = <1>;
>> @@ -776,6 +782,16 @@
>>  #address-cells = <1>;
>>  #size-cells = <1>;
>>  };
>> +
>> +gpu: gpu at 84 {
>> +clocks = <÷r_clk 1>;
>> +clock-names = "core";
>> +compatible = "vivante,gc";
>> +interrupts = <48>;
>> +        power-domains = <&gpu_domain>;
>> +reg = <0x84 0x4000>;
>> +status = "disabled";
>> +};
>>  };
>>  };
>>  };
>
> -- 
> Pengutronix e.K. | Lucas Stach |
> Industrial Linux Solutions   | http://www.pengutronix.de/  |
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com