[PATCH:libdrm] Link dristat with -lrt if appropriate.
The need for -lrt is determined at configure time, let's use the resulting variable for dristat's link, since it uses clock_gettime(). Signed-off-by: Cyril Brulebois --- tests/Makefile.am |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index bf1987f..6f48931 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -10,6 +10,8 @@ check_PROGRAMS = \ dristat \ drmstat +dristat_LDADD = $(CLOCK_LIB) + SUBDIRS = modeprint if HAVE_LIBKMS -- 1.7.4.1 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 34218] [r300g] Unigine Sanctuary: some surfaces are reflecting too much light
https://bugs.freedesktop.org/show_bug.cgi?id=34218 --- Comment #7 from Pavel Ondračka 2011-04-19 01:36:51 PDT --- (In reply to comment #6) > Can you try this again with the latest git version of mesa (commit > ffc1d166d24532aeaa4dcf06a431e43ab7e7e315 or newer)? Still broken with current git. Works fine with RADEON_DEBUG=noopt. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] radeon: Fix KMS CP writeback on big endian machines.
Hi, The following patch fixes interrupt acknowledge when write-back is enabled on big endian platform. The same should be applied on evergreen. Cedric Signed-off-by: Cedric Cano --- diff -Naur linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c --- linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c2011-04-19 09:52:13.0 +0200 +++ linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c2011-03-27 20:37:20.0 +0200 @@ -3227,7 +3227,7 @@ u32 wptr, tmp; if (rdev->wb.enabled) -wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); +wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; else wptr = RREG32(IH_RB_WPTR); ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] radeon: Fix KMS CP writeback on big endian machines.
On Die, 2011-04-19 at 10:23 +0200, Cédric Cano wrote: > > The following patch fixes interrupt acknowledge when write-back is > enabled on big endian platform. > > The same should be applied on evergreen. Can you include that in the patch? I somehow managed to miss these in my previous patch for older chips. :( -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] fix mesa tarball creation again
On 18 April 2011 01:27, Marek Olšák wrote: > Pushed, thanks. Can you know commit this one that fixes missing files in the generated tarball so that one can build mesa out of the tarball? Thx diff --git a/Makefile b/Makefile index 646e152..e4796cf 100644 --- a/Makefile +++ b/Makefile @@ -231,6 +231,8 @@ MAIN_FILES = \ $(DIRECTORY)/src/glsl/Makefile.template\ $(DIRECTORY)/src/glsl/SConscript\ $(DIRECTORY)/src/glsl/*.[ch] \ + $(DIRECTORY)/src/glsl/*.ll \ + $(DIRECTORY)/src/glsl/*.yy \ $(DIRECTORY)/src/glsl/*.[cly]pp \ $(DIRECTORY)/src/glsl/README \ $(DIRECTORY)/src/glsl/glcpp/*.[chly]\ @@ -245,6 +247,7 @@ MAIN_FILES = \ $(DIRECTORY)/src/mesa/depend \ $(MAIN_ES_FILES) \ $(DIRECTORY)/src/mesa/main/*.[chS]\ + $(DIRECTORY)/src/mesa/main/*.cpp\ $(DIRECTORY)/src/mesa/main/descrip.mms\ $(DIRECTORY)/src/mesa/math/*.[ch]\ $(DIRECTORY)/src/mesa/math/descrip.mms\ ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36386] New: Amnesia game crashes on RV570 (r300g)
https://bugs.freedesktop.org/show_bug.cgi?id=36386 Summary: Amnesia game crashes on RV570 (r300g) Product: Mesa Version: 7.10 Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r300 AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: va...@gmx.de The game Amnesia crashes after a startup screen with a silvery sun symbol displayed. glxinfo | grep string server glx vendor string: SGI server glx version string: 1.2 client glx vendor string: Mesa Project and SGI client glx version string: 1.4 OpenGL vendor string: X.Org R300 Project OpenGL renderer string: Gallium 0.4 on ATI RV570 OpenGL version string: 2.1 Mesa 7.10.2 OpenGL shading language version string: 1.20 gdb backtrace Program received signal SIGSEGV, Segmentation fault. 0x0082ab08 in hpl::iParticleEmitter::GetMaterial() () #0 0x0082ab08 in hpl::iParticleEmitter::GetMaterial() () #1 0x00805de2 in hpl::iRenderer::RenderObjectZAndAddToRenderList(hpl::iRenderable*) () #2 0x00805e59 in hpl::iRenderer::RenderObjectZAndAddToRenderListStaticCallback(hpl::iRenderer*, hpl::iRenderable*) () #3 0x00807d8f in hpl::iRenderer::RenderAndAddNodeObjects(hpl::iRenderableContainerNode*, bool (*)(hpl::iRenderer*, hpl::iRenderable*), unsigned int) () #4 0x0080808a in hpl::iRenderer::CheckForVisibleObjectsAddToListAndRenderZ(hpl::cVisibleRCNodeTracker*, unsigned int, unsigned int, bool, bool (*)(hpl::iRenderer*, hpl::iRenderable*)) () #5 0x007e4841 in hpl::cRendererDeferred::RenderObjects() () #6 0x00809334 in hpl::iRenderer::Render(float, hpl::cFrustum*, hpl::cWorld*, hpl::cRenderSettings*, hpl::cRenderTarget*, bool, std::list >*) () #7 0x0082496d in hpl::cScene::Render(float, unsigned int) () #8 0x00925423 in hpl::cEngine::Run() () #9 0x00689890 in hplMain(std::string const&) () #10 0x0090ff29 in main () -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36236] Problems with lights in Trine game from www.humblebundle.com
https://bugs.freedesktop.org/show_bug.cgi?id=36236 --- Comment #17 from Turo Lamminen 2011-04-19 02:59:55 PDT --- Created an attachment (id=45803) --> (https://bugs.freedesktop.org/attachment.cgi?id=45803) Modified shader Modified shader, replace data/shader/cg/deferred_light_pixel.cg with this and retest -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] radeon: Fix KMS CP writeback on big endian machines.
Signed-off-by: Cedric Cano --- --- linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c2011-04-19 11:39:39.0 +0200 +++ /home/cec/tmp/linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c 2011-03-27 20:37:20.0 +0200 @@ -2587,7 +2587,7 @@ u32 wptr, tmp; if (rdev->wb.enabled) -wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); +wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; else wptr = RREG32(IH_RB_WPTR); Le 19/04/2011 10:54, Michel Dänzer a écrit : On Die, 2011-04-19 at 10:23 +0200, Cédric Cano wrote: The following patch fixes interrupt acknowledge when write-back is enabled on big endian platform. The same should be applied on evergreen. Can you include that in the patch? I somehow managed to miss these in my previous patch for older chips. :( ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36236] Problems with lights in Trine game from www.humblebundle.com
https://bugs.freedesktop.org/show_bug.cgi?id=36236 --- Comment #18 from imamdxl8...@gmail.com 2011-04-19 04:48:10 PDT --- Created an attachment (id=45808) --> (https://bugs.freedesktop.org/attachment.cgi?id=45808) game graphics result 1 by Modified shader -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36236] Problems with lights in Trine game from www.humblebundle.com
https://bugs.freedesktop.org/show_bug.cgi?id=36236 --- Comment #19 from imamdxl8...@gmail.com 2011-04-19 04:48:54 PDT --- Created an attachment (id=45809) --> (https://bugs.freedesktop.org/attachment.cgi?id=45809) game graphics result 2 by Modified shader -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36327] fujitsu siemens amilo li1718: ati radeon x200m does not resume from suspend
https://bugs.freedesktop.org/show_bug.cgi?id=36327 --- Comment #11 from Евгений М. 2011-04-19 05:46:47 PDT --- Forgot to mention one more thing related to the Karesz' last comment. Neither Alex' patch from https://bugs.freedesktop.org/show_bug.cgi?id=29062 , nor the simple "return;" statement (without any if's to fight that DYN CLK 1 table issue) made any progress for me (including the recent 2.6.38.2 build) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36393] New: r200: font corruption in fog test
https://bugs.freedesktop.org/show_bug.cgi?id=36393 Summary: r200: font corruption in fog test Product: Mesa Version: unspecified Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/r200 AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: ni...@nikai.net Created an attachment (id=45812) --> (https://bugs.freedesktop.org/attachment.cgi?id=45812) fog test in mesa-7.9.2 In src/tests/fog the text appears distorted, looking somewhat similar to bug 34280. But in contrast, this problem is also present in mesa-7.9.2. System environment: -- system architecture: i686 -- Linux distribution: Gentoo -- GPU: R200 514D -- Model: ATI Radeon 9100 QM (AGP) -- Display connector: VGA -- xf86-video-ati: 982c22f16c89be81779fbfe17d8d3f9b6897 -- xserver: 1.9.4 -- mesa: 9dacbe222641443af000a82161922a5ade206340 and -- mesa: 7.9.2 -- drm: 2.4.25 -- kernel: 2.6.38.2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36393] r200: font corruption in fog test
https://bugs.freedesktop.org/show_bug.cgi?id=36393 --- Comment #1 from Nicolas Kaiser 2011-04-19 06:08:54 PDT --- Created an attachment (id=45813) --> (https://bugs.freedesktop.org/attachment.cgi?id=45813) fog test in mesa-git-9dacbe2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 29495] [r300g] Shadowgrounds: character portraits rendered wrong
https://bugs.freedesktop.org/show_bug.cgi?id=29495 --- Comment #4 from Sven Arvidsson 2011-04-19 06:29:23 PDT --- No change. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36236] Problems with lights in Trine game from www.humblebundle.com
https://bugs.freedesktop.org/show_bug.cgi?id=36236 --- Comment #20 from Sven Arvidsson 2011-04-19 06:34:09 PDT --- (In reply to comment #17) > Modified shader, replace data/shader/cg/deferred_light_pixel.cg with this and > retest AFAICT there's no change. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] radeon: Fix KMS CP writeback on big endian machines.
Hi, Sorry, I've done a patch in reverse mode :(. I repost the patch for r600 and evergreen write back correction for big endian platforms. Cedric Signed-off-by: Cedric Cano --- diff -Nuar linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c --- linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c2011-03-27 20:37:20.0 +0200 +++ linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c2011-04-19 11:39:39.0 +0200 @@ -2587,7 +2587,7 @@ u32 wptr, tmp; if (rdev->wb.enabled) -wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; +wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); else wptr = RREG32(IH_RB_WPTR); diff -Nuar linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c --- linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c2011-03-27 20:37:20.0 +0200 +++ linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c2011-04-19 09:52:13.0 +0200 @@ -3227,7 +3227,7 @@ u32 wptr, tmp; if (rdev->wb.enabled) -wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; +wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); else wptr = RREG32(IH_RB_WPTR); Le 19/04/2011 10:54, Michel Dänzer a écrit : On Die, 2011-04-19 at 10:23 +0200, Cédric Cano wrote: > > The following patch fixes interrupt acknowledge when write-back is > enabled on big endian platform. > > The same should be applied on evergreen. Can you include that in the patch? I somehow managed to miss these in my previous patch for older chips. :( ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36396] New: r600_state_inlines.h: unsupported color format
https://bugs.freedesktop.org/show_bug.cgi?id=36396 Summary: r600_state_inlines.h: unsupported color format Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: m...@tvk.rwth-aachen.de after starting the game Dawn of War with wine (git-version), the following messages are printed several times: EE r600_state_inlines.h/r600_translate_colorformat:408 - unsupported color format 12 EE r600_state_inlines.h/r600_translate_colorformat:408 - unsupported color format 12 EE r600_state_inlines.h/r600_translate_colorformat:408 - unsupported color format 95 EE r600_state_inlines.h/r600_translate_colorformat:408 - unsupported color format 12 EE r600_state_inlines.h/r600_translate_colorformat:408 - unsupported color format 96 EE r600_state_inlines.h/r600_translate_colorformat:408 - unsupported color format 12 some textures and all game-objects like units and buildings aren't drawn, I don't know if this is related. Game has platinum status in winedb, so everything should look fine. mesa: git, xf86-video-ati: git, kernel: d-r-t, HD4350 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] radeon: Fix KMS CP writeback on big endian machines.
On Die, 2011-04-19 at 16:38 +0200, Cédric Cano wrote: > > Sorry, I've done a patch in reverse mode :(. I can recommend using Git. :) > I repost the patch for r600 and evergreen write back correction for > big endian platforms. > > Cedric > > Signed-off-by: Cedric Cano > --- > diff -Nuar linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c > linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c > --- linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c2011-03-27 > 20:37:20.0 +0200 > +++ linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c2011-04-19 > 11:39:39.0 +0200 > @@ -2587,7 +2587,7 @@ > u32 wptr, tmp; > > if (rdev->wb.enabled) > -wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; > +wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); > else > wptr = RREG32(IH_RB_WPTR); > > > diff -Nuar linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c > linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c > --- linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c2011-03-27 > 20:37:20.0 +0200 > +++ linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c2011-04-19 > 09:52:13.0 +0200 > @@ -3227,7 +3227,7 @@ > u32 wptr, tmp; > > if (rdev->wb.enabled) > -wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; > +wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); > else > wptr = RREG32(IH_RB_WPTR); Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/radeon/kms: fix IH writeback on r6xx+ on big endian machines
From: Cédric Cano agd5f: fix commit message. Signed-off-by: Cedric Cano Reviewed-by: Michel Dänzer Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/evergreen.c |2 +- drivers/gpu/drm/radeon/r600.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c index 363f39b..eee208f 100644 --- a/drivers/gpu/drm/radeon/evergreen.c +++ b/drivers/gpu/drm/radeon/evergreen.c @@ -2638,7 +2638,7 @@ static inline u32 evergreen_get_ih_wptr(struct radeon_device *rdev) u32 wptr, tmp; if (rdev->wb.enabled) - wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; + wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); else wptr = RREG32(IH_RB_WPTR); diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index 62fc968..d74d4d7 100644 --- a/drivers/gpu/drm/radeon/r600.c +++ b/drivers/gpu/drm/radeon/r600.c @@ -3243,7 +3243,7 @@ static inline u32 r600_get_ih_wptr(struct radeon_device *rdev) u32 wptr, tmp; if (rdev->wb.enabled) - wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; + wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); else wptr = RREG32(IH_RB_WPTR); -- 1.7.1.1 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 2/2] drm: Verify debug message arguments
On Mon, Apr 18, 2011 at 04:09:11PM -0700, Joe Perches wrote:
> On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote:
> > > @@ -214,9 +214,9 @@ parse_lfp_panel_data(struct drm_i915_private
> > > *dev_priv,
> > > i915_lvds_downclock) {
> > > dev_priv->lvds_downclock_avail = 1;
> > > dev_priv->lvds_downclock = temp_downclock;
> > > - DRM_DEBUG_KMS("LVDS downclock is found in VBT. ",
> > > - "Normal Clock %dKHz, downclock %dKHz\n",
> > > - temp_downclock, panel_fixed_mode->clock);
> > > + DRM_DEBUG_KMS("LVDS downclock is found in VBT. "
> > > + "Normal Clock %dKHz, downclock %dKHz\n",
> > > + temp_downclock, panel_fixed_mode->clock);
> > > }
> > > return;
> > > }
> > Does this hunk only change white space, or am I missing something?
>
> No, you're right. It's just whitespace.
> I prefer arguments aligned to open paren.
It's not just whitespace. Look at the end of first line.
Marcin
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 33582] unable to hibernate with nouveau and NV11 [bisected]
https://bugzilla.kernel.org/show_bug.cgi?id=33582 C Sights changed: What|Removed |Added Blocks||16444 Summary|unable to hibernate with|unable to hibernate with |nouveau and NV11|nouveau and NV11 [bisected] -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev -- ___ Dri-devel mailing list dri-de...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 2/2] drm: Verify debug message arguments
On Tue, 2011-04-19 at 18:26 +0200, Marcin Slusarz wrote:
> On Mon, Apr 18, 2011 at 04:09:11PM -0700, Joe Perches wrote:
> > On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote:
> > > > - DRM_DEBUG_KMS("LVDS downclock is found in VBT. ",
> > > > - "Normal Clock %dKHz, downclock %dKHz\n",
> > > > - temp_downclock,
> > > > panel_fixed_mode->clock);
> > > > + DRM_DEBUG_KMS("LVDS downclock is found in VBT. "
> > > > + "Normal Clock %dKHz, downclock %dKHz\n",
> > > > + temp_downclock, panel_fixed_mode->clock);
> > > Does this hunk only change white space, or am I missing something?
> > No, you're right. It's just whitespace.
> > I prefer arguments aligned to open paren.
> It's not just whitespace. Look at the end of first line.
Heh. Thanks Marcin.
Teach me to just at the code in the patch.
It's a format error as the first quoted string has
a comma at the end so the arguments after the comma
were ignored.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm: Add a driver for kvm emulated Cirrus
On Mon, Apr 18, 2011 at 10:20:13PM +0100, Matthew Garrett wrote: > On Mon, Apr 18, 2011 at 10:03:06PM +0100, Alan Cox wrote: > > So has this been benchmarked - intuitively I'd agree and expect that a > > shadowfb driver ought to give best performance. > > No, but it's noticably nicer to use under virt-manager. I'll try to come > up with some numbers. x11perf shows it winning on every benchmark, with results ranging from 10% to >2% higher. -- Matthew Garrett | mj...@srcf.ucam.org ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/radeon/kms: pll tweaks for r7xx
Prefer min m to max p only on pre-r7xx asics.
Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=36197
Signed-off-by: Alex Deucher
Cc: sta...@kernel.org
---
drivers/gpu/drm/radeon/atombios_crtc.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c
b/drivers/gpu/drm/radeon/atombios_crtc.c
index 9d516a8..529a3a7 100644
--- a/drivers/gpu/drm/radeon/atombios_crtc.c
+++ b/drivers/gpu/drm/radeon/atombios_crtc.c
@@ -532,10 +532,7 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
else
pll->flags |= RADEON_PLL_PREFER_LOW_REF_DIV;
- if ((rdev->family == CHIP_R600) ||
- (rdev->family == CHIP_RV610) ||
- (rdev->family == CHIP_RV630) ||
- (rdev->family == CHIP_RV670))
+ if (rdev->family < CHIP_RV770)
pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP;
} else {
pll->flags |= RADEON_PLL_LEGACY;
@@ -565,7 +562,6 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
if (radeon_encoder->devices &
(ATOM_DEVICE_LCD_SUPPORT)) {
if (ss_enabled) {
if (ss->refdiv) {
- pll->flags |=
RADEON_PLL_PREFER_MINM_OVER_MAXP;
pll->flags |=
RADEON_PLL_USE_REF_DIV;
pll->reference_div = ss->refdiv;
if (ASIC_IS_AVIVO(rdev))
--
1.7.1.1
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: 2.6.39-rc1 nouveau(?) regression (bisected)
On Mon, Apr 18, 2011 at 01:27:10PM -0700, Linus Torvalds wrote: > On Mon, Apr 18, 2011 at 1:02 PM, Marcin Slusarz > wrote: > > > > It's some nasty corruption: > > Looks like something wrote 0x to free'd memory. > > Enabling DEBUG_PAGEALLOC *might* show where it happens. > > > > > [ 6.523867] > > = > > [ 6.523916] BUG sysfs_dir_cache: Poison overwritten > > [ 6.523949] > > - > > [ 6.523950] > > [ 6.524016] INFO: 0x8801bb47df4c-0x8801bb47df4f. First byte 0xff > > instead of 0x6b > > [ 6.524061] INFO: Slab 0xea00060f7b58 objects=22 used=21 > > fp=0x8801bb47df18 flags=0x80c1 > > [ 6.524110] INFO: Object 0x8801bb47df18 @offset=3864 fp=0x > > (null) > > [ 6.524111] > > [ 6.524170] Bytes b4 0x8801bb47df08: 00 00 00 00 00 00 00 00 5a 5a > > 5a 5a 5a 5a 5a 5a > > [ 6.524516] Object 0x8801bb47df18: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b > > 6b 6b 6b 6b 6b 6b > > [ 6.524862] Object 0x8801bb47df28: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b > > 6b 6b 6b 6b 6b 6b > > [ 6.525208] Object 0x8801bb47df38: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b > > 6b 6b 6b 6b 6b 6b > > [ 6.525556] Object 0x8801bb47df48: 6b 6b 6b 6b ff ff ff ff 6b 6b > > 6b 6b 6b 6b 6b 6b > > So here the 0x is pretty obvious. > > > and in another boot: > > > > [ 6.704786] BUG: unable to handle kernel paging request at > > bc70b058 > > Here it is less obvious, but it was _probably_ a regular kernel > pointer of the type 0x8801bc70b058 before the high bits were > overwritten by a 0x. > > So then sysfs_refresh_inode() follows that pointer, and crashes. > > Just a guess, obviously, but it looks rather likely. Thanks. It helped a bit. I'll send two patches in response to this message, one of which fixes this bug. Marcin ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 1/2] drm/nouveau: fix notifier memory corruption bug
nouveau_bo_wr32 expects offset to be in words, but we pass value in bytes,
so after commit 73412c3854c877e5f37ad944ee8977addde4d35a ("drm/nouveau: allocate
kernel's notifier object at end of block") we started to overwrite some memory
after notifier buffer object (previously m2mf_ntfy was always 0, so it didn't
matter it was a value in bytes).
Reported-by: Dominik Brodowski
Reported-by: Nigel Cunningham
Signed-off-by: Marcin Slusarz
Cc: Ben Skeggs
Cc: Pekka Paalanen
Cc: sta...@kernel.org[2.6.38]
---
drivers/gpu/drm/nouveau/nouveau_fbcon.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index 889c445..39aee6d 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -181,13 +181,13 @@ nouveau_fbcon_sync(struct fb_info *info)
OUT_RING (chan, 0);
}
- nouveau_bo_wr32(chan->notifier_bo, chan->m2mf_ntfy + 3, 0x);
+ nouveau_bo_wr32(chan->notifier_bo, chan->m2mf_ntfy/4 + 3, 0x);
FIRE_RING(chan);
mutex_unlock(&chan->mutex);
ret = -EBUSY;
for (i = 0; i < 10; i++) {
- if (!nouveau_bo_rd32(chan->notifier_bo, chan->m2mf_ntfy + 3)) {
+ if (!nouveau_bo_rd32(chan->notifier_bo, chan->m2mf_ntfy/4 + 3))
{
ret = 0;
break;
}
--
1.7.4.1
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 2/2] drm/nouveau: fix allocation of notifier object
Commit 73412c3854c877e5f37ad944ee8977addde4d35a ("drm/nouveau: allocate
kernel's notifier object at end of block") intended to align end of
notifier block to page boundary, but start of block was miscalculated
to be off by -16 bytes. Fix it.
Signed-off-by: Marcin Slusarz
Cc: Ben Skeggs
---
drivers/gpu/drm/nouveau/nouveau_dma.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_dma.c
b/drivers/gpu/drm/nouveau/nouveau_dma.c
index ce38e97..568caed 100644
--- a/drivers/gpu/drm/nouveau/nouveau_dma.c
+++ b/drivers/gpu/drm/nouveau/nouveau_dma.c
@@ -83,7 +83,7 @@ nouveau_dma_init(struct nouveau_channel *chan)
return ret;
/* NV_MEMORY_TO_MEMORY_FORMAT requires a notifier object */
- ret = nouveau_notifier_alloc(chan, NvNotify0, 32, 0xfd0, 0x1000,
+ ret = nouveau_notifier_alloc(chan, NvNotify0, 32, 0xfe0, 0x1000,
&chan->m2mf_ntfy);
if (ret)
return ret;
--
1.7.4.1
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36403] New: [r300g] glean vertattrib regression
https://bugs.freedesktop.org/show_bug.cgi?id=36403 Summary: [r300g] glean vertattrib regression Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: critical Priority: medium Component: Drivers/Gallium/r300 AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: v...@vmware.com mesa: 08d1c91e6c185a186e49189b7ed48629f35a4659 (master) chipset: RV530 71C5 (ATI Radeon X1600) system architecture: i686 kernel version: 2.6.35-28-generic Linux distribution: Ubuntu 10.10 i386 Machine model: iMac4,1 glean vertattrib crashes but previously passed. $ ./bin/glean -r results -t vertattrib --quick r300: DRM version: 2.5.0, Name: ATI RV530, ID: 0x71c5, GB: 1, Z: 2 r300: GART size: 509 MB, VRAM size: 128 MB r300: AA compression: NO, Z compression: NO, HiZ: NO Segmentation fault (core dumped) (gdb) bt #0 0x018887b9 in loopback_VertexAttrib2svARB (index=1, v=0x3f80) at src/mesa/main/api_loopback.c:1341 #1 0x017ca7c1 in execute_list (ctx=0x99ec320, list=42) at src/mesa/main/dlist.c:8174 #2 0x017cb74f in _mesa_CallList (list=42) at src/mesa/main/dlist.c:8511 #3 0x08140bda in GLEAN::VertAttribTest::TestAttribs (this=0x81c1300, r=..., attribFunc=26, getAttribfv=0x832350 , aliasing=GLEAN::VertAttribTest::DISALLOWED, numAttribs=16) at piglit/tests/glean/tvertattrib.cpp:1357 #4 0x08141257 in GLEAN::VertAttribTest::TestARBfuncs (this=0x81c1300, r=..., shader=false) at piglit/tests/glean/tvertattrib.cpp:1498 #5 0x08141406 in GLEAN::VertAttribTest::runOne (this=0x81c1300, r=...) at piglit/tests/glean/tvertattrib.cpp:1562 #6 0x08142304 in GLEAN::BaseTest::run (this=0x81c1300, environment=...) at piglit/tests/glean/tbase.h:325 #7 0x080bdd16 in main (argc=7, argv=0xbfd351d4) at piglit/tests/glean/main.cpp:141 (gdb) frame 0 #0 0x018887b9 in loopback_VertexAttrib2svARB (index=1, v=0x3f80) at src/mesa/main/api_loopback.c:1341 1341 ATTRIB2ARB(index, (GLfloat) v[0], (GLfloat) v[1]); (gdb) print v $3 = (const GLshort *) 0x3f80 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36403] [r300g] glean vertattrib regression
https://bugs.freedesktop.org/show_bug.cgi?id=36403 --- Comment #1 from Marek Olšák 2011-04-19 15:04:39 PDT --- The test passes here. Are you using --enable-shared-glapi? Try 'git clean -fdx' before building. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36403] [r300g] glean vertattrib regression
https://bugs.freedesktop.org/show_bug.cgi?id=36403 --- Comment #2 from Vinson Lee 2011-04-19 15:08:01 PDT --- (In reply to comment #1) > The test passes here. Are you using --enable-shared-glapi? Try 'git clean > -fdx' > before building. No, I'm building with 'scons dri-r300'. 34a5d3b9f4740601708c82093e2114356d749e65 is the first bad commit commit 34a5d3b9f4740601708c82093e2114356d749e65 Author: Brian Paul Date: Sun Apr 10 12:48:28 2011 -0600 mesa: plug in new functions for GL_ARB_sampler_objects Build the new sources, plug the new functions into the dispatch table, implement display list support. And enable extension in the gallium state tracker. :04 04 50d8747e0dc22e1634407703563447bd0e1c44d3 be44081fa9ea33563f8582df370cfb13a0d5c256 Msrc bisect run success -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: 2.6.39-rc1 nouveau(?) regression (bisected)
On Tue, 2011-04-19 at 23:47 +0200, Marcin Slusarz wrote: > On Mon, Apr 18, 2011 at 01:27:10PM -0700, Linus Torvalds wrote: > > On Mon, Apr 18, 2011 at 1:02 PM, Marcin Slusarz > > wrote: > > > > > > It's some nasty corruption: > > > > Looks like something wrote 0x to free'd memory. > > > > Enabling DEBUG_PAGEALLOC *might* show where it happens. > > > > > > > > [6.523867] > > > = > > > [6.523916] BUG sysfs_dir_cache: Poison overwritten > > > [6.523949] > > > - > > > [6.523950] > > > [6.524016] INFO: 0x8801bb47df4c-0x8801bb47df4f. First byte > > > 0xff instead of 0x6b > > > [6.524061] INFO: Slab 0xea00060f7b58 objects=22 used=21 > > > fp=0x8801bb47df18 flags=0x80c1 > > > [6.524110] INFO: Object 0x8801bb47df18 @offset=3864 fp=0x > > > (null) > > > [6.524111] > > > [6.524170] Bytes b4 0x8801bb47df08: 00 00 00 00 00 00 00 00 5a > > > 5a 5a 5a 5a 5a 5a 5a > > > [6.524516] Object 0x8801bb47df18: 6b 6b 6b 6b 6b 6b 6b 6b 6b > > > 6b 6b 6b 6b 6b 6b 6b > > > [6.524862] Object 0x8801bb47df28: 6b 6b 6b 6b 6b 6b 6b 6b 6b > > > 6b 6b 6b 6b 6b 6b 6b > > > [6.525208] Object 0x8801bb47df38: 6b 6b 6b 6b 6b 6b 6b 6b 6b > > > 6b 6b 6b 6b 6b 6b 6b > > > [6.525556] Object 0x8801bb47df48: 6b 6b 6b 6b ff ff ff ff 6b > > > 6b 6b 6b 6b 6b 6b 6b > > > > So here the 0x is pretty obvious. > > > > > and in another boot: > > > > > > [6.704786] BUG: unable to handle kernel paging request at > > > bc70b058 > > > > Here it is less obvious, but it was _probably_ a regular kernel > > pointer of the type 0x8801bc70b058 before the high bits were > > overwritten by a 0x. > > > > So then sysfs_refresh_inode() follows that pointer, and crashes. > > > > Just a guess, obviously, but it looks rather likely. > > Thanks. It helped a bit. > I'll send two patches in response to this message, one of which fixes this > bug. Nice catch. I'll push these to the nouveau tree now, and get them to Dave with some additional fixes. Ben. > > Marcin > ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 33825] [r600g, wine] sync/fenc GL extension missing
https://bugs.freedesktop.org/show_bug.cgi?id=33825 Tobias Jakobi changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] Big endian support for RV730 (Gallium r600g)
[ Moving to the mesa-dev list ]
On Fre, 2011-04-15 at 18:20 +0200, Cédric Cano wrote:
>
> Here you are a patch that adds big endian support for rv730 in r600
> gallium driver.
>
> I used the mesa-demos to test the driver status on big endian platform.
> Except with demos using accumulation buffer, the rendering is the same
> as on Intel platform. Albeit there are still some artefacts with some
> demos.
>
> I manage to fix accumulation buffer demos but then, glReadPixels demos
> won't work. I still can figure out (like with r600c) what and when I
> must enable swap. It will depends on object's domains. That's what I
> tried to do in r600_cb and r600_create_sampler_view.
That's probably because it hasn't been fully thought through yet how to
deal with big endian CPUs vs. little endian GPUs in Gallium. When this
was discussed previously, the basic rule decided was that all data
passed across the Gallium driver interface was supposed to be little
endian. That should probably be feasible in general for at least
'standard' pixel formats, but I'm afraid it doesn't really work for
vertex data[0], which could be fed from the application (which will use
CPU native byte order) to the GPU more or less directly.
Maybe byte order should be handled explicitly by the Gallium format
definitions, and then it would be up to the state tracker to use the
appropriate byte order formats. José, have you had any further thoughts
on this?
[0] Though there might also be ambiguities e.g. with multi-byte
component pixel formats: Does the little endian rule apply to the pixel
value as a whole, or only for each component?
> @@ -266,11 +268,31 @@ void r600_upload_const_buffer(struct r600_pipe_context
> *rctx, struct r600_resour
> uint8_t *ptr = (*rbuffer)->r.b.user_ptr;
> unsigned size = (*rbuffer)->r.b.b.b.width0;
> boolean flushed;
> +#ifdef PIPE_ARCH_BIG_ENDIAN
> + int i;
> + uint32_t *tmpPtr;
> +
> + *rbuffer = NULL;
> +
> + tmpPtr = (uint32_t *)malloc(size);
> + /* big endian swap */
> + if(tmpPtr == NULL) {
> + return;
> + }
> + for(i = 0; i < size / 4; i++) {
> + tmpPtr[i] = bswap_32(*((uint32_t *)ptr + i));
> + }
> +
> + u_upload_data(rctx->vbuf_mgr->uploader, 0, size, tmpPtr,
> const_offset,
> + (struct pipe_resource**)rbuffer, &flushed);
Might be better to add a helper like u_upload_data_to_le32().
--
Earthling Michel Dänzer |http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] fix mesa tarball creation again
On 04/19/2011 03:04 AM, Thierry Vignaud wrote: On 18 April 2011 01:27, Marek Olšák wrote: Pushed, thanks. Can you know commit this one that fixes missing files in the generated tarball so that one can build mesa out of the tarball? Thx I'll commit it soon. Thanks. There's a few other files missing, like SConscript files that I need to add too... -Brian ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[git pull] drm fixes (radeon + nouveau)
Hi Linus, Couple of radeon fixes and a few nouveau fixes, one for a memory corruption due to how the notifier was allocated. Dave. The following changes since commit 2582b6efceb43dce63b4a1090d289934067a972d: Revert "i915: restore only the mode of this driver on lastclose" (2011-04-13 09:20:24 +1000) are available in the git repository at: ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-fixes Alex Deucher (4): drm/radeon/kms: fix bad shift in atom iio table parser drm/radeon/kms: add connectors even if i2c fails drm/radeon/kms: adjust evergreen display watermark setup drm/radeon/kms: pll tweaks for r7xx Ben Skeggs (4): drm/nouveau: split ramin_lock into two locks, one hardirq safe drm/nouveau: fix nv30 pcie boards drm/nouveau: populate ttm_alloced with false, when it's not drm/nouveau: fix pinning of notifier block Dave Airlie (1): Merge remote branch 'nouveau/drm-nouveau-fixes' of /ssd/git/drm-nouveau-next into drm-fixes Marcin Slusarz (2): drm/nouveau: fix notifier memory corruption bug drm/nouveau: fix allocation of notifier object drivers/gpu/drm/nouveau/nouveau_dma.c |2 +- drivers/gpu/drm/nouveau/nouveau_drv.h |3 + drivers/gpu/drm/nouveau/nouveau_fbcon.c|4 +- drivers/gpu/drm/nouveau/nouveau_mem.c |2 +- drivers/gpu/drm/nouveau/nouveau_notifier.c | 11 ++- drivers/gpu/drm/nouveau/nouveau_object.c | 10 ++- drivers/gpu/drm/nouveau/nouveau_sgdma.c|5 +- drivers/gpu/drm/nouveau/nouveau_state.c|1 + drivers/gpu/drm/nouveau/nv50_instmem.c | 10 ++- drivers/gpu/drm/nouveau/nv50_vm.c |5 +- drivers/gpu/drm/nouveau/nvc0_vm.c |5 +- drivers/gpu/drm/radeon/atom.c |6 +- drivers/gpu/drm/radeon/atombios_crtc.c |6 +-- drivers/gpu/drm/radeon/evergreen.c | 89 ++-- drivers/gpu/drm/radeon/radeon_connectors.c | 29 - drivers/gpu/drm/radeon/radeon_i2c.c|6 ++ 16 files changed, 102 insertions(+), 92 deletions(-) ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36403] [r300g] glean vertattrib regression
https://bugs.freedesktop.org/show_bug.cgi?id=36403 --- Comment #3 from Marek Olšák 2011-04-19 23:43:39 PDT --- Tried the scons build and it works too. $ LIBGL_DRIVERS_PATH=[snip]/mesa/build/linux-x86-debug/gallium/targets/dri-r300 bin/glean -r results -t vertattrib --quick -o [snip] vertattrib: PASS rgba8, db, z24, s8, win+pmap, id 33 0 GL_NV_vertex_program functions tested 36 GL_ARB_vertex_program/shader functions tested 36 OpenGL 2.0 functions tested -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 1/2] drm: Create and use drm_err
On Mon, 2011-04-18 at 15:56 -0700, Ian Romanick wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 04/17/2011 08:35 PM, Joe Perches wrote:
> > Reduce drm text size ~1% by using drm_err and
> > printf extension %pV to emit error messages.
> >
> > Remove unused macro DRM_MEM_ERROR.
> >
> > $ size drivers/gpu/drm/built-in.o*
> >textdata bss dec hex filename
> > 3611599663 256 371078 5a986 drivers/gpu/drm/built-in.o.new
> > 3654169663 256 375335 5ba27 drivers/gpu/drm/built-in.o.old
> >
> > Signed-off-by: Joe Perches
> > ---
> > drivers/gpu/drm/drm_stub.c | 21 +
> > include/drm/drmP.h | 21 +++--
> > 2 files changed, 28 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c
> > index 001273d..6d7b083 100644
> > --- a/drivers/gpu/drm/drm_stub.c
> > +++ b/drivers/gpu/drm/drm_stub.c
> > @@ -62,6 +62,26 @@ struct idr drm_minors_idr;
> > struct class *drm_class;
> > struct proc_dir_entry *drm_proc_root;
> > struct dentry *drm_debugfs_root;
> > +
> > +int drm_err(const char *func, const char *format, ...)
> > +{
> > + struct va_format vaf;
> > + va_list args;
> > + int r;
> > +
> > + va_start(args, format);
> > +
> > + vaf.fmt = format;
> > + vaf.va = &args;
> > +
> > + r = printk(KERN_ERR "[" DRM_NAME ":%s] *ERROR* %pV", func, &vaf);
>
> This code has ben reorganized a lot over the years, so this comment may
> be bogus. However...
>
> I believe that DRM_NAME is a define, and drm_stub.c is in common code.
> As a result, won't this change cause something different to get logged?
No I think we hacked that out a long time past thankfully, so its always
"drm" now.
Dave.
[PATCH] drm/radeon/kms: adjust eDP handling
eDP is usually used as an LVDS replacement, so treat
it more like LVDS from the user perspective.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/radeon_connectors.c | 30 +++
1 files changed, 25 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c
b/drivers/gpu/drm/radeon/radeon_connectors.c
index 5f45fa1..a7bdcc7 100644
--- a/drivers/gpu/drm/radeon/radeon_connectors.c
+++ b/drivers/gpu/drm/radeon/radeon_connectors.c
@@ -1314,7 +1314,6 @@ radeon_add_atom_connector(struct drm_device *dev,
connector->doublescan_allowed = false;
break;
case DRM_MODE_CONNECTOR_DisplayPort:
- case DRM_MODE_CONNECTOR_eDP:
radeon_dig_connector = kzalloc(sizeof(struct
radeon_connector_atom_dig), GFP_KERNEL);
if (!radeon_dig_connector)
goto failed;
@@ -1324,10 +1323,7 @@ radeon_add_atom_connector(struct drm_device *dev,
drm_connector_helper_add(&radeon_connector->base,
&radeon_dp_connector_helper_funcs);
if (i2c_bus->valid) {
/* add DP i2c bus */
- if (connector_type == DRM_MODE_CONNECTOR_eDP)
- radeon_dig_connector->dp_i2c_bus =
radeon_i2c_create_dp(dev, i2c_bus, "eDP-auxch");
- else
- radeon_dig_connector->dp_i2c_bus =
radeon_i2c_create_dp(dev, i2c_bus, "DP-auxch");
+ radeon_dig_connector->dp_i2c_bus =
radeon_i2c_create_dp(dev, i2c_bus, "DP-auxch");
if (!radeon_dig_connector->dp_i2c_bus)
DRM_ERROR("DP: Failed to assign dp ddc bus!
Check dmesg for i2c errors.\n");
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
@@ -1353,6 +1349,30 @@ radeon_add_atom_connector(struct drm_device *dev,
/* in theory with a DP to VGA converter... */
connector->doublescan_allowed = false;
break;
+ case DRM_MODE_CONNECTOR_eDP:
+ radeon_dig_connector = kzalloc(sizeof(struct
radeon_connector_atom_dig), GFP_KERNEL);
+ if (!radeon_dig_connector)
+ goto failed;
+ radeon_dig_connector->igp_lane_info = igp_lane_info;
+ radeon_connector->con_priv = radeon_dig_connector;
+ drm_connector_init(dev, &radeon_connector->base,
&radeon_dp_connector_funcs, connector_type);
+ drm_connector_helper_add(&radeon_connector->base,
&radeon_dp_connector_helper_funcs);
+ if (i2c_bus->valid) {
+ /* add DP i2c bus */
+ radeon_dig_connector->dp_i2c_bus =
radeon_i2c_create_dp(dev, i2c_bus, "eDP-auxch");
+ if (!radeon_dig_connector->dp_i2c_bus)
+ DRM_ERROR("DP: Failed to assign dp ddc bus!
Check dmesg for i2c errors.\n");
+ radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
+ if (!radeon_connector->ddc_bus)
+ DRM_ERROR("DP: Failed to assign ddc bus! Check
dmesg for i2c errors.\n");
+ }
+ drm_connector_attach_property(&radeon_connector->base,
+
dev->mode_config.scaling_mode_property,
+ DRM_MODE_SCALE_FULLSCREEN);
+ subpixel_order = SubPixelHorizontalRGB;
+ connector->interlace_allowed = false;
+ connector->doublescan_allowed = false;
+ break;
case DRM_MODE_CONNECTOR_SVIDEO:
case DRM_MODE_CONNECTOR_Composite:
case DRM_MODE_CONNECTOR_9PinDIN:
--
1.7.1.1
[PATCH:libdrm] Link dristat with -lrt if appropriate.
The need for -lrt is determined at configure time, let's use the resulting variable for dristat's link, since it uses clock_gettime(). Signed-off-by: Cyril Brulebois --- tests/Makefile.am |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index bf1987f..6f48931 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -10,6 +10,8 @@ check_PROGRAMS = \ dristat \ drmstat +dristat_LDADD = $(CLOCK_LIB) + SUBDIRS = modeprint if HAVE_LIBKMS -- 1.7.4.1
[Bug 34218] [r300g] Unigine Sanctuary: some surfaces are reflecting too much light
https://bugs.freedesktop.org/show_bug.cgi?id=34218 --- Comment #7 from Pavel Ondra?ka 2011-04-19 01:36:51 PDT --- (In reply to comment #6) > Can you try this again with the latest git version of mesa (commit > ffc1d166d24532aeaa4dcf06a431e43ab7e7e315 or newer)? Still broken with current git. Works fine with RADEON_DEBUG=noopt. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[PATCH] radeon: Fix KMS CP writeback on big endian machines.
Hi, The following patch fixes interrupt acknowledge when write-back is enabled on big endian platform. The same should be applied on evergreen. Cedric Signed-off-by: Cedric Cano --- diff -Naur linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c --- linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c2011-04-19 09:52:13.0 +0200 +++ linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c2011-03-27 20:37:20.0 +0200 @@ -3227,7 +3227,7 @@ u32 wptr, tmp; if (rdev->wb.enabled) -wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); +wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; else wptr = RREG32(IH_RB_WPTR);
[PATCH] radeon: Fix KMS CP writeback on big endian machines.
On Die, 2011-04-19 at 10:23 +0200, C?dric Cano wrote: > > The following patch fixes interrupt acknowledge when write-back is > enabled on big endian platform. > > The same should be applied on evergreen. Can you include that in the patch? I somehow managed to miss these in my previous patch for older chips. :( -- Earthling Michel D?nzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer
[PATCH] fix mesa tarball creation again
On 18 April 2011 01:27, Marek Ol??k wrote: > Pushed, thanks. Can you know commit this one that fixes missing files in the generated tarball so that one can build mesa out of the tarball? Thx -- next part -- A non-text attachment was scrubbed... Name: fix-missing-files-in-tarball.diff Type: text/x-patch Size: 755 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20110419/0ffd436b/attachment.bin>
[Bug 36386] New: Amnesia game crashes on RV570 (r300g)
https://bugs.freedesktop.org/show_bug.cgi?id=36386 Summary: Amnesia game crashes on RV570 (r300g) Product: Mesa Version: 7.10 Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r300 AssignedTo: dri-devel at lists.freedesktop.org ReportedBy: vand2 at gmx.de The game Amnesia crashes after a startup screen with a silvery sun symbol displayed. glxinfo | grep string server glx vendor string: SGI server glx version string: 1.2 client glx vendor string: Mesa Project and SGI client glx version string: 1.4 OpenGL vendor string: X.Org R300 Project OpenGL renderer string: Gallium 0.4 on ATI RV570 OpenGL version string: 2.1 Mesa 7.10.2 OpenGL shading language version string: 1.20 gdb backtrace Program received signal SIGSEGV, Segmentation fault. 0x0082ab08 in hpl::iParticleEmitter::GetMaterial() () #0 0x0082ab08 in hpl::iParticleEmitter::GetMaterial() () #1 0x00805de2 in hpl::iRenderer::RenderObjectZAndAddToRenderList(hpl::iRenderable*) () #2 0x00805e59 in hpl::iRenderer::RenderObjectZAndAddToRenderListStaticCallback(hpl::iRenderer*, hpl::iRenderable*) () #3 0x00807d8f in hpl::iRenderer::RenderAndAddNodeObjects(hpl::iRenderableContainerNode*, bool (*)(hpl::iRenderer*, hpl::iRenderable*), unsigned int) () #4 0x0080808a in hpl::iRenderer::CheckForVisibleObjectsAddToListAndRenderZ(hpl::cVisibleRCNodeTracker*, unsigned int, unsigned int, bool, bool (*)(hpl::iRenderer*, hpl::iRenderable*)) () #5 0x007e4841 in hpl::cRendererDeferred::RenderObjects() () #6 0x00809334 in hpl::iRenderer::Render(float, hpl::cFrustum*, hpl::cWorld*, hpl::cRenderSettings*, hpl::cRenderTarget*, bool, std::list >*) () #7 0x0082496d in hpl::cScene::Render(float, unsigned int) () #8 0x00925423 in hpl::cEngine::Run() () #9 0x00689890 in hplMain(std::string const&) () #10 0x0090ff29 in main () -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36236] Problems with lights in Trine game from www.humblebundle.com
https://bugs.freedesktop.org/show_bug.cgi?id=36236 --- Comment #17 from Turo Lamminen 2011-04-19 02:59:55 PDT --- Created an attachment (id=45803) --> (https://bugs.freedesktop.org/attachment.cgi?id=45803) Modified shader Modified shader, replace data/shader/cg/deferred_light_pixel.cg with this and retest -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[PATCH] radeon: Fix KMS CP writeback on big endian machines.
Signed-off-by: Cedric Cano --- --- linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c2011-04-19 11:39:39.0 +0200 +++ /home/cec/tmp/linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c 2011-03-27 20:37:20.0 +0200 @@ -2587,7 +2587,7 @@ u32 wptr, tmp; if (rdev->wb.enabled) -wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); +wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; else wptr = RREG32(IH_RB_WPTR); Le 19/04/2011 10:54, Michel D?nzer a ?crit : > On Die, 2011-04-19 at 10:23 +0200, C?dric Cano wrote: >> The following patch fixes interrupt acknowledge when write-back is >> enabled on big endian platform. >> >> The same should be applied on evergreen. > Can you include that in the patch? I somehow managed to miss these in my > previous patch for older chips. :( > >
[Bug 36236] Problems with lights in Trine game from www.humblebundle.com
https://bugs.freedesktop.org/show_bug.cgi?id=36236 --- Comment #18 from imamdxl8805 at gmail.com 2011-04-19 04:48:10 PDT --- Created an attachment (id=45808) --> (https://bugs.freedesktop.org/attachment.cgi?id=45808) game graphics result 1 by Modified shader -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36236] Problems with lights in Trine game from www.humblebundle.com
https://bugs.freedesktop.org/show_bug.cgi?id=36236 --- Comment #19 from imamdxl8805 at gmail.com 2011-04-19 04:48:54 PDT --- Created an attachment (id=45809) --> (https://bugs.freedesktop.org/attachment.cgi?id=45809) game graphics result 2 by Modified shader -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36327] fujitsu siemens amilo li1718: ati radeon x200m does not resume from suspend
https://bugs.freedesktop.org/show_bug.cgi?id=36327 --- Comment #11 from ??? ?. 2011-04-19 05:46:47 PDT --- Forgot to mention one more thing related to the Karesz' last comment. Neither Alex' patch from https://bugs.freedesktop.org/show_bug.cgi?id=29062 , nor the simple "return;" statement (without any if's to fight that DYN CLK 1 table issue) made any progress for me (including the recent 2.6.38.2 build) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36393] New: r200: font corruption in fog test
https://bugs.freedesktop.org/show_bug.cgi?id=36393 Summary: r200: font corruption in fog test Product: Mesa Version: unspecified Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/r200 AssignedTo: dri-devel at lists.freedesktop.org ReportedBy: nikai at nikai.net Created an attachment (id=45812) --> (https://bugs.freedesktop.org/attachment.cgi?id=45812) fog test in mesa-7.9.2 In src/tests/fog the text appears distorted, looking somewhat similar to bug 34280. But in contrast, this problem is also present in mesa-7.9.2. System environment: -- system architecture: i686 -- Linux distribution: Gentoo -- GPU: R200 514D -- Model: ATI Radeon 9100 QM (AGP) -- Display connector: VGA -- xf86-video-ati: 982c22f16c89be81779fbfe17d8d3f9b6897 -- xserver: 1.9.4 -- mesa: 9dacbe222641443af000a82161922a5ade206340 and -- mesa: 7.9.2 -- drm: 2.4.25 -- kernel: 2.6.38.2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36393] r200: font corruption in fog test
https://bugs.freedesktop.org/show_bug.cgi?id=36393 --- Comment #1 from Nicolas Kaiser 2011-04-19 06:08:54 PDT --- Created an attachment (id=45813) --> (https://bugs.freedesktop.org/attachment.cgi?id=45813) fog test in mesa-git-9dacbe2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 29495] [r300g] Shadowgrounds: character portraits rendered wrong
https://bugs.freedesktop.org/show_bug.cgi?id=29495 --- Comment #4 from Sven Arvidsson 2011-04-19 06:29:23 PDT --- No change. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36236] Problems with lights in Trine game from www.humblebundle.com
https://bugs.freedesktop.org/show_bug.cgi?id=36236 --- Comment #20 from Sven Arvidsson 2011-04-19 06:34:09 PDT --- (In reply to comment #17) > Modified shader, replace data/shader/cg/deferred_light_pixel.cg with this and > retest AFAICT there's no change. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[PATCH] radeon: Fix KMS CP writeback on big endian machines.
Hi, Sorry, I've done a patch in reverse mode :(. I repost the patch for r600 and evergreen write back correction for big endian platforms. Cedric Signed-off-by: Cedric Cano --- diff -Nuar linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c --- linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c2011-03-27 20:37:20.0 +0200 +++ linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c2011-04-19 11:39:39.0 +0200 @@ -2587,7 +2587,7 @@ u32 wptr, tmp; if (rdev->wb.enabled) -wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; +wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); else wptr = RREG32(IH_RB_WPTR); diff -Nuar linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c --- linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c2011-03-27 20:37:20.0 +0200 +++ linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c2011-04-19 09:52:13.0 +0200 @@ -3227,7 +3227,7 @@ u32 wptr, tmp; if (rdev->wb.enabled) -wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; +wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); else wptr = RREG32(IH_RB_WPTR); Le 19/04/2011 10:54, Michel D?nzer a ?crit : > On Die, 2011-04-19 at 10:23 +0200, C?dric Cano wrote: > > > > The following patch fixes interrupt acknowledge when write-back is > > enabled on big endian platform. > > > > The same should be applied on evergreen. > > Can you include that in the patch? I somehow managed to miss these in > my previous patch for older chips. :( > > -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20110419/a2d770aa/attachment.htm>
[Bug 36396] New: r600_state_inlines.h: unsupported color format
https://bugs.freedesktop.org/show_bug.cgi?id=36396 Summary: r600_state_inlines.h: unsupported color format Product: Mesa Version: git Platform: x86-64 (AMD64) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/r600 AssignedTo: dri-devel at lists.freedesktop.org ReportedBy: mark at tvk.rwth-aachen.de after starting the game Dawn of War with wine (git-version), the following messages are printed several times: EE r600_state_inlines.h/r600_translate_colorformat:408 - unsupported color format 12 EE r600_state_inlines.h/r600_translate_colorformat:408 - unsupported color format 12 EE r600_state_inlines.h/r600_translate_colorformat:408 - unsupported color format 95 EE r600_state_inlines.h/r600_translate_colorformat:408 - unsupported color format 12 EE r600_state_inlines.h/r600_translate_colorformat:408 - unsupported color format 96 EE r600_state_inlines.h/r600_translate_colorformat:408 - unsupported color format 12 some textures and all game-objects like units and buildings aren't drawn, I don't know if this is related. Game has platinum status in winedb, so everything should look fine. mesa: git, xf86-video-ati: git, kernel: d-r-t, HD4350 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[PATCH] radeon: Fix KMS CP writeback on big endian machines.
On Die, 2011-04-19 at 16:38 +0200, C?dric Cano wrote: > > Sorry, I've done a patch in reverse mode :(. I can recommend using Git. :) > I repost the patch for r600 and evergreen write back correction for > big endian platforms. > > Cedric > > Signed-off-by: Cedric Cano > --- > diff -Nuar linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c > linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c > --- linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c2011-03-27 > 20:37:20.0 +0200 > +++ linux-2.6.38.2/drivers/gpu/drm/radeon/evergreen.c2011-04-19 > 11:39:39.0 +0200 > @@ -2587,7 +2587,7 @@ > u32 wptr, tmp; > > if (rdev->wb.enabled) > -wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; > +wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); > else > wptr = RREG32(IH_RB_WPTR); > > > diff -Nuar linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c > linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c > --- linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c2011-03-27 > 20:37:20.0 +0200 > +++ linux-2.6.38.2/drivers/gpu/drm/radeon/r600.c2011-04-19 > 09:52:13.0 +0200 > @@ -3227,7 +3227,7 @@ > u32 wptr, tmp; > > if (rdev->wb.enabled) > -wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; > +wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); > else > wptr = RREG32(IH_RB_WPTR); Reviewed-by: Michel D?nzer -- Earthling Michel D?nzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer
[PATCH] drm/radeon/kms: fix IH writeback on r6xx+ on big endian machines
From: C?dric Cano agd5f: fix commit message. Signed-off-by: Cedric Cano Reviewed-by: Michel D?nzer Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/evergreen.c |2 +- drivers/gpu/drm/radeon/r600.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c index 363f39b..eee208f 100644 --- a/drivers/gpu/drm/radeon/evergreen.c +++ b/drivers/gpu/drm/radeon/evergreen.c @@ -2638,7 +2638,7 @@ static inline u32 evergreen_get_ih_wptr(struct radeon_device *rdev) u32 wptr, tmp; if (rdev->wb.enabled) - wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; + wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); else wptr = RREG32(IH_RB_WPTR); diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index 62fc968..d74d4d7 100644 --- a/drivers/gpu/drm/radeon/r600.c +++ b/drivers/gpu/drm/radeon/r600.c @@ -3243,7 +3243,7 @@ static inline u32 r600_get_ih_wptr(struct radeon_device *rdev) u32 wptr, tmp; if (rdev->wb.enabled) - wptr = rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]; + wptr = le32_to_cpu(rdev->wb.wb[R600_WB_IH_WPTR_OFFSET/4]); else wptr = RREG32(IH_RB_WPTR); -- 1.7.1.1
[PATCH 2/2] drm: Verify debug message arguments
On Mon, Apr 18, 2011 at 04:09:11PM -0700, Joe Perches wrote:
> On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote:
> > > @@ -214,9 +214,9 @@ parse_lfp_panel_data(struct drm_i915_private
> > > *dev_priv,
> > > i915_lvds_downclock) {
> > > dev_priv->lvds_downclock_avail = 1;
> > > dev_priv->lvds_downclock = temp_downclock;
> > > - DRM_DEBUG_KMS("LVDS downclock is found in VBT. ",
> > > - "Normal Clock %dKHz, downclock %dKHz\n",
> > > - temp_downclock, panel_fixed_mode->clock);
> > > + DRM_DEBUG_KMS("LVDS downclock is found in VBT. "
> > > + "Normal Clock %dKHz, downclock %dKHz\n",
> > > + temp_downclock, panel_fixed_mode->clock);
> > > }
> > > return;
> > > }
> > Does this hunk only change white space, or am I missing something?
>
> No, you're right. It's just whitespace.
> I prefer arguments aligned to open paren.
It's not just whitespace. Look at the end of first line.
Marcin
[Bug 33582] unable to hibernate with nouveau and NV11 [bisected]
https://bugzilla.kernel.org/show_bug.cgi?id=33582 C Sights changed: What|Removed |Added Blocks||16444 Summary|unable to hibernate with|unable to hibernate with |nouveau and NV11|nouveau and NV11 [bisected] -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev -- ___ Dri-devel mailing list Dri-devel at lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[PATCH 2/2] drm: Verify debug message arguments
On Tue, 2011-04-19 at 18:26 +0200, Marcin Slusarz wrote:
> On Mon, Apr 18, 2011 at 04:09:11PM -0700, Joe Perches wrote:
> > On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote:
> > > > - DRM_DEBUG_KMS("LVDS downclock is found in VBT. ",
> > > > - "Normal Clock %dKHz, downclock %dKHz\n",
> > > > - temp_downclock,
> > > > panel_fixed_mode->clock);
> > > > + DRM_DEBUG_KMS("LVDS downclock is found in VBT. "
> > > > + "Normal Clock %dKHz, downclock %dKHz\n",
> > > > + temp_downclock, panel_fixed_mode->clock);
> > > Does this hunk only change white space, or am I missing something?
> > No, you're right. It's just whitespace.
> > I prefer arguments aligned to open paren.
> It's not just whitespace. Look at the end of first line.
Heh. Thanks Marcin.
Teach me to just at the code in the patch.
It's a format error as the first quoted string has
a comma at the end so the arguments after the comma
were ignored.
[PATCH] drm: Add a driver for kvm emulated Cirrus
On Mon, Apr 18, 2011 at 10:20:13PM +0100, Matthew Garrett wrote: > On Mon, Apr 18, 2011 at 10:03:06PM +0100, Alan Cox wrote: > > So has this been benchmarked - intuitively I'd agree and expect that a > > shadowfb driver ought to give best performance. > > No, but it's noticably nicer to use under virt-manager. I'll try to come > up with some numbers. x11perf shows it winning on every benchmark, with results ranging from 10% to >2% higher. -- Matthew Garrett | mjg59 at srcf.ucam.org
[PATCH] drm/radeon/kms: pll tweaks for r7xx
Prefer min m to max p only on pre-r7xx asics.
Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=36197
Signed-off-by: Alex Deucher
Cc: stable at kernel.org
---
drivers/gpu/drm/radeon/atombios_crtc.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c
b/drivers/gpu/drm/radeon/atombios_crtc.c
index 9d516a8..529a3a7 100644
--- a/drivers/gpu/drm/radeon/atombios_crtc.c
+++ b/drivers/gpu/drm/radeon/atombios_crtc.c
@@ -532,10 +532,7 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
else
pll->flags |= RADEON_PLL_PREFER_LOW_REF_DIV;
- if ((rdev->family == CHIP_R600) ||
- (rdev->family == CHIP_RV610) ||
- (rdev->family == CHIP_RV630) ||
- (rdev->family == CHIP_RV670))
+ if (rdev->family < CHIP_RV770)
pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP;
} else {
pll->flags |= RADEON_PLL_LEGACY;
@@ -565,7 +562,6 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
if (radeon_encoder->devices &
(ATOM_DEVICE_LCD_SUPPORT)) {
if (ss_enabled) {
if (ss->refdiv) {
- pll->flags |=
RADEON_PLL_PREFER_MINM_OVER_MAXP;
pll->flags |=
RADEON_PLL_USE_REF_DIV;
pll->reference_div = ss->refdiv;
if (ASIC_IS_AVIVO(rdev))
--
1.7.1.1
2.6.39-rc1 nouveau(?) regression (bisected)
On Mon, Apr 18, 2011 at 01:27:10PM -0700, Linus Torvalds wrote: > On Mon, Apr 18, 2011 at 1:02 PM, Marcin Slusarz > wrote: > > > > It's some nasty corruption: > > Looks like something wrote 0x to free'd memory. > > Enabling DEBUG_PAGEALLOC *might* show where it happens. > > > > > [ ? ?6.523867] > > = > > [ ? ?6.523916] BUG sysfs_dir_cache: Poison overwritten > > [ ? ?6.523949] > > - > > [ ? ?6.523950] > > [ ? ?6.524016] INFO: 0x8801bb47df4c-0x8801bb47df4f. First byte 0xff > > instead of 0x6b > > [ ? ?6.524061] INFO: Slab 0xea00060f7b58 objects=22 used=21 > > fp=0x8801bb47df18 flags=0x80c1 > > [ ? ?6.524110] INFO: Object 0x8801bb47df18 @offset=3864 fp=0x ? ? ? ? > > ?(null) > > [ ? ?6.524111] > > [ ? ?6.524170] Bytes b4 0x8801bb47df08: ?00 00 00 00 00 00 00 00 5a 5a > > 5a 5a 5a 5a 5a 5a > > [ ? ?6.524516] ? Object 0x8801bb47df18: ?6b 6b 6b 6b 6b 6b 6b 6b 6b 6b > > 6b 6b 6b 6b 6b 6b > > [ ? ?6.524862] ? Object 0x8801bb47df28: ?6b 6b 6b 6b 6b 6b 6b 6b 6b 6b > > 6b 6b 6b 6b 6b 6b > > [ ? ?6.525208] ? Object 0x8801bb47df38: ?6b 6b 6b 6b 6b 6b 6b 6b 6b 6b > > 6b 6b 6b 6b 6b 6b > > [ ? ?6.525556] ? Object 0x8801bb47df48: ?6b 6b 6b 6b ff ff ff ff 6b 6b > > 6b 6b 6b 6b 6b 6b > > So here the 0x is pretty obvious. > > > and in another boot: > > > > [ ? ?6.704786] BUG: unable to handle kernel paging request at > > bc70b058 > > Here it is less obvious, but it was _probably_ a regular kernel > pointer of the type 0x8801bc70b058 before the high bits were > overwritten by a 0x. > > So then sysfs_refresh_inode() follows that pointer, and crashes. > > Just a guess, obviously, but it looks rather likely. Thanks. It helped a bit. I'll send two patches in response to this message, one of which fixes this bug. Marcin
[PATCH 1/2] drm/nouveau: fix notifier memory corruption bug
nouveau_bo_wr32 expects offset to be in words, but we pass value in bytes,
so after commit 73412c3854c877e5f37ad944ee8977addde4d35a ("drm/nouveau: allocate
kernel's notifier object at end of block") we started to overwrite some memory
after notifier buffer object (previously m2mf_ntfy was always 0, so it didn't
matter it was a value in bytes).
Reported-by: Dominik Brodowski
Reported-by: Nigel Cunningham
Signed-off-by: Marcin Slusarz
Cc: Ben Skeggs
Cc: Pekka Paalanen
Cc: stable at kernel.org[2.6.38]
---
drivers/gpu/drm/nouveau/nouveau_fbcon.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
index 889c445..39aee6d 100644
--- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c
+++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c
@@ -181,13 +181,13 @@ nouveau_fbcon_sync(struct fb_info *info)
OUT_RING (chan, 0);
}
- nouveau_bo_wr32(chan->notifier_bo, chan->m2mf_ntfy + 3, 0x);
+ nouveau_bo_wr32(chan->notifier_bo, chan->m2mf_ntfy/4 + 3, 0x);
FIRE_RING(chan);
mutex_unlock(&chan->mutex);
ret = -EBUSY;
for (i = 0; i < 10; i++) {
- if (!nouveau_bo_rd32(chan->notifier_bo, chan->m2mf_ntfy + 3)) {
+ if (!nouveau_bo_rd32(chan->notifier_bo, chan->m2mf_ntfy/4 + 3))
{
ret = 0;
break;
}
--
1.7.4.1
[PATCH 2/2] drm/nouveau: fix allocation of notifier object
Commit 73412c3854c877e5f37ad944ee8977addde4d35a ("drm/nouveau: allocate
kernel's notifier object at end of block") intended to align end of
notifier block to page boundary, but start of block was miscalculated
to be off by -16 bytes. Fix it.
Signed-off-by: Marcin Slusarz
Cc: Ben Skeggs
---
drivers/gpu/drm/nouveau/nouveau_dma.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_dma.c
b/drivers/gpu/drm/nouveau/nouveau_dma.c
index ce38e97..568caed 100644
--- a/drivers/gpu/drm/nouveau/nouveau_dma.c
+++ b/drivers/gpu/drm/nouveau/nouveau_dma.c
@@ -83,7 +83,7 @@ nouveau_dma_init(struct nouveau_channel *chan)
return ret;
/* NV_MEMORY_TO_MEMORY_FORMAT requires a notifier object */
- ret = nouveau_notifier_alloc(chan, NvNotify0, 32, 0xfd0, 0x1000,
+ ret = nouveau_notifier_alloc(chan, NvNotify0, 32, 0xfe0, 0x1000,
&chan->m2mf_ntfy);
if (ret)
return ret;
--
1.7.4.1
[Bug 36403] New: [r300g] glean vertattrib regression
https://bugs.freedesktop.org/show_bug.cgi?id=36403 Summary: [r300g] glean vertattrib regression Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: critical Priority: medium Component: Drivers/Gallium/r300 AssignedTo: dri-devel at lists.freedesktop.org ReportedBy: vlee at vmware.com mesa: 08d1c91e6c185a186e49189b7ed48629f35a4659 (master) chipset: RV530 71C5 (ATI Radeon X1600) system architecture: i686 kernel version: 2.6.35-28-generic Linux distribution: Ubuntu 10.10 i386 Machine model: iMac4,1 glean vertattrib crashes but previously passed. $ ./bin/glean -r results -t vertattrib --quick r300: DRM version: 2.5.0, Name: ATI RV530, ID: 0x71c5, GB: 1, Z: 2 r300: GART size: 509 MB, VRAM size: 128 MB r300: AA compression: NO, Z compression: NO, HiZ: NO Segmentation fault (core dumped) (gdb) bt #0 0x018887b9 in loopback_VertexAttrib2svARB (index=1, v=0x3f80) at src/mesa/main/api_loopback.c:1341 #1 0x017ca7c1 in execute_list (ctx=0x99ec320, list=42) at src/mesa/main/dlist.c:8174 #2 0x017cb74f in _mesa_CallList (list=42) at src/mesa/main/dlist.c:8511 #3 0x08140bda in GLEAN::VertAttribTest::TestAttribs (this=0x81c1300, r=..., attribFunc=26, getAttribfv=0x832350 , aliasing=GLEAN::VertAttribTest::DISALLOWED, numAttribs=16) at piglit/tests/glean/tvertattrib.cpp:1357 #4 0x08141257 in GLEAN::VertAttribTest::TestARBfuncs (this=0x81c1300, r=..., shader=false) at piglit/tests/glean/tvertattrib.cpp:1498 #5 0x08141406 in GLEAN::VertAttribTest::runOne (this=0x81c1300, r=...) at piglit/tests/glean/tvertattrib.cpp:1562 #6 0x08142304 in GLEAN::BaseTest::run (this=0x81c1300, environment=...) at piglit/tests/glean/tbase.h:325 #7 0x080bdd16 in main (argc=7, argv=0xbfd351d4) at piglit/tests/glean/main.cpp:141 (gdb) frame 0 #0 0x018887b9 in loopback_VertexAttrib2svARB (index=1, v=0x3f80) at src/mesa/main/api_loopback.c:1341 1341 ATTRIB2ARB(index, (GLfloat) v[0], (GLfloat) v[1]); (gdb) print v $3 = (const GLshort *) 0x3f80 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36403] [r300g] glean vertattrib regression
https://bugs.freedesktop.org/show_bug.cgi?id=36403 --- Comment #1 from Marek Ol??k 2011-04-19 15:04:39 PDT --- The test passes here. Are you using --enable-shared-glapi? Try 'git clean -fdx' before building. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36403] [r300g] glean vertattrib regression
https://bugs.freedesktop.org/show_bug.cgi?id=36403 --- Comment #2 from Vinson Lee 2011-04-19 15:08:01 PDT --- (In reply to comment #1) > The test passes here. Are you using --enable-shared-glapi? Try 'git clean > -fdx' > before building. No, I'm building with 'scons dri-r300'. 34a5d3b9f4740601708c82093e2114356d749e65 is the first bad commit commit 34a5d3b9f4740601708c82093e2114356d749e65 Author: Brian Paul Date: Sun Apr 10 12:48:28 2011 -0600 mesa: plug in new functions for GL_ARB_sampler_objects Build the new sources, plug the new functions into the dispatch table, implement display list support. And enable extension in the gallium state tracker. :04 04 50d8747e0dc22e1634407703563447bd0e1c44d3 be44081fa9ea33563f8582df370cfb13a0d5c256 Msrc bisect run success -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 33825] [r600g, wine] sync/fenc GL extension missing
https://bugs.freedesktop.org/show_bug.cgi?id=33825 Tobias Jakobi changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[PATCH] Big endian support for RV730 (Gallium r600g)
[ Moving to the mesa-dev list ]
On Fre, 2011-04-15 at 18:20 +0200, C?dric Cano wrote:
>
> Here you are a patch that adds big endian support for rv730 in r600
> gallium driver.
>
> I used the mesa-demos to test the driver status on big endian platform.
> Except with demos using accumulation buffer, the rendering is the same
> as on Intel platform. Albeit there are still some artefacts with some
> demos.
>
> I manage to fix accumulation buffer demos but then, glReadPixels demos
> won't work. I still can figure out (like with r600c) what and when I
> must enable swap. It will depends on object's domains. That's what I
> tried to do in r600_cb and r600_create_sampler_view.
That's probably because it hasn't been fully thought through yet how to
deal with big endian CPUs vs. little endian GPUs in Gallium. When this
was discussed previously, the basic rule decided was that all data
passed across the Gallium driver interface was supposed to be little
endian. That should probably be feasible in general for at least
'standard' pixel formats, but I'm afraid it doesn't really work for
vertex data[0], which could be fed from the application (which will use
CPU native byte order) to the GPU more or less directly.
Maybe byte order should be handled explicitly by the Gallium format
definitions, and then it would be up to the state tracker to use the
appropriate byte order formats. Jos?, have you had any further thoughts
on this?
[0] Though there might also be ambiguities e.g. with multi-byte
component pixel formats: Does the little endian rule apply to the pixel
value as a whole, or only for each component?
> @@ -266,11 +268,31 @@ void r600_upload_const_buffer(struct r600_pipe_context
> *rctx, struct r600_resour
> uint8_t *ptr = (*rbuffer)->r.b.user_ptr;
> unsigned size = (*rbuffer)->r.b.b.b.width0;
> boolean flushed;
> +#ifdef PIPE_ARCH_BIG_ENDIAN
> + int i;
> + uint32_t *tmpPtr;
> +
> + *rbuffer = NULL;
> +
> + tmpPtr = (uint32_t *)malloc(size);
> + /* big endian swap */
> + if(tmpPtr == NULL) {
> + return;
> + }
> + for(i = 0; i < size / 4; i++) {
> + tmpPtr[i] = bswap_32(*((uint32_t *)ptr + i));
> + }
> +
> + u_upload_data(rctx->vbuf_mgr->uploader, 0, size, tmpPtr,
> const_offset,
> + (struct pipe_resource**)rbuffer, &flushed);
Might be better to add a helper like u_upload_data_to_le32().
--
Earthling Michel D?nzer |http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
[PATCH] fix mesa tarball creation again
On 04/19/2011 03:04 AM, Thierry Vignaud wrote: > On 18 April 2011 01:27, Marek Ol??k wrote: >> Pushed, thanks. > > Can you know commit this one that fixes missing files in the generated tarball > so that one can build mesa out of the tarball? > Thx I'll commit it soon. Thanks. There's a few other files missing, like SConscript files that I need to add too... -Brian
[Bug 36403] [r300g] glean vertattrib regression
https://bugs.freedesktop.org/show_bug.cgi?id=36403 --- Comment #3 from Marek Ol??k 2011-04-19 23:43:39 PDT --- Tried the scons build and it works too. $ LIBGL_DRIVERS_PATH=[snip]/mesa/build/linux-x86-debug/gallium/targets/dri-r300 bin/glean -r results -t vertattrib --quick -o [snip] vertattrib: PASS rgba8, db, z24, s8, win+pmap, id 33 0 GL_NV_vertex_program functions tested 36 GL_ARB_vertex_program/shader functions tested 36 OpenGL 2.0 functions tested -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
