[edk2-devel] [PATCH v1] Pyrite support - Secure erase is only available if encryption is supported.
From: Linus Liu
https://bugzilla.tianocore.org/show_bug.cgi?id=3004
Cc: Qi Zhang
Cc: Rahul Kumar
Cc: Jiewen Yao
---
SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
index e2e77cbc24..88650a28dc 100644
--- a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
+++ b/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
@@ -87,7 +87,9 @@ OpalSupportGetAvailableActions (
// Secure erase is performed by generating a new encryption key
// this is only available if encryption is supported
//
-AvalDiskActions->SecureErase = 1;
+if (SupportedAttributes->MediaEncryption) {
+ AvalDiskActions->SecureErase = 1;
+}
} else {
AvalDiskActions->PsidRevert = 0;
AvalDiskActions->SecureErase = 0;
--
2.39.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108253): https://edk2.groups.io/g/devel/message/108253
Mute This Topic: https://groups.io/mt/101144585/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 05/10] CryptoPkg: Add RSA functions based on Mbedtls
TestPublicExponent[] is same as default value so this test is nonsense.
Please use a different value to generate key and use RsaGetKey to confirm PE is
same as expect.
-Original Message-
From: Hou, Wenxing
Sent: Saturday, September 2, 2023 10:16 PM
To: devel@edk2.groups.io
Cc: Yao, Jiewen ; Li, Yi1 ; Lu, Xiaoyu1
; Jiang, Guomin
Subject: [PATCH v2 05/10] CryptoPkg: Add RSA functions based on Mbedtls
Add RSA APIs.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
Cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
.../BaseCryptLibMbedTls/InternalCryptLib.h| 44 +++
.../BaseCryptLibMbedTls/Pk/CryptRsaBasic.c| 268 ++
.../Pk/CryptRsaBasicNull.c| 121 +++
.../BaseCryptLibMbedTls/Pk/CryptRsaExt.c | 333 ++
.../BaseCryptLibMbedTls/Pk/CryptRsaExtNull.c | 117 ++
.../BaseCryptLibMbedTls/Pk/CryptRsaPss.c | 164 +
.../BaseCryptLibMbedTls/Pk/CryptRsaPssNull.c | 46 +++
.../BaseCryptLibMbedTls/Pk/CryptRsaPssSign.c | 231
.../Pk/CryptRsaPssSignNull.c | 60
.../UnitTest/Library/BaseCryptLib/RsaTests.c | 4 +
10 files changed, 1388 insertions(+)
create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/InternalCryptLib.h
create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaBasic.c
create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaBasicNull.c
create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaExt.c
create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaExtNull.c
create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaPss.c
create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaPssNull.c
create mode 100644 CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaPssSign.c
create mode 100644
CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaPssSignNull.c
diff --git a/CryptoPkg/Library/BaseCryptLibMbedTls/InternalCryptLib.h
b/CryptoPkg/Library/BaseCryptLibMbedTls/InternalCryptLib.h
new file mode 100644
index 00..3e56c9a75c
--- /dev/null
+++ b/CryptoPkg/Library/BaseCryptLibMbedTls/InternalCryptLib.h
@@ -0,0 +1,44 @@
+/** @file+ Internal include file for BaseCryptLib.++Copyright (c) 2023, Intel
Corporation. All rights reserved.+SPDX-License-Identifier:
BSD-2-Clause-Patent++**/++#ifndef INTERNAL_CRYPT_LIB_H_+#define
INTERNAL_CRYPT_LIB_H_++#include +#include
+#include +#include
+#include +#include
++//+// We should alwasy add mbedtls/config.h here+// to ensure the
config override takes effect.+//+#include ++/**+ The
MbedTLS function f_rng, which MbedRand implements, is not+ documented well.++
@param[in] RngState RngState.+ @param[in] OutputOutput.+
@param[in] Len Len.++ @retval 0 success.+
@retval non-zero failed.++**/+INT32+MbedRand (+ VOID *RngState,+
UINT8 *OutPut,+ UINTN Len+ );++#endifdiff --git
a/CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaBasic.c
b/CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaBasic.c
new file mode 100644
index 00..05c2cbd25a
--- /dev/null
+++ b/CryptoPkg/Library/BaseCryptLibMbedTls/Pk/CryptRsaBasic.c
@@ -0,0 +1,268 @@
+/** @file+ RSA Asymmetric Cipher Wrapper Implementation over MbedTLS.++ This
file implements following APIs which provide basic capabilities for RSA:+ 1)
RsaNew+ 2) RsaFree+ 3) RsaSetKey+ 4) RsaPkcs1Verify++ RFC 8017 - PKCS #1:
RSA Cryptography Specifications Version 2.2++Copyright (c) 2023, Intel
Corporation. All rights reserved.+SPDX-License-Identifier:
BSD-2-Clause-Patent++**/++#include "InternalCryptLib.h"++#include
++/**+ Allocates and initializes one RSA context for subsequent
use.++ @return Pointer to the RSA context that has been initialized.+
If the allocations fails, RsaNew() returns NULL.++**/+VOID *+EFIAPI+RsaNew (+
VOID+ )+{+ VOID *RsaContext;++ RsaContext = AllocateZeroPool (sizeof
(mbedtls_rsa_context));+ if (RsaContext == NULL) {+return RsaContext;+
}++ mbedtls_rsa_init (RsaContext);+ if (mbedtls_rsa_set_padding (RsaContext,
MBEDTLS_RSA_PKCS_V15, MBEDTLS_MD_NONE) != 0) {+return NULL;+ }++ return
RsaContext;+}++/**+ Release the specified RSA context.++ @param[in]
RsaContext Pointer to the RSA context to be released.++**/+VOID+EFIAPI+RsaFree
(+ IN VOID *RsaContext+ )+{+ mbedtls_rsa_free (RsaContext);+ if
(RsaContext != NULL) {+FreePool (RsaContext);+ }+}++/**+ Sets the
tag-designated key component into the established RSA context.++ This function
sets the tag-designated RSA key component into the established+ RSA context
from the user-specified non-negative integer (octet string format+ represented
in RSA PKCS#1).+ If BigNumber is NULL, then the specified key component in RSA
context is cleared.++ If RsaContext is NULL, then return FALSE.++ @param[in,
out] RsaContext Pointer to RSA context being set.+ @para
Re: [edk2-devel] [PATCH v2 09/10] CryptoPkg: Add Mbedtls submodule in CI
Skip those files in DscCompleteCheck is workaround IMO, I think we can add all
mbedtls libraries and components to CryptoPkg.dsc with new CRYPTO_SERVICES.
-Original Message-
From: Hou, Wenxing
Sent: Saturday, September 2, 2023 10:16 PM
To: devel@edk2.groups.io
Cc: Yao, Jiewen ; Li, Yi1 ; Lu, Xiaoyu1
; Jiang, Guomin
Subject: [PATCH v2 09/10] CryptoPkg: Add Mbedtls submodule in CI
Change CI for new Mbedtls submodule.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4177
Cc: Jiewen Yao
Cc: Yi Li
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
.pytool/CISettings.py | 2 ++
CryptoPkg/CryptoPkg.ci.yaml | 66 +++--
2 files changed, 65 insertions(+), 3 deletions(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index
6fb7342f81..c5803a877c 100644
--- a/.pytool/CISettings.py
+++ b/.pytool/CISettings.py
@@ -199,6 +199,8 @@ class Settings(CiBuildSettingsManager,
UpdateSettingsManager, SetupSettingsManag
"MdePkg/Library/BaseFdtLib/libfdt", False))
rs.append(RequiredSubmodule( "MdePkg/Library/MipiSysTLib/mipisyst",
False))+rs.append(RequiredSubmodule(+
"CryptoPkg/Library/MbedTlsLib/mbedtls", False)) return rs def
GetName(self):diff --git a/CryptoPkg/CryptoPkg.ci.yaml
b/CryptoPkg/CryptoPkg.ci.yaml
index 59ba56d41e..204b97f470 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -41,7 +41,14 @@
# These directories contain auto-generated OpenSSL content
"Library/OpensslLib", "Library/IntrinsicLib",-
"Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c"+
"Library/BaseCryptLib/Pk/CryptPkcs7VerifyBase.c",+# mbedtls+
"Library/MbedTlsLib/mbedtls",+# This has mbedtls interfaces
that aren't UEFI spec compliant+"Library/MbedTlsLib/EcSm2Null.c",+
"Library/MbedTlsLib/CrtWrapper.c",+
"Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h",+
"Library/BaseCryptLibMbedTls/SysCall" ] }, "CompilerPlugin":
{@@ -68,7 +75,16 @@
}, "DscCompleteCheck": { "DscPath": "CryptoPkg.dsc",-
"IgnoreInf": []+"IgnoreInf": [+
"CryptoPkg/Library/BaseCryptLibMbedTls/BaseCryptLib.inf",+
"CryptoPkg/Library/BaseCryptLibMbedTls/PeiCryptLib.inf",+
"CryptoPkg/Library/BaseCryptLibMbedTls/RuntimeCryptLib.inf",+
"CryptoPkg/Library/BaseCryptLibMbedTls/SecCryptLib.inf",+
"CryptoPkg/Library/BaseCryptLibMbedTls/SmmCryptLib.inf",+
"CryptoPkg/Library/BaseCryptLibMbedTls/TestBaseCryptLib.inf",+
"CryptoPkg/Library/MbedTlsLib/MbedTlsLib.inf",+
"CryptoPkg/Library/MbedTlsLib/MbedTlsLibFull.inf"+] },
"GuidCheck": { "IgnoreGuidName": [],@@ -76,7 +92,51 @@
"IgnoreFoldersAndFiles": [] }, "LibraryClassCheck": {-
"IgnoreHeaderFile": []+"IgnoreHeaderFile": [+
"Library/MbedTlsLib/mbedtls/Library/aesni.h",+
"Library/MbedTlsLib/mbedtls/Library/bignum_core.h",+
"Library/MbedTlsLib/mbedtls/Library/bignum_mod.h",+
"Library/MbedTlsLib/mbedtls/Library/bignum_mod_raw.h",+
"Library/MbedTlsLib/mbedtls/Library/bn_mul.h",+
"Library/MbedTlsLib/mbedtls/Library/check_crypto_config.h",+
"Library/MbedTlsLib/mbedtls/Library/cipher_wrap.h",+
"Library/MbedTlsLib/mbedtls/Library/common.h",+
"Library/MbedTlsLib/mbedtls/Library/constant_time_internal.h",+
"Library/MbedTlsLib/mbedtls/Library/constant_time_invasive.h",+
"Library/MbedTlsLib/mbedtls/Library/ecp_internal_alt.h",+
"Library/MbedTlsLib/mbedtls/Library/ecp_invasive.h",+
"Library/MbedTlsLib/mbedtls/Library/entropy_poll.h",+
"Library/MbedTlsLib/mbedtls/Library/hash_info.h",+
"Library/MbedTlsLib/mbedtls/Library/lmots.h",+
"Library/MbedTlsLib/mbedtls/Library/md_wrap.h",+
"Library/MbedTlsLib/mbedtls/Library/mps_common.h",+
"Library/MbedTlsLib/mbedtls/Library/mps_error.h",+
"Library/MbedTlsLib/mbedtls/Library/mps_reader.h",+
"Library/MbedTlsLib/mbedtls/Library/mps_trace.h",+
"Library/MbedTlsLib/mbedtls/Library/padlock.h",+
"Library/MbedTlsLib/mbedtls/Library/pkwrite.h",+
"Library/MbedTlsLib/mbedtls/Library/pk_wrap.h",+
"Library/MbedTlsLib/mbedtls/Library/psa_crypto_aead.h",+
"Library/MbedTlsLib/mbedtls/Library/psa_crypto_cipher.h",+
"Library/MbedTlsLib/mbedtls/Library/psa_crypto_driver_wrappers.h",+
"Library/MbedTlsLib/mbedtls/Library/psa_crypto_ecp.h",+
"Library/MbedTlsLib/mbedtls/Library/psa_crypto_hash.h",+
"Library/MbedTlsLib/mbedtls/Library/psa_crypto_invasive.h",+
"Library
Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy
On Thu, Aug 31, 2023 at 06:01:56PM +0200, Ard Biesheuvel wrote: > On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel wrote: > > > > On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > I have tried the patch below, and I don't see any slowdowns with or > > > > without the patch, running both DEBUG and RELEASE builds under > > > > ordinary KVM/nested-virt. Note that the change in the first hunk will > > > > cause the ASSERT()s removed in the other hunks to trigger so the code > > > > is definitely being exercised. > > > > > > QE team tested again with fresh builds, the slowdown isn't there any > > > more. Not fully clear where it came from, but most likely not from > > > this patch. > > > > > > Only 20 successful test runs so far, which a good start, but with > > > a reproduce rate below 20% not that much.I'll post an update > > > when it I get more results. > > > > > > > Excellent, thanks for the update. > > Given that the QE engineer appears to have lost interest, I intend to > merge this patch as-is unless anyone feels this is premature. I was offline a few days. QE actually reported back: 100 test runs without problems. Tested-by: Gerd Hoffmann Acked-by: Gerd Hoffmann take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108256): https://edk2.groups.io/g/devel/message/108256 Mute This Topic: https://groups.io/mt/100256049/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy
On Mon, 4 Sept 2023 at 13:45, Gerd Hoffmann wrote: > > On Thu, Aug 31, 2023 at 06:01:56PM +0200, Ard Biesheuvel wrote: > > On Mon, 28 Aug 2023 at 13:13, Ard Biesheuvel wrote: > > > > > > On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote: > > > > > > > > Hi, > > > > > > > > > I have tried the patch below, and I don't see any slowdowns with or > > > > > without the patch, running both DEBUG and RELEASE builds under > > > > > ordinary KVM/nested-virt. Note that the change in the first hunk will > > > > > cause the ASSERT()s removed in the other hunks to trigger so the code > > > > > is definitely being exercised. > > > > > > > > QE team tested again with fresh builds, the slowdown isn't there any > > > > more. Not fully clear where it came from, but most likely not from > > > > this patch. > > > > > > > > Only 20 successful test runs so far, which a good start, but with > > > > a reproduce rate below 20% not that much.I'll post an update > > > > when it I get more results. > > > > > > > > > > Excellent, thanks for the update. > > > > Given that the QE engineer appears to have lost interest, I intend to > > merge this patch as-is unless anyone feels this is premature. > > I was offline a few days. QE actually reported back: 100 test runs > without problems. > > Tested-by: Gerd Hoffmann > Acked-by: Gerd Hoffmann > Thanks for reporting back. This is merged now. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108257): https://edk2.groups.io/g/devel/message/108257 Mute This Topic: https://groups.io/mt/100256049/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v6 0/9] SecurityPkg/MdePkg: Update RngLib GUID identification
Hi All, This patch series implements code first USWG ECR 2386 (https://mantis.uefi.org/mantis/view.php?id=2386) and also fixes other issues to enable RNG support on Arm. The RNG implementation for Arm is broken without this series on some platforms. If there are no further comments by end of this week, I plan to merge this series along with https://edk2.groups.io/g/devel/topic/99863881#106547 Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108258): https://edk2.groups.io/g/devel/message/108258 Mute This Topic: https://groups.io/mt/100684678/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI
Hi Yuquan, On Mon, Sep 04, 2023 at 14:30:57 +0800, Yuquan Wang wrote: > Hi, Leif > On 2023-08-31 21:06, Leif wrote: > > I had to move one hunk (.dec change) from 2/3 to 1/3 in order to > not break bisect. > > If you're happy with the slightly modified version, I think this > is good to go in. Please let me know. > > > It' ok. > > In the second version of this series patches, in fact, I have moved the .dec > change into > 1/3. > > It is my fault that I forgot to add "Cc" to Ard, Leif and Graeme in my latest > version > of "xhci" patches. > The link is: https://edk2.groups.io/g/devel/message/106729 Understood, thanks. However, this version still breaks bisect: attempting to build at 1/3 or 2/3 leads to: --- /work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf(72): error 3000: PCD [gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlatformEhciBase] in [/work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf] is not found in dependent packages: --- Also, I think Ard's comments on the ACPI changes still apply. Do you have a comment on that? Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108259): https://edk2.groups.io/g/devel/message/108259 Mute This Topic: https://groups.io/mt/101073211/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU
> -Original Message- > From: Rebecca Cran > Sent: Wednesday, February 8, 2023 6:02 PM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Ard Biesheuvel > ; Jiewen Yao ; Jordan Justen > ; Gerd Hoffmann > Subject: [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then > running QEMU > > Allow users to build OVMF then run QEMU by moving the build block above > the run block and removing the exit line. > > Signed-off-by: Rebecca Cran > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > --- > OvmfPkg/build.sh | 13 + > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh > index 91b1442ade6b..b0334fb76e74 100755 > --- a/OvmfPkg/build.sh > +++ b/OvmfPkg/build.sh > @@ -245,6 +245,11 @@ else >echo using prebuilt tools > fi > > +# > +# Build the edk2 OvmfPkg > +# > +echo Running edk2 build for OvmfPkg$Processor > +build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n > $THREADNUMBER -DDEBUG_ON_SERIAL_PORT=TRUE > > if [[ "$RUN_QEMU" == "yes" ]]; then >if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then > @@ -260,11 +265,3 @@ if [[ "$RUN_QEMU" == "yes" ]]; then >$QEMU_COMMAND "$@" >exit $? > fi > - > -# > -# Build the edk2 OvmfPkg > -# > -echo Running edk2 build for OvmfPkg$Processor > -build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n > $THREADNUMBER > -exit $? > - > -- > 2.30.2 Hi, I was trying to raise the issue that I believe this change from Feb. of this year breaks intended and useful previous behaviour. It occurred to me that replying to the original post might make most sense. I've raised what I think are the issues here: https://bugzilla.tianocore.org/show_bug.cgi?id=4528 . WIth many thanks in advance for your attention. Mike Beaton -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108260): https://edk2.groups.io/g/devel/message/108260 Mute This Topic: https://groups.io/mt/96836052/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v6 0/9] SecurityPkg/MdePkg: Update RngLib GUID identification
In case the message didn't reach the relevant maintainers: On 9/4/23 15:01, Sami Mujawar wrote: Hi All, This patch series implements code first USWG ECR 2386 (https://mantis.uefi.org/mantis/view.php?id=2386) and also fixes other issues to enable RNG support on Arm. The RNG implementation for Arm is broken without this series on some platforms. If there are no further comments by end of this week, I plan to merge this series along with https://edk2.groups.io/g/devel/topic/99863881#106547 Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108261): https://edk2.groups.io/g/devel/message/108261 Mute This Topic: https://groups.io/mt/100684678/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/8] EDK2 on RISC-V Sophgo SG2042 platform
Hi Yuqing (?), Thank you for this contribution. I have a few high-level comments, but I will also look into the individual patches and comment if I find things I feel will make the port easier to maintain. 1) Git If it is possible for you to push these patches to some public git tree, that makes it easier for us to deal with the binary files (the .png files in 8/8). If you do so, you can add a link to the branch in the 0/8 blurb On Thu, Aug 31, 2023 at 21:44:16 +0800, caiyuqing...@163.com wrote: > From: caiyuqing379 <202235...@mail.sdu.edu.cn> > > Signed-off-by: caiyuqing379 <202235...@mail.sdu.edu.cn> > Co-authored-by: USER0FISH > Cc: dahogn > Cc: meng-cz > Cc: yli147 > Cc: ChaiEvan > Cc: Sunil V L > > *** BLURB HERE *** 2) Blurb It would be nice if the blurb could be replaced by a small description of what is being contributed, and why. For example, some quick searching on the Internet tells me that the SoC in question is the same as will be in the Milk-V Pioneer board. Is the EVB compatible with the Pioneer board? If not, are you planning to add support for the Pioneer board later? 3) Layout The layout of this port does not follow the usual pattern for edk2 platform ports. We split SoC support (Silicon/) apart from platform port (Platform/). Superficially, it looks like it would make sense to move most of the current port from Platform/Sophgo/SG2042Pkg/ to Silicon/Sophgo/SG2042Pkg/ except for Platform/Sophgo/SG2042Pkg/SG2042_EVB_Board/ which would make sense to keep under Platform/ as Platform/Sophgo/SG2042_EVB_Board/ (Knowing what the plan is for future work would also help us to provide useful giudance.) 4) Clang toolchain support I attempted to build the port using the CLANGDWARF toolchain profile. This leads to the same problem as described by https://www.mail-archive.com/devel@edk2.groups.io/msg61953.html and the same solution makes the build succeed. (I don't know if the resulting build *works*.) Best Regards, Leif > caiyuqing379 (8): > Sophgo/SG2042Pkg: Add SmbiosPlatformDxe module. > Sophgo/SG2042Pkg: Add PlatformUpdateMmuDxe module. > Sophgo/SG2042Pkg: Add Sophgo SDHCI driver. > Sophgo/SG2042Pkg: Add base MMC driver. > Sophgo/SG2042Pkg: Add SEC module. > SG2042Pkg/SG2042_EVB_Board: Add Sophgo SG2042 platform. > Sophgo/SG2042Pkg: Add SG2042Pkg. > Sophgo/SG2042Pkg: Add platform readme and document. > > Platform/Sophgo/SG2042Pkg/SG2042Pkg.dec | 35 + > .../SG2042Pkg/SG2042_EVB_Board/SG2042.dec | 19 + > .../SG2042Pkg/SG2042_EVB_Board/SG2042.dsc | 548 +++ > .../SG2042Pkg/SG2042_EVB_Board/SG2042.fdf | 247 + > Platform/Sophgo/SG2042Pkg/Sec/SecMain.inf | 68 ++ > .../SG2042Pkg/Universal/Dxe/MmcDxe/MmcDxe.inf | 46 + > .../PlatformUpdateMmuDxe.inf | 34 + > .../Universal/Dxe/SdHostDxe/SdHostDxe.inf | 47 + > .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 39 + > Platform/Sophgo/SG2042Pkg/Include/MmcHost.h | 225 + > Platform/Sophgo/SG2042Pkg/Sec/SecMain.h | 103 ++ > .../SG2042Pkg/Universal/Dxe/MmcDxe/Mmc.h | 513 ++ > .../SG2042Pkg/Universal/Dxe/SdHostDxe/SdHci.h | 309 ++ > Platform/Sophgo/SG2042Pkg/Sec/Cpu.c | 29 + > Platform/Sophgo/SG2042Pkg/Sec/Memory.c| 363 +++ > Platform/Sophgo/SG2042Pkg/Sec/Platform.c | 141 +++ > Platform/Sophgo/SG2042Pkg/Sec/SecMain.c | 116 +++ > .../Universal/Dxe/MmcDxe/ComponentName.c | 156 +++ > .../Universal/Dxe/MmcDxe/Diagnostics.c| 323 ++ > .../SG2042Pkg/Universal/Dxe/MmcDxe/Mmc.c | 527 ++ > .../Universal/Dxe/MmcDxe/MmcBlockIo.c | 643 > .../SG2042Pkg/Universal/Dxe/MmcDxe/MmcDebug.c | 194 > .../Universal/Dxe/MmcDxe/MmcIdentification.c | 719 ++ > .../PlatformUpdateMmuDxe.c| 591 +++ > .../SG2042Pkg/Universal/Dxe/SdHostDxe/SdHci.c | 929 ++ > .../Universal/Dxe/SdHostDxe/SdHostDxe.c | 450 + > .../Dxe/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 805 +++ > .../Sophgo/SG2042Pkg/About_Sophgo_platform.md | 39 + > .../Documents/Media/EDK2_SDU_Programme.png| Bin 0 -> 59830 bytes > .../SG2042Pkg/Documents/Media/SG2042_CPU.png | Bin 0 -> 806062 bytes > .../Documents/Media/Sophgo_SG2042_EVB.png | Bin 0 -> 1445528 bytes > Platform/Sophgo/SG2042Pkg/Maintainers.md | 107 ++ > Platform/Sophgo/SG2042Pkg/Readme.md | 79 ++ > Platform/Sophgo/SG2042Pkg/SG2042Pkg.uni | 13 + > Platform/Sophgo/SG2042Pkg/SG2042PkgExtra.uni | 12 + > .../SG2042Pkg/SG2042_EVB_Board/SG2042.fdf.inc | 62 ++ > .../SG2042_EVB_Board/VarStore.fdf.inc | 77 ++ > Platform/Sophgo/SG2042Pkg/Sec/SecEntry.S | 18 + > 38 files changed, 8626 insertions(+) > create mode 100644 Platform/Sophgo/SG2042Pkg/SG2042Pkg.dec > create mode 100644 Platform/Sophgo/SG2042Pkg/SG2042_EVB_Board/SG2042.dec > create mode 100644 Platform/Sophgo/SG2042Pkg/SG2042_EVB_Board/SG2042.dsc >
[edk2-devel] [PATCH v2 0/1] Drop ArmCpuInfo command
In June I sent patchset of improvements to ArmCpuInfo command. No one responded so I do not see sense in keeping it in EDK2. I created https://github.com/hrw/edk2-armcpuinfo to have a place to store final version. Will add information how to build it into README in repository. Changes since v2: - proper email address used to skip moderation queue Marcin Juszkiewicz (1): Revert "ArmPkg: add ArmCpuInfo EFI application" ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 2430 -- ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 31 - ArmPkg/ArmPkg.dsc|1 - 3 files changed, 2462 deletions(-) delete mode 100644 ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c delete mode 100644 ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf -- 2.41.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108263): https://edk2.groups.io/g/devel/message/108263 Mute This Topic: https://groups.io/mt/101153673/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 1/1] Revert "ArmPkg: add ArmCpuInfo EFI application"
I am moving this command outside of EDK2.
This reverts commit 2c2cb235289642775a7c4e6eaeffa6d3828d279c.
---
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 2430 --
ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 31 -
ArmPkg/ArmPkg.dsc|1 -
3 files changed, 2462 deletions(-)
delete mode 100644 ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c
delete mode 100644 ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf
diff --git a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c
b/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c
deleted file mode 100644
index deea90fbdf..00
--- a/ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c
+++ /dev/null
@@ -1,2430 +0,0 @@
-/** @file
- Application to present AArch64 cpu information.
-
- Based on ARM DDI 0487I.a. Update this information when the
- app is updated with features from subsequent releases.
-
-Copyright (c) 2023, Linaro Ltd. All rights reserved.
-
-SPDX-License-Identifier: BSD-2-Clause-Patent
-
-**/
-
-#include
-#include
-
-// We cannot assume GCC extensions to be present so let use
-// binary numbers via enum.
-// Arm ARM uses binary numbers so this way it is more readable.
-enum {
- b,
- b0001,
- b0010,
- b0011,
- b0100,
- b0101,
- b0110,
- b0111,
- b1000,
- b1001,
- b1010,
- b1011,
- b1100,
- b1101,
- b1110,
- b
-};
-
-/**
- Print formatted table line.
-
- Values can be empty if only new description line is needed.
-
- @param[in] Field name of system register
- @param[in] Bitsbits of system register
- @param[in] Value value of those bits
- @param[in] Description meaning of value
-**/
-VOID
-PrintText (
- CONST CHAR8 *Field,
- CONST CHAR8 *Bits,
- CONST CHAR8 *Value,
- CONST CHAR8 *Description
- )
-{
- AsciiPrint (" %-16a | %5a | %5a | %a\n", Field, Bits, Value, Description);
-}
-
-/**
- Print formatted table line with value printed in binary.
-
- @param[in] Field name of system register
- @param[in] Bitsbits of system register
- @param[in] Value value of those bits
- @param[in] Description meaning of value
-**/
-VOID
-PrintValues (
- CONST CHAR8 *Field,
- CONST CHAR8 *Bits,
- CONST UINT8 Value,
- CONST CHAR8 *Description
- )
-{
- STATIC CONST CHAR8 Nibbles[][5] = {
-"", "0001", "0010", "0011", "0100", "0101", "0110", "0111",
-"1000", "1001", "1010", "1011", "1100", "1101", "1110", ""
- };
-
- AsciiPrint (" %-16a | %5a | %5a | %a\n", Field, Bits, Nibbles[Value & 0xf],
Description);
-}
-
-/**
- Print spacer for results table.
-**/
-VOID
-PrintSpacer (
- VOID
- )
-{
- AsciiPrint
("--|---|---|--\n");
-}
-
-/**
- Handle ID_AA64DFR0_EL1 system register.
-
- @param[in] Aa64Dfr0 value of ID_AA64DFR0_EL1 system register
-**/
-VOID
-HandleAa64Dfr0 (
- CONST UINT64 Aa64Dfr0
- )
-{
- UINT64 Value;
- STATIC CONST CHAR8 RegName[] = "ID_AA64DFR0";
- CONST CHAR8 *Description;
- CONST CHAR8 *Bits;
-
- Bits = "3:0 ";
- Value = (Aa64Dfr0 >> 4) & 0xf;
- switch (Value) {
-case b0110:
- Description = "Armv8 debug architecture";
- break;
-case b0111:
- Description = "Armv8 debug architecture with VHE";
- break;
-case b1000:
- Description = "FEAT_Debugv8p2 implemented.";
- break;
-case b1001:
- Description = "FEAT_Debugv8p4 implemented.";
- break;
-case b1010:
- Description = "FEAT_Debugv8p8 implemented.";
- break;
-default:
- Description = "unknown";
- break;
- }
-
- PrintValues (RegName, Bits, Value, Description);
-
- Bits = "7:4 ";
- Value = (Aa64Dfr0 >> 4) & 0xf;
- switch (Value) {
-case b:
- Description = "Trace unit System registers not implemented.";
- break;
-case b0001:
- Description = "Trace unit System registers implemented.";
- break;
-default:
- Description = "unknown";
- break;
- }
-
- PrintValues (RegName, Bits, Value, Description);
-
- Bits = "11:8 ";
- Value = (Aa64Dfr0 >> 8) & 0xf;
- switch (Value) {
-case b:
- Description = "Performance Monitors Extension not implemented.";
- break;
-case b0001:
- Description = "FEAT_PMUv3 implemented.";
- break;
-case b0100:
- Description = "FEAT_PMUv3p1 implemented.";
- break;
-case b0101:
- Description = "FEAT_PMUv3p4 implemented.";
- break;
-case b0110:
- Description = "FEAT_PMUv3p5 implemented.";
- break;
-case b0111:
- Description = "FEAT_PMUv3p7 implemented.";
- break;
-case b1000:
- Description = "FEAT_PMUv3p8 implemented.";
- break;
-case b:
- Description = "IMPLEMENTATION DEFINED form of performance monitors
supported.";
- break;
-default:
- Description = "unknown";
- break;
- }
-
- PrintValues (RegName, Bits, Value, Description);
-
- Bits = "15:12";
- Value = (Aa64Dfr0 >> 12) & 0x
Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU
Sorry I've not responded to your emails before now. I don't normally use the build.sh script, so I'm fine with reverting to the previous behavior. -- Rebecca Cran On 9/4/23 08:24, Mike Beaton wrote: -Original Message- From: Rebecca Cran Sent: Wednesday, February 8, 2023 6:02 PM To: devel@edk2.groups.io Cc: Rebecca Cran ; Ard Biesheuvel ; Jiewen Yao ; Jordan Justen ; Gerd Hoffmann Subject: [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU Allow users to build OVMF then run QEMU by moving the build block above the run block and removing the exit line. Signed-off-by: Rebecca Cran Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann --- OvmfPkg/build.sh | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh index 91b1442ade6b..b0334fb76e74 100755 --- a/OvmfPkg/build.sh +++ b/OvmfPkg/build.sh @@ -245,6 +245,11 @@ else echo using prebuilt tools fi +# +# Build the edk2 OvmfPkg +# +echo Running edk2 build for OvmfPkg$Processor +build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER -DDEBUG_ON_SERIAL_PORT=TRUE if [[ "$RUN_QEMU" == "yes" ]]; then if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then @@ -260,11 +265,3 @@ if [[ "$RUN_QEMU" == "yes" ]]; then $QEMU_COMMAND "$@" exit $? fi - -# -# Build the edk2 OvmfPkg -# -echo Running edk2 build for OvmfPkg$Processor -build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n $THREADNUMBER -exit $? - -- 2.30.2 Hi, I was trying to raise the issue that I believe this change from Feb. of this year breaks intended and useful previous behaviour. It occurred to me that replying to the original post might make most sense. I've raised what I think are the issues here: https://bugzilla.tianocore.org/show_bug.cgi?id=4528 . WIth many thanks in advance for your attention. Mike Beaton -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108265): https://edk2.groups.io/g/devel/message/108265 Mute This Topic: https://groups.io/mt/96836052/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, September 4, 2023 #cal-reminder
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, September 4, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-41af-91ab-2d7cd011db47%22%2c%22Oid%22%3a%2223af6561-6e1c-450d-b917-d9d674eb3cb6%22%7d View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=2012899 ) *Description:* TianoCore community, Microsoft and Intel will be hosting a series of open meetings to discuss build, CI, tools, and other related topics. If you are interested, have ideas/opinions please join us. These meetings will be Monday 4:30pm Pacific Time on Microsoft Teams. MS Teams Link in following discussion: * https://github.com/tianocore/edk2/discussions/2614 Anyone is welcome to join. * tianocore/edk2: EDK II (github.com) * tianocore/edk2-basetools: EDK II BaseTools Python tools as a PIP module (github.com) https://github.com/tianocore/edk2-basetools * tianocore/edk2-pytool-extensions: Extensions to the edk2 build system allowing for a more robust and plugin based build system and tool execution environment (github.com) https://github.com/tianocore/edk2-pytool-extensions * tianocore/edk2-pytool-library: Python library package that supports UEFI development (github.com) https://github.com/tianocore/edk2-pytool-library MS Teams Browser Clients * https://docs.microsoft.com/en-us/microsoftteams/get-clients?tabs=Windows#browser-client -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108266): https://edk2.groups.io/g/devel/message/108266 Mute This Topic: https://groups.io/mt/101139575/21656 Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, September 4, 2023 #cal-notice
*Tools, CI, Code base construction meeting series* *When:* Monday, September 4, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-41af-91ab-2d7cd011db47%22%2c%22Oid%22%3a%2223af6561-6e1c-450d-b917-d9d674eb3cb6%22%7d View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=2012899 ) *Description:* TianoCore community, Microsoft and Intel will be hosting a series of open meetings to discuss build, CI, tools, and other related topics. If you are interested, have ideas/opinions please join us. These meetings will be Monday 4:30pm Pacific Time on Microsoft Teams. MS Teams Link in following discussion: * https://github.com/tianocore/edk2/discussions/2614 Anyone is welcome to join. * tianocore/edk2: EDK II (github.com) * tianocore/edk2-basetools: EDK II BaseTools Python tools as a PIP module (github.com) https://github.com/tianocore/edk2-basetools * tianocore/edk2-pytool-extensions: Extensions to the edk2 build system allowing for a more robust and plugin based build system and tool execution environment (github.com) https://github.com/tianocore/edk2-pytool-extensions * tianocore/edk2-pytool-library: Python library package that supports UEFI development (github.com) https://github.com/tianocore/edk2-pytool-library MS Teams Browser Clients * https://docs.microsoft.com/en-us/microsoftteams/get-clients?tabs=Windows#browser-client -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108267): https://edk2.groups.io/g/devel/message/108267 Mute This Topic: https://groups.io/mt/101159426/21656 Mute #cal-notice:https://edk2.groups.io/g/devel/mutehashtag/cal-notice Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, September 5, 2023 #cal-reminder
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, September 5, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%226e4ce4c4-1242-431b-9a51-92cd01a5df3c%22%7d *Organizer:* Liming Gao gaolim...@byosoft.com.cn ( gaolim...@byosoft.com.cn?subject=Re:%20Event:%20TianoCore%20Bug%20Triage%20-%20APAC%20%2F%20NAMO ) View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=2012897 ) *Description:* TianoCore Bug Triage - APAC / NAMO Hosted by Liming Gao Microsoft Teams meeting *Join on your computer or mobile app* Click here to join the meeting ( https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%226e4ce4c4-1242-431b-9a51-92cd01a5df3c%22%7d ) *Join with a video conferencing device* te...@conf.intel.com Video Conference ID: 116 062 094 0 Alternate VTC dialing instructions ( https://conf.intel.com/teams/?conf=1160620940&ivr=teams&d=conf.intel.com&test=test_call ) *Or call in (audio only)* +1 916-245-6934,,77463821# ( tel:+19162456934,,77463821# ) United States, Sacramento Phone Conference ID: 774 638 21# Find a local number ( https://dialin.teams.microsoft.com/d195d438-2daa-420e-b9ea-da26f9d1d6d5?id=77463821 ) | Reset PIN ( https://mysettings.lync.com/pstnconferencing ) Learn More ( https://aka.ms/JoinTeamsMeeting ) | Meeting options ( https://teams.microsoft.com/meetingOptions/?organizerId=b286b53a-1218-4db3-bfc9-3d4c5aa7669e&tenantId=46c98d88-e344-4ed4-8496-4ed7712e255d&threadId=19_meeting_OTUyZTg2NjgtNDhlNS00ODVlLTllYTUtYzg1OTNjNjdiZjFh@thread.v2&messageId=0&language=en-US ) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108268): https://edk2.groups.io/g/devel/message/108268 Mute This Topic: https://groups.io/mt/101161403/21656 Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue
Hi Oliver, thank you for taking a look at this patch. On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote: On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote: Hi Ard, Thanks for your response on this patch. Please see my reply inline... On 8/30/2023 8:10 PM, Ard Biesheuvel wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.] On Wed, 16 Aug 2023 at 10:56, Nhi Pham wrote: Hi Ard and Ming, I have been seeing an issue with StandaloneMM HobLib that can be fixed by this patch as well. The function CreateHob() in the HobLib instance StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf does not work at all. The HobList is early created by the StandaloneMmCoreEntryPoint then it is relocated on the heap memory by StandaloneMmCore. But the FreeMemoryTop and FreeMemoryBottom are not updated accordingly and the HOB free memory top is overlapped with the heap space. This causes the CreateHob() function to not work as expected. Introducing the PcdMemoryHobSize is reasonable to fix this issue. I tested this patch in my end. Tested-by: Nhi Pham Thanks for reminding me. So if the HOB creation is completely broken, are we sure this is the correct fix? Wouldn't it be better to update FreeMemoryTop and FreeMemoryBottom to the correct values? Per your question, I had a deep dive into the HOB today. I think I need to clarify further the issue to make sure that we are on the same page. 1. When the base of the HOB list (HobStart) is reallocated in the MM heap memory, the Hob->EfiEndOfHobList must be adjusted accordingly compared to the new HOB base. Currently, we are missing that. That causes the CreateHob() function does not work. The GetNextHob() function always look up the old HOB list instead of the new HOB list. 2. The Memory Allocation StandaloneMmPkg/Core/Page.c does not update the Hob->EfiFreeMemoryTop, this may cause the MM heap space and HOB space to be overlapped at some points. It sounds like the issue on the memory allocation in StandaloneMM. For #1, I think we should write a new patch for it. For #2, could you advise? If I am understanding this correctly, this is only an issue when HOBs are created in StMM, i.e. not from HOBs that are passed in. Is this correct? Yes, the issue only occurs when HOB are created in StandaloneMM by the HOB library instance StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf If so, is HOB creation in StMM and supported use case? The only instance I think it is intended to work as the CreateHob() function is implemented. a quick search turns up is the ARM StMM Core entry, where some information from TF-A is converted to HOB format. Do we have any other use cases (and curious more on this use case). My thought process would be that StMM would not create any HOBs. Depending on FW configuration, it may receive HOBs from PEI. I have a use case when enabling the UEFI Variable driver running in StandaloneMM. Instead of using the PCDs, the in-memory NVRAM region is allocated **dynamically** at boot time in the StMM secure memory. Then, they will be passed into the gVariableFlashInfoHobGuid for being consumed by other variable MM drivers. In PEI/DXE to StMM communication, we should be using the MM_Communicate interface. But in StMM to StMM communication, I would expect we would go through interfaces like protocols, PCDs, or UEFI variables. Any reason for HOBs that I'm not thinking of? I'm wondering if the answer here is to address what seemingly is one (or a very small set) of use cases and remove the HOB creation code in StMM altogether. Thanks, Oliver -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108269): https://edk2.groups.io/g/devel/message/108269 Mute This Topic: https://groups.io/mt/89020085/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
Avi:
The change is good. Reviewed-by: Liming Gao
But, I have one minor comment. Please see below.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Avinash
> 发送时间: 2023年9月2日 2:21
> 收件人: devel@edk2.groups.io
> 抄送: avinashbhargava ; Zhiguang Liu
> ; Dandan Bi ; Star Zeng
> ; Zhichao Gao
> 主题: [edk2-devel] [PATCH v1 1/1]
> MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family
> for SMBIOS Type 4 from SMBIOS 3.7.0
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4547
>
> Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
> Hex value - 16h
> Name - Intel® Processor
[Liming] Please remove non ascii char ® in the commit message.
Thanks
Liming
>
> Signed-off-by: avinashbhargava
> Cc: Zhiguang Liu
> Cc: Dandan Bi
> Cc: Star Zeng
> Cc: Zhichao Gao
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 40bdc9a937c0..56cec615a010 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -554,6 +554,7 @@ typedef enum {
>ProcessorFamilyM2 = 0x13,
>
>ProcessorFamilyIntelCeleronM = 0x14,
>
>ProcessorFamilyIntelPentium4Ht = 0x15,
>
> + ProcessorFamilyIntel = 0x16,
>
>ProcessorFamilyAmdDuron= 0x18,
>
>ProcessorFamilyK5 = 0x19,
>
>ProcessorFamilyK6 = 0x1A,
>
> --
> 2.37.3.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108270): https://edk2.groups.io/g/devel/message/108270
Mute This Topic: https://groups.io/mt/101162131/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [Patch V2] MdeModulePkg/DxeCorePerformanceLib:fix smm perf issue
The change is good to me. Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 duntan
> 发送时间: 2023年9月1日 12:07
> 收件人: devel@edk2.groups.io; Tan, Dun
> 抄送: Wang, Jian J ; Gao, Liming
> ; Ni, Ray
> 主题: Re: [edk2-devel] [Patch V2]
> MdeModulePkg/DxeCorePerformanceLib:fix smm perf issue
>
> Hi Jian and Liming,
>
> Could you please help to review this patch?
>
> Thanks,
> Dun
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of duntan
> Sent: Wednesday, August 30, 2023 3:36 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Ni, Ray
> Subject: [edk2-devel] [Patch V2] MdeModulePkg/DxeCorePerformanceLib:fix
> smm perf issue
>
> Fix smm perf issue in DxeCorePerformanceLib. In current code logic, total
> SMM perf record is copied multiple times to FPDT table if multiple
> ReadyToBoot events are signaled. This patch changes the function
> InternalGetSmmPerfData() to only get newly generated Smm perf data. Then
> previous generated Smm perf data won't be copied to FPDT again.
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4470
> Signed-off-by: Dun Tan
> Cc: Jian J Wang
> Cc: Liming Gao
> Cc: Ray Ni
> ---
> MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c
> | 32 +++-
> 1 file changed, 19 insertions(+), 13 deletions(-)
>
> diff --git
> a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.
> c
> b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.
> c
> index ef14bc0738..0a994be6a5 100644
> ---
> a/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.
> c
> +++
> b/MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.
> c
> @@ -10,7 +10,7 @@
>This library is mainly used by DxeCore to start performance logging to
> ensure that
>Performance Protocol is installed at the very beginning of DXE phase.
>
> -Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2023, Intel Corporation. All rights reserved.
> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -73,6 +73,7 @@ UINT8*mPerformancePointer = NULL;
> UINT8*mBootRecordBuffer= NULL;
> BOOLEAN mLockInsertRecord = FALSE;
> CHAR8*mDevicePathString= NULL;
> +UINTNmSmmBootRecordOffset = 0;
>
> EFI_DEVICE_PATH_TO_TEXT_PROTOCOL *mDevicePathToText = NULL;
>
> @@ -236,6 +237,7 @@ InternalGetSmmPerfData (
>VOID
> *SmmBootRecordData;
>UINTN
> SmmBootRecordDataSize;
>UINTNReservedMemSize;
> + UINTN
> SmmBootRecordDataRetrieved;
>
>//
>// Collect boot records from SMM drivers.
> @@ -297,28 +299,32 @@ InternalGetSmmPerfData (
>}
>
>//
> - // Get all boot records
> + // Get boot records starting from mSmmBootRecordOffset
>//
> - SmmCommData->Function =
> SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_OFFSET;
> - SmmBootRecordDataSize = SmmCommData->BootRecordSize;
> - SmmBootRecordData = AllocateZeroPool
> (SmmBootRecordDataSize);
> + SmmCommData->Function =
> SMM_FPDT_FUNCTION_GET_BOOT_RECORD_DATA_BY_OFFSET;
> + SmmCommData->BootRecordOffset = mSmmBootRecordOffset;
> + SmmBootRecordDataSize =
> SmmCommData->BootRecordSize - mSmmBootRecordOffset;
> + SmmBootRecordData = AllocateZeroPool
> (SmmBootRecordDataSize);
> + SmmBootRecordDataRetrieved= 0;
>ASSERT (SmmBootRecordData != NULL);
> - SmmCommData->BootRecordOffset = 0;
> - SmmCommData->BootRecordData = (VOID
> *)((UINTN)SmmCommMemRegion->PhysicalStart +
> SMM_BOOT_RECORD_COMM_SIZE);
> - SmmCommData->BootRecordSize = ReservedMemSize -
> SMM_BOOT_RECORD_COMM_SIZE;
> - while (SmmCommData->BootRecordOffset <
> SmmBootRecordDataSize) {
> + SmmCommData->BootRecordData = (VOID
> *)((UINTN)SmmCommMemRegion->PhysicalStart +
> SMM_BOOT_RECORD_COMM_SIZE);
> + SmmCommData->BootRecordSize = ReservedMemSize -
> SMM_BOOT_RECORD_COMM_SIZE;
> + while (SmmBootRecordDataRetrieved <
> SmmBootRecordDataSize) {
> Status = Communication->Communicate (Communication,
> SmmBootRecordCommBuffer, &CommSize);
> ASSERT_EFI_ERROR (Status);
> ASSERT_EFI_ERROR (SmmCommData->ReturnStatus);
> -if (SmmCommData->BootRecordOffset +
> SmmCommData->BootRecordSize > SmmBootRecordDataSize) {
> - CopyMem ((UINT8 *)SmmBootRecordData +
> SmmCommData->BootRecordOffset, SmmCommData->BootRecordData,
> SmmBootRecordDataSize - SmmCommData->BootRecordOffset);
> +if (SmmBootRecordDataRetrieved +
> SmmCommData->BootRecordSize > SmmBootRecordDataSize) {
> + CopyMem ((UINT8 *)SmmBootRecordData +
> + SmmBootRecordDataRetrieved, SmmCommData->BootRecordData,
> + SmmBootRecordDataSize - SmmBo
回复: [ ** SPAMMAIL ** ][edk2-devel] [PATCH v4 1/1] MdePkg: Add Cxl20.h into IndustryStandard
Chris:
I have no comments on the patch. I suggest you trig open CI to verify the
coding format in this patch.
For this patch, Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chris Li OS
> via groups.io
> 发送时间: 2023年8月25日 11:48
> 收件人: Kinney, Michael D ; Nong, Foster
> ; devel@edk2.groups.io; Gao, Liming
>
> 抄送: Yao, Jiewen ; Ni, Ray ;
> Open Source Submission
> 主题: [ ** SPAMMAIL ** ][edk2-devel] [PATCH v4 1/1] MdePkg: Add Cxl20.h
> into IndustryStandard
>
> @Foster @Mike @Liming and all kindly help review/vote again.
>
> RegisterBlock[] is used.
>
>
> 1) Add CXL 2.0 header file to comply with CXL 2.0 specification
> 2) CXL 2.0 header will embed Cxl11.h
> 3) Updated Cxl.h to point to 2.0 header file
>
> Signed-off-by: Chris Li
> ---
> MdePkg/Include/IndustryStandard/Cxl.h | 2 +-
> MdePkg/Include/IndustryStandard/Cxl20.h | 465
>
> 2 files changed, 466 insertions(+), 1 deletion(-)
> create mode 100644 MdePkg/Include/IndustryStandard/Cxl20.h
>
> diff --git a/MdePkg/Include/IndustryStandard/Cxl.h
> b/MdePkg/Include/IndustryStandard/Cxl.h
> index 06c1230e3e..9ad3242e25 100644
> --- a/MdePkg/Include/IndustryStandard/Cxl.h
> +++ b/MdePkg/Include/IndustryStandard/Cxl.h
> @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> #ifndef _CXL_MAIN_H_
> #define _CXL_MAIN_H_
>
> -#include
> +#include
> //
> // CXL assigned new Vendor ID
> //
> diff --git a/MdePkg/Include/IndustryStandard/Cxl20.h
> b/MdePkg/Include/IndustryStandard/Cxl20.h
> new file mode 100644
> index 00..6c9d6310d0
> --- /dev/null
> +++ b/MdePkg/Include/IndustryStandard/Cxl20.h
> @@ -0,0 +1,465 @@
> +/** @file
> + CXL 2.0 Register definitions
> +
> + This file contains the register definitions based on the Compute
Express
> Link
> + (CXL) Specification Revision 2.0.
> +
> + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
> +
> + SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +#ifndef CXL20_H_
> +#define CXL20_H_
> +
> +#include
> +
> +//
> +// CXL DVSEC IDs
> +// Compute Express Link Specification Revision 2.0 - Chapter 8.1.1
> +//
> +#define CXL_DVSEC_ID_PCIE_DVSEC_FOR_CXL_DEVICE0x0
> +#define CXL_DVSEC_ID_NON_CXL_FUNCTION_MAP
> 0x2
> +#define CXL_DVSEC_ID_CXL20_EXTENSIONS_DVSEC_FOR_PORTS 0x3
> +#define CXL_DVSEC_ID_GPF_DVSEC_FOR_CXL_PORTS 0x4
> +#define CXL_DVSEC_ID_GPF_DVSEC_FOR_CXL_DEVICES0x5
> +#define CXL_DVSEC_ID_PCIE_DVSEC_FOR_FLEX_BUS_PORT 0x7
> +#define CXL_DVSEC_ID_REGISTER_LOCATOR 0x8
> +#define CXL_DVSEC_ID_MLD 0x9
> +#define CXL_DVSEC_ID_PCIE_DVSEC_FOR_TEST_CAPABILITY 0xA
> +
> +//
> +// Register Block ID
> +// Compute Express Link Specification Revision 2.0 - Chapter 8.1.9.1
> +//
> +#define CXL_REGISTER_BLOCK_ID_EMPTY 0x0
> +#define CXL_REGISTER_BLOCK_ID_COMPONENT 0x1
> +#define CXL_REGISTER_BLOCK_ID_BAR_VIRTUALIZATION_ACL 0x2
> +#define CXL_REGISTER_BLOCK_ID_DEVICE 0x3
> +
> +//
> +// CXL component register layout
> +// Compute Express Link Specification Revision 2.0 - Chapter 8.2.4
> +//
> +//||
> +//|- Range & Type -|
> +//|| IO Base - 0KB
> +//| (0KB - 4KB)IO Regs |
> +//|| Cache and Mem Base - 4KB
> +//| {4KB - 8KB)Cache & Mem Regs|
> +//|| Implementation Spec Regs Base -
8KB
> +//| (8KB - 56KB)Implement Spec Regs|
> +//|| ARB/Mux Regs Base - 56KB
> +//| (56KB - 57KB)ARBMUX Regs |
> +//|| Reserved Base - 57KB
> +//| (57KB - 63KB)Reserved |
> +//|| End 64KB
> +//
> +// Component Register Block Register Ranges Offset
> +//
> +#define CXL_COMPONENT_REGISTER_RANGE_OFFSET_IO 0x0
> +#define CXL_COMPONENT_REGISTER_RANGE_OFFSET_CACHE_MEM
> 0x1000
> +#define CXL_COMPONENT_REGISTER_RANGE_OFFSET_ARB_MUX
> 0xE000
> +
> +
> +//
> +// CXL Cache Memory Capability IDs
> +// Compute Express Link Specification Revision 2.0 - Chapter 8.2.5
> +//
> +#define CXL_CACHE_MEM_CAPABILITY_ID_CXL 0x1
> +#define CXL_CACHE_MEM_CAPABILITY_ID_RAS 0x2
> +#define CXL_CACHE_MEM_CAPABILITY_ID_SECURITY 0x3
> +#define CXL_CACHE_MEM_CAPABILITY_ID_LINK 0x4
> +#define CXL_CACHE_MEM_CAPABILITY_ID_HDM_DECODER
> 0x5
> +#define CXL_CACHE_MEM_CAPABILITY_ID_EXTENDED_SECURITY 0x6
> +#define CXL_CACHE_MEM_CAPABILITY_ID_IDE 0x7
> +#define CXL_CACHE_MEM_CAPABILITY_ID_SNOOP_FILTER 0x8
> +#define CXL_CACHE_MEM_CAPABILITY_ID_MASK
> 0x
> +
> +//
> +// Generic CXL Device Capability IDs 0x ~ 0x3FFF
> +// Compute Express Link Specificati
Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0
Reviewed-by: Star Zeng
BTW: You'd better to have a separated patch to also update
https://github.com/tianocore/edk2/blob/master/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c#L1713.
-Original Message-
From: gaoliming
Sent: Tuesday, September 5, 2023 10:29 AM
To: devel@edk2.groups.io; Bhargava, Avinash
Cc: Liu, Zhiguang ; Bi, Dandan ;
Zeng, Star ; Gao, Zhichao
Subject: 回复: [edk2-devel] [PATCH v1 1/1]
MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor family for
SMBIOS Type 4 from SMBIOS 3.7.0
Avi:
The change is good. Reviewed-by: Liming Gao
But, I have one minor comment. Please see below.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Avinash
> 发送时间: 2023年9月2日 2:21
> 收件人: devel@edk2.groups.io
> 抄送: avinashbhargava ; Zhiguang Liu
> ; Dandan Bi ; Star Zeng
> ; Zhichao Gao
> 主题: [edk2-devel] [PATCH v1 1/1]
> MdePkg/Include/IndustryStandard/SmBios.h: Add New Intel Processor
> family for SMBIOS Type 4 from SMBIOS 3.7.0
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4547
>
> Add New Intel Processor family for SMBIOS Type 4 from SMBIOS 3.7.0 Hex
> value - 16h Name - Intel® Processor
[Liming] Please remove non ascii char ® in the commit message.
Thanks
Liming
>
> Signed-off-by: avinashbhargava
> Cc: Zhiguang Liu
> Cc: Dandan Bi
> Cc: Star Zeng
> Cc: Zhichao Gao
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 40bdc9a937c0..56cec615a010 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -554,6 +554,7 @@ typedef enum {
>ProcessorFamilyM2 = 0x13,
>
>ProcessorFamilyIntelCeleronM = 0x14,
>
>ProcessorFamilyIntelPentium4Ht = 0x15,
>
> + ProcessorFamilyIntel = 0x16,
>
>ProcessorFamilyAmdDuron= 0x18,
>
>ProcessorFamilyK5 = 0x19,
>
>ProcessorFamilyK6 = 0x1A,
>
> --
> 2.37.3.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108273): https://edk2.groups.io/g/devel/message/108273
Mute This Topic: https://groups.io/mt/101162402/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI
Hi, Leif On 2023-09-04 21:51, quic_llindhol wrote: > > However, this version still breaks bisect: attempting to build at 1/3 > or 2/3 leads to: > --- > /work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf(72): > error 3000: PCD > [gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlatformEhciBase] in > [/work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf] > is not found in dependent packages: > --- Maybe it is a stupid question: What is the meaning of bisect in here? > > Also, I think Ard's comments on the ACPI changes still apply. > Do you have a comment on that? > Sorry, I' m honestly not knowledgable enough about the DSDT content so I just managed to use the "Device (XHCI)" node to support the xhci controller to work and remove the previous "Device (USB0)" node. If you have time to discuss it, I'm glad to continue to fix and improve my patches. And I will go on to improve myself and learn from experienced experts like yours. Many thanks Yuquan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108274): https://edk2.groups.io/g/devel/message/108274 Mute This Topic: https://groups.io/mt/101073211/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then running QEMU
On Mon, 4 Sept 2023, 21:14 Rebecca Cran, wrote: > Sorry I've not responded to your emails before now. > > I don't normally use the build.sh script, so I'm fine with reverting to > the previous behavior. > Ah - thank you for the response - that'd be great, if the original people who ack-d and committed are fine to approve the change back too. I did put up a patch to this list (my v2 patch reverts the change, and at the same time removes an unwanted extra white space line which was actually there at the end of the original file) - but I am tbh not as familiar as I should be with text-based patches, I'll double check the process and check that it applies using (whatever I find out) the normal commands (are...!). Mike > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108275): https://edk2.groups.io/g/devel/message/108275 Mute This Topic: https://groups.io/mt/96836052/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI
W dniu 5.09.2023 o 08:11, Yuquan Wang pisze: Hi, Leif On 2023-09-04 21:51, quic_llindhol wrote: > > However, this version still breaks bisect: attempting to build at 1/3 > or 2/3 leads to: > --- > /work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf(72): > error 3000: PCD > [gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlatformEhciBase] in > [/work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf] > is not found in dependent packages: > --- Maybe it is a stupid question: What is the meaning of bisect in here? Project is meant to be buildable at every commit. Your patchset breaks that rule. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108276): https://edk2.groups.io/g/devel/message/108276 Mute This Topic: https://groups.io/mt/101073211/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 0/3] use XHCI to replace EHCI
On 2023-09-05 14:30, marcin.juszkiewicz wrote: Project is meant to be buildable at every commit. Your patchset breaks that rule. Oh! I get it ! I did not consider this principle when designing these patches. Thanks for your explanation : ) I am going to recheck and combine some content together. Many thanks Yuquan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108277): https://edk2.groups.io/g/devel/message/108277 Mute This Topic: https://groups.io/mt/101073211/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
