> -----Original Message-----
> From: Rebecca Cran <quic_rc...@quicinc.com>
> Sent: Wednesday, February 8, 2023 6:02 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebe...@quicinc.com>; Ard Biesheuvel 
> <ardb+tianoc...@kernel.org>; Jiewen Yao <jiewen....@intel.com>; Jordan Justen 
> <jordan.l.jus...@intel.com>; Gerd Hoffmann <kra...@redhat.com>
> Subject: [PATCH 1/1] OvmfPkg: Update build.sh to allow building OVMF then 
> running QEMU
>
> Allow users to build OVMF then run QEMU by moving the build block above
> the run block and removing the exit line.
>
> Signed-off-by: Rebecca Cran <rebe...@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
> Cc: Jiewen Yao <jiewen....@intel.com>
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Cc: Gerd Hoffmann <kra...@redhat.com>
> ---
>  OvmfPkg/build.sh | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 91b1442ade6b..b0334fb76e74 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -245,6 +245,11 @@ else
>    echo using prebuilt tools
>  fi
>
> +#
> +# Build the edk2 OvmfPkg
> +#
> +echo Running edk2 build for OvmfPkg$Processor
> +build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n 
> $THREADNUMBER -DDEBUG_ON_SERIAL_PORT=TRUE
>
>  if [[ "$RUN_QEMU" == "yes" ]]; then
>    if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then
> @@ -260,11 +265,3 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>    $QEMU_COMMAND "$@"
>    exit $?
>  fi
> -
> -#
> -# Build the edk2 OvmfPkg
> -#
> -echo Running edk2 build for OvmfPkg$Processor
> -build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -n 
> $THREADNUMBER
> -exit $?
> -
> --
> 2.30.2

Hi,

I was trying to raise the issue that I believe this change from Feb.
of this year breaks intended and useful previous behaviour. It
occurred to me that replying to the original post might make most
sense. I've raised what I think are the issues here:
https://bugzilla.tianocore.org/show_bug.cgi?id=4528 .

WIth many thanks in advance for your attention.

Mike Beaton


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108260): https://edk2.groups.io/g/devel/message/108260
Mute This Topic: https://groups.io/mt/96836052/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to