Re: Intent to ship: scrollbar-color and scrollbar-width properties

2018-09-26 Thread Jonathan Kew

On 26/09/2018 01:59, Xidorn Quan wrote:

As of Firefox 64, I intend to turn scrollbar-color and scrollbar-width properties on by default on 
all platforms. They have been developed behind pref "layout.css.scrollbar-colors.enabled" 
and "layout.css.scrollbar-width.enabled" respectively.


Awesome, thanks for this work!

One tiny nit, which may not be worth bothering about at this point: it 
seems slightly unfortunate that the pref is 
"layout.css.scrollbar-colors.enabled" (plural) when the property name is 
"scrollbar-color" (singular).


I realize this originated back when there were two scrollbar-*-color 
properties, so using plural for the pref made sense, but now it just 
feels a bit confusing.


Maybe consider dropping the final "s" from the pref name so it better 
matches the feature it controls?


JK
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: PSA: wpt MANIFEST.json has moved out of tree

2018-09-26 Thread James Graham

On 24/09/2018 13:43, James Graham wrote:

If you notice regressions from this change, please file a bug in the 
Testing::web-platform-tests component and needinfo me.


Due to bug 1493674 we were mistakenly looking for test metadata in the 
objdir rather than the source dir. If you notice that web-platform-tests 
are unexpectedly failing or not using the expected prefs, please ensure 
you have the commits from that bug in your tree, and delete 
/_tests/web-platform/wptrunner.local.ini; it should be recreated 
with the correct paths when you next run wpt tests.


[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1493674
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Input Delay Metric proposal

2018-09-26 Thread Randell Jesup
>For in-the-wild input delay not specifically during pageload we also
>measure INPUT_EVENT_RESPONSE_DELAY_MS[1] and (from Firefox 53-60 and then
>resuscitated in 64) INPUT_EVENT_RESPONSE_COALESCED_MS[2] which record[3]
>from the time the OS created the input event until the time when the
>process is done with the event.

Sure, those are interesting... though it's the tail that's generally the
concerning part here - and most of the tail will be during-pageload.
(and those that aren't can actually be interesting for other reasons).

MID is intended for automation and to a lesser extent for investigation
of responsiveness on specific pages, or for devtools (so developers can
see how their page is working).  It's arguable how useful this is in
telemetry - though I think it might be worth tracking there, at least
for a while to compare.

-- 
Randell Jesup, Mozilla Corp
remove "news" for personal email
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Intent to ship: scrollbar-color and scrollbar-width properties

2018-09-26 Thread Xidorn Quan
On Wed, Sep 26, 2018, at 7:50 PM, Jonathan Kew wrote:
> On 26/09/2018 01:59, Xidorn Quan wrote:
> > As of Firefox 64, I intend to turn scrollbar-color and scrollbar-width 
> > properties on by default on all platforms. They have been developed behind 
> > pref "layout.css.scrollbar-colors.enabled" and 
> > "layout.css.scrollbar-width.enabled" respectively.
> 
> Awesome, thanks for this work!
> 
> One tiny nit, which may not be worth bothering about at this point: it 
> seems slightly unfortunate that the pref is 
> "layout.css.scrollbar-colors.enabled" (plural) when the property name is 
> "scrollbar-color" (singular).
> 
> I realize this originated back when there were two scrollbar-*-color 
> properties, so using plural for the pref made sense, but now it just 
> feels a bit confusing.
> 
> Maybe consider dropping the final "s" from the pref name so it better 
> matches the feature it controls?

Sounds reasonable. Fixing in 
https://bugzilla.mozilla.org/show_bug.cgi?id=1494501

I initially thought it's probably not worth bothering... but it's indeed better 
if they match each other.

Thanks.

- Xidorn
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform