On Wed, Sep 26, 2018, at 7:50 PM, Jonathan Kew wrote: > On 26/09/2018 01:59, Xidorn Quan wrote: > > As of Firefox 64, I intend to turn scrollbar-color and scrollbar-width > > properties on by default on all platforms. They have been developed behind > > pref "layout.css.scrollbar-colors.enabled" and > > "layout.css.scrollbar-width.enabled" respectively. > > Awesome, thanks for this work! > > One tiny nit, which may not be worth bothering about at this point: it > seems slightly unfortunate that the pref is > "layout.css.scrollbar-colors.enabled" (plural) when the property name is > "scrollbar-color" (singular). > > I realize this originated back when there were two scrollbar-*-color > properties, so using plural for the pref made sense, but now it just > feels a bit confusing. > > Maybe consider dropping the final "s" from the pref name so it better > matches the feature it controls?
Sounds reasonable. Fixing in https://bugzilla.mozilla.org/show_bug.cgi?id=1494501 I initially thought it's probably not worth bothering... but it's indeed better if they match each other. Thanks. - Xidorn _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform