Re: [I] Allow to add a custom DNS suffix to OpenSearch Node addresses returned by Sniffer [incubator-stormcrawler]
rzo1 closed issue #1198: Allow to add a custom DNS suffix to OpenSearch Node addresses returned by Sniffer URL: https://github.com/apache/incubator-stormcrawler/issues/1198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Allow to add a custom DNS suffix to OpenSearch Node addresses returned by Sniffer [incubator-stormcrawler]
rzo1 commented on issue #1198: URL: https://github.com/apache/incubator-stormcrawler/issues/1198#issuecomment-2082475403 This is not an actual issue if `sniffing` is disabled _or_ the k8s operated resources are configured correctly. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Release?
Hi all, what do we need to do to run our first ASF release? Personally, I would love to see [1] in 3.0. Don't think we have any other formal blockers? Gruß Richard [1] https://github.com/apache/incubator-stormcrawler/pull/1199
Re: Release?
Should be great. Was looking around the code & see if there are any potential issues which can block the vote. Little bit curious around some files having "Licensed to DigitalPebble Ltd under one or more" [1] Should we ditch such LICENSE headers, not sure if it is allowed or not, [2] just mentions the standard License header There are some files here in this directory [3] referring to DigitalPebble, if not required we can consider dropping before the release Some files tend to have different header as compared to one mentioned in the official doc [4], it mentions reading the NOTICE file & stuff Just reading the incubator vote checklist [4], if everything is good as per this doc, We should be good to go. Thanx Richard for initiating the discussion!!! -Ayush [1] https://github.com/apache/incubator-stormcrawler/blob/main/core/src/test/java/org/apache/stormcrawler/indexer/BasicIndexingTest.java [2] https://www.apache.org/legal/src-headers#headers [3] https://github.com/apache/incubator-stormcrawler/tree/main/core/src/test/resources [4] https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist On Mon, 29 Apr 2024 at 19:16, Richard Zowalla wrote: > Hi all, > > what do we need to do to run our first ASF release? > Personally, I would love to see [1] in 3.0. > > Don't think we have any other formal blockers? > > Gruß > Richard > > > [1] https://github.com/apache/incubator-stormcrawler/pull/1199 >
[PR] 1200 - Fix license headers [incubator-stormcrawler]
jnioche opened a new pull request, #1201: URL: https://github.com/apache/incubator-stormcrawler/pull/1201 Thank you for contributing to Apache StormCrawler. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a issue associated with this PR? Is it referenced in the commit message? - [ x] Does your PR title start with `#` where `` is the issue number you are trying to resolve? - [x ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? - [ x] Is the code properly formatted with `mvn git-code-format:format-code -Dgcf.globPattern=**/*`? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via `mvn clean verify`? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Release?
Thanks Ayush I have fixed the license headers in https://github.com/apache/incubator-stormcrawler/pull/1201 Julien On Mon, 29 Apr 2024 at 15:18, Ayush Saxena wrote: > Should be great. > Was looking around the code & see if there are any potential issues which > can block the vote. > Little bit curious around some files having "Licensed to DigitalPebble Ltd > under one or more" [1] > > Should we ditch such LICENSE headers, not sure if it is allowed or not, [2] > just mentions the standard License header > > There are some files here in this directory [3] referring to DigitalPebble, > if not required we can consider dropping before the release > > Some files tend to have different header as compared to one mentioned in > the official doc [4], it mentions reading the NOTICE file & stuff > > Just reading the incubator vote checklist [4], if everything is good as per > this doc, We should be good to go. > > Thanx Richard for initiating the discussion!!! > > -Ayush > > [1] > > https://github.com/apache/incubator-stormcrawler/blob/main/core/src/test/java/org/apache/stormcrawler/indexer/BasicIndexingTest.java > [2] https://www.apache.org/legal/src-headers#headers > [3] > > https://github.com/apache/incubator-stormcrawler/tree/main/core/src/test/resources > [4] > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > On Mon, 29 Apr 2024 at 19:16, Richard Zowalla wrote: > > > Hi all, > > > > what do we need to do to run our first ASF release? > > Personally, I would love to see [1] in 3.0. > > > > Don't think we have any other formal blockers? > > > > Gruß > > Richard > > > > > > [1] https://github.com/apache/incubator-stormcrawler/pull/1199 > > >
Re: [PR] 1200 - Fix license headers [incubator-stormcrawler]
jnioche merged PR #1201: URL: https://github.com/apache/incubator-stormcrawler/pull/1201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Allow to disable SSL/TLS verification in OpenSearchConnection [incubator-stormcrawler]
jnioche closed issue #1197: Allow to disable SSL/TLS verification in OpenSearchConnection URL: https://github.com/apache/incubator-stormcrawler/issues/1197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] #1197 - Allow to disable SSL/TLS verification in OpenSearchConnection [incubator-stormcrawler]
jnioche merged PR #1199: URL: https://github.com/apache/incubator-stormcrawler/pull/1199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Fix license headers [incubator-stormcrawler]
rzo1 closed issue #1200: Fix license headers URL: https://github.com/apache/incubator-stormcrawler/issues/1200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix #1202 - Add release documentation and comply with source package naming requirements [incubator-stormcrawler]
rzo1 opened a new pull request, #1203: URL: https://github.com/apache/incubator-stormcrawler/pull/1203 Hi all, can you do a careful check, if the RELEASE docs comply with the incubator requirements and are technically correct? I don't really now the specifics for the incubator, but should cover the content from https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist Gruß Richard -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@stormcrawler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
