Thanks Ayush I have fixed the license headers in https://github.com/apache/incubator-stormcrawler/pull/1201
Julien On Mon, 29 Apr 2024 at 15:18, Ayush Saxena <ayush...@gmail.com> wrote: > Should be great. > Was looking around the code & see if there are any potential issues which > can block the vote. > Little bit curious around some files having "Licensed to DigitalPebble Ltd > under one or more" [1] > > Should we ditch such LICENSE headers, not sure if it is allowed or not, [2] > just mentions the standard License header > > There are some files here in this directory [3] referring to DigitalPebble, > if not required we can consider dropping before the release > > Some files tend to have different header as compared to one mentioned in > the official doc [4], it mentions reading the NOTICE file & stuff > > Just reading the incubator vote checklist [4], if everything is good as per > this doc, We should be good to go. > > Thanx Richard for initiating the discussion!!! > > -Ayush > > [1] > > https://github.com/apache/incubator-stormcrawler/blob/main/core/src/test/java/org/apache/stormcrawler/indexer/BasicIndexingTest.java > [2] https://www.apache.org/legal/src-headers#headers > [3] > > https://github.com/apache/incubator-stormcrawler/tree/main/core/src/test/resources > [4] > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > On Mon, 29 Apr 2024 at 19:16, Richard Zowalla <r...@apache.org> wrote: > > > Hi all, > > > > what do we need to do to run our first ASF release? > > Personally, I would love to see [1] in 3.0. > > > > Don't think we have any other formal blockers? > > > > Gruß > > Richard > > > > > > [1] https://github.com/apache/incubator-stormcrawler/pull/1199 > > >
