Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2
Hi, Yunze I’ve got several failed tests. [--] Global test environment tear-down [==] 528 tests from 85 test suites ran. (888193 ms total) [ PASSED ] 525 tests. [ FAILED ] 3 tests, listed below: [ FAILED ] CustomLoggerTest.testCustomLogger [ FAILED ] LookupServiceTest.testMultiAddresses [ FAILED ] c_ConsumerTest.testCDeadLetterTopic After rerun, the second and third tests still failed. /Users/mattisonchao/projects/apache/pulsar-client-cpp/tests/c/c_ConsumerTest.cc:182: Failure Expected equality of these values: pulsar_result_Timeout Which is: 3 res Which is: 0 [ FAILED ] c_ConsumerTest.testCDeadLetterTopic (75 ms) [--] 1 test from c_ConsumerTest (75 ms total) [--] Global test environment tear-down [==] 1 test from 1 test suite ran. (75 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] c_ConsumerTest.testCDeadLetterTopic Expected equality of these values: std::count(results.cbegin(), results.cend(), ResultRetryable) Which is: 0 numRequests / 2 Which is: 3 2023-11-12 22:10:03.538 INFO [0x1e483d300] ClientConnection:268 | [ -> pulsar://localhost:] Destroyed connection to pulsar://localhost: [ FAILED ] LookupServiceTest.testMultiAddresses (89 ms) [--] 1 test from LookupServiceTest (89 ms total) [--] Global test environment tear-down [==] 1 test from 1 test suite ran. (89 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] LookupServiceTest.testMultiAddresses Best, Mattison > On Nov 7, 2023, at 15:03, Yunze Xu wrote: > > This is the second release candidate for Apache Pulsar Client C++, > version 3.4.0. > > It fixes the following issues: > https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1 > > *** Please download, test and vote on this release. This vote will stay open > for at least 72 hours *** > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Source and binary files: > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/ > > SHA-512 checksums: > > 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950 > apache-pulsar-client-cpp-3.4.0.tar.gz > > > The tag to be voted upon: > v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70) > https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2 > > Pulsar's KEYS file containing PGP keys you use to sign the release: > https://downloads.apache.org/pulsar/KEYS > > Please download the source package, and follow the README to compile and test.
Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2
+1(binding) Some failing tests are unstable and state-dependent, and the test passes after retrying. Best, Mattison > On Nov 12, 2023, at 22:10, mattison chao wrote: > > Hi, Yunze > > I’ve got several failed tests. > > [--] Global test environment tear-down > [==] 528 tests from 85 test suites ran. (888193 ms total) > [ PASSED ] 525 tests. > [ FAILED ] 3 tests, listed below: > [ FAILED ] CustomLoggerTest.testCustomLogger > [ FAILED ] LookupServiceTest.testMultiAddresses > [ FAILED ] c_ConsumerTest.testCDeadLetterTopic > > > After rerun, the second and third tests still failed. > > /Users/mattisonchao/projects/apache/pulsar-client-cpp/tests/c/c_ConsumerTest.cc:182: > Failure > Expected equality of these values: > pulsar_result_Timeout > Which is: 3 > res > Which is: 0 > > [ FAILED ] c_ConsumerTest.testCDeadLetterTopic (75 ms) > [--] 1 test from c_ConsumerTest (75 ms total) > > [--] Global test environment tear-down > [==] 1 test from 1 test suite ran. (75 ms total) > [ PASSED ] 0 tests. > [ FAILED ] 1 test, listed below: > [ FAILED ] c_ConsumerTest.testCDeadLetterTopic > > > Expected equality of these values: > std::count(results.cbegin(), results.cend(), ResultRetryable) > Which is: 0 > numRequests / 2 > Which is: 3 > > 2023-11-12 22:10:03.538 INFO [0x1e483d300] ClientConnection:268 | [ -> > pulsar://localhost:] Destroyed connection to pulsar://localhost: > [ FAILED ] LookupServiceTest.testMultiAddresses (89 ms) > [--] 1 test from LookupServiceTest (89 ms total) > > [--] Global test environment tear-down > [==] 1 test from 1 test suite ran. (89 ms total) > [ PASSED ] 0 tests. > [ FAILED ] 1 test, listed below: > [ FAILED ] LookupServiceTest.testMultiAddresses > > > > Best, > Mattison > >> On Nov 7, 2023, at 15:03, Yunze Xu wrote: >> >> This is the second release candidate for Apache Pulsar Client C++, >> version 3.4.0. >> >> It fixes the following issues: >> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1 >> >> *** Please download, test and vote on this release. This vote will stay open >> for at least 72 hours *** >> >> Note that we are voting upon the source (tag), binaries are provided for >> convenience. >> >> Source and binary files: >> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/ >> >> SHA-512 checksums: >> >> 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950 >> apache-pulsar-client-cpp-3.4.0.tar.gz >> >> >> The tag to be voted upon: >> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70) >> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2 >> >> Pulsar's KEYS file containing PGP keys you use to sign the release: >> https://downloads.apache.org/pulsar/KEYS >> >> Please download the source package, and follow the README to compile and >> test. >
Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2
In addition to Mattison's failure. The `LookupServiceTest.testMultiAddresses` failed because the HTTP proxy is enabled. See https://github.com/apache/pulsar-client-cpp/issues/343 In addition, I edited the wiki to note proxy should be disabled because many failed tests could be caused by the proxy: https://github.com/apache/pulsar-client-cpp/wiki/Committer-Release-Guide#run-the-vote Thanks, Yunze On Mon, Nov 13, 2023 at 10:05 AM mattison chao wrote: > > +1(binding) > > Some failing tests are unstable and state-dependent, and the test passes > after retrying. > > > Best, > Mattison > > > On Nov 12, 2023, at 22:10, mattison chao wrote: > > > > Hi, Yunze > > > > I’ve got several failed tests. > > > > [--] Global test environment tear-down > > [==] 528 tests from 85 test suites ran. (888193 ms total) > > [ PASSED ] 525 tests. > > [ FAILED ] 3 tests, listed below: > > [ FAILED ] CustomLoggerTest.testCustomLogger > > [ FAILED ] LookupServiceTest.testMultiAddresses > > [ FAILED ] c_ConsumerTest.testCDeadLetterTopic > > > > > > After rerun, the second and third tests still failed. > > > > /Users/mattisonchao/projects/apache/pulsar-client-cpp/tests/c/c_ConsumerTest.cc:182: > > Failure > > Expected equality of these values: > > pulsar_result_Timeout > > Which is: 3 > > res > > Which is: 0 > > > > [ FAILED ] c_ConsumerTest.testCDeadLetterTopic (75 ms) > > [--] 1 test from c_ConsumerTest (75 ms total) > > > > [--] Global test environment tear-down > > [==] 1 test from 1 test suite ran. (75 ms total) > > [ PASSED ] 0 tests. > > [ FAILED ] 1 test, listed below: > > [ FAILED ] c_ConsumerTest.testCDeadLetterTopic > > > > > > Expected equality of these values: > > std::count(results.cbegin(), results.cend(), ResultRetryable) > > Which is: 0 > > numRequests / 2 > > Which is: 3 > > > > 2023-11-12 22:10:03.538 INFO [0x1e483d300] ClientConnection:268 | [ > > -> pulsar://localhost:] Destroyed connection to pulsar://localhost: > > [ FAILED ] LookupServiceTest.testMultiAddresses (89 ms) > > [--] 1 test from LookupServiceTest (89 ms total) > > > > [--] Global test environment tear-down > > [==] 1 test from 1 test suite ran. (89 ms total) > > [ PASSED ] 0 tests. > > [ FAILED ] 1 test, listed below: > > [ FAILED ] LookupServiceTest.testMultiAddresses > > > > > > > > Best, > > Mattison > > > >> On Nov 7, 2023, at 15:03, Yunze Xu wrote: > >> > >> This is the second release candidate for Apache Pulsar Client C++, > >> version 3.4.0. > >> > >> It fixes the following issues: > >> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1 > >> > >> *** Please download, test and vote on this release. This vote will stay > >> open > >> for at least 72 hours *** > >> > >> Note that we are voting upon the source (tag), binaries are provided for > >> convenience. > >> > >> Source and binary files: > >> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/ > >> > >> SHA-512 checksums: > >> > >> 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950 > >> apache-pulsar-client-cpp-3.4.0.tar.gz > >> > >> > >> The tag to be voted upon: > >> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70) > >> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2 > >> > >> Pulsar's KEYS file containing PGP keys you use to sign the release: > >> https://downloads.apache.org/pulsar/KEYS > >> > >> Please download the source package, and follow the README to compile and > >> test. > > >
Re: [VOTE] Pulsar Client C++ Release 3.4.0 Candidate 2
Closing this vote by 3 binding +1s: - Penghui - Yunze - Mattison Thanks, Yunze On Mon, Nov 13, 2023 at 11:14 AM Yunze Xu wrote: > > In addition to Mattison's failure. The > `LookupServiceTest.testMultiAddresses` failed because the HTTP proxy > is enabled. See https://github.com/apache/pulsar-client-cpp/issues/343 > > In addition, I edited the wiki to note proxy should be disabled > because many failed tests could be caused by the proxy: > https://github.com/apache/pulsar-client-cpp/wiki/Committer-Release-Guide#run-the-vote > > Thanks, > Yunze > > On Mon, Nov 13, 2023 at 10:05 AM mattison chao wrote: > > > > +1(binding) > > > > Some failing tests are unstable and state-dependent, and the test passes > > after retrying. > > > > > > Best, > > Mattison > > > > > On Nov 12, 2023, at 22:10, mattison chao wrote: > > > > > > Hi, Yunze > > > > > > I’ve got several failed tests. > > > > > > [--] Global test environment tear-down > > > [==] 528 tests from 85 test suites ran. (888193 ms total) > > > [ PASSED ] 525 tests. > > > [ FAILED ] 3 tests, listed below: > > > [ FAILED ] CustomLoggerTest.testCustomLogger > > > [ FAILED ] LookupServiceTest.testMultiAddresses > > > [ FAILED ] c_ConsumerTest.testCDeadLetterTopic > > > > > > > > > After rerun, the second and third tests still failed. > > > > > > /Users/mattisonchao/projects/apache/pulsar-client-cpp/tests/c/c_ConsumerTest.cc:182: > > > Failure > > > Expected equality of these values: > > > pulsar_result_Timeout > > > Which is: 3 > > > res > > > Which is: 0 > > > > > > [ FAILED ] c_ConsumerTest.testCDeadLetterTopic (75 ms) > > > [--] 1 test from c_ConsumerTest (75 ms total) > > > > > > [--] Global test environment tear-down > > > [==] 1 test from 1 test suite ran. (75 ms total) > > > [ PASSED ] 0 tests. > > > [ FAILED ] 1 test, listed below: > > > [ FAILED ] c_ConsumerTest.testCDeadLetterTopic > > > > > > > > > Expected equality of these values: > > > std::count(results.cbegin(), results.cend(), ResultRetryable) > > > Which is: 0 > > > numRequests / 2 > > > Which is: 3 > > > > > > 2023-11-12 22:10:03.538 INFO [0x1e483d300] ClientConnection:268 | > > > [ -> pulsar://localhost:] Destroyed connection to > > > pulsar://localhost: > > > [ FAILED ] LookupServiceTest.testMultiAddresses (89 ms) > > > [--] 1 test from LookupServiceTest (89 ms total) > > > > > > [--] Global test environment tear-down > > > [==] 1 test from 1 test suite ran. (89 ms total) > > > [ PASSED ] 0 tests. > > > [ FAILED ] 1 test, listed below: > > > [ FAILED ] LookupServiceTest.testMultiAddresses > > > > > > > > > > > > Best, > > > Mattison > > > > > >> On Nov 7, 2023, at 15:03, Yunze Xu wrote: > > >> > > >> This is the second release candidate for Apache Pulsar Client C++, > > >> version 3.4.0. > > >> > > >> It fixes the following issues: > > >> https://github.com/apache/pulsar-client-cpp/milestone/5?closed=1 > > >> > > >> *** Please download, test and vote on this release. This vote will stay > > >> open > > >> for at least 72 hours *** > > >> > > >> Note that we are voting upon the source (tag), binaries are provided for > > >> convenience. > > >> > > >> Source and binary files: > > >> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.4.0-candidate-2/ > > >> > > >> SHA-512 checksums: > > >> > > >> 10517590a2e4296d6767a044e58dd32c79e404a5136cf41126f4cb2416ed0ef8fb1ad7aa7da54c37c12ed71b05a527ed08bfac9d50d3550fa5d475c1e8c00950 > > >> apache-pulsar-client-cpp-3.4.0.tar.gz > > >> > > >> > > >> The tag to be voted upon: > > >> v3.4.0-candidate-2 (f337eff7caae93730ec1260810655cbb5a345e70) > > >> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.4.0-candidate-2 > > >> > > >> Pulsar's KEYS file containing PGP keys you use to sign the release: > > >> https://downloads.apache.org/pulsar/KEYS > > >> > > >> Please download the source package, and follow the README to compile and > > >> test. > > > > >
Re: [DISCUSS] PIP-315: Configurable max delay limit for delayed delivery
I think this is a good point. Thanks, Cong Zhao On 2023/10/31 22:21:56 Kevin Lu wrote: > Hi All, > > I just submitted a PIP to add an optional config to limit the max delay > allowed for delayed delivery. This would be helpful for Pulsar > administrators if they wanted to provide some limits on delayed delivery. > > Link - https://github.com/apache/pulsar/pull/21490 > > Thanks, > Kevin >
Re: [VOTE] PIP-318: Don't retain null-key messages during topic compaction
+1(binding) Best, Mattison > On Nov 10, 2023, at 12:12, Cong Zhao wrote: > > Hi Community, > > This thread is to start a vote for PIP-318. > > PIP: https://github.com/apache/pulsar/pull/21541 > Discussion thread: > https://lists.apache.org/thread/68k6vrghfp3np601lrfx5mbfmghbbrjh > > Thanks, > Cong Zhao
[ANNOUNCE] Yubiao Feng as new PMC member in Apache Pulsar
Dear Community, We are thrilled to announce that Yubiao Feng https://github.com/poorbarcode has been invited and has accepted the role of a member of the Apache Pulsar Project Management Committee (PMC). Yubiao Feng has proven to be an invaluable asset to our community, consistently showcasing dedication and active engagement through substantial contributions. Beyond his noteworthy technical input, Yubiao plays a crucial role in meticulously reviewing pull requests, thereby ensuring the overall excellence of our project. We eagerly anticipate and appreciate his ongoing contributions. On behalf of the Pulsar PMC, we extend a heartfelt welcome and congratulations to Yubiao Feng. Sincerely, Mattison
Re: [VOTE] PIP-318: Don't retain null-key messages during topic compaction
+1 (binding) Thanks, Yunze On Mon, Nov 13, 2023 at 3:28 PM mattison chao wrote: > > +1(binding) > > Best, > Mattison > > > On Nov 10, 2023, at 12:12, Cong Zhao wrote: > > > > Hi Community, > > > > This thread is to start a vote for PIP-318. > > > > PIP: https://github.com/apache/pulsar/pull/21541 > > Discussion thread: > > https://lists.apache.org/thread/68k6vrghfp3np601lrfx5mbfmghbbrjh > > > > Thanks, > > Cong Zhao >
