Re: [DISCUSS] PIP-242: Introduce enableStrictTopicName to reject creating topic with -partition- keyword.
+1 to me! In our actual usage scenario, in the Broker 272 version, if we create a topic with the -partition- keyword, new connections will be created continuously, so we disabled the -partition- on the control side Keyword, as described in PIP, does not allow users to carry the -partition- keyword as the Topic name when creating a Topic. I think it would be a more elegant option to support disabling the -partition- keyword on the Broker side. -- Thanks Xiaolong Ran Asaf Mesika 于2023年2月2日周四 22:50写道： > IMO the logic should be defined properly, and examples should help you > understand it. > > Regarding last step > > > >1. Make enableStrictTopicName=true in the next major release. > > > > Maybe just delete the flag? Just always do it? > > On Mon, Jan 30, 2023 at 6:31 AM wrote: > > > Hi, Asaf, Yunze > > > You mean to say, if the topic is partitioned, the word "partition" can > > notappear in the submitted topic name, in the topic creation API? > > It's a little bit confusing. I will give some examples to help explain: > > > > Create a topic: > > > > • no corresponding partitioned topic > > • persistent://public/default/local-name (passed) > > • persistent://public/default/local-name-partition-z (rejected by > > keyword) > > • persistent://public/default/local-name-partition-0 (rejected by > > keyword) > > • Has corresponding partitioned topic, partitions=2 and topic partition > > name is persistent://public/default/local-name > > • persistent://public/default/local-name-partition-0 (passed, Because > > it is the partition topic's sub-partition) > > • persistent://public/default/local-name-partition-z (rejected by > > keyword) > > • persistent://public/default/local-name-partition-4 (rejected, > > Because it exceeds the number of maximum partitions) > > > > > > Create a partitioned topic(topic metadata) > > > > • persistent://public/default/local-name (passed) > > • persistent://public/default/local-name-partition-z (rejected by > keyword) > > • persistent://public/default/local-name-partition-0 (rejected by > keyword) > > > > > > > > > I think this PIP should go close to this end to end, meaning the last > > stepbeing making it default true.Otherwise, we end up having so many > > "feature flags" turned off, it's hardto navigate and improve Pulsar. > > Yes, we will add a warning log-in step 3 at the current release and > enable > > it by default in the next major release(3.0?). > > > > Thanks a lot! > > > > Best, > > Mattison > > On Jan 30, 2023, 00:17 +0800, Asaf Mesika , > wrote: > > > You mean to say, if the topic is partitioned, the word "partition" can > > not appear in the submitted topic name, in the topic creation API? > > >
Re: [Vote] PIP-242: Introduce enableStrictTopicName to reject creating topic with -partition- keyword.
+1 (non-binding) -- Thanks Xiaolong Ran Enrico Olivelli 于2023年2月3日周五 00:04写道： > Asaf, > > Il giorno gio 2 feb 2023 alle ore 16:03 Asaf Mesika > ha scritto: > > > > Enrico - do we have those "rules" of conduct logged somewhere? > > https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md > > it reads... > "Once some consensus is reached, there will be a vote to formally > approve the proposal. The vote will be held on the > dev@pulsar.apache.org mailing list. Everyone is welcome to vote on the > proposal, though it will considered to be binding only the vote of PMC > members. I would be required to have a lazy majority of at least 3 > binding +1s votes. The vote should stay open for at least 48 hours." > > > > > Enrico > > > > > On Thu, Feb 2, 2023 at 4:59 PM Enrico Olivelli > wrote: > > > > > Il giorno gio 2 feb 2023 alle ore 15:52 Asaf Mesika > > > ha scritto: > > > > > > > > I agree. I don't think we can start a vote without closing all open > > > issues > > > > raised in the discussion, until a given timeout - 3 days is not > > > > enough timeout IMO > > > > > > > > > Agreed > > > > > > Also many people don't follow the mailing list during the weekend > > > (Saturday/Sunday) > > > > > > Enrico > > > > > > > > > > > On Wed, Feb 1, 2023 at 9:16 AM Michael Marshall < > mmarsh...@apache.org> > > > > wrote: > > > > > > > > > We did not have this discussion or vote open long enough. The > > > > > discussion started on a Saturday and then the vote started on > Monday. > > > > > The vote was closed 24 hours later. > > > > > > > > > > I just sent a note to the discussion thread. I would like to > discuss > > > > > increasing the scope of this PIP before we officially close this > vote. > > > > > > > > > > Thanks, > > > > > Michael > > > > > > > > > > On Tue, Jan 31, 2023 at 4:29 PM wrote: > > > > > > > > > > > > Passed the voting by 8 +1 (5 binding and 3 non-binding) > > > > > > > > > > > > Closed. > > > > > > > > > > > > Best, > > > > > > Mattison > > > > > > On Jan 31, 2023, 06:57 +0800, mattisonc...@gmail.com, wrote: > > > > > > > Hello everyone. > > > > > > > > > > > > > > I would like to start the vote for PIP-242 > > > > > https://github.com/apache/pulsar/issues/19239, > > > > > > > Please let me know if you have any concerns or questions. > > > > > > > > > > > > > > Best, > > > > > > > Mattison > > > > > > > > > > > > > > --- Paste original PIP content to help quote -- > > > > > > > > > > > > > > ### Motivation > > > > > > > > > > > > > > Currently, the Apache Pulsar broker allows users to create a > topic > > > > > name that includes `-partition-`, which is confusing for our > > > developers to > > > > > identify whether this is a partition of a partitioned topic. Plus, > we > > > need > > > > > to add more logic to be compatible with this special topic name. > for > > > > > example: > > > > > > > > > > > > > > - https://github.com/apache/pulsar/pull/19240 > > > > > > > - https://github.com/apache/pulsar/pull/19230 > > > > > > > - https://github.com/apache/pulsar/pull/19171 > > > > > > > - https://github.com/apache/pulsar/pull/19086 > > > > > > > - ... > > > > > > > > > > > > > > ### Goal > > > > > > > This proposal wants `-partition-` to be a topic name keyword. > Users > > > > > can only create a topic with it if the topic is partitioned. For > the > > > > > compatibility reason, we want to Introduce a new configuration - > > > > > `enableStrictTopicName` for the broker to help reject creating a > topic > > > in > > > > > the following cases: > > > > > > > 1. Create a partitioned topic that includes `-partition-`. > > > > > > > 2. Create a topic which is not a partitioned topic. > > > > > > > > > > > > > > **Create a topic:** > > > > > > > _no corresponding partitioned topic_ > > > > > > > > > > > > > > - persistent://public/default/local-name (passed) > > > > > > > - persistent://public/default/local-name-partition-z (rejected > by > > > > > keyword) > > > > > > > - persistent://public/default/local-name-partition-0 (rejected > by > > > > > keyword) > > > > > > > > > > > > > > _Has corresponding partitioned topic, **partitions=2** and > topic > > > > > partition name is **persistent://public/default/local-name**_ > > > > > > > > > > > > > > - persistent://public/default/local-name-partition-0 (passed, > > > Because > > > > > it is the partition topic's sub-partition) > > > > > > > - persistent://public/default/local-name-partition-z (rejected > by > > > > > keyword) > > > > > > > - persistent://public/default/local-name-partition-4 (rejected, > > > > > Because it exceeds the number of maximum partitions) > > > > > > > > > > > > > > **Create a partitioned topic(topic metadata)** > > > > > > > > > > > > > > - persistent://public/default/local-name (passed) > > > > > > > - persistent://public/default/local-name-partition-z (rejected > by > > > > > keyword) > > > > > > > - persistent://public/default/local-name-partition-0 (rejected > by > > > > > keyword) > > > > > > > > > > >
Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 2
+1 (non-binding) python version:3 1. run Go SDK producer and use python SDK consumer to receive messages; 2. run Python SDK consumer and use Go SDK producer to send messages; -- Thanks Xiaolong Ran 丛搏 于2023年2月3日周五 13:39写道： > +1(binding) > os: mac 12.6 > python: 3.9.6 > > python3 ./examples/consumer.py > python3 ./examples/producer.py > > Thanks, > Bo > > Matteo Merli 于2023年2月3日周五 03:26写道： > > > > +1 > > -- > > Matteo Merli > > > > > > On Thu, Feb 2, 2023 at 5:57 AM Yunze Xu > wrote: > > > > > > This is the 2nd release candidate for Apache Pulsar Client Python, > > > version 3.1.0. > > > > > > It fixes the following issues: > > > https://github.com/apache/pulsar-client-python/milestone/2?closed=1 > > > > > > *** Please download, test and vote on this release. This vote will > > > stay open for at least 72 hours *** > > > > > > Python wheels: > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-python-3.1.0-candidate-2/ > > > > > > The supported python versions are 3.7, 3.8, 3.9, 3.10 and 3.11. The > > > supported platforms and architectures are: > > > - Windows x86_64 (windows/) > > > - glibc-based Linux x86_64 (linux-glibc-x86_64/) > > > - glibc-based Linux arm64 (linux-glibc-arm64/) > > > - musl-based Linux x86_64 (linux-musl-x86_64/) > > > - musl-based Linux arm64 (linux-musl-arm64/) > > > - macOS universal 2 (macos/) > > > > > > The tag to be voted upon: v3.1.0-candidate-2 > > > (fda50867a9c7bf927309527fade2f53eb3907bed) > > > > https://github.com/apache/pulsar-client-python/releases/tag/v3.1.0-candidate-2 > > > > > > Pulsar's KEYS file containing PGP keys you use to sign the release: > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > Please download the Python wheels and follow the README to test. >
Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 2
+1 (binding) - Checked the signature - Install the python .whl file (pip3 install pulsar_client-3.1.0-cp310-cp310-macosx_10_15_universal2.whl) on macOS - Start the standalone (master) - Start consumer (python3 ./examples/consumer.py) - Start producer (python3 ./examples/producer.py ) Regards Jiwei Guo (Tboy) On Sat, Feb 4, 2023 at 6:11 PM r...@apache.org wrote: > > +1 (non-binding) > > python version:3 > > 1. run Go SDK producer and use python SDK consumer to receive messages; > 2. run Python SDK consumer and use Go SDK producer to send messages; > > -- > Thanks > Xiaolong Ran > > 丛搏 于2023年2月3日周五 13:39写道： > > > +1(binding) > > os: mac 12.6 > > python: 3.9.6 > > > > python3 ./examples/consumer.py > > python3 ./examples/producer.py > > > > Thanks, > > Bo > > > > Matteo Merli 于2023年2月3日周五 03:26写道： > > > > > > +1 > > > -- > > > Matteo Merli > > > > > > > > > On Thu, Feb 2, 2023 at 5:57 AM Yunze Xu > > wrote: > > > > > > > > This is the 2nd release candidate for Apache Pulsar Client Python, > > > > version 3.1.0. > > > > > > > > It fixes the following issues: > > > > https://github.com/apache/pulsar-client-python/milestone/2?closed=1 > > > > > > > > *** Please download, test and vote on this release. This vote will > > > > stay open for at least 72 hours *** > > > > > > > > Python wheels: > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-python-3.1.0-candidate-2/ > > > > > > > > The supported python versions are 3.7, 3.8, 3.9, 3.10 and 3.11. The > > > > supported platforms and architectures are: > > > > - Windows x86_64 (windows/) > > > > - glibc-based Linux x86_64 (linux-glibc-x86_64/) > > > > - glibc-based Linux arm64 (linux-glibc-arm64/) > > > > - musl-based Linux x86_64 (linux-musl-x86_64/) > > > > - musl-based Linux arm64 (linux-musl-arm64/) > > > > - macOS universal 2 (macos/) > > > > > > > > The tag to be voted upon: v3.1.0-candidate-2 > > > > (fda50867a9c7bf927309527fade2f53eb3907bed) > > > > > > https://github.com/apache/pulsar-client-python/releases/tag/v3.1.0-candidate-2 > > > > > > > > Pulsar's KEYS file containing PGP keys you use to sign the release: > > > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > > > > > > > Please download the Python wheels and follow the README to test. > >
