+1 to me!

In our actual usage scenario, in the Broker 272 version, if we create a
topic with the -partition- keyword, new connections will be created
continuously, so we disabled the -partition- on the control side Keyword,
as described in PIP, does not allow users to carry the -partition- keyword
as the Topic name when creating a Topic.

I think it would be a more elegant option to support disabling the
-partition- keyword on the Broker side.

--

Thanks
Xiaolong Ran

Asaf Mesika <asaf.mes...@gmail.com> 于2023年2月2日周四 22:50写道:

> IMO the logic should be defined properly, and examples should help you
> understand it.
>
> Regarding last step
>
>
> >    1. Make enableStrictTopicName=true in the next major release.
> >
> > Maybe just delete the flag? Just always do it?
>
> On Mon, Jan 30, 2023 at 6:31 AM <mattisonc...@gmail.com> wrote:
>
> > Hi,  Asaf, Yunze
> > > You mean to say, if the topic is partitioned, the word "partition" can
> > notappear in the submitted topic name, in the topic creation API?
> > It's a little bit confusing. I will give some examples to help explain:
> >
> > Create a topic:
> >
> > • no corresponding partitioned topic
> >     • persistent://public/default/local-name (passed)
> >     • persistent://public/default/local-name-partition-z (rejected by
> > keyword)
> >     • persistent://public/default/local-name-partition-0 (rejected by
> > keyword)
> > • Has corresponding partitioned topic, partitions=2 and topic partition
> > name is persistent://public/default/local-name
> >     • persistent://public/default/local-name-partition-0 (passed, Because
> > it is the partition topic's sub-partition)
> >     • persistent://public/default/local-name-partition-z (rejected by
> > keyword)
> >     • persistent://public/default/local-name-partition-4 (rejected,
> > Because it exceeds the number of maximum partitions)
> >
> >
> > Create a partitioned topic(topic metadata)
> >
> > • persistent://public/default/local-name (passed)
> > • persistent://public/default/local-name-partition-z (rejected by
> keyword)
> > • persistent://public/default/local-name-partition-0 (rejected by
> keyword)
> >
> >
>
>
> > > I think this PIP should go close to this end to end, meaning the last
> > stepbeing making it default true.Otherwise, we end up having so many
> > "feature flags" turned off, it's hardto navigate and improve Pulsar.
> > Yes, we will add a warning log-in step 3 at the current release and
> enable
> > it by default in the next major release(3.0?).
> >
> > Thanks a lot!
> >
> > Best,
> > Mattison
> > On Jan 30, 2023, 00:17 +0800, Asaf Mesika <asaf.mes...@gmail.com>,
> wrote:
> > > You mean to say, if the topic is partitioned, the word "partition" can
> > not appear in the submitted topic name, in the topic creation API?
> >
>

Reply via email to