[GitHub] [pulsar-dotpulsar] blankensteiner closed issue #111: Support - SendTimeout for Producer Client

2022-10-14 Thread GitBox


blankensteiner closed issue #111: Support - SendTimeout for Producer Client
URL: https://github.com/apache/pulsar-dotpulsar/issues/111


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [ANNOUNCE] New Committer: Qiang Huang

2022-10-14 Thread Jiaqi Shen
Congratulations!

(Are you BUPTer?🤔 )

Thanks,
Jiaqi Shen


Jun Ma  于2022年10月14日周五 14:55写道:

> Congratulations, Qiang!
> 
> From: Xiangying Meng 
> Sent: Friday, October 14, 2022 14:17
> To: dev@pulsar.apache.org 
> Subject: Re: [ANNOUNCE] New Committer: Qiang Huang
>
> Congratulations Qiang Huang
>
> Thanks,
> Xiangying
>
> On Fri, Oct 14, 2022 at 2:04 PM Haiting Jiang 
> wrote:
>
> > Congratulations!
> >
> > Best,
> > Haiting
> >
> > On Fri, Oct 14, 2022 at 1:58 PM Max Xu  wrote:
> > >
> > > Congratulations! Qiang
> > >
> > > Best,
> > > Max Xu
> > >
> > >
> > > On Fri, Oct 14, 2022 at 12:04 PM guo jiwei 
> wrote:
> > >
> > > > The Project Management Committee (PMC) for Apache Pulsar has invited
> > > > Qiang Huang (https://github.com/hqebupt) to become a committer and
> > > > we are pleased to announce that he has accepted.
> > > >
> > > > Qiang Huang (with Github id: hqebupt) contributed many improvements
> > > > and bug fixes to Pulsar.
> > > >
> > > > Being a committer enables easier contribution to the project since
> > > > there is no need to go via the patch submission process. This should
> > > > enable better productivity.
> > > >
> > > > Welcome and Congratulations, Qiang Huang!
> > > >
> > > > Please join us in congratulating and welcoming Qiang Huang onboard!
> > > >
> > > >
> > > > Regards
> > > > Jiwei Guo on behalf of the Pulsar PMC
> > > >
> >
>


Re: [ANNOUNCE] New Committer: Qiang Huang

2022-10-14 Thread Nicolò Boschi
Congrats!
Nicolò Boschi


Il giorno ven 14 ott 2022 alle ore 09:18 Jiaqi Shen 
ha scritto:

> Congratulations!
>
> (Are you BUPTer?🤔 )
>
> Thanks,
> Jiaqi Shen
>
>
> Jun Ma  于2022年10月14日周五 14:55写道:
>
> > Congratulations, Qiang!
> > 
> > From: Xiangying Meng 
> > Sent: Friday, October 14, 2022 14:17
> > To: dev@pulsar.apache.org 
> > Subject: Re: [ANNOUNCE] New Committer: Qiang Huang
> >
> > Congratulations Qiang Huang
> >
> > Thanks,
> > Xiangying
> >
> > On Fri, Oct 14, 2022 at 2:04 PM Haiting Jiang 
> > wrote:
> >
> > > Congratulations!
> > >
> > > Best,
> > > Haiting
> > >
> > > On Fri, Oct 14, 2022 at 1:58 PM Max Xu  wrote:
> > > >
> > > > Congratulations! Qiang
> > > >
> > > > Best,
> > > > Max Xu
> > > >
> > > >
> > > > On Fri, Oct 14, 2022 at 12:04 PM guo jiwei 
> > wrote:
> > > >
> > > > > The Project Management Committee (PMC) for Apache Pulsar has
> invited
> > > > > Qiang Huang (https://github.com/hqebupt) to become a committer and
> > > > > we are pleased to announce that he has accepted.
> > > > >
> > > > > Qiang Huang (with Github id: hqebupt) contributed many improvements
> > > > > and bug fixes to Pulsar.
> > > > >
> > > > > Being a committer enables easier contribution to the project since
> > > > > there is no need to go via the patch submission process. This
> should
> > > > > enable better productivity.
> > > > >
> > > > > Welcome and Congratulations, Qiang Huang!
> > > > >
> > > > > Please join us in congratulating and welcoming Qiang Huang onboard!
> > > > >
> > > > >
> > > > > Regards
> > > > > Jiwei Guo on behalf of the Pulsar PMC
> > > > >
> > >
> >
>


[GitHub] [pulsar-client-node] shibd opened a new pull request, #235: [feat] Napi support package c++ static binary.

2022-10-14 Thread GitBox


shibd opened a new pull request, #235:
URL: https://github.com/apache/pulsar-client-node/pull/235

   ### Motivation
   
   Currently, users using the `node js client` must first install the `C++ 
client`. And when the user executes `npm install`, it also needs to be 
compiled. This is not user-friendly.
   
   This PR is to provide pre-built packages for all the supported environments, 
using [GYP]() and rebuild. The pre-built package is then uploaded to [`Github 
Release`](https://github.com/shibd/pulsar-client-node/releases/tag/v1.7.0-rc.10),
 and when the user installs the client, the system version is matched and the 
pre-built package is downloaded.
   
   Currently tested `linux_x86` and `mac_x86`. I've built it in my [fork 
repository](https://github.com/shibd/pulsar-client-node/releases/tag/v1.7.0-rc.10)
 and can install it directly using the following command (without first 
installing the C++ client).
   
   ```
   npm intall shibaodi-pulsar-client
   ```
   
   ### Modifications
   
    New Github workflows
   
   - When trigger release: 
  1. Build the binary C++ static library first(use new c++ client 3.0 
source).
  2. And use [node-pre-gyp](https://github.com/mapbox/node-pre-gyp) 
pre-built `napi` packages.
  3. Use 
[node-pre-gyp-github](https://github.com/bchr02/node-pre-gyp-github) publish 
this package to `GitHub Release`.
   - When trigger unit test(use ubuntu GitHub runner):
  1. Install c++ lib(use new c++ client 3.0 version).
  2. Use this c++ lib build `napi`.
  3. Use pulsar image start broker(use pulsar latest).
  5. Run the unit test.
   
   ### Documentation
   
   
   
   - [ ] `doc` 
   - [x] `doc-required` 
   - [ ] `doc-not-needed` 
   - [ ] `doc-complete` 
   
   ### TODO
   - [ ] Add pre-build windows binary package.
   - [ ] Change user docs.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [pulsar-client-node] BewareMyPower commented on a diff in pull request #235: [feat] Napi support package c++ static binary.

2022-10-14 Thread GitBox


BewareMyPower commented on code in PR #235:
URL: https://github.com/apache/pulsar-client-node/pull/235#discussion_r995500769


##
examples/encryption-consumer.js:
##
@@ -32,7 +32,7 @@ const Pulsar = require('pulsar-client');
 subscription: 'sub1',
 subscriptionType: 'Shared',
 ackTimeoutMs: 1,
-privateKeyPath: "./certificate/private-key.client-rsa.pem"
+privateKeyPath: "./test-test-conf/private-key.client-rsa.pem"

Review Comment:
   This path is appears to be wrong. It should be `./tests/test-conf`.
   
   BTW, you should not change JS code to adapt your test script. Instead, you 
should change your test script to adapt the existing code, which is a little 
different from Python client.



##
examples/encryption-consumer.js:
##
@@ -32,7 +32,7 @@ const Pulsar = require('pulsar-client');
 subscription: 'sub1',
 subscriptionType: 'Shared',
 ackTimeoutMs: 1,
-privateKeyPath: "./certificate/private-key.client-rsa.pem"
+privateKeyPath: "./test-test-conf/private-key.client-rsa.pem"

Review Comment:
   This path appears to be wrong. It should be `./tests/test-conf`.
   
   BTW, you should not change JS code to adapt your test script. Instead, you 
should change your test script to adapt the existing code, which is a little 
different from Python client.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [pulsar-helm-chart] hpvd commented on issue #294: [security] helm chart is outdated and includes images with 992 vulnerabilities (623 fixable)

2022-10-14 Thread GitBox


hpvd commented on issue #294:
URL: 
https://github.com/apache/pulsar-helm-chart/issues/294#issuecomment-1278684995

   @michaeljmarshall many thanks for starting looking in it that fast
   and especially your proposal to make a general approach set the ground to 
finally solve this (https://github.com/apache/pulsar-helm-chart/pull/299)!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [pulsar-helm-chart] hpvd commented on issue #294: [security] helm chart is outdated and includes images with 992 vulnerabilities (623 fixable)

2022-10-14 Thread GitBox


hpvd commented on issue #294:
URL: 
https://github.com/apache/pulsar-helm-chart/issues/294#issuecomment-1278686184

   just as background info, the security scanner used by artifacthub, providing 
results shown above
   is trivy, **so all the finding should be pretty valid**.
   
   For details, see:
   https://artifacthub.io/docs/topics/security_report/
   
   and trivy
   https://github.com/aquasecurity/trivy)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [pulsar-client-node] equanz commented on issue #78: Error: Failed to send message: AlreadyClosed

2022-10-14 Thread GitBox


equanz commented on issue #78:
URL: 
https://github.com/apache/pulsar-client-node/issues/78#issuecomment-1278689559

   @jbmusso
   If batchingEnabled is false(default), Producer#flush does nothing.
   From C++ v2.8.2, pending messages fail when Producer#close is called.
   https://github.com/apache/pulsar/pull/11570
   
https://github.com/apache/pulsar/blob/v2.8.2/pulsar-client-cpp/lib/ProducerImpl.cc#L609-L610
   
   To fix it, for example, simply await Producer#send.
   
   For more detail, please see: 
https://github.com/apache/pulsar-client-cpp/issues/51


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[DISCUSS] Release Pulsar Client Node.js 3.0.0

2022-10-14 Thread Baodi Shi
Hi, We're releasing C++ and python 3.0.0 client, Node.js Client is also built 
on C++, and I'd like to discuss whether to start working on Node.js Client 
3.0.0 as well.

In Node.js 3.0.0 Client, I mainly want to make the following changes:

1. Users no longer need to install the C++ client when using the Node Js 
client. This PR has already done some work: 
https://github.com/apache/pulsar-client-node/pull/235
2. Let the node client build based on C++ 3.0.0.


Maybe it can be iterated according to the current version number, but I think 
the three clients of Python, Node, and C++ are closely related. Therefore, it 
will be more unified for the Node.js client to start with 3.0.0.

Thanks
Baodi Shi


[GitHub] [pulsar-client-node] shibd commented on pull request #235: [feat] Napi support package c++ static binary.

2022-10-14 Thread GitBox


shibd commented on PR #235:
URL: 
https://github.com/apache/pulsar-client-node/pull/235#issuecomment-1278692145

   > Why do you rename the directory name from `certificate` to `test-conf`?
   
   Just for the unified, put all the test-related configurations together.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [pulsar-helm-chart] hpvd commented on pull request #299: Replace monitoring solution with kube-prometheus-stack dependency

2022-10-14 Thread GitBox


hpvd commented on PR #299:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/299#issuecomment-1278701720

   just did the same check for the proposed stack at artifacthub.
   
   There are (like in every project) some vulnerabilities, but
   - much fewer than we have today
   - no damn old ones
   - most of them could be fixed by minor version bumps of their dependencies
   - and they are moving fast
   
   
![2022-10-14_10h55_33](https://user-images.githubusercontent.com/5681880/195806288-507d1c74-db01-4ccd-b76c-19fd0db32d00.png)
   
   see 
https://artifacthub.io/packages/helm/prometheus-community/kube-prometheus-stack?modal=security-report
   
   
   
   -> so it looks fine to use it.
   
   Maybe one could point their community to the general view of their security 
scan results by opening an issue...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [pulsar-client-node] BewareMyPower commented on pull request #235: [feat] Napi support package c++ static binary.

2022-10-14 Thread GitBox


BewareMyPower commented on PR #235:
URL: 
https://github.com/apache/pulsar-client-node/pull/235#issuecomment-1278700978

   > Just for the unified
   
   There is no need to make two separate repositories consistent. What if the 
Python client repo renamed the directory or adjust the hierarchy later? **In 
this case, do you also want to sync the changes here?** People who are 
interested in Node.js client might not be interested in Python client. That's 
why do we separate C++/Python repos.
   
   From my perspective, if you have a huge PR, please remove unnecessary 
changes as much as possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [ANNOUNCE] New Committer: Qiang Huang

2022-10-14 Thread r...@apache.org
Congratulations Qiang Huang

--
Thanks
XiaolongRan

Nicolò Boschi  于2022年10月14日周五 15:23写道:

> Congrats!
> Nicolò Boschi
>
>
> Il giorno ven 14 ott 2022 alle ore 09:18 Jiaqi Shen <
> gleiphir2...@gmail.com>
> ha scritto:
>
> > Congratulations!
> >
> > (Are you BUPTer?🤔 )
> >
> > Thanks,
> > Jiaqi Shen
> >
> >
> > Jun Ma  于2022年10月14日周五 14:55写道:
> >
> > > Congratulations, Qiang!
> > > 
> > > From: Xiangying Meng 
> > > Sent: Friday, October 14, 2022 14:17
> > > To: dev@pulsar.apache.org 
> > > Subject: Re: [ANNOUNCE] New Committer: Qiang Huang
> > >
> > > Congratulations Qiang Huang
> > >
> > > Thanks,
> > > Xiangying
> > >
> > > On Fri, Oct 14, 2022 at 2:04 PM Haiting Jiang 
> > > wrote:
> > >
> > > > Congratulations!
> > > >
> > > > Best,
> > > > Haiting
> > > >
> > > > On Fri, Oct 14, 2022 at 1:58 PM Max Xu  wrote:
> > > > >
> > > > > Congratulations! Qiang
> > > > >
> > > > > Best,
> > > > > Max Xu
> > > > >
> > > > >
> > > > > On Fri, Oct 14, 2022 at 12:04 PM guo jiwei 
> > > wrote:
> > > > >
> > > > > > The Project Management Committee (PMC) for Apache Pulsar has
> > invited
> > > > > > Qiang Huang (https://github.com/hqebupt) to become a committer
> and
> > > > > > we are pleased to announce that he has accepted.
> > > > > >
> > > > > > Qiang Huang (with Github id: hqebupt) contributed many
> improvements
> > > > > > and bug fixes to Pulsar.
> > > > > >
> > > > > > Being a committer enables easier contribution to the project
> since
> > > > > > there is no need to go via the patch submission process. This
> > should
> > > > > > enable better productivity.
> > > > > >
> > > > > > Welcome and Congratulations, Qiang Huang!
> > > > > >
> > > > > > Please join us in congratulating and welcoming Qiang Huang
> onboard!
> > > > > >
> > > > > >
> > > > > > Regards
> > > > > > Jiwei Guo on behalf of the Pulsar PMC
> > > > > >
> > > >
> > >
> >
>


RE: [VOTE] Pulsar Node.js Client Release 1.7.0 Candidate 2

2022-10-14 Thread Masahiro Sakamoto
Thanks Yuri. I agree with you and will change my vote to +1.

+1 (binding)

* Checked the license headers
* Verified the checksum and signature
* Built the source and ran producer/consumer

Regards,

Masahiro Sakamoto
Yahoo Japan Corp.
E-mail: massa...@yahoo-corp.jp

-Original Message-
From: Yuri Mizushima  
Sent: Friday, October 14, 2022 12:56 PM
To: dev@pulsar.apache.org
Subject: Re: [VOTE] Pulsar Node.js Client Release 1.7.0 Candidate 2

Hi Masahiro,

It seems the C++ client causes the AlreadyClosed issue.
https://github.com/apache/pulsar-client-cpp/issues/51

I think this issue doesn't block releasing new Node.js client.
What do you think?

Thanks,
--
Yuri Mizushima
yumiz...@yahoo-corp.jp


"Masahiro Sakamoto"  wrote:

-1 (binding)

I almost always get "Failed to send message: AlreadyClosed" errors when running 
the following code:
##
$ cat producer.js
const Pulsar = require('./index.js');

(async () => {
  const client = new Pulsar.Client({
serviceUrl: 'pulsar://localhost:6650',
  });

  const producer = await client.createProducer({
topic: 'persistent://public/default/t1',
batchingEnabled: false,
  });

  for (let i = 0; i < 10; i += 1) {
const msg = `my-message-${i}`;
producer.send({
  data: Buffer.from(msg),
});
console.log(`Sent message: ${msg}`);
  }
  await producer.flush();

  await producer.close();
  await client.close();
})();
$ node producer.js
Sent message: my-message-0
Sent message: my-message-1
Sent message: my-message-2
Sent message: my-message-3
Sent message: my-message-4
Sent message: my-message-5
Sent message: my-message-6
Sent message: my-message-7
Sent message: my-message-8
Sent message: my-message-9
(node:18572) UnhandledPromiseRejectionWarning: Error: Failed to send message: 
AlreadyClosed
(Use `node --trace-warnings ...` to show where the warning was created)
(node:18572) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
This error originated either by throwing inside of an async function without a 
catch block, or by rejecting a promise which was not handled with .catch(). To 
terminate the node process on unhandled promise rejection, use the CLI flag 
`--unhandled-rejections=strict` (see 
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fnodejs.org%2Fapi%2Fcli.html%23cli_unhandled_rejections_mode&data=05%7C01%7Cmassakam%40yahoo-corp.jp%7C9336663396fd4393d75508daad98220f%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C638013166172129841%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BZap9Q1gEK6HI%2Fq3KR3USXg1TBexbdPHG%2FgBFvCaxtc%3D&reserved=0).
 (rejection id: 1)
(node:18572) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
deprecated. In the future, promise rejections that are not handled will 
terminate the Node.js process with a non-zero exit code.
(node:18572) UnhandledPromiseRejectionWarning: Error: Failed to send message: 
AlreadyClosed
(node:18572) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
This error originated either by throwing inside of an async function without a 
catch block, or by rejecting a promise which was not handled with .catch(). To 
terminate the node process on unhandled promise rejection, use the CLI flag 
`--unhandled-rejections=strict` (see 
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fnodejs.org%2Fapi%2Fcli.html%23cli_unhandled_rejections_mode&data=05%7C01%7Cmassakam%40yahoo-corp.jp%7C9336663396fd4393d75508daad98220f%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C638013166172129841%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BZap9Q1gEK6HI%2Fq3KR3USXg1TBexbdPHG%2FgBFvCaxtc%3D&reserved=0).
 (rejection id: 2)
(node:18572) UnhandledPromiseRejectionWarning: Error: Failed to send message: 
AlreadyClosed
(node:18572) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
This error originated either by throwing inside of an async function without a 
catch block, or by rejecting a promise which was not handled with .catch(). To 
terminate the node process on unhandled promise rejection, use the CLI flag 
`--unhandled-rejections=strict` (see 
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fnodejs.org%2Fapi%2Fcli.html%23cli_unhandled_rejections_mode&data=05%7C01%7Cmassakam%40yahoo-corp.jp%7C9336663396fd4393d75508daad98220f%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C638013166172129841%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2BZap9Q1gEK6HI%2Fq3KR3USXg1TBexbdPHG%2FgBFvCaxtc%3D&reserved=0).
 (rejection id: 3)
(node:18572) UnhandledPromiseRejectionWarning: Error: Failed to send message: 
AlreadyClosed
(node:18572) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
This error originated either by throwing inside of an async function without a 
catch block, or by reject

[GitHub] [pulsar-helm-chart] hpvd commented on pull request #299: Replace monitoring solution with kube-prometheus-stack dependency

2022-10-14 Thread GitBox


hpvd commented on PR #299:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/299#issuecomment-1278733100

   @michaeljmarshall 
   since this will be some work and will probably trigger a major version bump,
   what do you think of releasing in the meantime a last updated version of 2.x 
- with no other changes than containing pulsar 2.10.1?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [pulsar-client-node] shibd commented on pull request #235: [feat] Napi support package c++ static binary.

2022-10-14 Thread GitBox


shibd commented on PR #235:
URL: 
https://github.com/apache/pulsar-client-node/pull/235#issuecomment-1278797419

   > From my perspective, if you have a huge PR, please remove unnecessary 
changes as much as possible.
   
   Make sense. I removed unnecessary changes. PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [pulsar-dotpulsar] amareshmad commented on issue #114: When i run test console app consumer is creating and when i integrate same to actual product consumer is not creating and going to Fault

2022-10-14 Thread GitBox


amareshmad commented on issue #114:
URL: 
https://github.com/apache/pulsar-dotpulsar/issues/114#issuecomment-1279135449

   tried with setting VerifyCertificateAuthority ,VerifyCertificateName it 
didn't help.
   
   tried with setting registry as well didn't help.
   [HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\.NETFramework\v2.0.50727]
 "SystemDefaultTlsVersions" = dword:0001
 "SchUseStrongCrypto" = dword:0001
   [HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\.NETFramework\v4.0.30319]
 "SystemDefaultTlsVersions" = dword:0001
 "SchUseStrongCrypto" = dword:0001
   
   Product code was in 4.5, migrated to 4.8 & verified existing messaging 
system (active mq ) started working then after I started migrating to pulsar.
   
   
   I can see from Wireshark log for both. from product we are getting 
connection is terminating.
   
   Test .net framework console app connection 
   DNS   93 Standard query 0x9e7c A xx.com
   DNS   141Standard query response 0x9e7c A xx.com A 
xx.xxx.xxx.xxx A xx.xxx.xxx.xxx
   TCP66   60427 → 6651 [SYN, ECE, CWR] Seq=0 Win=8192 Len=0 
MSS=1460 WS=256 SACK_PERM
   TCP66   58908 → 799 [ACK] Seq=13933 Ack=793324 Win=6523 
Len=0 TSval=2310068914 TSecr=341545951
   TCP66   6651 → 60427 [SYN, ACK] Seq=0 Ack=1 Win=26883 Len=0 
MSS=1460 SACK_PERM WS=128
   TCP54   60427 → 6651 [ACK] Seq=1 Ack=1 Win=262656 Len=0
   TCP56   6651 → 60427 [ACK] Seq=1 Ack=202 Win=28032 Len=0
   TLSv1.2 1514 Server Hello
   TLSv1.2 1160 Certificate, Server Key Exchange, Certificate Request, 
Server Hello Done
   TCP54   60427 → 6651 [ACK] Seq=202 Ack=2567 Win=262656 Len=0
   TLSv1.2 187  Certificate, Client Key Exchange, Change Cipher Spec, 
Encrypted Handshake Message
   TLSv1.2 255  Client Hello
   
   From actual product code log
   DNS   93 Standard query 0xb556 A 
   DNS   141Standard query response 0xb556 A xx.com A 
xx.xxx.xxx.xxx A xx.xxx.xxx.xxx
   TCP66   57823 → 6651 [SYN, ECE, CWR] Seq=0 Win=8192 Len=0 
MSS=1460 WS=256 SACK_PERM
   TCP66   6651 → 57823 [SYN, ACK] Seq=0 Ack=1 Win=26883 Len=0 
MSS=1460 SACK_PERM WS=128
   TCP54   57823 → 6651 [ACK] Seq=1 Ack=1 Win=262656 Len=0
   TCP54   57823 → 6651 [FIN, ACK] Seq=1 Ack=1 Win=262656 Len=0
   TCP56   6651 → 57823 [FIN, ACK] Seq=1 Ack=2 Win=27008 Len=0
   TCP54   57823 → 6651 [ACK] Seq=2 Ack=2 Win=262656 Len=0
   
   I don't have any idea on how to procced (validate 
TrustedCertificateAuthority, VerifyCertificateAuthority and 
VerifyCertificateName) now onwards.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [pulsar-helm-chart] michaeljmarshall commented on issue #290: Release Pulsar Helm Chart in GitHub Pages flavor

2022-10-14 Thread GitBox


michaeljmarshall commented on issue #290:
URL: 
https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1279300054

   The airflow process is defined here 
https://github.com/apache/airflow/blob/main/dev/README_RELEASE_HELM_CHART.md. I 
will take a closer look at it and see if we can learn from their process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [DISCUSS] Release Pulsar Client Node.js 3.0.0

2022-10-14 Thread Matteo Merli
Hi Baodi,

I'd suggest first getting the changes for pre-compiled binaries to be
merged, tested, and expanded to support more combinations of
os/cpu/nodejs. eg: mac-arm64, linux-alpine, etc..

Regarding the version number, 3.0 was adopted for C++ and Python
because we had to detach from the main Pulsar release and we needed
this number to be > 2.11 to avoid going back in time.

pulsar-client-node already has its own release versioning and I don't
think we necessarily need to match the C++ client version, especially
since we're working on getting the user to not need to know which c++
client is actually underneath.


--
Matteo Merli


On Fri, Oct 14, 2022 at 1:47 AM Baodi Shi
 wrote:
>
> Hi, We're releasing C++ and python 3.0.0 client, Node.js Client is also built 
> on C++, and I'd like to discuss whether to start working on Node.js Client 
> 3.0.0 as well.
>
> In Node.js 3.0.0 Client, I mainly want to make the following changes:
>
> 1. Users no longer need to install the C++ client when using the Node Js 
> client. This PR has already done some work: 
> https://github.com/apache/pulsar-client-node/pull/235
> 2. Let the node client build based on C++ 3.0.0.
>
>
> Maybe it can be iterated according to the current version number, but I think 
> the three clients of Python, Node, and C++ are closely related. Therefore, it 
> will be more unified for the Node.js client to start with 3.0.0.
>
> Thanks
> Baodi Shi


[GitHub] [pulsar-helm-chart] michaeljmarshall opened a new pull request, #300: Remove GitHub Action Workflows that release the chart

2022-10-14 Thread GitBox


michaeljmarshall opened a new pull request, #300:
URL: https://github.com/apache/pulsar-helm-chart/pull/300

   Relates to: https://github.com/apache/pulsar-helm-chart/issues/290
   
   ### Motivation
   
   We should not use GitHub Actions to release the helm chart. As such, we can 
remove the relevant workflow code from this repo while we build the relevant 
process to officially release the helm chart.
   
   The main risk with this kind of change is that we won't have a way to 
"release" the chart. However, it is relevant to point out that we have not had 
any official releases of the chart given that the PMC has not been voting on 
the releases. I think we need to prioritize fixing this process as a community.
   
   ### Modifications
   
   * Remove all scripts and configuration files that enabled GitHub Actions to 
release the helm chart.
   
   ### Verifying this change
   
   I'll need to some help making sure this change is sufficient.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a diff in pull request #274: Bump Apache Pulsar 2.10.1

2022-10-14 Thread GitBox


michaeljmarshall commented on code in PR #274:
URL: https://github.com/apache/pulsar-helm-chart/pull/274#discussion_r996038428


##
charts/pulsar/Chart.yaml:
##
@@ -18,10 +18,10 @@
 #
 
 apiVersion: v2
-appVersion: "2.9.2"
+appVersion: "2.10.1"
 description: Apache Pulsar Helm chart for Kubernetes
 name: pulsar
-version: 2.9.3
+version: 2.10.1

Review Comment:
   Can we decouple this PR from the version bump? I know we have historically 
had a process to bump the version here and trigger a release, but I think we 
should make releases align with the official Apache Release process. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [pulsar-helm-chart] michaeljmarshall merged pull request #284: Add nodeSelector to cluster initialize pod

2022-10-14 Thread GitBox


michaeljmarshall merged PR #284:
URL: https://github.com/apache/pulsar-helm-chart/pull/284


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [DISCUSS] PIP-212: Default reppDnsResolverClass to ZkBookieRackAffinityMapping

2022-10-14 Thread Michael Marshall
For the sake of the VOTE, I am classifying this as a bug and plan to
cherry pick it to all active release branches.

Thanks,
Michael

On Tue, Oct 11, 2022 at 2:59 PM Michael Marshall  wrote:
>
> Hi All,
>
> I created PIP 212: https://github.com/apache/pulsar/issues/18012. It
> already has a PR https://github.com/apache/pulsar/pull/15640. It is a
> minor change that I view as more of a bug fix, but because it changes
> a default value, it needs a PIP.
>
> The main point for discussion is whether we can cherry pick this to
> active release branches. My view is that it should be cherry picked
> because the feature doesn't work out of the box.
>
> If there isn't much discussion, I'll start a vote later this week.
>
> Thanks,
> Michael
>
>
> ### Motivation
>
> The current Bookkeeper configuration defaults to using
> `org.apache.bookkeeper.net.ScriptBasedMapping` for the
> `DNSToSwitchMapping` implementation. However, this default
> configuration does not align with the Broker's default configuration,
> which is `org.apache.pulsar.zookeeper.ZkBookieRackAffinityMapping`. As
> such, the default configuration for a Pulsar cluster does not lead to
> ideal rack awareness when ledgers need to be recovered. The result is
> that a user can configure a cluster for rack awareness and the brokers
> will honor that configuration, but the autorecovery process will not
> because it does not have the correct bookkeeper cluster topology view.
>
> I propose we configure bookkeeper to use the broker's
> `ZkBookieRackAffinityMapping` class. That way, autorecovery will honor
> the operator's configured rack awareness policies out of the box.
>
> ### Goal
>
> Ensure consistent rack awareness policies.
>
> I propose this is a bug fix that requires patching all active versions
> of Pulsar.
>
> ### API Changes
>
> None
>
> ### Implementation
>
> See https://github.com/apache/pulsar/pull/15640.
>
> Add default value for `reppDnsResolverClass` to the
> `conf/bookkeeper.conf` configuration. This change effectively switches
> the default from `org.apache.bookkeeper.net.ScriptBasedMapping` to
> `org.apache.pulsar.zookeeper.ZkBookieRackAffinityMapping`.
>
> ### Alternatives
>
> The tradeoff is that a user relying on the `ScriptBasedMapping`
> default might accidentally get switched to using the
> `ZkBookieRackAffinityMapping` implementation. Given that
> `ScriptBasedMapping` doesn't work out of the box, and that the
> broker's default to `ZkBookieRackAffinityMapping`, I think this is an
> acceptable tradeoff.
>
> ### Anything else?
>
> I manually verified that the `ZkBookieRackAffinityMapping` works by
> running some tests in a minikube cluster deployed with the DataStax
> helm chart for Apache Pulsar. I set up 3 racks, 4 bookies, and a topic
> with a E=2, Qw=2, and Qa=2. I then verified that the autorecovery pod
> correctly discovered the racks and then identified when an ensemble
> was not following the rack placement policy after two bookies were
> removed. I documented my testing a bit more here:
> https://github.com/datastax/pulsar-helm-chart/pull/214.


[VOTE] PIP-212: Default reppDnsResolverClass to ZkBookieRackAffinityMapping

2022-10-14 Thread Michael Marshall
Hi All,

I am starting the vote for PIP 212: Default reppDnsResolverClass to
ZkBookieRackAffinityMapping.
https://github.com/apache/pulsar/issues/18012

Here is the discussion thread:
https://lists.apache.org/thread/188nq3vcs40cwdwj5z2jon0ryfqh3wbg

The vote will be open for at least 3 days.

Note that just before sending this email, I sent a note to the
discussion thread classifying the current configuration as a bug and
indicating that I will cherry pick this change to all active release
branches, assuming it is accepted.

Thanks,
Michael


[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #114: When i run test console app consumer is creating and when i integrate same to actual product consumer is not creating and going to F

2022-10-14 Thread GitBox


blankensteiner commented on issue #114:
URL: 
https://github.com/apache/pulsar-dotpulsar/issues/114#issuecomment-1279428552

   It sounds like something is broken in the production app. Maybe some 
dependencies or settings are lingering from when it was .NET Framework 4.5. 
   Possibly related to SSL/TLS, I can't really say.
   If possible, you could create the solution from scratch (using .NET 
Framework 4.8) and then copy/paste the code from the old solution into the new 
solution. Using the new .csproc format (+nuget dependencies within the project 
file) and appsettings.json (or a clean configuration file). Just to get a 
relatively clean slate to work with.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [VOTE] Pulsar Client C++ Release 3.0.0 Candidate 2

2022-10-14 Thread Matteo Merli
I'm canceling this vote again.

There is an issue that was recently discovered, around an
inconsistencies in the validation of topic names in C++ (compared with
Java client and broker).
PTAL: https://github.com/apache/pulsar-client-cpp/pull/52

I'll send out an rc-3 once this is merged.


--
Matteo Merli


On Thu, Oct 13, 2022 at 10:26 AM Matteo Merli  wrote:
>
> This is the first release candidate for Apache Pulsar Client C++, version 
> 3.0.0.
>
> It fixes the following issues:
> https://github.com/apache/pulsar-client-cpp/milestone/1?closed=1
>
> *** Please download, test and vote on this release. This vote will stay open
> for at least 72 hours ***
>
> Note that we are voting upon the source (tag), binaries are provided for
> convenience.
>
> Source and binary files:
> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp-3.0.0-candidate-2/
>
> SHA-512 checksums:
> 22c72d158bdabe3080571b7aaf301bf8197ed016060b2c5e79335ed4791106f1eec3abae54e56c06aa98394e49a7afe70b5f68891586d09eb64189dceb535910
>  ./apache-pulsar-client-cpp-3.0.0.tar.gz
>
> The tag to be voted upon:
> v3.0.0-candidate-2 (d9706b379a28731556a51e97c1cf251d3ffcd461)
> https://github.com/apache/pulsar-client-cpp/releases/tag/v3.0.0-candidate-2
>
> Pulsar's KEYS file containing PGP keys you use to sign the release:
> https://dist.apache.org/repos/dist/dev/pulsar/KEYS
>
> Please download the source package, and follow the README to compile and test.
> --
> Matteo Merli
> 


[GitHub] [pulsar-helm-chart] michaeljmarshall opened a new pull request, #301: New Release Process

2022-10-14 Thread GitBox


michaeljmarshall opened a new pull request, #301:
URL: https://github.com/apache/pulsar-helm-chart/pull/301

   Fixes #290
   
   ### Motivation
   
   Make the Apache Pulsar Helm Chart release follow ASF rules for voting, and 
make the helm binary available via dist.apache.org. By following the 
information in https://issues.apache.org/jira/browse/LEGAL-573 and in the 
Apache Airflow project 
https://github.com/apache/airflow/blob/main/dev/README_RELEASE_HELM_CHART.md, I 
built this new release process. It will likely need some iterative improvement.
   
   ### Modifications
   
   * Add a release process that is based on the Apache Airflow release process
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[DISCUSS] Helm Chart Updates and Release Process

2022-10-14 Thread Michael Marshall
Hi Pulsar Community,

I propose that we update our Helm Chart release process so that it
follows the ASF guidelines. My proposed process is in this PR [0]. I
built it by copying the Apache Airflow release process [1] and
modifying it to fit the Apache Pulsar project. The git history shows
my changes.

Please let me know what you think about adopting a new process.

We also need to address several outdated dependencies in our chart
[2]. I started by creating [3] and [4], but I think it would make more
sense to make a breaking change and start using the
kube-prometheus-stack [5] as a helm dependency. Finally, we should
update the helm chart to use 2.10.1. That work is here [6].

Please review the relevant PRs and provide any feedback.

Once we finalize the process, I volunteer to be the first release manager.

Thanks,
Michael

[0] https://github.com/apache/pulsar-helm-chart/pull/301
[1] https://github.com/apache/airflow/blob/main/dev/README_RELEASE_HELM_CHART.md
[2] https://github.com/apache/pulsar-helm-chart/issues/294
[3] https://github.com/apache/pulsar-helm-chart/pull/296
[4] https://github.com/apache/pulsar-helm-chart/pull/297
[5] https://github.com/apache/pulsar-helm-chart/pull/299
[6] https://github.com/apache/pulsar-helm-chart/pull/274


[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #299: Replace monitoring solution with kube-prometheus-stack dependency

2022-10-14 Thread GitBox


michaeljmarshall commented on PR #299:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/299#issuecomment-1279519673

   > @michaeljmarshall since this will be some work and will probably trigger a 
major version bump, what do you think of releasing in the meantime a last 
updated version of 2.x - with no other changes than containing pulsar 2.10.1?
   > 
   > next version with new monitoring stack, could than directly start with 
pulsar 2.11 as pulsar helm 3.0
   
   I think we need to understand why #274 stalled first. I am working on fixing 
the release process too, so there will be a slight delay in getting these fixes 
delivered. However, once the new release process is in place, I expect that we 
will be able to ship releases more frequently.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org