BewareMyPower commented on code in PR #235:
URL: https://github.com/apache/pulsar-client-node/pull/235#discussion_r995500769
##########
examples/encryption-consumer.js:
##########
@@ -32,7 +32,7 @@ const Pulsar = require('pulsar-client');
subscription: 'sub1',
subscriptionType: 'Shared',
ackTimeoutMs: 10000,
- privateKeyPath: "./certificate/private-key.client-rsa.pem"
+ privateKeyPath: "./test-test-conf/private-key.client-rsa.pem"
Review Comment:
This path is appears to be wrong. It should be `./tests/test-conf`.
BTW, you should not change JS code to adapt your test script. Instead, you
should change your test script to adapt the existing code, which is a little
different from Python client.
##########
examples/encryption-consumer.js:
##########
@@ -32,7 +32,7 @@ const Pulsar = require('pulsar-client');
subscription: 'sub1',
subscriptionType: 'Shared',
ackTimeoutMs: 10000,
- privateKeyPath: "./certificate/private-key.client-rsa.pem"
+ privateKeyPath: "./test-test-conf/private-key.client-rsa.pem"
Review Comment:
This path appears to be wrong. It should be `./tests/test-conf`.
BTW, you should not change JS code to adapt your test script. Instead, you
should change your test script to adapt the existing code, which is a little
different from Python client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
