date:20220324

Re: [Guideline] Pulsar PR Naming Convention

2022-03-24 Thread Lari Hotari

The problem with the "Pulsar PR Naming Convention" is that it can conflict with 
general Git message conventions. 

The PR title automatically becomes the Git commit's subject line. That's how 
the PR title related to the Git commit's subject line (title).

In Git, the convention is to have a subject line (title) with no more than 50 
characters. When you start adding all kinds of tags in brackets in the title, 
there won't be much left for the actual content.

For example, GitHub's UI suggests to write commit messages that are less than 
50 characters. There's more explanation about the "Limit the subject line to 50 
characters" rule in Chris Beam's awesome "How to Write a Git Commit Message" 
blog post: https://cbea.ms/git-commit/#limit-50

Do we care about the general rule that a git commit message should be limited 
to 50 characters?

-Lari

On 2022/03/17 02:11:54 Yu wrote:
> Hi Pulsarers,
> 
> We submit or review PRs almost every day, we might see many vague and
> unclear PR titles that decrease team efficiency and productivity.
> 
> Good PR titles offer bring many benefits, such as speeding up the review
> process and improving search efficiency.
> 
> To solve the vague PR title issue and move *PIP 112: Generate Release Notes
> Automatically* [1] forward, I've created *Guideline: Pulsar PR Naming
> Convention* [2], which explains why you need good PR titles and how you do
> that with various self-explanatory examples. Also, Pulsar and client
> release notes will be generated automatically based on the rules defined in
> this guide.
> 
> Do not hesitate to comment if you have any questions or concerns. Feedback
> before EOD 3/21 CST is highly appreciated, thanks!
> 
> [1]
> https://docs.google.com/document/d/1Ul2qIChDe8QDlDwJBICq1VviYZhdk1djKJJC5wXAGsI/edit#
> 
> [2]
> https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#
> 
> Regards,
> Anonymitaet
>

RE: [VOTE] Pulsar Release 2.10.0 Candidate 4

2022-03-24 Thread Masahiro Sakamoto

Hi, I noticed that the binary package contains BookKeeper libraries compiled on 
Mac instead of Linux.

$ unzip -t lib/org.apache.bookkeeper-circe-checksum-4.14.4.jar | grep lib/lib

testing: lib/libcirce-checksum.jnilib   OK

$ unzip -t lib/org.apache.bookkeeper-cpu-affinity-4.14.4.jar | grep lib/lib

testing: lib/libcpu-affinity.jnilib   OK

The same thing happened when voting for v2.9.0, which caused the vote to be 
cancelled. Should it be fixed this time as well?
https://lists.apache.org/thread/gsbh95b2d9xtcg5fmtxpm9k9q6w68gd2

Regards,

Masahiro Sakamoto
Yahoo Japan Corp.
E-mail: massa...@yahoo-corp.jp

-Original Message-
From: r...@apache.org  
Sent: Wednesday, March 23, 2022 5:14 PM
To: Dev 
Subject: Re: [VOTE] Pulsar Release 2.10.0 Candidate 4

+1(non-binding)

Validate Go SDK
Validate Pub/Sub and Java Functions

--

Thanks
Xiaolong Ran

Matteo Merli  于2022年3月23日周三 15:06写道：

> +1
>
> Checked:
>  * Signatures
>  * Bin distribution:
>  - NOTICE, README, LICENSE
>  - Start standalone service and producer/consumer test
>  * Src distribution:
>  - NOTICE,  README, LICENSE
>  - Compile and unit tests
>  - Start standalone service
>  * Checked staging maven repository artifacts
>  * Checked docker images
>
>
>
> --
> Matteo Merli
> 
>
> On Tue, Mar 22, 2022 at 7:17 PM Haiting Jiang 
> wrote:
> >
> > +1
> >
> > - Compiled the source
> > - Checked checksums and signatures
> > - Validate Pub/Sub and Java Functions
> > - Validate Connectors
> > - Validate Stateful Functions
> >
> > Thanks
> > Haiting
> >
> > On 2022/03/22 01:52:36 PengHui Li wrote:
> > > This is the fourth release candidate for Apache Pulsar 2.10.0
> > >
> > > It fixes the following issues:
> > >
> https://github.com/apache/pulsar/pulls?q=is%3Apr+milestone%3A2.10.0+is%3Amerged+-label%3Arelease%2F2.9.1+-label%3Arelease%2F2.9.2
> > >
> > > *** Please download, test and vote on this release. This vote will
> stay open
> > > for at least 72 hours ***
> > >
> > > Note that we are voting upon the source (tag), binaries are provided
> for
> > > convenience.
> > >
> > > Source and binary files:
> > >
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2Fpulsar-2.10.0-candidate-4%2F&data=04%7C01%7Cmassakam%40yahoo-corp.jp%7Cc45307db50f1431ebf4108da0ca51318%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637836201936167509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=PcY63TeS2fukr%2Fn7zrvso6IY%2FNSFS1ldjDNM%2Fi0tzqs%3D&reserved=0
> > >
> > > SHA-512 checksums:
> > >
> > >
> f4ff0c5e06b7c09a6508f106be4287b47f4dfa6c2e1ec88d6a38ee767731428fde183ed2ce778aff89aece8fb1b06d5f1ada982817545be9a11c6e146913f7ab
> > > apache-pulsar-2.10.0-bin.tar.gz
> > >
> > >
> 1f6c98c6dede135a73858d29be055a76a178b31b861dd8ef4ef33cb7951f95fc13a5c5ad5bee35abb0ad6420b4d7a763175c46cb1f90786fe865fd075e4d85c6
> > > apache-pulsar-2.10.0-src.tar.gz
> > >
> > > Maven staging repo:
> > >
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachepulsar-1154%2F&data=04%7C01%7Cmassakam%40yahoo-corp.jp%7Cc45307db50f1431ebf4108da0ca51318%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637836201936167509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=A%2B9834yzCKElQICStfvxUdBjsKstw3dWFxzuNW3OBP4%3D&reserved=0
> > >
> > > The tag to be voted upon:
> > > v2.10.0-candidate-3 (6d3fbbea4e9aaaf183ff4117d368b19d9ab6ad7e)
> > > https://github.com/apache/pulsar/releases/tag/v2.10.0-candidate-4
> > >
> > > Pulsar's KEYS file containing PGP keys we use to sign the release:
> > > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2FKEYS&data=04%7C01%7Cmassakam%40yahoo-corp.jp%7Cc45307db50f1431ebf4108da0ca51318%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637836201936167509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=jDY%2BxI7KXfMaZmk3fXORma0bn6sshoHCn2W2EGAf6nc%3D&reserved=0
> > >
> > > Docker images:
> > >
> > >
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhub.docker.com%2Flayers%2F198540978%2Flph890127%2Fpulsar%2F2.10.0-rc4%2Fimages%2Fsha256-e4e3a6593ff3d7ca4b5ffca718fdb423370d2566fb34efadf5a69423331a04ff%3Fcontext%3Drepo&data=04%7C01%7Cmassakam%40yahoo-corp.jp%7Cc45307db50f1431ebf4108da0ca51318%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637836201936167509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=f8IBoJO7a%2BGB0SBxzv1l%2Fcbf%2FavHgkLz9fVVuRUza0U%3D&reserved=0
> > >
> > >
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhub.docker.com%2Flayers%2F198537125%2Flph890127%2Fpulsar-all%2F2.10.0-rc4%2Fimages%2Fsha256-53b6d69920b5b2115e147f6ed54a4bcef65fb0855dbced8a7ad5d45b2dd5c776%3Fcontext%3Drepo&data=04%7C01%7C

Re: [VOTE] Pulsar Release 2.10.0 Candidate 4

2022-03-24 Thread PengHui Li

Thanks,

I will clean up my local bookkeeper build cache and cut a new RC.

Penghui

On Thu, Mar 24, 2022 at 6:33 PM Masahiro Sakamoto 
wrote:

> Hi, I noticed that the binary package contains BookKeeper libraries
> compiled on Mac instead of Linux.
>
> $ unzip -t lib/org.apache.bookkeeper-circe-checksum-4.14.4.jar | grep
> lib/lib
>
> testing: lib/libcirce-checksum.jnilib   OK
>
> $ unzip -t lib/org.apache.bookkeeper-cpu-affinity-4.14.4.jar | grep lib/lib
>
> testing: lib/libcpu-affinity.jnilib   OK
>
> The same thing happened when voting for v2.9.0, which caused the vote to
> be cancelled. Should it be fixed this time as well?
> https://lists.apache.org/thread/gsbh95b2d9xtcg5fmtxpm9k9q6w68gd2
>
> Regards,
>
> Masahiro Sakamoto
> Yahoo Japan Corp.
> E-mail: massa...@yahoo-corp.jp
>
> -Original Message-
> From: r...@apache.org 
> Sent: Wednesday, March 23, 2022 5:14 PM
> To: Dev 
> Subject: Re: [VOTE] Pulsar Release 2.10.0 Candidate 4
>
> +1(non-binding)
>
> Validate Go SDK
> Validate Pub/Sub and Java Functions
>
> --
>
> Thanks
> Xiaolong Ran
>
> Matteo Merli  于2022年3月23日周三 15:06写道：
>
> > +1
> >
> > Checked:
> >  * Signatures
> >  * Bin distribution:
> >  - NOTICE, README, LICENSE
> >  - Start standalone service and producer/consumer test
> >  * Src distribution:
> >  - NOTICE,  README, LICENSE
> >  - Compile and unit tests
> >  - Start standalone service
> >  * Checked staging maven repository artifacts
> >  * Checked docker images
> >
> >
> >
> > --
> > Matteo Merli
> > 
> >
> > On Tue, Mar 22, 2022 at 7:17 PM Haiting Jiang 
> > wrote:
> > >
> > > +1
> > >
> > > - Compiled the source
> > > - Checked checksums and signatures
> > > - Validate Pub/Sub and Java Functions
> > > - Validate Connectors
> > > - Validate Stateful Functions
> > >
> > > Thanks
> > > Haiting
> > >
> > > On 2022/03/22 01:52:36 PengHui Li wrote:
> > > > This is the fourth release candidate for Apache Pulsar 2.10.0
> > > >
> > > > It fixes the following issues:
> > > >
> >
> https://github.com/apache/pulsar/pulls?q=is%3Apr+milestone%3A2.10.0+is%3Amerged+-label%3Arelease%2F2.9.1+-label%3Arelease%2F2.9.2
> > > >
> > > > *** Please download, test and vote on this release. This vote will
> > stay open
> > > > for at least 72 hours ***
> > > >
> > > > Note that we are voting upon the source (tag), binaries are provided
> > for
> > > > convenience.
> > > >
> > > > Source and binary files:
> > > >
> >
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2Fpulsar-2.10.0-candidate-4%2F&data=04%7C01%7Cmassakam%40yahoo-corp.jp%7Cc45307db50f1431ebf4108da0ca51318%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637836201936167509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=PcY63TeS2fukr%2Fn7zrvso6IY%2FNSFS1ldjDNM%2Fi0tzqs%3D&reserved=0
> > > >
> > > > SHA-512 checksums:
> > > >
> > > >
> >
> f4ff0c5e06b7c09a6508f106be4287b47f4dfa6c2e1ec88d6a38ee767731428fde183ed2ce778aff89aece8fb1b06d5f1ada982817545be9a11c6e146913f7ab
> > > > apache-pulsar-2.10.0-bin.tar.gz
> > > >
> > > >
> >
> 1f6c98c6dede135a73858d29be055a76a178b31b861dd8ef4ef33cb7951f95fc13a5c5ad5bee35abb0ad6420b4d7a763175c46cb1f90786fe865fd075e4d85c6
> > > > apache-pulsar-2.10.0-src.tar.gz
> > > >
> > > > Maven staging repo:
> > > >
> >
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachepulsar-1154%2F&data=04%7C01%7Cmassakam%40yahoo-corp.jp%7Cc45307db50f1431ebf4108da0ca51318%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637836201936167509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=A%2B9834yzCKElQICStfvxUdBjsKstw3dWFxzuNW3OBP4%3D&reserved=0
> > > >
> > > > The tag to be voted upon:
> > > > v2.10.0-candidate-3 (6d3fbbea4e9aaaf183ff4117d368b19d9ab6ad7e)
> > > > https://github.com/apache/pulsar/releases/tag/v2.10.0-candidate-4
> > > >
> > > > Pulsar's KEYS file containing PGP keys we use to sign the release:
> > > >
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2FKEYS&data=04%7C01%7Cmassakam%40yahoo-corp.jp%7Cc45307db50f1431ebf4108da0ca51318%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637836201936167509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=jDY%2BxI7KXfMaZmk3fXORma0bn6sshoHCn2W2EGAf6nc%3D&reserved=0
> > > >
> > > > Docker images:
> > > >
> > > >
> >
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhub.docker.com%2Flayers%2F198540978%2Flph890127%2Fpulsar%2F2.10.0-rc4%2Fimages%2Fsha256-e4e3a6593ff3d7ca4b5ffca718fdb423370d2566fb34efadf5a69423331a04ff%3Fcontext%3Drepo&data=04%7C01%7Cmassakam%40yahoo-corp.jp%7Cc45307db50f1431ebf4108da0ca51318%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637836201936167509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB

Re: [VOTE] Pulsar Release 2.10.0 Candidate 4

2022-03-24 Thread PengHui Li

I also updated the release doc
https://github.com/apache/pulsar/wiki/Release-process

To make sure the release manager cleans the local compiled bookkeeper
before processing the release.

Penghui

On Thu, Mar 24, 2022 at 9:32 PM PengHui Li  wrote:

> Thanks,
>
> I will clean up my local bookkeeper build cache and cut a new RC.
>
> Penghui
>
> On Thu, Mar 24, 2022 at 6:33 PM Masahiro Sakamoto 
> wrote:
>
>> Hi, I noticed that the binary package contains BookKeeper libraries
>> compiled on Mac instead of Linux.
>>
>> $ unzip -t lib/org.apache.bookkeeper-circe-checksum-4.14.4.jar | grep
>> lib/lib
>>
>> testing: lib/libcirce-checksum.jnilib   OK
>>
>> $ unzip -t lib/org.apache.bookkeeper-cpu-affinity-4.14.4.jar | grep
>> lib/lib
>>
>> testing: lib/libcpu-affinity.jnilib   OK
>>
>> The same thing happened when voting for v2.9.0, which caused the vote to
>> be cancelled. Should it be fixed this time as well?
>> https://lists.apache.org/thread/gsbh95b2d9xtcg5fmtxpm9k9q6w68gd2
>>
>> Regards,
>>
>> Masahiro Sakamoto
>> Yahoo Japan Corp.
>> E-mail: massa...@yahoo-corp.jp
>>
>> -Original Message-
>> From: r...@apache.org 
>> Sent: Wednesday, March 23, 2022 5:14 PM
>> To: Dev 
>> Subject: Re: [VOTE] Pulsar Release 2.10.0 Candidate 4
>>
>> +1(non-binding)
>>
>> Validate Go SDK
>> Validate Pub/Sub and Java Functions
>>
>> --
>>
>> Thanks
>> Xiaolong Ran
>>
>> Matteo Merli  于2022年3月23日周三 15:06写道：
>>
>> > +1
>> >
>> > Checked:
>> >  * Signatures
>> >  * Bin distribution:
>> >  - NOTICE, README, LICENSE
>> >  - Start standalone service and producer/consumer test
>> >  * Src distribution:
>> >  - NOTICE,  README, LICENSE
>> >  - Compile and unit tests
>> >  - Start standalone service
>> >  * Checked staging maven repository artifacts
>> >  * Checked docker images
>> >
>> >
>> >
>> > --
>> > Matteo Merli
>> > 
>> >
>> > On Tue, Mar 22, 2022 at 7:17 PM Haiting Jiang 
>> > wrote:
>> > >
>> > > +1
>> > >
>> > > - Compiled the source
>> > > - Checked checksums and signatures
>> > > - Validate Pub/Sub and Java Functions
>> > > - Validate Connectors
>> > > - Validate Stateful Functions
>> > >
>> > > Thanks
>> > > Haiting
>> > >
>> > > On 2022/03/22 01:52:36 PengHui Li wrote:
>> > > > This is the fourth release candidate for Apache Pulsar 2.10.0
>> > > >
>> > > > It fixes the following issues:
>> > > >
>> >
>> https://github.com/apache/pulsar/pulls?q=is%3Apr+milestone%3A2.10.0+is%3Amerged+-label%3Arelease%2F2.9.1+-label%3Arelease%2F2.9.2
>> > > >
>> > > > *** Please download, test and vote on this release. This vote will
>> > stay open
>> > > > for at least 72 hours ***
>> > > >
>> > > > Note that we are voting upon the source (tag), binaries are provided
>> > for
>> > > > convenience.
>> > > >
>> > > > Source and binary files:
>> > > >
>> >
>> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2Fpulsar-2.10.0-candidate-4%2F&data=04%7C01%7Cmassakam%40yahoo-corp.jp%7Cc45307db50f1431ebf4108da0ca51318%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637836201936167509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=PcY63TeS2fukr%2Fn7zrvso6IY%2FNSFS1ldjDNM%2Fi0tzqs%3D&reserved=0
>> > > >
>> > > > SHA-512 checksums:
>> > > >
>> > > >
>> >
>> f4ff0c5e06b7c09a6508f106be4287b47f4dfa6c2e1ec88d6a38ee767731428fde183ed2ce778aff89aece8fb1b06d5f1ada982817545be9a11c6e146913f7ab
>> > > > apache-pulsar-2.10.0-bin.tar.gz
>> > > >
>> > > >
>> >
>> 1f6c98c6dede135a73858d29be055a76a178b31b861dd8ef4ef33cb7951f95fc13a5c5ad5bee35abb0ad6420b4d7a763175c46cb1f90786fe865fd075e4d85c6
>> > > > apache-pulsar-2.10.0-src.tar.gz
>> > > >
>> > > > Maven staging repo:
>> > > >
>> >
>> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachepulsar-1154%2F&data=04%7C01%7Cmassakam%40yahoo-corp.jp%7Cc45307db50f1431ebf4108da0ca51318%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637836201936167509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=A%2B9834yzCKElQICStfvxUdBjsKstw3dWFxzuNW3OBP4%3D&reserved=0
>> > > >
>> > > > The tag to be voted upon:
>> > > > v2.10.0-candidate-3 (6d3fbbea4e9aaaf183ff4117d368b19d9ab6ad7e)
>> > > > https://github.com/apache/pulsar/releases/tag/v2.10.0-candidate-4
>> > > >
>> > > > Pulsar's KEYS file containing PGP keys we use to sign the release:
>> > > >
>> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fpulsar%2FKEYS&data=04%7C01%7Cmassakam%40yahoo-corp.jp%7Cc45307db50f1431ebf4108da0ca51318%7Ca208d369cd4e4f87b11998eaf31df2c3%7C1%7C0%7C637836201936167509%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=jDY%2BxI7KXfMaZmk3fXORma0bn6sshoHCn2W2EGAf6nc%3D&reserved=0
>> > > >
>> > > > Docker images:
>> > > >
>> > > >
>> >
>> https://jpn01.safelinks.protection.outlook.com/?

[GitHub] [pulsar-helm-chart] larmic opened a new pull request #249: Expose pulsar manager backend port

2022-03-24 Thread GitBox



larmic opened a new pull request #249:
URL: https://github.com/apache/pulsar-helm-chart/pull/249


   Fixes #
   
   ### Motivation
   
   To create a pulsar manager admin user, port 7750 must be available. 
   
   See also https://github.com/apache/pulsar-helm-chart/issues/229.
   
   ### Modifications
   
   I split the existing pulsar-manager-service.yaml into frontend and backend 
and made the backend configurable via a config parameter 
(pulsar_manager.serviceAdmin.enabled).
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [Guideline] Pulsar PR Naming Convention

2022-03-24 Thread Dave Fisher

Hi -

I think that these guidelines are making it hard for new contributors. Our 
guidelines should make it super easy to make contributions. The guidelines are 
for contributions. Contributors are the community. Committers will review 
contributors PRs and can gently fix mistakes for them to show them the way.

I think that more should be done with GitHub labels.

I think that putting [Issue 12345] in the front of a title is wasteful. A 
trailing hash - #12345 is a clearer and GitHub understands how to link.

Whatever is changed here is the place[1]

But we need to judge the updated page before accepting it. We should be working 
on a series of commits to the docs. I can see a few things that should be 
re-written. For instance [2] doesn’t have the ICLA story quite correct. All 
Committers must file an ICLA while contributors can file one it is understood 
that contributions made are under the AL2. Contributions made under a different 
license require discussion by the project to decide if they are acceptable.

ATB,
Dave

[1] https://pulsar.apache.org/en/contributing/
[2] 
https://pulsar.apache.org/en/contributing/#optionally-submit-contributor-license-agreement

> On Mar 24, 2022, at 12:06 AM, Lari Hotari  wrote:
> 
> The problem with the "Pulsar PR Naming Convention" is that it can conflict 
> with general Git message conventions. 
> 
> The PR title automatically becomes the Git commit's subject line. That's how 
> the PR title related to the Git commit's subject line (title).
> 
> In Git, the convention is to have a subject line (title) with no more than 50 
> characters. When you start adding all kinds of tags in brackets in the title, 
> there won't be much left for the actual content.
> 
> For example, GitHub's UI suggests to write commit messages that are less than 
> 50 characters. There's more explanation about the "Limit the subject line to 
> 50 characters" rule in Chris Beam's awesome "How to Write a Git Commit 
> Message" blog post: https://cbea.ms/git-commit/#limit-50
> 
> Do we care about the general rule that a git commit message should be limited 
> to 50 characters?
> 
> -Lari
> 
> On 2022/03/17 02:11:54 Yu wrote:
>> Hi Pulsarers,
>> 
>> We submit or review PRs almost every day, we might see many vague and
>> unclear PR titles that decrease team efficiency and productivity.
>> 
>> Good PR titles offer bring many benefits, such as speeding up the review
>> process and improving search efficiency.
>> 
>> To solve the vague PR title issue and move *PIP 112: Generate Release Notes
>> Automatically* [1] forward, I've created *Guideline: Pulsar PR Naming
>> Convention* [2], which explains why you need good PR titles and how you do
>> that with various self-explanatory examples. Also, Pulsar and client
>> release notes will be generated automatically based on the rules defined in
>> this guide.
>> 
>> Do not hesitate to comment if you have any questions or concerns. Feedback
>> before EOD 3/21 CST is highly appreciated, thanks!
>> 
>> [1]
>> https://docs.google.com/document/d/1Ul2qIChDe8QDlDwJBICq1VviYZhdk1djKJJC5wXAGsI/edit#
>> 
>> [2]
>> https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#
>> 
>> Regards,
>> Anonymitaet
>>

[GitHub] [pulsar-helm-chart] filipecaixeta opened a new issue #250: make proxy httpNumThreads configurable

2022-03-24 Thread GitBox



filipecaixeta opened a new issue #250:
URL: https://github.com/apache/pulsar-helm-chart/issues/250


   **Is your feature request related to a problem? Please describe.**
   `httpNumThreads` is hardcoded to 8 in 
`charts/pulsar/templates/proxy-configmap.yaml`
   When trying to override in values.yaml by using 
`proxy.configData.httpNumThreads` we get an error because the keys get 
duplicated
   ```shell
   Error: map[string]interface {}(nil): yaml: unmarshal errors:
 line 44: mapping key "httpNumThreads" already defined at line 34
   xargs: sh: exited with status 255; aborting
   ```
   
   **Describe the solution you'd like**
   Removing the key from `charts/pulsar/templates/proxy-configmap.yaml` and 
adding it to the values yaml solves the problem. Something like this
   ```yaml
 configData:
   PULSAR_MEM: >
 -Xms64m -Xmx64m -XX:MaxDirectMemorySize=64m
   PULSAR_GC: >
 -XX:+UseG1GC
 -XX:MaxGCPauseMillis=10
 -Dio.netty.leakDetectionLevel=disabled
 -Dio.netty.recycler.linkCapacity=1024
 -XX:+ParallelRefProcEnabled
 -XX:+UnlockExperimentalVMOptions
 -XX:+DoEscapeAnalysis
 -XX:ParallelGCThreads=4
 -XX:ConcGCThreads=4
 -XX:G1NewSizePercent=50
 -XX:+DisableExplicitGC
 -XX:-ResizePLAB
 -XX:+ExitOnOutOfMemoryError
 -XX:+PerfDisableSharedMem
   httpNumThreads: "8"
   ```
   
   **Describe alternatives you've considered**
   Couldn't find any
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] filipecaixeta opened a new pull request #251: make proxy httpNumThreads configurable

2022-03-24 Thread GitBox



filipecaixeta opened a new pull request #251:
URL: https://github.com/apache/pulsar-helm-chart/pull/251


   Fixes https://github.com/apache/pulsar-helm-chart/issues/250
   
   ### Motivation
   
   `httpNumThreads` is hardcoded to 8 in 
`charts/pulsar/templates/proxy-configmap.yaml`
   When trying to override in `values.yaml` by using 
`proxy.configData.httpNumThreads` we get an error because the keys get 
duplicated.
   This happens because `{{ toYaml .Values.proxy.configData | indent 2 }}` 
doesn't deduplicate the keys and there is no other way to set `httpNumThreads`
   
   ### Modifications
   
   Removing the key from charts/pulsar/templates/proxy-configmap.yaml and 
adding it to the values yaml solves the problem.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Pulsar download web page

2022-03-24 Thread Private List Moderation

Hi,

I'm afraid I cannot approve this announcement because the download page has an 
issue:

The signature and checksum links are incorrectly referring to 
www.apache.org/dist. The links (all of them) must be changed to refer to 
downloads.apache.org instead.

If you can fix the download page, let us know and we can approve the release.

Warm regards,
Craig

> Begin forwarded message:
> 
> From: announce-reject-1648094912.68399.gbohblngmkkcpjkle...@apache.org
> Subject: MODERATE for annou...@apache.org
> Date: March 23, 2022 at 9:08:32 PM PDT
> To: Recipient list not shown: ;
> Cc: 
> announce-allow-tc.1648094912.hplibhhbodgedkcploki-mmarshall=apache@apache.org
> Reply-To: announce-accept-1648094912.68399.gbohblngmkkcpjkle...@apache.org
> 
> 
> To approve:
>   announce-accept-1648094912.68399.gbohblngmkkcpjkle...@apache.org
> To reject:
>   announce-reject-1648094912.68399.gbohblngmkkcpjkle...@apache.org
> To give a reason to reject:
> %%% Start comment
> %%% End comment
> 
> 
> From: Michael Marshall 
> Subject: [ANNOUNCE] Apache Pulsar 2.8.3 released
> Date: March 23, 2022 at 9:07:55 PM PDT
> To: dev@pulsar.apache.org, us...@pulsar.apache.org, annou...@apache.org
> 
> 
> The Apache Pulsar team is proud to announce Apache Pulsar version 2.8.3.
> 
> Pulsar is a highly scalable, low latency messaging platform running on
> commodity hardware. It provides simple pub-sub semantics over topics,
> guaranteed at-least-once delivery of messages, automatic cursor management for
> subscribers, and cross-datacenter replication.
> 
> For Pulsar release details and downloads, visit:
> 
> https://pulsar.apache.org/download
> 
> Release Notes are at:
> https://pulsar.apache.org/release-notes
> 
> We would like to thank the contributors that made the release possible.
> 
> Regards,
> 
> The Pulsar Team
> 
> 
> 

Craig L Russell
Assistant Secretary, Apache Software Foundation
c...@apache.org  http://db.apache.org/jdo

Re: Pulsar download web page

2022-03-24 Thread Dave Fisher

Please Merge https://github.com/apache/pulsar/pull/14855 and test the website 
after the build to correct this issue.

> On Mar 24, 2022, at 5:10 PM, Private List Moderation  
> wrote:
> 
> Hi,
> 
> I'm afraid I cannot approve this announcement because the download page has 
> an issue:
> 
> The signature and checksum links are incorrectly referring to 
> www.apache.org/dist. The links (all of them) must be changed to refer to 
> downloads.apache.org instead.
> 
> If you can fix the download page, let us know and we can approve the release.
> 
> Warm regards,
> Craig
> 
>> Begin forwarded message:
>> 
>> From: announce-reject-1648094912.68399.gbohblngmkkcpjkle...@apache.org
>> Subject: MODERATE for annou...@apache.org
>> Date: March 23, 2022 at 9:08:32 PM PDT
>> To: Recipient list not shown: ;
>> Cc: 
>> announce-allow-tc.1648094912.hplibhhbodgedkcploki-mmarshall=apache@apache.org
>> Reply-To: announce-accept-1648094912.68399.gbohblngmkkcpjkle...@apache.org
>> 
>> 
>> To approve:
>>  announce-accept-1648094912.68399.gbohblngmkkcpjkle...@apache.org
>> To reject:
>>  announce-reject-1648094912.68399.gbohblngmkkcpjkle...@apache.org
>> To give a reason to reject:
>> %%% Start comment
>> %%% End comment
>> 
>> 
>> From: Michael Marshall 
>> Subject: [ANNOUNCE] Apache Pulsar 2.8.3 released
>> Date: March 23, 2022 at 9:07:55 PM PDT
>> To: dev@pulsar.apache.org, us...@pulsar.apache.org, annou...@apache.org
>> 
>> 
>> The Apache Pulsar team is proud to announce Apache Pulsar version 2.8.3.
>> 
>> Pulsar is a highly scalable, low latency messaging platform running on
>> commodity hardware. It provides simple pub-sub semantics over topics,
>> guaranteed at-least-once delivery of messages, automatic cursor management 
>> for
>> subscribers, and cross-datacenter replication.
>> 
>> For Pulsar release details and downloads, visit:
>> 
>> https://pulsar.apache.org/download
>> 
>> Release Notes are at:
>> https://pulsar.apache.org/release-notes
>> 
>> We would like to thank the contributors that made the release possible.
>> 
>> Regards,
>> 
>> The Pulsar Team
>> 
>> 
>> 
> 
> Craig L Russell
> Assistant Secretary, Apache Software Foundation
> c...@apache.org  http://db.apache.org/jdo 
>

[GitHub] [pulsar-site] urfreespace commented on issue #20: Error when cloning git repo

2022-03-24 Thread GitBox



urfreespace commented on issue #20:
URL: https://github.com/apache/pulsar-site/issues/20#issuecomment-1078579170


   @michaeljmarshall thanks for your issue, I have fixed it, please update your 
repo or re-clone your repo, thanks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] urfreespace closed issue #20: Error when cloning git repo

2022-03-24 Thread GitBox



urfreespace closed issue #20:
URL: https://github.com/apache/pulsar-site/issues/20


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] urfreespace closed issue #13: Logo and navigation menu bar overlap

2022-03-24 Thread GitBox



urfreespace closed issue #13:
URL: https://github.com/apache/pulsar-site/issues/13


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] urfreespace commented on issue #13: Logo and navigation menu bar overlap

2022-03-24 Thread GitBox



urfreespace commented on issue #13:
URL: https://github.com/apache/pulsar-site/issues/13#issuecomment-1078579969


   @dave2wave I think it had been fixed, PTAL again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[VOTE] PIP-149: Making the REST Admin API fully async

2022-03-24 Thread mattison chao

This is the voting thread for PIP-149. It will stay open for at least 48
hours.

https://github.com/apache/pulsar/issues/14365

Pasted below for quoting convenience.

-

Motivation

The Rest API was originally designed to be implemented asynchronously, but
with the iteration of functions, some synchronous implementations were
added, resulting in many asynchronous methods called synchronous
implementations. Also, many synchronous calls do not add timeouts. This
greatly reduces concurrency, user operations, and experience.
In order to prevent more problems, and improve code readability and
maintainability, we intend to refactor these synchronous calls and
standardize the implementation of the API.

Related discussion:
https://lists.apache.org/thread/pkkz2jgwtzpksp6d4rdm1pyxzb3z6vmg

Goals

Try to avoid synchronous method calls in asynchronous methods.
Async variable (AsyncResponse) is placed in the first parameter position.
Async variable (AsyncResponse) cannot be substituted into method
implementations.
Add more tests and increase the coverage.
Modification
Avoid synchronous method calls in asynchronous methods.

protected void internalDeleteNamespace(boolean authoritative) {
   validateTenantOperation(namespaceName.getTenant(),
TenantOperation.DELETE_NAMESPACE);
   validatePoliciesReadOnlyAccess();
}
Suggest to do like this:

protected CompletableFuture internalDeleteNamespace(boolean
authoritative) {
return validateTenantOperationAsync(namespaceName.getTenant(),
TenantOperation.DELETE_NAMESPACE)
   .thenCompose(__ -> validatePoliciesReadOnlyAccessAsync());
}
Async variable (AsyncResponse) is placed in the first parameter position

public void deleteNamespace(@Suspended final AsyncResponse asyncResponse,
 @PathParam("tenant") String tenant,
 @PathParam("namespace") String namespace,
 @QueryParam("force") @DefaultValue("false") boolean force,
 @QueryParam("authoritative") @DefaultValue("false") boolean
authoritative) {

Async variable (AsyncResponse) cannot be substituted into method
implementations

internalCreateNonPartitionedTopicAsync(asyncResponse, authoritative,
properties);
Suggest to do like this:

internalCreateNonPartitionedTopicAsync(authoritative, properties)
.thenAccept(__ ->
asyncResponse.resume(Response.noContent().build()))
.exceptionally(ex -> {
resumeAsyncResponseExceptionally(asyncResponse, ex.getCause());
return null;
});

Task tracking
In order to unify the modification and track the modified part, it's better
to open an issue to track, like #14353, #14013, #13854.

---
Best,
Mattison

[GitHub] [pulsar-site] urfreespace opened a new pull request #25: fix: download links fix

2022-03-24 Thread GitBox



urfreespace opened a new pull request #25:
URL: https://github.com/apache/pulsar-site/pull/25


   migrate change from https://github.com/apache/pulsar/pull/14855


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] urfreespace merged pull request #25: fix: download links fix

2022-03-24 Thread GitBox



urfreespace merged pull request #25:
URL: https://github.com/apache/pulsar-site/pull/25


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] urfreespace closed pull request #26: feat: crowdin-upload and crowdin-download are executed at different times and only once a day

2022-03-24 Thread GitBox



urfreespace closed pull request #26:
URL: https://github.com/apache/pulsar-site/pull/26


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-site] urfreespace merged pull request #26: feat: crowdin-upload and crowdin-download are executed at different times and only once a day

2022-03-24 Thread GitBox



urfreespace merged pull request #26:
URL: https://github.com/apache/pulsar-site/pull/26


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [Guideline] Pulsar PR Naming Convention

RE: [VOTE] Pulsar Release 2.10.0 Candidate 4

Re: [VOTE] Pulsar Release 2.10.0 Candidate 4

Re: [VOTE] Pulsar Release 2.10.0 Candidate 4

[GitHub] [pulsar-helm-chart] larmic opened a new pull request #249: Expose pulsar manager backend port

Re: [Guideline] Pulsar PR Naming Convention

[GitHub] [pulsar-helm-chart] filipecaixeta opened a new issue #250: make proxy httpNumThreads configurable

[GitHub] [pulsar-helm-chart] filipecaixeta opened a new pull request #251: make proxy httpNumThreads configurable

Pulsar download web page

Re: Pulsar download web page

[GitHub] [pulsar-site] urfreespace commented on issue #20: Error when cloning git repo

[GitHub] [pulsar-site] urfreespace closed issue #20: Error when cloning git repo

[GitHub] [pulsar-site] urfreespace closed issue #13: Logo and navigation menu bar overlap

[GitHub] [pulsar-site] urfreespace commented on issue #13: Logo and navigation menu bar overlap

[VOTE] PIP-149: Making the REST Admin API fully async

[GitHub] [pulsar-site] urfreespace opened a new pull request #25: fix: download links fix

[GitHub] [pulsar-site] urfreespace merged pull request #25: fix: download links fix

[GitHub] [pulsar-site] urfreespace closed pull request #26: feat: crowdin-upload and crowdin-download are executed at different times and only once a day

[GitHub] [pulsar-site] urfreespace merged pull request #26: feat: crowdin-upload and crowdin-download are executed at different times and only once a day

19 matches

Site Navigation

Mail list logo

Footer information