date:20220120

Re: [VOTE] PIP-129: Introduce intermediate state for ledger deletion

2022-01-20 Thread Zhanpeng Wu

Thanks for your participation. Close the vote with 3 (+1) bindings and 3
(+1) non-bindings, 0 (-1).

Lin Lin  于2022年1月20日周四 15:56写道：

> +1
>

Re: [VOTE] PIP-129: Introduce intermediate state for ledger deletion

2022-01-20 Thread PengHui Li

I have added the PIP to the WIKI page https://github.com/apache/pulsar/wiki

Thanks for the great work Zhanpeng,

Regards,
Penghui

On Thu, Jan 20, 2022 at 4:05 PM Zhanpeng Wu 
wrote:

> Thanks for your participation. Close the vote with 3 (+1) bindings and 3
> (+1) non-bindings, 0 (-1).
>
> Lin Lin  于2022年1月20日周四 15:56写道：
>
> > +1
> >
>

[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #207: [CI] Show status and logs for metadata job in CI logs

2022-01-20 Thread GitBox



lhotari opened a new pull request #207:
URL: https://github.com/apache/pulsar-helm-chart/pull/207


   ### Motivation
   
   - It's currently hard to investigate the Zookeeper TLS issue seen in Pulsar 
2.8.x / #190 since logging doesn't reveal status and logs for the metadata job.
   
   ### Modifications
   
   - show status and logs for jobs besides pods


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] lhotari merged pull request #207: [CI] Show status and logs for metadata job in CI logs

2022-01-20 Thread GitBox



lhotari merged pull request #207:
URL: https://github.com/apache/pulsar-helm-chart/pull/207


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #190: Bump to Pulsar 2.8.2

2022-01-20 Thread GitBox



lhotari commented on pull request #190:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1017599606


   Here are logs for the ZK TLS Only failure: 
https://gist.githubusercontent.com/lhotari/bf83fae80081f062c649384d79d8258f/raw/2e2d08830bed671b6b6dbbd0e87682200c9729fd/pulsar-ci-pulsar-init-logs-nots.txt
   from 
https://github.com/apache/pulsar-helm-chart/runs/4883211151?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] lhotari edited a comment on pull request #190: Bump to Pulsar 2.8.2

2022-01-20 Thread GitBox



lhotari edited a comment on pull request #190:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1017599606


   Here are logs for the ZK TLS Only failures filtered for pulsar-metadata and 
zookeeper logs: 
https://gist.githubusercontent.com/lhotari/200aae3dcb54912d0b5b5958ffb5fe13/raw/fd833e90307ce9e9e5f9084143450ab0de575d34/pulsar-ci-pulsar-init-and-zk-logs.txt
   from 
https://github.com/apache/pulsar-helm-chart/runs/4883211151?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #190: Bump to Pulsar 2.8.2

2022-01-20 Thread GitBox



lhotari commented on pull request #190:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1017620708


   based on the logs, it looks like the `pulsar-bookkeeper-verify-clusterid` 
container fails: 
https://github.com/apache/pulsar-helm-chart/blob/a919f309c6d73342196dbaf6bf146cfda8d9e8e8/charts/pulsar/templates/pulsar-cluster-initialize.yaml#L61-L73
 . I wonder why `pulsar-bookkeeper-verify-clusterid`.
   
   ```
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
14:22:08.341 [main-SendThread(pulsar-ci-zookeeper:2281)] INFO  
org.apache.zookeeper.ClientCnxn - Opening socket connection to server 
pulsar-ci-zookeeper/10.244.1.11:2281.
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
14:22:08.346 [main-SendThread(pulsar-ci-zookeeper:2281)] INFO  
org.apache.zookeeper.ClientCnxn - SASL config status: Will not attempt to 
authenticate using SASL (unknown error)
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
14:22:38.987 [main-SendThread(pulsar-ci-zookeeper:2281)] WARN  
org.apache.zookeeper.ClientCnxn - Client session timed out, have not heard from 
server in 30726ms for session id 0x0
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
14:22:39.125 [main-SendThread(pulsar-ci-zookeeper:2281)] WARN  
org.apache.zookeeper.ClientCnxn - Session 0x0 for sever 
pulsar-ci-zookeeper/10.244.1.11:2281, Closing socket connection. Attempting 
reconnect except it is a SessionExpiredException.
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
org.apache.zookeeper.ClientCnxn$SessionTimeoutException: Client session timed 
out, have not heard from server in 30726ms for session id 0x0
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1258) 
[org.apache.zookeeper-zookeeper-3.6.3.jar:3.6.3]
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
14:22:43.496 [main] INFO  org.apache.zookeeper.ClientCnxnSocketNetty - channel 
is told closing
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
14:22:43.686 [globalEventExecutor-1-1] WARN  
org.apache.zookeeper.ClientCnxnSocketNetty - future isn't success.
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
io.netty.util.concurrent.DefaultPromise$LeanCancellationException: null
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
at io.netty.util.concurrent.DefaultPromise.cancel(...)(Unknown Source) 
~[io.netty-netty-common-4.1.72.Final.jar:4.1.72.Final]
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
14:22:43.706 [main] INFO  org.apache.zookeeper.ZooKeeper - Session: 0x0 closed
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
14:22:43.721 [main-EventThread] INFO  org.apache.zookeeper.ClientCnxn - 
EventThread shut down for session: 0x0
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
14:22:43.707 [main] ERROR org.apache.bookkeeper.meta.zk.ZKMetadataDriverBase - 
Failed to create zookeeper client to pulsar-ci-zookeeper:2281
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = 
ConnectionLoss
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
at org.apache.zookeeper.KeeperException.create(KeeperException.java:102) 
~[org.apache.zookeeper-zookeeper-3.6.3.jar:3.6.3]
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
at 
org.apache.bookkeeper.zookeeper.ZooKeeperWatcherBase.waitForConnection(ZooKeeperWatcherBase.java:159)
 ~[org.apache.bookkeeper-bookkeeper-server-4.14.3.jar:4.14.3]
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
at 
org.apache.bookkeeper.zookeeper.ZooKeeperClient$Builder.build(ZooKeeperClient.java:260)
 ~[org.apache.bookkeeper-bookkeeper-server-4.14.3.jar:4.14.3]
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
at 
org.apache.bookkeeper.meta.zk.ZKMetadataDriverBase.initialize(ZKMetadataDriverBase.java:207)
 [org.apache.bookkeeper-bookkeeper-server-4.14.3.jar:4.14.3]
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
at 
org.apache.bookkeeper.meta.zk.ZKMetadataBookieDriver.initialize(ZKMetadataBookieDriver.java:60)
 [org.apache.bookkeeper-bookkeeper-server-4.14.3.jar:4.14.3]
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
at 
org.apache.bookkeeper.meta.MetadataDrivers.runFunctionWithMetadataBookieDriver(MetadataDrivers.java:345)
 [org.apache.bookkeeper-bookkeeper-server-4.14.3.jar:4.14.3]
   [pod/pulsar-ci-pulsar-init-pzc88/pulsar-bookkeeper-verify-clusterid] 
at 
org.apache.bookkeeper.meta.MetadataDrivers.runFunctionWithRegistrationManager(MetadataDrivers.java:372)
 [org.apache.bookkeeper-book

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #190: Bump to Pulsar 2.8.2

2022-01-20 Thread GitBox



lhotari commented on pull request #190:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1017624305


   here's the [bookie-init 
failure](https://gist.githubusercontent.com/lhotari/1762ae76483596a3d49d9c0df1e4bb6d/raw/cdb58eb085b336fa961e9283807698552ca536ee/pulsar-ci-bookie-init-and-zk-logs.txt):
   ```
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:45:47.975 [main] 
INFO  org.apache.zookeeper.ClientCnxnSocket - jute.maxbuffer value is 1048575 
Bytes
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:45:47.983 [main] 
INFO  org.apache.zookeeper.ClientCnxn - zookeeper.request.timeout value is 0. 
feature enabled=false
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:45:48.046 
[main-SendThread(pulsar-ci-zookeeper:2281)] INFO  
org.apache.zookeeper.ClientCnxn - Opening socket connection to server 
pulsar-ci-zookeeper/10.244.1.11:2281.
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:45:48.047 
[main-SendThread(pulsar-ci-zookeeper:2281)] INFO  
org.apache.zookeeper.ClientCnxn - SASL config status: Will not attempt to 
authenticate using SASL (unknown error)
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:45:49.113 
[epollEventLoopGroup-2-1] INFO  org.apache.zookeeper.ClientCnxnSocketNetty - 
SSL handler added for channel: [id: 0xe111b4a0]
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:45:49.166 
[epollEventLoopGroup-2-1] INFO  org.apache.zookeeper.ClientCnxn - Socket 
connection established, initiating session, client: /10.244.1.20:39420, server: 
pulsar-ci-zookeeper/10.244.1.11:2281
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:45:49.172 
[epollEventLoopGroup-2-1] INFO  org.apache.zookeeper.ClientCnxnSocketNetty - 
channel is connected: [id: 0xe111b4a0, L:/10.244.1.20:39420 - 
R:pulsar-ci-zookeeper/10.244.1.11:2281]
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:46:03.784 
[epollEventLoopGroup-2-1] INFO  org.apache.zookeeper.ClientCnxnSocketNetty - 
channel is disconnected: [id: 0xe111b4a0, L:/10.244.1.20:39420 ! 
R:pulsar-ci-zookeeper/10.244.1.11:2281]
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:46:03.786 
[epollEventLoopGroup-2-1] INFO  org.apache.zookeeper.ClientCnxnSocketNetty - 
channel is told closing
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:46:03.810 
[main-SendThread(pulsar-ci-zookeeper:2281)] WARN  
org.apache.zookeeper.ClientCnxn - Session 0x0 for sever 
pulsar-ci-zookeeper/10.244.1.11:2281, Closing socket connection. Attempting 
reconnect except it is a SessionExpiredException.
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 
org.apache.zookeeper.ClientCnxn$EndOfStreamException: channel for sessionid 0x0 
is lost
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init]  at 
org.apache.zookeeper.ClientCnxnSocketNetty.doTransport(ClientCnxnSocketNetty.java:285)
 ~[org.apache.zookeeper-zookeeper-3.6.3.jar:3.6.3]
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init]  at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1290) 
[org.apache.zookeeper-zookeeper-3.6.3.jar:3.6.3]
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:46:05.650 
[main-SendThread(pulsar-ci-zookeeper:2281)] INFO  
org.apache.zookeeper.ClientCnxn - Opening socket connection to server 
pulsar-ci-zookeeper/10.244.1.11:2281.
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:46:05.653 
[main-SendThread(pulsar-ci-zookeeper:2281)] INFO  
org.apache.zookeeper.ClientCnxn - SASL config status: Will not attempt to 
authenticate using SASL (unknown error)
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:46:20.277 
[epollEventLoopGroup-2-1] INFO  org.apache.zookeeper.ClientCnxnSocketNetty - 
SSL handler added for channel: [id: 0x20cc85f5]
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:46:20.285 
[epollEventLoopGroup-2-1] INFO  org.apache.zookeeper.ClientCnxn - Socket 
connection established, initiating session, client: /10.244.1.20:39662, server: 
pulsar-ci-zookeeper/10.244.1.11:2281
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:46:20.289 
[epollEventLoopGroup-2-1] INFO  org.apache.zookeeper.ClientCnxnSocketNetty - 
channel is connected: [id: 0x20cc85f5, L:/10.244.1.20:39662 - 
R:pulsar-ci-zookeeper/10.244.1.11:2281]
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:46:30.746 
[epollEventLoopGroup-2-1] INFO  org.apache.zookeeper.ClientCnxn - Session 
establishment complete on server pulsar-ci-zookeeper/10.244.1.11:2281, session 
id = 0x103b111025b, negotiated timeout = 3
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:46:32.021 
[main-EventThread] INFO  org.apache.bookkeeper.zookeeper.ZooKeeperWatcherBase - 
ZooKeeper client is connected now.
   [pod/pulsar-ci-bookie-init-pcxzk/pulsar-ci-bookie-init] 14:46:35.658 [main] 
INFO  org.apache.zookeeper.ClientCnxnSocketNetty - channel is told closing
   [pod/pulsar-ci-bookie-init-pcxzk/

[GitHub] [pulsar-helm-chart] lhotari edited a comment on pull request #190: Bump to Pulsar 2.8.2

2022-01-20 Thread GitBox



lhotari edited a comment on pull request #190:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/190#issuecomment-1017624305


   here's the [bookie-init 
failure](https://gist.githubusercontent.com/lhotari/1762ae76483596a3d49d9c0df1e4bb6d/raw/cdb58eb085b336fa961e9283807698552ca536ee/pulsar-ci-bookie-init-and-zk-logs.txt):
   ```
   14:45:47.975 [main] INFO  org.apache.zookeeper.ClientCnxnSocket - 
jute.maxbuffer value is 1048575 Bytes
   14:45:47.983 [main] INFO  org.apache.zookeeper.ClientCnxn - 
zookeeper.request.timeout value is 0. feature enabled=false
   14:45:48.046 [main-SendThread(pulsar-ci-zookeeper:2281)] INFO  
org.apache.zookeeper.ClientCnxn - Opening socket connection to server 
pulsar-ci-zookeeper/10.244.1.11:2281.
   14:45:48.047 [main-SendThread(pulsar-ci-zookeeper:2281)] INFO  
org.apache.zookeeper.ClientCnxn - SASL config status: Will not attempt to 
authenticate using SASL (unknown error)
   14:45:49.113 [epollEventLoopGroup-2-1] INFO  
org.apache.zookeeper.ClientCnxnSocketNetty - SSL handler added for channel: 
[id: 0xe111b4a0]
   14:45:49.166 [epollEventLoopGroup-2-1] INFO  org.apache.zookeeper.ClientCnxn 
- Socket connection established, initiating session, client: 
/10.244.1.20:39420, server: pulsar-ci-zookeeper/10.244.1.11:2281
   14:45:49.172 [epollEventLoopGroup-2-1] INFO  
org.apache.zookeeper.ClientCnxnSocketNetty - channel is connected: [id: 
0xe111b4a0, L:/10.244.1.20:39420 - R:pulsar-ci-zookeeper/10.244.1.11:2281]
   14:46:03.784 [epollEventLoopGroup-2-1] INFO  
org.apache.zookeeper.ClientCnxnSocketNetty - channel is disconnected: [id: 
0xe111b4a0, L:/10.244.1.20:39420 ! R:pulsar-ci-zookeeper/10.244.1.11:2281]
   14:46:03.786 [epollEventLoopGroup-2-1] INFO  
org.apache.zookeeper.ClientCnxnSocketNetty - channel is told closing
   14:46:03.810 [main-SendThread(pulsar-ci-zookeeper:2281)] WARN  
org.apache.zookeeper.ClientCnxn - Session 0x0 for sever 
pulsar-ci-zookeeper/10.244.1.11:2281, Closing socket connection. Attempting 
reconnect except it is a SessionExpiredException.
   org.apache.zookeeper.ClientCnxn$EndOfStreamException: channel for sessionid 
0x0 is lost
at 
org.apache.zookeeper.ClientCnxnSocketNetty.doTransport(ClientCnxnSocketNetty.java:285)
 ~[org.apache.zookeeper-zookeeper-3.6.3.jar:3.6.3]
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1290) 
[org.apache.zookeeper-zookeeper-3.6.3.jar:3.6.3]
   14:46:05.650 [main-SendThread(pulsar-ci-zookeeper:2281)] INFO  
org.apache.zookeeper.ClientCnxn - Opening socket connection to server 
pulsar-ci-zookeeper/10.244.1.11:2281.
   14:46:05.653 [main-SendThread(pulsar-ci-zookeeper:2281)] INFO  
org.apache.zookeeper.ClientCnxn - SASL config status: Will not attempt to 
authenticate using SASL (unknown error)
   14:46:20.277 [epollEventLoopGroup-2-1] INFO  
org.apache.zookeeper.ClientCnxnSocketNetty - SSL handler added for channel: 
[id: 0x20cc85f5]
   14:46:20.285 [epollEventLoopGroup-2-1] INFO  org.apache.zookeeper.ClientCnxn 
- Socket connection established, initiating session, client: 
/10.244.1.20:39662, server: pulsar-ci-zookeeper/10.244.1.11:2281
   14:46:20.289 [epollEventLoopGroup-2-1] INFO  
org.apache.zookeeper.ClientCnxnSocketNetty - channel is connected: [id: 
0x20cc85f5, L:/10.244.1.20:39662 - R:pulsar-ci-zookeeper/10.244.1.11:2281]
   14:46:30.746 [epollEventLoopGroup-2-1] INFO  org.apache.zookeeper.ClientCnxn 
- Session establishment complete on server 
pulsar-ci-zookeeper/10.244.1.11:2281, session id = 0x103b111025b, 
negotiated timeout = 3
   14:46:32.021 [main-EventThread] INFO  
org.apache.bookkeeper.zookeeper.ZooKeeperWatcherBase - ZooKeeper client is 
connected now.
   14:46:35.658 [main] INFO  org.apache.zookeeper.ClientCnxnSocketNetty - 
channel is told closing
   14:46:37.603 [epollEventLoopGroup-2-1] INFO  
org.apache.zookeeper.ClientCnxnSocketNetty - channel is disconnected: [id: 
0x20cc85f5, L:/10.244.1.20:39662 ! R:pulsar-ci-zookeeper/10.244.1.11:2281]
   14:46:37.603 [main-EventThread] INFO  org.apache.zookeeper.ClientCnxn - 
EventThread shut down for session: 0x103b111025b
   14:46:37.603 [main] INFO  org.apache.zookeeper.ZooKeeper - Session: 
0x103b111025b closed
   14:46:37.608 [main] ERROR org.apache.bookkeeper.meta.zk.ZKMetadataDriverBase 
- Failed to create zookeeper client to pulsar-ci-zookeeper:2281
   org.apache.zookeeper.KeeperException$ConnectionLossException: 
KeeperErrorCode = ConnectionLoss
at 
org.apache.zookeeper.KeeperException.create(KeeperException.java:102) 
~[org.apache.zookeeper-zookeeper-3.6.3.jar:3.6.3]
at 
org.apache.bookkeeper.zookeeper.ZooKeeperWatcherBase.waitForConnection(ZooKeeperWatcherBase.java:159)
 ~[org.apache.bookkeeper-bookkeeper-server-4.14.3.jar:4.14.3]
at 
org.apache.bookkeeper.zookeeper.ZooKeeperClient$Builder.build(ZooKeeperClient.java:260)
 ~[org.apache.bookkeeper-bookkeeper-server-4.14.3.jar:4.14.3]
at 
org.apache.bookkeeper.meta.zk.ZKMetadataDriverBase.initialize(ZKMet

[GitHub] [pulsar-helm-chart] frankjkelly commented on pull request #200: Use appVersion as default tag for Pulsar images

2022-01-20 Thread GitBox



frankjkelly commented on pull request #200:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/200#issuecomment-1017664408


   @lhotari just to confirm - for those of us who have overridden the `tag` 
that functionality will remain unchanged? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-adapters] lhotari opened a new pull request #32: Upgrade Log4J2 to 2.17.1

2022-01-20 Thread GitBox



lhotari opened a new pull request #32:
URL: https://github.com/apache/pulsar-adapters/pull/32


   Upgrade to most reason version with multiple Log4J CVE fixes, 2.17.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] pellicano commented on pull request #205: Tiered Storage config

2022-01-20 Thread GitBox



pellicano commented on pull request #205:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/205#issuecomment-1017731740


   Changes applied as suggested by @sijie. Thank you.
   Let me know if there are any other changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-adapters] lhotari merged pull request #32: Upgrade Log4J2 to 2.17.1

2022-01-20 Thread GitBox



lhotari merged pull request #32:
URL: https://github.com/apache/pulsar-adapters/pull/32


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #200: Use appVersion as default tag for Pulsar images

2022-01-20 Thread GitBox



lhotari commented on pull request #200:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/200#issuecomment-1017806199


   > @lhotari just to confirm - for those of us who have overridden the `tag` 
that functionality will remain unchanged? Thanks!
   
   @frankjkelly yes, the intention is to be backwards compatible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] PIP-135: Include MetadataStore backend for Etcd

2022-01-20 Thread Neng Lu

+1 (non-binding)

This is very interesting

On Mon, Jan 17, 2022 at 5:08 AM Lan Liang  wrote:

> +1, Thanks for your work!
>
>
> - lan.liang
>
>
> On 01/17/2022 20:50，ZhangJian He wrote：
> +1
>
> PengHui Li  于2022年1月17日周一 14:01写道：
>
> +1 (binding)
>
> Regards,
> Penghui
>
> On Sat, Jan 15, 2022 at 9:24 PM Joe F  wrote:
>
> +1 (binding)
>
> On Sat, Jan 15, 2022 at 4:46 AM Enrico Olivelli 
> wrote:
>
> Il Sab 15 Gen 2022, 09:10 tamer Abdlatif  ha
> scritto:
>
> Will that affect the existing ZK metadata in a pulsar instance , When
> we
> upgrade from a lower version to 2.10 ?  In other words,
> Do we need a metadate migration to switch from ZK to Etcd ?
>
>
> There is no need to migrate.
>
> Most probably the first release will bring this feature as non
> production
> ready and it will take some time to stabilise
>
> Enrico
>
>
>
>
> Thanks
> Tamer
>
>
>
> On Fri, 14 Jan 2022, 22:52 Matteo Merli, 
> wrote:
>
> https://github.com/apache/pulsar/issues/13717
>
> -
>
> ## Motivation
>
> Since all the pieces that composed the proposal in PIP-45 were
> finally
> merged
> and are currently ready for 2.10 release, it is now possible to add
> other
> metadata backends that can be used to support a BookKeeper + Pulsar
> cluster.
>
> One of the popular systems that is most commonly used as an
> alternative
> of
> ZooKeeper is Etcd, thus it makes sense to have this as the first
> non-zookeeper
> implementation.
>
> ## Goal
>
> Provide an Etcd implementation for the `MetadataStore` API. This
> will
> allow
> users to deploy Pulsar clusters using Etcd service for the metadata
> and
> it
> will
> not require the presence of ZooKeeper.
>
>
> ## Implementation
>
> * Use the existing JEtcd Java client library for Etcd
> * Extends the `AbstractBatchedMetadataStore` class, in order to
> reuse
> the
> transparent batching logic that will be shared with the
> ZooKeeper
> implementation.
>
> Work in progress: https://github.com/apache/pulsar/pull/13225
>
> --
> Matteo Merli
> 
>
>
>
>
>
>

-- 
Best Regards,
Neng

[DISCUSS] PIP-86: Pulsar Functions: Preload and release external resources

2022-01-20 Thread Neng Lu

Hi All,

Just want to bring this PIP[1] to your attention. The PRs [2] have been
open for quite some time. The feature is valuable for many use cases and I
would like to help the original author to push the effort on it.

The general idea is introducing a new API for Pulsar Functions which allows
develop to customize some setup and close logic. The API should look like
this:

```
public interface RichFunction extends Function{

/**
 * Called when function instance start
 *
 * @throws Exception
 */
void setup(Context context) throws Exception;

/**
 * Called when function instance close
 *
 * @throws Exception
 */
void tearDown() throws Exception;
}
```

Please join the discussion if you have any questions or concerns for this
new API.

[1] PIP-86

[2] PR-2  PR-13205


Best regards,
Neng

Re: [DISCUSS] PIP-86: Pulsar Functions: Preload and release external resources

2022-01-20 Thread Enrico Olivelli

Neng,

Il Gio 20 Gen 2022, 20:20 Neng Lu  ha scritto:

> Hi All,
>
> Just want to bring this PIP[1] to your attention. The PRs [2] have been
> open for quite some time. The feature is valuable for many use cases and I
> would like to help the original author to push the effort on it.
>
> The general idea is introducing a new API for Pulsar Functions which allows
> develop to customize some setup and close logic.


I am +1  on your proposal.
I left some feedback on the second PR. Basically we need some unit tests
and integration tests.
The first PR looks obsolete, please close it.

Enrico

The API should look like
> this:
>
> ```
> public interface RichFunction extends Function{
>
> /**
>  * Called when function instance start
>  *
>  * @throws Exception
>  */
> void setup(Context context) throws Exception;
>
> /**
>  * Called when function instance close
>  *
>  * @throws Exception
>  */
> void tearDown() throws Exception;
> }
> ```
>
> Please join the discussion if you have any questions or concerns for this
> new API.
>
> [1] PIP-86
> <
> https://github.com/apache/pulsar/wiki/PIP-86%3A-Pulsar-Functions%3A-Preload-and-release-external-resources
> >
> [2] PR-2  PR-13205
> 
>
> Best regards,
> Neng
>

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #127: Antiaffinity with zone topology for high availability

2022-01-20 Thread GitBox



michaeljmarshall commented on pull request #127:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/127#issuecomment-1017883950


   > @sdwerwed: I think the zone affinity would work for stateless components. 
I don't think it will work well for stateful components. Because the location 
of bookie and zookeeper pods will be bound to the location of EBS volumes.
   
   To add some AWS context, EBS volumes are restricted to a single availability 
zone within a region. Once a bookie gets an EBS volume, it cannot be migrated 
to another AZ. I haven't looked closely at this PR, but we'll need to make sure 
that it works for upgrading existing clusters that do not comply with the 
anti-affinity policy.
   
   > Also, even you are able to place bookies across different zones. But you 
don't configure the rack information, so bookkeeper can potentially place two 
same copies in the pods running in the same zone. 
   
   I agree that this could be misleading. We could mitigate the shortcoming 
with documentation, though. Also, this feature can work without configuring 
rack awareness. For example, if your ack quorum is greater than the number of 
bookies in a single AZ, you'll know that your writes are spread across multiple 
AZs and are therefore HA. This isn't as good as configuring rack awareness, but 
it is probably better than random bookie scheduling.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a change in pull request #155: Add grafana data persistence support.

2022-01-20 Thread GitBox



michaeljmarshall commented on a change in pull request #155:
URL: https://github.com/apache/pulsar-helm-chart/pull/155#discussion_r789135437



##
File path: charts/pulsar/values.yaml
##
@@ -988,6 +988,24 @@ grafana:
 requests:
   memory: 250Mi
   cpu: 0.1
+  volumes:
+# use a persistent volume or emptyDir
+persistence: true

Review comment:
   What is the reasoning for making this the default behavior? 
Alternatively, we could mount dashboards as config maps and avoid the extra 
storage costs associated with a PVC.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [DISCUSSION] PIP-133 Pulsar Functions Add API For Accessing Other Function States

2022-01-20 Thread Michael Marshall

I am concerned that sharing function state will lead to tightly
coupled functions.

I tend to think of functions as actors, according to the actor model
[0]. As such, I view the state of a function (actor) as private and as
something that can only be modified by other functions (actors)
indirectly through messaging. Technically, our documentation does not
state that functions are completely isolated or that they are actors,
but I think we should consider making it part of their design. Without
isolation, functions could become very coupled, and that will
introduce additional challenges related to function scaling, version
management, and security.

> Certain uses of Pulsar functions could benefit from the ability to access
> the states of other functions. Currently functions can only access their
> own states, and so sharing information between functions requires other
> solutions such as writing to a separate database.

Instead of using a separate database, have you considered sharing
state by publishing messages to a topic that another function is
listening to?

- Michael

[0] - https://en.wikipedia.org/wiki/Actor_model



On Tue, Jan 18, 2022 at 11:38 AM Jerry Peng  wrote:
>
> I have concerns about security in this case and potential consistency
> issues.  We will need to define and implement some sort of ACLs system
> first on top of state for this to make sense.
>
> On Mon, Jan 17, 2022 at 5:52 PM Ethan Merrill 
> wrote:
>
> > Thanks for the feedback. I see your concerns.
> >
> > I've been thinking about some ways to mitigate these concerns without
> > expanding the scope of this too much. First, I think it could be a good
> > idea to limit state access to just functions within the same namespace.
> > This will at least avoid any issues that might arise with different
> > namespaces having different state storage implementations.
> >
> > Another thing we could consider is making states read-only by other
> > functions. This allows us to clearly define the owner of the data and avoid
> > unexpected issues with multiple functions trying to change the same state.
> > It would limit some potentially desirable functionality such as 2 functions
> > being able to increment the same counter, but keeping the data ownership
> > clearly defined may be more important for now.
> >
> > Another option to think about could be adding a way to differentiate
> > public/private states or defining what other functions are allowed to
> > access certain states would ease security concerns. It would require some
> > more development time, though, since it would complicate the current
> > implementation a bit. We'd have to address how and where state access is
> > defined.
> >
> > Another option we could consider could be having a separate public state
> > store that all functions in a namespace have access to. It would be simple
> > to implement and would at least separate a function's private states from
> > states it wants other functions to have access to. Data ownership is a bit
> > messy with the public states for this solution, but it would at least
> > provide a method of sharing data that needs to be shared.
> >
> > Let me know if you have any thoughts on any of these changes
> >
> > 
> > From: Enrico Olivelli 
> > Sent: Tuesday, January 11, 2022 1:45 PM
> > To: Dev 
> > Subject: Re: [DISCUSSION] PIP-133 Pulsar Functions Add API For Accessing
> > Other Function States
> >
> > Thank you for posting your PIP !
> >
> > I am sharing some of Neng's concerns.
> > We should define clearly how security works.
> >
> > Also, currently the function defines some "namespace" for the state
> > storage, and we recently added support for custom state storage
> > implementation. With this change each function will possibly access
> > other state storage namespaces (think about using a Database per each
> > tenant).
> >
> > We should also state something about guarantees while accessing
> > multiple storages and/or about transactional (atomic?) access
> >
> >
> > Enrico
> >
> > Il giorno mar 11 gen 2022 alle ore 21:38 Neng Lu  ha
> > scritto:
> > >
> > > Before we advance further, we first need to get on the same page of the
> > > pros and cons of allowing this feature.
> > >
> > > If functions can access (especially the write access) other functions'
> > > state, the data ownership will be a mess, isolation is broken and data
> > > security might be compromised.
> > >
> > >
> > >
> > >
> > >
> > > On Wed, Jan 5, 2022 at 3:45 PM Ethan Merrill 
> > > wrote:
> > >
> > > > Original PIP:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fpulsar%2Fissues%2F13633&data=04%7C01%7Cethan.merrill%40legrand.us%7Cedd443d57f1e41c8588408d9d543508e%7C199686b5bef4496087867a6b1888fee3%7C1%7C0%7C637775307351827417%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=DbCae%2FULTgUiV3pIrUQbOtzvPlilATc%2Bcn50I1eg0Iw%3D&reserved=0
> >

Re: [PR] Pulsar non root docker image

2022-01-20 Thread Michael Marshall

> I am not sure if the fix in
> https://github.com/apache/pulsar/commit/04b5da0f95794259694cc781e8960b7e52fac06b
> is sufficient.

Are you able to describe your concerns so that I can address them?
That commit resolves the upgrade issue because the secret is readable
by any user in the container. Switching users on function upgrade
won't affect the secret's readability.

> I would like to see there is at least one integration test that covers
> running functions on k8s to ensure we don't break the basic stuff.

Are you asking for an integration test in the project or for an ad hoc
manual test?

Thanks,
Michael

On Wed, Jan 12, 2022 at 9:39 PM Sijie Guo  wrote:
>
> I am not sure if the fix in
> https://github.com/apache/pulsar/commit/04b5da0f95794259694cc781e8960b7e52fac06b
> is sufficient.
>
> I would like to see there is at least one integration test that covers
> running functions on k8s to ensure we don't break the basic stuff.
>
> - Sijie
>
> On Fri, Jan 7, 2022 at 9:58 PM Michael Marshall 
> wrote:
>
> > > Is Functions being verified?
> >
> > I discussed this a bit in PR 13376's description and comments, please
> > let me know if you have additional questions. I haven't done any extra
> > verification.
> >
> > Note that since [0] is in both 2.8.x and 2.9.x, the upgrade scenario
> > that led us to revert the first non-root work is no longer an issue.
> >
> > I plan to follow up with a PR to the Pulsar Helm Chart to make the
> > fsGroup configurable.
> >
> > - Michael
> >
> > [0]
> > https://github.com/apache/pulsar/commit/04b5da0f95794259694cc781e8960b7e52fac06b
> >
> > On Thu, Jan 6, 2022 at 7:00 PM Sijie Guo  wrote:
> > >
> > > Is Functions being verified?
> > >
> > > - Sijie
> > >
> > > On Wed, Jan 5, 2022 at 11:26 AM Michael Marshall 
> > > wrote:
> > >
> > > > PR 13376 is ready for review, PTAL.
> > > >
> > > > What approach should we take regarding docker image size?
> > > > I propose providing a minimal image along with documentation
> > > > on how to add your own debugging tools. Is that sufficient?
> > > >
> > > > I'd like to include this feature in 2.10.0.
> > > >
> > > > Note that you can test the new docker image here:
> > > > michaelmarshall/pulsar:2.10.0-SNAPSHOT-1dec8b9
> > > >
> > > > Thanks,
> > > > Michael
> > > >
> > > >
> > > >
> > > > On Wed, Dec 22, 2021 at 1:51 PM Michael Marshall  > >
> > > > wrote:
> > > > >
> > > > > Thanks for raising this important topic, Enrico.
> > > > >
> > > > > > Basically if you are running as non root, you cannot add tools on
> > > > demand,
> > > > > > so we need to add basic tools, like netstat/vim/unzip otherwise
> > > > when
> > > > > > you have a problem you are trapped.
> > > > >
> > > > > I agree that running as a non root user presents challenges for
> > > > > debugging. However, I don't think we should optimize our production
> > > > > image for debugging. We should instead optimize for a minimal docker
> > > > > image with as few dependencies as possible to decrease the image's
> > > > > attack surface.
> > > > >
> > > > > Also, I think it would be valuable to audit the current
> > > > > dependencies we already ship in our docker image. For example, this
> > > > > single `RUN` command [0] adds 1 GB of dependencies to our
> > > > > docker image.
> > > > >
> > > > > If there is a need for an image with debug tools, we could publish a
> > > > > "debug" image that extends our production image with extra tooling.
> > > > > Users could swap out the prod image with the debug image, as needed.
> > > > > However, it is pretty easy and quick to extend a public docker image
> > > > > to add your own tooling. By documenting how to extend our docker
> > > > > image, we could avoid decisions about which tools should be in our
> > > > > image.
> > > > >
> > > > > > there are ways to inject tools, but they are very hard to execute
> > for
> > > > > > people who is not very experienced
> > > > >
> > > > > We can solve this through additional documentation. Freeznet asked a
> > > > > similar question about debugging on the PR. I provided some methods
> > for
> > > > > debugging here [1].
> > > > >
> > > > > Thanks,
> > > > > Michael
> > > > >
> > > > > [0]
> > > >
> > https://github.com/apache/pulsar/blob/5dd60dbd748e446f8da396b448a5bb16a2ae6902/docker/pulsar/Dockerfile#L46-L55
> > > > > [1]
> > https://github.com/apache/pulsar/pull/13376#discussion_r773580954
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On Wed, Dec 22, 2021 at 1:29 AM Enrico Olivelli  > >
> > > > wrote:
> > > > > >
> > > > > > Michael,
> > > > > >
> > > > > > I would like to add this item to the list
> > > > > > https://github.com/apache/pulsar/pull/10815
> > > > > >
> > > > > > Basically if you are running as non root, you cannot add tools on
> > > > demand,
> > > > > > so we need to add basic tools, like netstat/vim/unzip otherwise
> > > > when
> > > > > > you have a problem you are trapped.
> > > > > >
> > > > > > there are ways to inject tools, but they are very hard to exec

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a change in pull request #206: Upgrade default images for Grafana & Pulsar Manager

2022-01-20 Thread GitBox



michaeljmarshall commented on a change in pull request #206:
URL: https://github.com/apache/pulsar-helm-chart/pull/206#discussion_r789218708



##
File path: charts/pulsar/values.yaml
##
@@ -190,11 +190,11 @@ images:
 pullPolicy: IfNotPresent
   grafana:
 repository: streamnative/apache-pulsar-grafana-dashboard-k8s

Review comment:
   We should consider switching to the official Grafana image.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [DISCUSS] New repository for website - pulsar-site

2022-01-20 Thread Liu Yu

Hi Dave,

Thanks for creating the pulsar-site repo [1]!

We (urf...@apache.org) are working on PIP 87 [2] and want to build and preview 
the Pulsar website with the new version of Docusarus. 

As discussed before, our community has been considering bringing website 
content out of the Pulsar repo. 

So can we move all the content under the site2 folder to the pulsar-site repo?

Thanks!

[1] https://github.com/apache/pulsar-site
[2] 
https://docs.google.com/document/d/1IV35SI_F8G8cL-Vuzknc6RTGLK9_edRMpZpnrHvAWNs/edit#heading=h.n6wibg4w77xk

On 2021/11/17 23:57:58 Dave Fisher wrote:
> I’m going to work through 
> https://github.com/apache/pulsar/blob/master/site2/README.md
> 
> I’ll make sure that any changes related to the asf-site branch don’t have 
> issue with that.
> 
> We may want to be able to publish alternative web designs to a staging sites.
> 
> > On Nov 17, 2021, at 3:02 PM, Dave Fisher  wrote:
> > 
> > I’ve updated my fork of apache/pulsar
> > 
> > I’m not seeing how to run the workflow "CI - Pulsar Website build”. Any 
> > ideas?
> > 
> > If not then I’m going to need to test locally and it will take some time to 
> > ready it.
> > 
> > 
> >> On Nov 17, 2021, at 1:15 PM, Matteo Merli  wrote:
> >> 
> >> Yes, that should work.
> >> 
> >> After that we can go ahead and remove `asf-site` from the main repo,
> >> although we need to make it "unprotected" to be able to do so.
> > 
> > Yes once we have moved over to the new then we can ask Infra to take care 
> > of the branch protection along with deleting it.
> > 
> > When I create the new repository I will copy all of the asf-site branch 
> > which will take care of transferring the parts of the site not actively 
> > being built.
> 
> I have created the new repository and populated the asf-site branch: 
> https://github.com/apache/pulsar-site/tree/asf-site
> 
> It publishes to a staging url which you can see here: 
> https://pulsar.staged.apache.org
> 
> Once we are ready we alter: 
> https://github.com/apache/pulsar-site/blob/asf-site/.asf.yaml
> 
> Per: 
> https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features
> 
> > 
> > Regards,
> > Dave
> > 
> >> 
> >> 
> >> --
> >> Matteo Merli
> >> 
> >> 
> >> On Wed, Nov 17, 2021 at 12:46 PM Dave Fisher  wrote:
> >>> 
> >>> If we change ORIGIN_REPO[1] to point to a new pulsar-site repos.
> >>> Then with the correct .asf.yaml file changes we can remove the asf-site 
> >>> branch.
> >>> I see that the publish is run from this workflow [2]
> >>> Let me think about a PR to make the move.
> >>> 
> >>> Regards,
> >>> Dave
> >>> 
> >>> [1] 
> >>> https://github.com/apache/pulsar/blob/7a34cebca25e6e584e8b758e6bd58c1c4fe8a58e/site2/tools/publish-website.sh#L25
> >>> [2] 
> >>> https://github.com/apache/pulsar/blob/master/.github/workflows/ci-pulsar-website-build.yaml
> >>> 
> >>> 
>  On Nov 17, 2021, at 12:31 PM, Matteo Merli  
>  wrote:
>  
>  https://github.com/apache/pulsar/blob/master/site2/tools/publish-website.sh
>  
>  
>  --
>  Matteo Merli
>  
>  
>  On Wed, Nov 17, 2021 at 12:29 PM Dave Fisher  wrote:
> > 
> > Show me where the code is that commits to the asf-site branch.
> > 
> >> On Nov 17, 2021, at 12:25 PM, Matteo Merli  
> >> wrote:
> >> 
> >> I agree with that.
> >> 
> >> I understand that there are tradeoffs for each approach, though the
> >> original intention was to allow for doc changes to be committed in the
> >> same PR as the code change. That doesn't have to be the case always,
> >> especially for larger multi-PR changes, but it makes it easier to do
> >> quick corrections to the docs.
> >> 
> >> I think the bigger problem here is to get rid of the generated site
> >> HTML stuff from the main pulsar repo.
> >> 
> >> --
> >> Matteo Merli
> >> 
> >> 
> >> On Wed, Nov 17, 2021 at 12:16 PM Enrico Olivelli  
> >> wrote:
> >>> 
> >>> Dave,
> >>> Having a new repo will make it harder for developers to contribute
> >>> documentation.
> >>> 
> >>> Usually engineers do  it like and do not have time to write docs.
> >>> 
> >>> If we ask them to create two PRs only to add, for instance, a new
> >>> configuration option, then it would be somehow a pain.
> >>> 
> >>> I am not saying that we shouldn't go this way, but it would be kind 
> >>> of a
> >>> pain for someone and we need to ear more voices.
> >>> 
> >>> Enrico
> >>> 
> >>> Il Mer 17 Nov 2021, 19:28 Sijie Guo  ha scritto:
> >>> 
>  I think we should have a PIP for this. Because this impacts all the
>  developers who are making documentation changes.
>  
>  - Sijie
>  
>  On Tue, Nov 16, 2021 at 8:46 AM Dave Fisher  wrote:
>  
> > Hi -
> > 
> > There are two efforts happening in the community around website 
> > refresh.
> > 
> >>

Re: [DISCUSS] New repository for website - pulsar-site

2022-01-20 Thread Dave Fisher

Hi Liu Yu,

> On Jan 20, 2022, at 6:21 PM, Liu Yu  wrote:
> 
> Hi Dave,
> 
> Thanks for creating the pulsar-site repo [1]!
> 
> We (urf...@apache.org) are working on PIP 87 [2] and want to build and 
> preview the Pulsar website with the new version of Docusarus. 
> 
> As discussed before, our community has been considering bringing website 
> content out of the Pulsar repo. 
> 
> So can we move all the content under the site2 folder to the pulsar-site repo?

Yes!

We’ll need to create a new ‘main’ branch and ask Infra to make it the default.

Also a new staging branch. From the PR it will be named ‘asf-site-next’

All the best,
Dave
> 
> Thanks!
> 
> [1] https://github.com/apache/pulsar-site
> [2] 
> https://docs.google.com/document/d/1IV35SI_F8G8cL-Vuzknc6RTGLK9_edRMpZpnrHvAWNs/edit#heading=h.n6wibg4w77xk
> 
>> On 2021/11/17 23:57:58 Dave Fisher wrote:
>> I’m going to work through 
>> https://github.com/apache/pulsar/blob/master/site2/README.md
>> 
>> I’ll make sure that any changes related to the asf-site branch don’t have 
>> issue with that.
>> 
>> We may want to be able to publish alternative web designs to a staging sites.
>> 
 On Nov 17, 2021, at 3:02 PM, Dave Fisher  wrote:
>>> 
>>> I’ve updated my fork of apache/pulsar
>>> 
>>> I’m not seeing how to run the workflow "CI - Pulsar Website build”. Any 
>>> ideas?
>>> 
>>> If not then I’m going to need to test locally and it will take some time to 
>>> ready it.
>>> 
>>> 
 On Nov 17, 2021, at 1:15 PM, Matteo Merli  wrote:
 
 Yes, that should work.
 
 After that we can go ahead and remove `asf-site` from the main repo,
 although we need to make it "unprotected" to be able to do so.
>>> 
>>> Yes once we have moved over to the new then we can ask Infra to take care 
>>> of the branch protection along with deleting it.
>>> 
>>> When I create the new repository I will copy all of the asf-site branch 
>>> which will take care of transferring the parts of the site not actively 
>>> being built.
>> 
>> I have created the new repository and populated the asf-site branch: 
>> https://github.com/apache/pulsar-site/tree/asf-site
>> 
>> It publishes to a staging url which you can see here: 
>> https://pulsar.staged.apache.org
>> 
>> Once we are ready we alter: 
>> https://github.com/apache/pulsar-site/blob/asf-site/.asf.yaml
>> 
>> Per: 
>> https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features
>> 
>>> 
>>> Regards,
>>> Dave
>>> 
 
 
 --
 Matteo Merli
 
 
 On Wed, Nov 17, 2021 at 12:46 PM Dave Fisher  wrote:
> 
> If we change ORIGIN_REPO[1] to point to a new pulsar-site repos.
> Then with the correct .asf.yaml file changes we can remove the asf-site 
> branch.
> I see that the publish is run from this workflow [2]
> Let me think about a PR to make the move.
> 
> Regards,
> Dave
> 
> [1] 
> https://github.com/apache/pulsar/blob/7a34cebca25e6e584e8b758e6bd58c1c4fe8a58e/site2/tools/publish-website.sh#L25
> [2] 
> https://github.com/apache/pulsar/blob/master/.github/workflows/ci-pulsar-website-build.yaml
> 
> 
>> On Nov 17, 2021, at 12:31 PM, Matteo Merli  
>> wrote:
>> 
>> https://github.com/apache/pulsar/blob/master/site2/tools/publish-website.sh
>> 
>> 
>> --
>> Matteo Merli
>> 
>> 
>> On Wed, Nov 17, 2021 at 12:29 PM Dave Fisher  wrote:
>>> 
>>> Show me where the code is that commits to the asf-site branch.
>>> 
 On Nov 17, 2021, at 12:25 PM, Matteo Merli  
 wrote:
 
 I agree with that.
 
 I understand that there are tradeoffs for each approach, though the
 original intention was to allow for doc changes to be committed in the
 same PR as the code change. That doesn't have to be the case always,
 especially for larger multi-PR changes, but it makes it easier to do
 quick corrections to the docs.
 
 I think the bigger problem here is to get rid of the generated site
 HTML stuff from the main pulsar repo.
 
 --
 Matteo Merli
 
 
 On Wed, Nov 17, 2021 at 12:16 PM Enrico Olivelli  
 wrote:
> 
> Dave,
> Having a new repo will make it harder for developers to contribute
> documentation.
> 
> Usually engineers do  it like and do not have time to write docs.
> 
> If we ask them to create two PRs only to add, for instance, a new
> configuration option, then it would be somehow a pain.
> 
> I am not saying that we shouldn't go this way, but it would be kind 
> of a
> pain for someone and we need to ear more voices.
> 
> Enrico
> 
> Il Mer 17 Nov 2021, 19:28 Sijie Guo  ha scritto:
> 
>> I think we should have a PIP for this. Because this impacts all the
>> developers

Re: [DISCUSS] New repository for website - pulsar-site

2022-01-20 Thread Li Li

+1, Yes, Dave is right.

> On Jan 21, 2022, at 11:04 AM, Dave Fisher  wrote:
> 
> Hi Liu Yu,
> 
>> On Jan 20, 2022, at 6:21 PM, Liu Yu  wrote:
>> 
>> Hi Dave,
>> 
>> Thanks for creating the pulsar-site repo [1]!
>> 
>> We (urf...@apache.org) are working on PIP 87 [2] and want to build and 
>> preview the Pulsar website with the new version of Docusarus. 
>> 
>> As discussed before, our community has been considering bringing website 
>> content out of the Pulsar repo. 
>> 
>> So can we move all the content under the site2 folder to the pulsar-site 
>> repo?
> 
> Yes!
> 
> We’ll need to create a new ‘main’ branch and ask Infra to make it the default.
> 
> Also a new staging branch. From the PR it will be named ‘asf-site-next’
> 
> All the best,
> Dave
>> 
>> Thanks!
>> 
>> [1] https://github.com/apache/pulsar-site
>> [2] 
>> https://docs.google.com/document/d/1IV35SI_F8G8cL-Vuzknc6RTGLK9_edRMpZpnrHvAWNs/edit#heading=h.n6wibg4w77xk
>> 
>>> On 2021/11/17 23:57:58 Dave Fisher wrote:
>>> I’m going to work through 
>>> https://github.com/apache/pulsar/blob/master/site2/README.md
>>> 
>>> I’ll make sure that any changes related to the asf-site branch don’t have 
>>> issue with that.
>>> 
>>> We may want to be able to publish alternative web designs to a staging 
>>> sites.
>>> 
> On Nov 17, 2021, at 3:02 PM, Dave Fisher  wrote:
 
 I’ve updated my fork of apache/pulsar
 
 I’m not seeing how to run the workflow "CI - Pulsar Website build”. Any 
 ideas?
 
 If not then I’m going to need to test locally and it will take some time 
 to ready it.
 
 
> On Nov 17, 2021, at 1:15 PM, Matteo Merli  wrote:
> 
> Yes, that should work.
> 
> After that we can go ahead and remove `asf-site` from the main repo,
> although we need to make it "unprotected" to be able to do so.
 
 Yes once we have moved over to the new then we can ask Infra to take care 
 of the branch protection along with deleting it.
 
 When I create the new repository I will copy all of the asf-site branch 
 which will take care of transferring the parts of the site not actively 
 being built.
>>> 
>>> I have created the new repository and populated the asf-site branch: 
>>> https://github.com/apache/pulsar-site/tree/asf-site
>>> 
>>> It publishes to a staging url which you can see here: 
>>> https://pulsar.staged.apache.org
>>> 
>>> Once we are ready we alter: 
>>> https://github.com/apache/pulsar-site/blob/asf-site/.asf.yaml
>>> 
>>> Per: 
>>> https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features
>>> 
 
 Regards,
 Dave
 
> 
> 
> --
> Matteo Merli
> 
> 
> On Wed, Nov 17, 2021 at 12:46 PM Dave Fisher  wrote:
>> 
>> If we change ORIGIN_REPO[1] to point to a new pulsar-site repos.
>> Then with the correct .asf.yaml file changes we can remove the asf-site 
>> branch.
>> I see that the publish is run from this workflow [2]
>> Let me think about a PR to make the move.
>> 
>> Regards,
>> Dave
>> 
>> [1] 
>> https://github.com/apache/pulsar/blob/7a34cebca25e6e584e8b758e6bd58c1c4fe8a58e/site2/tools/publish-website.sh#L25
>> [2] 
>> https://github.com/apache/pulsar/blob/master/.github/workflows/ci-pulsar-website-build.yaml
>> 
>> 
>>> On Nov 17, 2021, at 12:31 PM, Matteo Merli  
>>> wrote:
>>> 
>>> https://github.com/apache/pulsar/blob/master/site2/tools/publish-website.sh
>>> 
>>> 
>>> --
>>> Matteo Merli
>>> 
>>> 
>>> On Wed, Nov 17, 2021 at 12:29 PM Dave Fisher  wrote:
 
 Show me where the code is that commits to the asf-site branch.
 
> On Nov 17, 2021, at 12:25 PM, Matteo Merli  
> wrote:
> 
> I agree with that.
> 
> I understand that there are tradeoffs for each approach, though the
> original intention was to allow for doc changes to be committed in the
> same PR as the code change. That doesn't have to be the case always,
> especially for larger multi-PR changes, but it makes it easier to do
> quick corrections to the docs.
> 
> I think the bigger problem here is to get rid of the generated site
> HTML stuff from the main pulsar repo.
> 
> --
> Matteo Merli
> 
> 
> On Wed, Nov 17, 2021 at 12:16 PM Enrico Olivelli 
>  wrote:
>> 
>> Dave,
>> Having a new repo will make it harder for developers to contribute
>> documentation.
>> 
>> Usually engineers do  it like and do not have time to write docs.
>> 
>> If we ask them to create two PRs only to add, for instance, a new
>> configuration option, then it would be somehow a pain.
>> 
>> I am not saying that we shouldn't go this way, but it would be kind 
>> of a
>> pain fo

[GitHub] [pulsar-helm-chart] dragonls commented on a change in pull request #155: Add grafana data persistence support.

2022-01-20 Thread GitBox



dragonls commented on a change in pull request #155:
URL: https://github.com/apache/pulsar-helm-chart/pull/155#discussion_r789346328



##
File path: charts/pulsar/values.yaml
##
@@ -988,6 +988,24 @@ grafana:
 requests:
   memory: 250Mi
   cpu: 0.1
+  volumes:
+# use a persistent volume or emptyDir
+persistence: true

Review comment:
   Just thinking that user might be confused if the grafana pod restarts 
and data lost, once user modified the grafana data such as the dashboards.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [DISCUSS] PIP-86: Pulsar Functions: Preload and release external resources

2022-01-20 Thread Neng Lu

Hi Everyone,

I would like to call for a vote of the PIP-86 in a separate email.
Let me know if we've already done that.

On Thu, Jan 20, 2022 at 12:07 PM Enrico Olivelli 
wrote:

> Neng,
>
> Il Gio 20 Gen 2022, 20:20 Neng Lu  ha scritto:
>
> > Hi All,
> >
> > Just want to bring this PIP[1] to your attention. The PRs [2] have been
> > open for quite some time. The feature is valuable for many use cases and
> I
> > would like to help the original author to push the effort on it.
> >
> > The general idea is introducing a new API for Pulsar Functions which
> allows
> > develop to customize some setup and close logic.
>
>
> I am +1  on your proposal.
> I left some feedback on the second PR. Basically we need some unit tests
> and integration tests.
> The first PR looks obsolete, please close it.
>
> Enrico
>
> The API should look like
> > this:
> >
> > ```
> > public interface RichFunction extends Function{
> >
> > /**
> >  * Called when function instance start
> >  *
> >  * @throws Exception
> >  */
> > void setup(Context context) throws Exception;
> >
> > /**
> >  * Called when function instance close
> >  *
> >  * @throws Exception
> >  */
> > void tearDown() throws Exception;
> > }
> > ```
> >
> > Please join the discussion if you have any questions or concerns for this
> > new API.
> >
> > [1] PIP-86
> > <
> >
> https://github.com/apache/pulsar/wiki/PIP-86%3A-Pulsar-Functions%3A-Preload-and-release-external-resources
> > >
> > [2] PR-2  PR-13205
> > 
> >
> > Best regards,
> > Neng
> >
>


-- 
Best Regards,
Neng

Re: [DISCUSS] New repository for website - pulsar-site

2022-01-20 Thread Leo

Hi Dave,

We need add two secrets(PULSARBOT_TOKEN and PULSAR_CROWDIN_DOCUSAURUS_API_KEY) 
for pulsar-site repo, Here's the code link

https://github.com/apache/pulsar-site/blob/ffc2e424a7565584e58c1f5a10bb0b1253497f53/.github/workflows/ci-pulsar-website-next-build.yaml#L78-L79
 



Thanks,
Li Li


> On Jan 21, 2022, at 11:04 AM, Dave Fisher  wrote:
> 
> Hi Liu Yu,
> 
>> On Jan 20, 2022, at 6:21 PM, Liu Yu  wrote:
>> 
>> Hi Dave,
>> 
>> Thanks for creating the pulsar-site repo [1]!
>> 
>> We (urf...@apache.org) are working on PIP 87 [2] and want to build and 
>> preview the Pulsar website with the new version of Docusarus. 
>> 
>> As discussed before, our community has been considering bringing website 
>> content out of the Pulsar repo. 
>> 
>> So can we move all the content under the site2 folder to the pulsar-site 
>> repo?
> 
> Yes!
> 
> We’ll need to create a new ‘main’ branch and ask Infra to make it the default.
> 
> Also a new staging branch. From the PR it will be named ‘asf-site-next’
> 
> All the best,
> Dave
>> 
>> Thanks!
>> 
>> [1] https://github.com/apache/pulsar-site
>> [2] 
>> https://docs.google.com/document/d/1IV35SI_F8G8cL-Vuzknc6RTGLK9_edRMpZpnrHvAWNs/edit#heading=h.n6wibg4w77xk
>> 
>>> On 2021/11/17 23:57:58 Dave Fisher wrote:
>>> I’m going to work through 
>>> https://github.com/apache/pulsar/blob/master/site2/README.md
>>> 
>>> I’ll make sure that any changes related to the asf-site branch don’t have 
>>> issue with that.
>>> 
>>> We may want to be able to publish alternative web designs to a staging 
>>> sites.
>>> 
> On Nov 17, 2021, at 3:02 PM, Dave Fisher  wrote:
 
 I’ve updated my fork of apache/pulsar
 
 I’m not seeing how to run the workflow "CI - Pulsar Website build”. Any 
 ideas?
 
 If not then I’m going to need to test locally and it will take some time 
 to ready it.
 
 
> On Nov 17, 2021, at 1:15 PM, Matteo Merli  wrote:
> 
> Yes, that should work.
> 
> After that we can go ahead and remove `asf-site` from the main repo,
> although we need to make it "unprotected" to be able to do so.
 
 Yes once we have moved over to the new then we can ask Infra to take care 
 of the branch protection along with deleting it.
 
 When I create the new repository I will copy all of the asf-site branch 
 which will take care of transferring the parts of the site not actively 
 being built.
>>> 
>>> I have created the new repository and populated the asf-site branch: 
>>> https://github.com/apache/pulsar-site/tree/asf-site
>>> 
>>> It publishes to a staging url which you can see here: 
>>> https://pulsar.staged.apache.org
>>> 
>>> Once we are ready we alter: 
>>> https://github.com/apache/pulsar-site/blob/asf-site/.asf.yaml
>>> 
>>> Per: 
>>> https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features
>>> 
 
 Regards,
 Dave
 
> 
> 
> --
> Matteo Merli
> 
> 
> On Wed, Nov 17, 2021 at 12:46 PM Dave Fisher  wrote:
>> 
>> If we change ORIGIN_REPO[1] to point to a new pulsar-site repos.
>> Then with the correct .asf.yaml file changes we can remove the asf-site 
>> branch.
>> I see that the publish is run from this workflow [2]
>> Let me think about a PR to make the move.
>> 
>> Regards,
>> Dave
>> 
>> [1] 
>> https://github.com/apache/pulsar/blob/7a34cebca25e6e584e8b758e6bd58c1c4fe8a58e/site2/tools/publish-website.sh#L25
>> [2] 
>> https://github.com/apache/pulsar/blob/master/.github/workflows/ci-pulsar-website-build.yaml
>> 
>> 
>>> On Nov 17, 2021, at 12:31 PM, Matteo Merli  
>>> wrote:
>>> 
>>> https://github.com/apache/pulsar/blob/master/site2/tools/publish-website.sh
>>> 
>>> 
>>> --
>>> Matteo Merli
>>> 
>>> 
>>> On Wed, Nov 17, 2021 at 12:29 PM Dave Fisher  wrote:
 
 Show me where the code is that commits to the asf-site branch.
 
> On Nov 17, 2021, at 12:25 PM, Matteo Merli  
> wrote:
> 
> I agree with that.
> 
> I understand that there are tradeoffs for each approach, though the
> original intention was to allow for doc changes to be committed in the
> same PR as the code change. That doesn't have to be the case always,
> especially for larger multi-PR changes, but it makes it easier to do
> quick corrections to the docs.
> 
> I think the bigger problem here is to get rid of the generated site
> HTML stuff from the main pulsar repo.
> 
> --
> Matteo Merli
> 
> 
> On Wed, Nov 17, 2021 at 12:16 PM Enrico Olivelli 
>  wrote:
>> 
>> Dave,
>> Having a new repo will make it harder for de

Re: [DISCUSS] New repository for website - pulsar-site

2022-01-20 Thread Dave Fisher

It’s a bit late in my evening.

You could access the-asf.slack.com #asfinfra and ask about saving/copying these 
secrets from pulsar.git to pulsar-site.git.

All the best,
Dave

Sent from my iPhone

> On Jan 20, 2022, at 9:14 PM, Leo  wrote:
> 
> Hi Dave,
> 
> We need add two secrets(PULSARBOT_TOKEN and 
> PULSAR_CROWDIN_DOCUSAURUS_API_KEY) for pulsar-site repo, Here's the code link
> 
> https://github.com/apache/pulsar-site/blob/ffc2e424a7565584e58c1f5a10bb0b1253497f53/.github/workflows/ci-pulsar-website-next-build.yaml#L78-L79
>  
> 
> 
> 
> Thanks,
> Li Li
> 
> 
>> On Jan 21, 2022, at 11:04 AM, Dave Fisher  wrote:
>> 
>> Hi Liu Yu,
>> 
 On Jan 20, 2022, at 6:21 PM, Liu Yu  wrote:
>>> 
>>> Hi Dave,
>>> 
>>> Thanks for creating the pulsar-site repo [1]!
>>> 
>>> We (urf...@apache.org) are working on PIP 87 [2] and want to build and 
>>> preview the Pulsar website with the new version of Docusarus. 
>>> 
>>> As discussed before, our community has been considering bringing website 
>>> content out of the Pulsar repo. 
>>> 
>>> So can we move all the content under the site2 folder to the pulsar-site 
>>> repo?
>> 
>> Yes!
>> 
>> We’ll need to create a new ‘main’ branch and ask Infra to make it the 
>> default.
>> 
>> Also a new staging branch. From the PR it will be named ‘asf-site-next’
>> 
>> All the best,
>> Dave
>>> 
>>> Thanks!
>>> 
>>> [1] https://github.com/apache/pulsar-site
>>> [2] 
>>> https://docs.google.com/document/d/1IV35SI_F8G8cL-Vuzknc6RTGLK9_edRMpZpnrHvAWNs/edit#heading=h.n6wibg4w77xk
>>> 
 On 2021/11/17 23:57:58 Dave Fisher wrote:
 I’m going to work through 
 https://github.com/apache/pulsar/blob/master/site2/README.md
 
 I’ll make sure that any changes related to the asf-site branch don’t have 
 issue with that.
 
 We may want to be able to publish alternative web designs to a staging 
 sites.
 
>> On Nov 17, 2021, at 3:02 PM, Dave Fisher  wrote:
> 
> I’ve updated my fork of apache/pulsar
> 
> I’m not seeing how to run the workflow "CI - Pulsar Website build”. Any 
> ideas?
> 
> If not then I’m going to need to test locally and it will take some time 
> to ready it.
> 
> 
>> On Nov 17, 2021, at 1:15 PM, Matteo Merli  wrote:
>> 
>> Yes, that should work.
>> 
>> After that we can go ahead and remove `asf-site` from the main repo,
>> although we need to make it "unprotected" to be able to do so.
> 
> Yes once we have moved over to the new then we can ask Infra to take care 
> of the branch protection along with deleting it.
> 
> When I create the new repository I will copy all of the asf-site branch 
> which will take care of transferring the parts of the site not actively 
> being built.
 
 I have created the new repository and populated the asf-site branch: 
 https://github.com/apache/pulsar-site/tree/asf-site
 
 It publishes to a staging url which you can see here: 
 https://pulsar.staged.apache.org
 
 Once we are ready we alter: 
 https://github.com/apache/pulsar-site/blob/asf-site/.asf.yaml
 
 Per: 
 https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features
 
> 
> Regards,
> Dave
> 
>> 
>> 
>> --
>> Matteo Merli
>> 
>> 
>> On Wed, Nov 17, 2021 at 12:46 PM Dave Fisher  wrote:
>>> 
>>> If we change ORIGIN_REPO[1] to point to a new pulsar-site repos.
>>> Then with the correct .asf.yaml file changes we can remove the asf-site 
>>> branch.
>>> I see that the publish is run from this workflow [2]
>>> Let me think about a PR to make the move.
>>> 
>>> Regards,
>>> Dave
>>> 
>>> [1] 
>>> https://github.com/apache/pulsar/blob/7a34cebca25e6e584e8b758e6bd58c1c4fe8a58e/site2/tools/publish-website.sh#L25
>>> [2] 
>>> https://github.com/apache/pulsar/blob/master/.github/workflows/ci-pulsar-website-build.yaml
>>> 
>>> 
 On Nov 17, 2021, at 12:31 PM, Matteo Merli  
 wrote:
 
 https://github.com/apache/pulsar/blob/master/site2/tools/publish-website.sh
 
 
 --
 Matteo Merli
 
 
 On Wed, Nov 17, 2021 at 12:29 PM Dave Fisher  wrote:
> 
> Show me where the code is that commits to the asf-site branch.
> 
>> On Nov 17, 2021, at 12:25 PM, Matteo Merli  
>> wrote:
>> 
>> I agree with that.
>> 
>> I understand that there are tradeoffs for each approach, though the
>> original intention was to allow for doc changes to be committed in 
>> the
>> same PR as the code change. That doesn't have to be the case always,
>> especially for larger multi-PR changes, but it makes it

[ANNOUNCE] New Committer: Haiting Jiang

2022-01-20 Thread Jia Zhai

The Apache Pulsar Project Management Committee (PMC) has invited Haiting
Jiang
(https://github.com/jason918) to become a committer and we are pleased to

announce that he has accepted.


Haiting contributed a lot of interesting additions to the project, and
helped a lot to answer the user’s questions like in github issues, wechat
groups and slack channels.  His full list of contributions in github can be
found at https://github.com/apache/pulsar/commits?author=jason918.


Welcome and Congratulations, Haiting! Please enjoy the journey as a
committer :)


Please join us in congratulating and welcoming Haiting onboard!

Best Regards,
Jia on behalf of the Pulsar PMC

??????[ANNOUNCE] New Committer: Haiting Jiang

2022-01-20 Thread zhangao

Congratulations! 


Best Regards,
zhangao
--  --
??: 
   "dev"
https://github.com/jason918) to become a committer and we are pleased to

announce that he has accepted.


Haiting contributed a lot of interesting additions to the project, and
helped a lot to answer the user??s questions like in github issues, wechat
groups and slack channels.  His full list of contributions in github can be
found at https://github.com/apache/pulsar/commits?author=jason918.


Welcome and Congratulations, Haiting! Please enjoy the journey as a
committer :)


Please join us in congratulating and welcoming Haiting onboard!

Best Regards,
Jia on behalf of the Pulsar PMC

[GitHub] [pulsar-helm-chart] dragonls commented on a change in pull request #155: Add grafana data persistence support.

2022-01-20 Thread GitBox



dragonls commented on a change in pull request #155:
URL: https://github.com/apache/pulsar-helm-chart/pull/155#discussion_r789412624



##
File path: charts/pulsar/values.yaml
##
@@ -988,6 +988,24 @@ grafana:
 requests:
   memory: 250Mi
   cpu: 0.1
+  volumes:
+# use a persistent volume or emptyDir
+persistence: true
+data:
+  name: data
+  size: 10Gi

Review comment:
   Updated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [pulsar-helm-chart] dragonls commented on a change in pull request #155: Add grafana data persistence support.

2022-01-20 Thread GitBox



dragonls commented on a change in pull request #155:
URL: https://github.com/apache/pulsar-helm-chart/pull/155#discussion_r789346328



##
File path: charts/pulsar/values.yaml
##
@@ -988,6 +988,24 @@ grafana:
 requests:
   memory: 250Mi
   cpu: 0.1
+  volumes:
+# use a persistent volume or emptyDir
+persistence: true

Review comment:
   Just thinking that user modified the grafana data such as the dashboards 
or user data, he/she might be confused for the data lost if the grafana pod 
restarts.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [ANNOUNCE] New Committer: Haiting Jiang

2022-01-20 Thread Aloys Zhang

Congratulations!

zhangao  于2022年1月21日周五 15:07写道：

> Congratulations! 
>
>
> Best Regards,
> zhangao
> -- 原始邮件 --
> 发件人:
>   "dev"
> <
> zhai...@apache.org>;
> 发送时间: 2022年1月21日(星期五) 下午2:59
> 收件人: "Dev" us...@pulsar.apache.org>;
>
> 主题: [ANNOUNCE] New Committer: Haiting Jiang
>
>
>
> The Apache Pulsar Project Management Committee (PMC) has invited Haiting
> Jiang
> (https://github.com/jason918) to become a committer and we are pleased to
>
> announce that he has accepted.
>
>
> Haiting contributed a lot of interesting additions to the project, and
> helped a lot to answer the user’s questions like in github issues, wechat
> groups and slack channels.  His full list of contributions in github
> can be
> found at https://github.com/apache/pulsar/commits?author=jason918.
>
>
> Welcome and Congratulations, Haiting! Please enjoy the journey as a
> committer :)
>
>
> Please join us in congratulating and welcoming Haiting onboard!
>
> Best Regards,
> Jia on behalf of the Pulsar PMC

Re: [ANNOUNCE] New Committer: Haiting Jiang

2022-01-20 Thread Enrico Olivelli

Congratulations!


Enrico

Il Ven 21 Gen 2022, 08:38 Aloys Zhang  ha scritto:

> Congratulations!
>
> zhangao  于2022年1月21日周五 15:07写道：
>
> > Congratulations! 
> >
> >
> > Best Regards,
> > zhangao
> > -- 原始邮件 --
> > 发件人:
> >   "dev"
> > <
> > zhai...@apache.org>;
> > 发送时间: 2022年1月21日(星期五) 下午2:59
> > 收件人: "Dev" > us...@pulsar.apache.org>;
> >
> > 主题: [ANNOUNCE] New Committer: Haiting Jiang
> >
> >
> >
> > The Apache Pulsar Project Management Committee (PMC) has invited Haiting
> > Jiang
> > (https://github.com/jason918) to become a committer and we are pleased
> to
> >
> > announce that he has accepted.
> >
> >
> > Haiting contributed a lot of interesting additions to the project, and
> > helped a lot to answer the user’s questions like in github issues, wechat
> > groups and slack channels.  His full list of contributions in github
> > can be
> > found at https://github.com/apache/pulsar/commits?author=jason918.
> >
> >
> > Welcome and Congratulations, Haiting! Please enjoy the journey as a
> > committer :)
> >
> >
> > Please join us in congratulating and welcoming Haiting onboard!
> >
> > Best Regards,
> > Jia on behalf of the Pulsar PMC
>

Re: [VOTE] PIP-129: Introduce intermediate state for ledger deletion

Re: [VOTE] PIP-129: Introduce intermediate state for ledger deletion

[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #207: [CI] Show status and logs for metadata job in CI logs

[GitHub] [pulsar-helm-chart] lhotari merged pull request #207: [CI] Show status and logs for metadata job in CI logs

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #190: Bump to Pulsar 2.8.2

[GitHub] [pulsar-helm-chart] lhotari edited a comment on pull request #190: Bump to Pulsar 2.8.2

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #190: Bump to Pulsar 2.8.2

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #190: Bump to Pulsar 2.8.2

[GitHub] [pulsar-helm-chart] lhotari edited a comment on pull request #190: Bump to Pulsar 2.8.2

[GitHub] [pulsar-helm-chart] frankjkelly commented on pull request #200: Use appVersion as default tag for Pulsar images

[GitHub] [pulsar-adapters] lhotari opened a new pull request #32: Upgrade Log4J2 to 2.17.1

[GitHub] [pulsar-helm-chart] pellicano commented on pull request #205: Tiered Storage config

[GitHub] [pulsar-adapters] lhotari merged pull request #32: Upgrade Log4J2 to 2.17.1

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #200: Use appVersion as default tag for Pulsar images

Re: [VOTE] PIP-135: Include MetadataStore backend for Etcd

[DISCUSS] PIP-86: Pulsar Functions: Preload and release external resources

Re: [DISCUSS] PIP-86: Pulsar Functions: Preload and release external resources

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #127: Antiaffinity with zone topology for high availability

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a change in pull request #155: Add grafana data persistence support.

Re: [DISCUSSION] PIP-133 Pulsar Functions Add API For Accessing Other Function States

Re: [PR] Pulsar non root docker image

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a change in pull request #206: Upgrade default images for Grafana & Pulsar Manager

Re: [DISCUSS] New repository for website - pulsar-site

Re: [DISCUSS] New repository for website - pulsar-site

Re: [DISCUSS] New repository for website - pulsar-site

[GitHub] [pulsar-helm-chart] dragonls commented on a change in pull request #155: Add grafana data persistence support.

Re: [DISCUSS] PIP-86: Pulsar Functions: Preload and release external resources

Re: [DISCUSS] New repository for website - pulsar-site

Re: [DISCUSS] New repository for website - pulsar-site

[ANNOUNCE] New Committer: Haiting Jiang

??????[ANNOUNCE] New Committer: Haiting Jiang

[GitHub] [pulsar-helm-chart] dragonls commented on a change in pull request #155: Add grafana data persistence support.

[GitHub] [pulsar-helm-chart] dragonls commented on a change in pull request #155: Add grafana data persistence support.

Re: [ANNOUNCE] New Committer: Haiting Jiang

Re: [ANNOUNCE] New Committer: Haiting Jiang

35 matches

Site Navigation

Mail list logo

Footer information