michaeljmarshall commented on a change in pull request #155:
URL: https://github.com/apache/pulsar-helm-chart/pull/155#discussion_r789135437



##########
File path: charts/pulsar/values.yaml
##########
@@ -988,6 +988,24 @@ grafana:
     requests:
       memory: 250Mi
       cpu: 0.1
+  volumes:
+    # use a persistent volume or emptyDir
+    persistence: true

Review comment:
       What is the reasoning for making this the default behavior? 
Alternatively, we could mount dashboards as config maps and avoid the extra 
storage costs associated with a PVC.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to