[GitHub] [ozone-site] flirmnave opened a new pull request #1: HDDS-4415. Add mail lists page on ozone website
flirmnave opened a new pull request #1: URL: https://github.com/apache/ozone-site/pull/1 ## What changes were proposed in this pull request? Add **Community** menu. This page contains Ozone mailing list, Ozone slack, Ozone community call. But there is a question: Should I add past mailing archives to this page? Like this http://mail-archives.apache.org/mod_mbox/hadoop-ozone-dev/ ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-4415 ## How was this patch tested? Locally with hugo.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] cxorm commented on a change in pull request #1: HDDS-4415. Add mail lists page on ozone website
cxorm commented on a change in pull request #1: URL: https://github.com/apache/ozone-site/pull/1#discussion_r518122171 ## File path: content/community.md ## @@ -0,0 +1,63 @@ +--- +title: Ozone Community +--- + +## Ozone Mailing Lists + +### Developers + +If you’d like to contribute to Ozone, please subscribe to the Hadoop developer mailing list. Review comment: ```suggestion If you’d like to contribute to Ozone, please subscribe to the Ozone developer mailing list. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] flirmnave commented on pull request #1: HDDS-4415. Add mail lists page on ozone website
flirmnave commented on pull request #1: URL: https://github.com/apache/ozone-site/pull/1#issuecomment-722985571 Thanks @cxorm for the review and comment. I update the ozone community information.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] cxorm commented on a change in pull request #1: HDDS-4415. Add mail lists page on ozone website
cxorm commented on a change in pull request #1: URL: https://github.com/apache/ozone-site/pull/1#discussion_r519263085 ## File path: content/community.md ## @@ -0,0 +1,43 @@ +--- +title: Ozone Community +--- + +## Ozone Mailing Lists + +### Developers + +If you’d like to contribute to Ozone, please subscribe to the Ozone developer mailing list. + +The Ozone developer mailing list is: dev@ozone.apache.org. + +* [Subscribe to List](dev-subscr...@ozone.apache.org) +* [Unsubscribe from List](dev-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-dev/) + +### Commits + +If you’d like to see changes made in the Ozone version control system, please subscribe to the Ozone commits mailing list. + +The Ozone commits mailing list is: comm...@ozone.apache.org. + +* [Subscribe to List](commits-subscr...@ozone.apache.org) +* [Unsubscribe from List](commits-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-commits/) + +### Issues + +If you’d like to see changes made in the Ozone issue tracking system, please subscribe to the Ozone issues mailing list. + +The Ozone issues mailing list is: ss...@ozone.apache.org. Review comment: ```suggestion The Ozone issues mailing list is: iss...@ozone.apache.org. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] cxorm commented on a change in pull request #1: HDDS-4415. Add mail lists page on ozone website
cxorm commented on a change in pull request #1: URL: https://github.com/apache/ozone-site/pull/1#discussion_r519263118 ## File path: content/community.md ## @@ -0,0 +1,43 @@ +--- +title: Ozone Community +--- + +## Ozone Mailing Lists + +### Developers + +If you’d like to contribute to Ozone, please subscribe to the Ozone developer mailing list. + +The Ozone developer mailing list is: dev@ozone.apache.org. + +* [Subscribe to List](dev-subscr...@ozone.apache.org) +* [Unsubscribe from List](dev-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-dev/) + +### Commits + +If you’d like to see changes made in the Ozone version control system, please subscribe to the Ozone commits mailing list. + +The Ozone commits mailing list is: comm...@ozone.apache.org. + +* [Subscribe to List](commits-subscr...@ozone.apache.org) +* [Unsubscribe from List](commits-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-commits/) + +### Issues + +If you’d like to see changes made in the Ozone issue tracking system, please subscribe to the Ozone issues mailing list. + +The Ozone issues mailing list is: ss...@ozone.apache.org. Review comment: ```suggestion The Ozone issues mailing list is: iss...@ozone.apache.org. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] adoroszlai commented on a change in pull request #1: HDDS-4415. Add mail lists page on ozone website
adoroszlai commented on a change in pull request #1: URL: https://github.com/apache/ozone-site/pull/1#discussion_r519594558 ## File path: content/community.md ## @@ -0,0 +1,43 @@ +--- +title: Ozone Community +--- + +## Ozone Mailing Lists + +### Developers + +If you’d like to contribute to Ozone, please subscribe to the Ozone developer mailing list. + +The Ozone developer mailing list is: dev@ozone.apache.org. + +* [Subscribe to List](dev-subscr...@ozone.apache.org) +* [Unsubscribe from List](dev-unsubscr...@ozone.apache.org) Review comment: ```suggestion * [Subscribe to List](mailto:dev-subscr...@ozone.apache.org) * [Unsubscribe from List](mailto:dev-unsubscr...@ozone.apache.org) ``` ## File path: content/community.md ## @@ -0,0 +1,43 @@ +--- +title: Ozone Community +--- + +## Ozone Mailing Lists + +### Developers + +If you’d like to contribute to Ozone, please subscribe to the Ozone developer mailing list. + +The Ozone developer mailing list is: dev@ozone.apache.org. + +* [Subscribe to List](dev-subscr...@ozone.apache.org) +* [Unsubscribe from List](dev-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-dev/) + +### Commits + +If you’d like to see changes made in the Ozone version control system, please subscribe to the Ozone commits mailing list. + +The Ozone commits mailing list is: comm...@ozone.apache.org. + +* [Subscribe to List](commits-subscr...@ozone.apache.org) +* [Unsubscribe from List](commits-unsubscr...@ozone.apache.org) Review comment: ```suggestion * [Subscribe to List](mailto:commits-subscr...@ozone.apache.org) * [Unsubscribe from List](mailto:commits-unsubscr...@ozone.apache.org) ``` ## File path: content/community.md ## @@ -0,0 +1,43 @@ +--- +title: Ozone Community +--- + +## Ozone Mailing Lists + +### Developers + +If you’d like to contribute to Ozone, please subscribe to the Ozone developer mailing list. + +The Ozone developer mailing list is: dev@ozone.apache.org. + +* [Subscribe to List](dev-subscr...@ozone.apache.org) +* [Unsubscribe from List](dev-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-dev/) + +### Commits + +If you’d like to see changes made in the Ozone version control system, please subscribe to the Ozone commits mailing list. + +The Ozone commits mailing list is: comm...@ozone.apache.org. + +* [Subscribe to List](commits-subscr...@ozone.apache.org) +* [Unsubscribe from List](commits-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-commits/) + +### Issues + +If you’d like to see changes made in the Ozone issue tracking system, please subscribe to the Ozone issues mailing list. + +The Ozone issues mailing list is: ss...@ozone.apache.org. + +* [Subscribe to List](issues-subscr...@ozone.apache.org) +* [Unsubscribe from List](issues-unsubscr...@ozone.apache.org) Review comment: ```suggestion * [Subscribe to List](mailto:issues-subscr...@ozone.apache.org) * [Unsubscribe from List](mailto:issues-unsubscr...@ozone.apache.org) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] flirmnave commented on pull request #1: HDDS-4415. Add mail lists page on ozone website
flirmnave commented on pull request #1: URL: https://github.com/apache/ozone-site/pull/1#issuecomment-723851498 Thanks @adoroszlai for review and comment. I fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] smengcl commented on a change in pull request #1: HDDS-4415. Add mail lists page on ozone website
smengcl commented on a change in pull request #1: URL: https://github.com/apache/ozone-site/pull/1#discussion_r519903672 ## File path: content/community.md ## @@ -0,0 +1,43 @@ +--- +title: Ozone Community +--- + +## Ozone Mailing Lists + +### Developers + +If you’d like to contribute to Ozone, please subscribe to the Ozone developer mailing list. + +The Ozone developer mailing list is: dev@ozone.apache.org. + +* [Subscribe to List](mailto:dev-subscr...@ozone.apache.org) +* [Unsubscribe from List](mailto:dev-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-dev/) + +### Commits + +If you’d like to see changes made in the Ozone version control system, please subscribe to the Ozone commits mailing list. + +The Ozone commits mailing list is: comm...@ozone.apache.org. + +* [Subscribe to List](mailto:commits-subscr...@ozone.apache.org) +* [Unsubscribe from List](mailto:commits-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-commits/) + +### Issues + +If you’d like to see changes made in the Ozone issue tracking system, please subscribe to the Ozone issues mailing list. + +The Ozone issues mailing list is: iss...@ozone.apache.org. + +* [Subscribe to List](mailto:issues-subscr...@ozone.apache.org) +* [Unsubscribe from List](mailto:issues-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-issues/) + +## Ozone Slack + +If you would like to join the Ozone slack Channel, Please use this link to get self-invited https://s.apache.org/slack-invite and join the **#ozone** channel. Review comment: Nit: Capital "S" for slack. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] cxorm commented on pull request #1: HDDS-4415. Add mail lists page on ozone website
cxorm commented on pull request #1: URL: https://github.com/apache/ozone-site/pull/1#issuecomment-724111822 > Thanks @flirmnave for working on this. Looks good, but the email address links need `mailto:` protocol. Otherwise they are treated as web links and result in 404. Thanks @adoroszlai for the nice catch. TIL : ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] cku328 commented on a change in pull request #1: HDDS-4415. Add mail lists page on ozone website
cku328 commented on a change in pull request #1: URL: https://github.com/apache/ozone-site/pull/1#discussion_r519944036 ## File path: content/community.md ## @@ -0,0 +1,43 @@ +--- +title: Ozone Community +--- + +## Ozone Mailing Lists + +### Developers + +If you’d like to contribute to Ozone, please subscribe to the Ozone developer mailing list. + +The Ozone developer mailing list is: dev@ozone.apache.org. + +* [Subscribe to List](mailto:dev-subscr...@ozone.apache.org) +* [Unsubscribe from List](mailto:dev-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-dev/) + +### Commits + +If you’d like to see changes made in the Ozone version control system, please subscribe to the Ozone commits mailing list. + +The Ozone commits mailing list is: comm...@ozone.apache.org. + +* [Subscribe to List](mailto:commits-subscr...@ozone.apache.org) +* [Unsubscribe from List](mailto:commits-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-commits/) + +### Issues + +If you’d like to see changes made in the Ozone issue tracking system, please subscribe to the Ozone issues mailing list. + +The Ozone issues mailing list is: iss...@ozone.apache.org. + +* [Subscribe to List](mailto:issues-subscr...@ozone.apache.org) +* [Unsubscribe from List](mailto:issues-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-issues/) + +## Ozone Slack + +If you would like to join the Ozone slack Channel, Please use this link to get self-invited https://s.apache.org/slack-invite and join the **#ozone** channel. Review comment: I think "p" should be lowercase here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] adoroszlai commented on a change in pull request #1: HDDS-4415. Add mail lists page on ozone website
adoroszlai commented on a change in pull request #1: URL: https://github.com/apache/ozone-site/pull/1#discussion_r519951691 ## File path: content/community.md ## @@ -0,0 +1,43 @@ +--- +title: Ozone Community +--- + +## Ozone Mailing Lists + +### Developers + +If you’d like to contribute to Ozone, please subscribe to the Ozone developer mailing list. + +The Ozone developer mailing list is: dev@ozone.apache.org. + +* [Subscribe to List](mailto:dev-subscr...@ozone.apache.org) +* [Unsubscribe from List](mailto:dev-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-dev/) + +### Commits + +If you’d like to see changes made in the Ozone version control system, please subscribe to the Ozone commits mailing list. + +The Ozone commits mailing list is: comm...@ozone.apache.org. + +* [Subscribe to List](mailto:commits-subscr...@ozone.apache.org) +* [Unsubscribe from List](mailto:commits-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-commits/) + +### Issues + +If you’d like to see changes made in the Ozone issue tracking system, please subscribe to the Ozone issues mailing list. + +The Ozone issues mailing list is: iss...@ozone.apache.org. + +* [Subscribe to List](mailto:issues-subscr...@ozone.apache.org) +* [Unsubscribe from List](mailto:issues-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-issues/) + +## Ozone Slack + +If you would like to join the Ozone slack Channel, Please use this link to get self-invited https://s.apache.org/slack-invite and join the **#ozone** channel. Review comment: @flirmnave if you are making further changes, please also update http://mail-archives.apache.org links to HTTPS. (I didn't want to ask for this change in itself...) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] cku328 commented on a change in pull request #1: HDDS-4415. Add mail lists page on ozone website
cku328 commented on a change in pull request #1: URL: https://github.com/apache/ozone-site/pull/1#discussion_r519944036 ## File path: content/community.md ## @@ -0,0 +1,43 @@ +--- +title: Ozone Community +--- + +## Ozone Mailing Lists + +### Developers + +If you’d like to contribute to Ozone, please subscribe to the Ozone developer mailing list. + +The Ozone developer mailing list is: dev@ozone.apache.org. + +* [Subscribe to List](mailto:dev-subscr...@ozone.apache.org) +* [Unsubscribe from List](mailto:dev-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-dev/) + +### Commits + +If you’d like to see changes made in the Ozone version control system, please subscribe to the Ozone commits mailing list. + +The Ozone commits mailing list is: comm...@ozone.apache.org. + +* [Subscribe to List](mailto:commits-subscr...@ozone.apache.org) +* [Unsubscribe from List](mailto:commits-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-commits/) + +### Issues + +If you’d like to see changes made in the Ozone issue tracking system, please subscribe to the Ozone issues mailing list. + +The Ozone issues mailing list is: iss...@ozone.apache.org. + +* [Subscribe to List](mailto:issues-subscr...@ozone.apache.org) +* [Unsubscribe from List](mailto:issues-unsubscr...@ozone.apache.org) +* [Archives](http://mail-archives.apache.org/mod_mbox/ozone-issues/) + +## Ozone Slack + +If you would like to join the Ozone slack Channel, Please use this link to get self-invited https://s.apache.org/slack-invite and join the **#ozone** channel. Review comment: I think "p" should be lowercase here. Please -> please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] flirmnave commented on pull request #1: HDDS-4415. Add mail lists page on ozone website
flirmnave commented on pull request #1: URL: https://github.com/apache/ozone-site/pull/1#issuecomment-724465389 Thanks @cxorm @adoroszlai @smengcl @cku328 for review and comment. I update it. And add a section named **Older Archives**. Can you please share your suggestions? Thanks.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] cxorm merged pull request #1: HDDS-4415. Add mail lists page on ozone website
cxorm merged pull request #1: URL: https://github.com/apache/ozone-site/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] cxorm commented on pull request #1: HDDS-4415. Add mail lists page on ozone website
cxorm commented on pull request #1: URL: https://github.com/apache/ozone-site/pull/1#issuecomment-725938310 Thank you all for the careful reviews, @adoroszlai , @cku328 and @smengcl . Thank you @flirmnave for working on this. I have committed it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] flirmnave commented on pull request #1: HDDS-4415. Add mail lists page on ozone website
flirmnave commented on pull request #1: URL: https://github.com/apache/ozone-site/pull/1#issuecomment-725946399 Thanks @cxorm for commit and @adoroszlai @smengcl @cku328 for review. :smiley: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-runner] elek opened a new pull request #1: HDDS-4795. Separate source of Ozone container images to different repositories
elek opened a new pull request #1: URL: https://github.com/apache/ozone-docker-runner/pull/1 This PR contains basic cleanup after moving out the source of `apache/ozone-runner` to this repository. Basic Github action workflow + standard descriptors (PR template, notification) + README update. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-runner] adoroszlai commented on a change in pull request #1: HDDS-4795. Separate source of Ozone container images to different repositories
adoroszlai commented on a change in pull request #1: URL: https://github.com/apache/ozone-docker-runner/pull/1#discussion_r571382666 ## File path: README.md ## @@ -15,15 +15,35 @@ limitations under the License. --> -# Apache Ozone runner base image +# Apache Ozone **runner** base image -This is the base image to run Apache Hadoop Ozone in docker containers. This is for test/develop and not for production. +This is the base image to run Apache Hadoop Ozone in docker containers. This is only for test/develop and not for production. -It doesn't include any Ozone specific jar files or release artifacts just any empty environment which includes all the specific tools to run Apache Hadoop Ozone inside containers. +The container doesn't include any Ozone specific jar files or release artifacts just an empty environment which includes all the specific tools to run and test Apache Ozone inside containers. -To build it, please use: +The image is available as [apache/ozone-runner](https://hub.docker.com/r/apache/ozone-runner). Build is managed by Docker Hub. + +## Development + +To build the image, please use: + +``` +docker build -t apache/ozone-runner:dev . +``` + +To test it with Apache Ozone, do a custom build: Review comment: ```suggestion To test it, build [Apache Ozone](https://github.com/apache/ozone): ``` ## File path: README.md ## @@ -15,15 +15,35 @@ limitations under the License. --> -# Apache Ozone runner base image +# Apache Ozone **runner** base image -This is the base image to run Apache Hadoop Ozone in docker containers. This is for test/develop and not for production. +This is the base image to run Apache Hadoop Ozone in docker containers. This is only for test/develop and not for production. -It doesn't include any Ozone specific jar files or release artifacts just any empty environment which includes all the specific tools to run Apache Hadoop Ozone inside containers. +The container doesn't include any Ozone specific jar files or release artifacts just an empty environment which includes all the specific tools to run and test Apache Ozone inside containers. -To build it, please use: +The image is available as [apache/ozone-runner](https://hub.docker.com/r/apache/ozone-runner). Build is managed by Docker Hub. + +## Development + +To build the image, please use: + +``` +docker build -t apache/ozone-runner:dev . +``` + +To test it with Apache Ozone, do a custom build: ``` -docker build -t apache/ozone-runner +mvn clean install -DskipTests -Dskip.npx -DskipShade -o -Ddocker.ozone-runner.version=dev Review comment: I think "offline" mode is not required here, and I'd rather avoid install into local repo. ```suggestion mvn clean verify -DskipTests -Dskip.npx -DskipShade -Ddocker.ozone-runner.version=dev ``` ## File path: .github/workflows/build.yaml ## @@ -0,0 +1,26 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: build +on: + - push Review comment: Should it also build on PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-runner] elek commented on pull request #1: HDDS-4795. Separate source of Ozone container images to different repositories
elek commented on pull request #1: URL: https://github.com/apache/ozone-docker-runner/pull/1#issuecomment-775080667 Thanks for the review @adoroszlai. I applied the suggestions. After merging it, I am planning to do the following next steps: 1. Create a similar initial commit for `apache/ozone-docker-builder` 2. Remove files from the `apache/ozone-docker` repository from the build/runner branches with a README which points to the new repositories 3. Create new tags to test the docker hub builds (master is already built well). I also considered pushing docker images directly from the github actions to the github repository `ghcr.io/...`. It can make the builds faster as I assume the intra-azure traffic is faster. I tested it, and it worked well: I created an optional step which was executed only for tags, and pushed the image. But it can work only with setting additional permissions which is pending on https://issues.apache.org/jira/browse/INFRA-20959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-builder] elek opened a new pull request #1: HDDS-4795. Separate source of Ozone container images to different repositories
elek opened a new pull request #1: URL: https://github.com/apache/ozone-docker-builder/pull/1 Similar to fd796d64ce6e387ad7b93e88605ed97cc755ef85, this pull request contains initial README/builds/github actions after the separation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-builder] adoroszlai commented on a change in pull request #1: HDDS-4795. Separate source of Ozone container images to different repositories
adoroszlai commented on a change in pull request #1: URL: https://github.com/apache/ozone-docker-builder/pull/1#discussion_r583521241 ## File path: SECURITY.md ## @@ -0,0 +1,5 @@ +# Security Policy + +This container image (`apache/ozone-runner`) is indented to be used only in *test and dev* environment. Please don't use it in production environment. Review comment: ```suggestion This container image (`apache/ozone-build`) is indented to be used only in *test and dev* environment. Please don't use it in production environment. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-testkrb5] elek opened a new pull request #1: Provide testkrb5 image for faster ozonesecure tests
elek opened a new pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1 Today ozonesecure compose clusters (and ozonesecure-ha and ozonesecure-mr) use an adhoc keytab issuer. The issuer is download during the [image creation](https://github.com/apache/ozone/blob/master/hadoop-ozone/dist/src/main/compose/common/docker-image/docker-krb5/Dockerfile-krb5) and uses a [third party](https://github.com/flokkr/issuer) go lang application to create the keytabs on-demand. As discussed earlier, it would be faster to use a dedicacated, pre-built container image which includes the pre-created keytabs instead of issuing them on-the fly. For each of the tagged images we can export to current keytabs to `hadoop-ozone/dist/src/main/compose/` which can be mounted to the compose clusters. It makes the overall acceptance test faster (instead of creating keytab, which is quite slow, we can start the cluster immediately). And we don't need to depend on an external utility app. Pre-created keytabs are also more similar to production environment... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-testkrb5] elek commented on pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests
elek commented on pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#issuecomment-793989075 Tested on a [forked branch](https://github.com/elek/ozone/tree/docker-secure), and finally [it's passed](https://github.com/elek/ozone/runs/2056855876) (= only an intermittent integration test is failed, all the acceptance tests are passed). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-testkrb5] adoroszlai commented on a change in pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests
adoroszlai commented on a change in pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#discussion_r590497494 ## File path: .github/workflows/build.yaml ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: build +on: + - push + - pull_request +jobs: + build: +name: build and deploy +runs-on: ubuntu-18.04 +steps: + - name: checkout source +uses: actions/checkout@master Review comment: ```suggestion uses: actions/checkout@v2 ``` ## File path: README.md ## @@ -0,0 +1,9 @@ +# Containerized MIT Kerberos server for Ozone dev environments + +This repository containers the container definition of a MIT Kerberos server. Review comment: ```suggestion This repository contains the definition of a containerized MIT Kerberos server. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-testkrb5] elek commented on a change in pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests
elek commented on a change in pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#discussion_r590533575 ## File path: .github/workflows/build.yaml ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: build +on: + - push + - pull_request +jobs: + build: +name: build and deploy +runs-on: ubuntu-18.04 +steps: + - name: checkout source +uses: actions/checkout@master Review comment: Yes, it should be added to my routine. I copied this file from ozone-docker-runner (and ozone-docker-builder) so we can update those, too... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-testkrb5] adoroszlai commented on a change in pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests
adoroszlai commented on a change in pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#discussion_r590537066 ## File path: .github/workflows/build.yaml ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: build +on: + - push + - pull_request +jobs: + build: +name: build and deploy +runs-on: ubuntu-18.04 +steps: + - name: checkout source +uses: actions/checkout@master Review comment: Yep, PRs are there: https://github.com/apache/ozone-docker-builder/pull/2 and https://github.com/apache/ozone-docker-runner/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-testkrb5] elek commented on a change in pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests
elek commented on a change in pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#discussion_r591223319 ## File path: .github/workflows/build.yaml ## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: build +on: + - push + - pull_request +jobs: + build: +name: build and deploy +runs-on: ubuntu-18.04 +steps: + - name: checkout source +uses: actions/checkout@master Review comment: Oh, they were opened 8 days ago? I am behind you with one week ;-) Just merged them... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-testkrb5] adoroszlai commented on pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests
adoroszlai commented on pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#issuecomment-795234468 Thanks @elek for updating the patch. Do you have any hint on the problem with the image built locally? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-testkrb5] elek commented on pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests
elek commented on pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#issuecomment-796569758 > Shouldn't it be possible to seamlessly use a different image? How will image update work (eg. when a new principal is needed)? Are there any steps I missed? Good question. There are two required steps for getting kerberos keytab: 1. Generating the key 2. exporting the key to an extrenal keytabs In the existing solution both are handled by the golang rest app **runtime**. (Therefore the startup of secure servers are quite slow... Partially improved in HDDS-2895). With the new approach the generation happens in container build time, and the export should happen once when the docker image version is updated (and exported keytabs are committed) It means that you must update the keytabs for each new image built. If you create new image, please execute the `generate-keytab` command from the sample branch. But after exporting the keytabs first all subsequent runs will be slower as don't require any more keytab generation / export... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-testkrb5] adoroszlai commented on pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests
adoroszlai commented on pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#issuecomment-796573963 > the export should happen once when the docker image version is updated (and exported keytabs are committed) > please execute the `generate-keytab` command from the sample branch Thanks for the explanation. Where do I find this command? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-testkrb5] elek commented on pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests
elek commented on pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#issuecomment-796672157 > Thanks for the explanation. Where do I find this command? It's here: https://github.com/elek/ozone/tree/docker-secure/hadoop-ozone/dist/src/main/keytabs More preciously here: https://github.com/elek/ozone/blob/docker-secure/hadoop-ozone/dist/src/main/keytabs/update-keytabs.sh keytabs are generated once and committed. `dist-layout-stitching` copies them to the right places. (`apache/ozone` patch may need better documentation about this process) The trick in the script is that it runs inside a docker container to have access to all the keytabs which are generated by the init.sh in this patch... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-docker-testkrb5] elek commented on pull request #1: HDDS-4938. Provide testkrb5 image for faster ozonesecure tests
elek commented on pull request #1: URL: https://github.com/apache/ozone-docker-testkrb5/pull/1#issuecomment-802680678 Thanks the review, merging it now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] adoroszlai opened a new pull request #2: HDDS-5034. Update wiki links in website
adoroszlai opened a new pull request #2: URL: https://github.com/apache/ozone-site/pull/2 ## What changes were proposed in this pull request? Update references to Hadoop wiki. https://issues.apache.org/jira/browse/HDDS-5034 ## How was this patch tested? ``` hugo serve open http://localhost:1313/ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] adoroszlai opened a new pull request #3: HDDS-5036. Apply merge/notification settings to ozone-site repo
adoroszlai opened a new pull request #3: URL: https://github.com/apache/ozone-site/pull/3 ## What changes were proposed in this pull request? * Only allow squash merge. * Send issue/PR updates to `issues@`, not `dev@`. * Add PR link and label in Jira. https://issues.apache.org/jira/browse/HDDS-5036 ## How was this patch tested? Not tested, but same settings worked for other Ozone repos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone-site] elek merged pull request #3: HDDS-5036. Apply merge/notification settings to ozone-site repo
elek merged pull request #3: URL: https://github.com/apache/ozone-site/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3175: HDDS-6414. Ozone doesn’t reclaim space after deletion of volume via ofs
rakeshadr commented on code in PR #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r841389614
##
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##
@@ -567,7 +626,12 @@ public boolean delete(Path f, boolean recursive) throws
IOException {
}
}
- result = innerDelete(f, recursive);
+ if (ofsPath.isBucket() && isFSObucket(ofsPath.getVolumeName(),
+ ofsPath.getBucketName())) {
+result = recursiveBucketDelete(f, recursive);
Review Comment:
@sadanand48 Thanks for the updated patch.
Can we do the iterator creation using `DeleteIteratorFactory` something
like below:
`private class DeleteIteratorWithFSO extends DeleteIterator {`
```
private class DeleteIteratorFactory {
Path path;
boolean recursive;
OFSPath ofsPath;
DeleteIteratorFactory(Path f, boolean recursive,
OFSPath ofsPath) {
path = f;
recursive = recursive;
ofsPath = ofsPath;
}
DeleteIterator getDeleteIterator()
throws IOException {
DeleteIterator deleteIterator;
if (ofsPath.isBucket() &&
isFSObucket(ofsPath.getVolumeName(), ofsPath.getBucketName())) {
deleteIterator = new DeleteIteratorWithFSO(path, recursive);
} else {
deleteIterator = new DeleteIterator(path, recursive);
}
return deleteIterator;
}
}
```
```
private boolean innerDelete(Path f, boolean recursive, OFSPath ofsPath)
throws IOException {
LOG.trace("delete() path:{} recursive:{}", f, recursive);
try {
DeleteIterator iterator =
new DeleteIteratorFactory(f, recursive,
ofsPath).getDeleteIterator();
return iterator.iterate();
} catch (FileNotFoundException e) {
if (LOG.isDebugEnabled()) {
LOG.debug("Couldn't delete {} - does not exist", f);
}
return false;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3175: HDDS-6414. Ozone doesn’t reclaim space after deletion of volume via ofs
rakeshadr commented on code in PR #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r841390333
##
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##
@@ -468,6 +468,42 @@ boolean processKeyPath(List keyPathList) {
}
}
+ /**
+ * To be used only by recursiveBucketDelete().
+ */
+ private class DeleteIteratorWithFSO extends OzoneListingIterator {
+private final OzoneBucket bucket;
+private final BasicRootedOzoneClientAdapterImpl adapterImpl;
+private boolean recursive;
+private Path f;
+DeleteIteratorWithFSO(Path f, boolean recursive)
+throws IOException {
+ super(f, true);
+ this.f = f;
+ this.recursive = recursive;
+ // Initialize bucket here to reduce number of RPC calls
+ OFSPath ofsPath = new OFSPath(f);
+ adapterImpl = (BasicRootedOzoneClientAdapterImpl) adapter;
+ this.bucket = adapterImpl.getBucket(ofsPath, false);
Review Comment:
Can you please add a debug log message to know whether the deletion happens
via new DeleteIteratorWithFSO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3175: HDDS-6414. Ozone doesn’t reclaim space after deletion of volume via ofs
rakeshadr commented on code in PR #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r841391130
##
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##
@@ -986,15 +1076,15 @@ boolean iterate() throws IOException {
OFSPath ofsPath = new OFSPath(pathKey);
String ofsPathPrefix =
ofsPath.getNonKeyPathNoPrefixDelim() + OZONE_URI_DELIMITER;
-while (keyIterator.hasNext()) {
- BasicKeyInfo key = keyIterator.next();
- // Convert key to full path before passing it to processKeyPath
- // TODO: This conversion is redundant. But want to use only full path
- // outside AdapterImpl. - Maybe a refactor later.
- String keyPath = ofsPathPrefix + key.getName();
- LOG.trace("iterating key path: {}", keyPath);
- if (!key.getName().equals("")) {
-keyPathList.add(keyPath);
+if (isFSO) {
+ FileStatus[] fileStatuses;
+ fileStatuses = listStatus(path);
+ for (FileStatus fileStatus : fileStatuses) {
+String keyName =
+new OFSPath(fileStatus.getPath().toString()).getKeyName();
+keyName = status.isDirectory() ? addTrailingSlashIfNeeded(keyName)
:
Review Comment:
Should we need #addTrailingSlashIfNeeded logic ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3175: HDDS-6414. Ozone doesn’t reclaim space after deletion of volume via ofs
rakeshadr commented on code in PR #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r841394899
##
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##
@@ -489,6 +532,29 @@ private boolean innerDelete(Path f, boolean recursive)
throws IOException {
}
}
+ /**
+ * Deletes the children of the bucket i.e all files and dirs under it's
+ * path by iterating though th DeleteIteratorWithFSO.
+ *
+ * @param f directory path to be deleted
+ * @return true if successfully deletes all required keys, false otherwise
+ * @throws IOException
+ */
+ private boolean recursiveBucketDelete(Path f, boolean recursive)
+ throws IOException {
+LOG.trace("delete() path:{}", f);
+try {
+ DeleteIteratorWithFSO iterator = new DeleteIteratorWithFSO(f, recursive);
Review Comment:
Thanks for the discussion around this. On a second thought, I agreed to
avoid `recursive` flag attribute in the proto with additional special handling
on the server side. Probably, can proceed with the existing deleteObjects()
call by sending immediate sub-paths for FSO bucket. We can revisit if there is
any performance requirement comes or any other case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3175: HDDS-6414. Ozone doesn’t reclaim space after deletion of volume via ofs
rakeshadr commented on code in PR #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r841400022
##
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OmKeysDeleteRequestWithFSO.java:
##
@@ -0,0 +1,266 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.om.request.key;
+
+import com.google.common.base.Optional;
+import org.apache.commons.lang3.tuple.Pair;
+import org.apache.hadoop.hdds.utils.db.cache.CacheKey;
+import org.apache.hadoop.hdds.utils.db.cache.CacheValue;
+import org.apache.hadoop.ozone.audit.AuditLogger;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.ResolvedBucket;
+import org.apache.hadoop.ozone.om.helpers.BucketLayout;
+import org.apache.hadoop.ozone.om.helpers.OmBucketInfo;
+import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
+import org.apache.hadoop.ozone.om.helpers.OzoneFSUtils;
+import org.apache.hadoop.ozone.om.helpers.OzoneFileStatus;
+import org.apache.hadoop.ozone.om.ratis.utils.OzoneManagerDoubleBufferHelper;
+import org.apache.hadoop.ozone.om.request.file.OMFileRequest;
+import org.apache.hadoop.ozone.om.request.util.OmResponseUtil;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.key.OMKeysDeleteResponse;
+import org.apache.hadoop.ozone.om.response.key.OMKeysDeleteResponseWithFSO;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+import static org.apache.hadoop.ozone.OzoneConsts.BUCKET;
+import static org.apache.hadoop.ozone.OzoneConsts.DELETED_KEYS_LIST;
+import static org.apache.hadoop.ozone.OzoneConsts.UNDELETED_KEYS_LIST;
+import static org.apache.hadoop.ozone.OzoneConsts.VOLUME;
+import static org.apache.hadoop.ozone.audit.OMAction.DELETE_KEYS;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.Status.OK;
+import static
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.Status.PARTIAL_DELETE;
+
+/**
+ * Handles DeleteKeys request for recursive bucket deletion.
+ */
+public class OmKeysDeleteRequestWithFSO extends OMKeysDeleteRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(OmKeysDeleteRequestWithFSO.class);
+
+ public OmKeysDeleteRequestWithFSO(
+ OzoneManagerProtocolProtos.OMRequest omRequest,
+ BucketLayout bucketLayout) {
+super(omRequest, bucketLayout);
+ }
+
+
+ @Override
+ @SuppressWarnings("methodlength")
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
+ long trxnLogIndex, OzoneManagerDoubleBufferHelper omDoubleBufferHelper) {
+OzoneManagerProtocolProtos.DeleteKeysRequest deleteKeyRequest =
+getOmRequest().getDeleteKeysRequest();
+
+OzoneManagerProtocolProtos.DeleteKeyArgs deleteKeyArgs =
+deleteKeyRequest.getDeleteKeys();
+List deleteKeys = new ArrayList<>(deleteKeyArgs.getKeysList());
+
+IOException exception = null;
+OMClientResponse omClientResponse = null;
+Result result = null;
+
+OMMetrics omMetrics = ozoneManager.getMetrics();
+omMetrics.incNumKeyDeletes();
+String volumeName = deleteKeyArgs.getVolumeName();
+String bucketName = deleteKeyArgs.getBucketName();
+Map auditMap = new LinkedHashMap<>();
+auditMap.put(VOLUME, volumeName);
+auditMap.put(BUCKET, bucketName);
+List omKeyInfoList = new ArrayList<>();
+List dirList = new ArrayList<>();
+
+AuditLogger auditLogger = ozoneManager.getAuditLogger();
+OzoneManagerProtocolProtos.UserInfo userInfo =
getOmRequest().getUserInfo();
+
+OzoneManagerProtocolProtos.OMResponse.Builder omResponse =
+OmResponseUtil.getOMResponseBuil
[GitHub] [ozone] sadanand48 commented on a diff in pull request #3175: HDDS-6414. Ozone doesn’t reclaim space after deletion of volume via ofs
sadanand48 commented on code in PR #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r841483449
##
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##
@@ -986,15 +1076,15 @@ boolean iterate() throws IOException {
OFSPath ofsPath = new OFSPath(pathKey);
String ofsPathPrefix =
ofsPath.getNonKeyPathNoPrefixDelim() + OZONE_URI_DELIMITER;
-while (keyIterator.hasNext()) {
- BasicKeyInfo key = keyIterator.next();
- // Convert key to full path before passing it to processKeyPath
- // TODO: This conversion is redundant. But want to use only full path
- // outside AdapterImpl. - Maybe a refactor later.
- String keyPath = ofsPathPrefix + key.getName();
- LOG.trace("iterating key path: {}", keyPath);
- if (!key.getName().equals("")) {
-keyPathList.add(keyPath);
+if (isFSO) {
+ FileStatus[] fileStatuses;
+ fileStatuses = listStatus(path);
+ for (FileStatus fileStatus : fileStatuses) {
+String keyName =
+new OFSPath(fileStatus.getPath().toString()).getKeyName();
+keyName = status.isDirectory() ? addTrailingSlashIfNeeded(keyName)
:
Review Comment:
Yes this was not needed, removed
##
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##
@@ -468,6 +468,42 @@ boolean processKeyPath(List keyPathList) {
}
}
+ /**
+ * To be used only by recursiveBucketDelete().
+ */
+ private class DeleteIteratorWithFSO extends OzoneListingIterator {
+private final OzoneBucket bucket;
+private final BasicRootedOzoneClientAdapterImpl adapterImpl;
+private boolean recursive;
+private Path f;
+DeleteIteratorWithFSO(Path f, boolean recursive)
+throws IOException {
+ super(f, true);
+ this.f = f;
+ this.recursive = recursive;
+ // Initialize bucket here to reduce number of RPC calls
+ OFSPath ofsPath = new OFSPath(f);
+ adapterImpl = (BasicRootedOzoneClientAdapterImpl) adapter;
+ this.bucket = adapterImpl.getBucket(ofsPath, false);
Review Comment:
Done
##
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##
@@ -567,7 +626,12 @@ public boolean delete(Path f, boolean recursive) throws
IOException {
}
}
- result = innerDelete(f, recursive);
+ if (ofsPath.isBucket() && isFSObucket(ofsPath.getVolumeName(),
+ ofsPath.getBucketName())) {
+result = recursiveBucketDelete(f, recursive);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For additional commands, e-mail: dev-h...@ozone.apache.org
[GitHub] [ozone] sadanand48 commented on a diff in pull request #3175: HDDS-6414. Ozone doesn’t reclaim space after deletion of volume via ofs
sadanand48 commented on code in PR #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r841486761
##
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OmKeysDeleteRequestWithFSO.java:
##
@@ -0,0 +1,266 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.om.request.key;
+
+import com.google.common.base.Optional;
+import org.apache.commons.lang3.tuple.Pair;
+import org.apache.hadoop.hdds.utils.db.cache.CacheKey;
+import org.apache.hadoop.hdds.utils.db.cache.CacheValue;
+import org.apache.hadoop.ozone.audit.AuditLogger;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.ResolvedBucket;
+import org.apache.hadoop.ozone.om.helpers.BucketLayout;
+import org.apache.hadoop.ozone.om.helpers.OmBucketInfo;
+import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
+import org.apache.hadoop.ozone.om.helpers.OzoneFSUtils;
+import org.apache.hadoop.ozone.om.helpers.OzoneFileStatus;
+import org.apache.hadoop.ozone.om.ratis.utils.OzoneManagerDoubleBufferHelper;
+import org.apache.hadoop.ozone.om.request.file.OMFileRequest;
+import org.apache.hadoop.ozone.om.request.util.OmResponseUtil;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.key.OMKeysDeleteResponse;
+import org.apache.hadoop.ozone.om.response.key.OMKeysDeleteResponseWithFSO;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+import static org.apache.hadoop.ozone.OzoneConsts.BUCKET;
+import static org.apache.hadoop.ozone.OzoneConsts.DELETED_KEYS_LIST;
+import static org.apache.hadoop.ozone.OzoneConsts.UNDELETED_KEYS_LIST;
+import static org.apache.hadoop.ozone.OzoneConsts.VOLUME;
+import static org.apache.hadoop.ozone.audit.OMAction.DELETE_KEYS;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.Status.OK;
+import static
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.Status.PARTIAL_DELETE;
+
+/**
+ * Handles DeleteKeys request for recursive bucket deletion.
+ */
+public class OmKeysDeleteRequestWithFSO extends OMKeysDeleteRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(OmKeysDeleteRequestWithFSO.class);
+
+ public OmKeysDeleteRequestWithFSO(
+ OzoneManagerProtocolProtos.OMRequest omRequest,
+ BucketLayout bucketLayout) {
+super(omRequest, bucketLayout);
+ }
+
+
+ @Override
+ @SuppressWarnings("methodlength")
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
+ long trxnLogIndex, OzoneManagerDoubleBufferHelper omDoubleBufferHelper) {
+OzoneManagerProtocolProtos.DeleteKeysRequest deleteKeyRequest =
+getOmRequest().getDeleteKeysRequest();
+
+OzoneManagerProtocolProtos.DeleteKeyArgs deleteKeyArgs =
+deleteKeyRequest.getDeleteKeys();
+List deleteKeys = new ArrayList<>(deleteKeyArgs.getKeysList());
+
+IOException exception = null;
+OMClientResponse omClientResponse = null;
+Result result = null;
+
+OMMetrics omMetrics = ozoneManager.getMetrics();
+omMetrics.incNumKeyDeletes();
+String volumeName = deleteKeyArgs.getVolumeName();
+String bucketName = deleteKeyArgs.getBucketName();
+Map auditMap = new LinkedHashMap<>();
+auditMap.put(VOLUME, volumeName);
+auditMap.put(BUCKET, bucketName);
+List omKeyInfoList = new ArrayList<>();
+List dirList = new ArrayList<>();
+
+AuditLogger auditLogger = ozoneManager.getAuditLogger();
+OzoneManagerProtocolProtos.UserInfo userInfo =
getOmRequest().getUserInfo();
+
+OzoneManagerProtocolProtos.OMResponse.Builder omResponse =
+OmResponseUtil.getOMResponseBui
[GitHub] [ozone] sadanand48 commented on a diff in pull request #3175: HDDS-6414. Ozone doesn’t reclaim space after deletion of volume via ofs
sadanand48 commented on code in PR #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r841486761
##
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OmKeysDeleteRequestWithFSO.java:
##
@@ -0,0 +1,266 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.ozone.om.request.key;
+
+import com.google.common.base.Optional;
+import org.apache.commons.lang3.tuple.Pair;
+import org.apache.hadoop.hdds.utils.db.cache.CacheKey;
+import org.apache.hadoop.hdds.utils.db.cache.CacheValue;
+import org.apache.hadoop.ozone.audit.AuditLogger;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.OMMetrics;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.ResolvedBucket;
+import org.apache.hadoop.ozone.om.helpers.BucketLayout;
+import org.apache.hadoop.ozone.om.helpers.OmBucketInfo;
+import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
+import org.apache.hadoop.ozone.om.helpers.OzoneFSUtils;
+import org.apache.hadoop.ozone.om.helpers.OzoneFileStatus;
+import org.apache.hadoop.ozone.om.ratis.utils.OzoneManagerDoubleBufferHelper;
+import org.apache.hadoop.ozone.om.request.file.OMFileRequest;
+import org.apache.hadoop.ozone.om.request.util.OmResponseUtil;
+import org.apache.hadoop.ozone.om.response.OMClientResponse;
+import org.apache.hadoop.ozone.om.response.key.OMKeysDeleteResponse;
+import org.apache.hadoop.ozone.om.response.key.OMKeysDeleteResponseWithFSO;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos;
+import org.apache.hadoop.ozone.security.acl.IAccessAuthorizer;
+import org.apache.hadoop.ozone.security.acl.OzoneObj;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+import static org.apache.hadoop.ozone.OzoneConsts.BUCKET;
+import static org.apache.hadoop.ozone.OzoneConsts.DELETED_KEYS_LIST;
+import static org.apache.hadoop.ozone.OzoneConsts.UNDELETED_KEYS_LIST;
+import static org.apache.hadoop.ozone.OzoneConsts.VOLUME;
+import static org.apache.hadoop.ozone.audit.OMAction.DELETE_KEYS;
+import static
org.apache.hadoop.ozone.om.lock.OzoneManagerLock.Resource.BUCKET_LOCK;
+import static
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.Status.OK;
+import static
org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.Status.PARTIAL_DELETE;
+
+/**
+ * Handles DeleteKeys request for recursive bucket deletion.
+ */
+public class OmKeysDeleteRequestWithFSO extends OMKeysDeleteRequest {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(OmKeysDeleteRequestWithFSO.class);
+
+ public OmKeysDeleteRequestWithFSO(
+ OzoneManagerProtocolProtos.OMRequest omRequest,
+ BucketLayout bucketLayout) {
+super(omRequest, bucketLayout);
+ }
+
+
+ @Override
+ @SuppressWarnings("methodlength")
+ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
+ long trxnLogIndex, OzoneManagerDoubleBufferHelper omDoubleBufferHelper) {
+OzoneManagerProtocolProtos.DeleteKeysRequest deleteKeyRequest =
+getOmRequest().getDeleteKeysRequest();
+
+OzoneManagerProtocolProtos.DeleteKeyArgs deleteKeyArgs =
+deleteKeyRequest.getDeleteKeys();
+List deleteKeys = new ArrayList<>(deleteKeyArgs.getKeysList());
+
+IOException exception = null;
+OMClientResponse omClientResponse = null;
+Result result = null;
+
+OMMetrics omMetrics = ozoneManager.getMetrics();
+omMetrics.incNumKeyDeletes();
+String volumeName = deleteKeyArgs.getVolumeName();
+String bucketName = deleteKeyArgs.getBucketName();
+Map auditMap = new LinkedHashMap<>();
+auditMap.put(VOLUME, volumeName);
+auditMap.put(BUCKET, bucketName);
+List omKeyInfoList = new ArrayList<>();
+List dirList = new ArrayList<>();
+
+AuditLogger auditLogger = ozoneManager.getAuditLogger();
+OzoneManagerProtocolProtos.UserInfo userInfo =
getOmRequest().getUserInfo();
+
+OzoneManagerProtocolProtos.OMResponse.Builder omResponse =
+OmResponseUtil.getOMResponseBui
[GitHub] [ozone] sadanand48 commented on a diff in pull request #3175: HDDS-6414. Ozone doesn’t reclaim space after deletion of volume via ofs
sadanand48 commented on code in PR #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r841489692
##
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java:
##
@@ -152,6 +152,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
String omDefaultBucketLayout = ozoneManager.getOMDefaultBucketLayout();
BucketLayout defaultType =
BucketLayout.fromString(omDefaultBucketLayout);
omBucketInfo = OmBucketInfo.getFromProtobuf(bucketInfo, defaultType);
+ LOG.info("Bucket Layout not present for volume/bucket = {}/{}, "
+ + "initialising with default bucket layout" + ": {}", volumeName,
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For additional commands, e-mail: dev-h...@ozone.apache.org
