rakeshadr commented on code in PR #3175:
URL: https://github.com/apache/ozone/pull/3175#discussion_r841394899
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##########
@@ -489,6 +532,29 @@ private boolean innerDelete(Path f, boolean recursive)
throws IOException {
}
}
+ /**
+ * Deletes the children of the bucket i.e all files and dirs under it's
+ * path by iterating though th DeleteIteratorWithFSO.
+ *
+ * @param f directory path to be deleted
+ * @return true if successfully deletes all required keys, false otherwise
+ * @throws IOException
+ */
+ private boolean recursiveBucketDelete(Path f, boolean recursive)
+ throws IOException {
+ LOG.trace("delete() path:{}", f);
+ try {
+ DeleteIteratorWithFSO iterator = new DeleteIteratorWithFSO(f, recursive);
Review Comment:
Thanks for the discussion around this. On a second thought, I agreed to
avoid `recursive` flag attribute in the proto with additional special handling
on the server side. Probably, can proceed with the existing deleteObjects()
call by sending immediate sub-paths for FSO bucket. We can revisit if there is
any performance requirement comes or any other case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ozone.apache.org
For additional commands, e-mail: dev-h...@ozone.apache.org
