Re: [PR] Add basic EditorConfig file [openoffice]
Hi - > On Jan 24, 2025, at 12:05 PM, ardovm (via GitHub) wrote: > > > ardovm commented on PR #256: > URL: https://github.com/apache/openoffice/pull/256#issuecomment-2613292891 > >> Wiki is often outdated. > > ...but I liked it that way... ;-) > > In fact, I thought that that wiki page was written _after_ many files were > already formatted with tabs. > > It may be worth a short discussion on dev@. I’m reading this on dev. I’d like to know what currently busy developers like DamJan think. > >> Would that correspond to: >> >> `/* vim: set noet sw=4 ts=4: */` > > This should represent the current state of many files, i.e. tabs, to be > displayed as 4 spaces. > > I was suggesting we rather set `et` instead of `noet`, using no tabs for > indentation, but rather 4 spaces. If developer makes a mistake will this precommit hook fix our mistakes? Best, Dave > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Add basic EditorConfig file [openoffice]
ardovm commented on PR #256: URL: https://github.com/apache/openoffice/pull/256#issuecomment-2613292891 > Wiki is often outdated. ...but I liked it that way... ;-) In fact, I thought that that wiki page was written _after_ many files were already formatted with tabs. It may be worth a short discussion on dev@. > Would that correspond to: > > `/* vim: set noet sw=4 ts=4: */` This should represent the current state of many files, i.e. tabs, to be displayed as 4 spaces. I was suggesting we rather set `et` instead of `noet`, using no tabs for indentation, but rather 4 spaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Address bug 127942 [openoffice]
Pilot-Pirx commented on PR #251: URL: https://github.com/apache/openoffice/pull/251#issuecomment-2613358341 Windows build went fine. But after clearing the recent file list the URL history is still populated... After closing and reopening the URL history is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix spelling [openoffice]
Pilot-Pirx merged PR #254: URL: https://github.com/apache/openoffice/pull/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Add basic EditorConfig file [openoffice]
Pilot-Pirx commented on PR #256: URL: https://github.com/apache/openoffice/pull/256#issuecomment-2613117081 Wiki is often outdated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Add basic EditorConfig file [openoffice]
ardovm commented on PR #256: URL: https://github.com/apache/openoffice/pull/256#issuecomment-2613107969 I suggest we add: `tab_width = 4` to the `[*]` section because many files are formatted this way. [A page on our wiki](https://wiki.openoffice.org/wiki/Cpp_Coding_Standards/FORMAT) suggests to use 4 spaces for indentation, so we could also add: ``` indent_style = space indent_size = 4 ``` to the same section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Add basic EditorConfig file [openoffice]
ardovm commented on PR #256: URL: https://github.com/apache/openoffice/pull/256#issuecomment-2613319002 > Wiki is often outdated. > > Would that correspond to: > > /* vim: set noet sw=4 ts=4: */ I looked further and now I agree that this is our current standard. Yes, the wiki is outdated. So this PR shall only add: ``` tab_width = 4 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix end of hxx files remove unneeded blank lines [openoffice]
jbampton commented on PR #242: URL: https://github.com/apache/openoffice/pull/242#issuecomment-2612818155 This was an auto fix using pre-commit but I just submitted the line ending changes previously. From the official pre-commit hooks there is the `end-of-file-fixer` which was used: https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#end-of-file-fixer I can see the diff is too large / too many files etc for proper review. We could start with a subset of files ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Add basic EditorConfig file [openoffice]
jbampton commented on PR #256: URL: https://github.com/apache/openoffice/pull/256#issuecomment-2612922913 There is a good list of projects using EditorConfig: https://github.com/editorconfig/editorconfig/wiki/Projects-Using-EditorConfig -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Add 4 more official pre-commit hooks [openoffice]
Pilot-Pirx commented on PR #255: URL: https://github.com/apache/openoffice/pull/255#issuecomment-2612841963 I would also be interested in: https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#mixed-line-ending I already found and fixed some files with mixed line endings, but I could imagine that there are more of them... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix end of hxx files remove unneeded blank lines [openoffice]
Pilot-Pirx commented on PR #242: URL: https://github.com/apache/openoffice/pull/242#issuecomment-2612928821 It was the massive amount of files why I didn't merge it. But in the end, we can always revert the commit... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix spelling [openoffice]
jbampton opened a new pull request, #254: URL: https://github.com/apache/openoffice/pull/254 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Win64 port making progress
Hi Damjan, Now it *almost* succeeds. :-D Since my configure wants to build the NSIS/MSI installer it fails in the final module "instsetoo_native". Adding "epm" to configure didn't help. BTW, I never needed epm for the Windows 32-bit build, maybe the cause is here: https://github.com/apache/openoffice/blob/trunk/main/instsetoo_native/util/makefile.mk#L117 --- C:/cygwin64/bin/perl.exe -wC:/Source/openoffice/main/solenv/bin/packager.pl Using pack list /cygdrive/c/Source/Pack-small-64.lst Packager: dmake openoffice_de ... checking environment variables ... make_installer.pl, version 1.0 Product list file: ../util/openoffice.lst Taking setup script from solver Unpackpath:C:/Source/openoffice/main/instsetoo_native/wntmscx12.pro Compiler: wntmscx12 Product: Apache_OpenOffice BuildID: 9900 Build: AOO450 No minor set Product version Using default installpath Package format: msi msi templatepath:C:/Source/openoffice/main/instsetoo_native/wntmscx12.pro/misc/openoffice/msi_templates msi template path will be ignored for non Windows builds! msi languagepath:C:/Source/openoffice/main/instsetoo_native/wntmscx12.pro/misc/win_ulffiles msi language path will be ignored for non Windows builds! Calling epm Stripping files Unzip ARCHIVE files Languages: de ... checking required files ... .. searching zip.exe ... Found:C:/cygwin64/bin/zip.exe ... analyzing ../util/openoffice.lst ... ... reading include paths ... ... analyzing script:C:/Source/openoffice/main/solver/450/wntmscx12.pro/bin/setup_osl.inf ... ... analyzing script:C:/Source/openoffice/main/solver/450/wntmscx12.pro/bin/setup_osl.inf ... WARNING: mis-named or un-known %-variable in setup script at line 124637: Subkey = "Software\OpenOffice\OpenOffice\4.5.0\%PRODUCTCODE"; WARNING: mis-named or un-known %-variable in setup script at line 124646: Subkey = "Software\OpenOffice\OpenOffice\4.5.0\%PRODUCTCODE"; WARNING: mis-named or un-known %-variable in setup script at line 124655: Subkey = "Software\OpenOffice\OpenOffice\4.5.0\%PRODUCTCODE"; WARNING: mis-named or un-known %-variable in setup script at line 124664: Subkey = "Software\OpenOffice\OpenOffice\4.5.0\%UPGRADECODE"; WARNING: mis-named or un-known %-variable in setup script at line 124673: Subkey = "Software\OpenOffice\OpenOffice\4.5.0\%UPGRADECODE"; WARNING: mis-named or un-known %-variable in setup script at line 124682: Subkey = "Software\OpenOffice\OpenOffice\4.5.0\%UPGRADECODE"; ... analyzing directories ... ... analyzing files ... ... analyzing scpactions ... ... analyzing shortcuts ... ... analyzing unix links ... ... analyzing profile ... ... analyzing profileitems ... ... analyzing modules ... ... languages de ... ... analyzing files ... preparing 6 extension blobs for language de: dict-de_de.oxt dict-de_at.oxt dict-de_ch.oxt dict-en.oxt dict-fr.oxt dict-it.oxt preparing 0 bundled extensions for language de: ... analyzing files with flag ARCHIVE ... ... analyzing files with flag SUBST_FILENAME ... ... analyzing files with flag SCPZIP_REPLACE ... ... analyzing files with flag PATCH_SO_NAME ... ... analyzing files with flag HIDDEN ... ... analyzing all directories for this product ... ... analyzing links ... ... analyzing unix links ... ... creating profiles ... ... analyzing modules ... ... analyzing package list ... ... creating installation set inC:/Source/openoffice/main/instsetoo_native/wntmscx12.pro/Apache_OpenOffice/msi/install/de ... ... removing old installation directories ... ** ERROR: ERROR: Could not find program epm! in function: find_epm_on_system ** ... cleaning the output tree ... ... removing directory /tmp/ooopackaging/i_69851737693007 ... ... removing directoryC:/Source/openoffice/main/instsetoo_native/wntmscx12.pro/Apache_OpenOffice/msi/stripped/de ... Error: ERROR: Could not find program epm! in function: find_epm_on_systemstopping log at Fri Jan 24 05:31:19 2025 dmake: Error code 255, while making 'openoffice_de.msi' Packager finished: dmake openoffice_de ERROR: Packager dmake openoffice_de *** ERROR: Packing not successful : dmake openoffice_de in function: execute_system_calls *** dmake: Error code 255, while making 'updatepack' Am 23.01.25 um 21:57 schrieb Matthias Seidel: Hi Damjan, Am 23.01.25 um 20:57 schrieb Damjan Jovanovic: Hi Matthias For some reason, your build is trying to link with x86 ATL libraries, causing that error. Note that my ./configure switches for ATL and MFC specified the amd64 subdirectory at the end: --with-atl-lib-dir=/cygdrive/c/WINDDK/7600.16385.1/lib/ATL/amd64 --with-mfc-lib-dir=/cy
Re: [PR] Add 4 more official pre-commit hooks [openoffice]
jbampton commented on PR #255: URL: https://github.com/apache/openoffice/pull/255#issuecomment-2612958634 I pushed a second commit that fixed the line mixed line ending in `main` for just `cxx` and `hxx` files. Was a large amount just for this batch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Address bug 127942 [openoffice]
ardovm commented on PR #251: URL: https://github.com/apache/openoffice/pull/251#issuecomment-2613583413 There are other problems, unfortunately. When the history is cleared, it does not get populated again (visited documents are not saved) until the program is restarted. This cannot be merged as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix more spelling [openoffice]
jbampton opened a new pull request, #252: URL: https://github.com/apache/openoffice/pull/252 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix more spelling [openoffice]
jbampton commented on PR #252: URL: https://github.com/apache/openoffice/pull/252#issuecomment-2612195526 So there are a whole bunch of pre-commit hooks that can be added in future if needed. The official hooks are seen here: https://github.com/pre-commit/pre-commit-hooks And on the website there is a larger list of hooks: https://pre-commit.com/hooks.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] feat(actions): add `pre-commit` framework with `codespell` [openoffice]
jbampton merged PR #191: URL: https://github.com/apache/openoffice/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Standardize the pre-commit config [openoffice]
jbampton opened a new pull request, #253: URL: https://github.com/apache/openoffice/pull/253 https://github.com/codespell-project/codespell?tab=readme-ov-file#pre-commit-hook -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Add 4 more official pre-commit hooks [openoffice]
jbampton opened a new pull request, #255: URL: https://github.com/apache/openoffice/pull/255 https://github.com/pre-commit/pre-commit-hooks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Add basic EditorConfig file [openoffice]
On Fri, Jan 24, 2025 at 8:10 PM Dave Fisher wrote: > Hi - > > > On Jan 24, 2025, at 12:05 PM, ardovm (via GitHub) > wrote: > > > > > > ardovm commented on PR #256: > > URL: > https://github.com/apache/openoffice/pull/256#issuecomment-2613292891 > > > >> Wiki is often outdated. > > > > ...but I liked it that way... ;-) > > > > In fact, I thought that that wiki page was written _after_ many files > were already formatted with tabs. > > > > It may be worth a short discussion on dev@. > > I’m reading this on dev. I’d like to know what currently busy developers > like DamJan think. > > I always had to use a tab size of 4. As for spaces vs tabs, I usually try to preserve whatever the file originally used, which is usually tabs for C++ and makefiles, and spaces for Java. > > > >> Would that correspond to: > >> > >> `/* vim: set noet sw=4 ts=4: */` > > > > This should represent the current state of many files, i.e. tabs, to > be displayed as 4 spaces. > > > > I was suggesting we rather set `et` instead of `noet`, using no tabs > for indentation, but rather 4 spaces. > > If developer makes a mistake will this precommit hook fix our mistakes? > How can GitHub fix mistakes when we commit to gitbox.apache.org? > > Best, > Dave > > Damjan
