Re: building with gcc 10 and external (system) boost
On 20.06.21 07:40, Yury Tarasievich wrote: Hello Peter, Which leads to your (2), but thing is, modern boost sort of requires C++11. Might be other external modules do, too. Might that switch to C++11 be overdue? I would like to switch. I am a big fan of C++11, but I am worried on the impact. Without testing the switch on Mac and Windows I hesitate. That's is all. From our dependency point of view, yes we need to make the switch soon. But imho it has time after release 4.2. -- This is the Way! http://www.apache.org/theapacheway/index.html - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: building with gcc 10 and external (system) boost
On 20.06.21 08:57, Don Lewis wrote: On 20 Jun, Yury Tarasievich wrote: Hello Peter, You are right on both issues, of course. To be fair, on your (1), I didn't touch that variable check, I just brute-forced the C++11 mode of compilation. Which leads to your (2), but thing is, modern boost sort of requires C++11. Might be other external modules do, too. Might that switch to C++11 be overdue? What I consider the nicest result (beyond the 'fact of the pudding') is seeing that the C++11 build is achievable with very minimal changes to the source, which wouldn't (shouldn't?) reflect on builds with older versions of GCC. I think that we still need to do release builds of 4.1.x on CentOS 5. Is it's version of gcc new enough? Redhat 5 uses GCC 3.4 according to [1] CentOS 7 uses gcc 4.4.7 If I check with [2] it is to old. [1] https://access.redhat.com/solutions/19458 [2] https://en.cppreference.com/w/cpp/compiler_support -- This is the Way! http://www.apache.org/theapacheway/index.html - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] leginee commented on pull request #133: graphite: remove the -Werror option from debug builds
leginee commented on pull request #133: URL: https://github.com/apache/openoffice/pull/133#issuecomment-864513194 Then we have 2 choices. Fix the Issues or prepare the switch to a replacement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: building with gcc 10 and external (system) boost
Right, understandable. Only I believe there's need to consider also that the newer GCC (10.3.0 in my case) can't (won't?) compile even the headers-only part of older boost (1.55, the internal one). Maybe there're issues with other libraries frozen at their older versions, too. -Yury - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] ardovm commented on pull request #133: graphite: remove the -Werror option from debug builds
ardovm commented on pull request #133: URL: https://github.com/apache/openoffice/pull/133#issuecomment-864605285 The first two warnings are IMHO bugs. The first one is a function parameter type `bool` instead of `bool&` and the second is a mixup of return values in a `switch` statement. Others are linked to assertions not being compiled (although we are requesting a debug build). Some others are unused variables that are explicitly marked `TODO` in the code. I stopped after checking the first four warnings. I suggest we allow this PR through so that at least the source becomes compilable again. Then we could have a longer term plan for the replacement of the graphite with... whatever is better today. For what it's worth, both the [SourceForge project page](http://silgraphite.sourceforge.net) and [www.sil.org](https://software.sil.org/products/#supported) refer to http://graphite.sil.org that does not seem to exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] ardovm edited a comment on pull request #133: graphite: remove the -Werror option from debug builds
ardovm edited a comment on pull request #133: URL: https://github.com/apache/openoffice/pull/133#issuecomment-864605285 The first two warnings are IMHO bugs. The first one is a function parameter type `bool` instead of `bool&` and the second is a mixup of return values in a `switch` statement. Others are linked to assertions not being compiled (although we are requesting a debug build). Some others are unused variables that are explicitly marked `TODO` in the code. I stopped after checking the first four warnings. I suggest we allow this PR through so that at least the source becomes compilable again. Then we could have a longer term plan for the replacement of the graphite module with... whatever is better today. For what it's worth, both the [SourceForge project page](http://silgraphite.sourceforge.net) and [www.sil.org](https://software.sil.org/products/#supported) refer to http://graphite.sil.org that does not seem to exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [GitHub] [openoffice] ardovm edited a comment on pull request #133: graphite: remove the -Werror option from debug builds
Hi Arrigo, all Development seems to be quite live at https://github.com/silnrsi/graphite Regards, Pedro > On 06/20/2021 9:08 PM GitBox wrote: > > > ardovm edited a comment on pull request #133: > URL: https://github.com/apache/openoffice/pull/133#issuecomment-864605285 > > >The first two warnings are IMHO bugs. The first one is a function > parameter type `bool` instead of `bool&` and the second is a mixup of return > values in a `switch` statement. > >Others are linked to assertions not being compiled (although we are > requesting a debug build). Some others are unused variables that are > explicitly marked `TODO` in the code. > >I stopped after checking the first four warnings. > >I suggest we allow this PR through so that at least the source becomes > compilable again. Then we could have a longer term plan for the replacement > of the graphite module with... whatever is better today. > >For what it's worth, both the [SourceForge project > page](http://silgraphite.sourceforge.net) and > [www.sil.org](https://software.sil.org/products/#supported) refer to > http://graphite.sil.org that does not seem to exist. > > > -- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [GitHub] [openoffice] ardovm edited a comment on pull request #133: graphite: remove the -Werror option from debug builds
On 20 Jun, Pedro Lino wrote: > Hi Arrigo, all > > Development seems to be quite live at > https://github.com/silnrsi/graphite We are using SIL Graphite, http://silgraphite.sourceforge.net/ Looking at the Graphite technical overview page mentioned here: https://github.com/silnrsi/graphite/blob/master/README.md (https://scripts.sil.org/cms/scripts/page.php?site_id=projects&item_id=graphite_techAbout) under "Graphite engine implementations": There are two existing implementations of the Graphite engine. The original engine is packaged under the name "SilGraphite"; the initial implementation was done in 2000. The Graphite2 engine implementation began in 2010. The SilGraphite engine is currently used by OpenOffice, XeTeX, FieldWorks, and WorldPad. It includes some features not included in Graphite2, but is considerably slower. Graphite2 represents a significant (10x) optimization in terms of speed and greatly improved robustness, but does not include a few features such a ligature component handling and cross-line-boundary contextualization. Graphite2 is used by LibreOffice and Firefox. The two engines support different APIs. The Graphite2 API was specifically developed to be more compatible with the approach to text layout used by most commercial software. See the application development page for API documentation. Graphite2 would be better, is currently supported, and Libreoffice switched to it quite a while ago, but it is not a drop-in replacement. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
