4.2.0 unable open .docx (Was Re: Latest test builds)
On Mon, 21 Jan 2019 08:39:23 +0100 Peter Kovacs wrote: > Hi Rory, > > do we have a Bug for this? > > > All the Best > > Peter I have not yet raised this as a bug - will do later today when a current serious crisis (don't ask!) is dealt with. This has independently been brought to the en-Forum relative to 4.1.6 in this thread https://forum.openoffice.org/en/forum/viewtopic.php?f=7&t=96672 Rory > > On 20.01.19 17:45, Rory O'Farrell wrote: > > On Sun, 20 Jan 2019 10:28:53 -0500 > > Jim Jagielski wrote: > > > >> I've uploaded the latest test builds for macOS and Linux 64. > >> These are based on ~r1851640 and include 2 main updates from > >> the earlier one: > >> > >> o beanshell now included > >> o macOS path bug should now be squashed > >> (https://bz.apache.org/ooo/show_bug.cgi?id=127965) > >> > >> Let me know if anyone wants me to kick off a Linux 32bit > >> build. > >> > >> Find them here: > >> > >> http://home.apache.org/~jim/AOO-builds/4.2.0-dev-r1851640/ > >> > >> Cheers! > >> > > I have seen a report that 4.1.6 is failing to open .docx files. 4.2.0 > > (r1851640) and Jim's earlier version are also failing with .docx files. > > The latest 4.2.0 will crash with a small .docx (~20KB) and offer to recover > > it; it will then display it. With a larger .docx (365 KB) it will crash, > > and be unable to recover or display that file. It also does not identify > > the file with which it has crashed or is trying to recover. I have not > > checked these behaviours against 4.1.6 > > > > This does not present any immediate problem for me, as I work only in .odt > > format, but after repairing a corrupt .docx file on forum for a user, I was > > unable to open it for testing, although the repaired document.xml passed a > > "Well-formed XML" check. > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > > -- Rory O'Farrell - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Latest test builds
On Mon, 21 Jan 2019 08:39:23 +0100 Peter Kovacs wrote: > Hi Rory, > > do we have a Bug for this? > > > All the Best > > Peter Seems to be bug 115156 I have added my earlier information to that bug. Rory > > On 20.01.19 17:45, Rory O'Farrell wrote: > > On Sun, 20 Jan 2019 10:28:53 -0500 > > Jim Jagielski wrote: > > > >> I've uploaded the latest test builds for macOS and Linux 64. > >> These are based on ~r1851640 and include 2 main updates from > >> the earlier one: > >> > >> o beanshell now included > >> o macOS path bug should now be squashed > >> (https://bz.apache.org/ooo/show_bug.cgi?id=127965) > >> > >> Let me know if anyone wants me to kick off a Linux 32bit > >> build. > >> > >> Find them here: > >> > >> http://home.apache.org/~jim/AOO-builds/4.2.0-dev-r1851640/ > >> > >> Cheers! > >> > > I have seen a report that 4.1.6 is failing to open .docx files. 4.2.0 > > (r1851640) and Jim's earlier version are also failing with .docx files. > > The latest 4.2.0 will crash with a small .docx (~20KB) and offer to recover > > it; it will then display it. With a larger .docx (365 KB) it will crash, > > and be unable to recover or display that file. It also does not identify > > the file with which it has crashed or is trying to recover. I have not > > checked these behaviours against 4.1.6 > > > > This does not present any immediate problem for me, as I work only in .odt > > format, but after repairing a corrupt .docx file on forum for a user, I was > > unable to open it for testing, although the repaired document.xml passed a > > "Well-formed XML" check. > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > > -- Rory O'Farrell - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Latest test builds
Hi Rory, Am 21.01.19 um 15:29 schrieb Rory O'Farrell: > On Mon, 21 Jan 2019 08:39:23 +0100 > Peter Kovacs wrote: > >> Hi Rory, >> >> do we have a Bug for this? >> >> >> All the Best >> >> Peter > > Seems to be bug 115156 > I have added my earlier information to that bug. Can you please attach a file that crashes? I can not reproduce this behavior with any docx I have available. Regards, Matthias > > Rory >> On 20.01.19 17:45, Rory O'Farrell wrote: >>> On Sun, 20 Jan 2019 10:28:53 -0500 >>> Jim Jagielski wrote: >>> I've uploaded the latest test builds for macOS and Linux 64. These are based on ~r1851640 and include 2 main updates from the earlier one: o beanshell now included o macOS path bug should now be squashed (https://bz.apache.org/ooo/show_bug.cgi?id=127965) Let me know if anyone wants me to kick off a Linux 32bit build. Find them here: http://home.apache.org/~jim/AOO-builds/4.2.0-dev-r1851640/ Cheers! >>> I have seen a report that 4.1.6 is failing to open .docx files. 4.2.0 >>> (r1851640) and Jim's earlier version are also failing with .docx files. >>> The latest 4.2.0 will crash with a small .docx (~20KB) and offer to recover >>> it; it will then display it. With a larger .docx (365 KB) it will crash, >>> and be unable to recover or display that file. It also does not identify >>> the file with which it has crashed or is trying to recover. I have not >>> checked these behaviours against 4.1.6 >>> >>> This does not present any immediate problem for me, as I work only in .odt >>> format, but after repairing a corrupt .docx file on forum for a user, I was >>> unable to open it for testing, although the repaired document.xml passed a >>> "Well-formed XML" check. >>> >>> >> - >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org >> >> > smime.p7s Description: S/MIME Cryptographic Signature
Re: Latest test builds
On Mon, 21 Jan 2019 16:09:33 +0100 Matthias Seidel wrote: > Hi Rory, > > Am 21.01.19 um 15:29 schrieb Rory O'Farrell: > > On Mon, 21 Jan 2019 08:39:23 +0100 > > Peter Kovacs wrote: > > > >> Hi Rory, > >> > >> do we have a Bug for this? > >> > >> > >> All the Best > >> > >> Peter > > > > Seems to be bug 115156 > > I have added my earlier information to that bug. > > Can you please attach a file that crashes? > > I can not reproduce this behavior with any docx I have available. > > Regards, > > Matthias Sample file attached to bug report 115156 Rory > > > > Rory > >> On 20.01.19 17:45, Rory O'Farrell wrote: > >>> On Sun, 20 Jan 2019 10:28:53 -0500 > >>> Jim Jagielski wrote: > >>> > I've uploaded the latest test builds for macOS and Linux 64. > These are based on ~r1851640 and include 2 main updates from > the earlier one: > > o beanshell now included > o macOS path bug should now be squashed > (https://bz.apache.org/ooo/show_bug.cgi?id=127965) > > Let me know if anyone wants me to kick off a Linux 32bit > build. > > Find them here: > > http://home.apache.org/~jim/AOO-builds/4.2.0-dev-r1851640/ > > Cheers! > > >>> I have seen a report that 4.1.6 is failing to open .docx files. 4.2.0 > >>> (r1851640) and Jim's earlier version are also failing with .docx files. > >>> The latest 4.2.0 will crash with a small .docx (~20KB) and offer to > >>> recover it; it will then display it. With a larger .docx (365 KB) it > >>> will crash, and be unable to recover or display that file. It also does > >>> not identify the file with which it has crashed or is trying to recover. > >>> I have not checked these behaviours against 4.1.6 > >>> > >>> This does not present any immediate problem for me, as I work only in > >>> .odt format, but after repairing a corrupt .docx file on forum for a > >>> user, I was unable to open it for testing, although the repaired > >>> document.xml passed a "Well-formed XML" check. > >>> > >>> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > >> For additional commands, e-mail: dev-h...@openoffice.apache.org > >> > >> > > > -- Rory O'Farrell - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Latest test builds
Am 21.01.19 um 16:18 schrieb Rory O'Farrell: > On Mon, 21 Jan 2019 16:09:33 +0100 > Matthias Seidel wrote: > >> Hi Rory, >> >> Am 21.01.19 um 15:29 schrieb Rory O'Farrell: >>> On Mon, 21 Jan 2019 08:39:23 +0100 >>> Peter Kovacs wrote: >>> Hi Rory, do we have a Bug for this? All the Best Peter >>> Seems to be bug 115156 >>> I have added my earlier information to that bug. >> Can you please attach a file that crashes? >> >> I can not reproduce this behavior with any docx I have available. >> >> Regards, >> >> Matthias > Sample file attached to bug report 115156 Opened fine with AOO420m1(Build:9800) - Rev. 1851640 (Jim's build) on Xubuntu 18.04.1 (64-bit) When exactly should the crash occur? Matthias > > Rory > >>> Rory On 20.01.19 17:45, Rory O'Farrell wrote: > On Sun, 20 Jan 2019 10:28:53 -0500 > Jim Jagielski wrote: > >> I've uploaded the latest test builds for macOS and Linux 64. >> These are based on ~r1851640 and include 2 main updates from >> the earlier one: >> >> o beanshell now included >> o macOS path bug should now be squashed >> (https://bz.apache.org/ooo/show_bug.cgi?id=127965) >> >> Let me know if anyone wants me to kick off a Linux 32bit >> build. >> >> Find them here: >> >> http://home.apache.org/~jim/AOO-builds/4.2.0-dev-r1851640/ >> >> Cheers! >> > I have seen a report that 4.1.6 is failing to open .docx files. 4.2.0 > (r1851640) and Jim's earlier version are also failing with .docx files. > The latest 4.2.0 will crash with a small .docx (~20KB) and offer to > recover it; it will then display it. With a larger .docx (365 KB) it > will crash, and be unable to recover or display that file. It also does > not identify the file with which it has crashed or is trying to recover. > I have not checked these behaviours against 4.1.6 > > This does not present any immediate problem for me, as I work only in > .odt format, but after repairing a corrupt .docx file on forum for a > user, I was unable to open it for testing, although the repaired > document.xml passed a "Well-formed XML" check. > > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org > smime.p7s Description: S/MIME Cryptographic Signature
Re: Latest test builds
On 1/21/2019 7:37 AM, Matthias Seidel wrote: Am 21.01.19 um 16:18 schrieb Rory O'Farrell: On Mon, 21 Jan 2019 16:09:33 +0100 Matthias Seidel wrote: Hi Rory, Am 21.01.19 um 15:29 schrieb Rory O'Farrell: On Mon, 21 Jan 2019 08:39:23 +0100 Peter Kovacs wrote: Hi Rory, do we have a Bug for this? All the Best Peter Seems to be bug 115156 I have added my earlier information to that bug. Can you please attach a file that crashes? I can not reproduce this behavior with any docx I have available. Regards, Matthias Sample file attached to bug report 115156 Opened fine with AOO420m1(Build:9800) - Rev. 1851640 (Jim's build) on Xubuntu 18.04.1 (64-bit) When exactly should the crash occur? Matthias I opened it on MS Windows 10, using the 4.1.6 download from Sourceforge. No problems. This is significant because one of the changes in 4.1.6 involves expanding line separators from one character to two, which only happens when opening a file on an MS Windows system. I think we need more information on where this is happening. Also, I wonder whether profile deletion affects it. Rory Rory On 20.01.19 17:45, Rory O'Farrell wrote: On Sun, 20 Jan 2019 10:28:53 -0500 Jim Jagielski wrote: I've uploaded the latest test builds for macOS and Linux 64. These are based on ~r1851640 and include 2 main updates from the earlier one: o beanshell now included o macOS path bug should now be squashed (https://bz.apache.org/ooo/show_bug.cgi?id=127965) Let me know if anyone wants me to kick off a Linux 32bit build. Find them here: http://home.apache.org/~jim/AOO-builds/4.2.0-dev-r1851640/ Cheers! I have seen a report that 4.1.6 is failing to open .docx files. 4.2.0 (r1851640) and Jim's earlier version are also failing with .docx files. The latest 4.2.0 will crash with a small .docx (~20KB) and offer to recover it; it will then display it. With a larger .docx (365 KB) it will crash, and be unable to recover or display that file. It also does not identify the file with which it has crashed or is trying to recover. I have not checked these behaviours against 4.1.6 This does not present any immediate problem for me, as I work only in .odt format, but after repairing a corrupt .docx file on forum for a user, I was unable to open it for testing, although the repaired document.xml passed a "Well-formed XML" check. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org --- This email has been checked for viruses by AVG. https://www.avg.com - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Latest test builds
I'm in the process of uploading Linux 32bit builds > On Jan 20, 2019, at 10:28 AM, Jim Jagielski wrote: > > I've uploaded the latest test builds for macOS and Linux 64. > These are based on ~r1851640 and include 2 main updates from > the earlier one: > > o beanshell now included > o macOS path bug should now be squashed > (https://bz.apache.org/ooo/show_bug.cgi?id=127965) > > Let me know if anyone wants me to kick off a Linux 32bit > build. > > Find them here: > > http://home.apache.org/~jim/AOO-builds/4.2.0-dev-r1851640/ > > Cheers! > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: Latest test builds
On Mon, 21 Jan 2019 16:37:17 +0100 Matthias Seidel wrote: > Am 21.01.19 um 16:18 schrieb Rory O'Farrell: > > On Mon, 21 Jan 2019 16:09:33 +0100 > > Matthias Seidel wrote: > > > >> Hi Rory, > >> > >> Am 21.01.19 um 15:29 schrieb Rory O'Farrell: > >>> On Mon, 21 Jan 2019 08:39:23 +0100 > >>> Peter Kovacs wrote: > >>> > Hi Rory, > > do we have a Bug for this? > > > All the Best > > Peter > >>> Seems to be bug 115156 > >>> I have added my earlier information to that bug. > >> Can you please attach a file that crashes? > >> > >> I can not reproduce this behavior with any docx I have available. > >> > >> Regards, > >> > >> Matthias > > Sample file attached to bug report 115156 > I double click it, using AOO420m1(Build:9800) - Rev. 1851640 2019-01-19 15:48:21 (Sat, 19 Jan 2019) - Linux x86_64 [Apache OpenOffice Test Development Build] It starts to open, crashes, immediately recovers and then edits OK. I am running Xubuntu 64 18.04.1 on a well specified computer; I'll try a fresh User profile. OK, fresh profile worked OK with that file. I also have a 380KB .docx that crashes with the fresh profile. I can send that privately if you wish as it is a Forum user's file I was asked to rescue and should not be posted publicly. Rory > Opened fine with AOO420m1(Build:9800) - Rev. 1851640 (Jim's build) on > Xubuntu 18.04.1 (64-bit) > > When exactly should the crash occur? > > Matthias > > > > > Rory > > > >>> Rory > On 20.01.19 17:45, Rory O'Farrell wrote: > > On Sun, 20 Jan 2019 10:28:53 -0500 > > Jim Jagielski wrote: > > > >> I've uploaded the latest test builds for macOS and Linux 64. > >> These are based on ~r1851640 and include 2 main updates from > >> the earlier one: > >> > >> o beanshell now included > >> o macOS path bug should now be squashed > >> (https://bz.apache.org/ooo/show_bug.cgi?id=127965) > >> > >> Let me know if anyone wants me to kick off a Linux 32bit > >> build. > >> > >> Find them here: > >> > >> http://home.apache.org/~jim/AOO-builds/4.2.0-dev-r1851640/ > >> > >> Cheers! > >> > > I have seen a report that 4.1.6 is failing to open .docx files. 4.2.0 > > (r1851640) and Jim's earlier version are also failing with .docx files. > > The latest 4.2.0 will crash with a small .docx (~20KB) and offer to > > recover it; it will then display it. With a larger .docx (365 KB) it > > will crash, and be unable to recover or display that file. It also does > > not identify the file with which it has crashed or is trying to > > recover. I have not checked these behaviours against 4.1.6 > > > > This does not present any immediate problem for me, as I work only in > > .odt format, but after repairing a corrupt .docx file on forum for a > > user, I was unable to open it for testing, although the repaired > > document.xml passed a "Well-formed XML" check. > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > > > > > -- Rory O'Farrell - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
branch 4.1.7?
Does it make sense to create a branch of 4.1.7 from 4.1.6...? - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: branch 4.1.7?
On Mon, 21 Jan 2019 11:12:12 -0500 Jim Jagielski wrote: > Does it make sense to create a branch of 4.1.7 from 4.1.6...? No, unless for some urgent fix. I think better to continue with 4.2.0, then on to 5.0 4.2.0 editing OK in Writer (60k word file, book format, no illustrations/tables). A simple spreadsheet working OK; existing Impress presentations displaying, apart from two where slide backgrounds cause crash. Multimedia in new presentations not yet checked. -- Rory O'Farrell - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: branch 4.1.7?
Gotcha. I was just thinking that if we had a 4.1.7 branch in a ready-to-go stage, if we needed to do another 4.1.x release it would be already there. But agree that the focus should be on 4.2.0 > On Jan 21, 2019, at 11:25 AM, Rory O'Farrell wrote: > > On Mon, 21 Jan 2019 11:12:12 -0500 > Jim Jagielski wrote: > >> Does it make sense to create a branch of 4.1.7 from 4.1.6...? > > No, unless for some urgent fix. I think better to continue with 4.2.0, then > on to 5.0 > > 4.2.0 editing OK in Writer (60k word file, book format, no > illustrations/tables). A simple spreadsheet working OK; existing Impress > presentations displaying, apart from two where slide backgrounds cause crash. > Multimedia in new presentations not yet checked. > > -- > Rory O'Farrell > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: branch 4.1.7?
I agree that the focus should be on 4.2.0. However, I strongly favor having a ready-to-go 4.1.7. Any day, we could encounter a really serious, must-fix-immediately, security bug. Having as much as possible done ahead of time will reduce the delay from knowing the fix to end users having the fix. On 1/21/2019 8:36 AM, Jim Jagielski wrote: Gotcha. I was just thinking that if we had a 4.1.7 branch in a ready-to-go stage, if we needed to do another 4.1.x release it would be already there. But agree that the focus should be on 4.2.0 On Jan 21, 2019, at 11:25 AM, Rory O'Farrell wrote: On Mon, 21 Jan 2019 11:12:12 -0500 Jim Jagielski wrote: Does it make sense to create a branch of 4.1.7 from 4.1.6...? No, unless for some urgent fix. I think better to continue with 4.2.0, then on to 5.0 4.2.0 editing OK in Writer (60k word file, book format, no illustrations/tables). A simple spreadsheet working OK; existing Impress presentations displaying, apart from two where slide backgrounds cause crash. Multimedia in new presentations not yet checked. -- Rory O'Farrell - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org --- This email has been checked for viruses by AVG. https://www.avg.com - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Navigator query
Can anyone tell me if, in the AOO code, there is a module for Navigator? If so, which module is it? My thinking is that Navigator could do with some additions, such as ability to display the word count for Chapters (helpful for an author to tweak his chapter lengths to be roughly the same), and the ability to display only comments from one author - so that, for example, a student might see only his tutor's comments as he incorporated their advice into his text. If there is a Navigator module, I would look at the source code to try to implement the above, otherwise I'm thinking of an extension to show this information, whether integrated into Navigator or in a stand-alone panel. -- Rory O'Farrell - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: branch 4.1.7?
One "regression" that merits immediate attention is crashing on Windows when trying to edit a macro embedded in a Writer or Calc document ( I haven't checked Impress or Base yet). If I open a new document and try to make an embedded macro (menus Tools -> Macros -> Organize Macros -> OpenOffice Basic) OpenOffice crashes immediately after I accept the default module name of Module1. Going through the recovery process, I am asked to Enable or Disable macros, so the module is created but I cannot get at it. I can edit the Standard library in My Macros but it is unstable. For example, if I select two lines of code and press backspace, the program crashes. This problem started after a Windows update last summer. I thought a subsequent update fixed it, but I was wrong. I have checked 4.1.5, 4.1.6 and 4.2.0 and it affects all of them. It is not really a regression, since 4.1.5 worked fine until the Windows update, but Windows users cannot use macros. I looked for a bug report and did not find one but my Bugzilla skills are poor. Are the devs aware of this problem? best regards, Francis On Mon, Jan 21, 2019 at 9:38 AM Patricia Shanahan wrote: > I agree that the focus should be on 4.2.0. However, I strongly favor > having a ready-to-go 4.1.7. Any day, we could encounter a really > serious, must-fix-immediately, security bug. Having as much as possible > done ahead of time will reduce the delay from knowing the fix to end > users having the fix. > > On 1/21/2019 8:36 AM, Jim Jagielski wrote: > > Gotcha. I was just thinking that if we had a 4.1.7 branch in a > ready-to-go stage, if we needed to do another 4.1.x release it would be > already there. > > > > But agree that the focus should be on 4.2.0 > > > >> On Jan 21, 2019, at 11:25 AM, Rory O'Farrell wrote: > >> > >> On Mon, 21 Jan 2019 11:12:12 -0500 > >> Jim Jagielski wrote: > >> > >>> Does it make sense to create a branch of 4.1.7 from 4.1.6...? > >> > >> No, unless for some urgent fix. I think better to continue with 4.2.0, > then on to 5.0 > >> > >> 4.2.0 editing OK in Writer (60k word file, book format, no > illustrations/tables). A simple spreadsheet working OK; existing Impress > presentations displaying, apart from two where slide backgrounds cause > crash. Multimedia in new presentations not yet checked. > >> > >> -- > >> Rory O'Farrell > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > >> For additional commands, e-mail: dev-h...@openoffice.apache.org > >> > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > > For additional commands, e-mail: dev-h...@openoffice.apache.org > > > > --- > This email has been checked for viruses by AVG. > https://www.avg.com > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
Re: Navigator query
Hi
Here's how I found it:
View -> Navigator to open the window.
Look for the most complex unique text there, eg. "Heading Levels Shown" in
a tooltip.
Go to https://opengrok.libreoffice.org and search for "Heading Levels
Shown" under full-text search.
It finds 2 matches:
core/sw/uiconfig/swriter/ui/navigatorpanel.ui
core/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
It's almost certainly the former.
Do we have that file in our tree? No. But let's search for that text in our
code in the same module (sw):
main/sw]$ grep 'Heading Levels Shown' * -R
source/ui/utlui/navipi.src:Text [ en-US ] = "Heading Levels
Shown" ;
So it's in main/sw/source/ui/utlui/navipi.src
Sadly main/sw is one of our biggest modules :-/.
Where is the code using it? Well reading that file gives us:
ToolBoxItem
{
Identifier = FN_OUTLINE_LEVEL ;
HelpID = HID_NAVI_TBX13 ;
/* ### ACHTUNG: Neuer Text in Resource?
Angezeigte berschriftenebenen : Angezeigte <9A>berschriftenebenen */
Text [ en-US ] = "Heading Levels Shown" ;
DropDown = TRUE ;
};
So who is using FN_OUTLINE_LEVEL?
main/sw]$ grep FN_OUTLINE_LEVEL * -R
inc/cmdid.h:#define FN_OUTLINE_LEVEL(FN_VIEW + 36)/**/
source/ui/utlui/navipi.cxx:case FN_OUTLINE_LEVEL:
source/ui/utlui/navipi.cxx:
pBox->GetItemRect(FN_OUTLINE_LEVEL),
source/ui/utlui/navipi.cxx:aContentToolBox.SetItemBits(
FN_OUTLINE_LEVEL, aContentToolBox.GetItemBits( FN_OUTLINE_LEVEL ) |
TIB_DROPDOWNONLY );
source/ui/utlui/navipi.src:FN_OUTLINE_LEVEL ;\
source/ui/utlui/navipi.src:Identifier = FN_OUTLINE_LEVEL ;
Happy coding
Damjan
On Mon, Jan 21, 2019 at 6:58 PM Rory O'Farrell wrote:
> Can anyone tell me if, in the AOO code, there is a module for Navigator?
> If so, which module is it?
>
> My thinking is that Navigator could do with some additions, such as
> ability to display the word count for Chapters (helpful for an author to
> tweak his chapter lengths to be roughly the same), and the ability to
> display only comments from one author - so that, for example, a student
> might see only his tutor's comments as he incorporated their advice into
> his text.
>
> If there is a Navigator module, I would look at the source code to try to
> implement the above, otherwise I'm thinking of an extension to show this
> information, whether integrated into Navigator or in a stand-alone panel.
>
>
> --
> Rory O'Farrell
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
> For additional commands, e-mail: dev-h...@openoffice.apache.org
>
>
Re: Navigator query
On Mon, 21 Jan 2019 19:40:24 +0200
Damjan Jovanovic wrote:
> Hi
>
> Here's how I found it:
>
> View -> Navigator to open the window.
>
> Look for the most complex unique text there, eg. "Heading Levels Shown" in
> a tooltip.
>
> Go to https://opengrok.libreoffice.org and search for "Heading Levels
> Shown" under full-text search.
>
> It finds 2 matches:
> core/sw/uiconfig/swriter/ui/navigatorpanel.ui
> core/officecfg/registry/schema/org/openoffice/Office/Writer.xcs
>
> It's almost certainly the former.
>
> Do we have that file in our tree? No. But let's search for that text in our
> code in the same module (sw):
> main/sw]$ grep 'Heading Levels Shown' * -R
> source/ui/utlui/navipi.src:Text [ en-US ] = "Heading Levels
> Shown" ;
>
> So it's in main/sw/source/ui/utlui/navipi.src
> Sadly main/sw is one of our biggest modules :-/.
Thank you - I now know where to look when I get to this.
Rory
>
> Where is the code using it? Well reading that file gives us:
>
> ToolBoxItem
> {
> Identifier = FN_OUTLINE_LEVEL ;
> HelpID = HID_NAVI_TBX13 ;
> /* ### ACHTUNG: Neuer Text in Resource?
> Angezeigte berschriftenebenen : Angezeigte <9A>berschriftenebenen */
> Text [ en-US ] = "Heading Levels Shown" ;
> DropDown = TRUE ;
> };
>
> So who is using FN_OUTLINE_LEVEL?
>
> main/sw]$ grep FN_OUTLINE_LEVEL * -R
> inc/cmdid.h:#define FN_OUTLINE_LEVEL(FN_VIEW + 36)/**/
> source/ui/utlui/navipi.cxx:case FN_OUTLINE_LEVEL:
> source/ui/utlui/navipi.cxx:
> pBox->GetItemRect(FN_OUTLINE_LEVEL),
> source/ui/utlui/navipi.cxx:aContentToolBox.SetItemBits(
> FN_OUTLINE_LEVEL, aContentToolBox.GetItemBits( FN_OUTLINE_LEVEL ) |
> TIB_DROPDOWNONLY );
> source/ui/utlui/navipi.src:FN_OUTLINE_LEVEL ;\
> source/ui/utlui/navipi.src:Identifier = FN_OUTLINE_LEVEL ;
>
> Happy coding
> Damjan
>
> On Mon, Jan 21, 2019 at 6:58 PM Rory O'Farrell wrote:
>
> > Can anyone tell me if, in the AOO code, there is a module for Navigator?
> > If so, which module is it?
> >
> > My thinking is that Navigator could do with some additions, such as
> > ability to display the word count for Chapters (helpful for an author to
> > tweak his chapter lengths to be roughly the same), and the ability to
> > display only comments from one author - so that, for example, a student
> > might see only his tutor's comments as he incorporated their advice into
> > his text.
> >
> > If there is a Navigator module, I would look at the source code to try to
> > implement the above, otherwise I'm thinking of an extension to show this
> > information, whether integrated into Navigator or in a stand-alone panel.
> >
> >
> > --
> > Rory O'Farrell
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
> > For additional commands, e-mail: dev-h...@openoffice.apache.org
> >
> >
--
Rory O'Farrell
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: branch 4.1.7?
I'll just go ahead and create a branch. They are cheap. And, at least, we'll have a branch ready in case we need it. If not, no big deal. > On Jan 21, 2019, at 11:38 AM, Patricia Shanahan wrote: > > I agree that the focus should be on 4.2.0. However, I strongly favor having a > ready-to-go 4.1.7. Any day, we could encounter a really serious, > must-fix-immediately, security bug. Having as much as possible done ahead of > time will reduce the delay from knowing the fix to end users having the fix. > > On 1/21/2019 8:36 AM, Jim Jagielski wrote: >> Gotcha. I was just thinking that if we had a 4.1.7 branch in a ready-to-go >> stage, if we needed to do another 4.1.x release it would be already there. >> But agree that the focus should be on 4.2.0 >>> On Jan 21, 2019, at 11:25 AM, Rory O'Farrell wrote: >>> >>> On Mon, 21 Jan 2019 11:12:12 -0500 >>> Jim Jagielski wrote: >>> Does it make sense to create a branch of 4.1.7 from 4.1.6...? >>> >>> No, unless for some urgent fix. I think better to continue with 4.2.0, >>> then on to 5.0 >>> >>> 4.2.0 editing OK in Writer (60k word file, book format, no >>> illustrations/tables). A simple spreadsheet working OK; existing Impress >>> presentations displaying, apart from two where slide backgrounds cause >>> crash. Multimedia in new presentations not yet checked. >>> >>> -- >>> Rory O'Farrell >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>> >> - >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org > > --- > This email has been checked for viruses by AVG. > https://www.avg.com > > > - > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
