[jira] [Commented] (KAFKA-1870) Cannot commit with simpleConsumer on Zookeeper only with Java API

2015-01-17 Thread Thomas Vandevelde (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281389#comment-14281389
 ] 

Thomas Vandevelde commented on KAFKA-1870:
--

Thanks for the very quick fix guys!

It was indeed blocking us to move from 0.8.1  to 0.8.2
I can see that only the javaapi version is restricted to use v0, The scala one 
still has v1 as default. Is it expected? 
In our case, i suppose we will wait for the new kafkaconsumer to commit to 
kafka instead of zookeeper.

Do you know when 0.8.2 will be released by any chance?

> Cannot commit with simpleConsumer on Zookeeper only with Java API
> -
>
> Key: KAFKA-1870
> URL: https://issues.apache.org/jira/browse/KAFKA-1870
> Project: Kafka
>  Issue Type: Bug
>  Components: consumer
>Affects Versions: 0.8.2
>Reporter: Thomas Vandevelde
>Assignee: Jun Rao
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: OffsetCommitRequest.diff, kafka-1870.patch, 
> kafka-1870_2015-01-16_12:08:05.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> From Kafka 0.8.2, we need to pass version 0 in the OffsetCommitRequest if we 
> want to commit only on zookeeper.
> However the Java API doesnt allow to pass the version in parameter.
> Can you please add the version in the constructor of 
> kafka.javaapi.OffsetCommitRequest ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Hi Kafka

2015-01-17 Thread Sree V
Hi All,
I am new to Apache Kafka. I use it at work.I have been working with Apache 
Drill and Apache Calcite, as well.
I have made an updated doc for, dev setup on eclipse, if anyone needs.


Thanking you.

With Regards
Sree


Re: Review Request 29840: Patch for KAFKA-1818

2015-01-17 Thread Eric Olander

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29840/
---

(Updated Jan. 17, 2015, 3:32 p.m.)


Review request for kafka.


Bugs: KAFKA-1818
https://issues.apache.org/jira/browse/KAFKA-1818


Repository: kafka


Description
---

KAFKA-1818 clean up code to more idiomatic scala usage


Diffs
-

  core/src/main/scala/kafka/utils/ReplicationUtils.scala 
715767380f7c284148689fd34d4bfba51abd96a0 
  core/src/test/scala/unit/kafka/utils/ReplicationUtilsTest.scala 
84e08557de5acdcf0a98b192feac72836ea359b8 

Diff: https://reviews.apache.org/r/29840/diff/


Testing (updated)
---

This patch replaces some pattern matching on Option with calls to flatMap.  
Unit test added to cover both possible return values from 
ReplicationUtils.getLeaderIsrAndEpochForPartition.


Thanks,

Eric Olander



[jira] [Created] (KAFKA-1872) Update Developer Setup

2015-01-17 Thread Sree Vaddi (JIRA)
Sree Vaddi created KAFKA-1872:
-

 Summary: Update Developer Setup
 Key: KAFKA-1872
 URL: https://issues.apache.org/jira/browse/KAFKA-1872
 Project: Kafka
  Issue Type: Improvement
  Components: build
Affects Versions: 0.8.2
 Environment: Mac OSX Yosemite
eclipse Mars M4
Gradle 2
Scala 2
Git
Reporter: Sree Vaddi
 Fix For: 0.8.2


I setup my developer environment today and came up with an updated document.

Update the CWiki page at 
https://cwiki.apache.org/confluence/display/KAFKA/Developer+Setup
OR create a new page:

Update the site page at http://kafka.apache.org/code.html
with the one created in previous step.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1872) Update Developer Setup

2015-01-17 Thread Sree Vaddi (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281421#comment-14281421
 ] 

Sree Vaddi commented on KAFKA-1872:
---

[~junrao] [~maguro]
Would I get "write" permissions on Kafka CWiki to put this page ?
Would I get "assign" permissions, so I can 'Assign' this JIRA to myself and 
work on it ?


> Update Developer Setup
> --
>
> Key: KAFKA-1872
> URL: https://issues.apache.org/jira/browse/KAFKA-1872
> Project: Kafka
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 0.8.2
> Environment: Mac OSX Yosemite
> eclipse Mars M4
> Gradle 2
> Scala 2
> Git
>Reporter: Sree Vaddi
>  Labels: cwiki, development_environment, eclipse, git, gradle, 
> scala, setup
> Fix For: 0.8.2
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I setup my developer environment today and came up with an updated document.
> Update the CWiki page at 
> https://cwiki.apache.org/confluence/display/KAFKA/Developer+Setup
> OR create a new page:
> Update the site page at http://kafka.apache.org/code.html
> with the one created in previous step.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (KAFKA-1873) scalatest_2.10-1.9.1.jar of core build path is cross-compiled with an incompatible version of Scala (2.10.0)

2015-01-17 Thread Sree Vaddi (JIRA)
Sree Vaddi created KAFKA-1873:
-

 Summary: scalatest_2.10-1.9.1.jar of core build path is 
cross-compiled with an incompatible version of Scala (2.10.0)
 Key: KAFKA-1873
 URL: https://issues.apache.org/jira/browse/KAFKA-1873
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8.2
 Environment: Mac OSX Yosemite
Oracle JDK 1.7.0_72
eclipse Mars M4
Reporter: Sree Vaddi
Priority: Minor
 Fix For: 0.8.2


When you setup your development environment, you see this in Problems for the 
project 'core'.

Description ResourcePathLocationType
scalatest_2.10-1.9.1.jar of core build path is cross-compiled with an 
incompatible version of Scala (2.10.0). In case this report is mistaken, this 
check can be disabled in the compiler preference page.  core
Unknown Scala Version Problem




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1873) scalatest_2.10-1.9.1.jar of core build path is cross-compiled with an incompatible version of Scala (2.10.0)

2015-01-17 Thread Sree Vaddi (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281423#comment-14281423
 ] 

Sree Vaddi commented on KAFKA-1873:
---

Workaround:
Eclipse - Preferences - Scala - Compiler - Build manager
uncheck withVersionClasspathVariable

[~junrao] Would be good to fix the scalatest.jar itself.


> scalatest_2.10-1.9.1.jar of core build path is cross-compiled with an 
> incompatible version of Scala (2.10.0)
> 
>
> Key: KAFKA-1873
> URL: https://issues.apache.org/jira/browse/KAFKA-1873
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Affects Versions: 0.8.2
> Environment: Mac OSX Yosemite
> Oracle JDK 1.7.0_72
> eclipse Mars M4
>Reporter: Sree Vaddi
>Priority: Minor
>  Labels: 2.10.0, core, incompatible, scala, scalatest
> Fix For: 0.8.2
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When you setup your development environment, you see this in Problems for the 
> project 'core'.
> Description   ResourcePathLocationType
> scalatest_2.10-1.9.1.jar of core build path is cross-compiled with an 
> incompatible version of Scala (2.10.0). In case this report is mistaken, this 
> check can be disabled in the compiler preference page.core
> Unknown Scala Version Problem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (KAFKA-1845) KafkaConfig should use ConfigDef

2015-01-17 Thread Joe Stein (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Stein updated KAFKA-1845:
-
Reviewer: Gwen Shapira
Assignee: Andrii Biletskyi

Andrii, lets get this patch out of the way so that we can get back to the CLI & 
Global config changes since this is direct blocker of those please.

> KafkaConfig should use ConfigDef 
> -
>
> Key: KAFKA-1845
> URL: https://issues.apache.org/jira/browse/KAFKA-1845
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Gwen Shapira
>Assignee: Andrii Biletskyi
>  Labels: newbie
>
> ConfigDef is already used for the new producer and for TopicConfig. 
> Will be nice to standardize and use one configuration and validation library 
> across the board.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (KAFKA-1874) missing import util.parsing.json.JSON

2015-01-17 Thread Sree Vaddi (JIRA)
Sree Vaddi created KAFKA-1874:
-

 Summary: missing import util.parsing.json.JSON
 Key: KAFKA-1874
 URL: https://issues.apache.org/jira/browse/KAFKA-1874
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8.2
 Environment: Mac OSX Yosemite
Oracle JDK 1.7.0_72
eclipse Mars M4
Scala 2.11.5
Reporter: Sree Vaddi
 Fix For: 0.8.2


core project
main scala folder
kafka.utils.Json.scala file

line#21
import util.parsing.json.JSON

this class is missing.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [DISCUSS] KIPs

2015-01-17 Thread Joe Stein
+1 to everything we have been saying and where this (has settled to)/(is
settling to).

I am sure other folks have some more feedback and think we should try to
keep this discussion going if need be. I am also a firm believer of form
following function so kicking the tires some to flesh out the details of
this and have some organic growth with the process will be healthy and
beneficial to the community.

For my part, what I will do is open a few KIP based on some of the work I
have been involved with for 0.8.3. Off the top of my head this would
include 1) changes to re-assignment of partitions 2) kafka cli 3) global
configs 4) security white list black list by ip 5) SSL 6) We probably will
have lots of Security related KIPs and should treat them all individually
when the time is appropriate 7) Kafka on Mesos.

If someone else wants to jump in to start getting some of the security KIP
that we are going to have in 0.8.3 I think that would be great (e.g.
Multiple Listeners for Kafka Brokers). There are also a few other tickets I
can think of that are important to have in the code in 0.8.3 that should
have KIP also that I haven't really been involved in. I will take a few
minutes and go through JIRA (one I can think of like auto assign id that is
already committed I think) and ask for a KIP if appropriate or if I feel
that I can write it up (both from a time and understanding perspective) do
so.

long story short, I encourage folks to start moving ahead with the KIP for
0.8.3 as how we operate. any objections?

On Fri, Jan 16, 2015 at 2:40 PM, Guozhang Wang  wrote:

> +1 on the idea, and we could mutually link the KIP wiki page with the the
> created JIRA ticket (i.e. include the JIRA number on the page and the KIP
> url on the ticket description).
>
> Regarding the KIP process, probably we do not need two phase communication
> of a [DISCUSS] followed by [VOTE], as Jay said the voting should be clear
> while people discuss about that.
>
> About who should trigger the process, I think the only involved people
> would be 1) when the patch is submitted / or even the ticket is created,
> the assignee could choose to start the KIP process if she thought it is
> necessary; 2) the reviewer of the patch can also suggest starting KIP
> discussions.
>
> On Fri, Jan 16, 2015 at 10:49 AM, Gwen Shapira 
> wrote:
>
> > +1 to Ewen's suggestions: Deprecation, status and version.
> >
> > Perhaps add the JIRA where the KIP was implemented to the metadata.
> > This will help tie things together.
> >
> > On Fri, Jan 16, 2015 at 9:35 AM, Ewen Cheslack-Postava
> >  wrote:
> > > I think adding a section about deprecation would be helpful. A good
> > > fraction of the time I would expect the goal of a KIP is to fix or
> > replace
> > > older functionality that needs continued support for compatibility, but
> > > should eventually be phased out. This helps Kafka devs understand how
> > long
> > > they'll end up supporting multiple versions of features and helps users
> > > understand when they're going to have to make updates to their
> > applications.
> > >
> > > Less important but useful -- having a bit of standard metadata like
> PEPs
> > > do. Two I think are important are status (if someone lands on the KIP
> > page,
> > > can they tell whether this KIP was ever completed?) and/or the version
> > the
> > > KIP was first released in.
> > >
> > >
> > >
> > > On Fri, Jan 16, 2015 at 9:20 AM, Joel Koshy 
> wrote:
> > >
> > >> I'm definitely +1 on the KIP concept. As Joe mentioned, we are already
> > >> doing this in one form or the other. However, IMO it is fairly ad hoc
> > >> - i.e., a combination of DISCUSS threads, jira comments, RB and code
> > >> comments, wikis and html documentation. In the past I have had to dig
> > >> into a bunch of these to try and figure out why something was
> > >> implemented a certain way. I think KIPs can help a lot here first by
> > >> providing guidelines on what to think about (compatibility, new APIs,
> > >> etc.) when working through a major feature; and second by becoming a
> > >> crisp source of truth documentation for new releases.  E.g., for
> > >> feature X: see relevant KIPs: a, b, c, etc.
> > >>
> > >> On Thu, Jan 15, 2015 at 08:11:20PM -0800, Jay Kreps wrote:
> > >> > Hey Joe,
> > >> >
> > >> > Yeah I guess the question is what is the definition of major? I
> agree
> > we
> > >> > definitely don't want to generate a bunch of paperwork. We have
> enough
> > >> > problems just getting all the contributions reviewed and checked in
> > in a
> > >> > timely fashion...
> > >> >
> > >> > So obviously bug fixes would not apply here.
> > >> >
> > >> > I think it is also pretty clear that big features should get
> reviewed
> > and
> > >> > discussed. To pick on myself, for example, the log compaction work
> was
> > >> done
> > >> > without enough public discussion about how it worked and why
> (imho). I
> > >> > hope/claim that enough rigour in thinking about use-cases and
> > operations
> > >> > 

Re: Review Request 29840: Patch for KAFKA-1818

2015-01-17 Thread Gwen Shapira

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29840/#review68549
---

Ship it!


Looks nice, thanks for the cleanup and the test.

non-binding +1 from me.

- Gwen Shapira


On Jan. 17, 2015, 3:32 p.m., Eric Olander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29840/
> ---
> 
> (Updated Jan. 17, 2015, 3:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1818
> https://issues.apache.org/jira/browse/KAFKA-1818
> 
> 
> Repository: kafka
> 
> 
> Description
> ---
> 
> KAFKA-1818 clean up code to more idiomatic scala usage
> 
> 
> Diffs
> -
> 
>   core/src/main/scala/kafka/utils/ReplicationUtils.scala 
> 715767380f7c284148689fd34d4bfba51abd96a0 
>   core/src/test/scala/unit/kafka/utils/ReplicationUtilsTest.scala 
> 84e08557de5acdcf0a98b192feac72836ea359b8 
> 
> Diff: https://reviews.apache.org/r/29840/diff/
> 
> 
> Testing
> ---
> 
> This patch replaces some pattern matching on Option with calls to flatMap.  
> Unit test added to cover both possible return values from 
> ReplicationUtils.getLeaderIsrAndEpochForPartition.
> 
> 
> Thanks,
> 
> Eric Olander
> 
>



[jira] [Commented] (KAFKA-1872) Update Developer Setup

2015-01-17 Thread Jun Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281429#comment-14281429
 ] 

Jun Rao commented on KAFKA-1872:


Done for both wiki and jira.

> Update Developer Setup
> --
>
> Key: KAFKA-1872
> URL: https://issues.apache.org/jira/browse/KAFKA-1872
> Project: Kafka
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 0.8.2
> Environment: Mac OSX Yosemite
> eclipse Mars M4
> Gradle 2
> Scala 2
> Git
>Reporter: Sree Vaddi
>  Labels: cwiki, development_environment, eclipse, git, gradle, 
> scala, setup
> Fix For: 0.8.2
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I setup my developer environment today and came up with an updated document.
> Update the CWiki page at 
> https://cwiki.apache.org/confluence/display/KAFKA/Developer+Setup
> OR create a new page:
> Update the site page at http://kafka.apache.org/code.html
> with the one created in previous step.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1874) missing import util.parsing.json.JSON

2015-01-17 Thread Manikumar Reddy (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281431#comment-14281431
 ] 

Manikumar Reddy commented on KAFKA-1874:


I'm not sure if I understand your question. Can you elaborate?.  
util.parsing.json.JSON is part of scala-library.jar

> missing import util.parsing.json.JSON
> -
>
> Key: KAFKA-1874
> URL: https://issues.apache.org/jira/browse/KAFKA-1874
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Affects Versions: 0.8.2
> Environment: Mac OSX Yosemite
> Oracle JDK 1.7.0_72
> eclipse Mars M4
> Scala 2.11.5
>Reporter: Sree Vaddi
>  Labels: class, missing, scala
> Fix For: 0.8.2
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> core project
> main scala folder
> kafka.utils.Json.scala file
> line#21
> import util.parsing.json.JSON
> this class is missing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1873) scalatest_2.10-1.9.1.jar of core build path is cross-compiled with an incompatible version of Scala (2.10.0)

2015-01-17 Thread Jun Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281433#comment-14281433
 ] 

Jun Rao commented on KAFKA-1873:


Hmm, our build script is the following. It explicitly specifies 
scalatest_2.10-1.9.1.jar for scala 2.10 and our tests have been running fine. 
Are you sure this is an issue?

if (scalaVersion.startsWith('2.10')) {
  testCompile 'org.scalatest:scalatest_2.10:1.9.1'
} else if (scalaVersion.startsWith('2.11')) {
  compile 'org.scala-lang.modules:scala-xml_2.11:1.0.2'
  compile 'org.scala-lang.modules:scala-parser-combinators_2.11:1.0.2'
  testCompile "org.scalatest:scalatest_2.11:2.2.0"
} else {
  testCompile "org.scalatest:scalatest_$scalaVersion:1.8"
}


> scalatest_2.10-1.9.1.jar of core build path is cross-compiled with an 
> incompatible version of Scala (2.10.0)
> 
>
> Key: KAFKA-1873
> URL: https://issues.apache.org/jira/browse/KAFKA-1873
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Affects Versions: 0.8.2
> Environment: Mac OSX Yosemite
> Oracle JDK 1.7.0_72
> eclipse Mars M4
>Reporter: Sree Vaddi
>Priority: Minor
>  Labels: 2.10.0, core, incompatible, scala, scalatest
> Fix For: 0.8.2
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When you setup your development environment, you see this in Problems for the 
> project 'core'.
> Description   ResourcePathLocationType
> scalatest_2.10-1.9.1.jar of core build path is cross-compiled with an 
> incompatible version of Scala (2.10.0). In case this report is mistaken, this 
> check can be disabled in the compiler preference page.core
> Unknown Scala Version Problem



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [DISCUSS] KIPs

2015-01-17 Thread Gwen Shapira
+1

Will be happy to provide a KIP for the multiple-listeners patch.

Gwen

On Sat, Jan 17, 2015 at 8:10 AM, Joe Stein  wrote:
> +1 to everything we have been saying and where this (has settled to)/(is
> settling to).
>
> I am sure other folks have some more feedback and think we should try to
> keep this discussion going if need be. I am also a firm believer of form
> following function so kicking the tires some to flesh out the details of
> this and have some organic growth with the process will be healthy and
> beneficial to the community.
>
> For my part, what I will do is open a few KIP based on some of the work I
> have been involved with for 0.8.3. Off the top of my head this would
> include 1) changes to re-assignment of partitions 2) kafka cli 3) global
> configs 4) security white list black list by ip 5) SSL 6) We probably will
> have lots of Security related KIPs and should treat them all individually
> when the time is appropriate 7) Kafka on Mesos.
>
> If someone else wants to jump in to start getting some of the security KIP
> that we are going to have in 0.8.3 I think that would be great (e.g.
> Multiple Listeners for Kafka Brokers). There are also a few other tickets I
> can think of that are important to have in the code in 0.8.3 that should
> have KIP also that I haven't really been involved in. I will take a few
> minutes and go through JIRA (one I can think of like auto assign id that is
> already committed I think) and ask for a KIP if appropriate or if I feel
> that I can write it up (both from a time and understanding perspective) do
> so.
>
> long story short, I encourage folks to start moving ahead with the KIP for
> 0.8.3 as how we operate. any objections?
>
> On Fri, Jan 16, 2015 at 2:40 PM, Guozhang Wang  wrote:
>
>> +1 on the idea, and we could mutually link the KIP wiki page with the the
>> created JIRA ticket (i.e. include the JIRA number on the page and the KIP
>> url on the ticket description).
>>
>> Regarding the KIP process, probably we do not need two phase communication
>> of a [DISCUSS] followed by [VOTE], as Jay said the voting should be clear
>> while people discuss about that.
>>
>> About who should trigger the process, I think the only involved people
>> would be 1) when the patch is submitted / or even the ticket is created,
>> the assignee could choose to start the KIP process if she thought it is
>> necessary; 2) the reviewer of the patch can also suggest starting KIP
>> discussions.
>>
>> On Fri, Jan 16, 2015 at 10:49 AM, Gwen Shapira 
>> wrote:
>>
>> > +1 to Ewen's suggestions: Deprecation, status and version.
>> >
>> > Perhaps add the JIRA where the KIP was implemented to the metadata.
>> > This will help tie things together.
>> >
>> > On Fri, Jan 16, 2015 at 9:35 AM, Ewen Cheslack-Postava
>> >  wrote:
>> > > I think adding a section about deprecation would be helpful. A good
>> > > fraction of the time I would expect the goal of a KIP is to fix or
>> > replace
>> > > older functionality that needs continued support for compatibility, but
>> > > should eventually be phased out. This helps Kafka devs understand how
>> > long
>> > > they'll end up supporting multiple versions of features and helps users
>> > > understand when they're going to have to make updates to their
>> > applications.
>> > >
>> > > Less important but useful -- having a bit of standard metadata like
>> PEPs
>> > > do. Two I think are important are status (if someone lands on the KIP
>> > page,
>> > > can they tell whether this KIP was ever completed?) and/or the version
>> > the
>> > > KIP was first released in.
>> > >
>> > >
>> > >
>> > > On Fri, Jan 16, 2015 at 9:20 AM, Joel Koshy 
>> wrote:
>> > >
>> > >> I'm definitely +1 on the KIP concept. As Joe mentioned, we are already
>> > >> doing this in one form or the other. However, IMO it is fairly ad hoc
>> > >> - i.e., a combination of DISCUSS threads, jira comments, RB and code
>> > >> comments, wikis and html documentation. In the past I have had to dig
>> > >> into a bunch of these to try and figure out why something was
>> > >> implemented a certain way. I think KIPs can help a lot here first by
>> > >> providing guidelines on what to think about (compatibility, new APIs,
>> > >> etc.) when working through a major feature; and second by becoming a
>> > >> crisp source of truth documentation for new releases.  E.g., for
>> > >> feature X: see relevant KIPs: a, b, c, etc.
>> > >>
>> > >> On Thu, Jan 15, 2015 at 08:11:20PM -0800, Jay Kreps wrote:
>> > >> > Hey Joe,
>> > >> >
>> > >> > Yeah I guess the question is what is the definition of major? I
>> agree
>> > we
>> > >> > definitely don't want to generate a bunch of paperwork. We have
>> enough
>> > >> > problems just getting all the contributions reviewed and checked in
>> > in a
>> > >> > timely fashion...
>> > >> >
>> > >> > So obviously bug fixes would not apply here.
>> > >> >
>> > >> > I think it is also pretty clear that big features should get
>> reviewed
>> > and
>> > >> > dis

[jira] [Commented] (KAFKA-1870) Cannot commit with simpleConsumer on Zookeeper only with Java API

2015-01-17 Thread Jun Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281436#comment-14281436
 ] 

Jun Rao commented on KAFKA-1870:


Yes, the scala one still defaults to version 1. This is a bit harder to fix 
since both OffsetCommitRequest and OffsetFetchRequest are used internally and 
we always want the default to be the latest version. Technically, only the 
javaapi is our public api. If you are using the scala api, the workaround is to 
explicitly specify version 0 when constructing OffsetCommitRequest and 
OffsetFetchRequest.

0.8.2 is being voted now and hopefully we can release it by end of next week.

> Cannot commit with simpleConsumer on Zookeeper only with Java API
> -
>
> Key: KAFKA-1870
> URL: https://issues.apache.org/jira/browse/KAFKA-1870
> Project: Kafka
>  Issue Type: Bug
>  Components: consumer
>Affects Versions: 0.8.2
>Reporter: Thomas Vandevelde
>Assignee: Jun Rao
>Priority: Blocker
> Fix For: 0.8.2
>
> Attachments: OffsetCommitRequest.diff, kafka-1870.patch, 
> kafka-1870_2015-01-16_12:08:05.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> From Kafka 0.8.2, we need to pass version 0 in the OffsetCommitRequest if we 
> want to commit only on zookeeper.
> However the Java API doesnt allow to pass the version in parameter.
> Can you please add the version in the constructor of 
> kafka.javaapi.OffsetCommitRequest ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


ProducerFailureHandlingTest.testCannotSendToInternalTopic is failing

2015-01-17 Thread Manikumar Reddy
ProducerFailureHandlingTest.testCannotSendToInternalTopic is failing on
both 0.8.2 and trunk.

Error on 0.8.2:
kafka.api.ProducerFailureHandlingTest > testCannotSendToInternalTopic FAILED
java.util.concurrent.ExecutionException:
org.apache.kafka.common.errors.TimeoutException: Failed to update metadata
after 3000 ms.
at
org.apache.kafka.clients.producer.KafkaProducer$FutureFailure.(KafkaProducer.java:437)
at
org.apache.kafka.clients.producer.KafkaProducer.send(KafkaProducer.java:352)
at
org.apache.kafka.clients.producer.KafkaProducer.send(KafkaProducer.java:248)
at
kafka.api.ProducerFailureHandlingTest.testCannotSendToInternalTopic(ProducerFailureHandlingTest.scala:309)

Caused by:
org.apache.kafka.common.errors.TimeoutException: Failed to update
metadata after 3000 ms.


Error on Trunk:
kafka.api.test.ProducerFailureHandlingTest > testCannotSendToInternalTopic
FAILED
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:69)
at org.junit.Assert.assertTrue(Assert.java:32)
at org.junit.Assert.assertTrue(Assert.java:41)
at
kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic(ProducerFailureHandlingTest.scala:312)


Re: ProducerFailureHandlingTest.testCannotSendToInternalTopic is failing

2015-01-17 Thread Harsha
I don't see any failures in tests with the latest trunk or 0.8.2. I ran
it few times in a loop.
-Harsha

On Sat, Jan 17, 2015, at 08:38 AM, Manikumar Reddy wrote:
> ProducerFailureHandlingTest.testCannotSendToInternalTopic is failing on
> both 0.8.2 and trunk.
> 
> Error on 0.8.2:
> kafka.api.ProducerFailureHandlingTest > testCannotSendToInternalTopic
> FAILED
> java.util.concurrent.ExecutionException:
> org.apache.kafka.common.errors.TimeoutException: Failed to update
> metadata
> after 3000 ms.
> at
> org.apache.kafka.clients.producer.KafkaProducer$FutureFailure.(KafkaProducer.java:437)
> at
> org.apache.kafka.clients.producer.KafkaProducer.send(KafkaProducer.java:352)
> at
> org.apache.kafka.clients.producer.KafkaProducer.send(KafkaProducer.java:248)
> at
> kafka.api.ProducerFailureHandlingTest.testCannotSendToInternalTopic(ProducerFailureHandlingTest.scala:309)
> 
> Caused by:
> org.apache.kafka.common.errors.TimeoutException: Failed to update
> metadata after 3000 ms.
> 
> 
> Error on Trunk:
> kafka.api.test.ProducerFailureHandlingTest >
> testCannotSendToInternalTopic
> FAILED
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:69)
> at org.junit.Assert.assertTrue(Assert.java:32)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic(ProducerFailureHandlingTest.scala:312)


Re: Review Request 24214: Patch for KAFKA-1374

2015-01-17 Thread Manikumar Reddy O

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---

(Updated Jan. 17, 2015, 6:51 p.m.)


Review request for kafka.


Bugs: KAFKA-1374
https://issues.apache.org/jira/browse/KAFKA-1374


Repository: kafka


Description (updated)
---

Updating the rebased code


Diffs (updated)
-

  core/src/main/scala/kafka/log/LogCleaner.scala 
f8e7cd5fabce78c248a9027c4bb374a792508675 
  core/src/main/scala/kafka/tools/TestLogCleaning.scala 
af496f7c547a5ac7a4096a6af325dad0d8feec6f 
  core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 
07acd460b1259e0a3f4069b8b8dcd8123ef5810e 

Diff: https://reviews.apache.org/r/24214/diff/


Testing (updated)
---

/safe/KAFKA/docs/TestLogCleaning.txt


Thanks,

Manikumar Reddy O



[jira] [Commented] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2015-01-17 Thread Manikumar Reddy (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281480#comment-14281480
 ] 

Manikumar Reddy commented on KAFKA-1374:


Updated reviewboard https://reviews.apache.org/r/24214/diff/
 against branch origin/trunk

> LogCleaner (compaction) does not support compressed topics
> --
>
> Key: KAFKA-1374
> URL: https://issues.apache.org/jira/browse/KAFKA-1374
> Project: Kafka
>  Issue Type: Bug
>Reporter: Joel Koshy
>Assignee: Manikumar Reddy
>  Labels: newbie++
> Fix For: 0.8.3
>
> Attachments: KAFKA-1374.patch, KAFKA-1374_2014-08-09_16:18:55.patch, 
> KAFKA-1374_2014-08-12_22:23:06.patch, KAFKA-1374_2014-09-23_21:47:12.patch, 
> KAFKA-1374_2014-10-03_18:49:16.patch, KAFKA-1374_2014-10-03_19:17:17.patch, 
> KAFKA-1374_2015-01-18_00:19:21.patch
>
>
> This is a known issue, but opening a ticket to track.
> If you try to compact a topic that has compressed messages you will run into
> various exceptions - typically because during iteration we advance the
> position based on the decompressed size of the message. I have a bunch of
> stack traces, but it should be straightforward to reproduce.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2015-01-17 Thread Manikumar Reddy (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Manikumar Reddy updated KAFKA-1374:
---
Attachment: KAFKA-1374_2015-01-18_00:19:21.patch

> LogCleaner (compaction) does not support compressed topics
> --
>
> Key: KAFKA-1374
> URL: https://issues.apache.org/jira/browse/KAFKA-1374
> Project: Kafka
>  Issue Type: Bug
>Reporter: Joel Koshy
>Assignee: Manikumar Reddy
>  Labels: newbie++
> Fix For: 0.8.3
>
> Attachments: KAFKA-1374.patch, KAFKA-1374_2014-08-09_16:18:55.patch, 
> KAFKA-1374_2014-08-12_22:23:06.patch, KAFKA-1374_2014-09-23_21:47:12.patch, 
> KAFKA-1374_2014-10-03_18:49:16.patch, KAFKA-1374_2014-10-03_19:17:17.patch, 
> KAFKA-1374_2015-01-18_00:19:21.patch
>
>
> This is a known issue, but opening a ticket to track.
> If you try to compact a topic that has compressed messages you will run into
> various exceptions - typically because during iteration we advance the
> position based on the decompressed size of the message. I have a bunch of
> stack traces, but it should be straightforward to reproduce.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Review Request 24214: Patch for KAFKA-1374

2015-01-17 Thread Manikumar Reddy O

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24214/
---

(Updated Jan. 17, 2015, 6:53 p.m.)


Review request for kafka.


Bugs: KAFKA-1374
https://issues.apache.org/jira/browse/KAFKA-1374


Repository: kafka


Description
---

Updating the rebased code


Diffs
-

  core/src/main/scala/kafka/log/LogCleaner.scala 
f8e7cd5fabce78c248a9027c4bb374a792508675 
  core/src/main/scala/kafka/tools/TestLogCleaning.scala 
af496f7c547a5ac7a4096a6af325dad0d8feec6f 
  core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 
07acd460b1259e0a3f4069b8b8dcd8123ef5810e 

Diff: https://reviews.apache.org/r/24214/diff/


Testing (updated)
---

/*TestLogCleaning stress test output for compressed messages/

Producing 10 messages...
Logging produce requests to 
/tmp/kafka-log-cleaner-produced-6014466306002699464.txt
Sleeping for 120 seconds...
Consuming messages...
Logging consumed messages to 
/tmp/kafka-log-cleaner-consumed-177538909590644701.txt
10 rows of data produced, 13165 rows of data consumed (86.8% reduction).
De-duplicating and validating output files...
Validated 9005 values, 0 mismatches.

Producing 100 messages...
Logging produce requests to 
/tmp/kafka-log-cleaner-produced-3298578695475992991.txt
Sleeping for 120 seconds...
Consuming messages...
Logging consumed messages to 
/tmp/kafka-log-cleaner-consumed-7192293977610206930.txt
100 rows of data produced, 119926 rows of data consumed (88.0% reduction).
De-duplicating and validating output files...
Validated 89947 values, 0 mismatches.

Producing 1000 messages...
Logging produce requests to 
/tmp/kafka-log-cleaner-produced-3336255463347572934.txt
Sleeping for 120 seconds...
Consuming messages...
Logging consumed messages to 
/tmp/kafka-log-cleaner-consumed-9149188270705707725.txt
1000 rows of data produced, 1645281 rows of data consumed (83.5% reduction).
De-duplicating and validating output files...
Validated 899853 values, 0 mismatches.


/*TestLogCleaning stress test output for non-compressed messages*/

Producing 10 messages...
Logging produce requests to 
/tmp/kafka-log-cleaner-produced-5174543709786189363.txt
Sleeping for 120 seconds...
Consuming messages...
Logging consumed messages to 
/tmp/kafka-log-cleaner-consumed-514345501144701.txt
10 rows of data produced, 22775 rows of data consumed (77.2% reduction).
De-duplicating and validating output files...
Validated 17874 values, 0 mismatches.

Producing 100 messages...
Logging produce requests to 
/tmp/kafka-log-cleaner-produced-7814446915546169271.txt
Sleeping for 120 seconds...
Consuming messages...
Logging consumed messages to 
/tmp/kafka-log-cleaner-consumed-5172557663160447626.txt
100 rows of data produced, 129230 rows of data consumed (87.1% reduction).
De-duplicating and validating output files...
Validated 89947 values, 0 mismatches.

Producing 1000 messages...
Logging produce requests to 
/tmp/kafka-log-cleaner-produced-6092986571905399164.txt
Sleeping for 120 seconds...
Consuming messages...
Logging consumed messages to 
/tmp/kafka-log-cleaner-consumed-63626021421841220.txt
1000 rows of data produced, 1136608 rows of data consumed (88.6% reduction).
De-duplicating and validating output files...
Validated 899853 values, 0 mismatches.


Thanks,

Manikumar Reddy O



Re: ProducerFailureHandlingTest.testCannotSendToInternalTopic is failing

2015-01-17 Thread Manikumar Reddy
 I am consistently getting these errors. May be transient errors.

On Sun, Jan 18, 2015 at 12:05 AM, Harsha  wrote:

> I don't see any failures in tests with the latest trunk or 0.8.2. I ran
> it few times in a loop.
> -Harsha
>
> On Sat, Jan 17, 2015, at 08:38 AM, Manikumar Reddy wrote:
> > ProducerFailureHandlingTest.testCannotSendToInternalTopic is failing on
> > both 0.8.2 and trunk.
> >
> > Error on 0.8.2:
> > kafka.api.ProducerFailureHandlingTest > testCannotSendToInternalTopic
> > FAILED
> > java.util.concurrent.ExecutionException:
> > org.apache.kafka.common.errors.TimeoutException: Failed to update
> > metadata
> > after 3000 ms.
> > at
> >
> org.apache.kafka.clients.producer.KafkaProducer$FutureFailure.(KafkaProducer.java:437)
> > at
> >
> org.apache.kafka.clients.producer.KafkaProducer.send(KafkaProducer.java:352)
> > at
> >
> org.apache.kafka.clients.producer.KafkaProducer.send(KafkaProducer.java:248)
> > at
> >
> kafka.api.ProducerFailureHandlingTest.testCannotSendToInternalTopic(ProducerFailureHandlingTest.scala:309)
> >
> > Caused by:
> > org.apache.kafka.common.errors.TimeoutException: Failed to update
> > metadata after 3000 ms.
> >
> >
> > Error on Trunk:
> > kafka.api.test.ProducerFailureHandlingTest >
> > testCannotSendToInternalTopic
> > FAILED
> > java.lang.AssertionError: null
> > at org.junit.Assert.fail(Assert.java:69)
> > at org.junit.Assert.assertTrue(Assert.java:32)
> > at org.junit.Assert.assertTrue(Assert.java:41)
> > at
> >
> kafka.api.test.ProducerFailureHandlingTest.testCannotSendToInternalTopic(ProducerFailureHandlingTest.scala:312)
>


[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-17 Thread Ashish Kumar Singh (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281523#comment-14281523
 ] 

Ashish Kumar Singh commented on KAFKA-1856:
---

[~gwenshap] If jenkins job specifies {{BUILD_URL}}, then the link will be 
printed as well. So, yes it will work.

I noticed that many JIRAs mention 0.8.3 or 0.9.0 as the fix versions, those 
branches not yet exist. I am trying to understand how branching is done in 
Kafka. 0.8.1 came out of trunk and then was merged with trunk. 0.8.2 was again 
forked out of trunk. However, I think its not always true, as I was not able to 
build KAFKA-1694's patch with trunk, not even with 0.8.2. Could you help me 
understand branching aspect of the project a bit?

> Add PreCommit Patch Testing
> ---
>
> Key: KAFKA-1856
> URL: https://issues.apache.org/jira/browse/KAFKA-1856
> Project: Kafka
>  Issue Type: Task
>Reporter: Ashish Kumar Singh
>Assignee: Ashish Kumar Singh
> Attachments: KAFKA-1856.patch
>
>
> h1. Kafka PreCommit Patch Testing - *Don't wait for it to break*
> h2. Motivation
> *With great power comes great responsibility* - Uncle Ben. As Kafka user list 
> is growing, mechanism to ensure quality of the product is required. Quality 
> becomes hard to measure and maintain in an open source project, because of a 
> wide community of contributors. Luckily, Kafka is not the first open source 
> project and can benefit from learnings of prior projects.
> PreCommit tests are the tests that are run for each patch that gets attached 
> to an open JIRA. Based on tests results, test execution framework, test bot, 
> +1 or -1 the patch. Having PreCommit tests take the load off committers to 
> look at or test each patch.
> h2. Tests in Kafka
> h3. Unit and Integraiton Tests
> [Unit and Integration 
> tests|https://cwiki.apache.org/confluence/display/KAFKA/Kafka+0.9+Unit+and+Integration+Tests]
>  are cardinal to help contributors to avoid breaking existing functionalities 
> while adding new functionalities or fixing older ones. These tests, atleast 
> the ones relevant to the changes, must be run by contributors before 
> attaching a patch to a JIRA.
> h3. System Tests
> [System 
> tests|https://cwiki.apache.org/confluence/display/KAFKA/Kafka+System+Tests] 
> are much wider tests that, unlike unit tests, focus on end-to-end scenarios 
> and not some specific method or class.
> h2. Apache PreCommit tests
> Apache provides a mechanism to automatically build a project and run a series 
> of tests whenever a patch is uploaded to a JIRA. Based on test execution, the 
> test framework will comment with a +1 or -1 on the JIRA.
> You can read more about the framework here:
> http://wiki.apache.org/general/PreCommitBuilds
> h2. Plan
> # Create a test-patch.py script (similar to the one used in Flume, Sqoop and 
> other projects) that will take a jira as a parameter, apply on the 
> appropriate branch, build the project, run tests and report results. This 
> script should be committed into the Kafka code-base. To begin with, this will 
> only run unit tests. We can add code sanity checks, system_tests, etc in the 
> future.
> # Create a jenkins job for running the test (as described in 
> http://wiki.apache.org/general/PreCommitBuilds) and validate that it works 
> manually. This must be done by a committer with Jenkins access.
> # Ask someone with access to https://builds.apache.org/job/PreCommit-Admin/ 
> to add Kafka to the list of projects PreCommit-Admin triggers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1856) Add PreCommit Patch Testing

2015-01-17 Thread Joe Stein (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281546#comment-14281546
 ] 

Joe Stein commented on KAFKA-1856:
--

The way we have been developing since from incubation is on trunk. When we are 
ready (or close to ready) we make a branch for that release off of trunk. This 
allows new work to occur on trunk and any blockers to be double committed to 
branch release and trunk. If we ever need (as was the case with 0.8.0) to make 
a an update on that branched release we update on that branch (again double 
committing to trunk). When we actually do a final release we have it on a tag 
e.g. 0.8.1.0, 0.8.1.1, 0.8.2.0 etc so as to not conflict with the branch name 
and give the branch the ability for minor blocker fixes to get out.

> Add PreCommit Patch Testing
> ---
>
> Key: KAFKA-1856
> URL: https://issues.apache.org/jira/browse/KAFKA-1856
> Project: Kafka
>  Issue Type: Task
>Reporter: Ashish Kumar Singh
>Assignee: Ashish Kumar Singh
> Attachments: KAFKA-1856.patch
>
>
> h1. Kafka PreCommit Patch Testing - *Don't wait for it to break*
> h2. Motivation
> *With great power comes great responsibility* - Uncle Ben. As Kafka user list 
> is growing, mechanism to ensure quality of the product is required. Quality 
> becomes hard to measure and maintain in an open source project, because of a 
> wide community of contributors. Luckily, Kafka is not the first open source 
> project and can benefit from learnings of prior projects.
> PreCommit tests are the tests that are run for each patch that gets attached 
> to an open JIRA. Based on tests results, test execution framework, test bot, 
> +1 or -1 the patch. Having PreCommit tests take the load off committers to 
> look at or test each patch.
> h2. Tests in Kafka
> h3. Unit and Integraiton Tests
> [Unit and Integration 
> tests|https://cwiki.apache.org/confluence/display/KAFKA/Kafka+0.9+Unit+and+Integration+Tests]
>  are cardinal to help contributors to avoid breaking existing functionalities 
> while adding new functionalities or fixing older ones. These tests, atleast 
> the ones relevant to the changes, must be run by contributors before 
> attaching a patch to a JIRA.
> h3. System Tests
> [System 
> tests|https://cwiki.apache.org/confluence/display/KAFKA/Kafka+System+Tests] 
> are much wider tests that, unlike unit tests, focus on end-to-end scenarios 
> and not some specific method or class.
> h2. Apache PreCommit tests
> Apache provides a mechanism to automatically build a project and run a series 
> of tests whenever a patch is uploaded to a JIRA. Based on test execution, the 
> test framework will comment with a +1 or -1 on the JIRA.
> You can read more about the framework here:
> http://wiki.apache.org/general/PreCommitBuilds
> h2. Plan
> # Create a test-patch.py script (similar to the one used in Flume, Sqoop and 
> other projects) that will take a jira as a parameter, apply on the 
> appropriate branch, build the project, run tests and report results. This 
> script should be committed into the Kafka code-base. To begin with, this will 
> only run unit tests. We can add code sanity checks, system_tests, etc in the 
> future.
> # Create a jenkins job for running the test (as described in 
> http://wiki.apache.org/general/PreCommitBuilds) and validate that it works 
> manually. This must be done by a committer with Jenkins access.
> # Ask someone with access to https://builds.apache.org/job/PreCommit-Admin/ 
> to add Kafka to the list of projects PreCommit-Admin triggers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (KAFKA-1874) missing import util.parsing.json.JSON

2015-01-17 Thread Sree Vaddi (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sree Vaddi updated KAFKA-1874:
--
Attachment: Screen Shot 2015-01-17 at 3.14.33 PM.png

screenshot of the compilation error.


> missing import util.parsing.json.JSON
> -
>
> Key: KAFKA-1874
> URL: https://issues.apache.org/jira/browse/KAFKA-1874
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Affects Versions: 0.8.2
> Environment: Mac OSX Yosemite
> Oracle JDK 1.7.0_72
> eclipse Mars M4
> Scala 2.11.5
>Reporter: Sree Vaddi
>  Labels: class, missing, scala
> Fix For: 0.8.2
>
> Attachments: Screen Shot 2015-01-17 at 3.14.33 PM.png
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> core project
> main scala folder
> kafka.utils.Json.scala file
> line#21
> import util.parsing.json.JSON
> this class is missing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (KAFKA-1874) missing import util.parsing.json.JSON

2015-01-17 Thread Sree Vaddi (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281588#comment-14281588
 ] 

Sree Vaddi edited comment on KAFKA-1874 at 1/17/15 11:17 PM:
-

[~omkreddy]
screenshot of the compilation error.



was (Author: sreevaddi):
screenshot of the compilation error.


> missing import util.parsing.json.JSON
> -
>
> Key: KAFKA-1874
> URL: https://issues.apache.org/jira/browse/KAFKA-1874
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Affects Versions: 0.8.2
> Environment: Mac OSX Yosemite
> Oracle JDK 1.7.0_72
> eclipse Mars M4
> Scala 2.11.5
>Reporter: Sree Vaddi
>  Labels: class, missing, scala
> Fix For: 0.8.2
>
> Attachments: Screen Shot 2015-01-17 at 3.14.33 PM.png
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> core project
> main scala folder
> kafka.utils.Json.scala file
> line#21
> import util.parsing.json.JSON
> this class is missing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (KAFKA-1867) liveBroker list not updated on a cluster with no topics

2015-01-17 Thread Sriharsha Chintalapani (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sriharsha Chintalapani updated KAFKA-1867:
--
Attachment: KAFKA-1867.patch

> liveBroker list not updated on a cluster with no topics
> ---
>
> Key: KAFKA-1867
> URL: https://issues.apache.org/jira/browse/KAFKA-1867
> Project: Kafka
>  Issue Type: Bug
>Reporter: Jun Rao
> Fix For: 0.8.3
>
> Attachments: KAFKA-1867.patch
>
>
> Currently, when there is no topic in a cluster, the controller doesn't send 
> any UpdateMetadataRequest to the broker when it starts up. As a result, the 
> liveBroker list in metadataCache is empty. This means that we will return 
> incorrect broker list in TopicMetatadataResponse.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Review Request 30007: Patch for KAFKA-1867

2015-01-17 Thread Sriharsha Chintalapani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30007/
---

Review request for kafka.


Bugs: KAFKA-1867
https://issues.apache.org/jira/browse/KAFKA-1867


Repository: kafka


Description
---

KAFKA-1867. liveBroker list is not updated on a cluster with no topics.


Diffs
-

  core/src/main/scala/kafka/controller/ControllerChannelManager.scala 
eb492f00449744bc8d63f55b393e2a1659d38454 
  core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 
420a1dd30264c72704cc383a4161034c7922177d 
  core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 
5b93239cdc26b5be7696f4e7863adb9fbe5f0ed5 

Diff: https://reviews.apache.org/r/30007/diff/


Testing
---


Thanks,

Sriharsha Chintalapani



[jira] [Updated] (KAFKA-1867) liveBroker list not updated on a cluster with no topics

2015-01-17 Thread Sriharsha Chintalapani (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sriharsha Chintalapani updated KAFKA-1867:
--
Assignee: Sriharsha Chintalapani
  Status: Patch Available  (was: Open)

> liveBroker list not updated on a cluster with no topics
> ---
>
> Key: KAFKA-1867
> URL: https://issues.apache.org/jira/browse/KAFKA-1867
> Project: Kafka
>  Issue Type: Bug
>Reporter: Jun Rao
>Assignee: Sriharsha Chintalapani
> Fix For: 0.8.3
>
> Attachments: KAFKA-1867.patch
>
>
> Currently, when there is no topic in a cluster, the controller doesn't send 
> any UpdateMetadataRequest to the broker when it starts up. As a result, the 
> liveBroker list in metadataCache is empty. This means that we will return 
> incorrect broker list in TopicMetatadataResponse.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1867) liveBroker list not updated on a cluster with no topics

2015-01-17 Thread Sriharsha Chintalapani (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281592#comment-14281592
 ] 

Sriharsha Chintalapani commented on KAFKA-1867:
---

Created reviewboard https://reviews.apache.org/r/30007/diff/
 against branch origin/trunk

> liveBroker list not updated on a cluster with no topics
> ---
>
> Key: KAFKA-1867
> URL: https://issues.apache.org/jira/browse/KAFKA-1867
> Project: Kafka
>  Issue Type: Bug
>Reporter: Jun Rao
> Fix For: 0.8.3
>
> Attachments: KAFKA-1867.patch
>
>
> Currently, when there is no topic in a cluster, the controller doesn't send 
> any UpdateMetadataRequest to the broker when it starts up. As a result, the 
> liveBroker list in metadataCache is empty. This means that we will return 
> incorrect broker list in TopicMetatadataResponse.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1872) Update Developer Setup

2015-01-17 Thread Sree Vaddi (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281625#comment-14281625
 ] 

Sree Vaddi commented on KAFKA-1872:
---

Thank you, [~junrao].
I have added new child page.
https://cwiki.apache.org/confluence/display/KAFKA/Eclipse-Scala-Gradle-Git+Developement+Environment+Setup
 And added link to on.
https://cwiki.apache.org/confluence/display/KAFKA/Developer+Setup



> Update Developer Setup
> --
>
> Key: KAFKA-1872
> URL: https://issues.apache.org/jira/browse/KAFKA-1872
> Project: Kafka
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 0.8.2
> Environment: Mac OSX Yosemite
> eclipse Mars M4
> Gradle 2
> Scala 2
> Git
>Reporter: Sree Vaddi
>  Labels: cwiki, development_environment, eclipse, git, gradle, 
> scala, setup
> Fix For: 0.8.2
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I setup my developer environment today and came up with an updated document.
> Update the CWiki page at 
> https://cwiki.apache.org/confluence/display/KAFKA/Developer+Setup
> OR create a new page:
> Update the site page at http://kafka.apache.org/code.html
> with the one created in previous step.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (KAFKA-1872) Update Developer Setup

2015-01-17 Thread Sree Vaddi (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sree Vaddi updated KAFKA-1872:
--
Reviewer: Jun Rao
  Status: Patch Available  (was: Open)

> Update Developer Setup
> --
>
> Key: KAFKA-1872
> URL: https://issues.apache.org/jira/browse/KAFKA-1872
> Project: Kafka
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 0.8.2
> Environment: Mac OSX Yosemite
> eclipse Mars M4
> Gradle 2
> Scala 2
> Git
>Reporter: Sree Vaddi
>  Labels: cwiki, development_environment, eclipse, git, gradle, 
> scala, setup
> Fix For: 0.8.2
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I setup my developer environment today and came up with an updated document.
> Update the CWiki page at 
> https://cwiki.apache.org/confluence/display/KAFKA/Developer+Setup
> OR create a new page:
> Update the site page at http://kafka.apache.org/code.html
> with the one created in previous step.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-1872) Update Developer Setup

2015-01-17 Thread Sree Vaddi (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14281627#comment-14281627
 ] 

Sree Vaddi commented on KAFKA-1872:
---

[~junrao] I do not see an option to assign this jira to myself.  Would you 
assign it to me ? I'll go ahead and resolve it, after that.

> Update Developer Setup
> --
>
> Key: KAFKA-1872
> URL: https://issues.apache.org/jira/browse/KAFKA-1872
> Project: Kafka
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 0.8.2
> Environment: Mac OSX Yosemite
> eclipse Mars M4
> Gradle 2
> Scala 2
> Git
>Reporter: Sree Vaddi
>  Labels: cwiki, development_environment, eclipse, git, gradle, 
> scala, setup
> Fix For: 0.8.2
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I setup my developer environment today and came up with an updated document.
> Update the CWiki page at 
> https://cwiki.apache.org/confluence/display/KAFKA/Developer+Setup
> OR create a new page:
> Update the site page at http://kafka.apache.org/code.html
> with the one created in previous step.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (KAFKA-1872) Update Developer Setup

2015-01-17 Thread Jun Rao (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jun Rao updated KAFKA-1872:
---
Assignee: Sree Vaddi

> Update Developer Setup
> --
>
> Key: KAFKA-1872
> URL: https://issues.apache.org/jira/browse/KAFKA-1872
> Project: Kafka
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 0.8.2
> Environment: Mac OSX Yosemite
> eclipse Mars M4
> Gradle 2
> Scala 2
> Git
>Reporter: Sree Vaddi
>Assignee: Sree Vaddi
>  Labels: cwiki, development_environment, eclipse, git, gradle, 
> scala, setup
> Fix For: 0.8.2
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> I setup my developer environment today and came up with an updated document.
> Update the CWiki page at 
> https://cwiki.apache.org/confluence/display/KAFKA/Developer+Setup
> OR create a new page:
> Update the site page at http://kafka.apache.org/code.html
> with the one created in previous step.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)