----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29840/ -----------------------------------------------------------
(Updated Jan. 17, 2015, 3:32 p.m.) Review request for kafka. Bugs: KAFKA-1818 https://issues.apache.org/jira/browse/KAFKA-1818 Repository: kafka Description ------- KAFKA-1818 clean up code to more idiomatic scala usage Diffs ----- core/src/main/scala/kafka/utils/ReplicationUtils.scala 715767380f7c284148689fd34d4bfba51abd96a0 core/src/test/scala/unit/kafka/utils/ReplicationUtilsTest.scala 84e08557de5acdcf0a98b192feac72836ea359b8 Diff: https://reviews.apache.org/r/29840/diff/ Testing (updated) ------- This patch replaces some pattern matching on Option with calls to flatMap. Unit test added to cover both possible return values from ReplicationUtils.getLeaderIsrAndEpochForPartition. Thanks, Eric Olander