[jira] [Commented] (JSPWIKI-1146) Add AWS Kendra as a Search Provider
[ https://issues.apache.org/jira/browse/JSPWIKI-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293842#comment-17293842 ] Julien Masnada commented on JSPWIKI-1146: - Hello [~juanpablo] It seems that I can not edit the documentation. I'll follow the issue about the SpamFilter and the next release. Hopefully I can move the Dockerfile and the corresponding image there once it is solved. As for the PR I created PR [46](https://github.com/apache/jspwiki/pull/46) in Github. Tell me if something is missing > Add AWS Kendra as a Search Provider > --- > > Key: JSPWIKI-1146 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1146 > Project: JSPWiki > Issue Type: New Feature > Components: Search >Affects Versions: 2.11.0-M8 >Reporter: Julien Masnada >Priority: Minor > Labels: features, pull-request-available > Attachments: KendraSearchProvider.zip > > > We use AWS Kendra a central search tool in our organization to provide a > search result that can span different Data Source (DB, Sharepoint, etc). > Since we have a lot of documents in our Wiki, it is interesting for us to be > able to index (in Kendra) and search pages and attachments from our wiki. > Furthermore it is important to be able to search in attachments that are in > PDF / Word / PPT or HTML format also. > We have implemented a SearchProvider that does the job of indexing and > returning search result. The code is available in > [https://github.com/rostskadat/jspwiki] > Some further documentation is available in the README. > I would appreciate if you could direct me toward a document explaining the > process for requesting the inclusion of this feature > Thanks > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [jspwiki] rostskadat opened a new pull request #46: Add AWS Kendra as a Search Provider
rostskadat opened a new pull request #46: URL: https://github.com/apache/jspwiki/pull/46 We use AWS Kendra a central search tool in our organization to provide a search result that can span different Data Source (DB, Sharepoint, etc). Since we have a lot of documents in our Wiki, it is interesting for us to be able to index (in Kendra) and search pages and attachments from our wiki. Furthermore it is important to be able to search in attachments that are in PDF / Word / PPT or HTML format also. We have implemented a SearchProvider that does the job of indexing and returning search result. The code is available in https://github.com/rostskadat/jspwiki Some further documentation is available in the README. I would appreciate if you could direct me toward a document explaining the process for requesting the inclusion of this feature Thanks PS: This issue is tracked by [JSPWIKI-1146](https://issues.apache.org/jira/browse/JSPWIKI-1146) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jspwiki] takalat commented on a change in pull request #44: JSPWIKI-1117
takalat commented on a change in pull request #44: URL: https://github.com/apache/jspwiki/pull/44#discussion_r585901733 ## File path: jspwiki-war/src/main/webapp/templates/default/commonheader.jsp ## @@ -156,4 +177,76 @@ String.I18N.PREFIX = "javascript."; src="" > + + +<%-- Support for cookie acceptance --%> + +
[GitHub] [jspwiki] takalat commented on a change in pull request #44: JSPWIKI-1117
takalat commented on a change in pull request #44:
URL: https://github.com/apache/jspwiki/pull/44#discussion_r585901825
##
File path:
jspwiki-main/src/main/java/org/apache/wiki/preferences/Preferences.java
##
@@ -125,19 +133,21 @@ public static void reloadPreferences( final PageContext
pageContext ) {
* @param request
* @param prefs The default hashmap of preferences
*/
- private static void parseJSONPreferences( final HttpServletRequest
request, final Preferences prefs ) {
-final String prefVal = TextUtil.urlDecodeUTF8(
HttpUtil.retrieveCookieValue( request, "JSPWikiUserPrefs" ) );
-if( prefVal != null ) {
+ private static void parseJSONPreferences( final Preferences prefs,
final String prefVal ) {
Review comment:
I assume this meant only changing signature to package scope. Changed
method modifier to default modifier in the latest commit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
