[PATCH 1/1] examples/ipsec-secgw: resolve segfault for IPv6 packets

[Rakesh Kudurumalla]

While running ipsec-secgw application if IPV6 rules are not
configured in ipsec configuration lpm look up fails and
destination port is updated as BAD_PORT.During process_packet
ethernet_hdr is updated resulting in crash due out of bound.
This patch fixes the same.
Fixes: 6eb3ba03995c ("examples/ipsec-secgw: support poll mode NEON LPM lookup")

Signed-off-by: Rakesh Kudurumalla 
---
 examples/ipsec-secgw/ipsec_neon.h | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/examples/ipsec-secgw/ipsec_neon.h 
b/examples/ipsec-secgw/ipsec_neon.h
index 8b93b4b52e..fc04000336 100644
--- a/examples/ipsec-secgw/ipsec_neon.h
+++ b/examples/ipsec-secgw/ipsec_neon.h
@@ -23,6 +23,7 @@ processx4_step3(struct rte_mbuf *pkts[FWDSTEP], uint16_t 
dst_port[FWDSTEP],
uint32x4_t ve[FWDSTEP];
uint32_t *p[FWDSTEP];
struct rte_mbuf *pkt;
+   uint16_t port;
uint32_t val;
uint8_t i;
 
@@ -34,7 +35,8 @@ processx4_step3(struct rte_mbuf *pkts[FWDSTEP], uint16_t 
dst_port[FWDSTEP],
*l_pkt |= 1;
 
p[i] = rte_pktmbuf_mtod(pkt, uint32_t *);
-   ve[i] = vreinterpretq_u32_s32(val_eth[dst_port[i]]);
+   port = (dst_port[i] == BAD_PORT) ? 0 : dst_port[i];
+   ve[i] = vreinterpretq_u32_s32(val_eth[port]);
te[i] = vld1q_u32(p[i]);
 
/* Update last 4 bytes */
@@ -76,6 +78,7 @@ process_packet(struct rte_mbuf *pkt, uint16_t *dst_port, 
uint64_t tx_offloads,
 {
struct rte_ether_hdr *eth_hdr;
uint32x4_t te, ve;
+   uint16_t port;
uint32_t val;
 
/* Check if it is a large packet */
@@ -85,7 +88,8 @@ process_packet(struct rte_mbuf *pkt, uint16_t *dst_port, 
uint64_t tx_offloads,
eth_hdr = rte_pktmbuf_mtod(pkt, struct rte_ether_hdr *);
 
te = vld1q_u32((uint32_t *)eth_hdr);
-   ve = vreinterpretq_u32_s32(val_eth[dst_port[0]]);
+   port = (dst_port[0] == BAD_PORT) ? 0 : dst_port[0];
+   ve = vreinterpretq_u32_s32(val_eth[port]);
 
val = vgetq_lane_u32(te, 3);
 #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
-- 
2.25.1

Re: [PATCH] acl: fix build with GCC 15 on aarch64

[Bruce Richardson]

On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote:
> Caught in OBS for Fedora Rawhide on aarch64:
> 
> [  198s] In file included from ../lib/acl/acl_run_neon.h:7,
> [  198s]  from ../lib/acl/acl_run_neon.c:5:
> [  198s] In function ‘alloc_completion’,
> [  198s] inlined from ‘acl_start_next_trie’ at
>   ../lib/acl/acl_run.h:140:24,
> [  198s] inlined from ‘search_neon_4.isra’ at
>   ../lib/acl/acl_run_neon.h:239:20:
> [  198s] ../lib/acl/acl_run.h:93:25: error: ‘cmplt’ may be used
>   uninitialized [-Werror=maybe-uninitialized]
> [  198s]93 | if (p[n].count == 0) {
> [  198s]   | ^~
> [  198s] ../lib/acl/acl_run_neon.h: In function ‘search_neon_4.isra’:
> [  198s] ../lib/acl/acl_run_neon.h:230:27: note: ‘cmplt’ declared here
> [  198s]   230 | struct completion cmplt[4];
> [  198s]   |   ^
> 
> The code was resetting sequentially cmpl[].count at the exact index that
> later call to alloc_completion uses.
> While this code seems correct, GCC 15 does not understand this (probably
> when applying some optimisations).
> 
> Instead, reset cmpl[].count all at once in acl_set_flow, and cleanup the
> various vectorized implementations accordingly.
> 
> Bugzilla ID: 1678
> Cc: sta...@dpdk.org
> 
> Signed-off-by: David Marchand 
> ---
>  lib/acl/acl_run.h | 5 +
>  lib/acl/acl_run_altivec.h | 8 ++--
>  lib/acl/acl_run_avx2.h| 4 +---
>  lib/acl/acl_run_neon.h| 8 ++--
>  lib/acl/acl_run_scalar.c  | 4 +---
>  lib/acl/acl_run_sse.h | 8 ++--
>  6 files changed, 13 insertions(+), 24 deletions(-)
> 
> diff --git a/lib/acl/acl_run.h b/lib/acl/acl_run.h
> index 7f092413cd..9fd3e60021 100644
> --- a/lib/acl/acl_run.h
> +++ b/lib/acl/acl_run.h
> @@ -176,6 +176,8 @@ acl_set_flow(struct acl_flow_data *flows, struct 
> completion *cmplt,
>   uint32_t cmplt_size, const uint8_t **data, uint32_t *results,
>   uint32_t data_num, uint32_t categories, const uint64_t *trans)
>  {
> + unsigned int i;
> +
>   flows->num_packets = 0;
>   flows->started = 0;
>   flows->trie = 0;
> @@ -187,6 +189,9 @@ acl_set_flow(struct acl_flow_data *flows, struct 
> completion *cmplt,
>   flows->data = data;
>   flows->results = results;
>   flows->trans = trans;
> +
> + for (i = 0; i < cmplt_size; i++)
> + cmplt[i].count = 0;
>  }

Minor nit, but since we are using c11 standard, is it not better to declare
"i" inside the "for" statement. Keeps diffs simpler for adding/removing
code, I think.

For the rest of the code, I need to take a bit more time reviewing to be
sure I understand the change. I'll try and get to it later.

/Bruce

>  
>  typedef void (*resolve_priority_t)
> diff --git a/lib/acl/acl_run_altivec.h b/lib/acl/acl_run_altivec.h
> index 2d398ffded..d5ccdb94f0 100644
> --- a/lib/acl/acl_run_altivec.h
> +++ b/lib/acl/acl_run_altivec.h
> @@ -199,10 +199,8 @@ search_altivec_8(const struct rte_acl_ctx *ctx, const 
> uint8_t **data,
>   acl_set_flow(&flows, cmplt, RTE_DIM(cmplt), data, results,
>   total_packets, categories, ctx->trans_table);
>  
> - for (n = 0; n < MAX_SEARCHES_ALTIVEC8; n++) {
> - cmplt[n].count = 0;
> + for (n = 0; n < MAX_SEARCHES_ALTIVEC8; n++)
>   index_array[n] = acl_start_next_trie(&flows, parms, n, ctx);
> - }
>

[PATCH] app/dma-perf: fix infinite loop

[Dengdui Huang]

When a core that is not used by the rte is specified in the config
for testing, the problem of infinite loop occurs. This patch fix it
by adding a check for lcore_id.

Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test")
Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
---
 app/test-dma-perf/main.c | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c
index 0586b3e1d0..1365456dd1 100644
--- a/app/test-dma-perf/main.c
+++ b/app/test-dma-perf/main.c
@@ -523,7 +523,7 @@ main(int argc, char *argv[])
 {
int ret;
uint16_t case_nb;
-   uint32_t i, nb_lcores;
+   uint32_t i, j, nb_lcores, lcore;
pid_t cpid, wpid;
int wstatus;
char args[MAX_EAL_PARAM_NB][MAX_EAL_PARAM_LEN];
@@ -603,6 +603,12 @@ main(int argc, char *argv[])
if (nb_lcores < 2)
rte_exit(EXIT_FAILURE,
"There should be at least 2 worker 
lcores.\n");
+   for (j = 0; j < test_cases[i].num_worker; j++) {
+   lcore = 
test_cases[i].dma_config[j].lcore_dma_map.lcore;
+   if (!rte_lcore_has_role(lcore, ROLE_RTE))
+   rte_exit(EXIT_FAILURE,
+"Worker lcore %u not enabled 
in EAL\n", lcore);
+   }
 
fd = fopen(rst_path_ptr, "a");
if (!fd) {
-- 
2.33.0

[PATCH 1/2] eal: fix uncheck worker ID

[Dengdui Huang]

The worker_id may come from user input.
So it is necessary to verify it.

Fixes: a95d70547c57 ("eal: factorize lcore main loop")
Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
---
 lib/eal/common/eal_common_launch.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/eal/common/eal_common_launch.c 
b/lib/eal/common/eal_common_launch.c
index 5320c3bd3c..76313d5cdf 100644
--- a/lib/eal/common/eal_common_launch.c
+++ b/lib/eal/common/eal_common_launch.c
@@ -35,6 +35,9 @@ rte_eal_remote_launch(lcore_function_t *f, void *arg, 
unsigned int worker_id)
 {
int rc = -EBUSY;
 
+   if (!rte_lcore_has_role(worker_id, ROLE_RTE))
+   return -EINVAL;
+
/* Check if the worker is in 'WAIT' state. Use acquire order
 * since 'state' variable is used as the guard variable.
 */
-- 
2.33.0

[PATCH v2 2/2] app/dma-perf: fix infinite loop

[Dengdui Huang]

When a core that is not used by the rte is specified in the config
for testing, the problem of infinite loop occurs. This patch fix it
by adding a check for lcore_id.

Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test")
Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
---
 app/test-dma-perf/main.c | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c
index 0586b3e1d0..1365456dd1 100644
--- a/app/test-dma-perf/main.c
+++ b/app/test-dma-perf/main.c
@@ -523,7 +523,7 @@ main(int argc, char *argv[])
 {
int ret;
uint16_t case_nb;
-   uint32_t i, nb_lcores;
+   uint32_t i, j, nb_lcores, lcore;
pid_t cpid, wpid;
int wstatus;
char args[MAX_EAL_PARAM_NB][MAX_EAL_PARAM_LEN];
@@ -603,6 +603,12 @@ main(int argc, char *argv[])
if (nb_lcores < 2)
rte_exit(EXIT_FAILURE,
"There should be at least 2 worker 
lcores.\n");
+   for (j = 0; j < test_cases[i].num_worker; j++) {
+   lcore = 
test_cases[i].dma_config[j].lcore_dma_map.lcore;
+   if (!rte_lcore_has_role(lcore, ROLE_RTE))
+   rte_exit(EXIT_FAILURE,
+"Worker lcore %u not enabled 
in EAL\n", lcore);
+   }
 
fd = fopen(rst_path_ptr, "a");
if (!fd) {
-- 
2.33.0

Re: DPDK for rust

[Etelson, Gregory]

Hello Morten,

Thank you for raising these questions !



Do we want the DPDK project itself to support rust?
Or should parts of this be a DPDK hosted project, like grout?


Rust packages management is different.
Also DPDK Rust code will eventually provide a different API.
At this stage, DPDK hosted project looks like a good idea.



I don't object to supporting rust, quite the opposite. I'm only trying to think 
ahead...

I would hate to see a DPDK patch being rejected because it doesn't support 
rust, or needs additional work to not break DPDK for rust.

And how about the CI - do we want it to test "DPDK for rust", and how many 
resources are we going to put into this?



Regards,
Gregory

[PATCH v4] raw/cnxk_gpio: switch to character based GPIO interface

[Tomasz Duszynski]

The direct passthrough interrupt mechanism, which allowed bypassing the
kernel, was obscure and is no longer supported. So this driver won't
work with latest SDK kernels. Additionally, the sysfs GPIO control
interface has been deprecated by Linux kernel itself.

That said, this change updates the PMD to use the current GPIO interface
ensuring compatibility with current kernel standards while improving
maintainability and security.

Signed-off-by: Tomasz Duszynski 
---
v2:
- compile conditionally based on GPIO_V2_PRESENT
v3:
- fix compilation issues due to missing structure member
- quiesce compiler warnings about maybe unused parameters
v4:
- rename GPIO_V2_PRESENT to CNXK_GPIO_V2_PRESENT to indicate
  it's PMD specific

 doc/guides/rawdevs/cnxk_gpio.rst   |  37 +-
 drivers/raw/cnxk_gpio/cnxk_gpio.c  | 525 -
 drivers/raw/cnxk_gpio/cnxk_gpio.h  |  17 +-
 drivers/raw/cnxk_gpio/cnxk_gpio_irq.c  | 216 -
 drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c | 238 ++
 drivers/raw/cnxk_gpio/meson.build  |   1 -
 drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h  |  64 ++-
 7 files changed, 445 insertions(+), 653 deletions(-)
 delete mode 100644 drivers/raw/cnxk_gpio/cnxk_gpio_irq.c

diff --git a/doc/guides/rawdevs/cnxk_gpio.rst b/doc/guides/rawdevs/cnxk_gpio.rst
index 954d3b8905..8084dd4adb 100644
--- a/doc/guides/rawdevs/cnxk_gpio.rst
+++ b/doc/guides/rawdevs/cnxk_gpio.rst
@@ -6,31 +6,20 @@ Marvell CNXK GPIO Driver

 CNXK GPIO PMD configures and manages GPIOs available on the system using
 standard enqueue/dequeue mechanism offered by raw device abstraction. PMD 
relies
-both on standard sysfs GPIO interface provided by the Linux kernel and GPIO
-kernel driver custom interface allowing one to install userspace interrupt
-handlers.
+on standard kernel GPIO character device interface.

 Features
 

 Following features are available:

-- export/unexport a GPIO
-- read/write specific value from/to exported GPIO
+- read/write specific value from/to GPIO
 - set GPIO direction
 - set GPIO edge that triggers interrupt
 - set GPIO active low
 - register interrupt handler for specific GPIO
 - multiprocess aware

-Requirements
-
-
-PMD relies on modified kernel GPIO driver which exposes ``ioctl()`` interface
-for installing interrupt handlers for low latency signal processing.
-
-Driver is shipped with Marvell SDK.
-
 Limitations
 ---

@@ -43,20 +32,20 @@ Device Setup
 CNXK GPIO PMD binds to virtual device which gets created by passing
 `--vdev=cnxk_gpio,gpiochip=` command line to EAL. `gpiochip` parameter
 tells PMD which GPIO controller should be used. Available controllers are
-available under `/sys/class/gpio`. For further details on how Linux represents
-GPIOs in userspace please refer to
-`sysfs.txt `_.
+`/dev/gpiochipN` character devices. For further details on
+how Linux represents GPIOs in userspace please refer to
+`gpio-cdev `_.

 If `gpiochip=` was omitted then first gpiochip from the alphabetically
 sort list of available gpiochips is used.

 .. code-block:: console

-   $ ls /sys/class/gpio
-   export gpiochip448 unexport
+   $ ls /dev/gpiochip*
+   /dev/gpiochip0

 In above scenario only one GPIO controller is present hence
-`--vdev=cnxk_gpio,gpiochip=448` should be passed to EAL.
+`--vdev=cnxk_gpio,gpiochip=0` should be passed to EAL.

 Before performing actual data transfer one needs to call
 ``rte_rawdev_queue_count()`` followed by ``rte_rawdev_queue_conf_get()``. The
@@ -65,7 +54,7 @@ being controllable or not. Thus it is user responsibility to 
pick the proper
 ones. The latter call simply returns queue capacity.

 In order to allow using only subset of available GPIOs `allowlist` PMD param 
may
-be used. For example passing 
`--vdev=cnxk_gpio,gpiochip=448,allowlist=[0,1,2,3]`
+be used. For example passing `--vdev=cnxk_gpio,gpiochip=0,allowlist=[0,1,2,3]`
 to EAL will deny using all GPIOs except those specified explicitly in the
 `allowlist`.

@@ -179,12 +168,12 @@ Request interrupt

 Message is used to install custom interrupt handler.

-Message must have type set to ``CNXK_GPIO_MSG_TYPE_REGISTER_IRQ``.
+Message must have type set to ``CNXK_GPIO_MSG_TYPE_REGISTER_IRQ2``.

-Payload needs to be set to ``struct cnxk_gpio_irq`` which describes interrupt
+Payload needs to be set to ``struct cnxk_gpio_irq2`` which describes interrupt
 being requested.

-Consider using ``rte_pmd_gpio_register_gpio()`` wrapper.
+Consider using ``rte_pmd_gpio_register_irq2()`` wrapper.

 Free interrupt
 ~~
@@ -193,7 +182,7 @@ Message is used to remove installed interrupt handler.

 Message must have type set to ``CNXK_GPIO_MSG_TYPE_UNREGISTER_IRQ``.

-Consider using ``rte_pmd_gpio_unregister_gpio()`` wrapper.
+Consider using ``rte_pmd_gpio_unregister_irq()`` wrapper.

 Self test
 -
diff --git a/drivers/raw/cn

[PATCH 2/2] app/dma-perf: fix infinite loop

[Dengdui Huang]

When a core that is not used by the rte is specified in the config
for testing, the problem of infinite loop occurs. This patch fix it
by adding a check for lcore_id.

Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test")
Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
---
 app/test-dma-perf/main.c | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c
index 0586b3e1d0..1365456dd1 100644
--- a/app/test-dma-perf/main.c
+++ b/app/test-dma-perf/main.c
@@ -523,7 +523,7 @@ main(int argc, char *argv[])
 {
int ret;
uint16_t case_nb;
-   uint32_t i, nb_lcores;
+   uint32_t i, j, nb_lcores, lcore;
pid_t cpid, wpid;
int wstatus;
char args[MAX_EAL_PARAM_NB][MAX_EAL_PARAM_LEN];
@@ -603,6 +603,12 @@ main(int argc, char *argv[])
if (nb_lcores < 2)
rte_exit(EXIT_FAILURE,
"There should be at least 2 worker 
lcores.\n");
+   for (j = 0; j < test_cases[i].num_worker; j++) {
+   lcore = 
test_cases[i].dma_config[j].lcore_dma_map.lcore;
+   if (!rte_lcore_has_role(lcore, ROLE_RTE))
+   rte_exit(EXIT_FAILURE,
+"Worker lcore %u not enabled 
in EAL\n", lcore);
+   }
 
fd = fopen(rst_path_ptr, "a");
if (!fd) {
-- 
2.33.0

RE: [PATCH] acl: fix build with GCC 15 on aarch64

[Konstantin Ananyev]

> 
> Caught in OBS for Fedora Rawhide on aarch64:
> 
> [  198s] In file included from ../lib/acl/acl_run_neon.h:7,
> [  198s]  from ../lib/acl/acl_run_neon.c:5:
> [  198s] In function ‘alloc_completion’,
> [  198s] inlined from ‘acl_start_next_trie’ at
>   ../lib/acl/acl_run.h:140:24,
> [  198s] inlined from ‘search_neon_4.isra’ at
>   ../lib/acl/acl_run_neon.h:239:20:
> [  198s] ../lib/acl/acl_run.h:93:25: error: ‘cmplt’ may be used
>   uninitialized [-Werror=maybe-uninitialized]
> [  198s]93 | if (p[n].count == 0) {
> [  198s]   | ^~
> [  198s] ../lib/acl/acl_run_neon.h: In function ‘search_neon_4.isra’:
> [  198s] ../lib/acl/acl_run_neon.h:230:27: note: ‘cmplt’ declared here
> [  198s]   230 | struct completion cmplt[4];
> [  198s]   |   ^
> 
> The code was resetting sequentially cmpl[].count at the exact index that
> later call to alloc_completion uses.
> While this code seems correct, GCC 15 does not understand this (probably
> when applying some optimisations).
> 
> Instead, reset cmpl[].count all at once in acl_set_flow, and cleanup the
> various vectorized implementations accordingly.
> 
> Bugzilla ID: 1678
> Cc: sta...@dpdk.org
> 
> Signed-off-by: David Marchand 
> ---
>  lib/acl/acl_run.h | 5 +
>  lib/acl/acl_run_altivec.h | 8 ++--
>  lib/acl/acl_run_avx2.h| 4 +---
>  lib/acl/acl_run_neon.h| 8 ++--
>  lib/acl/acl_run_scalar.c  | 4 +---
>  lib/acl/acl_run_sse.h | 8 ++--
>  6 files changed, 13 insertions(+), 24 deletions(-)
> 
> diff --git a/lib/acl/acl_run.h b/lib/acl/acl_run.h
> index 7f092413cd..9fd3e60021 100644
> --- a/lib/acl/acl_run.h
> +++ b/lib/acl/acl_run.h
> @@ -176,6 +176,8 @@ acl_set_flow(struct acl_flow_data *flows, struct 
> completion *cmplt,
>   uint32_t cmplt_size, const uint8_t **data, uint32_t *results,
>   uint32_t data_num, uint32_t categories, const uint64_t *trans)
>  {
> + unsigned int i;
> +
>   flows->num_packets = 0;
>   flows->started = 0;
>   flows->trie = 0;
> @@ -187,6 +189,9 @@ acl_set_flow(struct acl_flow_data *flows, struct 
> completion *cmplt,
>   flows->data = data;
>   flows->results = results;
>   flows->trans = trans;
> +
> + for (i = 0; i < cmplt_size; i++)
> + cmplt[i].count = 0;
>  }
> 
>  typedef void (*resolve_priority_t)
> diff --git a/lib/acl/acl_run_altivec.h b/lib/acl/acl_run_altivec.h
> index 2d398ffded..d5ccdb94f0 100644
> --- a/lib/acl/acl_run_altivec.h
> +++ b/lib/acl/acl_run_altivec.h
> @@ -199,10 +199,8 @@ search_altivec_8(const struct rte_acl_ctx *ctx, const 
> uint8_t **data,
>   acl_set_flow(&flows, cmplt, RTE_DIM(cmplt), data, results,
>   total_packets, categories, ctx->trans_table);
> 
> - for (n = 0; n < MAX_SEARCHES_ALTIVEC8; n++) {
> - cmplt[n].count = 0;
> + for (n = 0; n < MAX_SEARCHES_ALTIVEC8; n++)
>   index_array[n] = acl_start_next_trie(&flows, parms, n, ctx);
> - }
> 
>/* Check for any matches. */
>   acl_match_check_x4(0, ctx, parms, &flows, (uint64_t *)&index_array[0]);
> @@ -270,10 +268,8 @@ search_altivec_4(const struct rte_acl_ctx *ctx, const 
> uint8_t **data,
>   acl_set_flow(&flows, cmplt, RTE_DIM(cmplt), data, results,
>   total_packets, categories, ctx->trans_table);
> 
> - for (n = 0; n < MAX_SEARCHES_ALTIVEC4; n++) {
> - cmplt[n].count = 0;
> + for (n = 0; n < MAX_SEARCHES_ALTIVEC4; n++)
>   index_array[n] = acl_start_next_trie(&flows, parms, n, ctx);
> - }
> 
>   /* Check for any matches. */
>   acl_match_check_x4(0, ctx, parms, &flows, index_array);
> diff --git a/lib/acl/acl_run_avx2.h b/lib/acl/acl_run_avx2.h
> index 0b8967f22e..e069fb85b2 100644
> --- a/lib/acl/acl_run_avx2.h
> +++ b/lib/acl/acl_run_avx2.h
> @@ -171,10 +171,8 @@ search_avx2x16(const struct rte_acl_ctx *ctx, const 
> uint8_t **data,
>   acl_set_flow(&flows, cmplt, RTE_DIM(cmplt), data, results,
>   total_packets, categories, ctx->trans_table);
> 
> - for (n = 0; n < RTE_DIM(cmplt); n++) {
> - cmplt[n].count = 0;
> + for (n = 0; n < RTE_DIM(cmplt); n++)
>   index_array[n] = acl_start_next_trie(&flows, parms, n, ctx);
> - }
> 
>   t0 = _mm256_set_epi64x(index_array[5], index_array[4],
>   index_array[1], index_array[0]);
> diff --git a/lib/acl/acl_run_neon.h b/lib/acl/acl_run_neon.h
> index 63074f871d..3b9bd0cc39 100644
> --- a/lib/acl/acl_run_neon.h
> +++ b/lib/acl/acl_run_neon.h
> @@ -172,10 +172,8 @@ search_neon_8(const struct rte_acl_ctx *ctx, const 
> uint8_t **data,
>   acl_set_flow(&flows, cmplt, RTE_DIM(cmplt), data, results,
>total_packets, categories, ctx->trans_table);
> 
> - for (n = 0; n < 8; n++) {
> - cmplt[n].count = 0;
> + for (n = 0; n < 8; n++)
>   index_array[n] = acl_st

Re: [PATCH] acl: fix build with GCC 15 on aarch64

[David Marchand]

On Thu, Mar 27, 2025 at 9:55 AM Bruce Richardson
 wrote:
>
> On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote:
> > Caught in OBS for Fedora Rawhide on aarch64:
> >
> > [  198s] In file included from ../lib/acl/acl_run_neon.h:7,
> > [  198s]  from ../lib/acl/acl_run_neon.c:5:
> > [  198s] In function ‘alloc_completion’,
> > [  198s] inlined from ‘acl_start_next_trie’ at
> >   ../lib/acl/acl_run.h:140:24,
> > [  198s] inlined from ‘search_neon_4.isra’ at
> >   ../lib/acl/acl_run_neon.h:239:20:
> > [  198s] ../lib/acl/acl_run.h:93:25: error: ‘cmplt’ may be used
> >   uninitialized [-Werror=maybe-uninitialized]
> > [  198s]93 | if (p[n].count == 0) {
> > [  198s]   | ^~
> > [  198s] ../lib/acl/acl_run_neon.h: In function ‘search_neon_4.isra’:
> > [  198s] ../lib/acl/acl_run_neon.h:230:27: note: ‘cmplt’ declared here
> > [  198s]   230 | struct completion cmplt[4];
> > [  198s]   |   ^
> >
> > The code was resetting sequentially cmpl[].count at the exact index that
> > later call to alloc_completion uses.
> > While this code seems correct, GCC 15 does not understand this (probably
> > when applying some optimisations).
> >
> > Instead, reset cmpl[].count all at once in acl_set_flow, and cleanup the
> > various vectorized implementations accordingly.
> >
> > Bugzilla ID: 1678
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: David Marchand 
> > ---
> >  lib/acl/acl_run.h | 5 +
> >  lib/acl/acl_run_altivec.h | 8 ++--
> >  lib/acl/acl_run_avx2.h| 4 +---
> >  lib/acl/acl_run_neon.h| 8 ++--
> >  lib/acl/acl_run_scalar.c  | 4 +---
> >  lib/acl/acl_run_sse.h | 8 ++--
> >  6 files changed, 13 insertions(+), 24 deletions(-)
> >
> > diff --git a/lib/acl/acl_run.h b/lib/acl/acl_run.h
> > index 7f092413cd..9fd3e60021 100644
> > --- a/lib/acl/acl_run.h
> > +++ b/lib/acl/acl_run.h
> > @@ -176,6 +176,8 @@ acl_set_flow(struct acl_flow_data *flows, struct 
> > completion *cmplt,
> >   uint32_t cmplt_size, const uint8_t **data, uint32_t *results,
> >   uint32_t data_num, uint32_t categories, const uint64_t *trans)
> >  {
> > + unsigned int i;
> > +
> >   flows->num_packets = 0;
> >   flows->started = 0;
> >   flows->trie = 0;
> > @@ -187,6 +189,9 @@ acl_set_flow(struct acl_flow_data *flows, struct 
> > completion *cmplt,
> >   flows->data = data;
> >   flows->results = results;
> >   flows->trans = trans;
> > +
> > + for (i = 0; i < cmplt_size; i++)
> > + cmplt[i].count = 0;
> >  }
>
> Minor nit, but since we are using c11 standard, is it not better to declare
> "i" inside the "for" statement. Keeps diffs simpler for adding/removing
> code, I think.

I still have this (bad) habit but yes, it looks nicer with declaring
in for() itself.


-- 
David Marchand

RE: [PATCH] acl: fix build with GCC 15 on aarch64

[Konstantin Ananyev]

> -Original Message-
> From: David Marchand 
> Sent: Thursday, March 27, 2025 10:37 AM
> To: Bruce Richardson 
> Cc: dev@dpdk.org; bl...@debian.org; sta...@dpdk.org; Konstantin Ananyev 
> ; David Christensen
> ; Wathsala Vithanage 
> Subject: Re: [PATCH] acl: fix build with GCC 15 on aarch64
> 
> On Thu, Mar 27, 2025 at 9:55 AM Bruce Richardson
>  wrote:
> >
> > On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote:
> > > Caught in OBS for Fedora Rawhide on aarch64:
> > >
> > > [  198s] In file included from ../lib/acl/acl_run_neon.h:7,
> > > [  198s]  from ../lib/acl/acl_run_neon.c:5:
> > > [  198s] In function ‘alloc_completion’,
> > > [  198s] inlined from ‘acl_start_next_trie’ at
> > >   ../lib/acl/acl_run.h:140:24,
> > > [  198s] inlined from ‘search_neon_4.isra’ at
> > >   ../lib/acl/acl_run_neon.h:239:20:
> > > [  198s] ../lib/acl/acl_run.h:93:25: error: ‘cmplt’ may be used
> > >   uninitialized [-Werror=maybe-uninitialized]
> > > [  198s]93 | if (p[n].count == 0) {
> > > [  198s]   | ^~
> > > [  198s] ../lib/acl/acl_run_neon.h: In function ‘search_neon_4.isra’:
> > > [  198s] ../lib/acl/acl_run_neon.h:230:27: note: ‘cmplt’ declared here
> > > [  198s]   230 | struct completion cmplt[4];
> > > [  198s]   |   ^
> > >
> > > The code was resetting sequentially cmpl[].count at the exact index that
> > > later call to alloc_completion uses.
> > > While this code seems correct, GCC 15 does not understand this (probably
> > > when applying some optimisations).
> > >
> > > Instead, reset cmpl[].count all at once in acl_set_flow, and cleanup the
> > > various vectorized implementations accordingly.
> > >
> > > Bugzilla ID: 1678
> > > Cc: sta...@dpdk.org
> > >
> > > Signed-off-by: David Marchand 
> > > ---
> > >  lib/acl/acl_run.h | 5 +
> > >  lib/acl/acl_run_altivec.h | 8 ++--
> > >  lib/acl/acl_run_avx2.h| 4 +---
> > >  lib/acl/acl_run_neon.h| 8 ++--
> > >  lib/acl/acl_run_scalar.c  | 4 +---
> > >  lib/acl/acl_run_sse.h | 8 ++--
> > >  6 files changed, 13 insertions(+), 24 deletions(-)
> > >
> > > diff --git a/lib/acl/acl_run.h b/lib/acl/acl_run.h
> > > index 7f092413cd..9fd3e60021 100644
> > > --- a/lib/acl/acl_run.h
> > > +++ b/lib/acl/acl_run.h
> > > @@ -176,6 +176,8 @@ acl_set_flow(struct acl_flow_data *flows, struct 
> > > completion *cmplt,
> > >   uint32_t cmplt_size, const uint8_t **data, uint32_t *results,
> > >   uint32_t data_num, uint32_t categories, const uint64_t *trans)
> > >  {
> > > + unsigned int i;
> > > +
> > >   flows->num_packets = 0;
> > >   flows->started = 0;
> > >   flows->trie = 0;
> > > @@ -187,6 +189,9 @@ acl_set_flow(struct acl_flow_data *flows, struct 
> > > completion *cmplt,
> > >   flows->data = data;
> > >   flows->results = results;
> > >   flows->trans = trans;
> > > +
> > > + for (i = 0; i < cmplt_size; i++)
> > > + cmplt[i].count = 0;
> > >  }
> >
> > Minor nit, but since we are using c11 standard, is it not better to declare
> > "i" inside the "for" statement. Keeps diffs simpler for adding/removing
> > code, I think.
> 
> I still have this (bad) habit but yes, it looks nicer with declaring
> in for() itself.

My vote would be to keep it in an old fashioned way.
Nothing is wrong in defining variable to use at the start of the function :) 
 

[PATCH v4 2/4] net/intel: use common Tx queue structure

[Shaiq Wani]

Merge in additional fields used by the idpf driver and then convert it
over to using the common Tx queue structure.

Signed-off-by: Shaiq Wani 
---
 drivers/net/intel/common/tx.h | 20 +++
 drivers/net/intel/cpfl/cpfl_ethdev.c  |  3 +-
 drivers/net/intel/cpfl/cpfl_ethdev.h  |  2 +-
 drivers/net/intel/cpfl/cpfl_rxtx.c| 26 -
 drivers/net/intel/cpfl/cpfl_rxtx.h|  3 +-
 drivers/net/intel/cpfl/cpfl_rxtx_vec_common.h |  3 +-
 drivers/net/intel/idpf/idpf_common_rxtx.c | 36 ++--
 drivers/net/intel/idpf/idpf_common_rxtx.h | 58 +++
 .../net/intel/idpf/idpf_common_rxtx_avx2.c| 12 ++--
 .../net/intel/idpf/idpf_common_rxtx_avx512.c  | 21 +++
 drivers/net/intel/idpf/idpf_common_virtchnl.c |  2 +-
 drivers/net/intel/idpf/idpf_common_virtchnl.h |  2 +-
 drivers/net/intel/idpf/idpf_ethdev.c  |  3 +-
 drivers/net/intel/idpf/idpf_rxtx.c| 21 ---
 drivers/net/intel/idpf/idpf_rxtx.h|  1 +
 drivers/net/intel/idpf/idpf_rxtx_vec_common.h |  5 +-
 16 files changed, 101 insertions(+), 117 deletions(-)

diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h
index d9cf4474fc..af32f4deda 100644
--- a/drivers/net/intel/common/tx.h
+++ b/drivers/net/intel/common/tx.h
@@ -35,6 +35,7 @@ struct ci_tx_queue {
volatile struct i40e_tx_desc *i40e_tx_ring;
volatile struct iavf_tx_desc *iavf_tx_ring;
volatile struct ice_tx_desc *ice_tx_ring;
+   volatile struct idpf_base_tx_desc *idpf_tx_ring;
volatile union ixgbe_adv_tx_desc *ixgbe_tx_ring;
};
volatile uint8_t *qtx_tail;   /* register address of tail */
@@ -98,6 +99,25 @@ struct ci_tx_queue {
uint8_t wthresh;   /**< Write-back threshold reg. */
uint8_t using_ipsec;  /**< indicates that IPsec TX 
feature is in use */
};
+   struct { /* idpf specific values */
+   volatile union {
+   struct idpf_flex_tx_sched_desc *desc_ring;
+   struct idpf_splitq_tx_compl_desc *compl_ring;
+   };
+   const struct idpf_txq_ops *idpf_ops;
+   struct ci_tx_queue *complq;
+   void **txqs;   /*only valid for split queue mode*/
+   bool q_started;   /* if tx queue has been started */
+
+   /* only valid for split queue mode */
+   uint32_t tx_start_qid;
+   uint16_t sw_nb_desc;
+   uint16_t sw_tail;
+#define IDPF_TX_CTYPE_NUM  8
+   uint16_t ctype[IDPF_TX_CTYPE_NUM];
+   uint8_t expected_gen_id;
+
+   };
};
 };
 
diff --git a/drivers/net/intel/cpfl/cpfl_ethdev.c 
b/drivers/net/intel/cpfl/cpfl_ethdev.c
index 1817221652..c94010bc51 100644
--- a/drivers/net/intel/cpfl/cpfl_ethdev.c
+++ b/drivers/net/intel/cpfl/cpfl_ethdev.c
@@ -18,6 +18,7 @@
 #include "cpfl_rxtx.h"
 #include "cpfl_flow.h"
 #include "cpfl_rules.h"
+#include "../common/tx.h"
 
 #define CPFL_REPRESENTOR   "representor"
 #define CPFL_TX_SINGLE_Q   "tx_single"
@@ -1167,7 +1168,7 @@ cpfl_hairpin_get_peer_ports(struct rte_eth_dev *dev, 
uint16_t *peer_ports,
 {
struct cpfl_vport *cpfl_vport =
(struct cpfl_vport *)dev->data->dev_private;
-   struct idpf_tx_queue *txq;
+   struct ci_tx_queue *txq;
struct idpf_rx_queue *rxq;
struct cpfl_tx_queue *cpfl_txq;
struct cpfl_rx_queue *cpfl_rxq;
diff --git a/drivers/net/intel/cpfl/cpfl_ethdev.h 
b/drivers/net/intel/cpfl/cpfl_ethdev.h
index 9a38a69194..d4e1176ab1 100644
--- a/drivers/net/intel/cpfl/cpfl_ethdev.h
+++ b/drivers/net/intel/cpfl/cpfl_ethdev.h
@@ -174,7 +174,7 @@ struct cpfl_vport {
uint16_t nb_p2p_txq;
 
struct idpf_rx_queue *p2p_rx_bufq;
-   struct idpf_tx_queue *p2p_tx_complq;
+   struct ci_tx_queue *p2p_tx_complq;
bool p2p_manual_bind;
 };
 
diff --git a/drivers/net/intel/cpfl/cpfl_rxtx.c 
b/drivers/net/intel/cpfl/cpfl_rxtx.c
index 8eed8f16d5..d7b5a660b5 100644
--- a/drivers/net/intel/cpfl/cpfl_rxtx.c
+++ b/drivers/net/intel/cpfl/cpfl_rxtx.c
@@ -11,7 +11,7 @@
 #include "cpfl_rxtx_vec_common.h"
 
 static inline void
-cpfl_tx_hairpin_descq_reset(struct idpf_tx_queue *txq)
+cpfl_tx_hairpin_descq_reset(struct ci_tx_queue *txq)
 {
uint32_t i, size;
 
@@ -26,7 +26,7 @@ cpfl_tx_hairpin_descq_reset(struct idpf_tx_queue *txq)
 }
 
 static inline void
-cpfl_tx_hairpin_complq_reset(struct idpf_tx_queue *cq)
+cpfl_tx_hairpin_complq_reset(struct ci_tx_queue *cq)
 {
uint32_t i, size;
 
@@ -320,7 +320,7 @@ static void
 cpfl_tx_queue_release(void *txq)
 {
struct cpfl_tx_queue *cpfl_txq = txq;
-   struct idpf_tx_queue *q = NULL;
+   struct ci_tx_qu

[PATCH v4 0/4] net/intel: using common functions in idpf driver

[Shaiq Wani]

reworked the drivers to use the common functions and structures
from drivers/net/intel/common.

Shaiq Wani (4):
  net/intel: align Tx queue struct field names
  net/intel: use common Tx queue structure
  net/intel: use common Tx entry structure
  net/idpf: use common Tx free fn in idpf

 drivers/net/intel/common/tx.h |  20 ++
 drivers/net/intel/cpfl/cpfl_ethdev.c  |   3 +-
 drivers/net/intel/cpfl/cpfl_ethdev.h  |   2 +-
 drivers/net/intel/cpfl/cpfl_rxtx.c|  66 ++--
 drivers/net/intel/cpfl/cpfl_rxtx.h|   3 +-
 drivers/net/intel/cpfl/cpfl_rxtx_vec_common.h |   7 +-
 drivers/net/intel/idpf/idpf_common_rxtx.c | 116 +++
 drivers/net/intel/idpf/idpf_common_rxtx.h |  69 +---
 .../net/intel/idpf/idpf_common_rxtx_avx2.c|  81 +++--
 .../net/intel/idpf/idpf_common_rxtx_avx512.c  | 324 +++---
 drivers/net/intel/idpf/idpf_common_virtchnl.c |   8 +-
 drivers/net/intel/idpf/idpf_common_virtchnl.h |   2 +-
 drivers/net/intel/idpf/idpf_ethdev.c  |   3 +-
 drivers/net/intel/idpf/idpf_rxtx.c|  47 ++-
 drivers/net/intel/idpf/idpf_rxtx.h|   1 +
 drivers/net/intel/idpf/idpf_rxtx_vec_common.h |   9 +-
 16 files changed, 257 insertions(+), 504 deletions(-)

-- 
2.34.1

RE: [PATCH] acl: fix build with GCC 15 on aarch64

[Morten Brørup]

> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Thursday, 27 March 2025 11.51
> 
> On Thu, Mar 27, 2025 at 10:39:09AM +, Konstantin Ananyev wrote:
> >
> >
> > > -Original Message-
> > > From: David Marchand 
> > > Sent: Thursday, March 27, 2025 10:37 AM
> > > To: Bruce Richardson 
> > > Cc: dev@dpdk.org; bl...@debian.org; sta...@dpdk.org; Konstantin
> Ananyev ; David Christensen
> > > ; Wathsala Vithanage
> 
> > > Subject: Re: [PATCH] acl: fix build with GCC 15 on aarch64
> > >
> > > On Thu, Mar 27, 2025 at 9:55 AM Bruce Richardson
> > >  wrote:
> > > >
> > > > On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote:
> > > > > Caught in OBS for Fedora Rawhide on aarch64:
> > > > >
> > > > > [  198s] In file included from ../lib/acl/acl_run_neon.h:7,
> > > > > [  198s]  from ../lib/acl/acl_run_neon.c:5:
> > > > > [  198s] In function ‘alloc_completion’,
> > > > > [  198s] inlined from ‘acl_start_next_trie’ at
> > > > >   ../lib/acl/acl_run.h:140:24,
> > > > > [  198s] inlined from ‘search_neon_4.isra’ at
> > > > >   ../lib/acl/acl_run_neon.h:239:20:
> > > > > [  198s] ../lib/acl/acl_run.h:93:25: error: ‘cmplt’ may be used
> > > > >   uninitialized [-Werror=maybe-uninitialized]
> > > > > [  198s]93 | if (p[n].count == 0) {
> > > > > [  198s]   | ^~
> > > > > [  198s] ../lib/acl/acl_run_neon.h: In function
> ‘search_neon_4.isra’:
> > > > > [  198s] ../lib/acl/acl_run_neon.h:230:27: note: ‘cmplt’
> declared here
> > > > > [  198s]   230 | struct completion cmplt[4];
> > > > > [  198s]   |   ^
> > > > >
> > > > > The code was resetting sequentially cmpl[].count at the exact
> index that
> > > > > later call to alloc_completion uses.
> > > > > While this code seems correct, GCC 15 does not understand this
> (probably
> > > > > when applying some optimisations).
> > > > >
> > > > > Instead, reset cmpl[].count all at once in acl_set_flow, and
> cleanup the
> > > > > various vectorized implementations accordingly.
> > > > >
> > > > > Bugzilla ID: 1678
> > > > > Cc: sta...@dpdk.org
> > > > >
> > > > > Signed-off-by: David Marchand 
> > > > > ---
> > > > >  lib/acl/acl_run.h | 5 +
> > > > >  lib/acl/acl_run_altivec.h | 8 ++--
> > > > >  lib/acl/acl_run_avx2.h| 4 +---
> > > > >  lib/acl/acl_run_neon.h| 8 ++--
> > > > >  lib/acl/acl_run_scalar.c  | 4 +---
> > > > >  lib/acl/acl_run_sse.h | 8 ++--
> > > > >  6 files changed, 13 insertions(+), 24 deletions(-)
> > > > >
> > > > > diff --git a/lib/acl/acl_run.h b/lib/acl/acl_run.h
> > > > > index 7f092413cd..9fd3e60021 100644
> > > > > --- a/lib/acl/acl_run.h
> > > > > +++ b/lib/acl/acl_run.h
> > > > > @@ -176,6 +176,8 @@ acl_set_flow(struct acl_flow_data *flows,
> struct completion *cmplt,
> > > > >   uint32_t cmplt_size, const uint8_t **data, uint32_t
> *results,
> > > > >   uint32_t data_num, uint32_t categories, const uint64_t
> *trans)
> > > > >  {
> > > > > + unsigned int i;
> > > > > +
> > > > >   flows->num_packets = 0;
> > > > >   flows->started = 0;
> > > > >   flows->trie = 0;
> > > > > @@ -187,6 +189,9 @@ acl_set_flow(struct acl_flow_data *flows,
> struct completion *cmplt,
> > > > >   flows->data = data;
> > > > >   flows->results = results;
> > > > >   flows->trans = trans;
> > > > > +
> > > > > + for (i = 0; i < cmplt_size; i++)
> > > > > + cmplt[i].count = 0;
> > > > >  }
> > > >
> > > > Minor nit, but since we are using c11 standard, is it not better
> to declare
> > > > "i" inside the "for" statement. Keeps diffs simpler for
> adding/removing
> > > > code, I think.
> > >
> > > I still have this (bad) habit but yes, it looks nicer with
> declaring
> > > in for() itself.
> >
> > My vote would be to keep it in an old fashioned way.
> > Nothing is wrong in defining variable to use at the start of the
> function :)
> >
> 
> No, there isn't. However, there is also a reason why later GCC
> revisions
> and modern languages allow use of a temporary variable defined within
> the
> loop itself. Cognitively, it's easier to have variables defined at
> point of
> use, as it saves the user having to mentally track them or move up and
> down the
> code. Furthermore, when debugging or reworking the code, it's far
> easier to
> have the variable inside the "for" statement as it means that as we
> comment/uncomment, or remove/re-add, the code block, the variable
> definition
> also gets commented/uncommented too, without having to constantly
> scroll up
> to make changes in two places. Lastly, it makes for smaller git diffs
> too.
> 
> /Bruce

I agree with Bruce.
Also, minimizing the scope of local variables reduces the risk of bugs caused 
by unintended reuse without re-initialization. Reducing the risk of bugs is 
important.

BTW: The Coding Style documentation [CODINGSTYLE] is still based on an ancient 
C version, and n

RE: [PATCH] acl: fix build with GCC 15 on aarch64

[Konstantin Ananyev]

> > >
> > > > -Original Message-
> > > > From: David Marchand 
> > > > Sent: Thursday, March 27, 2025 10:37 AM
> > > > To: Bruce Richardson 
> > > > Cc: dev@dpdk.org; bl...@debian.org; sta...@dpdk.org; Konstantin
> > Ananyev ; David Christensen
> > > > ; Wathsala Vithanage
> > 
> > > > Subject: Re: [PATCH] acl: fix build with GCC 15 on aarch64
> > > >
> > > > On Thu, Mar 27, 2025 at 9:55 AM Bruce Richardson
> > > >  wrote:
> > > > >
> > > > > On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote:
> > > > > > Caught in OBS for Fedora Rawhide on aarch64:
> > > > > >
> > > > > > [  198s] In file included from ../lib/acl/acl_run_neon.h:7,
> > > > > > [  198s]  from ../lib/acl/acl_run_neon.c:5:
> > > > > > [  198s] In function ‘alloc_completion’,
> > > > > > [  198s] inlined from ‘acl_start_next_trie’ at
> > > > > >   ../lib/acl/acl_run.h:140:24,
> > > > > > [  198s] inlined from ‘search_neon_4.isra’ at
> > > > > >   ../lib/acl/acl_run_neon.h:239:20:
> > > > > > [  198s] ../lib/acl/acl_run.h:93:25: error: ‘cmplt’ may be used
> > > > > >   uninitialized [-Werror=maybe-uninitialized]
> > > > > > [  198s]93 | if (p[n].count == 0) {
> > > > > > [  198s]   | ^~
> > > > > > [  198s] ../lib/acl/acl_run_neon.h: In function
> > ‘search_neon_4.isra’:
> > > > > > [  198s] ../lib/acl/acl_run_neon.h:230:27: note: ‘cmplt’
> > declared here
> > > > > > [  198s]   230 | struct completion cmplt[4];
> > > > > > [  198s]   |   ^
> > > > > >
> > > > > > The code was resetting sequentially cmpl[].count at the exact
> > index that
> > > > > > later call to alloc_completion uses.
> > > > > > While this code seems correct, GCC 15 does not understand this
> > (probably
> > > > > > when applying some optimisations).
> > > > > >
> > > > > > Instead, reset cmpl[].count all at once in acl_set_flow, and
> > cleanup the
> > > > > > various vectorized implementations accordingly.
> > > > > >
> > > > > > Bugzilla ID: 1678
> > > > > > Cc: sta...@dpdk.org
> > > > > >
> > > > > > Signed-off-by: David Marchand 
> > > > > > ---
> > > > > >  lib/acl/acl_run.h | 5 +
> > > > > >  lib/acl/acl_run_altivec.h | 8 ++--
> > > > > >  lib/acl/acl_run_avx2.h| 4 +---
> > > > > >  lib/acl/acl_run_neon.h| 8 ++--
> > > > > >  lib/acl/acl_run_scalar.c  | 4 +---
> > > > > >  lib/acl/acl_run_sse.h | 8 ++--
> > > > > >  6 files changed, 13 insertions(+), 24 deletions(-)
> > > > > >
> > > > > > diff --git a/lib/acl/acl_run.h b/lib/acl/acl_run.h
> > > > > > index 7f092413cd..9fd3e60021 100644
> > > > > > --- a/lib/acl/acl_run.h
> > > > > > +++ b/lib/acl/acl_run.h
> > > > > > @@ -176,6 +176,8 @@ acl_set_flow(struct acl_flow_data *flows,
> > struct completion *cmplt,
> > > > > >   uint32_t cmplt_size, const uint8_t **data, uint32_t
> > *results,
> > > > > >   uint32_t data_num, uint32_t categories, const uint64_t
> > *trans)
> > > > > >  {
> > > > > > + unsigned int i;
> > > > > > +
> > > > > >   flows->num_packets = 0;
> > > > > >   flows->started = 0;
> > > > > >   flows->trie = 0;
> > > > > > @@ -187,6 +189,9 @@ acl_set_flow(struct acl_flow_data *flows,
> > struct completion *cmplt,
> > > > > >   flows->data = data;
> > > > > >   flows->results = results;
> > > > > >   flows->trans = trans;
> > > > > > +
> > > > > > + for (i = 0; i < cmplt_size; i++)
> > > > > > + cmplt[i].count = 0;
> > > > > >  }
> > > > >
> > > > > Minor nit, but since we are using c11 standard, is it not better
> > to declare
> > > > > "i" inside the "for" statement. Keeps diffs simpler for
> > adding/removing
> > > > > code, I think.
> > > >
> > > > I still have this (bad) habit but yes, it looks nicer with
> > declaring
> > > > in for() itself.
> > >
> > > My vote would be to keep it in an old fashioned way.
> > > Nothing is wrong in defining variable to use at the start of the
> > function :)
> > >
> >
> > No, there isn't. However, there is also a reason why later GCC
> > revisions
> > and modern languages allow use of a temporary variable defined within
> > the
> > loop itself. Cognitively, it's easier to have variables defined at
> > point of
> > use, as it saves the user having to mentally track them or move up and
> > down the
> > code. Furthermore, when debugging or reworking the code, it's far
> > easier to
> > have the variable inside the "for" statement as it means that as we
> > comment/uncomment, or remove/re-add, the code block, the variable
> > definition
> > also gets commented/uncommented too, without having to constantly
> > scroll up
> > to make changes in two places. Lastly, it makes for smaller git diffs
> > too.

I understand that it is probably more convenient, though from my perspective it 
is also more error prone.
I saw several times people unintentionally defined new variable (in a local 
scope) with the same name
that was already used in an

Re: [PATCH] acl: fix build with GCC 15 on aarch64

[Bruce Richardson]

On Thu, Mar 27, 2025 at 12:10:12PM +, Konstantin Ananyev wrote:
> 
> 
> > > >
> > > > > -Original Message-
> > > > > From: David Marchand 
> > > > > Sent: Thursday, March 27, 2025 10:37 AM
> > > > > To: Bruce Richardson 
> > > > > Cc: dev@dpdk.org; bl...@debian.org; sta...@dpdk.org; Konstantin
> > > Ananyev ; David Christensen
> > > > > ; Wathsala Vithanage
> > > 
> > > > > Subject: Re: [PATCH] acl: fix build with GCC 15 on aarch64
> > > > >
> > > > > On Thu, Mar 27, 2025 at 9:55 AM Bruce Richardson
> > > > >  wrote:
> > > > > >
> > > > > > On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote:
> > > > > > > Caught in OBS for Fedora Rawhide on aarch64:
> > > > > > >
> > > > > > > [  198s] In file included from ../lib/acl/acl_run_neon.h:7,
> > > > > > > [  198s]  from ../lib/acl/acl_run_neon.c:5:
> > > > > > > [  198s] In function ‘alloc_completion’,
> > > > > > > [  198s] inlined from ‘acl_start_next_trie’ at
> > > > > > >   ../lib/acl/acl_run.h:140:24,
> > > > > > > [  198s] inlined from ‘search_neon_4.isra’ at
> > > > > > >   ../lib/acl/acl_run_neon.h:239:20:
> > > > > > > [  198s] ../lib/acl/acl_run.h:93:25: error: ‘cmplt’ may be used
> > > > > > >   uninitialized [-Werror=maybe-uninitialized]
> > > > > > > [  198s]93 | if (p[n].count == 0) {
> > > > > > > [  198s]   | ^~
> > > > > > > [  198s] ../lib/acl/acl_run_neon.h: In function
> > > ‘search_neon_4.isra’:
> > > > > > > [  198s] ../lib/acl/acl_run_neon.h:230:27: note: ‘cmplt’
> > > declared here
> > > > > > > [  198s]   230 | struct completion cmplt[4];
> > > > > > > [  198s]   |   ^
> > > > > > >
> > > > > > > The code was resetting sequentially cmpl[].count at the exact
> > > index that
> > > > > > > later call to alloc_completion uses.
> > > > > > > While this code seems correct, GCC 15 does not understand this
> > > (probably
> > > > > > > when applying some optimisations).
> > > > > > >
> > > > > > > Instead, reset cmpl[].count all at once in acl_set_flow, and
> > > cleanup the
> > > > > > > various vectorized implementations accordingly.
> > > > > > >
> > > > > > > Bugzilla ID: 1678
> > > > > > > Cc: sta...@dpdk.org
> > > > > > >
> > > > > > > Signed-off-by: David Marchand 
> > > > > > > ---
> > > > > > >  lib/acl/acl_run.h | 5 +
> > > > > > >  lib/acl/acl_run_altivec.h | 8 ++--
> > > > > > >  lib/acl/acl_run_avx2.h| 4 +---
> > > > > > >  lib/acl/acl_run_neon.h| 8 ++--
> > > > > > >  lib/acl/acl_run_scalar.c  | 4 +---
> > > > > > >  lib/acl/acl_run_sse.h | 8 ++--
> > > > > > >  6 files changed, 13 insertions(+), 24 deletions(-)
> > > > > > >
> > > > > > > diff --git a/lib/acl/acl_run.h b/lib/acl/acl_run.h
> > > > > > > index 7f092413cd..9fd3e60021 100644
> > > > > > > --- a/lib/acl/acl_run.h
> > > > > > > +++ b/lib/acl/acl_run.h
> > > > > > > @@ -176,6 +176,8 @@ acl_set_flow(struct acl_flow_data *flows,
> > > struct completion *cmplt,
> > > > > > >   uint32_t cmplt_size, const uint8_t **data, uint32_t
> > > *results,
> > > > > > >   uint32_t data_num, uint32_t categories, const uint64_t
> > > *trans)
> > > > > > >  {
> > > > > > > + unsigned int i;
> > > > > > > +
> > > > > > >   flows->num_packets = 0;
> > > > > > >   flows->started = 0;
> > > > > > >   flows->trie = 0;
> > > > > > > @@ -187,6 +189,9 @@ acl_set_flow(struct acl_flow_data *flows,
> > > struct completion *cmplt,
> > > > > > >   flows->data = data;
> > > > > > >   flows->results = results;
> > > > > > >   flows->trans = trans;
> > > > > > > +
> > > > > > > + for (i = 0; i < cmplt_size; i++)
> > > > > > > + cmplt[i].count = 0;
> > > > > > >  }
> > > > > >
> > > > > > Minor nit, but since we are using c11 standard, is it not better
> > > to declare
> > > > > > "i" inside the "for" statement. Keeps diffs simpler for
> > > adding/removing
> > > > > > code, I think.
> > > > >
> > > > > I still have this (bad) habit but yes, it looks nicer with
> > > declaring
> > > > > in for() itself.
> > > >
> > > > My vote would be to keep it in an old fashioned way.
> > > > Nothing is wrong in defining variable to use at the start of the
> > > function :)
> > > >
> > >
> > > No, there isn't. However, there is also a reason why later GCC
> > > revisions
> > > and modern languages allow use of a temporary variable defined within
> > > the
> > > loop itself. Cognitively, it's easier to have variables defined at
> > > point of
> > > use, as it saves the user having to mentally track them or move up and
> > > down the
> > > code. Furthermore, when debugging or reworking the code, it's far
> > > easier to
> > > have the variable inside the "for" statement as it means that as we
> > > comment/uncomment, or remove/re-add, the code block, the variable
> > > definition
> > > also gets commented/uncommented too, without having to constantly
> > > scroll up
> > > to make chang

RE: [PATCH] acl: fix build with GCC 15 on aarch64

[Morten Brørup]

> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com]
> Sent: Thursday, 27 March 2025 13.10
> 
> > > >
> > > > > From: David Marchand 
> > > > > Sent: Thursday, March 27, 2025 10:37 AM
> > > > >
> > > > > On Thu, Mar 27, 2025 at 9:55 AM Bruce Richardson
> > > > >  wrote:
> > > > > >
> > > > > > On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand
> wrote:
> > > > > > > @@ -176,6 +176,8 @@ acl_set_flow(struct acl_flow_data
> *flows,
> > > struct completion *cmplt,
> > > > > > >   uint32_t cmplt_size, const uint8_t **data, uint32_t
> > > *results,
> > > > > > >   uint32_t data_num, uint32_t categories, const
> uint64_t
> > > *trans)
> > > > > > >  {
> > > > > > > + unsigned int i;
> > > > > > > +
> > > > > > >   flows->num_packets = 0;
> > > > > > >   flows->started = 0;
> > > > > > >   flows->trie = 0;
> > > > > > > @@ -187,6 +189,9 @@ acl_set_flow(struct acl_flow_data
> *flows,
> > > struct completion *cmplt,
> > > > > > >   flows->data = data;
> > > > > > >   flows->results = results;
> > > > > > >   flows->trans = trans;
> > > > > > > +
> > > > > > > + for (i = 0; i < cmplt_size; i++)
> > > > > > > + cmplt[i].count = 0;
> > > > > > >  }
> > > > > >
> > > > > > Minor nit, but since we are using c11 standard, is it not
> better
> > > to declare
> > > > > > "i" inside the "for" statement. Keeps diffs simpler for
> > > adding/removing
> > > > > > code, I think.
> > > > >
> > > > > I still have this (bad) habit but yes, it looks nicer with
> > > declaring
> > > > > in for() itself.
> > > >
> > > > My vote would be to keep it in an old fashioned way.
> > > > Nothing is wrong in defining variable to use at the start of the
> > > function :)
> > > >
> > >
> > > No, there isn't. However, there is also a reason why later GCC
> > > revisions
> > > and modern languages allow use of a temporary variable defined
> within
> > > the
> > > loop itself. Cognitively, it's easier to have variables defined at
> > > point of
> > > use, as it saves the user having to mentally track them or move up
> and
> > > down the
> > > code. Furthermore, when debugging or reworking the code, it's far
> > > easier to
> > > have the variable inside the "for" statement as it means that as we
> > > comment/uncomment, or remove/re-add, the code block, the variable
> > > definition
> > > also gets commented/uncommented too, without having to constantly
> > > scroll up
> > > to make changes in two places. Lastly, it makes for smaller git
> diffs
> > > too.
> 
> I understand that it is probably more convenient, though from my
> perspective it is also more error prone.
> I saw several times people unintentionally defined new variable (in a
> local scope) with the same name
> that was already used in an outer scope, especially when function
> becomes large and clunky.

Yes, it used to be a problem, causing bugs that were difficult to find by the 
developer who wrote the code.
But modern compilers warn about that, so not a problem anymore.

> Personally, I think it is a good practice to do a 'mental track' of
> your variables when writing the code,
> and having all of them defined in one place definitely helps with that.

I partially agree with this. Variables declared in the middle of a code block 
are difficult to keep mental track of.

However, minimizing the scope of variables reduces the mental load when 
reviewing code.
If some variable is only used within a block of code, it should not be declared 
outside that block.

As always, there are exceptions to all rules. E.g. a local variable used at the 
end of a code block, e.g. as a helper for temporarily cleaning up, is OK to 
declare there.

> Anyway, I am not about to stop people to define variables inside the
> for() if it is more convenient for them,
> but I am against to force people to write code that way.

Coding style is a balance between readability/reviewability, bug prevention and 
preferences.

And with our current coding style, either way of declaring "i" in this case 
should be acceptable.

> 
> > >
> > > /Bruce
> >
> > I agree with Bruce.
> > Also, minimizing the scope of local variables reduces the risk of
> bugs caused by unintended reuse without re-initialization. Reducing
> > the risk of bugs is important.
> >
> > BTW: The Coding Style documentation [CODINGSTYLE] is still based on
> an ancient C version, and needs to be updated.
> >
> > [CODINGSTYLE]:
> https://doc.dpdk.org/guides/contributing/coding_style.html#local-
> variables

[PATCH v5 0/8] Symbol versioning and export rework

[David Marchand]

So far, each DPDK library (or driver) exposing symbols in an ABI had to
maintain a version.map and use some macros for symbol versioning,
specially crafted with the GNU linker in mind.

This series proposes to rework the whole principle, and instead rely on
marking the symbol exports in the source code itself, then let it to the
build framework to produce a version script adapted to the linker in use
(think GNU linker vs MSVC linker).

This greatly simplifies versioning symbols: a developer does not need to
know anything about version.map, or that a versioned symbol must be
renamed with _v26, annotated with __vsym, exported in a header etc...

Checking symbol maps becomes unnecessary since generated by the build
framework.

Updating to a new ABI is just a matter of bumping the value in
ABI_VERSION.



-- 
David Marchand

Changes since RFC v4:
- rebased on main, now that Bruce series is merged,
- the export macros header has been moved to lib/eal/common/
  and its inclusion is now mandatory (rather than an implicit -include),
- reordered patches: symbol versioning is touched last and merged
  in the export header (replacing the legacy rte_function_versioning.h),

Changes since RFC v3:
- fixed/simplified documentation,
- rebased on top of Bruce series for common handling of AVX sources,

Changes since RFC v2:
- updated RTE_VERSION_SYMBOL() (and friends) so that only the fonction
  signature is enclosed in the macro,
- dropped invalid exports for some dead symbols or inline helpers,
- updated documentation and tooling,
- converted the whole tree (via a local script of mine),

David Marchand (8):
  lib: remove incorrect exported symbols
  drivers: remove incorrect exported symbols
  buildtools: display version when listing symbols
  build: generate symbol maps
  build: mark exported symbols
  build: use dynamically generated version maps
  build: remove static version maps
  eal: rework function versioning macros

 .github/workflows/build.yml   |   1 -
 MAINTAINERS   |   9 +-
 buildtools/check-symbols.sh   |  33 +-
 buildtools/gen-version-map.py | 105 
 buildtools/map-list-symbol.sh |  15 +-
 buildtools/map_to_win.py  |  41 --
 buildtools/meson.build|   2 +-
 devtools/check-spdx-tag.sh|   2 +-
 devtools/check-symbol-change.py   |  90 +++
 devtools/check-symbol-change.sh   | 186 --
 devtools/check-symbol-maps.sh | 115 
 devtools/checkpatches.sh  |   4 +-
 devtools/update-abi.sh|  46 --
 devtools/update_version_map_abi.py| 210 ---
 doc/api/doxy-api-index.md |   1 -
 doc/guides/contributing/abi_policy.rst|  21 +-
 doc/guides/contributing/abi_versioning.rst| 415 +++--
 doc/guides/contributing/coding_style.rst  |   7 -
 .../contributing/img/patch_cheatsheet.svg | 303 +
 doc/guides/contributing/patches.rst   |   6 +-
 doc/guides/rel_notes/release_25_07.rst|   2 +
 drivers/baseband/acc/rte_acc100_pmd.c |   2 +
 drivers/baseband/acc/version.map  |  10 -
 .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c |   2 +
 drivers/baseband/fpga_5gnr_fec/version.map|  11 -
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.c  |   2 +
 drivers/baseband/fpga_lte_fec/version.map |  10 -
 drivers/bus/auxiliary/auxiliary_common.c  |   3 +
 drivers/bus/auxiliary/version.map |   8 -
 drivers/bus/cdx/cdx.c |   5 +
 drivers/bus/cdx/cdx_vfio.c|   5 +
 drivers/bus/cdx/version.map   |  14 -
 drivers/bus/dpaa/dpaa_bus.c   |  10 +
 drivers/bus/dpaa/dpaa_bus_symbols.c   |  99 +++
 drivers/bus/dpaa/meson.build  |   1 +
 drivers/bus/dpaa/version.map  | 109 
 drivers/bus/fslmc/fslmc_bus.c |   5 +
 drivers/bus/fslmc/fslmc_vfio.c|  13 +
 drivers/bus/fslmc/mc/dpbp.c   |   8 +
 drivers/bus/fslmc/mc/dpci.c   |   5 +
 drivers/bus/fslmc/mc/dpcon.c  |   8 +
 drivers/bus/fslmc/mc/dpdmai.c |  10 +
 drivers/bus/fslmc/mc/dpio.c   |  15 +
 drivers/bus/fslmc/mc/dpmng.c  |   4 +
 drivers/bus/fslmc/mc/mc_sys.c |   2 +
 drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c  |   4 +
 drivers/bus/fslmc/portal/dpaa2_hw_dpci.c  |   3 +
 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c  |  12 +
 drivers/bus/fslmc/qbman/qbman_debug.c |   4 +
 drivers/bus/fslmc/qbman/qbman_portal.c|  43 ++
 drivers/bus/fslmc/version.map | 129 
 drivers/bus/ifpga/ifpga_bus.c |   4 +
 drivers/bus/ifpga/version.map |   9 -
 drivers/bus/pci/bsd/pci.c |  11 +
 drivers/bus/pci/linux/pci.

[PATCH v5 6/8] build: use dynamically generated version maps

[David Marchand]

Switch to dynamically generated version maps.

As the map files get generated, tooling around checking, converting,
updating etc.. static version maps can be removed.

Signed-off-by: David Marchand 
---
 .github/workflows/build.yml   |   1 -
 MAINTAINERS   |   7 -
 buildtools/check-symbols.sh   |  33 +-
 buildtools/map-list-symbol.sh |   7 +-
 buildtools/map_to_win.py  |  41 ---
 buildtools/meson.build|   1 -
 devtools/check-symbol-change.sh   | 186 ---
 devtools/check-symbol-maps.sh | 101 --
 devtools/checkpatches.sh  |   2 +-
 devtools/update-abi.sh|  46 ---
 devtools/update_version_map_abi.py| 210 
 doc/guides/contributing/abi_policy.rst|  21 +-
 doc/guides/contributing/coding_style.rst  |   7 -
 .../contributing/img/patch_cheatsheet.svg | 303 --
 doc/guides/contributing/patches.rst   |   6 +-
 drivers/meson.build   |  74 ++---
 lib/meson.build   |  73 ++---
 17 files changed, 188 insertions(+), 931 deletions(-)
 delete mode 100644 buildtools/map_to_win.py
 delete mode 100755 devtools/check-symbol-change.sh
 delete mode 100755 devtools/check-symbol-maps.sh
 delete mode 100755 devtools/update-abi.sh
 delete mode 100755 devtools/update_version_map_abi.py

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 0cc4d12b0b..7a6b679fe5 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -31,7 +31,6 @@ jobs:
 failed=
 devtools/check-doc-vs-code.sh upstream/${{ env.REF_GIT_BRANCH }} || 
failed=true
 devtools/check-meson.py || failed=true
-devtools/check-symbol-maps.sh || failed=true
 [ -z "$failed" ]
   ubuntu-vm-builds:
 name: ${{ join(matrix.config.*, '-') }}
diff --git a/MAINTAINERS b/MAINTAINERS
index 42ea07854b..480972ef1e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -88,7 +88,6 @@ M: Thomas Monjalon 
 F: MAINTAINERS
 F: devtools/build-dict.sh
 F: devtools/check-abi.sh
-F: devtools/check-abi-version.sh
 F: devtools/check-doc-vs-code.sh
 F: devtools/check-dup-includes.sh
 F: devtools/check-maintainers.sh
@@ -96,17 +95,13 @@ F: devtools/check-forbidden-tokens.awk
 F: devtools/check-git-log.sh
 F: devtools/check-spdx-tag.sh
 F: devtools/check-symbol-change.py
-F: devtools/check-symbol-change.sh
-F: devtools/check-symbol-maps.sh
 F: devtools/checkpatches.sh
 F: devtools/get-maintainer.sh
 F: devtools/git-log-fixes.sh
 F: devtools/load-devel-config
 F: devtools/parse-flow-support.sh
 F: devtools/process-iwyu.py
-F: devtools/update-abi.sh
 F: devtools/update-patches.py
-F: devtools/update_version_map_abi.py
 F: devtools/libabigail.abignore
 F: devtools/words-case.txt
 F: license/
@@ -166,7 +161,6 @@ M: Tyler Retzlaff 
 F: lib/eal/common/
 F: lib/eal/unix/
 F: lib/eal/include/
-F: lib/eal/version.map
 F: doc/guides/prog_guide/env_abstraction_layer.rst
 F: app/test/test_alarm.c
 F: app/test/test_atomic.c
@@ -396,7 +390,6 @@ Windows support
 M: Dmitry Kozlyuk 
 M: Tyler Retzlaff 
 F: lib/eal/windows/
-F: buildtools/map_to_win.py
 F: doc/guides/windows_gsg/
 
 Windows memory allocation
diff --git a/buildtools/check-symbols.sh b/buildtools/check-symbols.sh
index b8ac24391e..0d6745ec14 100755
--- a/buildtools/check-symbols.sh
+++ b/buildtools/check-symbols.sh
@@ -7,29 +7,12 @@ OBJFILE=$2
 
 ROOTDIR=$(readlink -f $(dirname $(readlink -f $0))/..)
 LIST_SYMBOL=$ROOTDIR/buildtools/map-list-symbol.sh
-CHECK_SYMBOL_MAPS=$ROOTDIR/devtools/check-symbol-maps.sh
-
-# added check for "make -C test/" usage
-if [ ! -e $MAPFILE ] || [ ! -f $OBJFILE ]
-then
-   exit 0
-fi
-
-if [ -d $MAPFILE ]
-then
-   exit 0
-fi
-
 DUMPFILE=$(mktemp -t dpdk.${0##*/}.objdump.XX)
 trap 'rm -f "$DUMPFILE"' EXIT
 objdump -t $OBJFILE >$DUMPFILE
 
 ret=0
 
-if ! $CHECK_SYMBOL_MAPS $MAPFILE; then
-   ret=1
-fi
-
 for SYM in `$LIST_SYMBOL -S EXPERIMENTAL $MAPFILE |cut -d ' ' -f 3`
 do
if grep -q "\.text.*[[:space:]]$SYM$" $DUMPFILE &&
@@ -37,8 +20,7 @@ do
$LIST_SYMBOL -s $SYM $MAPFILE | grep -q EXPERIMENTAL
then
cat >&2 <<- END_OF_MESSAGE
-   $SYM is not flagged as experimental
-   but is listed in version map
+   $SYM is not flagged as experimental but is exported as an 
experimental symbol
Please add __rte_experimental to the definition of $SYM
END_OF_MESSAGE
ret=1
@@ -53,9 +35,8 @@ for SYM in `awk '{
 do
$LIST_SYMBOL -S EXPERIMENTAL -s $SYM -q $MAPFILE || {
cat >&2 <<- END_OF_MESSAGE
-   $SYM is flagged as experimental
-   but is not listed in version map
-   Please add $SYM to the version map
+   $SYM is flagged as experimenta

[PATCH v5 4/8] build: generate symbol maps

[David Marchand]

Rather than maintain a file in parallel of the code, symbols to be
exported can be marked with a token RTE_EXPORT_*SYMBOL.

>From those marks, the build framework generates map files only for
symbols actually compiled (which means that the WINDOWS_NO_EXPORT hack
becomes unnecessary).

The build framework directly creates a map file in the format that the
linker expects (rather than converting from GNU linker to MSVC linker).

Empty maps are allowed again as a replacement for drivers/version.map.

The symbol check is updated to only support the new format.

Signed-off-by: David Marchand 
---
Changes since RFC v4:
- fixed MSVC export map (a msvc->mslinker update was missing),
- fixed join() error (with older meson? I don't see this on Fedora),
- explicit inclusion of header is now required,
- header has been renamed and moved to lib/eal/common/,
- because lib/log does not depend on EAL, added explicit
  include_directories,
- symbol versioning update has been moved later in the series,
  so updated gen-version-map.py accordingly,
- fixed bug when checking symbol removal,

Changes since RFC v3:
- polished python,
- fixed doc updates not belonging to this patch,
- renamed map files,
- changed msvc->mslinker as link mode,
- added parsing of AVX sources,

Changes since RFC v2:
- because of MSVC limitations wrt macro passed via cmdline,
  used an internal header for defining RTE_EXPORT_* macros,
- updated documentation and tooling,

---
 MAINTAINERS|   2 +
 buildtools/gen-version-map.py  | 106 ++
 buildtools/map-list-symbol.sh  |  10 +-
 buildtools/meson.build |   1 +
 devtools/check-symbol-change.py|  90 
 devtools/check-symbol-maps.sh  |  14 --
 devtools/checkpatches.sh   |   2 +-
 doc/guides/contributing/abi_versioning.rst | 227 ++---
 drivers/meson.build|  96 +
 drivers/version.map|   3 -
 lib/eal/common/eal_symbol_exports.h|  16 ++
 lib/meson.build|  94 ++---
 12 files changed, 365 insertions(+), 296 deletions(-)
 create mode 100755 buildtools/gen-version-map.py
 create mode 100755 devtools/check-symbol-change.py
 delete mode 100644 drivers/version.map
 create mode 100644 lib/eal/common/eal_symbol_exports.h

diff --git a/MAINTAINERS b/MAINTAINERS
index 4b01103f8e..42ea07854b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -95,6 +95,7 @@ F: devtools/check-maintainers.sh
 F: devtools/check-forbidden-tokens.awk
 F: devtools/check-git-log.sh
 F: devtools/check-spdx-tag.sh
+F: devtools/check-symbol-change.py
 F: devtools/check-symbol-change.sh
 F: devtools/check-symbol-maps.sh
 F: devtools/checkpatches.sh
@@ -127,6 +128,7 @@ F: config/
 F: buildtools/check-symbols.sh
 F: buildtools/chkincs/
 F: buildtools/call-sphinx-build.py
+F: buildtools/gen-version-map.py
 F: buildtools/get-cpu-count.py
 F: buildtools/get-numa-count.py
 F: buildtools/list-dir-globs.py
diff --git a/buildtools/gen-version-map.py b/buildtools/gen-version-map.py
new file mode 100755
index 00..c7dfc9b8c2
--- /dev/null
+++ b/buildtools/gen-version-map.py
@@ -0,0 +1,106 @@
+#!/usr/bin/env python3
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (c) 2025 Red Hat, Inc.
+
+"""Generate a version map file used by GNU or MSVC linker."""
+
+import re
+import sys
+
+scriptname, link_mode, abi_version_file, output, *files = sys.argv
+
+# From eal_symbol_exports.h
+export_exp_sym_regexp = re.compile(r"^RTE_EXPORT_EXPERIMENTAL_SYMBOL\(([^,]+), 
([0-9]+.[0-9]+)\)")
+export_int_sym_regexp = re.compile(r"^RTE_EXPORT_INTERNAL_SYMBOL\(([^)]+)\)")
+export_sym_regexp = re.compile(r"^RTE_EXPORT_SYMBOL\(([^)]+)\)")
+# From rte_function_versioning.h
+ver_sym_regexp = re.compile(r"^VERSION_SYMBOL\(([^,]+), [^,]+, ([^,]+)\)")
+ver_exp_sym_regexp = re.compile(r"^VERSION_SYMBOL_EXPERIMENTAL\([^,]+, 
([^,]+)\)")
+default_sym_regexp = re.compile(r"^BIND_DEFAULT_SYMBOL\(([^,]+), [^,]+, 
([^,]+)\)")
+
+with open(abi_version_file) as f:
+abi = 'DPDK_{}'.format(re.match("([0-9]+).[0-9]", f.readline()).group(1))
+
+symbols = {}
+
+for file in files:
+with open(file, encoding="utf-8") as f:
+for ln in f.readlines():
+node = None
+symbol = None
+comment = ''
+if export_exp_sym_regexp.match(ln):
+node = 'EXPERIMENTAL'
+symbol = export_exp_sym_regexp.match(ln).group(1)
+comment = ' # added in 
{}'.format(export_exp_sym_regexp.match(ln).group(2))
+elif export_int_sym_regexp.match(ln):
+node = 'INTERNAL'
+symbol = export_int_sym_regexp.match(ln).group(1)
+elif export_sym_regexp.match(ln):
+node = abi
+symbol = export_sym_regexp.match(ln).group(1)
+elif ver_sym_regexp.match(ln):
+node = 'DPDK_{}'.format(ver_sym_re

[PATCH v5 8/8] eal: rework function versioning macros

[David Marchand]

For versioning symbols:
- MSVC uses pragmas on the symbol,
- GNU linker uses special asm directives,

To accommodate both GNU linker and MSVC linker, introduce new macros for
exporting and versioning symbols that will surround the whole function.

This has the advantage of hiding all the ugly details in the macros.
Now versioning a symbol is just a call to a single macro:
- RTE_VERSION_SYMBOL (resp. RTE_VERSION_EXPERIMENTAL_SYMBOL), for
  keeping an old implementation code under a versioned function (resp.
  experimental function),
- RTE_DEFAULT_SYMBOL, for declaring the new default versioned function,
  and handling the static link special case, instead of
  BIND_DEFAULT_SYMBOL + MAP_STATIC_SYMBOL,

This replaces the macros from rte_function_versioning.h that were
previously publicly exported.

Update lib/net accordingly.

Signed-off-by: David Marchand 
---
Changes since RFC v4:
- moved new macros to eal_symbol_exports.h and simply dropped legacy
  macros/header,
- added release notes update,

Changes since RFC v3:
- fixed documentation and simplified examples,

Changes since RFC v1:
- renamed and prefixed macros,
- reindented in prevision of second patch,

---
 buildtools/gen-version-map.py  |  15 +-
 devtools/check-symbol-change.py|   8 +-
 doc/api/doxy-api-index.md  |   1 -
 doc/guides/contributing/abi_versioning.rst | 192 ++---
 doc/guides/rel_notes/release_25_07.rst |   2 +
 lib/eal/common/eal_symbol_exports.h|  66 +++
 lib/eal/include/rte_function_versioning.h  |  99 ---
 lib/net/net_crc.h  |  15 --
 lib/net/rte_net_crc.c  |  29 +---
 9 files changed, 135 insertions(+), 292 deletions(-)
 delete mode 100644 lib/eal/include/rte_function_versioning.h

diff --git a/buildtools/gen-version-map.py b/buildtools/gen-version-map.py
index c7dfc9b8c2..7ee80ec640 100755
--- a/buildtools/gen-version-map.py
+++ b/buildtools/gen-version-map.py
@@ -13,10 +13,9 @@
 export_exp_sym_regexp = re.compile(r"^RTE_EXPORT_EXPERIMENTAL_SYMBOL\(([^,]+), 
([0-9]+.[0-9]+)\)")
 export_int_sym_regexp = re.compile(r"^RTE_EXPORT_INTERNAL_SYMBOL\(([^)]+)\)")
 export_sym_regexp = re.compile(r"^RTE_EXPORT_SYMBOL\(([^)]+)\)")
-# From rte_function_versioning.h
-ver_sym_regexp = re.compile(r"^VERSION_SYMBOL\(([^,]+), [^,]+, ([^,]+)\)")
-ver_exp_sym_regexp = re.compile(r"^VERSION_SYMBOL_EXPERIMENTAL\([^,]+, 
([^,]+)\)")
-default_sym_regexp = re.compile(r"^BIND_DEFAULT_SYMBOL\(([^,]+), [^,]+, 
([^,]+)\)")
+ver_sym_regexp = re.compile(r"^RTE_VERSION_SYMBOL\(([^,]+), [^,]+, ([^,]+),")
+ver_exp_sym_regexp = re.compile(r"^RTE_VERSION_EXPERIMENTAL_SYMBOL\([^,]+, 
([^,]+),")
+default_sym_regexp = re.compile(r"^RTE_DEFAULT_SYMBOL\(([^,]+), [^,]+, 
([^,]+),")
 
 with open(abi_version_file) as f:
 abi = 'DPDK_{}'.format(re.match("([0-9]+).[0-9]", f.readline()).group(1))
@@ -40,14 +39,14 @@
 node = abi
 symbol = export_sym_regexp.match(ln).group(1)
 elif ver_sym_regexp.match(ln):
-node = 'DPDK_{}'.format(ver_sym_regexp.match(ln).group(2))
-symbol = ver_sym_regexp.match(ln).group(1)
+node = 'DPDK_{}'.format(ver_sym_regexp.match(ln).group(1))
+symbol = ver_sym_regexp.match(ln).group(2)
 elif ver_exp_sym_regexp.match(ln):
 node = 'EXPERIMENTAL'
 symbol = ver_exp_sym_regexp.match(ln).group(1)
 elif default_sym_regexp.match(ln):
-node = 'DPDK_{}'.format(default_sym_regexp.match(ln).group(2))
-symbol = default_sym_regexp.match(ln).group(1)
+node = 'DPDK_{}'.format(default_sym_regexp.match(ln).group(1))
+symbol = default_sym_regexp.match(ln).group(2)
 
 if not symbol:
 continue
diff --git a/devtools/check-symbol-change.py b/devtools/check-symbol-change.py
index d522fbb1ec..d59ecaddd7 100755
--- a/devtools/check-symbol-change.py
+++ b/devtools/check-symbol-change.py
@@ -12,10 +12,10 @@
 export_exp_sym_regexp = 
re.compile(r"^.RTE_EXPORT_EXPERIMENTAL_SYMBOL\(([^,]+),")
 export_int_sym_regexp = re.compile(r"^.RTE_EXPORT_INTERNAL_SYMBOL\(([^)]+)\)")
 export_sym_regexp = re.compile(r"^.RTE_EXPORT_SYMBOL\(([^)]+)\)")
-# TODO, handle versioned symbols from rte_function_versioning.h
-# ver_sym_regexp = re.compile(r"^VERSION_SYMBOL\(([^,]+), [^,]+, ([^,]+)\)")
-# ver_exp_sym_regexp = re.compile(r"^VERSION_SYMBOL_EXPERIMENTAL\([^,]+, 
([^,]+)\)")
-# default_sym_regexp = re.compile(r"^BIND_DEFAULT_SYMBOL\(([^,]+), [^,]+, 
([^,]+)\)")
+# TODO, handle versioned symbols
+# ver_sym_regexp = re.compile(r"^.RTE_VERSION_SYMBOL\(([^,]+), [^,]+, 
([^,]+),")
+# ver_exp_sym_regexp = re.compile(r"^.RTE_VERSION_EXPERIMENTAL_SYMBOL\([^,]+, 
([^,]+),")
+# default_sym_regexp = re.compile(r"^.RTE_DEFAULT_SYMBOL\(([^,]+), [^,]+, 
([^,]+),")
 
 symbols = {}
 
diff --git a/doc/api/doxy-api-index.md b/doc/api/dox

Re: [External] Re: [PATCH v2] eal/linux: improve ASLR check

[Yang Ming]

On 2025/3/13 23:37, Stephen Hemminger wrote:

Caution: This is an external email. Please be very careful when clicking links 
or opening attachments. See http://nok.it/nsb for additional information.

On Thu, 13 Mar 2025 14:19:03 +0800
Yang Ming  wrote:


This change ensures that the current process is checked for
being run with 'setarch' before verifying the value of
'/proc/sys/kernel/randomize_va_space'. The '-R' or
'--addr-no-randomize' parameter of the 'setarch' command is used
to disable the randomization of the virtual address space.

Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org

Signed-off-by: Yang Ming 

Acked-by: Stephen Hemminger 


Hi Experts,

is there any chance to review and accept this patch?

Brs,

Yang Ming

[PATCH v4 4/4] net/idpf: use common Tx free fn in idpf

[Shaiq Wani]

Switch the idpf driver to use the common Tx free function for
AVX2 and AVX512.

Signed-off-by: Shaiq Wani 
---
 .../net/intel/idpf/idpf_common_rxtx_avx2.c|  10 +-
 .../net/intel/idpf/idpf_common_rxtx_avx512.c  | 237 +-
 2 files changed, 22 insertions(+), 225 deletions(-)

diff --git a/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c 
b/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
index bce0257804..fff31fedec 100644
--- a/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
+++ b/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
@@ -79,6 +79,14 @@ idpf_singleq_rx_rearm(struct idpf_rx_queue *rxq)
IDPF_PCI_REG_WRITE(rxq->qrx_tail, rx_id);
 }
 
+static inline int
+idpf_tx_desc_done(struct ci_tx_queue *txq, uint16_t idx)
+{
+   return (txq->idpf_tx_ring[idx].qw1 &
+   rte_cpu_to_le_64(IDPF_TXD_QW1_DTYPE_M)) ==
+   rte_cpu_to_le_64(IDPF_TX_DESC_DTYPE_DESC_DONE);
+}
+
 static inline uint16_t
 _idpf_singleq_recv_raw_pkts_vec_avx2(struct idpf_rx_queue *rxq, struct 
rte_mbuf **rx_pkts,
 uint16_t nb_pkts)
@@ -621,7 +629,7 @@ idpf_singleq_xmit_fixed_burst_vec_avx2(void *tx_queue, 
struct rte_mbuf **tx_pkts
nb_pkts = RTE_MIN(nb_pkts, txq->tx_rs_thresh);
 
if (txq->nb_tx_free < txq->tx_free_thresh)
-   idpf_singleq_tx_free_bufs_vec(txq);
+   ci_tx_free_bufs_vec(txq, idpf_tx_desc_done, false);
 
nb_commit = nb_pkts = (uint16_t)RTE_MIN(txq->nb_tx_free, nb_pkts);
if (unlikely(nb_pkts == 0))
diff --git a/drivers/net/intel/idpf/idpf_common_rxtx_avx512.c 
b/drivers/net/intel/idpf/idpf_common_rxtx_avx512.c
index c0ec754642..dbbdc71e22 100644
--- a/drivers/net/intel/idpf/idpf_common_rxtx_avx512.c
+++ b/drivers/net/intel/idpf/idpf_common_rxtx_avx512.c
@@ -122,6 +122,14 @@ idpf_singleq_rearm_common(struct idpf_rx_queue *rxq)
IDPF_PCI_REG_WRITE(rxq->qrx_tail, rx_id);
 }
 
+static inline int
+idpf_tx_desc_done(struct ci_tx_queue *txq, uint16_t idx)
+{
+   return (txq->idpf_tx_ring[idx].qw1 &
+   rte_cpu_to_le_64(IDPF_TXD_QW1_DTYPE_M)) ==
+   rte_cpu_to_le_64(IDPF_TX_DESC_DTYPE_DESC_DONE);
+}
+
 static __rte_always_inline void
 idpf_singleq_rearm(struct idpf_rx_queue *rxq)
 {
@@ -996,122 +1004,6 @@ idpf_dp_splitq_recv_pkts_avx512(void *rx_queue, struct 
rte_mbuf **rx_pkts,
 nb_pkts);
 }
 
-static __rte_always_inline int
-idpf_tx_singleq_free_bufs_avx512(struct ci_tx_queue *txq)
-{
-   struct ci_tx_entry_vec *txep;
-   uint32_t n;
-   uint32_t i;
-   int nb_free = 0;
-   struct rte_mbuf *m;
-   struct rte_mbuf **free = alloca(sizeof(struct rte_mbuf *) * 
txq->tx_rs_thresh);
-
-   /* check DD bits on threshold descriptor */
-   if ((txq->idpf_tx_ring[txq->tx_next_dd].qw1 &
-   rte_cpu_to_le_64(IDPF_TXD_QW1_DTYPE_M)) !=
-   rte_cpu_to_le_64(IDPF_TX_DESC_DTYPE_DESC_DONE))
-   return 0;
-
-   n = txq->tx_rs_thresh;
-
-/* first buffer to free from S/W ring is at index
- * tx_next_dd - (tx_rs_thresh-1)
- */
-   txep = (void *)txq->sw_ring;
-   txep += txq->tx_next_dd - (n - 1);
-
-   if (txq->offloads & IDPF_TX_OFFLOAD_MBUF_FAST_FREE && (n & 31) == 0) {
-   struct rte_mempool *mp = txep[0].mbuf->pool;
-   struct rte_mempool_cache *cache = rte_mempool_default_cache(mp,
-   rte_lcore_id());
-   void **cache_objs;
-
-   if (cache == NULL || cache->len == 0)
-   goto normal;
-
-   cache_objs = &cache->objs[cache->len];
-
-   if (n > RTE_MEMPOOL_CACHE_MAX_SIZE) {
-   rte_mempool_ops_enqueue_bulk(mp, (void *)txep, n);
-   goto done;
-   }
-
-   /* The cache follows the following algorithm
-*   1. Add the objects to the cache
-*   2. Anything greater than the cache min value (if it 
crosses the
-*   cache flush threshold) is flushed to the ring.
-*/
-   /* Add elements back into the cache */
-   uint32_t copied = 0;
-   /* n is multiple of 32 */
-   while (copied < n) {
-#ifdef RTE_ARCH_64
-   const __m512i a = _mm512_loadu_si512(&txep[copied]);
-   const __m512i b = _mm512_loadu_si512(&txep[copied + 8]);
-   const __m512i c = _mm512_loadu_si512(&txep[copied + 
16]);
-   const __m512i d = _mm512_loadu_si512(&txep[copied + 
24]);
-
-   _mm512_storeu_si512(&cache_objs[copied], a);
-   _mm512_storeu_si512(&cache_objs[copied + 8], b);
-   _mm512_storeu_si512(&cache_objs[copied + 16], c);

RE: [PATCH v2 1/2] eal: fix uncheck worker ID

[Morten Brørup]

> From: Dengdui Huang [mailto:huangdeng...@huawei.com]
> Sent: Thursday, 27 March 2025 10.01
> 
> The worker_id may come from user input.
> So it is necessary to verify it.
> 
> Fixes: a95d70547c57 ("eal: factorize lcore main loop")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Dengdui Huang 
> ---
>  lib/eal/common/eal_common_launch.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/eal/common/eal_common_launch.c
> b/lib/eal/common/eal_common_launch.c
> index 5320c3bd3c..76313d5cdf 100644
> --- a/lib/eal/common/eal_common_launch.c
> +++ b/lib/eal/common/eal_common_launch.c
> @@ -35,6 +35,9 @@ rte_eal_remote_launch(lcore_function_t *f, void *arg,
> unsigned int worker_id)
>  {
>   int rc = -EBUSY;
> 

Also check the lcore_id:
+   if (unlikely(lcore_id >= RTE_MAX_LCORE))
+   return -EINVAL;
+

> + if (!rte_lcore_has_role(worker_id, ROLE_RTE))
> + return -EINVAL;
> +

Although rte_lcore_has_role() checks the lcore_id and returns -EINVAL if 
invalid, "if (!-EINVAL))" will not take the branch to return -EINVAL here. So 
this check alone does not suffice. You could change it to "if 
(rte_lcore_has_role(worker_id, ROLE_RTE) <= 0) return -EINVAL;".
However, I prefer the separate lcore_id check, as mentioned above, rather than 
changing this check.

>   /* Check if the worker is in 'WAIT' state. Use acquire order
>* since 'state' variable is used as the guard variable.
>*/
> --
> 2.33.0


While you are at it, please also add "if (unlikely(lcore_id >= RTE_MAX_LCORE)) 
return -EINVAL;" checks in the other functions in eal_common_lcore.c where 
lcore_id comes from user input and the check is missing.

[DPDK/examples Bug 1684] Colt Python holster

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1684

Bug ID: 1684
   Summary: Colt Python holster
   Product: DPDK
   Version: 24.03
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: examples
  Assignee: dev@dpdk.org
  Reporter: devismiller...@gmail.com
  Target Milestone: ---

Hello! I am Davis Miller, a travel enthusiast who loves exploring new
destinations around the world. For my safety, I carry firearms during my
travels, and finding the right gear is essential. Recently, I was in search of
a Colt Python holster and discovered Wright Leather Works, a premier custom
leather holster maker based in Ohio. They specialize in creating high-quality
holsters that offer comfort, security, and confidence for concealed carry. The
Colt Python holster I received from them is exceptional—crafted with attention
to detail and providing a perfect fit. If you're in need of a reliable and
custom holster for your Colt Python, I highly recommend Wright Leather Works.
Their dedication to quality craftsmanship ensures you'll carry comfortably and
securely on your travels.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [PATCH] acl: fix build with GCC 15 on aarch64

[Bruce Richardson]

On Thu, Mar 27, 2025 at 10:39:09AM +, Konstantin Ananyev wrote:
> 
> 
> > -Original Message-
> > From: David Marchand 
> > Sent: Thursday, March 27, 2025 10:37 AM
> > To: Bruce Richardson 
> > Cc: dev@dpdk.org; bl...@debian.org; sta...@dpdk.org; Konstantin Ananyev 
> > ; David Christensen
> > ; Wathsala Vithanage 
> > Subject: Re: [PATCH] acl: fix build with GCC 15 on aarch64
> > 
> > On Thu, Mar 27, 2025 at 9:55 AM Bruce Richardson
> >  wrote:
> > >
> > > On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote:
> > > > Caught in OBS for Fedora Rawhide on aarch64:
> > > >
> > > > [  198s] In file included from ../lib/acl/acl_run_neon.h:7,
> > > > [  198s]  from ../lib/acl/acl_run_neon.c:5:
> > > > [  198s] In function ‘alloc_completion’,
> > > > [  198s] inlined from ‘acl_start_next_trie’ at
> > > >   ../lib/acl/acl_run.h:140:24,
> > > > [  198s] inlined from ‘search_neon_4.isra’ at
> > > >   ../lib/acl/acl_run_neon.h:239:20:
> > > > [  198s] ../lib/acl/acl_run.h:93:25: error: ‘cmplt’ may be used
> > > >   uninitialized [-Werror=maybe-uninitialized]
> > > > [  198s]93 | if (p[n].count == 0) {
> > > > [  198s]   | ^~
> > > > [  198s] ../lib/acl/acl_run_neon.h: In function ‘search_neon_4.isra’:
> > > > [  198s] ../lib/acl/acl_run_neon.h:230:27: note: ‘cmplt’ declared here
> > > > [  198s]   230 | struct completion cmplt[4];
> > > > [  198s]   |   ^
> > > >
> > > > The code was resetting sequentially cmpl[].count at the exact index that
> > > > later call to alloc_completion uses.
> > > > While this code seems correct, GCC 15 does not understand this (probably
> > > > when applying some optimisations).
> > > >
> > > > Instead, reset cmpl[].count all at once in acl_set_flow, and cleanup the
> > > > various vectorized implementations accordingly.
> > > >
> > > > Bugzilla ID: 1678
> > > > Cc: sta...@dpdk.org
> > > >
> > > > Signed-off-by: David Marchand 
> > > > ---
> > > >  lib/acl/acl_run.h | 5 +
> > > >  lib/acl/acl_run_altivec.h | 8 ++--
> > > >  lib/acl/acl_run_avx2.h| 4 +---
> > > >  lib/acl/acl_run_neon.h| 8 ++--
> > > >  lib/acl/acl_run_scalar.c  | 4 +---
> > > >  lib/acl/acl_run_sse.h | 8 ++--
> > > >  6 files changed, 13 insertions(+), 24 deletions(-)
> > > >
> > > > diff --git a/lib/acl/acl_run.h b/lib/acl/acl_run.h
> > > > index 7f092413cd..9fd3e60021 100644
> > > > --- a/lib/acl/acl_run.h
> > > > +++ b/lib/acl/acl_run.h
> > > > @@ -176,6 +176,8 @@ acl_set_flow(struct acl_flow_data *flows, struct 
> > > > completion *cmplt,
> > > >   uint32_t cmplt_size, const uint8_t **data, uint32_t *results,
> > > >   uint32_t data_num, uint32_t categories, const uint64_t *trans)
> > > >  {
> > > > + unsigned int i;
> > > > +
> > > >   flows->num_packets = 0;
> > > >   flows->started = 0;
> > > >   flows->trie = 0;
> > > > @@ -187,6 +189,9 @@ acl_set_flow(struct acl_flow_data *flows, struct 
> > > > completion *cmplt,
> > > >   flows->data = data;
> > > >   flows->results = results;
> > > >   flows->trans = trans;
> > > > +
> > > > + for (i = 0; i < cmplt_size; i++)
> > > > + cmplt[i].count = 0;
> > > >  }
> > >
> > > Minor nit, but since we are using c11 standard, is it not better to 
> > > declare
> > > "i" inside the "for" statement. Keeps diffs simpler for adding/removing
> > > code, I think.
> > 
> > I still have this (bad) habit but yes, it looks nicer with declaring
> > in for() itself.
> 
> My vote would be to keep it in an old fashioned way.
> Nothing is wrong in defining variable to use at the start of the function :) 
>  

No, there isn't. However, there is also a reason why later GCC revisions
and modern languages allow use of a temporary variable defined within the
loop itself. Cognitively, it's easier to have variables defined at point of
use, as it saves the user having to mentally track them or move up and down the
code. Furthermore, when debugging or reworking the code, it's far easier to
have the variable inside the "for" statement as it means that as we
comment/uncomment, or remove/re-add, the code block, the variable definition
also gets commented/uncommented too, without having to constantly scroll up
to make changes in two places. Lastly, it makes for smaller git diffs too.

/Bruce

[PATCH v4 1/4] net/intel: align Tx queue struct field names

[Shaiq Wani]

Align the Tx queue struct field names in idpf and
cpfl driver with the common Tx queue struct.

Signed-off-by: Shaiq Wani 
---
 drivers/net/intel/cpfl/cpfl_rxtx.c| 40 -
 drivers/net/intel/cpfl/cpfl_rxtx_vec_common.h |  4 +-
 drivers/net/intel/idpf/idpf_common_rxtx.c | 72 
 drivers/net/intel/idpf/idpf_common_rxtx.h | 21 ++---
 .../net/intel/idpf/idpf_common_rxtx_avx2.c| 44 +-
 .../net/intel/idpf/idpf_common_rxtx_avx512.c  | 84 +--
 drivers/net/intel/idpf/idpf_common_virtchnl.c |  6 +-
 drivers/net/intel/idpf/idpf_rxtx.c| 24 +++---
 drivers/net/intel/idpf/idpf_rxtx_vec_common.h |  4 +-
 9 files changed, 150 insertions(+), 149 deletions(-)

diff --git a/drivers/net/intel/cpfl/cpfl_rxtx.c 
b/drivers/net/intel/cpfl/cpfl_rxtx.c
index 47351ca102..8eed8f16d5 100644
--- a/drivers/net/intel/cpfl/cpfl_rxtx.c
+++ b/drivers/net/intel/cpfl/cpfl_rxtx.c
@@ -249,7 +249,7 @@ cpfl_rx_split_bufq_setup(struct rte_eth_dev *dev, struct 
idpf_rx_queue *rxq,
idpf_qc_split_rx_bufq_reset(bufq);
bufq->qrx_tail = hw->hw_addr + (vport->chunks_info.rx_buf_qtail_start +
 queue_idx * vport->chunks_info.rx_buf_qtail_spacing);
-   bufq->ops = &def_rxq_ops;
+   bufq->idpf_ops = &def_rxq_ops;
bufq->q_set = true;
 
if (bufq_id == IDPF_RX_SPLIT_BUFQ1_ID) {
@@ -310,7 +310,7 @@ cpfl_rx_queue_release(void *rxq)
}
 
/* Single queue */
-   q->ops->release_mbufs(q);
+   q->idpf_ops->release_mbufs(q);
rte_free(q->sw_ring);
rte_memzone_free(q->mz);
rte_free(cpfl_rxq);
@@ -332,7 +332,7 @@ cpfl_tx_queue_release(void *txq)
rte_free(q->complq);
}
 
-   q->ops->release_mbufs(q);
+   q->idpf_ops->release_mbufs(q);
rte_free(q->sw_ring);
rte_memzone_free(q->mz);
rte_free(cpfl_txq);
@@ -426,7 +426,7 @@ cpfl_rx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
idpf_qc_single_rx_queue_reset(rxq);
rxq->qrx_tail = hw->hw_addr + 
(vport->chunks_info.rx_qtail_start +
queue_idx * 
vport->chunks_info.rx_qtail_spacing);
-   rxq->ops = &def_rxq_ops;
+   rxq->idpf_ops = &def_rxq_ops;
} else {
idpf_qc_split_rx_descq_reset(rxq);
 
@@ -501,7 +501,7 @@ cpfl_tx_complq_setup(struct rte_eth_dev *dev, struct 
idpf_tx_queue *txq,
ret = -ENOMEM;
goto err_mz_reserve;
}
-   cq->tx_ring_phys_addr = mz->iova;
+   cq->tx_ring_dma = mz->iova;
cq->compl_ring = mz->addr;
cq->mz = mz;
idpf_qc_split_tx_complq_reset(cq);
@@ -565,8 +565,8 @@ cpfl_tx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
is_splitq = !!(vport->txq_model == VIRTCHNL2_QUEUE_MODEL_SPLIT);
 
txq->nb_tx_desc = nb_desc;
-   txq->rs_thresh = tx_rs_thresh;
-   txq->free_thresh = tx_free_thresh;
+   txq->tx_rs_thresh = tx_rs_thresh;
+   txq->tx_free_thresh = tx_free_thresh;
txq->queue_id = vport->chunks_info.tx_start_qid + queue_idx;
txq->port_id = dev->data->port_id;
txq->offloads = cpfl_tx_offload_convert(offloads);
@@ -585,7 +585,7 @@ cpfl_tx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
ret = -ENOMEM;
goto err_mz_reserve;
}
-   txq->tx_ring_phys_addr = mz->iova;
+   txq->tx_ring_dma = mz->iova;
txq->mz = mz;
 
txq->sw_ring = rte_zmalloc_socket("cpfl tx sw ring",
@@ -598,7 +598,7 @@ cpfl_tx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
}
 
if (!is_splitq) {
-   txq->tx_ring = mz->addr;
+   txq->idpf_tx_ring = mz->addr;
idpf_qc_single_tx_queue_reset(txq);
} else {
txq->desc_ring = mz->addr;
@@ -613,7 +613,7 @@ cpfl_tx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
 
txq->qtx_tail = hw->hw_addr + (vport->chunks_info.tx_qtail_start +
queue_idx * vport->chunks_info.tx_qtail_spacing);
-   txq->ops = &def_txq_ops;
+   txq->idpf_ops = &def_txq_ops;
cpfl_vport->nb_data_txq++;
txq->q_set = true;
dev->data->tx_queues[queue_idx] = cpfl_txq;
@@ -663,7 +663,7 @@ cpfl_rx_hairpin_bufq_setup(struct rte_eth_dev *dev, struct 
idpf_rx_queue *bufq,
bufq->rx_buf_len = CPFL_P2P_MBUF_SIZE - RTE_PKTMBUF_HEADROOM;
 
bufq->q_set = true;
-   bufq->ops = &def_rxq_ops;
+   bufq->idpf_ops = &def_rxq_ops;
 
return 0;
 }
@@ -860,7 +860,7 @@ cpfl_tx_hairpin_queue_setup(struct rte_eth_dev *dev, 
uint16_t queue_idx,
goto err_txq_mz_rsv;
}
 
-   txq->tx_ring_phys_addr = mz->iova;
+   txq->tx_ring_dma = mz->iova;
txq->desc_ring = mz->addr;
txq->mz = mz;
 
@@ -868,7 +868,7 @@ cpfl_tx_hairpin_queue_setup(struct rte_eth_dev *dev, 
uint16_t queue_i

Re: DPDK compilers and RHEL 7 support

[Kevin Traynor]

On 27/03/2025 07:55, Morten Brørup wrote:
> + Red Hat tech board members
> 
>> From: Stephen Hemminger [mailto:step...@networkplumber.org]
>> Sent: Wednesday, 26 March 2025 20.21
>>
>> On Wed, 26 Mar 2025 19:06:58 +0100
>> Morten Brørup  wrote:
>>
 From: Bruce Richardson [mailto:bruce.richard...@intel.com]
 Sent: Wednesday, 26 March 2025 17.22

 On Tue, Mar 25, 2025 at 05:22:15PM +, Bruce Richardson wrote:
> When doing a build for a target that already has the instruction
>> sets
> for AVX2/AVX512 enabled, skip emitting the AVX compiler flags, or
>> the
> skylake-avx512 '-march' flags, as they are unnecessary. Instead,
>> when
> the default flags produce the desired output, just use them
 unmodified.
>
> Depends-on: series-34915 ("remove component-specific logic for
>> AVX
 builds")
>
> Signed-off-by: Bruce Richardson 
> ---
>
> This patchset depends on the previous AVX rework. However,
>> sending it
> separately as a new RFC because it effectively increases the
>> minimum
> compiler versions needed for x86 builds - from GCC 5 to 6, and
> Clang 3.6 to 3.9.
>
> For now, I've just documented that as an additional note in the
>> GSG
 that
> these versions are recommended, but it would be simpler if we
>> could
 just
> set them as the required minimum baseline (at least in the docs).
>
> Feedback on these compiler version requirements welcome.
>

 +techboard

 Ping for a little bit of feedback for this. Are we ok to bump the
 minimum
 compiler versions as described above, or will I continue with the
 approach
 in this RFC of keeping the minimum and just recommending the higher
 versions for x86 platforms?

 For reference GCC 6.1 was released April 2016[1], and, Clang 3.9
>> was
 released Sept 2016[2]

 /Bruce

 [1] https://gcc.gnu.org/gcc-6/
 [2] https://releases.llvm.org/
>>>
>>> Considering GCC versions shipped with RHEL [3]...
>>> We kind of support RHEL 7, but we already require a newer compiler
>> (GCC 5) than shipped with RHEL 7 (GCC 4.8).
>>> RHEL 8 ships with GCC 8, which was released in May 2018 [4]. Maybe we
>> can jump to GCC 8?
>>>
>>> BTW, we should also apply the same principle I argued [5] should
>> apply for upgrading the Kernel requirements: There should be a need for
>> specific feature or similar - which there is with your patch - and the
>> details should be mentioned in the release notes.
>>>
>>> [3]: https://access.redhat.com/solutions/19458
>>> [4]: https://gcc.gnu.org/gcc-8/
>>> [5]:
>> https://inbox.dpdk.org/dev/CAMEVEZutf4sJ=EQFONw_bJW0tGTWqTbF_Tk_y38qzBL
>> ccco...@mail.gmail.com/T/#me7c8f1dbe4331ccf232d43512d6ddb51458c568a
>>>
>>
>> RHEL 7 reached end of life on June 30, 2024.
>> DPDK need no longer support it on future versions.
> 
> CentOS 7 reached EOL June 2024, yes.
> RHEL 7 reached End of Maintenance June 2024, but RHEL 7 Extended Life Cycle 
> Support is available until June 2028 [6].
> 
> Although RHEL 7 not fully EOL, I would consider "End Of Maintenance" 
> sufficiently dead for future DPDK versions not needing to support it.
> If you are running a production system on a distro that's on Extended Life 
> Cycle Support, you shouldn't deploy a new DPDK version - and if you do 
> anyway, it's your own problem, not the DPDK community's problem.
> @Aaron, @Kevin, @Maxime - speak up if you disagree!
> 

+1

Red Hat will not release new RHEL 7 DPDK packages now and there are no
new features/versions of RHEL 7.

I agree if anyone is running RHEL(/CentOS) 7 at this point, they should
not expect that they can just use new versions of DPDK on it without
having to resolve the dependencies themselves.

> 
> [6]: 
> https://www.redhat.com/en/technologies/linux-platforms/enterprise-linux/rhel-7-end-of-maintenance
> 

[PATCH] cnxk: use stdatomic API

[pbhagavatula]

From: Pavan Nikhilesh 

Replace GCC inbuilt atomic functions with rte_atomic_xxx API.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 36 ++-
 drivers/crypto/cnxk/cn9k_cryptodev_ops.c  | 20 +--
 drivers/net/cnxk/cn10k_tx.h   | 42 +--
 drivers/net/cnxk/cn20k_tx.h   | 39 -
 drivers/net/cnxk/cn9k_tx.h|  5 +--
 5 files changed, 79 insertions(+), 63 deletions(-)

diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c 
b/drivers/crypto/cnxk/cn10k_cryptodev_ops.c
index dbebc5aef1..fe28c7529d 100644
--- a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c
+++ b/drivers/crypto/cnxk/cn10k_cryptodev_ops.c
@@ -292,7 +292,7 @@ cn10k_cpt_fill_inst(struct cnxk_cpt_qp *qp, struct 
rte_crypto_op *ops[], struct
}
 
inst[0].res_addr = (uint64_t)&infl_req->res;
-   __atomic_store_n(&infl_req->res.u64[0], res.u64[0], __ATOMIC_RELAXED);
+   rte_atomic_store_explicit(&infl_req->res.u64[0], res.u64[0], 
rte_memory_order_relaxed);
infl_req->cop = op;
 
inst[0].w7.u64 = w7;
@@ -361,7 +361,7 @@ cn10k_cpt_enqueue_burst(void *qptr, struct rte_crypto_op 
**ops, uint16_t nb_ops,
inst = (struct cpt_inst_s *)lmt_base;
 
 again:
-   fc.u64[0] = __atomic_load_n(fc_addr, __ATOMIC_RELAXED);
+   fc.u64[0] = rte_atomic_load_explicit(fc_addr, rte_memory_order_relaxed);
if (unlikely(fc.s.qsize > fc_thresh)) {
i = 0;
goto pend_q_commit;
@@ -392,7 +392,7 @@ cn10k_cpt_enqueue_burst(void *qptr, struct rte_crypto_op 
**ops, uint16_t nb_ops,
}
 
 pend_q_commit:
-   rte_atomic_thread_fence(__ATOMIC_RELEASE);
+   rte_atomic_thread_fence(rte_memory_order_release);
 
pend_q->head = head;
pend_q->time_out = rte_get_timer_cycles() +
@@ -541,7 +541,7 @@ cn10k_cpt_vec_inst_fill(struct vec_request *vec_req, struct 
cpt_inst_s *inst,
infl_req->qp = qp;
 
inst->res_addr = (uint64_t)&infl_req->res;
-   __atomic_store_n(&infl_req->res.u64[0], res.u64[0], __ATOMIC_RELAXED);
+   rte_atomic_store_explicit(&infl_req->res.u64[0], res.u64[0], 
rte_memory_order_relaxed);
 
inst->w0.u64 = 0;
inst->w2.u64 = vec_req->w2;
@@ -593,7 +593,7 @@ cn10k_cpt_vec_submit(struct vec_request vec_tbl[], uint16_t 
vec_tbl_len, struct
cn10k_cpt_vec_inst_fill(&vec_tbl[i], &inst[i], qp, 
vec_tbl[0].w7);
 
do {
-   fc.u64[0] = __atomic_load_n(fc_addr, __ATOMIC_RELAXED);
+   fc.u64[0] = rte_atomic_load_explicit(fc_addr, 
rte_memory_order_relaxed);
if (likely(fc.s.qsize < fc_thresh))
break;
if (unlikely(rte_get_timer_cycles() > timeout))
@@ -644,7 +644,7 @@ ca_lmtst_vec_submit(struct ops_burst *burst, struct 
vec_request vec_tbl[], uint1
 #endif
 
/* Perform fc check before putting packets into vectors */
-   fc.u64[0] = __atomic_load_n(fc_addr, __ATOMIC_RELAXED);
+   fc.u64[0] = rte_atomic_load_explicit(fc_addr, rte_memory_order_relaxed);
if (unlikely(fc.s.qsize > fc_thresh)) {
rte_errno = EAGAIN;
return 0;
@@ -789,7 +789,7 @@ ca_lmtst_burst_submit(struct ops_burst *burst, const bool 
is_sg_ver2)
inst->w3.u64 = CNXK_CPT_INST_W3(1, infl_req);
}
 
-   fc.u64[0] = __atomic_load_n(fc_addr, __ATOMIC_RELAXED);
+   fc.u64[0] = rte_atomic_load_explicit(fc_addr, rte_memory_order_relaxed);
if (unlikely(fc.s.qsize > fc_thresh)) {
rte_errno = EAGAIN;
for (j = 0; j < i; j++) {
@@ -1237,7 +1237,7 @@ cn10k_cpt_crypto_adapter_dequeue(uintptr_t get_work1)
cop = infl_req->cop;
qp = infl_req->qp;
 
-   res.u64[0] = __atomic_load_n(&infl_req->res.u64[0], __ATOMIC_RELAXED);
+   res.u64[0] = rte_atomic_load_explicit(&infl_req->res.u64[0], 
rte_memory_order_relaxed);
 
cn10k_cpt_dequeue_post_process(qp, infl_req->cop, infl_req, &res.cn10k);
 
@@ -1267,7 +1267,7 @@ cn10k_cpt_crypto_adapter_vector_dequeue(uintptr_t 
get_work1)
req_mp = qp->ca.req_mp;
 
 #ifdef CNXK_CRYPTODEV_DEBUG
-   res.u64[0] = __atomic_load_n(&vec_infl_req->res.u64[0], 
__ATOMIC_RELAXED);
+   res.u64[0] = rte_atomic_load_explicit(&vec_infl_req->res.u64[0], 
rte_memory_order_relaxed);
PLT_ASSERT(res.cn10k.compcode == CPT_COMP_GOOD);
PLT_ASSERT(res.cn10k.uc_compcode == 0);
 #endif
@@ -1276,7 +1276,8 @@ cn10k_cpt_crypto_adapter_vector_dequeue(uintptr_t 
get_work1)
infl_req = vec->ptrs[i];
cop = infl_req->cop;
 
-   res.u64[0] = __atomic_load_n(&infl_req->res.u64[0], 
__ATOMIC_RELAXED);
+   res.u64[0] =
+   rte_atomic_load_explicit(&infl_req->res.u64[0], 
rte_memory_order_relaxed);
cn10k_cpt_dequeue_post_process(qp, cop, infl_req, &res.cn10k);
 
vec->ptrs[i] = cop;

[PATCH] devtools: exclude atomic checks for common cnxk

[pbhagavatula]

From: Pavan Nikhilesh 

Since driver/common/cnxk has common code that is
used across multiple platforms, allow use of
GCC builtin atomic functions.

Signed-off-by: Pavan Nikhilesh 
---
 Rest of drivers i.e., drivers/*/cnxk have been migrated to use stdatomics in:
 
https://patchwork.dpdk.org/project/dpdk/patch/2025032720.1641-1-pbhagavat...@marvell.com/

 devtools/checkpatches.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index c9088bb403..2470d4fa83 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -139,6 +139,7 @@ check_forbidden_additions() { # 

# refrain from using compiler __atomic_xxx builtins
awk -v FOLDERS="lib drivers app examples" \
+   -v SKIP_FILES='drivers/common/cnxk/' \
-v EXPRESSIONS="__atomic_.*\\\( 
__ATOMIC_(RELAXED|CONSUME|ACQUIRE|RELEASE|ACQ_REL|SEQ_CST)" \
-v RET_ON_FAIL=1 \
-v MESSAGE='Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer 
rte_atomic_xxx/rte_memory_order_xxx' \
--
2.43.0

RE: [PATCH] acl: fix build with GCC 15 on aarch64

[Konstantin Ananyev]

> On Thu, Mar 27, 2025 at 12:10:12PM +, Konstantin Ananyev wrote:
> >
> >
> > > > >
> > > > > > -Original Message-
> > > > > > From: David Marchand 
> > > > > > Sent: Thursday, March 27, 2025 10:37 AM
> > > > > > To: Bruce Richardson 
> > > > > > Cc: dev@dpdk.org; bl...@debian.org; sta...@dpdk.org; Konstantin
> > > > Ananyev ; David Christensen
> > > > > > ; Wathsala Vithanage
> > > > 
> > > > > > Subject: Re: [PATCH] acl: fix build with GCC 15 on aarch64
> > > > > >
> > > > > > On Thu, Mar 27, 2025 at 9:55 AM Bruce Richardson
> > > > > >  wrote:
> > > > > > >
> > > > > > > On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote:
> > > > > > > > Caught in OBS for Fedora Rawhide on aarch64:
> > > > > > > >
> > > > > > > > [  198s] In file included from ../lib/acl/acl_run_neon.h:7,
> > > > > > > > [  198s]  from ../lib/acl/acl_run_neon.c:5:
> > > > > > > > [  198s] In function ‘alloc_completion’,
> > > > > > > > [  198s] inlined from ‘acl_start_next_trie’ at
> > > > > > > >   ../lib/acl/acl_run.h:140:24,
> > > > > > > > [  198s] inlined from ‘search_neon_4.isra’ at
> > > > > > > >   ../lib/acl/acl_run_neon.h:239:20:
> > > > > > > > [  198s] ../lib/acl/acl_run.h:93:25: error: ‘cmplt’ may be used
> > > > > > > >   uninitialized [-Werror=maybe-uninitialized]
> > > > > > > > [  198s]93 | if (p[n].count == 0) {
> > > > > > > > [  198s]   | ^~
> > > > > > > > [  198s] ../lib/acl/acl_run_neon.h: In function
> > > > ‘search_neon_4.isra’:
> > > > > > > > [  198s] ../lib/acl/acl_run_neon.h:230:27: note: ‘cmplt’
> > > > declared here
> > > > > > > > [  198s]   230 | struct completion cmplt[4];
> > > > > > > > [  198s]   |   ^
> > > > > > > >
> > > > > > > > The code was resetting sequentially cmpl[].count at the exact
> > > > index that
> > > > > > > > later call to alloc_completion uses.
> > > > > > > > While this code seems correct, GCC 15 does not understand this
> > > > (probably
> > > > > > > > when applying some optimisations).
> > > > > > > >
> > > > > > > > Instead, reset cmpl[].count all at once in acl_set_flow, and
> > > > cleanup the
> > > > > > > > various vectorized implementations accordingly.
> > > > > > > >
> > > > > > > > Bugzilla ID: 1678
> > > > > > > > Cc: sta...@dpdk.org
> > > > > > > >
> > > > > > > > Signed-off-by: David Marchand 
> > > > > > > > ---
> > > > > > > >  lib/acl/acl_run.h | 5 +
> > > > > > > >  lib/acl/acl_run_altivec.h | 8 ++--
> > > > > > > >  lib/acl/acl_run_avx2.h| 4 +---
> > > > > > > >  lib/acl/acl_run_neon.h| 8 ++--
> > > > > > > >  lib/acl/acl_run_scalar.c  | 4 +---
> > > > > > > >  lib/acl/acl_run_sse.h | 8 ++--
> > > > > > > >  6 files changed, 13 insertions(+), 24 deletions(-)
> > > > > > > >
> > > > > > > > diff --git a/lib/acl/acl_run.h b/lib/acl/acl_run.h
> > > > > > > > index 7f092413cd..9fd3e60021 100644
> > > > > > > > --- a/lib/acl/acl_run.h
> > > > > > > > +++ b/lib/acl/acl_run.h
> > > > > > > > @@ -176,6 +176,8 @@ acl_set_flow(struct acl_flow_data *flows,
> > > > struct completion *cmplt,
> > > > > > > >   uint32_t cmplt_size, const uint8_t **data, uint32_t
> > > > *results,
> > > > > > > >   uint32_t data_num, uint32_t categories, const uint64_t
> > > > *trans)
> > > > > > > >  {
> > > > > > > > + unsigned int i;
> > > > > > > > +
> > > > > > > >   flows->num_packets = 0;
> > > > > > > >   flows->started = 0;
> > > > > > > >   flows->trie = 0;
> > > > > > > > @@ -187,6 +189,9 @@ acl_set_flow(struct acl_flow_data *flows,
> > > > struct completion *cmplt,
> > > > > > > >   flows->data = data;
> > > > > > > >   flows->results = results;
> > > > > > > >   flows->trans = trans;
> > > > > > > > +
> > > > > > > > + for (i = 0; i < cmplt_size; i++)
> > > > > > > > + cmplt[i].count = 0;
> > > > > > > >  }
> > > > > > >
> > > > > > > Minor nit, but since we are using c11 standard, is it not better
> > > > to declare
> > > > > > > "i" inside the "for" statement. Keeps diffs simpler for
> > > > adding/removing
> > > > > > > code, I think.
> > > > > >
> > > > > > I still have this (bad) habit but yes, it looks nicer with
> > > > declaring
> > > > > > in for() itself.
> > > > >
> > > > > My vote would be to keep it in an old fashioned way.
> > > > > Nothing is wrong in defining variable to use at the start of the
> > > > function :)
> > > > >
> > > >
> > > > No, there isn't. However, there is also a reason why later GCC
> > > > revisions
> > > > and modern languages allow use of a temporary variable defined within
> > > > the
> > > > loop itself. Cognitively, it's easier to have variables defined at
> > > > point of
> > > > use, as it saves the user having to mentally track them or move up and
> > > > down the
> > > > code. Furthermore, when debugging or reworking the code, it's far
> > > > easier to
> > > > have the variable inside the "for" s

RE: Dpdk-pdump not capturing packet for vmxnet3 device

[Rajesh Goel (rajegoel)]

Thanks Stephen.

I checked this module is not present in 20.11 dpdk version, but its in 23.11
But can you suggest if I need to port this back to 20.11, any necessary steps I 
can follow or any dependencies with the new version etc,

Thanks
Rajesh

-Original Message-
From: Stephen Hemminger  
Sent: 19 March 2025 21:58
To: Rajesh Goel (rajegoel) 
Cc: dev@dpdk.org
Subject: Re: Dpdk-pdump not capturing packet for vmxnet3 device

On Wed, 19 Mar 2025 07:21:30 +
"Rajesh Goel (rajegoel)"  wrote:

> Hi DPDK community,
> 
> I need some urgent help.
> 
> 1)  Iam running my dpdk application on a VMware based VM. Iam using 
> 20.11.9 dpdk version
> Iam directly connected to the PCI device to receive pkts on my application.
> 
>   :
>   EAL: Detected 16 lcore(s)
>   EAL: Detected 1 NUMA nodes
>   EAL: Detected shared linkage of DPDK
>   EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
>   EAL: Selected IOVA mode 'PA'
>   EAL: No available hugepages reported in hugepages-1048576kB
>   EAL: Probing VFIO support...
>   EAL: VFIO support initialized
>   EAL: Probe PCI driver: net_vmxnet3 (15ad:7b0) device: :04:00.0 
> (socket 0)
>   EAL: No legacy callbacks, legacy socket not created
>   :
> 
> 2)  Iam trying to use dpdk-pdump application to capture packets.
> 
>   dpdk-pdump -l 3 -- --pdump 
> 'device_id=:04:00.0,queue=*,rx-dev=/tmp/rx.pcap,total-num-mbufs=8192,ring-size=128'
> 
>   EAL: Detected 16 lcore(s)
>   EAL: Detected 1 NUMA nodes
>   EAL: Detected static linkage of DPDK
>   EAL: Multi-process socket 
> /var/run/dpdk/rte/mp_socket_644376_50d5dc20612f8
>   EAL: Selected IOVA mode 'PA'
>   EAL: Probing VFIO support...
>   EAL: VFIO support initialized
>   EAL: Probe PCI driver: net_vmxnet3 (15ad:7b0) device: :04:00.0 
> (socket 0)
>   Port 1 MAC: 02 70 63 61 70 00
>core (3), capture for (1) tuples
>- port 0 device (:04:00.0) queue 65535
>   ^C
> 
>   Signal 2 received, preparing to exit...
>   # PDUMP DEBUG STATS #
>-packets dequeued:   0
>-packets transmitted to vdev:0
>-packets freed:  0
> 
> This is the mempool and ring which got created in app side
> 
> ring @0x10045db00
>   flags=0
>   size=16384
>   capacity=16383
>   ct=0
>   ch=0
>   pt=8192
>   ph=8192
>   used=8192
>   avail=8191
> ring @0x102802680
>   flags=0
>   size=128
>   capacity=127
>   ct=0
>   ch=0
>   pt=0
>   ph=0
>   used=0
>   avail=127
> 
> This is the port output, port 0 is application and port 1 is created by pdump 
> and no pkt is seen to be captured.
> 
> Port 0 stats:
>  - link status: 1
>  - Pkts in:   50
>  - Pkts out:  0
>  - total ibytes: 4024
>  - total obytes: 0
>  - rx miss: 0
>  - In Errs:   0
>  - Out Errs:  0
>  - Mbuf Errs: 0
>  - Q Rx Packets:
> 
> Port 1 stats:
>  - link status: 1
>  - Pkts in:   0
>  - Pkts out:  0
>  - total ibytes: 0
>  - total obytes: 0
>  - rx miss: 0
>  - In Errs:   0
>  - Out Errs:  0
>  - Mbuf Errs: 0
>  - Q Rx Packets:
> 
> 3)  I see the same result while using dpdk-testpmd on the APP side.
> 
> 4)  As per this page, https://doc.dpdk.org/guides/tools/pdump.html.
>   Is this applicable to vmxnet3 device here ??
> 
> *   As of now the dpdk-pdump tool cannot capture the packets of virtual 
> devices in the primary process due to a bug in the ethdev library. Due to 
> this bug, in a multi process context, when the primary and secondary have 
> different ports set, then the secondary process (here the dpdk-pdump tool) 
> overwrites the rte_eth_devices[] entries of the primary process.
> 
> Thanks
> Rajesh
> 
> 

Try dpdk-dumpcap instead. Pdump is limited and will not get any new features.
I am going to propose deprecating pdump in 25.11.

Re: Driver: bnxt_en

[Eldho Paul Mathew]

Hi All,

What is the importance of the 'ice' driver?

Right now I am using 18.05.1. Does it have 'ice' driver support?

We bought a new card: BCM57508 NetXtreme-E 10Gb/25Gb/40Gb/50Gb/100Gb/200Gb
Ethernet

To support this card using the 'ice' driver, is the DPDK 18.05.1 version
sufficient, or is there any other driver that is the placeholder for 'ice'
in 18.05.1?

If I need to go for an upgrade, which is the minimum version to support
this card by 'ice'?

Kindly help!



On Fri, Jan 10, 2025 at 11:34 PM Stephen Hemminger <
step...@networkplumber.org> wrote:

> On Fri, 10 Jan 2025 10:02:48 +0530
> Eldho Paul Mathew  wrote:
>
> > We are using DPDK 18.05.1
> >
> > We received a new network card.
> >
> > Broadcom Inc. and subsidiaries BCM57414 NetXtreme-E 10Gb/25Gb RDMA
> Ethernet
> > Controller
> >
> > DPDK 18.05.1 has support for this card and driver bnxt_en?
> >
> > If not, which stable version onwards has this driver support added?
>
> Release 18.05 is not a stable LTS version.
>
> Let me teach you how to look this question up.
>
> To look up device you need the actual PCI-ID, using pcilookup.com
> 14e4:16d7
>
> Look at source of drivers/net/bnxt/bnxt_ethdev.c for the pci table
> bnxt_id_pci_map.
> The entry for 16d7 is
> #define BROADCOM_DEV_ID_57414   0x16d7
>
> Using git blame find the commit that added that:
>
> $ git blame drivers/net/bnxt/bnxt_ethdev.c | grep BROADCOM_DEV_ID_57414
> 3fab7694403 (Ajit Khaparde   2017-04-26 14:20:02 -0500
>  51){ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414_VF)
> },
> 1f4a84672ec (Ajit Khaparde   2017-01-06 13:55:17 -0600
>  60){ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414) },
> 1f4a84672ec (Ajit Khaparde   2017-01-06 13:55:17 -0600
>  68){ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414_MF)
> },
> 3f6d59b0c88 (Kalesh AP   2019-12-02 09:48:07 +0530
> 4999)case BROADCOM_DEV_ID_57414_VF:
>
> So we want 1f4a84672ec
>
> If you look at that commit with a tool like gitk it shows it happened way
> back in 17.02
> And the card is listed in driver for 18.11
>
>

[PATCH v5 2/8] drivers: remove incorrect exported symbols

[David Marchand]

Declaring inline helpers in version.map is unnecessary.
There is no exported symbol and this will probably be treated as an
error by MSVC linker.

rte_dpaa2_dev_type is an enum token.
roc_se_ctx_swap has no implementation (leftover from a previous rework)
and can be removed.

Signed-off-by: David Marchand 
---
 drivers/bus/dpaa/version.map| 1 -
 drivers/bus/fslmc/version.map   | 2 --
 drivers/common/cnxk/roc_se.h| 1 -
 drivers/common/cnxk/version.map | 2 --
 4 files changed, 6 deletions(-)

diff --git a/drivers/bus/dpaa/version.map b/drivers/bus/dpaa/version.map
index a17d57632e..8f09b72757 100644
--- a/drivers/bus/dpaa/version.map
+++ b/drivers/bus/dpaa/version.map
@@ -18,7 +18,6 @@ INTERNAL {
dpaa_update_link_speed;
dpaa_intr_disable;
dpaa_intr_enable;
-   dpaa_seqn;
dpaa_svr_family;
dpaa_update_link_status;
fman_dealloc_bufs_mask_hi;
diff --git a/drivers/bus/fslmc/version.map b/drivers/bus/fslmc/version.map
index 2c36895285..ba3c7f36e3 100644
--- a/drivers/bus/fslmc/version.map
+++ b/drivers/bus/fslmc/version.map
@@ -22,7 +22,6 @@ INTERNAL {
dpaa2_get_mcp_ptr;
dpaa2_io_portal;
dpaa2_seqn_dynfield_offset;
-   dpaa2_seqn;
dpaa2_svr_family;
dpbp_disable;
dpbp_enable;
@@ -108,7 +107,6 @@ INTERNAL {
qbman_swp_push_set;
qbman_swp_release;
rte_dpaa2_alloc_dpci_dev;
-   rte_dpaa2_dev_type;
rte_dpaa2_free_dpci_dev;
rte_dpaa2_intr_disable;
rte_dpaa2_intr_enable;
diff --git a/drivers/common/cnxk/roc_se.h b/drivers/common/cnxk/roc_se.h
index ede8d69c0e..f2c4056169 100644
--- a/drivers/common/cnxk/roc_se.h
+++ b/drivers/common/cnxk/roc_se.h
@@ -405,7 +405,6 @@ int __roc_api roc_se_auth_key_set(struct roc_se_ctx 
*se_ctx, roc_se_auth_type ty
 int __roc_api roc_se_ciph_key_set(struct roc_se_ctx *se_ctx, 
roc_se_cipher_type type,
  const uint8_t *key, uint16_t key_len);
 
-void __roc_api roc_se_ctx_swap(struct roc_se_ctx *se_ctx);
 void __roc_api roc_se_ctx_init(struct roc_se_ctx *se_ctx);
 
 void __roc_api roc_se_hmac_opad_ipad_gen(roc_se_auth_type auth_type, const 
uint8_t *key,
diff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map
index cdbfc1d39a..7f40dcced2 100644
--- a/drivers/common/cnxk/version.map
+++ b/drivers/common/cnxk/version.map
@@ -164,7 +164,6 @@ INTERNAL {
roc_mcs_custom_tag_cfg_get;
roc_mcs_dev_init;
roc_mcs_dev_fini;
-   roc_mcs_dev_get;
roc_mcs_event_cb_register;
roc_mcs_event_cb_unregister;
roc_mcs_flowid_entry_enable;
@@ -546,7 +545,6 @@ INTERNAL {
roc_tim_lf_enable;
roc_tim_lf_free;
roc_tim_lf_interval;
-   roc_se_ctx_swap;
roc_ree_af_reg_read;
roc_ree_af_reg_write;
roc_ree_config_lf;
-- 
2.48.1

[PATCH v1 3/3] net/ixgbe: support MDD on VF Tx path

[Anatoly Burakov]

According to datasheet for 82599 and similar NICs, the Tx path must set
CC (Check Context) bit in the descriptor in cases when Tx switching is
enabled in the PF. In case of using VF functions, the fact that it is a
VF function implies that Tx switching is enabled, and thus the CC bit
must always be set for all packet descriptors in the VF Tx path.

However, even though it is specified in the datasheet that this should be
the case, it was never checked in hardware, and not setting this bit did
not cause any problems, so VF Tx have not been setting this bit since the
beginning of ixgbe PMD. In later hardware revisions (X550 onwards), a
hardware feature called MDD (malicious driver detection) was introduced,
which, when enabled, will (among other things) check if CC bit is set,
and will stop the Tx queue when it is not. As of this writing, this
feature is not enabled by default on most configurations, but it may be
enabled on some, and may be enabled by default in the future.

To ensure DPDK ixgbe VF driver works across all possible configurations,
this patch enables setting the CC bit across all VF Tx paths (simple,
offload, and vectorized), as well as ensures that the VF driver will set
up relevant context descriptor (as setting CC bit implies a valid context
descriptor must be set up prior to using the Tx path) whenever the VF
driver is being used.

Signed-off-by: Anatoly Burakov 
---
 drivers/net/intel/common/tx.h |   2 +
 drivers/net/intel/ixgbe/ixgbe_rxtx.c  | 133 --
 .../net/intel/ixgbe/ixgbe_rxtx_vec_common.h   |   4 +
 drivers/net/intel/ixgbe/ixgbe_rxtx_vec_neon.c |   6 +-
 drivers/net/intel/ixgbe/ixgbe_rxtx_vec_sse.c  |   6 +-
 5 files changed, 136 insertions(+), 15 deletions(-)

diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h
index d9cf4474fc..3b862536f6 100644
--- a/drivers/net/intel/common/tx.h
+++ b/drivers/net/intel/common/tx.h
@@ -97,6 +97,8 @@ struct ci_tx_queue {
uint8_t hthresh;   /**< Host threshold register. */
uint8_t wthresh;   /**< Write-back threshold reg. */
uint8_t using_ipsec;  /**< indicates that IPsec TX 
feature is in use */
+   uint8_t is_vf;   /**< indicates that this is a VF queue 
*/
+   uint8_t vf_ctx_initialized; /**< VF context descriptors 
initialized */
};
};
 };
diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.c 
b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
index b216e0612a..a643f30910 100644
--- a/drivers/net/intel/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
@@ -89,6 +89,7 @@
 
 /* forward-declare some functions */
 static int ixgbe_is_vf(struct rte_eth_dev *dev);
+static int ixgbe_write_default_ctx_desc(struct ci_tx_queue *txq, struct 
rte_mempool *mp, bool vec);
 
 /*
  *
@@ -151,7 +152,8 @@ ixgbe_tx_free_bufs(struct ci_tx_queue *txq)
 
 /* Populate 4 descriptors with data from 4 mbufs */
 static inline void
-tx4(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf **pkts)
+tx4(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf **pkts,
+   const uint32_t olinfo_flags)
 {
uint64_t buf_dma_addr;
uint32_t pkt_len;
@@ -168,7 +170,8 @@ tx4(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf 
**pkts)
rte_cpu_to_le_32((uint32_t)DCMD_DTYP_FLAGS | pkt_len);
 
txdp->read.olinfo_status =
-   rte_cpu_to_le_32(pkt_len << IXGBE_ADVTXD_PAYLEN_SHIFT);
+   rte_cpu_to_le_32(pkt_len << IXGBE_ADVTXD_PAYLEN_SHIFT) |
+   olinfo_flags;
 
rte_prefetch0(&(*pkts)->pool);
}
@@ -176,7 +179,8 @@ tx4(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf 
**pkts)
 
 /* Populate 1 descriptor with data from 1 mbuf */
 static inline void
-tx1(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf **pkts)
+tx1(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf **pkts,
+   const uint32_t olinfo_flags)
 {
uint64_t buf_dma_addr;
uint32_t pkt_len;
@@ -189,7 +193,8 @@ tx1(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf 
**pkts)
txdp->read.cmd_type_len =
rte_cpu_to_le_32((uint32_t)DCMD_DTYP_FLAGS | pkt_len);
txdp->read.olinfo_status =
-   rte_cpu_to_le_32(pkt_len << IXGBE_ADVTXD_PAYLEN_SHIFT);
+   rte_cpu_to_le_32(pkt_len << IXGBE_ADVTXD_PAYLEN_SHIFT) |
+   olinfo_flags;
rte_prefetch0(&(*pkts)->pool);
 }
 
@@ -205,6 +210,8 @@ ixgbe_tx_fill_hw_ring(struct ci_tx_queue *txq, struct 
rte_mbuf **pkts,
struct ci_tx_entry *txep = &txq->sw_ring[txq->tx_tail];
const int N_PER_LOOP = 4;
const int N_PER_LOOP_MASK = N_PER_LOOP-1;
+   /* for VF queues, need to set CC bit. context idx is al

[PATCH v1 1/3] net/ixgbe: use check for VF function

[Anatoly Burakov]

In a couple of places, we are using explicit mac type comparisons to
trigger a VF-specific path, but we already have a function that does the
same thing, so use it.

Signed-off-by: Anatoly Burakov 
---
 drivers/net/intel/ixgbe/ixgbe_rxtx.c | 17 +
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.c 
b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
index 0c8a9ec763..b216e0612a 100644
--- a/drivers/net/intel/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
@@ -87,6 +87,9 @@
 #define rte_ixgbe_prefetch(p)   do {} while (0)
 #endif
 
+/* forward-declare some functions */
+static int ixgbe_is_vf(struct rte_eth_dev *dev);
+
 /*
  *
  *  TX functions
@@ -2766,12 +2769,7 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
/*
 * Modification to set VFTDT for virtual function if vf is detected
 */
-   if (hw->mac.type == ixgbe_mac_82599_vf ||
-   hw->mac.type == ixgbe_mac_E610_vf ||
-   hw->mac.type == ixgbe_mac_X540_vf ||
-   hw->mac.type == ixgbe_mac_X550_vf ||
-   hw->mac.type == ixgbe_mac_X550EM_x_vf ||
-   hw->mac.type == ixgbe_mac_X550EM_a_vf)
+   if (ixgbe_is_vf(dev))
txq->qtx_tail = IXGBE_PCI_REG_ADDR(hw, IXGBE_VFTDT(queue_idx));
else
txq->qtx_tail = IXGBE_PCI_REG_ADDR(hw, IXGBE_TDT(txq->reg_idx));
@@ -3154,12 +3152,7 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
/*
 * Modified to setup VFRDT for Virtual Function
 */
-   if (hw->mac.type == ixgbe_mac_82599_vf ||
-   hw->mac.type == ixgbe_mac_E610_vf ||
-   hw->mac.type == ixgbe_mac_X540_vf ||
-   hw->mac.type == ixgbe_mac_X550_vf ||
-   hw->mac.type == ixgbe_mac_X550EM_x_vf ||
-   hw->mac.type == ixgbe_mac_X550EM_a_vf) {
+   if (ixgbe_is_vf(dev)) {
rxq->rdt_reg_addr =
IXGBE_PCI_REG_ADDR(hw, IXGBE_VFRDT(queue_idx));
rxq->rdh_reg_addr =
-- 
2.47.1

[PATCH v1 2/3] net/ixgbe: fix VF registers for E610

[Anatoly Burakov]

When adding E610 support, some case statements for VF definitions were
missing, resulting in picking incorrect registers to write to in certain
cases. Fix it by adding necessary case statements for E610 VF.

Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device")
Cc: sta...@dpdk.org

Signed-off-by: Anatoly Burakov 
---
 drivers/net/intel/ixgbe/ixgbe_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/intel/ixgbe/ixgbe_ethdev.c 
b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
index b80d5894f8..0fa4898aba 100644
--- a/drivers/net/intel/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
@@ -7515,6 +7515,7 @@ ixgbe_mrqc_reg_get(enum ixgbe_mac_type mac_type) {
case ixgbe_mac_X550_vf:
case ixgbe_mac_X550EM_x_vf:
case ixgbe_mac_X550EM_a_vf:
+   case ixgbe_mac_E610_vf:
return IXGBE_VFMRQC;
default:
return IXGBE_MRQC;
@@ -7527,6 +7528,7 @@ ixgbe_rssrk_reg_get(enum ixgbe_mac_type mac_type, uint8_t 
i) {
case ixgbe_mac_X550_vf:
case ixgbe_mac_X550EM_x_vf:
case ixgbe_mac_X550EM_a_vf:
+   case ixgbe_mac_E610_vf:
return IXGBE_VFRSSRK(i);
default:
return IXGBE_RSSRK(i);
-- 
2.47.1

[PATCH v6 06/14] net/zxdh: add eram tables ops

[Bingbin Chen]

Implement the eram tables read and write operations
by dtb channel.

Signed-off-by: Bingbin Chen 
---
 drivers/net/zxdh/zxdh_np.c | 545 -
 drivers/net/zxdh/zxdh_np.h |  15 +
 2 files changed, 558 insertions(+), 2 deletions(-)

diff --git a/drivers/net/zxdh/zxdh_np.c b/drivers/net/zxdh/zxdh_np.c
index 98135b37a7..fd9c7b47c9 100644
--- a/drivers/net/zxdh/zxdh_np.c
+++ b/drivers/net/zxdh/zxdh_np.c
@@ -27,6 +27,10 @@ static const ZXDH_VERSION_COMPATIBLE_REG_T g_np_sdk_version 
= {
ZXDH_NPSDK_COMPAT_ITEM_ID, 1, 0, 0, 0, {0} };
 static const uint32_t hardware_ep_id[5] = {5, 6, 7, 8, 9};
 static ZXDH_RB_CFG 
*g_dtb_dump_addr_rb[ZXDH_DEV_CHANNEL_MAX][ZXDH_DTB_QUEUE_NUM_MAX];
+static const char * const g_dpp_dtb_name[] = {
+   "DOWN TAB",
+   "UP TAB",
+};
 
 static const ZXDH_FIELD_T g_smmu0_smmu0_cpu_ind_cmd_reg[] = {
{"cpu_ind_rw", ZXDH_FIELD_FLAG_RW, 31, 1, 0x0, 0x0},
@@ -196,6 +200,81 @@ static const ZXDH_DTB_TABLE_T g_dpp_dtb_table_info[] = {
},
 };
 
+static const ZXDH_DTB_FIELD_T g_dtb_eram_dump_cmd_info[] = {
+   {"valid", 127, 1},
+   {"up_type", 126, 2},
+   {"base_addr", 106, 19},
+   {"tb_depth", 83, 20},
+   {"tb_dst_addr_h", 63, 32},
+   {"tb_dst_addr_l", 31, 32},
+};
+
+static const ZXDH_DTB_FIELD_T g_dtb_ddr_dump_cmd_info[] = {
+   {"valid", 127, 1},
+   {"up_type", 126, 2},
+   {"base_addr", 117, 30},
+   {"tb_depth", 83, 20},
+   {"tb_dst_addr_h", 63, 32},
+   {"tb_dst_addr_l", 31, 32},
+
+};
+
+static const ZXDH_DTB_FIELD_T g_dtb_zcam_dump_cmd_info[] = {
+   {"valid", 127, 1},
+   {"up_type", 126, 2},
+   {"zgroup_id", 124, 2},
+   {"zblock_id", 122, 3},
+   {"ram_reg_flag", 119, 1},
+   {"z_reg_cell_id", 118, 2},
+   {"sram_addr", 116, 9},
+   {"tb_depth", 97, 10},
+   {"tb_width", 65, 2},
+   {"tb_dst_addr_h", 63, 32},
+   {"tb_dst_addr_l", 31, 32},
+
+};
+
+static const ZXDH_DTB_FIELD_T g_dtb_etcam_dump_cmd_info[] = {
+   {"valid", 127, 1},
+   {"up_type", 126, 2},
+   {"block_sel", 124, 3},
+   {"addr", 121, 9},
+   {"rd_mode", 112, 8},
+   {"data_or_mask", 104, 1},
+   {"tb_depth", 91, 10},
+   {"tb_width", 81, 2},
+   {"tb_dst_addr_h", 63, 32},
+   {"tb_dst_addr_l", 31, 32},
+
+};
+
+static const ZXDH_DTB_TABLE_T g_dpp_dtb_dump_info[] = {
+   {
+   "eram",
+   ZXDH_DTB_DUMP_ERAM,
+   6,
+   g_dtb_eram_dump_cmd_info,
+   },
+   {
+   "ddr",
+   ZXDH_DTB_DUMP_DDR,
+   6,
+   g_dtb_ddr_dump_cmd_info,
+   },
+   {
+   "zcam",
+   ZXDH_DTB_DUMP_ZCAM,
+   11,
+   g_dtb_zcam_dump_cmd_info,
+   },
+   {
+   "etcam",
+   ZXDH_DTB_DUMP_ETCAM,
+   10,
+   g_dtb_etcam_dump_cmd_info,
+   },
+};
+
 #define ZXDH_SDT_MGR_PTR_GET()(&g_sdt_mgr)
 #define ZXDH_SDT_SOFT_TBL_GET(id) (g_sdt_mgr.sdt_tbl_array[id])
 #define ZXDH_DEV_INFO_GET(id) (g_dev_mgr.p_dev_array[id])
@@ -314,6 +393,17 @@ zxdh_np_comm_convert32(uint32_t dw_data)

(p_dpp_dtb_mgr[DEV_ID]->queue_info[QUEUE_ID].tab_up.user_addr[INDEX].user_flag 
= \
VAL)
 
+static inline uint64_t
+zxdh_np_dtb_tab_down_phy_addr_get(uint32_t DEV_ID, uint32_t QUEUE_ID,
+   uint32_t INDEX)
+{
+   return 
p_dpp_dtb_mgr[DEV_ID]->queue_info[QUEUE_ID].tab_down.start_phy_addr +
+   INDEX * 
p_dpp_dtb_mgr[DEV_ID]->queue_info[QUEUE_ID].tab_down.item_size;
+}
+
+#define ZXDH_DTB_TAB_DOWN_PHY_ADDR_GET(DEV_ID, QUEUE_ID, INDEX)   \
+   zxdh_np_dtb_tab_down_phy_addr_get(DEV_ID, QUEUE_ID, INDEX)
+
 static inline uint64_t
 zxdh_np_dtb_tab_up_phy_addr_get(uint32_t DEV_ID, uint32_t QUEUE_ID,
uint32_t INDEX)
@@ -3220,6 +3310,12 @@ zxdh_np_dtb_table_info_get(uint32_t table_type)
return &g_dpp_dtb_table_info[table_type];
 }
 
+static const ZXDH_DTB_TABLE_T *
+zxdh_np_dtb_dump_info_get(uint32_t up_type)
+{
+   return &g_dpp_dtb_dump_info[up_type];
+}
+
 static uint32_t
 zxdh_np_dtb_write_table_cmd(uint32_t dev_id,
ZXDH_DTB_TABLE_INFO_E table_type,
@@ -3254,6 +3350,39 @@ zxdh_np_dtb_write_table_cmd(uint32_t dev_id,
return rc;
 }
 
+static uint32_t
+zxdh_np_dtb_write_dump_cmd(uint32_t dev_id,
+   ZXDH_DTB_DUMP_INFO_E 
dump_type,
+   void *p_cmd_data,
+   void *p_cmd_buff)
+{
+   uint32_t rc = ZXDH_OK;
+   uint32_t field_cnt = 0;
+   const ZXDH_DTB_TABLE_T *p_table_info = NULL;
+   const ZXDH_DTB_FIELD_T *p_field_info = NULL;
+   uint32_t temp_data = 0;
+
+   p_table_info = zxdh_np_dtb_dump_info_get(dump_type);
+   ZXDH_COMM_CHECK_DEV_POINT(dev_id, p_table_info);
+   p_field_info

[PATCH v3 3/9] net/ixgbe/base: correct definition of macro

[Bruce Richardson]

The definition of IXGBE_LE32_TO_CPUS macro is meant to modify the value
in place - similar to the le32_to_cpus() macro in kernel. Fixing the
definition allows us to remove some warning flags, and removes the need
for the uintptr_t typecasts.

Fixes: aa4fc14d2cee ("ixgbe: update base driver")
Cc: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 drivers/net/intel/ixgbe/base/ixgbe_common.c | 4 ++--
 drivers/net/intel/ixgbe/base/ixgbe_osdep.h  | 2 +-
 drivers/net/intel/ixgbe/base/meson.build| 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/intel/ixgbe/base/ixgbe_common.c 
b/drivers/net/intel/ixgbe/base/ixgbe_common.c
index d6425c5b78..fbc9605e4d 100644
--- a/drivers/net/intel/ixgbe/base/ixgbe_common.c
+++ b/drivers/net/intel/ixgbe/base/ixgbe_common.c
@@ -4610,7 +4610,7 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 
*buffer,
/* first pull in the header so we know the buffer length */
for (bi = 0; bi < dword_len; bi++) {
buffer[bi] = IXGBE_READ_REG_ARRAY(hw, IXGBE_FLEX_MNG, bi);
-   IXGBE_LE32_TO_CPUS((uintptr_t)&buffer[bi]);
+   IXGBE_LE32_TO_CPUS(&buffer[bi]);
}
 
/*
@@ -4646,7 +4646,7 @@ s32 ixgbe_host_interface_command(struct ixgbe_hw *hw, u32 
*buffer,
/* Pull in the rest of the buffer (bi is where we left off) */
for (; bi <= dword_len; bi++) {
buffer[bi] = IXGBE_READ_REG_ARRAY(hw, IXGBE_FLEX_MNG, bi);
-   IXGBE_LE32_TO_CPUS((uintptr_t)&buffer[bi]);
+   IXGBE_LE32_TO_CPUS(&buffer[bi]);
}
 
 rel_out:
diff --git a/drivers/net/intel/ixgbe/base/ixgbe_osdep.h 
b/drivers/net/intel/ixgbe/base/ixgbe_osdep.h
index cffc6a4ce8..6e5f7b4ae8 100644
--- a/drivers/net/intel/ixgbe/base/ixgbe_osdep.h
+++ b/drivers/net/intel/ixgbe/base/ixgbe_osdep.h
@@ -83,7 +83,7 @@ enum {
 #define IXGBE_LE16_TO_CPU(_i)  rte_le_to_cpu_16(_i)
 #define IXGBE_LE32_TO_CPU(_i)  rte_le_to_cpu_32(_i)
 #define IXGBE_LE64_TO_CPU(_i)  rte_le_to_cpu_64(_i)
-#define IXGBE_LE32_TO_CPUS(_i) rte_le_to_cpu_32(_i)
+#define IXGBE_LE32_TO_CPUS(_i) do { *_i = rte_le_to_cpu_32(*_i); } while(0)
 #define IXGBE_CPU_TO_BE16(_i)  rte_cpu_to_be_16(_i)
 #define IXGBE_CPU_TO_BE32(_i)  rte_cpu_to_be_32(_i)
 #define IXGBE_BE32_TO_CPU(_i)  rte_be_to_cpu_32(_i)
diff --git a/drivers/net/intel/ixgbe/base/meson.build 
b/drivers/net/intel/ixgbe/base/meson.build
index 7e4fbdfa0f..f8b2ee6341 100644
--- a/drivers/net/intel/ixgbe/base/meson.build
+++ b/drivers/net/intel/ixgbe/base/meson.build
@@ -19,7 +19,7 @@ sources = [
 'ixgbe_x550.c',
 ]
 
-error_cflags = ['-Wno-unused-value',
+error_cflags = [
 '-Wno-unused-but-set-variable',
 '-Wno-unused-parameter',
 ]
-- 
2.45.2

Re: Driver: bnxt_en

[Ajit Khaparde]

On Thu, Mar 27, 2025 at 6:49 AM Eldho Paul Mathew  wrote:
>
> Hi All,
>
> What is the importance of the 'ice' driver?
>
> Right now I am using 18.05.1. Does it have 'ice' driver support?
>
> We bought a new card: BCM57508 NetXtreme-E 10Gb/25Gb/40Gb/50Gb/100Gb/200Gb 
> Ethernet
>
> To support this card using the 'ice' driver, is the DPDK 18.05.1 version 
> sufficient, or is there any other driver that is the placeholder for 'ice' in 
> 18.05.1?
>
> If I need to go for an upgrade, which is the minimum version to support this 
> card by 'ice'?
ice driver will not work with the card you have listed. It is for an Intel NIC.
Support for BCM5708 was added in 2019 in the Broadcom bnxt PMD.
You can either use the 19.11 - an LTS version. But that is not
maintained anymore.
You can use the 22.11 release which is still maintained. Refer to the
DPDK roadmap
for EOL releases.
https://core.dpdk.org/roadmap/

Thanks
Ajit

>
> Kindly help!
>
>
>
> On Fri, Jan 10, 2025 at 11:34 PM Stephen Hemminger 
>  wrote:
>>
>> On Fri, 10 Jan 2025 10:02:48 +0530
>> Eldho Paul Mathew  wrote:
>>
>> > We are using DPDK 18.05.1
>> >
>> > We received a new network card.
>> >
>> > Broadcom Inc. and subsidiaries BCM57414 NetXtreme-E 10Gb/25Gb RDMA Ethernet
>> > Controller
>> >
>> > DPDK 18.05.1 has support for this card and driver bnxt_en?
>> >
>> > If not, which stable version onwards has this driver support added?
>>
>> Release 18.05 is not a stable LTS version.
>>
>> Let me teach you how to look this question up.
>>
>> To look up device you need the actual PCI-ID, using pcilookup.com
>> 14e4:16d7
>>
>> Look at source of drivers/net/bnxt/bnxt_ethdev.c for the pci table 
>> bnxt_id_pci_map.
>> The entry for 16d7 is
>> #define BROADCOM_DEV_ID_57414   0x16d7
>>
>> Using git blame find the commit that added that:
>>
>> $ git blame drivers/net/bnxt/bnxt_ethdev.c | grep BROADCOM_DEV_ID_57414
>> 3fab7694403 (Ajit Khaparde   2017-04-26 14:20:02 -0500   51) 
>>{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414_VF) },
>> 1f4a84672ec (Ajit Khaparde   2017-01-06 13:55:17 -0600   60) 
>>{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414) },
>> 1f4a84672ec (Ajit Khaparde   2017-01-06 13:55:17 -0600   68) 
>>{ RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57414_MF) },
>> 3f6d59b0c88 (Kalesh AP   2019-12-02 09:48:07 +0530 4999) 
>>case BROADCOM_DEV_ID_57414_VF:
>>
>> So we want 1f4a84672ec
>>
>> If you look at that commit with a tool like gitk it shows it happened way 
>> back in 17.02
>> And the card is listed in driver for 18.11
>>


smime.p7s
Description: S/MIME Cryptographic Signature

[PATCH v5 2/4] net/intel: use common Tx queue structure

[Shaiq Wani]

Merge in additional fields used by the idpf driver and then convert it
over to using the common Tx queue structure

Signed-off-by: Shaiq Wani 
---
 drivers/net/intel/common/tx.h | 20 +++
 drivers/net/intel/cpfl/cpfl_ethdev.c  |  3 +-
 drivers/net/intel/cpfl/cpfl_ethdev.h  |  2 +-
 drivers/net/intel/cpfl/cpfl_rxtx.c| 26 -
 drivers/net/intel/cpfl/cpfl_rxtx.h|  3 +-
 drivers/net/intel/cpfl/cpfl_rxtx_vec_common.h |  3 +-
 drivers/net/intel/idpf/idpf_common_rxtx.c | 36 ++--
 drivers/net/intel/idpf/idpf_common_rxtx.h | 58 +++
 .../net/intel/idpf/idpf_common_rxtx_avx2.c| 12 ++--
 .../net/intel/idpf/idpf_common_rxtx_avx512.c  | 21 +++
 drivers/net/intel/idpf/idpf_common_virtchnl.c |  2 +-
 drivers/net/intel/idpf/idpf_common_virtchnl.h |  2 +-
 drivers/net/intel/idpf/idpf_ethdev.c  |  3 +-
 drivers/net/intel/idpf/idpf_rxtx.c| 21 ---
 drivers/net/intel/idpf/idpf_rxtx.h|  1 +
 drivers/net/intel/idpf/idpf_rxtx_vec_common.h |  5 +-
 16 files changed, 101 insertions(+), 117 deletions(-)

diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h
index d9cf4474fc..af32f4deda 100644
--- a/drivers/net/intel/common/tx.h
+++ b/drivers/net/intel/common/tx.h
@@ -35,6 +35,7 @@ struct ci_tx_queue {
volatile struct i40e_tx_desc *i40e_tx_ring;
volatile struct iavf_tx_desc *iavf_tx_ring;
volatile struct ice_tx_desc *ice_tx_ring;
+   volatile struct idpf_base_tx_desc *idpf_tx_ring;
volatile union ixgbe_adv_tx_desc *ixgbe_tx_ring;
};
volatile uint8_t *qtx_tail;   /* register address of tail */
@@ -98,6 +99,25 @@ struct ci_tx_queue {
uint8_t wthresh;   /**< Write-back threshold reg. */
uint8_t using_ipsec;  /**< indicates that IPsec TX 
feature is in use */
};
+   struct { /* idpf specific values */
+   volatile union {
+   struct idpf_flex_tx_sched_desc *desc_ring;
+   struct idpf_splitq_tx_compl_desc *compl_ring;
+   };
+   const struct idpf_txq_ops *idpf_ops;
+   struct ci_tx_queue *complq;
+   void **txqs;   /*only valid for split queue mode*/
+   bool q_started;   /* if tx queue has been started */
+
+   /* only valid for split queue mode */
+   uint32_t tx_start_qid;
+   uint16_t sw_nb_desc;
+   uint16_t sw_tail;
+#define IDPF_TX_CTYPE_NUM  8
+   uint16_t ctype[IDPF_TX_CTYPE_NUM];
+   uint8_t expected_gen_id;
+
+   };
};
 };
 
diff --git a/drivers/net/intel/cpfl/cpfl_ethdev.c 
b/drivers/net/intel/cpfl/cpfl_ethdev.c
index 1817221652..c94010bc51 100644
--- a/drivers/net/intel/cpfl/cpfl_ethdev.c
+++ b/drivers/net/intel/cpfl/cpfl_ethdev.c
@@ -18,6 +18,7 @@
 #include "cpfl_rxtx.h"
 #include "cpfl_flow.h"
 #include "cpfl_rules.h"
+#include "../common/tx.h"
 
 #define CPFL_REPRESENTOR   "representor"
 #define CPFL_TX_SINGLE_Q   "tx_single"
@@ -1167,7 +1168,7 @@ cpfl_hairpin_get_peer_ports(struct rte_eth_dev *dev, 
uint16_t *peer_ports,
 {
struct cpfl_vport *cpfl_vport =
(struct cpfl_vport *)dev->data->dev_private;
-   struct idpf_tx_queue *txq;
+   struct ci_tx_queue *txq;
struct idpf_rx_queue *rxq;
struct cpfl_tx_queue *cpfl_txq;
struct cpfl_rx_queue *cpfl_rxq;
diff --git a/drivers/net/intel/cpfl/cpfl_ethdev.h 
b/drivers/net/intel/cpfl/cpfl_ethdev.h
index 9a38a69194..d4e1176ab1 100644
--- a/drivers/net/intel/cpfl/cpfl_ethdev.h
+++ b/drivers/net/intel/cpfl/cpfl_ethdev.h
@@ -174,7 +174,7 @@ struct cpfl_vport {
uint16_t nb_p2p_txq;
 
struct idpf_rx_queue *p2p_rx_bufq;
-   struct idpf_tx_queue *p2p_tx_complq;
+   struct ci_tx_queue *p2p_tx_complq;
bool p2p_manual_bind;
 };
 
diff --git a/drivers/net/intel/cpfl/cpfl_rxtx.c 
b/drivers/net/intel/cpfl/cpfl_rxtx.c
index 8eed8f16d5..d7b5a660b5 100644
--- a/drivers/net/intel/cpfl/cpfl_rxtx.c
+++ b/drivers/net/intel/cpfl/cpfl_rxtx.c
@@ -11,7 +11,7 @@
 #include "cpfl_rxtx_vec_common.h"
 
 static inline void
-cpfl_tx_hairpin_descq_reset(struct idpf_tx_queue *txq)
+cpfl_tx_hairpin_descq_reset(struct ci_tx_queue *txq)
 {
uint32_t i, size;
 
@@ -26,7 +26,7 @@ cpfl_tx_hairpin_descq_reset(struct idpf_tx_queue *txq)
 }
 
 static inline void
-cpfl_tx_hairpin_complq_reset(struct idpf_tx_queue *cq)
+cpfl_tx_hairpin_complq_reset(struct ci_tx_queue *cq)
 {
uint32_t i, size;
 
@@ -320,7 +320,7 @@ static void
 cpfl_tx_queue_release(void *txq)
 {
struct cpfl_tx_queue *cpfl_txq = txq;
-   struct idpf_tx_queue *q = NULL;
+   struct ci_tx_que

Re: [External] Re: [PATCH] eal: prevent socket closure before MP sync

[Yang Ming]

On 2025/3/17 21:56, Stephen Hemminger wrote:

Caution: This is an external email. Please be very careful when clicking links 
or opening attachments. See http://nok.it/nsb for additional information.

On Fri, 14 Mar 2025 18:36:38 +0800
Yang Ming  wrote:


The secordary process should not close socket file for MP
channel before performing MP request synchronization.
This prevents error logs when the secondary process exits
without any operation on the crypto device while the primary
process starts the device.

Case situation:
eal_bus_cleanup has been added in rte_eal_cleanup. But for the
secondary process, rte_eal_cleanup firstly performs
rte_mp_channel_cleanup, which closes socket file for the MP
channel, making mp_fd invalid. Subsequently, eal_bus_cleanup
triggers vdev_cleanup, which calls mp_request_sync to send a
message via the MP channel. Since mp_fd is invalid, error logs
occur.

Error logs occur as below when the secordary process exit:
EAL: failed to send to (/tmp/dpdk/l2hicu/mp_socket) due to Bad
file descriptor
EAL: Fail to send request /tmp/dpdk/l2hicu/mp_socket:
ipsec_mb_mp_msg
USER1: Create MR request to primary process failed.

Function call trace:
1. rte_eal_cleanup->rte_mp_channel_cleanup->close_socket_fd
2. rte_eal_cleanup->eal_bus_cleanup->vdev_cleanup->
rte_vdev_driver->ipsec_mb_remove->ipsec_mb_qp_release->
ipsec_mb_secondary_qp_op->rte_mp_request_sync->mp_request_sync->
send_msg->sendmsg(mp_fd, &msgh, 0);

Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown")
Cc: kevin.la...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Yang Ming 

Looks good, could there be a test?

Acked-by: Stephen Hemminger 


Hi Thanks Stephen,

We have some findings for this change in our product test line. I will 
do more investigation for this patch.


Brs,

Yang Ming

[PATCH v2] eal/linux: skip vfio for non-privileged container

[Yang Ming]

DPDK detect vfio container according the existence of vfio
module. But for container with non-privileged mode, there is
possibility that no VFIO_DIR(/dev/vfio) mapping from host to
container when host have both Intel NIC and Mellanox NIC but
this conntainer only allocate VFs from Mellanox NIC.
In this case, vfio kernel module has already been loaded from
the host.
This scenario will cause the error log occurs in DPDK primary
process as below:
'EAL:   cannot open VFIO container, error 2 (No such file or
directory)'
'EAL: VFIO support could not be initialized'
Because `rte_vfio_enable()` call `rte_vfio_get_container_fd()`
to execute `vfio_container_fd = open(VFIO_CONTAINER_PATH,
O_RDWR);` but VFIO_CONTAINER_PATH(/dev/vfio/vfio) doesn't exist
in this container.
This scenario will also lead to the delay of DPDK secondary
process because `default_vfio_cfg->vfio_enabled = 0` and
`default_vfio_cfg->vfio_container_fd = -1`, socket error will
be set in DPDK primary process when it sync this info to
the secondary process.
This patch use to skip this kind of useless detection for this
scenario.

Signed-off-by: Yang Ming 
---
 lib/eal/linux/eal_vfio.c | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c
index 7132e24cba..1679d29263 100644
--- a/lib/eal/linux/eal_vfio.c
+++ b/lib/eal/linux/eal_vfio.c
@@ -7,6 +7,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -1083,6 +1084,7 @@ rte_vfio_enable(const char *modname)
/* initialize group list */
int i, j;
int vfio_available;
+   DIR *dir;
const struct internal_config *internal_conf =
eal_get_internal_configuration();
 
@@ -1119,6 +1121,15 @@ rte_vfio_enable(const char *modname)
return 0;
}
 
+   /* return 0 if VFIO directory not exist for container with 
non-privileged mode */
+   dir = opendir(VFIO_DIR);
+   if (dir == NULL) {
+   EAL_LOG(DEBUG,
+   "VFIO directory not exist, skipping VFIO support...");
+   return 0;
+   }
+   closedir(dir);
+
if (internal_conf->process_type == RTE_PROC_PRIMARY) {
if (vfio_mp_sync_setup() == -1) {
default_vfio_cfg->vfio_container_fd = -1;
-- 
2.34.1

DPDK compilers and RHEL 7 support

[Morten Brørup]

+ Red Hat tech board members

> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, 26 March 2025 20.21
> 
> On Wed, 26 Mar 2025 19:06:58 +0100
> Morten Brørup  wrote:
> 
> > > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > > Sent: Wednesday, 26 March 2025 17.22
> > >
> > > On Tue, Mar 25, 2025 at 05:22:15PM +, Bruce Richardson wrote:
> > > > When doing a build for a target that already has the instruction
> sets
> > > > for AVX2/AVX512 enabled, skip emitting the AVX compiler flags, or
> the
> > > > skylake-avx512 '-march' flags, as they are unnecessary. Instead,
> when
> > > > the default flags produce the desired output, just use them
> > > unmodified.
> > > >
> > > > Depends-on: series-34915 ("remove component-specific logic for
> AVX
> > > builds")
> > > >
> > > > Signed-off-by: Bruce Richardson 
> > > > ---
> > > >
> > > > This patchset depends on the previous AVX rework. However,
> sending it
> > > > separately as a new RFC because it effectively increases the
> minimum
> > > > compiler versions needed for x86 builds - from GCC 5 to 6, and
> > > > Clang 3.6 to 3.9.
> > > >
> > > > For now, I've just documented that as an additional note in the
> GSG
> > > that
> > > > these versions are recommended, but it would be simpler if we
> could
> > > just
> > > > set them as the required minimum baseline (at least in the docs).
> > > >
> > > > Feedback on these compiler version requirements welcome.
> > > >
> > >
> > > +techboard
> > >
> > > Ping for a little bit of feedback for this. Are we ok to bump the
> > > minimum
> > > compiler versions as described above, or will I continue with the
> > > approach
> > > in this RFC of keeping the minimum and just recommending the higher
> > > versions for x86 platforms?
> > >
> > > For reference GCC 6.1 was released April 2016[1], and, Clang 3.9
> was
> > > released Sept 2016[2]
> > >
> > > /Bruce
> > >
> > > [1] https://gcc.gnu.org/gcc-6/
> > > [2] https://releases.llvm.org/
> >
> > Considering GCC versions shipped with RHEL [3]...
> > We kind of support RHEL 7, but we already require a newer compiler
> (GCC 5) than shipped with RHEL 7 (GCC 4.8).
> > RHEL 8 ships with GCC 8, which was released in May 2018 [4]. Maybe we
> can jump to GCC 8?
> >
> > BTW, we should also apply the same principle I argued [5] should
> apply for upgrading the Kernel requirements: There should be a need for
> specific feature or similar - which there is with your patch - and the
> details should be mentioned in the release notes.
> >
> > [3]: https://access.redhat.com/solutions/19458
> > [4]: https://gcc.gnu.org/gcc-8/
> > [5]:
> https://inbox.dpdk.org/dev/CAMEVEZutf4sJ=EQFONw_bJW0tGTWqTbF_Tk_y38qzBL
> ccco...@mail.gmail.com/T/#me7c8f1dbe4331ccf232d43512d6ddb51458c568a
> >
> 
> RHEL 7 reached end of life on June 30, 2024.
> DPDK need no longer support it on future versions.

CentOS 7 reached EOL June 2024, yes.
RHEL 7 reached End of Maintenance June 2024, but RHEL 7 Extended Life Cycle 
Support is available until June 2028 [6].

Although RHEL 7 not fully EOL, I would consider "End Of Maintenance" 
sufficiently dead for future DPDK versions not needing to support it.
If you are running a production system on a distro that's on Extended Life 
Cycle Support, you shouldn't deploy a new DPDK version - and if you do anyway, 
it's your own problem, not the DPDK community's problem.
@Aaron, @Kevin, @Maxime - speak up if you disagree!


[6]: 
https://www.redhat.com/en/technologies/linux-platforms/enterprise-linux/rhel-7-end-of-maintenance

Re: [PATCH v4 00/11] remove component-specific logic for AVX builds

[David Marchand]

On Wed, Mar 19, 2025 at 6:30 PM Bruce Richardson
 wrote:
>
> A number of libs and drivers had special optimized AVX2 and AVX512 code
> paths for performance reasons, and these tended to have copy-pasted
> logic to build those files. Centralise that logic in the main
> drivers/ and lib/ meson.build files to avoid duplication.
>
> v4: rebase on latest main branch
> minor fixes following feedback
> limit use of -march=skylake-avx512 to when we don't already have a
>   -march flag supporting AVX512.
> v3: add patch for event/dlb2 AVX512 handling.
> add common code for libraries as well as drivers.
> v2: add patch 4 to remove use of unnecessary CC_AVX2_SUPPORT flag
>
> Bruce Richardson (11):
>   drivers: add generalized AVX build handling
>   net/intel: use common AVX build code
>   drivers/net: build use common AVX handling
>   drivers/net: remove AVX2 build-time define
>   event/dlb2: build using common AVX handling
>   lib: add generalized AVX build handling
>   acl: use common AVX build handling
>   fib: use common AVX build handling
>   net: simplify build-time logic for x86
>   net: use common AVX512 build code
>   member: use common AVX512 build support
>
>  drivers/event/dlb2/dlb2_sse.c |  4 ++
>  drivers/event/dlb2/meson.build| 16 +---
>  drivers/meson.build   | 30 ++
>  drivers/net/bnxt/bnxt_ethdev.c|  2 -
>  drivers/net/bnxt/meson.build  | 10 +
>  drivers/net/enic/meson.build  | 10 +
>  drivers/net/intel/i40e/meson.build| 26 +---
>  drivers/net/intel/iavf/meson.build| 25 +---
>  drivers/net/intel/ice/meson.build | 25 +---
>  drivers/net/intel/idpf/meson.build| 25 +---
>  drivers/net/nfp/meson.build   | 10 +
>  drivers/net/octeon_ep/meson.build | 13 +-
>  drivers/net/octeon_ep/otx_ep_ethdev.c |  4 --
>  drivers/net/virtio/meson.build|  9 +
>  lib/acl/meson.build   | 54 ++---
>  lib/fib/dir24_8.c |  6 +--
>  lib/fib/meson.build   | 18 +
>  lib/fib/trie.c|  6 +--
>  lib/member/meson.build| 46 -
>  lib/meson.build   | 34 +++-
>  lib/net/meson.build   | 58 +++
>  lib/net/rte_net_crc.c | 16 
>  22 files changed, 114 insertions(+), 333 deletions(-)

Series applied, thanks Bruce.


-- 
David Marchand

Re: [External] Re: [PATCH v2] eal/linux: improve ASLR check

[David Marchand]

Hello,

On Thu, Mar 27, 2025 at 9:02 AM Yang Ming  wrote:
> On 2025/3/13 23:37, Stephen Hemminger wrote:
> > On Thu, 13 Mar 2025 14:19:03 +0800
> > Yang Ming  wrote:
> >
> >> This change ensures that the current process is checked for
> >> being run with 'setarch' before verifying the value of
> >> '/proc/sys/kernel/randomize_va_space'. The '-R' or
> >> '--addr-no-randomize' parameter of the 'setarch' command is used
> >> to disable the randomization of the virtual address space.
> >>
> >> Fixes: af75078fece3 ("first public release")
> >> Cc: sta...@dpdk.org
> >>
> >> Signed-off-by: Yang Ming 
> > Acked-by: Stephen Hemminger 
> >
> Hi Experts,
>
> is there any chance to review and accept this patch?

I just merged rc0 which means the patch merging fest is opened.

I put this patch and a few other EAL patches on my rc1 queue, as those
changes don't belong to next-net.

-- 
David Marchand

DPDK for rust

[Morten Brørup]

> From: Gregory Etelson [mailto:getel...@nvidia.com]
> Sent: Thursday, 6 March 2025 14.37
> Subject: [PATCH] rust: support DPDK API
> 
> The patch converts include files with DPDK API to RUST and binds new
> RUST API files info dpdklib package.
> 
> The RUST dpdklib files and DPDK libraries build from C sources
> allow creation of DPDK application in RUST.

Do we want the DPDK project itself to support rust?
Or should parts of this be a DPDK hosted project, like grout?

I don't object to supporting rust, quite the opposite. I'm only trying to think 
ahead...

I would hate to see a DPDK patch being rejected because it doesn't support 
rust, or needs additional work to not break DPDK for rust.

And how about the CI - do we want it to test "DPDK for rust", and how many 
resources are we going to put into this?

-Morten

RE: [PATCH v3] common/cnxk: fix aura offset

[Jerin Jacob]

> -Original Message-
> From: Nawal Kishor 
> Sent: Monday, March 24, 2025 12:05 PM
> To: dev@dpdk.org; Nithin Kumar Dabilpuram ;
> Kiran Kumar Kokkilagadda ; Sunil Kumar Kori
> ; Satha Koteswara Rao Kottidi
> ; Harman Kalra ; Ashwin
> Sekhar T K 
> Cc: Jerin Jacob ; Nawal Kishor 
> Subject: [PATCH v3] common/cnxk: fix aura offset
> 
> Aura field width has reduced from 20 bits in cn10k/cn9k to 17 bits in cn20k.
> Adjust the setting of aura offset in NPA_LF_POOL_OP_INT register accordingly
> based on the platform.
> 
> Fixes: 620fc02bf7eb ("common/cnxk: accommodate change in aura field
> width")
> 
> Signed-off-by: Nawal Kishor 

Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-main. 
Thanks

Re: [PATCH] version: 25.07-rc0

[David Marchand]

On Wed, Mar 26, 2025 at 10:00 AM David Marchand
 wrote:
>
> Start a new release cycle with empty release notes.
> Bump version and ABI minor.
>
> Signed-off-by: David Marchand 
> Acked-by: Bruce Richardson 

Applied, thanks.


-- 
David Marchand

[PATCH v2 0/2] fix the problem of dma-perf infinite loop

[Dengdui Huang]

After CPU isolation is configured, an infinite loop occurs when
dma-perf is executed using the default config file.

This patchset fix it.

Dengdui Huang (2):
  eal: fix uncheck worker ID
  app/dma-perf: fix infinite loop

 app/test-dma-perf/main.c   | 8 +++-
 lib/eal/common/eal_common_launch.c | 3 +++
 2 files changed, 10 insertions(+), 1 deletion(-)

-- 
2.33.0

[PATCH v2 1/3] net/ixgbe: use check for VF function

[Anatoly Burakov]

In a couple of places, we are using explicit mac type comparisons to
trigger a VF-specific path, but we already have a function that does the
same thing, so use it.

Signed-off-by: Anatoly Burakov 
---
 drivers/net/intel/ixgbe/ixgbe_rxtx.c | 17 +
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.c 
b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
index 0c8a9ec763..b216e0612a 100644
--- a/drivers/net/intel/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
@@ -87,6 +87,9 @@
 #define rte_ixgbe_prefetch(p)   do {} while (0)
 #endif
 
+/* forward-declare some functions */
+static int ixgbe_is_vf(struct rte_eth_dev *dev);
+
 /*
  *
  *  TX functions
@@ -2766,12 +2769,7 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
/*
 * Modification to set VFTDT for virtual function if vf is detected
 */
-   if (hw->mac.type == ixgbe_mac_82599_vf ||
-   hw->mac.type == ixgbe_mac_E610_vf ||
-   hw->mac.type == ixgbe_mac_X540_vf ||
-   hw->mac.type == ixgbe_mac_X550_vf ||
-   hw->mac.type == ixgbe_mac_X550EM_x_vf ||
-   hw->mac.type == ixgbe_mac_X550EM_a_vf)
+   if (ixgbe_is_vf(dev))
txq->qtx_tail = IXGBE_PCI_REG_ADDR(hw, IXGBE_VFTDT(queue_idx));
else
txq->qtx_tail = IXGBE_PCI_REG_ADDR(hw, IXGBE_TDT(txq->reg_idx));
@@ -3154,12 +3152,7 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
/*
 * Modified to setup VFRDT for Virtual Function
 */
-   if (hw->mac.type == ixgbe_mac_82599_vf ||
-   hw->mac.type == ixgbe_mac_E610_vf ||
-   hw->mac.type == ixgbe_mac_X540_vf ||
-   hw->mac.type == ixgbe_mac_X550_vf ||
-   hw->mac.type == ixgbe_mac_X550EM_x_vf ||
-   hw->mac.type == ixgbe_mac_X550EM_a_vf) {
+   if (ixgbe_is_vf(dev)) {
rxq->rdt_reg_addr =
IXGBE_PCI_REG_ADDR(hw, IXGBE_VFRDT(queue_idx));
rxq->rdh_reg_addr =
-- 
2.47.1

[PATCH v2 3/3] net/ixgbe: support MDD on VF Tx path

[Anatoly Burakov]

According to datasheet for 82599 and similar NICs, the Tx path must set
CC (Check Context) bit in the descriptor in cases when Tx switching is
enabled in the PF. In case of using VF functions, the fact that it is a
VF function implies that Tx switching is enabled, and thus the CC bit
must always be set for all packet descriptors in the VF Tx path.

However, even though it is specified in the datasheet that this should be
the case, it was never checked in hardware, and not setting this bit did
not cause any problems, so VF Tx have not been setting this bit since the
beginning of ixgbe PMD. In later hardware revisions (X550 onwards), a
hardware feature called MDD (malicious driver detection) was introduced,
which, when enabled, will (among other things) check if CC bit is set,
and will stop the Tx queue when it is not. As of this writing, this
feature is not enabled by default on most configurations, but it may be
enabled on some, and may be enabled by default in the future.

To ensure DPDK ixgbe VF driver works across all possible configurations,
this patch enables setting the CC bit across all VF Tx paths (simple,
offload, and vectorized), as well as ensures that the VF driver will set
up relevant context descriptor (as setting CC bit implies a valid context
descriptor must be set up prior to using the Tx path) whenever the VF
driver is being used.

Signed-off-by: Anatoly Burakov 
---

Notes:
v1 -> v2:
- Wrap CC flag in rte_cpu_to_le32() for generic path

 drivers/net/intel/common/tx.h |   2 +
 drivers/net/intel/ixgbe/ixgbe_rxtx.c  | 133 --
 .../net/intel/ixgbe/ixgbe_rxtx_vec_common.h   |   4 +
 drivers/net/intel/ixgbe/ixgbe_rxtx_vec_neon.c |   6 +-
 drivers/net/intel/ixgbe/ixgbe_rxtx_vec_sse.c  |   6 +-
 5 files changed, 136 insertions(+), 15 deletions(-)

diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h
index d9cf4474fc..3b862536f6 100644
--- a/drivers/net/intel/common/tx.h
+++ b/drivers/net/intel/common/tx.h
@@ -97,6 +97,8 @@ struct ci_tx_queue {
uint8_t hthresh;   /**< Host threshold register. */
uint8_t wthresh;   /**< Write-back threshold reg. */
uint8_t using_ipsec;  /**< indicates that IPsec TX 
feature is in use */
+   uint8_t is_vf;   /**< indicates that this is a VF queue 
*/
+   uint8_t vf_ctx_initialized; /**< VF context descriptors 
initialized */
};
};
 };
diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.c 
b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
index b216e0612a..3d56ef 100644
--- a/drivers/net/intel/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
@@ -89,6 +89,7 @@
 
 /* forward-declare some functions */
 static int ixgbe_is_vf(struct rte_eth_dev *dev);
+static int ixgbe_write_default_ctx_desc(struct ci_tx_queue *txq, struct 
rte_mempool *mp, bool vec);
 
 /*
  *
@@ -151,7 +152,8 @@ ixgbe_tx_free_bufs(struct ci_tx_queue *txq)
 
 /* Populate 4 descriptors with data from 4 mbufs */
 static inline void
-tx4(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf **pkts)
+tx4(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf **pkts,
+   const uint32_t olinfo_flags)
 {
uint64_t buf_dma_addr;
uint32_t pkt_len;
@@ -168,7 +170,8 @@ tx4(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf 
**pkts)
rte_cpu_to_le_32((uint32_t)DCMD_DTYP_FLAGS | pkt_len);
 
txdp->read.olinfo_status =
-   rte_cpu_to_le_32(pkt_len << IXGBE_ADVTXD_PAYLEN_SHIFT);
+   rte_cpu_to_le_32(pkt_len << IXGBE_ADVTXD_PAYLEN_SHIFT) |
+   olinfo_flags;
 
rte_prefetch0(&(*pkts)->pool);
}
@@ -176,7 +179,8 @@ tx4(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf 
**pkts)
 
 /* Populate 1 descriptor with data from 1 mbuf */
 static inline void
-tx1(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf **pkts)
+tx1(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf **pkts,
+   const uint32_t olinfo_flags)
 {
uint64_t buf_dma_addr;
uint32_t pkt_len;
@@ -189,7 +193,8 @@ tx1(volatile union ixgbe_adv_tx_desc *txdp, struct rte_mbuf 
**pkts)
txdp->read.cmd_type_len =
rte_cpu_to_le_32((uint32_t)DCMD_DTYP_FLAGS | pkt_len);
txdp->read.olinfo_status =
-   rte_cpu_to_le_32(pkt_len << IXGBE_ADVTXD_PAYLEN_SHIFT);
+   rte_cpu_to_le_32(pkt_len << IXGBE_ADVTXD_PAYLEN_SHIFT) |
+   olinfo_flags;
rte_prefetch0(&(*pkts)->pool);
 }
 
@@ -205,6 +210,8 @@ ixgbe_tx_fill_hw_ring(struct ci_tx_queue *txq, struct 
rte_mbuf **pkts,
struct ci_tx_entry *txep = &txq->sw_ring[txq->tx_tail];
const int N_PER_LOOP = 4;
const int N_PER_LOOP_MASK

[PATCH v2 2/3] net/ixgbe: fix VF registers for E610

[Anatoly Burakov]

When adding E610 support, some case statements for VF definitions were
missing, resulting in picking incorrect registers to write to in certain
cases. Fix it by adding necessary case statements for E610 VF.

Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device")
Cc: sta...@dpdk.org

Signed-off-by: Anatoly Burakov 
---
 drivers/net/intel/ixgbe/ixgbe_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/intel/ixgbe/ixgbe_ethdev.c 
b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
index b80d5894f8..0fa4898aba 100644
--- a/drivers/net/intel/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
@@ -7515,6 +7515,7 @@ ixgbe_mrqc_reg_get(enum ixgbe_mac_type mac_type) {
case ixgbe_mac_X550_vf:
case ixgbe_mac_X550EM_x_vf:
case ixgbe_mac_X550EM_a_vf:
+   case ixgbe_mac_E610_vf:
return IXGBE_VFMRQC;
default:
return IXGBE_MRQC;
@@ -7527,6 +7528,7 @@ ixgbe_rssrk_reg_get(enum ixgbe_mac_type mac_type, uint8_t 
i) {
case ixgbe_mac_X550_vf:
case ixgbe_mac_X550EM_x_vf:
case ixgbe_mac_X550EM_a_vf:
+   case ixgbe_mac_E610_vf:
return IXGBE_VFRSSRK(i);
default:
return IXGBE_RSSRK(i);
-- 
2.47.1

RE: [EXTERNAL] [PATCH] config/arm: fix meson for native instruction set Arm CPUs

[Pavan Nikhilesh Bhagavatula]

> Hi Gregory,
> 
> > Arm meson.build unconditionally relays on the `extra_features`
> > member of SoC configuration.
> >
> > SoC dictionary is populated for Arm CPUs with generic instruction set
> > only.
> > For Arm CPUs with native CPU instruction set the SoC dictionary is
> > empty.
> >
> > meson setup failed for the BlueField-3 because it belongs to
> > the native Arm CPU instruction set.
> >
> > The patch adds global definition for extra_features.
> >
> > Fixes: 7829776d0abf ("config/arm: add extra -march features")
> > Signed-off-by: Gregory Etelson 

Acked-by: Pavan Nikhilesh 

> > ---
> >  config/arm/meson.build | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/config/arm/meson.build b/config/arm/meson.build
> > index a97a28ebb7..f971ed3c1b 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -767,6 +767,7 @@ dpdk_conf.set('RTE_FORCE_INTRINSICS', 1)
> >
> >  update_flags = false
> >  soc_flags = []
> > +extra_features = []
> 

I re-checked with arm64 native compilation and see the issue.

Thanks, 
Pavan.

> We do set the default to be [] when extra_march_features is not found
> In soc_config.
> 
> extra_features = soc_config.get('extra_march_features', [])
> 
> I have tested cross build[1] of bluefield3 with  both meson 1.7.0 and 0.61.2
> and didn’t see any failure which version of meson are you using?
> 
> [1]meson build --cross-file config/arm/arm64_bluefield3_linux_gcc
> 
> Thanks,
> Pavan.
> 
> 
> >  if dpdk_conf.get('RTE_ARCH_32')
> >  # 32-bit build
> >  dpdk_conf.set('RTE_CACHE_LINE_SIZE', 64)
> > --
> > 2.45.2

[PATCH v5 1/4] net/intel: align Tx queue struct field names

[Shaiq Wani]

Align the Tx queue struct field names in idpf and
cpfl driver with the common Tx queue struct.

Signed-off-by: Shaiq Wani 
---
 drivers/net/intel/cpfl/cpfl_rxtx.c| 40 -
 drivers/net/intel/cpfl/cpfl_rxtx_vec_common.h |  4 +-
 drivers/net/intel/idpf/idpf_common_rxtx.c | 72 
 drivers/net/intel/idpf/idpf_common_rxtx.h | 21 ++---
 .../net/intel/idpf/idpf_common_rxtx_avx2.c| 44 +-
 .../net/intel/idpf/idpf_common_rxtx_avx512.c  | 84 +--
 drivers/net/intel/idpf/idpf_common_virtchnl.c |  6 +-
 drivers/net/intel/idpf/idpf_rxtx.c| 24 +++---
 drivers/net/intel/idpf/idpf_rxtx_vec_common.h |  4 +-
 9 files changed, 150 insertions(+), 149 deletions(-)

diff --git a/drivers/net/intel/cpfl/cpfl_rxtx.c 
b/drivers/net/intel/cpfl/cpfl_rxtx.c
index 47351ca102..8eed8f16d5 100644
--- a/drivers/net/intel/cpfl/cpfl_rxtx.c
+++ b/drivers/net/intel/cpfl/cpfl_rxtx.c
@@ -249,7 +249,7 @@ cpfl_rx_split_bufq_setup(struct rte_eth_dev *dev, struct 
idpf_rx_queue *rxq,
idpf_qc_split_rx_bufq_reset(bufq);
bufq->qrx_tail = hw->hw_addr + (vport->chunks_info.rx_buf_qtail_start +
 queue_idx * vport->chunks_info.rx_buf_qtail_spacing);
-   bufq->ops = &def_rxq_ops;
+   bufq->idpf_ops = &def_rxq_ops;
bufq->q_set = true;
 
if (bufq_id == IDPF_RX_SPLIT_BUFQ1_ID) {
@@ -310,7 +310,7 @@ cpfl_rx_queue_release(void *rxq)
}
 
/* Single queue */
-   q->ops->release_mbufs(q);
+   q->idpf_ops->release_mbufs(q);
rte_free(q->sw_ring);
rte_memzone_free(q->mz);
rte_free(cpfl_rxq);
@@ -332,7 +332,7 @@ cpfl_tx_queue_release(void *txq)
rte_free(q->complq);
}
 
-   q->ops->release_mbufs(q);
+   q->idpf_ops->release_mbufs(q);
rte_free(q->sw_ring);
rte_memzone_free(q->mz);
rte_free(cpfl_txq);
@@ -426,7 +426,7 @@ cpfl_rx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
idpf_qc_single_rx_queue_reset(rxq);
rxq->qrx_tail = hw->hw_addr + 
(vport->chunks_info.rx_qtail_start +
queue_idx * 
vport->chunks_info.rx_qtail_spacing);
-   rxq->ops = &def_rxq_ops;
+   rxq->idpf_ops = &def_rxq_ops;
} else {
idpf_qc_split_rx_descq_reset(rxq);
 
@@ -501,7 +501,7 @@ cpfl_tx_complq_setup(struct rte_eth_dev *dev, struct 
idpf_tx_queue *txq,
ret = -ENOMEM;
goto err_mz_reserve;
}
-   cq->tx_ring_phys_addr = mz->iova;
+   cq->tx_ring_dma = mz->iova;
cq->compl_ring = mz->addr;
cq->mz = mz;
idpf_qc_split_tx_complq_reset(cq);
@@ -565,8 +565,8 @@ cpfl_tx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
is_splitq = !!(vport->txq_model == VIRTCHNL2_QUEUE_MODEL_SPLIT);
 
txq->nb_tx_desc = nb_desc;
-   txq->rs_thresh = tx_rs_thresh;
-   txq->free_thresh = tx_free_thresh;
+   txq->tx_rs_thresh = tx_rs_thresh;
+   txq->tx_free_thresh = tx_free_thresh;
txq->queue_id = vport->chunks_info.tx_start_qid + queue_idx;
txq->port_id = dev->data->port_id;
txq->offloads = cpfl_tx_offload_convert(offloads);
@@ -585,7 +585,7 @@ cpfl_tx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
ret = -ENOMEM;
goto err_mz_reserve;
}
-   txq->tx_ring_phys_addr = mz->iova;
+   txq->tx_ring_dma = mz->iova;
txq->mz = mz;
 
txq->sw_ring = rte_zmalloc_socket("cpfl tx sw ring",
@@ -598,7 +598,7 @@ cpfl_tx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
}
 
if (!is_splitq) {
-   txq->tx_ring = mz->addr;
+   txq->idpf_tx_ring = mz->addr;
idpf_qc_single_tx_queue_reset(txq);
} else {
txq->desc_ring = mz->addr;
@@ -613,7 +613,7 @@ cpfl_tx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
 
txq->qtx_tail = hw->hw_addr + (vport->chunks_info.tx_qtail_start +
queue_idx * vport->chunks_info.tx_qtail_spacing);
-   txq->ops = &def_txq_ops;
+   txq->idpf_ops = &def_txq_ops;
cpfl_vport->nb_data_txq++;
txq->q_set = true;
dev->data->tx_queues[queue_idx] = cpfl_txq;
@@ -663,7 +663,7 @@ cpfl_rx_hairpin_bufq_setup(struct rte_eth_dev *dev, struct 
idpf_rx_queue *bufq,
bufq->rx_buf_len = CPFL_P2P_MBUF_SIZE - RTE_PKTMBUF_HEADROOM;
 
bufq->q_set = true;
-   bufq->ops = &def_rxq_ops;
+   bufq->idpf_ops = &def_rxq_ops;
 
return 0;
 }
@@ -860,7 +860,7 @@ cpfl_tx_hairpin_queue_setup(struct rte_eth_dev *dev, 
uint16_t queue_idx,
goto err_txq_mz_rsv;
}
 
-   txq->tx_ring_phys_addr = mz->iova;
+   txq->tx_ring_dma = mz->iova;
txq->desc_ring = mz->addr;
txq->mz = mz;
 
@@ -868,7 +868,7 @@ cpfl_tx_hairpin_queue_setup(struct rte_eth_dev *dev, 
uint16_t queue_i

[PATCH v5 3/4] net/intel: use common Tx entry structure

[Shaiq Wani]

Used the common Tx entry structure and common Tx mbuf ring replenish fn
in place of idpf-specific structure and function.
The vector driver code paths (AVX2, AVX512) use the smaller SW
ring structure.

Signed-off-by: Shaiq Wani 
---
 drivers/net/intel/idpf/idpf_common_rxtx.c | 26 -
 drivers/net/intel/idpf/idpf_common_rxtx.h | 10 ---
 .../net/intel/idpf/idpf_common_rxtx_avx2.c| 23 +--
 .../net/intel/idpf/idpf_common_rxtx_avx512.c  | 28 ++-
 drivers/net/intel/idpf/idpf_rxtx.c|  2 +-
 5 files changed, 30 insertions(+), 59 deletions(-)

diff --git a/drivers/net/intel/idpf/idpf_common_rxtx.c 
b/drivers/net/intel/idpf/idpf_common_rxtx.c
index 48fc3ef7ae..4318b3fb3c 100644
--- a/drivers/net/intel/idpf/idpf_common_rxtx.c
+++ b/drivers/net/intel/idpf/idpf_common_rxtx.c
@@ -210,7 +210,7 @@ idpf_qc_single_rx_queue_reset(struct idpf_rx_queue *rxq)
 void
 idpf_qc_split_tx_descq_reset(struct ci_tx_queue *txq)
 {
-   struct idpf_tx_entry *txe;
+   struct ci_tx_entry *txe;
uint32_t i, size;
uint16_t prev;
 
@@ -223,7 +223,7 @@ idpf_qc_split_tx_descq_reset(struct ci_tx_queue *txq)
for (i = 0; i < size; i++)
((volatile char *)txq->desc_ring)[i] = 0;
 
-   txe = (struct idpf_tx_entry *)txq->sw_ring;
+   txe = (struct ci_tx_entry *)txq->sw_ring;
prev = (uint16_t)(txq->sw_nb_desc - 1);
for (i = 0; i < txq->sw_nb_desc; i++) {
txe[i].mbuf = NULL;
@@ -266,7 +266,7 @@ idpf_qc_split_tx_complq_reset(struct ci_tx_queue *cq)
 void
 idpf_qc_single_tx_queue_reset(struct ci_tx_queue *txq)
 {
-   struct idpf_tx_entry *txe;
+   struct ci_tx_entry *txe;
uint32_t i, size;
uint16_t prev;
 
@@ -275,7 +275,7 @@ idpf_qc_single_tx_queue_reset(struct ci_tx_queue *txq)
return;
}
 
-   txe = (struct idpf_tx_entry *)txq->sw_ring;
+   txe = (struct ci_tx_entry *)txq->sw_ring;
size = sizeof(struct idpf_base_tx_desc) * txq->nb_tx_desc;
for (i = 0; i < size; i++)
((volatile char *)txq->idpf_tx_ring)[i] = 0;
@@ -755,7 +755,7 @@ idpf_split_tx_free(struct ci_tx_queue *cq)
volatile struct idpf_splitq_tx_compl_desc *compl_ring = cq->compl_ring;
volatile struct idpf_splitq_tx_compl_desc *txd;
uint16_t next = cq->tx_tail;
-   struct idpf_tx_entry *txe;
+   struct ci_tx_entry *txe;
struct ci_tx_queue *txq;
uint16_t gen, qid, q_head;
uint16_t nb_desc_clean;
@@ -794,7 +794,7 @@ idpf_split_tx_free(struct ci_tx_queue *cq)
break;
case IDPF_TXD_COMPLT_RS:
/* q_head indicates sw_id when ctype is 2 */
-   txe = (struct idpf_tx_entry *)&txq->sw_ring[q_head];
+   txe = &txq->sw_ring[q_head];
if (txe->mbuf != NULL) {
rte_pktmbuf_free_seg(txe->mbuf);
txe->mbuf = NULL;
@@ -863,9 +863,9 @@ idpf_dp_splitq_xmit_pkts(void *tx_queue, struct rte_mbuf 
**tx_pkts,
struct ci_tx_queue *txq = (struct ci_tx_queue *)tx_queue;
volatile struct idpf_flex_tx_sched_desc *txr;
volatile struct idpf_flex_tx_sched_desc *txd;
-   struct idpf_tx_entry *sw_ring;
+   struct ci_tx_entry *sw_ring;
union idpf_tx_offload tx_offload = {0};
-   struct idpf_tx_entry *txe, *txn;
+   struct ci_tx_entry *txe, *txn;
uint16_t nb_used, tx_id, sw_id;
struct rte_mbuf *tx_pkt;
uint16_t nb_to_clean;
@@ -878,7 +878,7 @@ idpf_dp_splitq_xmit_pkts(void *tx_queue, struct rte_mbuf 
**tx_pkts,
return nb_tx;
 
txr = txq->desc_ring;
-   sw_ring = (struct idpf_tx_entry *)txq->sw_ring;
+   sw_ring = txq->sw_ring;
tx_id = txq->tx_tail;
sw_id = txq->sw_tail;
txe = &sw_ring[sw_id];
@@ -1305,7 +1305,7 @@ static inline int
 idpf_xmit_cleanup(struct ci_tx_queue *txq)
 {
uint16_t last_desc_cleaned = txq->last_desc_cleaned;
-   struct idpf_tx_entry *sw_ring = (struct idpf_tx_entry *)txq->sw_ring;
+   struct ci_tx_entry *sw_ring = txq->sw_ring;
uint16_t nb_tx_desc = txq->nb_tx_desc;
uint16_t desc_to_clean_to;
uint16_t nb_tx_to_clean;
@@ -1349,8 +1349,8 @@ idpf_dp_singleq_xmit_pkts(void *tx_queue, struct rte_mbuf 
**tx_pkts,
volatile struct idpf_base_tx_desc *txd;
volatile struct idpf_base_tx_desc *txr;
union idpf_tx_offload tx_offload = {0};
-   struct idpf_tx_entry *txe, *txn;
-   struct idpf_tx_entry *sw_ring;
+   struct ci_tx_entry *txe, *txn;
+   struct ci_tx_entry *sw_ring;
struct ci_tx_queue *txq;
struct rte_mbuf *tx_pkt;
struct rte_mbuf *m_seg;
@@ -1371,7 +1371,7 @@ idpf_dp_singleq_xmit_pkts(void *tx_queue, struct rte_mbuf 
**tx_pkts,
if (unlikely(txq == NULL))
return nb_tx;
 
-   sw_ring = (struct idpf_tx_entry *)txq->sw_ring;
+   sw_ring = txq->

[PATCH v5 4/4] net/idpf: use common Tx free fn in idpf

[Shaiq Wani]

Switch the idpf driver to use the common Tx free function for
AVX2 and AVX512

Signed-off-by: Shaiq Wani 
---
 .../net/intel/idpf/idpf_common_rxtx_avx2.c|  68 +
 .../net/intel/idpf/idpf_common_rxtx_avx512.c  | 237 +-
 2 files changed, 22 insertions(+), 283 deletions(-)

diff --git a/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c 
b/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
index bce0257804..6399f357d3 100644
--- a/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
+++ b/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
@@ -79,6 +79,14 @@ idpf_singleq_rx_rearm(struct idpf_rx_queue *rxq)
IDPF_PCI_REG_WRITE(rxq->qrx_tail, rx_id);
 }
 
+static inline int
+idpf_tx_desc_done(struct ci_tx_queue *txq, uint16_t idx)
+{
+   return (txq->idpf_tx_ring[idx].qw1 &
+   rte_cpu_to_le_64(IDPF_TXD_QW1_DTYPE_M)) ==
+   rte_cpu_to_le_64(IDPF_TX_DESC_DTYPE_DESC_DONE);
+}
+
 static inline uint16_t
 _idpf_singleq_recv_raw_pkts_vec_avx2(struct idpf_rx_queue *rxq, struct 
rte_mbuf **rx_pkts,
 uint16_t nb_pkts)
@@ -479,64 +487,6 @@ idpf_dp_singleq_recv_pkts_avx2(void *rx_queue, struct 
rte_mbuf **rx_pkts, uint16
return _idpf_singleq_recv_raw_pkts_vec_avx2(rx_queue, rx_pkts, nb_pkts);
 }
 
-static __rte_always_inline int
-idpf_singleq_tx_free_bufs_vec(struct ci_tx_queue *txq)
-{
-   struct ci_tx_entry_vec *txep;
-   uint32_t n;
-   uint32_t i;
-   int nb_free = 0;
-   struct rte_mbuf *m;
-   struct rte_mbuf **free = alloca(sizeof(struct rte_mbuf *) * 
txq->tx_rs_thresh);
-
-   /* check DD bits on threshold descriptor */
-   if ((txq->idpf_tx_ring[txq->tx_next_dd].qw1 &
-   rte_cpu_to_le_64(IDPF_TXD_QW1_DTYPE_M)) !=
-   rte_cpu_to_le_64(IDPF_TX_DESC_DTYPE_DESC_DONE))
-   return 0;
-
-   n = txq->tx_rs_thresh;
-
-/* first buffer to free from S/W ring is at index
- * tx_next_dd - (tx_rs_thresh-1)
- */
-   txep = &txq->sw_ring_vec[txq->tx_next_dd - (n - 1)];
-   m = rte_pktmbuf_prefree_seg(txep[0].mbuf);
-   if (likely(m)) {
-   free[0] = m;
-   nb_free = 1;
-   for (i = 1; i < n; i++) {
-   m = rte_pktmbuf_prefree_seg(txep[i].mbuf);
-   if (likely(m)) {
-   if (likely(m->pool == free[0]->pool)) {
-   free[nb_free++] = m;
-   } else {
-   rte_mempool_put_bulk(free[0]->pool,
-(void *)free,
-nb_free);
-   free[0] = m;
-   nb_free = 1;
-   }
-   }
-   }
-   rte_mempool_put_bulk(free[0]->pool, (void **)free, nb_free);
-   } else {
-   for (i = 1; i < n; i++) {
-   m = rte_pktmbuf_prefree_seg(txep[i].mbuf);
-   if (m)
-   rte_mempool_put(m->pool, m);
-   }
-   }
-
-   /* buffers were freed, update counters */
-   txq->nb_tx_free = (uint16_t)(txq->nb_tx_free + txq->tx_rs_thresh);
-   txq->tx_next_dd = (uint16_t)(txq->tx_next_dd + txq->tx_rs_thresh);
-   if (txq->tx_next_dd >= txq->nb_tx_desc)
-   txq->tx_next_dd = (uint16_t)(txq->tx_rs_thresh - 1);
-
-   return txq->tx_rs_thresh;
-}
-
 static inline void
 idpf_singleq_vtx1(volatile struct idpf_base_tx_desc *txdp,
  struct rte_mbuf *pkt, uint64_t flags)
@@ -621,7 +571,7 @@ idpf_singleq_xmit_fixed_burst_vec_avx2(void *tx_queue, 
struct rte_mbuf **tx_pkts
nb_pkts = RTE_MIN(nb_pkts, txq->tx_rs_thresh);
 
if (txq->nb_tx_free < txq->tx_free_thresh)
-   idpf_singleq_tx_free_bufs_vec(txq);
+   ci_tx_free_bufs_vec(txq, idpf_tx_desc_done, false);
 
nb_commit = nb_pkts = (uint16_t)RTE_MIN(txq->nb_tx_free, nb_pkts);
if (unlikely(nb_pkts == 0))
diff --git a/drivers/net/intel/idpf/idpf_common_rxtx_avx512.c 
b/drivers/net/intel/idpf/idpf_common_rxtx_avx512.c
index c0ec754642..dbbdc71e22 100644
--- a/drivers/net/intel/idpf/idpf_common_rxtx_avx512.c
+++ b/drivers/net/intel/idpf/idpf_common_rxtx_avx512.c
@@ -122,6 +122,14 @@ idpf_singleq_rearm_common(struct idpf_rx_queue *rxq)
IDPF_PCI_REG_WRITE(rxq->qrx_tail, rx_id);
 }
 
+static inline int
+idpf_tx_desc_done(struct ci_tx_queue *txq, uint16_t idx)
+{
+   return (txq->idpf_tx_ring[idx].qw1 &
+   rte_cpu_to_le_64(IDPF_TXD_QW1_DTYPE_M)) ==
+   rte_cpu_to_le_64(IDPF_TX_DESC_DTYPE_DESC_DONE);
+}
+
 static __rte_always_inline void
 idpf_singleq_rearm(struct idpf_rx_queue *rxq)
 {
@@ -99

[PATCH v5 0/4] net/intel: using common functions in idpf driver

[Shaiq Wani]

reworked the drivers to use the common functions
and structures from drivers/net/intel/common.

Shaiq Wani (4):
  net/intel: align Tx queue struct field names
  net/intel: use common Tx queue structure
  net/intel: use common Tx entry structure
  net/idpf: use common Tx free fn in idpf

 drivers/net/intel/common/tx.h |  20 ++
 drivers/net/intel/cpfl/cpfl_ethdev.c  |   3 +-
 drivers/net/intel/cpfl/cpfl_ethdev.h  |   2 +-
 drivers/net/intel/cpfl/cpfl_rxtx.c|  66 ++--
 drivers/net/intel/cpfl/cpfl_rxtx.h|   3 +-
 drivers/net/intel/cpfl/cpfl_rxtx_vec_common.h |   7 +-
 drivers/net/intel/idpf/idpf_common_rxtx.c | 116 +++
 drivers/net/intel/idpf/idpf_common_rxtx.h |  69 +---
 .../net/intel/idpf/idpf_common_rxtx_avx2.c| 115 ++-
 .../net/intel/idpf/idpf_common_rxtx_avx512.c  | 324 +++---
 drivers/net/intel/idpf/idpf_common_virtchnl.c |   8 +-
 drivers/net/intel/idpf/idpf_common_virtchnl.h |   2 +-
 drivers/net/intel/idpf/idpf_ethdev.c  |   3 +-
 drivers/net/intel/idpf/idpf_rxtx.c|  47 ++-
 drivers/net/intel/idpf/idpf_rxtx.h|   1 +
 drivers/net/intel/idpf/idpf_rxtx_vec_common.h |   9 +-
 16 files changed, 245 insertions(+), 550 deletions(-)

-- 
2.34.1

[PATCH v5 1/8] lib: remove incorrect exported symbols

[David Marchand]

Declaring inline helpers in version.map is unnecessary.
There is no exported symbol and this will probably be treated as an
error by MSVC linker.

eal_log_journal has no implementation and can be removed.

Signed-off-by: David Marchand 
---
 lib/eventdev/version.map | 12 
 lib/graph/version.map| 17 -
 lib/ipsec/version.map|  4 
 lib/log/log_internal.h   |  3 ---
 lib/log/version.map  |  1 -
 lib/pdcp/version.map |  4 
 lib/regexdev/version.map |  2 --
 lib/vhost/version.map|  1 -
 8 files changed, 44 deletions(-)

diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
index 44687255cb..bff08d6a62 100644
--- a/lib/eventdev/version.map
+++ b/lib/eventdev/version.map
@@ -102,9 +102,6 @@ DPDK_25 {
rte_event_timer_adapter_stats_get;
rte_event_timer_adapter_stats_reset;
rte_event_timer_adapter_stop;
-   rte_event_timer_arm_burst;
-   rte_event_timer_arm_tmo_tick_burst;
-   rte_event_timer_cancel_burst;
rte_event_vector_pool_create;
 
local: *;
@@ -149,9 +146,7 @@ EXPERIMENTAL {
__rte_eventdev_trace_port_profile_switch;
 
# added in 24.11
-   rte_event_port_preschedule_modify;
__rte_eventdev_trace_port_preschedule_modify;
-   rte_event_port_preschedule;
__rte_eventdev_trace_port_preschedule;
 
# added in 25.03
@@ -166,14 +161,7 @@ INTERNAL {
event_dev_probing_finish;
rte_event_logtype;
rte_event_pmd_allocate;
-   rte_event_pmd_get_named_dev;
-   rte_event_pmd_is_valid_dev;
-   rte_event_pmd_pci_probe;
-   rte_event_pmd_pci_probe_named;
-   rte_event_pmd_pci_remove;
rte_event_pmd_release;
rte_event_pmd_selftest_seqn_dynfield_offset;
-   rte_event_pmd_vdev_init;
-   rte_event_pmd_vdev_uninit;
rte_eventdevs;
 };
diff --git a/lib/graph/version.map b/lib/graph/version.map
index 44fadc00fd..d03d44434d 100644
--- a/lib/graph/version.map
+++ b/lib/graph/version.map
@@ -27,9 +27,7 @@ DPDK_25 {
rte_graph_node_get;
rte_graph_node_get_by_name;
rte_graph_obj_dump;
-   rte_graph_walk;
rte_graph_worker_model_get;
-   rte_graph_worker_model_no_check_get;
rte_graph_worker_model_set;
rte_node_clone;
rte_node_dump;
@@ -37,25 +35,10 @@ DPDK_25 {
rte_node_edge_get;
rte_node_edge_shrink;
rte_node_edge_update;
-   rte_node_enqueue;
-   rte_node_enqueue_next;
-   rte_node_enqueue_x1;
-   rte_node_enqueue_x2;
-   rte_node_enqueue_x4;
rte_node_from_name;
rte_node_id_to_name;
rte_node_list_dump;
rte_node_max_count;
-   rte_node_next_stream_get;
-   rte_node_next_stream_move;
-   rte_node_next_stream_put;
 
local: *;
 };
-
-EXPERIMENTAL {
-   global:
-
-   # added in 24.11
-   rte_node_xstat_increment;
-};
diff --git a/lib/ipsec/version.map b/lib/ipsec/version.map
index 308f9d2e0d..47e3df5bb6 100644
--- a/lib/ipsec/version.map
+++ b/lib/ipsec/version.map
@@ -1,9 +1,6 @@
 DPDK_25 {
global:
 
-   rte_ipsec_pkt_crypto_group;
-   rte_ipsec_pkt_crypto_prepare;
-   rte_ipsec_pkt_process;
rte_ipsec_sa_fini;
rte_ipsec_sa_init;
rte_ipsec_sa_size;
@@ -14,7 +11,6 @@ DPDK_25 {
rte_ipsec_sad_destroy;
rte_ipsec_sad_find_existing;
rte_ipsec_sad_lookup;
-   rte_ipsec_ses_from_crypto;
rte_ipsec_session_prepare;
rte_ipsec_telemetry_sa_add;
rte_ipsec_telemetry_sa_del;
diff --git a/lib/log/log_internal.h b/lib/log/log_internal.h
index bba7041ea3..525e1397fd 100644
--- a/lib/log/log_internal.h
+++ b/lib/log/log_internal.h
@@ -29,9 +29,6 @@ int eal_log_save_pattern(const char *pattern, uint32_t level);
 __rte_internal
 int eal_log_syslog(const char *name);
 
-__rte_internal
-int eal_log_journal(const char *opt);
-
 /*
  * Convert log level to string.
  */
diff --git a/lib/log/version.map b/lib/log/version.map
index 09d8a4289b..603be493b3 100644
--- a/lib/log/version.map
+++ b/lib/log/version.map
@@ -27,7 +27,6 @@ INTERNAL {
 
eal_log_color;
eal_log_init;
-   eal_log_journal; # WINDOWS_NO_EXPORT
eal_log_level2str;
eal_log_save_pattern;
eal_log_save_regexp;
diff --git a/lib/pdcp/version.map b/lib/pdcp/version.map
index 9c02303c45..72b2d4729b 100644
--- a/lib/pdcp/version.map
+++ b/lib/pdcp/version.map
@@ -3,13 +3,9 @@ EXPERIMENTAL {
 
# added in 23.07
rte_pdcp_control_pdu_create;
-   rte_pdcp_en_from_cop;
rte_pdcp_entity_establish;
rte_pdcp_entity_release;
rte_pdcp_entity_suspend;
-   rte_pdcp_pkt_post_process;
-   rte_pdcp_pkt_pre_process;
-   rte_pdcp_pkt_crypto_group;
rte_pdcp_t_reordering_expiry_handle;
 
local: *;
diff --git a/lib/regexdev/version.map b/lib/regexdev/version.map
index 4c0435180c..713a800ca4 100644
--- a/lib/regexdev/version.map
+

[PATCH v5 3/8] buildtools: display version when listing symbols

[David Marchand]

Display the version when a symbol was introduced.
This is needed for scripting the conversion from static to dynamically
generated version maps.
It is also useful when listing experimental symbols.

Signed-off-by: David Marchand 
---
 buildtools/map-list-symbol.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/buildtools/map-list-symbol.sh b/buildtools/map-list-symbol.sh
index 43f276c05f..eb98451d8e 100755
--- a/buildtools/map-list-symbol.sh
+++ b/buildtools/map-list-symbol.sh
@@ -73,7 +73,7 @@ for file in $@; do
if ("'$symbol'" == "all" || $1 == "'$symbol'") {
ret = 0;
if ("'$quiet'" == "") {
-   print "'$file' "current_section" "$1;
+   print "'$file' "current_section" "$1" 
"current_version;
}
if ("'$symbol'" != "all") {
exit 0;
-- 
2.48.1

Re: [PATCH v5 5/8] build: mark exported symbols

[David Marchand]

On Thu, Mar 27, 2025 at 2:50 PM David Marchand
 wrote:
>
> Annotate symbols with newly introduced export macros.
>
> For code not compiled via drivers/meson.build (think base drivers code),
> the exported symbols are added in some new .c listed in the sources so they
> get caught by drivers/meson.build.
>
> Signed-off-by: David Marchand 
> ---
> Changes since RFC v4:
> - rebased and fixed mlx5 new export,

I missed exporting this symbol in the windows implementation.


-- 
David Marchand

Re: [PATCH] acl: fix build with GCC 15 on aarch64

[Bruce Richardson]

On Wed, Mar 26, 2025 at 11:39:28AM +0100, David Marchand wrote:
> Caught in OBS for Fedora Rawhide on aarch64:
> 
> [  198s] In file included from ../lib/acl/acl_run_neon.h:7,
> [  198s]  from ../lib/acl/acl_run_neon.c:5:
> [  198s] In function ‘alloc_completion’,
> [  198s] inlined from ‘acl_start_next_trie’ at
>   ../lib/acl/acl_run.h:140:24,
> [  198s] inlined from ‘search_neon_4.isra’ at
>   ../lib/acl/acl_run_neon.h:239:20:
> [  198s] ../lib/acl/acl_run.h:93:25: error: ‘cmplt’ may be used
>   uninitialized [-Werror=maybe-uninitialized]
> [  198s]93 | if (p[n].count == 0) {
> [  198s]   | ^~
> [  198s] ../lib/acl/acl_run_neon.h: In function ‘search_neon_4.isra’:
> [  198s] ../lib/acl/acl_run_neon.h:230:27: note: ‘cmplt’ declared here
> [  198s]   230 | struct completion cmplt[4];
> [  198s]   |   ^
> 
> The code was resetting sequentially cmpl[].count at the exact index that
> later call to alloc_completion uses.
> While this code seems correct, GCC 15 does not understand this (probably
> when applying some optimisations).
> 
> Instead, reset cmpl[].count all at once in acl_set_flow, and cleanup the
> various vectorized implementations accordingly.
> 
> Bugzilla ID: 1678
> Cc: sta...@dpdk.org
> 
> Signed-off-by: David Marchand 
> ---
Acked-by: Bruce Richardson 

Re: [PATCH v6 00/14] net/zxdh: add network processor ops

[Stephen Hemminger]

On Fri, 21 Mar 2025 15:31:46 +0800
Bingbin Chen  wrote:

> v6:
>   - Use byte stream to process bar channel return messages
> and modify some issues to ensure proper functionality.
> 
> v5:
>   - the VF read/write table function is fixed.
> 
> v4:
>   - change some tables to const.
>   - use %u instead of %d.
>   - delete cast of ret_zmalloc() return.
>   - resolve code functionality issues.
> 
> V3:
>   - resolve code style.
>   - resolve spin lock build issue.
>   - rebase code baseline.
>   - modify parameters of the plcr function.
> 
> V2:
>   - resolve code style and github-robot build issue.
>   - eliminate commit warning.
>   - remove unnecessary initialization, which first usage will set.
>   - replace mutex lock with spinlock.
> 
> V1:
>   - updated network processor driver.
>   - improve insert/delete/get table code funcs.
> 
> Bingbin Chen (14):
>   net/zxdh: add network processor registers ops
>   net/zxdh: support compatibility check
>   net/zxdh: add agent channel
>   net/zxdh: modify dtb queue ops
>   net/zxdh: add tables dump address ops
>   net/zxdh: add eram tables ops
>   net/zxdh: get flow tables resources
>   net/zxdh: support hash resources configuration
>   net/zxdh: implement tables initialization
>   net/zxdh: support hash tables write and delete ops
>   net/zxdh: get hash table entry result
>   net/zxdh: delete all hash entries
>   net/zxdh: add acl tables ops
>   net/zxdh: optimize msg processing ops and modify some issues
> 
>  drivers/net/zxdh/zxdh_common.h |   100 +
>  drivers/net/zxdh/zxdh_ethdev.c |88 +-
>  drivers/net/zxdh/zxdh_ethdev.h | 1 +
>  drivers/net/zxdh/zxdh_ethdev_ops.c |   109 +-
>  drivers/net/zxdh/zxdh_ethdev_ops.h |35 +
>  drivers/net/zxdh/zxdh_msg.c|   381 +-
>  drivers/net/zxdh/zxdh_msg.h|99 +-
>  drivers/net/zxdh/zxdh_mtr.c|50 +-
>  drivers/net/zxdh/zxdh_mtr.h| 5 +
>  drivers/net/zxdh/zxdh_np.c | 11631 +++
>  drivers/net/zxdh/zxdh_np.h |  1243 ++-
>  drivers/net/zxdh/zxdh_pci.c|24 +-
>  drivers/net/zxdh/zxdh_pci.h| 2 +-
>  drivers/net/zxdh/zxdh_rxtx.c   |12 +-
>  drivers/net/zxdh/zxdh_tables.c |67 +-
>  drivers/net/zxdh/zxdh_tables.h |68 +-
>  16 files changed, 11983 insertions(+), 1932 deletions(-)
> 

Applied to next-net with a couple of small additions:
  1. Added Bingbing Chen to mailmap
  2. Removed unnecessary usage of VLA and enabled warning

Re: [PATCH v5 0/8] Symbol versioning and export rework

[David Marchand]

On Thu, Mar 27, 2025 at 2:37 PM David Marchand
 wrote:
>
> So far, each DPDK library (or driver) exposing symbols in an ABI had to
> maintain a version.map and use some macros for symbol versioning,
> specially crafted with the GNU linker in mind.
>
> This series proposes to rework the whole principle, and instead rely on
> marking the symbol exports in the source code itself, then let it to the
> build framework to produce a version script adapted to the linker in use
> (think GNU linker vs MSVC linker).
>
> This greatly simplifies versioning symbols: a developer does not need to
> know anything about version.map, or that a versioned symbol must be
> renamed with _v26, annotated with __vsym, exported in a header etc...
>
> Checking symbol maps becomes unnecessary since generated by the build
> framework.
>
> Updating to a new ABI is just a matter of bumping the value in
> ABI_VERSION.

Intel CI keeps on spewing non sense failures on doc generation, as it
filters out doc/ updates from patches...


-- 
David Marchand

[PATCH v3 9/9] net/intel: simplify base code builds

[Bruce Richardson]

Now that base-code warning flags have been removed from a number of
drivers, we can simplify their build configuration by just including the
base code files in the regular list of driver files passed back. There
is no need to use pre-compiled objects.

Signed-off-by: Bruce Richardson 
---
 drivers/net/intel/e1000/base/meson.build | 9 ++---
 drivers/net/intel/e1000/meson.build  | 4 ++--
 drivers/net/intel/fm10k/base/meson.build | 9 ++---
 drivers/net/intel/fm10k/meson.build  | 4 ++--
 drivers/net/intel/i40e/base/meson.build  | 9 ++---
 drivers/net/intel/i40e/meson.build   | 4 ++--
 drivers/net/intel/idpf/base/meson.build  | 2 +-
 drivers/net/intel/idpf/meson.build   | 7 ---
 drivers/net/intel/ixgbe/base/meson.build | 9 ++---
 drivers/net/intel/ixgbe/meson.build  | 4 ++--
 10 files changed, 21 insertions(+), 40 deletions(-)

diff --git a/drivers/net/intel/e1000/base/meson.build 
b/drivers/net/intel/e1000/base/meson.build
index 8cbd9f62e6..4fe86dc6df 100644
--- a/drivers/net/intel/e1000/base/meson.build
+++ b/drivers/net/intel/e1000/base/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-sources = [
+base_sources = files(
 'e1000_base.c',
 'e1000_80003es2lan.c',
 'e1000_82540.c',
@@ -21,9 +21,4 @@ sources = [
 'e1000_osdep.c',
 'e1000_phy.c',
 'e1000_vf.c',
-]
-
-base_lib = static_library('e1000_base', sources,
-dependencies: static_rte_eal,
-c_args: cflags)
-base_objs = base_lib.extract_all_objects(recursive: true)
+)
diff --git a/drivers/net/intel/e1000/meson.build 
b/drivers/net/intel/e1000/meson.build
index cd42c0042a..b52a843228 100644
--- a/drivers/net/intel/e1000/meson.build
+++ b/drivers/net/intel/e1000/meson.build
@@ -2,9 +2,9 @@
 # Copyright(c) 2017 Intel Corporation
 
 subdir('base')
-objs = [base_objs]
 
-sources = files(
+sources += base_sources
+sources += files(
 'e1000_logs.c',
 'em_ethdev.c',
 'em_rxtx.c',
diff --git a/drivers/net/intel/fm10k/base/meson.build 
b/drivers/net/intel/fm10k/base/meson.build
index a2640d1ee8..c45b31d6b2 100644
--- a/drivers/net/intel/fm10k/base/meson.build
+++ b/drivers/net/intel/fm10k/base/meson.build
@@ -1,16 +1,11 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-sources = [
+base_sources = files(
 'fm10k_api.c',
 'fm10k_common.c',
 'fm10k_mbx.c',
 'fm10k_pf.c',
 'fm10k_tlv.c',
 'fm10k_vf.c',
-]
-
-base_lib = static_library('fm10k_base', sources,
-dependencies: static_rte_eal,
-c_args: cflags)
-base_objs = base_lib.extract_all_objects(recursive: true)
+)
diff --git a/drivers/net/intel/fm10k/meson.build 
b/drivers/net/intel/fm10k/meson.build
index 69566add96..e08a00cb49 100644
--- a/drivers/net/intel/fm10k/meson.build
+++ b/drivers/net/intel/fm10k/meson.build
@@ -8,9 +8,9 @@ if is_windows
 endif
 
 subdir('base')
-objs = [base_objs]
 
-sources = files(
+sources += base_sources
+sources += files(
 'fm10k_ethdev.c',
 'fm10k_rxtx.c',
 )
diff --git a/drivers/net/intel/i40e/base/meson.build 
b/drivers/net/intel/i40e/base/meson.build
index 766383101b..7b4882ad1d 100644
--- a/drivers/net/intel/i40e/base/meson.build
+++ b/drivers/net/intel/i40e/base/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2020 Intel Corporation
 
-sources = [
+base_sources = files(
 'i40e_adminq.c',
 'i40e_common.c',
 'i40e_dcb.c',
@@ -9,9 +9,4 @@ sources = [
 'i40e_hmc.c',
 'i40e_lan_hmc.c',
 'i40e_nvm.c',
-]
-
-base_lib = static_library('i40e_base', sources,
-dependencies: static_rte_eal,
-c_args: cflags)
-base_objs = base_lib.extract_all_objects(recursive: true)
+)
diff --git a/drivers/net/intel/i40e/meson.build 
b/drivers/net/intel/i40e/meson.build
index 15993393fb..17b6715cd9 100644
--- a/drivers/net/intel/i40e/meson.build
+++ b/drivers/net/intel/i40e/meson.build
@@ -18,9 +18,9 @@ if dpdk_conf.get('RTE_IOVA_IN_MBUF') == 0
 endif
 
 subdir('base')
-objs = [base_objs]
 
-sources = files(
+sources += base_sources
+sources += files(
 'i40e_ethdev.c',
 'i40e_rxtx.c',
 'i40e_pf.c',
diff --git a/drivers/net/intel/idpf/base/meson.build 
b/drivers/net/intel/idpf/base/meson.build
index 7316e0a805..78782e463e 100644
--- a/drivers/net/intel/idpf/base/meson.build
+++ b/drivers/net/intel/idpf/base/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2023 Intel Corporation
 
-sources += files(
+base_sources = files(
 'idpf_controlq.c',
 'idpf_controlq_setup.c',
 )
diff --git a/drivers/net/intel/idpf/meson.build 
b/drivers/net/intel/idpf/meson.build
index 4b272d02b1..a8690da87b 100644
--- a/drivers/net/intel/idpf/meson.build
+++ b/drivers/net/intel/idpf/meson.build
@@ -7,9 +7,12 @@ if is_windows
 subdir_done()
 endif
 
+subdir('base')
+
 includes += incl

Re: [PATCH v4] rust: support raw DPDK API

[Bruce Richardson]

On Sat, Mar 22, 2025 at 12:59:11PM +0200, Gregory Etelson wrote:
> The patch converts include files with DPDK API to RUST and binds new
> RUST API files into raw module under dpdk crate.
> 
> The RUST files and DPDK libraries build from C sources
> allow creation of DPDK application in RUST.
> 
> RUST DPDK application must specify the `dpdk` crate as
> dependency in Cargo.toml file.
> 
> RUST `dpdk` crate is installed into
> $MESON_INSTALL_DESTDIR_PREFIX/$libdir/rust directory.
> 
> Software requirements:
> - clang
> - RUST installation
> - bindgen-cli crate
> 
> RUST dpdk installation instructions:
> 1. Configure DPDK with `-Deanble_rust=true`
> 2. Build and install DPDK. The installation procedure will create
>$MESON_INSTALL_DESTDIR_PREFIX/$libdir/rust crate.
> 3. Update PKG_CONFIG_PATH to point to DPDK installation.
> 
> Signed-off-by: Gregory Etelson 

Hi Gregory,

some additional thoughts and comments inline below.

/Bruce

> ---
> v2:
> Change rust crate name from dpdklib to dpdk.
> Add raw module for to link with C API.
> Add "cargo:rerun-if-changed=build.rs".
> v3:
> Move init_port_config() to Port.
> Move start_port() to Port.
> Remove Cargo.lock from git repository
> Reformat code.
> v4:
> Blocked bindgen to convert stdlib functions with u128 type.
> Allow compilation of C style symbols.

When using bindgen, are we better to take the approach (as in this patch)
of running it on everything in the headers and just excluding some things,
or taking the opposite conservative approach of just listing the functions
and defines we actually do want exposed (with wildcarding as necessary)?
When playing with rust apps on top of DPDK myself, I've tended toward the
latter scheme, but maybe for this effort we may want the former.

> ---
>  buildtools/meson.build   |   4 +
>  buildtools/rust-env.sh   |  96 
>  examples/rust/helloworld/Cargo.toml  |   7 +
>  examples/rust/helloworld/build.rs|  24 +++
>  examples/rust/helloworld/src/main.rs | 219 +++
>  meson_options.txt|   2 +
>  6 files changed, 352 insertions(+)
>  create mode 100755 buildtools/rust-env.sh
>  create mode 100644 examples/rust/helloworld/Cargo.toml
>  create mode 100644 examples/rust/helloworld/build.rs
>  create mode 100644 examples/rust/helloworld/src/main.rs
> 
> diff --git a/buildtools/meson.build b/buildtools/meson.build
> index 4e2c1217a2..b9d0092f07 100644
> --- a/buildtools/meson.build
> +++ b/buildtools/meson.build
> @@ -50,3 +50,7 @@ else
>  pmdinfo += 'ar'
>  pmdinfogen += 'elf'
>  endif
> +
> +if get_option('enable_rust')
> +meson.add_install_script(['rust-env.sh', get_option('libdir')])
> +endif

I'm not convinced by having this done as a post-install script. Instead I'd
tend towards having a rust crate hosted somewhere that does the bindgen as
part of the rust build.

> diff --git a/buildtools/rust-env.sh b/buildtools/rust-env.sh
> new file mode 100755
> index 00..a239432a28
> --- /dev/null
> +++ b/buildtools/rust-env.sh
> @@ -0,0 +1,96 @@
> +#! /bin/sh
> +
> +# Convert DPDK API files into RUST.
> +# DPDK files selection is on demand.
> +#



> diff --git a/examples/rust/helloworld/build.rs 
> b/examples/rust/helloworld/build.rs
> new file mode 100644
> index 00..bd5737d209
> --- /dev/null
> +++ b/examples/rust/helloworld/build.rs
> @@ -0,0 +1,24 @@
> +use std::process::Command;
> +
> +pub fn main() {
> +let mut pkgconfig = Command::new("pkg-config");
> +
> +match pkgconfig.args(["--libs", "libdpdk"]).output() {

This work of using pkgconfig should not be necessary in the application
build.rs file. If we switch to actually producing a proper crate, the
pkgconfig handling and linking should be covered there (I would hope,
anyway).

> +Ok(output) => {
> +let stdout = String::from_utf8_lossy(&output.stdout)
> +.trim_end()
> +.to_string();
> +for token in stdout.split_ascii_whitespace().filter(|s| 
> !s.is_empty()) {
> +if token.starts_with("-L") {
> +println!("cargo::rustc-link-search=native={}", 
> &token[2..]);
> +} else if token.starts_with("-l") {
> +println!("cargo::rustc-link-lib={}", &token[2..]);
> +}
> +}
> +println!("cargo:rerun-if-changed=build.rs");
> +}
> +Err(error) => {
> +panic!("failed to read libdpdk package: {:?}", error);
> +}
> +}
> +}

[PATCH v3 5/9] net/ixgbe/base: fix lock checker errors

[Bruce Richardson]

When building on FreeBSD, errors are reported in the base code by the
lock checker (-Wthread-safety). For example:

../drivers/net/intel/ixgbe/base/ixgbe_osdep.c:42:1: error: mutex 'lock->mutex' 
is still held at the end of function [-Werror,-Wthread-safety-analysis]
   42 | }
  | ^

These errors are due to the checker not recognising the lock wrapper
functions. We can avoid these errors by converting these functions into
macros.

Fixes: 30b19d1b5c43 ("net/ixgbe/base: add definitions for E610")
Cc: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 drivers/net/intel/ixgbe/base/ixgbe_osdep.c | 20 
 drivers/net/intel/ixgbe/base/ixgbe_osdep.h |  8 
 2 files changed, 4 insertions(+), 24 deletions(-)

diff --git a/drivers/net/intel/ixgbe/base/ixgbe_osdep.c 
b/drivers/net/intel/ixgbe/base/ixgbe_osdep.c
index d3d7e8e116..778f74e644 100644
--- a/drivers/net/intel/ixgbe/base/ixgbe_osdep.c
+++ b/drivers/net/intel/ixgbe/base/ixgbe_osdep.c
@@ -25,23 +25,3 @@ ixgbe_free(struct ixgbe_hw __rte_unused *hw, void *addr)
 {
free(addr);
 }
-
-void ixgbe_init_lock(struct ixgbe_lock *lock)
-{
-   pthread_mutex_init(&lock->mutex, NULL);
-}
-
-void ixgbe_destroy_lock(struct ixgbe_lock *lock)
-{
-   pthread_mutex_destroy(&lock->mutex);
-}
-
-void ixgbe_acquire_lock(struct ixgbe_lock *lock)
-{
-   pthread_mutex_lock(&lock->mutex);
-}
-
-void ixgbe_release_lock(struct ixgbe_lock *lock)
-{
-   pthread_mutex_unlock(&lock->mutex);
-}
diff --git a/drivers/net/intel/ixgbe/base/ixgbe_osdep.h 
b/drivers/net/intel/ixgbe/base/ixgbe_osdep.h
index 398c38bffd..6e35991f49 100644
--- a/drivers/net/intel/ixgbe/base/ixgbe_osdep.h
+++ b/drivers/net/intel/ixgbe/base/ixgbe_osdep.h
@@ -167,9 +167,9 @@ void *ixgbe_calloc(struct ixgbe_hw *hw, size_t count, 
size_t size);
 void *ixgbe_malloc(struct ixgbe_hw *hw, size_t size);
 void ixgbe_free(struct ixgbe_hw *hw, void *addr);
 
-void ixgbe_init_lock(struct ixgbe_lock *lock);
-void ixgbe_destroy_lock(struct ixgbe_lock *lock);
-void ixgbe_acquire_lock(struct ixgbe_lock *lock);
-void ixgbe_release_lock(struct ixgbe_lock *lock);
+#define ixgbe_init_lock(lock) pthread_mutex_init(&(lock)->mutex, NULL)
+#define ixgbe_destroy_lock(lock) pthread_mutex_destroy(&(lock)->mutex)
+#define ixgbe_acquire_lock(lock) pthread_mutex_lock(&(lock)->mutex)
+#define ixgbe_release_lock(lock)   pthread_mutex_unlock(&(lock)->mutex)
 
 #endif /* _IXGBE_OS_H_ */
-- 
2.45.2

[PATCH v3 6/9] net/i40e/base: fix unused value warnings

[Bruce Richardson]

Fix warnings about unused values - parameters, variables, etc., and
remove the warning disable flags for them. Although modifying the
base-code files is not ideal, the changes required are minor, and only
affect two files from the imported base code.

Fixes: 8db9e2a1b232 ("i40e: base driver")
Cc: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 drivers/net/intel/i40e/base/i40e_nvm.c   |  2 +-
 drivers/net/intel/i40e/base/i40e_osdep.h |  4 ++--
 drivers/net/intel/i40e/base/i40e_type.h  | 14 +-
 drivers/net/intel/i40e/base/meson.build  |  3 ---
 drivers/net/intel/i40e/i40e_ethdev.c |  1 +
 5 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/drivers/net/intel/i40e/base/i40e_nvm.c 
b/drivers/net/intel/i40e/base/i40e_nvm.c
index 3e16a0d997..56dc4d9279 100644
--- a/drivers/net/intel/i40e/base/i40e_nvm.c
+++ b/drivers/net/intel/i40e/base/i40e_nvm.c
@@ -1743,7 +1743,7 @@ STATIC enum i40e_status_code 
i40e_nvmupd_get_aq_result(struct i40e_hw *hw,
  **/
 STATIC enum i40e_status_code i40e_nvmupd_get_aq_event(struct i40e_hw *hw,
struct i40e_nvm_access *cmd,
-   u8 *bytes, int *perrno)
+   u8 *bytes, __rte_unused int 
*perrno)
 {
u32 aq_total_len;
u32 aq_desc_len;
diff --git a/drivers/net/intel/i40e/base/i40e_osdep.h 
b/drivers/net/intel/i40e/base/i40e_osdep.h
index c04f94732a..197f4678bf 100644
--- a/drivers/net/intel/i40e/base/i40e_osdep.h
+++ b/drivers/net/intel/i40e/base/i40e_osdep.h
@@ -184,8 +184,8 @@ struct __rte_packed_begin i40e_dma_mem {
const void *zone;
 } __rte_packed_end;
 
-#define i40e_allocate_dma_mem(h, m, unused, s, a) \
-   i40e_allocate_dma_mem_d(h, m, s, a)
+#define i40e_allocate_dma_mem(h, m, mt, s, a) \
+   i40e_allocate_dma_mem_d(h, m, mt, s, a)
 #define i40e_free_dma_mem(h, m) i40e_free_dma_mem_d(h, m)
 
 struct __rte_packed_begin i40e_virt_mem {
diff --git a/drivers/net/intel/i40e/base/i40e_type.h 
b/drivers/net/intel/i40e/base/i40e_type.h
index 7cc746f82f..968e1982a6 100644
--- a/drivers/net/intel/i40e/base/i40e_type.h
+++ b/drivers/net/intel/i40e/base/i40e_type.h
@@ -14,11 +14,15 @@
 #include "i40e_devids.h"
 
 #define UNREFERENCED_XPARAMETER
-#define UNREFERENCED_1PARAMETER(_p) (_p);
-#define UNREFERENCED_2PARAMETER(_p, _q) (_p); (_q);
-#define UNREFERENCED_3PARAMETER(_p, _q, _r) (_p); (_q); (_r);
-#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (_p); (_q); (_r); (_s);
-#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (_p); (_q); (_r); (_s); 
(_t);
+#define UNREFERENCED_1PARAMETER(_p) (void)(_p)
+#define UNREFERENCED_2PARAMETER(_p, _q) \
+   do { (void)(_p); (void)(_q); } while (0)
+#define UNREFERENCED_3PARAMETER(_p, _q, _r) \
+   do { (void)(_p); (void)(_q); (void)(_r); } while (0)
+#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) \
+   do { (void)(_p); (void)(_q); (void)(_r); (void)(_s); } while (0)
+#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) \
+   do { (void)(_p); (void)(_q); (void)(_r); (void)(_s); (void)(_t); } 
while (0)
 
 #define BIT(a) (1UL << (a))
 #define BIT_ULL(a) (1ULL << (a))
diff --git a/drivers/net/intel/i40e/base/meson.build 
b/drivers/net/intel/i40e/base/meson.build
index a0912b1788..2648e5d0c4 100644
--- a/drivers/net/intel/i40e/base/meson.build
+++ b/drivers/net/intel/i40e/base/meson.build
@@ -13,10 +13,7 @@ sources = [
 
 error_cflags = [
 '-Wno-sign-compare',
-'-Wno-unused-value',
 '-Wno-strict-aliasing',
-'-Wno-unused-but-set-variable',
-'-Wno-unused-parameter',
 ]
 c_args = cflags
 foreach flag: error_cflags
diff --git a/drivers/net/intel/i40e/i40e_ethdev.c 
b/drivers/net/intel/i40e/i40e_ethdev.c
index 1c5ab35a8b..90eba3419f 100644
--- a/drivers/net/intel/i40e/i40e_ethdev.c
+++ b/drivers/net/intel/i40e/i40e_ethdev.c
@@ -4694,6 +4694,7 @@ i40e_dev_rss_reta_query(struct rte_eth_dev *dev,
 enum i40e_status_code
 i40e_allocate_dma_mem_d(__rte_unused struct i40e_hw *hw,
struct i40e_dma_mem *mem,
+   __rte_unused enum i40e_memory_type mtype,
u64 size,
u32 alignment)
 {
-- 
2.45.2

[PATCH v3 7/9] net/i40e/base: fix compiler warnings

[Bruce Richardson]

Add a single-line fix to the base code, and then the remaining two
compiler warning disable flags can be removed from the driver base code
build file.

Fixes: 8db9e2a1b232 ("i40e: base driver")
Cc: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 drivers/net/intel/i40e/base/i40e_diag.c |  2 +-
 drivers/net/intel/i40e/base/meson.build | 13 +
 2 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/drivers/net/intel/i40e/base/i40e_diag.c 
b/drivers/net/intel/i40e/base/i40e_diag.c
index 4ca102cdd5..71b2e53e85 100644
--- a/drivers/net/intel/i40e/base/i40e_diag.c
+++ b/drivers/net/intel/i40e/base/i40e_diag.c
@@ -34,7 +34,7 @@ static enum i40e_status_code 
i40e_diag_reg_pattern_test(struct i40e_hw *hw,
 {
const u32 patterns[] = {0x5A5A5A5A, 0xA5A5A5A5, 0x, 0x};
u32 pat, val, orig_val;
-   int i;
+   unsigned int i;
 
orig_val = rd32(hw, reg);
for (i = 0; i < ARRAY_SIZE(patterns); i++) {
diff --git a/drivers/net/intel/i40e/base/meson.build 
b/drivers/net/intel/i40e/base/meson.build
index 2648e5d0c4..766383101b 100644
--- a/drivers/net/intel/i40e/base/meson.build
+++ b/drivers/net/intel/i40e/base/meson.build
@@ -11,18 +11,7 @@ sources = [
 'i40e_nvm.c',
 ]
 
-error_cflags = [
-'-Wno-sign-compare',
-'-Wno-strict-aliasing',
-]
-c_args = cflags
-foreach flag: error_cflags
-if cc.has_argument(flag)
-c_args += flag
-endif
-endforeach
-
 base_lib = static_library('i40e_base', sources,
 dependencies: static_rte_eal,
-c_args: c_args)
+c_args: cflags)
 base_objs = base_lib.extract_all_objects(recursive: true)
-- 
2.45.2

[PATCH v3 1/9] net/fm10k/base: fix compilation warnings

[Bruce Richardson]

The fixes required to re-enable warnings in the fm10k base code are
trivial, so let's make the changes and get a clean compile without any
warning disable flags.

* provide definitions for the UNREFERENCED_PARAMETER macros
* fix the spelling of the work "fallthrough" in comments
* provide a definition of FM10K_READ_PCI_WORD in os_dep.h that marks the
  parameters as used.

Fixes: 7223d200c227 ("fm10k: add base driver")
Cc: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 drivers/net/intel/fm10k/base/fm10k_mbx.c   |  2 +-
 drivers/net/intel/fm10k/base/fm10k_osdep.h |  2 +-
 drivers/net/intel/fm10k/base/fm10k_pf.c|  8 
 drivers/net/intel/fm10k/base/fm10k_type.h  |  6 +++---
 drivers/net/intel/fm10k/base/meson.build   | 14 +-
 5 files changed, 10 insertions(+), 22 deletions(-)

diff --git a/drivers/net/intel/fm10k/base/fm10k_mbx.c 
b/drivers/net/intel/fm10k/base/fm10k_mbx.c
index 2bb0d82efe..9028403757 100644
--- a/drivers/net/intel/fm10k/base/fm10k_mbx.c
+++ b/drivers/net/intel/fm10k/base/fm10k_mbx.c
@@ -1602,7 +1602,7 @@ s32 fm10k_pfvf_mbx_init(struct fm10k_hw *hw, struct 
fm10k_mbx_info *mbx,
mbx->mbmem_reg = FM10K_MBMEM_VF(id, 0);
break;
}
-   /* fallthough */
+   /* fallthrough */
default:
return FM10K_MBX_ERR_NO_MBX;
}
diff --git a/drivers/net/intel/fm10k/base/fm10k_osdep.h 
b/drivers/net/intel/fm10k/base/fm10k_osdep.h
index a727a57481..5f8ff10474 100644
--- a/drivers/net/intel/fm10k/base/fm10k_osdep.h
+++ b/drivers/net/intel/fm10k/base/fm10k_osdep.h
@@ -67,7 +67,7 @@ typedef uint64_t   u64;
 #define FM10K_PCI_REG_WRITE(reg, value) rte_write32((value), (reg))
 
 /* not implemented */
-#define FM10K_READ_PCI_WORD(hw, reg) 0
+#define FM10K_READ_PCI_WORD(hw, reg) ((void)hw, (void)reg, 0)
 
 #define FM10K_WRITE_MBX(hw, reg, value) FM10K_WRITE_REG(hw, reg, value)
 #define FM10K_READ_MBX(hw, reg) FM10K_READ_REG(hw, reg)
diff --git a/drivers/net/intel/fm10k/base/fm10k_pf.c 
b/drivers/net/intel/fm10k/base/fm10k_pf.c
index 439dd224de..b54116a4b5 100644
--- a/drivers/net/intel/fm10k/base/fm10k_pf.c
+++ b/drivers/net/intel/fm10k/base/fm10k_pf.c
@@ -1362,19 +1362,19 @@ STATIC u8 fm10k_iov_supported_xcast_mode_pf(struct 
fm10k_vf_info *vf_info,
case FM10K_XCAST_MODE_PROMISC:
if (vf_flags & FM10K_VF_FLAG_PROMISC_CAPABLE)
return FM10K_XCAST_MODE_PROMISC;
-   /* fallthough */
+   /* fallthrough */
case FM10K_XCAST_MODE_ALLMULTI:
if (vf_flags & FM10K_VF_FLAG_ALLMULTI_CAPABLE)
return FM10K_XCAST_MODE_ALLMULTI;
-   /* fallthough */
+   /* fallthrough */
case FM10K_XCAST_MODE_MULTI:
if (vf_flags & FM10K_VF_FLAG_MULTI_CAPABLE)
return FM10K_XCAST_MODE_MULTI;
-   /* fallthough */
+   /* fallthrough */
case FM10K_XCAST_MODE_NONE:
if (vf_flags & FM10K_VF_FLAG_NONE_CAPABLE)
return FM10K_XCAST_MODE_NONE;
-   /* fallthough */
+   /* fallthrough */
default:
break;
}
diff --git a/drivers/net/intel/fm10k/base/fm10k_type.h 
b/drivers/net/intel/fm10k/base/fm10k_type.h
index 84781ba9b2..437fb1c55e 100644
--- a/drivers/net/intel/fm10k/base/fm10k_type.h
+++ b/drivers/net/intel/fm10k/base/fm10k_type.h
@@ -83,9 +83,9 @@ struct fm10k_hw;
 #define FM10K_NOT_IMPLEMENTED  0x7FFF
 
 #define UNREFERENCED_XPARAMETER
-#define UNREFERENCED_1PARAMETER(_p) (_p)
-#define UNREFERENCED_2PARAMETER(_p, _q)do { (_p); (_q); } while (0)
-#define UNREFERENCED_3PARAMETER(_p, _q, _r) do { (_p); (_q); (_r); } while (0)
+#define UNREFERENCED_1PARAMETER(_p) (void)(_p)
+#define UNREFERENCED_2PARAMETER(_p, _q)do { (void)(_p); 
(void)(_q); } while (0)
+#define UNREFERENCED_3PARAMETER(_p, _q, _r) do { (void)(_p); (void)(_q); 
(void)(_r); } while (0)
 
 /* Start of PF registers */
 #define FM10K_CTRL 0x
diff --git a/drivers/net/intel/fm10k/base/meson.build 
b/drivers/net/intel/fm10k/base/meson.build
index f24e453fd0..a2640d1ee8 100644
--- a/drivers/net/intel/fm10k/base/meson.build
+++ b/drivers/net/intel/fm10k/base/meson.build
@@ -10,19 +10,7 @@ sources = [
 'fm10k_vf.c',
 ]
 
-error_cflags = [
-'-Wno-unused-parameter',
-'-Wno-unused-value',
-'-Wno-implicit-fallthrough',
-]
-c_args = cflags
-foreach flag: error_cflags
-if cc.has_argument(flag)
-c_args += flag
-endif
-endforeach
-
 base_lib = static_library('fm10k_base', sources,
 dependencies: static_rte_eal,
-c_args: c_args)
+c_args: cflags)
 base_objs = base_lib.extract_all_objects(recursive: true)
-- 
2.45.2

[PATCH v3 4/9] net/ixgbe/base: fix compilation warnings

[Bruce Richardson]

We can remove almost all of the "unused parameter" and "unused variable"
warnings by just improving the macro definitions in the osdep.h header.
Remaining two instances can be fixed by just one-line additions to the
code, so add those to give us a clean build with the warnings enabled.

Fixes: af75078fece3 ("first public release")
Fixes: c6cb313da739 ("net/ixgbe/base: add link management for E610")
Cc: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 drivers/net/intel/ixgbe/base/ixgbe_e610.c  |  2 ++
 drivers/net/intel/ixgbe/base/ixgbe_osdep.h | 19 +++
 drivers/net/intel/ixgbe/base/meson.build   | 11 ---
 3 files changed, 13 insertions(+), 19 deletions(-)

diff --git a/drivers/net/intel/ixgbe/base/ixgbe_e610.c 
b/drivers/net/intel/ixgbe/base/ixgbe_e610.c
index 5474c3012a..7420c78d07 100644
--- a/drivers/net/intel/ixgbe/base/ixgbe_e610.c
+++ b/drivers/net/intel/ixgbe/base/ixgbe_e610.c
@@ -1054,6 +1054,7 @@ static void ixgbe_parse_vsi_func_caps(struct ixgbe_hw *hw,
  struct ixgbe_hw_func_caps *func_p,
  struct ixgbe_aci_cmd_list_caps_elem *cap)
 {
+   UNREFERENCED_PARAMETER(cap);
func_p->guar_num_vsi = ixgbe_get_num_per_func(hw, IXGBE_MAX_VSI);
 }
 
@@ -1770,6 +1771,7 @@ s32 ixgbe_aci_set_event_mask(struct ixgbe_hw *hw, u8 
port_num, u16 mask)
struct ixgbe_aci_cmd_set_event_mask *cmd;
struct ixgbe_aci_desc desc;
 
+   UNREFERENCED_PARAMETER(port_num);
cmd = &desc.params.set_event_mask;
 
ixgbe_fill_dflt_direct_cmd_desc(&desc, ixgbe_aci_opc_set_event_mask);
diff --git a/drivers/net/intel/ixgbe/base/ixgbe_osdep.h 
b/drivers/net/intel/ixgbe/base/ixgbe_osdep.h
index 6e5f7b4ae8..398c38bffd 100644
--- a/drivers/net/intel/ixgbe/base/ixgbe_osdep.h
+++ b/drivers/net/intel/ixgbe/base/ixgbe_osdep.h
@@ -57,13 +57,16 @@
 
 /* Bunch of defines for shared code bogosity */
 #ifndef UNREFERENCED_PARAMETER
-#define UNREFERENCED_PARAMETER(_p)  
+#define UNREFERENCED_PARAMETER(_p) (void)(_p)
 #endif
-#define UNREFERENCED_1PARAMETER(_p) 
-#define UNREFERENCED_2PARAMETER(_p, _q)
-#define UNREFERENCED_3PARAMETER(_p, _q, _r) 
-#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) 
-#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t)
+#define UNREFERENCED_1PARAMETER(_p) (void)(_p)
+#define UNREFERENCED_2PARAMETER(_p, _q) do { (void)(_p); (void)(_q); } while(0)
+#define UNREFERENCED_3PARAMETER(_p, _q, _r) \
+   do { (void)(_p); (void)(_q); (void)(_r); } while(0)
+#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) \
+   do { (void)(_p); (void)(_q); (void)(_r); (void)(_s); } while(0)
+#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) \
+   do { (void)(_p); (void)(_q); (void)(_r); (void)(_s); (void)(_t); } 
while(0)
 
 /* Shared code error reporting */
 enum {
@@ -130,8 +133,8 @@ static inline uint32_t ixgbe_read_addr(volatile void* addr)
IXGBE_PCI_REG_ADDR((hw), (reg) + ((index) << 2))
 
 /* Not implemented !! */
-#define IXGBE_READ_PCIE_WORD(hw, reg) 0
-#define IXGBE_WRITE_PCIE_WORD(hw, reg, value) do { } while(0)
+#define IXGBE_READ_PCIE_WORD(hw, reg)  ((void)hw, (void)(reg), 0)
+#define IXGBE_WRITE_PCIE_WORD(hw, reg, value) do { (void)hw; (void)reg; 
(void)value; } while(0)
 
 #define IXGBE_WRITE_FLUSH(a) IXGBE_READ_REG(a, IXGBE_STATUS)
 
diff --git a/drivers/net/intel/ixgbe/base/meson.build 
b/drivers/net/intel/ixgbe/base/meson.build
index f8b2ee6341..64e0bfd7be 100644
--- a/drivers/net/intel/ixgbe/base/meson.build
+++ b/drivers/net/intel/ixgbe/base/meson.build
@@ -19,17 +19,6 @@ sources = [
 'ixgbe_x550.c',
 ]
 
-error_cflags = [
-'-Wno-unused-but-set-variable',
-'-Wno-unused-parameter',
-]
-c_args = cflags
-foreach flag: error_cflags
-if cc.has_argument(flag)
-c_args += flag
-endif
-endforeach
-
 base_lib = static_library('ixgbe_base', sources,
 dependencies: [static_rte_eal, static_rte_net],
 c_args: c_args)
-- 
2.45.2

[PATCH v3 8/9] net/ice/base: reduce warnings for unused variables

[Bruce Richardson]

Improve base code macros to reduce the number of issues with unused
variables in the code. Issues still remain with unused-but-set
variables, but completely unused variable warnings are eliminated.

Signed-off-by: Bruce Richardson 
---
 drivers/net/intel/ice/base/ice_osdep.h  | 6 +++---
 drivers/net/intel/ice/base/ice_switch.c | 2 --
 drivers/net/intel/ice/base/ice_type.h   | 2 +-
 drivers/net/intel/ice/base/meson.build  | 1 -
 drivers/net/intel/ice/ice_fdir_filter.c | 2 +-
 5 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/net/intel/ice/base/ice_osdep.h 
b/drivers/net/intel/ice/base/ice_osdep.h
index 7b96fcde03..ad6cde9896 100644
--- a/drivers/net/intel/ice/base/ice_osdep.h
+++ b/drivers/net/intel/ice/base/ice_osdep.h
@@ -196,9 +196,9 @@ struct __rte_packed_begin ice_virt_mem {
u32 size;
 } __rte_packed_end;
 
-#define ice_malloc(h, s)rte_zmalloc(NULL, s, 0)
-#define ice_calloc(h, c, s) rte_calloc(NULL, c, s, 0)
-#define ice_free(h, m) rte_free(m)
+#define ice_malloc(h, s)((void)h, rte_zmalloc(NULL, s, 0))
+#define ice_calloc(h, c, s) ((void)h, rte_calloc(NULL, c, s, 0))
+#define ice_free(h, m)  ((void)h, rte_free(m))
 
 #define ice_memset(a, b, c, d) memset((a), (b), (c))
 #define ice_memcpy(a, b, c, d) rte_memcpy((a), (b), (c))
diff --git a/drivers/net/intel/ice/base/ice_switch.c 
b/drivers/net/intel/ice/base/ice_switch.c
index a3786961e6..468a9f055d 100644
--- a/drivers/net/intel/ice/base/ice_switch.c
+++ b/drivers/net/intel/ice/base/ice_switch.c
@@ -8190,7 +8190,6 @@ ice_add_adv_recipe(struct ice_hw *hw, struct 
ice_adv_lkup_elem *lkups,
struct ice_sw_recipe *rm;
u8 i;
int status = ICE_SUCCESS;
-   u16 cnt;
 
if (!ice_is_prof_rule(rinfo->tun_type) && !lkups_cnt)
return ICE_ERR_PARAM;
@@ -9795,7 +9794,6 @@ ice_rem_adv_rule(struct ice_hw *hw, struct 
ice_adv_lkup_elem *lkups,
bool remove_rule = false;
struct ice_lock *rule_lock; /* Lock to protect filter rule list */
u16 i, rid, vsi_handle;
-   bool is_add = false;
int status = ICE_SUCCESS;
 
ice_memset(&lkup_exts, 0, sizeof(lkup_exts), ICE_NONDMA_MEM);
diff --git a/drivers/net/intel/ice/base/ice_type.h 
b/drivers/net/intel/ice/base/ice_type.h
index 35f832eb9f..297a5ea890 100644
--- a/drivers/net/intel/ice/base/ice_type.h
+++ b/drivers/net/intel/ice/base/ice_type.h
@@ -153,7 +153,7 @@ static inline u32 ice_round_to_num(u32 N, u32 R)
 #define ICE_DBG_USER   BIT_ULL(31)
 #define ICE_DBG_ALL0xULL
 
-#define __ALWAYS_UNUSED
+#define __ALWAYS_UNUSED __rte_unused
 
 #define IS_ETHER_ADDR_EQUAL(addr1, addr2) \
(((bool)u16 *)(addr1))[0] == ((u16 *)(addr2))[0]))) && \
diff --git a/drivers/net/intel/ice/base/meson.build 
b/drivers/net/intel/ice/base/meson.build
index 38d092c370..e7ba9c34bc 100644
--- a/drivers/net/intel/ice/base/meson.build
+++ b/drivers/net/intel/ice/base/meson.build
@@ -39,7 +39,6 @@ if is_ms_compiler
 else
 error_cflags = [
 '-Wno-unused-but-set-variable',
-'-Wno-unused-variable',
 '-Wno-unused-parameter',
 ]
 endif
diff --git a/drivers/net/intel/ice/ice_fdir_filter.c 
b/drivers/net/intel/ice/ice_fdir_filter.c
index 940fe171b6..2ff0090aca 100644
--- a/drivers/net/intel/ice/ice_fdir_filter.c
+++ b/drivers/net/intel/ice/ice_fdir_filter.c
@@ -1090,7 +1090,7 @@ ice_fdir_input_set_conf(struct ice_pf *pf, enum 
ice_fltr_ptype flow,
return -EINVAL;
 
seg_tun = (struct ice_flow_seg_info *)
-   ice_malloc(hw, sizeof(*seg_tun) * ICE_FD_HW_SEG_MAX);
+   ice_malloc(pf->adapter->hw, sizeof(*seg_tun) * 
ICE_FD_HW_SEG_MAX);
if (!seg_tun) {
PMD_DRV_LOG(ERR, "No memory can be allocated");
return -ENOMEM;
-- 
2.45.2

[PATCH v3 2/9] net/iavf/base: remove unused meson.build file

[Bruce Richardson]

The meson.build file in the base folder was never used, as the base
files were just included in the main sources list for iavf.

Fixes: f1fdc9ddba5e ("drivers: move iavf common folder to iavf net")

Signed-off-by: Bruce Richardson 
---
 drivers/net/intel/iavf/base/meson.build | 10 --
 1 file changed, 10 deletions(-)
 delete mode 100644 drivers/net/intel/iavf/base/meson.build

diff --git a/drivers/net/intel/iavf/base/meson.build 
b/drivers/net/intel/iavf/base/meson.build
deleted file mode 100644
index 273e88e921..00
--- a/drivers/net/intel/iavf/base/meson.build
+++ /dev/null
@@ -1,10 +0,0 @@
-# SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2019-2021 Intel Corporation
-
-sources = files('iavf_adminq.c', 'iavf_common.c', 'iavf_impl.c')
-
-if cc.has_argument('-Wno-pointer-to-int-cast')
-cflags += '-Wno-pointer-to-int-cast'
-endif
-
-require_iova_in_mbuf = false
-- 
2.45.2

[PATCH v3 0/9] net/intel: clean up base code build

[Bruce Richardson]

Simplify the build of the various intel base code directories, by
clearing compiler warnings so the files can be compiled directly along
with the regular driver files.

v3: add fix for lock checker issues on FreeBSD
v2: added missing patch for fm10k

Bruce Richardson (9):
  net/fm10k/base: fix compilation warnings
  net/iavf/base: remove unused meson.build file
  net/ixgbe/base: correct definition of macro
  net/ixgbe/base: fix compilation warnings
  net/ixgbe/base: fix lock checker errors
  net/i40e/base: fix unused value warnings
  net/i40e/base: fix compiler warnings
  net/ice/base: reduce warnings for unused variables
  net/intel: simplify base code builds

 drivers/net/intel/e1000/base/meson.build|  9 ++-
 drivers/net/intel/e1000/meson.build |  4 +--
 drivers/net/intel/fm10k/base/fm10k_mbx.c|  2 +-
 drivers/net/intel/fm10k/base/fm10k_osdep.h  |  2 +-
 drivers/net/intel/fm10k/base/fm10k_pf.c |  8 +++---
 drivers/net/intel/fm10k/base/fm10k_type.h   |  6 ++---
 drivers/net/intel/fm10k/base/meson.build| 21 ++-
 drivers/net/intel/fm10k/meson.build |  4 +--
 drivers/net/intel/i40e/base/i40e_diag.c |  2 +-
 drivers/net/intel/i40e/base/i40e_nvm.c  |  2 +-
 drivers/net/intel/i40e/base/i40e_osdep.h|  4 +--
 drivers/net/intel/i40e/base/i40e_type.h | 14 ++
 drivers/net/intel/i40e/base/meson.build | 23 ++--
 drivers/net/intel/i40e/i40e_ethdev.c|  1 +
 drivers/net/intel/i40e/meson.build  |  4 +--
 drivers/net/intel/iavf/base/meson.build | 10 ---
 drivers/net/intel/ice/base/ice_osdep.h  |  6 ++---
 drivers/net/intel/ice/base/ice_switch.c |  2 --
 drivers/net/intel/ice/base/ice_type.h   |  2 +-
 drivers/net/intel/ice/base/meson.build  |  1 -
 drivers/net/intel/ice/ice_fdir_filter.c |  2 +-
 drivers/net/intel/idpf/base/meson.build |  2 +-
 drivers/net/intel/idpf/meson.build  |  7 ++---
 drivers/net/intel/ixgbe/base/ixgbe_common.c |  4 +--
 drivers/net/intel/ixgbe/base/ixgbe_e610.c   |  2 ++
 drivers/net/intel/ixgbe/base/ixgbe_osdep.c  | 20 --
 drivers/net/intel/ixgbe/base/ixgbe_osdep.h  | 29 -
 drivers/net/intel/ixgbe/base/meson.build| 20 ++
 drivers/net/intel/ixgbe/meson.build |  4 +--
 29 files changed, 69 insertions(+), 148 deletions(-)
 delete mode 100644 drivers/net/intel/iavf/base/meson.build

--
2.45.2

Re: DPDK for rust

[Bruce Richardson]

On Thu, Mar 27, 2025 at 11:00:40AM +0200, Etelson, Gregory wrote:
> Hello Morten,
> 
> Thank you for raising these questions !
> 
> > 
> > Do we want the DPDK project itself to support rust?
> > Or should parts of this be a DPDK hosted project, like grout?
> 
> Rust packages management is different.
> Also DPDK Rust code will eventually provide a different API.
> At this stage, DPDK hosted project looks like a good idea.
> 

For ease of use, that would mean hosting a cargo registry, no?

Re: [PATCH] mempool: micro optimizations

[Bruce Richardson]

On Wed, Feb 26, 2025 at 03:59:22PM +, Morten Brørup wrote:
> The comparisons lcore_id < RTE_MAX_LCORE and lcore_id != LCORE_ID_ANY are
> equivalent, but the latter compiles to fewer bytes of code space.
> Similarly for lcore_id >= RTE_MAX_LCORE and lcore_id == LCORE_ID_ANY.
> 
> The rte_mempool_get_ops() function is also used in the fast path, so
> RTE_VERIFY() was replaced by RTE_ASSERT().
> 
> Compilers implicitly consider comparisons of variable == 0 likely, so
> unlikely() was added to the check for no mempool cache (mp->cache_size ==
> 0) in the rte_mempool_default_cache() function.
> 
> The rte_mempool_do_generic_put() function for adding objects to a mempool
> was refactored as follows:
> - The comparison for the request itself being too big, which is considered
>   unlikely, was moved down and out of the code path where the cache has
>   sufficient room for the added objects, which is considered the most
>   likely code path.
> - Added __rte_assume() about the cache length, size and threshold, for
>   compiler optimization when "n" is compile time constant.
> - Added __rte_assume() about "ret" being zero, so other functions using
>   the value returned by this function can be potentially optimized by the
>   compiler; especially when it merges multiple sequential code paths of
>   inlined code depending on the return value being either zero or
>   negative.
> - The refactored source code (with comments) made the separate comment
>   describing the cache flush/add algorithm superfluous, so it was removed.
> 
> A few more likely()/unlikely() were added.

In general not a big fan of using likely/unlikely, but if they give a perf
benefit, we should probably take them.

Few more comments inline below.

> A few comments were improved for readability.
> 
> Some assertions, RTE_ASSERT(), were added. Most importantly to assert that
> the return values of the mempool drivers' enqueue and dequeue operations
> are API compliant, i.e. 0 (for success) or negative (for failure), and
> never positive.
> 
> Signed-off-by: Morten Brørup 

Acked-by: Bruce Richardson 

> ---
>  lib/mempool/rte_mempool.h | 67 ++-
>  1 file changed, 38 insertions(+), 29 deletions(-)
> 
> diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h
> index c495cc012f..aedc100964 100644
> --- a/lib/mempool/rte_mempool.h
> +++ b/lib/mempool/rte_mempool.h
> @@ -334,7 +334,7 @@ struct __rte_cache_aligned rte_mempool {
>  #ifdef RTE_LIBRTE_MEMPOOL_STATS
>  #define RTE_MEMPOOL_STAT_ADD(mp, name, n) do {   
>\
>   unsigned int __lcore_id = rte_lcore_id();   
> \
> - if (likely(__lcore_id < RTE_MAX_LCORE)) 
> \
> + if (likely(__lcore_id != LCORE_ID_ANY)) 
> \

Is this not opening up the possibility of runtime crashes, if __lcore_id is
invalid? I see from the commit log, you say the change in comparison
results in smaller code gen, but it does leave undefined behaviour when
__lcore_id == 500, for example.

>   (mp)->stats[__lcore_id].name += (n);
> \
>   else
> \
>   
> rte_atomic_fetch_add_explicit(&((mp)->stats[RTE_MAX_LCORE].name),  \
> @@ -751,7 +751,7 @@ extern struct rte_mempool_ops_table rte_mempool_ops_table;
>  static inline struct rte_mempool_ops *
>  rte_mempool_get_ops(int ops_index)
>  {
> - RTE_VERIFY((ops_index >= 0) && (ops_index < RTE_MEMPOOL_MAX_OPS_IDX));
> + RTE_ASSERT((ops_index >= 0) && (ops_index < RTE_MEMPOOL_MAX_OPS_IDX));
>  
>   return &rte_mempool_ops_table.ops[ops_index];
>  }
> @@ -791,7 +791,8 @@ rte_mempool_ops_dequeue_bulk(struct rte_mempool *mp,
>   rte_mempool_trace_ops_dequeue_bulk(mp, obj_table, n);
>   ops = rte_mempool_get_ops(mp->ops_index);
>   ret = ops->dequeue(mp, obj_table, n);
> - if (ret == 0) {
> + RTE_ASSERT(ret <= 0);
> + if (likely(ret == 0)) {
>   RTE_MEMPOOL_STAT_ADD(mp, get_common_pool_bulk, 1);
>   RTE_MEMPOOL_STAT_ADD(mp, get_common_pool_objs, n);
>   }
> @@ -816,11 +817,14 @@ rte_mempool_ops_dequeue_contig_blocks(struct 
> rte_mempool *mp,
>   void **first_obj_table, unsigned int n)
>  {
>   struct rte_mempool_ops *ops;
> + int ret;
>  
>   ops = rte_mempool_get_ops(mp->ops_index);
>   RTE_ASSERT(ops->dequeue_contig_blocks != NULL);
>   rte_mempool_trace_ops_dequeue_contig_blocks(mp, first_obj_table, n);
> - return ops->dequeue_contig_blocks(mp, first_obj_table, n);
> + ret = ops->dequeue_contig_blocks(mp, first_obj_table, n);
> + RTE_ASSERT(ret <= 0);
> + return ret;
>  }
>  
>  /**
> @@ -848,6 +852,7 @@ rte_mempool_ops_enqueue_bulk(struct rte_mempool *mp, void 
> * const *obj_table,
>   rte_mempool_trace_ops_enqueue_bulk(mp, obj_table, n);
>   ops = rte_mempool_g

Re: [PATCH v16 00/28] [v16]drivers/net Add Support mucse N10 Pmd Driver

[Stephen Hemminger]

On Wed, 26 Feb 2025 15:41:47 +0800
Wenbo Cao  wrote:

> For This patchset just to support the basic chip init work
> and user can just found the eth_dev, but can't control more.
> For Now just support 2*10g nic,the chip can support
> 2*10g,4*10g,4*1g,8*1g,8*10g.
> The Feature rx side can support rx-cksum-offload,rss,vlan-filter
> flow_clow,uncast_filter,mcast_filter,1588,Jumbo-frame
> The Feature tx side can support tx-cksum-offload,tso,vxlan-tso 
> flow director base on ntuple pattern of tcp/udp/ip/ eth_hdr->type
> for sriov is also support.
> 
> Because of the chip design defect, for multiple-port mode
> one pci-bdf will have multiple-port (max can have four ports)
> so this code must be care of one bdf init multiple-port.
> 
> v16
>   * fixed rxq/txq stop/start not add to eth_ops as rnp doc descript.
> 
> v15:
>   * fixed scatter recv for jumbo frame test by dts mtu.
> 
> v14:
>   * add multicast mac filter feature for basic nic feature.
>   * fixed pvs studio low,media,high level warning as the below cmd
> pvs-studio-analyzer analyze -f build/compile_commands.json -j 8
> plog-converter -a GA:1,2,3 -t fullhtml PVS-Studio.log -o /root/report
> 
> v13:
>   * Supplementary document about n10 network card characteristics.
>   * update release_25_03.rst.
>   * fixed the code style advisea Stephen Hemminger.
>   * fixed the code issue check PVS-stdio for Static compilation error.
> 
> v12:
>   * fixed __rte_packed __deprecated__ compile issue.
> 
> v11:
>   * fixed array-bounds issue when used rte_memcpy src addr is
>   * not enough to hold align dst.
>   * improve efficient_code advised by Stephen
> 
> v10:
>   * fixed mingw windows meson issue
>   * rnp not support windows for now.
> 
> v9:
>   * fixed commit log format check by devtools.
>   * fixed code compile issue.
> 
> v8:
>   * fixed codespell issue.
>   * fixed MAINTAINERS file
> 
> v7:
>   * add support nic basic feature such as rss vlan strip/filter,
>   * mtu-change recv/send scater-recv/mutltiple-send.
>   * fixed code rationality, advised by Ferruh Yigit.
> v6:
>   * fixed the doc(rst) format problem advise by Thomas Monjalon
> 
> v5:
>   * fixed the symbol name require by the style documentation
> 
> v4:
>   * one patch has been forgot to upload :(
> 
> v3:
>   * fixed http://dpdk.org/patch/129830 FreeBSD 13 compile Issue
>   * change iobar type to void suggest by Stephen Hemminger
>   * add KMOD_DEP support for vfio-pci
>   * change run-cmd argument parse check for invalid extra_args
> 
> v2:
>   * fixed MAINTAIN maillist fullname format
>   * fixed driver/net/meson the order issue of new driver to driver list
>   * improve virtual point function usage suggest by Stephen Hemminger
> 
> Wenbo Cao (29):
>   net/rnp: add skeleton
>   net/rnp: add ethdev probe and remove
>   net/rnp: add log
>   net/rnp: support mailbox basic operate
>   net/rnp: add device init and uninit
>   net/rnp: add get device information operation
>   net/rnp: add support MAC promisc mode
>   net/rnp: add queue setup and release operations
>   net/rnp: add queue stop and start operations
>   net/rnp: add support device start stop operations
>   net/rnp: add RSS support operations
>   net/rnp: add support link update operations
>   net/rnp: add support link setup operations
>   net/rnp: add Rx burst simple support
>   net/rnp: add Tx burst simple support
>   net/rnp: add MTU set operation
>   net/rnp: add Rx scatter segment version
>   net/rnp: add Tx multiple segment version
>   net/rnp: add support basic stats operation
>   net/rnp: add support xstats operation
>   net/rnp: add unicast MAC filter operation
>   net/rnp: add supported packet types
>   net/rnp: add support Rx checksum offload
>   net/rnp: add support Tx TSO offload
>   net/rnp: support VLAN offloads
>   net/rnp: add support VLAN filters operations
>   net/rnp: add queue info operation
>   net/rnp: support Rx/Tx burst mode info
>   net/rnp: add multicast MAC filter operation
> 
>  .mailmap   |1 +
>  MAINTAINERS|6 +
>  doc/guides/nics/features/rnp.ini   |   34 +
>  doc/guides/nics/img/mucse_nic_port.svg | 4023 
>  doc/guides/nics/index.rst  |1 +
>  doc/guides/nics/rnp.rst|  130 +
>  doc/guides/rel_notes/release_25_03.rst |5 +
>  drivers/net/meson.build|1 +
>  drivers/net/rnp/base/meson.build   |   18 +
>  drivers/net/rnp/base/rnp_bdq_if.c  |  398 +++
>  drivers/net/rnp/base/rnp_bdq_if.h  |  154 +
>  drivers/net/rnp/base/rnp_bitrev.h  |   64 +
>  drivers/net/rnp/base/rnp_common.c  |  103 +
>  drivers/net/rnp/base/rnp_common.h  |   17 +
>  drivers/net/rnp/base/rnp_crc32.c   |   53 +
>  drivers/net/rnp/base/rnp_crc32.h   |   11 +
>  drivers/net/rnp/base/rnp_dma_regs.h|   68 +
>  drivers/net/rnp/base/rnp_eth_regs.h|   94 +
>  drivers/net/rnp/base/rnp_fw_cmd.c  |  162 +
>  drivers/net/rnp/base/rnp_fw_cmd.h  |  357

Re: [PATCH] event/dlb2: consolidate AVX512 and SSE changes

[Bruce Richardson]

On Thu, Mar 27, 2025 at 04:53:27AM -0500, tirthendu.sarkar wrote:
> Streamline code for AVX512 and SSE by removing separate files for them
> and adding runtime checks for selecting appropriate paths based on CPU
> capability. Also, update meson build file.
> 
> Signed-off-by: Tirthendu Sarkar 
> ---
>  drivers/event/dlb2/dlb2.c| 248 +++
>  drivers/event/dlb2/dlb2_avx512.c | 276 ---
>  drivers/event/dlb2/dlb2_priv.h   |   6 -
>  drivers/event/dlb2/dlb2_sse.c| 232 --
>  drivers/event/dlb2/meson.build   |   3 -
>  5 files changed, 248 insertions(+), 517 deletions(-)
>  delete mode 100644 drivers/event/dlb2/dlb2_avx512.c
>  delete mode 100644 drivers/event/dlb2/dlb2_sse.c
> 
> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> index 934fcafcfe..ac0eb3fb24 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c
> @@ -2669,6 +2669,21 @@ dlb2_eventdev_start(struct rte_eventdev *dev)
>   return 0;
>  }
>  



> +  */
> +#define DLB2_QE_EV_TYPE_WORD 0
> + sse_qe[0] = _mm_insert_epi16(sse_qe[0],
> +  ev[0].sub_event_type << 4 |
> + ev[0].event_type << 12,
> +  DLB2_QE_EV_TYPE_WORD);
> + sse_qe[0] = _mm_insert_epi16(sse_qe[0],
> +  ev[1].sub_event_type << 4 |
> + ev[1].event_type << 12,
> +  DLB2_QE_EV_TYPE_WORD + 4);
> + sse_qe[1] = _mm_insert_epi16(sse_qe[1],
> +  ev[2].sub_event_type << 4 |
> + ev[2].event_type << 12,
> +  DLB2_QE_EV_TYPE_WORD);
> + sse_qe[1] = _mm_insert_epi16(sse_qe[1],
> +  ev[3].sub_event_type << 4 |
> + ev[3].event_type << 12,
> +  DLB2_QE_EV_TYPE_WORD + 4);
> +#ifdef __AVX512VL__
> + if (qm_port->use_avx512) {
> + /*

Hi Tirthendu,

This runtime detection is not really correct, and not fully completely,
for a number of reasons:

* if doing a "default" or generic build, __AVX512VL__ flag will not be
  defined at build time, unless you explicitly add the AVX512 flags.
  Therefore, unlike other drivers, we won't have a generic build that can
  opportunistically use accelerated code paths at runtime.
* On the flip side, if we do have a build with AVX512 enabled, then AVX
  code can (and possibly will) be used by the compiler anywhere in the
  output code. Therefore, the "SSE" code paths outside this ifdefs may well
  be converted to the compiler into AVX equivalents, and as such may not run
  on a non-AVX capable machine.

To have proper runtime support, you need to build both SSE and AVX512 paths
separately with different compiler flags, and then do a runtime check to
choose between them, using a function pointer or similar.

Regards,
/Bruce

RE: [PATCH] mempool: micro optimizations

[Morten Brørup]

> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Thursday, 27 March 2025 18.16
> 
> On Wed, Feb 26, 2025 at 03:59:22PM +, Morten Brørup wrote:
> > The comparisons lcore_id < RTE_MAX_LCORE and lcore_id != LCORE_ID_ANY
> are
> > equivalent, but the latter compiles to fewer bytes of code space.
> > Similarly for lcore_id >= RTE_MAX_LCORE and lcore_id == LCORE_ID_ANY.
> >
> > The rte_mempool_get_ops() function is also used in the fast path, so
> > RTE_VERIFY() was replaced by RTE_ASSERT().
> >
> > Compilers implicitly consider comparisons of variable == 0 likely, so
> > unlikely() was added to the check for no mempool cache (mp-
> >cache_size ==
> > 0) in the rte_mempool_default_cache() function.
> >
> > The rte_mempool_do_generic_put() function for adding objects to a
> mempool
> > was refactored as follows:
> > - The comparison for the request itself being too big, which is
> considered
> >   unlikely, was moved down and out of the code path where the cache
> has
> >   sufficient room for the added objects, which is considered the most
> >   likely code path.
> > - Added __rte_assume() about the cache length, size and threshold,
> for
> >   compiler optimization when "n" is compile time constant.
> > - Added __rte_assume() about "ret" being zero, so other functions
> using
> >   the value returned by this function can be potentially optimized by
> the
> >   compiler; especially when it merges multiple sequential code paths
> of
> >   inlined code depending on the return value being either zero or
> >   negative.
> > - The refactored source code (with comments) made the separate
> comment
> >   describing the cache flush/add algorithm superfluous, so it was
> removed.
> >
> > A few more likely()/unlikely() were added.
> 
> In general not a big fan of using likely/unlikely, but if they give a
> perf
> benefit, we should probably take them.

They can also be a hint to the code reviewer.

The benefit varies depending on the architecture's dynamic branch predictor. 
Some architectures don't consume a branch predictor entry if the code follows 
the expected path (according to static branch prediction); but I don't know if 
this is the case for architectures supported by DPDK, or ancient architectures 
only.

I like them enough to probably some day provide an EAL patch offering 
superlikely() and superunlikely() based on __builtin_expect_with_probability().
I have seen compilers emit different assembly output when using superlikely() 
vs. likely().
Moving away the super-unlikely code from the cache lines holding the common 
code path reduces the L1 instruction cache pressure.

In other words: Not even a perfect dynamic branch predictor can substitute all 
the benefits from using likely()/unlikely().

> 
> Few more comments inline below.
> 
> > A few comments were improved for readability.
> >
> > Some assertions, RTE_ASSERT(), were added. Most importantly to assert
> that
> > the return values of the mempool drivers' enqueue and dequeue
> operations
> > are API compliant, i.e. 0 (for success) or negative (for failure),
> and
> > never positive.
> >
> > Signed-off-by: Morten Brørup 
> 
> Acked-by: Bruce Richardson 
> 
> > ---
> >  lib/mempool/rte_mempool.h | 67 ++---
> --
> >  1 file changed, 38 insertions(+), 29 deletions(-)
> >
> > diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h
> > index c495cc012f..aedc100964 100644
> > --- a/lib/mempool/rte_mempool.h
> > +++ b/lib/mempool/rte_mempool.h
> > @@ -334,7 +334,7 @@ struct __rte_cache_aligned rte_mempool {
> >  #ifdef RTE_LIBRTE_MEMPOOL_STATS
> >  #define RTE_MEMPOOL_STAT_ADD(mp, name, n) do {
> \
> > unsigned int __lcore_id = rte_lcore_id();
> \
> > -   if (likely(__lcore_id < RTE_MAX_LCORE))
> \
> > +   if (likely(__lcore_id != LCORE_ID_ANY))
> \
> 
> Is this not opening up the possibility of runtime crashes, if
> __lcore_id is
> invalid? I see from the commit log, you say the change in comparison
> results in smaller code gen, but it does leave undefined behaviour when
> __lcore_id == 500, for example.

In this case, __lcore_id comes from rte_lcore_id(), and if that is invalid, 
everything breaks everywhere.

> 
> > (mp)->stats[__lcore_id].name += (n);
> \
> > else
> \
> > rte_atomic_fetch_add_explicit(&((mp)-
> >stats[RTE_MAX_LCORE].name),  \
> > @@ -751,7 +751,7 @@ extern struct rte_mempool_ops_table
> rte_mempool_ops_table;
> >  static inline struct rte_mempool_ops *
> >  rte_mempool_get_ops(int ops_index)
> >  {
> > -   RTE_VERIFY((ops_index >= 0) && (ops_index <
> RTE_MEMPOOL_MAX_OPS_IDX));
> > +   RTE_ASSERT((ops_index >= 0) && (ops_index <
> RTE_MEMPOOL_MAX_OPS_IDX));
> >
> > return &rte_mempool_ops_table.ops[ops_index];
> >  }
> > @@ -791,7 +791,8 @@ rte_mempool_ops_dequeue_bulk(struct rte_mempool
> *mp,
> > rte_mempool_trace_ops_dequeue_bulk(mp, obj_table, n);
> > ops = rte_mempool_get_ops(mp

[PATCH v17 29/29] net/rnp: add multicast MAC filter operation

[Wenbo Cao]

add mac filter for single/multiple port.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|   1 +
 doc/guides/nics/rnp.rst |   1 +
 drivers/net/rnp/base/rnp_crc32.c|  18 -
 drivers/net/rnp/base/rnp_crc32.h|   1 +
 drivers/net/rnp/base/rnp_eth_regs.h |   3 +
 drivers/net/rnp/base/rnp_hw.h   |   4 +
 drivers/net/rnp/base/rnp_mac.c  | 121 +++-
 drivers/net/rnp/base/rnp_mac.h  |   2 +
 drivers/net/rnp/base/rnp_mac_regs.h |   2 +
 drivers/net/rnp/rnp.h   |   4 +
 drivers/net/rnp/rnp_ethdev.c|  26 ++
 11 files changed, 181 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 48d250c86b..801a8de711 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -20,6 +20,7 @@ Promiscuous mode = Y
 Allmulticast mode= Y
 MTU update   = Y
 Unicast MAC filter   = Y
+Multicast MAC filter = Y
 VLAN filter  = Y
 VLAN offload = Y
 QinQ offload = P
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index f0afea9cd4..7b5cfed97b 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -94,6 +94,7 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_dev_default_mac_addr_set``
 * ``rte_eth_dev_mac_addr_add``
 * ``rte_eth_dev_mac_addr_remove``
+* ``rte_eth_dev_set_mc_addr_list``
 * ``rte_eth_dev_get_supported_ptypes``
 * ``rte_eth_dev_get_vlan_offload``
 * ``rte_eth_dev_set_vlan_offload``
diff --git a/drivers/net/rnp/base/rnp_crc32.c b/drivers/net/rnp/base/rnp_crc32.c
index c287b35759..9d03754a4b 100644
--- a/drivers/net/rnp/base/rnp_crc32.c
+++ b/drivers/net/rnp/base/rnp_crc32.c
@@ -5,6 +5,7 @@
 #include "rnp_osdep.h"
 #include "rnp_crc32.h"
 
+#define RNP_CRC32_POLY_LE 0xedb88320
 static inline int get_bitmask_order(u32 count)
 {
int order;
@@ -30,7 +31,22 @@ u32 rnp_vid_crc32_calc(u32 crc_init, u16 vid_le)
crc >>= 1;
data_byte >>= 1;
if (temp)
-   crc ^= 0xedb88320;
+   crc ^= RNP_CRC32_POLY_LE;
+   }
+
+   return crc;
+}
+
+u32 rnp_calc_crc32(u32 seed, u8 *mac, u32 len)
+{
+   u32 crc = seed;
+   u32 i;
+
+   while (len--) {
+   crc ^= *mac++;
+   for (i = 0; i < 8; i++)
+   crc = (crc >> 1) ^ ((crc & 1) ?
+   RNP_CRC32_POLY_LE : 0);
}
 
return crc;
diff --git a/drivers/net/rnp/base/rnp_crc32.h b/drivers/net/rnp/base/rnp_crc32.h
index e117dcfc2f..dc3026ddf8 100644
--- a/drivers/net/rnp/base/rnp_crc32.h
+++ b/drivers/net/rnp/base/rnp_crc32.h
@@ -6,5 +6,6 @@
 #define _RNP_CRC32_H_
 
 u32 rnp_vid_crc32_calc(u32 crc_init, u16 vid_le);
+u32 rnp_calc_crc32(u32 seed, u8 *mac, u32 len);
 
 #endif /* _RNP_CRC32_H_ */
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index 5c3f7f906c..1378328add 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -57,6 +57,8 @@
 #define RNP_MAC_HASH_MASK  RTE_GENMASK32(11, 0)
 #define RNP_MAC_MULTICASE_TBL_EN   RTE_BIT32(2)
 #define RNP_MAC_UNICASE_TBL_EN RTE_BIT32(3)
+#define RNP_HTA_BIT_SHIFT  (5)
+#define RNP_HTA_BIT_MASK   ((1 << RNP_HTA_BIT_SHIFT) - 1)
 /* vlan strip ctrl */
 #define RNP_VLAN_Q_STRIP_CTRL(n)   _ETH_(0x8040 + 0x4 * ((n) / 32))
 /* vlan filter ctrl */
@@ -87,5 +89,6 @@
 #define RNP_RAL_BASE_ADDR(n)   _ETH_(0xA000 + (0x04 * (n)))
 #define RNP_RAH_BASE_ADDR(n)   _ETH_(0xA400 + (0x04 * (n)))
 #define RNP_MAC_FILTER_EN  RTE_BIT32(31)
+#define RNP_MC_HASH_TABLE(n)   _ETH_(0xAC00 + ((0x04) * ((n
 
 #endif /* _RNP_ETH_REGS_H */
diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index 8cf57db185..8dc29b6873 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -74,6 +74,10 @@ struct rnp_mac_ops {
/* Receive Address Filter table */
int (*set_rafb)(struct rnp_eth_port *port, const u8 *mac, u32 index);
int (*clear_rafb)(struct rnp_eth_port *port, u32 index);
+   /* update multicast address table */
+   int (*update_mta)(struct rnp_eth_port *port, u8 *mc_addr);
+   /* clear all multicast hash table */
+   int (*clear_mta)(struct rnp_eth_port *port, bool en);
/* receive vlan filter */
int (*vlan_f_en)(struct rnp_eth_port *port, bool en);
int (*update_vlan)(struct rnp_eth_port *port, u16 vid, bool en);
diff --git a/drivers/net/rnp/base/rnp_mac.c b/drivers/net/rnp/base/rnp_mac.c
index b723c29ac5..96750e1cde 100644
--- a/drivers/net/rnp/base/rnp_mac.c
+++ b/drivers/net/rnp/base/rnp_mac.c
@@ -46,7 +46,7 @@ rnp_update_mpfm_indep(struct rnp_eth_port *port, u32 mode, 
bool en)
reg |= disable;
}
/* disable common filter when indep mode */
- 

[PATCH v17 10/29] net/rnp: add support device start stop operations

[Wenbo Cao]

add basic support for device to start/stop function.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/rnp.rst |   2 +
 drivers/net/rnp/base/rnp_common.c   |  22 +++
 drivers/net/rnp/base/rnp_common.h   |   1 +
 drivers/net/rnp/base/rnp_dma_regs.h |  10 +
 drivers/net/rnp/base/rnp_eth_regs.h |   5 +
 drivers/net/rnp/base/rnp_hw.h   |   1 +
 drivers/net/rnp/base/rnp_mac.h  |  14 ++
 drivers/net/rnp/base/rnp_mac_regs.h |  42 
 drivers/net/rnp/rnp.h   |   3 +
 drivers/net/rnp/rnp_ethdev.c| 284 +++-
 10 files changed, 383 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 7b3462c64b..0ab9bba20b 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -68,6 +68,8 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_dev_rx_queue_stop``
 * ``rte_eth_dev_tx_queue_start``
 * ``rte_eth_dev_tx_queue_stop``
+* ``rte_eth_dev_start``
+* ``rte_eth_dev_stop``
 * ``rte_eth_promiscuous_disable``
 * ``rte_eth_promiscuous_enable``
 * ``rte_eth_allmulticast_enable``
diff --git a/drivers/net/rnp/base/rnp_common.c 
b/drivers/net/rnp/base/rnp_common.c
index 58de3bde03..2dacb5113e 100644
--- a/drivers/net/rnp/base/rnp_common.c
+++ b/drivers/net/rnp/base/rnp_common.c
@@ -79,3 +79,25 @@ rnp_setup_common_ops(struct rnp_hw *hw)
 
return 0;
 }
+
+int rnp_clock_valid_check(struct rnp_hw *hw, u16 nr_lane)
+{
+   uint16_t timeout = 0;
+
+   do {
+   RNP_E_REG_WR(hw, RNP_RSS_REDIR_TB(nr_lane, 0), 0x7f);
+   udelay(10);
+   timeout++;
+   if (timeout >= 1000)
+   break;
+   } while (RNP_E_REG_RD(hw, RNP_RSS_REDIR_TB(nr_lane, 0)) != 0x7f);
+
+   if (timeout >= 1000) {
+   RNP_PMD_ERR("ethernet[%d] eth reg can't be write", nr_lane);
+   return -EPERM;
+   }
+   /* clear the dirty value */
+   RNP_E_REG_WR(hw, RNP_RSS_REDIR_TB(nr_lane, 0), 0);
+
+   return 0;
+}
diff --git a/drivers/net/rnp/base/rnp_common.h 
b/drivers/net/rnp/base/rnp_common.h
index cf1996a675..91e2996398 100644
--- a/drivers/net/rnp/base/rnp_common.h
+++ b/drivers/net/rnp/base/rnp_common.h
@@ -12,5 +12,6 @@
 ((macaddr[4] << 8)) | (macaddr[5]))
 int rnp_init_hw(struct rnp_hw *hw);
 int rnp_setup_common_ops(struct rnp_hw *hw);
+int rnp_clock_valid_check(struct rnp_hw *hw, u16 nr_lane);
 
 #endif /* _RNP_COMMON_H_ */
diff --git a/drivers/net/rnp/base/rnp_dma_regs.h 
b/drivers/net/rnp/base/rnp_dma_regs.h
index 7c17741c55..8bc6fe581a 100644
--- a/drivers/net/rnp/base/rnp_dma_regs.h
+++ b/drivers/net/rnp/base/rnp_dma_regs.h
@@ -6,9 +6,19 @@
 #define _RNP_DMA_REGS_H_
 
 #define RNP_DMA_VERSION(0)
+#define RNP_DMA_CTRL   (0x4)
+/* 1bit <-> 16 bytes dma addr size */
+#define RNP_DMA_SCATTER_MEM_MASK   RTE_GENMASK32(31, 16)
+#define RNP_DMA_SCATTER_MEN_S  (16)
+#define RNP_DMA_RX_MEM_PAD_EN  RTE_BIT32(8)
+#define RTE_DMA_VEB_BYPASS RTE_BIT32(4)
+#define RNP_DMA_TXRX_LOOP  RTE_BIT32(1)
+#define RNP_DMA_TXMRX_LOOP RTE_BIT32(0)
+
 #define RNP_DMA_HW_EN  (0x10)
 #define RNP_DMA_EN_ALL (0b)
 #define RNP_DMA_HW_STATE   (0x14)
+
 /* --- queue register --- */
 /* queue enable */
 #define RNP_RXQ_START(qid) _RING_(0x0010 + 0x100 * (qid))
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index 10e3d954b8..60766d2035 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -10,6 +10,9 @@
 #define RNP_E_FILTER_EN_ETH_(0x801c)
 #define RNP_E_REDIR_EN _ETH_(0x8030)
 
+#define RNP_RX_ETH_F_CTRL(n)   _ETH_(0x8070 + ((n) * 0x8))
+#define RNP_RX_ETH_F_OFF   (0x7ff)
+#define RNP_RX_ETH_F_ON(0x270)
 /* rx queue flow ctrl */
 #define RNP_RX_FC_ENABLE   _ETH_(0x8520)
 #define RNP_RING_FC_EN(n)  _ETH_(0x8524 + ((0x4) * ((n) / 32)))
@@ -28,6 +31,8 @@
 #define RNP_MAC_HASH_MASK  RTE_GENMASK32(11, 0)
 #define RNP_MAC_MULTICASE_TBL_EN   RTE_BIT32(2)
 #define RNP_MAC_UNICASE_TBL_EN RTE_BIT32(3)
+/* rss function ctrl */
+#define RNP_RSS_REDIR_TB(n, id) _ETH_(0xe000 + ((n) * 0x200) + ((id) * 0x4))
 
 #define RNP_TC_PORT_OFFSET(lane)   _ETH_(0xe840 + 0x04 * (lane))
 
diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index 9541b4e9be..548e3a4468 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -120,6 +120,7 @@ struct rnp_hw {
bool lane_is_sgmii[RNP_MAX_PORT_OF_PF];
struct rnp_mbx_info mbx;
struct rnp_fw_info fw_info;
+   u16 min_dma_size;
 
spinlock_t rxq_reset_lock; /* reset op isn't thread safe */
spinlock_t txq_reset_lock; /* reset op isn't thread safe */
diff --git a/drivers/net/rnp/base/rnp_mac.h b/drivers/net/rnp/base/rnp_mac.h
index 57cbd9e3d5..1dac903396 100644
--- a/drivers/

[PATCH v17 20/29] net/rnp: add support xstats operation

[Wenbo Cao]

add support mac eth rx tx hw xstats.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|   1 +
 doc/guides/nics/rnp.rst |   3 +
 drivers/net/rnp/base/rnp_eth_regs.h |   4 +
 drivers/net/rnp/base/rnp_mac_regs.h |  80 ++
 drivers/net/rnp/rnp.h   |  44 ++
 drivers/net/rnp/rnp_ethdev.c| 226 +++-
 6 files changed, 353 insertions(+), 5 deletions(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 07caedba7a..14ff88fec1 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -9,6 +9,7 @@ Link status  = Y
 Link status event= Y
 Basic stats  = Y
 Stats per queue  = Y
+Extended stats   = Y
 Queue start/stop = Y
 Promiscuous mode = Y
 Allmulticast mode= Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 73686f5882..e1e6b6d843 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -98,3 +98,6 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_link_get_nowait``
 * ``rte_eth_stats_get``
 * ``rte_eth_stats_reset``
+* ``rte_eth_xstats_get``
+* ``rte_eth_xstats_reset``
+* ``rte_eth_xstats_get_names``
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index 391688bd80..adac817df2 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -25,6 +25,10 @@
 #define RNP_RING_FC_THRESH(n)  _ETH_(0x8a00 + ((0x4) * (n)))
 /* ETH Statistic */
 #define RNP_ETH_RXTRANS_DROP   _ETH_(0x8904)
+#define RNP_ETH_RXSLAN_DROP_ETH_(0x8914)
+#define RNP_ETH_RXGLAN_DROP_ETH_(0x8918)
+#define RNP_ETH_RXIPH_E_DROP   _ETH_(0x891c)
+#define RNP_ETH_RXCKSUM_E_DROP _ETH_(0x8920)
 #define RNP_ETH_RXTRUNC_DROP   _ETH_(0x8928)
 /* Mac Host Filter  */
 #define RNP_MAC_FCTRL  _ETH_(0x9110)
diff --git a/drivers/net/rnp/base/rnp_mac_regs.h 
b/drivers/net/rnp/base/rnp_mac_regs.h
index 1ae880143d..4fd907a601 100644
--- a/drivers/net/rnp/base/rnp_mac_regs.h
+++ b/drivers/net/rnp/base/rnp_mac_regs.h
@@ -78,4 +78,84 @@
 /* PHY Link Status */
 #define RNP_MAC_PLSRTE_BIT32(17)
 
+/* Mac Manage Counts */
+#define RNP_MMC_CTRL   (0x0800)
+#define RNP_MMC_RSTONRDRTE_BIT32(2)
+/* Tx Good And Bad Bytes Base */
+#define RNP_MMC_TX_GBOCTGB (0x0814)
+/* Tx Good And Bad Frame Num Base */
+#define RNP_MMC_TX_GBFRMB  (0x081c)
+/* Tx Good Broadcast Frame Num Base */
+#define RNP_MMC_TX_BCASTB  (0x0824)
+/* Tx Good Multicast Frame Num Base */
+#define RNP_MMC_TX_MCASTB  (0x082c)
+/* Tx 64Bytes Frame Num */
+#define RNP_MMC_TX_64_BYTESB   (0x0834)
+#define RNP_MMC_TX_65TO127_BYTESB  (0x083c)
+#define RNP_MMC_TX_128TO255_BYTEB  (0x0844)
+#define RNP_MMC_TX_256TO511_BYTEB  (0x084c)
+#define RNP_MMC_TX_512TO1023_BYTEB (0x0854)
+#define RNP_MMC_TX_1024TOMAX_BYTEB (0x085c)
+/* Tx Good And Bad Unicast Frame Num Base */
+#define RNP_MMC_TX_GBUCASTB(0x0864)
+/* Tx Good And Bad Multicast Frame Num Base */
+#define RNP_MMC_TX_GBMCASTB(0x086c)
+/* Tx Good And Bad Broadcast Frame NUM Base */
+#define RNP_MMC_TX_GBBCASTB(0x0874)
+/* Tx Frame Underflow Error */
+#define RNP_MMC_TX_UNDRFLWB(0x087c)
+/* Tx Good Frame Bytes Base */
+#define RNP_MMC_TX_GBYTESB (0x0884)
+/* Tx Good Frame Num Base*/
+#define RNP_MMC_TX_GBRMB   (0x088c)
+/* Tx Good Pause Frame Num Base */
+#define RNP_MMC_TX_PAUSEB  (0x0894)
+/* Tx Good Vlan Frame Num Base */
+#define RNP_MMC_TX_VLANB   (0x089c)
+
+/* Rx Good And Bad Frames Num Base */
+#define RNP_MMC_RX_GBFRMB  (0x0900)
+/* Rx Good And Bad Frames Bytes Base */
+#define RNP_MMC_RX_GBOCTGB (0x0908)
+/* Rx Good Framse Bytes Base */
+#define RNP_MMC_RX_GOCTGB  (0x0910)
+/* Rx Good Broadcast Frames Num Base */
+#define RNP_MMC_RX_BCASTGB (0x0918)
+/* Rx Good Multicast Frames Num Base */
+#define RNP_MMC_RX_MCASTGB (0x0920)
+/* Rx Crc Error Frames Num Base */
+#define RNP_MMC_RX_CRCERB  (0x0928)
+/* Rx Less Than 64Byes with Crc Err Base*/
+#define RNP_MMC_RX_RUNTERB (0x0930)
+/* Receive Jumbo Frame Error */
+#define RNP_MMC_RX_JABBER_ERR  (0x0934)
+/* Shorter Than 64Bytes without Any Errora Base */
+#define RNP_MMC_RX_USIZEGB (0x0938)
+/* Len Oversize 9k */
+#define RNP_MMC_RX_OSIZEGB (0x093c)
+/* Rx 64Byes Frame Num Base */
+#define RNP_MMC_RX_64_BYTESB   (0x0940)
+/* Rx 65Bytes To 127Bytes Frame Num Base */
+#define RNP_MMC_RX_65TO127_BYTESB  (0x0948)
+/* Rx 128Bytes To 255Bytes Frame Num Base */
+#define RNP_MMC_RX_128TO255_BYTESB (0x0950)
+/* Rx 256Bytes To 511Bytes Frame Num Base */
+#define RNP_MMC_RX_256TO511_BYTESB (0x0958)
+/* Rx 512Bytes To 1023Bytes Frame Num Base */
+#define RNP_MMC_RX_512TO1203_BYTESB(0x0960)
+/* Rx Len Bigger Than 1

[PATCH v17 13/29] net/rnp: add support link setup operations

[Wenbo Cao]

add set link_down/link_up implement

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/rnp.rst |  2 +
 drivers/net/rnp/base/rnp_eth_regs.h |  3 +
 drivers/net/rnp/base/rnp_fw_cmd.c   | 22 +++
 drivers/net/rnp/base/rnp_fw_cmd.h   |  6 ++
 drivers/net/rnp/base/rnp_mbx_fw.c   | 33 ++
 drivers/net/rnp/base/rnp_mbx_fw.h   |  1 +
 drivers/net/rnp/rnp_ethdev.c| 10 ++-
 drivers/net/rnp/rnp_link.c  | 97 +
 drivers/net/rnp/rnp_link.h  |  2 +
 9 files changed, 175 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 4d4f3ebffe..8677b6c775 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -78,6 +78,8 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_dev_rss_hash_update``
 * ``rte_eth_dev_rss_reta_query``
 * ``rte_eth_dev_rss_reta_update``
+* ``rte_eth_dev_set_link_down``
+* ``rte_eth_dev_set_link_up``
 * ``rte_eth_promiscuous_disable``
 * ``rte_eth_promiscuous_enable``
 * ``rte_eth_allmulticast_enable``
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index be7ed5b886..c74886e70c 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -5,6 +5,9 @@
 #ifndef _RNP_ETH_REGS_H
 #define _RNP_ETH_REGS_H
 
+#define RNP_ETH_TX_FIFO_STATE  _ETH_(0x0330)
+#define RNP_ETH_TX_FIFO_EMPT(lane) ((1 << (lane)) | (1 << ((lane) + 4)))
+
 #define RNP_E_ENG_BYPASS   _ETH_(0x8000)
 #define RNP_E_VXLAN_PARSE_EN   _ETH_(0x8004)
 #define RNP_E_FILTER_EN_ETH_(0x801c)
diff --git a/drivers/net/rnp/base/rnp_fw_cmd.c 
b/drivers/net/rnp/base/rnp_fw_cmd.c
index a4a2171868..ed0eddfd1f 100644
--- a/drivers/net/rnp/base/rnp_fw_cmd.c
+++ b/drivers/net/rnp/base/rnp_fw_cmd.c
@@ -107,6 +107,25 @@ rnp_build_lane_evet_mask(struct rnp_mbx_fw_cmd_req *req,
arg->event_en = req_arg->param2;
 }
 
+static void
+rnp_build_ifup_down(struct rnp_mbx_fw_cmd_req *req,
+   struct rnp_fw_req_arg *req_arg,
+   void *cookie)
+{
+   struct rnp_ifup_down_req *arg =
+   (struct rnp_ifup_down_req *)req->data;
+
+   req->flags = 0;
+   req->opcode = RNP_IFUP_DOWN;
+   req->datalen = sizeof(*arg);
+   req->cookie = cookie;
+   req->reply_lo = 0;
+   req->reply_hi = 0;
+
+   arg->nr_lane = req_arg->param0;
+   arg->up = req_arg->param1;
+}
+
 int rnp_build_fwcmd_req(struct rnp_mbx_fw_cmd_req *req,
struct rnp_fw_req_arg *arg,
void *cookie)
@@ -132,6 +151,9 @@ int rnp_build_fwcmd_req(struct rnp_mbx_fw_cmd_req *req,
case RNP_SET_LANE_EVENT_EN:
rnp_build_lane_evet_mask(req, arg, cookie);
break;
+   case RNP_IFUP_DOWN:
+   rnp_build_ifup_down(req, arg, cookie);
+   break;
default:
err = -EOPNOTSUPP;
}
diff --git a/drivers/net/rnp/base/rnp_fw_cmd.h 
b/drivers/net/rnp/base/rnp_fw_cmd.h
index 6c6fd1803e..26db07ad36 100644
--- a/drivers/net/rnp/base/rnp_fw_cmd.h
+++ b/drivers/net/rnp/base/rnp_fw_cmd.h
@@ -309,6 +309,12 @@ struct rnp_link_stat_req {
struct rnp_port_stat states[RNP_MAX_PORT_OF_PF];
 };
 
+struct rnp_ifup_down_req {
+   u32 nr_lane;
+   u32 up;
+   u8 rsvd[24];
+};
+
 struct rnp_mbx_fw_cmd_req {
u16 flags;
u16 opcode;
diff --git a/drivers/net/rnp/base/rnp_mbx_fw.c 
b/drivers/net/rnp/base/rnp_mbx_fw.c
index c7e3b6819d..3e7cf7f9ad 100644
--- a/drivers/net/rnp/base/rnp_mbx_fw.c
+++ b/drivers/net/rnp/base/rnp_mbx_fw.c
@@ -460,3 +460,36 @@ rnp_rcv_msg_from_fw(struct rnp_eth_adapter *adapter, u32 
*msgbuf)
 
return 0;
 }
+
+static void rnp_link_stat_reset(struct rnp_hw *hw, u16 lane)
+{
+   u32 state;
+
+   spin_lock(&hw->link_sync);
+   state = RNP_E_REG_RD(hw, RNP_FW_LINK_SYNC);
+   state &= ~RNP_LINK_MAGIC_MASK;
+   state |= RNP_LINK_MAGIC_CODE;
+   state &= ~RTE_BIT32(lane);
+
+   RNP_E_REG_WR(hw, RNP_FW_LINK_SYNC, state);
+   rte_spinlock_unlock(&hw->link_sync);
+}
+
+int rnp_mbx_fw_ifup_down(struct rnp_eth_port *port, bool up)
+{
+   u16 nr_lane = port->attr.nr_lane;
+   struct rnp_hw *hw = port->hw;
+   struct rnp_fw_req_arg arg;
+   int err;
+
+   memset(&arg, 0, sizeof(arg));
+   arg.opcode = RNP_IFUP_DOWN;
+   arg.param0 = nr_lane;
+   arg.param1 = up;
+
+   err = rnp_fw_send_norep_cmd(port, &arg);
+   /* force firmware send irq event to dpdk */
+   if (!err && up)
+   rnp_link_stat_reset(hw, nr_lane);
+   return err;
+}
diff --git a/drivers/net/rnp/base/rnp_mbx_fw.h 
b/drivers/net/rnp/base/rnp_mbx_fw.h
index 159a0237be..397d2ec8c4 100644
--- a/drivers/net/rnp/base/rnp_mbx_fw.h
+++ b/drivers/net/rnp/base/rnp_mbx_fw.h
@@ -19,5 +19,6 @@ int rnp_fw_init(struct rnp_hw *hw);
 int rnp_rcv_msg_from_fw(struct rnp_eth_adapter *adapter, u32 *msgbuf);
 int rn

[PATCH v17 16/29] net/rnp: add MTU set operation

[Wenbo Cao]

add mtu update limit for multiple port mode.
multiple mode just used the max-mtu of ports
to limit receive.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|   1 +
 doc/guides/nics/rnp.rst |   3 +
 drivers/net/rnp/base/rnp_eth_regs.h |   3 +
 drivers/net/rnp/rnp.h   |   3 +
 drivers/net/rnp/rnp_ethdev.c| 145 
 5 files changed, 155 insertions(+)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 695b9c0dba..6d13370e8f 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -10,6 +10,7 @@ Link status event= Y
 Queue start/stop = Y
 Promiscuous mode = Y
 Allmulticast mode= Y
+MTU update   = Y
 RSS hash = Y
 RSS key update   = Y
 RSS reta update  = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 8677b6c775..c9d6baa5c2 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -43,6 +43,7 @@ Features
   Inner RSS is only support for vxlan/nvgre
 - Promiscuous mode
 - Link state information
+- MTU update
 
 Prerequisites and Pre-conditions
 
@@ -80,6 +81,8 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_dev_rss_reta_update``
 * ``rte_eth_dev_set_link_down``
 * ``rte_eth_dev_set_link_up``
+* ``rte_eth_dev_get_mtu``
+* ``rte_eth_dev_set_mtu``
 * ``rte_eth_promiscuous_disable``
 * ``rte_eth_promiscuous_enable``
 * ``rte_eth_allmulticast_enable``
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index c74886e70c..91a18dd42d 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -16,6 +16,9 @@
 #define RNP_RX_ETH_F_CTRL(n)   _ETH_(0x8070 + ((n) * 0x8))
 #define RNP_RX_ETH_F_OFF   (0x7ff)
 #define RNP_RX_ETH_F_ON(0x270)
+/* max/min pkts length receive limit ctrl */
+#define RNP_MIN_FRAME_CTRL _ETH_(0x80f0)
+#define RNP_MAX_FRAME_CTRL _ETH_(0x80f4)
 /* rx queue flow ctrl */
 #define RNP_RX_FC_ENABLE   _ETH_(0x8520)
 #define RNP_RING_FC_EN(n)  _ETH_(0x8524 + ((0x4) * ((n) / 32)))
diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index e5f3ac32bf..8323858043 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -123,6 +123,9 @@ struct rnp_eth_port {
bool hw_rss_en;
uint32_t indirtbl[RNP_RSS_INDIR_SIZE];
 
+   uint16_t cur_mtu;
+   bool jumbo_en;
+
rte_spinlock_t rx_mac_lock;
bool port_stopped;
 };
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 9a20df8990..8cb9078ce9 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -21,6 +21,7 @@
 #include "rnp_rss.h"
 #include "rnp_link.h"
 
+static int rnp_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
 static struct rte_eth_dev *
 rnp_alloc_eth_port(struct rte_pci_device *pci, char *name)
 {
@@ -142,6 +143,13 @@ static void rnp_mac_rx_enable(struct rte_eth_dev *dev)
mac_cfg = RNP_MAC_REG_RD(hw, lane, RNP_MAC_RX_CFG);
mac_cfg |= RNP_MAC_RE;
 
+   if (port->jumbo_en) {
+   mac_cfg |= RNP_MAC_JE;
+   mac_cfg |= RNP_MAC_GPSLCE | RNP_MAC_WD;
+   } else {
+   mac_cfg &= ~RNP_MAC_JE;
+   mac_cfg &= ~RNP_MAC_WD;
+   }
mac_cfg &= ~RNP_MAC_GPSL_MASK;
mac_cfg |= (RNP_MAC_MAX_GPSL << RNP_MAC_CPSL_SHIFT);
RNP_MAC_REG_WR(hw, lane, RNP_MAC_RX_CFG, mac_cfg);
@@ -211,6 +219,7 @@ rnp_rx_scattered_setup(struct rte_eth_dev *dev)
 {
uint16_t max_pkt_size =
dev->data->dev_conf.rxmode.mtu + RNP_ETH_OVERHEAD;
+   struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
struct rnp_hw *hw = port->hw;
struct rnp_rx_queue *rxq;
@@ -236,6 +245,12 @@ rnp_rx_scattered_setup(struct rte_eth_dev *dev)
return -ENOTSUP;
}
dma_buf_size = hw->min_dma_size;
+   if (dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_SCATTER ||
+   max_pkt_size > dma_buf_size ||
+   dev->data->mtu + RNP_ETH_OVERHEAD > dma_buf_size)
+   dev->data->scattered_rx = 1;
+   else
+   dev->data->scattered_rx = 0;
/* Setup max dma scatter engine split size */
if (max_pkt_size == dma_buf_size)
dma_buf_size += (dma_buf_size % 16);
@@ -296,6 +311,7 @@ static int rnp_dev_start(struct rte_eth_dev *eth_dev)
 {
struct rnp_eth_port *port = RNP_DEV_TO_PORT(eth_dev);
struct rte_eth_dev_data *data = eth_dev->data;
+   uint16_t max_rx_pkt_len = eth_dev->data->mtu;
bool lsc = data->dev_conf.intr_conf.lsc;
struct rnp_hw *hw = port->hw;
uint16_t lane = 0;
@@ -316,6 +332,9 @@ static int rnp_dev_start(struct rte_eth_dev *eth_dev)
if (ret)
return ret;
ret = rnp_rx_

[PATCH v17 07/29] net/rnp: add support MAC promisc mode

[Wenbo Cao]

add support two method of MAC unicast promisc
mulcast promisc broadcast promisc mode

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|   2 +
 doc/guides/nics/rnp.rst |  11 +++
 drivers/net/rnp/base/rnp_common.c   |   5 ++
 drivers/net/rnp/base/rnp_eth_regs.h |  15 
 drivers/net/rnp/base/rnp_hw.h   |  11 ++-
 drivers/net/rnp/base/rnp_mac.c  | 107 +++-
 drivers/net/rnp/base/rnp_mac.h  |   2 +
 drivers/net/rnp/base/rnp_mac_regs.h |  39 ++
 drivers/net/rnp/base/rnp_osdep.h|   5 ++
 drivers/net/rnp/rnp_ethdev.c|  43 +++
 10 files changed, 238 insertions(+), 2 deletions(-)
 create mode 100644 drivers/net/rnp/base/rnp_mac_regs.h

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 6766130a68..65f1ed3da0 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -5,5 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Promiscuous mode = Y
+Allmulticast mode= Y
 Linux= Y
 x86-64   = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index d6934ffdb9..767353644c 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -34,6 +34,11 @@ N10 has two functions, each function support muiple ports(1 
to 8),which not same
 
rnp mucse nic port.
 
+Features
+
+
+- Promiscuous mode
+
 Prerequisites and Pre-conditions
 
 - Prepare the system as recommended by DPDK suite.
@@ -58,3 +63,9 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_dev_close``
 * ``rte_eth_dev_stop``
 * ``rte_eth_dev_infos_get``
+* ``rte_eth_promiscuous_disable``
+* ``rte_eth_promiscuous_enable``
+* ``rte_eth_allmulticast_enable``
+* ``rte_eth_allmulticast_disable``
+* ``rte_eth_promiscuous_get``
+* ``rte_eth_allmulticast_get``
diff --git a/drivers/net/rnp/base/rnp_common.c 
b/drivers/net/rnp/base/rnp_common.c
index 5cd4ec133e..5655126ae0 100644
--- a/drivers/net/rnp/base/rnp_common.c
+++ b/drivers/net/rnp/base/rnp_common.c
@@ -4,6 +4,7 @@
 
 #include "rnp_osdep.h"
 #include "rnp_hw.h"
+#include "rnp_mac_regs.h"
 #include "rnp_eth_regs.h"
 #include "rnp_dma_regs.h"
 #include "rnp_common.h"
@@ -28,6 +29,7 @@ int rnp_init_hw(struct rnp_hw *hw)
struct rnp_eth_port *port = RNP_DEV_TO_PORT(hw->back->eth_dev);
u32 version = 0;
int ret = -1;
+   u32 idx = 0;
u32 state;
 
PMD_INIT_FUNC_TRACE();
@@ -60,6 +62,9 @@ int rnp_init_hw(struct rnp_hw *hw)
if (hw->nic_mode == RNP_DUAL_10G && hw->max_port_num == 2)
RNP_E_REG_WR(hw, RNP_TC_PORT_OFFSET(RNP_TARGET_TC_PORT),
RNP_PORT_OFF_QUEUE_NUM);
+   /* setup mac resiger ctrl base */
+   for (idx = 0; idx < hw->max_port_num; idx++)
+   hw->mac_base[idx] = (u8 *)hw->e_ctrl + RNP_MAC_BASE_OFFSET(idx);
 
return 0;
 }
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index 6957866d76..c4519ba1e5 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -10,6 +10,21 @@
 #define RNP_E_FILTER_EN_ETH_(0x801c)
 #define RNP_E_REDIR_EN _ETH_(0x8030)
 
+/* Mac Host Filter  */
+#define RNP_MAC_FCTRL  _ETH_(0x9110)
+#define RNP_MAC_FCTRL_MPE  RTE_BIT32(8)  /* Multicast Promiscuous En */
+#define RNP_MAC_FCTRL_UPE  RTE_BIT32(9)  /* Unicast Promiscuous En */
+#define RNP_MAC_FCTRL_BAM  RTE_BIT32(10) /* Broadcast Accept Mode */
+#define RNP_MAC_FCTRL_BYPASS   (\
+   RNP_MAC_FCTRL_MPE | \
+   RNP_MAC_FCTRL_UPE | \
+   RNP_MAC_FCTRL_BAM)
+/* Mucast unicast mac hash filter ctrl */
+#define RNP_MAC_MCSTCTRL   _ETH_(0x9114)
+#define RNP_MAC_HASH_MASK  RTE_GENMASK32(11, 0)
+#define RNP_MAC_MULTICASE_TBL_EN   RTE_BIT32(2)
+#define RNP_MAC_UNICASE_TBL_EN RTE_BIT32(3)
+
 #define RNP_TC_PORT_OFFSET(lane)   _ETH_(0xe840 + 0x04 * (lane))
 
 #endif /* _RNP_ETH_REGS_H */
diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index 3d1d5cd87b..8e4ca54d45 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -60,9 +60,17 @@ struct rnp_mbx_info {
 
 struct rnp_eth_port;
 /* mac operations */
+enum rnp_mpf_modes {
+   RNP_MPF_MODE_NONE = 0,
+   RNP_MPF_MODE_ALLMULTI, /* Multitle Promisc */
+   RNP_MPF_MODE_PROMISC,  /* Unicast Promisc */
+};
+
 struct rnp_mac_ops {
-   /* update mac packet filter mode */
+   /* get default mac address */
int (*get_macaddr)(struct rnp_eth_port *port, u8 *mac);
+   /* update mac packet filter mode */
+   int (*update_mpfm)(struct rnp_eth_port *port, u32 mode, bool en);
 };
 
 struct rnp_eth_adapter;
@@ -92,6 +100,7 @@ struct rnp_hw {
struct rnp_eth_adapter *back;   /* backup to the adapter handle */
void __iomem *e_ctrl;   /* eth

[PATCH v17 12/29] net/rnp: add support link update operations

[Wenbo Cao]

This patch add support poll/irq link get mode.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini  |   2 +
 doc/guides/nics/rnp.rst   |   3 +
 drivers/net/rnp/base/rnp_fw_cmd.c |  45 
 drivers/net/rnp/base/rnp_fw_cmd.h |  55 +
 drivers/net/rnp/base/rnp_hw.h |   3 +-
 drivers/net/rnp/base/rnp_mbx_fw.c |  72 ++-
 drivers/net/rnp/base/rnp_mbx_fw.h |   4 +
 drivers/net/rnp/meson.build   |   1 +
 drivers/net/rnp/rnp.h |  12 ++
 drivers/net/rnp/rnp_ethdev.c  | 118 ++-
 drivers/net/rnp/rnp_link.c| 339 ++
 drivers/net/rnp/rnp_link.h|  50 +
 12 files changed, 697 insertions(+), 7 deletions(-)
 create mode 100644 drivers/net/rnp/rnp_link.c
 create mode 100644 drivers/net/rnp/rnp_link.h

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 2fc94825f5..695b9c0dba 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -5,6 +5,8 @@
 ;
 [Features]
 Speed capabilities   = Y
+Link status  = Y
+Link status event= Y
 Queue start/stop = Y
 Promiscuous mode = Y
 Allmulticast mode= Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 5f9385720b..4d4f3ebffe 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -42,6 +42,7 @@ Features
   Receiver Side Steering (RSS) on IPv4, IPv6, IPv4-TCP/UDP/SCTP, 
IPv6-TCP/UDP/SCTP
   Inner RSS is only support for vxlan/nvgre
 - Promiscuous mode
+- Link state information
 
 Prerequisites and Pre-conditions
 
@@ -85,3 +86,5 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_allmulticast_get``
 * ``rte_eth_rx_queue_setup``
 * ``rte_eth_tx_queue_setup``
+* ``rte_eth_link_get``
+* ``rte_eth_link_get_nowait``
diff --git a/drivers/net/rnp/base/rnp_fw_cmd.c 
b/drivers/net/rnp/base/rnp_fw_cmd.c
index 3891249499..a4a2171868 100644
--- a/drivers/net/rnp/base/rnp_fw_cmd.c
+++ b/drivers/net/rnp/base/rnp_fw_cmd.c
@@ -68,6 +68,45 @@ rnp_build_get_lane_status_req(struct rnp_mbx_fw_cmd_req *req,
arg->nr_lane = req_arg->param0;
 }
 
+static void
+rnp_build_set_event_mask(struct rnp_mbx_fw_cmd_req *req,
+struct rnp_fw_req_arg *req_arg,
+void *cookie)
+{
+   struct rnp_set_pf_event_mask *arg =
+   (struct rnp_set_pf_event_mask *)req->data;
+
+   req->flags = 0;
+   req->opcode = RNP_SET_EVENT_MASK;
+   req->datalen = sizeof(*arg);
+   req->cookie = cookie;
+   req->reply_lo = 0;
+   req->reply_hi = 0;
+
+   arg->event_mask = req_arg->param0;
+   arg->event_en = req_arg->param1;
+}
+
+static void
+rnp_build_lane_evet_mask(struct rnp_mbx_fw_cmd_req *req,
+struct rnp_fw_req_arg *req_arg,
+void *cookie)
+{
+   struct rnp_set_lane_event_mask *arg =
+   (struct rnp_set_lane_event_mask *)req->data;
+
+   req->flags = 0;
+   req->opcode = RNP_SET_LANE_EVENT_EN;
+   req->datalen = sizeof(*arg);
+   req->cookie = cookie;
+   req->reply_lo = 0;
+   req->reply_hi = 0;
+
+   arg->nr_lane = req_arg->param0;
+   arg->event_mask = req_arg->param1;
+   arg->event_en = req_arg->param2;
+}
+
 int rnp_build_fwcmd_req(struct rnp_mbx_fw_cmd_req *req,
struct rnp_fw_req_arg *arg,
void *cookie)
@@ -87,6 +126,12 @@ int rnp_build_fwcmd_req(struct rnp_mbx_fw_cmd_req *req,
case RNP_GET_LANE_STATUS:
rnp_build_get_lane_status_req(req, arg, cookie);
break;
+   case RNP_SET_EVENT_MASK:
+   rnp_build_set_event_mask(req, arg, cookie);
+   break;
+   case RNP_SET_LANE_EVENT_EN:
+   rnp_build_lane_evet_mask(req, arg, cookie);
+   break;
default:
err = -EOPNOTSUPP;
}
diff --git a/drivers/net/rnp/base/rnp_fw_cmd.h 
b/drivers/net/rnp/base/rnp_fw_cmd.h
index 5f60ac6187..6c6fd1803e 100644
--- a/drivers/net/rnp/base/rnp_fw_cmd.h
+++ b/drivers/net/rnp/base/rnp_fw_cmd.h
@@ -6,6 +6,7 @@
 #define _RNP_FW_CMD_H_
 
 #include "rnp_osdep.h"
+#include "rnp_hw.h"
 
 #define RNP_FW_LINK_SYNC   (0x000c)
 #define RNP_LINK_MAGIC_CODE(0xa5a4)
@@ -73,6 +74,22 @@ enum RNP_GENERIC_CMD {
RNP_SET_DDR_CSL = 0xFF11,
 };
 
+struct rnp_port_stat {
+   u8 phy_addr; /* Phy MDIO address */
+
+   u8 duplex   : 1; /* FIBRE is always 1,Twisted Pair 1 or 0 */
+   u8 autoneg  : 1; /* autoned state */
+   u8 fec  : 1;
+   u8 an_rev   : 1;
+   u8 link_traing  : 1;
+   u8 is_sgmii : 1; /* avild fw >= 0.5.0.17 */
+   u8 rsvd0: 2;
+   u16 speed;   /* cur port linked speed */
+
+   u16 pause   : 4;
+   u16 rsvd1   : 12;
+};
+
 /* firmware -> driver reply */
 struct __rte_aligned(4) __rte_packed_begin rnp_

[PATCH v17 08/29] net/rnp: add queue setup and release operations

[Wenbo Cao]

support tx/rx queue setup and release add hw bd
queue reset,sw queue reset.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/rnp.rst |   3 +
 drivers/net/rnp/base/meson.build|   1 +
 drivers/net/rnp/base/rnp_bdq_if.c   | 398 +++
 drivers/net/rnp/base/rnp_bdq_if.h   | 149 +
 drivers/net/rnp/base/rnp_common.h   |   4 +
 drivers/net/rnp/base/rnp_dma_regs.h |  45 +++
 drivers/net/rnp/base/rnp_eth_regs.h |   4 +
 drivers/net/rnp/base/rnp_hw.h   |   4 +
 drivers/net/rnp/base/rnp_osdep.h|  12 +
 drivers/net/rnp/meson.build |   1 +
 drivers/net/rnp/rnp.h   |   2 +
 drivers/net/rnp/rnp_ethdev.c|  38 ++-
 drivers/net/rnp/rnp_rxtx.c  | 471 
 drivers/net/rnp/rnp_rxtx.h  | 123 
 14 files changed, 1254 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/rnp/base/rnp_bdq_if.c
 create mode 100644 drivers/net/rnp/base/rnp_bdq_if.h
 create mode 100644 drivers/net/rnp/rnp_rxtx.c
 create mode 100644 drivers/net/rnp/rnp_rxtx.h

diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 767353644c..6ab2474c42 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -37,6 +37,7 @@ N10 has two functions, each function support muiple ports(1 
to 8),which not same
 Features
 
 
+- Multiple queues for TX and RX
 - Promiscuous mode
 
 Prerequisites and Pre-conditions
@@ -69,3 +70,5 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_allmulticast_disable``
 * ``rte_eth_promiscuous_get``
 * ``rte_eth_allmulticast_get``
+* ``rte_eth_rx_queue_setup``
+* ``rte_eth_tx_queue_setup``
diff --git a/drivers/net/rnp/base/meson.build b/drivers/net/rnp/base/meson.build
index 10026e0425..ba49accdec 100644
--- a/drivers/net/rnp/base/meson.build
+++ b/drivers/net/rnp/base/meson.build
@@ -7,6 +7,7 @@ sources = [
 'rnp_mbx_fw.c',
 'rnp_common.c',
 'rnp_mac.c',
+'rnp_bdq_if.c',
 ]
 
 c_args = cflags
diff --git a/drivers/net/rnp/base/rnp_bdq_if.c 
b/drivers/net/rnp/base/rnp_bdq_if.c
new file mode 100644
index 00..471c19efda
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_bdq_if.c
@@ -0,0 +1,398 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+
+#include "rnp_osdep.h"
+
+#include "../rnp.h"
+#include "rnp_dma_regs.h"
+#include "rnp_eth_regs.h"
+#include "rnp_bdq_if.h"
+#include "rnp_common.h"
+#include "../rnp_rxtx.h"
+
+static void
+rnp_read_mac_veb(struct rnp_hw *hw,
+ u16 nr_lane,
+ u16 vf_id,
+ struct rnp_veb_cfg *cfg)
+{
+   cfg->mac_lo = RNP_E_REG_RD(hw, RNP_VEB_MAC_LO(nr_lane, vf_id));
+   cfg->mac_hi = RNP_E_REG_RD(hw, RNP_VEB_MAC_HI(nr_lane, vf_id));
+   cfg->ring = RNP_E_REG_RD(hw, RNP_VEB_VF_RING(nr_lane, vf_id));
+}
+
+static void
+rnp_update_mac_veb(struct rnp_hw *hw,
+  u16 nr_lane,
+  u16 vf_id,
+  struct rnp_veb_cfg *cfg)
+{
+   u32 reg = cfg->ring;
+   u16 idx = 0;
+
+   idx = nr_lane;
+   wmb();
+   RNP_E_REG_WR(hw, RNP_VEB_MAC_LO(idx, vf_id), cfg->mac_lo);
+   RNP_E_REG_WR(hw, RNP_VEB_MAC_HI(idx, vf_id), cfg->mac_hi);
+   reg |= ((RNP_VEB_SWITCH_VF_EN | vf_id) << 8);
+   RNP_E_REG_WR(hw, RNP_VEB_VF_RING(idx, vf_id), reg);
+}
+
+void
+rnp_rxq_flow_disable(struct rnp_hw *hw,
+u16 hw_idx)
+{
+   u32 fc_ctrl;
+
+   spin_lock(&hw->rxq_reset_lock);
+   fc_ctrl = RNP_E_REG_RD(hw, RNP_RING_FC_EN(hw_idx));
+   wmb();
+   RNP_E_REG_WR(hw, RNP_RING_FC_THRESH(hw_idx), 0);
+   fc_ctrl |= 1 << (hw_idx % 32);
+   wmb();
+   RNP_E_REG_WR(hw, RNP_RING_FC_EN(hw_idx), fc_ctrl);
+}
+
+void
+rnp_rxq_flow_enable(struct rnp_hw *hw,
+   u16 hw_idx)
+{
+   u32 fc_ctrl;
+
+
+   fc_ctrl = RNP_E_REG_RD(hw, RNP_RING_FC_EN(hw_idx));
+   fc_ctrl &= ~(1 << (hw_idx % 32));
+   wmb();
+   RNP_E_REG_WR(hw, RNP_RING_FC_EN(hw_idx), fc_ctrl);
+
+   spin_unlock(&hw->rxq_reset_lock);
+}
+
+#define RNP_RXQ_RESET_PKT_LEN  (64)
+
+static void
+rnp_reset_xmit(struct rnp_tx_queue *txq, u64 pkt_addr)
+{
+   volatile struct rnp_tx_desc *txbd;
+   struct rnp_txsw_entry *tx_entry;
+   u16 timeout = 0;
+   u16 tx_id;
+
+   tx_id = txq->tx_tail;
+   txbd = &txq->tx_bdr[tx_id];
+   tx_entry = &txq->sw_ring[tx_id];
+   memset(tx_entry, 0, sizeof(*tx_entry));
+
+   txbd->d.addr = pkt_addr;
+   txbd->d.blen = RNP_RXQ_RESET_PKT_LEN;
+   wmb();
+   txbd->d.cmd = cpu_to_le16(RNP_CMD_EOP | RNP_CMD_RS);
+   tx_id = (tx_id + 1) & txq->attr.nb_desc_mask;
+   wmb();
+   RNP_REG_WR(txq->tx_tailreg, 0, tx_id);
+   do {
+   if (txbd->d.cmd & RNP_CMD_DD)
+   break;
+   if (timeout == 1000)
+   RNP_PMD_ERR("rx queue %u reset send pkt is hang",
+   txq->

[PATCH v17 05/29] net/rnp: add device init and uninit

[Wenbo Cao]

add firmware communic method and basic device
init, uninit and close resource function.

Signed-off-by: Wenbo Cao 
Reviewed-by: Ferruh Yigit 
---
 doc/guides/nics/rnp.rst |  10 +
 drivers/net/rnp/base/meson.build|   4 +
 drivers/net/rnp/base/rnp_common.c   |  73 ++
 drivers/net/rnp/base/rnp_common.h   |  12 +
 drivers/net/rnp/base/rnp_dma_regs.h |  13 ++
 drivers/net/rnp/base/rnp_eth_regs.h |  15 ++
 drivers/net/rnp/base/rnp_fw_cmd.c   |  75 +++
 drivers/net/rnp/base/rnp_fw_cmd.h   | 216 ++
 drivers/net/rnp/base/rnp_hw.h   |  39 
 drivers/net/rnp/base/rnp_mac.c  |  28 +++
 drivers/net/rnp/base/rnp_mac.h  |  14 ++
 drivers/net/rnp/base/rnp_mbx_fw.c   | 337 
 drivers/net/rnp/base/rnp_mbx_fw.h   |  18 ++
 drivers/net/rnp/base/rnp_osdep.h|  91 
 drivers/net/rnp/meson.build |   1 +
 drivers/net/rnp/rnp.h   |  44 
 drivers/net/rnp/rnp_ethdev.c| 321 +-
 17 files changed, 1302 insertions(+), 9 deletions(-)
 create mode 100644 drivers/net/rnp/base/rnp_common.c
 create mode 100644 drivers/net/rnp/base/rnp_common.h
 create mode 100644 drivers/net/rnp/base/rnp_dma_regs.h
 create mode 100644 drivers/net/rnp/base/rnp_eth_regs.h
 create mode 100644 drivers/net/rnp/base/rnp_fw_cmd.c
 create mode 100644 drivers/net/rnp/base/rnp_fw_cmd.h
 create mode 100644 drivers/net/rnp/base/rnp_mac.c
 create mode 100644 drivers/net/rnp/base/rnp_mac.h
 create mode 100644 drivers/net/rnp/base/rnp_mbx_fw.c
 create mode 100644 drivers/net/rnp/base/rnp_mbx_fw.h

diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 89c2f64d35..77337a68ad 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -47,3 +47,13 @@ Limitations or Known issues
 ---
 
 X86-32, BSD, Armv7, RISC-V, Windows, are not supported yet.
+
+Supported APIs
+--
+
+rte_eth APIs
+
+
+Listed below are the rte_eth functions supported:
+* ``rte_eth_dev_close``
+* ``rte_eth_dev_stop``
diff --git a/drivers/net/rnp/base/meson.build b/drivers/net/rnp/base/meson.build
index 22e7d0ee4b..10026e0425 100644
--- a/drivers/net/rnp/base/meson.build
+++ b/drivers/net/rnp/base/meson.build
@@ -3,6 +3,10 @@
 
 sources = [
 'rnp_mbx.c',
+'rnp_fw_cmd.c',
+'rnp_mbx_fw.c',
+'rnp_common.c',
+'rnp_mac.c',
 ]
 
 c_args = cflags
diff --git a/drivers/net/rnp/base/rnp_common.c 
b/drivers/net/rnp/base/rnp_common.c
new file mode 100644
index 00..5cd4ec133e
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_common.c
@@ -0,0 +1,73 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+
+#include "rnp_osdep.h"
+#include "rnp_hw.h"
+#include "rnp_eth_regs.h"
+#include "rnp_dma_regs.h"
+#include "rnp_common.h"
+#include "rnp_mbx_fw.h"
+#include "rnp_mac.h"
+#include "../rnp.h"
+
+static void
+rnp_hw_reset(struct rnp_hw *hw)
+{
+   PMD_INIT_FUNC_TRACE();
+
+   RNP_E_REG_WR(hw, RNP_NIC_RESET, 0);
+   /* hardware reset valid must be 0 -> 1 */
+   wmb();
+   RNP_E_REG_WR(hw, RNP_NIC_RESET, 1);
+   RNP_PMD_DRV_LOG(INFO, "PF[%d] reset nic finish", hw->mbx.pf_num);
+}
+
+int rnp_init_hw(struct rnp_hw *hw)
+{
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(hw->back->eth_dev);
+   u32 version = 0;
+   int ret = -1;
+   u32 state;
+
+   PMD_INIT_FUNC_TRACE();
+   version = RNP_E_REG_RD(hw, RNP_DMA_VERSION);
+   RNP_PMD_DRV_LOG(INFO, "nic hw version:0x%.2x", version);
+   rnp_fw_init(hw);
+   RNP_E_REG_WR(hw, RNP_DMA_HW_EN, FALSE);
+   do {
+   state = RNP_E_REG_RD(hw, RNP_DMA_HW_STATE);
+   } while (state == 0);
+   ret = rnp_mbx_fw_get_capability(port);
+   if (ret) {
+   RNP_PMD_ERR("mbx_get_capability error! errcode=%d", ret);
+   return ret;
+   }
+   rnp_hw_reset(hw);
+   rnp_mbx_fw_reset_phy(hw);
+   /* rx packet protocol engine bypass */
+   RNP_E_REG_WR(hw, RNP_E_ENG_BYPASS, FALSE);
+   /* enable host filter */
+   RNP_E_REG_WR(hw, RNP_E_FILTER_EN, TRUE);
+   /* enable vxlan parse */
+   RNP_E_REG_WR(hw, RNP_E_VXLAN_PARSE_EN, TRUE);
+   /* enable flow direct engine */
+   RNP_E_REG_WR(hw, RNP_E_REDIR_EN, TRUE);
+   /* enable dma engine */
+   RNP_E_REG_WR(hw, RNP_DMA_HW_EN, RNP_DMA_EN_ALL);
+#define RNP_TARGET_TC_PORT (2)
+#define RNP_PORT_OFF_QUEUE_NUM (2)
+   if (hw->nic_mode == RNP_DUAL_10G && hw->max_port_num == 2)
+   RNP_E_REG_WR(hw, RNP_TC_PORT_OFFSET(RNP_TARGET_TC_PORT),
+   RNP_PORT_OFF_QUEUE_NUM);
+
+   return 0;
+}
+
+int
+rnp_setup_common_ops(struct rnp_hw *hw)
+{
+   rnp_mac_ops_init(hw);
+
+   return 0;
+}
diff --git a/drivers/net/rnp/base/rnp_common.h 
b/drivers/net/rnp/base/rnp_common.h
new file mode 100644
index 00..aaf77a6dad
--- /dev/null
+++ b/drivers

[PATCH v17 09/29] net/rnp: add queue stop and start operations

[Wenbo Cao]

support rx/tx queue stop/start,for rx queue stop
need to reset a queue,must stop all rx queue
during reset this queue.

Signed-off-by: Wenbo Cao 
Reviewed-by: Stephen Hemminger 
---
 doc/guides/nics/features/rnp.ini  |   1 +
 doc/guides/nics/rnp.rst   |   4 +
 drivers/net/rnp/base/rnp_common.c |   3 +
 drivers/net/rnp/rnp_ethdev.c  |   4 +
 drivers/net/rnp/rnp_rxtx.c| 167 ++
 drivers/net/rnp/rnp_rxtx.h|   9 ++
 6 files changed, 188 insertions(+)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 65f1ed3da0..fd7d4b9d8d 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -5,6 +5,7 @@
 ;
 [Features]
 Speed capabilities   = Y
+Queue start/stop = Y
 Promiscuous mode = Y
 Allmulticast mode= Y
 Linux= Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 6ab2474c42..7b3462c64b 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -64,6 +64,10 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_dev_close``
 * ``rte_eth_dev_stop``
 * ``rte_eth_dev_infos_get``
+* ``rte_eth_dev_rx_queue_start``
+* ``rte_eth_dev_rx_queue_stop``
+* ``rte_eth_dev_tx_queue_start``
+* ``rte_eth_dev_tx_queue_stop``
 * ``rte_eth_promiscuous_disable``
 * ``rte_eth_promiscuous_enable``
 * ``rte_eth_allmulticast_enable``
diff --git a/drivers/net/rnp/base/rnp_common.c 
b/drivers/net/rnp/base/rnp_common.c
index 5655126ae0..58de3bde03 100644
--- a/drivers/net/rnp/base/rnp_common.c
+++ b/drivers/net/rnp/base/rnp_common.c
@@ -65,6 +65,9 @@ int rnp_init_hw(struct rnp_hw *hw)
/* setup mac resiger ctrl base */
for (idx = 0; idx < hw->max_port_num; idx++)
hw->mac_base[idx] = (u8 *)hw->e_ctrl + RNP_MAC_BASE_OFFSET(idx);
+   /* tx all hw queue must be started */
+   for (idx = 0; idx < RNP_MAX_RX_QUEUE_NUM; idx++)
+   RNP_E_REG_WR(hw, RNP_TXQ_START(idx), true);
 
return 0;
 }
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index f207a7e865..8c8691ce7f 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -249,8 +249,12 @@ static const struct eth_dev_ops rnp_eth_dev_ops = {
 
.rx_queue_setup   = rnp_rx_queue_setup,
.rx_queue_release = rnp_dev_rx_queue_release,
+   .rx_queue_stop= rnp_rx_queue_stop,
+   .rx_queue_start   = rnp_rx_queue_start,
.tx_queue_setup   = rnp_tx_queue_setup,
.tx_queue_release = rnp_dev_tx_queue_release,
+   .tx_queue_stop= rnp_tx_queue_stop,
+   .tx_queue_start   = rnp_tx_queue_start,
 };
 
 static void
diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index d370948d6b..e65bc06d36 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -86,6 +86,7 @@ rnp_rx_queue_reset(struct rnp_eth_port *port,
struct rte_eth_txconf def_conf;
struct rnp_hw *hw = port->hw;
struct rte_mbuf *m_mbuf[2];
+   bool tx_origin_e = false;
bool tx_new = false;
uint16_t index;
int err = 0;
@@ -121,6 +122,9 @@ rnp_rx_queue_reset(struct rnp_eth_port *port,
return -ENOMEM;
}
rnp_rxq_flow_disable(hw, index);
+   tx_origin_e = txq->txq_started;
+   rte_io_wmb();
+   txq->txq_started = false;
rte_mbuf_refcnt_set(m_mbuf[0], 1);
rte_mbuf_refcnt_set(m_mbuf[1], 1);
m_mbuf[0]->data_off = RTE_PKTMBUF_HEADROOM;
@@ -139,6 +143,7 @@ rnp_rx_queue_reset(struct rnp_eth_port *port,
rnp_tx_queue_reset(port, txq);
rnp_tx_queue_sw_reset(txq);
}
+   txq->txq_started = tx_origin_e;
}
rte_mempool_put_bulk(adapter->reset_pool, (void **)m_mbuf, 2);
rnp_rxq_flow_enable(hw, index);
@@ -367,6 +372,7 @@ rnp_tx_queue_sw_reset(struct rnp_tx_queue *txq)
txq->nb_tx_free = txq->attr.nb_desc - 1;
txq->tx_next_dd = txq->tx_rs_thresh - 1;
txq->tx_next_rs = txq->tx_rs_thresh - 1;
+   txq->tx_tail = 0;
 
size = (txq->attr.nb_desc + RNP_TX_MAX_BURST_SIZE);
for (idx = 0; idx < size * sizeof(struct rnp_tx_desc); idx++)
@@ -469,3 +475,164 @@ rnp_tx_queue_setup(struct rte_eth_dev *dev,
 
return err;
 }
+
+int rnp_tx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t qidx)
+{
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(eth_dev);
+   struct rte_eth_dev_data *data = eth_dev->data;
+   struct rnp_tx_queue *txq;
+
+   PMD_INIT_FUNC_TRACE();
+   txq = eth_dev->data->tx_queues[qidx];
+   if (!txq) {
+   RNP_PMD_ERR("TX queue %u is null or not setup", qidx);
+   return -EINVAL;
+   }
+   if (data->tx_queue_state[qidx] == RTE_ETH_QUEUE_STATE_STARTED) {
+   txq->txq_started = 0;
+   

[PATCH v17 06/29] net/rnp: add get device information operation

[Wenbo Cao]

add get device hardware capability function

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini  |   1 +
 doc/guides/nics/rnp.rst   |   1 +
 drivers/net/rnp/base/rnp_fw_cmd.c |  20 ++
 drivers/net/rnp/base/rnp_fw_cmd.h |  80 +
 drivers/net/rnp/base/rnp_mbx_fw.c |  55 ++
 drivers/net/rnp/base/rnp_mbx_fw.h |   1 +
 drivers/net/rnp/rnp.h |  73 ++-
 drivers/net/rnp/rnp_ethdev.c  | 115 +-
 8 files changed, 344 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 2ad04ee330..6766130a68 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -4,5 +4,6 @@
 ; Refer to default.ini for the full list of available PMD features.
 ;
 [Features]
+Speed capabilities   = Y
 Linux= Y
 x86-64   = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 77337a68ad..d6934ffdb9 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -57,3 +57,4 @@ rte_eth APIs
 Listed below are the rte_eth functions supported:
 * ``rte_eth_dev_close``
 * ``rte_eth_dev_stop``
+* ``rte_eth_dev_infos_get``
diff --git a/drivers/net/rnp/base/rnp_fw_cmd.c 
b/drivers/net/rnp/base/rnp_fw_cmd.c
index 676c5a2521..3891249499 100644
--- a/drivers/net/rnp/base/rnp_fw_cmd.c
+++ b/drivers/net/rnp/base/rnp_fw_cmd.c
@@ -51,6 +51,23 @@ rnp_build_get_macaddress_req(struct rnp_mbx_fw_cmd_req *req,
arg->pfvf_num = req_arg->param1;
 }
 
+static inline void
+rnp_build_get_lane_status_req(struct rnp_mbx_fw_cmd_req *req,
+ struct rnp_fw_req_arg *req_arg,
+ void *cookie)
+{
+   struct rnp_get_lane_st_req *arg = (struct rnp_get_lane_st_req 
*)req->data;
+
+   req->flags = 0;
+   req->opcode = RNP_GET_LANE_STATUS;
+   req->datalen = sizeof(*arg);
+   req->cookie = cookie;
+   req->reply_lo = 0;
+   req->reply_hi = 0;
+
+   arg->nr_lane = req_arg->param0;
+}
+
 int rnp_build_fwcmd_req(struct rnp_mbx_fw_cmd_req *req,
struct rnp_fw_req_arg *arg,
void *cookie)
@@ -67,6 +84,9 @@ int rnp_build_fwcmd_req(struct rnp_mbx_fw_cmd_req *req,
case RNP_GET_MAC_ADDRESS:
rnp_build_get_macaddress_req(req, arg, cookie);
break;
+   case RNP_GET_LANE_STATUS:
+   rnp_build_get_lane_status_req(req, arg, cookie);
+   break;
default:
err = -EOPNOTSUPP;
}
diff --git a/drivers/net/rnp/base/rnp_fw_cmd.h 
b/drivers/net/rnp/base/rnp_fw_cmd.h
index 87f0823dba..5f60ac6187 100644
--- a/drivers/net/rnp/base/rnp_fw_cmd.h
+++ b/drivers/net/rnp/base/rnp_fw_cmd.h
@@ -129,6 +129,80 @@ struct rnp_mac_addr_rep {
u32 pcode;
 };
 
+#define RNP_SPEED_CAP_UNKNOWN(0)
+#define RNP_SPEED_CAP_10M_FULL   RTE_BIT32(2)
+#define RNP_SPEED_CAP_100M_FULL  RTE_BIT32(3)
+#define RNP_SPEED_CAP_1GB_FULL   RTE_BIT32(4)
+#define RNP_SPEED_CAP_10GB_FULL  RTE_BIT32(5)
+#define RNP_SPEED_CAP_40GB_FULL  RTE_BIT32(6)
+#define RNP_SPEED_CAP_25GB_FULL  RTE_BIT32(7)
+#define RNP_SPEED_CAP_50GB_FULL  RTE_BIT32(8)
+#define RNP_SPEED_CAP_100GB_FULL RTE_BIT32(9)
+#define RNP_SPEED_CAP_10M_HALF   RTE_BIT32(10)
+#define RNP_SPEED_CAP_100M_HALF  RTE_BIT32(11)
+#define RNP_SPEED_CAP_1GB_HALF   RTE_BIT32(12)
+
+enum rnp_pma_phy_type {
+   RNP_PHY_TYPE_NONE = 0,
+   RNP_PHY_TYPE_1G_BASE_KX,
+   RNP_PHY_TYPE_SGMII,
+   RNP_PHY_TYPE_10G_BASE_KR,
+   RNP_PHY_TYPE_25G_BASE_KR,
+   RNP_PHY_TYPE_40G_BASE_KR4,
+   RNP_PHY_TYPE_10G_BASE_SR,
+   RNP_PHY_TYPE_40G_BASE_SR4,
+   RNP_PHY_TYPE_40G_BASE_CR4,
+   RNP_PHY_TYPE_40G_BASE_LR4,
+   RNP_PHY_TYPE_10G_BASE_LR,
+   RNP_PHY_TYPE_10G_BASE_ER,
+   RNP_PHY_TYPE_10G_TP,
+};
+
+struct rnp_lane_stat_rep {
+   u8 nr_lane; /* 0-3 cur port correspond with hw lane */
+   u8 pci_gen  : 4; /* nic cur pci speed genX: 1,2,3 */
+   u8 pci_lanes: 4; /* nic cur pci x1 x2 x4 x8 x16 */
+   u8 pma_type;
+   u8 phy_type;/* interface media type */
+
+   u16 linkup  : 1; /* cur port link state */
+   u16 duplex  : 1; /* duplex state only RJ45 valid */
+   u16 autoneg : 1; /* autoneg state */
+   u16 fec : 1; /* fec state */
+   u16 rev_an  : 1;
+   u16 link_traing : 1; /* link-traing state */
+   u16 media_available : 1;
+   u16 is_sgmii: 1; /* 1: Twisted Pair 0: FIBRE */
+   u16 link_fault  : 4;
+#define RNP_LINK_LINK_FAULTRTE_BIT32(0)
+#define RNP_LINK_TX_FAULT  RTE_BIT32(1)
+#define RNP_LINK_RX_FAULT  RTE_BIT32(2)
+#define RNP_LINK_REMOTE_FAULT  RTE_BIT32(3)
+   u16 is_backplane: 1;   /* Backplane Mode */
+   u16 is_speed_10G_1G_auto_swit

[PATCH v17 26/29] net/rnp: add support VLAN filters operations

[Wenbo Cao]

add support to update vid for vlan filter.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|  1 +
 doc/guides/nics/rnp.rst |  3 +-
 drivers/net/rnp/base/meson.build|  1 +
 drivers/net/rnp/base/rnp_bitrev.h   | 64 
 drivers/net/rnp/base/rnp_crc32.c| 37 
 drivers/net/rnp/base/rnp_crc32.h| 10 
 drivers/net/rnp/base/rnp_eth_regs.h |  1 +
 drivers/net/rnp/base/rnp_hw.h   |  1 +
 drivers/net/rnp/base/rnp_mac.c  | 90 -
 drivers/net/rnp/base/rnp_mac.h  |  1 +
 drivers/net/rnp/base/rnp_mac_regs.h |  6 ++
 drivers/net/rnp/base/rnp_osdep.h| 13 +
 drivers/net/rnp/rnp.h   | 11 
 drivers/net/rnp/rnp_ethdev.c| 11 
 14 files changed, 247 insertions(+), 3 deletions(-)
 create mode 100644 drivers/net/rnp/base/rnp_bitrev.h
 create mode 100644 drivers/net/rnp/base/rnp_crc32.c
 create mode 100644 drivers/net/rnp/base/rnp_crc32.h

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index c1ab91697a..48d250c86b 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -20,6 +20,7 @@ Promiscuous mode = Y
 Allmulticast mode= Y
 MTU update   = Y
 Unicast MAC filter   = Y
+VLAN filter  = Y
 VLAN offload = Y
 QinQ offload = P
 RSS hash = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index de7df8932a..2713d03765 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -44,7 +44,7 @@ Features
 - Promiscuous mode
 - Link state information
 - MTU update
-- MAC filtering
+- MAC/VLAN filtering
 - Jumbo frames
 - Scatter-Gather IO support
 - Port hardware statistic
@@ -98,6 +98,7 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_dev_get_vlan_offload``
 * ``rte_eth_dev_set_vlan_offload``
 * ``rte_eth_dev_set_vlan_strip_on_queue``
+* ``rte_eth_dev_vlan_filter``
 * ``rte_eth_promiscuous_disable``
 * ``rte_eth_promiscuous_enable``
 * ``rte_eth_allmulticast_enable``
diff --git a/drivers/net/rnp/base/meson.build b/drivers/net/rnp/base/meson.build
index ba49accdec..2a1f2c22ea 100644
--- a/drivers/net/rnp/base/meson.build
+++ b/drivers/net/rnp/base/meson.build
@@ -8,6 +8,7 @@ sources = [
 'rnp_common.c',
 'rnp_mac.c',
 'rnp_bdq_if.c',
+'rnp_crc32.c',
 ]
 
 c_args = cflags
diff --git a/drivers/net/rnp/base/rnp_bitrev.h 
b/drivers/net/rnp/base/rnp_bitrev.h
new file mode 100644
index 00..05c36ca80d
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_bitrev.h
@@ -0,0 +1,64 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+
+#ifndef _RNP_BITREV_H_
+#define _RNP_BITREV_H_
+
+#include "rnp_osdep.h"
+
+static const u8 byte_rev_table[256] = {
+   0x00, 0x80, 0x40, 0xc0, 0x20, 0xa0, 0x60, 0xe0,
+   0x10, 0x90, 0x50, 0xd0, 0x30, 0xb0, 0x70, 0xf0,
+   0x08, 0x88, 0x48, 0xc8, 0x28, 0xa8, 0x68, 0xe8,
+   0x18, 0x98, 0x58, 0xd8, 0x38, 0xb8, 0x78, 0xf8,
+   0x04, 0x84, 0x44, 0xc4, 0x24, 0xa4, 0x64, 0xe4,
+   0x14, 0x94, 0x54, 0xd4, 0x34, 0xb4, 0x74, 0xf4,
+   0x0c, 0x8c, 0x4c, 0xcc, 0x2c, 0xac, 0x6c, 0xec,
+   0x1c, 0x9c, 0x5c, 0xdc, 0x3c, 0xbc, 0x7c, 0xfc,
+   0x02, 0x82, 0x42, 0xc2, 0x22, 0xa2, 0x62, 0xe2,
+   0x12, 0x92, 0x52, 0xd2, 0x32, 0xb2, 0x72, 0xf2,
+   0x0a, 0x8a, 0x4a, 0xca, 0x2a, 0xaa, 0x6a, 0xea,
+   0x1a, 0x9a, 0x5a, 0xda, 0x3a, 0xba, 0x7a, 0xfa,
+   0x06, 0x86, 0x46, 0xc6, 0x26, 0xa6, 0x66, 0xe6,
+   0x16, 0x96, 0x56, 0xd6, 0x36, 0xb6, 0x76, 0xf6,
+   0x0e, 0x8e, 0x4e, 0xce, 0x2e, 0xae, 0x6e, 0xee,
+   0x1e, 0x9e, 0x5e, 0xde, 0x3e, 0xbe, 0x7e, 0xfe,
+   0x01, 0x81, 0x41, 0xc1, 0x21, 0xa1, 0x61, 0xe1,
+   0x11, 0x91, 0x51, 0xd1, 0x31, 0xb1, 0x71, 0xf1,
+   0x09, 0x89, 0x49, 0xc9, 0x29, 0xa9, 0x69, 0xe9,
+   0x19, 0x99, 0x59, 0xd9, 0x39, 0xb9, 0x79, 0xf9,
+   0x05, 0x85, 0x45, 0xc5, 0x25, 0xa5, 0x65, 0xe5,
+   0x15, 0x95, 0x55, 0xd5, 0x35, 0xb5, 0x75, 0xf5,
+   0x0d, 0x8d, 0x4d, 0xcd, 0x2d, 0xad, 0x6d, 0xed,
+   0x1d, 0x9d, 0x5d, 0xdd, 0x3d, 0xbd, 0x7d, 0xfd,
+   0x03, 0x83, 0x43, 0xc3, 0x23, 0xa3, 0x63, 0xe3,
+   0x13, 0x93, 0x53, 0xd3, 0x33, 0xb3, 0x73, 0xf3,
+   0x0b, 0x8b, 0x4b, 0xcb, 0x2b, 0xab, 0x6b, 0xeb,
+   0x1b, 0x9b, 0x5b, 0xdb, 0x3b, 0xbb, 0x7b, 0xfb,
+   0x07, 0x87, 0x47, 0xc7, 0x27, 0xa7, 0x67, 0xe7,
+   0x17, 0x97, 0x57, 0xd7, 0x37, 0xb7, 0x77, 0xf7,
+   0x0f, 0x8f, 0x4f, 0xcf, 0x2f, 0xaf, 0x6f, 0xef,
+   0x1f, 0x9f, 0x5f, 0xdf, 0x3f, 0xbf, 0x7f, 0xff,
+};
+
+static inline u8 bitrev8(u8 byte)
+{
+   return byte_rev_table[byte];
+}
+
+static u16 bitrev16(u16 x)
+{
+   return (bitrev8(x & 0xff) << 8) | bitrev8(x >> 8);
+}
+
+/**
+ * bitrev32 - reverse the order of bits in a u32 value
+ * @x: value to be bit-reversed
+ */
+static u32 bitrev32(uint32_t x)
+{
+   return (bitrev16(x & 0x) << 16) | bitrev16(x >> 16);

[PATCH v17 25/29] net/rnp: support VLAN offloads

[Wenbo Cao]

add support rx vlan strip,filter,tx vlan/qinq insert.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|   2 +
 doc/guides/nics/rnp.rst |   4 +
 drivers/net/rnp/base/rnp_bdq_if.h   |   2 +-
 drivers/net/rnp/base/rnp_eth_regs.h |   5 +
 drivers/net/rnp/base/rnp_hw.h   |   2 +
 drivers/net/rnp/base/rnp_mac.c  |  53 -
 drivers/net/rnp/base/rnp_mac.h  |   1 +
 drivers/net/rnp/base/rnp_mac_regs.h |  41 ++-
 drivers/net/rnp/rnp.h   |   7 ++
 drivers/net/rnp/rnp_ethdev.c| 170 +++-
 drivers/net/rnp/rnp_rxtx.c  |  22 +++-
 11 files changed, 303 insertions(+), 6 deletions(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index f6feb9aa70..c1ab91697a 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -20,6 +20,8 @@ Promiscuous mode = Y
 Allmulticast mode= Y
 MTU update   = Y
 Unicast MAC filter   = Y
+VLAN offload = Y
+QinQ offload = P
 RSS hash = Y
 RSS key update   = Y
 RSS reta update  = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 022a3d4535..de7df8932a 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -51,6 +51,7 @@ Features
 - Packet type parsing
 - Checksum offload
 - TSO offload
+- VLAN stripping and VLAN/QINQ insertion
 
 Prerequisites and Pre-conditions
 
@@ -94,6 +95,9 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_dev_mac_addr_add``
 * ``rte_eth_dev_mac_addr_remove``
 * ``rte_eth_dev_get_supported_ptypes``
+* ``rte_eth_dev_get_vlan_offload``
+* ``rte_eth_dev_set_vlan_offload``
+* ``rte_eth_dev_set_vlan_strip_on_queue``
 * ``rte_eth_promiscuous_disable``
 * ``rte_eth_promiscuous_enable``
 * ``rte_eth_allmulticast_enable``
diff --git a/drivers/net/rnp/base/rnp_bdq_if.h 
b/drivers/net/rnp/base/rnp_bdq_if.h
index 7a6d0b21ec..182a8a715d 100644
--- a/drivers/net/rnp/base/rnp_bdq_if.h
+++ b/drivers/net/rnp/base/rnp_bdq_if.h
@@ -87,7 +87,7 @@ struct rnp_tx_desc {
 #define RNP_RX_TUNNEL_MASK RTE_GENMASK32(14, 13)
 #define RNP_RX_PTYPE_VXLAN (0x01UL << RNP_RX_TUNNEL_TYPE_S)
 #define RNP_RX_PTYPE_NVGRE (0x02UL << RNP_RX_TUNNEL_TYPE_S)
-#define RNP_RX_PTYPE_VLAN  RTE_BIT32(15)
+#define RNP_RX_STRIP_VLAN  RTE_BIT32(15)
 /* mark_data */
 #define RNP_RX_L3TYPE_VALIDRTE_BIT32(31)
 /* tx data cmd */
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index e096ec90e6..f84386d93a 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -57,6 +57,11 @@
 #define RNP_MAC_HASH_MASK  RTE_GENMASK32(11, 0)
 #define RNP_MAC_MULTICASE_TBL_EN   RTE_BIT32(2)
 #define RNP_MAC_UNICASE_TBL_EN RTE_BIT32(3)
+/* vlan strip ctrl */
+#define RNP_VLAN_Q_STRIP_CTRL(n)   _ETH_(0x8040 + 0x4 * ((n) / 32))
+/* vlan filter ctrl */
+#define RNP_VLAN_FILTER_CTRL   _ETH_(0x9118)
+#define RNP_VLAN_FILTER_EN RTE_BIT32(30)
 /* rss function ctrl */
 #define RNP_RSS_INNER_CTRL _ETH_(0x805c)
 #define RNP_INNER_RSS_EN   (1)
diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index e5a19a1918..c7e5a2f506 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -74,6 +74,8 @@ struct rnp_mac_ops {
/* Receive Address Filter table */
int (*set_rafb)(struct rnp_eth_port *port, const u8 *mac, u32 index);
int (*clear_rafb)(struct rnp_eth_port *port, u32 index);
+   /* receive vlan filter */
+   int (*vlan_f_en)(struct rnp_eth_port *port, bool en);
 };
 
 struct rnp_eth_adapter;
diff --git a/drivers/net/rnp/base/rnp_mac.c b/drivers/net/rnp/base/rnp_mac.c
index 6ad2ca0a4a..b6b969a020 100644
--- a/drivers/net/rnp/base/rnp_mac.c
+++ b/drivers/net/rnp/base/rnp_mac.c
@@ -166,11 +166,53 @@ rnp_clear_mac_indep(struct rnp_eth_port *port, u32 index)
return 0;
 }
 
+static int
+rnp_en_vlan_filter_pf(struct rnp_eth_port *port, bool en)
+{
+   struct rnp_hw *hw = port->hw;
+   u32 ctrl;
+
+   /* enable/disable all vlan filter configuration */
+   ctrl = RNP_E_REG_RD(hw, RNP_VLAN_FILTER_CTRL);
+   if (en)
+   ctrl |= RNP_VLAN_FILTER_EN;
+   else
+   ctrl &= ~RNP_VLAN_FILTER_EN;
+   RNP_E_REG_WR(hw, RNP_VLAN_FILTER_CTRL, ctrl);
+
+   return 0;
+}
+
+static int
+rnp_en_vlan_filter_indep(struct rnp_eth_port *port, bool en)
+{
+   u16 lane = port->attr.nr_lane;
+   struct rnp_hw *hw = port->hw;
+   u32 flt_reg, vlan_reg;
+
+   flt_reg = RNP_MAC_REG_RD(hw, lane, RNP_MAC_PKT_FLT_CTRL);
+   vlan_reg = RNP_MAC_REG_RD(hw, lane, RNP_MAC_VLAN_TAG);
+   if (en) {
+   flt_reg |= RNP_MAC_VTFE;
+   vlan_reg |= (RNP_MAC_VLAN_VTHM | RNP_MAC_VLAN_ETV | \;
+RNP_MAC_VLAN_HASH_EN);
+   } else {
+   flt_reg &= ~RN

[PATCH v17 14/29] net/rnp: add Rx burst simple support

[Wenbo Cao]

add only support simple recv pkts.

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp_ethdev.c |   7 ++
 drivers/net/rnp/rnp_rxtx.c   | 130 +++
 drivers/net/rnp/rnp_rxtx.h   |   5 ++
 3 files changed, 142 insertions(+)

diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 4f82c08d28..31f339c021 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -335,6 +335,8 @@ static int rnp_dev_start(struct rte_eth_dev *eth_dev)
goto rxq_start_failed;
/* enable eth rx flow */
RNP_RX_ETH_ENABLE(hw, lane);
+   rnp_rx_func_select(eth_dev);
+   rnp_tx_func_select(eth_dev);
port->port_stopped = 0;
 
return 0;
@@ -595,6 +597,11 @@ static int rnp_dev_infos_get(struct rte_eth_dev *eth_dev,
/* default port configure */
dev_info->default_rxconf = (struct rte_eth_rxconf) {
.rx_drop_en = 0,
+   .rx_thresh = {
+   .pthresh = RNP_RX_DESC_FETCH_TH,
+   .hthresh = RNP_RX_DESC_FETCH_BURST,
+   },
+   .rx_free_thresh = RNP_DEFAULT_RX_FREE_THRESH,
.offloads = 0,
};
 
diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index e65bc06d36..a742646c7e 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -636,3 +636,133 @@ int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, 
uint16_t qidx)
 
return 0;
 }
+
+#define RNP_CACHE_FETCH_RX (4)
+static __rte_always_inline int
+rnp_refill_rx_ring(struct rnp_rx_queue *rxq)
+{
+   volatile struct rnp_rx_desc *rxbd;
+   struct rnp_rxsw_entry *rx_swbd;
+   struct rte_eth_dev_data *data;
+   struct rte_mbuf *mb;
+   uint16_t j, i;
+   uint16_t rx_id;
+   int ret;
+
+   rxbd = rxq->rx_bdr + rxq->rxrearm_start;
+   rx_swbd = &rxq->sw_ring[rxq->rxrearm_start];
+   ret = rte_mempool_get_bulk(rxq->mb_pool, (void *)rx_swbd,
+   rxq->rx_free_thresh);
+   data = rte_eth_devices[rxq->attr.port_id].data;
+   if (unlikely(ret != 0)) {
+   if (rxq->rxrearm_nb + rxq->rx_free_thresh >= rxq->attr.nb_desc) 
{
+   for (i = 0; i < RNP_CACHE_FETCH_RX; i++) {
+   rx_swbd[i].mbuf = &rxq->fake_mbuf;
+   rxbd[i].d.pkt_addr = 0;
+   rxbd[i].d.cmd = 0;
+   }
+   }
+   data->rx_mbuf_alloc_failed += rxq->rx_free_thresh;
+   return 0;
+   }
+   for (j = 0; j < rxq->rx_free_thresh; ++j) {
+   mb = rx_swbd[j].mbuf;
+   rte_mbuf_refcnt_set(mb, 1);
+   mb->data_off = RTE_PKTMBUF_HEADROOM;
+   mb->port = rxq->attr.port_id;
+
+   rxbd[j].d.pkt_addr = rnp_get_dma_addr(&rxq->attr, mb);
+   rxbd[j].d.cmd = 0;
+   }
+   rxq->rxrearm_start += rxq->rx_free_thresh;
+   if (rxq->rxrearm_start >= rxq->attr.nb_desc - 1)
+   rxq->rxrearm_start = 0;
+   rxq->rxrearm_nb -= rxq->rx_free_thresh;
+
+   rx_id = (uint16_t)((rxq->rxrearm_start == 0) ?
+   (rxq->attr.nb_desc - 1) : (rxq->rxrearm_start - 1));
+   rte_wmb();
+   RNP_REG_WR(rxq->rx_tailreg, 0, rx_id);
+
+   return j;
+}
+
+static __rte_always_inline uint16_t
+rnp_recv_pkts(void *_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
+{
+   struct rnp_rx_queue *rxq = (struct rnp_rx_queue *)_rxq;
+   struct rnp_rxsw_entry *rx_swbd;
+   uint32_t state_cmd[RNP_CACHE_FETCH_RX];
+   uint32_t pkt_len[RNP_CACHE_FETCH_RX] = {0};
+   volatile struct rnp_rx_desc *rxbd;
+   struct rte_mbuf *nmb;
+   int nb_dd, nb_rx = 0;
+   int i, j;
+
+   if (unlikely(!rxq->rxq_started || !rxq->rx_link))
+   return 0;
+   nb_pkts = RTE_ALIGN_FLOOR(nb_pkts, RNP_CACHE_FETCH_RX);
+   rxbd = &rxq->rx_bdr[rxq->rx_tail];
+   rte_prefetch0(rxbd);
+   if (rxq->rxrearm_nb > rxq->rx_free_thresh)
+   rnp_refill_rx_ring(rxq);
+
+   if (!(rxbd->wb.qword1.cmd & RNP_CMD_DD))
+   return 0;
+
+   rx_swbd = &rxq->sw_ring[rxq->rx_tail];
+   for (i = 0; i < nb_pkts;
+   i += RNP_CACHE_FETCH_RX, rxbd += RNP_CACHE_FETCH_RX,
+   rx_swbd += RNP_CACHE_FETCH_RX) {
+   for (j = 0; j < RNP_CACHE_FETCH_RX; j++)
+   state_cmd[j] = rxbd[j].wb.qword1.cmd;
+   rte_atomic_thread_fence(rte_memory_order_acquire);
+
+   for (nb_dd = 0; nb_dd < RNP_CACHE_FETCH_RX &&
+   (state_cmd[nb_dd] & 
rte_cpu_to_le_16(RNP_CMD_DD));
+   nb_dd++)
+   ;
+   for (j = 0; j < nb_dd; j++)
+   pkt_len[j] = rxbd[j].wb.qword1.lens;
+
+   for (j = 0; j < nb_dd; ++j) {
+ 

[PATCH v17 18/29] net/rnp: add Tx multiple segment version

[Wenbo Cao]

add support multiple segs mbuf send.

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp_ethdev.c |   2 +
 drivers/net/rnp/rnp_rxtx.c   | 126 ++-
 drivers/net/rnp/rnp_rxtx.h   |   3 +-
 3 files changed, 128 insertions(+), 3 deletions(-)

diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 48e4431945..a664c76847 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -608,6 +608,8 @@ static int rnp_dev_infos_get(struct rte_eth_dev *eth_dev,
dev_info->speed_capa = rnp_get_speed_caps(eth_dev);
/* rx support offload cap */
dev_info->rx_offload_capa = RTE_ETH_RX_OFFLOAD_SCATTER;
+   /* tx support offload cap */
+   dev_info->tx_offload_capa = RTE_ETH_TX_OFFLOAD_MULTI_SEGS;
/* default ring configure */
dev_info->default_rxportconf.burst_size = 32;
dev_info->default_txportconf.burst_size = 32;
diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index b2ca9b15fc..3d8fc50012 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -369,9 +369,11 @@ rnp_tx_queue_sw_reset(struct rnp_tx_queue *txq)
sw_ring[prev].next_id = idx;
prev = idx;
}
+   txq->last_desc_cleaned = txq->attr.nb_desc - 1;
txq->nb_tx_free = txq->attr.nb_desc - 1;
txq->tx_next_dd = txq->tx_rs_thresh - 1;
txq->tx_next_rs = txq->tx_rs_thresh - 1;
+   txq->nb_tx_used = 0;
txq->tx_tail = 0;
 
size = (txq->attr.nb_desc + RNP_TX_MAX_BURST_SIZE);
@@ -857,6 +859,7 @@ rnp_rxq_bulk_alloc(struct rnp_rx_queue *rxq,
rxe->mbuf = nmb;
rxbd->d.pkt_addr = rnp_get_dma_addr(&rxq->attr, nmb);
}
+   rxq->rxrearm_nb++;
if (rxq->rxrearm_nb > rxq->rx_free_thresh) {
rxq->rxrearm_nb -= rxq->rx_free_thresh;
rxq->rxrearm_start += rxq->rx_free_thresh;
@@ -924,7 +927,6 @@ rnp_scattered_rx(void *rx_queue, struct rte_mbuf **rx_pkts,
first_seg->nb_segs++;
last_seg->next = rxm;
}
-   rxq->rxrearm_nb++;
if (!(rx_status & rte_cpu_to_le_16(RNP_CMD_EOP))) {
last_seg = rxm;
continue;
@@ -945,6 +947,106 @@ rnp_scattered_rx(void *rx_queue, struct rte_mbuf 
**rx_pkts,
return nb_rx;
 }
 
+static __rte_always_inline uint16_t
+rnp_multiseg_clean_txq(struct rnp_tx_queue *txq)
+{
+   uint16_t last_desc_cleaned = txq->last_desc_cleaned;
+   struct rnp_txsw_entry *sw_ring = txq->sw_ring;
+   volatile struct rnp_tx_desc *txbd;
+   uint16_t desc_to_clean_to;
+   uint16_t nb_tx_to_clean;
+
+   desc_to_clean_to = (uint16_t)(last_desc_cleaned + txq->tx_rs_thresh);
+   desc_to_clean_to = desc_to_clean_to & (txq->attr.nb_desc - 1);
+
+   desc_to_clean_to = sw_ring[desc_to_clean_to].last_id;
+   txbd = &txq->tx_bdr[desc_to_clean_to];
+   if (!(txbd->d.cmd & RNP_CMD_DD))
+   return txq->nb_tx_free;
+
+   if (last_desc_cleaned > desc_to_clean_to)
+   nb_tx_to_clean = (uint16_t)((txq->attr.nb_desc -
+   last_desc_cleaned) + desc_to_clean_to);
+   else
+   nb_tx_to_clean = (uint16_t)(desc_to_clean_to -
+   last_desc_cleaned);
+
+   txbd->d.cmd = 0;
+
+   txq->last_desc_cleaned = desc_to_clean_to;
+   txq->nb_tx_free = (uint16_t)(txq->nb_tx_free + nb_tx_to_clean);
+
+   return txq->nb_tx_free;
+}
+
+static __rte_always_inline uint16_t
+rnp_multiseg_xmit_pkts(void *_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
+{
+   struct rnp_tx_queue *txq = (struct rnp_tx_queue *)_txq;
+   volatile struct rnp_tx_desc *txbd;
+   struct rnp_txsw_entry *txe, *txn;
+   struct rte_mbuf *tx_pkt, *m_seg;
+   uint16_t send_pkts = 0;
+   uint16_t nb_used_bd;
+   uint16_t tx_last;
+   uint16_t nb_tx;
+   uint16_t tx_id;
+
+   if (unlikely(!txq->txq_started || !txq->tx_link))
+   return 0;
+   if (txq->nb_tx_free < txq->tx_free_thresh)
+   rnp_multiseg_clean_txq(txq);
+   if (unlikely(txq->nb_tx_free == 0))
+   return 0;
+   tx_id = txq->tx_tail;
+   txbd = &txq->tx_bdr[tx_id];
+   txe = &txq->sw_ring[tx_id];
+   for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) {
+   tx_pkt = tx_pkts[nb_tx];
+   nb_used_bd = tx_pkt->nb_segs;
+   tx_last = (uint16_t)(tx_id + nb_used_bd - 1);
+   if (tx_last >= txq->attr.nb_desc)
+   tx_last = (uint16_t)(tx_last - txq->attr.nb_desc);
+   if (nb_used_bd > txq->nb_tx_free)
+   if (nb_used_bd > rnp_multiseg_clean_txq(txq))
+   break;
+   m_seg = tx_pkt;
+   do {
+   txbd = &txq->tx_bdr[tx_id];
+  

[PATCH v17 21/29] net/rnp: add unicast MAC filter operation

[Wenbo Cao]

add mac filter for single/multiple port.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/features/rnp.ini|  1 +
 doc/guides/nics/rnp.rst |  6 ++
 drivers/net/rnp/base/rnp_eth_regs.h |  4 ++
 drivers/net/rnp/base/rnp_hw.h   |  3 +
 drivers/net/rnp/base/rnp_mac.c  | 91 +
 drivers/net/rnp/base/rnp_mac.h  |  2 +
 drivers/net/rnp/base/rnp_mac_regs.h |  4 ++
 drivers/net/rnp/rnp.h   |  4 ++
 drivers/net/rnp/rnp_ethdev.c| 62 ++--
 9 files changed, 171 insertions(+), 6 deletions(-)

diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
index 14ff88fec1..00b23b0fa2 100644
--- a/doc/guides/nics/features/rnp.ini
+++ b/doc/guides/nics/features/rnp.ini
@@ -14,6 +14,7 @@ Queue start/stop = Y
 Promiscuous mode = Y
 Allmulticast mode= Y
 MTU update   = Y
+Unicast MAC filter   = Y
 RSS hash = Y
 RSS key update   = Y
 RSS reta update  = Y
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index e1e6b6d843..1e1f471673 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -44,6 +44,7 @@ Features
 - Promiscuous mode
 - Link state information
 - MTU update
+- MAC filtering
 - Jumbo frames
 - Scatter-Gather IO support
 - Port hardware statistic
@@ -86,6 +87,9 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_dev_set_link_up``
 * ``rte_eth_dev_get_mtu``
 * ``rte_eth_dev_set_mtu``
+* ``rte_eth_dev_default_mac_addr_set``
+* ``rte_eth_dev_mac_addr_add``
+* ``rte_eth_dev_mac_addr_remove``
 * ``rte_eth_promiscuous_disable``
 * ``rte_eth_promiscuous_enable``
 * ``rte_eth_allmulticast_enable``
@@ -101,3 +105,5 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_xstats_get``
 * ``rte_eth_xstats_reset``
 * ``rte_eth_xstats_get_names``
+* ``rte_eth_macaddr_get``
+* ``rte_eth_macaddrs_get``
diff --git a/drivers/net/rnp/base/rnp_eth_regs.h 
b/drivers/net/rnp/base/rnp_eth_regs.h
index adac817df2..49860135bd 100644
--- a/drivers/net/rnp/base/rnp_eth_regs.h
+++ b/drivers/net/rnp/base/rnp_eth_regs.h
@@ -64,5 +64,9 @@
 #define RNP_RSS_KEY_TABLE(idx) _ETH_(0x92d0 + ((idx) * 0x4))
 
 #define RNP_TC_PORT_OFFSET(lane)   _ETH_(0xe840 + 0x04 * (lane))
+/* host mac address filter */
+#define RNP_RAL_BASE_ADDR(n)   _ETH_(0xA000 + (0x04 * (n)))
+#define RNP_RAH_BASE_ADDR(n)   _ETH_(0xA400 + (0x04 * (n)))
+#define RNP_MAC_FILTER_EN  RTE_BIT32(31)
 
 #endif /* _RNP_ETH_REGS_H */
diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index 72e66338a0..e5a19a1918 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -71,6 +71,9 @@ struct rnp_mac_ops {
int (*get_macaddr)(struct rnp_eth_port *port, u8 *mac);
/* update mac packet filter mode */
int (*update_mpfm)(struct rnp_eth_port *port, u32 mode, bool en);
+   /* Receive Address Filter table */
+   int (*set_rafb)(struct rnp_eth_port *port, const u8 *mac, u32 index);
+   int (*clear_rafb)(struct rnp_eth_port *port, u32 index);
 };
 
 struct rnp_eth_adapter;
diff --git a/drivers/net/rnp/base/rnp_mac.c b/drivers/net/rnp/base/rnp_mac.c
index 52d8a47437..6ad2ca0a4a 100644
--- a/drivers/net/rnp/base/rnp_mac.c
+++ b/drivers/net/rnp/base/rnp_mac.c
@@ -95,14 +95,89 @@ rnp_update_mpfm_pf(struct rnp_eth_port *port, u32 mode, 
bool en)
return 0;
 }
 
+static int
+rnp_set_mac_addr_pf(struct rnp_eth_port *port,
+   const u8 *addr, u32 index)
+{
+   struct rnp_hw *hw = port->hw;
+   u32 addr_hi = 0, addr_lo = 0;
+   u8 *mac = NULL;
+
+   mac = (u8 *)&addr_hi;
+   mac[0] = addr[1];
+   mac[1] = addr[0];
+   mac = (u8 *)&addr_lo;
+   mac[0] = addr[5];
+   mac[1] = addr[4];
+   mac[2] = addr[3];
+   mac[3] = addr[2];
+   addr_hi |= RNP_MAC_FILTER_EN;
+   RNP_E_REG_WR(hw, RNP_RAH_BASE_ADDR(index), addr_hi);
+   RNP_E_REG_WR(hw, RNP_RAL_BASE_ADDR(index), addr_lo);
+
+   return 0;
+}
+
+static int
+rnp_set_mac_addr_indep(struct rnp_eth_port *port,
+  const u8 *addr, u32 index)
+{
+   u16 lane = port->attr.nr_lane;
+   struct rnp_hw *hw = port->hw;
+   u32 addr_hi = 0, addr_lo = 0;
+   u8 *mac = NULL;
+
+   mac = (u8 *)&addr_lo;
+   mac[0] = addr[0];
+   mac[1] = addr[1];
+   mac[2] = addr[2];
+   mac[3] = addr[3];
+   mac = (u8 *)&addr_hi;
+   mac[0] = addr[4];
+   mac[1] = addr[5];
+
+   addr_hi |= RNP_MAC_AE;
+   RNP_MAC_REG_WR(hw, lane, RNP_MAC_ADDR_HI(index), addr_hi);
+   RNP_MAC_REG_WR(hw, lane, RNP_MAC_ADDR_LO(index), addr_lo);
+
+   return 0;
+}
+
+static int
+rnp_clear_mac_pf(struct rnp_eth_port *port, u32 index)
+{
+   struct rnp_hw *hw = port->hw;
+
+   RNP_E_REG_WR(hw, RNP_RAL_BASE_ADDR(index), 0);
+   RNP_E_REG_WR(hw, RNP_RAH_BASE_ADDR(index), 0);
+
+   return 0;
+}
+
+static int
+rnp_clear_mac_indep(struct rnp_eth_port *port, u32 i

[PATCH v17 27/29] net/rnp: add queue info operation

[Wenbo Cao]

add support get queue configure info for user debug

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/rnp.rst  |  2 ++
 drivers/net/rnp/rnp_ethdev.c |  2 ++
 drivers/net/rnp/rnp_rxtx.c   | 42 
 drivers/net/rnp/rnp_rxtx.h   |  4 
 4 files changed, 50 insertions(+)

diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 2713d03765..671bb28112 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -106,7 +106,9 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_promiscuous_get``
 * ``rte_eth_allmulticast_get``
 * ``rte_eth_rx_queue_setup``
+* ``rte_eth_rx_queue_info_get``
 * ``rte_eth_tx_queue_setup``
+* ``rte_eth_tx_queue_info_get``
 * ``rte_eth_link_get``
 * ``rte_eth_link_get_nowait``
 * ``rte_eth_stats_get``
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 9ce0779592..84352509a1 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -1480,10 +1480,12 @@ static const struct eth_dev_ops rnp_eth_dev_ops = {
.rx_queue_release = rnp_dev_rx_queue_release,
.rx_queue_stop= rnp_rx_queue_stop,
.rx_queue_start   = rnp_rx_queue_start,
+   .rxq_info_get = rnp_rx_queue_info_get,
.tx_queue_setup   = rnp_tx_queue_setup,
.tx_queue_release = rnp_dev_tx_queue_release,
.tx_queue_stop= rnp_tx_queue_stop,
.tx_queue_start   = rnp_tx_queue_start,
+   .txq_info_get = rnp_tx_queue_info_get,
/* rss impl */
.reta_update  = rnp_dev_rss_reta_update,
.reta_query   = rnp_dev_rss_reta_query,
diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index 6504d62f62..d58b0412ce 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -1720,3 +1720,45 @@ int rnp_tx_func_select(struct rte_eth_dev *dev)
 
return 0;
 }
+
+void
+rnp_rx_queue_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
+ struct rte_eth_rxq_info *qinfo)
+{
+   struct rnp_rx_queue *rxq;
+
+   rxq = dev->data->rx_queues[queue_id];
+   if (!rxq)
+   return;
+   qinfo->mp = rxq->mb_pool;
+   qinfo->scattered_rx = dev->data->scattered_rx;
+   qinfo->queue_state = rxq->rxq_started;
+   qinfo->nb_desc = rxq->attr.nb_desc;
+   qinfo->rx_buf_size = rxq->rx_buf_len;
+
+   qinfo->conf.rx_deferred_start = rxq->rx_deferred_start;
+   qinfo->conf.rx_free_thresh = rxq->rx_free_thresh;
+   qinfo->conf.rx_thresh.pthresh = rxq->pthresh;
+   qinfo->conf.rx_thresh.hthresh = rxq->pburst;
+   qinfo->conf.offloads = rxq->rx_offloads;
+}
+
+void
+rnp_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
+ struct rte_eth_txq_info *qinfo)
+{
+   struct rnp_tx_queue *txq;
+
+   txq = dev->data->tx_queues[queue_id];
+   if (!txq)
+   return;
+   qinfo->queue_state = txq->txq_started;
+   qinfo->nb_desc = txq->attr.nb_desc;
+
+   qinfo->conf.tx_deferred_start = txq->tx_deferred_start;
+   qinfo->conf.tx_free_thresh = txq->tx_free_thresh;
+   qinfo->conf.tx_rs_thresh = txq->tx_rs_thresh;
+   qinfo->conf.tx_thresh.pthresh = txq->pthresh;
+   qinfo->conf.tx_thresh.hthresh = txq->pburst;
+   qinfo->conf.offloads = txq->tx_offloads;
+}
diff --git a/drivers/net/rnp/rnp_rxtx.h b/drivers/net/rnp/rnp_rxtx.h
index 51e5d4b600..dc4a8ea9dd 100644
--- a/drivers/net/rnp/rnp_rxtx.h
+++ b/drivers/net/rnp/rnp_rxtx.h
@@ -148,5 +148,9 @@ int rnp_rx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t 
qidx);
 int rnp_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t qidx);
 int rnp_rx_func_select(struct rte_eth_dev *dev);
 int rnp_tx_func_select(struct rte_eth_dev *dev);
+void rnp_rx_queue_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
+  struct rte_eth_rxq_info *qinfo);
+void rnp_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
+  struct rte_eth_txq_info *qinfo);
 
 #endif /* _RNP_RXTX_H_ */
-- 
2.25.1

[PATCH v17 28/29] net/rnp: support Rx/Tx burst mode info

[Wenbo Cao]

add platform method for get rx/tx burst function select
by upload func name.

Signed-off-by: Wenbo Cao 
---
 doc/guides/nics/rnp.rst  |  2 ++
 drivers/net/rnp/rnp_ethdev.c |  2 ++
 drivers/net/rnp/rnp_rxtx.c   | 58 
 drivers/net/rnp/rnp_rxtx.h   |  6 
 4 files changed, 68 insertions(+)

diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
index 671bb28112..f0afea9cd4 100644
--- a/doc/guides/nics/rnp.rst
+++ b/doc/guides/nics/rnp.rst
@@ -107,8 +107,10 @@ Listed below are the rte_eth functions supported:
 * ``rte_eth_allmulticast_get``
 * ``rte_eth_rx_queue_setup``
 * ``rte_eth_rx_queue_info_get``
+* ``rte_eth_rx_burst_mode_get``
 * ``rte_eth_tx_queue_setup``
 * ``rte_eth_tx_queue_info_get``
+* ``rte_eth_tx_burst_mode_get``
 * ``rte_eth_link_get``
 * ``rte_eth_link_get_nowait``
 * ``rte_eth_stats_get``
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 84352509a1..484e40f3be 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -1481,11 +1481,13 @@ static const struct eth_dev_ops rnp_eth_dev_ops = {
.rx_queue_stop= rnp_rx_queue_stop,
.rx_queue_start   = rnp_rx_queue_start,
.rxq_info_get = rnp_rx_queue_info_get,
+   .rx_burst_mode_get= rnp_rx_burst_mode_get,
.tx_queue_setup   = rnp_tx_queue_setup,
.tx_queue_release = rnp_dev_tx_queue_release,
.tx_queue_stop= rnp_tx_queue_stop,
.tx_queue_start   = rnp_tx_queue_start,
.txq_info_get = rnp_tx_queue_info_get,
+   .tx_burst_mode_get= rnp_tx_burst_mode_get,
/* rss impl */
.reta_update  = rnp_dev_rss_reta_update,
.reta_query   = rnp_dev_rss_reta_query,
diff --git a/drivers/net/rnp/rnp_rxtx.c b/drivers/net/rnp/rnp_rxtx.c
index d58b0412ce..da08728198 100644
--- a/drivers/net/rnp/rnp_rxtx.c
+++ b/drivers/net/rnp/rnp_rxtx.c
@@ -1762,3 +1762,61 @@ rnp_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t 
queue_id,
qinfo->conf.tx_thresh.hthresh = txq->pburst;
qinfo->conf.offloads = txq->tx_offloads;
 }
+
+static const struct {
+   eth_rx_burst_t pkt_burst;
+   const char *info;
+} rnp_rx_burst_infos[] = {
+   { rnp_scattered_rx, "Scalar Scattered" },
+   { rnp_recv_pkts,"Scalar" },
+};
+
+static const struct {
+   eth_tx_burst_t pkt_burst;
+   const char *info;
+} rnp_tx_burst_infos[] = {
+   { rnp_xmit_simple,  "Scalar Simple" },
+   { rnp_multiseg_xmit_pkts,   "Scalar" },
+};
+
+int
+rnp_rx_burst_mode_get(struct rte_eth_dev *dev,
+ __rte_unused uint16_t queue_id,
+ struct rte_eth_burst_mode *mode)
+{
+   eth_rx_burst_t pkt_burst = dev->rx_pkt_burst;
+   int ret = -EINVAL;
+   unsigned int i;
+
+   for (i = 0; i < RTE_DIM(rnp_rx_burst_infos); ++i) {
+   if (pkt_burst == rnp_rx_burst_infos[i].pkt_burst) {
+   snprintf(mode->info, sizeof(mode->info), "%s",
+   rnp_rx_burst_infos[i].info);
+   ret = 0;
+   break;
+   }
+   }
+
+   return ret;
+}
+
+int
+rnp_tx_burst_mode_get(struct rte_eth_dev *dev,
+ __rte_unused uint16_t queue_id,
+ struct rte_eth_burst_mode *mode)
+{
+   eth_tx_burst_t pkt_burst = dev->tx_pkt_burst;
+   int ret = -EINVAL;
+   unsigned int i;
+
+   for (i = 0; i < RTE_DIM(rnp_tx_burst_infos); ++i) {
+   if (pkt_burst == rnp_tx_burst_infos[i].pkt_burst) {
+   snprintf(mode->info, sizeof(mode->info), "%s",
+   rnp_tx_burst_infos[i].info);
+   ret = 0;
+   break;
+   }
+   }
+
+   return ret;
+}
diff --git a/drivers/net/rnp/rnp_rxtx.h b/drivers/net/rnp/rnp_rxtx.h
index dc4a8ea9dd..8639f0892d 100644
--- a/drivers/net/rnp/rnp_rxtx.h
+++ b/drivers/net/rnp/rnp_rxtx.h
@@ -152,5 +152,11 @@ void rnp_rx_queue_info_get(struct rte_eth_dev *dev, 
uint16_t queue_id,
   struct rte_eth_rxq_info *qinfo);
 void rnp_tx_queue_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
   struct rte_eth_txq_info *qinfo);
+int rnp_rx_burst_mode_get(struct rte_eth_dev *dev,
+ __rte_unused uint16_t queue_id,
+ struct rte_eth_burst_mode *mode);
+int rnp_tx_burst_mode_get(struct rte_eth_dev *dev,
+ __rte_unused uint16_t queue_id,
+ struct rte_eth_burst_mode *mode);
 
 #endif /* _RNP_RXTX_H_ */
-- 
2.25.1

Re: [PATCH] event/eth_tx: prefetch mbuf headers

[Mattias Rönnblom]

On 2025-03-28 06:43, Mattias Rönnblom wrote:

Prefetch mbuf headers, resulting in ~10% throughput improvement when
the Ethernet RX and TX Adapters are hosted on the same core (likely
~2x in case a dedicated TX core is used).

Signed-off-by: Mattias Rönnblom 
Tested-by: Peter Nilsson 


What should be added is that what's been tested is the 
non-RTE_EVENT_TYPE_VECTOR case.



---
  lib/eventdev/rte_event_eth_tx_adapter.c | 20 
  1 file changed, 20 insertions(+)

diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c 
b/lib/eventdev/rte_event_eth_tx_adapter.c
index 67fff8b7d6..d740ae00f9 100644
--- a/lib/eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/eventdev/rte_event_eth_tx_adapter.c
@@ -598,6 +598,12 @@ txa_process_event_vector(struct txa_service_data *txa,
return nb_tx;
  }
  
+static inline void

+txa_prefetch_mbuf(struct rte_mbuf *mbuf)
+{
+   rte_mbuf_prefetch_part1(mbuf);
+}
+
  static void
  txa_service_tx(struct txa_service_data *txa, struct rte_event *ev,
uint32_t n)
@@ -608,6 +614,20 @@ txa_service_tx(struct txa_service_data *txa, struct 
rte_event *ev,
  
  	stats = &txa->stats;
  
+	for (i = 0; i < n; i++) {

+   struct rte_event *event = &ev[i];
+
+   if (unlikely(event->event_type & RTE_EVENT_TYPE_VECTOR)) {
+   struct rte_event_vector *vec = event->vec;
+   struct rte_mbuf **mbufs = vec->mbufs;
+   uint32_t k;
+
+   for (k = 0; k < vec->nb_elem; k++)
+   txa_prefetch_mbuf(mbufs[k]);
+   } else
+   txa_prefetch_mbuf(event->mbuf);
+   }
+
nb_tx = 0;
for (i = 0; i < n; i++) {
uint16_t port;

[PATCH v17 00/29] [v17]drivers/net Add Support mucse N10 Pmd Driver

[Wenbo Cao]

For This patchset just to support the basic chip init work
and user can just found the eth_dev, but can't control more.
For Now just support 2*10g nic,the chip can support
2*10g,4*10g,4*1g,8*1g,8*10g.
The Feature rx side can support rx-cksum-offload,rss,vlan-filter
flow_clow,uncast_filter,mcast_filter,1588,Jumbo-frame
The Feature tx side can support tx-cksum-offload,tso,vxlan-tso 
flow director base on ntuple pattern of tcp/udp/ip/ eth_hdr->type
for sriov is also support.

Because of the chip design defect, for multiple-port mode
one pci-bdf will have multiple-port (max can have four ports)
so this code must be care of one bdf init multiple-port.

v17
  * base 25.07 porting
  * change rte_memcpy to memcpy
  * doc rnp.rst remove ocp support, change nic-card description

v16
  * fixed rxq/txq stop/start not add to eth_ops as rnp doc descript.

v15:
  * fixed scatter recv for jumbo frame test by dts mtu.

v14:
  * add multicast mac filter feature for basic nic feature.
  * fixed pvs studio low,media,high level warning as the below cmd
pvs-studio-analyzer analyze -f build/compile_commands.json -j 8
plog-converter -a GA:1,2,3 -t fullhtml PVS-Studio.log -o /root/report

v13:
  * Supplementary document about n10 network card characteristics.
  * update release_25_03.rst.
  * fixed the code style advisea Stephen Hemminger.
  * fixed the code issue check PVS-stdio for Static compilation error.

v12:
  * fixed __rte_packed __deprecated__ compile issue.

v11:
  * fixed array-bounds issue when used rte_memcpy src addr is
  * not enough to hold align dst.
  * improve efficient_code advised by Stephen

v10:
  * fixed mingw windows meson issue
  * rnp not support windows for now.

v9:
  * fixed commit log format check by devtools.
  * fixed code compile issue.

v8:
  * fixed codespell issue.
  * fixed MAINTAINERS file

v7:
  * add support nic basic feature such as rss vlan strip/filter,
  * mtu-change recv/send scater-recv/mutltiple-send.
  * fixed code rationality, advised by Ferruh Yigit.
v6:
  * fixed the doc(rst) format problem advise by Thomas Monjalon

v5:
  * fixed the symbol name require by the style documentation

v4:
  * one patch has been forgot to upload :(

v3:
  * fixed http://dpdk.org/patch/129830 FreeBSD 13 compile Issue
  * change iobar type to void suggest by Stephen Hemminger
  * add KMOD_DEP support for vfio-pci
  * change run-cmd argument parse check for invalid extra_args

v2:
  * fixed MAINTAIN maillist fullname format
  * fixed driver/net/meson the order issue of new driver to driver list
  * improve virtual point function usage suggest by Stephen Hemminger

Wenbo Cao (29):
  net/rnp: add skeleton
  net/rnp: add ethdev probe and remove
  net/rnp: add log
  net/rnp: support mailbox basic operate
  net/rnp: add device init and uninit
  net/rnp: add get device information operation
  net/rnp: add support MAC promisc mode
  net/rnp: add queue setup and release operations
  net/rnp: add queue stop and start operations
  net/rnp: add support device start stop operations
  net/rnp: add RSS support operations
  net/rnp: add support link update operations
  net/rnp: add support link setup operations
  net/rnp: add Rx burst simple support
  net/rnp: add Tx burst simple support
  net/rnp: add MTU set operation
  net/rnp: add Rx scatter segment version
  net/rnp: add Tx multiple segment version
  net/rnp: add support basic stats operation
  net/rnp: add support xstats operation
  net/rnp: add unicast MAC filter operation
  net/rnp: add supported packet types
  net/rnp: add support Rx checksum offload
  net/rnp: add support Tx TSO offload
  net/rnp: support VLAN offloads
  net/rnp: add support VLAN filters operations
  net/rnp: add queue info operation
  net/rnp: support Rx/Tx burst mode info
  net/rnp: add multicast MAC filter operation

 .mailmap   |1 +
 MAINTAINERS|6 +
 doc/guides/nics/features/rnp.ini   |   34 +
 doc/guides/nics/img/mucse_nic_port.svg | 4023 
 doc/guides/nics/index.rst  |1 +
 doc/guides/nics/rnp.rst|  123 +
 doc/guides/rel_notes/release_25_07.rst |5 +
 drivers/net/meson.build|1 +
 drivers/net/rnp/base/meson.build   |   18 +
 drivers/net/rnp/base/rnp_bdq_if.c  |  398 +++
 drivers/net/rnp/base/rnp_bdq_if.h  |  154 +
 drivers/net/rnp/base/rnp_bitrev.h  |   64 +
 drivers/net/rnp/base/rnp_common.c  |  103 +
 drivers/net/rnp/base/rnp_common.h  |   17 +
 drivers/net/rnp/base/rnp_crc32.c   |   53 +
 drivers/net/rnp/base/rnp_crc32.h   |   11 +
 drivers/net/rnp/base/rnp_dma_regs.h|   68 +
 drivers/net/rnp/base/rnp_eth_regs.h|   94 +
 drivers/net/rnp/base/rnp_fw_cmd.c  |  162 +
 drivers/net/rnp/base/rnp_fw_cmd.h  |  357 +++
 drivers/net/rnp/base/rnp_hw.h  |  141 +
 drivers/net/rnp/base/rnp_mac.c |  480 +++
 drivers/net/rnp/base/rnp_mac.h |   36 +
 drivers/net/rnp/base/rnp_mac_

[PATCH v17 03/29] net/rnp: add log

[Wenbo Cao]

add log function for trace or debug

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp_ethdev.c |  2 ++
 drivers/net/rnp/rnp_logs.h   | 36 
 2 files changed, 38 insertions(+)
 create mode 100644 drivers/net/rnp/rnp_logs.h

diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index e2eb80ba69..7fe93edcf6 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -64,6 +64,8 @@ static struct rte_pci_driver rte_rnp_pmd = {
.remove = rnp_pci_remove,
 };
 
+RTE_LOG_REGISTER_SUFFIX(rnp_init_logtype, init, NOTICE);
+
 RTE_PMD_REGISTER_PCI(net_rnp, rte_rnp_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(net_rnp, pci_id_rnp_map);
 RTE_PMD_REGISTER_KMOD_DEP(net_rnp, "igb_uio | uio_pci_generic | vfio-pci");
diff --git a/drivers/net/rnp/rnp_logs.h b/drivers/net/rnp/rnp_logs.h
new file mode 100644
index 00..c68a5c1028
--- /dev/null
+++ b/drivers/net/rnp/rnp_logs.h
@@ -0,0 +1,36 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+
+#ifndef __RNP_LOGS_H__
+#define __RNP_LOGS_H__
+
+#include 
+
+extern int rnp_init_logtype;
+#define RTE_LOGTYPE_RNP_INIT rnp_init_logtype
+#define RNP_PMD_INIT_LOG(level, ...) \
+   RTE_LOG_LINE_PREFIX(level, RNP_INIT, "%s(): ", __func__,  __VA_ARGS__)
+#define PMD_INIT_FUNC_TRACE() RNP_PMD_INIT_LOG(DEBUG, " >>")
+#define RNP_PMD_DRV_LOG(level, ...) \
+   RTE_LOG_LINE_PREFIX(level, RNP_INIT, \
+   "%s(): ", __func__, __VA_ARGS__)
+#define RNP_PMD_LOG(level, ...) \
+   RTE_LOG_LINE_PREFIX(level, RNP_INIT, \
+   "rnp_net: (%d) ", __LINE__, __VA_ARGS__)
+#define RNP_PMD_ERR(fmt, ...) \
+   RNP_PMD_LOG(ERR, fmt, ## __VA_ARGS__)
+#define RNP_PMD_WARN(fmt, ...) \
+   RNP_PMD_LOG(WARNING, fmt, ## __VA_ARGS__)
+#define RNP_PMD_INFO(fmt, ...) \
+   RNP_PMD_LOG(INFO, fmt, ## __VA_ARGS__)
+
+#ifdef RTE_LIBRTE_RNP_REG_DEBUG
+#define RNP_PMD_REG_LOG(level, ...) \
+   RTE_LOG_LINE_PREFIX(level, RNP_INIT, \
+   "%s(): ", __func__, __VA_ARGS__)
+#else
+#define RNP_PMD_REG_LOG(...) do { } while (0)
+#endif
+
+#endif /* __RNP_LOGS_H__ */
-- 
2.25.1