Re: [PATCH v4 6/6] lib/vhost: remove check around pthread_mutex_init()

[Maxime Coquelin]

On 1/14/25 8:50 AM, Ariel Otilibili wrote:

pthread_mutex_init always returns 0. The other mutex functions
return 0 on success and a non-zero error code on error.


Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Cc: Maxime Coquelin 
Cc: Chenbo Xia 
Signed-off-by: Ariel Otilibili 
Acked-by: Stephen Hemminger 
---
  lib/vhost/socket.c | 14 ++
  1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
index d29d15494c8e..531aa8adc06c 100644
--- a/lib/vhost/socket.c
+++ b/lib/vhost/socket.c
@@ -498,11 +498,7 @@ vhost_user_reconnect_init(void)
  {
int ret;
  
-	ret = pthread_mutex_init(&reconn_list.mutex, NULL);

-   if (ret < 0) {
-   VHOST_CONFIG_LOG("thread", ERR, "%s: failed to initialize 
mutex", __func__);
-   return ret;
-   }
+   pthread_mutex_init(&reconn_list.mutex, NULL);
TAILQ_INIT(&reconn_list.head);
  
  	ret = rte_thread_create_internal_control(&reconn_tid, "vhost-reco",

@@ -921,11 +917,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
goto out;
}
TAILQ_INIT(&vsocket->conn_list);
-   ret = pthread_mutex_init(&vsocket->conn_mutex, NULL);
-   if (ret) {
-   VHOST_CONFIG_LOG(path, ERR, "failed to init connection mutex");
-   goto out_free;
-   }
+   pthread_mutex_init(&vsocket->conn_mutex, NULL);
  
  	if (!strncmp("/dev/vduse/", path, strlen("/dev/vduse/")))

vsocket->is_vduse = true;
@@ -1034,8 +1026,6 @@ rte_vhost_driver_register(const char *path, uint64_t 
flags)
if (pthread_mutex_destroy(&vsocket->conn_mutex)) {
VHOST_CONFIG_LOG(path, ERR, "failed to destroy connection 
mutex");
}
-out_free:
-   vhost_user_socket_mem_free(vsocket);
  out:
pthread_mutex_unlock(&vhost_user.mutex);
  


Reviewed-by: Maxime Coquelin 

Thanks,
Maxime

Re: [EXTERNAL] [PATCH v6 0/4] add feature arc in rte_graph

[Nitin Saxena]

Hi,

As discussed on slack, please find details of meeting  for feature arc
discussion

==
Date and time: 16th Jan 2025 (Thursday) 12:00 PM (UTC + 1)

Join Zoom Meeting
Password:
267382

Meeting URL:
https://marvell.zoom.us/j/97204271800?pwd=qR8Tc5WawaYdw8CTP2DK6bA4EEXR2J.1&from=addon

Join by Telephone
Dial: +1 669 900 6833 (US Toll) or +1 689 278 1000 (US Toll)

Meeting ID: 972 0427 1800

Password: 267382

International and Toll Free Numbers
Join from a Video Conference Room
Marvell:
>From Touchpad, tap Join Zoom button. When prompted, enter Meeting ID
and Password

China sites: Dial * then 972 0427 1800
External: Dial 97204271...@zoomcrc.com
OR:
Dial 144.195.19.161 (US West), enter 972 0427 1800 and # when
prompted. International H323 IP addresses
==

Thanks,
Nitin

On Fri, Jan 10, 2025 at 7:29 PM Robin Jarry  wrote:
>
> Nitin Saxena, Jan 03, 2025 at 15:41:
> > Hi,
> >
> > Please find attached slides explaining feature arc concept and its
> > usage in graph library
> >
> > I can also present these slides to community to facilitate this patch
> > series review process
>
> Hi Nitin,
>
> thanks for taking the time to explain your design better.
>
> I would really like to have a video meeting to really understand what
> problem you are trying to solve. And how it could help the grout code
> base.
>
> Let me know how what you think.
>
> Cheers
>

Re: [PATCH v3 0/6] remove check around pthread_mutex_init()

[Ariel Otilibili-Anieli]

Hi Stephen,

On Monday, January 13, 2025 20:11 CET, Stephen Hemminger 
 wrote:

> On Sun, 12 Jan 2025 21:20:15 +0100
> Ariel Otilibili  wrote:
> 
> 
> 
> LGTM
> Series-Acked-by: Stephen Hemminger 
Thanks for having looked into the series. Herewith a new version, I addressed 
your feedback,
https://inbox.dpdk.org/dev/20250114075033.2027286-1-otili...@eurecom.fr/

RE: questions about pinned external buffers

[Slava Ovsiienko]

Hi, Morten

> Question 1:
> Please confirm that the mbuf's pinned external buffer's refcnt is supposed to
> be 1 when an mbuf is returned to the mempool?
...
> + rte_mbuf_ext_refcnt_read(m->shinfo) == 1)));
I think we can add this extra check and neglect the light performance impact in 
debug version.

> Question 2:
> Could this assertion be moved to __rte_mbuf_raw_sanity_check()?
Looks like it could, but we should be careful about side effects in 
__rte_mbuf_raw_sanity_check(), it is exposed in rte_mbuf.h to users
(also as legacy MBUF_RAW_ALLOC_CHECK). But I have no strong objections.


With best regards,
Slava

> -Original Message-
> From: Morten Brørup 
> Sent: Thursday, January 9, 2025 2:12 PM
> To: Shahaf Shuler ; Slava Ovsiienko
> ; dev@dpdk.org
> Cc: Olivier Matz ; NBU-Contact-Thomas Monjalon
> (EXTERNAL) 
> Subject: questions about pinned external buffers
> 
> Pinned external buffers were introduced with this patch:
> https://git.dpdk.org/dpdk/commit/lib/librte_mbuf/rte_mbuf.h?id=6ef1107ad4
> c6d4fcb6be627367ee0b97bb13e822
> 
> Question 1:
> Please confirm that the mbuf's pinned external buffer's refcnt is supposed to
> be 1 when an mbuf is returned to the mempool?
> 
> If so, the below assertion should be updated for completion:
> 
> rte_mbuf_raw_free(struct rte_mbuf *m)
> {
>   RTE_ASSERT(!RTE_MBUF_CLONED(m) &&
> - (!RTE_MBUF_HAS_EXTBUF(m) ||
> RTE_MBUF_HAS_PINNED_EXTBUF(m)));
> + (!RTE_MBUF_HAS_EXTBUF(m) ||
> + (RTE_MBUF_HAS_PINNED_EXTBUF(m) &&
> + rte_mbuf_ext_refcnt_read(m->shinfo) == 1)));
>   __rte_mbuf_raw_sanity_check(m);
>   rte_mempool_put(m->pool, m);
> }
> 
> The increased performance cost should be acceptable for debug builds (i.e.
> with assertions enabled).
> 
> Question 2:
> Could this assertion be moved to __rte_mbuf_raw_sanity_check()?
> 
> I'm working on a new rte_mbuf_raw_free_bulk() function, for use with
> RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE; and if the assertion is not moved
> to __rte_mbuf_raw_sanity_check(), it needs to be copy-pasted into the new
> raw_free_bulk() function too.

Re: [PATCH v5 00/15] XSC PMD for Yunsilicon NICs

[WanRenyong]

Dear Maintainers,

I wanted to follow up this patch series that I submitted a week ago. It 
is currently listed as being in an 'under review' status on the patch 
worker. A week has now passed, and I have not received any feedback
May I kindly ask if there is any additional information or clarification 
that I need to provide to facilitate the review process?

Thank you very much for your time and consideration.

Best regards,
WanRenyong


On 2025/1/7 10:50, WanRenyong wrote:
> This xsc PMD (**librte_net_xsc**) provides poll mode driver for
> Yunsilicon metaScale serials NICs.
>
> Features:
> -
> - MTU update
> - TSO
> - RSS hash
> - RSS key update
> - RSS reta update
> - L3 checksum offload
> - L4 checksum offload
> - Inner L3 checksum
> - Inner L4 checksum
> - Basic stats
>
> Support NICs:
> -
> - metaScale-200S   Single QSFP56 Port 200GE SmartNIC
> - metaScale-200Quad QSFP28 Ports 100GE SmartNIC
> - metaScale-50 Dual QSFP28 Port 25GE SmartNIC
> - metaScale-100Q   Quad QSFP28 Port 25GE SmartNIC
>
> ---
>
> v5:
> * fix compilation errors.
> * fix coding style issue with misspelling.
> * remove some unnecessary parameter checks.
> * remove unnecessary call of rte_wmb.
> * Rearrange elements in structure to avoid holes.
>
> v4:
> * Based on the review comments from previous versions, reconstruct the xsc 
> PMD to eliminate
>the dependency on rdma core library and proprietary kernel driver, while 
> adding support for
>the vfio kernel driver.
>
> v3:
> * fix compilation errors
>
> v2:
> * fix checkpatch warnings and errors
>
> ---
> WanRenyong (15):
>net/xsc: add xsc PMD framework
>net/xsc: add xsc device initialization
>net/xsc: add xsc mailbox
>net/xsc: add xsc dev ops to support VFIO driver
>net/xsc: add PCT interfaces
>net/xsc: initialize xsc representors
>net/xsc: add ethdev configure and RSS ops
>net/xsc: add Rx and Tx queue setup
>net/xsc: add ethdev start
>net/xsc: add ethdev stop and close
>net/xsc: add ethdev Rx burst
>net/xsc: add ethdev Tx burst
>net/xsc: add basic stats ops
>net/xsc: add ethdev infos get
>net/xsc: add ethdev link and MTU ops
>
>   .mailmap   |   5 +
>   MAINTAINERS|  10 +
>   doc/guides/nics/features/xsc.ini   |  18 +
>   doc/guides/nics/index.rst  |   1 +
>   doc/guides/nics/xsc.rst|  31 +
>   doc/guides/rel_notes/release_25_03.rst |   4 +
>   drivers/net/meson.build|   1 +
>   drivers/net/xsc/meson.build|  17 +
>   drivers/net/xsc/xsc_cmd.h  | 387 +++
>   drivers/net/xsc/xsc_defs.h | 100 +++
>   drivers/net/xsc/xsc_dev.c  | 397 +++
>   drivers/net/xsc/xsc_dev.h  | 184 +
>   drivers/net/xsc/xsc_ethdev.c   | 918 +
>   drivers/net/xsc/xsc_ethdev.h   |  63 ++
>   drivers/net/xsc/xsc_log.h  |  24 +
>   drivers/net/xsc/xsc_np.c   | 492 +
>   drivers/net/xsc/xsc_np.h   | 154 +
>   drivers/net/xsc/xsc_rx.c   | 512 ++
>   drivers/net/xsc/xsc_rx.h   |  65 ++
>   drivers/net/xsc/xsc_rxtx.h | 191 +
>   drivers/net/xsc/xsc_tx.c   | 354 ++
>   drivers/net/xsc/xsc_tx.h   |  62 ++
>   drivers/net/xsc/xsc_vfio.c | 746 
>   drivers/net/xsc/xsc_vfio_mbox.c| 691 +++
>   drivers/net/xsc/xsc_vfio_mbox.h| 142 
>   25 files changed, 5569 insertions(+)
>   create mode 100644 doc/guides/nics/features/xsc.ini
>   create mode 100644 doc/guides/nics/xsc.rst
>   create mode 100644 drivers/net/xsc/meson.build
>   create mode 100644 drivers/net/xsc/xsc_cmd.h
>   create mode 100644 drivers/net/xsc/xsc_defs.h
>   create mode 100644 drivers/net/xsc/xsc_dev.c
>   create mode 100644 drivers/net/xsc/xsc_dev.h
>   create mode 100644 drivers/net/xsc/xsc_ethdev.c
>   create mode 100644 drivers/net/xsc/xsc_ethdev.h
>   create mode 100644 drivers/net/xsc/xsc_log.h
>   create mode 100644 drivers/net/xsc/xsc_np.c
>   create mode 100644 drivers/net/xsc/xsc_np.h
>   create mode 100644 drivers/net/xsc/xsc_rx.c
>   create mode 100644 drivers/net/xsc/xsc_rx.h
>   create mode 100644 drivers/net/xsc/xsc_rxtx.h
>   create mode 100644 drivers/net/xsc/xsc_tx.c
>   create mode 100644 drivers/net/xsc/xsc_tx.h
>   create mode 100644 drivers/net/xsc/xsc_vfio.c
>   create mode 100644 drivers/net/xsc/xsc_vfio_mbox.c
>   create mode 100644 drivers/net/xsc/xsc_vfio_mbox.h
>


-- 
Thanks,
WanRenyong

Re: [PATCH] examples/l3fwd: add option to set refetch offset

[huangdengdui]

On 2025/1/11 1:20, Stephen Hemminger wrote:
> This will make it slower for many platforms.
> GCC will unroll a loop of fixed small size, which is what we want.

Do you mean to replace option with a macro?
But most of prefetch_offset are used with the nb_rx, So using macros is the 
same as using options.

const int32_t k = RTE_ALIGN_FLOOR(nb_rx, FWDSTEP);
for (j = 0; j != k; j += FWDSTEP) {
for (i = 0, pos = j + prefetch_offset;
 i < FWDSTEP && pos < k; i++, pos++)
rte_prefetch0(rte_pktmbuf_mtod(pkts_burst[pos], void *));
processx4_step1(&pkts_burst[j], &dip, &ipv4_flag);
processx4_step2(qconf, dip, ipv4_flag, portid,
&pkts_burst[j], &dst_port[j]);
if (do_step3)
processx4_step3(&pkts_burst[j], &dst_port[j]);
}

The option can dynamically adjust the prefetch window, which makes it easier to 
find the prefetch window for a HW platform.
So I think it's better to use option.

Re: [PATCH] examples/l3fwd: add option to set refetch offset

[huangdengdui]

On 2025/1/11 1:19, Stephen Hemminger wrote:
> On Fri, 10 Jan 2025 17:37:15 +0800
> Dengdui Huang  wrote:
> 
>> +#define DEFAULT_PREFECH_OFFSET 4
> 
> Spelling

I made a mistake. I'll fix it for the next version.

Re: [PATCH v1 2/2] ethdev: fix skip valid port in probing callback

[Thomas Monjalon]

14/01/2025 02:50, lihuisong (C):
> 在 2025/1/13 21:14, Thomas Monjalon 写道:
> > 13/01/2025 13:47, lihuisong (C):
> >> 在 2025/1/13 20:30, Thomas Monjalon 写道:
> >>> 13/01/2025 13:05, lihuisong (C):
>  在 2025/1/13 19:23, lihuisong (C) 写道:
> > 在 2025/1/13 18:57, Thomas Monjalon 写道:
> >> 13/01/2025 10:35, lihuisong (C):
> >>> 在 2025/1/13 16:16, Thomas Monjalon 写道:
>  13/01/2025 03:55, Huisong Li:
> > The event callback in application may use the macro
> > RTE_ETH_FOREACH_DEV to
> > iterate over all enabled ports to do something(like, verifying the
> > port id
> > validity) when receive a probing event. If the ethdev state of a
> > port is
> > not RTE_ETH_DEV_UNUSED, this port will be considered as a valid 
> > port.
> >
> > However, this state is set to RTE_ETH_DEV_ATTACHED after pushing
> > probing
> > event. It means that probing callback will skip this port. But this
> > assignment can not move to front of probing notification. See
> > commit be8cd210379a ("ethdev: fix port probing notification")
> >
> > So this patch has to add a new state, RTE_ETH_DEV_ALLOCATED. Set
> > the ethdev
> > state to RTE_ETH_DEV_ALLOCATED before pushing probing event and
> > set it to
> > RTE_ETH_DEV_ATTACHED after definitely probed. And this port is
> > valid if its
> > device state is 'ALLOCATED' or 'ATTACHED'.
>  If you do that, changing the definition of eth_dev_find_free_port()
>  you allow the application using a port before probing is finished.
> >>> Yes, it's not reasonable.
> >>>
> >>> Thinking your comment twice, I feel that the root cause of this
> >>> issue is
> >>> application want to check if the port id is valid.
> >>> However, application just receive the new event from the device and 
> >>> the
> >>> port id of this device must be valid when report new event.
> >>> So application can think the received new event is valid and don't 
> >>> need
> >>> to check, right?
> >> Yes
> >> Do you think it should be highlighted in the API doc?
> > Security detection is common and always good for application.
> > So I think it's better to highlight that in doc.
> >
>  Now I remember why I have to put this patch into the patchset [1] that
>  testpmd support multiple process attach and detach port.
>  Becase patch 4/5 in this series depands on this patch.
>  The setup_attached_port() have to move to eth_event_callback() in
>  testpmd to update something.
>  And the setup_attached_port() would indirectyly check if this port is
>  valid by rte_eth_dev_is_valid_port().
>  Their caller stack is as follows:
>  eth_event_callback
> -->setup_attached_port
> -->rte_eth_dev_socket_id
> -->rte_eth_dev_is_valid_port
> 
> From the testpmd's modification, that is to say, it is possible for
>  appllication to call some APIs like rte_eth_dev_socket_id() and
>  indirectyly check if this port id is valid in event new callback.
>  So should we add this patch? I think there are many like these API in
>  ethdev layer. I'm confused a bit now.
> >>> Yes rte_eth_dev_is_valid_port() is used in many API functions,
> >>> so that's a valid concern.
> >>> I would say we should not call much of these functions in the "new port"
> >>> event callback.
> >>> But the case of rte_eth_dev_socket_id() is concerning.
> >>>
> >>> I suggest to update rte_eth_dev_socket_id() to make it work with
> >>> a newly allocated port.
> >>> I suppose we can use the function eth_dev_is_allocated().
> >> What you mean is doing it like the following code?
> >> -->
> >>
> >> --- a/lib/ethdev/rte_ethdev.c
> >> +++ b/lib/ethdev/rte_ethdev.c
> >> @@ -635,8 +635,10 @@ int
> >>rte_eth_dev_socket_id(uint16_t port_id)
> >>{
> >>   int socket_id = SOCKET_ID_ANY;
> >> +   struct rte_eth_dev *ethdev;
> >>
> >> -   if (!rte_eth_dev_is_valid_port(port_id)) {
> >> +   ethdev = &rte_eth_devices[port_id];
> >> +   if (!eth_dev_is_allocated(ethdev)) {
> >>   rte_errno = EINVAL;
> >>   } else {
> >>   socket_id = rte_eth_devices[port_id].data->numa_node;
> >
> > Yes. Would it work?
> I think it can work for this API.
> 
>  From the disscussion for this patch, we've come to an aggreement that 
> application can think port is valid in new event.

We don't want an application to configure a port before probing is finished
(like still in the event processing).

> Now that the port id is valid, the new event callback of application may 
> call other API, for example, rte_eth_dev_info_get().
> (Apllication may call rte_eth_dev_info_get to get someting in new event 
> callback)
> Note: patch 4/5 modified in the series[1] also used this API.
> -->
> et

Re: [PATCH] app/testpmd: add ipv6 extension header parse

[Thomas Monjalon]

14/01/2025 03:05, Jie Hai:
> Hi, Stephen Hemminger,
> 
> On 2025/1/9 1:02, Stephen Hemminger wrote:
> > On Wed, 8 Jan 2025 10:46:32 +0800
> > Jie Hai  wrote:
> > 
> >> From: Jie Hai 
> >> To: , , , Aman 
> >> Singh  
> >> CC: , , 
> >> ,  
> >> Subject: [PATCH] app/testpmd: add ipv6 extension header parse
> >> Date: Wed, 8 Jan 2025 10:46:32 +0800
> >> X-Mailer: git-send-email 2.22.0
> >>
> >> This patch support parse ipv6 extension header, and
> >> support TSO for ipv6tcp packets with extension header.
> >>
> >> Signed-off-by: Jie Hai 
> >> ---
> >>   app/test-pmd/csumonly.c | 47 -
> >>   1 file changed, 46 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
> >> index 2246c22e8e56..a7b11490fe27 100644
> >> --- a/app/test-pmd/csumonly.c
> >> +++ b/app/test-pmd/csumonly.c
> >> @@ -124,14 +124,59 @@ parse_ipv4(struct rte_ipv4_hdr *ipv4_hdr, struct 
> >> testpmd_offload_info *info)
> >>info->l4_len = 0;
> >>   }
> >>   
> >> +static uint16_t
> >> +parse_ipv6_ext(struct rte_ipv6_hdr *ipv6_hdr, uint32_t *off)
> >> +{
> >> +  struct ext_hdr {
> >> +  uint8_t next_hdr;
> >> +  uint8_t len;
> >> +  };
> >> +  struct ext_hdr *xh;
> >> +  uint16_t proto;
> >> +  char *xh_fst;
> >> +  uint16_t i;
> >> +
> >> +  proto = ipv6_hdr->proto;
> >> +  xh_fst = (char *)ipv6_hdr + sizeof(*ipv6_hdr);
> >> +#define MAX_EXT_HDRS 9
> >> +  for (i = 0; i < MAX_EXT_HDRS; i++) {
> >> +  switch (proto) {
> >> +  case IPPROTO_HOPOPTS:
> >> +  case IPPROTO_ROUTING:
> >> +  case IPPROTO_DSTOPTS:
> >> +  xh = (struct ext_hdr *)(xh_fst + *off);
> >> +  *off += (xh->len + 1) * 8;
> >> +  proto = xh->next_hdr;
> >> +  break;
> >> +  case IPPROTO_AH:
> >> +  xh = (struct ext_hdr *)(xh_fst + *off);
> >> +  *off += (xh->len + 2) * 4;
> >> +  proto = xh->next_hdr;
> >> +  break;
> >> +  case IPPROTO_FRAGMENT:
> >> +  xh = (struct ext_hdr *)(xh_fst + *off);
> >> +  *off += 8;
> >> +  proto = xh->next_hdr;
> >> +  return proto; /* this is always the last ext hdr */
> >> +  case IPPROTO_NONE:
> >> +  return proto;
> >> +  default:
> >> +  return proto;
> >> +  }
> >> +  }
> >> +  return proto;
> >> +}
> >> +
> > 
> > Why copy/paste of rte_net_skip_ip6_ext, why not use that?
> > Having two copies of same codes means that bugs need to be fixed in two 
> > places later.
> > .
> Thanks for your review.
> 
> rte_net_skip_ip6_ext uses mbuf as a parameter, but its upper-layer
> function does not pass this parameter, and it is difficult to deduce the
> mbuf address. It would also be strange to pass only the mbuf address and
> not use it.
> 
> My idea is to replace the packet identification in csum fwd with
> 'rte_net_get_ptype()'. In this case, 'rte_net_get_ptype' needs to be 
> updated to adapt to the packet types supported by csum fwd. This may
> affect the ptype of packets identified by the current software.
> I'm not sure how big the impact is, which is why I didn't use it.
> 
> Maybe I can send it out later for review.

The only thing I'm sure is that testpmd is a test application,
so it should reuse the functions from the libs.
It should not reinvent new functions for network parsing.

If you need to add a new function to the library, please do it.
You can probably move the content of rte_net_skip_ip6_ext()
in a new function in the file lib/net/rte_ip6.h.
Something similar to rte_ipv6_get_next_ext().

Re: [PATCH v1 2/2] ethdev: fix skip valid port in probing callback

[Thomas Monjalon]

14/01/2025 13:13, lihuisong (C):
> 在 2025/1/14 19:13, Thomas Monjalon 写道:
> > As explained above, we should not do allow much API from RTE_ETH_EVENT_NEW.
> > rte_eth_dev_socket_id() is reasonnable.
> > Functions rte_eth_dev_owner_*() are fine.
> > Others functions should be called only after probing.
> 
> All right, will fix it in new patch set.
> And I'll also add these comments like above you said for RTE_ETH_EVENT_NEW.

Thank you

[PATCH] net/i40e/base: fix the debug print format

[Zhichao Zeng]

This patch modifies format specifier in debug prints to match to the
change of time variables from 64 bit to 32 bit.

Fixes: d980a401b137 ("net/i40e/base: add NVM acquire with custom timeout")
Fixes: ba90329a5eb3 ("net/i40e/base: fix invalid log format characters")
Cc: sta...@dpdk.org

Signed-off-by: Jaroslaw Ilgiewicz 
Signed-off-by: Zhichao Zeng 
---
 drivers/net/i40e/base/i40e_nvm.c | 14 ++
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c
index 3e16a0d997..5ece2ebf55 100644
--- a/drivers/net/i40e/base/i40e_nvm.c
+++ b/drivers/net/i40e/base/i40e_nvm.c
@@ -79,7 +79,7 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *hw,
 
if (ret_code)
i40e_debug(hw, I40E_DEBUG_NVM,
-  "NVM acquire type %d failed time_left=%" PRIu32 " 
ret=%d aq_err=%d\n",
+  "NVM acquire type %d failed time_left=%u ret=%d 
aq_err=%d\n",
   access, time_left, ret_code, hw->aq.asq_last_status);
 
if (ret_code && time_left) {
@@ -101,7 +101,7 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *hw,
if (ret_code != I40E_SUCCESS) {
hw->nvm.hw_semaphore_timeout = 0;
i40e_debug(hw, I40E_DEBUG_NVM,
-  "NVM acquire timed out, wait %" PRIu32 " ms 
before trying again. status=%d aq_err=%d\n",
+  "NVM acquire timed out, wait %u ms before 
trying again. status=%d aq_err=%d\n",
   time_left, ret_code, hw->aq.asq_last_status);
}
}
@@ -145,9 +145,8 @@ enum i40e_status_code i40e_acquire_nvm_ex(struct i40e_hw 
*hw,
 
if (ret_code)
i40e_debug(hw, I40E_DEBUG_NVM,
-  "NVM acquire type %d failed time_left=%llu ret=%d 
aq_err=%d\n",
-  access, (unsigned long long)time_left, ret_code,
-  hw->aq.asq_last_status);
+  "NVM acquire type %d failed time_left=%u ret=%d 
aq_err=%d\n",
+  access, time_left, ret_code, hw->aq.asq_last_status);
 
if (ret_code && time_left) {
/* Poll until the current NVM owner timeouts */
@@ -168,9 +167,8 @@ enum i40e_status_code i40e_acquire_nvm_ex(struct i40e_hw 
*hw,
if (ret_code != I40E_SUCCESS) {
hw->nvm.hw_semaphore_timeout = 0;
i40e_debug(hw, I40E_DEBUG_NVM,
-  "NVM acquire timed out, wait %llu ms before 
trying again. status=%d aq_err=%d\n",
-  (unsigned long long)time_left, ret_code,
-  hw->aq.asq_last_status);
+  "NVM acquire timed out, wait %u ms before 
trying again. status=%d aq_err=%d\n",
+  time_left, ret_code, hw->aq.asq_last_status);
}
}
 
-- 
2.34.1

[PATCH v2] ring: add the second version of the RTS interface

[Huichao Cai]

Hi Konstantin, thank you very much for your question!

I have modified the __rte_ring_rts_v2_update_tail function(See at the 
bottom)and it works properly when
using your test command in my local environment(KVM). The local environment 
parameters are as follows:
Architecture:x86_64
  CPU op-mode(s):32-bit, 64-bit
  Address sizes: 46 bits physical, 57 bits virtual
  Byte Order:Little Endian
CPU(s):  8
  On-line CPU(s) list:   0-7
NUMA:
  NUMA node(s):  1
  NUMA node0 CPU(s): 0-7

I have roughly looked at the code of the SORING patch, and my patch's update 
logic
for tail is similar to the __rte_soring_stage_finalize function. Update the 
tail as soon as possible.

Tail update logic explanation:
Assuming there are three deqs/enqs simultaneously deq/enq. The order of 
completion for
deq/enq is first, second, and third deqs/enqs.
RTS: The tail will only be updated after the third deqs/enqs completes it.
RTS_V2: After each deqs/enqs completes it, the tail will be updated.

I have tested it multiple times and found that the performance comparison 
between RTS
and RTS_V2 test results is not fixed, each with its own strengths and 
weaknesses, as shown
in the following two test results. So I'm not sure if this patch can truly 
improve performance,
maybe useful for certain scenarios?

Here are two stress tests comparing the results of RTS and RTS_V2 tests:
=test 1=
[root@localhost ~]# echo ring_stress_autotest  | 
/opt/build-dpdk-release/app/dpdk-test --lcores "(2-7)@(3-5)" -n 8 --no-pci 
--no-huge
EAL: Detected CPU lcores: 8
EAL: Detected NUMA nodes: 1
EAL: Static memory layout is selected, amount of reserved memory can be 
adjusted with -m or --socket-mem
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
APP: HPET is not enabled, using TSC as default timer
RTE>>ring_stress_autotest
TEST-CASE MT_RTS MT-WRK_ENQ_DEQ-MST_NONE-PRCS START
lcore_stat_dump(AGGREGATE)={
nb_cycle=168020391844(60007282.80 usec),
DEQ+ENQ={
nb_call=87964158,
nb_obj=3122632083,
nb_cycle=357901041584,
obj/call(avg): 35.50
cycles/obj(avg): 114.62
cycles/call(avg): 4068.71
max cycles/call=226802256(81000.81 usec),
min cycles/call=288(0.10 usec),
},
};
TEST-CASE MT_RTS MT-WRK_ENQ_DEQ-MST_NONE-PRCS OK
TEST-CASE MT_RTS MT-WRK_ENQ_DEQ-MST_NONE-AVG START
lcore_stat_dump(AGGREGATE)={
nb_cycle=168039915096(60014255.39 usec),
DEQ+ENQ={
nb_call=92846537,
nb_obj=3296030996,
nb_cycle=840090079114,
obj/call(avg): 35.50
cycles/obj(avg): 254.88
cycles/call(avg): 9048.16
},
};
TEST-CASE MT_RTS MT-WRK_ENQ_DEQ-MST_NONE-AVG OK
TEST-CASE MT_RTS_V2 MT-WRK_ENQ_DEQ-MST_NONE-PRCS START
lcore_stat_dump(AGGREGATE)={
nb_cycle=168006214342(60002219.41 usec),
DEQ+ENQ={
nb_call=83543881,
nb_obj=2965835220,
nb_cycle=389465266530,
obj/call(avg): 35.50
cycles/obj(avg): 131.32
cycles/call(avg): 4661.80
max cycles/call=123210780(44003.85 usec),
min cycles/call=298(0.11 usec),
},
};
TEST-CASE MT_RTS_V2 MT-WRK_ENQ_DEQ-MST_NONE-PRCS OK
TEST-CASE MT_RTS_V2 MT-WRK_ENQ_DEQ-MST_NONE-AVG START
lcore_stat_dump(AGGREGATE)={
nb_cycle=16836710(6013.11 usec),
DEQ+ENQ={
nb_call=89759571,
nb_obj=3186412623,
nb_cycle=839986422120,
obj/call(avg): 35.50
cycles/obj(avg): 263.62
cycles/call(avg): 9358.18
},
};
TEST-CASE MT_RTS_V2 MT-WRK_ENQ_DEQ-MST_NONE-AVG OK
Number of tests:4
Success:4
Failed: 0
Test OK

=test 2=
[root@localhost ~]# echo ring_stress_autotest  | 
/opt/build-dpdk-release/app/dpdk-test --lcores "(2-7)@(3-5)" -n 8 --no-pci 
--no-huge
EAL: Detected CPU lcores: 8
EAL: Detected NUMA nodes: 1
EAL: Static memory layout is selected, amount of reserved memory can be 
adjusted with -m or --socket-mem
EAL: Detected static linkage of DPDK
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
APP: HPET is not enabled, using TSC as default timer
RTE>>ring_stress_autotest
TEST-CASE MT_RTS MT-WRK_ENQ_DEQ-MST_NONE-PRCS START
lcore_stat_dump(AGGREGATE)={
nb_cycle=168011911986(60004254.28 usec),
DEQ+ENQ={
nb_call=47315418,
nb_obj=1679700058,
nb_cycle=361351406016,
obj/call(avg): 35.50
cycles/obj(avg): 215.13
cycles/call(avg): 7637.08
max cycles/call=114663660(40951.31 usec

[PATCH 02/10] net/ixgbe/base: add interface for LED control on E610

[Yuan Wang]

From: Dawid Zielinski 

Add interface for sending ACI command for setting port
identification LED on E610.

Signed-off-by: Dawid Zielinski 
Signed-off-by: Yuan Wang 
---
 drivers/net/ixgbe/base/ixgbe_e610.c  | 29 
 drivers/net/ixgbe/base/ixgbe_e610.h  |  1 +
 drivers/net/ixgbe/base/ixgbe_type_e610.h | 15 
 3 files changed, 45 insertions(+)

diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c 
b/drivers/net/ixgbe/base/ixgbe_e610.c
index b0d55a2411..ee8614d3db 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.c
+++ b/drivers/net/ixgbe/base/ixgbe_e610.c
@@ -2004,6 +2004,35 @@ s32 ixgbe_aci_write_i2c(struct ixgbe_hw *hw,
return ixgbe_aci_send_cmd(hw, &desc, NULL, 0);
 }
 
+/**
+ * ixgbe_aci_set_port_id_led - set LED value for the given port
+ * @hw: pointer to the HW struct
+ * @orig_mode: set LED original mode
+ *
+ * Set LED value for the given port (0x06E9)
+ *
+ * Return: the exit code of the operation.
+ */
+s32 ixgbe_aci_set_port_id_led(struct ixgbe_hw *hw, bool orig_mode)
+{
+   struct ixgbe_aci_cmd_set_port_id_led *cmd;
+   struct ixgbe_aci_desc desc;
+
+   cmd = &desc.params.set_port_id_led;
+
+   ixgbe_fill_dflt_direct_cmd_desc(&desc, ixgbe_aci_opc_set_port_id_led);
+
+   cmd->lport_num = (u8)hw->bus.func;
+   cmd->lport_num_valid = IXGBE_ACI_PORT_ID_PORT_NUM_VALID;
+
+   if (orig_mode)
+   cmd->ident_mode = IXGBE_ACI_PORT_IDENT_LED_ORIG;
+   else
+   cmd->ident_mode = IXGBE_ACI_PORT_IDENT_LED_BLINK;
+
+   return ixgbe_aci_send_cmd(hw, &desc, NULL, 0);
+}
+
 /**
  * ixgbe_aci_set_gpio - set GPIO pin state
  * @hw: pointer to the hw struct
diff --git a/drivers/net/ixgbe/base/ixgbe_e610.h 
b/drivers/net/ixgbe/base/ixgbe_e610.h
index 4babee821e..716bb86303 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.h
+++ b/drivers/net/ixgbe/base/ixgbe_e610.h
@@ -61,6 +61,7 @@ s32 ixgbe_aci_read_i2c(struct ixgbe_hw *hw,
 s32 ixgbe_aci_write_i2c(struct ixgbe_hw *hw,
struct ixgbe_aci_cmd_link_topo_addr topo_addr,
u16 bus_addr, __le16 addr, u8 params, u8 *data);
+s32 ixgbe_aci_set_port_id_led(struct ixgbe_hw *hw, bool orig_mode);
 s32 ixgbe_aci_set_gpio(struct ixgbe_hw *hw, u16 gpio_ctrl_handle, u8 pin_idx,
   bool value);
 s32 ixgbe_aci_get_gpio(struct ixgbe_hw *hw, u16 gpio_ctrl_handle, u8 pin_idx,
diff --git a/drivers/net/ixgbe/base/ixgbe_type_e610.h 
b/drivers/net/ixgbe/base/ixgbe_type_e610.h
index bad332c6b8..4f09fcf3d5 100644
--- a/drivers/net/ixgbe/base/ixgbe_type_e610.h
+++ b/drivers/net/ixgbe/base/ixgbe_type_e610.h
@@ -477,6 +477,7 @@ enum ixgbe_aci_opc {
ixgbe_aci_opc_write_mdio= 0x06E5,
ixgbe_aci_opc_set_gpio_by_func  = 0x06E6,
ixgbe_aci_opc_get_gpio_by_func  = 0x06E7,
+   ixgbe_aci_opc_set_port_id_led   = 0x06E9,
ixgbe_aci_opc_set_gpio  = 0x06EC,
ixgbe_aci_opc_get_gpio  = 0x06ED,
ixgbe_aci_opc_sff_eeprom= 0x06EE,
@@ -1252,6 +1253,19 @@ struct ixgbe_aci_cmd_gpio_by_func {
 
 IXGBE_CHECK_PARAM_LEN(ixgbe_aci_cmd_gpio_by_func);
 
+/* Set Port Identification LED (direct, 0x06E9) */
+struct ixgbe_aci_cmd_set_port_id_led {
+   u8 lport_num;
+   u8 lport_num_valid;
+#define IXGBE_ACI_PORT_ID_PORT_NUM_VALID   BIT(0)
+   u8 ident_mode;
+#define IXGBE_ACI_PORT_IDENT_LED_BLINK BIT(0)
+#define IXGBE_ACI_PORT_IDENT_LED_ORIG  0
+   u8 rsvd[13];
+};
+
+IXGBE_CHECK_PARAM_LEN(ixgbe_aci_cmd_set_port_id_led);
+
 /* Set/Get GPIO (direct, 0x06EC/0x06ED) */
 struct ixgbe_aci_cmd_gpio {
__le16 gpio_ctrl_handle;
@@ -1854,6 +1868,7 @@ struct ixgbe_aci_desc {
struct ixgbe_aci_cmd_mdio read_write_mdio;
struct ixgbe_aci_cmd_mdio read_mdio;
struct ixgbe_aci_cmd_mdio write_mdio;
+   struct ixgbe_aci_cmd_set_port_id_led set_port_id_led;
struct ixgbe_aci_cmd_gpio_by_func read_write_gpio_by_func;
struct ixgbe_aci_cmd_gpio read_write_gpio;
struct ixgbe_aci_cmd_sff_eeprom read_write_sff_param;
-- 
2.43.5

[PATCH 01/10] net/ixgbe/base: fix TSAM checking return value

[Yuan Wang]

From: Lukasz Krakowiak 

The return value of ixgbe_get_fw_tsam_mode function may be a large integer
that does not match the desired bool type.

Fixes: 316637762a5f (net/ixgbe/base: enable E610 device)
Cc: sta...@dpdk.org

Signed-off-by: Lukasz Krakowiak 
Signed-off-by: Yuan Wang 
---
 drivers/net/ixgbe/base/ixgbe_api.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ixgbe/base/ixgbe_api.c 
b/drivers/net/ixgbe/base/ixgbe_api.c
index b4920867bc..670dd3 100644
--- a/drivers/net/ixgbe/base/ixgbe_api.c
+++ b/drivers/net/ixgbe/base/ixgbe_api.c
@@ -1168,8 +1168,9 @@ s32 ixgbe_set_fw_drv_ver(struct ixgbe_hw *hw, u8 maj, u8 
min, u8 build,
  */
 bool ixgbe_get_fw_tsam_mode(struct ixgbe_hw *hw)
 {
-   return ixgbe_call_func(hw, hw->mac.ops.get_fw_tsam_mode, (hw),
-  IXGBE_NOT_IMPLEMENTED);
+   if (hw->mac.ops.get_fw_tsam_mode)
+   return hw->mac.ops.get_fw_tsam_mode(hw);
+   return false;
 }
 
 /**
-- 
2.43.5

[PATCH 00/10] update net/ixgbe base driver

[Yuan Wang]

Update the ixgbe driver to the lastest version of the snapshot.

Dan Nowlin (1):
  net/ixgbe/base: add missing buffer copy

Dawid Zielinski (2):
  net/ixgbe/base: add interface for LED control on E610
  net/ixgbe/base: Add capability for OROM recovery update

Karol Kolacinski (2):
  net/ixgbe/base: Add PTP by PHY feature for E610
  net/ixgbe/base: add max_drift_thresh to get_ptp_by_phy

Krzysztof Galazka (1):
  net/ixgbe/base: add definition of FW temp event for E610

Lukasz Krakowiak (1):
  net/ixgbe/base: fix TSAM checking return value

Piotr Kwapulinski (2):
  net/ixgbe/base: disable 2.5/5G speeds from auto-negotiation for E610
  net/ixgbe/base: update VF HV subsystem device ID constant

Yuan Wang (1):
  net/ixgbe: update base driver README

 drivers/net/ixgbe/base/README|   2 +-
 drivers/net/ixgbe/base/ixgbe_api.c   |   5 +-
 drivers/net/ixgbe/base/ixgbe_e610.c  | 127 ---
 drivers/net/ixgbe/base/ixgbe_e610.h  |   5 +
 drivers/net/ixgbe/base/ixgbe_type.h  |   2 +-
 drivers/net/ixgbe/base/ixgbe_type_e610.h |  95 +
 6 files changed, 220 insertions(+), 16 deletions(-)

-- 
2.43.5

[PATCH 04/10] net/ixgbe/base: Add PTP by PHY feature for E610

[Yuan Wang]

From: Karol Kolacinski 

Add "Set PTP by PHY" (0x0634) ACI command.
Add a new PTP by PHY capability (0x0097).
This command allows configuring PTP timestamping on PHY or MAC.

Add 2 PTP by PHY registers:
PROXY_TX_TS (XGMII_SPARE_REG[0])
PROXY_STS (XGMII_SPARE_REG[1])

Signed-off-by: Karol Kolacinski 
Signed-off-by: Yuan Wang 
---
 drivers/net/ixgbe/base/ixgbe_e610.c  | 56 
 drivers/net/ixgbe/base/ixgbe_e610.h  |  3 ++
 drivers/net/ixgbe/base/ixgbe_type_e610.h | 52 ++
 3 files changed, 111 insertions(+)

diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c 
b/drivers/net/ixgbe/base/ixgbe_e610.c
index a7d642887f..5124b18f59 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.c
+++ b/drivers/net/ixgbe/base/ixgbe_e610.c
@@ -747,6 +747,11 @@ ixgbe_parse_common_caps(struct ixgbe_hw *hw, struct 
ixgbe_hw_common_caps *caps,
DEBUGOUT2("%s: next_cluster_id_support = %d\n",
  prefix, caps->next_cluster_id_support);
break;
+   case IXGBE_ACI_CAPS_PTP_BY_PHY:
+   caps->ptp_by_phy_support = (number == 1);
+   DEBUGOUT2("%s: ptp_by_phy_support = %d\n", prefix,
+ caps->ptp_by_phy_support);
+   break;
default:
/* Not one of the recognized common capabilities */
found = false;
@@ -1797,6 +1802,57 @@ s32 ixgbe_configure_lse(struct ixgbe_hw *hw, bool 
activate, u16 mask)
return IXGBE_SUCCESS;
 }
 
+/**
+ * ixgbe_set_ptp_by_phy - Set PTP timestamping by PHY
+ * @hw: pointer to the HW struct
+ * @ptp_request: timestamp mode request
+ * @flags: timestamp mode flags
+ *
+ * Set PTP by PHY using ACI command (0x0634).
+ *
+ * Return: 0 on success, negative error code otherwise
+ */
+s32 ixgbe_set_ptp_by_phy(struct ixgbe_hw *hw, u8 ptp_request, u8 flags)
+{
+   struct ixgbe_aci_cmd_set_ptp_by_phy *cmd;
+   struct ixgbe_aci_desc desc;
+
+   ixgbe_fill_dflt_direct_cmd_desc(&desc, ixgbe_aci_opc_set_ptp_by_phy);
+   cmd = &desc.params.set_ptp_by_phy;
+   cmd->ptp_request = ptp_request;
+   cmd->flags = flags;
+
+   return ixgbe_aci_send_cmd(hw, &desc, NULL, 0);
+}
+
+/**
+ * ixgbe_get_ptp_by_phy - Get PTP timestamping by PHY
+ * @hw: pointer to the HW struct
+ * @ptp_config: timestamp mode config
+ * @flags: timestamp mode flags
+ *
+ * Get PTP by PHY using ACI command (0x0635).
+ *
+ * Return: 0 on success, negative error code otherwise
+ */
+s32 ixgbe_get_ptp_by_phy(struct ixgbe_hw *hw, u8 *ptp_config, u8 *flags)
+{
+   struct ixgbe_aci_cmd_get_ptp_by_phy_resp *resp;
+   struct ixgbe_aci_desc desc;
+   s32 status;
+
+   ixgbe_fill_dflt_direct_cmd_desc(&desc, ixgbe_aci_opc_get_ptp_by_phy);
+   resp = &desc.params.get_ptp_by_phy_resp;
+
+   status = ixgbe_aci_send_cmd(hw, &desc, NULL, 0);
+   if (!status) {
+   *ptp_config = resp->ptp_config;
+   *flags = resp->flags;
+   }
+
+   return status;
+}
+
 /**
  * ixgbe_aci_get_netlist_node - get a node handle
  * @hw: pointer to the hw struct
diff --git a/drivers/net/ixgbe/base/ixgbe_e610.h 
b/drivers/net/ixgbe/base/ixgbe_e610.h
index 716bb86303..ccf76e3b9b 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.h
+++ b/drivers/net/ixgbe/base/ixgbe_e610.h
@@ -47,6 +47,9 @@ s32 ixgbe_aci_get_link_info(struct ixgbe_hw *hw, bool ena_lse,
 s32 ixgbe_aci_set_event_mask(struct ixgbe_hw *hw, u8 port_num, u16 mask);
 s32 ixgbe_configure_lse(struct ixgbe_hw *hw, bool activate, u16 mask);
 
+s32 ixgbe_set_ptp_by_phy(struct ixgbe_hw *hw, u8 ptp_request, u8 flags);
+s32 ixgbe_get_ptp_by_phy(struct ixgbe_hw *hw, u8 *ptp_config, u8 *flags);
+
 s32 ixgbe_aci_get_netlist_node(struct ixgbe_hw *hw,
   struct ixgbe_aci_cmd_get_link_topo *cmd,
   u8 *node_part_number, u16 *node_handle);
diff --git a/drivers/net/ixgbe/base/ixgbe_type_e610.h 
b/drivers/net/ixgbe/base/ixgbe_type_e610.h
index 4f09fcf3d5..d0c34c8690 100644
--- a/drivers/net/ixgbe/base/ixgbe_type_e610.h
+++ b/drivers/net/ixgbe/base/ixgbe_type_e610.h
@@ -469,6 +469,8 @@ enum ixgbe_aci_opc {
ixgbe_aci_opc_restart_an= 0x0605,
ixgbe_aci_opc_get_link_status   = 0x0607,
ixgbe_aci_opc_set_event_mask= 0x0613,
+   ixgbe_aci_opc_set_ptp_by_phy= 0x0634,
+   ixgbe_aci_opc_get_ptp_by_phy= 0x0635,
ixgbe_aci_opc_get_link_topo = 0x06E0,
ixgbe_aci_opc_get_link_topo_pin = 0x06E1,
ixgbe_aci_opc_read_i2c  = 0x06E2,
@@ -697,6 +699,7 @@ struct ixgbe_aci_cmd_list_caps_elem {
 #define IXGBE_ACI_CAPS_EXT_TOPO_DEV_IMG2   0x0083
 #define IXGBE_ACI_CAPS_EXT_TOPO_DEV_IMG3   0x0084
 #define IXGBE_ACI_CAPS_NEXT_CLUSTER_ID 0x0096
+#define IXGBE_ACI_CAPS_PTP_BY_PHY  0x0097

[PATCH 03/10] net/ixgbe/base: disable 2.5/5G speeds from auto-negotiation for E610

[Yuan Wang]

From: Piotr Kwapulinski 

2.5 and 5 Gbps link speeds must be excluded from the auto-negotiation set
used during driver initialization due to compatibility issues with
certain switches. Those issues do not exist in case of E610 2.5G SKU
device (0x57b1).

Fixes: c6cb313da739 (net/ixgbe/base: add link management for E610)
Cc: sta...@dpdk.org

Signed-off-by: Piotr Kwapulinski 
Signed-off-by: Yuan Wang 
---
 drivers/net/ixgbe/base/ixgbe_e610.c | 35 +++--
 1 file changed, 23 insertions(+), 12 deletions(-)

diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c 
b/drivers/net/ixgbe/base/ixgbe_e610.c
index ee8614d3db..a7d642887f 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.c
+++ b/drivers/net/ixgbe/base/ixgbe_e610.c
@@ -4256,16 +4256,6 @@ s32 ixgbe_identify_phy_E610(struct ixgbe_hw *hw)
pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_1G_SGMII||
pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_1G_USXGMII)
hw->phy.speeds_supported |= IXGBE_LINK_SPEED_1GB_FULL;
-   if (pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_2500BASE_T   ||
-   pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_2500BASE_X   ||
-   pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_2500BASE_KX  ||
-   pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_2500M_SGMII ||
-   pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_2500M_USXGMII)
-   hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL;
-   if (pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_5GBASE_T  ||
-   pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_5GBASE_KR ||
-   pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_5G_USXGMII)
-   hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL;
if (pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_10GBASE_T   ||
pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_10G_SFI_DA  ||
pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_10GBASE_SR  ||
@@ -4276,10 +4266,31 @@ s32 ixgbe_identify_phy_E610(struct ixgbe_hw *hw)
pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_10G_USXGMII)
hw->phy.speeds_supported |= IXGBE_LINK_SPEED_10GB_FULL;
 
-   /* Initialize autoneg speeds */
-   if (!hw->phy.autoneg_advertised)
+   /* 2.5 and 5 Gbps link speeds must be excluded from the
+* auto-negotiation set used during driver initialization due to
+* compatibility issues with certain switches. Those issues do not
+* exist in case of E610 2.5G SKU device (0x57b1).
+*/
+   if (!hw->phy.autoneg_advertised &&
+   hw->device_id != IXGBE_DEV_ID_E610_2_5G_T)
hw->phy.autoneg_advertised = hw->phy.speeds_supported;
 
+   if (pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_2500BASE_T   ||
+   pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_2500BASE_X   ||
+   pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_2500BASE_KX  ||
+   pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_2500M_SGMII ||
+   pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_2500M_USXGMII)
+   hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL;
+
+   if (!hw->phy.autoneg_advertised &&
+   hw->device_id == IXGBE_DEV_ID_E610_2_5G_T)
+   hw->phy.autoneg_advertised = hw->phy.speeds_supported;
+
+   if (pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_5GBASE_T  ||
+   pcaps.phy_type_low  & IXGBE_PHY_TYPE_LOW_5GBASE_KR ||
+   pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_5G_USXGMII)
+   hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL;
+
/* Set PHY ID */
memcpy(&hw->phy.id, pcaps.phy_id_oui, sizeof(u32));
 
-- 
2.43.5

[PATCH 06/10] net/ixgbe/base: Add capability for OROM recovery update

[Yuan Wang]

From: Dawid Zielinski 

Added new capability informing about OROM recovery update.

Signed-off-by: Dawid Zielinski 
Signed-off-by: Yuan Wang 
---
 drivers/net/ixgbe/base/ixgbe_e610.c  | 3 +++
 drivers/net/ixgbe/base/ixgbe_type_e610.h | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c 
b/drivers/net/ixgbe/base/ixgbe_e610.c
index 5124b18f59..802dfb5062 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.c
+++ b/drivers/net/ixgbe/base/ixgbe_e610.c
@@ -741,6 +741,9 @@ ixgbe_parse_common_caps(struct ixgbe_hw *hw, struct 
ixgbe_hw_common_caps *caps,
(phys_id & IXGBE_EXT_TOPO_DEV_IMG_PROG_EN) != 0;
break;
}
+   case IXGBE_ACI_CAPS_OROM_RECOVERY_UPDATE:
+   caps->orom_recovery_update = (number == 1);
+   break;
 
case IXGBE_ACI_CAPS_NEXT_CLUSTER_ID:
caps->next_cluster_id_support = (number == 1);
diff --git a/drivers/net/ixgbe/base/ixgbe_type_e610.h 
b/drivers/net/ixgbe/base/ixgbe_type_e610.h
index f367ef8a41..e804172252 100644
--- a/drivers/net/ixgbe/base/ixgbe_type_e610.h
+++ b/drivers/net/ixgbe/base/ixgbe_type_e610.h
@@ -700,6 +700,7 @@ struct ixgbe_aci_cmd_list_caps_elem {
 #define IXGBE_ACI_CAPS_EXT_TOPO_DEV_IMG1   0x0082
 #define IXGBE_ACI_CAPS_EXT_TOPO_DEV_IMG2   0x0083
 #define IXGBE_ACI_CAPS_EXT_TOPO_DEV_IMG3   0x0084
+#define IXGBE_ACI_CAPS_OROM_RECOVERY_UPDATE0x0090
 #define IXGBE_ACI_CAPS_NEXT_CLUSTER_ID 0x0096
 #define IXGBE_ACI_CAPS_PTP_BY_PHY  0x0097
u8 major_ver;
@@ -2087,6 +2088,8 @@ struct ixgbe_hw_common_caps {
 #define IXGBE_EXT_TOPO_DEV_IMG_LOAD_EN BIT(0)
bool ext_topo_dev_img_prog_en[IXGBE_EXT_TOPO_DEV_IMG_COUNT];
 #define IXGBE_EXT_TOPO_DEV_IMG_PROG_EN BIT(1)
+   /* Support for OROM update in Recovery Mode. */
+   bool orom_recovery_update;
bool next_cluster_id_support;
bool ptp_by_phy_support;
 };
-- 
2.43.5

[PATCH 09/10] net/ixgbe/base: add missing buffer copy

[Yuan Wang]

From: Dan Nowlin 

Add missing buffer copy in ixgbe_aci_send_cmd_sc().

In ixgbe_aci_send_cmd_sc() there is code to retry aq commands for
certain commands. To achieve this the function makes a copy of the
original ixgbe_aci_desc structure and allocates memory to store an
original copy of the command buffer. This allows the original structure
and buffer to be restored before attempting the command again. However,
the function didn't perform the actual copy of the original command
buffer into the copy buffer.

Signed-off-by: Dan Nowlin 
Signed-off-by: Yuan Wang 
---
 drivers/net/ixgbe/base/ixgbe_e610.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c 
b/drivers/net/ixgbe/base/ixgbe_e610.c
index dc4eafaa5a..5474c3012a 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.c
+++ b/drivers/net/ixgbe/base/ixgbe_e610.c
@@ -282,6 +282,7 @@ s32 ixgbe_aci_send_cmd(struct ixgbe_hw *hw, struct 
ixgbe_aci_desc *desc,
buf_cpy = (u8 *)ixgbe_malloc(hw, buf_size);
if (!buf_cpy)
return IXGBE_ERR_OUT_OF_MEM;
+   memcpy(buf_cpy, buf, buf_size);
}
memcpy(&desc_cpy, desc, sizeof(desc_cpy));
}
-- 
2.43.5

[PATCH 10/10] net/ixgbe: update base driver README

[Yuan Wang]

Update README with the date of when the lastest snapshot was generated.

Signed-off-by: Yuan Wang 
---
 drivers/net/ixgbe/base/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/base/README b/drivers/net/ixgbe/base/README
index a6429fef19..8693c4ebc1 100644
--- a/drivers/net/ixgbe/base/README
+++ b/drivers/net/ixgbe/base/README
@@ -6,7 +6,7 @@ Intel?? IXGBE driver
 ===
 
 This directory contains source code of ixgbe base driver generated on
-2024-08-38 released by the team which develops
+2024-12-20 released by the team which develops
 basic drivers for any ixgbe NIC. The sub-directory of base/
 contains the original source package.
 This driver is valid for the product(s) listed below
-- 
2.43.5

[PATCH 05/10] net/ixgbe/base: add definition of FW temp event for E610

[Yuan Wang]

From: Krzysztof Galazka 

E610 adapters report overheating using a FW event. Add opcode
and event structure to properly handle such events.

Signed-off-by: Krzysztof Galazka 
Signed-off-by: Yuan Wang 
---
 drivers/net/ixgbe/base/ixgbe_type_e610.h | 25 
 1 file changed, 25 insertions(+)

diff --git a/drivers/net/ixgbe/base/ixgbe_type_e610.h 
b/drivers/net/ixgbe/base/ixgbe_type_e610.h
index d0c34c8690..f367ef8a41 100644
--- a/drivers/net/ixgbe/base/ixgbe_type_e610.h
+++ b/drivers/net/ixgbe/base/ixgbe_type_e610.h
@@ -509,6 +509,8 @@ enum ixgbe_aci_opc {
ixgbe_aci_opc_done_alt_write= 0x0904,
ixgbe_aci_opc_clear_port_alt_write  = 0x0906,
 
+   ixgbe_aci_opc_temp_tca_event= 0x0C94,
+
/* debug commands */
ixgbe_aci_opc_debug_dump_internals  = 0xFF08,
 
@@ -1756,6 +1758,29 @@ struct ixgbe_aci_cmd_get_cgu_info {
 
 IXGBE_CHECK_PARAM_LEN(ixgbe_aci_cmd_get_cgu_info);
 
+struct ixgbe_aci_cmd_temp_tca_event {
+   u8 event_desc;
+#define IXGBE_TEMP_TCA_EVENT_DESC_SUBJ_SHIFT 0
+#define IXGBE_TEMP_TCA_EVENT_DESC_SUBJ_NVM   0
+#define IXGBE_TEMP_TCA_EVENT_DESC_SUBJ_EVENT_STATE   1
+#define IXGBE_TEMP_TCA_EVENT_DESC_SUBJ_ALL   2
+
+#define IXGBE_TEMP_TCA_EVENT_DESC_ALARM_SHIFT2
+#define IXGBE_TEMP_TCA_EVENT_DESC_WARNING_CLEARED0
+#define IXGBE_TEMP_TCA_EVENT_DESC_ALARM_CLEARED  1
+#define IXGBE_TEMP_TCA_EVENT_DESC_WARNING_RAISED 2
+#define IXGBE_TEMP_TCA_EVENT_DESC_ALARM_RAISED   3
+
+   u8 reserved;
+   __le16 temperature;
+   __le16 thermal_sensor_max_value;
+   __le16 thermal_sensor_min_value;
+   __le32 addr_high;
+   __le32 addr_low;
+};
+
+IXGBE_CHECK_PARAM_LEN(ixgbe_aci_cmd_temp_tca_event);
+
 /* Debug Dump Internal Data (indirect 0xFF08) */
 struct ixgbe_aci_cmd_debug_dump_internals {
__le16 cluster_id; /* Expresses next cluster ID in response */
-- 
2.43.5

[PATCH 07/10] net/ixgbe/base: add max_drift_thresh to get_ptp_by_phy

[Yuan Wang]

From: Karol Kolacinski 

Add max_drift_thresh parameter to ixgbe_get_ptp_by_phy() to allow
passing maxDriftThreshold parameter from the response.

Signed-off-by: Karol Kolacinski 
Signed-off-by: Yuan Wang 
---
 drivers/net/ixgbe/base/ixgbe_e610.c | 5 -
 drivers/net/ixgbe/base/ixgbe_e610.h | 3 ++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c 
b/drivers/net/ixgbe/base/ixgbe_e610.c
index 802dfb5062..dc4eafaa5a 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.c
+++ b/drivers/net/ixgbe/base/ixgbe_e610.c
@@ -1833,12 +1833,14 @@ s32 ixgbe_set_ptp_by_phy(struct ixgbe_hw *hw, u8 
ptp_request, u8 flags)
  * @hw: pointer to the HW struct
  * @ptp_config: timestamp mode config
  * @flags: timestamp mode flags
+ * @max_drift_thresh: maximal PHY clock drift threshold
  *
  * Get PTP by PHY using ACI command (0x0635).
  *
  * Return: 0 on success, negative error code otherwise
  */
-s32 ixgbe_get_ptp_by_phy(struct ixgbe_hw *hw, u8 *ptp_config, u8 *flags)
+s32 ixgbe_get_ptp_by_phy(struct ixgbe_hw *hw, u8 *ptp_config, u8 *flags,
+u16 *max_drift_thresh)
 {
struct ixgbe_aci_cmd_get_ptp_by_phy_resp *resp;
struct ixgbe_aci_desc desc;
@@ -1851,6 +1853,7 @@ s32 ixgbe_get_ptp_by_phy(struct ixgbe_hw *hw, u8 
*ptp_config, u8 *flags)
if (!status) {
*ptp_config = resp->ptp_config;
*flags = resp->flags;
+   *max_drift_thresh = IXGBE_LE16_TO_CPU(resp->maxDriftThreshold);
}
 
return status;
diff --git a/drivers/net/ixgbe/base/ixgbe_e610.h 
b/drivers/net/ixgbe/base/ixgbe_e610.h
index ccf76e3b9b..f60268cf91 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.h
+++ b/drivers/net/ixgbe/base/ixgbe_e610.h
@@ -48,7 +48,8 @@ s32 ixgbe_aci_set_event_mask(struct ixgbe_hw *hw, u8 
port_num, u16 mask);
 s32 ixgbe_configure_lse(struct ixgbe_hw *hw, bool activate, u16 mask);
 
 s32 ixgbe_set_ptp_by_phy(struct ixgbe_hw *hw, u8 ptp_request, u8 flags);
-s32 ixgbe_get_ptp_by_phy(struct ixgbe_hw *hw, u8 *ptp_config, u8 *flags);
+s32 ixgbe_get_ptp_by_phy(struct ixgbe_hw *hw, u8 *ptp_config, u8 *flags,
+u16 *max_drift_thresh);
 
 s32 ixgbe_aci_get_netlist_node(struct ixgbe_hw *hw,
   struct ixgbe_aci_cmd_get_link_topo *cmd,
-- 
2.43.5

Re: [PATCH v4 6/6] lib/vhost: remove check around pthread_mutex_init()

[Ariel Otilibili-Anieli]

Hello Maxime,

On Tuesday, January 14, 2025 09:48 CET, Maxime Coquelin 
 wrote:

> 
> 
> On 1/14/25 8:50 AM, Ariel Otilibili wrote:
> 
> Reviewed-by: Maxime Coquelin 
> 
Thanks!

Have a good day,
Ariel
> Thanks,
> Maxime
>

Re: [PATCH v1 2/2] ethdev: fix skip valid port in probing callback

[lihuisong (C)]

在 2025/1/14 19:13, Thomas Monjalon 写道:

14/01/2025 02:50, lihuisong (C):

在 2025/1/13 21:14, Thomas Monjalon 写道:

13/01/2025 13:47, lihuisong (C):

在 2025/1/13 20:30, Thomas Monjalon 写道:

13/01/2025 13:05, lihuisong (C):

在 2025/1/13 19:23, lihuisong (C) 写道:

在 2025/1/13 18:57, Thomas Monjalon 写道:

13/01/2025 10:35, lihuisong (C):

在 2025/1/13 16:16, Thomas Monjalon 写道:

13/01/2025 03:55, Huisong Li:

The event callback in application may use the macro
RTE_ETH_FOREACH_DEV to
iterate over all enabled ports to do something(like, verifying the
port id
validity) when receive a probing event. If the ethdev state of a
port is
not RTE_ETH_DEV_UNUSED, this port will be considered as a valid port.

However, this state is set to RTE_ETH_DEV_ATTACHED after pushing
probing
event. It means that probing callback will skip this port. But this
assignment can not move to front of probing notification. See
commit be8cd210379a ("ethdev: fix port probing notification")

So this patch has to add a new state, RTE_ETH_DEV_ALLOCATED. Set
the ethdev
state to RTE_ETH_DEV_ALLOCATED before pushing probing event and
set it to
RTE_ETH_DEV_ATTACHED after definitely probed. And this port is
valid if its
device state is 'ALLOCATED' or 'ATTACHED'.

If you do that, changing the definition of eth_dev_find_free_port()
you allow the application using a port before probing is finished.

Yes, it's not reasonable.

Thinking your comment twice, I feel that the root cause of this
issue is
application want to check if the port id is valid.
However, application just receive the new event from the device and the
port id of this device must be valid when report new event.
So application can think the received new event is valid and don't need
to check, right?

Yes
Do you think it should be highlighted in the API doc?

Security detection is common and always good for application.
So I think it's better to highlight that in doc.


Now I remember why I have to put this patch into the patchset [1] that
testpmd support multiple process attach and detach port.
Becase patch 4/5 in this series depands on this patch.
The setup_attached_port() have to move to eth_event_callback() in
testpmd to update something.
And the setup_attached_port() would indirectyly check if this port is
valid by rte_eth_dev_is_valid_port().
Their caller stack is as follows:
eth_event_callback
-->setup_attached_port
-->rte_eth_dev_socket_id
-->rte_eth_dev_is_valid_port

From the testpmd's modification, that is to say, it is possible for
appllication to call some APIs like rte_eth_dev_socket_id() and
indirectyly check if this port id is valid in event new callback.
So should we add this patch? I think there are many like these API in
ethdev layer. I'm confused a bit now.

Yes rte_eth_dev_is_valid_port() is used in many API functions,
so that's a valid concern.
I would say we should not call much of these functions in the "new port"
event callback.
But the case of rte_eth_dev_socket_id() is concerning.

I suggest to update rte_eth_dev_socket_id() to make it work with
a newly allocated port.
I suppose we can use the function eth_dev_is_allocated().

What you mean is doing it like the following code?
-->

--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -635,8 +635,10 @@ int
rte_eth_dev_socket_id(uint16_t port_id)
{
   int socket_id = SOCKET_ID_ANY;
+   struct rte_eth_dev *ethdev;

-   if (!rte_eth_dev_is_valid_port(port_id)) {
+   ethdev = &rte_eth_devices[port_id];
+   if (!eth_dev_is_allocated(ethdev)) {
   rte_errno = EINVAL;
   } else {
   socket_id = rte_eth_devices[port_id].data->numa_node;

Yes. Would it work?

I think it can work for this API.

  From the disscussion for this patch, we've come to an aggreement that
application can think port is valid in new event.

We don't want an application to configure a port before probing is finished
(like still in the event processing).

Ok



Now that the port id is valid, the new event callback of application may
call other API, for example, rte_eth_dev_info_get().
(Apllication may call rte_eth_dev_info_get to get someting in new event
callback)
Note: patch 4/5 modified in the series[1] also used this API.
-->
eth_event_callback
  -->setup_attached_port
  -->reconfig
  -->init_config_port_offloads
  -->eth_dev_info_get_print_err
---

I don't agree with configuring a port which is not fully probed.

Got it.



There is RTE_ETH_VALID_PORTID_OR_ERR_RET to check port_id is valid in
rte_eth_dev_info_get.
Application also happen to this issue like rte_eth_dev_socket_id, right?

Right, I think such application is abusing the new event.

testpmd set a flag when receiving an event, it should not do more:

 case RTE_ETH_EVENT_NEW:
 ports[port_id].need_setup = 1;
 ports[port_id].port_status = RTE_PORT_HANDLING;
 break;

ok I know what you mean.

This macro 

[PATCH 08/10] net/ixgbe/base: update VF HV subsystem device ID constant

[Yuan Wang]

From: Piotr Kwapulinski 

Current value of IXGBE_SUBDEV_ID_E610_VF_HV (0x0001) causes the conflict
with real e610 subsystem device ID. This causes the TX hung of driver
running in VM. Update this value to 0x00FF to resolve conflict.

Fixes: 659e36767e77 (net/ixgbe/base: add E610 VF HV macro)
Cc: sta...@dpdk.org

Signed-off-by: Piotr Kwapulinski 
Signed-off-by: Yuan Wang 
---
 drivers/net/ixgbe/base/ixgbe_type.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/base/ixgbe_type.h 
b/drivers/net/ixgbe/base/ixgbe_type.h
index cc49eace91..99ae823119 100644
--- a/drivers/net/ixgbe/base/ixgbe_type.h
+++ b/drivers/net/ixgbe/base/ixgbe_type.h
@@ -131,7 +131,7 @@
 #define IXGBE_DEV_ID_E610_2_5G_T   0x57B1
 #define IXGBE_DEV_ID_E610_SGMII0x57B2
 #define IXGBE_DEV_ID_E610_VF   0x57AD
-#define IXGBE_SUBDEV_ID_E610_VF_HV 0x0001
+#define IXGBE_SUBDEV_ID_E610_VF_HV 0x00FF
 
 #define IXGBE_CAT(r, m) IXGBE_##r##m
 
-- 
2.43.5

Re: [PATCH] net/i40e/base: fix the debug print format

[David Marchand]

On Tue, Jan 14, 2025 at 10:44 AM Zhichao Zeng  wrote:
>
> This patch modifies format specifier in debug prints to match to the
> change of time variables from 64 bit to 32 bit.

I am missing something... this is reverting a valid change.

If anything needs to be changed.. PRIu32 should be used in the four
hunks this patch touches.

>
> Fixes: d980a401b137 ("net/i40e/base: add NVM acquire with custom timeout")
> Fixes: ba90329a5eb3 ("net/i40e/base: fix invalid log format characters")

And in this case, I think you want to point at:
Fixes: cb593a832630 ("net/i40e/base: reduce size of time variables")

> Cc: sta...@dpdk.org
>
> Signed-off-by: Jaroslaw Ilgiewicz 
> Signed-off-by: Zhichao Zeng 


-- 
David Marchand

[techboard/hosting Bug 1615] Arissa Seah

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=1615

Bug ID: 1615
   Summary: Arissa Seah
   Product: techboard
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: hosting
  Assignee: techbo...@dpdk.org
  Reporter: arissasea...@gmail.com
CC: dev@dpdk.org
  Target Milestone: ---

At Mercury Consulting, we specialise in providing comprehensive services to
support businesses and individuals. Our expertise spans company formation,
trustee services, immigration, accounting, tax, and audit, all designed to help
our clients navigate complex regulatory environments with ease. We are
particularly well-versed in facilitating the Greece Golden Visa program,
offering clients a pathway to secure residency in Greece through investment.
Whether you are looking to establish a business, streamline your financial
operations or explore new immigration opportunities, our team of experienced
professionals is committed to delivering tailored solutions that meet your
specific needs. With a strong presence, Mercury Consulting is your trusted
partner for sustainable growth and success in the global marketplace.
Telephone: +65 6330 6380

Visit here: 
https://www.mercuryconsulting.biz/services/immigration/greece-golden-visa/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Re: [PATCH v2] ring: add the second version of the RTS interface

[Thomas Monjalon]

08/01/2025 02:41, Huichao Cai:
> Hi,Thomas
> This patch adds a field to the ABI structure.I have added the 
> suppress_type
> field in the file libabigail.abignore, but "ci/github-robot: Build" still 
> reported
> an error, could you please advise on how to fill in the suppress_type field?

You must check locally and see what happens when you add some suppressions.

You will find documentation here:
https://sourceware.org/libabigail/manual/libabigail-concepts.html#suppression-specifications

Re: [PATCH v14 03/81] eal/common: remove use of VLAs

[Andre Muezerie]

On Mon, Jan 13, 2025 at 01:30:12PM -0800, Andre Muezerie wrote:
> On Fri, Jan 10, 2025 at 05:14:05PM -0800, Stephen Hemminger wrote:
> > On Fri, 10 Jan 2025 12:22:22 -0800
> > Andre Muezerie  wrote:
> > 
> > > diff --git a/lib/eal/meson.build b/lib/eal/meson.build
> > > index e1d6c4cf17..352db049e9 100644
> > > --- a/lib/eal/meson.build
> > > +++ b/lib/eal/meson.build
> > > @@ -31,3 +31,11 @@ endif
> > >  if is_freebsd
> > >  annotate_locks = false
> > >  endif
> > > +
> > > +warning_flags = ['-Wvla']
> > > +
> > > +foreach arg: warning_flags
> > > +if cc.has_argument(arg)
> > > +cflags += arg
> > > +endif
> > > +endforeach
> > > -- 
> > 
> > Could we enable it for all libs and only turn it off as required?
> 
> Yes. Although the data types in meson are additive only, we can
> add -Wno-vla to cancel a -Wvla already present. Let me send out a
> new series with this change.

Series v16 has the changes proposed.

There was only one failure reported now, which seems infra-related:
"The requested resource was not found on this server":
https://mails.dpdk.org/archives/test-report/2025-January/842300.html

Let me know if any action is needed from my side.

Thanks,

Andre Muezerie

Re: [PATCH] examples/l3fwd: add option to set refetch offset

[Stephen Hemminger]

On Tue, 14 Jan 2025 08:07:52 -0800
Stephen Hemminger  wrote:

> On Tue, 14 Jan 2025 17:22:08 +0800
> huangdengdui  wrote:
> 
> > On 2025/1/11 1:20, Stephen Hemminger wrote:  
> > > This will make it slower for many platforms.
> > > GCC will unroll a loop of fixed small size, which is what we want.
> > 
> > Do you mean to replace option with a macro?
> > But most of prefetch_offset are used with the nb_rx, So using macros is the 
> > same as using options.
> > 
> > const int32_t k = RTE_ALIGN_FLOOR(nb_rx, FWDSTEP);
> > for (j = 0; j != k; j += FWDSTEP) {
> > for (i = 0, pos = j + prefetch_offset;
> >  i < FWDSTEP && pos < k; i++, pos++)
> > rte_prefetch0(rte_pktmbuf_mtod(pkts_burst[pos], void *));
> > processx4_step1(&pkts_burst[j], &dip, &ipv4_flag);
> > processx4_step2(qconf, dip, ipv4_flag, portid,
> > &pkts_burst[j], &dst_port[j]);
> > if (do_step3)
> > processx4_step3(&pkts_burst[j], &dst_port[j]);
> > }
> > 
> > The option can dynamically adjust the prefetch window, which makes it 
> > easier to find the prefetch window for a HW platform.
> > So I think it's better to use option.  
> 
> The tradeoff is that loop unrolling most often is only done on small fix 
> sized loops.
> And the cost of a loop with variable small values (branch prediction) is high 
> enough that it 
> could make things slower.
> 
> Prefetching is a balancing act, and more is not better especially on real 
> workloads.

You might also want to look at the quad loop model used in VPP for prefetching.

https://my-vpp-docs.readthedocs.io/en/latest/gettingstarted/developers/vnet.html

Re: [PATCH] eal: fix undeclared function error on old CPUs

[Bruce Richardson]

On Tue, Jan 14, 2025 at 08:21:13AM -0800, Andre Muezerie wrote:
> Error reported:
> ../lib/net/net_crc_sse.c:49:17: error: call to undeclared function
> '_mm_clmulepi64_si128'; ISO C99 and later do not support implicit
> function declarations [-Wimplicit-function-declaration]
> 
> The fix is to remove the unnecessary ifdef around the inclusion of
> header file immintrin.h. This header also contains functions that do
> not require AVX instructions, so should not be included only when AVX
> is available.
> 
> Bugzilla ID: 1595
> Fixes: da826b7135a4 ("eal: introduce ymm type for AVX 256-bit")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Andre Muezerie 
> ---

Acked-by: Bruce Richardson 

>  lib/eal/x86/include/rte_vect.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lib/eal/x86/include/rte_vect.h b/lib/eal/x86/include/rte_vect.h
> index 5ac3ccfd82..5fdcd632ac 100644
> --- a/lib/eal/x86/include/rte_vect.h
> +++ b/lib/eal/x86/include/rte_vect.h
> @@ -19,9 +19,7 @@
>  
>  #if defined(__ICC) || defined(_WIN64)
>  #include  /* SSE4 */
> -#if defined(__AVX__)
>  #include 
> -#endif
>  #else
>  #include 
>  #endif
> -- 
> 2.47.0.vfs.0.3
> 

[PATCH] eal: fix undeclared function error on old CPUs

[Andre Muezerie]

Error reported:
../lib/net/net_crc_sse.c:49:17: error: call to undeclared function
'_mm_clmulepi64_si128'; ISO C99 and later do not support implicit
function declarations [-Wimplicit-function-declaration]

The fix is to remove the unnecessary ifdef around the inclusion of
header file immintrin.h. This header also contains functions that do
not require AVX instructions, so should not be included only when AVX
is available.

Bugzilla ID: 1595
Fixes: da826b7135a4 ("eal: introduce ymm type for AVX 256-bit")
Cc: sta...@dpdk.org

Signed-off-by: Andre Muezerie 
---
 lib/eal/x86/include/rte_vect.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/eal/x86/include/rte_vect.h b/lib/eal/x86/include/rte_vect.h
index 5ac3ccfd82..5fdcd632ac 100644
--- a/lib/eal/x86/include/rte_vect.h
+++ b/lib/eal/x86/include/rte_vect.h
@@ -19,9 +19,7 @@
 
 #if defined(__ICC) || defined(_WIN64)
 #include  /* SSE4 */
-#if defined(__AVX__)
 #include 
-#endif
 #else
 #include 
 #endif
-- 
2.47.0.vfs.0.3

[PATCH] mbuf: add fast free bulk function

[Morten Brørup]

When putting an mbuf back into its mempool, there are certain requirements
to the mbuf. Specifically, some of its fields must be initialized.

These requirements are in fact invariants about free mbufs, held in
mempools, and thus also apply when allocating an mbuf from a mempool.
With this in mind, the additional assertions in rte_mbuf_raw_free() were
moved to __rte_mbuf_raw_sanity_check().
Furthermore, the assertion regarding pinned external buffer was enhanced;
it now also asserts that the referenced pinned external buffer has
refcnt == 1.

The description of RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE was updated to
include the remaining requirements, which were missing here.

And finally:
A new rte_mbuf_fast_free_bulk() inline function was added for the benefit
of ethdev drivers supporting fast release of mbufs.
It asserts these requirements and that the mbufs belong to the specified
mempool, and then calls rte_mempool_put_bulk().

Signed-off-by: Morten Brørup 
---
 lib/ethdev/rte_ethdev.h |  6 --
 lib/mbuf/rte_mbuf.h | 39 +--
 2 files changed, 41 insertions(+), 4 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 1f71cad244..e9267fca79 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -1612,8 +1612,10 @@ struct rte_eth_conf {
 #define RTE_ETH_TX_OFFLOAD_MULTI_SEGS   RTE_BIT64(15)
 /**
  * Device supports optimization for fast release of mbufs.
- * When set application must guarantee that per-queue all mbufs comes from
- * the same mempool and has refcnt = 1.
+ * When set application must guarantee that per-queue all mbufs come from the 
same mempool,
+ * are direct, have refcnt=1, next=NULL and nb_segs=1, as done by 
rte_pktmbuf_prefree_seg().
+ *
+ * @see rte_mbuf_fast_free_bulk()
  */
 #define RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE   RTE_BIT64(16)
 #define RTE_ETH_TX_OFFLOAD_SECURITY RTE_BIT64(17)
diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
index 0d2e0e64b3..cae96bed20 100644
--- a/lib/mbuf/rte_mbuf.h
+++ b/lib/mbuf/rte_mbuf.h
@@ -568,6 +568,10 @@ __rte_mbuf_raw_sanity_check(__rte_unused const struct 
rte_mbuf *m)
RTE_ASSERT(rte_mbuf_refcnt_read(m) == 1);
RTE_ASSERT(m->next == NULL);
RTE_ASSERT(m->nb_segs == 1);
+   RTE_ASSERT(!RTE_MBUF_CLONED(m));
+   RTE_ASSERT(!RTE_MBUF_HAS_EXTBUF(m) ||
+   (RTE_MBUF_HAS_PINNED_EXTBUF(m) &&
+   rte_mbuf_ext_refcnt_read(m->shinfo) == 1));
__rte_mbuf_sanity_check(m, 0);
 }
 
@@ -623,12 +627,43 @@ static inline struct rte_mbuf *rte_mbuf_raw_alloc(struct 
rte_mempool *mp)
 static __rte_always_inline void
 rte_mbuf_raw_free(struct rte_mbuf *m)
 {
-   RTE_ASSERT(!RTE_MBUF_CLONED(m) &&
- (!RTE_MBUF_HAS_EXTBUF(m) || RTE_MBUF_HAS_PINNED_EXTBUF(m)));
__rte_mbuf_raw_sanity_check(m);
rte_mempool_put(m->pool, m);
 }
 
+/**
+ * Put a bulk of mbufs allocated from the same mempool back into the mempool.
+ *
+ * The caller must ensure that the mbufs come from the specified mempool,
+ * are direct and properly reinitialized (refcnt=1, next=NULL, nb_segs=1), as 
done by
+ * rte_pktmbuf_prefree_seg().
+ *
+ * This function should be used with care, when optimization is
+ * required. For standard needs, prefer rte_pktmbuf_free_bulk().
+ *
+ * @see RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE
+ *
+ * @param mp
+ *   The mempool to which the mbufs belong.
+ * @param mbufs
+ *   Array of pointers to packet mbufs.
+ *   The array must not contain NULL pointers.
+ * @param count
+ *   Array size.
+ */
+void
+rte_mbuf_fast_free_bulk(struct rte_mempool *mp, struct rte_mbuf **mbufs, 
unsigned int count)
+{
+   for (unsigned int idx = 0; idx < count; idx++) {
+   const struct rte_mbuf *m = mbufs[idx];
+   RTE_ASSERT(m != NULL);
+   RTE_ASSERT(m->pool == mp);
+   __rte_mbuf_raw_sanity_check(m);
+   }
+
+   rte_mempool_put_bulk(mp, (void **)mbufs, count);
+}
+
 /**
  * The packet mbuf constructor.
  *
-- 
2.43.0

Re: [PATCH] eal: add worker threads cleanup in rte_eal_cleanup()

[Stephen Hemminger]

On Tue, 14 Jan 2025 04:53:51 +
Gagandeep Singh  wrote:

> Hi,
> 
> > -Original Message-
> > From: Stephen Hemminger 
> > Sent: Monday, January 13, 2025 10:10 PM
> > To: Gagandeep Singh 
> > Cc: dev@dpdk.org
> > Subject: Re: [PATCH] eal: add worker threads cleanup in rte_eal_cleanup()
> > 
> > On Mon, 13 Jan 2025 05:13:01 +
> > Gagandeep Singh  wrote:
> >   
> > > Hi,
> > >  
> > > > -Original Message-
> > > > From: Stephen Hemminger 
> > > > Sent: Friday, January 10, 2025 10:49 PM
> > > > To: Gagandeep Singh 
> > > > Cc: dev@dpdk.org
> > > > Subject: Re: [PATCH] eal: add worker threads cleanup in
> > > > rte_eal_cleanup()
> > > >
> > > > On Fri, 10 Jan 2025 12:17:17 +0530
> > > > Gagandeep Singh  wrote:
> > > >  
> > > > > This patch introduces a worker thread cleanup function in the EAL
> > > > > library, ensuring proper termination of created pthreads and
> > > > > invocation of registered pthread destructors.
> > > > > This guarantees the correct cleanup of thread-specific resources,
> > > > > used by drivers or applications.
> > > > >
> > > > > Signed-off-by: Gagandeep Singh 
> > > > > ---  
> > > >
> > > > What problem is this trying to solve?
> > > >
> > > > Canceling threads sends signals and can be problematic.
> > > > Many of the operations done in drivers are not signal safe.  
> > >
> > > To ensure the proper cleanup of thread-specific resources, the DPAA 
> > > driver  
> > initializes pthread-specific destructors using pthread_key_create(). These
> > destructors are executed only when a thread terminates or the key is 
> > deleted.
> > However, since threads are not terminated when the application is killed, 
> > these
> > destructors are not executed, resulting in resource leaks.  
> > > To address this issue, we propose adding thread termination code to
> > > rte_eal_cleanup() to ensure that threads are properly terminated,
> > > thereby triggering the execution of pthread-specific destructors
> > >
> > > Any alternate suggestion in case pthread_cancel is not a better
> > > solution? We can add pthread join timeout to avoid blocking on thread 
> > > stuck or  
> > May be any way to call pthread_exit?
> > 
> > The DPAA driver is the problem here. It should not be using pthread_key.
> > Other drivers don't do this. Other drivers do setup on probe and cleanup on 
> > close.
> > 
> > An application doing a clean shutdown should do what existing testpmd, 
> > l3fwd, do
> > - wait for worker threads to go idle
> > - stop all ports
> > - close all ports
> > - call eal cleanup
> > 
> > If DPAA driver needs pthread_key it should handling that in the close.
> > But it really should be using DPDK thread local storage for this.
> >   
> This is fine for graceful application termination, but what about 
> non-graceful application termination?
> I have a DPAA bus cleanup patch ready, and will submit it soon, But we still 
> need
> destructor in case application exit without calling the rte_eal_cleanup().

If application crashes, the code isn't going to be called  so the pthread 
destructor won't help.
You need to build any driver so that if application ungracefully exits, the 
hardware can be
reset on restart. Trying to rely on application doing anything while crashing 
is not going
to work. Alternatively, having a distinct separate watcher process (or using 
systemd) that can
do a forceful cleanup on application crash can work. The point is you can't 
handle non-graceful
shutdown cleanup in a DPDK driver and have it work reliably.


> 
> I can see DPDK is giving an API rte_thread_key_create() which is defined only 
> in UNIX and windows.
> Why not for Linux?

I was thinking of the recent per-thread allocator.

> 
> I know DPAA driver is using pthread_key which it should not use but instead 
> use
> rte_thread_key_create() provided by DPDK which we can replace.
> Having pthread destructor is still a valid case in my opinion.

[PATCH v2] mbuf: add fast free bulk function

[Morten Brørup]

mbuf: add fast free bulk function

When putting an mbuf back into its mempool, there are certain requirements
to the mbuf. Specifically, some of its fields must be initialized.

These requirements are in fact invariants about free mbufs, held in
mempools, and thus also apply when allocating an mbuf from a mempool.
With this in mind, the additional assertions in rte_mbuf_raw_free() were
moved to __rte_mbuf_raw_sanity_check().
Furthermore, the assertion regarding pinned external buffer was enhanced;
it now also asserts that the referenced pinned external buffer has
refcnt == 1.

The description of RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE was updated to
include the remaining requirements, which were missing here.

And finally:
A new rte_mbuf_fast_free_bulk() inline function was added for the benefit
of ethdev drivers supporting fast release of mbufs.
It asserts these requirements and that the mbufs belong to the specified
mempool, and then calls rte_mempool_put_bulk().

Signed-off-by: Morten Brørup 
---
v2:
* Fixed missing inline.
---
 lib/ethdev/rte_ethdev.h |  6 --
 lib/mbuf/rte_mbuf.h | 39 +--
 2 files changed, 41 insertions(+), 4 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 1f71cad244..e9267fca79 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -1612,8 +1612,10 @@ struct rte_eth_conf {
 #define RTE_ETH_TX_OFFLOAD_MULTI_SEGS   RTE_BIT64(15)
 /**
  * Device supports optimization for fast release of mbufs.
- * When set application must guarantee that per-queue all mbufs comes from
- * the same mempool and has refcnt = 1.
+ * When set application must guarantee that per-queue all mbufs come from the 
same mempool,
+ * are direct, have refcnt=1, next=NULL and nb_segs=1, as done by 
rte_pktmbuf_prefree_seg().
+ *
+ * @see rte_mbuf_fast_free_bulk()
  */
 #define RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE   RTE_BIT64(16)
 #define RTE_ETH_TX_OFFLOAD_SECURITY RTE_BIT64(17)
diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
index 0d2e0e64b3..7590d82689 100644
--- a/lib/mbuf/rte_mbuf.h
+++ b/lib/mbuf/rte_mbuf.h
@@ -568,6 +568,10 @@ __rte_mbuf_raw_sanity_check(__rte_unused const struct 
rte_mbuf *m)
RTE_ASSERT(rte_mbuf_refcnt_read(m) == 1);
RTE_ASSERT(m->next == NULL);
RTE_ASSERT(m->nb_segs == 1);
+   RTE_ASSERT(!RTE_MBUF_CLONED(m));
+   RTE_ASSERT(!RTE_MBUF_HAS_EXTBUF(m) ||
+   (RTE_MBUF_HAS_PINNED_EXTBUF(m) &&
+   rte_mbuf_ext_refcnt_read(m->shinfo) == 1));
__rte_mbuf_sanity_check(m, 0);
 }
 
@@ -623,12 +627,43 @@ static inline struct rte_mbuf *rte_mbuf_raw_alloc(struct 
rte_mempool *mp)
 static __rte_always_inline void
 rte_mbuf_raw_free(struct rte_mbuf *m)
 {
-   RTE_ASSERT(!RTE_MBUF_CLONED(m) &&
- (!RTE_MBUF_HAS_EXTBUF(m) || RTE_MBUF_HAS_PINNED_EXTBUF(m)));
__rte_mbuf_raw_sanity_check(m);
rte_mempool_put(m->pool, m);
 }
 
+/**
+ * Put a bulk of mbufs allocated from the same mempool back into the mempool.
+ *
+ * The caller must ensure that the mbufs come from the specified mempool,
+ * are direct and properly reinitialized (refcnt=1, next=NULL, nb_segs=1), as 
done by
+ * rte_pktmbuf_prefree_seg().
+ *
+ * This function should be used with care, when optimization is
+ * required. For standard needs, prefer rte_pktmbuf_free_bulk().
+ *
+ * @see RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE
+ *
+ * @param mp
+ *   The mempool to which the mbufs belong.
+ * @param mbufs
+ *   Array of pointers to packet mbufs.
+ *   The array must not contain NULL pointers.
+ * @param count
+ *   Array size.
+ */
+static __rte_always_inline void
+rte_mbuf_fast_free_bulk(struct rte_mempool *mp, struct rte_mbuf **mbufs, 
unsigned int count)
+{
+   for (unsigned int idx = 0; idx < count; idx++) {
+   const struct rte_mbuf *m = mbufs[idx];
+   RTE_ASSERT(m != NULL);
+   RTE_ASSERT(m->pool == mp);
+   __rte_mbuf_raw_sanity_check(m);
+   }
+
+   rte_mempool_put_bulk(mp, (void **)mbufs, count);
+}
+
 /**
  * The packet mbuf constructor.
  *
-- 
2.43.0

Re: [PATCH] examples/l3fwd: add option to set refetch offset

[Stephen Hemminger]

On Tue, 14 Jan 2025 17:22:08 +0800
huangdengdui  wrote:

> On 2025/1/11 1:20, Stephen Hemminger wrote:
> > This will make it slower for many platforms.
> > GCC will unroll a loop of fixed small size, which is what we want.  
> 
> Do you mean to replace option with a macro?
> But most of prefetch_offset are used with the nb_rx, So using macros is the 
> same as using options.
> 
> const int32_t k = RTE_ALIGN_FLOOR(nb_rx, FWDSTEP);
> for (j = 0; j != k; j += FWDSTEP) {
>   for (i = 0, pos = j + prefetch_offset;
>i < FWDSTEP && pos < k; i++, pos++)
>   rte_prefetch0(rte_pktmbuf_mtod(pkts_burst[pos], void *));
>   processx4_step1(&pkts_burst[j], &dip, &ipv4_flag);
>   processx4_step2(qconf, dip, ipv4_flag, portid,
>   &pkts_burst[j], &dst_port[j]);
>   if (do_step3)
>   processx4_step3(&pkts_burst[j], &dst_port[j]);
> }
> 
> The option can dynamically adjust the prefetch window, which makes it easier 
> to find the prefetch window for a HW platform.
> So I think it's better to use option.

The tradeoff is that loop unrolling most often is only done on small fix sized 
loops.
And the cost of a loop with variable small values (branch prediction) is high 
enough that it 
could make things slower.

Prefetching is a balancing act, and more is not better especially on real 
workloads.

Re: [PATCH 2/2] drivers/net: remove unused variables and add MSVC compiler flag

[Stephen Hemminger]

On Thu, 26 Dec 2024 10:41:44 -0800
Andre Muezerie  wrote:

> Removed unused variables and added MSVC specific compiler flag to
> ignore warnings about unused variables, like is being done for
> other compilers.
> 
> Signed-off-by: Andre Muezerie 
> ---
>  drivers/net/ice/base/ice_switch.c  |  2 --
>  drivers/net/ice/base/meson.build   | 16 ++---
>  drivers/net/qede/base/ecore_dcbx.c |  2 --
>  drivers/net/qede/base/ecore_mcp.c  |  2 --
>  drivers/net/qede/base/meson.build  | 57 +-
>  5 files changed, 43 insertions(+), 36 deletions(-)


Makes sense, but this base (ie shared across OS code).
Can't make changes there in general; and requires approval of that PMD 
maintainer.

Re: [EXTERNAL] Re: [PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is missing

[Stephen Hemminger]

On Thu, 9 Jan 2025 07:31:32 +
Tomasz Duszynski  wrote:

> >> From: Tomasz Duszynski 
> >> To: , Stephen Hemminger ,  
> >"Pascal  Mazon"   
> >> CC: , Tomasz Duszynski 
> >> Subject: [PATCH] net/tap: fix compilation issues if HAVE_TCA_FLOWER is
> >> missing
> >> Date: Wed, 8 Jan 2025 13:10:11 +0100
> >> X-Mailer: git-send-email 2.34.1
> >>
> >> If HAVE_TCA_FLOWER is undefined compilation errors / warnings may
> >> appear. This addresses following spotted issues:
> >>
> >> ../drivers/net/tap/rte_eth_tap.c:2113:1: error: label ‘disable_rte_flow’
> >> defined but not used [-Werror=unused-label]
> >>
> >> ../drivers/net/tap/rte_eth_tap.c:1908:26: error: unused parameter
> >> ‘remote_iface’ [-Werror=unused-parameter]
> >>
> >> Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing")
> >> Cc: pascal.ma...@6wind.com
> >>
> >> Signed-off-by: Tomasz Duszynski   
> >
> >Looks good, but realize that flower was added in kernel 4.2 and the current
> >oldest supported upstream kernel is 4.4.
> >So if you are using a supported kernel, flower will be present.  
> 
> It only pops up on 32bit build. That build is maybe not too common so error 
> might have
> gone unnoticed. Anyway, I thought I would add these fixes just in case. 
>  

TCA_FLOWER is still available in 32 bit kernel looks like your build envrionment
is not using a supported kernel.

My goal is to get rid of #ifdef's since it creates untested variants and
multiple ifdef's create combinational chaos.

Re: [PATCH v6 00/15] net/zxdh: updated net zxdh driver

[Stephen Hemminger]

On Thu, 26 Dec 2024 11:37:04 +0800
Junlong Wang  wrote:

> V6:
>   - Remove unnecessary __rte_packed in the virtqueue structure and others.
>   - Remove Some blank before or after log message,
> and remove some end with period in log message.
> 
> V5:
>   - Simplify the notify_data part in the zxdh_notify_queue function.
>   - Replace rte_zmalloc with rte_calloc in the rss_reta_update function.
>   - Remove unnecessary check in mtu_set function.
> 
> V4:
>   - resolved ci compile issues.
> 
> V3:
>   - use rte_zmalloc and rte_calloc to avoid memset.
>   - remove unnecessary initialization, which first usage will set.
>   - adjust some function which is always return 0, changed to void 
> and skip the ASSERTION later.
>   - resolved some WARNING:MACRO_ARG_UNUSED issues.
>   - resolved some other issues.
> 
> V2:
>   - resolve code style and github-robot build issue.
> 
> V1:
>   - updated net zxdh driver
> provided insert/delete/get table code funcs.
> provided link/mac/vlan/promiscuous/rss/mtu ops.
> 
> Junlong Wang (15):
>   net/zxdh: zxdh np init implementation
>   net/zxdh: zxdh np uninit implementation
>   net/zxdh: port tables init implementations
>   net/zxdh: port tables unint implementations
>   net/zxdh: rx/tx queue setup and intr enable
>   net/zxdh: dev start/stop ops implementations
>   net/zxdh: provided dev simple tx implementations
>   net/zxdh: provided dev simple rx implementations
>   net/zxdh: link info update, set link up/down
>   net/zxdh: mac set/add/remove ops implementations
>   net/zxdh: promisc/allmulti ops implementations
>   net/zxdh: vlan filter/ offload ops implementations
>   net/zxdh: rss hash config/update, reta update/get
>   net/zxdh: basic stats ops implementations
>   net/zxdh: mtu update ops implementations
> 
>  doc/guides/nics/features/zxdh.ini  |   18 +
>  doc/guides/nics/zxdh.rst   |   17 +
>  drivers/net/zxdh/meson.build   |4 +
>  drivers/net/zxdh/zxdh_common.c |   28 +-
>  drivers/net/zxdh/zxdh_common.h |1 +
>  drivers/net/zxdh/zxdh_ethdev.c |  603 +++-
>  drivers/net/zxdh/zxdh_ethdev.h |   40 +
>  drivers/net/zxdh/zxdh_ethdev_ops.c | 1573 +
>  drivers/net/zxdh/zxdh_ethdev_ops.h |   80 ++
>  drivers/net/zxdh/zxdh_msg.c|  205 ++-
>  drivers/net/zxdh/zxdh_msg.h|  232 
>  drivers/net/zxdh/zxdh_np.c | 2060 
>  drivers/net/zxdh/zxdh_np.h |  579 
>  drivers/net/zxdh/zxdh_pci.c|   27 +-
>  drivers/net/zxdh/zxdh_pci.h|9 +-
>  drivers/net/zxdh/zxdh_queue.c  |  242 +++-
>  drivers/net/zxdh/zxdh_queue.h  |  164 ++-
>  drivers/net/zxdh/zxdh_rxtx.c   |  804 +++
>  drivers/net/zxdh/zxdh_rxtx.h   |   20 +-
>  drivers/net/zxdh/zxdh_tables.c |  794 +++
>  drivers/net/zxdh/zxdh_tables.h |  231 
>  21 files changed, 7649 insertions(+), 82 deletions(-)
>  create mode 100644 drivers/net/zxdh/zxdh_ethdev_ops.c
>  create mode 100644 drivers/net/zxdh/zxdh_ethdev_ops.h
>  create mode 100644 drivers/net/zxdh/zxdh_np.c
>  create mode 100644 drivers/net/zxdh/zxdh_np.h
>  create mode 100644 drivers/net/zxdh/zxdh_rxtx.c
>  create mode 100644 drivers/net/zxdh/zxdh_tables.c
>  create mode 100644 drivers/net/zxdh/zxdh_tables.h
> 

Building with address-of-packed structure warning produces this warning.
Is it fixable?


[1589/3228] Compiling C object 
drivers/libtmp_rte_net_zxdh.a.p/net_zxdh_zxdh_ethdev_ops.c.o
../drivers/net/zxdh/zxdh_ethdev_ops.c: In function ‘zxdh_dev_rss_reta_update’:
../drivers/net/zxdh/zxdh_ethdev_ops.c:921:59: warning: taking address of packed 
member of ‘union ’ may result in an unaligned pointer value 
[-Waddress-of-packed-member]
  921 | ret = zxdh_rss_table_set(hw->vport.vport, 
&msg.data.rss_reta);
  |   
^~
../drivers/net/zxdh/zxdh_ethdev_ops.c: In function ‘zxdh_dev_rss_reta_query’:
../drivers/net/zxdh/zxdh_ethdev_ops.c:979:59: warning: taking address of packed 
member of ‘union ’ may result in an unaligned pointer value 
[-Waddress-of-packed-member]
  979 | ret = zxdh_rss_table_get(hw->vport.vport, 
&reply_msg.reply_body.rss_reta);
  |   
^~
../drivers/net/zxdh/zxdh_ethdev_ops.c:993:44: warning: taking address of packed 
member of ‘union ’ may result in an unaligned pointer value 
[-Waddress-of-packed-member]
  993 | struct zxdh_rss_reta *reta_table = 
&reply_msg.reply_body.rss_reta;
  |
^~
../drivers/net/zxdh/zxdh_ethdev_ops.c: In function ‘zxdh_rss_configure’:
../drivers/net/zxdh/zxdh_ethdev_ops.c:1247:59: warning: taking address of 
packed member of ‘union ’ may result in an unaligned pointer value 
[-Waddress-of-packed-member]
 1247 | ret = zxdh_rss_table_set(hw-

[PATCH] dts: fix hugepage configuration bug

[Nicholas Pratte]

The dts framework checks for total hugepages of a specific size on a
system without first checking if such hugepages are supported. This
results in unhelpful error messages, since attempting to grab
information from a file/directory that does not exist creates undefined
behavior. This quick reorientation of the code prevents this, and
allows for easier error assessment.

Signed-off-by: Nicholas Pratte 
---
 dts/framework/testbed_model/linux_session.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dts/framework/testbed_model/linux_session.py 
b/dts/framework/testbed_model/linux_session.py
index bda2d448f7..e3732f0827 100644
--- a/dts/framework/testbed_model/linux_session.py
+++ b/dts/framework/testbed_model/linux_session.py
@@ -90,12 +90,12 @@ def setup_hugepages(self, number_of: int, hugepage_size: 
int, force_first_numa:
 ConfigurationError: If the given `hugepage_size` is not supported 
by the OS.
 """
 self._logger.info("Getting Hugepage information.")
-hugepages_total = self._get_hugepages_total(hugepage_size)
 if (
 f"hugepages-{hugepage_size}kB"
 not in self.send_command("ls /sys/kernel/mm/hugepages").stdout
 ):
 raise ConfigurationError("hugepage size not supported by operating 
system")
+hugepages_total = self._get_hugepages_total(hugepage_size)
 self._numa_nodes = self._get_numa_nodes()
 
 if force_first_numa or hugepages_total < number_of:
-- 
2.47.1

[PATCH v2] net/i40e/base: fix the debug print format

[Jaroslaw Ilgiewicz]

This patch modifies format specifier in debug prints to match to the
change of time variables from 64 bit to 32 bit.

Fixes: d980a401b137 ("net/i40e/base: add NVM acquire with custom timeout")
Cc: sta...@dpdk.org

Signed-off-by: Zhichao Zeng 
Signed-off-by: Jaroslaw Ilgiewicz 
---
 drivers/net/i40e/base/README |  2 +-
 drivers/net/i40e/base/i40e_nvm.c | 10 --
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README
index c5305ffae0..188633dde3 100644
--- a/drivers/net/i40e/base/README
+++ b/drivers/net/i40e/base/README
@@ -6,7 +6,7 @@ Intel® I40E driver
 ==
 
 This directory contains source code of i40e base driver generated on
-2024-08-30 released by the team which develops
+2025-01-15 released by the team which develops
 basic drivers for any i40e NIC. The directory of base/ contains the
 original source package.
 This driver is valid for the product(s) listed below
diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c
index 3e16a0d997..890c1dfc8a 100644
--- a/drivers/net/i40e/base/i40e_nvm.c
+++ b/drivers/net/i40e/base/i40e_nvm.c
@@ -145,9 +145,8 @@ enum i40e_status_code i40e_acquire_nvm_ex(struct i40e_hw 
*hw,
 
if (ret_code)
i40e_debug(hw, I40E_DEBUG_NVM,
-  "NVM acquire type %d failed time_left=%llu ret=%d 
aq_err=%d\n",
-  access, (unsigned long long)time_left, ret_code,
-  hw->aq.asq_last_status);
+  "NVM acquire type %d failed time_left=%" PRIu32 " 
ret=%d aq_err=%d\n",
+  access, time_left, ret_code, hw->aq.asq_last_status);
 
if (ret_code && time_left) {
/* Poll until the current NVM owner timeouts */
@@ -168,9 +167,8 @@ enum i40e_status_code i40e_acquire_nvm_ex(struct i40e_hw 
*hw,
if (ret_code != I40E_SUCCESS) {
hw->nvm.hw_semaphore_timeout = 0;
i40e_debug(hw, I40E_DEBUG_NVM,
-  "NVM acquire timed out, wait %llu ms before 
trying again. status=%d aq_err=%d\n",
-  (unsigned long long)time_left, ret_code,
-  hw->aq.asq_last_status);
+  "NVM acquire timed out, wait %" PRIu32 " ms 
before trying again. status=%d aq_err=%d\n",
+  time_left, ret_code, hw->aq.asq_last_status);
}
}
 
-- 
2.34.1

-
Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial 
Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | 
Kapital zakladowy 200.000 PLN.
Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z 
dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach 
handlowych.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i 
moze zawierac informacje poufne. W razie przypadkowego otrzymania tej 
wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; 
jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole 
use of the intended recipient(s). If you are not the intended recipient, please 
contact the sender and delete all copies; any review or distribution by others 
is strictly prohibited.

Re: [PATCH 1/3] net/hns3: fix simple Tx path incorrect free the mbuf

[huangdengdui]

On 2025/1/10 1:03, Stephen Hemminger wrote:
> On Thu, 9 Jan 2025 15:43:12 +0800
> huangdengdui  wrote:
> 
>> On 2025/1/9 0:57, Stephen Hemminger wrote:
>>> On Wed, 8 Jan 2025 10:40:43 +0800
>>> Jie Hai  wrote:
>>>   
 On 2024/12/31 1:55, Stephen Hemminger wrote:  
> On Mon, 30 Dec 2024 14:54:03 +0800
> Jie Hai  wrote:
> 
>> From: Jie Hai 
>> To: , , ,  
>> , , Chengwen 
>> Feng  , "Wei Hu (Xavier)" 
>> ,  Huisong Li 
>> CC: , 
>> Subject: [PATCH 1/3] net/hns3: fix simple Tx path incorrect free the mbuf
>> Date: Mon, 30 Dec 2024 14:54:03 +0800
>> X-Mailer: git-send-email 2.22.0
>>
>> From: Dengdui Huang 
>>
>> When RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload is not set,
>> use rte_pktmbuf_free_seg() to free the mbuf.
>>
>> Fixes: 7ef933908f04 ("net/hns3: add simple Tx path")
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Dengdui Huang 
>> Signed-off-by: Jie Hai 
>
> What about the fast free case which is using rte_mempool_put_bulk when
> it should use rte_pktmbuf_free_bulk instead?
>
> 
 Hi, Stephen Hemminger,

 During the fast free case, the performance of using
 rte_mempool_put_bulk is higher than that of using
 rte_pktmbuf_free_bulk because other references
 to mbuf do not need to be considered. So it's better
   to not change.

 Thanks,
 Jie Hai  
>>>
>>> The problem is that having an open coded version of this buried in
>>> one driver is a long term potential proble>
>>> If you really think that optimizing free like this is noticeable, then
>>> why not make a new function "rte_pktmuf_fast_free_bulk" and put it in the
>>> regular mbuf library.
>>>   
>>
>> Do you mean to add the following functions to the library?
>>
>> void rte_pktmbuf_fast_free_bulk(struct rte_mbuf **mbufs, unsigned int count)
>> {
>>  rte_mempool_put_bulk(mbufs[0]->pool, (void **)mbufs, count);
>> }
> 
> Yes something like that. Or call it rte_mbuf_raw_free_bulk to align with
> what rte_mbuf_raw_free(). And maybe add some debug assertions to make sure
> that mbuf is not cloned, indirect or has refcnt.
> 
> The concern is that this optimization might put an mbuf in the pool
> that has different properties than the normal free path.
> And that all semantics of allocation/free should be in rte_mbuf code to
> allow for future optimizations.

"Morten Brørup" has submitted a patch to implement this function.[1]
Currently, multiple drivers use rte_mempool_put_bulk to release mbufs.
We can modify them later so that all drivers use rte_mbuf_fast_free_bulk to 
free mbufs.

The current patch is a function problem, which has caused troubles to hns3 
users. Can we merge it first?

[1]https://inbox.dpdk.org/dev/20250114163951.125667-1...@smartsharesystems.com/

> 
> 
>>
>> The driver uses rte_mempool_put_bulk only when the following conditions are 
>> met:
>> 1. All mbufs comes from the same mempool
>> 2. All mbufs have only one reference.
>> 3. All mbufs have only one segment.
>> So the rte_pktmbuf_fast_free_bulk function is just a wrapper around the 
>> rte_mempool_put_bulk function.
> 

[PATCH v12 2/3] drivers/common: add diagnostics macros to make code portable

[Andre Muezerie]

It was a common pattern to have "GCC diagnostic ignored" pragmas
sprinkled over the code and only activate these pragmas for certain
compilers (gcc and clang). Clang supports GCC's pragma for
compatibility with existing source code, so #pragma GCC diagnostic
and #pragma clang diagnostic are synonyms for Clang
(https://clang.llvm.org/docs/UsersManual.html).

Now that effort is being made to make the code compatible with MSVC
these expressions would become more complex. It makes sense to hide
this complexity behind macros. This makes maintenance easier as these
macros are defined in a single place. As a plus the code becomes
more readable as well.

Signed-off-by: Andre Muezerie 
---
 drivers/common/idpf/idpf_common_rxtx_avx512.c | 77 ++-
 1 file changed, 39 insertions(+), 38 deletions(-)

diff --git a/drivers/common/idpf/idpf_common_rxtx_avx512.c 
b/drivers/common/idpf/idpf_common_rxtx_avx512.c
index b8450b03ae..fefc0a05ca 100644
--- a/drivers/common/idpf/idpf_common_rxtx_avx512.c
+++ b/drivers/common/idpf/idpf_common_rxtx_avx512.c
@@ -6,10 +6,6 @@
 #include "idpf_common_device.h"
 #include "idpf_common_rxtx.h"
 
-#ifndef __INTEL_COMPILER
-#pragma GCC diagnostic ignored "-Wcast-qual"
-#endif
-
 #define IDPF_DESCS_PER_LOOP_AVX 8
 #define PKTLEN_SHIFT 10
 
@@ -34,7 +30,7 @@ idpf_singleq_rearm_common(struct idpf_rx_queue *rxq)
dma_addr0 = _mm_setzero_si128();
for (i = 0; i < IDPF_VPMD_DESCS_PER_LOOP; i++) {
rxp[i] = &rxq->fake_mbuf;
-   _mm_store_si128((__m128i *)&rxdp[i].read,
+   _mm_store_si128((__m128i 
*)RTE_IGNORE_CAST_QUAL(&rxdp[i].read),
dma_addr0);
}
}
@@ -108,8 +104,10 @@ idpf_singleq_rearm_common(struct idpf_rx_queue *rxq)
dma_addr4_7 = _mm512_add_epi64(dma_addr4_7, hdr_room);
 
/* flush desc with pa dma_addr */
-   _mm512_store_si512((__m512i *)&rxdp->read, dma_addr0_3);
-   _mm512_store_si512((__m512i *)&(rxdp + 4)->read, dma_addr4_7);
+   _mm512_store_si512((__m512i *)RTE_IGNORE_CAST_QUAL(&rxdp->read),
+   dma_addr0_3);
+   _mm512_store_si512((__m512i *)RTE_IGNORE_CAST_QUAL(&(rxdp + 
4)->read),
+   dma_addr4_7);
}
 
rxq->rxrearm_start += IDPF_RXQ_REARM_THRESH;
@@ -164,8 +162,8 @@ idpf_singleq_rearm(struct idpf_rx_queue *rxq)
dma_addr0 = _mm_setzero_si128();
for (i = 0; i < IDPF_VPMD_DESCS_PER_LOOP; i++) {
rxp[i] = &rxq->fake_mbuf;
-   _mm_storeu_si128((__m128i 
*)&rxdp[i].read,
-dma_addr0);
+   _mm_storeu_si128((__m128i 
*)RTE_IGNORE_CAST_QUAL
+   (&rxdp[i].read), 
dma_addr0);
}
}

rte_atomic_fetch_add_explicit(&rxq->rx_stats.mbuf_alloc_failed,
@@ -216,10 +214,10 @@ idpf_singleq_rearm(struct idpf_rx_queue *rxq)
 iovas1);
const __m512i desc6_7 = _mm512_bsrli_epi128(desc4_5, 8);
 
-   _mm512_storeu_si512((void *)rxdp, desc0_1);
-   _mm512_storeu_si512((void *)(rxdp + 2), desc2_3);
-   _mm512_storeu_si512((void *)(rxdp + 4), desc4_5);
-   _mm512_storeu_si512((void *)(rxdp + 6), desc6_7);
+   _mm512_storeu_si512((void *)RTE_IGNORE_CAST_QUAL(rxdp), 
desc0_1);
+   _mm512_storeu_si512((void *)RTE_IGNORE_CAST_QUAL((rxdp + 2)), 
desc2_3);
+   _mm512_storeu_si512((void *)RTE_IGNORE_CAST_QUAL((rxdp + 4)), 
desc4_5);
+   _mm512_storeu_si512((void *)RTE_IGNORE_CAST_QUAL((rxdp + 6)), 
desc6_7);
 
rxp += IDPF_DESCS_PER_LOOP_AVX;
rxdp += IDPF_DESCS_PER_LOOP_AVX;
@@ -337,28 +335,28 @@ _idpf_singleq_recv_raw_pkts_avx512(struct idpf_rx_queue 
*rxq,
 
__m512i raw_desc0_3, raw_desc4_7;
const __m128i raw_desc7 =
-   _mm_load_si128((void *)(rxdp + 7));
+   _mm_load_si128((void *)RTE_IGNORE_CAST_QUAL(rxdp + 7));
rte_compiler_barrier();
const __m128i raw_desc6 =
-   _mm_load_si128((void *)(rxdp + 6));
+   _mm_load_si128((void *)RTE_IGNORE_CAST_QUAL(rxdp + 6));
rte_compiler_barrier();
const __m128i raw_desc5 =
-   _mm_load_si128((void *)(rxdp + 5));
+   _mm_load_si128((void *)RTE_IGNORE_CAST_QUAL(rxdp + 5));
rte_compiler_barrier();
const __m128i raw_desc4 =
-   

[PATCH v12 3/3] drivers/net: add diagnostics macros to make code portable

[Andre Muezerie]

It was a common pattern to have "GCC diagnostic ignored" pragmas
sprinkled over the code and only activate these pragmas for certain
compilers (gcc and clang). Clang supports GCC's pragma for
compatibility with existing source code, so #pragma GCC diagnostic
and #pragma clang diagnostic are synonyms for Clang
(https://clang.llvm.org/docs/UsersManual.html).

Now that effort is being made to make the code compatible with MSVC
these expressions would become more complex. It makes sense to hide
this complexity behind macros. This makes maintenance easier as these
macros are defined in a single place. As a plus the code becomes
more readable as well.

Signed-off-by: Andre Muezerie 
---
 drivers/net/axgbe/axgbe_rxtx.h|  9 --
 drivers/net/cpfl/cpfl_rxtx_vec_common.h   |  4 -
 drivers/net/dpaa2/dpaa2_rxtx.c| 16 +---
 drivers/net/fm10k/fm10k_rxtx_vec.c| 22 +++--
 drivers/net/hns3/hns3_rxtx_vec_neon.h |  7 +-
 .../net/i40e/i40e_recycle_mbufs_vec_common.c  |  2 -
 drivers/net/i40e/i40e_rxtx_common_avx.h   | 24 +++---
 drivers/net/i40e/i40e_rxtx_vec_altivec.c  | 22 ++---
 drivers/net/i40e/i40e_rxtx_vec_avx2.c | 40 +
 drivers/net/i40e/i40e_rxtx_vec_avx512.c   | 30 ---
 drivers/net/i40e/i40e_rxtx_vec_common.h   |  4 -
 drivers/net/i40e/i40e_rxtx_vec_neon.c | 44 +-
 drivers/net/i40e/i40e_rxtx_vec_sse.c  | 34 
 drivers/net/iavf/iavf_rxtx_vec_avx2.c | 84 ++-
 drivers/net/iavf/iavf_rxtx_vec_avx512.c   | 78 -
 drivers/net/iavf/iavf_rxtx_vec_common.h   | 12 ++-
 drivers/net/iavf/iavf_rxtx_vec_neon.c | 27 +++---
 drivers/net/iavf/iavf_rxtx_vec_sse.c  | 56 +++--
 drivers/net/ice/ice_rxtx_common_avx.h | 24 +++---
 drivers/net/ice/ice_rxtx_vec_avx2.c   | 82 +-
 drivers/net/ice/ice_rxtx_vec_avx512.c | 72 
 drivers/net/ice/ice_rxtx_vec_common.h |  4 -
 drivers/net/ice/ice_rxtx_vec_sse.c| 42 --
 drivers/net/idpf/idpf_rxtx_vec_common.h   |  4 -
 .../ixgbe/ixgbe_recycle_mbufs_vec_common.c|  2 -
 drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c   | 18 ++--
 drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c| 22 +++--
 drivers/net/mlx5/mlx5_flow.c  |  5 +-
 drivers/net/mlx5/mlx5_rxtx_vec_altivec.h  |  5 --
 drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 18 ++--
 drivers/net/mlx5/mlx5_rxtx_vec_sse.h  | 76 ++---
 drivers/net/ngbe/ngbe_rxtx_vec_neon.c | 11 ++-
 drivers/net/tap/tap_flow.c|  6 +-
 drivers/net/txgbe/txgbe_rxtx_vec_neon.c   |  8 +-
 drivers/net/virtio/virtio_rxtx_simple.c   |  4 -
 35 files changed, 445 insertions(+), 473 deletions(-)

diff --git a/drivers/net/axgbe/axgbe_rxtx.h b/drivers/net/axgbe/axgbe_rxtx.h
index a326ba9ac8..f5f74a0a39 100644
--- a/drivers/net/axgbe/axgbe_rxtx.h
+++ b/drivers/net/axgbe/axgbe_rxtx.h
@@ -6,15 +6,6 @@
 #ifndef _AXGBE_RXTX_H_
 #define _AXGBE_RXTX_H_
 
-/* to suppress gcc warnings related to descriptor casting*/
-#ifdef RTE_TOOLCHAIN_GCC
-#pragma GCC diagnostic ignored "-Wcast-qual"
-#endif
-
-#ifdef RTE_TOOLCHAIN_CLANG
-#pragma GCC diagnostic ignored "-Wcast-qual"
-#endif
-
 /* Descriptor related defines */
 #define AXGBE_MAX_RING_DESC4096 /*should be power of 2*/
 #define AXGBE_TX_DESC_MIN_FREE (AXGBE_MAX_RING_DESC >> 3)
diff --git a/drivers/net/cpfl/cpfl_rxtx_vec_common.h 
b/drivers/net/cpfl/cpfl_rxtx_vec_common.h
index 479e1ddcb9..5b98f86932 100644
--- a/drivers/net/cpfl/cpfl_rxtx_vec_common.h
+++ b/drivers/net/cpfl/cpfl_rxtx_vec_common.h
@@ -11,10 +11,6 @@
 #include "cpfl_ethdev.h"
 #include "cpfl_rxtx.h"
 
-#ifndef __INTEL_COMPILER
-#pragma GCC diagnostic ignored "-Wcast-qual"
-#endif
-
 #define CPFL_SCALAR_PATH   0
 #define CPFL_VECTOR_PATH   1
 #define CPFL_RX_NO_VECTOR_FLAGS (  \
diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c
index e3b6c7e460..fd73c655dd 100644
--- a/drivers/net/dpaa2/dpaa2_rxtx.c
+++ b/drivers/net/dpaa2/dpaa2_rxtx.c
@@ -1962,14 +1962,6 @@ dpaa2_dev_tx_ordered(void *queue, struct rte_mbuf 
**bufs, uint16_t nb_pkts)
return num_tx;
 }
 
-#if defined(RTE_TOOLCHAIN_GCC)
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wcast-qual"
-#elif defined(RTE_TOOLCHAIN_CLANG)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wcast-qual"
-#endif
-
 /* This function loopbacks all the received packets.*/
 uint16_t
 dpaa2_dev_loopback_rx(void *queue,
@@ -2083,7 +2075,8 @@ dpaa2_dev_loopback_rx(void *queue,
if (unlikely((status & QBMAN_DQ_STAT_VALIDFRAME) == 0))
continue;
}
-   fd[num_rx] = (struct qbman_fd *)qbman_result_DQ_fd(dq_storage);
+   fd[num_rx] = (struct qbman_fd *)RTE_IGNORE_CAST_QUAL
+   (q

[PATCH v12 0/3] add diagnostics macros to make code portable

[Andre Muezerie]

It was a common pattern to have "GCC diagnostic ignored" pragmas
sprinkled over the code and only activate these pragmas for certain
compilers (gcc and clang). Clang supports GCC's pragma for
compatibility with existing source code, so #pragma GCC diagnostic
and #pragma clang diagnostic are synonyms for Clang
(https://clang.llvm.org/docs/UsersManual.html).

Now that effort is being made to make the code compatible with MSVC
these expressions would become more complex. It makes sense to hide
this complexity behind macros. This makes maintenance easier as these
macros are defined in a single place. As a plus the code becomes
more readable as well.

v12:
 * Added macro RTE_IGNORE_CAST_QUAL and used it as a more compact and
   readable form to suppress warnings where a cast is used to remove
   a type qualifier.

v11:
 * Added __rte_diagnostic_ignored_wcast_qual to a few more places where
   it was needed.

v10:
 * Added __rte_diagnostic_ignored_wcast_qual to a few more places where
   it was needed.

v9:
 * Added __rte_diagnostic_ignored_wcast_qual to a few more places where
   it was needed.

v8:
 * Added __rte_diagnostic_ignored_wcast_qual to a few more places where
   it was needed.

v7:
 * Added __rte_diagnostic_ignored_wcast_qual to a few more places where
   it was needed.

v6:
 * Added __rte_diagnostic_ignored_wcast_qual to a few more places where
   it was needed.

v5:
 * Added __rte_diagnostic_ignored_wcast_qual to a few more places where
   it was needed.

v4:
 * Added __rte_diagnostic_ignored_wcast_qual to a few more places where
   it was needed.

v3:
 * Added __rte_diagnostic_ignored_wcast_qual to a few more places where
   it was needed.

v2:
 * Removed __rte_diagnostic_ignored_wstrict_aliasing (introduced
   in v1).
 * Removed the pragmas from many files where they were not needed.
 * In the files where the pragmas were indeed needed, reduced the
   scope during which they are active, reducing the chance that
   unforeseen issues are hidden due to warning suppression.

Andre Muezerie (3):
  lib/eal: add diagnostics macros to make code portable
  drivers/common: add diagnostics macros to make code portable
  drivers/net: add diagnostics macros to make code portable

 drivers/common/idpf/idpf_common_rxtx_avx512.c | 77 -
 drivers/net/axgbe/axgbe_rxtx.h|  9 --
 drivers/net/cpfl/cpfl_rxtx_vec_common.h   |  4 -
 drivers/net/dpaa2/dpaa2_rxtx.c| 16 +---
 drivers/net/fm10k/fm10k_rxtx_vec.c| 22 +++--
 drivers/net/hns3/hns3_rxtx_vec_neon.h |  7 +-
 .../net/i40e/i40e_recycle_mbufs_vec_common.c  |  2 -
 drivers/net/i40e/i40e_rxtx_common_avx.h   | 24 +++---
 drivers/net/i40e/i40e_rxtx_vec_altivec.c  | 22 ++---
 drivers/net/i40e/i40e_rxtx_vec_avx2.c | 40 +
 drivers/net/i40e/i40e_rxtx_vec_avx512.c   | 30 ---
 drivers/net/i40e/i40e_rxtx_vec_common.h   |  4 -
 drivers/net/i40e/i40e_rxtx_vec_neon.c | 44 +-
 drivers/net/i40e/i40e_rxtx_vec_sse.c  | 34 
 drivers/net/iavf/iavf_rxtx_vec_avx2.c | 84 ++-
 drivers/net/iavf/iavf_rxtx_vec_avx512.c   | 78 -
 drivers/net/iavf/iavf_rxtx_vec_common.h   | 12 ++-
 drivers/net/iavf/iavf_rxtx_vec_neon.c | 27 +++---
 drivers/net/iavf/iavf_rxtx_vec_sse.c  | 56 +++--
 drivers/net/ice/ice_rxtx_common_avx.h | 24 +++---
 drivers/net/ice/ice_rxtx_vec_avx2.c   | 82 +-
 drivers/net/ice/ice_rxtx_vec_avx512.c | 72 
 drivers/net/ice/ice_rxtx_vec_common.h |  4 -
 drivers/net/ice/ice_rxtx_vec_sse.c| 42 --
 drivers/net/idpf/idpf_rxtx_vec_common.h   |  4 -
 .../ixgbe/ixgbe_recycle_mbufs_vec_common.c|  2 -
 drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c   | 18 ++--
 drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c| 22 +++--
 drivers/net/mlx5/mlx5_flow.c  |  5 +-
 drivers/net/mlx5/mlx5_rxtx_vec_altivec.h  |  5 --
 drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 18 ++--
 drivers/net/mlx5/mlx5_rxtx_vec_sse.h  | 76 ++---
 drivers/net/ngbe/ngbe_rxtx_vec_neon.c | 11 ++-
 drivers/net/tap/tap_flow.c|  6 +-
 drivers/net/txgbe/txgbe_rxtx_vec_neon.c   |  8 +-
 drivers/net/virtio/virtio_rxtx_simple.c   |  4 -
 lib/eal/include/rte_common.h  | 26 ++
 37 files changed, 510 insertions(+), 511 deletions(-)

--
2.47.0.vfs.0.3

[PATCH v12 1/3] lib/eal: add diagnostics macros to make code portable

[Andre Muezerie]

It was a common pattern to have "GCC diagnostic ignored" pragmas
sprinkled over the code and only activate these pragmas for certain
compilers (gcc and clang). Clang supports GCC's pragma for
compatibility with existing source code, so #pragma GCC diagnostic
and #pragma clang diagnostic are synonyms for Clang
(https://clang.llvm.org/docs/UsersManual.html).

Now that effort is being made to make the code compatible with MSVC
these expressions would become more complex. It makes sense to hide
this complexity behind macros. This makes maintenance easier as these
macros are defined in a single place. As a plus the code becomes
more readable as well.

Signed-off-by: Andre Muezerie 
---
 lib/eal/include/rte_common.h | 26 ++
 1 file changed, 26 insertions(+)

diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index 4d299f2b36..2142dd968d 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -137,6 +137,32 @@ typedef uint16_t unaligned_uint16_t;
 #define RTE_DEPRECATED(x)
 #endif
 
+/*
+ * Macro to ignore whenever a pointer is cast so as to remove a type
+ * qualifier from the target type.
+ */
+#if !defined __INTEL_COMPILER && !defined RTE_TOOLCHAIN_MSVC
+#define __rte_diagnostic_ignored_wcast_qual \
+   _Pragma("GCC diagnostic ignored \"-Wcast-qual\"")
+#else
+#define __rte_diagnostic_ignored_wcast_qual
+#endif
+
+/*
+ * Macros to cause the compiler to remember the state of the diagnostics as of
+ * each push, and restore to that point at each pop.
+ */
+#if !defined __INTEL_COMPILER && !defined RTE_TOOLCHAIN_MSVC
+#define __rte_diagnostic_push _Pragma("GCC diagnostic push")
+#define __rte_diagnostic_pop  _Pragma("GCC diagnostic pop")
+#else
+#define __rte_diagnostic_push
+#define __rte_diagnostic_pop
+#endif
+
+#define RTE_IGNORE_CAST_QUAL(X) \
+   ((uintptr_t)(X))
+
 /**
  * Mark a function or variable to a weak reference.
  */
-- 
2.47.0.vfs.0.3

Re: [PATCH v2] mbuf: add fast free bulk function

[huangdengdui]

On 2025/1/15 0:39, Morten Brørup wrote:
> mbuf: add fast free bulk function
> 
> When putting an mbuf back into its mempool, there are certain requirements
> to the mbuf. Specifically, some of its fields must be initialized.
> 
> These requirements are in fact invariants about free mbufs, held in
> mempools, and thus also apply when allocating an mbuf from a mempool.
> With this in mind, the additional assertions in rte_mbuf_raw_free() were
> moved to __rte_mbuf_raw_sanity_check().
> Furthermore, the assertion regarding pinned external buffer was enhanced;
> it now also asserts that the referenced pinned external buffer has
> refcnt == 1.
> 
> The description of RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE was updated to
> include the remaining requirements, which were missing here.
> 
> And finally:
> A new rte_mbuf_fast_free_bulk() inline function was added for the benefit
> of ethdev drivers supporting fast release of mbufs.
> It asserts these requirements and that the mbufs belong to the specified
> mempool, and then calls rte_mempool_put_bulk().
> 
> Signed-off-by: Morten Brørup 
> ---
> v2:
> * Fixed missing inline.
> ---
>  lib/ethdev/rte_ethdev.h |  6 --
>  lib/mbuf/rte_mbuf.h | 39 +--
>  2 files changed, 41 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> index 1f71cad244..e9267fca79 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -1612,8 +1612,10 @@ struct rte_eth_conf {
>  #define RTE_ETH_TX_OFFLOAD_MULTI_SEGS   RTE_BIT64(15)
>  /**
>   * Device supports optimization for fast release of mbufs.
> - * When set application must guarantee that per-queue all mbufs comes from
> - * the same mempool and has refcnt = 1.
> + * When set application must guarantee that per-queue all mbufs come from 
> the same mempool,
> + * are direct, have refcnt=1, next=NULL and nb_segs=1, as done by 
> rte_pktmbuf_prefree_seg().
> + *
> + * @see rte_mbuf_fast_free_bulk()
>   */
>  #define RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE   RTE_BIT64(16)
>  #define RTE_ETH_TX_OFFLOAD_SECURITY RTE_BIT64(17)
> diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
> index 0d2e0e64b3..7590d82689 100644
> --- a/lib/mbuf/rte_mbuf.h
> +++ b/lib/mbuf/rte_mbuf.h
> @@ -568,6 +568,10 @@ __rte_mbuf_raw_sanity_check(__rte_unused const struct 
> rte_mbuf *m)
>   RTE_ASSERT(rte_mbuf_refcnt_read(m) == 1);
>   RTE_ASSERT(m->next == NULL);
>   RTE_ASSERT(m->nb_segs == 1);
> + RTE_ASSERT(!RTE_MBUF_CLONED(m));
> + RTE_ASSERT(!RTE_MBUF_HAS_EXTBUF(m) ||
> + (RTE_MBUF_HAS_PINNED_EXTBUF(m) &&
> + rte_mbuf_ext_refcnt_read(m->shinfo) == 1));
>   __rte_mbuf_sanity_check(m, 0);
>  }
>  
> @@ -623,12 +627,43 @@ static inline struct rte_mbuf 
> *rte_mbuf_raw_alloc(struct rte_mempool *mp)
>  static __rte_always_inline void
>  rte_mbuf_raw_free(struct rte_mbuf *m)
>  {
> - RTE_ASSERT(!RTE_MBUF_CLONED(m) &&
> -   (!RTE_MBUF_HAS_EXTBUF(m) || RTE_MBUF_HAS_PINNED_EXTBUF(m)));
>   __rte_mbuf_raw_sanity_check(m);
>   rte_mempool_put(m->pool, m);
>  }
>  
> +/**
> + * Put a bulk of mbufs allocated from the same mempool back into the mempool.
> + *
> + * The caller must ensure that the mbufs come from the specified mempool,
> + * are direct and properly reinitialized (refcnt=1, next=NULL, nb_segs=1), 
> as done by
> + * rte_pktmbuf_prefree_seg().
> + *
> + * This function should be used with care, when optimization is
> + * required. For standard needs, prefer rte_pktmbuf_free_bulk().
> + *
> + * @see RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE
> + *
> + * @param mp
> + *   The mempool to which the mbufs belong.
> + * @param mbufs
> + *   Array of pointers to packet mbufs.
> + *   The array must not contain NULL pointers.
> + * @param count
> + *   Array size.
> + */
> +static __rte_always_inline void
> +rte_mbuf_fast_free_bulk(struct rte_mempool *mp, struct rte_mbuf **mbufs, 
> unsigned int count)
> +{
> + for (unsigned int idx = 0; idx < count; idx++) {
> + const struct rte_mbuf *m = mbufs[idx];
> + RTE_ASSERT(m != NULL);
> + RTE_ASSERT(m->pool == mp);
> + __rte_mbuf_raw_sanity_check(m);
> + }

Is there some way to avoid executing a loop in non-debug mode? Like the 
following or other better way

#ifdef RTE_LIBRTE_MBUF_DEBUG
{
for (unsigned int idx = 0; idx < count; idx++) {
const struct rte_mbuf *m = mbufs[idx];
RTE_ASSERT(m != NULL);
RTE_ASSERT(m->pool == mp);
__rte_mbuf_raw_sanity_check(m);
}
}
#endif

> +
> + rte_mempool_put_bulk(mp, (void **)mbufs, count);

Can the mp be obtained from the mbuf?

> +}
> +
>  /**
>   * The packet mbuf constructor.
>   *

Re: [PATCH v2] net/af_packet: allow changing fanout mode

[Stephen Hemminger]

On Mon,  6 Jan 2025 17:35:08 +0200
Tudor Cornea  wrote:

> This allows us to control the algorithm used to spread traffic between
> sockets, adding more fine grained control. If the user does not
> specify a fanout mode, the PMD driver will default to
> PACKET_FANOUT_HASH.
> 
> Signed-off-by: Tudor Cornea 
> 
> ---
> v2:
> * Renamed the patch
> * Replaced packet_fanout argument with fanout_mode, which allows
> more fine grained control
> ---
>  doc/guides/nics/af_packet.rst |  4 +-
>  drivers/net/af_packet/rte_eth_af_packet.c | 92 ---
>  2 files changed, 83 insertions(+), 13 deletions(-)
> 
> diff --git a/doc/guides/nics/af_packet.rst b/doc/guides/nics/af_packet.rst
> index a343d3a961..3443f95004 100644
> --- a/doc/guides/nics/af_packet.rst
> +++ b/doc/guides/nics/af_packet.rst
> @@ -25,6 +25,8 @@ Some of these, in turn, will be used to configure the 
> PACKET_MMAP settings.
>  *   ``qpairs`` - number of Rx and Tx queues (optional, default 1);
>  *   ``qdisc_bypass`` - set PACKET_QDISC_BYPASS option in AF_PACKET (optional,
>  disabled by default);
> +*   ``fanout_mode`` - set fanout algorithm. Possible choices: 
> hash,lb,cpu,rollover,rnd,qm (optional,
> +default hash);

Use proper punctuation here, need space after comma.
A description of what the differences are or reference to af-packet man page 
would help.
https://www.man7.org/linux/man-pages/man7/packet.7.html
The user should not have to huting to find what "qm" means for example.

Should also address the earlier part in this document that is:
The PACKET_FANOUT_HASH behavior of AF_PACKET is used for frame reception.


>  *   ``blocksz`` - PACKET_MMAP block size (optional, default 4096);
>  *   ``framesz`` - PACKET_MMAP frame size (optional, default 2048B; Note: 
> multiple
>  of 16B);
> @@ -64,7 +66,7 @@ framecnt=512):
>  
>  .. code-block:: console
>  
> -
> --vdev=eth_af_packet0,iface=tap0,blocksz=4096,framesz=2048,framecnt=512,qpairs=1,qdisc_bypass=0
> +
> --vdev=eth_af_packet0,iface=tap0,blocksz=4096,framesz=2048,framecnt=512,qpairs=1,qdisc_bypass=0,fanout_mode=hash
>  
>  Features and Limitations
>  
> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c 
> b/drivers/net/af_packet/rte_eth_af_packet.c
> index ceb8d9356a..8449975384 100644
> --- a/drivers/net/af_packet/rte_eth_af_packet.c
> +++ b/drivers/net/af_packet/rte_eth_af_packet.c
> @@ -36,6 +36,7 @@
>  #define ETH_AF_PACKET_FRAMESIZE_ARG  "framesz"
>  #define ETH_AF_PACKET_FRAMECOUNT_ARG "framecnt"
>  #define ETH_AF_PACKET_QDISC_BYPASS_ARG   "qdisc_bypass"
> +#define ETH_AF_PACKET_FANOUT_MODE_ARG"fanout_mode"
>  
>  #define DFLT_FRAME_SIZE  (1 << 11)
>  #define DFLT_FRAME_COUNT (1 << 9)
> @@ -96,6 +97,7 @@ static const char *valid_arguments[] = {
>   ETH_AF_PACKET_FRAMESIZE_ARG,
>   ETH_AF_PACKET_FRAMECOUNT_ARG,
>   ETH_AF_PACKET_QDISC_BYPASS_ARG,
> + ETH_AF_PACKET_FANOUT_MODE_ARG,
>   NULL
>  };
>  
> @@ -700,6 +702,61 @@ open_packet_iface(const char *key __rte_unused,
>   return 0;
>  }
>  
> +#if defined(PACKET_FANOUT)

Since PACKET_FANOUT has existed since Linux 3.1, the #ifdef
for this can be removed now.


> +#define PACKET_FANOUT_INVALID -1
> +
> +static int
> +get_fanout_group_id(int if_index)
> +{
> + return (getpid() ^ if_index) & 0x;
> +}
> +
> +static int
> +get_fanout_mode(const char *fanout_mode)
> +{
> + int mode = PACKET_FANOUT_FLAG_DEFRAG;
> +
> +#if defined(PACKET_FANOUT_FLAG_ROLLOVER)
No more #ifdefs please

> + mode |= PACKET_FANOUT_FLAG_ROLLOVER;
> +#endif
> +
> + if (!fanout_mode) {
> + /* Default */
> + mode |= PACKET_FANOUT_HASH;
> + } else if (!strcmp(fanout_mode, "hash")) {
> + mode |= PACKET_FANOUT_HASH;
> + } else if (!strcmp(fanout_mode, "lb")) {
> + mode |= PACKET_FANOUT_LB;
> + } else if (!strcmp(fanout_mode, "cpu")) {
> + mode |= PACKET_FANOUT_CPU;
> + } else if (!strcmp(fanout_mode, "rollover")) {
> + mode |= PACKET_FANOUT_ROLLOVER;
> + } else if (!strcmp(fanout_mode, "rnd")) {
> + mode |= PACKET_FANOUT_RND;
> + } else if (!strcmp(fanout_mode, "qm")) {
> + mode |= PACKET_FANOUT_QM;
> + } else {
> + /* Invalid Fanout Mode */
> + mode = PACKET_FANOUT_INVALID;
> + }

Maybe allow longer names like "load_balance" or "queue_map"
> +
> + return mode;
> +}
> +
> +static int
> +get_fanout(const char *fanout_mode, int if_index)
> +{
> + int group_id = get_fanout_group_id(if_index);
> + int mode = get_fanout_mode(fanout_mode);
> + int fanout = PACKET_FANOUT_INVALID;
> +
> + if (mode != PACKET_FANOUT_INVALID)
> + fanout = group_id | (mode << 16);
> +
> + return fanout;
> +}

This could be simplified as:

static int
get_fanout(const char *fanout_mode, int if_index)
{
int mode = get_fanout_mode(fanout_mode);
if (mod

[PATCH v3] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

[Andre Muezerie]

This patch avoids warnings like the ones below emitted by MSVC:

1)
../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)

2)
../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
signed/unsigned mismatch

The fix for (1) is to use 64-bit shifting when appropriate
(according to what the result is used for).

The fix for (2) is to explicitly cast the variables used in the
comparison.

Signed-off-by: Andre Muezerie 
---
 drivers/net/i40e/i40e_ethdev.c   | 22 +++---
 drivers/net/iavf/iavf_ethdev.c   |  2 +-
 drivers/net/iavf/iavf_rxtx.c |  2 +-
 drivers/net/iavf/iavf_vchnl.c|  2 +-
 drivers/net/ice/base/meson.build | 19 +--
 drivers/net/ice/ice_dcf_sched.c  |  2 +-
 drivers/net/ice/ice_ethdev.c |  4 ++--
 drivers/net/ice/ice_rxtx.c   |  2 +-
 drivers/net/ixgbe/ixgbe_ethdev.c |  2 +-
 drivers/net/vmxnet3/vmxnet3_ethdev.h |  6 +++---
 10 files changed, 35 insertions(+), 28 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 30dcdc68a8..e565c953e2 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -3094,7 +3094,7 @@ i40e_stat_update_48_in_64(struct i40e_hw *hw, uint32_t 
hireg,
/* enlarge the limitation when statistics counters overflowed */
if (offset_loaded) {
if (I40E_RXTX_BYTES_L_48_BIT(*prev_stat) > *stat)
-   *stat += (uint64_t)1 << I40E_48_BIT_WIDTH;
+   *stat += RTE_BIT64(I40E_48_BIT_WIDTH);
*stat += I40E_RXTX_BYTES_H_16_BIT(*prev_stat);
}
*prev_stat = *stat;
@@ -4494,7 +4494,7 @@ i40e_macaddr_remove(struct rte_eth_dev *dev, uint32_t 
index)
pool_sel = dev->data->mac_pool_sel[index];
 
for (i = 0; i < sizeof(pool_sel) * CHAR_BIT; i++) {
-   if (pool_sel & (1ULL << i)) {
+   if (pool_sel & RTE_BIT64(i)) {
if (i == 0)
vsi = pf->main_vsi;
else {
@@ -4630,7 +4630,7 @@ i40e_dev_rss_reta_update(struct rte_eth_dev *dev,
for (i = 0; i < reta_size; i++) {
idx = i / RTE_ETH_RETA_GROUP_SIZE;
shift = i % RTE_ETH_RETA_GROUP_SIZE;
-   if (reta_conf[idx].mask & (1ULL << shift))
+   if (reta_conf[idx].mask & RTE_BIT64(shift))
lut[i] = reta_conf[idx].reta[shift];
}
ret = i40e_set_rss_lut(pf->main_vsi, lut, reta_size);
@@ -4674,7 +4674,7 @@ i40e_dev_rss_reta_query(struct rte_eth_dev *dev,
for (i = 0; i < reta_size; i++) {
idx = i / RTE_ETH_RETA_GROUP_SIZE;
shift = i % RTE_ETH_RETA_GROUP_SIZE;
-   if (reta_conf[idx].mask & (1ULL << shift))
+   if (reta_conf[idx].mask & RTE_BIT64(shift))
reta_conf[idx].reta[shift] = lut[i];
}
 
@@ -6712,7 +6712,7 @@ i40e_vmdq_setup(struct rte_eth_dev *dev)
loop = sizeof(vmdq_conf->pool_map[0].pools) * CHAR_BIT;
for (i = 0; i < vmdq_conf->nb_pool_maps; i++) {
for (j = 0; j < loop && j < pf->nb_cfg_vmdq_vsi; j++) {
-   if (vmdq_conf->pool_map[i].pools & (1UL << j)) {
+   if (vmdq_conf->pool_map[i].pools & RTE_BIT64(j)) {
PMD_INIT_LOG(INFO, "Add vlan %u to vmdq pool 
%u",
vmdq_conf->pool_map[i].vlan_id, j);
 
@@ -6761,7 +6761,7 @@ i40e_stat_update_32(struct i40e_hw *hw,
*stat = (uint64_t)(new_data - *offset);
else
*stat = (uint64_t)((new_data +
-   ((uint64_t)1 << I40E_32_BIT_WIDTH)) - *offset);
+   RTE_BIT64(I40E_32_BIT_WIDTH)) - *offset);
 }
 
 static void
@@ -6789,7 +6789,7 @@ i40e_stat_update_48(struct i40e_hw *hw,
*stat = new_data - *offset;
else
*stat = (uint64_t)((new_data +
-   ((uint64_t)1 << I40E_48_BIT_WIDTH)) - *offset);
+   RTE_BIT64(I40E_48_BIT_WIDTH)) - *offset);
 
*stat &= I40E_48_BIT_MASK;
 }
@@ -7730,7 +7730,7 @@ i40e_config_hena(const struct i40e_adapter *adapter, 
uint64_t flags)
return hena;
 
for (i = RTE_ETH_FLOW_UNKNOWN + 1; i < I40E_FLOW_TYPE_MAX; i++) {
-   if (flags & (1ULL << i))
+   if (flags & RTE_BIT64(i))
hena |= adapter->pctypes_tbl[i];
}
 
@@ -7749,7 +7749,7 @@ i40e_parse_hena(const struct i40e_adapter *adapter, 
uint64_t flags)
 
for (i = RTE_ETH_FLOW_UNKNOWN + 1; i < I40E_FLOW_TYPE_MAX; i++) {
if (flags & adapter->pctypes_tbl[i])
-   rss_hf |= (1ULL << i);
+   rss_hf |= RTE_BIT64(i);
}
return rss_hf;
 }
@@ -10

Re: [PATCH v2] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

[Andre Muezerie]

On Tue, Jan 14, 2025 at 10:41:53AM -0800, Stephen Hemminger wrote:
> On Mon,  6 Jan 2025 13:16:55 -0800
> Andre Muezerie  wrote:
> 
> > This patch avoids warnings like the ones below emitted by MSVC:
> > 
> > 1)
> > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
> > result of 32-bit shift implicitly converted to 64 bits
> > (was 64-bit shift intended?)
> > 
> > 2)
> > ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
> > signed/unsigned mismatch
> > 
> > The fix for (1) is to use 64-bit shifting when appropriate
> > (according to what the result is used for).
> > 
> > The fix for (2) is to explicitly cast the variables used in the
> > comparison.
> > 
> > Signed-off-by: Andre Muezerie 
> > ---
> >  drivers/net/i40e/i40e_ethdev.c   | 22 +++---
> >  drivers/net/iavf/iavf_ethdev.c   |  2 +-
> >  drivers/net/iavf/iavf_rxtx.c |  2 +-
> >  drivers/net/iavf/iavf_vchnl.c|  2 +-
> >  drivers/net/ice/base/ice_flg_rd.c|  4 ++--
> >  drivers/net/ice/base/ice_parser_rt.c | 16 
> >  drivers/net/ice/base/ice_xlt_kb.c|  2 +-
> >  drivers/net/ice/base/meson.build | 19 +--
> 
> Patches to base driver need to be avoided if at all possible.
> Please resubmit without that part

Thanks for the information. I sent out a v3 for this series.
It does contain _coding style issues_ for preexisting code.
Hopefuly that can be ignored.

Re: [PATCH v11 0/3] add diagnostics macros to make code portable

[Andre Muezerie]

On Wed, Jan 08, 2025 at 09:20:27AM +, Bruce Richardson wrote:
> On Tue, Jan 07, 2025 at 06:46:48PM -0800, Andre Muezerie wrote:
> > On Mon, Jan 06, 2025 at 11:00:15AM +, Bruce Richardson wrote:
> > > On Fri, Jan 03, 2025 at 01:26:34PM -0800, Andre Muezerie wrote:
> > > > On Fri, Jan 03, 2025 at 11:24:02AM -0800, Stephen Hemminger wrote:
> > > > > On Fri,  3 Jan 2025 07:36:48 -0800
> > > > > Andre Muezerie  wrote:
> > > > > 
> > > > > > From: Andre Muezerie 
> > > > > > To: andre...@linux.microsoft.com
> > > > > > Cc: dev@dpdk.org,  step...@networkplumber.org
> > > > > > Subject: [PATCH v11 0/3] add diagnostics macros to make code 
> > > > > > portable
> > > > > > Date: Fri,  3 Jan 2025 07:36:48 -0800
> > > > > > X-Mailer: git-send-email 1.8.3.1
> > > > > > 
> > > > > > It was a common pattern to have "GCC diagnostic ignored" pragmas
> > > > > > sprinkled over the code and only activate these pragmas for certain
> > > > > > compilers (gcc and clang). Clang supports GCC's pragma for
> > > > > > compatibility with existing source code, so #pragma GCC diagnostic
> > > > > > and #pragma clang diagnostic are synonyms for Clang
> > > > > > (https://clang.llvm.org/docs/UsersManual.html).
> > > > > > 
> > > > > > Now that effort is being made to make the code compatible with MSVC
> > > > > > these expressions would become more complex. It makes sense to hide
> > > > > > this complexity behind macros. This makes maintenance easier as 
> > > > > > these
> > > > > > macros are defined in a single place. As a plus the code becomes
> > > > > > more readable as well.
> > > > > 
> > > > > Since 90% of these cases are about removing const from a pointer,
> > > > > maybe it would be better to have a macro that did that?
> > > > > 
> > > > > Would not work for base driver code which is pretending to be 
> > > > > platform independent.
> > > > 
> > > > Most of the warnings I've seen were about dropping the volatile 
> > > > qualifier, like the one below:
> > > > 
> > > > ../drivers/net/i40e/i40e_rxtx_vec_sse.c:42:32: warning: cast from 
> > > > 'volatile struct i40e_32byte_rx_desc::(unnamed at 
> > > > ../drivers/net/i40e/base/i40e_type.h:803:2) *' to 
> > > > '__attribute__((__vector_size__(2 * sizeof(long long long long *' 
> > > > drops volatile qualifier [-Wcast-qual]
> > > >42 | _mm_store_si128((__m128i 
> > > > *)&rxdp[i].read,
> > > >   |^
> > > > 
> > > > To make sure I understood your suggestion correctly, you're proposing 
> > > > to replace this
> > > > 
> > > > __rte_diagnostic_push
> > > > __rte_diagnostic_ignored_wcast_qual
> > > > _mm_store_si128((__m128i *)&rxdp[i].read, dma_addr0);
> > > > __rte_diagnostic_pop
> > > > 
> > > > 
> > > > with something like this?
> > > > 
> > > > _mm_store_si128(RTE_IGNORE_CAST_QUAL((__m128i *)&rxdp[i].read), 
> > > > dma_addr0);
> > > > 
> > > > This could be done, and I think it does look better, despite the slight 
> > > > line length increase.
> > > 
> > > +1 for this option. One macro can be used to drop all qualifiers, both
> > > const and volatile, right?
> > 
> > Yes, a single macro can drop all qualifiers. I did realize though that the 
> > macro must involve the entire expression - it cannot be used just around 
> > one parameter, unfortunately.
> > 
> For many use cases, those involving pointers, the qualifiers can be cast
> away by passing through a uintptr_t. Just tested this with gcc and clang:
> 
> volatile int x = 5;
> int *y = (int *)(uintptr_t)&x;
> printf("*y = %d\n", *y);
> 
> works without warnings or errors. Does this similarly work with MSVC? If
> so, we can do a macro specifically for pointers types, which should cover
> 99% of what we need.
> 
> /Bruce

Yes, that also works with MSVC. So for the macro you mentioned, is this what 
you had in mind?

old code:
_mm_store_si128((__m128i *)&rxdp[i].read, dma_addr0);


new code:
#define RTE_IGNORE_CAST_QUAL(X) \
(uintptr_t)(X)

_mm_store_si128((__m128i *)RTE_IGNORE_CAST_QUAL(&rxdp[i].read), dma_addr0);

[PATCH v1 2/2] ethdev: fix some APIs can be used in the new event

[Huisong Li]

The rte_eth_dev_socket_id() and rte_eth_dev_owner_*() can be used after
allocating an ethdev. So this patch relaxes the conditions for using them.

Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Fixes: 53ef1b34776b ("ethdev: add sanity checks in control APIs")
Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
---
 lib/ethdev/rte_ethdev.c | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 6413c54e3b..9cfb397cee 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -600,9 +600,10 @@ rte_eth_dev_owner_get(const uint16_t port_id, struct 
rte_eth_dev_owner *owner)
struct rte_eth_dev *ethdev;
int ret;
 
-   RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-   ethdev = &rte_eth_devices[port_id];
+   if (port_id >= RTE_MAX_ETHPORTS)
+   return -ENODEV;
 
+   ethdev = &rte_eth_devices[port_id];
if (!eth_dev_is_allocated(ethdev)) {
RTE_ETHDEV_LOG_LINE(ERR, "Port ID %"PRIu16" is not allocated",
port_id);
@@ -635,8 +636,15 @@ int
 rte_eth_dev_socket_id(uint16_t port_id)
 {
int socket_id = SOCKET_ID_ANY;
+   struct rte_eth_dev *ethdev;
 
-   if (!rte_eth_dev_is_valid_port(port_id)) {
+   if (port_id >= RTE_MAX_ETHPORTS) {
+   rte_errno = EINVAL;
+   return socket_id;
+   }
+
+   ethdev = &rte_eth_devices[port_id];
+   if (!eth_dev_is_allocated(ethdev)) {
rte_errno = EINVAL;
} else {
socket_id = rte_eth_devices[port_id].data->numa_node;
-- 
2.22.0

[PATCH v1 0/2] ethdev: clarify something about new event

[Huisong Li]

I've had some issues when I add the verification of the port id in the
event callback, which are discussed in another patch series[1]. So this
series clarify something about RTE_ETH_EVENT_NEW based on the previous
discussion.

[1] 
https://patches.dpdk.org/project/dpdk/cover/20250113025521.32703-1-lihuis...@huawei.com/

Huisong Li (2):
  ethdev: clarify do not something in the new event
  ethdev: fix some APIs can be used in the new event

 lib/ethdev/rte_ethdev.c | 14 +++---
 lib/ethdev/rte_ethdev.h |  9 -
 2 files changed, 19 insertions(+), 4 deletions(-)

-- 
2.22.0

[PATCH v1 1/2] ethdev: clarify do not something in the new event

[Huisong Li]

If application verify the validity of the port id or configure this port in
the new event callback, application may happen to the port id is invalid.

Actually, when application receive a new event from one port, the port is
not fully probed and is just in allocated state. Application doesn't need
to verify the validity of the port id because it is definitely valid.
What's more, application shouldn't do something like configuring this port
or querying some information of this port by ethdev ops.

Signed-off-by: Huisong Li 
---
 lib/ethdev/rte_ethdev.h | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 1f71cad244..e2021f0f12 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -4128,7 +4128,14 @@ enum rte_eth_event_type {
RTE_ETH_EVENT_VF_MBOX,  /**< message from the VF received by PF */
RTE_ETH_EVENT_MACSEC,   /**< MACsec offload related event */
RTE_ETH_EVENT_INTR_RMV, /**< device removal event */
-   RTE_ETH_EVENT_NEW,  /**< port is probed */
+   /** Port is probed and application's event callback will be called.
+* In this moment, the port is not fully probed and is just in allocated
+* state. When application receive this event, application doesn't need
+* to verify the validity of the port id because it is definitely valid.
+* What's more, application shouldn't do something like configuring this
+* port or querying some information of this port by ethdev ops.
+*/
+   RTE_ETH_EVENT_NEW,
RTE_ETH_EVENT_DESTROY,  /**< port is released */
RTE_ETH_EVENT_IPSEC,/**< IPsec offload related event */
RTE_ETH_EVENT_FLOW_AGED,/**< New aged-out flows is detected */
-- 
2.22.0

Re: [PATCH v2] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

[Stephen Hemminger]

On Mon,  6 Jan 2025 13:16:55 -0800
Andre Muezerie  wrote:

> This patch avoids warnings like the ones below emitted by MSVC:
> 
> 1)
> ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<':
> result of 32-bit shift implicitly converted to 64 bits
> (was 64-bit shift intended?)
> 
> 2)
> ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=':
> signed/unsigned mismatch
> 
> The fix for (1) is to use 64-bit shifting when appropriate
> (according to what the result is used for).
> 
> The fix for (2) is to explicitly cast the variables used in the
> comparison.
> 
> Signed-off-by: Andre Muezerie 
> ---
>  drivers/net/i40e/i40e_ethdev.c   | 22 +++---
>  drivers/net/iavf/iavf_ethdev.c   |  2 +-
>  drivers/net/iavf/iavf_rxtx.c |  2 +-
>  drivers/net/iavf/iavf_vchnl.c|  2 +-
>  drivers/net/ice/base/ice_flg_rd.c|  4 ++--
>  drivers/net/ice/base/ice_parser_rt.c | 16 
>  drivers/net/ice/base/ice_xlt_kb.c|  2 +-
>  drivers/net/ice/base/meson.build | 19 +--

Patches to base driver need to be avoided if at all possible.
Please resubmit without that part

[PATCH v2 2/2] drivers/net: add MSVC compiler flag for unused variables

[Andre Muezerie]

Added MSVC specific compiler flag to ignore warnings about unused
variables, like is being done for other compilers.

Signed-off-by: Andre Muezerie 
---
 drivers/net/ice/base/meson.build  | 16 ++---
 drivers/net/qede/base/meson.build | 57 +--
 2 files changed, 43 insertions(+), 30 deletions(-)

diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build
index addb922ac9..a291d05b93 100644
--- a/drivers/net/ice/base/meson.build
+++ b/drivers/net/ice/base/meson.build
@@ -31,11 +31,17 @@ sources = [
 'ice_vf_mbx.c',
 ]
 
-error_cflags = [
-'-Wno-unused-but-set-variable',
-'-Wno-unused-variable',
-'-Wno-unused-parameter',
-]
+if is_ms_compiler
+error_cflags = [
+'/wd4101', # unreferenced local variable
+]
+else
+error_cflags = [
+'-Wno-unused-but-set-variable',
+'-Wno-unused-variable',
+'-Wno-unused-parameter',
+]
+endif
 
 # Bugzilla ID: 678
 if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))
diff --git a/drivers/net/qede/base/meson.build 
b/drivers/net/qede/base/meson.build
index 4ad177b478..66251360bf 100644
--- a/drivers/net/qede/base/meson.build
+++ b/drivers/net/qede/base/meson.build
@@ -19,31 +19,38 @@ sources = [
 ]
 
 
-error_cflags = [
-'-Wno-unused-parameter',
-'-Wno-sign-compare',
-'-Wno-missing-prototypes',
-'-Wno-cast-qual',
-'-Wno-unused-function',
-'-Wno-unused-variable',
-'-Wno-strict-aliasing',
-'-Wno-missing-prototypes',
-'-Wno-unused-value',
-'-Wno-format-nonliteral',
-'-Wno-shift-negative-value',
-'-Wno-unused-but-set-variable',
-'-Wno-missing-declarations',
-'-Wno-maybe-uninitialized',
-'-Wno-strict-prototypes',
-'-Wno-shift-negative-value',
-'-Wno-implicit-fallthrough',
-'-Wno-format-extra-args',
-'-Wno-visibility',
-'-Wno-empty-body',
-'-Wno-invalid-source-encoding',
-'-Wno-sometimes-uninitialized',
-'-Wno-pointer-bool-conversion',
-]
+if is_ms_compiler
+error_cflags = [
+'/wd4101', # unreferenced local variable
+]
+else
+error_cflags = [
+'-Wno-unused-parameter',
+'-Wno-sign-compare',
+'-Wno-missing-prototypes',
+'-Wno-cast-qual',
+'-Wno-unused-function',
+'-Wno-unused-variable',
+'-Wno-strict-aliasing',
+'-Wno-missing-prototypes',
+'-Wno-unused-value',
+'-Wno-format-nonliteral',
+'-Wno-shift-negative-value',
+'-Wno-unused-but-set-variable',
+'-Wno-missing-declarations',
+'-Wno-maybe-uninitialized',
+'-Wno-strict-prototypes',
+'-Wno-shift-negative-value',
+'-Wno-implicit-fallthrough',
+'-Wno-format-extra-args',
+'-Wno-visibility',
+'-Wno-empty-body',
+'-Wno-invalid-source-encoding',
+'-Wno-sometimes-uninitialized',
+'-Wno-pointer-bool-conversion',
+]
+endif
+
 c_args = cflags
 foreach flag: error_cflags
 if cc.has_argument(flag)
-- 
2.47.0.vfs.0.3

[PATCH v2 0/2] remove unused variables and add MSVC compiler flag

[Andre Muezerie]

Removed unused variables and added MSVC specific compiler flag to
ignore warnings about unused variables, like is being done for
other compilers.

Andre Muezerie (2):
  drivers/common: remove unused variables and add MSVC compiler flag
  drivers/net: add MSVC compiler flag for unused variables

 drivers/common/idpf/base/meson.build   | 13 +++--
 drivers/common/idpf/idpf_common_rxtx.c |  2 -
 drivers/common/idpf/idpf_common_virtchnl.c |  4 +-
 drivers/common/sfc_efx/base/efx_mae.c  |  2 +-
 drivers/common/sfc_efx/base/efx_table.c|  1 -
 drivers/common/sfc_efx/base/meson.build| 20 +---
 drivers/net/ice/base/meson.build   | 16 --
 drivers/net/qede/base/meson.build  | 57 --
 8 files changed, 69 insertions(+), 46 deletions(-)

--
2.47.0.vfs.0.3

[PATCH v2 1/2] drivers/common: remove unused variables and add MSVC compiler flag

[Andre Muezerie]

Removed unused variables and added MSVC specific compiler flag to
ignore warnings about unused variables, like is being done for
other compilers.

Signed-off-by: Andre Muezerie 
---
 drivers/common/idpf/base/meson.build   | 13 ++---
 drivers/common/idpf/idpf_common_rxtx.c |  2 --
 drivers/common/idpf/idpf_common_virtchnl.c |  4 ++--
 drivers/common/sfc_efx/base/efx_mae.c  |  2 +-
 drivers/common/sfc_efx/base/efx_table.c|  1 -
 drivers/common/sfc_efx/base/meson.build| 20 +---
 6 files changed, 26 insertions(+), 16 deletions(-)

diff --git a/drivers/common/idpf/base/meson.build 
b/drivers/common/idpf/base/meson.build
index f30ec7dfc2..c069507f12 100644
--- a/drivers/common/idpf/base/meson.build
+++ b/drivers/common/idpf/base/meson.build
@@ -6,9 +6,16 @@ sources += files(
 'idpf_controlq_setup.c',
 )
 
-error_cflags = [
-'-Wno-unused-variable',
-]
+if is_ms_compiler
+error_cflags = [
+'/wd4101', # unreferenced local variable
+]
+else
+error_cflags = [
+'-Wno-unused-variable',
+]
+endif
+
 foreach flag: error_cflags
 if cc.has_argument(flag)
 cflags += flag
diff --git a/drivers/common/idpf/idpf_common_rxtx.c 
b/drivers/common/idpf/idpf_common_rxtx.c
index a04e54ce26..9b17279181 100644
--- a/drivers/common/idpf/idpf_common_rxtx.c
+++ b/drivers/common/idpf/idpf_common_rxtx.c
@@ -1178,7 +1178,6 @@ idpf_dp_singleq_recv_scatter_pkts(void *rx_queue, struct 
rte_mbuf **rx_pkts,
struct rte_mbuf *last_seg = rxq->pkt_last_seg;
struct rte_mbuf *rxm;
struct rte_mbuf *nmb;
-   struct rte_eth_dev *dev;
const uint32_t *ptype_tbl = rxq->adapter->ptype_tbl;
uint16_t rx_id = rxq->rx_tail;
uint16_t rx_packet_len;
@@ -1310,7 +1309,6 @@ idpf_xmit_cleanup(struct idpf_tx_queue *txq)
uint16_t nb_tx_desc = txq->nb_tx_desc;
uint16_t desc_to_clean_to;
uint16_t nb_tx_to_clean;
-   uint16_t i;
 
volatile struct idpf_base_tx_desc *txd = txq->tx_ring;
 
diff --git a/drivers/common/idpf/idpf_common_virtchnl.c 
b/drivers/common/idpf/idpf_common_virtchnl.c
index de511da788..0ae1d55d79 100644
--- a/drivers/common/idpf/idpf_common_virtchnl.c
+++ b/drivers/common/idpf/idpf_common_virtchnl.c
@@ -362,7 +362,7 @@ idpf_vc_queue_grps_add(struct idpf_vport *vport,
 {
struct idpf_adapter *adapter = vport->adapter;
struct idpf_cmd_info args;
-   int size, qg_info_size;
+   int size;
int err = -1;
 
size = sizeof(*p2p_queue_grps_info) +
@@ -1044,7 +1044,7 @@ int idpf_vc_rxq_config_by_info(struct idpf_vport *vport, 
struct virtchnl2_rxq_in
struct idpf_adapter *adapter = vport->adapter;
struct virtchnl2_config_rx_queues *vc_rxqs = NULL;
struct idpf_cmd_info args;
-   int size, err, i;
+   int size, err;
 
size = sizeof(*vc_rxqs) + (num_qs - 1) *
sizeof(struct virtchnl2_rxq_info);
diff --git a/drivers/common/sfc_efx/base/efx_mae.c 
b/drivers/common/sfc_efx/base/efx_mae.c
index 9ae136dcce..1429e7dd0a 100644
--- a/drivers/common/sfc_efx/base/efx_mae.c
+++ b/drivers/common/sfc_efx/base/efx_mae.c
@@ -740,7 +740,6 @@ efx_mae_mport_by_pcie_function(
__inuint32_t vf,
__out   efx_mport_sel_t *mportp)
 {
-   efx_dword_t dword;
efx_rc_t rc;
 
rc = efx_mae_mport_by_pcie_mh_function(EFX_PCIE_INTERFACE_CALLER,
@@ -4280,6 +4279,7 @@ efx_mae_action_set_replay(
__out   efx_mae_actions_t **spec_clonep)
 {
const efx_nic_cfg_t *encp = efx_nic_cfg_get(enp);
+   (void)encp;
efx_mae_actions_t *spec_clone;
efx_rc_t rc;
 
diff --git a/drivers/common/sfc_efx/base/efx_table.c 
b/drivers/common/sfc_efx/base/efx_table.c
index 13a12a116e..50e9a37d1c 100644
--- a/drivers/common/sfc_efx/base/efx_table.c
+++ b/drivers/common/sfc_efx/base/efx_table.c
@@ -240,7 +240,6 @@ efx_table_describe(
const efx_nic_cfg_t *encp = efx_nic_cfg_get(enp);
unsigned int n_entries;
efx_mcdi_req_t req;
-   unsigned int i;
efx_rc_t rc;
EFX_MCDI_DECLARE_BUF(payload,
MC_CMD_TABLE_DESCRIPTOR_IN_LEN,
diff --git a/drivers/common/sfc_efx/base/meson.build 
b/drivers/common/sfc_efx/base/meson.build
index 7fc04aa57b..c8deb4555e 100644
--- a/drivers/common/sfc_efx/base/meson.build
+++ b/drivers/common/sfc_efx/base/meson.build
@@ -66,13 +66,19 @@ sources = [
 'rhead_virtio.c',
 ]
 
-extra_flags = [
-'-Wno-sign-compare',
-'-Wno-unused-parameter',
-'-Wno-unused-variable',
-'-Wno-empty-body',
-'-Wno-unused-but-set-variable',
-]
+if is_ms_compiler
+extra_flags = [
+'/wd4101', # unreferenced local variable
+]
+else
+extra_flags = [
+'-Wno-sign-compare',
+'-Wno-unused-parameter',
+'-Wno-unused-variable',
+'-Wno-empty-body',
+   

RE: [PATCH] net/i40e/base: fix the debug print format

[Zeng, ZhichaoX]

Hi David

Thanks for your comments, will submit v2 patch.

Regards
Zhichao

> -Original Message-
> From: David Marchand 
> Sent: Tuesday, January 14, 2025 9:15 PM
> To: Zeng, ZhichaoX 
> Cc: dev@dpdk.org; sta...@dpdk.org; Ilgiewicz, Jaroslaw
> ; Stokes, Ian ;
> Richardson, Bruce ; Midde Ajijur Rehaman
> ; Burakov, Anatoly
> 
> Subject: Re: [PATCH] net/i40e/base: fix the debug print format
> 
> On Tue, Jan 14, 2025 at 10:44 AM Zhichao Zeng 
> wrote:
> >
> > This patch modifies format specifier in debug prints to match to the
> > change of time variables from 64 bit to 32 bit.
> 
> I am missing something... this is reverting a valid change.
> 
> If anything needs to be changed.. PRIu32 should be used in the four hunks
> this patch touches.
> 
> >
> > Fixes: d980a401b137 ("net/i40e/base: add NVM acquire with custom
> > timeout")
> > Fixes: ba90329a5eb3 ("net/i40e/base: fix invalid log format
> > characters")
> 
> And in this case, I think you want to point at:
> Fixes: cb593a832630 ("net/i40e/base: reduce size of time variables")
> 
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Jaroslaw Ilgiewicz 
> > Signed-off-by: Zhichao Zeng 
> 
> 
> --
> David Marchand

Re: [PATCH 2/2] drivers/net/sfc: remove unused value

[Ariel Otilibili-Anieli]

Hello Stephen,

On Tuesday, January 14, 2025 19:47 CET, Stephen Hemminger 
 wrote:

> On Fri, 13 Dec 2024 22:41:55 +0100
> Ariel Otilibili  wrote:
> 
> > Coverity issue: 38
> > Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> > Cc: Andrew Rybchenko 
> > Cc: sta...@dpdk.org
> > Signed-off-by: Ariel Otilibili 
> > ---
> 
> This gets checkpatch warning when I merged the SHA value is not correct.
> 
> ### [PATCH] net/sfc: remove unused value
> 
> WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of 
> sha1> ("")' - ie: 'Fixes: a62ec90522a6 ("net/sfc: add port 
> representors infrastructure")'
>

Thanks for the heads up; I'll set the correct length in my .gitconfig
> Bad
>  Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> Good
>  Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")
Have a good one,
Ariel

Re: [PATCH v2] drivers/net: use 64-bit shift and avoid signed/unsigned mismatch

[Stephen Hemminger]

On Tue, 14 Jan 2025 13:08:28 -0800
Andre Muezerie  wrote:

> > 
> > Patches to base driver need to be avoided if at all possible.
> > Please resubmit without that part  
> 
> Thanks for the information. I sent out a v3 for this series.
> It does contain _coding style issues_ for preexisting code.
> Hopefuly that can be ignored.

Yeah, that is common. I always look to see why checkpatch is whining
before merging.

Re: [PATCH 2/2] drivers/net/sfc: remove unused value

[Stephen Hemminger]

On Tue, 14 Jan 2025 20:54:51 +0100
"Ariel Otilibili-Anieli"  wrote:

> Hello Stephen,
> 
> On Tuesday, January 14, 2025 19:47 CET, Stephen Hemminger 
>  wrote:
> 
> > On Fri, 13 Dec 2024 22:41:55 +0100
> > Ariel Otilibili  wrote:
> >   
> > > Coverity issue: 38
> > > Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> > > Cc: Andrew Rybchenko 
> > > Cc: sta...@dpdk.org
> > > Signed-off-by: Ariel Otilibili 
> > > ---  
> > 
> > This gets checkpatch warning when I merged the SHA value is not correct.
> > 
> > ### [PATCH] net/sfc: remove unused value
> > 
> > WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of 
> > sha1> ("")' - ie: 'Fixes: a62ec90522a6 ("net/sfc: add port 
> > representors infrastructure")'
> >  
> 
> Thanks for the heads up; I'll set the correct length in my .gitconfig
> > Bad
> >  Fixes: a62ec90522a ("net/sfc: add port representors infrastructure")
> > Good
> >  Fixes: a62ec90522a6 ("net/sfc: add port representors infrastructure")  
> Have a good one,
> Ariel
> 

Also, please send a patch to add your address to the .mailmap file.
Right now, check-git-log.sh script is complaining.