Hi David
Thanks for your comments, will submit v2 patch.
Regards
Zhichao
> -----Original Message-----
> From: David Marchand <david.march...@redhat.com>
> Sent: Tuesday, January 14, 2025 9:15 PM
> To: Zeng, ZhichaoX <zhichaox.z...@intel.com>
> Cc: dev@dpdk.org; sta...@dpdk.org; Ilgiewicz, Jaroslaw
> <jaroslaw.ilgiew...@intel.com>; Stokes, Ian <ian.sto...@intel.com>;
> Richardson, Bruce <bruce.richard...@intel.com>; Midde Ajijur Rehaman
> <ajijurx.rehaman.mi...@intel.com>; Burakov, Anatoly
> <anatoly.bura...@intel.com>
> Subject: Re: [PATCH] net/i40e/base: fix the debug print format
>
> On Tue, Jan 14, 2025 at 10:44 AM Zhichao Zeng <zhichaox.z...@intel.com>
> wrote:
> >
> > This patch modifies format specifier in debug prints to match to the
> > change of time variables from 64 bit to 32 bit.
>
> I am missing something... this is reverting a valid change.
>
> If anything needs to be changed.. PRIu32 should be used in the four hunks
> this patch touches.
>
> >
> > Fixes: d980a401b137 ("net/i40e/base: add NVM acquire with custom
> > timeout")
> > Fixes: ba90329a5eb3 ("net/i40e/base: fix invalid log format
> > characters")
>
> And in this case, I think you want to point at:
> Fixes: cb593a832630 ("net/i40e/base: reduce size of time variables")
>
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Jaroslaw Ilgiewicz <jaroslaw.ilgiew...@intel.com>
> > Signed-off-by: Zhichao Zeng <zhichaox.z...@intel.com>
>
>
> --
> David Marchand
