date:20241127

MSVC issues the warnings below:

1) ../lib/hash/rte_thash_gf2_poly_math.c(128): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)

The code would be better off by using 64 bit numbers to begin with.
That eliminates the need for a conversion to 64 bits later.

2) ../lib/hash/rte_thash.c(568): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)

1ULL should be used as the result of the bit shift gets multiplied
by sizeof(uint32_t).

Signed-off-by: Andre Muezerie 
---
 lib/hash/rte_thash.c   | 2 +-
 lib/hash/rte_thash_gf2_poly_math.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c
index fa78787143..f076311b57 100644
--- a/lib/hash/rte_thash.c
+++ b/lib/hash/rte_thash.c
@@ -565,7 +565,7 @@ rte_thash_add_helper(struct rte_thash_ctx *ctx, const char 
*name, uint32_t len,
offset;
 
ent = rte_zmalloc(NULL, sizeof(struct rte_thash_subtuple_helper) +
-   sizeof(uint32_t) * (1 << ctx->reta_sz_log),
+   sizeof(uint32_t) * (1ULL << ctx->reta_sz_log),
RTE_CACHE_LINE_SIZE);
if (ent == NULL)
return -ENOMEM;
diff --git a/lib/hash/rte_thash_gf2_poly_math.c 
b/lib/hash/rte_thash_gf2_poly_math.c
index 825da4382f..858884b4d4 100644
--- a/lib/hash/rte_thash_gf2_poly_math.c
+++ b/lib/hash/rte_thash_gf2_poly_math.c
@@ -119,16 +119,16 @@ static uint32_t
 gf2_mul(uint32_t a, uint32_t b, uint32_t r, int degree)
 {
uint64_t product = 0;
-   uint64_t r_poly = r|(1ULL << degree);
+   uint64_t r_poly = r | RTE_BIT64(degree);
 
for (; b; b &= (b - 1))
product ^= (uint64_t)a << (rte_bsf32(b));
 
for (int i = degree * 2 - 1; i >= degree; i--)
-   if (product & (1 << i))
+   if (product & RTE_BIT64(i))
product ^= r_poly << (i - degree);
 
-   return product;
+   return (uint32_t)product;
 }
 
 static uint32_t
-- 
2.47.0.vfs.0.3

[PATCH 1/2] lib/cryptodev: avoid implicit conversion to 64 bit number

MSVC issues the warning below:

../lib/cryptodev/rte_cryptodev.c(623): warning C4334: '<<':
result of 32-bit shift implicitly converted to 64 bits
(was 64-bit shift intended?)

The code would be better off by using 64 bit numbers to begin with.
That eliminates the need for a conversion to 64 bits later.

Signed-off-by: Andre Muezerie 
---
 lib/cryptodev/rte_cryptodev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
index 85a4b46ac9..a49b0662f3 100644
--- a/lib/cryptodev/rte_cryptodev.c
+++ b/lib/cryptodev/rte_cryptodev.c
@@ -620,7 +620,7 @@ rte_cryptodev_asym_xform_capability_check_hash(
 {
bool ret = false;
 
-   if (capability->hash_algos & (1 << hash))
+   if (capability->hash_algos & RTE_BIT64(hash))
ret = true;
 
rte_cryptodev_trace_asym_xform_capability_check_hash(
-- 
2.47.0.vfs.0.3

[PATCH 2/2] app/test: add test_init_m128i using compiler intrinsic

This test initializes an __m128i data type using the old
non-portable way used until now and the more portable way
using compiler intrinsics. The test ensures the resulting
values after initialization match.

Signed-off-by: Andre Muezerie 
---
 app/test/test_thash.c | 37 +
 1 file changed, 37 insertions(+)

diff --git a/app/test/test_thash.c b/app/test/test_thash.c
index b9c6e9118e..c121b1f43f 100644
--- a/app/test/test_thash.c
+++ b/app/test/test_thash.c
@@ -1030,6 +1030,38 @@ test_keygen(void)
return TEST_SUCCESS;
 }
 
+#ifdef RTE_ARCH_X86
+#ifndef RTE_TOOLCHAIN_MSVC
+static int
+test_init_m128i(void)
+{
+   /* When initializing __m128i with two constant values like below
+* MSVC issues warning C4305:
+* 'initializing': truncation from 'unsigned __int64' to 'char'
+*/
+   static const __m128i a = {
+   0x0405060700010203ULL, 0x0C0D0E0F08090A0BULL};
+
+   /* Using compiler intrinsics to initialize __m128i is therefore
+* preferred, like below
+*/
+   static const uint8_t b_bytes[] = {
+   0x03, 0x02, 0x01, 0x00, 0x07, 0x06, 0x05, 0x04,
+   0x0B, 0x0A, 0x09, 0x08, 0x0F, 0x0E, 0x0D, 0x0C};
+   const __m128i b =
+   _mm_loadu_si128((const __m128i *)&b_bytes);
+
+   if (memcmp(&a, &b, sizeof(a)) != 0) {
+   printf("Same value was expected when initializing data "
+   "type using compiler intrinsic\n");
+   return -1;
+   }
+
+   return TEST_SUCCESS;
+}
+#endif
+#endif
+
 static struct unit_test_suite thash_tests = {
.suite_name = "thash autotest",
.setup = NULL,
@@ -1052,6 +1084,11 @@ static struct unit_test_suite thash_tests = {
TEST_CASE(test_adjust_tuple),
TEST_CASE(test_adjust_tuple_mult_reta),
TEST_CASE(test_keygen),
+#ifdef RTE_ARCH_X86
+#ifndef RTE_TOOLCHAIN_MSVC
+   TEST_CASE(test_init_m128i),
+#endif
+#endif
TEST_CASES_END()
}
 };
-- 
2.34.1

[PATCH 1/2] lib/hash: initialize __m128i data type in a portable way

The mechanism used to initialize an __m128i data type in rte_thash.h is
non-portable and MSVC does not like it. It clearly is not doing what
is desired:

..\lib\hash\rte_thash.h(38): warning C4305: 'initializing':
truncation from 'unsigned __int64' to 'char'
..\lib\hash\rte_thash.h(38): warning C4305: 'initializing':
truncation from 'unsigned __int64' to 'char'

A more portable approach is to use compiler intrinsics to perform the
initialization. This patch uses a single compiler intrinsic to
initialize the data type using a sequence of 16 bytes stored in
memory.

There should be no perf degradation due to this change.

Signed-off-by: Andre Muezerie 
---
 lib/hash/rte_thash.h | 11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lib/hash/rte_thash.h b/lib/hash/rte_thash.h
index c0af5968df..3512639792 100644
--- a/lib/hash/rte_thash.h
+++ b/lib/hash/rte_thash.h
@@ -34,8 +34,9 @@ extern "C" {
 /* Byte swap mask used for converting IPv6 address
  * 4-byte chunks to CPU byte order
  */
-static const __m128i rte_thash_ipv6_bswap_mask = {
-   0x0405060700010203ULL, 0x0C0D0E0F08090A0BULL};
+static const uint8_t rte_thash_ipv6_bswap_mask[] = {
+   0x03, 0x02, 0x01, 0x00, 0x07, 0x06, 0x05, 0x04,
+   0x0B, 0x0A, 0x09, 0x08, 0x0F, 0x0E, 0x0D, 0x0C};
 #endif
 
 /**
@@ -152,12 +153,14 @@ rte_thash_load_v6_addrs(const struct rte_ipv6_hdr *orig,
union rte_thash_tuple *targ)
 {
 #ifdef RTE_ARCH_X86
+   const __m128i ipv6_bswap_mask =
+   _mm_loadu_si128((const 
__m128i*)&rte_thash_ipv6_bswap_mask);
__m128i ipv6 = _mm_loadu_si128((const __m128i *)&orig->src_addr);
*(__m128i *)&targ->v6.src_addr =
-   _mm_shuffle_epi8(ipv6, rte_thash_ipv6_bswap_mask);
+   _mm_shuffle_epi8(ipv6, ipv6_bswap_mask);
ipv6 = _mm_loadu_si128((const __m128i *)&orig->dst_addr);
*(__m128i *)&targ->v6.dst_addr =
-   _mm_shuffle_epi8(ipv6, rte_thash_ipv6_bswap_mask);
+   _mm_shuffle_epi8(ipv6, ipv6_bswap_mask);
 #elif defined(__ARM_NEON)
uint8x16_t ipv6 = vld1q_u8(orig->src_addr.a);
vst1q_u8(targ->v6.src_addr.a, vrev32q_u8(ipv6));
-- 
2.34.1

[PATCH 1/2] lib/hash: initialize __m128i data type in a portable way

The mechanism used to initialize an __m128i data type in rte_thash.h is
non-portable and MSVC does not like it. It clearly is not doing what
is desired:

..\lib\hash\rte_thash.h(38): warning C4305: 'initializing':
truncation from 'unsigned __int64' to 'char'
..\lib\hash\rte_thash.h(38): warning C4305: 'initializing':
truncation from 'unsigned __int64' to 'char'

A more portable approach is to use compiler intrinsics to perform the
initialization. This patch uses a single compiler intrinsic to
initialize the data type using a sequence of 16 bytes stored in
memory.

There should be no perf degradation due to this change.

Signed-off-by: Andre Muezerie 
---
 lib/hash/rte_thash.h | 11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/lib/hash/rte_thash.h b/lib/hash/rte_thash.h
index c0af5968df..3512639792 100644
--- a/lib/hash/rte_thash.h
+++ b/lib/hash/rte_thash.h
@@ -34,8 +34,9 @@ extern "C" {
 /* Byte swap mask used for converting IPv6 address
  * 4-byte chunks to CPU byte order
  */
-static const __m128i rte_thash_ipv6_bswap_mask = {
-   0x0405060700010203ULL, 0x0C0D0E0F08090A0BULL};
+static const uint8_t rte_thash_ipv6_bswap_mask[] = {
+   0x03, 0x02, 0x01, 0x00, 0x07, 0x06, 0x05, 0x04,
+   0x0B, 0x0A, 0x09, 0x08, 0x0F, 0x0E, 0x0D, 0x0C};
 #endif
 
 /**
@@ -152,12 +153,14 @@ rte_thash_load_v6_addrs(const struct rte_ipv6_hdr *orig,
union rte_thash_tuple *targ)
 {
 #ifdef RTE_ARCH_X86
+   const __m128i ipv6_bswap_mask =
+   _mm_loadu_si128((const 
__m128i*)&rte_thash_ipv6_bswap_mask);
__m128i ipv6 = _mm_loadu_si128((const __m128i *)&orig->src_addr);
*(__m128i *)&targ->v6.src_addr =
-   _mm_shuffle_epi8(ipv6, rte_thash_ipv6_bswap_mask);
+   _mm_shuffle_epi8(ipv6, ipv6_bswap_mask);
ipv6 = _mm_loadu_si128((const __m128i *)&orig->dst_addr);
*(__m128i *)&targ->v6.dst_addr =
-   _mm_shuffle_epi8(ipv6, rte_thash_ipv6_bswap_mask);
+   _mm_shuffle_epi8(ipv6, ipv6_bswap_mask);
 #elif defined(__ARM_NEON)
uint8x16_t ipv6 = vld1q_u8(orig->src_addr.a);
vst1q_u8(targ->v6.src_addr.a, vrev32q_u8(ipv6));
-- 
2.34.1

[PATCH 2/2] app/test: add test_init_m128i using compiler intrinsic

This test initializes an __m128i data type using the old
non-portable way used until now and the more portable way
using compiler intrinsics. The test ensures the resulting
values after initialization match.

Signed-off-by: Andre Muezerie 
---
 app/test/test_thash.c | 37 +
 1 file changed, 37 insertions(+)

diff --git a/app/test/test_thash.c b/app/test/test_thash.c
index b9c6e9118e..c121b1f43f 100644
--- a/app/test/test_thash.c
+++ b/app/test/test_thash.c
@@ -1030,6 +1030,38 @@ test_keygen(void)
return TEST_SUCCESS;
 }
 
+#ifdef RTE_ARCH_X86
+#ifndef RTE_TOOLCHAIN_MSVC
+static int
+test_init_m128i(void)
+{
+   /* When initializing __m128i with two constant values like below
+* MSVC issues warning C4305:
+* 'initializing': truncation from 'unsigned __int64' to 'char'
+*/
+   static const __m128i a = {
+   0x0405060700010203ULL, 0x0C0D0E0F08090A0BULL};
+
+   /* Using compiler intrinsics to initialize __m128i is therefore
+* preferred, like below
+*/
+   static const uint8_t b_bytes[] = {
+   0x03, 0x02, 0x01, 0x00, 0x07, 0x06, 0x05, 0x04,
+   0x0B, 0x0A, 0x09, 0x08, 0x0F, 0x0E, 0x0D, 0x0C};
+   const __m128i b =
+   _mm_loadu_si128((const __m128i *)&b_bytes);
+
+   if (memcmp(&a, &b, sizeof(a)) != 0) {
+   printf("Same value was expected when initializing data "
+   "type using compiler intrinsic\n");
+   return -1;
+   }
+
+   return TEST_SUCCESS;
+}
+#endif
+#endif
+
 static struct unit_test_suite thash_tests = {
.suite_name = "thash autotest",
.setup = NULL,
@@ -1052,6 +1084,11 @@ static struct unit_test_suite thash_tests = {
TEST_CASE(test_adjust_tuple),
TEST_CASE(test_adjust_tuple_mult_reta),
TEST_CASE(test_keygen),
+#ifdef RTE_ARCH_X86
+#ifndef RTE_TOOLCHAIN_MSVC
+   TEST_CASE(test_init_m128i),
+#endif
+#endif
TEST_CASES_END()
}
 };
-- 
2.34.1

[DPDK/meson Bug 1589] meson_tests/driver link_bonding_autotest test failed

2024-11-27 Thread bugzilla

https://bugs.dpdk.org/show_bug.cgi?id=1589

Bug ID: 1589
   Summary: meson_tests/driver link_bonding_autotest test failed
   Product: DPDK
   Version: 24.11
  Hardware: x86
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: meson
  Assignee: dev@dpdk.org
  Reporter: hailinx...@intel.com
  Target Milestone: ---

Environment
===
DPDK version: 24.11.0-rc4 a4f455560f747af8cd7fa99db86e757b7ff2fe79
OS: Red Hat Enterprise Linux 9.4 (Plow)/5.14.0-427.13.1.el9_4.x86_64
Compiler:  gcc version 11.4.1 20231218 (Red Hat 11.4.1-3)
Hardware platform: Intel(R) Xeon(R) Gold 6140M CPU @ 2.30GHz
NIC hardware: Ethernet Controller XXV710 for 25GbE SFP28 158b
NIC firmware: 
  FW: 9.50 0x8000f49c 255.65535.255
  Driver: 5.14.0-427.13.1.el9_4.x86_64

Test Setup
Steps to reproduce
==
1. Bind ports to vfio-pci
./usertools/dpdk-devbind.py -b vfio-pci :af:00.0 :af:00.1

2. Launch dpdk-test
./x86_64-native-linuxapp-gcc/app/dpdk-test -c 0xff -a :af:00.0 -a
:af:00.1

3. Start link_bonding_autotest test
RTE>>link_bonding_autotest

Show the output from the previous commands.
===
 + --- +
 + Test Suite Summary : Link Bonding Unit Test Suite
 + --- +
 + Tests Total :       65
 + Tests Skipped :      0
 + Tests Executed :    65
 + Tests Unsupported:   0
 + Tests Passed :      27
 + Tests Failed :      38
 + --- +
Test Failed 

Expected Result
===
 + --- +
 + Test Suite Summary : Link Bonding Unit Test Suite
 + --- +
 + Tests Total :       65
 + Tests Skipped :      0
 + Tests Executed :    65
 + Tests Unsupported:   0
 + Tests Passed :      65
 + Tests Failed :       0
 + --- +
Test OK 

bad commit
**
commit 112ce3917674b7e316776305d7e27778d17eb1b7 (HEAD)
Author: Stephen Hemminger 
Date:   Thu Nov 21 10:23:22 2024 -0800

    test/bonding: fix loop on members

    Do not use same variable for outer and inner loop in bonding test.
    Since the loop is just freeing the resulting burst use bulk free.

    Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
    Fixes: 92073ef961ee ("bond: unit tests")
    Cc: sta...@dpdk.org

    Signed-off-by: Stephen Hemminger 
    Acked-by: Bruce Richardson 
    Acked-by: Chengwen Feng 

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [PATCH] examples/ptpclient: revert add frequency adjustment

On Wed, Nov 27, 2024 at 07:27:21AM +, Mingjin Ye wrote:
> This commit references GPL-licensed code and therefore cannot be applied
> to the DPDK.
> 
> Therefore the following commit was reverted accordingly.
> 
> Fixes: 6d55af611fd5 ("examples/ptpclient: add frequency adjustment")
> 
> By resuming this commit, the basic functionality (PMD support for
> high-precision clocks) will not be affected, but its accuracy will be
> reduced to the microsecond level.
> 
> Fixes: 6d55af611fd5 ("examples/ptpclient: add frequency adjustment")
> 
> Signed-off-by: Mingjin Ye 
> ---
>  doc/guides/sample_app_ug/ptpclient.rst |  17 +-
>  examples/ptpclient/ptpclient.c | 302 ++---
>  2 files changed, 25 insertions(+), 294 deletions(-)
> 
Acked-by: Bruce Richardson 

Applied to dpdk-next-net-intel


/Bruce

[PATCH v5 6/8] build: reduce driver dependencies

From: Bruce Richardson 

Remove any unnecessary dependencies from the driver dependency lists.
This will give each driver a near-minimum set of required dependencies.

Signed-off-by: Bruce Richardson 
Reviewed-by: Rosen Xu 
---
 drivers/baseband/fpga_5gnr_fec/meson.build | 2 +-
 drivers/baseband/fpga_lte_fec/meson.build  | 2 +-
 drivers/baseband/la12xx/meson.build| 2 +-
 drivers/baseband/null/meson.build  | 2 +-
 drivers/baseband/turbo_sw/meson.build  | 2 +-
 drivers/bus/auxiliary/meson.build  | 2 --
 drivers/bus/dpaa/meson.build   | 2 +-
 drivers/bus/fslmc/meson.build  | 2 +-
 drivers/bus/ifpga/meson.build  | 2 +-
 drivers/bus/pci/meson.build| 4 +---
 drivers/bus/platform/meson.build   | 1 -
 drivers/bus/uacce/meson.build  | 2 --
 drivers/bus/vdev/meson.build   | 2 --
 drivers/common/cnxk/meson.build| 4 ++--
 drivers/common/cpt/meson.build | 2 +-
 drivers/common/idpf/meson.build| 2 +-
 drivers/common/mlx5/meson.build| 2 +-
 drivers/common/qat/meson.build | 3 ++-
 drivers/compress/mlx5/meson.build  | 2 +-
 drivers/compress/nitrox/meson.build| 2 +-
 drivers/compress/octeontx/meson.build  | 2 +-
 drivers/crypto/bcmfs/meson.build   | 2 +-
 drivers/crypto/cnxk/meson.build| 2 +-
 drivers/crypto/dpaa_sec/meson.build| 2 +-
 drivers/crypto/ipsec_mb/meson.build| 2 +-
 drivers/crypto/mlx5/meson.build| 2 +-
 drivers/crypto/nitrox/meson.build  | 2 +-
 drivers/dma/cnxk/meson.build   | 2 +-
 drivers/dma/dpaa/meson.build   | 2 +-
 drivers/dma/dpaa2/meson.build  | 2 +-
 drivers/dma/odm/meson.build| 2 +-
 drivers/dma/skeleton/meson.build   | 2 +-
 drivers/event/cnxk/meson.build | 2 +-
 drivers/event/dlb2/meson.build | 2 +-
 drivers/event/dpaa2/meson.build| 2 +-
 drivers/event/octeontx/meson.build | 3 +--
 drivers/event/sw/meson.build   | 2 +-
 drivers/mempool/cnxk/meson.build   | 2 +-
 drivers/mempool/dpaa/meson.build   | 2 +-
 drivers/mempool/dpaa2/meson.build  | 2 +-
 drivers/mempool/octeontx/meson.build   | 2 +-
 drivers/ml/cnxk/meson.build| 2 +-
 drivers/net/cnxk/meson.build   | 4 +---
 drivers/net/iavf/meson.build   | 2 +-
 drivers/net/ice/meson.build| 2 +-
 drivers/net/mana/meson.build   | 2 +-
 drivers/net/mlx5/meson.build   | 2 +-
 drivers/net/sfc/meson.build| 2 +-
 drivers/net/softnic/meson.build| 2 +-
 drivers/net/virtio/meson.build | 2 +-
 drivers/raw/cnxk_bphy/meson.build  | 2 +-
 drivers/raw/cnxk_gpio/meson.build  | 2 +-
 drivers/raw/gdtc/meson.build   | 2 +-
 drivers/raw/ntb/meson.build| 2 +-
 drivers/raw/skeleton/meson.build   | 2 +-
 drivers/regex/cn9k/meson.build | 2 +-
 drivers/regex/mlx5/meson.build | 2 +-
 drivers/vdpa/ifc/meson.build   | 2 +-
 drivers/vdpa/meson.build   | 3 +--
 drivers/vdpa/mlx5/meson.build  | 2 +-
 drivers/vdpa/sfc/meson.build   | 2 +-
 61 files changed, 59 insertions(+), 71 deletions(-)

diff --git a/drivers/baseband/fpga_5gnr_fec/meson.build 
b/drivers/baseband/fpga_5gnr_fec/meson.build
index c3678d23eb..31b9e92fbb 100644
--- a/drivers/baseband/fpga_5gnr_fec/meson.build
+++ b/drivers/baseband/fpga_5gnr_fec/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2020 Intel Corporation
 
-deps += ['bus_vdev', 'ring', 'pci', 'bus_pci']
+deps += ['bus_vdev', 'bus_pci']
 
 sources = files('rte_fpga_5gnr_fec.c')
 
diff --git a/drivers/baseband/fpga_lte_fec/meson.build 
b/drivers/baseband/fpga_lte_fec/meson.build
index 14e07826ef..fbf24755db 100644
--- a/drivers/baseband/fpga_lte_fec/meson.build
+++ b/drivers/baseband/fpga_lte_fec/meson.build
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2019 Intel Corporation
 
-deps += ['bus_vdev', 'ring', 'pci', 'bus_pci']
+deps += ['bus_vdev', 'bus_pci']
 sources = files('fpga_lte_fec.c')
diff --git a/drivers/baseband/la12xx/meson.build 
b/drivers/baseband/la12xx/meson.build
index 7b7e41c961..e1dbdd0fa7 100644
--- a/drivers/baseband/la12xx/meson.build
+++ b/drivers/baseband/la12xx/meson.build
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2020-2021 NXP
 
-deps += ['bus_vdev', 'ring']
+deps += ['bus_vdev']
 
 sources = files('bbdev_la12xx.c')
diff --git a/drivers/baseband/null/meson.build 
b/drivers/baseband/null/meson.build
index 22863f0bd8..716d6c6fdb 100644
--- a/drivers/baseband/null/meson.build
+++ b/drivers/baseband/null/meson.build
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Luca Boccassi 
 
-deps += ['bus_

[PATCH v3 0/1] Add DPDK build directory configuration script

Note: this patch depends upon Bruce's v5 patchset:

https://patches.dpdk.org/project/dpdk/list/?series=34055

This patch is based on initial script for VSCode configuration:

https://patches.dpdk.org/project/dpdk/patch/6a6b20c037cffcc5f68a341c4b4e4f21990ae991.1721997016.git.anatoly.bura...@intel.com/

This is a TUI frontend for Meson. It is by no means meant to be used as a
replacement for using Meson proper, it is merely a shortcut for those who
constantly deal with creating new Meson build directories but don't want to type
out all components each time.

It relies on dependency graphs from the above Bruce's patchset (v3 introduced
support for optional dependencies, which this script requires) to work. It'll
create a Meson build directory in the background, enabling all options, and then
use both dependency graph and meson introspection to figure out what can be
built, and what dependencies it has.

With this script it is possible to produce very minimal builds - the script is
not only able to track dependencies between components to enable them, but it
can also (with a command line switch) specify which libraries we want to enable
(omitting those not required by currently selected components). This can be
useful for users who frequently reconfigure their tree with e.g. debug/release,
shared/static etc. builds while keeping the reconfiguration time fairly small.

We used to have a "setup.sh" script to "set up" DPDK. This is not that, but it's
a good start.

Anatoly Burakov (1):
devtools: add DPDK build directory setup script

devtools/dpdk-setup.py | 784
doc/guides/linux_gsg/build_dpdk.rst | 26 +
2 files changed, 810 insertions(+)
create mode 100755 devtools/dpdk-setup.py

--
2.43.5

[PATCH v3 1/1] devtools: add DPDK build directory setup script

Currently, the only way to set up a build directory for DPDK development
is through running Meson directly. This has a number of drawbacks.

For one, the default configuration is very "fat", meaning everything gets
enabled and built (aside from examples, which have to be enabled
manually), so while Meson is very good at minimizing work needed to
rebuild DPDK, for any change that affects a lot of components (such as
editing an EAL header), there's a lot of rebuilding to do, which may not
be needed.

It is of course possible to reduce the number of components built through
meson options, but this mechanism isn't perfect, as the user needs to
remember exact spelling of all the options and components, and currently
it doesn't handle inter-component dependencies very well (e.g. if net/ice
is enabled, common/iavf is not automatically enabled, so net/ice can't be
built unless user also doesn't forget to specify common/iavf). Error
messages are displayed, but to an untrained eye it is not always clear
what the user has to do for them to go away.

Enter this script. It relies on Meson's introspection capabilities as
well as the dependency graphs generated by our build system to display
all available components, and handle any dependencies for them
automatically, while also not forcing user to remember any command-line
options and lists of drivers, and instead relying on interactive TUI to
display list of available options. It can also produce builds that are as
minimal as possible (including cutting down libraries being built) by
utilizing the fact that our dependency graphs report which dependency is
mandatory and which one is optional.

Because it is not meant to replace native Meson build configuration but
is rather targeted at developers who are not intimately familiar with
DPDK's build system or want to quickly enable this or that without
thinking about dependencies, it is run in interactive mode by default.
However, it is also possible to run it without interaction, in which case
it will pass all its parameters to Meson directly, with added benefit of
dependency tracking and producing minimal builds if desired.
Reconfiguring existing build directory is also supported, in which case
existing configuration for the flags managed by the script will be kept
updated (for other options we can rely on the fact that Meson keeps track
of all of the specified options and thus we don't have to re-specify them
when we reconfigure).

Signed-off-by: Anatoly Burakov 
---

Notes:
v2 -> v3:
- Fix all naming issues once and for all by improving digraph [1]
- Miscellaneous bug fixes and formatting changes

v1 -> v2:
- Moved to devtools
- Added a --dry-run mode
- Improved support for reconfiguring existing directory
- Some refactoring and code improvements
- Different menus now display different prompts
- Added documentation

[1] https://patches.dpdk.org/project/dpdk/list/?series=34055

 devtools/dpdk-setup.py  | 784 
 doc/guides/linux_gsg/build_dpdk.rst |  26 +
 2 files changed, 810 insertions(+)
 create mode 100755 devtools/dpdk-setup.py

diff --git a/devtools/dpdk-setup.py b/devtools/dpdk-setup.py
new file mode 100755
index 00..b0e28f3d36
--- /dev/null
+++ b/devtools/dpdk-setup.py
@@ -0,0 +1,784 @@
+#!/usr/bin/env python3
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2024 Intel Corporation
+
+"""
+Displays an interactive TUI-based menu for configuring a DPDK build directory.
+"""
+
+# This is an interactive script that allows the user to configure a DPDK build 
directory using a
+# text-based user interface (TUI). The script will prompt the user to select 
various configuration
+# options, and will then call `meson setup|configure` to configure the build 
directory with the
+# selected options.
+#
+# To be more user-friendly, the script will also run `meson setup` into a 
temporary directory in
+# the background, which will generate both the list of available options, and 
any dependencies
+# between them, so whenever the user selects an option, we automatically 
enable its dependencies.
+# This will also allow us to use meson introspection to get list of things we 
are capable of
+# building, and warn the user if they selected something that can't be built.
+
+import argparse
+import collections
+import fnmatch
+import json
+import os
+import subprocess
+import sys
+import textwrap
+import typing as T
+from tempfile import TemporaryDirectory
+
+
+# some apps have different names in the Meson build system
+APP_RENAME_MAP = {
+"testpmd": "test-pmd",
+}
+
+
+# cut off dpdk- prefix
+def _unprefix_app(app: str) -> str:
+return app[5:]
+
+
+def _prefix_app(app: str) -> str:
+return f"dpdk-{app}"
+
+
+def _slash_driver(driver: str) -> str:
+return driver.replace("/", "_", 1)
+
+
+def _unslash_driver(driver: str) -> str:
+return driver.replace("_", "/", 1)
+
+
+def create_meson_build(src_dir: str, build_d

[PATCH v5 0/8] Record and rework component dependencies

As part of the meson build, we can record the dependencies for each
component as we process it, logging them to a file. This file can be
used as input to a number of other scripts and tools, for example, to
graph the dependencies, or to allow higher-level build-config tools to
automatically enable component requirements, etc.

The first patch of this set separates dependencies inside meson into
optional or mandatory. The second patch of this set generates the basic
dependency tree. The third patch does some processing of that dependency
tree to identify cases where dependencies are being unnecessarily
specified. Reducing these makes it easier to have readable dependency
graphs in future, without affecting the build.

The following 4 patches are based on the output of the second patch, and
greatly cut down the number of direct dependency links between
components. Even with the cut-down dependencies, the full dependency
graph is nigh-unreadable, so the final patch adds a new script to
generate dependency tree subgraphs, creating dot files for e.g. the
dependencies of a particular component, or a component class such as
mempool drivers.

v4 -> v5:
- Improve optional dependency handling by making it (mostly) automatic
- Fix CI issue from accidentally changing testpmd binary filename
- Explicitly encode display name vs binary name information in the graph
- Reduce some more dependencies
- Update all scripts to handle new graph output format

v3 -> v4:
- Update to latest main

v2 -> v3:
- Split dependencies into optional and mandatory
- Fixup graph scripts to read and generate graphs that encode optional
  dependencies into the graph
- Python version fixes to avoid using features not available in minimum
  supported Python version
- Formatting with Ruff, and PEP-484 compliance

Anatoly Burakov (1):
  build: introduce optional internal dependencies

Bruce Richardson (7):
  build: output a dependency log in build directory
  devtools: add script to flag unneeded dependencies
  build: remove kvargs from driver class dependencies
  build: reduce library dependencies
  build: reduce driver dependencies
  build: reduce app dependencies
  devtools: add script to generate DPDK dependency graphs

 app/dumpcap/meson.build|   2 +-
 app/graph/meson.build  |   2 +-
 app/meson.build|  31 ++-
 app/pdump/meson.build  |   2 +-
 app/proc-info/meson.build  |   6 +-
 app/test-bbdev/meson.build |  18 +-
 app/test-crypto-perf/meson.build   |   6 +-
 app/test-fib/meson.build   |   2 +-
 app/test-pmd/meson.build   |  56 ++
 app/test-sad/meson.build   |   2 +-
 app/test/meson.build   |  14 +-
 buildtools/log-deps.py |  94 +
 buildtools/meson.build |   2 +
 devtools/draw-dependency-graphs.py | 223 +
 devtools/find-duplicate-deps.py|  62 ++
 drivers/baseband/fpga_5gnr_fec/meson.build |   2 +-
 drivers/baseband/fpga_lte_fec/meson.build  |   2 +-
 drivers/baseband/la12xx/meson.build|   2 +-
 drivers/baseband/null/meson.build  |   2 +-
 drivers/baseband/turbo_sw/meson.build  |   2 +-
 drivers/bus/auxiliary/meson.build  |   2 -
 drivers/bus/dpaa/meson.build   |   2 +-
 drivers/bus/fslmc/meson.build  |   2 +-
 drivers/bus/ifpga/meson.build  |   2 +-
 drivers/bus/pci/meson.build|   4 +-
 drivers/bus/platform/meson.build   |   1 -
 drivers/bus/uacce/meson.build  |   2 -
 drivers/bus/vdev/meson.build   |   2 -
 drivers/common/cnxk/meson.build|   4 +-
 drivers/common/cpt/meson.build |   2 +-
 drivers/common/idpf/meson.build|   2 +-
 drivers/common/mlx5/meson.build|   2 +-
 drivers/common/qat/meson.build |   3 +-
 drivers/compress/mlx5/meson.build  |   2 +-
 drivers/compress/nitrox/meson.build|   2 +-
 drivers/compress/octeontx/meson.build  |   2 +-
 drivers/crypto/bcmfs/meson.build   |   2 +-
 drivers/crypto/cnxk/meson.build|   2 +-
 drivers/crypto/dpaa_sec/meson.build|   2 +-
 drivers/crypto/ipsec_mb/meson.build|   2 +-
 drivers/crypto/mlx5/meson.build|   2 +-
 drivers/crypto/nitrox/meson.build  |   2 +-
 drivers/dma/cnxk/meson.build   |   2 +-
 drivers/dma/dpaa/meson.build   |   2 +-
 drivers/dma/dpaa2/meson.build  |   2 +-
 drivers/dma/odm/meson.build|   2 +-
 drivers/dma/skeleton/meson.build   |   2 +-
 drivers/event/cnxk/meson.build |   2 +-
 drivers/event/dlb2/meson.build |   2 +-
 drivers/event/dpaa2/meson.build|   2 +-
 drivers/event/meson.build  |   2 +-
 drivers/event/octeontx/meson.build |

[PATCH v5 1/8] build: introduce optional internal dependencies

Allow specifying internal dependencies as either mandatory or optional.
Specifying a dependency as optional will mean that the component being
built will not be skipped if said dependency is not being built. At build
time, the build system will resolve any optional dependencies and add
them to the list of dependencies to be built. Any source files requiring
said optional depepdencies will still have to be added explicitly to the
build by the respective component (e.g. adding BPF-related files when BPF
support is being built).

Signed-off-by: Bruce Richardson 
Signed-off-by: Anatoly Burakov 
---

Notes:
v4 -> v5:
- Automatically handle optional dependencies based on Bruce's
  earlier patch [1]

[1] 
https://patches.dpdk.org/project/dpdk/patch/20231220142152.492556-4-bruce.richard...@intel.com/

 app/meson.build   | 14 ++-
 app/proc-info/meson.build |  4 +-
 app/test-bbdev/meson.build| 18 +++--
 app/test-crypto-perf/meson.build  |  4 +-
 app/test-pmd/meson.build  | 56 +--
 app/test/meson.build  | 12 +++---
 drivers/meson.build   | 13 ++-
 examples/ethtool/meson.build  |  4 +-
 examples/l2fwd-crypto/meson.build |  4 +-
 examples/l3fwd/meson.build|  4 +-
 examples/meson.build  | 13 ++-
 examples/vm_power_manager/meson.build | 16 +++-
 lib/meson.build   | 13 ++-
 13 files changed, 89 insertions(+), 86 deletions(-)

diff --git a/app/meson.build b/app/meson.build
index e2db888ae1..61202495bd 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -66,6 +66,7 @@ foreach app:apps
 # external package/library requirements
 ext_deps = []
 deps = []
+optional_deps = []
 
 if not enable_apps.contains(app)
 build = false
@@ -83,10 +84,19 @@ foreach app:apps
 endif
 endif
 
+# resolve any optional internal dependencies
+def_lib = get_option('default_library')
+foreach d: optional_deps
+# if optional dependency is defined, add it to the deps list
+if is_variable(def_lib + '_rte_' + d)
+deps += [d]
+endif
+endforeach
+
 if build
 dep_objs = []
 foreach d:deps
-var_name = get_option('default_library') + '_rte_' + d
+var_name = def_lib + '_rte_' + d
 if not is_variable(var_name)
 build = false
 reason = 'missing internal dependency, "@0@"'.format(d)
@@ -111,7 +121,7 @@ foreach app:apps
 
 dpdk_apps_enabled += app
 link_libs = []
-if get_option('default_library') == 'static'
+if def_lib == 'static'
 link_libs = dpdk_static_libraries + dpdk_drivers
 endif
 
diff --git a/app/proc-info/meson.build b/app/proc-info/meson.build
index 4f83f29a64..5fefb0857e 100644
--- a/app/proc-info/meson.build
+++ b/app/proc-info/meson.build
@@ -9,6 +9,4 @@ endif
 
 sources = files('main.c')
 deps += ['ethdev', 'security', 'eventdev']
-if dpdk_conf.has('RTE_LIB_METRICS')
-deps += 'metrics'
-endif
+optional_deps += 'metrics'
diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build
index 926e0a5271..bd38694eaf 100644
--- a/app/test-bbdev/meson.build
+++ b/app/test-bbdev/meson.build
@@ -14,15 +14,9 @@ sources = files(
 'test_bbdev_vector.c',
 )
 deps += ['bbdev', 'bus_vdev']
-if dpdk_conf.has('RTE_BASEBAND_FPGA_LTE_FEC')
-deps += ['baseband_fpga_lte_fec']
-endif
-if dpdk_conf.has('RTE_BASEBAND_FPGA_5GNR_FEC')
-deps += ['baseband_fpga_5gnr_fec']
-endif
-if dpdk_conf.has('RTE_BASEBAND_ACC')
-deps += ['baseband_acc']
-endif
-if dpdk_conf.has('RTE_BASEBAND_LA12XX')
-deps += ['baseband_la12xx']
-endif
+optional_deps += [
+'baseband_fpga_lte_fec',
+'baseband_fpga_5gnr_fec',
+'baseband_acc',
+'baseband_la12xx'
+]
diff --git a/app/test-crypto-perf/meson.build b/app/test-crypto-perf/meson.build
index 7b02b518f0..1ac0ac1099 100644
--- a/app/test-crypto-perf/meson.build
+++ b/app/test-crypto-perf/meson.build
@@ -20,6 +20,4 @@ sources = files(
 'main.c',
 )
 deps += ['cryptodev', 'net', 'security']
-if dpdk_conf.has('RTE_CRYPTO_SCHEDULER')
-deps += 'crypto_scheduler'
-endif
+optional_deps += 'crypto_scheduler'
diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
index f1c36529b4..bbb0c83fa5 100644
--- a/app/test-pmd/meson.build
+++ b/app/test-pmd/meson.build
@@ -34,47 +34,29 @@ sources = files(
 if dpdk_conf.has('RTE_HAS_JANSSON')
 ext_deps += jansson_dep
 endif
-
-deps += ['ethdev', 'cmdline']
-if dpdk_conf.has('RTE_CRYPTO_SCHEDULER')
-deps += 'crypto_scheduler'
-endif
-if dpdk_conf.has('RTE_LIB_BITRATESTATS')
-deps += 'bitratestats'
-endif
 if dpdk_conf.has('RTE_LIB_BPF')
 sources += files('bpf_cmd.c')
-deps += 'bpf'
-endif
-if dpdk_conf.has('RTE_LIB_GRO')
-deps += 'gro'
-endif
-if dpdk_conf.has('RTE_LIB_GSO')
-deps += 'gso'
-endif
-if d

[PATCH v5 3/8] devtools: add script to flag unneeded dependencies

From: Bruce Richardson 

While not a serious problem, DPDK components often list more
dependencies than are actually necessary to build, due to the use of
recursive dependencies. In extreme cases, such as with core libraries,
this can lead to longer configuration times due to meson having to
deduplicate long lists of dependencies. Therefore we can add a script to
identify when a component has got unnecessary dependencies listed.

Signed-off-by: Bruce Richardson 
---
 devtools/find-duplicate-deps.py | 62 +
 1 file changed, 62 insertions(+)
 create mode 100755 devtools/find-duplicate-deps.py

diff --git a/devtools/find-duplicate-deps.py b/devtools/find-duplicate-deps.py
new file mode 100755
index 00..cbd0ca7196
--- /dev/null
+++ b/devtools/find-duplicate-deps.py
@@ -0,0 +1,62 @@
+#! /usr/bin/env python3
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2024 Intel Corporation
+
+"""Identify any superfluous dependencies listed in DPDK deps graph."""
+
+import sys
+
+all_deps = {}
+
+
+class dep:
+"""Holds a component and its dependencies."""
+
+def __init__(self, name, dep_names):
+"""Create and process a component and its deps."""
+self.name = name.strip('" ')
+self.base_deps = [all_deps[dn.strip('" ')] for dn in dep_names]
+self.recursive_deps = []
+for d in self.base_deps:
+self.recursive_deps.extend(d.base_deps)
+self.recursive_deps.extend(d.recursive_deps)
+self.extra_deps = []
+for d in self.base_deps:
+if d in self.recursive_deps:
+self.extra_deps.append(d.name)
+if self.extra_deps:
+print(f'{self.name}: extra deps {self.extra_deps}')
+
+def dict_add(self, d):
+"""Add this object to a dictionary by name."""
+d[self.name] = self
+
+
+def remove_attrs(ln):
+"""Remove attributes from a line."""
+while ln.find("[") != -1:
+start = ln.find("[")
+end = ln.find("]")
+ln = ln[:start] + ln[end + 1 :]
+return ln.strip()
+
+
+def main(argv):
+"""Read the dependency tree from a dot file and process it."""
+if len(argv) != 2:
+print(f'Usage: {argv[0]} /deps.dot', file=sys.stderr)
+sys.exit(1)
+
+with open(argv[1]) as f:
+for ln in f.readlines():
+ln = remove_attrs(ln.strip())
+if '->' in ln:
+name, deps = ln.split('->')
+deps = deps.strip(' {}')
+dep(name, deps.split(',')).dict_add(all_deps)
+elif ln.startswith('"') and ln.endswith('"'):
+dep(ln.strip('"'), []).dict_add(all_deps)
+
+
+if __name__ == '__main__':
+main(sys.argv)
-- 
2.43.5

[PATCH v5 5/8] build: reduce library dependencies

From: Bruce Richardson 

Rather than having each library depend up on EAL + any extra libs, we
can take advantage of recursive dependency support in meson and
just assign the dependencies of each directory directly, rather than
appending to the array. For libraries which only depend upon EAL, keep
that as a default, but for libraries which depend upon even a single
extra lib, that EAL dependency is unnecessary.

Going further, we can identify using the find_duplicate_deps.py script
any unnecessary deps in each library's list, and remove them to slim the
dependency tree down.

Reducing number of dependencies means that meson takes less time
processing and deduplicating the dependency tree for each component, and
also shrinks the dependency graph for DPDK itself.

Signed-off-by: Bruce Richardson 
---
 lib/argparse/meson.build | 2 +-
 lib/bbdev/meson.build| 2 +-
 lib/bitratestats/meson.build | 2 +-
 lib/bpf/meson.build  | 2 +-
 lib/cmdline/meson.build  | 2 +-
 lib/compressdev/meson.build  | 2 +-
 lib/cryptodev/meson.build| 2 +-
 lib/dispatcher/meson.build   | 2 +-
 lib/distributor/meson.build  | 2 +-
 lib/dmadev/meson.build   | 2 --
 lib/eal/meson.build  | 5 +
 lib/efd/meson.build  | 2 +-
 lib/ethdev/meson.build   | 2 +-
 lib/eventdev/meson.build | 3 +--
 lib/fib/meson.build  | 4 +---
 lib/gpudev/meson.build   | 2 +-
 lib/graph/meson.build| 2 +-
 lib/gro/meson.build  | 2 +-
 lib/gso/meson.build  | 2 +-
 lib/hash/meson.build | 4 +---
 lib/ip_frag/meson.build  | 2 +-
 lib/ipsec/meson.build| 2 +-
 lib/kvargs/meson.build   | 2 +-
 lib/latencystats/meson.build | 2 +-
 lib/lpm/meson.build  | 4 +---
 lib/mbuf/meson.build | 2 +-
 lib/member/meson.build   | 2 +-
 lib/mempool/meson.build  | 2 +-
 lib/metrics/meson.build  | 2 +-
 lib/mldev/meson.build| 2 +-
 lib/net/meson.build  | 2 +-
 lib/node/meson.build | 2 +-
 lib/pcapng/meson.build   | 2 +-
 lib/pdcp/meson.build | 2 +-
 lib/pdump/meson.build| 2 +-
 lib/pipeline/meson.build | 2 +-
 lib/port/meson.build | 2 +-
 lib/power/meson.build| 3 +--
 lib/rawdev/meson.build   | 2 --
 lib/rcu/meson.build  | 2 +-
 lib/regexdev/meson.build | 2 +-
 lib/reorder/meson.build  | 2 +-
 lib/rib/meson.build  | 2 +-
 lib/ring/meson.build | 1 -
 lib/sched/meson.build| 2 +-
 lib/security/meson.build | 2 +-
 lib/table/meson.build| 2 +-
 lib/telemetry/meson.build| 2 +-
 lib/vhost/meson.build| 2 +-
 49 files changed, 46 insertions(+), 62 deletions(-)

diff --git a/lib/argparse/meson.build b/lib/argparse/meson.build
index b6a08ca049..96abc8766f 100644
--- a/lib/argparse/meson.build
+++ b/lib/argparse/meson.build
@@ -4,4 +4,4 @@
 sources = files('rte_argparse.c')
 headers = files('rte_argparse.h')
 
-deps += ['log']
+deps = ['log']
diff --git a/lib/bbdev/meson.build b/lib/bbdev/meson.build
index 07685e7578..2e68aa7873 100644
--- a/lib/bbdev/meson.build
+++ b/lib/bbdev/meson.build
@@ -11,4 +11,4 @@ sources = files('rte_bbdev.c')
 headers = files('rte_bbdev.h',
 'rte_bbdev_pmd.h',
 'rte_bbdev_op.h')
-deps += ['mbuf']
+deps = ['mbuf']
diff --git a/lib/bitratestats/meson.build b/lib/bitratestats/meson.build
index ede7e0a579..8defcd53bf 100644
--- a/lib/bitratestats/meson.build
+++ b/lib/bitratestats/meson.build
@@ -3,4 +3,4 @@
 
 sources = files('rte_bitrate.c')
 headers = files('rte_bitrate.h')
-deps += ['ethdev', 'metrics']
+deps = ['metrics']
diff --git a/lib/bpf/meson.build b/lib/bpf/meson.build
index aa258a9061..82127bc657 100644
--- a/lib/bpf/meson.build
+++ b/lib/bpf/meson.build
@@ -31,7 +31,7 @@ headers = files('bpf_def.h',
 'rte_bpf.h',
 'rte_bpf_ethdev.h')
 
-deps += ['mbuf', 'net', 'ethdev']
+deps = ['ethdev']
 
 dep = dependency('libelf', required: false, method: 'pkg-config')
 if dep.found()
diff --git a/lib/cmdline/meson.build b/lib/cmdline/meson.build
index 63fb69100d..4451f3da29 100644
--- a/lib/cmdline/meson.build
+++ b/lib/cmdline/meson.build
@@ -31,4 +31,4 @@ else
 sources += files('cmdline_os_unix.c')
 endif
 
-deps += ['net']
+deps = ['net']
diff --git a/lib/compressdev/meson.build b/lib/compressdev/meson.build
index c80295dc0d..4b86955baf 100644
--- a/lib/compressdev/meson.build
+++ b/lib/compressdev/meson.build
@@ -16,4 +16,4 @@ driver_sdk_headers = files(
 'rte_compressdev_pmd.h',
 'rte_compressdev_internal.h',
 )
-deps += ['kvargs', 'mbuf']
+deps = ['mbuf']
diff --git a/lib/cryptodev/meson.build b/lib/cryptodev/meson.build
index 4734acf321..74e42ac700 100644
--- a/lib/cryptodev/meson.build
+++ b/lib/cryptodev/meson.build
@@ -20,4 +20,4 @@ driver_sdk_headers += files(
 'cryptodev_pmd.h',
 )
 
-deps += ['kvargs', 'mbuf', 'rcu', 'telemetry']
+deps = ['mbuf', 'rcu']
diff --git a/lib/dispatcher/meson.build b/lib/dispatcher/meson.build
index f

[PATCH v5 8/8] devtools: add script to generate DPDK dependency graphs

From: Bruce Richardson 

Rather than the single monolithic graph that would be output from the
deps.dot file in a build directory, we can post-process that to generate
simpler graphs for different tasks. This new "draw_dependency_graphs"
script takes the "deps.dot" as input and generates an output file that
has the nodes categorized, filtering them based off the requested node or
category. For example, use "--match net/ice" to show the dependency tree
from that driver, or "--match lib" to show just the library dependency
tree.

Signed-off-by: Bruce Richardson 
Signed-off-by: Anatoly Burakov 
---
 devtools/draw-dependency-graphs.py | 223 +
 1 file changed, 223 insertions(+)
 create mode 100755 devtools/draw-dependency-graphs.py

diff --git a/devtools/draw-dependency-graphs.py 
b/devtools/draw-dependency-graphs.py
new file mode 100755
index 00..4fb765498d
--- /dev/null
+++ b/devtools/draw-dependency-graphs.py
@@ -0,0 +1,223 @@
+#! /usr/bin/env python3
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2024 Intel Corporation
+
+import argparse
+import collections
+import sys
+import typing as T
+
+# typedef for dependency data types
+Deps = T.Set[str]
+DepData = T.Dict[str, T.Dict[str, T.Dict[bool, Deps]]]
+
+
+def parse_dep_line(line: str) -> T.Tuple[str, Deps, str, bool]:
+"""Parse digraph line into (component, {dependencies}, type, optional)."""
+# extract attributes first
+first, last = line.index("["), line.rindex("]")
+edge_str, attr_str = line[:first], line[first + 1 : last]
+# key=value, key=value, ...
+attrs = {
+key.strip('" '): value.strip('" ')
+for attr_kv in attr_str.split(",")
+for key, value in [attr_kv.strip().split("=", 1)]
+}
+# check if edge is defined as dotted line, meaning it's optional
+optional = "dotted" in attrs.get("style", "")
+try:
+component_type = attrs["dpdk_componentType"]
+except KeyError as _e:
+raise ValueError(f"Error: missing component type: {line}") from _e
+
+# now, extract component name and any of its dependencies
+deps: T.Set[str] = set()
+try:
+component, deps_str = edge_str.strip('" ').split("->", 1)
+component = component.strip().strip('" ')
+deps_str = deps_str.strip().strip("{}")
+deps = {d.strip('" ') for d in deps_str.split(",")}
+except ValueError as _e:
+component = edge_str.strip('" ')
+
+return component, deps, component_type, optional
+
+
+def gen_dep_line(component: str, deps: T.Set[str], optional: bool) -> str:
+"""Generate a dependency line for a component."""
+# we use dotted line to represent optional components
+attr_str = ' [style="dotted"]' if optional else ""
+dep_list_str = '", "'.join(deps)
+deps_str = "" if not deps else f' -> {{ "{dep_list_str}" }}'
+return f'"{component}"{deps_str}{attr_str}\n'
+
+
+def read_deps_list(lines: T.List[str]) -> DepData:
+"""Read a list of dependency lines into a dictionary."""
+deps_data: T.Dict[str, T.Any] = {}
+for ln in lines:
+if ln.startswith("digraph") or ln == "}":
+continue
+
+component, deps, component_type, optional = parse_dep_line(ln)
+
+# each component will have two sets of dependencies - required and 
optional
+c_dict = deps_data.setdefault(component_type, 
{}).setdefault(component, {})
+c_dict[optional] = deps
+return deps_data
+
+
+def create_classified_graph(deps_data: DepData) -> T.Iterator[str]:
+"""Create a graph of dependencies with components classified by type."""
+yield "digraph dpdk_dependencies {\n  overlap=false\n  model=subset\n"
+for n, deps_t in enumerate(deps_data.items()):
+component_type, component_dict = deps_t
+yield f'  subgraph cluster_{n} {{\nlabel = "{component_type}"\n'
+for component, optional_d in component_dict.items():
+for optional, deps in optional_d.items():
+yield gen_dep_line(component, deps, optional)
+yield "  }\n"
+yield "}\n"
+
+
+def parse_match(line: str, dep_data: DepData) -> T.List[str]:
+"""Extract list of components from a category string."""
+# if this is not a compound string, we have very few valid choices
+if "/" not in line:
+# is this a category?
+if line in dep_data:
+return list(dep_data[line].keys())
+# this isn't a category. maybe an app name?
+maybe_app_name = f"dpdk-{line}"
+if maybe_app_name in dep_data["app"]:
+return [maybe_app_name]
+if maybe_app_name in dep_data["examples"]:
+return [maybe_app_name]
+# this isn't an app name either, so just look for component with that 
name
+for _, component_dict in dep_data.items():
+if line in component_dict:
+return [line]
+# nothing found still. one last try: maybe it's a driver? we have to 
be ca

[PATCH v5 2/8] build: output a dependency log in build directory

From: Bruce Richardson 

As meson processes our DPDK source tree it manages dependencies
specified by each individual driver. To enable future analysis of the
dependency links between components, log the dependencies of each DPDK
component as it gets processed. This could potentially allow other tools
to automatically enable or disable components based on the desired end
components to be built, e.g. if the user requests net/ice, ensure that
common/iavf is also enabled in the drivers.

The output file produced is in "dot" or "graphviz" format, which allows
producing a graphical representation of the DPDK dependency tree if so
desired. For example: "dot -Tpng -O build/deps.dot" to produce the
image file "build/deps.dot.png".

Signed-off-by: Bruce Richardson 
Acked-by: Konstantin Ananyev 
Signed-off-by: Anatoly Burakov 
---

Notes:
v4 -> v5:
- Change output format to include display name

 app/meson.build| 17 +++-
 buildtools/log-deps.py | 94 ++
 buildtools/meson.build |  2 +
 drivers/meson.build| 14 +++
 examples/meson.build   | 18 +++-
 lib/meson.build| 14 +++
 6 files changed, 157 insertions(+), 2 deletions(-)
 create mode 100644 buildtools/log-deps.py

diff --git a/app/meson.build b/app/meson.build
index 61202495bd..a971738d40 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -77,7 +77,22 @@ foreach app:apps
 endif
 
 if build
+# call into subdir may update name so record it here
+display_name = name
+
 subdir(name)
+app_name = 'dpdk-' + name
+
+# log mandatory dependencies
+cmds = ['--type', 'app']
+cmds += ['--display-name', display_name]
+run_command([log_deps_cmd, cmds, app_name, deps], check: false)
+
+# log optional dependencies, if any
+if optional_deps.length() > 0
+cmds += ['--optional']
+run_command([log_deps_cmd, cmds, app_name, optional_deps], check: 
false)
+endif
 if not build and require_apps
 error('Cannot build explicitly requested app "@0@".\n'.format(name)
   + '\tReason: ' + reason)
@@ -125,7 +140,7 @@ foreach app:apps
 link_libs = dpdk_static_libraries + dpdk_drivers
 endif
 
-exec = executable('dpdk-' + name,
+exec = executable(app_name,
 [ sources, resources ],
 c_args: cflags,
 link_args: ldflags,
diff --git a/buildtools/log-deps.py b/buildtools/log-deps.py
new file mode 100644
index 00..7a99b129d7
--- /dev/null
+++ b/buildtools/log-deps.py
@@ -0,0 +1,94 @@
+#! /usr/bin/env python3
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2024 Intel Corporation
+
+"""Utility script to build up a list of dependencies from meson."""
+
+import os
+import sys
+import argparse
+import typing as T
+
+
+def file_to_list(filename: str) -> T.List[str]:
+"""Read file into a list of strings."""
+with open(filename, encoding="utf-8") as f:
+return f.readlines()
+
+
+def list_to_file(filename: str, lines: T.List[str]):
+"""Write a list of strings out to a file."""
+with open(filename, "w", encoding="utf-8") as f:
+f.writelines(lines)
+
+
+def gen_deps(
+component_type: str,
+optional: bool,
+component: str,
+display_name: T.Optional[str],
+deps: T.List[str],
+) -> str:
+"""Generate a dependency graph for meson."""
+dep_list_str = '", "'.join(deps)
+deps_str = "" if not deps else f' -> {{ "{dep_list_str}" }}'
+# we define custom attributes for the nodes
+attr_str = f'dpdk_componentType="{component_type}"'
+if optional:
+# we use a dotted line to represent optional dependencies
+attr_str += ',style="dotted"'
+if display_name is not None:
+attr_str += f',dpdk_displayName="{display_name}"'
+return f'"{component}"{deps_str} [{attr_str}]\n'
+
+
+def _main():
+depsfile = f'{os.environ["MESON_BUILD_ROOT"]}/deps.dot'
+
+# to reset the deps file on each build, the script is called without any 
params
+if len(sys.argv) == 1:
+os.remove(depsfile)
+sys.exit(0)
+
+# we got arguments, parse them
+parser = argparse.ArgumentParser(
+description="Generate a dependency graph for meson."
+)
+# type is required
+parser.add_argument(
+"--type", required=True, help="Type of dependency (lib, examples, 
etc.)"
+)
+parser.add_argument(
+"--optional", action="store_true", help="Whether the dependency is 
optional"
+)
+parser.add_argument(
+"--display-name",
+help="Component name as it is used in the build system",
+)
+# component is required
+parser.add_argument("component", help="The component to add to the graph")
+parser.add_argument("deps", nargs="*", help="The dependencies of the 
component")
+
+parsed = parser.parse_args()
+
+try:
+contents = file_to_list(depsfile)
+exce

[PATCH v5 7/8] build: reduce app dependencies

From: Bruce Richardson 

Remove any unnecessary dependencies from the app dependency lists.
This will give each app a near-minimum set of required dependencies.

Signed-off-by: Bruce Richardson 
---
 app/dumpcap/meson.build  | 2 +-
 app/graph/meson.build| 2 +-
 app/pdump/meson.build| 2 +-
 app/proc-info/meson.build| 2 +-
 app/test-crypto-perf/meson.build | 2 +-
 app/test-fib/meson.build | 2 +-
 app/test-sad/meson.build | 2 +-
 app/test/meson.build | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/dumpcap/meson.build b/app/dumpcap/meson.build
index 69c016c780..6204cf051a 100644
--- a/app/dumpcap/meson.build
+++ b/app/dumpcap/meson.build
@@ -14,4 +14,4 @@ endif
 
 ext_deps += pcap_dep
 sources = files('main.c')
-deps += ['ethdev', 'pdump', 'pcapng', 'bpf']
+deps += ['pdump']
diff --git a/app/graph/meson.build b/app/graph/meson.build
index 344e4a418f..9c4cd080d9 100644
--- a/app/graph/meson.build
+++ b/app/graph/meson.build
@@ -9,7 +9,7 @@ if not build
 subdir_done()
 endif
 
-deps += ['graph', 'eal', 'lpm', 'ethdev', 'node', 'cmdline', 'net']
+deps += ['node', 'cmdline']
 sources = files(
 'cli.c',
 'conn.c',
diff --git a/app/pdump/meson.build b/app/pdump/meson.build
index fb282bba1f..a10f9d6124 100644
--- a/app/pdump/meson.build
+++ b/app/pdump/meson.build
@@ -8,4 +8,4 @@ if is_windows
 endif
 
 sources = files('main.c')
-deps += ['ethdev', 'kvargs', 'pdump']
+deps += ['pdump']
diff --git a/app/proc-info/meson.build b/app/proc-info/meson.build
index 5fefb0857e..3631d7a675 100644
--- a/app/proc-info/meson.build
+++ b/app/proc-info/meson.build
@@ -8,5 +8,5 @@ if is_windows
 endif
 
 sources = files('main.c')
-deps += ['ethdev', 'security', 'eventdev']
+deps += ['security', 'eventdev']
 optional_deps += 'metrics'
diff --git a/app/test-crypto-perf/meson.build b/app/test-crypto-perf/meson.build
index 1ac0ac1099..839d42e28d 100644
--- a/app/test-crypto-perf/meson.build
+++ b/app/test-crypto-perf/meson.build
@@ -19,5 +19,5 @@ sources = files(
 'cperf_test_verify.c',
 'main.c',
 )
-deps += ['cryptodev', 'net', 'security']
+deps += ['cryptodev']
 optional_deps += 'crypto_scheduler'
diff --git a/app/test-fib/meson.build b/app/test-fib/meson.build
index eb36772cf3..25e2ea1a1d 100644
--- a/app/test-fib/meson.build
+++ b/app/test-fib/meson.build
@@ -8,4 +8,4 @@ if is_windows
 endif
 
 sources = files('main.c')
-deps += ['fib', 'lpm', 'net']
+deps += ['fib', 'lpm']
diff --git a/app/test-sad/meson.build b/app/test-sad/meson.build
index a50616a9c7..414e2a05cb 100644
--- a/app/test-sad/meson.build
+++ b/app/test-sad/meson.build
@@ -8,4 +8,4 @@ if is_windows
 endif
 
 sources = files('main.c')
-deps += ['ipsec', 'net']
+deps += ['ipsec']
diff --git a/app/test/meson.build b/app/test/meson.build
index 36c2016a49..a77c152ef3 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -2,7 +2,7 @@
 # Copyright(c) 2017-2023 Intel Corporation
 
 # the main test files [test.c and commands.c] relies on these libraries
-deps += ['cmdline', 'ring', 'mempool', 'mbuf']
+deps += ['cmdline']
 sources += files('commands.c', 'test.c')
 
 # optional dependencies: some files may use these - and so we should link them 
in -
-- 
2.43.5

[PATCH v5 4/8] build: remove kvargs from driver class dependencies

From: Bruce Richardson 

The kvargs library is used by EAL, and therefore is implicitly a
dependency of every DPDK driver. Remove it from the minimum set of
dependencies for each driver class as it's unnecessary to call it out
there.

Signed-off-by: Bruce Richardson 
---
 drivers/event/meson.build | 2 +-
 drivers/net/meson.build   | 2 +-
 drivers/regex/meson.build | 2 +-
 drivers/vdpa/meson.build  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/event/meson.build b/drivers/event/meson.build
index d6706b57f7..2708833adf 100644
--- a/drivers/event/meson.build
+++ b/drivers/event/meson.build
@@ -19,4 +19,4 @@ if not (toolchain == 'gcc' and 
cc.version().version_compare('<4.8.6') and
 dpdk_conf.has('RTE_ARCH_ARM64'))
 drivers += 'octeontx'
 endif
-std_deps = ['eventdev', 'kvargs']
+std_deps = ['eventdev']
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index dafd637ba4..3b388ead24 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -65,6 +65,6 @@ drivers = [
 'vmxnet3',
 'zxdh',
 ]
-std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc
+std_deps = ['ethdev']   # 'ethdev' also pulls in mbuf, net, eal etc
 std_deps += ['bus_pci'] # very many PMDs depend on PCI, so make std
 std_deps += ['bus_vdev']# same with vdev bus
diff --git a/drivers/regex/meson.build b/drivers/regex/meson.build
index ff2a8fea89..10192e7c77 100644
--- a/drivers/regex/meson.build
+++ b/drivers/regex/meson.build
@@ -5,4 +5,4 @@ drivers = [
 'mlx5',
 'cn9k',
 ]
-std_deps = ['ethdev', 'kvargs', 'regexdev'] # 'ethdev' also pulls in mbuf, 
net, eal etc
+std_deps = ['ethdev', 'regexdev'] # 'ethdev' also pulls in mbuf, net, eal etc
diff --git a/drivers/vdpa/meson.build b/drivers/vdpa/meson.build
index 896e8e0304..e01c277b9e 100644
--- a/drivers/vdpa/meson.build
+++ b/drivers/vdpa/meson.build
@@ -11,5 +11,5 @@ drivers = [
 'nfp',
 'sfc',
 ]
-std_deps = ['bus_pci', 'kvargs']
+std_deps = ['bus_pci']
 std_deps += ['vhost']
-- 
2.43.5

[PATCH v1 1/1] usertools/devbind: fix missing active marker

When adding NUMA node printouts, the "*Active*" marker was accidentally
omitted. Add it back in.

Fixes: a7d69cef8f20 ("usertools/devbind: print device NUMA node")

Signed-off-by: Anatoly Burakov 
---
 usertools/dpdk-devbind.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index f2a2a9a12f..34f8f3ed3b 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -631,6 +631,7 @@ def show_device_status(devices_type, device_name, 
if_field=False):
 extra_param = "if=%(Interface)s " + extra_param
 if print_numa:
 extra_param = "numa_node=%(NUMANode)s " + extra_param
+extra_param += " %(Active)s"
 display_devices("%s devices using kernel driver" % device_name,
 kernel_drv, extra_param)
 if no_drv:
-- 
2.43.5

[PATCH v2] crypto/virtio: remove redundant crypto queue free

2024-11-27 Thread Rajesh Mudimadugula

Remove multiple invocations of virtio_crypto_queue_release,
and set virtio crypto queue as null upon free to avoid
segfaults.

Signed-off-by: Rajesh Mudimadugula 
---
 .mailmap |  1 +
 drivers/crypto/virtio/virtio_cryptodev.c | 11 +--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.mailmap b/.mailmap
index 7334ad58a9..66e275c262 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1246,6 +1246,7 @@ Rahul Gupta 
 Rahul Lakkireddy 
 Rahul Shah 
 Raja Zidane 
+Rajesh Mudimadugula 
 Rajesh Ravi 
 Rakesh Kudurumalla  
 Ralf Hoffmann 
diff --git a/drivers/crypto/virtio/virtio_cryptodev.c 
b/drivers/crypto/virtio/virtio_cryptodev.c
index 643921dc02..98415af123 100644
--- a/drivers/crypto/virtio/virtio_cryptodev.c
+++ b/drivers/crypto/virtio/virtio_cryptodev.c
@@ -478,10 +478,13 @@ virtio_crypto_free_queues(struct rte_cryptodev *dev)
 
/* control queue release */
virtio_crypto_queue_release(hw->cvq);
+   hw->cvq = NULL;
 
/* data queue release */
-   for (i = 0; i < hw->max_dataqueues; i++)
+   for (i = 0; i < hw->max_dataqueues; i++) {
virtio_crypto_queue_release(dev->data->queue_pairs[i]);
+   dev->data->queue_pairs[i] = NULL;
+   }
 }
 
 static int
@@ -613,6 +616,7 @@ virtio_crypto_qp_release(struct rte_cryptodev *dev, 
uint16_t queue_pair_id)
}
 
virtio_crypto_queue_release(vq);
+   dev->data->queue_pairs[queue_pair_id] = NULL;
return 0;
 }
 
@@ -760,8 +764,6 @@ crypto_virtio_create(const char *name, struct 
rte_pci_device *pci_dev,
 static int
 virtio_crypto_dev_uninit(struct rte_cryptodev *cryptodev)
 {
-   struct virtio_crypto_hw *hw = cryptodev->data->dev_private;
-
PMD_INIT_FUNC_TRACE();
 
if (rte_eal_process_type() == RTE_PROC_SECONDARY)
@@ -776,9 +778,6 @@ virtio_crypto_dev_uninit(struct rte_cryptodev *cryptodev)
cryptodev->enqueue_burst = NULL;
cryptodev->dequeue_burst = NULL;
 
-   /* release control queue */
-   virtio_crypto_queue_release(hw->cvq);
-
rte_free(cryptodev->data);
cryptodev->data = NULL;
 
-- 
2.34.1

[PATCH v1 1/1] net/ixgbe: fix missing VF PCI ID

PCI ID's for E610 devices were added, but the ID's that were added were
only for physical functions, not VF's. Add missing PCI ID for E610 VF.

Fixes: 5662e97457eb ("net/ixgbe: add PCI IDs for new E610 variants")

Signed-off-by: Anatoly Burakov 
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index dfb29295a9..8bee97d191 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -475,6 +475,7 @@ static const struct rte_pci_id pci_id_ixgbevf_map[] = {
{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_X550EM_A_VF_HV) },
{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_X550EM_X_VF) },
{ RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_X550EM_X_VF_HV) },
+   { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_E610_VF) },
{ .vendor_id = 0, /* sentinel */ },
 };
 
-- 
2.43.5

[PATCH v2] lib/eal: fix macros for noinline and alwaysinline for MSVC

MSVC supports forcing code to be inlined or forcing code to not be
inlined, like other compilers.

This patch fixes existing macros __rte_noinline and
__rte_always_inline so that they also do what is expected from them
when used with MSVC.

Signed-off-by: Andre Muezerie 
---
 lib/eal/include/rte_common.h | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index 21bfd26b2b..ed6e2c7ffd 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -410,7 +410,7 @@ static void __attribute__((destructor(RTE_PRIO(prio)), 
used)) func(void)
  * Force a function to be inlined
  */
 #ifdef RTE_TOOLCHAIN_MSVC
-#define __rte_always_inline
+#define __rte_always_inline __forceinline
 #else
 #define __rte_always_inline inline __attribute__((always_inline))
 #endif
@@ -418,7 +418,11 @@ static void __attribute__((destructor(RTE_PRIO(prio)), 
used)) func(void)
 /**
  * Force a function to be noinlined
  */
+#ifdef RTE_TOOLCHAIN_MSVC
+#define __rte_noinline __declspec(noinline)
+#else
 #define __rte_noinline __attribute__((noinline))
+#endif
 
 /**
  * Hint function in the hot path
-- 
2.34.1

[PATCH] test/crypto: return proper codes in create session

2024-11-27 Thread Rajesh Mudimadugula

Return proper error codes in create_auth_session() to avoid
segfaults as a result of this.

Signed-off-by: Rajesh Mudimadugula 
---
 app/test/test_cryptodev.c | 38 --
 1 file changed, 28 insertions(+), 10 deletions(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index c647baeee1..448ace3216 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -13009,6 +13009,8 @@ test_cryptodev_error_recover_helper(uint8_t dev_id, 
const void *test_data, bool
 
ut_params->sess = rte_cryptodev_sym_session_create(dev_id, 
&ut_params->cipher_xform,
   
ts_params->session_mpool);
+   if (ut_params->sess == NULL && rte_errno == ENOTSUP)
+   return TEST_SKIPPED;
TEST_ASSERT_NOT_NULL(ut_params->sess, "Session creation failed");
 
ut_params->op = rte_crypto_op_alloc(ts_params->op_mpool, 
RTE_CRYPTO_OP_TYPE_SYMMETRIC);
@@ -14710,15 +14712,19 @@ test_multi_session(void)
sessions[i] = rte_cryptodev_sym_session_create(
ts_params->valid_devs[0], &ut_params->auth_xform,
ts_params->session_mpool);
-   if (sessions[i] == NULL && rte_errno == ENOTSUP) {
+   if (sessions[i] == NULL) {
nb_sess = i;
-   ret = TEST_SKIPPED;
+   if (rte_errno == ENOTSUP)
+   ret = TEST_SKIPPED;
+   else {
+   ret = TEST_FAILED;
+   printf("TestCase %s() line %d failed : "
+   "Session creation failed at 
session number %u",
+   __func__, __LINE__, i);
+   }
break;
}
 
-   TEST_ASSERT_NOT_NULL(sessions[i],
-   "Session creation failed at session number %u",
-   i);
 
/* Attempt to send a request on each session */
ret = test_AES_CBC_HMAC_SHA512_decrypt_perform(
@@ -14846,15 +14852,19 @@ test_multi_session_random_usage(void)
ts_params->valid_devs[0],
&ut_paramz[i].ut_params.auth_xform,
ts_params->session_mpool);
-   if (sessions[i] == NULL && rte_errno == ENOTSUP) {
+   if (sessions[i] == NULL) {
nb_sess = i;
-   ret = TEST_SKIPPED;
+   if (rte_errno == ENOTSUP)
+   ret = TEST_SKIPPED;
+   else {
+   ret = TEST_FAILED;
+   printf("TestCase %s() line %d failed : "
+   "Session creation failed at 
session number %u",
+   __func__, __LINE__, i);
+   }
goto session_clear;
}
 
-   TEST_ASSERT_NOT_NULL(sessions[i],
-   "Session creation failed at session number %u",
-   i);
}
 
nb_sess = i;
@@ -14937,6 +14947,8 @@ test_null_invalid_operation(void)
ut_params->sess = rte_cryptodev_sym_session_create(
ts_params->valid_devs[0], &ut_params->cipher_xform,
ts_params->session_mpool);
+   if (ut_params->sess == NULL && rte_errno == ENOTSUP)
+   return TEST_SKIPPED;
TEST_ASSERT(ut_params->sess == NULL,
"Session creation succeeded unexpectedly");
 
@@ -14951,6 +14963,8 @@ test_null_invalid_operation(void)
ut_params->sess = rte_cryptodev_sym_session_create(
ts_params->valid_devs[0], &ut_params->auth_xform,
ts_params->session_mpool);
+   if (ut_params->sess == NULL && rte_errno == ENOTSUP)
+   return TEST_SKIPPED;
TEST_ASSERT(ut_params->sess == NULL,
"Session creation succeeded unexpectedly");
 
@@ -15098,6 +15112,8 @@ test_enqdeq_callback_null_cipher(void)
/* Create Crypto session */
ut_params->sess = 
rte_cryptodev_sym_session_create(ts_params->valid_devs[0],
&ut_params->auth_xform, 
ts_params->session_mpool);
+   if (ut_params->sess == NULL && rte_errno == ENOTSUP)
+   return TEST_SKIPPED;
TEST_ASSERT_NOT_NULL(ut_params->sess, "Session creation failed");
 
ut_params->op = rte_crypto_op_alloc(ts_params->op_mpool, 
RTE_CRYPTO_OP_TYPE_SYMMETRIC);
@@ -16158,6 +16174,7 @@ create_auth_session(struct crypto_unittest_params 
*ut_params,
ts_params->session_mpool);
if (ut_params->se

Re: [PATCH v1 1/1] net/ixgbe: fix missing VF PCI ID

On Wed, Nov 27, 2024 at 04:16:17PM +, Anatoly Burakov wrote:
> PCI ID's for E610 devices were added, but the ID's that were added were
> only for physical functions, not VF's. Add missing PCI ID for E610 VF.
> 
> Fixes: 5662e97457eb ("net/ixgbe: add PCI IDs for new E610 variants")
> 
> Signed-off-by: Anatoly Burakov 
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c 
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index dfb29295a9..8bee97d191 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -475,6 +475,7 @@ static const struct rte_pci_id pci_id_ixgbevf_map[] = {
>   { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_X550EM_A_VF_HV) },
>   { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_X550EM_X_VF) },
>   { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_X550EM_X_VF_HV) },
> + { RTE_PCI_DEVICE(IXGBE_INTEL_VENDOR_ID, IXGBE_DEV_ID_E610_VF) },
>   { .vendor_id = 0, /* sentinel */ },
>  };
Acked-by: Bruce Richardson 

Applied to dpdk-next-net-intel

Thanks,
/Bruce

Re: [PATCH V1] doc: add tested Intel platforms with Intel NICs

On Wed, Nov 27, 2024 at 03:16:01AM +, Lingli Chen wrote:
> Add tested Intel platforms with Intel NICs to v24.11 release note.
> 
> Signed-off-by: Lingli Chen 
> ---
>  doc/guides/rel_notes/release_24_11.rst | 165 +
>  1 file changed, 165 insertions(+)
> 
Applied to dpdk-next-net-intel.

Thanks,
/Bruce

[PATCH] lib/eal: fix macros for noinline and alwaysinline for MSVC

From: Andre Muezerie 

MSVC supports forcing code to be inlined or forcing code to not be
inlined, like other compilers.

This patch fixes existing macros __rte_noinline and
__rte_always_inline so that they also do what is expected from them
when used with MSVC.

Signed-off-by: Andre Muezerie 
---
 lib/eal/include/rte_common.h | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h
index 4d299f2b36..f97e52f869 100644
--- a/lib/eal/include/rte_common.h
+++ b/lib/eal/include/rte_common.h
@@ -408,7 +408,7 @@ static void __attribute__((destructor(RTE_PRIO(prio)), 
used)) func(void)
  * Force a function to be inlined
  */
 #ifdef RTE_TOOLCHAIN_MSVC
-#define __rte_always_inline
+#define __rte_always_inline __forceinline
 #else
 #define __rte_always_inline inline __attribute__((always_inline))
 #endif
@@ -416,7 +416,11 @@ static void __attribute__((destructor(RTE_PRIO(prio)), 
used)) func(void)
 /**
  * Force a function to be noinlined
  */
+#ifdef RTE_TOOLCHAIN_MSVC
+#define __rte_noinline __declspec(noinline)
+#else
 #define __rte_noinline __attribute__((noinline))
+#endif
 
 /**
  * Hint function in the hot path
-- 
2.47.0.vfs.0.3

Re: [PATCH v5 6/8] build: reduce driver dependencies

2024-11-27 Thread Burakov, Anatoly


On 11/27/2024 3:56 PM, Anatoly Burakov wrote:

From: Bruce Richardson 

Remove any unnecessary dependencies from the driver dependency lists.
This will give each driver a near-minimum set of required dependencies.

Signed-off-by: Bruce Richardson 
Reviewed-by: Rosen Xu 
---




diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build
index 5a8de16fe0..5ffb56fc93 100644
--- a/drivers/common/qat/meson.build
+++ b/drivers/common/qat/meson.build
@@ -71,7 +71,7 @@ else
  endif
  endif
  
-deps += ['bus_pci', 'cryptodev', 'net', 'compressdev']

+deps += ['bus_pci']
  sources += files(
  'qat_common.c',
  'qat_qp.c',
@@ -101,6 +101,7 @@ if qat_compress
  ]
  sources += files(join_paths(qat_compress_relpath, f))
  endforeach
+deps += ['compressdev']
  endif
  
  if qat_crypto


Seems that these changes were overly aggressive and cause build 
failures. Will fix in v6.


--
Thanks,
Anatoly

[PATCH] eal: fix bus cleanup in secondary process

2024-11-27 Thread myang

eal_bus_cleanup has been added in rte_eal_cleanup. But for
secondary process, eal_bus_cleanup will trigger vdev_cleanup
which trigger rte_vdev_driver to remove. Then our crypto devices
will execute ipsec_mb_remove to rte_cryptodev_pmd_destroy.

Finally error logs occur as below:
CRYPTODEV: rte_cryptodev_close() line 1453: Device 0 must be
stopped before closing
EAL: failed to send to (/tmp/dpdk/l2hicu/mp_socket) due to Bad
file descriptor
EAL: Fail to send request /tmp/dpdk/l2hicu/mp_socket:ipsec_mb_mp_msg
USER1: Create MR request to primary process failed.

Function call trace: rte_eal_cleanup->eal_bus_cleanup->
vdev_cleanup->rte_vdev_driver->ipsec_mb_remove->
1. ipsec_mb_remove->rte_cryptodev_pmd_destroy->
rte_cryptodev_pmd_release_device->rte_cryptodev_close
2. ipsec_mb_remove->ipsec_mb_qp_release->ipsec_mb_secondary_qp_op
->rte_mp_request_async->mp_request_async

Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown")
Cc: sta...@dpdk.org

Signed-off-by: myang 
---
 lib/eal/linux/eal.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index a6220524a4..eec791ce1e 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -1320,7 +1320,8 @@ rte_eal_cleanup(void)
vfio_mp_sync_cleanup();
 #endif
rte_mp_channel_cleanup();
-   eal_bus_cleanup();
+   if (rte_eal_process_type() == RTE_PROC_PRIMARY)
+   eal_bus_cleanup();
rte_trace_save();
eal_trace_fini();
eal_mp_dev_hotplug_cleanup();
-- 
2.34.1

RE: [EXTERNAL] Re: [RFC] crypto/virtio: add vhost-vdpa backend

2024-11-27 Thread Gowrishankar Muthukrishnan

Hi Jason,
> Hello:
> 
> On Fri, Nov 22, 2024 at 2:03 AM Gowrishankar Muthukrishnan
>  wrote:
> >
> > Hi,
> > We are adding support for vDPA user backend for virtio-crypto PMD in DPDK.
> 
> I wonder what kind of vDPA device you are using? Is there a marvell specific
> vDPA or just a standard virtio-pci device via vp-vdpa.
> 
Yes, we have Marvell specific vDPA.
https://github.com/ColinIanKing/linux-next/commit/8b6c724cdab85d8923dd8c474a5a9464228379c5

Thanks,
Gowrishankar
> Thanks

RE: release candidate 24.11-rc3

2024-11-27 Thread Xu, HailinX

> -Original Message-
> From: Thomas Monjalon 
> Sent: Wednesday, November 20, 2024 10:13 AM
> To: annou...@dpdk.org
> Subject: release candidate 24.11-rc3
> 
> A new DPDK release candidate is ready for testing:
>   https://git.dpdk.org/dpdk/tag/?id=v24.11-rc3
> 
> There are 192 new patches in this snapshot.
> Hopefully almost everything expected should be in.
> 
> Release notes:
>   https://doc.dpdk.org/guides/rel_notes/release_24_11.html
> 
> Highlights of 24.11-rc3:
>   - Realtek r8169 net driver
>   - ZTE gdtc raw driver
> 
> As usual, you can report any issue on https://bugs.dpdk.org
> 
> Only documentation and critical bug fixes should be accepted at this stage.
> 
> There are only 10 days remaining before the end of the month.
> DPDK 24.11-rc4 should be the last release candidate (in one week).
> 
> Thank you everyone
> 
Update the test status for Intel part. dpdk24.11-rc3 all test is done. found 
one new issue.

New issue:
1. [dpdk-24.11] Linkville mseon_tests/test_perf: pmd_perf_autotest Unsupported 
loopback mode-> Fixed

# Basic Intel(R) NIC testing
* Build or compile:  
 *Build: cover the build test combination with latest GCC/Clang version and the 
popular OS revision such as Ubuntu24.10, Ubuntu24.04.1, Fedora40, RHEL8.10 
RHEL9.4, FreeBSD14.1, SUSE15.6, OpenAnolis8.9, AzureLinux 3.0 etc.
  - Execution rate is done. No new issue is found.
 *Compile: cover the CFLAGES(O0/O1/O2/O3) with popular OS such as Ubuntu24.04.1 
and RHEL9.4.
  - All test passed with latest dpdk.
* PF/VF(i40e, ixgbe): test scenarios including 
PF/VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc. 
- All test case is done. found the 1 issue.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow 
Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
- Execution rate is done. No new issue is found.
* CPF/APF(MEV): test scenarios including 
APF-HOST,CPF-HOST,CPF-ACC,cpfl_rte_flow/MTU/Jumboframe/checksum offload, etc.
- Execution rate is done. No new issue is found.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single 
core performance test, RFC2544 Zero packet loss performance test, etc.
- Execution rate is done. No new issue is found.
* Power and IPsec: 
 * Power: test scenarios including bi-direction/Telemetry/Empty Poll 
Lib/Priority Base Frequency, etc. 
- Execution rate is done. No new issue is found.
 * IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - 
QAT&SW/FIB library, etc.
- Execution rate is done. No new issue is found. 
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as 
PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE 
ESXI 8.0U1, etc.
- Execution rate is done. No new issue is found.
* Cryptodev: 
 *Function test: test scenarios including Cryptodev API testing/CompressDev 
ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
- Execution rate is done. No new issue is found. 
 *Performance test: test scenarios including Throughput Performance /Cryptodev 
Latency, etc.
- Execution rate is done. No performance drop.

Regards,
Xu, Hailin

Re: [PATCH v2 1/1] usertools/devbind: allow changing UID/GID for VFIO

2024-11-27 Thread Burakov, Anatoly


On 11/26/2024 5:15 PM, Robin Jarry wrote:

Hi Anatoly,

Anatoly Burakov, Nov 26, 2024 at 16:02:

Currently, when binding a device to VFIO, the UID/GID for the device will
always stay as system default (`root`). Yet, when running DPDK as non- 
root

user, one has to change the UID/GID of the device to match the user's
UID/GID to use the device.

This patch adds an option to `dpdk-devbind.py` to change the UID/GID of
the device when binding it to VFIO.

Signed-off-by: Anatoly Burakov 
---

Notes:
    v1 -> v2:
    - Replaced hard exit with an error printout


Sorry I had missed that particular detail.

I don't think this should only print a warning. Otherwise, the user has 
no way to detect if the operation failed.


Sure, I'll change it back.


 from glob import glob
 from os.path import exists, basename
@@ -108,6 +110,8 @@
 status_flag = False
 force_flag = False
 noiommu_flag = False
+vfio_uid = ""
+vfio_gid = ""


These are supposed to be integers. Initialize them to -1.


Actually, the pwd.getpwnam() accepts strings not integers, but yeah, 
technically these are supposed to be integers. I'll change that.





 args = []


@@ -463,6 +467,22 @@ def bind_one(dev_id, driver, force):
  % (dev_id, filename, err))


+def own_one(dev_id, uid, gid):
+    """Set the IOMMU group ownership for a device"""
+    # find IOMMU group for a particular device
+    iommu_grp_base_path = os.path.join("/sys/bus/pci/devices", 
dev_id, "iommu_group")

+    try:
+    iommu_grp = os.path.basename(os.readlink(iommu_grp_base_path))
+    # we found IOMMU group, now find the device
+    dev_path = os.path.join("/dev/vfio", iommu_grp)
+    # set the ownership
+    _uid = pwd.getpwnam(uid).pw_uid if uid else -1
+    _gid = grp.getgrnam(gid).gr_gid if gid else -1


The validity of these values should be checked when parsing command line 
arguments.


Sure, I'll move this check somewhere close to init.




+    os.chown(dev_path, _uid, _gid)
+    except OSError as err:
+    print(f"Error: failed to read IOMMU group for {dev_id}: {err}")


Remove the try/except block and let the error bubble up the stack. This 
probably does not require a dedicated function. Moreover, the name 
own_one() is ambiguous.


We do the same thing for other errors (e.g. in bind_one) so I'm not sure 
if we want to let it bubble up the stack - we don't catch any exceptions 
anywhere up the stack. Current implementation, however deficient from 
error handling point of view, is consistent with the rest of the script.



 # For kernels < 3.15 when binding devices to a generic driver
 # (i.e. one that doesn't have a PCI ID table) using new_id, some 
devices

@@ -697,6 +720,8 @@ def parse_args():
 global force_flag
 global noiommu_flag
 global args
+    global vfio_uid
+    global vfio_gid

 parser = argparse.ArgumentParser(
 description='Utility to bind and unbind devices from Linux 
kernel',

@@ -746,6 +771,12 @@ def parse_args():
 '--noiommu-mode',
 action='store_true',
 help="If IOMMU is not available, enable no IOMMU mode for 
VFIO drivers")

+    parser.add_argument(
+    "-U", "--uid", help="For VFIO, specify the UID to set IOMMU 
group ownership"


In order to fail early if an invalid user name is passed, add these two 
lines:


   type=lambda u: pwd.getpwnam(u).pw_uid,
   default=-1,



Guido doesn't like lambdas :D


--
Thanks,
Anatoly

Re: rte_event_eth_tx_adapter_enqueue() short enqueue

On Wed, Nov 27, 2024 at 11:03:31AM +0100, Mattias Rönnblom wrote:
> Hi.
> 
> Consider the following situation:
> 
> An application does
> 
> rte_event_eth_tx_adapter_enqueue()
> 
> and due to back-pressure or some other reason not all events/packets could
> be enqueued, and a count lower than the nb_events input parameter is
> returned.
> 
> The API says that "/../ the remaining events at the end of ev[] are not
> consumed and the caller has to take care of them /../".
> 
> May an event device rearrange the ev array so that any enqueue failures are
> put last in the ev array?
> 
> In other words: does the "at the end of ev[]" mean "at the end of ev[] as
> the call has completed", or is the event array supposed to be untouched, and
> thus the same events are at the end both before and after the call.
> 
> The ev array pointer is not const, so from that perspective it may be
> modified.
> 
> This situation may occur for example the bonding driver is used under the
> hood. The bonding driver does this kind of rearrangements on the ethdev
> level.
> 

Interesting question. I tend to think that we should not proclude this
reordering, as it should allow e.g  an eventdev which is short on space to
selectively enqueue only the high priority events.

Only caveat is that if we do allow the reordering we clarify the
documentation to explicitly state that it is allowed.

/Bruce

RE: [PATCH 2/3] eventdev: fix uninitialized variable

2024-11-27 Thread Gujjar, Abhinandan S




> -Original Message-
> From: Ma, WenwuX 
> Sent: Monday, November 25, 2024 12:18 PM
> To: ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com;
> amitpraka...@marvell.com; Gujjar, Abhinandan S
> ; dev@dpdk.org; sta...@dpdk.org
> Cc: Liao, TingtingX ; Ma, WenwuX
> 
> Subject: [PATCH 2/3] eventdev: fix uninitialized variable
> 
> This patch fixes the variable 'events' may be used uninitialized.
> 
> Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Wenwu Ma 
> ---
>  lib/eventdev/rte_event_crypto_adapter.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/eventdev/rte_event_crypto_adapter.c
> b/lib/eventdev/rte_event_crypto_adapter.c
> index 939ca1cad9..1ca839510b 100644
> --- a/lib/eventdev/rte_event_crypto_adapter.c
> +++ b/lib/eventdev/rte_event_crypto_adapter.c
> @@ -685,6 +685,7 @@ eca_ops_enqueue_burst(struct
> event_crypto_adapter *adapter,
>   nb_ev = 0;
>   retry = 0;
>   nb_enqueued = 0;
> + memset(events, 0, sizeof(events));
There is a rte_memcpy() at line number 699 which is copying response 
information as event into this.
So, that will initialize all the event fields. We don't require to initialize 
events here.

>   num = RTE_MIN(num, BATCH_SIZE);
>   for (i = 0; i < num; i++) {
>   struct rte_event *ev = &events[nb_ev++];
> --
> 2.34.1

Re: [RFC] crypto/virtio: add vhost-vdpa backend

2024-11-27 Thread Jason Wang

Hello:

On Fri, Nov 22, 2024 at 2:03 AM Gowrishankar Muthukrishnan
 wrote:
>
> Hi,
> We are adding support for vDPA user backend for virtio-crypto PMD in DPDK.

I wonder what kind of vDPA device you are using? Is there a marvell
specific vDPA or just a standard virtio-pci device via vp-vdpa.

Thanks

Re: Doubts in JumboFrames and stats_checks tests in DTS.

2024-11-27 Thread Bharati Bhole - Geminus

Hi Patrik,

I used site - https://dpdk.org/git/dpdk to clone the DPDK code. I tried to go 
through the DTS/README.md file.

This file says, it uses docker container for dev as well as test execution. But 
I did not find any steps for setting up the test environment for it.

I tried to look for the steps at https://doc.dpdk.org/guides/tools/dts.html but 
its not there.
Can you please point me to the document for the execution steps?

Thanks,
Bharati.


From: Patrick Robb 
Sent: 22 November 2024 10:29 PM
To: Bharati Bhole - Geminus 
Cc: d...@dpdk.org ; Nicholas Pratte ; Dean 
Marx ; Paul Szczepanek ; Luca 
Vizzarro ; NBU-Contact-Thomas Monjalon (EXTERNAL) 
; dev 
Subject: Re: Doubts in JumboFrames and stats_checks tests in DTS.

Hi Bharati,

Welcome to the DTS mailing list. I will try to provide some answers based on my 
experience running DTS at the DPDK Community Lab at UNH. I will also flag that 
this "legacy" version of DTS is deprecated and getting minimal maintenance. The 
majority of the current efforts for DTS are directed towards the rewrite which 
exists within the /dts dir of the DPDK repo: https://git.dpdk.org/dpdk/tree/dts

With that being said, of course the legacy repo is still useful and I encourage 
you to use it, so I will provide some comments inline below:

On Fri, Nov 22, 2024 at 9:43 AM Bharati Bhole - Geminus 
mailto:c_bhara...@xsightlabs.com>> wrote:
Hi,

I am Bharati Bhole. I am a new member of DTS mailing list.
I have recently started working on DTS for my company and facing some 
issues/failures while running the DTS.
Please help me with understanding the test cases and expected behaviours.

I am trying to understand the DTS behaviour for following TCs:

1. JumboFrames :

  1.
When the test set the max_pkt_len for testpmd and calculate the expected 
acceptable packet size, does it consider NICs supporting 2 VLANS? (In case of 
MTU update test, I have seen that 2 VLANs NIC are being considered while 
calculating acceptable packets size but in JumboFrames I dont see it).

No, 2 VLANs is not properly accounted for in the Jumboframes testsuite. And, 
this is actually highly topical, as this is an ongoing point of discussion in 
rewriting jumboframes and mtu_update for the new DTS framework (the testcases 
are getting combined into 1 testsuite).  I will paste the function from 
mtu_update of legacy DTS which you may be referring to:

--

def send_packet_of_size_to_port(self, port_id: int, pktsize: int):

# The packet total size include ethernet header, ip header, and payload.
# ethernet header length is 18 bytes, ip standard header length is 20 
bytes.
# pktlen = pktsize - ETHER_HEADER_LEN
if self.kdriver in ["igb", "igc", "ixgbe"]:
max_pktlen = pktsize + ETHER_HEADER_LEN + VLAN
padding = max_pktlen - IP_HEADER_LEN - ETHER_HEADER_LEN - VLAN
else:
max_pktlen = pktsize + ETHER_HEADER_LEN + VLAN * 2
padding = max_pktlen - IP_HEADER_LEN - ETHER_HEADER_LEN
out = self.send_scapy_packet(
port_id,
f'Ether(dst=dutmac, 
src="52:00:00:00:00:00")/IP()/Raw(load="\x50"*{padding})',

--

One difference between legacy DTS and the "new" DTS is that in legacy DTS a 
master list of devices/drivers was maintained, and there were an endless amount 
of conditions like this where a device list would be checked, and then some 
behavior modified based on that list. Because this strategy leads to bugs, it's 
unresponsive to changes in driver code, hard to maintain, and for other 
reasons, we are no longer follow this approach in new DTS. Now, if we want to 
toggle different behavior (like determine max_pkt_len for a given MTU for a 
given device) that needs to be accomplished by querying testpmd for device info 
(there are various testpmd runtime commands for this). And, in situations where 
testpmd doesn't expose the information we need for checking device behavior in 
a particular testsuite - testpmd needs to be updated to allow for this.

I am CC'ing Nick who is the person writing the new jumboframes + MTU testsuite, 
which (work in progress) is on patchwork here: 
https://patchwork.dpdk.org/project/dpdk/patch/20240726141307.14410-3-npra...@iol.unh.edu/

Nick, maybe you can include the mailing list threads Thomas linke you, and 
explain your current understanding of how to handle this issue? This won't 
really help Bharati in the short term, but at least it will clarify to him how 
this issue will be handled in the new DTS framework, which presumably he will 
upgrade to using at some point.


  1.

  2.
In function jumboframes_send_packet() -

if received:
if self.nic.startswith("fastlinq"):
self.verify(
self.pmdout.check_tx_bytes(tx_pkts, rx_pkts)
and (self.pmdout.check_tx_bytes(tx_bytes, pktsize))
and (rx_byt

Re: Doubts in JumboFrames and stats_checks tests in DTS.

2024-11-27 Thread Bharati Bhole - Geminus

Hi Patrick,
Thanks a lot for the quick response.
Thank you for adding me in the discussion meeting.


Thank you,
Bharati.

From: Patrick Robb 
Sent: Friday, November 22, 2024 10:29:18 PM
To: Bharati Bhole - Geminus 
Cc: d...@dpdk.org ; Nicholas Pratte ; Dean 
Marx ; Paul Szczepanek ; Luca 
Vizzarro ; NBU-Contact-Thomas Monjalon (EXTERNAL) 
; dev 
Subject: Re: Doubts in JumboFrames and stats_checks tests in DTS.

Hi Bharati,

Welcome to the DTS mailing list. I will try to provide some answers based on my 
experience running DTS at the DPDK Community Lab at UNH. I will also flag that 
this "legacy" version of DTS is deprecated and getting minimal maintenance. The 
majority of the current efforts for DTS are directed towards the rewrite which 
exists within the /dts dir of the DPDK repo: https://git.dpdk.org/dpdk/tree/dts

With that being said, of course the legacy repo is still useful and I encourage 
you to use it, so I will provide some comments inline below:

On Fri, Nov 22, 2024 at 9:43 AM Bharati Bhole - Geminus 
mailto:c_bhara...@xsightlabs.com>> wrote:
Hi,

I am Bharati Bhole. I am a new member of DTS mailing list.
I have recently started working on DTS for my company and facing some 
issues/failures while running the DTS.
Please help me with understanding the test cases and expected behaviours.

I am trying to understand the DTS behaviour for following TCs:

1. JumboFrames :

  1.
When the test set the max_pkt_len for testpmd and calculate the expected 
acceptable packet size, does it consider NICs supporting 2 VLANS? (In case of 
MTU update test, I have seen that 2 VLANs NIC are being considered while 
calculating acceptable packets size but in JumboFrames I dont see it).

No, 2 VLANs is not properly accounted for in the Jumboframes testsuite. And, 
this is actually highly topical, as this is an ongoing point of discussion in 
rewriting jumboframes and mtu_update for the new DTS framework (the testcases 
are getting combined into 1 testsuite).  I will paste the function from 
mtu_update of legacy DTS which you may be referring to:

--

def send_packet_of_size_to_port(self, port_id: int, pktsize: int):

# The packet total size include ethernet header, ip header, and payload.
# ethernet header length is 18 bytes, ip standard header length is 20 
bytes.
# pktlen = pktsize - ETHER_HEADER_LEN
if self.kdriver in ["igb", "igc", "ixgbe"]:
max_pktlen = pktsize + ETHER_HEADER_LEN + VLAN
padding = max_pktlen - IP_HEADER_LEN - ETHER_HEADER_LEN - VLAN
else:
max_pktlen = pktsize + ETHER_HEADER_LEN + VLAN * 2
padding = max_pktlen - IP_HEADER_LEN - ETHER_HEADER_LEN
out = self.send_scapy_packet(
port_id,
f'Ether(dst=dutmac, 
src="52:00:00:00:00:00")/IP()/Raw(load="\x50"*{padding})',

--

One difference between legacy DTS and the "new" DTS is that in legacy DTS a 
master list of devices/drivers was maintained, and there were an endless amount 
of conditions like this where a device list would be checked, and then some 
behavior modified based on that list. Because this strategy leads to bugs, it's 
unresponsive to changes in driver code, hard to maintain, and for other 
reasons, we are no longer follow this approach in new DTS. Now, if we want to 
toggle different behavior (like determine max_pkt_len for a given MTU for a 
given device) that needs to be accomplished by querying testpmd for device info 
(there are various testpmd runtime commands for this). And, in situations where 
testpmd doesn't expose the information we need for checking device behavior in 
a particular testsuite - testpmd needs to be updated to allow for this.

I am CC'ing Nick who is the person writing the new jumboframes + MTU testsuite, 
which (work in progress) is on patchwork here: 
https://patchwork.dpdk.org/project/dpdk/patch/20240726141307.14410-3-npra...@iol.unh.edu/

Nick, maybe you can include the mailing list threads Thomas linke you, and 
explain your current understanding of how to handle this issue? This won't 
really help Bharati in the short term, but at least it will clarify to him how 
this issue will be handled in the new DTS framework, which presumably he will 
upgrade to using at some point.


  1.

  2.
In function jumboframes_send_packet() -

if received:
if self.nic.startswith("fastlinq"):
self.verify(
self.pmdout.check_tx_bytes(tx_pkts, rx_pkts)
and (self.pmdout.check_tx_bytes(tx_bytes, pktsize))
and (rx_bytes == pktsize),
"packet pass assert error",
)
else:
self.verify(
self.pmdout.check_tx_bytes(tx_pkts, rx_pkts)
and (self.pmdout.check_tx_bytes(tx_bytes + 4, pktsize))
and ((rx_bytes + 4) == pktsize)

Re: [PATCH] maintainers: update for DMA perf app

2024-11-27 Thread 姜诚


Good to have more maintainers for this app.

Thanks.

Acked-by: Cheng Jiang 

在 2023/10/27 11:00, Gowrishankar Muthukrishnan 写道:

Add co-maintainer for DMA perf app.

Signed-off-by: Gowrishankar Muthukrishnan 
---
  MAINTAINERS | 1 +
  1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4083658697..b81eb1d5c0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1773,6 +1773,7 @@ F: doc/guides/testpmd_app_ug/
  
  DMA device performance tool

  M: Cheng Jiang 
+M: Gowrishankar Muthukrishnan 
  F: app/test-dma-perf/
  F: doc/guides/tools/dmaperf.rst

[PATCH] vhost: clear ring addresses when getting vring base

2024-11-27 Thread jianping.zhao

From: "Jianping.zhao" 

Clear ring addresses during vring base retrieval to handle guest reboot
scenarios correctly. This is particularly important for vdpa-blk devices
where the following issue occurs:

When a guest OS with vdpa-blk device reboots, during UEFI stage, only
one vring is actually used and configured. However, QEMU still sends
enable messages for all configured queues. The remaining queues retain
their addresses from before reboot, which reference invalid memory
mappings in the rebooted guest.

The issue manifests in vq_is_ready():

static bool
vq_is_ready(struct virtio_net *dev, struct vhost_virtqueue *vq)
{
/* Only checks pointer validity, not address freshness */
rings_ok = vq->desc && vq->avail && vq->used;
...
}

vq_is_ready() incorrectly considers these queues as ready because it
only checks if desc/avail/used pointers are non-NULL, but cannot
detect that these addresses are stale from the previous boot.

Clear the ring addresses in vhost_user_get_vring_base() to force
the guest driver to reconfigure them before use. This ensures that
vq_is_ready() will return false for queues with stale addresses
until they are properly reconfigured by the guest driver.

Fixes: 3ea7052f4b1b ("vhost: postpone rings addresses translation")
Cc: sta...@dpdk.org
Cc: Maxime Coquelin 
Cc: Chenbo Xia 

Signed-off-by: jianping.zhao 
---
 lib/vhost/vhost_user.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 6d92ad904e..52d8078d7c 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -2277,6 +2277,7 @@ vhost_user_get_vring_base(struct virtio_net **pdev,

rte_rwlock_write_lock(&vq->access_lock);
vring_invalidate(dev, vq);
+   memset(&vq->ring_addrs, 0, sizeof(struct vhost_vring_addr));
rte_rwlock_write_unlock(&vq->access_lock);

return RTE_VHOST_MSG_RESULT_REPLY;
--
2.34.1

Re: Doubts in JumboFrames and stats_checks tests in DTS.

2024-11-27 Thread Bharati Bhole - Geminus

Hi Patrick,

11/26 16:00 UTC works for me.
Please let me know which link to join.

Thanks,
Bharati.

From: Patrick Robb 
Sent: Monday, November 25, 2024 9:27:29 PM
To: Bharati Bhole - Geminus 
Cc: d...@dpdk.org ; Nicholas Pratte ; Dean 
Marx ; Paul Szczepanek ; Luca 
Vizzarro ; NBU-Contact-Thomas Monjalon (EXTERNAL) 
; dev 
Subject: Re: Doubts in JumboFrames and stats_checks tests in DTS.

Hi Bharati,

It might be easiest to address your questions over a video conference call 
instead of email. Would this be okay?

I am free tomorrow 11/26 16:00-18:00 UTC, or Wednesday 11/27 14:00-16:00 UTC 
and 20:00-22:00 UTC. Or I have other availability if none of these work.

On Mon, Nov 25, 2024 at 5:45 AM Bharati Bhole - Geminus 
mailto:c_bhara...@xsightlabs.com>> wrote:
Hi Patrik,

I used site - https://dpdk.org/git/dpdk to clone the DPDK code. I tried to go 
through the DTS/README.md file.

This file says, it uses docker container for dev as well as test execution. But 
I did not find any steps for setting up the test environment for it.

I tried to look for the steps at https://doc.dpdk.org/guides/tools/dts.html but 
its not there.
Can you please point me to the document for the execution steps?

Thanks,
Bharati.


From: Patrick Robb mailto:pr...@iol.unh.edu>>
Sent: 22 November 2024 10:29 PM
To: Bharati Bhole - Geminus 
mailto:c_bhara...@xsightlabs.com>>
Cc: d...@dpdk.org mailto:d...@dpdk.org>>; 
Nicholas Pratte mailto:npra...@iol.unh.edu>>; Dean Marx 
mailto:dm...@iol.unh.edu>>; Paul Szczepanek 
mailto:paul.szczepa...@arm.com>>; Luca Vizzarro 
mailto:luca.vizza...@arm.com>>; NBU-Contact-Thomas 
Monjalon (EXTERNAL) mailto:tho...@monjalon.net>>; dev 
mailto:dev@dpdk.org>>
Subject: Re: Doubts in JumboFrames and stats_checks tests in DTS.

Hi Bharati,

Welcome to the DTS mailing list. I will try to provide some answers based on my 
experience running DTS at the DPDK Community Lab at UNH. I will also flag that 
this "legacy" version of DTS is deprecated and getting minimal maintenance. The 
majority of the current efforts for DTS are directed towards the rewrite which 
exists within the /dts dir of the DPDK repo: https://git.dpdk.org/dpdk/tree/dts

With that being said, of course the legacy repo is still useful and I encourage 
you to use it, so I will provide some comments inline below:

On Fri, Nov 22, 2024 at 9:43 AM Bharati Bhole - Geminus 
mailto:c_bhara...@xsightlabs.com>> wrote:
Hi,

I am Bharati Bhole. I am a new member of DTS mailing list.
I have recently started working on DTS for my company and facing some 
issues/failures while running the DTS.
Please help me with understanding the test cases and expected behaviours.

I am trying to understand the DTS behaviour for following TCs:

1. JumboFrames :

  1.
When the test set the max_pkt_len for testpmd and calculate the expected 
acceptable packet size, does it consider NICs supporting 2 VLANS? (In case of 
MTU update test, I have seen that 2 VLANs NIC are being considered while 
calculating acceptable packets size but in JumboFrames I dont see it).

No, 2 VLANs is not properly accounted for in the Jumboframes testsuite. And, 
this is actually highly topical, as this is an ongoing point of discussion in 
rewriting jumboframes and mtu_update for the new DTS framework (the testcases 
are getting combined into 1 testsuite).  I will paste the function from 
mtu_update of legacy DTS which you may be referring to:

--

def send_packet_of_size_to_port(self, port_id: int, pktsize: int):

# The packet total size include ethernet header, ip header, and payload.
# ethernet header length is 18 bytes, ip standard header length is 20 
bytes.
# pktlen = pktsize - ETHER_HEADER_LEN
if self.kdriver in ["igb", "igc", "ixgbe"]:
max_pktlen = pktsize + ETHER_HEADER_LEN + VLAN
padding = max_pktlen - IP_HEADER_LEN - ETHER_HEADER_LEN - VLAN
else:
max_pktlen = pktsize + ETHER_HEADER_LEN + VLAN * 2
padding = max_pktlen - IP_HEADER_LEN - ETHER_HEADER_LEN
out = self.send_scapy_packet(
port_id,
f'Ether(dst=dutmac, 
src="52:00:00:00:00:00")/IP()/Raw(load="\x50"*{padding})',

--

One difference between legacy DTS and the "new" DTS is that in legacy DTS a 
master list of devices/drivers was maintained, and there were an endless amount 
of conditions like this where a device list would be checked, and then some 
behavior modified based on that list. Because this strategy leads to bugs, it's 
unresponsive to changes in driver code, hard to maintain, and for other 
reasons, we are no longer follow this approach in new DTS. Now, if we want to 
toggle different behavior (like determine max_pkt_len for a given MTU for a 
given device) that needs to be accomplished by querying testpmd for device info 
(there are various testpmd runtime c

[PATCH v3 1/1] usertools/devbind: allow changing UID/GID for VFIO

Currently, when binding a device to VFIO, the UID/GID for the device will
always stay as system default (`root`). Yet, when running DPDK as non-root
user, one has to change the UID/GID of the device to match the user's
UID/GID to use the device.

This patch adds an option to `dpdk-devbind.py` to change the UID/GID of
the device when binding it to VFIO.

Signed-off-by: Anatoly Burakov 
---

Notes:
v2 -> v3:
- Replaced error printout back to hard exit
- Reworked UID/GID validation to be at command line parsing
- Simplified chown code

v1 -> v2:
- Replaced hard exit with an error printout

 usertools/dpdk-devbind.py | 41 ---
 1 file changed, 38 insertions(+), 3 deletions(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index f2a2a9a12f..ed1ef0cabc 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -3,11 +3,13 @@
 # Copyright(c) 2010-2014 Intel Corporation
 #
 
-import sys
-import os
-import subprocess
 import argparse
+import grp
+import os
 import platform
+import pwd
+import subprocess
+import sys
 
 from glob import glob
 from os.path import exists, basename
@@ -108,6 +110,8 @@
 status_flag = False
 force_flag = False
 noiommu_flag = False
+vfio_uid = -1
+vfio_gid = -1
 args = []
 
 
@@ -544,6 +548,19 @@ def bind_all(dev_list, driver, force=False):
 
 for d in dev_list:
 bind_one(d, driver, force)
+# if we're binding to vfio-pci, set the IOMMU user/group ownership if 
one was specified
+if driver == "vfio-pci" and (vfio_uid != -1 or vfio_gid != -1):
+# find IOMMU group for a particular PCI device
+iommu_grp_base_path = os.path.join("/sys/bus/pci/devices", d, 
"iommu_group")
+# extract the IOMMU group number
+iommu_grp = os.path.basename(os.readlink(iommu_grp_base_path))
+# find VFIO device correspondiong to this IOMMU group
+dev_path = os.path.join("/dev/vfio", iommu_grp)
+# set ownership
+try:
+os.chown(dev_path, vfio_uid, vfio_gid)
+except OSError as err:
+sys.exit(f"Error: failed to set IOMMU group ownership for {d}: 
{err}")
 
 # For kernels < 3.15 when binding devices to a generic driver
 # (i.e. one that doesn't have a PCI ID table) using new_id, some devices
@@ -697,6 +714,8 @@ def parse_args():
 global force_flag
 global noiommu_flag
 global args
+global vfio_uid
+global vfio_gid
 
 parser = argparse.ArgumentParser(
 description='Utility to bind and unbind devices from Linux kernel',
@@ -746,6 +765,20 @@ def parse_args():
 '--noiommu-mode',
 action='store_true',
 help="If IOMMU is not available, enable no IOMMU mode for VFIO 
drivers")
+parser.add_argument(
+"-U",
+"--uid",
+help="For VFIO, specify the UID to set IOMMU group ownership",
+type=lambda u: pwd.getpwnam(u).pw_uid,
+default=-1,
+)
+parser.add_argument(
+"-G",
+"--gid",
+help="For VFIO, specify the GID to set IOMMU group ownership",
+type=lambda g: grp.getgrnam(g).gr_gid,
+default=-1,
+)
 parser.add_argument(
 '--force',
 action='store_true',
@@ -778,6 +811,8 @@ def parse_args():
 b_flag = opt.bind
 elif opt.unbind:
 b_flag = "none"
+vfio_uid = opt.uid
+vfio_gid = opt.gid
 args = opt.devices
 
 if not b_flag and not status_flag:
-- 
2.43.5

rte_event_eth_tx_adapter_enqueue() short enqueue

2024-11-27 Thread Mattias Rönnblom


Hi.

Consider the following situation:

An application does

rte_event_eth_tx_adapter_enqueue()

and due to back-pressure or some other reason not all events/packets 
could be enqueued, and a count lower than the nb_events input parameter 
is returned.


The API says that "/../ the remaining events at the end of ev[] are not 
consumed and the caller has to take care of them /../".


May an event device rearrange the ev array so that any enqueue failures 
are put last in the ev array?


In other words: does the "at the end of ev[]" mean "at the end of ev[] 
as the call has completed", or is the event array supposed to be 
untouched, and thus the same events are at the end both before and after 
the call.


The ev array pointer is not const, so from that perspective it may be 
modified.


This situation may occur for example the bonding driver is used under 
the hood. The bonding driver does this kind of rearrangements on the 
ethdev level.


Thanks,
Mattias

[PATCH v4] net/hns3: fix Rx packet without CRC data

2024-11-27 Thread Jie Hai

From: Dengdui Huang 

When KEEP_CRC offload is enabled, the CRC data is still stripped
in following cases:
1. For HIP08 network engine, the packet type is TCP and the length
   is less than or equal to 60B.
2. For HIP09 network engine, the packet type is IP and the length
   is less than or equal to 60B.

So driver has to recaculate packet CRC for this rare scenarios.

In addition, to avoid impacting performance, KEEP_CRC is not
supported when NEON or SVE algorithm is used.

Fixes: 8973d7c4ca12 ("net/hns3: support keeping CRC")
Cc: sta...@dpdk.org

Signed-off-by: Dengdui Huang 
Acked-by: Huisong Li 
Acked-by: Jie Hai 
---
 drivers/net/hns3/hns3_ethdev.c|   5 ++
 drivers/net/hns3/hns3_ethdev.h|  23 +
 drivers/net/hns3/hns3_rxtx.c  | 121 +-
 drivers/net/hns3/hns3_rxtx.h  |   3 +
 drivers/net/hns3/hns3_rxtx_vec.c  |   3 +-
 drivers/net/hns3/hns3_rxtx_vec_neon.h |  19 
 drivers/net/hns3/hns3_rxtx_vec_sve.c  |   3 +-
 7 files changed, 132 insertions(+), 45 deletions(-)

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 72d1c30a7b2e..b3bd439d0dd5 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -2739,6 +2739,7 @@ hns3_get_capability(struct hns3_hw *hw)
hw->udp_cksum_mode = HNS3_SPECIAL_PORT_SW_CKSUM_MODE;
pf->support_multi_tc_pause = false;
hw->rx_dma_addr_align = HNS3_RX_DMA_ADDR_ALIGN_64;
+   hw->strip_crc_ptype = HNS3_STRIP_CRC_PTYPE_TCP;
return 0;
}
 
@@ -2760,6 +2761,10 @@ hns3_get_capability(struct hns3_hw *hw)
hw->udp_cksum_mode = HNS3_SPECIAL_PORT_HW_CKSUM_MODE;
pf->support_multi_tc_pause = true;
hw->rx_dma_addr_align = HNS3_RX_DMA_ADDR_ALIGN_128;
+   if (hw->revision == PCI_REVISION_ID_HIP09_A)
+   hw->strip_crc_ptype = HNS3_STRIP_CRC_PTYPE_IP;
+   else
+   hw->strip_crc_ptype = HNS3_STRIP_CRC_PTYPE_NONE;
 
return 0;
 }
diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h
index 7824503bb89f..01d473fd2e66 100644
--- a/drivers/net/hns3/hns3_ethdev.h
+++ b/drivers/net/hns3/hns3_ethdev.h
@@ -54,6 +54,10 @@
 #define HNS3_SPECIAL_PORT_SW_CKSUM_MODE 0
 #define HNS3_SPECIAL_PORT_HW_CKSUM_MODE 1
 
+#define HNS3_STRIP_CRC_PTYPE_NONE 0
+#define HNS3_STRIP_CRC_PTYPE_TCP  1
+#define HNS3_STRIP_CRC_PTYPE_IP   2
+
 #define HNS3_UC_MACADDR_NUM128
 #define HNS3_VF_UC_MACADDR_NUM 48
 #define HNS3_MC_MACADDR_NUM128
@@ -655,6 +659,25 @@ struct hns3_hw {
 */
uint8_t udp_cksum_mode;
 
+   /*
+* When KEEP_CRC offload is enabled, the CRC data of some type packets
+* whose length is less than or equal to HNS3_KEEP_CRC_OK_MIN_PKT_LEN
+* is still be stripped on some network engine. So here has to use this
+* field to distinguish the difference between different network 
engines.
+* value range:
+*  - HNS3_STRIP_CRC_PTYPE_TCP
+* This value for HIP08 network engine.
+* Indicates that only the IP-TCP packet type is stripped.
+*
+*  - HNS3_STRIP_CRC_PTYPE_IP
+* This value for HIP09 network engine.
+* Indicates that all IP packet types are stripped.
+*
+*  - HNS3_STRIP_CRC_PTYPE_NONE
+* Indicates that all packet types are not stripped.
+*/
+   uint8_t strip_crc_ptype;
+
struct hns3_port_base_vlan_config port_base_vlan_cfg;
 
pthread_mutex_t flows_lock; /* rte_flow ops lock */
diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c
index 03bbbc435fac..75fd4f55e73a 100644
--- a/drivers/net/hns3/hns3_rxtx.c
+++ b/drivers/net/hns3/hns3_rxtx.c
@@ -11,6 +11,7 @@
 #include 
 #include 
 #include 
+#include 
 #if defined(RTE_ARCH_ARM64)
 #include 
 #include 
@@ -1768,8 +1769,9 @@ hns3_rx_buf_len_calc(struct rte_mempool *mp, uint16_t 
*rx_buf_len)
 }
 
 static int
-hns3_rxq_conf_runtime_check(struct hns3_hw *hw, uint16_t buf_size,
-   uint16_t nb_desc)
+hns3_rxq_conf_runtime_check(struct hns3_hw *hw,
+   const struct rte_eth_rxconf *conf,
+   uint16_t buf_size, uint16_t nb_desc)
 {
struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
eth_rx_burst_t pkt_burst = dev->rx_pkt_burst;
@@ -1802,6 +1804,14 @@ hns3_rxq_conf_runtime_check(struct hns3_hw *hw, uint16_t 
buf_size,
return -EINVAL;
}
}
+
+   if ((conf->offloads & RTE_ETH_RX_OFFLOAD_KEEP_CRC) &&
+   pkt_burst != hns3_recv_pkts_simple &&
+   pkt_burst != hns3_recv_scattered_pkts) {
+   hns3_err(hw, "KEEP_CRC offload is not supported in the current 
rx function.");
+   return -EINVAL;
+   }
+
return 0;
 }
 
@@ -1838,7 +

Re: rte_event_eth_tx_adapter_enqueue() short enqueue

2024-11-27 Thread Mattias Rönnblom


On 2024-11-27 11:38, Bruce Richardson wrote:

On Wed, Nov 27, 2024 at 11:03:31AM +0100, Mattias Rönnblom wrote:

Hi.

Consider the following situation:

An application does

rte_event_eth_tx_adapter_enqueue()

and due to back-pressure or some other reason not all events/packets could
be enqueued, and a count lower than the nb_events input parameter is
returned.

The API says that "/../ the remaining events at the end of ev[] are not
consumed and the caller has to take care of them /../".

May an event device rearrange the ev array so that any enqueue failures are
put last in the ev array?

In other words: does the "at the end of ev[]" mean "at the end of ev[] as
the call has completed", or is the event array supposed to be untouched, and
thus the same events are at the end both before and after the call.

The ev array pointer is not const, so from that perspective it may be
modified.

This situation may occur for example the bonding driver is used under the
hood. The bonding driver does this kind of rearrangements on the ethdev
level.



Interesting question. I tend to think that we should not proclude this
reordering, as it should allow e.g  an eventdev which is short on space to
selectively enqueue only the high priority events.



Allowing reordering may be a little surprising to the user. At least it 
would be for me.


Other eventdev APIs enqueue do not allow this kind of reordering (with 
const-marked arrays).


That said, I lean toward agreeing with you, since it will solve the 
ethdev tx_burst() mapping issue mentioned.



Only caveat is that if we do allow the reordering we clarify the
documentation to explicitly state that it is allowed.

/Bruce

Re: rte_event_eth_tx_adapter_enqueue() short enqueue

On Wed, Nov 27, 2024 at 11:53:50AM +0100, Mattias Rönnblom wrote:
> On 2024-11-27 11:38, Bruce Richardson wrote:
> > On Wed, Nov 27, 2024 at 11:03:31AM +0100, Mattias Rönnblom wrote:
> > > Hi.
> > > 
> > > Consider the following situation:
> > > 
> > > An application does
> > > 
> > > rte_event_eth_tx_adapter_enqueue()
> > > 
> > > and due to back-pressure or some other reason not all events/packets could
> > > be enqueued, and a count lower than the nb_events input parameter is
> > > returned.
> > > 
> > > The API says that "/../ the remaining events at the end of ev[] are not
> > > consumed and the caller has to take care of them /../".
> > > 
> > > May an event device rearrange the ev array so that any enqueue failures 
> > > are
> > > put last in the ev array?
> > > 
> > > In other words: does the "at the end of ev[]" mean "at the end of ev[] as
> > > the call has completed", or is the event array supposed to be untouched, 
> > > and
> > > thus the same events are at the end both before and after the call.
> > > 
> > > The ev array pointer is not const, so from that perspective it may be
> > > modified.
> > > 
> > > This situation may occur for example the bonding driver is used under the
> > > hood. The bonding driver does this kind of rearrangements on the ethdev
> > > level.
> > > 
> > 
> > Interesting question. I tend to think that we should not proclude this
> > reordering, as it should allow e.g  an eventdev which is short on space to
> > selectively enqueue only the high priority events.
> > 
> 
> Allowing reordering may be a little surprising to the user. At least it
> would be for me.
> 
> Other eventdev APIs enqueue do not allow this kind of reordering (with
> const-marked arrays).
> 

That is a good point. I forgot that the events are directly passed to the
enqueue functions rather than being passed as pointers, which could then be
reordered without modifying the underlying events.

> That said, I lean toward agreeing with you, since it will solve the ethdev
> tx_burst() mapping issue mentioned.
> 

If enabling this solves a real problem, then let's allow it, despite the
inconsistency in the APIs. Again, though, we need to to call this out in
the docs very prominently to avoid surprises.

Alternatively, do we want to add a separate API that explicitly allows
reordering, and update the existing API to have a const value parameter?
For drivers that don't implement the reordering they can just not provide
the reordering function and the non-reorder version can be used
transparently instead.

/Bruce

Re: [PATCH v2] docs: remove html dir from nested docs

2024-11-27 Thread Thomas Monjalon

27/11/2024 12:41, Paul Szczepanek:
> +# don't append html dir if dst is already nested in one but first
> +# remove the part of the path outside the tree in case html dir exists 
> there
> +rel_path = os.path.relpath(dst, os.path.dirname(__file__))
> +html_dst = dst if 'html' in rel_path else join(dst, 'html')

What happens if the build directory is a completely different path
of the source tree?
Is there a risk of having the build directory inside a tree having /html/?

[PATCH v2] net/sxe: submit the build directory and rough doc documentation

2024-11-27 Thread Jie Liu

Modify sxe pf document.

Signed-off-by: Jie Liu 
---
 doc/guides/nics/features/sxe.ini | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/features/sxe.ini b/doc/guides/nics/features/sxe.ini
index 209825a1fc..173ab48889 100644
--- a/doc/guides/nics/features/sxe.ini
+++ b/doc/guides/nics/features/sxe.ini
@@ -4,5 +4,7 @@
 ; Refer to default.ini for the full list of available PMD features.
 ;
 [Features]
-Linux UIO= Y
-Linux VFIO   = Y
+Linux= Y
+ARMv8= Y
+x86-32   = Y
+x86-64   = Y
-- 
2.27.0

Re: [RFC 5/6] build: install indirect headers to a dedicated directory

On Wed, Nov 27, 2024 at 12:26:15PM +0100, David Marchand wrote:
> The headers check currently skips "indirect" headers as instrusted via
> the indirect_headers meson variable.
> 
> This headers check has some limitation that will be addressed in a next
> change by inspected all exported headers.
> However, exported headers lack the information about "indirect" quality.
> 
> Separate "indirect" headers by exporting them in a internal/ sub directory.
> This also makes it more obvious which headers are not to be directly used
> by an application.
> 
> Signed-off-by: David Marchand 
> ---
>  buildtools/pkg-config/meson.build | 8 +++-
>  lib/eal/x86/include/meson.build   | 3 ++-
>  lib/meson.build   | 2 +-
>  3 files changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/buildtools/pkg-config/meson.build 
> b/buildtools/pkg-config/meson.build
> index b36add17e3..809706fe3e 100644
> --- a/buildtools/pkg-config/meson.build
> +++ b/buildtools/pkg-config/meson.build
> @@ -27,12 +27,18 @@ endif
>  # are skipped in the case of static linkage thanks to the flag --as-needed.
>  
>  
> +subdirs = [ '.', 'internal' ]
> +if get_option('include_subdir_arch') != ''
> +subdirs = [ subdirs, get_option('include_subdir_arch') ]
> +subdirs = [ subdirs, join_paths(get_option('include_subdir_arch'), 
> 'internal')]

minor nit, I tend to prefer using "+=" rather than relying on flattening to
extend the arrays.


> +endif
> +
>  pkg.generate(name: 'dpdk-libs',
>  filebase: 'libdpdk-libs',
>  description: '''Internal-only DPDK pkgconfig file. Not for direct 
> use.
>  Use libdpdk.pc instead of this file to query DPDK compile/link arguments''',
>  version: meson.project_version(),
> -subdirs: [get_option('include_subdir_arch'), '.'],
> +subdirs: subdirs,
>  extra_cflags: pkg_extra_cflags,
>  libraries: ['-Wl,--as-needed'] + dpdk_libraries,
>  libraries_private: dpdk_extra_ldflags)
> diff --git a/lib/eal/x86/include/meson.build b/lib/eal/x86/include/meson.build
> index 52d2f8e969..a100330208 100644
> --- a/lib/eal/x86/include/meson.build
> +++ b/lib/eal/x86/include/meson.build
> @@ -22,5 +22,6 @@ arch_indirect_headers = files(
>  'rte_byteorder_32.h',
>  'rte_byteorder_64.h',
>  )
> -install_headers(arch_headers + arch_indirect_headers, subdir: 
> get_option('include_subdir_arch'))
> +install_headers(arch_headers, subdir: get_option('include_subdir_arch'))
> +install_headers(arch_indirect_headers, subdir: 
> join_paths(get_option('include_subdir_arch'), 'internal'))
>  dpdk_chkinc_headers += arch_headers
> diff --git a/lib/meson.build b/lib/meson.build
> index ce92cb5537..78ada7782e 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -202,7 +202,7 @@ foreach l:libraries
>  dpdk_libs_enabled += name
>  dpdk_conf.set('RTE_LIB_' + name.to_upper(), 1)
>  install_headers(headers)
> -install_headers(indirect_headers)
> +install_headers(indirect_headers, subdir: 'internal')
>  if get_option('enable_driver_sdk')
>  install_headers(driver_sdk_headers)
>  endif
> -- 
> 2.47.0
>

[RFC 4/6] drivers: fix exported headers

Those headers could not be included individually as they were not
including their dependencies, or were subject to some build warnings.

Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
Fixes: 5b2a1a02dcaf ("crypto/cnxk: fix experimental version for PMD API")
Fixes: e5abbfa5 ("crypto/cnxk: add PMD API for getting CPTR")
Fixes: 3ca607402c4d ("crypto/cnxk: add PMD API to flush CTX")
Fixes: 8c3495f5d2dd ("net/dpaa: support loopback API")
Fixes: 12b435bf8f2f ("net/iavf: support flex desc metadata extraction")
Fixes: 23f627e0ed28 ("net/mlx5: add flow sync API")
Fixes: f5177bdc8b76 ("net/mlx5: add GENEVE TLV options parser API")
Fixes: 7cf197684589 ("raw/cnxk_bphy: support interrupt init and cleanup")
Fixes: 633dae698070 ("raw/cnxk_gpio: add standard GPIO operations")
Fixes: 53c71586c789 ("raw/dpaa2_cmdif: support enqueue/dequeue operations")
Fixes: c39d1e082a4b ("raw/ntb: setup queues")

Signed-off-by: David Marchand 
---
 drivers/bus/vmbus/rte_vmbus_reg.h |  6 ++
 drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h |  4 
 drivers/net/dpaa/rte_pmd_dpaa.h   |  2 ++
 drivers/net/iavf/rte_pmd_iavf.h   |  6 ++
 drivers/net/mlx5/rte_pmd_mlx5.h   |  3 +++
 drivers/raw/cnxk_bphy/rte_pmd_bphy.h  | 16 
 drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h |  3 +++
 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h |  2 ++
 drivers/raw/ntb/rte_pmd_ntb.h |  2 ++
 9 files changed, 44 insertions(+)

diff --git a/drivers/bus/vmbus/rte_vmbus_reg.h 
b/drivers/bus/vmbus/rte_vmbus_reg.h
index e3299aa871..95c8eb29b4 100644
--- a/drivers/bus/vmbus/rte_vmbus_reg.h
+++ b/drivers/bus/vmbus/rte_vmbus_reg.h
@@ -6,6 +6,12 @@
 #ifndef _VMBUS_REG_H_
 #define _VMBUS_REG_H_
 
+#include 
+
+#include 
+#include 
+#include 
+
 /*
  * Hyper-V SynIC message format.
  */
diff --git a/drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h 
b/drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h
index 02278605a2..2bb0ff9e95 100644
--- a/drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h
+++ b/drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h
@@ -11,8 +11,12 @@
 #ifndef _PMD_CNXK_CRYPTO_H_
 #define _PMD_CNXK_CRYPTO_H_
 
+#include 
 #include 
 
+#include 
+#include 
+
 /* Forward declarations */
 
 /**
diff --git a/drivers/net/dpaa/rte_pmd_dpaa.h b/drivers/net/dpaa/rte_pmd_dpaa.h
index ec45633ba2..0a57e2097a 100644
--- a/drivers/net/dpaa/rte_pmd_dpaa.h
+++ b/drivers/net/dpaa/rte_pmd_dpaa.h
@@ -5,6 +5,8 @@
 #ifndef _PMD_DPAA_H_
 #define _PMD_DPAA_H_
 
+#include 
+
 /**
  * @file rte_pmd_dpaa.h
  *
diff --git a/drivers/net/iavf/rte_pmd_iavf.h b/drivers/net/iavf/rte_pmd_iavf.h
index 56d453fc4c..04b86a5dd7 100644
--- a/drivers/net/iavf/rte_pmd_iavf.h
+++ b/drivers/net/iavf/rte_pmd_iavf.h
@@ -15,6 +15,7 @@
  */
 
 #include 
+
 #include 
 #include 
 #include 
@@ -184,6 +185,7 @@ __rte_experimental
 static inline void
 rte_pmd_ifd_dump_proto_xtr_metadata(struct rte_mbuf *m)
 {
+#ifdef ALLOW_EXPERIMENTAL_API
union rte_pmd_ifd_proto_xtr_metadata data;
 
if (!rte_pmd_ifd_dynf_proto_xtr_metadata_avail())
@@ -243,6 +245,10 @@ rte_pmd_ifd_dump_proto_xtr_metadata(struct rte_mbuf *m)
else if (m->ol_flags & RTE_IAVF_PKT_RX_DYNF_PROTO_XTR_IP_OFFSET)
printf(" - Flexible descriptor's Extraction: ip_offset=%u",
   data.ip_ofs);
+#else
+   RTE_SET_USED(m);
+   RTE_VERIFY(false);
+#endif
 }
 
 #ifdef __cplusplus
diff --git a/drivers/net/mlx5/rte_pmd_mlx5.h b/drivers/net/mlx5/rte_pmd_mlx5.h
index fdd2f65888..f2c6aebe0b 100644
--- a/drivers/net/mlx5/rte_pmd_mlx5.h
+++ b/drivers/net/mlx5/rte_pmd_mlx5.h
@@ -5,6 +5,9 @@
 #ifndef RTE_PMD_PRIVATE_MLX5_H_
 #define RTE_PMD_PRIVATE_MLX5_H_
 
+#include 
+
+#include 
 #include 
 
 /**
diff --git a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h 
b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h
index f668e6ea82..c200c935ff 100644
--- a/drivers/raw/cnxk_bphy/rte_pmd_bphy.h
+++ b/drivers/raw/cnxk_bphy/rte_pmd_bphy.h
@@ -391,6 +391,7 @@ rte_pmd_bphy_intr_init(uint16_t dev_id)
 {
struct cnxk_bphy_irq_msg msg = {
.type = CNXK_BPHY_IRQ_MSG_TYPE_INIT,
+   .data = NULL,
};
 
return __rte_pmd_bphy_enq_deq(dev_id, CNXK_BPHY_DEF_QUEUE, &msg,
@@ -411,6 +412,7 @@ rte_pmd_bphy_intr_fini(uint16_t dev_id)
 {
struct cnxk_bphy_irq_msg msg = {
.type = CNXK_BPHY_IRQ_MSG_TYPE_FINI,
+   .data = NULL,
};
 
return __rte_pmd_bphy_enq_deq(dev_id, CNXK_BPHY_DEF_QUEUE, &msg,
@@ -470,6 +472,9 @@ rte_pmd_bphy_intr_unregister(uint16_t dev_id, int irq_num)
 {
struct cnxk_bphy_irq_info info = {
.irq_num = irq_num,
+   .handler = NULL,
+   .data = NULL,
+   .cpu = -1,
};
struct cnxk_bphy_irq_msg msg = {
.type = CNXK_BPHY_IRQ_MSG_TYPE_UNREGISTER,
@@ -496,6 +501,7 @@ rte_pmd_bphy_intr_mem_get(uint16_t dev_id, struct 
cnxk_bphy_mem *mem)
 {
struct cnxk_bphy_irq_m

[RFC 0/6] Add a stricter headers check

As explained in patch 6, the current headers check can not catch
issues when a public header includes an internal header.
Fixing this from meson does not seem an easy task.

The approach of this RFC is to reimplement the check in a Makefile invoked
out of DPDK (like what is done for external compilation of examples).
This has the advantage of being simple, and avoiding any (non intentional)
implicit include path coming from the meson framework.

As there was no easy way to distinguish "indirect" headers in an
installed DPDK, I chose to move those headers in a new sub directory
(patch 5).

Patch 1-4 fixes have not been marked as backport material as those bugs
seems minor/easy to fix externally (by either including missing headers,
or enabling enable_driver_sdk option).

For now, I left the check_includes= option untouched, as there may be
users of this check and this check still catches issues without
requiring to install DPDK.


-- 
David Marchand

David Marchand (6):
  baseband/acc: fix exported header
  drivers: drop export of driver headers
  eventdev: do not include driver header in DMA adapter
  drivers: fix exported headers
  build: install indirect headers to a dedicated directory
  buildtools: externally check exported headers

 .ci/linux-build.sh|  7 +-
 buildtools/chkincs/Makefile   | 77 +++
 buildtools/pkg-config/meson.build |  8 +-
 devtools/test-meson-builds.sh |  6 +-
 drivers/baseband/acc/meson.build  |  2 +-
 drivers/bus/vmbus/rte_vmbus_reg.h |  6 ++
 drivers/crypto/cnxk/rte_pmd_cnxk_crypto.h |  4 +
 drivers/net/dpaa/rte_pmd_dpaa.h   |  2 +
 drivers/net/iavf/rte_pmd_iavf.h   |  6 ++
 drivers/net/mlx5/rte_pmd_mlx5.h   |  3 +
 drivers/raw/cnxk_bphy/rte_pmd_bphy.h  | 16 
 drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h |  3 +
 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h |  2 +
 drivers/raw/ntb/rte_pmd_ntb.h |  2 +
 lib/bbdev/meson.build |  5 +-
 lib/eal/x86/include/meson.build   |  3 +-
 lib/ethdev/meson.build|  6 +-
 lib/eventdev/rte_event_dma_adapter.h  |  2 +-
 lib/meson.build   |  2 +-
 lib/mldev/meson.build |  5 +-
 lib/rawdev/meson.build|  3 +-
 lib/regexdev/meson.build  |  3 +-
 lib/security/meson.build  |  3 +-
 23 files changed, 153 insertions(+), 23 deletions(-)
 create mode 100644 buildtools/chkincs/Makefile

-- 
2.47.0

[RFC 3/6] eventdev: do not include driver header in DMA adapter

The dma adapter header does not require including rte_dmadev_pmd.h which
is a driver header.

Fixes: 66a30a29387a ("eventdev/dma: introduce DMA adapter")

Signed-off-by: David Marchand 
---
 lib/eventdev/rte_event_dma_adapter.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/eventdev/rte_event_dma_adapter.h 
b/lib/eventdev/rte_event_dma_adapter.h
index 5c480b82ff..34142f26db 100644
--- a/lib/eventdev/rte_event_dma_adapter.h
+++ b/lib/eventdev/rte_event_dma_adapter.h
@@ -144,7 +144,7 @@
 #include 
 
 #include 
-#include 
+#include 
 #include 
 
 #ifdef __cplusplus
-- 
2.47.0

[RFC 5/6] build: install indirect headers to a dedicated directory

The headers check currently skips "indirect" headers as instrusted via
the indirect_headers meson variable.

This headers check has some limitation that will be addressed in a next
change by inspected all exported headers.
However, exported headers lack the information about "indirect" quality.

Separate "indirect" headers by exporting them in a internal/ sub directory.
This also makes it more obvious which headers are not to be directly used
by an application.

Signed-off-by: David Marchand 
---
 buildtools/pkg-config/meson.build | 8 +++-
 lib/eal/x86/include/meson.build   | 3 ++-
 lib/meson.build   | 2 +-
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/buildtools/pkg-config/meson.build 
b/buildtools/pkg-config/meson.build
index b36add17e3..809706fe3e 100644
--- a/buildtools/pkg-config/meson.build
+++ b/buildtools/pkg-config/meson.build
@@ -27,12 +27,18 @@ endif
 # are skipped in the case of static linkage thanks to the flag --as-needed.
 
 
+subdirs = [ '.', 'internal' ]
+if get_option('include_subdir_arch') != ''
+subdirs = [ subdirs, get_option('include_subdir_arch') ]
+subdirs = [ subdirs, join_paths(get_option('include_subdir_arch'), 
'internal')]
+endif
+
 pkg.generate(name: 'dpdk-libs',
 filebase: 'libdpdk-libs',
 description: '''Internal-only DPDK pkgconfig file. Not for direct use.
 Use libdpdk.pc instead of this file to query DPDK compile/link arguments''',
 version: meson.project_version(),
-subdirs: [get_option('include_subdir_arch'), '.'],
+subdirs: subdirs,
 extra_cflags: pkg_extra_cflags,
 libraries: ['-Wl,--as-needed'] + dpdk_libraries,
 libraries_private: dpdk_extra_ldflags)
diff --git a/lib/eal/x86/include/meson.build b/lib/eal/x86/include/meson.build
index 52d2f8e969..a100330208 100644
--- a/lib/eal/x86/include/meson.build
+++ b/lib/eal/x86/include/meson.build
@@ -22,5 +22,6 @@ arch_indirect_headers = files(
 'rte_byteorder_32.h',
 'rte_byteorder_64.h',
 )
-install_headers(arch_headers + arch_indirect_headers, subdir: 
get_option('include_subdir_arch'))
+install_headers(arch_headers, subdir: get_option('include_subdir_arch'))
+install_headers(arch_indirect_headers, subdir: 
join_paths(get_option('include_subdir_arch'), 'internal'))
 dpdk_chkinc_headers += arch_headers
diff --git a/lib/meson.build b/lib/meson.build
index ce92cb5537..78ada7782e 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -202,7 +202,7 @@ foreach l:libraries
 dpdk_libs_enabled += name
 dpdk_conf.set('RTE_LIB_' + name.to_upper(), 1)
 install_headers(headers)
-install_headers(indirect_headers)
+install_headers(indirect_headers, subdir: 'internal')
 if get_option('enable_driver_sdk')
 install_headers(driver_sdk_headers)
 endif
-- 
2.47.0

[RFC 6/6] buildtools: externally check exported headers

At the moment, the headers check (triggered via the check_includes meson
option) is run "internally", iow with compilation flags and include path
coming from the meson components.

One issue is that both internal and public headers are usually stored
in a single directory in the DPDK components.
If a lib/foo library exports a header rte_foo.h (iow rte_foo.h is part
of the headers list in lib/foo/meson.build) and this rte_foo.h includes
an internal header foo_internal.h, then the headers check won't detect
such an issue as rte_foo.h is compiled with -Ilib/foo.

Reimplement the headers check by inspecting (compiling) all DPDK headers
installed in a staging directory.
To identify the directory where DPDK headers are, this check relies on
pkg-config and skips EAL generic/ and internal/ headers.

The existing headers check (though less accurate) is kept as is,
as it provides a first level of check and may have existing users.

Signed-off-by: David Marchand 
---
 .ci/linux-build.sh|  7 ++--
 buildtools/chkincs/Makefile   | 77 +++
 devtools/test-meson-builds.sh |  6 ++-
 3 files changed, 85 insertions(+), 5 deletions(-)
 create mode 100644 buildtools/chkincs/Makefile

diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index fdb5787621..3146d9ccd8 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -95,8 +95,6 @@ OPTS="$OPTS -Ddefault_library=$DEF_LIB"
 OPTS="$OPTS -Dbuildtype=$buildtype"
 if [ "$STDATOMIC" = "true" ]; then
OPTS="$OPTS -Denable_stdatomic=true"
-else
-   OPTS="$OPTS -Dcheck_includes=true"
 fi
 if [ "$MINI" = "true" ]; then
 OPTS="$OPTS -Denable_drivers=net/null"
@@ -176,13 +174,16 @@ if [ "$RUN_TESTS" = "true" ]; then
 [ "$failed" != "true" ]
 fi
 
-# Test examples compilation with an installed dpdk
+# Test headers and examples compilation with an installed dpdk
 if [ "$BUILD_EXAMPLES" = "true" ]; then
 [ -d install ] || DESTDIR=$(pwd)/install meson install -C build
 export LD_LIBRARY_PATH=$(dirname $(find $(pwd)/install -name 
librte_eal.so)):$LD_LIBRARY_PATH
 export PATH=$(dirname $(find $(pwd)/install -name dpdk-devbind.py)):$PATH
 export PKG_CONFIG_PATH=$(dirname $(find $(pwd)/install -name 
libdpdk.pc)):$PKG_CONFIG_PATH
 export PKGCONF="pkg-config --define-prefix"
+
+make -C buildtools/chkincs O=build/buildtools/chkincs
+
 find build/examples -maxdepth 1 -type f -name "dpdk-*" |
 while read target; do
 target=${target%%:*}
diff --git a/buildtools/chkincs/Makefile b/buildtools/chkincs/Makefile
new file mode 100644
index 00..838819c617
--- /dev/null
+++ b/buildtools/chkincs/Makefile
@@ -0,0 +1,77 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (c) 2024 Red Hat, Inc.
+
+ifeq ($(V),)
+Q ?= @
+else
+Q =
+endif
+
+O ?= build
+
+PKGCONF ?= pkg-config
+
+ifneq ($(shell $(PKGCONF) --exists libdpdk && echo 0),0)
+$(error "no installation of DPDK found")
+endif
+
+ifeq ($(I),)
+
+.PHONY: headers_list
+.ONESHELL:
+headers_list:
+   $(Q)for dir in $$($(PKGCONF) --cflags-only-I libdpdk); do
+   dir=$${dir##-I}
+   [ -e $$dir/rte_build_config.h ] || continue
+   $(MAKE) I="$$dir" O="$(O)"
+   break
+   done
+else
+
+HEADERS := $(shell find $(I) -name "*.h" | grep -vE $(I)'/(generic|internal)/')
+SRCS := $(patsubst $(I)/%.h, $(O)/%.c, $(HEADERS))
+.PRECIOUS: $(SRCS)
+
+PC_FILE := $(shell $(PKGCONF) --path libdpdk 2>/dev/null)
+CFLAGS = $(shell $(PKGCONF) --cflags libdpdk) -Wall -Wextra -Werror
+LDFLAGS = $(shell $(PKGCONF) --libs libdpdk)
+
+OBJS := $(patsubst $(I)/%.h, $(O)/%.o, $(HEADERS))
+OBJS_EXP := $(patsubst $(I)/%.h, $(O)/%+exp.o, $(HEADERS))
+OBJS_ALL := $(patsubst $(I)/%.h, $(O)/%+all.o, $(HEADERS))
+
+all: $(OBJS) $(OBJS_EXP) $(OBJS_ALL)
+
+$(O):
+   $(Q)mkdir -p $@
+
+$(O)/%.c: $(I)/%.h $(O) gen_c_file_for_header.py Makefile
+   $(Q)python3 gen_c_file_for_header.py $< $@
+
+$(O)/%.o: $(O)/%.c Makefile $(PC_FILE)
+   $(Q)$(CC) $(CFLAGS) -o $@ -c $<
+
+$(O)/%+exp.o: $(O)/%.c Makefile $(PC_FILE)
+   $(Q)$(CC) $(CFLAGS) -DALLOW_EXPERIMENTAL_API -o $@ -c $<
+
+$(O)/%+all.o: $(O)/%.c Makefile $(PC_FILE)
+   $(Q)$(CC) $(CFLAGS) -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -o $@ 
-c $<
+
+CXXFLAGS = $(shell $(PKGCONF) --cflags libdpdk) -Wall -Wextra -Werror
+
+OBJS_CPP := $(patsubst $(I)/%.h, $(O)/%.cpp.o, $(HEADERS))
+OBJS_CPP_EXP := $(patsubst $(I)/%.h, $(O)/%.cpp+exp.o, $(HEADERS))
+OBJS_CPP_ALL := $(patsubst $(I)/%.h, $(O)/%.cpp+all.o, $(HEADERS))
+
+all: $(OBJS_CPP) $(OBJS_CPP_EXP) $(OBJS_CPP_ALL)
+
+$(O)/%.cpp.o: $(O)/%.c Makefile $(PC_FILE)
+   $(Q)$(CXX) $(CXXFLAGS) -o $@ -c $<
+
+$(O)/%.cpp+exp.o: $(O)/%.c Makefile $(PC_FILE)
+   $(Q)$(CXX) $(CXXFLAGS) -DALLOW_EXPERIMENTAL_API -o $@ -c $<
+
+$(O)/%.cpp+all.o: $(O)/%.c Makefile $(PC_FILE)
+   $(Q)$(CXX) $(CXXFLAGS) -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -o 
$@ -c $<
+
+endif
diff --git a/devtools/test-meson-builds.sh b/devto

[RFC 1/6] baseband/acc: fix exported header

rte_acc_cfg.h relies on rte_acc_common_cfg.h.

Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code")

Signed-off-by: David Marchand 
---
 drivers/baseband/acc/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/baseband/acc/meson.build b/drivers/baseband/acc/meson.build
index 64fcf1537a..d9fb947eaa 100644
--- a/drivers/baseband/acc/meson.build
+++ b/drivers/baseband/acc/meson.build
@@ -26,4 +26,4 @@ deps += ['bus_pci']
 
 sources = files('acc_common.c', 'rte_acc100_pmd.c', 'rte_vrb_pmd.c')
 
-headers = files('rte_acc_cfg.h')
+headers = files('rte_acc_cfg.h', 'rte_acc_common_cfg.h')
-- 
2.47.0

[RFC 2/6] drivers: drop export of driver headers