[RFC PATCH v2 0/1] Introduce Event ML Adapter

[Srikanth Yalavarthi]

Machine learning event adapter library
==

DPDK Eventdev library provides event driven programming model with features to 
schedule
events. ML Device library provides an interface to ML poll mode drivers that 
support
Machine Learning inference operations. Event ML Adapter is intended to bridge 
between
the event device and the ML device.

Packet flow from ML device to the event device can be accomplished using 
software and hardware
based transfer mechanisms. The adapter queries an eventdev PMD to determine 
which mechanism to
be used. The adapter uses an EAL service core function for software based 
packet transfer and
uses the eventdev PMD functions to configure hardware based packet transfer 
between ML device
and the event device.

The application can choose to submit a ML operation directly to an ML device or 
send it to the ML
adapter via eventdev based on RTE_EVENT_ML_ADAPTER_CAP_INTERNAL_PORT_OP_FWD 
capability. The first
mode is known as the event new (RTE_EVENT_ML_ADAPTER_OP_NEW) mode and the 
second as the event
forward (RTE_EVENT_ML_ADAPTER_OP_FORWARD) mode. The choice of mode can be 
specified while
creating the adapter. In the former mode, it is an application responsibility 
to enable ingress
packet ordering. In the latter mode, it is the adapter responsibility to enable 
the ingress
packet ordering.


Working model of RTE_EVENT_ML_ADAPTER_OP_NEW mode:

   +--+ +--+
   |  | |   ML stage   |
   | Application  |---[2]-->| + enqueue to |
   |  | | mldev|
   +--+ +--+
   ^   ^   |
   |   |  [3]
  [6] [1]  |
   |   |   |
   +--+|
   |  ||
   | Event device ||
   |  ||
   +--+|
  ^|
  ||
 [5]   |
  |v
   +--+ +--+
   |  | |  |
   |  ML adapter  |<--[4]---|mldev |
   |  | |  |
   +--+ +--+


[1] Application dequeues events from the previous stage.
[2] Application prepares the ML operations.
[3] ML operations are submitted to mldev by application.
[4] ML adapter dequeues ML completions from mldev.
[5] ML adapter enqueues events to the eventdev.
[6] Application dequeues from eventdev for further processing.

In the RTE_EVENT_ML_ADAPTER_OP_NEW mode, application submits ML operations 
directly to ML device.
The ML adapter then dequeues ML completions from ML device and enqueue events 
to the event
device. This mode does not ensure ingress ordering, if the application directly 
enqueues to mldev
without going through ML / atomic stage i.e. removing item [1] and [2].

Events dequeued from the adapter will be treated as new events. In this mode, 
application needs
to specify event information (response information) which is needed to enqueue 
an event after the
ML operation is completed.


Working model of RTE_EVENT_ML_ADAPTER_OP_FORWARD mode:

   +--+ +--+
   --[1]-->|  |---[2]-->|  Application |
   | Event device | |  in  |
   <--[8]--|  |<--[3]---| Ordered stage|
   +--+ +--+
   ^  |
   | [4]
  [7] |
   |  v
  ++   +--+
  ||--[5]->|  |
  |   ML adapter   |   | mldev|
  ||<-[6]--|  |
  ++   +--+


[1] Events from the previous stage.
[2] Application in ordered stage dequeues events from eventdev.
[3] Application enqueues ML operations as events to eventdev.
[4] ML adapter dequeues event from eventdev.
[5] ML adapter submits ML operations to mldev (Atomic stage).
[6] ML adapter dequeues ML completions from mldev
[7] ML adapter enqueues events to the eventdev
[8] Events to the next stage

In the event forward (RTE_EVENT_ML_ADAPTER_OP_FORWARD) mode, if the HW supports 
the capability
RTE_EVENT_ML_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, application can directly submit 
the ML operations
to the mldev. 

[RFC PATCH v2 1/1] eventdev: introduce ML event adapter library

[Srikanth Yalavarthi]

Introduce event ML adapter APIs. This patch provides information
on adapter modes and usage. Application can use this event adapter
interface to transfer packets between ML device and event device.

Signed-off-by: Srikanth Yalavarthi 
---
 MAINTAINERS   |6 +
 config/rte_config.h   |1 +
 doc/api/doxy-api-index.md |1 +
 doc/guides/prog_guide/event_ml_adapter.rst|  268 
 doc/guides/prog_guide/eventdev.rst|8 +-
 .../img/event_ml_adapter_op_forward.svg   | 1086 +
 .../img/event_ml_adapter_op_new.svg   | 1079 
 doc/guides/prog_guide/index.rst   |1 +
 lib/eventdev/meson.build  |4 +-
 lib/eventdev/rte_event_ml_adapter.c   |6 +
 lib/eventdev/rte_event_ml_adapter.h   |  594 +
 lib/eventdev/rte_eventdev.h   |   45 +
 lib/meson.build   |2 +-
 lib/mldev/rte_mldev.h |6 +
 14 files changed, 3102 insertions(+), 5 deletions(-)
 create mode 100644 doc/guides/prog_guide/event_ml_adapter.rst
 create mode 100644 doc/guides/prog_guide/img/event_ml_adapter_op_forward.svg
 create mode 100644 doc/guides/prog_guide/img/event_ml_adapter_op_new.svg
 create mode 100644 lib/eventdev/rte_event_ml_adapter.c
 create mode 100644 lib/eventdev/rte_event_ml_adapter.h

diff --git a/MAINTAINERS b/MAINTAINERS
index 18bc05fccd..3f9d4d2c43 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -544,6 +544,12 @@ F: drivers/raw/skeleton/
 F: app/test/test_rawdev.c
 F: doc/guides/prog_guide/rawdev.rst
 
+Eventdev ML Adapter API
+M: Srikanth Yalavarthi 
+T: git://dpdk.org/next/dpdk-next-eventdev
+F: lib/eventdev/*ml_adapter*
+F: doc/guides/prog_guide/event_ml_adapter.rst
+
 
 Memory Pool Drivers
 ---
diff --git a/config/rte_config.h b/config/rte_config.h
index 400e44e3cf..ec244c9da9 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -77,6 +77,7 @@
 #define RTE_EVENT_ETH_INTR_RING_SIZE 1024
 #define RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE 32
 #define RTE_EVENT_ETH_TX_ADAPTER_MAX_INSTANCE 32
+#define RTE_EVENT_ML_ADAPTER_MAX_INSTANCE 32
 
 /* rawdev defines */
 #define RTE_RAWDEV_MAX_DEVS 64
diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
index 3bc8778981..02495319ea 100644
--- a/doc/api/doxy-api-index.md
+++ b/doc/api/doxy-api-index.md
@@ -29,6 +29,7 @@ The public API headers are grouped by topics:
   [event_eth_tx_adapter](@ref rte_event_eth_tx_adapter.h),
   [event_timer_adapter](@ref rte_event_timer_adapter.h),
   [event_crypto_adapter](@ref rte_event_crypto_adapter.h),
+  [event_ml_adapter](@ref rte_event_ml_adapter.h),
   [rawdev](@ref rte_rawdev.h),
   [metrics](@ref rte_metrics.h),
   [bitrate](@ref rte_bitrate.h),
diff --git a/doc/guides/prog_guide/event_ml_adapter.rst 
b/doc/guides/prog_guide/event_ml_adapter.rst
new file mode 100644
index 00..d0b8f9c1b6
--- /dev/null
+++ b/doc/guides/prog_guide/event_ml_adapter.rst
@@ -0,0 +1,268 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright (c) 2023 Marvell.
+
+Event ML Adapter Library
+
+
+DPDK :doc:`Eventdev library ` provides event driven programming 
model with features
+to schedule events. :doc:`ML Device library ` provides an interface to 
ML poll mode
+drivers that support Machine Learning inference operations. Event ML Adapter 
is intended to
+bridge between the event device and the ML device.
+
+Packet flow from ML device to the event device can be accomplished using 
software and hardware
+based transfer mechanisms. The adapter queries an eventdev PMD to determine 
which mechanism to
+be used. The adapter uses an EAL service core function for software based 
packet transfer and
+uses the eventdev PMD functions to configure hardware based packet transfer 
between ML device
+and the event device. ML adapter uses a new event type called 
``RTE_EVENT_TYPE_MLDEV`` to
+indicate the source of event.
+
+Application can choose to submit an ML operation directly to an ML device or 
send it to an ML
+adapter via eventdev based on RTE_EVENT_ML_ADAPTER_CAP_INTERNAL_PORT_OP_FWD 
capability. The
+first mode is known as the event new (RTE_EVENT_ML_ADAPTER_OP_NEW) mode and 
the second as the
+event forward (RTE_EVENT_ML_ADAPTER_OP_FORWARD) mode. Choice of mode can be 
specified while
+creating the adapter. In the former mode, it is the application's 
responsibility to enable
+ingress packet ordering. In the latter mode, it is the adapter's 
responsibility to enable
+ingress packet ordering.
+
+
+Adapter Modes
+-
+
+RTE_EVENT_ML_ADAPTER_OP_NEW mode
+
+
+In the RTE_EVENT_ML_ADAPTER_OP_NEW mode, application submits ML operations 
directly to an ML
+device. The adapter then dequeues ML completions from the ML device and 
enqueues them as events
+to the event device. This mode does not ensure ingress o

[[PATCH v1] 8/8] net/rnp handle device interrupts

[Wenbo Cao]

Handle device lsc interrupt event

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/base/rnp_hw.h   |   5 +
 drivers/net/rnp/base/rnp_mac_regs.h | 279 
 drivers/net/rnp/rnp.h   |   8 +
 drivers/net/rnp/rnp_ethdev.c|  17 ++
 drivers/net/rnp/rnp_mbx.h   |   3 +-
 drivers/net/rnp/rnp_mbx_fw.c| 233 +++
 drivers/net/rnp/rnp_mbx_fw.h|  38 +++-
 7 files changed, 580 insertions(+), 3 deletions(-)
 create mode 100644 drivers/net/rnp/base/rnp_mac_regs.h

diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index 7b7584959e..a8a253b766 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -10,6 +10,7 @@
 #include "rnp_osdep.h"
 #include "rnp_dma_regs.h"
 #include "rnp_eth_regs.h"
+#include "rnp_mac_regs.h"
 #include "rnp_cfg.h"
 
 static inline unsigned int rnp_rd_reg(volatile void *addr)
@@ -35,6 +36,10 @@ static inline void rnp_wr_reg(volatile void *reg, int val)
rnp_eth_wr(hw, RNP_RAL_BASE_ADDR(hw_idx), val)
 #define RNP_MACADDR_UPDATE_HI(hw, hw_idx, val) \
rnp_eth_wr(hw, RNP_RAH_BASE_ADDR(hw_idx), val)
+#define rnp_mac_rd(hw, id, off) \
+   rnp_rd_reg((char *)(hw)->mac_base[id] + (off))
+#define rnp_mac_wr(hw, id, off, val) \
+   rnp_wr_reg((char *)(hw)->mac_base[id] + (off), val)
 struct rnp_hw;
 /* Mbx Operate info */
 enum MBX_ID {
diff --git a/drivers/net/rnp/base/rnp_mac_regs.h 
b/drivers/net/rnp/base/rnp_mac_regs.h
new file mode 100644
index 00..bfe7e1d780
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_mac_regs.h
@@ -0,0 +1,279 @@
+#ifndef __RNP_MAC_REGS_H__
+#define __RNP_MAC_REGS_H__
+
+#include "rnp_osdep.h"
+#define RNP_MAC_TX_CFG (0x0)
+
+/* Transmitter Enable */
+#define RNP_MAC_TE BIT(0)
+/* Jabber Disable */
+#define RNP_MAC_JD BIT(16)
+#define RNP_SPEED_SEL_1G   (BIT(30) | BIT(29) | BIT(28))
+#define RNP_SPEED_SEL_10G  BIT(30)
+#define RNP_SPEED_SEL_40G  (0)
+#define RNP_MAC_RX_CFG (0x4)
+/* Receiver Enable */
+#define RNP_MAC_RE BIT(0)
+/* Automatic Pad or CRC Stripping */
+#define RNP_MAC_ACSBIT(1)
+/* CRC stripping for Type packets */
+#define RNP_MAC_CSTBIT(2)
+/* Disable CRC Check */
+#define RNP_MAC_DCRCC  BIT(3)
+/* Enable Max Frame Size Limit */
+#define RNP_MAC_GPSLCE BIT(6)
+/* Watchdog Disable */
+#define RNP_MAC_WD BIT(7)
+/* Jumbo Packet Support En */
+#define RNP_MAC_JE BIT(8)
+/* Loopback Mode */
+#define RNP_MAC_LM BIT(10)
+/* Giant Packet Size Limit */
+#define RNP_MAC_GPSL_MASK  GENMASK(29, 16)
+#define RNP_MAC_MAX_GPSL   (1518)
+#define RNP_MAC_CPSL_SHIFT (16)
+
+#define RNP_MAC_PKT_FLT_CTRL   (0x8)
+
+/* Receive All */
+#define RNP_MAC_RA BIT(31)
+/* Pass Control Packets */
+#define RNP_MAC_PCFGENMASK(7, 6)
+#define RNP_MAC_PCF_OFFSET (6)
+/* Mac Filter ALL Ctrl Frame */
+#define RNP_MAC_PCF_FAC(0)
+/* Mac Forward ALL Ctrl Frame Except Pause */
+#define RNP_MAC_PCF_NO_PAUSE   (1)
+/* Mac Forward All Ctrl Pkt */
+#define RNP_MAC_PCF_PA (2)
+/* Mac Forward Ctrl Frame Match Unicast */
+#define RNP_MAC_PCF_PUN(3)
+/* Promiscuous Mode */
+#define RNP_MAC_PROMISC_EN BIT(0)
+/* Hash Unicast */
+#define RNP_MAC_HUCBIT(1)
+/* Hash Multicast */
+#define RNP_MAC_HMCBIT(2)
+/*  Pass All Multicast */
+#define RNP_MAC_PM BIT(4)
+/* Disable Broadcast Packets */
+#define RNP_MAC_DBFBIT(5)
+/* Hash or Perfect Filter */
+#define RNP_MAC_HPFBIT(10)
+#define RNP_MAC_VTFE   BIT(16)
+/* Interrupt Status */
+#define RNP_MAC_INT_STATUS _MAC_(0xb0)
+#define RNP_MAC_LS_MASKGENMASK(25, 24)
+#define RNP_MAC_LS_UP  (0)
+#define RNP_MAC_LS_LOCAL_FAULT BIT(25)
+#define RNP_MAC_LS_REMOT_FAULT (BIT(25) | BIT(24))
+/* Unicast Mac Hash Table */
+#define RNP_MAC_UC_HASH_TB(n)  _MAC_(0x10 + ((n) * 0x4))
+
+
+#define RNP_MAC_LPI_CTRL   (0xd0)
+
+/* PHY Link Status Disable */
+#define RNP_MAC_PLSDIS BIT(18)
+/* PHY Link Status */
+#define RNP_MAC_PLSBIT(17)
+
+/* MAC VLAN CTRL Strip REG */
+#define RNP_MAC_VLAN_TAG   (0x50)
+
+/* En Inner VLAN Strip Action */
+#define RNP_MAC_EIVLS  GENMASK(29, 28)
+/* Inner VLAN Strip Action Shift */
+#define RNP_MAC_IV_EIVLS_SHIFT (28)
+/* Inner Vlan Don't Strip*/
+#define RNP_MAC_IV_STRIP_NONE  (0x0)
+/* Inner Vlan Strip When Filter Match Success */
+#define RNP_MAC_IV_STRIP_PASS  (0x1)
+/* Inner Vla

[[PATCH v1] 0/8] *** SUBJECT HERE ***

[Wenbo Cao]

*** BLURB HERE ***

Wenbo Cao (8):
  net/rnp: add skeleton
  net/rnp: add ethdev probe and remove
  net/rnp: add device init and uninit
  net/rnp: add mbx basic api feature
  net/rnp add reset code for Chip Init process
  net/rnp add port info resource init
  net/rnp add devargs runtime parsing functions
  net/rnp handle device interrupts

 MAINTAINERS |   6 +
 doc/guides/nics/features/rnp.ini|   8 +
 doc/guides/nics/index.rst   |   1 +
 doc/guides/nics/rnp.rst |  43 ++
 drivers/net/meson.build |   1 +
 drivers/net/rnp/base/rnp_api.c  |  71 +++
 drivers/net/rnp/base/rnp_api.h  |  17 +
 drivers/net/rnp/base/rnp_cfg.h  |   7 +
 drivers/net/rnp/base/rnp_dma_regs.h |  73 +++
 drivers/net/rnp/base/rnp_eth_regs.h | 124 +
 drivers/net/rnp/base/rnp_hw.h   | 193 +++
 drivers/net/rnp/base/rnp_mac_regs.h | 279 ++
 drivers/net/rnp/meson.build |  18 +
 drivers/net/rnp/rnp.h   | 217 
 drivers/net/rnp/rnp_ethdev.c| 823 
 drivers/net/rnp/rnp_logs.h  |  43 ++
 drivers/net/rnp/rnp_mbx.c   | 522 ++
 drivers/net/rnp/rnp_mbx.h   | 139 +
 drivers/net/rnp/rnp_mbx_fw.c| 781 ++
 drivers/net/rnp/rnp_mbx_fw.h| 401 ++
 drivers/net/rnp/rnp_osdep.h |  30 +
 drivers/net/rnp/rnp_rxtx.c  |  83 +++
 drivers/net/rnp/rnp_rxtx.h  |  14 +
 23 files changed, 3894 insertions(+)
 create mode 100644 doc/guides/nics/features/rnp.ini
 create mode 100644 doc/guides/nics/rnp.rst
 create mode 100644 drivers/net/rnp/base/rnp_api.c
 create mode 100644 drivers/net/rnp/base/rnp_api.h
 create mode 100644 drivers/net/rnp/base/rnp_cfg.h
 create mode 100644 drivers/net/rnp/base/rnp_dma_regs.h
 create mode 100644 drivers/net/rnp/base/rnp_eth_regs.h
 create mode 100644 drivers/net/rnp/base/rnp_hw.h
 create mode 100644 drivers/net/rnp/base/rnp_mac_regs.h
 create mode 100644 drivers/net/rnp/meson.build
 create mode 100644 drivers/net/rnp/rnp.h
 create mode 100644 drivers/net/rnp/rnp_ethdev.c
 create mode 100644 drivers/net/rnp/rnp_logs.h
 create mode 100644 drivers/net/rnp/rnp_mbx.c
 create mode 100644 drivers/net/rnp/rnp_mbx.h
 create mode 100644 drivers/net/rnp/rnp_mbx_fw.c
 create mode 100644 drivers/net/rnp/rnp_mbx_fw.h
 create mode 100644 drivers/net/rnp/rnp_osdep.h
 create mode 100644 drivers/net/rnp/rnp_rxtx.c
 create mode 100644 drivers/net/rnp/rnp_rxtx.h

-- 
2.27.0

[[PATCH v1] 1/8] net/rnp: add skeleton

[Wenbo Cao]

Add Basic PMD library and doc build infrastructure
Update maintainers file to claim responsibility.

Signed-off-by: Wenbo Cao 
---
 MAINTAINERS  |  6 +
 doc/guides/nics/features/rnp.ini |  8 ++
 doc/guides/nics/index.rst|  1 +
 doc/guides/nics/rnp.rst  | 43 
 drivers/net/meson.build  |  1 +
 drivers/net/rnp/meson.build  | 12 +
 drivers/net/rnp/rnp_ethdev.c |  3 +++
 7 files changed, 74 insertions(+)
 create mode 100644 doc/guides/nics/features/rnp.ini
 create mode 100644 doc/guides/nics/rnp.rst
 create mode 100644 drivers/net/rnp/meson.build
 create mode 100644 drivers/net/rnp/rnp_ethdev.c

diff --git a/MAINTAINERS b/MAINTAINERS
index a5219926ab..36f4867cf8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -955,6 +955,12 @@ F: drivers/net/qede/
 F: doc/guides/nics/qede.rst
 F: doc/guides/nics/features/qede*.ini
 
+Mucse rnp
+M: caowe...@mucse.com
+F: drivers/net/rnp
+F: doc/guides/nics/rnp.rst
+F: doc/guides/nics/features/rnp.ini
+
 Solarflare sfc_efx
 M: Andrew Rybchenko 
 F: drivers/common/sfc_efx/
diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
new file mode 100644
index 00..2ad04ee330
--- /dev/null
+++ b/doc/guides/nics/features/rnp.ini
@@ -0,0 +1,8 @@
+;
+; Supported features of the 'rnp' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Linux= Y
+x86-64   = Y
diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst
index 5c9d1edf5e..cc89d3154a 100644
--- a/doc/guides/nics/index.rst
+++ b/doc/guides/nics/index.rst
@@ -61,6 +61,7 @@ Network Interface Controller Drivers
 pcap_ring
 pfe
 qede
+rnp
 sfc_efx
 softnic
 tap
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
new file mode 100644
index 00..8785972fd9
--- /dev/null
+++ b/doc/guides/nics/rnp.rst
@@ -0,0 +1,43 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2023 Mucse IC Design Ltd.
+
+RNP Poll Mode driver
+==
+
+The RNP ETHDEV PMD (**librte_net_rnp**) provides poll mode ethdev
+driver support for the inbuilt network device found in the **Mucse RNP**
+
+Prerequisites
+-
+More information can be found at `Mucse, Official Website
+`_.
+
+Supported RNP SoCs
+
+
+- N10
+
+Driver compilation and testing
+--
+
+Refer to the document :ref:`compiling and testing a PMD for a NIC 
`
+for details.
+
+#. Running testpmd:
+
+   Follow instructions available in the document
+   :ref:`compiling and testing a PMD for a NIC `
+   to run testpmd.
+
+Limitations or Known issues
+---
+Build with ICC is not supported yet.
+CRC stripping
+
+The RNP SoC family NICs strip the CRC for every packets coming into the
+host interface irrespective of the offload configuration.
+When You Want To Disable CRC_OFFLOAD The Feature Will Influence The RxCksum 
Offload
+VLAN Strip
+~~
+For VLAN Strip RNP Just Support CVLAN(0x8100) Type If The Vlan Type Is 
SVLAN(0X88a8)
+VLAN Filter Or Strip Will Not Effert For This Packet It Will Bypass To The 
Host.
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index b1df17ce8c..8bdbf05857 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -56,6 +56,7 @@ drivers = [
 'ring',
 'sfc',
 'softnic',
+'rnp',
 'tap',
 'thunderx',
 'txgbe',
diff --git a/drivers/net/rnp/meson.build b/drivers/net/rnp/meson.build
new file mode 100644
index 00..0c38d39347
--- /dev/null
+++ b/drivers/net/rnp/meson.build
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(C) 2023 Mucse IC Design Ltd.
+#
+if is_windows
+build = false
+reason = 'not supported on Windows'
+subdir_done()
+endif
+
+sources = files(
+   'rnp_ethdev.c',
+)
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
new file mode 100644
index 00..9ce3c0b497
--- /dev/null
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
-- 
2.27.0

[[PATCH v1] 2/8] net/rnp: add ethdev probe and remove

[Wenbo Cao]

Add basic PCIe ethdev probe and remove.

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp.h| 13 ++
 drivers/net/rnp/rnp_ethdev.c | 83 
 2 files changed, 96 insertions(+)
 create mode 100644 drivers/net/rnp/rnp.h

diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
new file mode 100644
index 00..76d281cc0a
--- /dev/null
+++ b/drivers/net/rnp/rnp.h
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+#ifndef __RNP_H__
+#define __RNP_H__
+
+#define PCI_VENDOR_ID_MUCSE(0x8848)
+#define RNP_DEV_ID_N10G(0x1000)
+
+struct rnp_eth_port {
+} __rte_cache_aligned;
+
+#endif /* __RNP_H__ */
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 9ce3c0b497..5951c2b311 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -1,3 +1,86 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright(C) 2023 Mucse IC Design Ltd.
  */
+
+#include 
+#include 
+#include 
+
+#include "rnp.h"
+
+static int
+rnp_eth_dev_init(struct rte_eth_dev *eth_dev)
+{
+   RTE_SET_USED(eth_dev);
+
+   return -ENODEV;
+}
+
+static int
+rnp_eth_dev_uninit(struct rte_eth_dev *eth_dev)
+{
+   RTE_SET_USED(eth_dev);
+
+   return -ENODEV;
+}
+
+static int
+rnp_pci_remove(struct rte_pci_device *pci_dev)
+{
+   struct rte_eth_dev *eth_dev;
+   int rc;
+
+   eth_dev = rte_eth_dev_allocated(pci_dev->device.name);
+
+   if (eth_dev) {
+   /* Cleanup eth dev */
+   rc = rte_eth_dev_pci_generic_remove(pci_dev,
+   rnp_eth_dev_uninit);
+   if (rc)
+   return rc;
+   }
+   /* Nothing to be done for secondary processes */
+   if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+   return 0;
+
+   return 0;
+}
+
+static int
+rnp_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
+{
+   int rc;
+
+   RTE_SET_USED(pci_drv);
+
+   rc = rte_eth_dev_pci_generic_probe(pci_dev, sizeof(struct rnp_eth_port),
+  rnp_eth_dev_init);
+
+   /* On error on secondary, recheck if port exists in primary or
+* in mid of detach state.
+*/
+   if (rte_eal_process_type() != RTE_PROC_PRIMARY && rc)
+   if (!rte_eth_dev_allocated(pci_dev->device.name))
+   return 0;
+   return rc;
+}
+
+static const struct rte_pci_id pci_id_rnp_map[] = {
+   {
+   RTE_PCI_DEVICE(PCI_VENDOR_ID_MUCSE, RNP_DEV_ID_N10G)
+   },
+   {
+   .vendor_id = 0,
+   },
+};
+
+static struct rte_pci_driver rte_rnp_pmd = {
+   .id_table = pci_id_rnp_map,
+   .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
+   .probe = rnp_pci_probe,
+   .remove = rnp_pci_remove,
+};
+
+RTE_PMD_REGISTER_PCI(net_rnp, rte_rnp_pmd);
+RTE_PMD_REGISTER_PCI_TABLE(net_rnp, pci_id_rnp_map);
+RTE_PMD_REGISTER_KMOD_DEP(net_txgbe, "igb_uio | uio_pci_generic");
-- 
2.27.0

[[PATCH v1] 4/8] net/rnp: add mbx basic api feature

[Wenbo Cao]

mbx base code is for communicate with the firmware

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/base/rnp_hw.h | 107 ++-
 drivers/net/rnp/meson.build   |   1 +
 drivers/net/rnp/rnp.h |  35 +++
 drivers/net/rnp/rnp_ethdev.c  |  68 +
 drivers/net/rnp/rnp_logs.h|   9 +
 drivers/net/rnp/rnp_mbx.c | 522 ++
 drivers/net/rnp/rnp_mbx.h | 138 +
 drivers/net/rnp/rnp_mbx_fw.h  |  22 ++
 8 files changed, 901 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/rnp/rnp_mbx.c
 create mode 100644 drivers/net/rnp/rnp_mbx.h
 create mode 100644 drivers/net/rnp/rnp_mbx_fw.h

diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index 543011a64c..da3659bd67 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -4,15 +4,120 @@
 #ifndef __RNP_HW_H__
 #define __RNP_HW_H__
 
+#include 
+#include 
+
+#include "rnp_osdep.h"
+
+static inline unsigned int rnp_rd_reg(volatile void *addr)
+{
+   unsigned int v = rte_read32(addr);
+
+   return v;
+}
+
+static inline void rnp_wr_reg(volatile void *reg, int val)
+{
+   rte_write32_relaxed((val), (reg));
+}
+
+#define mbx_rd32(hw, reg)  rnp_rd_reg((hw)->iobar4 + (reg))
+#define mbx_wr32(hw, reg, val) rnp_wr_reg((hw)->iobar4 + (reg), (val))
+
+struct rnp_hw;
+/* Mbx Operate info */
+enum MBX_ID {
+   MBX_PF = 0,
+   MBX_VF,
+   MBX_CM3CPU,
+   MBX_FW = MBX_CM3CPU,
+   MBX_VFCNT
+};
+struct rnp_mbx_api {
+   void (*init_mbx)(struct rnp_hw *hw);
+   int32_t (*read)(struct rnp_hw *hw,
+   uint32_t *msg,
+   uint16_t size,
+   enum MBX_ID);
+   int32_t (*write)(struct rnp_hw *hw,
+   uint32_t *msg,
+   uint16_t size,
+   enum MBX_ID);
+   int32_t (*read_posted)(struct rte_eth_dev *dev,
+   uint32_t *msg,
+   uint16_t size,
+   enum MBX_ID);
+   int32_t (*write_posted)(struct rte_eth_dev *dev,
+   uint32_t *msg,
+   uint16_t size,
+   enum MBX_ID);
+   int32_t (*check_for_msg)(struct rnp_hw *hw, enum MBX_ID);
+   int32_t (*check_for_ack)(struct rnp_hw *hw, enum MBX_ID);
+   int32_t (*check_for_rst)(struct rnp_hw *hw, enum MBX_ID);
+   int32_t (*configure)(struct rnp_hw *hw, int nr_vec, bool enable);
+};
+
+struct rnp_mbx_stats {
+   u32 msgs_tx;
+   u32 msgs_rx;
+
+   u32 acks;
+   u32 reqs;
+   u32 rsts;
+};
+
+struct rnp_mbx_info {
+   struct rnp_mbx_api ops;
+   uint32_t usec_delay;/* retry interval delay time */
+   uint32_t timeout;   /* retry ops timeout limit */
+   uint16_t size;  /* data buffer size*/
+   uint16_t vf_num;/* Virtual Function num */
+   uint16_t pf_num;/* Physical Function num */
+   uint16_t sriov_st;  /* Sriov state */
+   bool irq_enabled;
+   union {
+   struct {
+   unsigned short pf_req;
+   unsigned short pf_ack;
+   };
+   struct {
+   unsigned short cpu_req;
+   unsigned short cpu_ack;
+   };
+   };
+   unsigned short vf_req[64];
+   unsigned short vf_ack[64];
+
+   struct rnp_mbx_stats stats;
+
+   rte_atomic16_t state;
+} __rte_cache_aligned;
+
+#define RNP_MAX_HW_PORT_PERR_PF (4)
 struct rnp_hw {
void *back;
char *iobar0;
uint32_t iobar0_len;
char *iobar4;
uint32_t iobar4_len;
+   char *link_sync;
+   char *dma_base;
+   char *eth_base;
+   char *veb_base;
+   char *mac_base[RNP_MAX_HW_PORT_PERR_PF];
+   char *msix_base;
+   /* === dma == */
+   char *dma_axi_en;
+   char *dma_axi_st;
 
uint16_t device_id;
uint16_t vendor_id;
-} __rte_cache_aligned;
+   uint16_t function;
+   uint16_t pf_vf_num;
+   uint16_t max_vfs;
+   void *cookie_pool;
+   char cookie_p_name[RTE_MEMZONE_NAMESIZE];
 
+   struct rnp_mbx_info mbx;
+} __rte_cache_aligned;
 #endif /* __RNP_H__*/
diff --git a/drivers/net/rnp/meson.build b/drivers/net/rnp/meson.build
index 36a1f7148d..38dbee5ca4 100644
--- a/drivers/net/rnp/meson.build
+++ b/drivers/net/rnp/meson.build
@@ -9,5 +9,6 @@ endif
 
 sources = files(
'rnp_ethdev.c',
+   'rnp_mbx.c',
 )
 includes += include_directories('base')
diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index ea9d138673..a8999ddc47 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -3,6 +3,7 @@
  */
 #ifndef __RNP_H__
 #define __RNP_H__
+#include 
 
 #include "base/rnp_hw.h"
 
@@ -14,14 +15,17 @@
 
 struct rnp_eth_port {
void *adapt;
+   struct rnp_hw *hw;
struct rte_eth_dev *eth_dev;
 } __rte_cache_aligned;
 
 str

[[PATCH v1] 3/8] net/rnp: add device init and uninit

[Wenbo Cao]

Add basic init and uninit function

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/base/rnp_hw.h |  18 
 drivers/net/rnp/meson.build   |   1 +
 drivers/net/rnp/rnp.h |  25 +
 drivers/net/rnp/rnp_ethdev.c  | 197 +-
 drivers/net/rnp/rnp_logs.h|  34 ++
 drivers/net/rnp/rnp_osdep.h   |  30 ++
 6 files changed, 300 insertions(+), 5 deletions(-)
 create mode 100644 drivers/net/rnp/base/rnp_hw.h
 create mode 100644 drivers/net/rnp/rnp_logs.h
 create mode 100644 drivers/net/rnp/rnp_osdep.h

diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
new file mode 100644
index 00..543011a64c
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -0,0 +1,18 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+#ifndef __RNP_HW_H__
+#define __RNP_HW_H__
+
+struct rnp_hw {
+   void *back;
+   char *iobar0;
+   uint32_t iobar0_len;
+   char *iobar4;
+   uint32_t iobar4_len;
+
+   uint16_t device_id;
+   uint16_t vendor_id;
+} __rte_cache_aligned;
+
+#endif /* __RNP_H__*/
diff --git a/drivers/net/rnp/meson.build b/drivers/net/rnp/meson.build
index 0c38d39347..36a1f7148d 100644
--- a/drivers/net/rnp/meson.build
+++ b/drivers/net/rnp/meson.build
@@ -10,3 +10,4 @@ endif
 sources = files(
'rnp_ethdev.c',
 )
+includes += include_directories('base')
diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index 76d281cc0a..ea9d138673 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -4,10 +4,35 @@
 #ifndef __RNP_H__
 #define __RNP_H__
 
+#include "base/rnp_hw.h"
+
 #define PCI_VENDOR_ID_MUCSE(0x8848)
 #define RNP_DEV_ID_N10G(0x1000)
+#define RNP_MAX_PORT_OF_PF (4)
+#define RNP_CFG_BAR(4)
+#define RNP_PF_INFO_BAR(0)
 
 struct rnp_eth_port {
+   void *adapt;
+   struct rte_eth_dev *eth_dev;
+} __rte_cache_aligned;
+
+struct rnp_share_ops {
 } __rte_cache_aligned;
 
+struct rnp_eth_adapter {
+   struct rnp_hw hw;
+   struct rte_pci_device *pdev;
+   struct rte_eth_dev *eth_dev; /* master eth_dev */
+   struct rnp_eth_port *ports[RNP_MAX_PORT_OF_PF];
+   struct rnp_share_ops *share_priv;
+
+   uint8_t num_ports; /* Cur Pf Has physical Port Num */
+} __rte_cache_aligned;
+
+#define RNP_DEV_TO_PORT(eth_dev) \
+   (((struct rnp_eth_port *)((eth_dev)->data->dev_private)))
+#define RNP_DEV_TO_ADAPTER(eth_dev) \
+   ((struct rnp_eth_adapter *)(RNP_DEV_TO_PORT(eth_dev)->adapt))
+
 #endif /* __RNP_H__ */
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 5951c2b311..18fd169166 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -5,23 +5,199 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "rnp.h"
+#include "rnp_logs.h"
 
 static int
-rnp_eth_dev_init(struct rte_eth_dev *eth_dev)
+rnp_mac_rx_disable(struct rte_eth_dev *dev)
 {
-   RTE_SET_USED(eth_dev);
+   RTE_SET_USED(dev);
 
-   return -ENODEV;
+   return 0;
+}
+
+static int
+rnp_mac_tx_disable(struct rte_eth_dev *dev)
+{
+   RTE_SET_USED(dev);
+
+   return 0;
+}
+
+static int rnp_dev_close(struct rte_eth_dev *dev)
+{
+   RTE_SET_USED(dev);
+
+   return 0;
+}
+
+/* Features supported by this driver */
+static const struct eth_dev_ops rnp_eth_dev_ops = {
+};
+
+static int
+rnp_init_port_resource(struct rnp_eth_adapter *adapter,
+  struct rte_eth_dev *dev,
+  char *name,
+  uint8_t p_id)
+{
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
+
+   port->eth_dev = dev;
+   adapter->ports[p_id] = port;
+   dev->dev_ops = &rnp_eth_dev_ops;
+   RTE_SET_USED(name);
+
+   return 0;
+}
+
+static struct rte_eth_dev *
+rnp_alloc_eth_port(struct rte_pci_device *master_pci, char *name)
+{
+   struct rnp_eth_port *port;
+   struct rte_eth_dev *eth_dev;
+
+   eth_dev = rte_eth_dev_allocate(name);
+   if (!eth_dev) {
+   RNP_PMD_DRV_LOG(ERR, "Could not allocate "
+   "eth_dev for %s\n", name);
+   return NULL;
+   }
+   port = rte_zmalloc_socket(name,
+   sizeof(*port),
+   RTE_CACHE_LINE_SIZE,
+   master_pci->device.numa_node);
+   if (!port) {
+   RNP_PMD_DRV_LOG(ERR, "Could not allocate "
+   "rnp_eth_port for %s\n", name);
+   return NULL;
+   }
+   eth_dev->data->dev_private = port;
+   eth_dev->process_private = calloc(1, sizeof(struct rnp_share_ops));
+   if (!eth_dev->process_private) {
+   RNP_PMD_DRV_LOG(ERR, "Could not calloc "
+   "for Process_priv\n");
+   goto fail_calloc;
+   }
+   return eth_dev;
+fail_calloc:
+   rte_free(port);
+   rte_eth_dev_release_port(eth_de

[[PATCH v1] 5/8] net/rnp add reset code for Chip Init process

[Wenbo Cao]

we must get the shape info of nic from Firmware for
reset. so the related codes is first get firmware info
and then reset the chip

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/base/rnp_api.c  |  24 +++
 drivers/net/rnp/base/rnp_api.h  |   7 +
 drivers/net/rnp/base/rnp_cfg.h  |   7 +
 drivers/net/rnp/base/rnp_dma_regs.h |  73 
 drivers/net/rnp/base/rnp_eth_regs.h | 124 +
 drivers/net/rnp/base/rnp_hw.h   |  46 +
 drivers/net/rnp/meson.build |   3 +
 drivers/net/rnp/rnp.h   |  28 ++-
 drivers/net/rnp/rnp_ethdev.c|  99 +-
 drivers/net/rnp/rnp_mbx_fw.c| 272 
 drivers/net/rnp/rnp_mbx_fw.h| 163 -
 11 files changed, 840 insertions(+), 6 deletions(-)
 create mode 100644 drivers/net/rnp/base/rnp_api.c
 create mode 100644 drivers/net/rnp/base/rnp_api.h
 create mode 100644 drivers/net/rnp/base/rnp_cfg.h
 create mode 100644 drivers/net/rnp/base/rnp_dma_regs.h
 create mode 100644 drivers/net/rnp/base/rnp_eth_regs.h
 create mode 100644 drivers/net/rnp/rnp_mbx_fw.c

diff --git a/drivers/net/rnp/base/rnp_api.c b/drivers/net/rnp/base/rnp_api.c
new file mode 100644
index 00..f3044e595e
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_api.c
@@ -0,0 +1,24 @@
+#include "rnp.h"
+#include "rnp_api.h"
+
+int
+rnp_init_hw(struct rte_eth_dev *dev)
+{
+   struct rnp_mac_api *ops = RNP_DEV_TO_MAC_OPS(dev);
+   struct rnp_hw *hw = RNP_DEV_TO_HW(dev);
+
+   if (ops->init_hw)
+   return ops->init_hw(hw);
+   return -EOPNOTSUPP;
+}
+
+int
+rnp_reset_hw(struct rte_eth_dev *dev, struct rnp_hw *hw)
+{
+   struct rnp_mac_api *ops = RNP_DEV_TO_MAC_OPS(dev);
+
+   if (ops->reset_hw)
+   return ops->reset_hw(hw);
+   return -EOPNOTSUPP;
+}
+
diff --git a/drivers/net/rnp/base/rnp_api.h b/drivers/net/rnp/base/rnp_api.h
new file mode 100644
index 00..df574dab77
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_api.h
@@ -0,0 +1,7 @@
+#ifndef __RNP_API_H__
+#define __RNP_API_H__
+int
+rnp_init_hw(struct rte_eth_dev *dev);
+int
+rnp_reset_hw(struct rte_eth_dev *dev, struct rnp_hw *hw);
+#endif /* __RNP_API_H__ */
diff --git a/drivers/net/rnp/base/rnp_cfg.h b/drivers/net/rnp/base/rnp_cfg.h
new file mode 100644
index 00..90f25268ad
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_cfg.h
@@ -0,0 +1,7 @@
+#ifndef __RNP_CFG_H__
+#define __RNP_CFG_H__
+#include "rnp_osdep.h"
+
+#define RNP_NIC_RESET  _NIC_(0x0010)
+#define RNP_TX_QINQ_WORKAROUND _NIC_(0x801c)
+#endif /* __RNP_CFG_H__ */
diff --git a/drivers/net/rnp/base/rnp_dma_regs.h 
b/drivers/net/rnp/base/rnp_dma_regs.h
new file mode 100644
index 00..bfe87e534d
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_dma_regs.h
@@ -0,0 +1,73 @@
+#ifndef __RNP_REGS_H__
+#define __RNP_REGS_H__
+
+#include "rnp_osdep.h"
+
+/* mac address offset */
+#define RNP_DMA_CTRL   (0x4)
+#define RNP_VEB_BYPASS_EN  BIT(4)
+#define RNP_DMA_MEM_CFG_LE (0 << 5)
+#define TSNR10_DMA_MEM_CFG_BE  (1 << 5)
+#define RNP_DMA_SCATTER_MEM_SHIFT  (16)
+
+#define RNP_FIRMWARE_SYNC  (0xc)
+#define RNP_FIRMWARE_SYNC_MASK GENMASK(31, 16)
+#define RNP_FIRMWARE_SYNC_MAGIC(0xa5a4)
+#define RNP_DRIVER_REMOVE  (0x5a00)
+/* 1BIT <-> 16 bytes Dma Addr Size*/
+#define RNP_DMA_SCATTER_MEM_MASK   GENMASK(31, 16)
+#define RNP_DMA_TX_MAP_MODE_SHIFT  (12)
+#define RNP_DMA_TX_MAP_MODE_MASK   GENMASK(15, 12)
+#define RNP_DMA_RX_MEM_PAD_EN  BIT(8)
+/* === queue register = */
+/* enable */
+#define RNP_DMA_RXQ_START(qid) _RING_(0x0010 + 0x100 * (qid))
+#define RNP_DMA_RXQ_READY(qid) _RING_(0x0014 + 0x100 * (qid))
+#define RNP_DMA_TXQ_START(qid) _RING_(0x0018 + 0x100 * (qid))
+#define RNP_DMA_TXQ_READY(qid) _RING_(0x001c + 0x100 * (qid))
+
+#define RNP_DMA_INT_STAT(qid)  _RING_(0x0020 + 0x100 * (qid))
+#define RNP_DMA_INT_MASK(qid)  _RING_(0x0024 + 0x100 * (qid))
+#define RNP_TX_INT_MASKBIT(1)
+#define RNP_RX_INT_MASKBIT(0)
+#define RNP_DMA_INT_CLER(qid)  _RING_(0x0028 + 0x100 * (qid))
+
+/* rx-queue */
+#define RNP_DMA_RXQ_BASE_ADDR_HI(qid)  _RING_(0x0030 + 0x100 * (qid))
+#define RNP_DMA_RXQ_BASE_ADDR_LO(qid)  _RING_(0x0034 + 0x100 * (qid))
+#define RNP_DMA_RXQ_LEN(qid)   _RING_(0x0038 + 0x100 * (qid))
+#define RNP_DMA_RXQ_HEAD(qid)  _RING_(0x003c + 0x100 * (qid))
+#define RNP_DMA_RXQ_TAIL(qid)  _RING_(0x0040 + 0x100 * (qid))
+#define RNP_DMA_RXQ_DESC_FETCH_CTRL(qid)   _RING_(0x0044 + 0x100 * (qid))
+#define RNP_DMA_RXQ_INT_DELAY_TIMER(qid)   _RING_(0x0048 + 0x100 * (qid))
+

[[PATCH v1] 6/8] net/rnp add port info resource init

[Wenbo Cao]

Add Api For FW Mac Info, Port Resoucre info init Code
For Different Shape Of Nic

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/base/rnp_api.c |  47 +++
 drivers/net/rnp/base/rnp_api.h |  10 ++
 drivers/net/rnp/base/rnp_hw.h  |  19 +++
 drivers/net/rnp/meson.build|   1 +
 drivers/net/rnp/rnp.h  |  88 +
 drivers/net/rnp/rnp_ethdev.c   | 224 +++--
 drivers/net/rnp/rnp_mbx_fw.c   | 112 +
 drivers/net/rnp/rnp_mbx_fw.h   | 115 +
 drivers/net/rnp/rnp_rxtx.c |  83 
 drivers/net/rnp/rnp_rxtx.h |  14 +++
 10 files changed, 706 insertions(+), 7 deletions(-)
 create mode 100644 drivers/net/rnp/rnp_rxtx.c
 create mode 100644 drivers/net/rnp/rnp_rxtx.h

diff --git a/drivers/net/rnp/base/rnp_api.c b/drivers/net/rnp/base/rnp_api.c
index f3044e595e..f2ab0ea270 100644
--- a/drivers/net/rnp/base/rnp_api.c
+++ b/drivers/net/rnp/base/rnp_api.c
@@ -22,3 +22,50 @@ rnp_reset_hw(struct rte_eth_dev *dev, struct rnp_hw *hw)
return -EOPNOTSUPP;
 }
 
+int
+rnp_get_mac_addr(struct rte_eth_dev *dev, uint8_t *macaddr)
+{
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
+   struct rnp_mac_api *ops = RNP_DEV_TO_MAC_OPS(dev);
+
+   if (!macaddr)
+   return -EINVAL;
+   if (ops->get_mac_addr)
+   return ops->get_mac_addr(port, port->attr.nr_lane, macaddr);
+   return -EOPNOTSUPP;
+}
+
+int
+rnp_set_default_mac(struct rte_eth_dev *dev, uint8_t *mac_addr)
+{
+   struct rnp_mac_api *ops = RNP_DEV_TO_MAC_OPS(dev);
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
+
+   if (ops->set_default_mac)
+   return ops->set_default_mac(port, mac_addr);
+   return -EOPNOTSUPP;
+}
+
+int
+rnp_set_rafb(struct rte_eth_dev *dev, uint8_t *addr,
+   uint8_t vm_pool, uint8_t index)
+{
+   struct rnp_mac_api *ops = RNP_DEV_TO_MAC_OPS(dev);
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
+
+   if (ops->set_rafb)
+   return ops->set_rafb(port, addr, vm_pool, index);
+   return -EOPNOTSUPP;
+}
+
+int
+rnp_clear_rafb(struct rte_eth_dev *dev,
+   uint8_t vm_pool, uint8_t index)
+{
+   struct rnp_mac_api *ops = RNP_DEV_TO_MAC_OPS(dev);
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
+
+   if (ops->clear_rafb)
+   return ops->clear_rafb(port, vm_pool, index);
+   return -EOPNOTSUPP;
+}
diff --git a/drivers/net/rnp/base/rnp_api.h b/drivers/net/rnp/base/rnp_api.h
index df574dab77..b998b11237 100644
--- a/drivers/net/rnp/base/rnp_api.h
+++ b/drivers/net/rnp/base/rnp_api.h
@@ -4,4 +4,14 @@ int
 rnp_init_hw(struct rte_eth_dev *dev);
 int
 rnp_reset_hw(struct rte_eth_dev *dev, struct rnp_hw *hw);
+int
+rnp_get_mac_addr(struct rte_eth_dev *dev, uint8_t *macaddr);
+int
+rnp_set_default_mac(struct rte_eth_dev *dev, uint8_t *mac_addr);
+int
+rnp_set_rafb(struct rte_eth_dev *dev, uint8_t *addr,
+   uint8_t vm_pool, uint8_t index);
+int
+rnp_clear_rafb(struct rte_eth_dev *dev,
+   uint8_t vm_pool, uint8_t index);
 #endif /* __RNP_API_H__ */
diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index 03381ab6d0..7b7584959e 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -30,6 +30,11 @@ static inline void rnp_wr_reg(volatile void *reg, int val)
 #define rnp_eth_rd(hw, off)rnp_rd_reg((char *)(hw)->eth_base + (off))
 #define rnp_eth_wr(hw, off, val) \
rnp_wr_reg((char *)(hw)->eth_base + (off), val)
+/* == reg-rw == */
+#define RNP_MACADDR_UPDATE_LO(hw, hw_idx, val) \
+   rnp_eth_wr(hw, RNP_RAL_BASE_ADDR(hw_idx), val)
+#define RNP_MACADDR_UPDATE_HI(hw, hw_idx, val) \
+   rnp_eth_wr(hw, RNP_RAH_BASE_ADDR(hw_idx), val)
 struct rnp_hw;
 /* Mbx Operate info */
 enum MBX_ID {
@@ -99,9 +104,23 @@ struct rnp_mbx_info {
rte_atomic16_t state;
 } __rte_cache_aligned;
 
+struct rnp_eth_port;
 struct rnp_mac_api {
int32_t (*init_hw)(struct rnp_hw *hw);
int32_t (*reset_hw)(struct rnp_hw *hw);
+   /* MAC Address */
+   int32_t (*get_mac_addr)(struct rnp_eth_port *port,
+   uint8_t lane,
+   uint8_t *macaddr);
+   int32_t (*set_default_mac)(struct rnp_eth_port *port, uint8_t *mac);
+   /* Receive Address Filter Table */
+   int32_t (*set_rafb)(struct rnp_eth_port *port,
+   uint8_t *mac,
+   uint8_t vm_pool,
+   uint8_t index);
+   int32_t (*clear_rafb)(struct rnp_eth_port *port,
+   uint8_t vm_pool,
+   uint8_t index);
 };
 
 struct rnp_mac_info {
diff --git a/drivers/net/rnp/meson.build b/drivers/net/rnp/meson.build
index c52566c357..7d63460c45 100644
--- a/drivers/net/rnp/meson.build
+++ b/drivers/net/rnp/meson.build
@@ -11,6 +11,7 @@ sources = files(
'rnp_ethdev.c'

[[PATCH v1] 7/8] net/rnp add devargs runtime parsing functions

[Wenbo Cao]

add various runtime devargs command line options
supported by this driver.

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp.h|  22 +
 drivers/net/rnp/rnp_ethdev.c | 164 +++
 drivers/net/rnp/rnp_mbx_fw.c | 164 +++
 drivers/net/rnp/rnp_mbx_fw.h |  69 +++
 4 files changed, 419 insertions(+)

diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index 892dbc47f4..029e8a2776 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -107,6 +107,8 @@ struct rnp_eth_port {
void *adapt;
uint8_t mac_addr[RTE_ETHER_ADDR_LEN];
struct rnp_hw *hw;
+   uint8_t rx_func_sec; /* force set io rx_func */
+   uint8_t tx_func_sec; /* force set io tx func */
struct rte_eth_dev *eth_dev;
struct rnp_port_attr attr;
/* Recvice Mac Address Record Table */
@@ -122,6 +124,13 @@ struct rnp_share_ops {
struct rnp_mac_api mac_api;
 } __rte_cache_aligned;
 
+enum {
+   RNP_IO_FUNC_USE_NONE = 0,
+   RNP_IO_FUNC_USE_VEC,
+   RNP_IO_FUNC_USE_SIMPLE,
+   RNP_IO_FUNC_USE_COMMON,
+};
+
 struct rnp_eth_adapter {
enum rnp_work_mode mode;
enum rnp_resource_share_m s_mode; /* Port Resource Share Policy */
@@ -135,6 +144,19 @@ struct rnp_eth_adapter {
int max_link_speed;
uint8_t num_ports; /* Cur Pf Has physical Port Num */
uint8_t lane_mask;
+
+   uint8_t rx_func_sec; /* force set io rx_func */
+   uint8_t tx_func_sec; /* force set io tx func*/
+   /*fw-update*/
+   bool  do_fw_update;
+   char *fw_path;
+
+   bool loopback_en;
+   bool fw_sfp_10g_1g_auto_det;
+   int fw_force_speed_1g;
+#define FOCE_SPEED_1G_NOT_SET  (-1)
+#define FOCE_SPEED_1G_DISABLED (0)
+#define FOCE_SPEED_1G_ENABLED  (1)
 } __rte_cache_aligned;
 
 #define RNP_DEV_TO_PORT(eth_dev) \
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 22b9ffd685..fbcfc4f661 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -6,6 +6,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "rnp.h"
 #include "rnp_mbx.h"
@@ -14,6 +15,13 @@
 #include "rnp_rxtx.h"
 #include "rnp_logs.h"
 
+#define RNP_HW_MAC_LOOPBACK_ARG  "hw_loopback"
+#define RNP_FW_UPDATE"fw_update"
+#define RNP_RX_FUNC_SELECT   "rx_func_sec"
+#define RNP_TX_FUNC_SELECT   "tx_func_sec"
+#define RNP_FW_4X10G_10G_1G_DET  "fw_4x10g_10g_1g_auto_det"
+#define RNP_FW_FORCE_SPEED_1G"fw_force_1g_speed"
+
 extern struct rnp_mbx_api rnp_mbx_pf_ops;
 static int
 rnp_mac_rx_disable(struct rte_eth_dev *dev)
@@ -109,6 +117,8 @@ rnp_init_port_resource(struct rnp_eth_adapter *adapter,
struct rnp_hw *hw = &adapter->hw;
 
port->adapt = adapter;
+   port->rx_func_sec = adapter->rx_func_sec;
+   port->tx_func_sec = adapter->tx_func_sec;
port->s_mode = adapter->s_mode;
port->port_stopped = 1;
port->hw = hw;
@@ -444,6 +454,152 @@ rnp_special_ops_init(struct rte_eth_dev *eth_dev)
return 0;
 }
 
+static const char *const rnp_valid_arguments[] = {
+   RNP_HW_MAC_LOOPBACK_ARG,
+   RNP_FW_UPDATE,
+   RNP_RX_FUNC_SELECT,
+   RNP_TX_FUNC_SELECT,
+   RNP_FW_4X10G_10G_1G_DET,
+   RNP_FW_FORCE_SPEED_1G,
+   NULL
+};
+
+static int
+rnp_parse_handle_devarg(const char *key, const char *value,
+   void *extra_args)
+{
+   struct rnp_eth_adapter *adapter = NULL;
+
+   if (value == NULL || extra_args == NULL)
+   return -EINVAL;
+
+   if (strcmp(key, RNP_HW_MAC_LOOPBACK_ARG) == 0) {
+   uint16_t *n = extra_args;
+   *n = (uint16_t)strtoul(value, NULL, 10);
+   if (*n == USHRT_MAX && errno == ERANGE)
+   return -1;
+   } else if (strcmp(key, RNP_FW_UPDATE) == 0) {
+   adapter = (struct rnp_eth_adapter *)extra_args;
+   adapter->do_fw_update = true;
+   adapter->fw_path = strdup(value);
+   } else if (strcmp(key, RNP_FW_4X10G_10G_1G_DET) == 0) {
+   adapter = (struct rnp_eth_adapter *)extra_args;
+   if (adapter->num_ports == 2 && adapter->hw.speed == 10 * 1000) {
+   adapter->fw_sfp_10g_1g_auto_det =
+   (strcmp(value, "on") == 0) ? true : false;
+   } else {
+   adapter->fw_sfp_10g_1g_auto_det = false;
+   }
+   } else if (strcmp(key, RNP_FW_FORCE_SPEED_1G) == 0) {
+   adapter = (struct rnp_eth_adapter *)extra_args;
+   if (adapter->num_ports == 2) {
+   if (strcmp(value, "on") == 0)
+   adapter->fw_force_speed_1g = 
FOCE_SPEED_1G_ENABLED;
+   else if (strcmp(value, "off") == 0)
+   adapter->fw_force_speed_1g = 
FOCE_SPEED_1G_DISABLED;
+   

RE: [PATCH v2 0/4] eal: update public API to use stdatomic atomics

[Morten Brørup]

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Tuesday, 1 August 2023 07.04
> 
> Update EAL public API to use standard C11 atomics. In accordance with
> technical board discussion February 2023.
> http://mails.dpdk.org/archives/dev/2023-February/263516.html
> 
> This initial series makes no attempt to adapt every use of builtin atomics
> from GCC it intends only to adapt the public API of the EAL presented as
> a compatibility surface to applications.
> 
> Further series will be submitted to adapt the rest of DPDK to use standard
> atomics that are 'internal' and not do not straddle the EAL API.
> 
> The choice has been made to break these two changes apart to allow more
> precise analysis of any potential performance impact this change or
> subsequent changes may introduce.
> 
> Additionally, it is not possible to break the commits up per driver/lib as
> both the provider and consumer of the APIs need to be changed in the same
> commit to maintain non-broken build and function.
> 
> Finally, the first patch in this series is a duplication of Bruce Richardson
> series https://patchwork.dpdk.org/project/dpdk/list/?series=29048 and is
> only being provided to enable the CI run on this series. It is expected that
> Bruce's series when committed will allow the build: require minimum c11
> compiler
> here to be dropped from this series.
> 
> v2:
>   * remove volatile qualification from variables, structure fields and
> parameters that have been qualified _Atomic
>   * restore removal of #include  in rte_ring_core.h the ring
> library still uses other rte_atomic APIs and types that are not replaced
> by the standard or compiler intrinsics
>   * add missing adaption to stdatomic in ring/rte_ring_c11_pvt.h

Series-acked-by: Morten Brørup 

Re: [PATCH v2] kni: remove deprecated kernel network interface

[David Marchand]

Hello Stephen,

While rebasing, please also fix those nits:

On Sun, Jul 30, 2023 at 4:12 AM Stephen Hemminger
 wrote:
> diff --git a/doc/guides/contributing/documentation.rst 
> b/doc/guides/contributing/documentation.rst
> index 7fcbb7fc43b2..f16c94e9768b 100644
> --- a/doc/guides/contributing/documentation.rst
> +++ b/doc/guides/contributing/documentation.rst
> @@ -95,7 +95,7 @@ added to by the developer.
>  * **The Programmers Guide**
>
>The Programmers Guide explains how the API components of DPDK such as the 
> EAL, Memzone, Rings and the Hash Library work.
> -  It also explains how some higher level functionality such as Packet 
> Distributor, Packet Framework and KNI work.
> +  It also explains how some higher level functionality such as Packet 
> Distributor and Packet Framework.

s/how some higher level functionality/how some higher level functionality work/

>It also shows the build system and explains how to add applications.
>
>The Programmers Guide should be expanded when new functionality is added 
> to DPDK.

[snip]

> diff --git a/doc/guides/rel_notes/release_23_11.rst 
> b/doc/guides/rel_notes/release_23_11.rst
> new file mode 100644
> index ..e2158934751f
> --- /dev/null
> +++ b/doc/guides/rel_notes/release_23_11.rst
> @@ -0,0 +1,16 @@
> +.. SPDX-License-Identifier: BSD-3-Clause
> +   Copyright 2022 The DPDK contributors
> +
> +.. include:: 
> +
> +DPDK Release 23.11
> +==
> +
> +New Features
> +
> +
> +
> +Removed Items
> +-
> +
> +* kni: Remove deprecated Kernel Network Interface driver, libraries and 
> examples

s/Remove/Removed/
s/$/./


Thanks.

-- 
David Marchand

Re: [PATCH] flow_classify: remove library

[David Marchand]

Hello,

On Mon, Jul 31, 2023 at 10:45 PM Stephen Hemminger
 wrote:
>
> The flow_classify library was marked for removal last year
> because there was no maintainer and the functionality is
> limited.
>
> Signed-off-by: Stephen Hemminger 
> ---
>  MAINTAINERS   |   7 -
>  app/test/meson.build  |   4 -
>  app/test/test_flow_classify.c | 895 --

app/test/test_flow_classify.h can be removed too.

>  doc/api/doxy-api-index.md |   1 -
>  doc/api/doxy-api.conf.in  |   1 -
>  doc/guides/freebsd_gsg/build_sample_apps.rst  |   2 +-
>  doc/guides/freebsd_gsg/install_from_ports.rst |   2 +-
>  doc/guides/prog_guide/flow_classify_lib.rst   | 424 -
>  doc/guides/prog_guide/index.rst   |   1 -
>  doc/guides/rel_notes/deprecation.rst  |   8 +-
>  doc/guides/rel_notes/release_23_11.rst|   3 +
>  doc/guides/sample_app_ug/flow_classify.rst| 242 -
>  doc/guides/sample_app_ug/index.rst|   1 -
>  examples/flow_classify/Makefile   |  51 -
>  examples/flow_classify/flow_classify.c| 878 -
>  examples/flow_classify/ipv4_rules_file.txt|  14 -
>  examples/flow_classify/meson.build|  13 -
>  examples/meson.build  |   1 -
>  lib/flow_classify/meson.build |  12 -
>  lib/flow_classify/rte_flow_classify.c | 670 -
>  lib/flow_classify/rte_flow_classify.h | 284 --
>  lib/flow_classify/rte_flow_classify_parse.c   | 532 ---
>  lib/flow_classify/rte_flow_classify_parse.h   |  58 --
>  lib/flow_classify/version.map |  13 -
>  lib/meson.build   |   3 -
>  meson_options.txt |   2 +-
>  26 files changed, 7 insertions(+), 4115 deletions(-)
>  delete mode 100644 app/test/test_flow_classify.c
>  delete mode 100644 doc/guides/prog_guide/flow_classify_lib.rst
>  delete mode 100644 doc/guides/sample_app_ug/flow_classify.rst
>  delete mode 100644 examples/flow_classify/Makefile
>  delete mode 100644 examples/flow_classify/flow_classify.c
>  delete mode 100644 examples/flow_classify/ipv4_rules_file.txt
>  delete mode 100644 examples/flow_classify/meson.build
>  delete mode 100644 lib/flow_classify/meson.build
>  delete mode 100644 lib/flow_classify/rte_flow_classify.c
>  delete mode 100644 lib/flow_classify/rte_flow_classify.h
>  delete mode 100644 lib/flow_classify/rte_flow_classify_parse.c
>  delete mode 100644 lib/flow_classify/rte_flow_classify_parse.h
>  delete mode 100644 lib/flow_classify/version.map
>

[snip]

> diff --git a/doc/guides/rel_notes/release_23_11.rst 
> b/doc/guides/rel_notes/release_23_11.rst
> index 6b4dd21fd0e1..f4c1e5ef4a7a 100644
> --- a/doc/guides/rel_notes/release_23_11.rst
> +++ b/doc/guides/rel_notes/release_23_11.rst
> @@ -68,6 +68,9 @@ Removed Items
> Also, make sure to start the actual text at the margin.
> ===
>
> +* flow_classify: library has been removed as planned.
> +  The library was experimental there was no maintainer or user interest.
> +
>

Please use a consistent wording, like for kni.


>  API Changes
>  ---

Thanks.


-- 
David Marchand

Re: [[PATCH v1] 0/8] *** SUBJECT HERE ***

[David Marchand]

Hello Wenbo,

On Tue, Aug 1, 2023 at 9:21 AM Wenbo Cao  wrote:
>
> *** BLURB HERE ***

I think you hit the "send" button too early, adding a new net driver
deserves a better cover letter :-).
Please provide some high level description of this driver features and
the nic details/capabilities.

Also, don't forget to Cc: net maintainers, like Ferruh and Andrew.


-- 
David Marchand

回复：Re: [[PATCH v1] 0/8] *** SUBJECT HERE ***

[曹文博]

Hi David,


Thanks for your advice, as you can see this is first time that send the patch 
:(.

For nic feature/cap, what is the right thing that i need to do ?
Describe on the cover letter or that on 
the doc/guides/nics/features/rnp.ini.


regards Wenbo



 --回复的邮件信息--
   David Marchand

[PATCH] security: hide security context

[Akhil Goyal]

rte_security_ctx is used by all security APIs to identify
which device security_op it need to call and hence it should
be opaque to the application.
Hence, it is now moved to internal header file and all
APIs will now take an opaque pointer for it.
The fast path inline APIs like set metadata need to get flags
from security_ctx. The flags are now retrieved using inline APIs
which use macros to get the offset of flags in security_ctx.

Signed-off-by: Akhil Goyal 
---
 app/test-crypto-perf/cperf_ops.c  |  9 +--
 app/test-crypto-perf/cperf_test_latency.c |  3 +-
 .../cperf_test_pmd_cyclecount.c   |  8 +-
 app/test-crypto-perf/cperf_test_throughput.c  |  9 +--
 app/test-crypto-perf/cperf_test_verify.c  |  4 +-
 app/test-security-perf/test_security_perf.c   |  2 +-
 app/test/test_cryptodev.c | 22 ++
 app/test/test_cryptodev_security_ipsec.c  |  2 +-
 app/test/test_cryptodev_security_ipsec.h  |  2 +-
 app/test/test_security_inline_macsec.c| 10 +--
 app/test/test_security_inline_proto.c | 14 ++--
 examples/ipsec-secgw/ipsec-secgw.c|  2 +-
 examples/ipsec-secgw/ipsec.c  | 15 ++--
 examples/ipsec-secgw/ipsec.h  |  2 +-
 examples/ipsec-secgw/ipsec_worker.c   |  2 +-
 examples/ipsec-secgw/ipsec_worker.h   |  4 +-
 examples/l2fwd-macsec/main.c  |  2 +-
 lib/security/rte_security.c   | 57 --
 lib/security/rte_security.h   | 77 +--
 lib/security/rte_security_driver.h| 24 ++
 20 files changed, 139 insertions(+), 131 deletions(-)

diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cperf_ops.c
index 93b9bfb240..84945d1313 100644
--- a/app/test-crypto-perf/cperf_ops.c
+++ b/app/test-crypto-perf/cperf_ops.c
@@ -749,8 +749,7 @@ create_ipsec_session(struct rte_mempool *sess_mp,
else
sess_conf.ipsec.direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS;
 
-   struct rte_security_ctx *ctx = (struct rte_security_ctx *)
-   rte_cryptodev_get_sec_ctx(dev_id);
+   void *ctx = rte_cryptodev_get_sec_ctx(dev_id);
 
/* Create security session */
return (void *)rte_security_session_create(ctx, &sess_conf, sess_mp);
@@ -853,8 +852,7 @@ cperf_create_session(struct rte_mempool *sess_mp,
.crypto_xform = &cipher_xform
};
 
-   struct rte_security_ctx *ctx = (struct rte_security_ctx *)
-   rte_cryptodev_get_sec_ctx(dev_id);
+   void *ctx = rte_cryptodev_get_sec_ctx(dev_id);
 
/* Create security session */
return (void *)rte_security_session_create(ctx, &sess_conf, 
sess_mp);
@@ -901,8 +899,7 @@ cperf_create_session(struct rte_mempool *sess_mp,
} },
.crypto_xform = &cipher_xform
};
-   struct rte_security_ctx *ctx = (struct rte_security_ctx *)
-   rte_cryptodev_get_sec_ctx(dev_id);
+   void *ctx = rte_cryptodev_get_sec_ctx(dev_id);
 
/* Create security session */
return (void *)rte_security_session_create(ctx, &sess_conf, 
sess_mp);
diff --git a/app/test-crypto-perf/cperf_test_latency.c 
b/app/test-crypto-perf/cperf_test_latency.c
index f1676a9aa9..484bc9eb4e 100644
--- a/app/test-crypto-perf/cperf_test_latency.c
+++ b/app/test-crypto-perf/cperf_test_latency.c
@@ -53,8 +53,7 @@ cperf_latency_test_free(struct cperf_latency_ctx *ctx)
else if (ctx->options->op_type == CPERF_PDCP ||
 ctx->options->op_type == CPERF_DOCSIS ||
 ctx->options->op_type == CPERF_IPSEC) {
-   struct rte_security_ctx *sec_ctx =
-   rte_cryptodev_get_sec_ctx(ctx->dev_id);
+   void *sec_ctx = rte_cryptodev_get_sec_ctx(ctx->dev_id);
rte_security_session_destroy(sec_ctx, ctx->sess);
}
 #endif
diff --git a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c 
b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c
index 0307e82996..4a60f6d558 100644
--- a/app/test-crypto-perf/cperf_test_pmd_cyclecount.c
+++ b/app/test-crypto-perf/cperf_test_pmd_cyclecount.c
@@ -67,11 +67,9 @@ cperf_pmd_cyclecount_test_free(struct 
cperf_pmd_cyclecount_ctx *ctx)
 #ifdef RTE_LIB_SECURITY
if (ctx->options->op_type == CPERF_PDCP ||
ctx->options->op_type == CPERF_DOCSIS) {
-   struct rte_security_ctx *sec_ctx =
-   (struct rte_security_ctx *)
-   rte_cryptodev_get_sec_ctx(ctx->dev_id);
-   rte_security_session_destroy(sec_ctx,
-   (void *)ctx->sess);
+   void

Re: [PATCH v4 2/9] event/dlb2: skip configuration if no eventdev lib

[David Marchand]

Hello Bruce,

On Tue, Jul 18, 2023 at 11:10 AM Bruce Richardson
 wrote:
>
> On Thu, Jun 29, 2023 at 11:39:53AM +0200, David Marchand wrote:
> > On Wed, Jun 28, 2023 at 12:19 PM David Marchand
> >  wrote:
> > >
> > > On Fri, Jun 23, 2023 at 5:07 PM Bruce Richardson
> > >  wrote:
> > > >
> > > > While the build system will skip building most libs and drivers when a
> > > > dependency is missing for a component, for DLB2 driver, the
> > > > "static_rte_eventdev" object is referenced inside the meson.build file
> > > > itself, which will cause crashes if it doesn't exist i.e. if eventdev is
> > > > disabled. Prevent this issue by skipping processing the file if no
> > > > eventdev. [The build system will still report missing dependency, as the
> > > > dependency is set by default for all eventdev drivers]
> > > >
> > > > Signed-off-by: Bruce Richardson 
> > >
> > > Could we evaluate the class "std_deps" before jumping to each driver
> > > meson.build?
> >
> > Hum, with my suggestion, we lose the opportunity for drivers to
> > rewrite completely their "deps".
> > I doubt we have cases where it really matters, but if this revealed to
> > be necessary, such driver may be directly referenced in
> > drivers/meson.build like we do for common/cnxk & friends.
> >
> > To illustrate the idea, I pushed your series along patches of mine
> > (target is v23.11) in my github repo.
> > https://github.com/david-marchand/dpdk/commit/enable_libs~8
> >
> I don't think we should need to worry too much about the case of a driver
> needing to rewrite deps. The standard deps should really just be the
> minimal deps for a class.
>
> However, for the implementation of that check, I'm not sure I like the
> approach of checking std_deps in a loop for each driver. Firstly, the logic
> inside the per-driver block is already pretty complicated, but secondly, I
> think we can skip that loop entirely if the standard deps for a class are
> not met. I think instead it would be better to process std_deps value once
> immediately after the "subdir(class)" line, and if not all deps are
> present, just loop through all the driver directories for that class
> immediately and mark them as unbuildable, before just moving on to the next
> class.

Skipping this loop makes the change smaller and the logic in
drivers/meson.build easier to understand.
We lose the exhaustive summary for disabled content (before, every
disabled driver was logged with the associated reason), but we can
still log the reason why a class is disabled.

Your suggestion looks good to me, let me send a patch.


-- 
David Marchand

[PATCH 1/1] node: remove MAX macro from all nodes

[Rakesh Kudurumalla]

Removed MAX macro from all graph nodes to extend
edges to nodes at ease

Signed-off-by: Rakesh Kudurumalla 
---

v2: Update changes to TOT and resolve 
dependecy related issues

 lib/node/ip4_lookup.c   | 2 +-
 lib/node/ip6_lookup.c   | 2 +-
 lib/node/rte_node_ip4_api.h | 2 --
 lib/node/rte_node_ip6_api.h | 2 --
 4 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c
index 8bce03d7db..72fd760512 100644
--- a/lib/node/ip4_lookup.c
+++ b/lib/node/ip4_lookup.c
@@ -225,7 +225,7 @@ static struct rte_node_register ip4_lookup_node = {
 
.init = ip4_lookup_node_init,
 
-   .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_MAX,
+   .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP + 1,
.next_nodes = {
[RTE_NODE_IP4_LOOKUP_NEXT_REWRITE] = "ip4_rewrite",
[RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c
index 646e466551..6f56eb5ec5 100644
--- a/lib/node/ip6_lookup.c
+++ b/lib/node/ip6_lookup.c
@@ -362,7 +362,7 @@ static struct rte_node_register ip6_lookup_node = {
 
.init = ip6_lookup_node_init,
 
-   .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_MAX,
+   .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP + 1,
.next_nodes = {
[RTE_NODE_IP6_LOOKUP_NEXT_REWRITE] = "ip6_rewrite",
[RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
diff --git a/lib/node/rte_node_ip4_api.h b/lib/node/rte_node_ip4_api.h
index 3397da0ae8..0f997761b6 100644
--- a/lib/node/rte_node_ip4_api.h
+++ b/lib/node/rte_node_ip4_api.h
@@ -29,8 +29,6 @@ enum rte_node_ip4_lookup_next {
RTE_NODE_IP4_LOOKUP_NEXT_REWRITE,
/**< Rewrite node. */
RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP,
-   /**< Packet drop node. */
-   RTE_NODE_IP4_LOOKUP_NEXT_MAX,
/**< Number of next nodes of lookup node. */
 };
 
diff --git a/lib/node/rte_node_ip6_api.h b/lib/node/rte_node_ip6_api.h
index f3b5a1002a..a538dc2ea7 100644
--- a/lib/node/rte_node_ip6_api.h
+++ b/lib/node/rte_node_ip6_api.h
@@ -30,8 +30,6 @@ enum rte_node_ip6_lookup_next {
/**< Rewrite node. */
RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP,
/**< Packet drop node. */
-   RTE_NODE_IP6_LOOKUP_NEXT_MAX,
-   /**< Number of next nodes of lookup node. */
 };
 
 /**
-- 
2.25.1

[PATCH] build: check drivers class dependencies early

[David Marchand]

Drivers implementing a class of devices (for example, drivers/event)
depend on the associated abstraction library (lib/eventdev).
This dependency is expressed in the top level meson.build for this class
(drivers/event/meson.build).

As we are making more libraries optional, custom constructs referencing
the class dependencies in some drivers meson.build (event/dlb2) may break.

It would be possible to add more checks in those drivers meson.build but
it is more straightforward to not even consider a driver meson.build when
the class dependencies are not met.

Signed-off-by: David Marchand 
---
 drivers/meson.build | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/drivers/meson.build b/drivers/meson.build
index 74ae8cb96b..c375352e77 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -70,6 +70,17 @@ foreach subpath:subdirs
 else
 class = subpath
 subdir(class)
+skip_class = false
+foreach d:std_deps
+if not is_variable('shared_rte_' + d)
+skip_class = true
+message('Disabling all @1@ drivers: missing internal 
dependency "@0@"'
+.format(d, class))
+endif
+endforeach
+if skip_class
+continue
+endif
 endif
 
 # save class name on first occurrence
-- 
2.41.0

Re: Re: [[PATCH v1] 0/8] *** SUBJECT HERE ***

[David Marchand]

On Tue, Aug 1, 2023 at 10:09 AM 曹文博  wrote:
> Thanks for your advice, as you can see this is first time that send the patch 
> :(.

No problem, everyone had to learn how to do this in the past.

There is an issue with threading the patches together.
You should read the contributors guide and check your git send-email
configuration.
https://doc.dpdk.org/guides/contributing/patches.html

Especially:
https://doc.dpdk.org/guides/contributing/patches.html#sending-patches

> For nic feature/cap, what is the right thing that i need to do ?
> Describe on the cover letter or that on the doc/guides/nics/features/rnp.ini.

For the cover letter content, git format-patch provided you an empty
-XXX file that you must fill with a title and a summary of what
this series does.
In your case here, I am just requesting a description of what this nic
is (like its name and a list of supported hardwares if you have many)
and what the driver added with this series support (like rx / tx,
stats ...).
Maybe Ferruh has more requests, but it is a good start.


-- 
David Marchand

Re: [PATCH v4 2/9] event/dlb2: skip configuration if no eventdev lib

[Bruce Richardson]

On Tue, Aug 01, 2023 at 10:36:30AM +0200, David Marchand wrote:
> Hello Bruce,
> 
> On Tue, Jul 18, 2023 at 11:10 AM Bruce Richardson
>  wrote:
> >
> > On Thu, Jun 29, 2023 at 11:39:53AM +0200, David Marchand wrote:
> > > On Wed, Jun 28, 2023 at 12:19 PM David Marchand
> > >  wrote:
> > > >
> > > > On Fri, Jun 23, 2023 at 5:07 PM Bruce Richardson
> > > >  wrote:
> > > > >
> > > > > While the build system will skip building most libs and drivers when a
> > > > > dependency is missing for a component, for DLB2 driver, the
> > > > > "static_rte_eventdev" object is referenced inside the meson.build file
> > > > > itself, which will cause crashes if it doesn't exist i.e. if eventdev 
> > > > > is
> > > > > disabled. Prevent this issue by skipping processing the file if no
> > > > > eventdev. [The build system will still report missing dependency, as 
> > > > > the
> > > > > dependency is set by default for all eventdev drivers]
> > > > >
> > > > > Signed-off-by: Bruce Richardson 
> > > >
> > > > Could we evaluate the class "std_deps" before jumping to each driver
> > > > meson.build?
> > >
> > > Hum, with my suggestion, we lose the opportunity for drivers to
> > > rewrite completely their "deps".
> > > I doubt we have cases where it really matters, but if this revealed to
> > > be necessary, such driver may be directly referenced in
> > > drivers/meson.build like we do for common/cnxk & friends.
> > >
> > > To illustrate the idea, I pushed your series along patches of mine
> > > (target is v23.11) in my github repo.
> > > https://github.com/david-marchand/dpdk/commit/enable_libs~8
> > >
> > I don't think we should need to worry too much about the case of a driver
> > needing to rewrite deps. The standard deps should really just be the
> > minimal deps for a class.
> >
> > However, for the implementation of that check, I'm not sure I like the
> > approach of checking std_deps in a loop for each driver. Firstly, the logic
> > inside the per-driver block is already pretty complicated, but secondly, I
> > think we can skip that loop entirely if the standard deps for a class are
> > not met. I think instead it would be better to process std_deps value once
> > immediately after the "subdir(class)" line, and if not all deps are
> > present, just loop through all the driver directories for that class
> > immediately and mark them as unbuildable, before just moving on to the next
> > class.
> 
> Skipping this loop makes the change smaller and the logic in
> drivers/meson.build easier to understand.
> We lose the exhaustive summary for disabled content (before, every
> disabled driver was logged with the associated reason), but we can
> still log the reason why a class is disabled.
> 

When we "subdir" into the driver class directory to get the standard
dependencies, we also get the list of drivers of that class. We can then
loop through those drivers to individually mark them as disabled for the
summary. It would be a fairly small loop, and would keep things consistent
with what we have now.

On the other hand, having a single line for a whole class of drivers may
make the summary more useful!

/Bruce

Re: [PATCH v3] build: update DPDK to use C11 standard

[Bruce Richardson]

On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote:
>Hi Bruce,
>I see some failures for this series for our Ubuntu 20.04 containers.
>And, our DTS testbeds which are on ubuntu 20.04 are skipping running
>testsuites because they can't compile DPDK. So, that's why it has some
>missing results for a couple of the Intel NICs. For context, I'll paste
>below where the compile job terminates in one of our containerized
>compile test runs. The GCC in use here is version 9.4, so it meets the
>requirements as described in your patch as far as I can tell. I'll
>check it out more tomorrow to see whether it's an infra failure, like
>some missing dependencies. Please let me know if we expect to have no
>issues with 20.04 or if this is anticipated.
>Thanks!

While not anticipated, this is why we have CI so these range of distros can
all be checked. There are a lot of failure reports from Ubuntu 20.04 so I
think this is a genuine issue. I will fire up a 20.04 VM myself and see
what I can find, and submit a new patch revision.

/Bruce

Re: [PATCH] build: check drivers class dependencies early

[Bruce Richardson]

On Tue, Aug 01, 2023 at 10:52:53AM +0200, David Marchand wrote:
> Drivers implementing a class of devices (for example, drivers/event)
> depend on the associated abstraction library (lib/eventdev).
> This dependency is expressed in the top level meson.build for this class
> (drivers/event/meson.build).
> 
> As we are making more libraries optional, custom constructs referencing
> the class dependencies in some drivers meson.build (event/dlb2) may break.
> 
> It would be possible to add more checks in those drivers meson.build but
> it is more straightforward to not even consider a driver meson.build when
> the class dependencies are not met.
> 
> Signed-off-by: David Marchand 
> ---
>  drivers/meson.build | 11 +++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/meson.build b/drivers/meson.build
> index 74ae8cb96b..c375352e77 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -70,6 +70,17 @@ foreach subpath:subdirs
>  else
>  class = subpath
>  subdir(class)
> +skip_class = false
> +foreach d:std_deps
> +if not is_variable('shared_rte_' + d)
> +skip_class = true
> +message('Disabling all @1@ drivers: missing internal 
> dependency "@0@"'
> +.format(d, class))
> +endif
> +endforeach
> +if skip_class
> +continue
> +endif
>  endif
>  
>  # save class name on first occurrence

I like this approach. However, we do need something in the summary at the
end of the build too. Either:

* Single message stating all drivers of a given class are skipped
* (as now), message for each driver stating that it has been disabled

The former is nice as it gives us a shorter summary. The latter is nice
because it's consistent with what we have now.  Authors choice, which to go
for! :-)

Thanks.
/Bruce

[RFC] eventdev/eth_rx: update adapter create APIs

[Naga Harish K S V]

The adapter create APIs such as rte_event_eth_rx_adapter_create_ext() and
rte_event_eth_rx_adapter_create() are updated to take additional argument
as a pointer of type struct rte_event_eth_rx_adapter_params.

The API rte_event_eth_rx_adapter_create_with_params() is
deprecated.

Signed-off-by: Naga Harish K S V 
---
 app/test-eventdev/test_perf_common.c  |  2 +-
 app/test-eventdev/test_pipeline_common.c  |  2 +-
 app/test/test_event_eth_rx_adapter.c  | 22 ++---
 app/test/test_security_inline_proto.c |  2 +-
 .../pipeline_worker_generic.c |  2 +-
 .../eventdev_pipeline/pipeline_worker_tx.c|  2 +-
 examples/ipsec-secgw/event_helper.c   |  2 +-
 examples/l2fwd-event/l2fwd_event_generic.c|  2 +-
 .../l2fwd-event/l2fwd_event_internal_port.c   |  2 +-
 examples/l3fwd/l3fwd_event_generic.c  |  2 +-
 examples/l3fwd/l3fwd_event_internal_port.c|  2 +-
 lib/eventdev/rte_event_eth_rx_adapter.c   | 96 ---
 lib/eventdev/rte_event_eth_rx_adapter.h   | 34 +--
 lib/eventdev/version.map  |  1 -
 14 files changed, 67 insertions(+), 106 deletions(-)

diff --git a/app/test-eventdev/test_perf_common.c 
b/app/test-eventdev/test_perf_common.c
index 5e0255cfeb..0c6c252f7d 100644
--- a/app/test-eventdev/test_perf_common.c
+++ b/app/test-eventdev/test_perf_common.c
@@ -1002,7 +1002,7 @@ perf_event_rx_adapter_setup(struct evt_options *opt, 
uint8_t stride,
}
queue_conf.ev.queue_id = prod * stride;
ret = rte_event_eth_rx_adapter_create(prod, opt->dev_id,
-   &prod_conf);
+   &prod_conf, NULL);
if (ret) {
evt_err("failed to create rx adapter[%d]", prod);
return ret;
diff --git a/app/test-eventdev/test_pipeline_common.c 
b/app/test-eventdev/test_pipeline_common.c
index b111690b7c..5ae175f2c7 100644
--- a/app/test-eventdev/test_pipeline_common.c
+++ b/app/test-eventdev/test_pipeline_common.c
@@ -571,7 +571,7 @@ pipeline_event_rx_adapter_setup(struct evt_options *opt, 
uint8_t stride,
}
queue_conf.ev.queue_id = prod * stride;
ret = rte_event_eth_rx_adapter_create(prod, opt->dev_id,
-   &prod_conf);
+   &prod_conf, NULL);
if (ret) {
evt_err("failed to create rx adapter[%d]", prod);
return ret;
diff --git a/app/test/test_event_eth_rx_adapter.c 
b/app/test/test_event_eth_rx_adapter.c
index 52d146f97c..42edcb625a 100644
--- a/app/test/test_event_eth_rx_adapter.c
+++ b/app/test/test_event_eth_rx_adapter.c
@@ -401,7 +401,7 @@ adapter_create(void)
rx_p_conf.dequeue_depth = dev_info.max_event_port_dequeue_depth;
rx_p_conf.enqueue_depth = dev_info.max_event_port_enqueue_depth;
err = rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID,
-   &rx_p_conf);
+   &rx_p_conf, NULL);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
 
return err;
@@ -427,17 +427,17 @@ adapter_create_with_params(void)
rxa_params.use_queue_event_buf = false;
rxa_params.event_buf_size = 0;
 
-   err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
+   err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
TEST_DEV_ID, &rx_p_conf, &rxa_params);
TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
 
rxa_params.use_queue_event_buf = true;
 
-   err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
+   err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
TEST_DEV_ID, &rx_p_conf, &rxa_params);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
 
-   err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
+   err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
TEST_DEV_ID, &rx_p_conf, &rxa_params);
TEST_ASSERT(err == -EEXIST, "Expected -EEXIST got %d", err);
 
@@ -567,15 +567,15 @@ adapter_create_free(void)
};
 
err = rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID,
-   NULL);
+   NULL, NULL);
TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
 
err = rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID,
-   &rx_p_conf);
+   &rx_p_conf, NULL);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
 
err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
-   TEST_DEV_ID, &rx_p_conf);
+   TEST_DEV_ID, &rx_p_conf, NULL);
TEST_ASSERT(err == -EEXIS

[RFC] Rx adapter create API changes

[Naga Harish K, S V]

Hi all,

The API "rte_event_eth_rx_adapter_create_with_params()" is an extension to 
rte_event_eth_rx_adapter_create() with additional adapter configuration params 
structure.
There is no equivalent API existing today for 
"rte_event_eth_rx_adapter_create_ext()" API. We may need to have one more 
adapter create API for this.
That makes so many Adapter create APIs and will be confusing for the user.

   I am proposing the following changes to the Rx adapter create APIs which 
will consolidate the create APIs to 2 in number with all possible combinations.

Current RX Adapter create APIs
Proposed changes
 int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,
rte_event_eth_rx_adapter_conf_cb conf_cb,
void *conf_arg)
 int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,
  rte_event_eth_rx_adapter_conf_cb conf_cb,
  void *conf_arg,
  struct rte_event_eth_rx_adapter_params *rxa_params)
 int rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id,
struct rte_event_port_conf *port_config)
 int rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id,
   struct rte_event_port_conf *port_config,
   struct rte_event_eth_rx_adapter_params *rxa_params)
 int rte_event_eth_rx_adapter_create_with_params(uint8_t id, uint8_t dev_id,
struct rte_event_port_conf *port_config,
struct rte_event_eth_rx_adapter_params *rxa_params)
 Will be deprecated.

The applications that are currently using rte_event_eth_rx_adapter_create_ext() 
or rte_event_eth_rx_adapter_create() APIs for creating Rx adapter can pass NULL 
argument for the
Newly added argument which will behave same as before.

Let me know your comments for this change.

Patchwork link:
https://patches.dpdk.org/project/dpdk/patch/20230801094004.51939-1-s.v.naga.haris...@intel.com/

-Harish

Re: [PATCH v3] build: update DPDK to use C11 standard

[Bruce Richardson]

On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote:
>Hi Bruce,
>I see some failures for this series for our Ubuntu 20.04 containers.
>And, our DTS testbeds which are on ubuntu 20.04 are skipping running
>testsuites because they can't compile DPDK. So, that's why it has some
>missing results for a couple of the Intel NICs. For context, I'll paste
>below where the compile job terminates in one of our containerized
>compile test runs. The GCC in use here is version 9.4, so it meets the
>requirements as described in your patch as far as I can tell. I'll
>check it out more tomorrow to see whether it's an infra failure, like
>some missing dependencies. Please let me know if we expect to have no
>issues with 20.04 or if this is anticipated.
>Thanks!
>[1638/2730] Generating symbol file
>'drivers/a715181@@rte_net_ixgbe@sha/librte_net_ixgbe.so.24.0.symbols'.
>[1639/2730] Compiling C object
>'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o'.
>FAILED: drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o
>ccache cc -Idrivers/a715181@@tmp_rte_net_mlx4@sta -Idrivers
>-I../drivers -Idrivers/net/mlx4 -I../drivers/net/mlx4 -Ilib/ethdev
>-I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include
>-I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include
>-Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common
>-I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs
>-Ilib/telemetry/../metrics -I../lib/telemetry/../metrics
>-Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf
>-I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring
>-Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci
>-I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev
>-I../drivers/bus/vdev -I/usr/include/libnl3 -fdiagnostics-color=always
>-pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror
>-std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat
>-Wformat-nonliteral -Wformat-security -Wmissing-declarations
>-Wmissing-prototypes -Wnested-externs -Wold-style-definition
>-Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef
>-Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned
>-Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native
>-DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation
>-std=c11 -Wno-strict-prototypes -D_BSD_SOURCE -D_DEFAULT_SOURCE
>-D_XOPEN_SOURCE=600 -UPEDANTIC -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.mlx4
>-MD -MQ 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -MF
>'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o.d' -o
>'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -c
>../drivers/net/mlx4/mlx4.c
>In file included from ../drivers/net/mlx4/mlx4_rxtx.h:27,
> from ../drivers/net/mlx4/mlx4.c:49:
>../drivers/net/mlx4/mlx4_prm.h:111:8: error: redefinition of 'struct
>mlx4_wqe_lso_seg'
>  111 | struct mlx4_wqe_lso_seg {
>  |^~~~
>In file included from ../drivers/net/mlx4/mlx4_glue.h:16,
> from ../drivers/net/mlx4/mlx4.c:46:
>/usr/include/infiniband/mlx4dv.h:410:8: note: originally defined here
>  410 | struct mlx4_wqe_lso_seg {
>  |^~~~
>ninja: build stopped: subcommand failed.

Hi again,

I've attempted to reproduce this on my Ubuntu 20.04 VM and failed,
everything seems to build ok.

Looking through the logs, though, there does appear to be a difference in
the configurations in the two cases. I suspect my Ubuntu has an updated
verbs package compared to the image you are using. In the log of the failed
build, I see:

Checking whether type "struct mlx4_wqe_lso_seg" has member 
"mss_hdr_size" with dependencies libmlx4, libibverbs: NO 
Configuring mlx4_autoconf.h using configuration

While building in my VM, I have:

Checking whether type "struct mlx4_wqe_lso_seg" has member 
"mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached)
Configuring mlx4_autoconf.h using configuration

So my verbs mlx4 header has got a different set of definitions to those in
the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev package
version "28.0-1ubuntu1"

Can the CI image be updated to latest 20.04 packages?

/Bruce

Re: [PATCH] build: check drivers class dependencies early

[David Marchand]

On Tue, Aug 1, 2023 at 11:25 AM Bruce Richardson
 wrote:
>
> On Tue, Aug 01, 2023 at 10:52:53AM +0200, David Marchand wrote:
> > Drivers implementing a class of devices (for example, drivers/event)
> > depend on the associated abstraction library (lib/eventdev).
> > This dependency is expressed in the top level meson.build for this class
> > (drivers/event/meson.build).
> >
> > As we are making more libraries optional, custom constructs referencing
> > the class dependencies in some drivers meson.build (event/dlb2) may break.
> >
> > It would be possible to add more checks in those drivers meson.build but
> > it is more straightforward to not even consider a driver meson.build when
> > the class dependencies are not met.
> >
> > Signed-off-by: David Marchand 
> > ---
> >  drivers/meson.build | 11 +++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/meson.build b/drivers/meson.build
> > index 74ae8cb96b..c375352e77 100644
> > --- a/drivers/meson.build
> > +++ b/drivers/meson.build
> > @@ -70,6 +70,17 @@ foreach subpath:subdirs
> >  else
> >  class = subpath
> >  subdir(class)
> > +skip_class = false
> > +foreach d:std_deps
> > +if not is_variable('shared_rte_' + d)
> > +skip_class = true
> > +message('Disabling all @1@ drivers: missing internal 
> > dependency "@0@"'
> > +.format(d, class))
> > +endif
> > +endforeach
> > +if skip_class
> > +continue
> > +endif
> >  endif
> >
> >  # save class name on first occurrence
>
> I like this approach. However, we do need something in the summary at the
> end of the build too. Either:
>
> * Single message stating all drivers of a given class are skipped
> * (as now), message for each driver stating that it has been disabled
>
> The former is nice as it gives us a shorter summary. The latter is nice
> because it's consistent with what we have now.  Authors choice, which to go
> for! :-)

I like the shorter summary.
WDYT of:

diff --git a/drivers/meson.build b/drivers/meson.build
index c375352e77..02268918e4 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -74,11 +74,18 @@ foreach subpath:subdirs
 foreach d:std_deps
 if not is_variable('shared_rte_' + d)
 skip_class = true
-message('Disabling all @1@ drivers: missing internal
dependency "@0@"'
+reason = 'missing internal dependency, "@0@"'.format(d)
+if dpdk_libs_deprecated.contains(d)
+reason += ' (deprecated lib)'
+endif
+message('Disabling @1@/* drivers: missing internal
dependency "@0@"'
 .format(d, class))
 endif
 endforeach
 if skip_class
+drv_path = join_paths(class, '*')
+dpdk_drvs_disabled += drv_path
+set_variable(drv_path.underscorify() + '_disable_reason', reason)
 continue
 endif
 endif


This gives the following output (testing on top of your series
extending optional libs and a fix on the new reasm perf test).
https://github.com/david-marchand/dpdk/actions/runs/5725429526/job/15513923381#step:19:346

...
=
Content Skipped
=
...
drivers:
...
mempool/dpaa2: not in enabled drivers build config
mempool/octeontx: not in enabled drivers build config
mempool/stack: not in enabled drivers build config
dma/*: missing internal dependency, "dmadev"
net/af_packet: not in enabled drivers build config
net/af_xdp: not in enabled drivers build config
net/ark: not in enabled drivers build config
...


-- 
David Marchand

Threads using mempools

[Dumitrescu, Cristian]

Hi folks,

Is there a way in DPDK to create a POSIX thread in the driver/app and hook it 
up to an existing mempool by creating a mempool cache on the fly for this 
thread?

The regular RTE lcores and service cores seem to be the only threads that have 
access to mempools, is my observation correct? This would prevent (on purpose?) 
the drivers/apps to create threads that can be directly involved in processing 
packets.

Thanks,
Cristian

Re: [RFC] eventdev/eth_rx: update adapter create APIs

[Jerin Jacob]

On Tue, Aug 1, 2023 at 3:10 PM Naga Harish K S V
 wrote:
>
> The adapter create APIs such as rte_event_eth_rx_adapter_create_ext() and
> rte_event_eth_rx_adapter_create() are updated to take additional argument
> as a pointer of type struct rte_event_eth_rx_adapter_params.

Please avod API prototype changes . It will be pain for application
which needs to manage both. IMO, It is not worth it.



>
> The API rte_event_eth_rx_adapter_create_with_params() is
> deprecated.
>
> Signed-off-by: Naga Harish K S V 
> ---
>  app/test-eventdev/test_perf_common.c  |  2 +-
>  app/test-eventdev/test_pipeline_common.c  |  2 +-
>  app/test/test_event_eth_rx_adapter.c  | 22 ++---
>  app/test/test_security_inline_proto.c |  2 +-
>  .../pipeline_worker_generic.c |  2 +-
>  .../eventdev_pipeline/pipeline_worker_tx.c|  2 +-
>  examples/ipsec-secgw/event_helper.c   |  2 +-
>  examples/l2fwd-event/l2fwd_event_generic.c|  2 +-
>  .../l2fwd-event/l2fwd_event_internal_port.c   |  2 +-
>  examples/l3fwd/l3fwd_event_generic.c  |  2 +-
>  examples/l3fwd/l3fwd_event_internal_port.c|  2 +-
>  lib/eventdev/rte_event_eth_rx_adapter.c   | 96 ---
>  lib/eventdev/rte_event_eth_rx_adapter.h   | 34 +--
>  lib/eventdev/version.map  |  1 -
>  14 files changed, 67 insertions(+), 106 deletions(-)
>
> diff --git a/app/test-eventdev/test_perf_common.c 
> b/app/test-eventdev/test_perf_common.c
> index 5e0255cfeb..0c6c252f7d 100644
> --- a/app/test-eventdev/test_perf_common.c
> +++ b/app/test-eventdev/test_perf_common.c
> @@ -1002,7 +1002,7 @@ perf_event_rx_adapter_setup(struct evt_options *opt, 
> uint8_t stride,
> }
> queue_conf.ev.queue_id = prod * stride;
> ret = rte_event_eth_rx_adapter_create(prod, opt->dev_id,
> -   &prod_conf);
> +   &prod_conf, NULL);
> if (ret) {
> evt_err("failed to create rx adapter[%d]", prod);
> return ret;
> diff --git a/app/test-eventdev/test_pipeline_common.c 
> b/app/test-eventdev/test_pipeline_common.c
> index b111690b7c..5ae175f2c7 100644
> --- a/app/test-eventdev/test_pipeline_common.c
> +++ b/app/test-eventdev/test_pipeline_common.c
> @@ -571,7 +571,7 @@ pipeline_event_rx_adapter_setup(struct evt_options *opt, 
> uint8_t stride,
> }
> queue_conf.ev.queue_id = prod * stride;
> ret = rte_event_eth_rx_adapter_create(prod, opt->dev_id,
> -   &prod_conf);
> +   &prod_conf, NULL);
> if (ret) {
> evt_err("failed to create rx adapter[%d]", prod);
> return ret;
> diff --git a/app/test/test_event_eth_rx_adapter.c 
> b/app/test/test_event_eth_rx_adapter.c
> index 52d146f97c..42edcb625a 100644
> --- a/app/test/test_event_eth_rx_adapter.c
> +++ b/app/test/test_event_eth_rx_adapter.c
> @@ -401,7 +401,7 @@ adapter_create(void)
> rx_p_conf.dequeue_depth = dev_info.max_event_port_dequeue_depth;
> rx_p_conf.enqueue_depth = dev_info.max_event_port_enqueue_depth;
> err = rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID,
> -   &rx_p_conf);
> +   &rx_p_conf, NULL);
> TEST_ASSERT(err == 0, "Expected 0 got %d", err);
>
> return err;
> @@ -427,17 +427,17 @@ adapter_create_with_params(void)
> rxa_params.use_queue_event_buf = false;
> rxa_params.event_buf_size = 0;
>
> -   err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
> +   err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
> TEST_DEV_ID, &rx_p_conf, &rxa_params);
> TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
>
> rxa_params.use_queue_event_buf = true;
>
> -   err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
> +   err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
> TEST_DEV_ID, &rx_p_conf, &rxa_params);
> TEST_ASSERT(err == 0, "Expected 0 got %d", err);
>
> -   err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
> +   err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
> TEST_DEV_ID, &rx_p_conf, &rxa_params);
> TEST_ASSERT(err == -EEXIST, "Expected -EEXIST got %d", err);
>
> @@ -567,15 +567,15 @@ adapter_create_free(void)
> };
>
> err = rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID,
> -   NULL);
> +   NULL, NULL);
> TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
>
> err = rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID,
> -

[[PATCH v1] 0/8] *** SUBJECT HERE ***

[Wenbo Cao]

*** BLURB HERE ***

Wenbo Cao (8):
  net/rnp: add skeleton
  net/rnp: add ethdev probe and remove
  net/rnp: add device init and uninit
  net/rnp: add mbx basic api feature
  net/rnp add reset code for Chip Init process
  net/rnp add port info resource init
  net/rnp add devargs runtime parsing functions
  net/rnp handle device interrupts

 MAINTAINERS |   6 +
 doc/guides/nics/features/rnp.ini|   8 +
 doc/guides/nics/index.rst   |   1 +
 doc/guides/nics/rnp.rst |  43 ++
 drivers/net/meson.build |   1 +
 drivers/net/rnp/base/rnp_api.c  |  71 +++
 drivers/net/rnp/base/rnp_api.h  |  17 +
 drivers/net/rnp/base/rnp_cfg.h  |   7 +
 drivers/net/rnp/base/rnp_dma_regs.h |  73 +++
 drivers/net/rnp/base/rnp_eth_regs.h | 124 +
 drivers/net/rnp/base/rnp_hw.h   | 193 +++
 drivers/net/rnp/base/rnp_mac_regs.h | 279 ++
 drivers/net/rnp/meson.build |  18 +
 drivers/net/rnp/rnp.h   | 217 
 drivers/net/rnp/rnp_ethdev.c| 823 
 drivers/net/rnp/rnp_logs.h  |  43 ++
 drivers/net/rnp/rnp_mbx.c   | 522 ++
 drivers/net/rnp/rnp_mbx.h   | 139 +
 drivers/net/rnp/rnp_mbx_fw.c| 781 ++
 drivers/net/rnp/rnp_mbx_fw.h| 401 ++
 drivers/net/rnp/rnp_osdep.h |  30 +
 drivers/net/rnp/rnp_rxtx.c  |  83 +++
 drivers/net/rnp/rnp_rxtx.h  |  14 +
 23 files changed, 3894 insertions(+)
 create mode 100644 doc/guides/nics/features/rnp.ini
 create mode 100644 doc/guides/nics/rnp.rst
 create mode 100644 drivers/net/rnp/base/rnp_api.c
 create mode 100644 drivers/net/rnp/base/rnp_api.h
 create mode 100644 drivers/net/rnp/base/rnp_cfg.h
 create mode 100644 drivers/net/rnp/base/rnp_dma_regs.h
 create mode 100644 drivers/net/rnp/base/rnp_eth_regs.h
 create mode 100644 drivers/net/rnp/base/rnp_hw.h
 create mode 100644 drivers/net/rnp/base/rnp_mac_regs.h
 create mode 100644 drivers/net/rnp/meson.build
 create mode 100644 drivers/net/rnp/rnp.h
 create mode 100644 drivers/net/rnp/rnp_ethdev.c
 create mode 100644 drivers/net/rnp/rnp_logs.h
 create mode 100644 drivers/net/rnp/rnp_mbx.c
 create mode 100644 drivers/net/rnp/rnp_mbx.h
 create mode 100644 drivers/net/rnp/rnp_mbx_fw.c
 create mode 100644 drivers/net/rnp/rnp_mbx_fw.h
 create mode 100644 drivers/net/rnp/rnp_osdep.h
 create mode 100644 drivers/net/rnp/rnp_rxtx.c
 create mode 100644 drivers/net/rnp/rnp_rxtx.h

-- 
2.27.0

[[PATCH v1] 1/8] net/rnp: add skeleton

[Wenbo Cao]

Add Basic PMD library and doc build infrastructure
Update maintainers file to claim responsibility.

Signed-off-by: Wenbo Cao 
---
 MAINTAINERS  |  6 +
 doc/guides/nics/features/rnp.ini |  8 ++
 doc/guides/nics/index.rst|  1 +
 doc/guides/nics/rnp.rst  | 43 
 drivers/net/meson.build  |  1 +
 drivers/net/rnp/meson.build  | 12 +
 drivers/net/rnp/rnp_ethdev.c |  3 +++
 7 files changed, 74 insertions(+)
 create mode 100644 doc/guides/nics/features/rnp.ini
 create mode 100644 doc/guides/nics/rnp.rst
 create mode 100644 drivers/net/rnp/meson.build
 create mode 100644 drivers/net/rnp/rnp_ethdev.c

diff --git a/MAINTAINERS b/MAINTAINERS
index a5219926ab..36f4867cf8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -955,6 +955,12 @@ F: drivers/net/qede/
 F: doc/guides/nics/qede.rst
 F: doc/guides/nics/features/qede*.ini
 
+Mucse rnp
+M: caowe...@mucse.com
+F: drivers/net/rnp
+F: doc/guides/nics/rnp.rst
+F: doc/guides/nics/features/rnp.ini
+
 Solarflare sfc_efx
 M: Andrew Rybchenko 
 F: drivers/common/sfc_efx/
diff --git a/doc/guides/nics/features/rnp.ini b/doc/guides/nics/features/rnp.ini
new file mode 100644
index 00..2ad04ee330
--- /dev/null
+++ b/doc/guides/nics/features/rnp.ini
@@ -0,0 +1,8 @@
+;
+; Supported features of the 'rnp' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Linux= Y
+x86-64   = Y
diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst
index 5c9d1edf5e..cc89d3154a 100644
--- a/doc/guides/nics/index.rst
+++ b/doc/guides/nics/index.rst
@@ -61,6 +61,7 @@ Network Interface Controller Drivers
 pcap_ring
 pfe
 qede
+rnp
 sfc_efx
 softnic
 tap
diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst
new file mode 100644
index 00..8785972fd9
--- /dev/null
+++ b/doc/guides/nics/rnp.rst
@@ -0,0 +1,43 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2023 Mucse IC Design Ltd.
+
+RNP Poll Mode driver
+==
+
+The RNP ETHDEV PMD (**librte_net_rnp**) provides poll mode ethdev
+driver support for the inbuilt network device found in the **Mucse RNP**
+
+Prerequisites
+-
+More information can be found at `Mucse, Official Website
+`_.
+
+Supported RNP SoCs
+
+
+- N10
+
+Driver compilation and testing
+--
+
+Refer to the document :ref:`compiling and testing a PMD for a NIC 
`
+for details.
+
+#. Running testpmd:
+
+   Follow instructions available in the document
+   :ref:`compiling and testing a PMD for a NIC `
+   to run testpmd.
+
+Limitations or Known issues
+---
+Build with ICC is not supported yet.
+CRC stripping
+
+The RNP SoC family NICs strip the CRC for every packets coming into the
+host interface irrespective of the offload configuration.
+When You Want To Disable CRC_OFFLOAD The Feature Will Influence The RxCksum 
Offload
+VLAN Strip
+~~
+For VLAN Strip RNP Just Support CVLAN(0x8100) Type If The Vlan Type Is 
SVLAN(0X88a8)
+VLAN Filter Or Strip Will Not Effert For This Packet It Will Bypass To The 
Host.
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index b1df17ce8c..8bdbf05857 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -56,6 +56,7 @@ drivers = [
 'ring',
 'sfc',
 'softnic',
+'rnp',
 'tap',
 'thunderx',
 'txgbe',
diff --git a/drivers/net/rnp/meson.build b/drivers/net/rnp/meson.build
new file mode 100644
index 00..0c38d39347
--- /dev/null
+++ b/drivers/net/rnp/meson.build
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(C) 2023 Mucse IC Design Ltd.
+#
+if is_windows
+build = false
+reason = 'not supported on Windows'
+subdir_done()
+endif
+
+sources = files(
+   'rnp_ethdev.c',
+)
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
new file mode 100644
index 00..9ce3c0b497
--- /dev/null
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -0,0 +1,3 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
-- 
2.27.0

[[PATCH v1] 4/8] net/rnp: add mbx basic api feature

[Wenbo Cao]

mbx base code is for communicate with the firmware

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/base/rnp_hw.h | 107 ++-
 drivers/net/rnp/meson.build   |   1 +
 drivers/net/rnp/rnp.h |  35 +++
 drivers/net/rnp/rnp_ethdev.c  |  68 +
 drivers/net/rnp/rnp_logs.h|   9 +
 drivers/net/rnp/rnp_mbx.c | 522 ++
 drivers/net/rnp/rnp_mbx.h | 138 +
 drivers/net/rnp/rnp_mbx_fw.h  |  22 ++
 8 files changed, 901 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/rnp/rnp_mbx.c
 create mode 100644 drivers/net/rnp/rnp_mbx.h
 create mode 100644 drivers/net/rnp/rnp_mbx_fw.h

diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index 543011a64c..da3659bd67 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -4,15 +4,120 @@
 #ifndef __RNP_HW_H__
 #define __RNP_HW_H__
 
+#include 
+#include 
+
+#include "rnp_osdep.h"
+
+static inline unsigned int rnp_rd_reg(volatile void *addr)
+{
+   unsigned int v = rte_read32(addr);
+
+   return v;
+}
+
+static inline void rnp_wr_reg(volatile void *reg, int val)
+{
+   rte_write32_relaxed((val), (reg));
+}
+
+#define mbx_rd32(hw, reg)  rnp_rd_reg((hw)->iobar4 + (reg))
+#define mbx_wr32(hw, reg, val) rnp_wr_reg((hw)->iobar4 + (reg), (val))
+
+struct rnp_hw;
+/* Mbx Operate info */
+enum MBX_ID {
+   MBX_PF = 0,
+   MBX_VF,
+   MBX_CM3CPU,
+   MBX_FW = MBX_CM3CPU,
+   MBX_VFCNT
+};
+struct rnp_mbx_api {
+   void (*init_mbx)(struct rnp_hw *hw);
+   int32_t (*read)(struct rnp_hw *hw,
+   uint32_t *msg,
+   uint16_t size,
+   enum MBX_ID);
+   int32_t (*write)(struct rnp_hw *hw,
+   uint32_t *msg,
+   uint16_t size,
+   enum MBX_ID);
+   int32_t (*read_posted)(struct rte_eth_dev *dev,
+   uint32_t *msg,
+   uint16_t size,
+   enum MBX_ID);
+   int32_t (*write_posted)(struct rte_eth_dev *dev,
+   uint32_t *msg,
+   uint16_t size,
+   enum MBX_ID);
+   int32_t (*check_for_msg)(struct rnp_hw *hw, enum MBX_ID);
+   int32_t (*check_for_ack)(struct rnp_hw *hw, enum MBX_ID);
+   int32_t (*check_for_rst)(struct rnp_hw *hw, enum MBX_ID);
+   int32_t (*configure)(struct rnp_hw *hw, int nr_vec, bool enable);
+};
+
+struct rnp_mbx_stats {
+   u32 msgs_tx;
+   u32 msgs_rx;
+
+   u32 acks;
+   u32 reqs;
+   u32 rsts;
+};
+
+struct rnp_mbx_info {
+   struct rnp_mbx_api ops;
+   uint32_t usec_delay;/* retry interval delay time */
+   uint32_t timeout;   /* retry ops timeout limit */
+   uint16_t size;  /* data buffer size*/
+   uint16_t vf_num;/* Virtual Function num */
+   uint16_t pf_num;/* Physical Function num */
+   uint16_t sriov_st;  /* Sriov state */
+   bool irq_enabled;
+   union {
+   struct {
+   unsigned short pf_req;
+   unsigned short pf_ack;
+   };
+   struct {
+   unsigned short cpu_req;
+   unsigned short cpu_ack;
+   };
+   };
+   unsigned short vf_req[64];
+   unsigned short vf_ack[64];
+
+   struct rnp_mbx_stats stats;
+
+   rte_atomic16_t state;
+} __rte_cache_aligned;
+
+#define RNP_MAX_HW_PORT_PERR_PF (4)
 struct rnp_hw {
void *back;
char *iobar0;
uint32_t iobar0_len;
char *iobar4;
uint32_t iobar4_len;
+   char *link_sync;
+   char *dma_base;
+   char *eth_base;
+   char *veb_base;
+   char *mac_base[RNP_MAX_HW_PORT_PERR_PF];
+   char *msix_base;
+   /* === dma == */
+   char *dma_axi_en;
+   char *dma_axi_st;
 
uint16_t device_id;
uint16_t vendor_id;
-} __rte_cache_aligned;
+   uint16_t function;
+   uint16_t pf_vf_num;
+   uint16_t max_vfs;
+   void *cookie_pool;
+   char cookie_p_name[RTE_MEMZONE_NAMESIZE];
 
+   struct rnp_mbx_info mbx;
+} __rte_cache_aligned;
 #endif /* __RNP_H__*/
diff --git a/drivers/net/rnp/meson.build b/drivers/net/rnp/meson.build
index 36a1f7148d..38dbee5ca4 100644
--- a/drivers/net/rnp/meson.build
+++ b/drivers/net/rnp/meson.build
@@ -9,5 +9,6 @@ endif
 
 sources = files(
'rnp_ethdev.c',
+   'rnp_mbx.c',
 )
 includes += include_directories('base')
diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index ea9d138673..a8999ddc47 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -3,6 +3,7 @@
  */
 #ifndef __RNP_H__
 #define __RNP_H__
+#include 
 
 #include "base/rnp_hw.h"
 
@@ -14,14 +15,17 @@
 
 struct rnp_eth_port {
void *adapt;
+   struct rnp_hw *hw;
struct rte_eth_dev *eth_dev;
 } __rte_cache_aligned;
 
 str

[[PATCH v1] 2/8] net/rnp: add ethdev probe and remove

[Wenbo Cao]

Add basic PCIe ethdev probe and remove.

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp.h| 13 ++
 drivers/net/rnp/rnp_ethdev.c | 83 
 2 files changed, 96 insertions(+)
 create mode 100644 drivers/net/rnp/rnp.h

diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
new file mode 100644
index 00..76d281cc0a
--- /dev/null
+++ b/drivers/net/rnp/rnp.h
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+#ifndef __RNP_H__
+#define __RNP_H__
+
+#define PCI_VENDOR_ID_MUCSE(0x8848)
+#define RNP_DEV_ID_N10G(0x1000)
+
+struct rnp_eth_port {
+} __rte_cache_aligned;
+
+#endif /* __RNP_H__ */
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 9ce3c0b497..5951c2b311 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -1,3 +1,86 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright(C) 2023 Mucse IC Design Ltd.
  */
+
+#include 
+#include 
+#include 
+
+#include "rnp.h"
+
+static int
+rnp_eth_dev_init(struct rte_eth_dev *eth_dev)
+{
+   RTE_SET_USED(eth_dev);
+
+   return -ENODEV;
+}
+
+static int
+rnp_eth_dev_uninit(struct rte_eth_dev *eth_dev)
+{
+   RTE_SET_USED(eth_dev);
+
+   return -ENODEV;
+}
+
+static int
+rnp_pci_remove(struct rte_pci_device *pci_dev)
+{
+   struct rte_eth_dev *eth_dev;
+   int rc;
+
+   eth_dev = rte_eth_dev_allocated(pci_dev->device.name);
+
+   if (eth_dev) {
+   /* Cleanup eth dev */
+   rc = rte_eth_dev_pci_generic_remove(pci_dev,
+   rnp_eth_dev_uninit);
+   if (rc)
+   return rc;
+   }
+   /* Nothing to be done for secondary processes */
+   if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+   return 0;
+
+   return 0;
+}
+
+static int
+rnp_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
+{
+   int rc;
+
+   RTE_SET_USED(pci_drv);
+
+   rc = rte_eth_dev_pci_generic_probe(pci_dev, sizeof(struct rnp_eth_port),
+  rnp_eth_dev_init);
+
+   /* On error on secondary, recheck if port exists in primary or
+* in mid of detach state.
+*/
+   if (rte_eal_process_type() != RTE_PROC_PRIMARY && rc)
+   if (!rte_eth_dev_allocated(pci_dev->device.name))
+   return 0;
+   return rc;
+}
+
+static const struct rte_pci_id pci_id_rnp_map[] = {
+   {
+   RTE_PCI_DEVICE(PCI_VENDOR_ID_MUCSE, RNP_DEV_ID_N10G)
+   },
+   {
+   .vendor_id = 0,
+   },
+};
+
+static struct rte_pci_driver rte_rnp_pmd = {
+   .id_table = pci_id_rnp_map,
+   .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_INTR_LSC,
+   .probe = rnp_pci_probe,
+   .remove = rnp_pci_remove,
+};
+
+RTE_PMD_REGISTER_PCI(net_rnp, rte_rnp_pmd);
+RTE_PMD_REGISTER_PCI_TABLE(net_rnp, pci_id_rnp_map);
+RTE_PMD_REGISTER_KMOD_DEP(net_txgbe, "igb_uio | uio_pci_generic");
-- 
2.27.0

[[PATCH v1] 3/8] net/rnp: add device init and uninit

[Wenbo Cao]

Add basic init and uninit function

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/base/rnp_hw.h |  18 
 drivers/net/rnp/meson.build   |   1 +
 drivers/net/rnp/rnp.h |  25 +
 drivers/net/rnp/rnp_ethdev.c  | 197 +-
 drivers/net/rnp/rnp_logs.h|  34 ++
 drivers/net/rnp/rnp_osdep.h   |  30 ++
 6 files changed, 300 insertions(+), 5 deletions(-)
 create mode 100644 drivers/net/rnp/base/rnp_hw.h
 create mode 100644 drivers/net/rnp/rnp_logs.h
 create mode 100644 drivers/net/rnp/rnp_osdep.h

diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
new file mode 100644
index 00..543011a64c
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -0,0 +1,18 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Mucse IC Design Ltd.
+ */
+#ifndef __RNP_HW_H__
+#define __RNP_HW_H__
+
+struct rnp_hw {
+   void *back;
+   char *iobar0;
+   uint32_t iobar0_len;
+   char *iobar4;
+   uint32_t iobar4_len;
+
+   uint16_t device_id;
+   uint16_t vendor_id;
+} __rte_cache_aligned;
+
+#endif /* __RNP_H__*/
diff --git a/drivers/net/rnp/meson.build b/drivers/net/rnp/meson.build
index 0c38d39347..36a1f7148d 100644
--- a/drivers/net/rnp/meson.build
+++ b/drivers/net/rnp/meson.build
@@ -10,3 +10,4 @@ endif
 sources = files(
'rnp_ethdev.c',
 )
+includes += include_directories('base')
diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index 76d281cc0a..ea9d138673 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -4,10 +4,35 @@
 #ifndef __RNP_H__
 #define __RNP_H__
 
+#include "base/rnp_hw.h"
+
 #define PCI_VENDOR_ID_MUCSE(0x8848)
 #define RNP_DEV_ID_N10G(0x1000)
+#define RNP_MAX_PORT_OF_PF (4)
+#define RNP_CFG_BAR(4)
+#define RNP_PF_INFO_BAR(0)
 
 struct rnp_eth_port {
+   void *adapt;
+   struct rte_eth_dev *eth_dev;
+} __rte_cache_aligned;
+
+struct rnp_share_ops {
 } __rte_cache_aligned;
 
+struct rnp_eth_adapter {
+   struct rnp_hw hw;
+   struct rte_pci_device *pdev;
+   struct rte_eth_dev *eth_dev; /* master eth_dev */
+   struct rnp_eth_port *ports[RNP_MAX_PORT_OF_PF];
+   struct rnp_share_ops *share_priv;
+
+   uint8_t num_ports; /* Cur Pf Has physical Port Num */
+} __rte_cache_aligned;
+
+#define RNP_DEV_TO_PORT(eth_dev) \
+   (((struct rnp_eth_port *)((eth_dev)->data->dev_private)))
+#define RNP_DEV_TO_ADAPTER(eth_dev) \
+   ((struct rnp_eth_adapter *)(RNP_DEV_TO_PORT(eth_dev)->adapt))
+
 #endif /* __RNP_H__ */
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 5951c2b311..18fd169166 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -5,23 +5,199 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "rnp.h"
+#include "rnp_logs.h"
 
 static int
-rnp_eth_dev_init(struct rte_eth_dev *eth_dev)
+rnp_mac_rx_disable(struct rte_eth_dev *dev)
 {
-   RTE_SET_USED(eth_dev);
+   RTE_SET_USED(dev);
 
-   return -ENODEV;
+   return 0;
+}
+
+static int
+rnp_mac_tx_disable(struct rte_eth_dev *dev)
+{
+   RTE_SET_USED(dev);
+
+   return 0;
+}
+
+static int rnp_dev_close(struct rte_eth_dev *dev)
+{
+   RTE_SET_USED(dev);
+
+   return 0;
+}
+
+/* Features supported by this driver */
+static const struct eth_dev_ops rnp_eth_dev_ops = {
+};
+
+static int
+rnp_init_port_resource(struct rnp_eth_adapter *adapter,
+  struct rte_eth_dev *dev,
+  char *name,
+  uint8_t p_id)
+{
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
+
+   port->eth_dev = dev;
+   adapter->ports[p_id] = port;
+   dev->dev_ops = &rnp_eth_dev_ops;
+   RTE_SET_USED(name);
+
+   return 0;
+}
+
+static struct rte_eth_dev *
+rnp_alloc_eth_port(struct rte_pci_device *master_pci, char *name)
+{
+   struct rnp_eth_port *port;
+   struct rte_eth_dev *eth_dev;
+
+   eth_dev = rte_eth_dev_allocate(name);
+   if (!eth_dev) {
+   RNP_PMD_DRV_LOG(ERR, "Could not allocate "
+   "eth_dev for %s\n", name);
+   return NULL;
+   }
+   port = rte_zmalloc_socket(name,
+   sizeof(*port),
+   RTE_CACHE_LINE_SIZE,
+   master_pci->device.numa_node);
+   if (!port) {
+   RNP_PMD_DRV_LOG(ERR, "Could not allocate "
+   "rnp_eth_port for %s\n", name);
+   return NULL;
+   }
+   eth_dev->data->dev_private = port;
+   eth_dev->process_private = calloc(1, sizeof(struct rnp_share_ops));
+   if (!eth_dev->process_private) {
+   RNP_PMD_DRV_LOG(ERR, "Could not calloc "
+   "for Process_priv\n");
+   goto fail_calloc;
+   }
+   return eth_dev;
+fail_calloc:
+   rte_free(port);
+   rte_eth_dev_release_port(eth_de

[[PATCH v1] 5/8] net/rnp add reset code for Chip Init process

[Wenbo Cao]

we must get the shape info of nic from Firmware for
reset. so the related codes is first get firmware info
and then reset the chip

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/base/rnp_api.c  |  24 +++
 drivers/net/rnp/base/rnp_api.h  |   7 +
 drivers/net/rnp/base/rnp_cfg.h  |   7 +
 drivers/net/rnp/base/rnp_dma_regs.h |  73 
 drivers/net/rnp/base/rnp_eth_regs.h | 124 +
 drivers/net/rnp/base/rnp_hw.h   |  46 +
 drivers/net/rnp/meson.build |   3 +
 drivers/net/rnp/rnp.h   |  28 ++-
 drivers/net/rnp/rnp_ethdev.c|  99 +-
 drivers/net/rnp/rnp_mbx_fw.c| 272 
 drivers/net/rnp/rnp_mbx_fw.h| 163 -
 11 files changed, 840 insertions(+), 6 deletions(-)
 create mode 100644 drivers/net/rnp/base/rnp_api.c
 create mode 100644 drivers/net/rnp/base/rnp_api.h
 create mode 100644 drivers/net/rnp/base/rnp_cfg.h
 create mode 100644 drivers/net/rnp/base/rnp_dma_regs.h
 create mode 100644 drivers/net/rnp/base/rnp_eth_regs.h
 create mode 100644 drivers/net/rnp/rnp_mbx_fw.c

diff --git a/drivers/net/rnp/base/rnp_api.c b/drivers/net/rnp/base/rnp_api.c
new file mode 100644
index 00..f3044e595e
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_api.c
@@ -0,0 +1,24 @@
+#include "rnp.h"
+#include "rnp_api.h"
+
+int
+rnp_init_hw(struct rte_eth_dev *dev)
+{
+   struct rnp_mac_api *ops = RNP_DEV_TO_MAC_OPS(dev);
+   struct rnp_hw *hw = RNP_DEV_TO_HW(dev);
+
+   if (ops->init_hw)
+   return ops->init_hw(hw);
+   return -EOPNOTSUPP;
+}
+
+int
+rnp_reset_hw(struct rte_eth_dev *dev, struct rnp_hw *hw)
+{
+   struct rnp_mac_api *ops = RNP_DEV_TO_MAC_OPS(dev);
+
+   if (ops->reset_hw)
+   return ops->reset_hw(hw);
+   return -EOPNOTSUPP;
+}
+
diff --git a/drivers/net/rnp/base/rnp_api.h b/drivers/net/rnp/base/rnp_api.h
new file mode 100644
index 00..df574dab77
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_api.h
@@ -0,0 +1,7 @@
+#ifndef __RNP_API_H__
+#define __RNP_API_H__
+int
+rnp_init_hw(struct rte_eth_dev *dev);
+int
+rnp_reset_hw(struct rte_eth_dev *dev, struct rnp_hw *hw);
+#endif /* __RNP_API_H__ */
diff --git a/drivers/net/rnp/base/rnp_cfg.h b/drivers/net/rnp/base/rnp_cfg.h
new file mode 100644
index 00..90f25268ad
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_cfg.h
@@ -0,0 +1,7 @@
+#ifndef __RNP_CFG_H__
+#define __RNP_CFG_H__
+#include "rnp_osdep.h"
+
+#define RNP_NIC_RESET  _NIC_(0x0010)
+#define RNP_TX_QINQ_WORKAROUND _NIC_(0x801c)
+#endif /* __RNP_CFG_H__ */
diff --git a/drivers/net/rnp/base/rnp_dma_regs.h 
b/drivers/net/rnp/base/rnp_dma_regs.h
new file mode 100644
index 00..bfe87e534d
--- /dev/null
+++ b/drivers/net/rnp/base/rnp_dma_regs.h
@@ -0,0 +1,73 @@
+#ifndef __RNP_REGS_H__
+#define __RNP_REGS_H__
+
+#include "rnp_osdep.h"
+
+/* mac address offset */
+#define RNP_DMA_CTRL   (0x4)
+#define RNP_VEB_BYPASS_EN  BIT(4)
+#define RNP_DMA_MEM_CFG_LE (0 << 5)
+#define TSNR10_DMA_MEM_CFG_BE  (1 << 5)
+#define RNP_DMA_SCATTER_MEM_SHIFT  (16)
+
+#define RNP_FIRMWARE_SYNC  (0xc)
+#define RNP_FIRMWARE_SYNC_MASK GENMASK(31, 16)
+#define RNP_FIRMWARE_SYNC_MAGIC(0xa5a4)
+#define RNP_DRIVER_REMOVE  (0x5a00)
+/* 1BIT <-> 16 bytes Dma Addr Size*/
+#define RNP_DMA_SCATTER_MEM_MASK   GENMASK(31, 16)
+#define RNP_DMA_TX_MAP_MODE_SHIFT  (12)
+#define RNP_DMA_TX_MAP_MODE_MASK   GENMASK(15, 12)
+#define RNP_DMA_RX_MEM_PAD_EN  BIT(8)
+/* === queue register = */
+/* enable */
+#define RNP_DMA_RXQ_START(qid) _RING_(0x0010 + 0x100 * (qid))
+#define RNP_DMA_RXQ_READY(qid) _RING_(0x0014 + 0x100 * (qid))
+#define RNP_DMA_TXQ_START(qid) _RING_(0x0018 + 0x100 * (qid))
+#define RNP_DMA_TXQ_READY(qid) _RING_(0x001c + 0x100 * (qid))
+
+#define RNP_DMA_INT_STAT(qid)  _RING_(0x0020 + 0x100 * (qid))
+#define RNP_DMA_INT_MASK(qid)  _RING_(0x0024 + 0x100 * (qid))
+#define RNP_TX_INT_MASKBIT(1)
+#define RNP_RX_INT_MASKBIT(0)
+#define RNP_DMA_INT_CLER(qid)  _RING_(0x0028 + 0x100 * (qid))
+
+/* rx-queue */
+#define RNP_DMA_RXQ_BASE_ADDR_HI(qid)  _RING_(0x0030 + 0x100 * (qid))
+#define RNP_DMA_RXQ_BASE_ADDR_LO(qid)  _RING_(0x0034 + 0x100 * (qid))
+#define RNP_DMA_RXQ_LEN(qid)   _RING_(0x0038 + 0x100 * (qid))
+#define RNP_DMA_RXQ_HEAD(qid)  _RING_(0x003c + 0x100 * (qid))
+#define RNP_DMA_RXQ_TAIL(qid)  _RING_(0x0040 + 0x100 * (qid))
+#define RNP_DMA_RXQ_DESC_FETCH_CTRL(qid)   _RING_(0x0044 + 0x100 * (qid))
+#define RNP_DMA_RXQ_INT_DELAY_TIMER(qid)   _RING_(0x0048 + 0x100 * (qid))
+

[[PATCH v1] 6/8] net/rnp add port info resource init

[Wenbo Cao]

Add Api For FW Mac Info, Port Resoucre info init Code
For Different Shape Of Nic

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/base/rnp_api.c |  47 +++
 drivers/net/rnp/base/rnp_api.h |  10 ++
 drivers/net/rnp/base/rnp_hw.h  |  19 +++
 drivers/net/rnp/meson.build|   1 +
 drivers/net/rnp/rnp.h  |  88 +
 drivers/net/rnp/rnp_ethdev.c   | 224 +++--
 drivers/net/rnp/rnp_mbx_fw.c   | 112 +
 drivers/net/rnp/rnp_mbx_fw.h   | 115 +
 drivers/net/rnp/rnp_rxtx.c |  83 
 drivers/net/rnp/rnp_rxtx.h |  14 +++
 10 files changed, 706 insertions(+), 7 deletions(-)
 create mode 100644 drivers/net/rnp/rnp_rxtx.c
 create mode 100644 drivers/net/rnp/rnp_rxtx.h

diff --git a/drivers/net/rnp/base/rnp_api.c b/drivers/net/rnp/base/rnp_api.c
index f3044e595e..f2ab0ea270 100644
--- a/drivers/net/rnp/base/rnp_api.c
+++ b/drivers/net/rnp/base/rnp_api.c
@@ -22,3 +22,50 @@ rnp_reset_hw(struct rte_eth_dev *dev, struct rnp_hw *hw)
return -EOPNOTSUPP;
 }
 
+int
+rnp_get_mac_addr(struct rte_eth_dev *dev, uint8_t *macaddr)
+{
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
+   struct rnp_mac_api *ops = RNP_DEV_TO_MAC_OPS(dev);
+
+   if (!macaddr)
+   return -EINVAL;
+   if (ops->get_mac_addr)
+   return ops->get_mac_addr(port, port->attr.nr_lane, macaddr);
+   return -EOPNOTSUPP;
+}
+
+int
+rnp_set_default_mac(struct rte_eth_dev *dev, uint8_t *mac_addr)
+{
+   struct rnp_mac_api *ops = RNP_DEV_TO_MAC_OPS(dev);
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
+
+   if (ops->set_default_mac)
+   return ops->set_default_mac(port, mac_addr);
+   return -EOPNOTSUPP;
+}
+
+int
+rnp_set_rafb(struct rte_eth_dev *dev, uint8_t *addr,
+   uint8_t vm_pool, uint8_t index)
+{
+   struct rnp_mac_api *ops = RNP_DEV_TO_MAC_OPS(dev);
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
+
+   if (ops->set_rafb)
+   return ops->set_rafb(port, addr, vm_pool, index);
+   return -EOPNOTSUPP;
+}
+
+int
+rnp_clear_rafb(struct rte_eth_dev *dev,
+   uint8_t vm_pool, uint8_t index)
+{
+   struct rnp_mac_api *ops = RNP_DEV_TO_MAC_OPS(dev);
+   struct rnp_eth_port *port = RNP_DEV_TO_PORT(dev);
+
+   if (ops->clear_rafb)
+   return ops->clear_rafb(port, vm_pool, index);
+   return -EOPNOTSUPP;
+}
diff --git a/drivers/net/rnp/base/rnp_api.h b/drivers/net/rnp/base/rnp_api.h
index df574dab77..b998b11237 100644
--- a/drivers/net/rnp/base/rnp_api.h
+++ b/drivers/net/rnp/base/rnp_api.h
@@ -4,4 +4,14 @@ int
 rnp_init_hw(struct rte_eth_dev *dev);
 int
 rnp_reset_hw(struct rte_eth_dev *dev, struct rnp_hw *hw);
+int
+rnp_get_mac_addr(struct rte_eth_dev *dev, uint8_t *macaddr);
+int
+rnp_set_default_mac(struct rte_eth_dev *dev, uint8_t *mac_addr);
+int
+rnp_set_rafb(struct rte_eth_dev *dev, uint8_t *addr,
+   uint8_t vm_pool, uint8_t index);
+int
+rnp_clear_rafb(struct rte_eth_dev *dev,
+   uint8_t vm_pool, uint8_t index);
 #endif /* __RNP_API_H__ */
diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
index 03381ab6d0..7b7584959e 100644
--- a/drivers/net/rnp/base/rnp_hw.h
+++ b/drivers/net/rnp/base/rnp_hw.h
@@ -30,6 +30,11 @@ static inline void rnp_wr_reg(volatile void *reg, int val)
 #define rnp_eth_rd(hw, off)rnp_rd_reg((char *)(hw)->eth_base + (off))
 #define rnp_eth_wr(hw, off, val) \
rnp_wr_reg((char *)(hw)->eth_base + (off), val)
+/* == reg-rw == */
+#define RNP_MACADDR_UPDATE_LO(hw, hw_idx, val) \
+   rnp_eth_wr(hw, RNP_RAL_BASE_ADDR(hw_idx), val)
+#define RNP_MACADDR_UPDATE_HI(hw, hw_idx, val) \
+   rnp_eth_wr(hw, RNP_RAH_BASE_ADDR(hw_idx), val)
 struct rnp_hw;
 /* Mbx Operate info */
 enum MBX_ID {
@@ -99,9 +104,23 @@ struct rnp_mbx_info {
rte_atomic16_t state;
 } __rte_cache_aligned;
 
+struct rnp_eth_port;
 struct rnp_mac_api {
int32_t (*init_hw)(struct rnp_hw *hw);
int32_t (*reset_hw)(struct rnp_hw *hw);
+   /* MAC Address */
+   int32_t (*get_mac_addr)(struct rnp_eth_port *port,
+   uint8_t lane,
+   uint8_t *macaddr);
+   int32_t (*set_default_mac)(struct rnp_eth_port *port, uint8_t *mac);
+   /* Receive Address Filter Table */
+   int32_t (*set_rafb)(struct rnp_eth_port *port,
+   uint8_t *mac,
+   uint8_t vm_pool,
+   uint8_t index);
+   int32_t (*clear_rafb)(struct rnp_eth_port *port,
+   uint8_t vm_pool,
+   uint8_t index);
 };
 
 struct rnp_mac_info {
diff --git a/drivers/net/rnp/meson.build b/drivers/net/rnp/meson.build
index c52566c357..7d63460c45 100644
--- a/drivers/net/rnp/meson.build
+++ b/drivers/net/rnp/meson.build
@@ -11,6 +11,7 @@ sources = files(
'rnp_ethdev.c'

[[PATCH v1] 7/8] net/rnp add devargs runtime parsing functions

[Wenbo Cao]

add various runtime devargs command line options
supported by this driver.

Signed-off-by: Wenbo Cao 
---
 drivers/net/rnp/rnp.h|  22 +
 drivers/net/rnp/rnp_ethdev.c | 164 +++
 drivers/net/rnp/rnp_mbx_fw.c | 164 +++
 drivers/net/rnp/rnp_mbx_fw.h |  69 +++
 4 files changed, 419 insertions(+)

diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index 892dbc47f4..029e8a2776 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -107,6 +107,8 @@ struct rnp_eth_port {
void *adapt;
uint8_t mac_addr[RTE_ETHER_ADDR_LEN];
struct rnp_hw *hw;
+   uint8_t rx_func_sec; /* force set io rx_func */
+   uint8_t tx_func_sec; /* force set io tx func */
struct rte_eth_dev *eth_dev;
struct rnp_port_attr attr;
/* Recvice Mac Address Record Table */
@@ -122,6 +124,13 @@ struct rnp_share_ops {
struct rnp_mac_api mac_api;
 } __rte_cache_aligned;
 
+enum {
+   RNP_IO_FUNC_USE_NONE = 0,
+   RNP_IO_FUNC_USE_VEC,
+   RNP_IO_FUNC_USE_SIMPLE,
+   RNP_IO_FUNC_USE_COMMON,
+};
+
 struct rnp_eth_adapter {
enum rnp_work_mode mode;
enum rnp_resource_share_m s_mode; /* Port Resource Share Policy */
@@ -135,6 +144,19 @@ struct rnp_eth_adapter {
int max_link_speed;
uint8_t num_ports; /* Cur Pf Has physical Port Num */
uint8_t lane_mask;
+
+   uint8_t rx_func_sec; /* force set io rx_func */
+   uint8_t tx_func_sec; /* force set io tx func*/
+   /*fw-update*/
+   bool  do_fw_update;
+   char *fw_path;
+
+   bool loopback_en;
+   bool fw_sfp_10g_1g_auto_det;
+   int fw_force_speed_1g;
+#define FOCE_SPEED_1G_NOT_SET  (-1)
+#define FOCE_SPEED_1G_DISABLED (0)
+#define FOCE_SPEED_1G_ENABLED  (1)
 } __rte_cache_aligned;
 
 #define RNP_DEV_TO_PORT(eth_dev) \
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 22b9ffd685..fbcfc4f661 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -6,6 +6,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "rnp.h"
 #include "rnp_mbx.h"
@@ -14,6 +15,13 @@
 #include "rnp_rxtx.h"
 #include "rnp_logs.h"
 
+#define RNP_HW_MAC_LOOPBACK_ARG  "hw_loopback"
+#define RNP_FW_UPDATE"fw_update"
+#define RNP_RX_FUNC_SELECT   "rx_func_sec"
+#define RNP_TX_FUNC_SELECT   "tx_func_sec"
+#define RNP_FW_4X10G_10G_1G_DET  "fw_4x10g_10g_1g_auto_det"
+#define RNP_FW_FORCE_SPEED_1G"fw_force_1g_speed"
+
 extern struct rnp_mbx_api rnp_mbx_pf_ops;
 static int
 rnp_mac_rx_disable(struct rte_eth_dev *dev)
@@ -109,6 +117,8 @@ rnp_init_port_resource(struct rnp_eth_adapter *adapter,
struct rnp_hw *hw = &adapter->hw;
 
port->adapt = adapter;
+   port->rx_func_sec = adapter->rx_func_sec;
+   port->tx_func_sec = adapter->tx_func_sec;
port->s_mode = adapter->s_mode;
port->port_stopped = 1;
port->hw = hw;
@@ -444,6 +454,152 @@ rnp_special_ops_init(struct rte_eth_dev *eth_dev)
return 0;
 }
 
+static const char *const rnp_valid_arguments[] = {
+   RNP_HW_MAC_LOOPBACK_ARG,
+   RNP_FW_UPDATE,
+   RNP_RX_FUNC_SELECT,
+   RNP_TX_FUNC_SELECT,
+   RNP_FW_4X10G_10G_1G_DET,
+   RNP_FW_FORCE_SPEED_1G,
+   NULL
+};
+
+static int
+rnp_parse_handle_devarg(const char *key, const char *value,
+   void *extra_args)
+{
+   struct rnp_eth_adapter *adapter = NULL;
+
+   if (value == NULL || extra_args == NULL)
+   return -EINVAL;
+
+   if (strcmp(key, RNP_HW_MAC_LOOPBACK_ARG) == 0) {
+   uint16_t *n = extra_args;
+   *n = (uint16_t)strtoul(value, NULL, 10);
+   if (*n == USHRT_MAX && errno == ERANGE)
+   return -1;
+   } else if (strcmp(key, RNP_FW_UPDATE) == 0) {
+   adapter = (struct rnp_eth_adapter *)extra_args;
+   adapter->do_fw_update = true;
+   adapter->fw_path = strdup(value);
+   } else if (strcmp(key, RNP_FW_4X10G_10G_1G_DET) == 0) {
+   adapter = (struct rnp_eth_adapter *)extra_args;
+   if (adapter->num_ports == 2 && adapter->hw.speed == 10 * 1000) {
+   adapter->fw_sfp_10g_1g_auto_det =
+   (strcmp(value, "on") == 0) ? true : false;
+   } else {
+   adapter->fw_sfp_10g_1g_auto_det = false;
+   }
+   } else if (strcmp(key, RNP_FW_FORCE_SPEED_1G) == 0) {
+   adapter = (struct rnp_eth_adapter *)extra_args;
+   if (adapter->num_ports == 2) {
+   if (strcmp(value, "on") == 0)
+   adapter->fw_force_speed_1g = 
FOCE_SPEED_1G_ENABLED;
+   else if (strcmp(value, "off") == 0)
+   adapter->fw_force_speed_1g = 
FOCE_SPEED_1G_DISABLED;
+   

Re: [PATCH v3] build: update DPDK to use C11 standard

[David Marchand]

On Tue, Aug 1, 2023 at 12:19 PM Bruce Richardson
 wrote:
>
> On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote:
> >Hi Bruce,
> >I see some failures for this series for our Ubuntu 20.04 containers.
> >And, our DTS testbeds which are on ubuntu 20.04 are skipping running
> >testsuites because they can't compile DPDK. So, that's why it has some
> >missing results for a couple of the Intel NICs. For context, I'll paste
> >below where the compile job terminates in one of our containerized
> >compile test runs. The GCC in use here is version 9.4, so it meets the
> >requirements as described in your patch as far as I can tell. I'll
> >check it out more tomorrow to see whether it's an infra failure, like
> >some missing dependencies. Please let me know if we expect to have no
> >issues with 20.04 or if this is anticipated.
> >Thanks!
> >[1638/2730] Generating symbol file
> >'drivers/a715181@@rte_net_ixgbe@sha/librte_net_ixgbe.so.24.0.symbols'.
> >[1639/2730] Compiling C object
> >'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o'.
> >FAILED: drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o
> >ccache cc -Idrivers/a715181@@tmp_rte_net_mlx4@sta -Idrivers
> >-I../drivers -Idrivers/net/mlx4 -I../drivers/net/mlx4 -Ilib/ethdev
> >-I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include
> >-I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include
> >-Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common
> >-I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs
> >-Ilib/telemetry/../metrics -I../lib/telemetry/../metrics
> >-Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf
> >-I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring
> >-Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci
> >-I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev
> >-I../drivers/bus/vdev -I/usr/include/libnl3 -fdiagnostics-color=always
> >-pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror
> >-std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat
> >-Wformat-nonliteral -Wformat-security -Wmissing-declarations
> >-Wmissing-prototypes -Wnested-externs -Wold-style-definition
> >-Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef
> >-Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned
> >-Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native
> >-DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation
> >-std=c11 -Wno-strict-prototypes -D_BSD_SOURCE -D_DEFAULT_SOURCE
> >-D_XOPEN_SOURCE=600 -UPEDANTIC -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.mlx4
> >-MD -MQ 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -MF
> >'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o.d' -o
> >'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -c
> >../drivers/net/mlx4/mlx4.c
> >In file included from ../drivers/net/mlx4/mlx4_rxtx.h:27,
> > from ../drivers/net/mlx4/mlx4.c:49:
> >../drivers/net/mlx4/mlx4_prm.h:111:8: error: redefinition of 'struct
> >mlx4_wqe_lso_seg'
> >  111 | struct mlx4_wqe_lso_seg {
> >  |^~~~
> >In file included from ../drivers/net/mlx4/mlx4_glue.h:16,
> > from ../drivers/net/mlx4/mlx4.c:46:
> >/usr/include/infiniband/mlx4dv.h:410:8: note: originally defined here
> >  410 | struct mlx4_wqe_lso_seg {
> >  |^~~~
> >ninja: build stopped: subcommand failed.
>
> Hi again,
>
> I've attempted to reproduce this on my Ubuntu 20.04 VM and failed,
> everything seems to build ok.
>
> Looking through the logs, though, there does appear to be a difference in
> the configurations in the two cases. I suspect my Ubuntu has an updated
> verbs package compared to the image you are using. In the log of the failed
> build, I see:
>
> Checking whether type "struct mlx4_wqe_lso_seg" has member 
> "mss_hdr_size" with dependencies libmlx4, libibverbs: NO
> Configuring mlx4_autoconf.h using configuration
>
> While building in my VM, I have:
>
> Checking whether type "struct mlx4_wqe_lso_seg" has member 
> "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached)
> Configuring mlx4_autoconf.h using configuration
>
> So my verbs mlx4 header has got a different set of definitions to those in
> the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev package
> version "28.0-1ubuntu1"
>
> Can the CI image be updated to latest 20.04 packages?
>
> /Bruce
>

I can reproduce the issue seen at UNH, with a 20.04.6 container and
the same libibverbs as you:
ii  libibverbs-dev:amd64   28.0-1ubuntu1
  amd64Development files for the libibverbs library

So I suspect something is different in container images..

Past

Re: [PATCH] build: check drivers class dependencies early

[Bruce Richardson]

On Tue, Aug 01, 2023 at 12:20:47PM +0200, David Marchand wrote:
> On Tue, Aug 1, 2023 at 11:25 AM Bruce Richardson
>  wrote:
> >
> > On Tue, Aug 01, 2023 at 10:52:53AM +0200, David Marchand wrote:
> > > Drivers implementing a class of devices (for example, drivers/event)
> > > depend on the associated abstraction library (lib/eventdev).
> > > This dependency is expressed in the top level meson.build for this class
> > > (drivers/event/meson.build).
> > >
> > > As we are making more libraries optional, custom constructs referencing
> > > the class dependencies in some drivers meson.build (event/dlb2) may break.
> > >
> > > It would be possible to add more checks in those drivers meson.build but
> > > it is more straightforward to not even consider a driver meson.build when
> > > the class dependencies are not met.
> > >
> > > Signed-off-by: David Marchand 
> > > ---
> > >  drivers/meson.build | 11 +++
> > >  1 file changed, 11 insertions(+)
> > >
> > > diff --git a/drivers/meson.build b/drivers/meson.build
> > > index 74ae8cb96b..c375352e77 100644
> > > --- a/drivers/meson.build
> > > +++ b/drivers/meson.build
> > > @@ -70,6 +70,17 @@ foreach subpath:subdirs
> > >  else
> > >  class = subpath
> > >  subdir(class)
> > > +skip_class = false
> > > +foreach d:std_deps
> > > +if not is_variable('shared_rte_' + d)
> > > +skip_class = true
> > > +message('Disabling all @1@ drivers: missing internal 
> > > dependency "@0@"'
> > > +.format(d, class))
> > > +endif
> > > +endforeach
> > > +if skip_class
> > > +continue
> > > +endif
> > >  endif
> > >
> > >  # save class name on first occurrence
> >
> > I like this approach. However, we do need something in the summary at the
> > end of the build too. Either:
> >
> > * Single message stating all drivers of a given class are skipped
> > * (as now), message for each driver stating that it has been disabled
> >
> > The former is nice as it gives us a shorter summary. The latter is nice
> > because it's consistent with what we have now.  Authors choice, which to go
> > for! :-)
> 
> I like the shorter summary.
> WDYT of:
> 
> diff --git a/drivers/meson.build b/drivers/meson.build
> index c375352e77..02268918e4 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -74,11 +74,18 @@ foreach subpath:subdirs
>  foreach d:std_deps
>  if not is_variable('shared_rte_' + d)
>  skip_class = true
> -message('Disabling all @1@ drivers: missing internal
> dependency "@0@"'
> +reason = 'missing internal dependency, "@0@"'.format(d)
> +if dpdk_libs_deprecated.contains(d)
> +reason += ' (deprecated lib)'
> +endif
> +message('Disabling @1@/* drivers: missing internal
> dependency "@0@"'
>  .format(d, class))

Minor nit: You probably want a break here, as we only have room for one
missing dependency, so no point in checking more after the first missing.

>  endif
>  endforeach
>  if skip_class
> +drv_path = join_paths(class, '*')
> +dpdk_drvs_disabled += drv_path
> +set_variable(drv_path.underscorify() + '_disable_reason', reason)
>  continue
>  endif
>  endif
> 
> 
> This gives the following output (testing on top of your series
> extending optional libs and a fix on the new reasm perf test).
> https://github.com/david-marchand/dpdk/actions/runs/5725429526/job/15513923381#step:19:346
> 
> ...
> =
> Content Skipped
> =
> ...
> drivers:
> ...
> mempool/dpaa2: not in enabled drivers build config
> mempool/octeontx: not in enabled drivers build config
> mempool/stack: not in enabled drivers build config
> dma/*: missing internal dependency, "dmadev"
> net/af_packet: not in enabled drivers build config
> net/af_xdp: not in enabled drivers build config
> net/ark: not in enabled drivers build config
> ...
> 

+1 to this. Works for me.

Re: [PATCH v3] build: update DPDK to use C11 standard

[Thomas Monjalon]

01/08/2023 12:19, Bruce Richardson:
> On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote:
> >Hi Bruce,
> >I see some failures for this series for our Ubuntu 20.04 containers.
> >And, our DTS testbeds which are on ubuntu 20.04 are skipping running
> >testsuites because they can't compile DPDK. So, that's why it has some
> >missing results for a couple of the Intel NICs. For context, I'll paste
> >below where the compile job terminates in one of our containerized
> >compile test runs. The GCC in use here is version 9.4, so it meets the
> >requirements as described in your patch as far as I can tell. I'll
> >check it out more tomorrow to see whether it's an infra failure, like
> >some missing dependencies. Please let me know if we expect to have no
> >issues with 20.04 or if this is anticipated.
> >Thanks!
> >[1638/2730] Generating symbol file
> >'drivers/a715181@@rte_net_ixgbe@sha/librte_net_ixgbe.so.24.0.symbols'.
> >[1639/2730] Compiling C object
> >'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o'.
> >FAILED: drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o
> >ccache cc -Idrivers/a715181@@tmp_rte_net_mlx4@sta -Idrivers
> >-I../drivers -Idrivers/net/mlx4 -I../drivers/net/mlx4 -Ilib/ethdev
> >-I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include
> >-I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include
> >-Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common
> >-I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs
> >-Ilib/telemetry/../metrics -I../lib/telemetry/../metrics
> >-Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf
> >-I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring
> >-Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci
> >-I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev
> >-I../drivers/bus/vdev -I/usr/include/libnl3 -fdiagnostics-color=always
> >-pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror
> >-std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat
> >-Wformat-nonliteral -Wformat-security -Wmissing-declarations
> >-Wmissing-prototypes -Wnested-externs -Wold-style-definition
> >-Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef
> >-Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned
> >-Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native
> >-DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation
> >-std=c11 -Wno-strict-prototypes -D_BSD_SOURCE -D_DEFAULT_SOURCE
> >-D_XOPEN_SOURCE=600 -UPEDANTIC -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.mlx4
> >-MD -MQ 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -MF
> >'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o.d' -o
> >'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -c
> >../drivers/net/mlx4/mlx4.c
> >In file included from ../drivers/net/mlx4/mlx4_rxtx.h:27,
> > from ../drivers/net/mlx4/mlx4.c:49:
> >../drivers/net/mlx4/mlx4_prm.h:111:8: error: redefinition of 'struct
> >mlx4_wqe_lso_seg'
> >  111 | struct mlx4_wqe_lso_seg {
> >  |^~~~
> >In file included from ../drivers/net/mlx4/mlx4_glue.h:16,
> > from ../drivers/net/mlx4/mlx4.c:46:
> >/usr/include/infiniband/mlx4dv.h:410:8: note: originally defined here
> >  410 | struct mlx4_wqe_lso_seg {
> >  |^~~~
> >ninja: build stopped: subcommand failed.
> 
> Hi again,
> 
> I've attempted to reproduce this on my Ubuntu 20.04 VM and failed,
> everything seems to build ok.
> 
> Looking through the logs, though, there does appear to be a difference in
> the configurations in the two cases. I suspect my Ubuntu has an updated
> verbs package compared to the image you are using. In the log of the failed
> build, I see:
> 
>   Checking whether type "struct mlx4_wqe_lso_seg" has member 
> "mss_hdr_size" with dependencies libmlx4, libibverbs: NO 
>   Configuring mlx4_autoconf.h using configuration
> 
> While building in my VM, I have:
> 
>   Checking whether type "struct mlx4_wqe_lso_seg" has member 
> "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached)
>   Configuring mlx4_autoconf.h using configuration
> 
> So my verbs mlx4 header has got a different set of definitions to those in
> the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev package
> version "28.0-1ubuntu1"
> 
> Can the CI image be updated to latest 20.04 packages?

I'm surprised there is such issue.
The autoconf mechanism should manage any old package.

Ali, do you have an idea what happens?

Re: Threads using mempools

[Bruce Richardson]

On Tue, Aug 01, 2023 at 10:21:16AM +, Dumitrescu, Cristian wrote:
>Hi folks,
> 
> 
>Is there a way in DPDK to create a POSIX thread in the driver/app and
>hook it up to an existing mempool by creating a mempool cache on the
>fly for this thread?
> 
> 
>The regular RTE lcores and service cores seem to be the only threads
>that have access to mempools, is my observation correct? This would
>prevent (on purpose?) the drivers/apps to create threads that can be
>directly involved in processing packets.
> 
> 
"rte_thread_register" is the API you are looking for, I think. It assigns
an lcore_id to a non-DPDK thread so it can access mempools etc.

/Bruce

Re: [PATCH v3] build: update DPDK to use C11 standard

[Bruce Richardson]

On Tue, Aug 01, 2023 at 12:35:21PM +0200, David Marchand wrote:
> On Tue, Aug 1, 2023 at 12:19 PM Bruce Richardson
>  wrote:
> >
> > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote:
> > >Hi Bruce,
> > >I see some failures for this series for our Ubuntu 20.04 containers.

> >
> > Hi again,
> >
> > I've attempted to reproduce this on my Ubuntu 20.04 VM and failed,
> > everything seems to build ok.
> >
> > Looking through the logs, though, there does appear to be a difference in
> > the configurations in the two cases. I suspect my Ubuntu has an updated
> > verbs package compared to the image you are using. In the log of the failed
> > build, I see:
> >
> > Checking whether type "struct mlx4_wqe_lso_seg" has member 
> > "mss_hdr_size" with dependencies libmlx4, libibverbs: NO
> > Configuring mlx4_autoconf.h using configuration
> >
> > While building in my VM, I have:
> >
> > Checking whether type "struct mlx4_wqe_lso_seg" has member 
> > "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached)
> > Configuring mlx4_autoconf.h using configuration
> >
> > So my verbs mlx4 header has got a different set of definitions to those in
> > the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev package
> > version "28.0-1ubuntu1"
> >
> > Can the CI image be updated to latest 20.04 packages?
> >
> > /Bruce
> >
> 
> I can reproduce the issue seen at UNH, with a 20.04.6 container and
> the same libibverbs as you:
> ii  libibverbs-dev:amd64   28.0-1ubuntu1
>   amd64Development files for the libibverbs library
> 
> So I suspect something is different in container images..
> 
> Pasting the (hopefully) relevant meson logs:
> 
> Running compile:
> Working directory:  /root/dpdk/build/meson-private/tmp0ovvvd9g
> Command line:  ccache cc -I/usr/include/libnl3
> /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c -o
> /root/dpdk/build/meson-private/tmp0ovvvd9g/output.obj -pipe -c
> -D_FILE_OFFSET_BITS=64 -O0 -std=c11
> 
> Code:
>  #include 
> void bar(void) {
> struct mlx4_wqe_lso_seg foo;
> foo.mss_hdr_size;
> 
> };
> Compiler stdout:
> 
> Compiler stderr:
>  In file included from 
> /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c:1:
> /usr/include/infiniband/mlx4dv.h:176:2: error: unknown type name 'off_t'
>   176 |  off_t   uar_mmap_offset;
>   |  ^
> 
> Checking whether type "struct mlx4_wqe_lso_seg" has member
> "mss_hdr_size" with dependencies libmlx4, libibverbs: NO
> 
Thanks. I'll dig some more.

RE: [PATCH] build: check drivers class dependencies early

[Morten Brørup]

> From: David Marchand [mailto:david.march...@redhat.com]
> Sent: Tuesday, 1 August 2023 12.21
> 
> On Tue, Aug 1, 2023 at 11:25 AM Bruce Richardson
>  wrote:
> >
> > On Tue, Aug 01, 2023 at 10:52:53AM +0200, David Marchand wrote:
> > > Drivers implementing a class of devices (for example, drivers/event)
> > > depend on the associated abstraction library (lib/eventdev).
> > > This dependency is expressed in the top level meson.build for this class
> > > (drivers/event/meson.build).
> > >
> > > As we are making more libraries optional, custom constructs referencing
> > > the class dependencies in some drivers meson.build (event/dlb2) may break.
> > >
> > > It would be possible to add more checks in those drivers meson.build but
> > > it is more straightforward to not even consider a driver meson.build when
> > > the class dependencies are not met.
> > >
> > > Signed-off-by: David Marchand 
> > > ---
> 
> This gives the following output (testing on top of your series
> extending optional libs and a fix on the new reasm perf test).
> https://github.com/david-
> marchand/dpdk/actions/runs/5725429526/job/15513923381#step:19:346
> 
> ...
> =
> Content Skipped
> =
> ...
> drivers:
> ...
> mempool/dpaa2: not in enabled drivers build config
> mempool/octeontx: not in enabled drivers build config
> mempool/stack: not in enabled drivers build config
> dma/*: missing internal dependency, "dmadev"
> net/af_packet: not in enabled drivers build config
> net/af_xdp: not in enabled drivers build config
> net/ark: not in enabled drivers build config
> ...
> 

For the concept suggested by David (and preferably with Bruce's output):

Acked-by: Morten Brørup 

Re: [PATCH v3] build: update DPDK to use C11 standard

[Bruce Richardson]

On Tue, Aug 01, 2023 at 11:39:06AM +0100, Bruce Richardson wrote:
> On Tue, Aug 01, 2023 at 12:35:21PM +0200, David Marchand wrote:
> > On Tue, Aug 1, 2023 at 12:19 PM Bruce Richardson
> >  wrote:
> > >
> > > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote:
> > > >Hi Bruce,
> > > >I see some failures for this series for our Ubuntu 20.04 containers.
> 
> > >
> > > Hi again,
> > >
> > > I've attempted to reproduce this on my Ubuntu 20.04 VM and failed,
> > > everything seems to build ok.
> > >
> > > Looking through the logs, though, there does appear to be a difference in
> > > the configurations in the two cases. I suspect my Ubuntu has an updated
> > > verbs package compared to the image you are using. In the log of the 
> > > failed
> > > build, I see:
> > >
> > > Checking whether type "struct mlx4_wqe_lso_seg" has member 
> > > "mss_hdr_size" with dependencies libmlx4, libibverbs: NO
> > > Configuring mlx4_autoconf.h using configuration
> > >
> > > While building in my VM, I have:
> > >
> > > Checking whether type "struct mlx4_wqe_lso_seg" has member 
> > > "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached)
> > > Configuring mlx4_autoconf.h using configuration
> > >
> > > So my verbs mlx4 header has got a different set of definitions to those in
> > > the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev package
> > > version "28.0-1ubuntu1"
> > >
> > > Can the CI image be updated to latest 20.04 packages?
> > >
> > > /Bruce
> > >
> > 
> > I can reproduce the issue seen at UNH, with a 20.04.6 container and
> > the same libibverbs as you:
> > ii  libibverbs-dev:amd64   28.0-1ubuntu1
> >   amd64Development files for the libibverbs library
> > 
> > So I suspect something is different in container images..
> > 
> > Pasting the (hopefully) relevant meson logs:
> > 
> > Running compile:
> > Working directory:  /root/dpdk/build/meson-private/tmp0ovvvd9g
> > Command line:  ccache cc -I/usr/include/libnl3
> > /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c -o
> > /root/dpdk/build/meson-private/tmp0ovvvd9g/output.obj -pipe -c
> > -D_FILE_OFFSET_BITS=64 -O0 -std=c11
> > 
> > Code:
> >  #include 
> > void bar(void) {
> > struct mlx4_wqe_lso_seg foo;
> > foo.mss_hdr_size;
> > 
> > };
> > Compiler stdout:
> > 
> > Compiler stderr:
> >  In file included from 
> > /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c:1:
> > /usr/include/infiniband/mlx4dv.h:176:2: error: unknown type name 'off_t'
> >   176 |  off_t   uar_mmap_offset;
> >   |  ^
> > 
> > Checking whether type "struct mlx4_wqe_lso_seg" has member
> > "mss_hdr_size" with dependencies libmlx4, libibverbs: NO
> > 
> Thanks. I'll dig some more.

I think the meson version may be the culprit here. In my meson log I don't
see the -std=c11 flag appended to the test compilation command.

Let me downgrade my meson version and see if I can reproduce.

/Bruce

RE: [PATCH] build: check drivers class dependencies early

[Morten Brørup]

> From: Morten Brørup [mailto:m...@smartsharesystems.com]
> Sent: Tuesday, 1 August 2023 12.49
> 
> > From: David Marchand [mailto:david.march...@redhat.com]
> > Sent: Tuesday, 1 August 2023 12.21
> >
> > On Tue, Aug 1, 2023 at 11:25 AM Bruce Richardson
> >  wrote:
> > >
> > > On Tue, Aug 01, 2023 at 10:52:53AM +0200, David Marchand wrote:
> > > > Drivers implementing a class of devices (for example, drivers/event)
> > > > depend on the associated abstraction library (lib/eventdev).
> > > > This dependency is expressed in the top level meson.build for this class
> > > > (drivers/event/meson.build).
> > > >
> > > > As we are making more libraries optional, custom constructs referencing
> > > > the class dependencies in some drivers meson.build (event/dlb2) may
> break.
> > > >
> > > > It would be possible to add more checks in those drivers meson.build but
> > > > it is more straightforward to not even consider a driver meson.build
> when
> > > > the class dependencies are not met.
> > > >
> > > > Signed-off-by: David Marchand 
> > > > ---
> >
> > This gives the following output (testing on top of your series
> > extending optional libs and a fix on the new reasm perf test).
> > https://github.com/david-
> > marchand/dpdk/actions/runs/5725429526/job/15513923381#step:19:346
> >
> > ...
> > =
> > Content Skipped
> > =
> > ...
> > drivers:
> > ...
> > mempool/dpaa2: not in enabled drivers build config
> > mempool/octeontx: not in enabled drivers build config
> > mempool/stack: not in enabled drivers build config
> > dma/*: missing internal dependency, "dmadev"
> > net/af_packet: not in enabled drivers build config
> > net/af_xdp: not in enabled drivers build config
> > net/ark: not in enabled drivers build config
> > ...
> >
> 
> For the concept suggested by David (and preferably with Bruce's output):

Sorry... This was David's suggestion, which I prefer. I thought I was replying 
to Bruce's reply.

> 
> Acked-by: Morten Brørup 

My ACK still valid.

Marvell DPDK 23.11 Roadmap

[Jerin Jacob Kollanukkaran]

Marvell - DPDK v23.11 Roadmap for non-driver changes
===

cryptodev
=
1) Support for cryptodev to inject packets to ethdev Rx. On capable devices, 
this would help in using ethdev Rx offloads 
(like inline reassembly, inner packet parsing) after cryptodev processing (like 
inbound IPsec).

dmadev
==
1) Support HW offload to free mbuf upon DMA transfer completion.

eventdev

1) Support dmadev adapter 
http://patches.dpdk.org/project/dpdk/patch/20230724080744.1209290-1-amitpraka...@marvell.com/

2) Support mldev adapter
http://patches.dpdk.org/project/dpdk/patch/20230801070016.340-2-syalavar...@marvell.com/

3)Introduce link profiles, a set of event queues can be grouped together as a 
profile and then
linked to an event port. The active profile can be switched before making a 
dequeue call.

mldev
=
1) Update rte_ml_op structure, quantize/dequantize APIs to support rte_mbuf 
buffers.

2) Update rte_ml_model_info to support arbitrary shape input/output.

rte_security

1) Support TLS record processing offload 

2) Introduce out of place support for inline ingress security sessions
https://patches.dpdk.org/project/dpdk/patch/20230309085645.1630826-1-ndabilpu...@marvell.com/

3) Hide structures ``rte_security_ops`` and ``rte_security_ctx`` as these are 
internal to DPDK library and drivers.
https://patches.dpdk.org/project/dpdk/patch/20230801081047.1219935-1-gak...@marvell.com/

libpdcp
==
1) Support for handling Control PDU

Test applications
==

1) test/crypto: add external mbuf test-case for look-aside IPsec
2) test/pdcp: add test cases to verify all packet lengths required to be 
supported with PDCP
3) test/dmadev: add test cases to verify rte_dmadev_copy_sg() functionality 
with all combinations of src & dst pointers.
4) app/test-dma-perf: DMA perf test application enhancement to support "device 
to memory" and "memory to device" data transfer and scatter-gather copy support.
4) app/graph: Add graph application for exercise different use-cases
Currently l3fwd-graph application demonstrates only l3fwd use case.
With this new application, a framework is provided to add new use cases
using static configuration file (.cli). Also a CLI framework to allow user
to configure some configuration at runtime

https://patches.dpdk.org/project/dpdk/patch/20230425131516.3308612-5-vattun...@marvell.com/
 
Marvell - DPDK v23.11 Roadmap for driver changes
==

cnxk-ethdev
===
1) Support flow aging
2) Support port representor

cnxk-cryptodev:
==
1) Support SM2 algorithm

mldev-cnxk
==
1) Extend driver to support ML models compiled using TVM framework.

RE: [PATCH v3] build: update DPDK to use C11 standard

[Ali Alnubani]

> -Original Message-
> From: Bruce Richardson 
> Sent: Tuesday, August 1, 2023 1:51 PM
> To: David Marchand 
> Cc: Patrick Robb ; Tyler Retzlaff
> ; dev@dpdk.org; Morten Brørup
> ; NBU-Contact-Thomas Monjalon
> (EXTERNAL) 
> Subject: Re: [PATCH v3] build: update DPDK to use C11 standard
> 
> On Tue, Aug 01, 2023 at 11:39:06AM +0100, Bruce Richardson wrote:
> > On Tue, Aug 01, 2023 at 12:35:21PM +0200, David Marchand wrote:
> > > On Tue, Aug 1, 2023 at 12:19 PM Bruce Richardson
> > >  wrote:
> > > >
> > > > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote:
> > > > >Hi Bruce,
> > > > >I see some failures for this series for our Ubuntu 20.04 
> > > > > containers.
> > 
> > > >
> > > > Hi again,
> > > >
> > > > I've attempted to reproduce this on my Ubuntu 20.04 VM and failed,
> > > > everything seems to build ok.
> > > >
> > > > Looking through the logs, though, there does appear to be a difference 
> > > > in
> > > > the configurations in the two cases. I suspect my Ubuntu has an updated
> > > > verbs package compared to the image you are using. In the log of the
> failed
> > > > build, I see:
> > > >
> > > > Checking whether type "struct mlx4_wqe_lso_seg" has member
> "mss_hdr_size" with dependencies libmlx4, libibverbs: NO
> > > > Configuring mlx4_autoconf.h using configuration
> > > >
> > > > While building in my VM, I have:
> > > >
> > > > Checking whether type "struct mlx4_wqe_lso_seg" has member
> "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached)
> > > > Configuring mlx4_autoconf.h using configuration
> > > >
> > > > So my verbs mlx4 header has got a different set of definitions to those 
> > > > in
> > > > the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev
> package
> > > > version "28.0-1ubuntu1"
> > > >
> > > > Can the CI image be updated to latest 20.04 packages?
> > > >
> > > > /Bruce
> > > >
> > >
> > > I can reproduce the issue seen at UNH, with a 20.04.6 container and
> > > the same libibverbs as you:
> > > ii  libibverbs-dev:amd64   28.0-1ubuntu1
> > >   amd64Development files for the libibverbs library
> > >
> > > So I suspect something is different in container images..
> > >
> > > Pasting the (hopefully) relevant meson logs:
> > >
> > > Running compile:
> > > Working directory:  /root/dpdk/build/meson-private/tmp0ovvvd9g
> > > Command line:  ccache cc -I/usr/include/libnl3
> > > /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c -o
> > > /root/dpdk/build/meson-private/tmp0ovvvd9g/output.obj -pipe -c
> > > -D_FILE_OFFSET_BITS=64 -O0 -std=c11
> > >
> > > Code:
> > >  #include 
> > > void bar(void) {
> > > struct mlx4_wqe_lso_seg foo;
> > > foo.mss_hdr_size;
> > >
> > > };
> > > Compiler stdout:
> > >
> > > Compiler stderr:
> > >  In file included from /root/dpdk/build/meson-
> private/tmp0ovvvd9g/testfile.c:1:
> > > /usr/include/infiniband/mlx4dv.h:176:2: error: unknown type name 'off_t'
> > >   176 |  off_t   uar_mmap_offset;
> > >   |  ^
> > >
> > > Checking whether type "struct mlx4_wqe_lso_seg" has member
> > > "mss_hdr_size" with dependencies libmlx4, libibverbs: NO
> > >
> > Thanks. I'll dig some more.
> 
> I think the meson version may be the culprit here. In my meson log I don't
> see the -std=c11 flag appended to the test compilation command.
> 
> Let me downgrade my meson version and see if I can reproduce.
> 
> /Bruce

Hello,

I see two other build failures.

On Ubuntu 20.04 with clang 10 and rdma-core v47.0 (built from source), I see 
errors similar to these:

drivers/common/mlx5/linux/mlx5_glue.h:58:6: error: redefinition of 
'mlx5_ib_uapi_flow_action_packet_reformat_type'
[..]
drivers/common/mlx5/linux/mlx5_glue.h:59:6: error: redefinition of 
'mlx5_ib_uapi_flow_table_type'
[..]
drivers/common/mlx5/linux/mlx5_glue.h:121:2: error: redefinition of enumerator 
'MLX5DV_DR_ACTION_DEST_REFORMAT'
[..]

On Ubuntu 20.04 while cross compiling for ppc64le with 
powerpc64le-linux-gnu-gcc 9.4, I see:

[..]
lib/acl/acl_run_altivec.h:44:16: error: two or more data types in declaration 
specifiers
[..]
lib/acl/acl_run_altivec.h:44:2: error: use of boolean types in AltiVec types is 
invalid
[..]
error: incompatible types when assigning to type '__vector unsigned char' {aka 
'__vector(16) unsigned char'} from type '__vector __bool int' {aka '__vector(4) 
__bool int'}
[..]
lib/acl/acl_run_altivec.h:66:4: error: invalid parameter combination for 
AltiVec intrinsic '__builtin_vec_sel'
[..]

Regards,
Ali

Re: [PATCH v3] build: update DPDK to use C11 standard

[Bruce Richardson]

On Tue, Aug 01, 2023 at 12:42:36PM +, Ali Alnubani wrote:
> > -Original Message-
> > From: Bruce Richardson 
> > Sent: Tuesday, August 1, 2023 1:51 PM
> > To: David Marchand 
> > Cc: Patrick Robb ; Tyler Retzlaff
> > ; dev@dpdk.org; Morten Brørup
> > ; NBU-Contact-Thomas Monjalon
> > (EXTERNAL) 
> > Subject: Re: [PATCH v3] build: update DPDK to use C11 standard
> > 
> > On Tue, Aug 01, 2023 at 11:39:06AM +0100, Bruce Richardson wrote:
> > > On Tue, Aug 01, 2023 at 12:35:21PM +0200, David Marchand wrote:
> > > > On Tue, Aug 1, 2023 at 12:19 PM Bruce Richardson
> > > >  wrote:
> > > > >
> > > > > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote:
> > > > > >Hi Bruce,
> > > > > >I see some failures for this series for our Ubuntu 20.04 
> > > > > > containers.
> > > 
> > > > >
> > > > > Hi again,
> > > > >
> > > > > I've attempted to reproduce this on my Ubuntu 20.04 VM and failed,
> > > > > everything seems to build ok.
> > > > >
> > > > > Looking through the logs, though, there does appear to be a 
> > > > > difference in
> > > > > the configurations in the two cases. I suspect my Ubuntu has an 
> > > > > updated
> > > > > verbs package compared to the image you are using. In the log of the
> > failed
> > > > > build, I see:
> > > > >
> > > > > Checking whether type "struct mlx4_wqe_lso_seg" has member
> > "mss_hdr_size" with dependencies libmlx4, libibverbs: NO
> > > > > Configuring mlx4_autoconf.h using configuration
> > > > >
> > > > > While building in my VM, I have:
> > > > >
> > > > > Checking whether type "struct mlx4_wqe_lso_seg" has member
> > "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached)
> > > > > Configuring mlx4_autoconf.h using configuration
> > > > >
> > > > > So my verbs mlx4 header has got a different set of definitions to 
> > > > > those in
> > > > > the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev
> > package
> > > > > version "28.0-1ubuntu1"
> > > > >
> > > > > Can the CI image be updated to latest 20.04 packages?
> > > > >
> > > > > /Bruce
> > > > >
> > > >
> > > > I can reproduce the issue seen at UNH, with a 20.04.6 container and
> > > > the same libibverbs as you:
> > > > ii  libibverbs-dev:amd64   28.0-1ubuntu1
> > > >   amd64Development files for the libibverbs library
> > > >
> > > > So I suspect something is different in container images..
> > > >
> > > > Pasting the (hopefully) relevant meson logs:
> > > >
> > > > Running compile:
> > > > Working directory:  /root/dpdk/build/meson-private/tmp0ovvvd9g
> > > > Command line:  ccache cc -I/usr/include/libnl3
> > > > /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c -o
> > > > /root/dpdk/build/meson-private/tmp0ovvvd9g/output.obj -pipe -c
> > > > -D_FILE_OFFSET_BITS=64 -O0 -std=c11
> > > >
> > > > Code:
> > > >  #include 
> > > > void bar(void) {
> > > > struct mlx4_wqe_lso_seg foo;
> > > > foo.mss_hdr_size;
> > > >
> > > > };
> > > > Compiler stdout:
> > > >
> > > > Compiler stderr:
> > > >  In file included from /root/dpdk/build/meson-
> > private/tmp0ovvvd9g/testfile.c:1:
> > > > /usr/include/infiniband/mlx4dv.h:176:2: error: unknown type name 'off_t'
> > > >   176 |  off_t   uar_mmap_offset;
> > > >   |  ^
> > > >
> > > > Checking whether type "struct mlx4_wqe_lso_seg" has member
> > > > "mss_hdr_size" with dependencies libmlx4, libibverbs: NO
> > > >
> > > Thanks. I'll dig some more.
> > 
> > I think the meson version may be the culprit here. In my meson log I don't
> > see the -std=c11 flag appended to the test compilation command.
> > 
> > Let me downgrade my meson version and see if I can reproduce.
> > 
> > /Bruce
> 
> Hello,
> 
> I see two other build failures.
> 
> On Ubuntu 20.04 with clang 10 and rdma-core v47.0 (built from source), I see 
> errors similar to these:
> 
> drivers/common/mlx5/linux/mlx5_glue.h:58:6: error: redefinition of 
> 'mlx5_ib_uapi_flow_action_packet_reformat_type'
> [..]
> drivers/common/mlx5/linux/mlx5_glue.h:59:6: error: redefinition of 
> 'mlx5_ib_uapi_flow_table_type'
> [..]
> drivers/common/mlx5/linux/mlx5_glue.h:121:2: error: redefinition of 
> enumerator 'MLX5DV_DR_ACTION_DEST_REFORMAT'
> [..]
> 

I believe I have a fix for these. The checks for the various structure
members need the driver "cflags" passed as args to the check, as the
std=c11 means that some things like off_t type are no longer defined (off_t
is posix)

> On Ubuntu 20.04 while cross compiling for ppc64le with 
> powerpc64le-linux-gnu-gcc 9.4, I see:
> 
> [..]
> lib/acl/acl_run_altivec.h:44:16: error: two or more data types in declaration 
> specifiers
> [..]
> lib/acl/acl_run_altivec.h:44:2: error: use of boolean types in AltiVec types 
> is invalid
> [..]
> error: incompatible types when assigning to type '__vector unsigned char' 
> {aka '__vector(16) unsigned char'} from type '__vector __bool int' {aka 
> '__vector(4) __bool int'}
> [..]
> lib/acl/acl_run

[PATCH v4] build: update DPDK to use C11 standard

[Bruce Richardson]

As previously announced, DPDK 23.11 will require a C11 supporting
compiler and will use the C11 standard in all builds.

Forcing use of the C standard, rather than the standard with
GNU extensions, means that some posix definitions which are not in
the C standard are unavailable by default. We fix this by ensuring
the correct defines or cflags are passed to the components that
need them.

Signed-off-by: Bruce Richardson 
Acked-by: Morten Brørup 
Acked-by: Tyler Retzlaff 
---
V4:
* pass cflags to the structure and definition checks in mlx* drivers
  to ensure posix definitions - as well as C-standard ones - are
  available.

V3:
* remove (now unneeded) use of -std=gnu99 in failsafe net driver.

V2:
* Resubmit now that 23.11-rc0 patch applied
* Add _POSIX_C_SOURCE macro to eal_common_errno.c to get POSIX
  definition of strerror_r() with c11 standard.
---
 doc/guides/linux_gsg/sys_reqs.rst  |  3 ++-
 doc/guides/rel_notes/deprecation.rst   | 18 --
 doc/guides/rel_notes/release_23_11.rst | 17 +
 drivers/common/mlx5/linux/meson.build  |  5 +++--
 drivers/net/failsafe/meson.build   |  1 -
 drivers/net/mlx4/meson.build   |  4 ++--
 lib/eal/common/eal_common_errno.c  |  1 +
 meson.build|  1 +
 8 files changed, 26 insertions(+), 24 deletions(-)

diff --git a/doc/guides/linux_gsg/sys_reqs.rst 
b/doc/guides/linux_gsg/sys_reqs.rst
index dfeaf4e1c5..13be715933 100644
--- a/doc/guides/linux_gsg/sys_reqs.rst
+++ b/doc/guides/linux_gsg/sys_reqs.rst
@@ -27,7 +27,8 @@ Compilation of the DPDK
 The setup commands and installed packages needed on various systems may be 
different.
 For details on Linux distributions and the versions tested, please consult 
the DPDK Release Notes.
 
-*   General development tools including a supported C compiler such as gcc 
(version 4.9+) or clang (version 3.4+),
+*   General development tools including a C compiler supporting the C11 
standard,
+including standard atomics, for example: GCC (version 5.0+) or Clang 
(version 3.6+),
 and ``pkg-config`` or ``pkgconf`` to be used when building end-user 
binaries against DPDK.
 
 * For RHEL/Fedora systems these can be installed using ``dnf groupinstall 
"Development Tools"``
diff --git a/doc/guides/rel_notes/deprecation.rst 
b/doc/guides/rel_notes/deprecation.rst
index 494b401cda..cc939d3c67 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -17,24 +17,6 @@ Other API and ABI deprecation notices are to be posted below.
 Deprecation Notices
 ---
 
-* C Compiler: From DPDK 23.11 onwards,
-  building DPDK will require a C compiler which supports the C11 standard,
-  including support for C11 standard atomics.
-
-  More specifically, the requirements will be:
-
-  * Support for flag "-std=c11" (or similar)
-  * __STDC_NO_ATOMICS__ is *not defined* when using c11 flag
-
-  Please note:
-
-  * C11, including standard atomics, is supported from GCC version 5 onwards,
-and is the default language version in that release
-(Ref: https://gcc.gnu.org/gcc-5/changes.html)
-  * C11 is the default compilation mode in Clang from version 3.6,
-which also added support for standard atomics
-(Ref: https://releases.llvm.org/3.6.0/tools/clang/docs/ReleaseNotes.html)
-
 * build: Enabling deprecated libraries (``flow_classify``, ``kni``)
   won't be possible anymore through the use of the ``disable_libs`` build 
option.
   A new build option for deprecated libraries will be introduced instead.
diff --git a/doc/guides/rel_notes/release_23_11.rst 
b/doc/guides/rel_notes/release_23_11.rst
index 6b4dd21fd0..c8b9ed456c 100644
--- a/doc/guides/rel_notes/release_23_11.rst
+++ b/doc/guides/rel_notes/release_23_11.rst
@@ -20,6 +20,23 @@ DPDK Release 23.11
   ninja -C build doc
   xdg-open build/doc/guides/html/rel_notes/release_23_11.html
 
+* Build Requirements: From DPDK 23.11 onwards,
+  building DPDK will require a C compiler which supports the C11 standard,
+  including support for C11 standard atomics.
+
+  More specifically, the requirements will be:
+
+  * Support for flag "-std=c11" (or similar)
+  * __STDC_NO_ATOMICS__ is *not defined* when using c11 flag
+
+  Please note:
+
+  * C11, including standard atomics, is supported from GCC version 5 onwards,
+and is the default language version in that release
+(Ref: https://gcc.gnu.org/gcc-5/changes.html)
+  * C11 is the default compilation mode in Clang from version 3.6,
+which also added support for standard atomics
+(Ref: https://releases.llvm.org/3.6.0/tools/clang/docs/ReleaseNotes.html)
 
 New Features
 
diff --git a/drivers/common/mlx5/linux/meson.build 
b/drivers/common/mlx5/linux/meson.build
index 15edc13041..b3a64547c5 100644
--- a/drivers/common/mlx5/linux/meson.build
+++ b/drivers/common/mlx5/linux/meson.build
@@ -231,11 +231,12 @@ if  libmtcr_ul_found
 endif
 
 foreach arg:has_sym_args
-mlx5_config.set

Re: [PATCH v3] build: update DPDK to use C11 standard

[Bruce Richardson]

On Tue, Aug 01, 2023 at 12:42:36PM +, Ali Alnubani wrote:

> 
> On Ubuntu 20.04 while cross compiling for ppc64le with 
> powerpc64le-linux-gnu-gcc 9.4, I see:
> 
> [..]
> lib/acl/acl_run_altivec.h:44:16: error: two or more data types in declaration 
> specifiers
> [..]
> lib/acl/acl_run_altivec.h:44:2: error: use of boolean types in AltiVec types 
> is invalid
> [..]
> error: incompatible types when assigning to type '__vector unsigned char' 
> {aka '__vector(16) unsigned char'} from type '__vector __bool int' {aka 
> '__vector(4) __bool int'}
> [..]
> lib/acl/acl_run_altivec.h:66:4: error: invalid parameter combination for 
> AltiVec intrinsic '__builtin_vec_sel'
> [..]
> 
Hi Ali,

where can I get the full log for this error? Is it recorded in patchwork
under a particular test set? I see compile runs for loongarch and
aarch(64), but nothing listed for PPC.

/Bruce

Re: [PATCH v4] build: update DPDK to use C11 standard

[David Marchand]

On Tue, Aug 1, 2023 at 3:16 PM Bruce Richardson
 wrote:
>
> As previously announced, DPDK 23.11 will require a C11 supporting
> compiler and will use the C11 standard in all builds.
>
> Forcing use of the C standard, rather than the standard with
> GNU extensions, means that some posix definitions which are not in
> the C standard are unavailable by default. We fix this by ensuring
> the correct defines or cflags are passed to the components that
> need them.
>
> Signed-off-by: Bruce Richardson 
> Acked-by: Morten Brørup 
> Acked-by: Tyler Retzlaff 
> ---
> V4:
> * pass cflags to the structure and definition checks in mlx* drivers
>   to ensure posix definitions - as well as C-standard ones - are
>   available.

With this v4, mlx4 builds fine in my Ubuntu 20.04.6 container.
However, I think the mlx4dv.h includes are probably faulty: as this
header is using off_t, it should include sys/types.h in the first
place.
https://github.com/linux-rdma/rdma-core/blob/master/providers/mlx4/mlx4dv.h#L36

This had been fixed in the mlx5 header in some rdma-core change in the
past: https://github.com/linux-rdma/rdma-core/commit/d2389b34ccc5


-- 
David Marchand

Re: [PATCH v4] build: update DPDK to use C11 standard

[Bruce Richardson]

On Tue, Aug 01, 2023 at 03:24:19PM +0200, David Marchand wrote:
> On Tue, Aug 1, 2023 at 3:16 PM Bruce Richardson
>  wrote:
> >
> > As previously announced, DPDK 23.11 will require a C11 supporting
> > compiler and will use the C11 standard in all builds.
> >
> > Forcing use of the C standard, rather than the standard with
> > GNU extensions, means that some posix definitions which are not in
> > the C standard are unavailable by default. We fix this by ensuring
> > the correct defines or cflags are passed to the components that
> > need them.
> >
> > Signed-off-by: Bruce Richardson 
> > Acked-by: Morten Brørup 
> > Acked-by: Tyler Retzlaff 
> > ---
> > V4:
> > * pass cflags to the structure and definition checks in mlx* drivers
> >   to ensure posix definitions - as well as C-standard ones - are
> >   available.
> 
> With this v4, mlx4 builds fine in my Ubuntu 20.04.6 container.
> However, I think the mlx4dv.h includes are probably faulty: as this
> header is using off_t, it should include sys/types.h in the first
> place.
> https://github.com/linux-rdma/rdma-core/blob/master/providers/mlx4/mlx4dv.h#L36
> 
> This had been fixed in the mlx5 header in some rdma-core change in the
> past: https://github.com/linux-rdma/rdma-core/commit/d2389b34ccc5
> 
Even if that were fixed, I still think the correct behaviour in our build
here is to test the structures using the same flags as will be used to
build the final lib.

/Bruce

Re: [PATCH v4] build: update DPDK to use C11 standard

[David Marchand]

On Tue, Aug 1, 2023 at 3:29 PM Bruce Richardson
 wrote:
>
> On Tue, Aug 01, 2023 at 03:24:19PM +0200, David Marchand wrote:
> > On Tue, Aug 1, 2023 at 3:16 PM Bruce Richardson
> >  wrote:
> > >
> > > As previously announced, DPDK 23.11 will require a C11 supporting
> > > compiler and will use the C11 standard in all builds.
> > >
> > > Forcing use of the C standard, rather than the standard with
> > > GNU extensions, means that some posix definitions which are not in
> > > the C standard are unavailable by default. We fix this by ensuring
> > > the correct defines or cflags are passed to the components that
> > > need them.
> > >
> > > Signed-off-by: Bruce Richardson 
> > > Acked-by: Morten Brørup 
> > > Acked-by: Tyler Retzlaff 
> > > ---
> > > V4:
> > > * pass cflags to the structure and definition checks in mlx* drivers
> > >   to ensure posix definitions - as well as C-standard ones - are
> > >   available.
> >
> > With this v4, mlx4 builds fine in my Ubuntu 20.04.6 container.
> > However, I think the mlx4dv.h includes are probably faulty: as this
> > header is using off_t, it should include sys/types.h in the first
> > place.
> > https://github.com/linux-rdma/rdma-core/blob/master/providers/mlx4/mlx4dv.h#L36
> >
> > This had been fixed in the mlx5 header in some rdma-core change in the
> > past: https://github.com/linux-rdma/rdma-core/commit/d2389b34ccc5
> >
> Even if that were fixed, I still think the correct behaviour in our build
> here is to test the structures using the same flags as will be used to
> build the final lib.

Yes, compiling for testing and using the structures must be aligned.


-- 
David Marchand

[PATCH v2] build: check drivers class dependencies early

[David Marchand]

Drivers implementing a class of devices (for example, drivers/event)
depend on the associated abstraction library (lib/eventdev).
This dependency is expressed in the top level meson.build for this class
(drivers/event/meson.build).

As we are making more libraries optional, custom constructs referencing
the class dependencies in some drivers meson.build (event/dlb2) may break.

It would be possible to add more checks in those drivers meson.build but
it is more straightforward to not even consider a driver meson.build when
the class dependencies are not met.

Signed-off-by: David Marchand 
Acked-by: Morten Brørup 
---
Changes since v1:
- added break on the first missing dependency,
- added logs for disabled drivers,

---
 drivers/meson.build | 19 +++
 1 file changed, 19 insertions(+)

diff --git a/drivers/meson.build b/drivers/meson.build
index 74ae8cb96b..c909070c30 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -70,6 +70,25 @@ foreach subpath:subdirs
 else
 class = subpath
 subdir(class)
+skip_class = false
+foreach d:std_deps
+if not is_variable('shared_rte_' + d)
+skip_class = true
+reason = 'missing internal dependency, "@0@"'.format(d)
+if dpdk_libs_deprecated.contains(d)
+reason += ' (deprecated lib)'
+endif
+message('Disabling @1@/* drivers: missing internal dependency 
"@0@"'
+.format(d, class))
+break
+endif
+endforeach
+if skip_class
+drv_path = join_paths(class, '*')
+dpdk_drvs_disabled += drv_path
+set_variable(drv_path.underscorify() + '_disable_reason', reason)
+continue
+endif
 endif
 
 # save class name on first occurrence
-- 
2.41.0

RE: [PATCH v3] build: update DPDK to use C11 standard

[Ali Alnubani]

> -Original Message-
> From: Bruce Richardson 
> Sent: Tuesday, August 1, 2023 4:22 PM
> To: Ali Alnubani 
> Cc: David Marchand ; Patrick Robb
> ; Tyler Retzlaff ;
> dev@dpdk.org; Morten Brørup ; NBU-
> Contact-Thomas Monjalon (EXTERNAL) 
> Subject: Re: [PATCH v3] build: update DPDK to use C11 standard
> 
> On Tue, Aug 01, 2023 at 12:42:36PM +, Ali Alnubani wrote:
> 
> >
> > On Ubuntu 20.04 while cross compiling for ppc64le with powerpc64le-linux-
> gnu-gcc 9.4, I see:
> >
> > [..]
> > lib/acl/acl_run_altivec.h:44:16: error: two or more data types in 
> > declaration
> specifiers
> > [..]
> > lib/acl/acl_run_altivec.h:44:2: error: use of boolean types in AltiVec 
> > types is
> invalid
> > [..]
> > error: incompatible types when assigning to type '__vector unsigned char'
> {aka '__vector(16) unsigned char'} from type '__vector __bool int' {aka
> '__vector(4) __bool int'}
> > [..]
> > lib/acl/acl_run_altivec.h:66:4: error: invalid parameter combination for
> AltiVec intrinsic '__builtin_vec_sel'
> > [..]
> >
> Hi Ali,
> 
> where can I get the full log for this error? Is it recorded in patchwork
> under a particular test set? I see compile runs for loongarch and
> aarch(64), but nothing listed for PPC.

Hello Bruce,

I run this build internally. Attaching build log with more info about the 
environment.

Note: I'm using an out-of-tree cross file because the in-tree one doesn't set 
binaries.pkgconfig.
$ meson --werror --buildtype=debugoptimized --cross-file 
/tmp/ppc64le-power8-linux-gcc -Dexamples=all 
-Ddisable_drivers=*/cnxk,*/octeontx -Dc_args='-I/opt/cudart' 
/tmp/build-ppc64-gcc
The Meson build system
Version: 1.2.0
Source dir: /root/dpdk
Build dir: /tmp/build-ppc64-gcc
Build type: cross build
Program cat found: YES (/usr/bin/cat)
Project name: DPDK
Project version: 23.11.0-rc0
C compiler for the host machine: powerpc64le-linux-gnu-gcc (gcc 9.4.0 
"powerpc64le-linux-gnu-gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0")
C linker for the host machine: powerpc64le-linux-gnu-gcc ld.bfd 2.34
C compiler for the build machine: ccache cc (gcc 9.4.0 "cc (Ubuntu 
9.4.0-1ubuntu1~20.04.1) 9.4.0")
C linker for the build machine: cc ld.bfd 2.34
Build machine cpu family: x86_64
Build machine cpu: x86_64
Host machine cpu family: ppc64
Host machine cpu: power8
Target machine cpu family: ppc64
Target machine cpu: power8
Message: ## Building in Developer Mode ##
Program pkg-config found: YES (/usr/bin/pkg-config)
Program check-symbols.sh found: YES (/root/dpdk/buildtools/check-symbols.sh)
Program options-ibverbs-static.sh found: YES 
(/root/dpdk/buildtools/options-ibverbs-static.sh)
Program objdump found: YES (/usr/bin/objdump)
Program python3 found: YES (/usr/bin/python3)
Program cat found: YES (/usr/bin/cat)
Checking for size of "void *" : 8 
Checking for size of "void *" : 8 
Library m found: YES
Library numa found: NO
Library fdt found: NO
Library execinfo found: NO
Has header "execinfo.h" : YES 
Found pkg-config: /usr/bin/powerpc64le-linux-gnu-pkg-config (0.29.1)
Run-time dependency libarchive found: NO (tried pkgconfig)
Run-time dependency libbsd found: NO (tried pkgconfig)
Run-time dependency jansson found: NO (tried pkgconfig)
Run-time dependency openssl found: NO (tried pkgconfig)
Run-time dependency libpcap found: NO (tried pkgconfig)
Library pcap found: NO
Compiler for C supports arguments -Wcast-qual: YES 
Compiler for C supports arguments -Wdeprecated: YES 
Compiler for C supports arguments -Wformat: YES 
Compiler for C supports arguments -Wformat-nonliteral: YES 
Compiler for C supports arguments -Wformat-security: YES 
Compiler for C supports arguments -Wmissing-declarations: YES 
Compiler for C supports arguments -Wmissing-prototypes: YES 
Compiler for C supports arguments -Wnested-externs: YES 
Compiler for C supports arguments -Wold-style-definition: YES 
Compiler for C supports arguments -Wpointer-arith: YES 
Compiler for C supports arguments -Wsign-compare: YES 
Compiler for C supports arguments -Wstrict-prototypes: YES 
Compiler for C supports arguments -Wundef: YES 
Compiler for C supports arguments -Wwrite-strings: YES 
Compiler for C supports arguments -Wno-address-of-packed-member: YES 
Compiler for C supports arguments -Wno-packed-not-aligned: YES 
Compiler for C supports arguments -Wno-missing-field-initializers: YES 
Compiler for C supports arguments -mcpu=power9: YES 
Compiler for C supports arguments -Wno-format-truncation: YES 
Message: lib/kvargs: Defining dependency "kvargs"
Message: lib/telemetry: Defining dependency "telemetry"
Checking for function "getentropy" : NO 
Message: lib/eal: Defining dependency "eal"
Message: lib/ring: Defining dependency "ring"
Message: lib/rcu: Defining dependency "rcu"
Message: lib/mempool: Defining dependency "mempool"
Message: lib/mbuf: Defining dependency "mbuf"
Message: lib/net: Defining dependency "net"
Message: lib/meter: Defining dependency "meter"
Message: lib/ethdev: Defining dependency "ethdev"
Message: lib/pci: Defining dependency "pci"
Me

[PATCH v2] eventdev/eth_rx: update adapter create APIs

[Naga Harish K S V]

The adapter create APIs such as rte_event_eth_rx_adapter_create_ext() and
rte_event_eth_rx_adapter_create() are updated to take additional argument
as a pointer of type struct rte_event_eth_rx_adapter_params.

The API rte_event_eth_rx_adapter_create_with_params() is
deprecated.

Signed-off-by: Naga Harish K S V 
---
v2:
*  Fix doxygen compile issue and warning
---
---
 app/test-eventdev/test_perf_common.c  |   2 +-
 app/test-eventdev/test_pipeline_common.c  |   2 +-
 app/test/test_event_eth_rx_adapter.c  |  22 ++--
 app/test/test_security_inline_proto.c |   2 +-
 .../pipeline_worker_generic.c |   2 +-
 .../eventdev_pipeline/pipeline_worker_tx.c|   2 +-
 examples/ipsec-secgw/event_helper.c   |   2 +-
 examples/l2fwd-event/l2fwd_event_generic.c|   2 +-
 .../l2fwd-event/l2fwd_event_internal_port.c   |   2 +-
 examples/l3fwd/l3fwd_event_generic.c  |   2 +-
 examples/l3fwd/l3fwd_event_internal_port.c|   2 +-
 lib/eventdev/rte_event_eth_rx_adapter.c   | 100 --
 lib/eventdev/rte_event_eth_rx_adapter.h   |  36 ++-
 lib/eventdev/version.map  |   1 -
 14 files changed, 74 insertions(+), 105 deletions(-)

diff --git a/app/test-eventdev/test_perf_common.c 
b/app/test-eventdev/test_perf_common.c
index 5e0255cfeb..0c6c252f7d 100644
--- a/app/test-eventdev/test_perf_common.c
+++ b/app/test-eventdev/test_perf_common.c
@@ -1002,7 +1002,7 @@ perf_event_rx_adapter_setup(struct evt_options *opt, 
uint8_t stride,
}
queue_conf.ev.queue_id = prod * stride;
ret = rte_event_eth_rx_adapter_create(prod, opt->dev_id,
-   &prod_conf);
+   &prod_conf, NULL);
if (ret) {
evt_err("failed to create rx adapter[%d]", prod);
return ret;
diff --git a/app/test-eventdev/test_pipeline_common.c 
b/app/test-eventdev/test_pipeline_common.c
index b111690b7c..5ae175f2c7 100644
--- a/app/test-eventdev/test_pipeline_common.c
+++ b/app/test-eventdev/test_pipeline_common.c
@@ -571,7 +571,7 @@ pipeline_event_rx_adapter_setup(struct evt_options *opt, 
uint8_t stride,
}
queue_conf.ev.queue_id = prod * stride;
ret = rte_event_eth_rx_adapter_create(prod, opt->dev_id,
-   &prod_conf);
+   &prod_conf, NULL);
if (ret) {
evt_err("failed to create rx adapter[%d]", prod);
return ret;
diff --git a/app/test/test_event_eth_rx_adapter.c 
b/app/test/test_event_eth_rx_adapter.c
index 52d146f97c..42edcb625a 100644
--- a/app/test/test_event_eth_rx_adapter.c
+++ b/app/test/test_event_eth_rx_adapter.c
@@ -401,7 +401,7 @@ adapter_create(void)
rx_p_conf.dequeue_depth = dev_info.max_event_port_dequeue_depth;
rx_p_conf.enqueue_depth = dev_info.max_event_port_enqueue_depth;
err = rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID,
-   &rx_p_conf);
+   &rx_p_conf, NULL);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
 
return err;
@@ -427,17 +427,17 @@ adapter_create_with_params(void)
rxa_params.use_queue_event_buf = false;
rxa_params.event_buf_size = 0;
 
-   err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
+   err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
TEST_DEV_ID, &rx_p_conf, &rxa_params);
TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
 
rxa_params.use_queue_event_buf = true;
 
-   err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
+   err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
TEST_DEV_ID, &rx_p_conf, &rxa_params);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
 
-   err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
+   err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
TEST_DEV_ID, &rx_p_conf, &rxa_params);
TEST_ASSERT(err == -EEXIST, "Expected -EEXIST got %d", err);
 
@@ -567,15 +567,15 @@ adapter_create_free(void)
};
 
err = rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID,
-   NULL);
+   NULL, NULL);
TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
 
err = rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID,
-   &rx_p_conf);
+   &rx_p_conf, NULL);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
 
err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
-   TEST_DEV_ID, &rx_p_conf);
+   

Re: [PATCH v3] build: update DPDK to use C11 standard

[Bruce Richardson]

+David Christensen

On Tue, Aug 01, 2023 at 01:47:19PM +, Ali Alnubani wrote:
> > -Original Message-
> > From: Bruce Richardson 
> > Sent: Tuesday, August 1, 2023 4:22 PM
> > To: Ali Alnubani 
> > Cc: David Marchand ; Patrick Robb
> > ; Tyler Retzlaff ;
> > dev@dpdk.org; Morten Brørup ; NBU-
> > Contact-Thomas Monjalon (EXTERNAL) 
> > Subject: Re: [PATCH v3] build: update DPDK to use C11 standard
> > 
> > On Tue, Aug 01, 2023 at 12:42:36PM +, Ali Alnubani wrote:
> > 
> > >
> > > On Ubuntu 20.04 while cross compiling for ppc64le with powerpc64le-linux-
> > gnu-gcc 9.4, I see:
> > >
> > > [..]
> > > lib/acl/acl_run_altivec.h:44:16: error: two or more data types in 
> > > declaration
> > specifiers
> > > [..]
> > > lib/acl/acl_run_altivec.h:44:2: error: use of boolean types in AltiVec 
> > > types is
> > invalid
> > > [..]
> > > error: incompatible types when assigning to type '__vector unsigned char'
> > {aka '__vector(16) unsigned char'} from type '__vector __bool int' {aka
> > '__vector(4) __bool int'}
> > > [..]
> > > lib/acl/acl_run_altivec.h:66:4: error: invalid parameter combination for
> > AltiVec intrinsic '__builtin_vec_sel'
> > > [..]
> > >
> > Hi Ali,
> > 
> > where can I get the full log for this error? Is it recorded in patchwork
> > under a particular test set? I see compile runs for loongarch and
> > aarch(64), but nothing listed for PPC.
> 
> Hello Bruce,
> 
> I run this build internally. Attaching build log with more info about the 
> environment.
> 
> Note: I'm using an out-of-tree cross file because the in-tree one doesn't set 
> binaries.pkgconfig.



> In file included from ../../root/dpdk/lib/acl/acl_run_altivec.c:6:
> ../../root/dpdk/lib/acl/acl_run_altivec.h: In function 
> 'resolve_priority_altivec':
> ../../root/dpdk/lib/acl/acl_run_altivec.h:44:16: error: two or more data 
> types in declaration specifiers
>44 |  __vector bool int selector;
>   |^~~
> ../../root/dpdk/lib/acl/acl_run_altivec.h:44:2: error: use of boolean types 
> in AltiVec types is invalid
>44 |  __vector bool int selector;
>   |  ^~~~

I don't know anything about altivec, unfortunately, and the use of "bool
int" together looks very strange. Adding PPC maintainer to thread.

David, can you perhaps help out with these issues?

Thanks,
/Bruce

RE: [PATCH v3] build: update DPDK to use C11 standard

[Ali Alnubani]

> -Original Message-
> From: Thomas Monjalon 
> Sent: Tuesday, August 1, 2023 1:37 PM
> To: Patrick Robb ; Bruce Richardson
> ; Ali Alnubani 
> Cc: Tyler Retzlaff ; dev@dpdk.org; Morten
> Brørup ; david.march...@redhat.com;
> Raslan Darawsheh 
> Subject: Re: [PATCH v3] build: update DPDK to use C11 standard
> 
> 01/08/2023 12:19, Bruce Richardson:
> > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote:
> > >Hi Bruce,
> > >I see some failures for this series for our Ubuntu 20.04 containers.
> > >And, our DTS testbeds which are on ubuntu 20.04 are skipping running
> > >testsuites because they can't compile DPDK. So, that's why it has some
> > >missing results for a couple of the Intel NICs. For context, I'll paste
> > >below where the compile job terminates in one of our containerized
> > >compile test runs. The GCC in use here is version 9.4, so it meets the
> > >requirements as described in your patch as far as I can tell. I'll
> > >check it out more tomorrow to see whether it's an infra failure, like
> > >some missing dependencies. Please let me know if we expect to have no
> > >issues with 20.04 or if this is anticipated.
> > >Thanks!
> > >[1638/2730] Generating symbol file
> > >
> 'drivers/a715181@@rte_net_ixgbe@sha/librte_net_ixgbe.so.24.0.symbols'.
> > >[1639/2730] Compiling C object
> > >'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o'.
> > >FAILED: drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o
> > >ccache cc -Idrivers/a715181@@tmp_rte_net_mlx4@sta -Idrivers
> > >-I../drivers -Idrivers/net/mlx4 -I../drivers/net/mlx4 -Ilib/ethdev
> > >-I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include
> > >-I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include
> > >-Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common
> > >-I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs
> > >-Ilib/telemetry/../metrics -I../lib/telemetry/../metrics
> > >-Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf
> > >-I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring
> > >-Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci
> > >-I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev
> > >-I../drivers/bus/vdev -I/usr/include/libnl3 -fdiagnostics-color=always
> > >-pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror
> > >-std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat
> > >-Wformat-nonliteral -Wformat-security -Wmissing-declarations
> > >-Wmissing-prototypes -Wnested-externs -Wold-style-definition
> > >-Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef
> > >-Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-
> aligned
> > >-Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native
> > >-DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-
> truncation
> > >-std=c11 -Wno-strict-prototypes -D_BSD_SOURCE -D_DEFAULT_SOURCE
> > >-D_XOPEN_SOURCE=600 -UPEDANTIC -
> DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.mlx4
> > >-MD -MQ
> 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -MF
> > >'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o.d' -o
> > >'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -c
> > >../drivers/net/mlx4/mlx4.c
> > >In file included from ../drivers/net/mlx4/mlx4_rxtx.h:27,
> > > from ../drivers/net/mlx4/mlx4.c:49:
> > >../drivers/net/mlx4/mlx4_prm.h:111:8: error: redefinition of 'struct
> > >mlx4_wqe_lso_seg'
> > >  111 | struct mlx4_wqe_lso_seg {
> > >  |^~~~
> > >In file included from ../drivers/net/mlx4/mlx4_glue.h:16,
> > > from ../drivers/net/mlx4/mlx4.c:46:
> > >/usr/include/infiniband/mlx4dv.h:410:8: note: originally defined here
> > >  410 | struct mlx4_wqe_lso_seg {
> > >  |^~~~
> > >ninja: build stopped: subcommand failed.
> >
> > Hi again,
> >
> > I've attempted to reproduce this on my Ubuntu 20.04 VM and failed,
> > everything seems to build ok.
> >
> > Looking through the logs, though, there does appear to be a difference in
> > the configurations in the two cases. I suspect my Ubuntu has an updated
> > verbs package compared to the image you are using. In the log of the failed
> > build, I see:
> >
> > Checking whether type "struct mlx4_wqe_lso_seg" has member
> "mss_hdr_size" with dependencies libmlx4, libibverbs: NO
> > Configuring mlx4_autoconf.h using configuration
> >
> > While building in my VM, I have:
> >
> > Checking whether type "struct mlx4_wqe_lso_seg" has member
> "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached)
> > Configuring mlx4_autoconf.h using configuration
> >
> > So my verbs mlx4 header has got a different set of definitions to those in
> >

Re: [PATCH v2] build: check drivers class dependencies early

[Bruce Richardson]

On Tue, Aug 01, 2023 at 03:41:33PM +0200, David Marchand wrote:
> Drivers implementing a class of devices (for example, drivers/event)
> depend on the associated abstraction library (lib/eventdev).
> This dependency is expressed in the top level meson.build for this class
> (drivers/event/meson.build).
> 
> As we are making more libraries optional, custom constructs referencing
> the class dependencies in some drivers meson.build (event/dlb2) may break.
> 
> It would be possible to add more checks in those drivers meson.build but
> it is more straightforward to not even consider a driver meson.build when
> the class dependencies are not met.
> 
> Signed-off-by: David Marchand 
> Acked-by: Morten Brørup 
Acked-by: Bruce Richardson 

Re: [PATCH] app/testpmd: add flush multicast MAC address command

[Stephen Hemminger]

On Tue, 1 Aug 2023 10:43:04 +0800
Dengdui Huang  wrote:

> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 0d0723f659..2d9d925776 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -494,6 +494,9 @@ static void cmd_help_long_parsed(void *parsed_result,
>   "mac_addr remove (port_id) (XX:XX:XX:XX:XX:XX)\n"
>   "Remove a MAC address from port_id.\n\n"
>  
> + "mcast_addr flush (port_id)\n"
> + "To flush the set of multicast addresses.\n\n"
> +
>   "mac_addr set (port_id) (XX:XX:XX:XX:XX:XX)\n"
>   "Set the default MAC address for port_id.\n\n"

Why out this in middle of the mac_addr commands? better to be in logical or 
alpha order.

[PATCH] net/mlx5: fix leak in sysfs port name translation

[David Marchand]

getline() may allocate a buffer even though it returns -1:
"""
If  *lineptr  is set to NULL before the call, then getline() will allocate
a buffer for storing the line.  This buffer should be freed by the user
program even if getline() failed.
"""

This leak has been observed on a RHEL8 system with two CX5 PF devices
(no VFs).

ASan reports:
==8899==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 120 byte(s) in 1 object(s) allocated from:
#0 0x7fe58576aba8 in __interceptor_malloc
(/lib64/libasan.so.5+0xefba8)
#1 0x7fe583e866b2 in __getdelim (/lib64/libc.so.6+0x886b2)
#2 0x327bd23 in mlx5_sysfs_switch_info
../drivers/net/mlx5/linux/mlx5_ethdev_os.c:1084
#3 0x3271f86 in mlx5_os_pci_probe_pf
../drivers/net/mlx5/linux/mlx5_os.c:2282
#4 0x3273c83 in mlx5_os_pci_probe
../drivers/net/mlx5/linux/mlx5_os.c:2497
#5 0x327475f in mlx5_os_net_probe
../drivers/net/mlx5/linux/mlx5_os.c:2578
#6 0xc6eac7 in drivers_probe
../drivers/common/mlx5/mlx5_common.c:937
#7 0xc6f150 in mlx5_common_dev_probe
../drivers/common/mlx5/mlx5_common.c:1027
#8 0xc8ef80 in mlx5_common_pci_probe
../drivers/common/mlx5/mlx5_common_pci.c:168
#9 0xc21b67 in rte_pci_probe_one_driver
../drivers/bus/pci/pci_common.c:312
#10 0xc2224c in pci_probe_all_drivers
../drivers/bus/pci/pci_common.c:396
#11 0xc222f4 in pci_probe ../drivers/bus/pci/pci_common.c:423
#12 0xb71fff in rte_bus_probe ../lib/eal/common/eal_common_bus.c:78
#13 0xbe6888 in rte_eal_init ../lib/eal/linux/eal.c:1300
#14 0x5ec717 in main ../app/test-pmd/testpmd.c:4515
#15 0x7fe583e38d84 in __libc_start_main (/lib64/libc.so.6+0x3ad84)

As far as why getline() errors, strace gives a hint:
8516  openat(AT_FDCWD, "/sys/class/net/enp130s0f0/phys_port_name",
O_RDONLY) = 34
8516  fstat(34, {st_mode=S_IFREG|0444, st_size=4096, ...}) = 0
8516  read(34, 0x62198900, 4096)= -1 EOPNOTSUPP (Operation
not supported)

Fixes: f8a226ed65fa ("net/mlx5: fix sysfs port name translation")
Cc: sta...@dpdk.org

Signed-off-by: David Marchand 
---
 drivers/net/mlx5/linux/mlx5_ethdev_os.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c 
b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index 639e629fe4..dd5a0c546d 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -1083,6 +1083,7 @@ mlx5_sysfs_switch_info(unsigned int ifindex, struct 
mlx5_switch_info *info)
 
line_size = getline(&port_name, &port_name_size, file);
if (line_size < 0) {
+   free(port_name);
fclose(file);
rte_errno = errno;
return -rte_errno;
-- 
2.41.0

Re: [[PATCH v1] 3/8] net/rnp: add device init and uninit

[Stephen Hemminger]

On Tue,  1 Aug 2023 06:43:41 +
Wenbo Cao  wrote:

> + return 0;
> +eth_alloc_error:
> +init_failed:

Why have two labels for same place, to later patches insert code here?

Re: [PATCH v2] eventdev/eth_rx: update adapter create APIs

[Jerin Jacob]

On Tue, Aug 1, 2023 at 7:22 PM Naga Harish K S V
 wrote:
>
> The adapter create APIs such as rte_event_eth_rx_adapter_create_ext() and
> rte_event_eth_rx_adapter_create() are updated to take additional argument
> as a pointer of type struct rte_event_eth_rx_adapter_params.
>
> The API rte_event_eth_rx_adapter_create_with_params() is
> deprecated.
>
> Signed-off-by: Naga Harish K S V 

Pleas check v1 comment
http://mails.dpdk.org/archives/dev/2023-August/273602.html

> ---
> v2:
> *  Fix doxygen compile issue and warning
> ---
> ---
>  app/test-eventdev/test_perf_common.c  |   2 +-
>  app/test-eventdev/test_pipeline_common.c  |   2 +-
>  app/test/test_event_eth_rx_adapter.c  |  22 ++--
>  app/test/test_security_inline_proto.c |   2 +-
>  .../pipeline_worker_generic.c |   2 +-
>  .../eventdev_pipeline/pipeline_worker_tx.c|   2 +-
>  examples/ipsec-secgw/event_helper.c   |   2 +-
>  examples/l2fwd-event/l2fwd_event_generic.c|   2 +-
>  .../l2fwd-event/l2fwd_event_internal_port.c   |   2 +-
>  examples/l3fwd/l3fwd_event_generic.c  |   2 +-
>  examples/l3fwd/l3fwd_event_internal_port.c|   2 +-
>  lib/eventdev/rte_event_eth_rx_adapter.c   | 100 --
>  lib/eventdev/rte_event_eth_rx_adapter.h   |  36 ++-
>  lib/eventdev/version.map  |   1 -
>  14 files changed, 74 insertions(+), 105 deletions(-)
>
> diff --git a/app/test-eventdev/test_perf_common.c 
> b/app/test-eventdev/test_perf_common.c
> index 5e0255cfeb..0c6c252f7d 100644
> --- a/app/test-eventdev/test_perf_common.c
> +++ b/app/test-eventdev/test_perf_common.c
> @@ -1002,7 +1002,7 @@ perf_event_rx_adapter_setup(struct evt_options *opt, 
> uint8_t stride,
> }
> queue_conf.ev.queue_id = prod * stride;
> ret = rte_event_eth_rx_adapter_create(prod, opt->dev_id,
> -   &prod_conf);
> +   &prod_conf, NULL);
> if (ret) {
> evt_err("failed to create rx adapter[%d]", prod);
> return ret;
> diff --git a/app/test-eventdev/test_pipeline_common.c 
> b/app/test-eventdev/test_pipeline_common.c
> index b111690b7c..5ae175f2c7 100644
> --- a/app/test-eventdev/test_pipeline_common.c
> +++ b/app/test-eventdev/test_pipeline_common.c
> @@ -571,7 +571,7 @@ pipeline_event_rx_adapter_setup(struct evt_options *opt, 
> uint8_t stride,
> }
> queue_conf.ev.queue_id = prod * stride;
> ret = rte_event_eth_rx_adapter_create(prod, opt->dev_id,
> -   &prod_conf);
> +   &prod_conf, NULL);
> if (ret) {
> evt_err("failed to create rx adapter[%d]", prod);
> return ret;
> diff --git a/app/test/test_event_eth_rx_adapter.c 
> b/app/test/test_event_eth_rx_adapter.c
> index 52d146f97c..42edcb625a 100644
> --- a/app/test/test_event_eth_rx_adapter.c
> +++ b/app/test/test_event_eth_rx_adapter.c
> @@ -401,7 +401,7 @@ adapter_create(void)
> rx_p_conf.dequeue_depth = dev_info.max_event_port_dequeue_depth;
> rx_p_conf.enqueue_depth = dev_info.max_event_port_enqueue_depth;
> err = rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID,
> -   &rx_p_conf);
> +   &rx_p_conf, NULL);
> TEST_ASSERT(err == 0, "Expected 0 got %d", err);
>
> return err;
> @@ -427,17 +427,17 @@ adapter_create_with_params(void)
> rxa_params.use_queue_event_buf = false;
> rxa_params.event_buf_size = 0;
>
> -   err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
> +   err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
> TEST_DEV_ID, &rx_p_conf, &rxa_params);
> TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
>
> rxa_params.use_queue_event_buf = true;
>
> -   err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
> +   err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
> TEST_DEV_ID, &rx_p_conf, &rxa_params);
> TEST_ASSERT(err == 0, "Expected 0 got %d", err);
>
> -   err = rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID,
> +   err = rte_event_eth_rx_adapter_create(TEST_INST_ID,
> TEST_DEV_ID, &rx_p_conf, &rxa_params);
> TEST_ASSERT(err == -EEXIST, "Expected -EEXIST got %d", err);
>
> @@ -567,15 +567,15 @@ adapter_create_free(void)
> };
>
> err = rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID,
> -   NULL);
> +   NULL, NULL);
> TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
>
> err = rte_event_eth_rx_adapter_create(TEST_INST_ID, TEST_DEV_ID,
> -

Re: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

[Stephen Hemminger]

On Tue,  1 Aug 2023 07:22:07 +
Wenbo Cao  wrote:

> +struct rnp_mbx_api {
> + void (*init_mbx)(struct rnp_hw *hw);
> + int32_t (*read)(struct rnp_hw *hw,
> + uint32_t *msg,
> + uint16_t size,
> + enum MBX_ID);
> + int32_t (*write)(struct rnp_hw *hw,
> + uint32_t *msg,
> + uint16_t size,
> + enum MBX_ID);
> + int32_t (*read_posted)(struct rte_eth_dev *dev,
> + uint32_t *msg,
> + uint16_t size,
> + enum MBX_ID);
> + int32_t (*write_posted)(struct rte_eth_dev *dev,
> + uint32_t *msg,
> + uint16_t size,
> + enum MBX_ID);
> + int32_t (*check_for_msg)(struct rnp_hw *hw, enum MBX_ID);
> + int32_t (*check_for_ack)(struct rnp_hw *hw, enum MBX_ID);
> + int32_t (*check_for_rst)(struct rnp_hw *hw, enum MBX_ID);
> + int32_t (*configure)(struct rnp_hw *hw, int nr_vec, bool enable);
> +};

Since this data structure only has virtual function pointers;
many types of bugs can be avoided if it can be made const.
If it const, then compiler can put the initialized table in r/o text section.

RE: [PATCH] net/mlx5: fix leak in sysfs port name translation

[Bing Zhao]

Hi David,

Thanks for catching this.

BR. Bing

> -Original Message-
> From: David Marchand 
> Sent: Tuesday, August 1, 2023 11:19 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Matan Azrad ; Slava Ovsiienko
> ; Ori Kam ; Suanming Mou
> ; Bing Zhao 
> Subject: [PATCH] net/mlx5: fix leak in sysfs port name translation
> 
> External email: Use caution opening links or attachments
> 
> 
> getline() may allocate a buffer even though it returns -1:
> """
> If  *lineptr  is set to NULL before the call, then getline() will allocate a 
> buffer for
> storing the line.  This buffer should be freed by the user program even if
> getline() failed.
> """
> 
> This leak has been observed on a RHEL8 system with two CX5 PF devices (no
> VFs).
> 
> ASan reports:
> ==8899==ERROR: LeakSanitizer: detected memory leaks
> 
> Direct leak of 120 byte(s) in 1 object(s) allocated from:
> #0 0x7fe58576aba8 in __interceptor_malloc
> (/lib64/libasan.so.5+0xefba8)
> #1 0x7fe583e866b2 in __getdelim (/lib64/libc.so.6+0x886b2)
> #2 0x327bd23 in mlx5_sysfs_switch_info
> ../drivers/net/mlx5/linux/mlx5_ethdev_os.c:1084
> #3 0x3271f86 in mlx5_os_pci_probe_pf
> ../drivers/net/mlx5/linux/mlx5_os.c:2282
> #4 0x3273c83 in mlx5_os_pci_probe
> ../drivers/net/mlx5/linux/mlx5_os.c:2497
> #5 0x327475f in mlx5_os_net_probe
> ../drivers/net/mlx5/linux/mlx5_os.c:2578
> #6 0xc6eac7 in drivers_probe
> ../drivers/common/mlx5/mlx5_common.c:937
> #7 0xc6f150 in mlx5_common_dev_probe
> ../drivers/common/mlx5/mlx5_common.c:1027
> #8 0xc8ef80 in mlx5_common_pci_probe
> ../drivers/common/mlx5/mlx5_common_pci.c:168
> #9 0xc21b67 in rte_pci_probe_one_driver
> ../drivers/bus/pci/pci_common.c:312
> #10 0xc2224c in pci_probe_all_drivers
> ../drivers/bus/pci/pci_common.c:396
> #11 0xc222f4 in pci_probe ../drivers/bus/pci/pci_common.c:423
> #12 0xb71fff in rte_bus_probe ../lib/eal/common/eal_common_bus.c:78
> #13 0xbe6888 in rte_eal_init ../lib/eal/linux/eal.c:1300
> #14 0x5ec717 in main ../app/test-pmd/testpmd.c:4515
> #15 0x7fe583e38d84 in __libc_start_main (/lib64/libc.so.6+0x3ad84)
> 
> As far as why getline() errors, strace gives a hint:
> 8516  openat(AT_FDCWD, "/sys/class/net/enp130s0f0/phys_port_name",
> O_RDONLY) = 34
> 8516  fstat(34, {st_mode=S_IFREG|0444, st_size=4096, ...}) = 0
> 8516  read(34, 0x62198900, 4096)= -1 EOPNOTSUPP (Operation
> not supported)
> 
> Fixes: f8a226ed65fa ("net/mlx5: fix sysfs port name translation")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: David Marchand 
> ---
>  drivers/net/mlx5/linux/mlx5_ethdev_os.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
> b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
> index 639e629fe4..dd5a0c546d 100644
> --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
> @@ -1083,6 +1083,7 @@ mlx5_sysfs_switch_info(unsigned int ifindex, struct
> mlx5_switch_info *info)
> 
> line_size = getline(&port_name, &port_name_size, file);
> if (line_size < 0) {
> +   free(port_name);
> fclose(file);
> rte_errno = errno;
> return -rte_errno;
> --
> 2.41.0

RE: [PATCH v4] build: update DPDK to use C11 standard

[Ali Alnubani]

> -Original Message-
> From: Bruce Richardson 
> Sent: Tuesday, August 1, 2023 4:16 PM
> To: dev@dpdk.org
> Cc: Bruce Richardson ; Morten Brørup
> ; Tyler Retzlaff
> 
> Subject: [PATCH v4] build: update DPDK to use C11 standard
> 
> As previously announced, DPDK 23.11 will require a C11 supporting
> compiler and will use the C11 standard in all builds.
> 
> Forcing use of the C standard, rather than the standard with
> GNU extensions, means that some posix definitions which are not in
> the C standard are unavailable by default. We fix this by ensuring
> the correct defines or cflags are passed to the components that
> need them.
> 
> Signed-off-by: Bruce Richardson 
> Acked-by: Morten Brørup 
> Acked-by: Tyler Retzlaff 
> ---

By the way, I also see this build failure in RHEL 7:

[827/1011] Compiling C object app/dpdk-testpmd.p/test-pmd_cmdline_flow.c.o
FAILED: app/dpdk-testpmd.p/test-pmd_cmdline_flow.c.o
ccache cc -Iapp/dpdk-testpmd.p -Iapp -I../app -Iapp/test-pmd -I../app/test-pmd 
-Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/include 
-I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include 
-Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common 
-I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs 
-Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net 
-I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring 
-I../lib/ring -Ilib/meter -I../lib/meter -Ilib/cmdline -I../lib/cmdline 
-Ilib/bitratestats -I../lib/bitratestats -Ilib/bpf -I../lib/bpf -Ilib/gro 
-I../lib/gro -Ilib/gso -I../lib/gso -Ilib/latencystats -I../lib/latencystats 
-Ilib/pdump -I../lib/pdump -Ilib/pcapng -I../lib/pcapng -Idrivers/net/mlx5 
-I../drivers/net/mlx5 -Idrivers/net/mlx5/linux -I../drivers/net/mlx5/linux 
-Idrivers/net/mlx5/hws -I../drivers/net/mlx5/hws -Idrivers/bus/pci 
-I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci 
-Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/hash -I../lib/hash -Ilib/rcu 
-I../lib/rcu -Idrivers/common/mlx5 -I../drivers/common/mlx5 
-Idrivers/common/mlx5/linux -I../drivers/common/mlx5/linux 
-Idrivers/bus/auxiliary -I../drivers/bus/auxiliary -pipe -D_FILE_OFFSET_BITS=64 
-Wall -Winvalid-pch -Wextra -Werror -std=c11 -O3 -include rte_config.h 
-Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security 
-Wmissing-declarations -Wmissing-prototypes -Wnested-externs 
-Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes 
-Wundef -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE 
-march=native -DALLOW_EXPERIMENTAL_API -Wno-deprecated-declarations -MD -MQ 
app/dpdk-testpmd.p/test-pmd_cmdline_flow.c.o -MF 
app/dpdk-testpmd.p/test-pmd_cmdline_flow.c.o.d -o 
app/dpdk-testpmd.p/test-pmd_cmdline_flow.c.o -c ../app/test-pmd/cmdline_flow.c
../app/test-pmd/cmdline_flow.c: In function ‘parse_vc_spec’:
../app/test-pmd/cmdline_flow.c:1035:37: error: array initialized from 
non-constant array expression
 #define NEXT_ENTRY(...) (const enum index []){ __VA_ARGS__, ZERO, }
 ^
../app/test-pmd/cmdline_flow.c:8049:38: note: in expansion of macro ‘NEXT_ENTRY’
   static const enum index prefix[] = NEXT_ENTRY(COMMON_PREFIX);
  ^
../app/test-pmd/cmdline_flow.c: In function ‘parse_vc_action_rss_type’:
../app/test-pmd/cmdline_flow.c:1035:37: error: array initialized from 
non-constant array expression
 #define NEXT_ENTRY(...) (const enum index []){ __VA_ARGS__, ZERO, }
 ^
../app/test-pmd/cmdline_flow.c:8391:35: note: in expansion of macro ‘NEXT_ENTRY’
  static const enum index next[] = NEXT_ENTRY(ACTION_RSS_TYPE);
   ^
../app/test-pmd/cmdline_flow.c: In function ‘parse_vc_action_rss_queue’:
../app/test-pmd/cmdline_flow.c:1035:37: error: array initialized from 
non-constant array expression
 #define NEXT_ENTRY(...) (const enum index []){ __VA_ARGS__, ZERO, }
 ^
../app/test-pmd/cmdline_flow.c:8435:35: note: in expansion of macro ‘NEXT_ENTRY’
  static const enum index next[] = NEXT_ENTRY(ACTION_RSS_QUEUE);
   ^
[834/1011] Compiling C object app/dpdk-testpmd.p/test-pmd_config.c.o
ninja: build stopped: subcommand failed.

Meson: 1.2.0
Gcc: 4.8.5

Re: [PATCH v4] build: update DPDK to use C11 standard

[Bruce Richardson]

On Tue, Aug 01, 2023 at 03:47:03PM +, Ali Alnubani wrote:
> > -Original Message-
> > From: Bruce Richardson 
> > Sent: Tuesday, August 1, 2023 4:16 PM
> > To: dev@dpdk.org
> > Cc: Bruce Richardson ; Morten Brørup
> > ; Tyler Retzlaff
> > 
> > Subject: [PATCH v4] build: update DPDK to use C11 standard
> > 
> > As previously announced, DPDK 23.11 will require a C11 supporting
> > compiler and will use the C11 standard in all builds.
> > 
> > Forcing use of the C standard, rather than the standard with
> > GNU extensions, means that some posix definitions which are not in
> > the C standard are unavailable by default. We fix this by ensuring
> > the correct defines or cflags are passed to the components that
> > need them.
> > 
> > Signed-off-by: Bruce Richardson 
> > Acked-by: Morten Brørup 
> > Acked-by: Tyler Retzlaff 
> > ---
> 
> By the way, I also see this build failure in RHEL 7:
> 
It's my understanding that we no longer support the default compilers in
RHEL 7, since gcc 4.8.5 doesn't support the necessary c11 standard atomics.

/Bruce

[PATCH v2 0/2] Remove disabled functionality

[Stephen Hemminger]

The KNI and flow_classify library were already marked disabled
in 23.11 release.

Stephen Hemminger (2):
  flow_classify: remove library
  kni: remove deprecated kernel network interface

 MAINTAINERS   |  17 -
 app/test/meson.build  |   6 -
 app/test/test_flow_classify.c | 895 --
 app/test/test_flow_classify.h |  26 -
 app/test/test_kni.c   | 740 ---
 doc/api/doxy-api-index.md |   3 -
 doc/api/doxy-api.conf.in  |   2 -
 doc/guides/contributing/documentation.rst |   4 +-
 doc/guides/freebsd_gsg/build_sample_apps.rst  |   2 +-
 doc/guides/freebsd_gsg/install_from_ports.rst |   2 +-
 doc/guides/howto/flow_bifurcation.rst |   3 +-
 doc/guides/nics/index.rst |   1 -
 doc/guides/nics/kni.rst   | 170 
 doc/guides/nics/virtio.rst|  92 +-
 .../prog_guide/env_abstraction_layer.rst  |   2 -
 doc/guides/prog_guide/flow_classify_lib.rst   | 424 -
 doc/guides/prog_guide/glossary.rst|   3 -
 doc/guides/prog_guide/index.rst   |   2 -
 .../prog_guide/kernel_nic_interface.rst   | 423 -
 doc/guides/prog_guide/packet_framework.rst|   9 +-
 doc/guides/rel_notes/deprecation.rst  |  15 +-
 doc/guides/rel_notes/release_23_11.rst|   4 +
 doc/guides/sample_app_ug/flow_classify.rst| 242 -
 doc/guides/sample_app_ug/index.rst|   1 -
 doc/guides/sample_app_ug/ip_pipeline.rst  |  22 -
 drivers/net/cnxk/cnxk_ethdev.c|   2 +-
 drivers/net/kni/meson.build   |  11 -
 drivers/net/kni/rte_eth_kni.c | 524 --
 drivers/net/meson.build   |   1 -
 examples/flow_classify/Makefile   |  51 -
 examples/flow_classify/flow_classify.c| 878 -
 examples/flow_classify/ipv4_rules_file.txt|  14 -
 examples/flow_classify/meson.build|  13 -
 examples/ip_pipeline/Makefile |   1 -
 examples/ip_pipeline/cli.c|  95 --
 examples/ip_pipeline/examples/kni.cli |  69 --
 examples/ip_pipeline/kni.c| 168 
 examples/ip_pipeline/kni.h|  46 -
 examples/ip_pipeline/main.c   |  10 -
 examples/ip_pipeline/meson.build  |   1 -
 examples/ip_pipeline/pipeline.c   |  57 --
 examples/ip_pipeline/pipeline.h   |   2 -
 examples/meson.build  |   1 -
 kernel/linux/kni/Kbuild   |   6 -
 kernel/linux/kni/compat.h | 157 ---
 kernel/linux/kni/kni_dev.h| 137 ---
 kernel/linux/kni/kni_fifo.h   |  87 --
 kernel/linux/kni/kni_misc.c   | 719 --
 kernel/linux/kni/kni_net.c| 878 -
 kernel/linux/kni/meson.build  |  41 -
 kernel/linux/meson.build  |   2 +-
 lib/eal/common/eal_common_log.c   |   1 -
 lib/eal/include/rte_log.h |   2 +-
 lib/eal/linux/eal.c   |  19 -
 lib/flow_classify/meson.build |  12 -
 lib/flow_classify/rte_flow_classify.c | 670 -
 lib/flow_classify/rte_flow_classify.h | 284 --
 lib/flow_classify/rte_flow_classify_parse.c   | 532 ---
 lib/flow_classify/rte_flow_classify_parse.h   |  58 --
 lib/flow_classify/version.map |  13 -
 lib/kni/meson.build   |  21 -
 lib/kni/rte_kni.c | 843 -
 lib/kni/rte_kni.h | 269 --
 lib/kni/rte_kni_common.h  | 147 ---
 lib/kni/rte_kni_fifo.h| 117 ---
 lib/kni/version.map   |  24 -
 lib/meson.build   |   9 -
 lib/port/meson.build  |   6 -
 lib/port/rte_port_kni.c   | 515 --
 lib/port/rte_port_kni.h   |  63 --
 lib/port/version.map  |   3 -
 meson_options.txt |   2 +-
 72 files changed, 18 insertions(+), 10673 deletions(-)
 delete mode 100644 app/test/test_flow_classify.c
 delete mode 100644 app/test/test_flow_classify.h
 delete mode 100644 app/test/test_kni.c
 delete mode 100644 doc/guides/nics/kni.rst
 delete mode 100644 doc/guides/prog_guide/flow_classify_lib.rst
 delete mode 100644 doc/guides/prog_guide/kernel_nic_interface.rst
 delete mode 100644 doc/guides/sample_app_ug/flow_classify.rst
 delete mode 100644 drivers/net/kni/meson.build
 delete mode 100644 drivers/net/kni/rte_eth_kni.c
 delete mode 100644 examples/flow_classify/Makefile
 delete mode 100644 examples/flow_classify/flow_classify.c
 delete mode 10

[PATCH v2 1/2] flow_classify: remove library

[Stephen Hemminger]

The flow_classify library was marked for removal last year
because there was no maintainer and the functionality is
limited.

Signed-off-by: Stephen Hemminger 
---
 MAINTAINERS   |   7 -
 app/test/meson.build  |   4 -
 app/test/test_flow_classify.c | 895 --
 app/test/test_flow_classify.h |  26 -
 doc/api/doxy-api-index.md |   1 -
 doc/api/doxy-api.conf.in  |   1 -
 doc/guides/freebsd_gsg/build_sample_apps.rst  |   2 +-
 doc/guides/freebsd_gsg/install_from_ports.rst |   2 +-
 doc/guides/prog_guide/flow_classify_lib.rst   | 424 -
 doc/guides/prog_guide/index.rst   |   1 -
 doc/guides/rel_notes/deprecation.rst  |   8 +-
 doc/guides/rel_notes/release_23_11.rst|   2 +
 doc/guides/sample_app_ug/flow_classify.rst| 242 -
 doc/guides/sample_app_ug/index.rst|   1 -
 examples/flow_classify/Makefile   |  51 -
 examples/flow_classify/flow_classify.c| 878 -
 examples/flow_classify/ipv4_rules_file.txt|  14 -
 examples/flow_classify/meson.build|  13 -
 examples/meson.build  |   1 -
 lib/flow_classify/meson.build |  12 -
 lib/flow_classify/rte_flow_classify.c | 670 -
 lib/flow_classify/rte_flow_classify.h | 284 --
 lib/flow_classify/rte_flow_classify_parse.c   | 532 ---
 lib/flow_classify/rte_flow_classify_parse.h   |  58 --
 lib/flow_classify/version.map |  13 -
 lib/meson.build   |   3 -
 meson_options.txt |   2 +-
 27 files changed, 6 insertions(+), 4141 deletions(-)
 delete mode 100644 app/test/test_flow_classify.c
 delete mode 100644 app/test/test_flow_classify.h
 delete mode 100644 doc/guides/prog_guide/flow_classify_lib.rst
 delete mode 100644 doc/guides/sample_app_ug/flow_classify.rst
 delete mode 100644 examples/flow_classify/Makefile
 delete mode 100644 examples/flow_classify/flow_classify.c
 delete mode 100644 examples/flow_classify/ipv4_rules_file.txt
 delete mode 100644 examples/flow_classify/meson.build
 delete mode 100644 lib/flow_classify/meson.build
 delete mode 100644 lib/flow_classify/rte_flow_classify.c
 delete mode 100644 lib/flow_classify/rte_flow_classify.h
 delete mode 100644 lib/flow_classify/rte_flow_classify_parse.c
 delete mode 100644 lib/flow_classify/rte_flow_classify_parse.h
 delete mode 100644 lib/flow_classify/version.map

diff --git a/MAINTAINERS b/MAINTAINERS
index 18bc05fccd0d..dbb25211c367 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1511,13 +1511,6 @@ F: lib/pdcp/
 F: doc/guides/prog_guide/pdcp_lib.rst
 F: app/test/test_pdcp*
 
-Flow Classify - EXPERIMENTAL - UNMAINTAINED
-F: lib/flow_classify/
-F: app/test/test_flow_classify*
-F: doc/guides/prog_guide/flow_classify_lib.rst
-F: examples/flow_classify/
-F: doc/guides/sample_app_ug/flow_classify.rst
-
 Distributor
 M: David Hunt 
 F: lib/distributor/
diff --git a/app/test/meson.build b/app/test/meson.build
index b89cf0368fb5..90a2e350c7ae 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -359,10 +359,6 @@ if dpdk_conf.has('RTE_EVENT_SKELETON')
 test_deps += 'event_skeleton'
 endif
 
-if dpdk_conf.has('RTE_LIB_FLOW_CLASSIFY')
-test_sources += 'test_flow_classify.c'
-fast_tests += [['flow_classify_autotest', false, true]]
-endif
 if dpdk_conf.has('RTE_LIB_GRAPH')
 test_sources += 'test_graph.c'
 fast_tests += [['graph_autotest', true, true]]
diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c
deleted file mode 100644
index 6e274d88e645..
--- a/app/test/test_flow_classify.c
+++ /dev/null
@@ -1,895 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2017 Intel Corporation
- */
-
-#include 
-#include 
-
-#include "test.h"
-
-#include 
-#include 
-#include 
-#include 
-
-#ifdef RTE_EXEC_ENV_WINDOWS
-static int
-test_flow_classify(void)
-{
-   printf("flow_classify not supported on Windows, skipping test\n");
-   return TEST_SKIPPED;
-}
-
-#else
-
-#include 
-#include 
-#include 
-#include 
-#include 
-
-#include "packet_burst_generator.h"
-#include "test_flow_classify.h"
-
-
-#define FLOW_CLASSIFY_MAX_RULE_NUM 100
-#define MAX_PKT_BURST  32
-#define NB_SOCKETS 4
-#define MEMPOOL_CACHE_SIZE 256
-#define MBUF_SIZE  512
-#define NB_MBUF512
-
-/* test UDP, TCP and SCTP packets */
-static struct rte_mempool *mbufpool[NB_SOCKETS];
-static struct rte_mbuf *bufs[MAX_PKT_BURST];
-
-static struct rte_acl_field_def ipv4_defs[NUM_FIELDS_IPV4] = {
-   /* first input field - always one byte long. */
-   {
-   .type = RTE_ACL_FIELD_TYPE_BITMASK,
-   .size = sizeof(uint8_t),
-   .field_index = PROTO_FIELD_IPV4,
-   .input_index = PROTO_INPUT_IPV

Re: [PATCH] lib/ethdev: sanity check on callback before resource allocation

[Stephen Hemminger]

On Tue, 11 Jul 2023 01:18:09 +
Kaiyu Zhang  wrote:

> sanity check is performed after a rte_eth_dev object is allocated.
> The object is not freed if the check fails, though in the current
> reality this never happens, but it's better programming paradigm
> to move the quick check up front to the start of
> rte_eth_dev_pci_generic_probe.
> 
> Signed-off-by: Kaiyu Zhang 

The term sanity check is on the non-inclusive naming word list.
Please don't use that term in DPDK.
There is an outstanding patchset to remove all use of the term.

Re: [PATCH v4] build: update DPDK to use C11 standard

[Tyler Retzlaff]

On Tue, Aug 01, 2023 at 04:50:45PM +0100, Bruce Richardson wrote:
> On Tue, Aug 01, 2023 at 03:47:03PM +, Ali Alnubani wrote:
> > > -Original Message-
> > > From: Bruce Richardson 
> > > Sent: Tuesday, August 1, 2023 4:16 PM
> > > To: dev@dpdk.org
> > > Cc: Bruce Richardson ; Morten Brørup
> > > ; Tyler Retzlaff
> > > 
> > > Subject: [PATCH v4] build: update DPDK to use C11 standard
> > > 
> > > As previously announced, DPDK 23.11 will require a C11 supporting
> > > compiler and will use the C11 standard in all builds.
> > > 
> > > Forcing use of the C standard, rather than the standard with
> > > GNU extensions, means that some posix definitions which are not in
> > > the C standard are unavailable by default. We fix this by ensuring
> > > the correct defines or cflags are passed to the components that
> > > need them.
> > > 
> > > Signed-off-by: Bruce Richardson 
> > > Acked-by: Morten Brørup 
> > > Acked-by: Tyler Retzlaff 
> > > ---
> > 
> > By the way, I also see this build failure in RHEL 7:
> > 
> It's my understanding that we no longer support the default compilers in
> RHEL 7, since gcc 4.8.5 doesn't support the necessary c11 standard atomics.

yes, support is being dropped for RHEL 7

http://mails.dpdk.org/archives/dev/2023-February/263516.html

it seems like now that we are in 23.11 merge window the CI pipelines for
the unsupported targets can be decomissioned?

> 
> /Bruce

Re: [PATCH v2 0/4] eal: update public API to use stdatomic atomics

[Tyler Retzlaff]

top post

just a heads up on this series, please defer review until v3 is
submitted.

clang is stricter in atomic type enforcement than gcc so a new revision
is needed that removes the direct use of intrinsics replacing them with
the standard atomics for all _Atomic types.

thanks

On Mon, Jul 31, 2023 at 10:03:50PM -0700, Tyler Retzlaff wrote:
> Update EAL public API to use standard C11 atomics. In accordance with
> technical board discussion February 2023.
> http://mails.dpdk.org/archives/dev/2023-February/263516.html
> 
> This initial series makes no attempt to adapt every use of builtin atomics
> from GCC it intends only to adapt the public API of the EAL presented as
> a compatibility surface to applications.
> 
> Further series will be submitted to adapt the rest of DPDK to use standard
> atomics that are 'internal' and not do not straddle the EAL API.
> 
> The choice has been made to break these two changes apart to allow more
> precise analysis of any potential performance impact this change or
> subsequent changes may introduce.
> 
> Additionally, it is not possible to break the commits up per driver/lib as
> both the provider and consumer of the APIs need to be changed in the same
> commit to maintain non-broken build and function.
> 
> Finally, the first patch in this series is a duplication of Bruce Richardson
> series https://patchwork.dpdk.org/project/dpdk/list/?series=29048 and is
> only being provided to enable the CI run on this series. It is expected that
> Bruce's series when committed will allow the build: require minimum c11 
> compiler
> here to be dropped from this series.
> 
> v2:
>   * remove volatile qualification from variables, structure fields and
> parameters that have been qualified _Atomic
>   * restore removal of #include  in rte_ring_core.h the ring
> library still uses other rte_atomic APIs and types that are not replaced
> by the standard or compiler intrinsics
>   * add missing adaption to stdatomic in ring/rte_ring_c11_pvt.h
> 
> Tyler Retzlaff (4):
>   build: require minimum c11 compiler
>   devtools: forbid use of GCC atomic builtins
>   eal: adapt rte pause APIs to use C11 atomics
>   eal: adapt rte spinlock and rwlock APIs to use C11 atomics
> 
>  app/test-bbdev/test_bbdev_perf.c | 123 
> ---
>  app/test/test_func_reentrancy.c  |   8 +-
>  app/test/test_mcslock.c  |  12 +--
>  app/test/test_mempool_perf.c |   8 +-
>  app/test/test_pflock.c   |  12 +--
>  app/test/test_pmd_perf.c |  10 +--
>  app/test/test_ring_perf.c|   8 +-
>  app/test/test_rwlock.c   |   8 +-
>  app/test/test_spinlock.c |   8 +-
>  app/test/test_stack_perf.c   |  12 +--
>  app/test/test_ticketlock.c   |   8 +-
>  app/test/test_timer.c|  16 ++--
>  devtools/checkpatches.sh |   8 ++
>  drivers/event/opdl/opdl_ring.c   |  47 ++--
>  drivers/net/failsafe/meson.build |   1 -
>  drivers/net/thunderx/nicvf_rxtx.c|   5 +-
>  drivers/net/thunderx/nicvf_struct.h  |   2 +-
>  lib/bpf/bpf_pkt.c|   4 +-
>  lib/distributor/distributor_private.h|   2 +-
>  lib/distributor/rte_distributor_single.c |  44 +--
>  lib/eal/arm/include/rte_pause_64.h   |  28 +++
>  lib/eal/common/eal_common_errno.c|   1 +
>  lib/eal/common/eal_memcfg.h  |   2 +-
>  lib/eal/include/generic/rte_pause.h  |  52 ++---
>  lib/eal/include/generic/rte_rwlock.h |  46 ++--
>  lib/eal/include/generic/rte_spinlock.h   |  21 +++---
>  lib/eal/include/rte_mcslock.h|  12 +--
>  lib/eal/include/rte_pflock.h |  22 +++---
>  lib/eal/include/rte_ticketlock.h |   8 +-
>  lib/eal/loongarch/include/rte_pause.h|   2 -
>  lib/eal/ppc/include/rte_pause.h  |   2 -
>  lib/eal/riscv/include/rte_pause.h|   2 -
>  lib/eal/x86/include/rte_spinlock.h   |   2 +-
>  lib/ring/rte_ring_c11_pvt.h  |  28 +++
>  lib/ring/rte_ring_core.h |   4 +-
>  lib/ring/rte_ring_generic_pvt.h  |  19 +++--
>  lib/ring/rte_ring_peek_elem_pvt.h|   2 +-
>  meson.build  |   1 +
>  38 files changed, 326 insertions(+), 274 deletions(-)
> 
> -- 
> 1.8.3.1

Re: [PATCH v4] build: update DPDK to use C11 standard

[Patrick Robb]

On Tue, Aug 1, 2023 at 12:20 PM Tyler Retzlaff 
wrote:

>
> yes, support is being dropped for RHEL 7
>
> http://mails.dpdk.org/archives/dev/2023-February/263516.html
>
> it seems like now that we are in 23.11 merge window the CI pipelines for
> the unsupported targets can be decomissioned?
>
> >
> > /Bruce
>
The Community Lab will discontinue CI testing on RHEL7 at start of day
tomorrow.

[PATCH v2] cmdline: remove cmdline_poll()

[Stephen Hemminger]

The API functions cmdline_poll() was unused by any project,
untested, and buggy. Remove it from 23.11 release.

Signed-off-by: Stephen Hemminger 
Acked-by: Bruce Richardson 
---
 doc/guides/rel_notes/release_23_11.rst |  1 +
 lib/cmdline/cmdline.c  | 34 -
 lib/cmdline/cmdline.h  | 16 --
 lib/cmdline/cmdline_os_unix.c  | 12 -
 lib/cmdline/cmdline_os_windows.c   | 68 --
 lib/cmdline/cmdline_private.h  |  3 --
 lib/cmdline/version.map|  1 -
 7 files changed, 1 insertion(+), 134 deletions(-)

diff --git a/doc/guides/rel_notes/release_23_11.rst 
b/doc/guides/rel_notes/release_23_11.rst
index 6b4dd21fd0e1..0e206219a83e 100644
--- a/doc/guides/rel_notes/release_23_11.rst
+++ b/doc/guides/rel_notes/release_23_11.rst
@@ -68,6 +68,7 @@ Removed Items
Also, make sure to start the actual text at the margin.
===
 
+* cmdline: Removed broken and unused function ``cmdline_poll``.
 
 API Changes
 ---
diff --git a/lib/cmdline/cmdline.c b/lib/cmdline/cmdline.c
index 355c7d8ca635..08721ee919be 100644
--- a/lib/cmdline/cmdline.c
+++ b/lib/cmdline/cmdline.c
@@ -177,40 +177,6 @@ cmdline_quit(struct cmdline *cl)
rdline_quit(&cl->rdl);
 }
 
-int
-cmdline_poll(struct cmdline *cl)
-{
-   int status;
-   ssize_t read_status;
-   char c;
-
-   if (!cl)
-   return -EINVAL;
-   else if (cl->rdl.status == RDLINE_EXITED)
-   return RDLINE_EXITED;
-
-   status = cmdline_poll_char(cl);
-   if (status < 0)
-   return status;
-   else if (status > 0) {
-   c = -1;
-   read_status = cmdline_read_char(cl, &c);
-   if (read_status < 0)
-   return read_status;
-
-   if (read_status == 0) {
-   /* end of file is implicit quit */
-   cmdline_quit(cl);
-   } else {
-   status = cmdline_in(cl, &c, 1);
-   if (status < 0 && cl->rdl.status != RDLINE_EXITED)
-   return status;
-   }
-   }
-
-   return cl->rdl.status;
-}
-
 void
 cmdline_interact(struct cmdline *cl)
 {
diff --git a/lib/cmdline/cmdline.h b/lib/cmdline/cmdline.h
index d631cd4bd459..992c84591456 100644
--- a/lib/cmdline/cmdline.h
+++ b/lib/cmdline/cmdline.h
@@ -43,22 +43,6 @@ __rte_experimental
 struct rdline *
 cmdline_get_rdline(struct cmdline *cl);
 
-/**
- * @deprecated Function is broken and scheduled for removal.
- *
- * This function is nonblocking equivalent of ``cmdline_interact()``. It polls
- * *cl* for one character and interpret it. If return value is *RDLINE_EXITED*
- * it mean that ``cmdline_quit()`` was invoked.
- *
- * @param cl
- *   The command line object.
- *
- * @return
- *   On success return object status - one of *enum rdline_status*.
- *   On error return negative value.
- */
-__rte_deprecated
-int cmdline_poll(struct cmdline *cl);
 
 void cmdline_interact(struct cmdline *cl);
 void cmdline_quit(struct cmdline *cl);
diff --git a/lib/cmdline/cmdline_os_unix.c b/lib/cmdline/cmdline_os_unix.c
index 9a4ec4e33477..0365e73c115e 100644
--- a/lib/cmdline/cmdline_os_unix.c
+++ b/lib/cmdline/cmdline_os_unix.c
@@ -28,18 +28,6 @@ terminal_restore(const struct cmdline *cl)
tcsetattr(fileno(stdin), TCSANOW, &cl->oldterm);
 }
 
-int
-cmdline_poll_char(struct cmdline *cl)
-{
-   struct pollfd pfd;
-
-   pfd.fd = cl->s_in;
-   pfd.events = POLLIN;
-   pfd.revents = 0;
-
-   return poll(&pfd, 1, 0);
-}
-
 ssize_t
 cmdline_read_char(struct cmdline *cl, char *c)
 {
diff --git a/lib/cmdline/cmdline_os_windows.c b/lib/cmdline/cmdline_os_windows.c
index 80863bfc8a00..74dc8a18db49 100644
--- a/lib/cmdline/cmdline_os_windows.c
+++ b/lib/cmdline/cmdline_os_windows.c
@@ -72,74 +72,6 @@ cmdline_is_key_down(const INPUT_RECORD *record)
record->Event.KeyEvent.bKeyDown;
 }
 
-static int
-cmdline_poll_char_console(HANDLE handle)
-{
-   INPUT_RECORD record;
-   DWORD events;
-
-   if (!PeekConsoleInput(handle, &record, 1, &events)) {
-   /* Simulate poll(3) behavior on EOF. */
-   return (GetLastError() == ERROR_HANDLE_EOF) ? 1 : -1;
-   }
-
-   if ((events == 0) || !cmdline_is_key_down(&record))
-   return 0;
-
-   return 1;
-}
-
-static int
-cmdline_poll_char_file(struct cmdline *cl, HANDLE handle)
-{
-   DWORD type = GetFileType(handle);
-
-   /* Since console is handled by cmdline_poll_char_console(),
-* this is either a serial port or input handle had been replaced.
-*/
-   if (type == FILE_TYPE_CHAR)
-   return cmdline_poll_char_console(handle);
-
-   /* PeekNamedPipe() can handle all pipes and also sockets. */
-   if (type == FILE_TYPE_PIPE) {
-   DWORD bytes_avail;
-

Re: [PATCH] app/testpmd: add flush multicast MAC address command

[huangdengdui]

在 2023/8/1 23:18, Stephen Hemminger 写道:
> On Tue, 1 Aug 2023 10:43:04 +0800
> Dengdui Huang  wrote:
> 
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>> index 0d0723f659..2d9d925776 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -494,6 +494,9 @@ static void cmd_help_long_parsed(void *parsed_result,
>>  "mac_addr remove (port_id) (XX:XX:XX:XX:XX:XX)\n"
>>  "Remove a MAC address from port_id.\n\n"
>>  
>> +"mcast_addr flush (port_id)\n"
>> +"To flush the set of multicast addresses.\n\n"
>> +
>>  "mac_addr set (port_id) (XX:XX:XX:XX:XX:XX)\n"
>>  "Set the default MAC address for port_id.\n\n"
> 
> Why out this in middle of the mac_addr commands? better to be in logical or 
> alpha order.
Thanks, I will do in v2.

RE: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

[11]

Hi Stephen,

Thanks for your comment, as your advice that I need to define the virtual
function pointers
As the below type ?
const struct rnp_mbx_api {
..
}
If It will protect the virtual function address ,won't be remove by mistake?

Regards Wenbo
-Original Message-
From: Stephen Hemminger  
Sent: 2023年8月1日 23:26
To: Wenbo Cao 
Cc: dev@dpdk.org
Subject: Re: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

On Tue,  1 Aug 2023 07:22:07 +
Wenbo Cao  wrote:

> +struct rnp_mbx_api {
> + void (*init_mbx)(struct rnp_hw *hw);
> + int32_t (*read)(struct rnp_hw *hw,
> + uint32_t *msg,
> + uint16_t size,
> + enum MBX_ID);
> + int32_t (*write)(struct rnp_hw *hw,
> + uint32_t *msg,
> + uint16_t size,
> + enum MBX_ID);
> + int32_t (*read_posted)(struct rte_eth_dev *dev,
> + uint32_t *msg,
> + uint16_t size,
> + enum MBX_ID);
> + int32_t (*write_posted)(struct rte_eth_dev *dev,
> + uint32_t *msg,
> + uint16_t size,
> + enum MBX_ID);
> + int32_t (*check_for_msg)(struct rnp_hw *hw, enum MBX_ID);
> + int32_t (*check_for_ack)(struct rnp_hw *hw, enum MBX_ID);
> + int32_t (*check_for_rst)(struct rnp_hw *hw, enum MBX_ID);
> + int32_t (*configure)(struct rnp_hw *hw, int nr_vec, bool enable); };

Since this data structure only has virtual function pointers; many types of
bugs can be avoided if it can be made const.
If it const, then compiler can put the initialized table in r/o text
section.

Re: [[PATCH v1] 1/8] net/rnp: add skeleton

[Stephen Hemminger]

On Tue,  1 Aug 2023 07:21:38 +
Wenbo Cao  wrote:

> +Mucse rnp
> +M: caowe...@mucse.com
> +F: drivers/net/rnp
> +F: doc/guides/nics/rnp.rst
> +F: doc/guides/nics/features/rnp.ini

Please use the full email address for the M: line.


> diff --git a/drivers/net/meson.build b/drivers/net/meson.build
> index b1df17ce8c..8bdbf05857 100644
> --- a/drivers/net/meson.build
> +++ b/drivers/net/meson.build
> @@ -56,6 +56,7 @@ drivers = [
>  'ring',
>  'sfc',
>  'softnic',
> +'rnp',
>  'tap',
>  'thunderx',
>  'txgbe',

Insert new driver into list in the alphabetic order.
I.e after 'ring'

Re: [PATCH v1] mempool: fix some errors in html api

[Rma Ma]

Hi,

I know, it's a simple, no-impact patch for dpdk functionality.
However, this can be misleading for app programs.
When the return value of the interface is judged against -ENOENT, this will 
cause the program to error out.
It also affects the presentation of the api documentation:
https://doc.dpdk.org/api/rte__mempool_8h.html#a0d326354d53ef5068d86a8b7d9ec2d61

I'm not sure if this needs to be fixed or not.



> Subject: [PATCH v1] mempool: fix some errors in html api

>

> This patch fix some error descriptions of return value in mempool api which

> affect in html api.

>

> Signed-off-by: Rma Ma mailto:rma...@jaguarmicro.com>>

> ---

>  lib/mempool/rte_mempool.h | 12 ++--

>  1 file changed, 6 insertions(+), 6 deletions(-)

>




Best wishes,

Rma


From: Rma Ma
Sent: Monday, July 3, 2023 14:18
To: dpdk-dev 
Cc: Olivier Matz ; Andrew Rybchenko 
; Rma Ma 
Subject: [PATCH v1] mempool: fix some errors in html api

This patch fix some error descriptions of
return value in mempool api which affect in html api.

Signed-off-by: Rma Ma 
---
 lib/mempool/rte_mempool.h | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h
index 160975a7e7..d4d707533a 100644
--- a/lib/mempool/rte_mempool.h
+++ b/lib/mempool/rte_mempool.h
@@ -1610,7 +1610,7 @@ rte_mempool_do_generic_get(struct rte_mempool *mp, void 
**obj_table,
  * Get several objects from the mempool.
  *
  * If cache is enabled, objects will be retrieved first from cache,
- * subsequently from the common pool. Note that it can return -ENOENT when
+ * subsequently from the common pool. Note that it can return -ENOBUFS when
  * the local cache and common pool are empty, even if cache from other
  * lcores are full.
  *
@@ -1624,7 +1624,7 @@ rte_mempool_do_generic_get(struct rte_mempool *mp, void 
**obj_table,
  *   A pointer to a mempool cache structure. May be NULL if not needed.
  * @return
  *   - 0: Success; objects taken.
- *   - -ENOENT: Not enough entries in the mempool; no object is retrieved.
+ *   - -ENOBUFS: Not enough entries in the mempool; no object is retrieved.
  */
 static __rte_always_inline int
 rte_mempool_generic_get(struct rte_mempool *mp, void **obj_table,
@@ -1646,7 +1646,7 @@ rte_mempool_generic_get(struct rte_mempool *mp, void 
**obj_table,
  * mempool creation time (see flags).
  *
  * If cache is enabled, objects will be retrieved first from cache,
- * subsequently from the common pool. Note that it can return -ENOENT when
+ * subsequently from the common pool. Note that it can return -ENOBUFS when
  * the local cache and common pool are empty, even if cache from other
  * lcores are full.
  *
@@ -1658,7 +1658,7 @@ rte_mempool_generic_get(struct rte_mempool *mp, void 
**obj_table,
  *   The number of objects to get from the mempool to obj_table.
  * @return
  *   - 0: Success; objects taken
- *   - -ENOENT: Not enough entries in the mempool; no object is retrieved.
+ *   - -ENOBUFS: Not enough entries in the mempool; no object is retrieved.
  */
 static __rte_always_inline int
 rte_mempool_get_bulk(struct rte_mempool *mp, void **obj_table, unsigned int n)
@@ -1677,7 +1677,7 @@ rte_mempool_get_bulk(struct rte_mempool *mp, void 
**obj_table, unsigned int n)
  * mempool creation (see flags).
  *
  * If cache is enabled, objects will be retrieved first from cache,
- * subsequently from the common pool. Note that it can return -ENOENT when
+ * subsequently from the common pool. Note that it can return -ENOBUFS when
  * the local cache and common pool are empty, even if cache from other
  * lcores are full.
  *
@@ -1687,7 +1687,7 @@ rte_mempool_get_bulk(struct rte_mempool *mp, void 
**obj_table, unsigned int n)
  *   A pointer to a void * pointer (object) that will be filled.
  * @return
  *   - 0: Success; objects taken.
- *   - -ENOENT: Not enough entries in the mempool; no object is retrieved.
+ *   - -ENOBUFS: Not enough entries in the mempool; no object is retrieved.
  */
 static __rte_always_inline int
 rte_mempool_get(struct rte_mempool *mp, void **obj_p)
--
2.17.1

RE: [[PATCH v1] 3/8] net/rnp: add device init and uninit

[11]

Hi Stephen,

Why have two labels for same place, to later patches insert code here?
For this question the new code in rnp_init_port_resource
Will zmalloc dev->data->mac_addrs  and  dev->data->hash_mac_addrs
So I wish to free the zmalloc mem when init port resource failed


Regards wenbo

-Original Message-
From: Stephen Hemminger  
Sent: 2023年8月1日 23:21
To: Wenbo Cao 
Cc: Anatoly Burakov ; dev@dpdk.org
Subject: Re: [[PATCH v1] 3/8] net/rnp: add device init and uninit

On Tue,  1 Aug 2023 06:43:41 +
Wenbo Cao  wrote:

> + return 0;
> +eth_alloc_error:
> +init_failed:

Why have two labels for same place, to later patches insert code here?

Re: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

[Stephen Hemminger]

On Wed, 2 Aug 2023 09:41:29 +0800
"11"  wrote:

> Hi Stephen,
> 
> Thanks for your comment, as your advice that I need to define the virtual
> function pointers
> As the below type ?

No, keep the struct the same, but make it const where used.
You also do a copy of the ops struct so the one you initialize
ends up in the shared ops. It would be cleaner to have one
initialized object and have objects point to that.

Tried something like this, but it won't work.


diff --git a/drivers/net/rnp/rnp.h b/drivers/net/rnp/rnp.h
index a8999ddc471c..437a2cc2093d 100644
--- a/drivers/net/rnp/rnp.h
+++ b/drivers/net/rnp/rnp.h
@@ -20,7 +20,7 @@ struct rnp_eth_port {
 } __rte_cache_aligned;
 
 struct rnp_share_ops {
-   struct rnp_mbx_api mbx_api;
+   const struct rnp_mbx_api *mbx_api;
 } __rte_cache_aligned;
 
 struct rnp_eth_adapter {
@@ -41,7 +41,7 @@ struct rnp_eth_adapter {
 #define RNP_DEV_TO_HW(eth_dev) \
(&((struct rnp_eth_adapter *)(RNP_DEV_TO_PORT((eth_dev))->adapt))->hw)
 #define RNP_DEV_PP_PRIV_TO_MBX_OPS(dev) \
-   (&((struct rnp_share_ops *)(dev)->process_private)->mbx_api)
+   (((struct rnp_share_ops *)(dev)->process_private)->mbx_api)
 #define RNP_DEV_TO_MBX_OPS(dev)RNP_DEV_PP_PRIV_TO_MBX_OPS(dev)
 
 static inline void rnp_reg_offset_init(struct rnp_hw *hw)
diff --git a/drivers/net/rnp/rnp_ethdev.c b/drivers/net/rnp/rnp_ethdev.c
index 4747a41423dd..4518eaa3efa9 100644
--- a/drivers/net/rnp/rnp_ethdev.c
+++ b/drivers/net/rnp/rnp_ethdev.c
@@ -11,7 +11,6 @@
 #include "rnp_mbx.h"
 #include "rnp_logs.h"
 
-extern struct rnp_mbx_api rnp_mbx_pf_ops;
 static int
 rnp_mac_rx_disable(struct rte_eth_dev *dev)
 {
@@ -133,7 +132,7 @@ rnp_common_ops_init(struct rnp_eth_adapter *adapter)
struct rnp_share_ops *share_priv;
 
share_priv = adapter->share_priv;
-   share_priv->mbx_api = rnp_mbx_pf_ops;
+   share_priv->mbx_api = &rnp_mbx_pf_ops;
 }
 
 static int
diff --git a/drivers/net/rnp/rnp_mbx.c b/drivers/net/rnp/rnp_mbx.c
index 0f1c0a5b7471..b39e05bb715c 100644
--- a/drivers/net/rnp/rnp_mbx.c
+++ b/drivers/net/rnp/rnp_mbx.c
@@ -455,7 +455,7 @@ static int get_pfvfnum(struct rnp_hw *hw)
return val >> RNP_PFVF_SHIFT;
 }
 
-struct rnp_mbx_api rnp_mbx_pf_ops = {
+const struct rnp_mbx_api rnp_mbx_pf_ops = {
.read   = rnp_read_mbx_pf,
.write  = rnp_write_mbx_pf,
.read_posted= rnp_read_posted_mbx_pf,
diff --git a/drivers/net/rnp/rnp_mbx.h b/drivers/net/rnp/rnp_mbx.h
index ee020b5fbce7..0fae78167336 100644
--- a/drivers/net/rnp/rnp_mbx.h
+++ b/drivers/net/rnp/rnp_mbx.h
@@ -135,4 +135,6 @@
 
 void rnp_init_mbx_ops_pf(struct rnp_hw *hw);
 void *rnp_memzone_reserve(const char *name, unsigned int size);
+
+extern const struct rnp_mbx_api rnp_mbx_pf_ops;
 #endif

Re: [[PATCH v1] 0/8] *** SUBJECT HERE ***

[Stephen Hemminger]

On Tue,  1 Aug 2023 07:21:29 +
Wenbo Cao  wrote:

> *** BLURB HERE ***
> 
> Wenbo Cao (8):
>   net/rnp: add skeleton
>   net/rnp: add ethdev probe and remove
>   net/rnp: add device init and uninit
>   net/rnp: add mbx basic api feature
>   net/rnp add reset code for Chip Init process
>   net/rnp add port info resource init
>   net/rnp add devargs runtime parsing functions
>   net/rnp handle device interrupts
> 
>  MAINTAINERS |   6 +
>  doc/guides/nics/features/rnp.ini|   8 +
>  doc/guides/nics/index.rst   |   1 +
>  doc/guides/nics/rnp.rst |  43 ++
>  drivers/net/meson.build |   1 +
>  drivers/net/rnp/base/rnp_api.c  |  71 +++
>  drivers/net/rnp/base/rnp_api.h  |  17 +
>  drivers/net/rnp/base/rnp_cfg.h  |   7 +
>  drivers/net/rnp/base/rnp_dma_regs.h |  73 +++
>  drivers/net/rnp/base/rnp_eth_regs.h | 124 +
>  drivers/net/rnp/base/rnp_hw.h   | 193 +++
>  drivers/net/rnp/base/rnp_mac_regs.h | 279 ++
>  drivers/net/rnp/meson.build |  18 +
>  drivers/net/rnp/rnp.h   | 217 
>  drivers/net/rnp/rnp_ethdev.c| 823 
>  drivers/net/rnp/rnp_logs.h  |  43 ++
>  drivers/net/rnp/rnp_mbx.c   | 522 ++
>  drivers/net/rnp/rnp_mbx.h   | 139 +
>  drivers/net/rnp/rnp_mbx_fw.c| 781 ++
>  drivers/net/rnp/rnp_mbx_fw.h| 401 ++
>  drivers/net/rnp/rnp_osdep.h |  30 +
>  drivers/net/rnp/rnp_rxtx.c  |  83 +++
>  drivers/net/rnp/rnp_rxtx.h  |  14 +
>  23 files changed, 3894 insertions(+)
>  create mode 100644 doc/guides/nics/features/rnp.ini
>  create mode 100644 doc/guides/nics/rnp.rst
>  create mode 100644 drivers/net/rnp/base/rnp_api.c
>  create mode 100644 drivers/net/rnp/base/rnp_api.h
>  create mode 100644 drivers/net/rnp/base/rnp_cfg.h
>  create mode 100644 drivers/net/rnp/base/rnp_dma_regs.h
>  create mode 100644 drivers/net/rnp/base/rnp_eth_regs.h
>  create mode 100644 drivers/net/rnp/base/rnp_hw.h
>  create mode 100644 drivers/net/rnp/base/rnp_mac_regs.h
>  create mode 100644 drivers/net/rnp/meson.build
>  create mode 100644 drivers/net/rnp/rnp.h
>  create mode 100644 drivers/net/rnp/rnp_ethdev.c
>  create mode 100644 drivers/net/rnp/rnp_logs.h
>  create mode 100644 drivers/net/rnp/rnp_mbx.c
>  create mode 100644 drivers/net/rnp/rnp_mbx.h
>  create mode 100644 drivers/net/rnp/rnp_mbx_fw.c
>  create mode 100644 drivers/net/rnp/rnp_mbx_fw.h
>  create mode 100644 drivers/net/rnp/rnp_osdep.h
>  create mode 100644 drivers/net/rnp/rnp_rxtx.c
>  create mode 100644 drivers/net/rnp/rnp_rxtx.h

Your git commit headings are messed up with extra [].

RE: [[PATCH v1] 0/8] *** SUBJECT HERE ***

[11]

Your git commit headings are messed up with extra [].
Yes, this is my problem :) 
David has been mentioned before , I'm re edit the cover-letter now.
Thanks a lot.

Regards wenbo
-Original Message-
From: Stephen Hemminger  
Sent: 2023年8月2日 10:31
To: Wenbo Cao 
Cc: dev@dpdk.org
Subject: Re: [[PATCH v1] 0/8] *** SUBJECT HERE ***

On Tue,  1 Aug 2023 07:21:29 +
Wenbo Cao  wrote:

> *** BLURB HERE ***
> 
> Wenbo Cao (8):
>   net/rnp: add skeleton
>   net/rnp: add ethdev probe and remove
>   net/rnp: add device init and uninit
>   net/rnp: add mbx basic api feature
>   net/rnp add reset code for Chip Init process
>   net/rnp add port info resource init
>   net/rnp add devargs runtime parsing functions
>   net/rnp handle device interrupts
> 
>  MAINTAINERS |   6 +
>  doc/guides/nics/features/rnp.ini|   8 +
>  doc/guides/nics/index.rst   |   1 +
>  doc/guides/nics/rnp.rst |  43 ++
>  drivers/net/meson.build |   1 +
>  drivers/net/rnp/base/rnp_api.c  |  71 +++
>  drivers/net/rnp/base/rnp_api.h  |  17 +
>  drivers/net/rnp/base/rnp_cfg.h  |   7 +
>  drivers/net/rnp/base/rnp_dma_regs.h |  73 +++  
> drivers/net/rnp/base/rnp_eth_regs.h | 124 +
>  drivers/net/rnp/base/rnp_hw.h   | 193 +++
>  drivers/net/rnp/base/rnp_mac_regs.h | 279 ++
>  drivers/net/rnp/meson.build |  18 +
>  drivers/net/rnp/rnp.h   | 217 
>  drivers/net/rnp/rnp_ethdev.c| 823 
>  drivers/net/rnp/rnp_logs.h  |  43 ++
>  drivers/net/rnp/rnp_mbx.c   | 522 ++
>  drivers/net/rnp/rnp_mbx.h   | 139 +
>  drivers/net/rnp/rnp_mbx_fw.c| 781 ++
>  drivers/net/rnp/rnp_mbx_fw.h| 401 ++
>  drivers/net/rnp/rnp_osdep.h |  30 +
>  drivers/net/rnp/rnp_rxtx.c  |  83 +++
>  drivers/net/rnp/rnp_rxtx.h  |  14 +
>  23 files changed, 3894 insertions(+)
>  create mode 100644 doc/guides/nics/features/rnp.ini  create mode 
> 100644 doc/guides/nics/rnp.rst  create mode 100644 
> drivers/net/rnp/base/rnp_api.c  create mode 100644 
> drivers/net/rnp/base/rnp_api.h  create mode 100644 
> drivers/net/rnp/base/rnp_cfg.h  create mode 100644 
> drivers/net/rnp/base/rnp_dma_regs.h
>  create mode 100644 drivers/net/rnp/base/rnp_eth_regs.h
>  create mode 100644 drivers/net/rnp/base/rnp_hw.h  create mode 100644 
> drivers/net/rnp/base/rnp_mac_regs.h
>  create mode 100644 drivers/net/rnp/meson.build  create mode 100644 
> drivers/net/rnp/rnp.h  create mode 100644 drivers/net/rnp/rnp_ethdev.c  
> create mode 100644 drivers/net/rnp/rnp_logs.h  create mode 100644 
> drivers/net/rnp/rnp_mbx.c  create mode 100644 
> drivers/net/rnp/rnp_mbx.h  create mode 100644 
> drivers/net/rnp/rnp_mbx_fw.c  create mode 100644 
> drivers/net/rnp/rnp_mbx_fw.h  create mode 100644 
> drivers/net/rnp/rnp_osdep.h  create mode 100644 
> drivers/net/rnp/rnp_rxtx.c  create mode 100644 
> drivers/net/rnp/rnp_rxtx.h

Your git commit headings are messed up with extra [].

Re: [PATCH] app/testpmd: add flush multicast MAC address command

[huangdengdui]

在 2023/8/1 23:18, Stephen Hemminger 写道:
> On Tue, 1 Aug 2023 10:43:04 +0800
> Dengdui Huang  wrote:
> 
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>> index 0d0723f659..2d9d925776 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -494,6 +494,9 @@ static void cmd_help_long_parsed(void *parsed_result,
>>  "mac_addr remove (port_id) (XX:XX:XX:XX:XX:XX)\n"
>>  "Remove a MAC address from port_id.\n\n"
>>  
>> +"mcast_addr flush (port_id)\n"
>> +"To flush the set of multicast addresses.\n\n"
>> +
>>  "mac_addr set (port_id) (XX:XX:XX:XX:XX:XX)\n"
>>  "Set the default MAC address for port_id.\n\n"
> 
> Why out this in middle of the mac_addr commands? better to be in logical or 
> alpha order.
Sorry Stephen, I made a mistake in my reply. It's already in logical 
order(mac_addr/mcast_addr add/remove>other setting), the same order as in 
the doc.
The order looks odd because the help command doesn't have a description of 
"multicast add/remove".Do you agree with this explanation?

[PATCH v2] app/testpmd: fix UDP cksum error for UFO enable

[Huisong Li]

The command "tso set  " is used to enable UFO, please
see commit ce8e6e742807 ("app/testpmd: support UFO in checksum engine")

The above patch configures the RTE_MBUF_F_TX_UDP_SEG to enable UFO only if
tso_segsz is set. Then tx_prepare() may call rte_net_intel_cksum_prepare()
to compute pseudo header checksum (because some PMDs may supports TSO).
As a result, if the peer sends UDP packets, all packets with UDP checksum
error are received for the PMDs only supported TSO.

So enabling UFO also depends on if driver has RTE_ETH_TX_OFFLOAD_UDP_TSO
capability. Similarly, TSO also need to do like this.

In addition, this patch also fixes cmd_tso_set_parsed() for UFO to make
it better to support TSO and UFO.

Fixes: ce8e6e742807 ("app/testpmd: support UFO in checksum engine")

Signed-off-by: Huisong Li 
---
 v2: add handle for tunnel TSO offload in process_inner_cksums

---
 app/test-pmd/cmdline.c  | 47 +
 app/test-pmd/csumonly.c | 11 --
 2 files changed, 33 insertions(+), 25 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 0d0723f659..8be593d405 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -4906,6 +4906,7 @@ cmd_tso_set_parsed(void *parsed_result,
 {
struct cmd_tso_set_result *res = parsed_result;
struct rte_eth_dev_info dev_info;
+   uint64_t offloads;
int ret;
 
if (port_id_is_invalid(res->port_id, ENABLED_WARN))
@@ -4922,37 +4923,37 @@ cmd_tso_set_parsed(void *parsed_result,
if (ret != 0)
return;
 
-   if ((ports[res->port_id].tso_segsz != 0) &&
-   (dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_TCP_TSO) == 0) {
-   fprintf(stderr, "Error: TSO is not supported by port %d\n",
-   res->port_id);
-   return;
+   if (ports[res->port_id].tso_segsz != 0) {
+   if ((dev_info.tx_offload_capa & (RTE_ETH_TX_OFFLOAD_TCP_TSO |
+   RTE_ETH_TX_OFFLOAD_UDP_TSO)) == 0) {
+   fprintf(stderr, "Error: both TSO and UFO are not 
supported by port %d\n",
+   res->port_id);
+   return;
+   }
+   /* display warnings if configuration is not supported by the 
NIC */
+   if ((dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_TCP_TSO) == 
0)
+   fprintf(stderr, "Warning: port %d doesn't support 
TSO\n",
+   res->port_id);
+   if ((dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_UDP_TSO) == 
0)
+   fprintf(stderr, "Warning: port %d doesn't support 
UFO\n",
+   res->port_id);
}
 
if (ports[res->port_id].tso_segsz == 0) {
ports[res->port_id].dev_conf.txmode.offloads &=
-   ~RTE_ETH_TX_OFFLOAD_TCP_TSO;
-   printf("TSO for non-tunneled packets is disabled\n");
+   ~(RTE_ETH_TX_OFFLOAD_TCP_TSO | 
RTE_ETH_TX_OFFLOAD_UDP_TSO);
+   printf("TSO and UFO for non-tunneled packets is disabled\n");
} else {
-   ports[res->port_id].dev_conf.txmode.offloads |=
-   RTE_ETH_TX_OFFLOAD_TCP_TSO;
-   printf("TSO segment size for non-tunneled packets is %d\n",
+   offloads = (dev_info.tx_offload_capa & 
RTE_ETH_TX_OFFLOAD_TCP_TSO) ?
+   RTE_ETH_TX_OFFLOAD_TCP_TSO : 0;
+   offloads |= (dev_info.tx_offload_capa & 
RTE_ETH_TX_OFFLOAD_UDP_TSO) ?
+   RTE_ETH_TX_OFFLOAD_UDP_TSO : 0;
+   ports[res->port_id].dev_conf.txmode.offloads |= offloads;
+   printf("segment size for non-tunneled packets is %d\n",
ports[res->port_id].tso_segsz);
}
-   cmd_config_queue_tx_offloads(&ports[res->port_id]);
-
-   /* display warnings if configuration is not supported by the NIC */
-   ret = eth_dev_info_get_print_err(res->port_id, &dev_info);
-   if (ret != 0)
-   return;
-
-   if ((ports[res->port_id].tso_segsz != 0) &&
-   (dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_TCP_TSO) == 0) {
-   fprintf(stderr,
-   "Warning: TSO enabled but not supported by port %d\n",
-   res->port_id);
-   }
 
+   cmd_config_queue_tx_offloads(&ports[res->port_id]);
cmd_reconfig_device_queue(res->port_id, 1, 1);
 }
 
diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index c103e54111..21210aff43 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -466,6 +466,12 @@ process_inner_cksums(void *l3_hdr, const struct 
testpmd_offload_info *info,
uint64_t ol_flags = 0;
uint32_t max_pkt_len, tso_segsz = 0;
uint16_t l4_off;
+   uint

[PATCH RESEND v6 5/5] app/testpmd: stop forwarding in new or destroy event

[Huisong Li]

When testpmd receives the new or destroy event, the port related
information will be updated. Testpmd must stop packet forwarding
before updating the information to avoid some serious problems.

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
---
 app/test-pmd/testpmd.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index a5124c3231..15cbede69b 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3953,6 +3953,8 @@ eth_event_callback(portid_t port_id, enum 
rte_eth_event_type type, void *param,
 
switch (type) {
case RTE_ETH_EVENT_NEW:
+   if (test_done == 0)
+   stop_packet_forwarding();
if (setup_on_probe_event)
setup_attached_port(port_id);
break;
@@ -3963,6 +3965,8 @@ eth_event_callback(portid_t port_id, enum 
rte_eth_event_type type, void *param,
"Could not set up deferred device removal\n");
break;
case RTE_ETH_EVENT_DESTROY:
+   if (test_done == 0)
+   stop_packet_forwarding();
ports[port_id].port_status = RTE_PORT_CLOSED;
printf("Port %u is closed\n", port_id);
if (rte_eal_alarm_set(10, remove_invalid_ports_callback,
-- 
2.22.0

[PATCH RESEND v6 3/5] app/testpmd: check the validity of the port

[Huisong Li]

This patch checks the validity of port id for all events in
'eth_event_callback()'.

Signed-off-by: Huisong Li 
Acked-by: Aman Singh 
Acked-by: Chengwen Feng 
---
 app/test-pmd/testpmd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 938ca035d4..f934f6b418 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3945,14 +3945,15 @@ eth_event_callback(portid_t port_id, enum 
rte_eth_event_type type, void *param,
fflush(stdout);
}
 
+   if (port_id_is_invalid(port_id, DISABLED_WARN))
+   return 0;
+
switch (type) {
case RTE_ETH_EVENT_NEW:
ports[port_id].need_setup = 1;
ports[port_id].port_status = RTE_PORT_HANDLING;
break;
case RTE_ETH_EVENT_INTR_RMV:
-   if (port_id_is_invalid(port_id, DISABLED_WARN))
-   break;
if (rte_eal_alarm_set(10,
rmv_port_callback, (void *)(intptr_t)port_id))
fprintf(stderr,
-- 
2.22.0

[PATCH RESEND v6 0/5] app/testpmd: support multiple process attach and detach port

[Huisong Li]

This patchset fix some bugs and support attaching and detaching port
in primary and secondary.

---
 -v6: adjust rte_eth_dev_is_used position based on alphabetical order
  in version.map
 -v5: move 'ALLOCATED' state to the back of 'REMOVED' to avoid abi break.
 -v4: fix a misspelling. 
 -v3:
   #1 merge patch 1/6 and patch 2/6 into patch 1/5, and add modification
  for other bus type.
   #2 add a RTE_ETH_DEV_ALLOCATED state in rte_eth_dev_state to resolve
  the probelm in patch 2/5. 
 -v2: resend due to CI unexplained failure.

Huisong Li (5):
  drivers/bus: restore driver assignment at front of probing
  ethdev: fix skip valid port in probing callback
  app/testpmd: check the validity of the port
  app/testpmd: add attach and detach port for multiple process
  app/testpmd: stop forwarding in new or destroy event

 app/test-pmd/testpmd.c   | 47 +++-
 app/test-pmd/testpmd.h   |  1 -
 drivers/bus/auxiliary/auxiliary_common.c |  9 -
 drivers/bus/dpaa/dpaa_bus.c  |  9 -
 drivers/bus/fslmc/fslmc_bus.c|  8 +++-
 drivers/bus/ifpga/ifpga_bus.c| 12 --
 drivers/bus/pci/pci_common.c |  9 -
 drivers/bus/vdev/vdev.c  | 10 -
 drivers/bus/vmbus/vmbus_common.c |  9 -
 drivers/net/bnxt/bnxt_ethdev.c   |  3 +-
 drivers/net/bonding/bonding_testpmd.c|  1 -
 drivers/net/mlx5/mlx5.c  |  2 +-
 lib/ethdev/ethdev_driver.c   | 13 +--
 lib/ethdev/ethdev_driver.h   | 12 ++
 lib/ethdev/ethdev_pci.h  |  2 +-
 lib/ethdev/rte_class_eth.c   |  2 +-
 lib/ethdev/rte_ethdev.c  |  4 +-
 lib/ethdev/rte_ethdev.h  |  4 +-
 lib/ethdev/version.map   |  1 +
 19 files changed, 114 insertions(+), 44 deletions(-)

-- 
2.22.0

[PATCH RESEND v6 4/5] app/testpmd: add attach and detach port for multiple process

[Huisong Li]

The port information needs to be updated due to attaching and detaching
port. Currently, it is done in the same thread as removing or probing
device, which doesn't satisfy the operation of attaching and detaching
device in multiple process.

If this operation is performed in one process, the other process can
receive 'new' or 'destroy' event. So we can move updating port information
to event callback to support attaching and detaching port in primary and
secondary process.

The reason for adding an alarm callback in 'destroy' event is that the
ethdev state is changed from 'ATTACHED' to 'UNUSED' only after the event
callback finished. But the remove_invalid_ports() function removes invalid
port only if ethdev state is 'UNUSED'. If we don't add alarm callback, this
detached port information can not be removed.

Signed-off-by: Huisong Li 
Signed-off-by: Dongdong Liu 
Acked-by: Chengwen Feng 
---
 app/test-pmd/testpmd.c| 38 ---
 app/test-pmd/testpmd.h|  1 -
 drivers/net/bonding/bonding_testpmd.c |  1 -
 3 files changed, 22 insertions(+), 18 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index f934f6b418..a5124c3231 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3610,15 +3610,12 @@ attach_port(char *identifier)
return;
}
 
-   /* first attach mode: event */
-   if (setup_on_probe_event) {
-   /* new ports are detected on RTE_ETH_EVENT_NEW event */
-   for (pi = 0; pi < RTE_MAX_ETHPORTS; pi++)
-   if (ports[pi].port_status == RTE_PORT_HANDLING &&
-   ports[pi].need_setup != 0)
-   setup_attached_port(pi);
+   /*
+* first attach mode: event, setting up attached port is done in
+* probing callback.
+*/
+   if (setup_on_probe_event)
return;
-   }
 
/* second attach mode: iterator */
RTE_ETH_FOREACH_MATCHING_DEV(pi, identifier, &iterator) {
@@ -3649,7 +3646,6 @@ setup_attached_port(portid_t pi)
ports_ids[nb_ports++] = pi;
fwd_ports_ids[nb_fwd_ports++] = pi;
nb_cfg_ports = nb_fwd_ports;
-   ports[pi].need_setup = 0;
ports[pi].port_status = RTE_PORT_STOPPED;
 
printf("Port %d is attached. Now total ports is %d\n", pi, nb_ports);
@@ -3683,10 +3679,8 @@ detach_device(struct rte_device *dev)
TESTPMD_LOG(ERR, "Failed to detach device %s\n", 
rte_dev_name(dev));
return;
}
-   remove_invalid_ports();
 
printf("Device is detached\n");
-   printf("Now total ports is %d\n", nb_ports);
printf("Done\n");
return;
 }
@@ -3753,11 +3747,9 @@ detach_devargs(char *identifier)
return;
}
 
-   remove_invalid_ports();
-
printf("Device %s is detached\n", identifier);
-   printf("Now total ports is %d\n", nb_ports);
printf("Done\n");
+
rte_devargs_reset(&da);
 }
 
@@ -3921,11 +3913,22 @@ rmv_port_callback(void *arg)
struct rte_device *device = dev_info.device;
close_port(port_id);
detach_device(device); /* might be already removed or have more 
ports */
+   remove_invalid_ports();
+   printf("Now total ports is %d\n", nb_ports);
}
if (need_to_start)
start_packet_forwarding(0);
 }
 
+static void
+remove_invalid_ports_callback(void *arg)
+{
+   RTE_SET_USED(arg);
+
+   remove_invalid_ports();
+   printf("Now total ports is %d\n", nb_ports);
+}
+
 /* This function is used by the interrupt thread */
 static int
 eth_event_callback(portid_t port_id, enum rte_eth_event_type type, void *param,
@@ -3950,8 +3953,8 @@ eth_event_callback(portid_t port_id, enum 
rte_eth_event_type type, void *param,
 
switch (type) {
case RTE_ETH_EVENT_NEW:
-   ports[port_id].need_setup = 1;
-   ports[port_id].port_status = RTE_PORT_HANDLING;
+   if (setup_on_probe_event)
+   setup_attached_port(port_id);
break;
case RTE_ETH_EVENT_INTR_RMV:
if (rte_eal_alarm_set(10,
@@ -3962,6 +3965,9 @@ eth_event_callback(portid_t port_id, enum 
rte_eth_event_type type, void *param,
case RTE_ETH_EVENT_DESTROY:
ports[port_id].port_status = RTE_PORT_CLOSED;
printf("Port %u is closed\n", port_id);
+   if (rte_eal_alarm_set(10, remove_invalid_ports_callback,
+   (void *)(intptr_t)port_id))
+   fprintf(stderr, "Could not set up deferred device 
released\n");
break;
case RTE_ETH_EVENT_RX_AVAIL_THRESH: {
uint16_t rxq_id;
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index f1df6a8faf..daacdd7ee4 100644
--- a/app/test-pmd/testpmd.h
+++ b/ap

[PATCH RESEND v6 2/5] ethdev: fix skip valid port in probing callback

[Huisong Li]

The event callback in application may use the macro RTE_ETH_FOREACH_DEV to
iterate over all enabled ports to do something(like, verifying the port id
validity) when receive a probing event. If the ethdev state of a port is
not RTE_ETH_DEV_UNUSED, this port will be considered as a valid port.

However, this state is set to RTE_ETH_DEV_ATTACHED after pushing probing
event. It means that probing callback will skip this port. But this
assignment can not move to front of probing notification. See
commit be8cd210379a ("ethdev: fix port probing notification")

So this patch has to add a new state, RTE_ETH_DEV_ALLOCATED. Set the ethdev
state to RTE_ETH_DEV_ALLOCATED before pushing probing event and set it to
RTE_ETH_DEV_ATTACHED after definitely probed. And this port is valid if its
device state is 'ALLOCATED' or 'ATTACHED'.

In addition, the new state has to be placed behind 'REMOVED' to avoid ABI
break. Fortunately, this ethdev state is internal and applications can not
access it directly. So this patch encapsulates an API, rte_eth_dev_is_used,
for ethdev or PMD to call and eliminate concerns about using this state
enum value comparison.

Fixes: be8cd210379a ("ethdev: fix port probing notification")
Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
---
 drivers/net/bnxt/bnxt_ethdev.c |  3 ++-
 drivers/net/mlx5/mlx5.c|  2 +-
 lib/ethdev/ethdev_driver.c | 13 ++---
 lib/ethdev/ethdev_driver.h | 12 
 lib/ethdev/ethdev_pci.h|  2 +-
 lib/ethdev/rte_class_eth.c |  2 +-
 lib/ethdev/rte_ethdev.c|  4 ++--
 lib/ethdev/rte_ethdev.h|  4 +++-
 lib/ethdev/version.map |  1 +
 9 files changed, 33 insertions(+), 10 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index ee1552452a..bf1910709b 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -6108,7 +6108,8 @@ bnxt_dev_uninit(struct rte_eth_dev *eth_dev)
 
PMD_DRV_LOG(DEBUG, "Calling Device uninit\n");
 
-   if (eth_dev->state != RTE_ETH_DEV_UNUSED)
+
+   if (rte_eth_dev_is_used(eth_dev->state))
bnxt_dev_close_op(eth_dev);
 
return 0;
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index b373306f98..54c6fff889 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -3152,7 +3152,7 @@ mlx5_eth_find_next(uint16_t port_id, struct rte_device 
*odev)
while (port_id < RTE_MAX_ETHPORTS) {
struct rte_eth_dev *dev = &rte_eth_devices[port_id];
 
-   if (dev->state != RTE_ETH_DEV_UNUSED &&
+   if (rte_eth_dev_is_used(dev->state) &&
dev->device &&
(dev->device == odev ||
 (dev->device->driver &&
diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c
index 0be1e8ca04..29e9417bea 100644
--- a/lib/ethdev/ethdev_driver.c
+++ b/lib/ethdev/ethdev_driver.c
@@ -50,8 +50,8 @@ eth_dev_find_free_port(void)
for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
/* Using shared name field to find a free port. */
if (eth_dev_shared_data->data[i].name[0] == '\0') {
-   RTE_ASSERT(rte_eth_devices[i].state ==
-  RTE_ETH_DEV_UNUSED);
+   RTE_ASSERT(!rte_eth_dev_is_used(
+   rte_eth_devices[i].state));
return i;
}
}
@@ -208,11 +208,18 @@ rte_eth_dev_probing_finish(struct rte_eth_dev *dev)
if (rte_eal_process_type() == RTE_PROC_SECONDARY)
eth_dev_fp_ops_setup(rte_eth_fp_ops + dev->data->port_id, dev);
 
+   dev->state = RTE_ETH_DEV_ALLOCATED;
rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_NEW, NULL);
 
dev->state = RTE_ETH_DEV_ATTACHED;
 }
 
+bool rte_eth_dev_is_used(uint16_t dev_state)
+{
+   return dev_state == RTE_ETH_DEV_ALLOCATED ||
+   dev_state == RTE_ETH_DEV_ATTACHED;
+}
+
 int
 rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)
 {
@@ -221,7 +228,7 @@ rte_eth_dev_release_port(struct rte_eth_dev *eth_dev)
 
eth_dev_shared_data_prepare();
 
-   if (eth_dev->state != RTE_ETH_DEV_UNUSED)
+   if (rte_eth_dev_is_used(eth_dev->state))
rte_eth_dev_callback_process(eth_dev,
RTE_ETH_EVENT_DESTROY, NULL);
 
diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h
index 980f837ab6..5bd2780643 100644
--- a/lib/ethdev/ethdev_driver.h
+++ b/lib/ethdev/ethdev_driver.h
@@ -1582,6 +1582,18 @@ int rte_eth_dev_callback_process(struct rte_eth_dev *dev,
 __rte_internal
 void rte_eth_dev_probing_finish(struct rte_eth_dev *dev);
 
+/**
+ * Check if a Ethernet device state is used or not
+ *
+ * @param dev_state
+ *   The state of the Ethernet device
+ * @return
+ *   - true if the state of the Ethernet device is allocated or attached
+ *   - false if this s

[PATCH RESEND v6 1/5] drivers/bus: restore driver assignment at front of probing

[Huisong Li]

The driver assignment was moved back at the end of the device probing
because there is no something to use rte_driver during the phase of
probing. See commit 391797f04208 ("drivers/bus: move driver assignment
to end of probing")

However, it is necessary for probing callback to reference rte_driver
before probing. For example, probing callback may call some APIs which
access the rte_pci_driver::driver by the device::driver pointer to get
driver information. In this case, a segment fault will occur in probing
callback if there is not this assignment.

Further, some comments in code need to be updated if we do that. The
driver pointer in rte_device is set before probing and needs to be reset
if probing failed. And rte_dev_is_probed can not be called inside probing.

Fixes: 391797f04208 ("drivers/bus: move driver assignment to end of probing")
Cc: sta...@dpdk.org

Signed-off-by: Huisong Li 
Acked-by: Chengwen Feng 
---
 drivers/bus/auxiliary/auxiliary_common.c |  9 +++--
 drivers/bus/dpaa/dpaa_bus.c  |  9 +++--
 drivers/bus/fslmc/fslmc_bus.c|  8 +++-
 drivers/bus/ifpga/ifpga_bus.c| 12 +---
 drivers/bus/pci/pci_common.c |  9 +++--
 drivers/bus/vdev/vdev.c  | 10 --
 drivers/bus/vmbus/vmbus_common.c |  9 +++--
 7 files changed, 52 insertions(+), 14 deletions(-)

diff --git a/drivers/bus/auxiliary/auxiliary_common.c 
b/drivers/bus/auxiliary/auxiliary_common.c
index 29f99342a7..6313684b8f 100644
--- a/drivers/bus/auxiliary/auxiliary_common.c
+++ b/drivers/bus/auxiliary/auxiliary_common.c
@@ -132,16 +132,21 @@ rte_auxiliary_probe_one_driver(struct 
rte_auxiliary_driver *drv,
}
 
dev->driver = drv;
+   /*
+* Reference rte_driver before probing so as to this pointer can
+* be used to get driver information in case of segment fault in
+* probing callback.
+*/
+   dev->device.driver = &drv->driver;
 
AUXILIARY_LOG(INFO, "Probe auxiliary driver: %s device: %s (NUMA node 
%i)",
  drv->driver.name, dev->name, dev->device.numa_node);
ret = drv->probe(drv, dev);
if (ret != 0) {
dev->driver = NULL;
+   dev->device.driver = NULL;
rte_intr_instance_free(dev->intr_handle);
dev->intr_handle = NULL;
-   } else {
-   dev->device.driver = &drv->driver;
}
 
return ret;
diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c
index e57159f5d8..f1b817e58c 100644
--- a/drivers/bus/dpaa/dpaa_bus.c
+++ b/drivers/bus/dpaa/dpaa_bus.c
@@ -693,17 +693,22 @@ rte_dpaa_bus_probe(void)
(dev->device.devargs &&
 dev->device.devargs->policy == RTE_DEV_BLOCKED))
continue;
-
+   /*
+* Reference rte_driver before probing so as to this
+* pointer can be used to get driver information in case
+* of segment fault in probing callback.
+*/
+   dev->device.driver = &drv->driver;
if (probe_all ||
(dev->device.devargs &&
 dev->device.devargs->policy == RTE_DEV_ALLOWED)) {
ret = drv->probe(drv, dev);
if (ret) {
+   dev->device.driver = NULL;
DPAA_BUS_ERR("unable to probe:%s",
 dev->name);
} else {
dev->driver = drv;
-   dev->device.driver = &drv->driver;
}
}
break;
diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index 57bfb5111a..4bc0c6d3d4 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -471,15 +471,21 @@ rte_fslmc_probe(void)
continue;
}
 
+   /*
+* Reference rte_driver before probing so as to this
+* pointer can be used to get driver information in case
+* of segment fault in probing callback.
+*/
+   dev->device.driver = &drv->driver;
if (probe_all ||
   (dev->device.devargs &&
dev->device.devargs->policy == RTE_DEV_ALLOWED)) {
ret = drv->probe(drv, dev);
if (ret) {
+   dev->device.driver = NULL;
DPAA2_BUS_ERR("Unable

Re: [PATCH] app/testpmd: add flush multicast MAC address command

[Stephen Hemminger]

On Wed, 2 Aug 2023 10:41:46 +0800
huangdengdui  wrote:

> 在 2023/8/1 23:18, Stephen Hemminger 写道:
> > On Tue, 1 Aug 2023 10:43:04 +0800
> > Dengdui Huang  wrote:
> >   
> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> >> index 0d0723f659..2d9d925776 100644
> >> --- a/app/test-pmd/cmdline.c
> >> +++ b/app/test-pmd/cmdline.c
> >> @@ -494,6 +494,9 @@ static void cmd_help_long_parsed(void *parsed_result,
> >>"mac_addr remove (port_id) (XX:XX:XX:XX:XX:XX)\n"
> >>"Remove a MAC address from port_id.\n\n"
> >>  
> >> +  "mcast_addr flush (port_id)\n"
> >> +  "To flush the set of multicast addresses.\n\n"
> >> +
> >>"mac_addr set (port_id) (XX:XX:XX:XX:XX:XX)\n"
> >>"Set the default MAC address for port_id.\n\n"  
> > 
> > Why out this in middle of the mac_addr commands? better to be in logical or 
> > alpha order.  
> Sorry Stephen, I made a mistake in my reply. It's already in logical 
> order(mac_addr/mcast_addr add/remove>other setting), the same order as in 
> the doc.
> The order looks odd because the help command doesn't have a description of 
> "multicast add/remove".Do you agree with this explanation?

The help is already a bit of a mess. It really needs to be split up more.

Lets add the new line after "set allmulti"?

[PATCH v3 0/4] eal: update public API to use stdatomic atomics

[Tyler Retzlaff]

Update EAL public API to use standard C11 atomics. In accordance with
technical board discussion February 2023.
http://mails.dpdk.org/archives/dev/2023-February/263516.html

This initial series makes no attempt to adapt every use of builtin atomics
from GCC it intends only to adapt the public API of the EAL presented as
a compatibility surface to applications.

Further series will be submitted to adapt the rest of DPDK to use standard
atomics that are 'internal' and not do not straddle the EAL API.

The choice has been made to break these two changes apart to allow more
precise analysis of any potential performance impact this change or
subsequent changes may introduce.

Additionally, it is not possible to break the commits up per driver/lib as
both the provider and consumer of the APIs need to be changed in the same
commit to maintain non-broken build and function.

Finally, the first patch in this series is a duplication of Bruce Richardson
series https://patchwork.dpdk.org/project/dpdk/list/?series=29048 and is
only being provided to enable the CI run on this series. It is expected that
Bruce's series when committed will allow the build: require minimum c11 compiler
here to be dropped from this series.

v3:
  * restore incorrectly dropped architecture specific #include "rte_paused.h"
for loongarch, ppc, riscv
  * convert parameters to stdatomic in RTE_WAIT_UNTIL_MASKED macro usage
(missed previously)
  * lib/ring missed some conversion to stdatomic on struct rte_ring _Atomic
fields (picked up by clang which is more strict than gcc)
  * drivers/mlx5 use stdatomic operations on struct rte_ring _Atomic fields
(picked up by clang which is more strict than gcc)

v2:
  * remove volatile qualification from variables, structure fields and
parameters that have been qualified _Atomic
  * restore removal of #include  in rte_ring_core.h the ring
library still uses other rte_atomic APIs and types that are not replaced
by the standard or compiler intrinsics
  * add missing adaption to stdatomic in ring/rte_ring_c11_pvt.h

Tyler Retzlaff (4):
  build: require minimum c11 compiler
  devtools: forbid use of GCC atomic builtins
  eal: adapt rte pause APIs to use C11 atomics
  eal: adapt rte spinlock and rwlock APIs to use C11 atomics

 app/test-bbdev/test_bbdev_perf.c | 123 ---
 app/test/test_func_reentrancy.c  |   8 +-
 app/test/test_mcslock.c  |  12 +--
 app/test/test_mempool_perf.c |   8 +-
 app/test/test_pflock.c   |  12 +--
 app/test/test_pmd_perf.c |  10 +--
 app/test/test_ring_perf.c|   8 +-
 app/test/test_rwlock.c   |   8 +-
 app/test/test_spinlock.c |   8 +-
 app/test/test_stack_perf.c   |  12 +--
 app/test/test_ticketlock.c   |   8 +-
 app/test/test_timer.c|  16 ++--
 devtools/checkpatches.sh |   8 ++
 drivers/event/opdl/opdl_ring.c   |  47 ++--
 drivers/net/failsafe/meson.build |   1 -
 drivers/net/mlx5/mlx5_hws_cnt.h  |   4 +-
 drivers/net/thunderx/nicvf_rxtx.c|   5 +-
 drivers/net/thunderx/nicvf_struct.h  |   2 +-
 lib/bpf/bpf_pkt.c|   6 +-
 lib/distributor/distributor_private.h|   2 +-
 lib/distributor/rte_distributor_single.c |  44 +--
 lib/eal/arm/include/rte_pause_64.h   |  28 +++
 lib/eal/common/eal_common_errno.c|   1 +
 lib/eal/common/eal_memcfg.h  |   2 +-
 lib/eal/include/generic/rte_pause.h  |  51 ++---
 lib/eal/include/generic/rte_rwlock.h |  46 ++--
 lib/eal/include/generic/rte_spinlock.h   |  21 +++---
 lib/eal/include/rte_mcslock.h|  14 ++--
 lib/eal/include/rte_pflock.h |  22 +++---
 lib/eal/include/rte_ticketlock.h |   8 +-
 lib/eal/loongarch/include/rte_pause.h|   2 +-
 lib/eal/ppc/include/rte_pause.h  |   2 +-
 lib/eal/riscv/include/rte_pause.h|   2 +-
 lib/eal/x86/include/rte_spinlock.h   |   2 +-
 lib/ring/rte_ring_c11_pvt.h  |  42 ++-
 lib/ring/rte_ring_core.h |   4 +-
 lib/ring/rte_ring_generic_pvt.h  |  19 +++--
 lib/ring/rte_ring_peek_elem_pvt.h|   2 +-
 meson.build  |   1 +
 39 files changed, 340 insertions(+), 281 deletions(-)

-- 
1.8.3.1

[PATCH v3 1/4] build: require minimum c11 compiler

[Tyler Retzlaff]

Update top level meson.build to require c_std=c11 and remove use of
-std=gnu99.

Signed-off-by: Tyler Retzlaff 
---
 drivers/net/failsafe/meson.build  | 1 -
 lib/eal/common/eal_common_errno.c | 1 +
 meson.build   | 1 +
 3 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/failsafe/meson.build b/drivers/net/failsafe/meson.build
index 6013e13..c1d3610 100644
--- a/drivers/net/failsafe/meson.build
+++ b/drivers/net/failsafe/meson.build
@@ -7,7 +7,6 @@ if is_windows
 subdir_done()
 endif
 
-cflags += '-std=gnu99'
 cflags += '-D_DEFAULT_SOURCE'
 cflags += '-D_XOPEN_SOURCE=700'
 cflags += '-pedantic'
diff --git a/lib/eal/common/eal_common_errno.c 
b/lib/eal/common/eal_common_errno.c
index ef8f782..d4e2c13 100644
--- a/lib/eal/common/eal_common_errno.c
+++ b/lib/eal/common/eal_common_errno.c
@@ -4,6 +4,7 @@
 
 /* Use XSI-compliant portable version of strerror_r() */
 #undef _GNU_SOURCE
+#define _POSIX_C_SOURCE 200112L
 
 #include 
 #include 
diff --git a/meson.build b/meson.build
index 39cb738..70b54f0 100644
--- a/meson.build
+++ b/meson.build
@@ -9,6 +9,7 @@ project('DPDK', 'c',
 license: 'BSD',
 default_options: [
 'buildtype=release',
+'c_std=c11',
 'default_library=static',
 'warning_level=2',
 ],
-- 
1.8.3.1

[PATCH v3 2/4] devtools: forbid use of GCC atomic builtins

[Tyler Retzlaff]

Refrain from using compiler __atomic_xxx builtins DPDK now uses standard
C11 atomics atomic_xxx.

Signed-off-by: Tyler Retzlaff 
Acked-by: Morten Brørup 
---
 devtools/checkpatches.sh | 8 
 1 file changed, 8 insertions(+)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 43f5e36..a32f02e 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -102,6 +102,14 @@ check_forbidden_additions() { # 
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
 
+   # refrain from using compiler __atomic_xxx builtins
+   awk -v FOLDERS="lib drivers app examples" \
+   -v EXPRESSIONS="__atomic_.*\\\(" \
+   -v RET_ON_FAIL=1 \
+   -v MESSAGE='Using __atomic_xxx builtins' \
+   -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+   "$1" || res=1
+
# refrain from using compiler __atomic_thread_fence()
# It should be avoided on x86 for SMP case.
awk -v FOLDERS="lib drivers app examples" \
-- 
1.8.3.1

[PATCH v3 3/4] eal: adapt rte pause APIs to use C11 atomics

[Tyler Retzlaff]

Adapt rte_pause.h APIs to use standard C11 atomics. Update consumers of
the pause APIs for the API break.

Signed-off-by: Tyler Retzlaff 
Acked-by: Morten Brørup 
---
 app/test-bbdev/test_bbdev_perf.c | 123 ---
 app/test/test_func_reentrancy.c  |   8 +-
 app/test/test_mcslock.c  |  12 +--
 app/test/test_mempool_perf.c |   8 +-
 app/test/test_pflock.c   |  12 +--
 app/test/test_pmd_perf.c |  10 +--
 app/test/test_ring_perf.c|   8 +-
 app/test/test_rwlock.c   |   8 +-
 app/test/test_spinlock.c |   8 +-
 app/test/test_stack_perf.c   |  12 +--
 app/test/test_ticketlock.c   |   8 +-
 app/test/test_timer.c|  16 ++--
 drivers/event/opdl/opdl_ring.c   |  47 ++--
 drivers/net/mlx5/mlx5_hws_cnt.h  |   4 +-
 drivers/net/thunderx/nicvf_rxtx.c|   5 +-
 drivers/net/thunderx/nicvf_struct.h  |   2 +-
 lib/bpf/bpf_pkt.c|   6 +-
 lib/distributor/distributor_private.h|   2 +-
 lib/distributor/rte_distributor_single.c |  44 +--
 lib/eal/arm/include/rte_pause_64.h   |  28 +++
 lib/eal/common/eal_memcfg.h  |   2 +-
 lib/eal/include/generic/rte_pause.h  |  51 ++---
 lib/eal/include/rte_mcslock.h|  14 ++--
 lib/eal/include/rte_pflock.h |  22 +++---
 lib/eal/include/rte_ticketlock.h |   8 +-
 lib/eal/loongarch/include/rte_pause.h|   2 +-
 lib/eal/ppc/include/rte_pause.h  |   2 +-
 lib/eal/riscv/include/rte_pause.h|   2 +-
 lib/ring/rte_ring_c11_pvt.h  |  42 ++-
 lib/ring/rte_ring_core.h |   4 +-
 lib/ring/rte_ring_generic_pvt.h  |  19 +++--
 lib/ring/rte_ring_peek_elem_pvt.h|   2 +-
 32 files changed, 294 insertions(+), 247 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 276bbf0..c3a3a28 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -143,7 +143,7 @@ struct test_op_params {
uint16_t num_to_process;
uint16_t num_lcores;
int vector_mask;
-   uint16_t sync;
+   uint16_t _Atomic sync;
struct test_buffers q_bufs[RTE_MAX_NUMA_NODES][MAX_QUEUES];
 };
 
@@ -158,7 +158,7 @@ struct thread_params {
uint8_t iter_count;
double iter_average;
double bler;
-   uint16_t nb_dequeued;
+   uint16_t _Atomic nb_dequeued;
int16_t processing_status;
uint16_t burst_sz;
struct test_op_params *op_params;
@@ -3021,27 +3021,32 @@ typedef int (test_case_function)(struct active_device 
*ad,
if (test_vector.op_type == RTE_BBDEV_OP_TURBO_DEC)
deq = rte_bbdev_dequeue_dec_ops(dev_id, queue_id,
&tp->dec_ops[
-   __atomic_load_n(&tp->nb_dequeued, 
__ATOMIC_RELAXED)],
+   atomic_load_explicit(&tp->nb_dequeued,
+   memory_order_relaxed)],
burst_sz);
else if (test_vector.op_type == RTE_BBDEV_OP_LDPC_DEC)
deq = rte_bbdev_dequeue_ldpc_dec_ops(dev_id, queue_id,
&tp->dec_ops[
-   __atomic_load_n(&tp->nb_dequeued, 
__ATOMIC_RELAXED)],
+   atomic_load_explicit(&tp->nb_dequeued,
+   memory_order_relaxed)],
burst_sz);
else if (test_vector.op_type == RTE_BBDEV_OP_LDPC_ENC)
deq = rte_bbdev_dequeue_ldpc_enc_ops(dev_id, queue_id,
&tp->enc_ops[
-   __atomic_load_n(&tp->nb_dequeued, 
__ATOMIC_RELAXED)],
+   atomic_load_explicit(&tp->nb_dequeued,
+   memory_order_relaxed)],
burst_sz);
else if (test_vector.op_type == RTE_BBDEV_OP_FFT)
deq = rte_bbdev_dequeue_fft_ops(dev_id, queue_id,
&tp->fft_ops[
-   __atomic_load_n(&tp->nb_dequeued, 
__ATOMIC_RELAXED)],
+   atomic_load_explicit(&tp->nb_dequeued,
+   memory_order_relaxed)],
burst_sz);
else /*RTE_BBDEV_OP_TURBO_ENC*/
deq = rte_bbdev_dequeue_enc_ops(dev_id, queue_id,
&tp->enc_ops[
-   __atomic_load_n(&tp->nb_dequeued, 
__ATOMIC_RELAXED)],
+   atomic_load_explicit(&tp->nb_dequeued,
+   

[PATCH v3 4/4] eal: adapt rte spinlock and rwlock APIs to use C11 atomics

[Tyler Retzlaff]

Adapt rte_spinlock.h and rte_rwlock.h APIs to use standard C11 atomics.
Update consumers of the spinlock and rwlock APIs for the API break.

Signed-off-by: Tyler Retzlaff 
Acked-by: Morten Brørup 
---
 lib/eal/include/generic/rte_rwlock.h   | 46 ++
 lib/eal/include/generic/rte_spinlock.h | 21 
 lib/eal/x86/include/rte_spinlock.h |  2 +-
 3 files changed, 36 insertions(+), 33 deletions(-)

diff --git a/lib/eal/include/generic/rte_rwlock.h 
b/lib/eal/include/generic/rte_rwlock.h
index 9e083bb..b659c4c 100644
--- a/lib/eal/include/generic/rte_rwlock.h
+++ b/lib/eal/include/generic/rte_rwlock.h
@@ -22,6 +22,8 @@
  *  https://locklessinc.com/articles/locks/
  */
 
+#include 
+
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -57,7 +59,7 @@
 #define RTE_RWLOCK_READ 0x4/* Reader increment */
 
 typedef struct __rte_lockable {
-   int32_t cnt;
+   int32_t _Atomic cnt;
 } rte_rwlock_t;
 
 /**
@@ -92,21 +94,21 @@
 
while (1) {
/* Wait while writer is present or pending */
-   while (__atomic_load_n(&rwl->cnt, __ATOMIC_RELAXED)
+   while (atomic_load_explicit(&rwl->cnt, memory_order_relaxed)
   & RTE_RWLOCK_MASK)
rte_pause();
 
/* Try to get read lock */
-   x = __atomic_fetch_add(&rwl->cnt, RTE_RWLOCK_READ,
-  __ATOMIC_ACQUIRE) + RTE_RWLOCK_READ;
+   x = atomic_fetch_add_explicit(&rwl->cnt, RTE_RWLOCK_READ,
+  memory_order_acquire) + RTE_RWLOCK_READ;
 
/* If no writer, then acquire was successful */
if (likely(!(x & RTE_RWLOCK_MASK)))
return;
 
/* Lost race with writer, backout the change. */
-   __atomic_fetch_sub(&rwl->cnt, RTE_RWLOCK_READ,
-  __ATOMIC_RELAXED);
+   atomic_fetch_sub_explicit(&rwl->cnt, RTE_RWLOCK_READ,
+  memory_order_relaxed);
}
 }
 
@@ -127,20 +129,20 @@
 {
int32_t x;
 
-   x = __atomic_load_n(&rwl->cnt, __ATOMIC_RELAXED);
+   x = atomic_load_explicit(&rwl->cnt, memory_order_relaxed);
 
/* fail if write lock is held or writer is pending */
if (x & RTE_RWLOCK_MASK)
return -EBUSY;
 
/* Try to get read lock */
-   x = __atomic_fetch_add(&rwl->cnt, RTE_RWLOCK_READ,
-  __ATOMIC_ACQUIRE) + RTE_RWLOCK_READ;
+   x = atomic_fetch_add_explicit(&rwl->cnt, RTE_RWLOCK_READ,
+  memory_order_acquire) + RTE_RWLOCK_READ;
 
/* Back out if writer raced in */
if (unlikely(x & RTE_RWLOCK_MASK)) {
-   __atomic_fetch_sub(&rwl->cnt, RTE_RWLOCK_READ,
-  __ATOMIC_RELEASE);
+   atomic_fetch_sub_explicit(&rwl->cnt, RTE_RWLOCK_READ,
+  memory_order_release);
 
return -EBUSY;
}
@@ -158,7 +160,7 @@
__rte_unlock_function(rwl)
__rte_no_thread_safety_analysis
 {
-   __atomic_fetch_sub(&rwl->cnt, RTE_RWLOCK_READ, __ATOMIC_RELEASE);
+   atomic_fetch_sub_explicit(&rwl->cnt, RTE_RWLOCK_READ, 
memory_order_release);
 }
 
 /**
@@ -178,10 +180,10 @@
 {
int32_t x;
 
-   x = __atomic_load_n(&rwl->cnt, __ATOMIC_RELAXED);
+   x = atomic_load_explicit(&rwl->cnt, memory_order_relaxed);
if (x < RTE_RWLOCK_WRITE &&
-   __atomic_compare_exchange_n(&rwl->cnt, &x, x + RTE_RWLOCK_WRITE,
-   1, __ATOMIC_ACQUIRE, __ATOMIC_RELAXED))
+   atomic_compare_exchange_weak_explicit(&rwl->cnt, &x, x + 
RTE_RWLOCK_WRITE,
+   memory_order_acquire, 
memory_order_relaxed))
return 0;
else
return -EBUSY;
@@ -201,22 +203,22 @@
int32_t x;
 
while (1) {
-   x = __atomic_load_n(&rwl->cnt, __ATOMIC_RELAXED);
+   x = atomic_load_explicit(&rwl->cnt, memory_order_relaxed);
 
/* No readers or writers? */
if (likely(x < RTE_RWLOCK_WRITE)) {
/* Turn off RTE_RWLOCK_WAIT, turn on RTE_RWLOCK_WRITE */
-   if (__atomic_compare_exchange_n(&rwl->cnt, &x, 
RTE_RWLOCK_WRITE, 1,
-   __ATOMIC_ACQUIRE, 
__ATOMIC_RELAXED))
+   if (atomic_compare_exchange_weak_explicit(&rwl->cnt, 
&x, RTE_RWLOCK_WRITE,
+   memory_order_acquire, 
memory_order_relaxed))
return;
}
 
/* Turn on writer wait bit */
if (!(x & RTE_RWLOCK_WAIT))
-   __atomic_fetch_or(&rwl->cnt, RTE_RWLOCK_WAIT, 
__ATOMIC_RELAXED);
+   

[PATCH v4 1/4] build: require minimum c11 compiler

[Tyler Retzlaff]

Update top level meson.build to require c_std=c11 and remove use of
-std=gnu99.

Signed-off-by: Tyler Retzlaff 
---
 drivers/net/failsafe/meson.build  | 1 -
 lib/eal/common/eal_common_errno.c | 1 +
 meson.build   | 1 +
 3 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/failsafe/meson.build b/drivers/net/failsafe/meson.build
index 6013e13..c1d3610 100644
--- a/drivers/net/failsafe/meson.build
+++ b/drivers/net/failsafe/meson.build
@@ -7,7 +7,6 @@ if is_windows
 subdir_done()
 endif
 
-cflags += '-std=gnu99'
 cflags += '-D_DEFAULT_SOURCE'
 cflags += '-D_XOPEN_SOURCE=700'
 cflags += '-pedantic'
diff --git a/lib/eal/common/eal_common_errno.c 
b/lib/eal/common/eal_common_errno.c
index ef8f782..d4e2c13 100644
--- a/lib/eal/common/eal_common_errno.c
+++ b/lib/eal/common/eal_common_errno.c
@@ -4,6 +4,7 @@
 
 /* Use XSI-compliant portable version of strerror_r() */
 #undef _GNU_SOURCE
+#define _POSIX_C_SOURCE 200112L
 
 #include 
 #include 
diff --git a/meson.build b/meson.build
index 39cb738..70b54f0 100644
--- a/meson.build
+++ b/meson.build
@@ -9,6 +9,7 @@ project('DPDK', 'c',
 license: 'BSD',
 default_options: [
 'buildtype=release',
+'c_std=c11',
 'default_library=static',
 'warning_level=2',
 ],
-- 
1.8.3.1

[PATCH v4 2/4] devtools: forbid use of GCC atomic builtins

[Tyler Retzlaff]

Refrain from using compiler __atomic_xxx builtins DPDK now uses standard
C11 atomics atomic_xxx.

Signed-off-by: Tyler Retzlaff 
Acked-by: Morten Brørup 
---
 devtools/checkpatches.sh | 8 
 1 file changed, 8 insertions(+)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 43f5e36..a32f02e 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -102,6 +102,14 @@ check_forbidden_additions() { # 
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
 
+   # refrain from using compiler __atomic_xxx builtins
+   awk -v FOLDERS="lib drivers app examples" \
+   -v EXPRESSIONS="__atomic_.*\\\(" \
+   -v RET_ON_FAIL=1 \
+   -v MESSAGE='Using __atomic_xxx builtins' \
+   -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+   "$1" || res=1
+
# refrain from using compiler __atomic_thread_fence()
# It should be avoided on x86 for SMP case.
awk -v FOLDERS="lib drivers app examples" \
-- 
1.8.3.1

[PATCH v4 0/4] eal: update public API to use stdatomic atomics

[Tyler Retzlaff]

Update EAL public API to use standard C11 atomics. In accordance with
technical board discussion February 2023.
http://mails.dpdk.org/archives/dev/2023-February/263516.html

This initial series makes no attempt to adapt every use of builtin atomics
from GCC it intends only to adapt the public API of the EAL presented as
a compatibility surface to applications.

Further series will be submitted to adapt the rest of DPDK to use standard
atomics that are 'internal' and not do not straddle the EAL API.

The choice has been made to break these two changes apart to allow more
precise analysis of any potential performance impact this change or
subsequent changes may introduce.

Additionally, it is not possible to break the commits up per driver/lib as
both the provider and consumer of the APIs need to be changed in the same
commit to maintain non-broken build and function.

Finally, the first patch in this series is a duplication of Bruce Richardson
series https://patchwork.dpdk.org/project/dpdk/list/?series=29048 and is
only being provided to enable the CI run on this series. It is expected that
Bruce's series when committed will allow the build: require minimum c11 compiler
here to be dropped from this series.

v4:
  * fix previous cut & paste mistake including rte_pause.h when rte_atomic.h
was intended in loongarch, ppc, riscv rte_pause.h (sorry was tired)

v3:
  * restore incorrectly dropped architecture specific #include "rte_pause.h"
for loongarch, ppc, riscv
  * convert parameters to stdatomic in RTE_WAIT_UNTIL_MASKED macro usage
(missed previously)
  * lib/ring missed some conversion to stdatomic on struct rte_ring _Atomic
fields (picked up by clang which is more strict than gcc)
  * drivers/mlx5 use stdatomic operations on struct rte_ring _Atomic fields
(picked up by clang which is more strict than gcc)

v2:
  * remove volatile qualification from variables, structure fields and
parameters that have been qualified _Atomic
  * restore removal of #include  in rte_ring_core.h the ring
library still uses other rte_atomic APIs and types that are not replaced
by the standard or compiler intrinsics
  * add missing adaption to stdatomic in ring/rte_ring_c11_pvt.h

Tyler Retzlaff (4):
  build: require minimum c11 compiler
  devtools: forbid use of GCC atomic builtins
  eal: adapt rte pause APIs to use C11 atomics
  eal: adapt rte spinlock and rwlock APIs to use C11 atomics

 app/test-bbdev/test_bbdev_perf.c | 123 ---
 app/test/test_func_reentrancy.c  |   8 +-
 app/test/test_mcslock.c  |  12 +--
 app/test/test_mempool_perf.c |   8 +-
 app/test/test_pflock.c   |  12 +--
 app/test/test_pmd_perf.c |  10 +--
 app/test/test_ring_perf.c|   8 +-
 app/test/test_rwlock.c   |   8 +-
 app/test/test_spinlock.c |   8 +-
 app/test/test_stack_perf.c   |  12 +--
 app/test/test_ticketlock.c   |   8 +-
 app/test/test_timer.c|  16 ++--
 devtools/checkpatches.sh |   8 ++
 drivers/event/opdl/opdl_ring.c   |  47 ++--
 drivers/net/failsafe/meson.build |   1 -
 drivers/net/mlx5/mlx5_hws_cnt.h  |   4 +-
 drivers/net/thunderx/nicvf_rxtx.c|   5 +-
 drivers/net/thunderx/nicvf_struct.h  |   2 +-
 lib/bpf/bpf_pkt.c|   6 +-
 lib/distributor/distributor_private.h|   2 +-
 lib/distributor/rte_distributor_single.c |  44 +--
 lib/eal/arm/include/rte_pause_64.h   |  28 +++
 lib/eal/common/eal_common_errno.c|   1 +
 lib/eal/common/eal_memcfg.h  |   2 +-
 lib/eal/include/generic/rte_pause.h  |  51 ++---
 lib/eal/include/generic/rte_rwlock.h |  46 ++--
 lib/eal/include/generic/rte_spinlock.h   |  21 +++---
 lib/eal/include/rte_mcslock.h|  14 ++--
 lib/eal/include/rte_pflock.h |  22 +++---
 lib/eal/include/rte_ticketlock.h |   8 +-
 lib/eal/x86/include/rte_spinlock.h   |   2 +-
 lib/ring/rte_ring_c11_pvt.h  |  42 ++-
 lib/ring/rte_ring_core.h |   4 +-
 lib/ring/rte_ring_generic_pvt.h  |  19 +++--
 lib/ring/rte_ring_peek_elem_pvt.h|   2 +-
 meson.build  |   1 +
 36 files changed, 337 insertions(+), 278 deletions(-)

-- 
1.8.3.1