Re: baseband PMD APIs

[Thomas Monjalon]

To bbdev maintainers,

Do you think we can avoid having some PMD-specific configuration?
It looks blocking migration from a driver to another.
How do we manage that?


13/10/2022 11:07, Akhil Goyal:
> There are 6 bbdev PMDs, out of which 3 have pmd APIs - all from Intel
> These are the PMD APIs for baseband drivers.
> rte_acc_configure -> this is being used by 2 drivers(acc100 and acc200) 
> merged in a single folder.
> rte_fpga_5gnr_fec_configure
> rte_fpga_lte_fec_configure
> 
> The fpga ones have almost same syntax.

[PATCH v5 0/2] vhost: introduce DMA vchannel unconfiguration

[xuan . ding]

From: Xuan Ding 

This patchset introduces a new API rte_vhost_async_dma_unconfigure()
to help user to manually free DMA vchannels finished to use.

Note: this API should be called after async channel unregister.

v5:
* Use mutex instead of spinlock.
* Improve code readability.

v4:
* Rebase to 22.11 rc1.
* Fix the usage of 'dma_ref_count' to make sure the specified DMA device
  is not used by any vhost ports before unconfiguration.

v3:
* Rebase to latest DPDK.
* Refine some descriptions in the doc.
* Fix one bug in the vhost example.

v2:
* Add spinlock protection.
* Fix a memory leak issue.
* Refine the doc.

Xuan Ding (2):
  vhost: introduce DMA vchannel unconfiguration
  examples/vhost: unconfigure DMA vchannel

 doc/guides/prog_guide/vhost_lib.rst|  6 +++
 doc/guides/rel_notes/release_22_11.rst |  4 ++
 examples/vhost/main.c  | 40 ++-
 lib/vhost/rte_vhost_async.h| 18 +++
 lib/vhost/version.map  |  3 ++
 lib/vhost/vhost.c  | 69 --
 6 files changed, 122 insertions(+), 18 deletions(-)

-- 
2.17.1

[PATCH v5 1/2] vhost: introduce DMA vchannel unconfiguration

[xuan . ding]

From: Xuan Ding 

Add a new API rte_vhost_async_dma_unconfigure() to unconfigure DMA
vchannels in vhost async data path. Lock protection are also added
to protect DMA vchannels configuration and unconfiguration
from concurrent calls.

Signed-off-by: Xuan Ding 
---
 doc/guides/prog_guide/vhost_lib.rst|  6 +++
 doc/guides/rel_notes/release_22_11.rst |  4 ++
 lib/vhost/rte_vhost_async.h| 18 +++
 lib/vhost/version.map  |  3 ++
 lib/vhost/vhost.c  | 69 --
 5 files changed, 95 insertions(+), 5 deletions(-)

diff --git a/doc/guides/prog_guide/vhost_lib.rst 
b/doc/guides/prog_guide/vhost_lib.rst
index bad4d819e1..d3cef978d0 100644
--- a/doc/guides/prog_guide/vhost_lib.rst
+++ b/doc/guides/prog_guide/vhost_lib.rst
@@ -323,6 +323,12 @@ The following is an overview of some key Vhost API 
functions:
   Get device type of vDPA device, such as VDPA_DEVICE_TYPE_NET,
   VDPA_DEVICE_TYPE_BLK.
 
+* ``rte_vhost_async_dma_unconfigure(dma_id, vchan_id)``
+
+  Clean DMA vChannels finished to use. This function needs to
+  be called after the deregistration of async DMA vchannel
+  has been finished.
+
 Vhost-user Implementations
 --
 
diff --git a/doc/guides/rel_notes/release_22_11.rst 
b/doc/guides/rel_notes/release_22_11.rst
index 2da8bc9661..3be150122c 100644
--- a/doc/guides/rel_notes/release_22_11.rst
+++ b/doc/guides/rel_notes/release_22_11.rst
@@ -236,6 +236,10 @@ New Features
 
  strings $dpdk_binary_or_driver | sed -n 's/^PMD_INFO_STRING= //p'
 
+* **Added DMA vChannel unconfiguration for async vhost.**
+
+  * Added support to unconfigure DMA vChannels that have been unregistered.
+
 
 Removed Items
 -
diff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h
index 1db2a10124..6ee4f7258d 100644
--- a/lib/vhost/rte_vhost_async.h
+++ b/lib/vhost/rte_vhost_async.h
@@ -266,6 +266,24 @@ rte_vhost_async_try_dequeue_burst(int vid, uint16_t 
queue_id,
struct rte_mempool *mbuf_pool, struct rte_mbuf **pkts, uint16_t count,
int *nr_inflight, int16_t dma_id, uint16_t vchan_id);
 
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change, or be removed, without prior notice.
+ *
+ * Unconfigure DMA vChannels in asynchronous data path.
+ * This function should be called after the DMA vChannel has been unregistered.
+ *
+ * @param dma_id
+ *  the identifier of DMA device
+ * @param vchan_id
+ *  the identifier of virtual DMA channel
+ * @return
+ *  0 on success, and -1 on failure
+ */
+__rte_experimental
+int
+rte_vhost_async_dma_unconfigure(int16_t dma_id, uint16_t vchan_id);
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/lib/vhost/version.map b/lib/vhost/version.map
index 7a00b65740..0b61870870 100644
--- a/lib/vhost/version.map
+++ b/lib/vhost/version.map
@@ -94,6 +94,9 @@ EXPERIMENTAL {
rte_vhost_async_try_dequeue_burst;
rte_vhost_driver_get_vdpa_dev_type;
rte_vhost_clear_queue;
+
+   # added in 22.11
+   rte_vhost_async_dma_unconfigure;
 };
 
 INTERNAL {
diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
index 8740aa2788..975c0d3297 100644
--- a/lib/vhost/vhost.c
+++ b/lib/vhost/vhost.c
@@ -23,6 +23,7 @@
 
 struct virtio_net *vhost_devices[RTE_MAX_VHOST_DEVICE];
 pthread_mutex_t vhost_dev_lock = PTHREAD_MUTEX_INITIALIZER;
+pthread_mutex_t vhost_dma_lock = PTHREAD_MUTEX_INITIALIZER;
 
 struct vhost_vq_stats_name_off {
char name[RTE_VHOST_STATS_NAME_SIZE];
@@ -1844,19 +1845,20 @@ rte_vhost_async_dma_configure(int16_t dma_id, uint16_t 
vchan_id)
void *pkts_cmpl_flag_addr;
uint16_t max_desc;
 
+   pthread_mutex_lock(&vhost_dma_lock);
if (!rte_dma_is_valid(dma_id)) {
VHOST_LOG_CONFIG("dma", ERR, "DMA %d is not found.\n", dma_id);
-   return -1;
+   goto error;
}
 
if (rte_dma_info_get(dma_id, &info) != 0) {
VHOST_LOG_CONFIG("dma", ERR, "Fail to get DMA %d 
information.\n", dma_id);
-   return -1;
+   goto error;
}
 
if (vchan_id >= info.max_vchans) {
VHOST_LOG_CONFIG("dma", ERR, "Invalid DMA %d vChannel %u.\n", 
dma_id, vchan_id);
-   return -1;
+   goto error;
}
 
if (!dma_copy_track[dma_id].vchans) {
@@ -1868,7 +1870,7 @@ rte_vhost_async_dma_configure(int16_t dma_id, uint16_t 
vchan_id)
VHOST_LOG_CONFIG("dma", ERR,
"Failed to allocate vchans for DMA %d vChannel 
%u.\n",
dma_id, vchan_id);
-   return -1;
+   goto error;
}
 
dma_copy_track[dma_id].vchans = vchans;
@@ -1877,6 +1879,7 @@ rte_vhost_async_dma_configure(int16_t dma_id, uint16_t 
vchan_id)
if (dma_copy_track[dma_id].vchans[vchan_id].pkts_cmpl_flag_addr) {
VHOST_LOG_CONFIG("dma", INFO, "DMA %d vChannel %u already 

[PATCH v5 2/2] examples/vhost: unconfigure DMA vchannel

[xuan . ding]

From: Xuan Ding 

This patch applies rte_vhost_async_dma_unconfigure() to manually free
DMA vchannels. Before unconfiguration, make sure the specified DMA
device is no longer used by any vhost ports.

Signed-off-by: Xuan Ding 
---
 examples/vhost/main.c | 40 +++-
 1 file changed, 27 insertions(+), 13 deletions(-)

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index ac78704d79..baf7d49116 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -73,6 +73,7 @@ static int total_num_mbufs = NUM_MBUFS_DEFAULT;
 
 struct dma_for_vhost dma_bind[RTE_MAX_VHOST_DEVICE];
 int16_t dmas_id[RTE_DMADEV_DEFAULT_MAX];
+int16_t dma_ref_count[RTE_DMADEV_DEFAULT_MAX];
 static int dma_count;
 
 /* mask of enabled ports */
@@ -371,6 +372,7 @@ open_dma(const char *value)
 done:
(dma_info + socketid)->dmas[vring_id].dev_id = dev_id;
(dma_info + socketid)->async_flag |= async_flag;
+   dma_ref_count[dev_id]++;
i++;
}
 out:
@@ -1562,6 +1564,29 @@ vhost_clear_queue(struct vhost_dev *vdev, uint16_t 
queue_id)
}
 }
 
+static void
+vhost_clear_async(struct vhost_dev *vdev, int vid, uint16_t queue_id)
+{
+   int16_t dma_id;
+
+   if (!dma_bind[vid].dmas[queue_id].async_enabled)
+   return;
+
+   vhost_clear_queue(vdev, queue_id);
+   rte_vhost_async_channel_unregister(vid, queue_id);
+   dma_bind[vid].dmas[queue_id].async_enabled = false;
+
+   dma_id = dma_bind[vid2socketid[vdev->vid]].dmas[queue_id].dev_id;
+   dma_ref_count[dma_id]--;
+
+   if (dma_ref_count[dma_id] > 0)
+   return;
+
+   if (rte_vhost_async_dma_unconfigure(dma_id, 0) < 0)
+   RTE_LOG(ERR, VHOST_CONFIG,
+   "Failed to unconfigure DMA %d in vhost.\n", dma_id);
+}
+
 /*
  * Remove a device from the specific data core linked list and from the
  * main linked list. Synchronization  occurs through the use of the
@@ -1618,17 +1643,8 @@ destroy_device(int vid)
"(%d) device has been removed from data core\n",
vdev->vid);
 
-   if (dma_bind[vid].dmas[VIRTIO_RXQ].async_enabled) {
-   vhost_clear_queue(vdev, VIRTIO_RXQ);
-   rte_vhost_async_channel_unregister(vid, VIRTIO_RXQ);
-   dma_bind[vid].dmas[VIRTIO_RXQ].async_enabled = false;
-   }
-
-   if (dma_bind[vid].dmas[VIRTIO_TXQ].async_enabled) {
-   vhost_clear_queue(vdev, VIRTIO_TXQ);
-   rte_vhost_async_channel_unregister(vid, VIRTIO_TXQ);
-   dma_bind[vid].dmas[VIRTIO_TXQ].async_enabled = false;
-   }
+   vhost_clear_async(vdev, vid, VIRTIO_RXQ);
+   vhost_clear_async(vdev, vid, VIRTIO_TXQ);
 
rte_free(vdev);
 }
@@ -1690,8 +1706,6 @@ vhost_async_channel_register(int vid)
return rx_ret | tx_ret;
 }
 
-
-
 /*
  * A new device is added to a data core. First the device is added to the main 
linked list
  * and then allocated to a specific data core.
-- 
2.17.1

RE: [PATCH] eventdev: increase xstats ID width to 64 bits

[Morten Brørup]

> From: pbhagavat...@marvell.com [mailto:pbhagavat...@marvell.com]
> Sent: Thursday, 13 October 2022 11.24
> 
> From: Pavan Nikhilesh 
> 
> Increase xstats ID width to 64bits from 32 bits, this also
> fixes the xstats ID datatype discrepancy between reset and
> rest of the xstats family.
> 
> Signed-off-by: Pavan Nikhilesh 
> ---

Acked-by: Morten Brørup 

[PATCH] net/mlx5: fix thread workspace memory leak

[Dong Zhou]

The thread workspace push/pop should be paired. In the "flow_list_create"
routine, if error happened the workspace pop was missed. This patch shares
the workspace pop for all return paths.

Fixes: 0064bf431899 ("net/mlx5: fix nested flow creation")
Cc: xuemi...@nvidia.com
Cc: sta...@dpdk.org

Signed-off-by: Dong Zhou 
Acked-by: Viacheslav Ovsiienko 
---
 drivers/net/mlx5/mlx5_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index e4744b0..6fb1d53 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -7028,8 +7028,8 @@ struct mlx5_list_entry *
rte_errno = ret; /* Restore rte_errno. */
ret = rte_errno;
rte_errno = ret;
-   mlx5_flow_pop_thread_workspace();
 error_before_hairpin_split:
+   mlx5_flow_pop_thread_workspace();
rte_free(translated_actions);
return 0;
 }
-- 
1.8.3.1

RE: [PATCH v2 0/4] crypto/ccp cleanup

[Akhil Goyal]

Hi Sunil

> For this series
> 
> Below shared patches seems fine, verified on AMD platform works fine.
> 
> crypto/ccp: fix IOVA handling
> crypto/ccp: remove some dead code for UIO
> crypto/ccp: remove some printf
> 
> Now working on the "crypto/ccp: fix PCI probing" patch and will update on 
> this.
> 
Any update on this?
Please provide your ack if no comments.

RE: [PATCH v2 2/2] vhost: fix slot index calculation in async vhost

[Ling, WeiX]

> -Original Message-
> From: Cheng Jiang 
> Sent: Tuesday, October 11, 2022 11:08 AM
> To: maxime.coque...@redhat.com; Xia, Chenbo 
> Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan
> ; Ma, WenwuX ; Wang,
> YuanX ; Yang, YvonneX
> ; He, Xingguang ;
> Jiang, Cheng1 ; sta...@dpdk.org
> Subject: [PATCH v2 2/2] vhost: fix slot index calculation in async vhost
> 
> When the packet receiving failure and the DMA ring full occur simultaneously
> in the asynchronous vhost, the slot_idx needs to be decreased by 1. For
> packed virtqueue, the slot index should be ring_size - 1, if the slot_idx is
> currently 0, since the ring size is not necessarily the power of 2.
> 
> Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring")
> Fixes: fe8477ebbd94 ("vhost: support async packed ring dequeue")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Cheng Jiang 
> ---
Tested-by: Wei Ling 

[v1] examples/fips_validation: remove unused include file

[Gowrishankar Muthukrishnan]

Remove invoking include for sys/random.h which is not actually used
by app.

Signed-off-by: Gowrishankar Muthukrishnan 
---
 examples/fips_validation/fips_validation_rsa.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/examples/fips_validation/fips_validation_rsa.c 
b/examples/fips_validation/fips_validation_rsa.c
index 43ff2a0634..f675b51051 100644
--- a/examples/fips_validation/fips_validation_rsa.c
+++ b/examples/fips_validation/fips_validation_rsa.c
@@ -5,7 +5,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 
-- 
2.25.1

Re: 回复: 回复: [PATCH v2 1/3] ethdev: add API for direct rearm mode

[Konstantin Ananyev]

12/10/2022 14:38, Feifei Wang пишет:




-邮件原件-
发件人: Konstantin Ananyev 
发送时间: Wednesday, October 12, 2022 6:21 AM
收件人: Feifei Wang ; tho...@monjalon.net;
Ferruh Yigit ; Andrew Rybchenko
; Ray Kinsella 
抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli
; Ruifeng Wang

主题: Re: 回复: [PATCH v2 1/3] ethdev: add API for direct rearm mode




Add API for enabling direct rearm mode and for mapping RX and TX
queues. Currently, the API supports 1:1(txq : rxq) mapping.

Furthermore, to avoid Rx load Tx data directly, add API called
'rte_eth_txq_data_get' to get Tx sw_ring and its information.

Suggested-by: Honnappa Nagarahalli 
Suggested-by: Ruifeng Wang 
Signed-off-by: Feifei Wang 
Reviewed-by: Ruifeng Wang 
Reviewed-by: Honnappa Nagarahalli 
---
lib/ethdev/ethdev_driver.h   |  9 
lib/ethdev/ethdev_private.c  |  1 +
lib/ethdev/rte_ethdev.c  | 37 ++
lib/ethdev/rte_ethdev.h  | 95



lib/ethdev/rte_ethdev_core.h |  5 ++
lib/ethdev/version.map   |  4 ++
6 files changed, 151 insertions(+)

diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h
index 47a55a419e..14f52907c1 100644
--- a/lib/ethdev/ethdev_driver.h
+++ b/lib/ethdev/ethdev_driver.h
@@ -58,6 +58,8 @@ struct rte_eth_dev {
eth_rx_descriptor_status_t rx_descriptor_status;
/** Check the status of a Tx descriptor */
eth_tx_descriptor_status_t tx_descriptor_status;
+   /**  Use Tx mbufs for Rx to rearm */
+   eth_rx_direct_rearm_t rx_direct_rearm;

/**
 * Device data that is shared between primary and secondary
processes @@ -486,6 +488,11 @@ typedef int

(*eth_rx_enable_intr_t)(struct rte_eth_dev *dev,

typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev,
uint16_t rx_queue_id);

+/**< @internal Get Tx information of a transmit queue of an
+Ethernet device. */ typedef void (*eth_txq_data_get_t)(struct

rte_eth_dev *dev,

+ uint16_t tx_queue_id,
+ struct rte_eth_txq_data *txq_data);
+
/** @internal Release memory resources allocated by given Rx/Tx

queue.

*/

typedef void (*eth_queue_release_t)(struct rte_eth_dev *dev,
uint16_t queue_id);
@@ -1138,6 +1145,8 @@ struct eth_dev_ops {
eth_rxq_info_get_t rxq_info_get;
/** Retrieve Tx queue information */
eth_txq_info_get_t txq_info_get;
+   /** Get the address where Tx data is stored */
+   eth_txq_data_get_t txq_data_get;
eth_burst_mode_get_t   rx_burst_mode_get; /**< Get Rx burst

mode */

eth_burst_mode_get_t   tx_burst_mode_get; /**< Get Tx burst

mode */

eth_fw_version_get_t   fw_version_get; /**< Get firmware

version */

diff --git a/lib/ethdev/ethdev_private.c
b/lib/ethdev/ethdev_private.c index 48090c879a..bfe16c7d77 100644
--- a/lib/ethdev/ethdev_private.c
+++ b/lib/ethdev/ethdev_private.c
@@ -276,6 +276,7 @@ eth_dev_fp_ops_setup(struct rte_eth_fp_ops

*fpo,

fpo->rx_queue_count = dev->rx_queue_count;
fpo->rx_descriptor_status = dev->rx_descriptor_status;
fpo->tx_descriptor_status = dev->tx_descriptor_status;
+   fpo->rx_direct_rearm = dev->rx_direct_rearm;

fpo->rxq.data = dev->data->rx_queues;
fpo->rxq.clbk = (void **)(uintptr_t)dev->post_rx_burst_cbs;
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index
0c2c1088c0..0dccec2e4b 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -1648,6 +1648,43 @@ rte_eth_dev_is_removed(uint16_t port_id)
return ret;
}

+int
+rte_eth_tx_queue_data_get(uint16_t port_id, uint16_t queue_id,
+   struct rte_eth_txq_data *txq_data) {
+   struct rte_eth_dev *dev;
+
+   RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+   dev = &rte_eth_devices[port_id];
+
+   if (queue_id >= dev->data->nb_tx_queues) {
+   RTE_ETHDEV_LOG(ERR, "Invalid Tx queue_id=%u\n",

queue_id);

+   return -EINVAL;
+   }
+
+   if (txq_data == NULL) {
+   RTE_ETHDEV_LOG(ERR, "Cannot get ethdev port %u Tx

queue %u data to NULL\n",

+   port_id, queue_id);
+   return -EINVAL;
+   }
+
+   if (dev->data->tx_queues == NULL ||
+   dev->data->tx_queues[queue_id] == NULL) {
+   RTE_ETHDEV_LOG(ERR,
+  "Tx queue %"PRIu16" of device with port_id=%"
+  PRIu16" has not been setup\n",
+  queue_id, port_id);
+   return -EINVAL;
+   }
+
+   if (*dev->dev_ops->txq_data_get == NULL)
+   return -ENOTSUP;
+
+   dev->dev_ops->txq_data_get(dev, queue_id, txq_data);
+
+   return 0;
+}
+
static int
rte_eth_rx_queue_check_split(const struct rte_eth_rxseg_split

*rx_seg,

   

Re: [PATCH 2/4] eventdev: have ethernet Rx adapter appropriately report idle

[Mattias Rönnblom]

On 2022-10-13 03:32, Naga Harish K, S V wrote:
> 
> 
>> -Original Message-
>> From: Jayatheerthan, Jay 
>> Sent: Tuesday, October 11, 2022 12:40 PM
>> To: mattias.ronnblom ; Carrillo, Erik G
>> ; Gujjar, Abhinandan S
>> ; Jerin Jacob ; Naga
>> Harish K, S V 
>> Cc: dev@dpdk.org; Van Haaren, Harry ;
>> hof...@lysator.liu.se; mattias.ronnblom 
>> Subject: RE: [PATCH 2/4] eventdev: have ethernet Rx adapter appropriately
>> report idle
>>
>> @Harish, Could you review the patch ?
>>
>> -Jay
>>
>>> -Original Message-
>>> From: Mattias Rönnblom 
>>> Sent: Monday, October 10, 2022 8:24 PM
>>> To: Jayatheerthan, Jay ; Carrillo, Erik G
>>> ; Gujjar, Abhinandan S
>>> ; Jerin Jacob 
>>> Cc: dev@dpdk.org; Van Haaren, Harry ;
>>> hof...@lysator.liu.se; mattias.ronnblom
>>> 
>>> Subject: [PATCH 2/4] eventdev: have ethernet Rx adapter appropriately
>>> report idle
>>>
>>> Update the Event Ethernet Rx Adapter's service function to report as
>>> idle (i.e., return -EAGAIN) in case no Ethernet frames were received
>>> from the ethdev and no events were enqueued to the event device.
>>>
>>> Signed-off-by: Mattias Rönnblom 
>>> ---
>>>   lib/eventdev/rte_event_eth_rx_adapter.c | 56
>>> ++---
>>>   1 file changed, 41 insertions(+), 15 deletions(-)
>>>
>>> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
>>> b/lib/eventdev/rte_event_eth_rx_adapter.c
>>> index 5c3021a184..cf7bbd4d69 100644
>>> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
>>> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
>>> @@ -1184,7 +1184,7 @@ rxa_intr_thread(void *arg)
>>>   /* Dequeue  from interrupt ring and enqueue received
>>>* mbufs to eventdev
>>>*/
>>> -static inline void
>>> +static inline bool
>>>   rxa_intr_ring_dequeue(struct event_eth_rx_adapter *rx_adapter)  {
>>> uint32_t n;
>>> @@ -1194,20 +1194,27 @@ rxa_intr_ring_dequeue(struct
>> event_eth_rx_adapter *rx_adapter)
>>> struct rte_event_eth_rx_adapter_stats *stats;
>>> rte_spinlock_t *ring_lock;
>>> uint8_t max_done = 0;
>>> +   bool work = false;
>>>
>>> if (rx_adapter->num_rx_intr == 0)
>>> -   return;
>>> +   return work;
>>>
>>> if (rte_ring_count(rx_adapter->intr_ring) == 0
>>> && !rx_adapter->qd_valid)
>>> -   return;
>>> +   return work;
>>>
>>> buf = &rx_adapter->event_enqueue_buffer;
>>> stats = &rx_adapter->stats;
>>> ring_lock = &rx_adapter->intr_ring_lock;
>>>
>>> -   if (buf->count >= BATCH_SIZE)
>>> -   rxa_flush_event_buffer(rx_adapter, buf, stats);
>>> +   if (buf->count >= BATCH_SIZE) {
>>> +   uint16_t n;
>>> +
>>> +   n = rxa_flush_event_buffer(rx_adapter, buf, stats);
>>> +
>>> +   if (likely(n > 0))
>>> +   work = true;
>>> +   }
>>>
>>> while (rxa_pkt_buf_available(buf)) {
>>> struct eth_device_info *dev_info;
>>> @@ -1289,7 +1296,12 @@ rxa_intr_ring_dequeue(struct
>> event_eth_rx_adapter *rx_adapter)
>>> }
>>>
>>>   done:
>>> -   rx_adapter->stats.rx_intr_packets += nb_rx;
>>> +   if (nb_rx > 0) {
> 
> How are the performance numbers before and after this patch?
> Trying to understand the performance impact, as new condition is added to the 
> service function Datapath.
> 
I haven't tested the RX and TX adapters separately, but if you run them 
on the same core, I get the following result:

Without patches, with stats disabled: 16,0 Mpps
Without patches, with stats enabled: 16,1 Mpps
With patches, with stats disabled: 16,1 Mpps
With patches, with stats enabled: 16,2 Mpps

So these patches, with this particular hardware, compiler, and test 
application, adding a tiny bit of additional logic actually make the 
RX+TX adapter perform better. This is contrary to what you might expect, 
and I'm sure YMMV.

Enabling service core statistics (which boils down to a 2x rdtsc and 
some cheap arithmetic in rte_service.c) actually make the RX+TX adapter 
core perform better, both before and after this patchset. Also contrary 
to what you might expect.

The results are consistent across multiple runs.

GCC 11.2.0 and AMD Zen 3 @ 3,7 GHz. Event device is DSW and I/O is the 
ring Ethdev.

>>> +   rx_adapter->stats.rx_intr_packets += nb_rx;
>>> +   work = true;
>>> +   }
>>> +
>>> +   return work;
>>>   }
>>>
>>>   /*
>>> @@ -1305,7 +1317,7 @@ rxa_intr_ring_dequeue(struct
>> event_eth_rx_adapter *rx_adapter)
>>>* the hypervisor's switching layer where adjustments can be made to deal
>> with
>>>* it.
>>>*/
>>> -static inline void
>>> +static inline bool
>>>   rxa_poll(struct event_eth_rx_adapter *rx_adapter)  {
>>> uint32_t num_queue;
>>> @@ -1314,6 +1326,7 @@ rxa_poll(struct event_eth_rx_adapter
>> *rx_adapter)
>>> struct rte_event_eth_rx_adapter_stats *stats = NULL;
>>> uint32_t wrr_pos;
>>> uint32_t max_nb_rx;
>>> +   bool work = false;
>>>
>>> wrr_pos = rx_adapter->wrr_pos;
>>> max_nb_rx = rx_adapter->max_nb_rx;
>>> @@ -1329,14 +1342,20 @@ rxa

unsubscribe

[Benjamin Demartin]

Hello I would like to unsubscribe but I don’t know how

Re: [PATCH] eventdev: increase xstats ID width to 64 bits

[Mattias Rönnblom]

On 2022-10-13 11:23, pbhagavat...@marvell.com wrote:
> From: Pavan Nikhilesh 
> 
> Increase xstats ID width to 64bits from 32 bits, this also

"Increase xstats ID width from 32 to 64 bits. This /../"

Not that "unsigned int" is always 32, but anyways, I guess that's true 
for all platforms DPDK supports.

> fixes the xstats ID datatype discrepancy between reset and
> rest of the xstats family.
> 
> Signed-off-by: Pavan Nikhilesh 
> ---
>   doc/guides/rel_notes/release_22_11.rst   |   5 ++
>   drivers/event/cnxk/cnxk_eventdev.h   |   6 +-
>   drivers/event/cnxk/cnxk_eventdev_stats.c |   6 +-
>   drivers/event/dlb2/dlb2_priv.h   |   8 +-
>   drivers/event/dlb2/dlb2_xstats.c |  18 ++--
>   drivers/event/dsw/dsw_evdev.h|   6 +-
>   drivers/event/dsw/dsw_xstats.c   |  32 +++
>   drivers/event/opdl/opdl_evdev.h  |   8 +-
>   drivers/event/opdl/opdl_evdev_xstats.c   |   8 +-
>   drivers/event/opdl/opdl_test.c   |   4 +-
>   drivers/event/sw/sw_evdev.h  |   8 +-
>   drivers/event/sw/sw_evdev_selftest.c | 101 +++
>   drivers/event/sw/sw_evdev_xstats.c   |  18 ++--
>   lib/eventdev/eventdev_pmd.h  |   8 +-
>   lib/eventdev/rte_eventdev.c  |  12 +--
>   lib/eventdev/rte_eventdev.h  |   8 +-
>   16 files changed, 128 insertions(+), 128 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_22_11.rst 
> b/doc/guides/rel_notes/release_22_11.rst
> index 2da8bc9661..6b76ad5566 100644
> --- a/doc/guides/rel_notes/release_22_11.rst
> +++ b/doc/guides/rel_notes/release_22_11.rst
> @@ -454,6 +454,11 @@ API Changes
>   
>   * raw/ifgpa: The function ``rte_pmd_ifpga_get_pci_bus`` has been removed.
>   
> +* eventdev: The datatype of the ID parameter in the functions
> +  ``rte_event_dev_xstats_names_get``, ``rte_event_dev_xstats_get``,
> +  ``rte_event_dev_xstats_by_name_get`` and ``rte_event_dev_xstats_reset``
> +  is changed to ``uint64_t`` from ``unsigned int`` and ``uint32_t``.
> +
>   
>   ABI Changes
>   ---
> diff --git a/drivers/event/cnxk/cnxk_eventdev.h 
> b/drivers/event/cnxk/cnxk_eventdev.h
> index f68c2aee23..738e335ea4 100644
> --- a/drivers/event/cnxk/cnxk_eventdev.h
> +++ b/drivers/event/cnxk/cnxk_eventdev.h
> @@ -271,14 +271,14 @@ int cnxk_sso_xstats_get_names(const struct rte_eventdev 
> *event_dev,
> enum rte_event_dev_xstats_mode mode,
> uint8_t queue_port_id,
> struct rte_event_dev_xstats_name *xstats_names,
> -   unsigned int *ids, unsigned int size);
> +   uint64_t *ids, unsigned int size);
>   int cnxk_sso_xstats_get(const struct rte_eventdev *event_dev,
>   enum rte_event_dev_xstats_mode mode,
> - uint8_t queue_port_id, const unsigned int ids[],
> + uint8_t queue_port_id, const uint64_t ids[],
>   uint64_t values[], unsigned int n);
>   int cnxk_sso_xstats_reset(struct rte_eventdev *event_dev,
> enum rte_event_dev_xstats_mode mode,
> -   int16_t queue_port_id, const uint32_t ids[],
> +   int16_t queue_port_id, const uint64_t ids[],
> uint32_t n);
>   
>   /* CN9K */
> diff --git a/drivers/event/cnxk/cnxk_eventdev_stats.c 
> b/drivers/event/cnxk/cnxk_eventdev_stats.c
> index a3b548f462..715ca9cd8f 100644
> --- a/drivers/event/cnxk/cnxk_eventdev_stats.c
> +++ b/drivers/event/cnxk/cnxk_eventdev_stats.c
> @@ -103,7 +103,7 @@ static struct cnxk_sso_xstats_name sso_hwgrp_xstats[] = {
>   int
>   cnxk_sso_xstats_get(const struct rte_eventdev *event_dev,
>   enum rte_event_dev_xstats_mode mode, uint8_t queue_port_id,
> - const unsigned int ids[], uint64_t values[], unsigned int n)
> + const uint64_t ids[], uint64_t values[], unsigned int n)
>   {
>   struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev);
>   struct roc_sso_hwgrp_stats hwgrp_stats;
> @@ -170,7 +170,7 @@ cnxk_sso_xstats_get(const struct rte_eventdev *event_dev,
>   int
>   cnxk_sso_xstats_reset(struct rte_eventdev *event_dev,
> enum rte_event_dev_xstats_mode mode,
> -   int16_t queue_port_id, const uint32_t ids[], uint32_t n)
> +   int16_t queue_port_id, const uint64_t ids[], uint32_t n)
>   {
>   struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev);
>   struct roc_sso_hwgrp_stats hwgrp_stats;
> @@ -235,7 +235,7 @@ cnxk_sso_xstats_get_names(const struct rte_eventdev 
> *event_dev,
> enum rte_event_dev_xstats_mode mode,
> uint8_t queue_port_id,
> struct rte_event_dev_xstats_name *xstats_names,
> -   unsigned int *ids, unsigned int size)
> +   uint64_t *ids, unsigned int size

[PATCH] gro : fix reordering of packets in GRO library

[Kumara Parameshwaran]

From: Kumara Parameshwaran 

When a TCP packet contains flags like PSH it is returned
immediately to the application though there might be packets of
the same flow in the GRO table. If PSH flag is set on a segment
packets upto the segment should be delivered immediately. But the
current implementation delivers the last arrived packet with PSH flag
set causing re-ordering

With this patch, if a packet does not contain only ACK flag and if there are
no previous packets for the flow the packet would be returned
immediately, else will be merged with the previous segment and the
flag on the last segment will be set on the entire segment.
This is the behaviour with linux stack as well

Signed-off-by: Kumara Parameshwaran 
---
v1:
If the received packet is not a pure ACK packet, we check if
there are any previous packets in the flow, if present we indulge
the received packet also in the coalescing logic and update the flags
of the last recived packet to the entire segment which would avoid
re-ordering.

Lets say a case where P1(PSH), P2(ACK), P3(ACK)  are received in burst mode,
P1 contains PSH flag and since it does not contain any prior packets in the 
flow
we copy it to unprocess_packets and P2(ACK) and P3(ACK) are merged together.
In the existing case the  P2,P3 would be delivered as single segment first 
and the
unprocess_packets will be copied later which will cause reordering. With 
the patch
copy the unprocess packets first and then the packets from the GRO table.

Testing done
The csum test-pmd was modifited to support the following
GET request of 10MB from client to server via test-pmd (static arp entries 
added in client
and server). Enable GRO and TSO in test-pmd where the packets recived from 
the client mac
would be sent to server mac and vice versa.
In above testing, without the patch the client observerd re-ordering of 25 
packets
and with the patch there were no packet re-ordering observerd.

 lib/gro/gro_tcp4.c | 35 ---
 lib/gro/rte_gro.c  | 18 +-
 2 files changed, 37 insertions(+), 16 deletions(-)

diff --git a/lib/gro/gro_tcp4.c b/lib/gro/gro_tcp4.c
index 8f5e800250..9ed891c253 100644
--- a/lib/gro/gro_tcp4.c
+++ b/lib/gro/gro_tcp4.c
@@ -188,6 +188,19 @@ update_header(struct gro_tcp4_item *item)
pkt->l2_len);
 }
 
+static inline void
+update_tcp_hdr_flags(struct rte_tcp_hdr *tcp_hdr, struct rte_mbuf *pkt)
+{
+   struct rte_ether_hdr *eth_hdr;
+   struct rte_ipv4_hdr *ipv4_hdr;
+   struct rte_tcp_hdr *merged_tcp_hdr;
+
+   eth_hdr = rte_pktmbuf_mtod(pkt, struct rte_ether_hdr *);
+   ipv4_hdr = (struct rte_ipv4_hdr *)((char *)eth_hdr + pkt->l2_len);
+   merged_tcp_hdr = (struct rte_tcp_hdr *)((char *)ipv4_hdr + pkt->l3_len);
+   merged_tcp_hdr->tcp_flags |= tcp_hdr->tcp_flags;
+}
+
 int32_t
 gro_tcp4_reassemble(struct rte_mbuf *pkt,
struct gro_tcp4_tbl *tbl,
@@ -206,6 +219,7 @@ gro_tcp4_reassemble(struct rte_mbuf *pkt,
uint32_t i, max_flow_num, remaining_flow_num;
int cmp;
uint8_t find;
+   uint32_t start_idx;
 
/*
 * Don't process the packet whose TCP header length is greater
@@ -219,12 +233,6 @@ gro_tcp4_reassemble(struct rte_mbuf *pkt,
tcp_hdr = (struct rte_tcp_hdr *)((char *)ipv4_hdr + pkt->l3_len);
hdr_len = pkt->l2_len + pkt->l3_len + pkt->l4_len;
 
-   /*
-* Don't process the packet which has FIN, SYN, RST, PSH, URG, ECE
-* or CWR set.
-*/
-   if (tcp_hdr->tcp_flags != RTE_TCP_ACK_FLAG)
-   return -1;
/*
 * Don't process the packet whose payload length is less than or
 * equal to 0.
@@ -263,12 +271,21 @@ gro_tcp4_reassemble(struct rte_mbuf *pkt,
if (tbl->flows[i].start_index != INVALID_ARRAY_INDEX) {
if (is_same_tcp4_flow(tbl->flows[i].key, key)) {
find = 1;
+   start_idx = tbl->flows[i].start_index;
break;
}
remaining_flow_num--;
}
}
 
+   if (tcp_hdr->tcp_flags != RTE_TCP_ACK_FLAG) {
+   if (find)
+   /* Since PSH flag is set, start time will be set to 0 
so it will be flushed immediately */
+   tbl->items[start_idx].start_time = 0;
+   else
+   return -1;
+   }
+
/*
 * Fail to find a matched flow. Insert a new flow and store the
 * packet into the flow.
@@ -303,8 +320,12 @@ gro_tcp4_reassemble(struct rte_mbuf *pkt,
is_atomic);
if (cmp) {
if (merge_two_tcp4_packets(&(tbl->items[cur_idx]),
-   pkt, cmp, sent_seq, ip_id, 0))
+ 

[PATCH v6 00/10] dts: ssh connection to a node

[Juraj Linkeš]

All the necessary code needed to connect to a node in a topology with
a bit more, such as basic logging and some extra useful methods.

To run the code, modify the config file, conf.yaml and execute ./main.py
from the root dts folder. Here's an example config:
executions:
  - system_under_test: "SUT 1"
nodes:
  - name: "SUT 1"
hostname: 127.0.0.1
user: root

The framework will use the user's SSH key to authenticate. User password
can be specified, in which case it will be used, but it's strongly
discouraged.

There are configuration files with a README that help with setting up
the execution/development environment.

The code only connects to a node. You'll see logs emitted to console
saying where DTS connected.

There's only a bit of documentation, as there's not much to document.
We'll add some real docs when there's enough functionality to document,
when the HelloWorld testcases is in (point 4 in our roadmap below). What
will be documented later is runtime dependencies and how to set up the DTS
control node environment.

This is our current roadmap:
1. Review this patchset and do the rest of the items in parallel, if
possible.
2. We have extracted the code needed to run the most basic testcase,
HelloWorld, which runs the DPDK Hello World application. We'll split
this along logical/functional boundaries and send after 1 is done.
3. Once we have 2 applied, we're planning on adding a basic functional
testcase - pf_smoke. This send a bit of traffic, so the big addition is
the software traffic generator, Scapy. There's some work already done on
Traffic generators we'll be sending as a dependence on this patch
series.
4. After 3, we'll add a basic performance testcase which doesn't use
Scapy, but Trex or Ixia instead.
5. This is far in the future, but at this point we should have all of
the core functionality in place. What then remains is adding the rest of
the testcases.

We're already working on items 2-4 and we may send more patches even
before this patch series is accepted if that's beneficial. The new
patches would then depend on this patch.

This patch, as well as all others in the pipeline, are the result of
extensive DTS workgroup review which happens internally. If you'd like
us to make it more public we'd have no problem with that.

v3:
Added project config files and developer tools.
Removed locks for parallel nodes, which are not needed now and will be
implemented much later (in a different patch).

v4:
Minor fixes - added missing Exception and utils function.

v5:
Reordered commits because the dependencies between commits changed.
Added more developer tools.
Added definitions of DTS testbed elements.
Reworked SSH implementation - split it so that the split between an
abstraction and the actual implementation is clearer.
Modified the directory structure to better organize the current and the
future code.

v6:
Minor code/grammar/style changes and a minor bugfix suggested by
Stanislaw.

Juraj Linkeš (9):
  dts: add project tools config
  dts: add developer tools
  dts: add basic logging facility
  dts: add remote session abstraction
  dts: add ssh session module
  dts: add node base class
  dts: add dts workflow module
  dts: add dts executable script
  maintainers: add dts maintainers

Owen Hilyard (1):
  dts: add config parser module

 .editorconfig |   2 +-
 .gitignore|   9 +-
 MAINTAINERS   |   5 +
 devtools/python-checkpatch.sh |  39 ++
 devtools/python-format.sh |  54 +++
 devtools/python-lint.sh   |  26 ++
 doc/guides/contributing/coding_style.rst  |   4 +-
 dts/.devcontainer/devcontainer.json   |  30 ++
 dts/Dockerfile|  39 ++
 dts/README.md | 154 
 dts/conf.yaml |   6 +
 dts/framework/__init__.py |   4 +
 dts/framework/config/__init__.py  | 100 +
 dts/framework/config/conf_yaml_schema.json|  65 
 dts/framework/dts.py  |  68 
 dts/framework/exception.py|  57 +++
 dts/framework/logger.py   | 114 ++
 dts/framework/remote_session/__init__.py  |  15 +
 .../remote_session/remote_session.py  | 100 +
 dts/framework/remote_session/ssh_session.py   | 185 +
 dts/framework/settings.py | 119 ++
 dts/framework/testbed_model/__init__.py   |   8 +
 dts/framework/testbed_model/node.py   |  63 
 dts/framework/utils.py|  31 ++
 dts/main.py   |  24 ++
 dts/poetry.lock   | 351 ++
 dts/pyproject.toml|  55 +++
 27 files changed, 1723 insertions(+), 4 deletions(-)
 create mode 100755 devtools/python-checkpatch.sh
 create mode 100755 devt

[PATCH v6 01/10] dts: add project tools config

[Juraj Linkeš]

Add configuration for Python tools used in DTS:
Poetry, dependency and package manager
Black, formatter
Pylama, static analysis
Isort, import sorting

Add Python and DTS specifics to .gitignore and .editorconfig. Of note is
the change of maximum line length of Python code to 88, which is a good
compromise between shorter files, readability and other considerations.
More in [0].

[0] 
https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length

Signed-off-by: Owen Hilyard 
Signed-off-by: Juraj Linkeš 
---
 .editorconfig|   2 +-
 .gitignore   |   9 +-
 doc/guides/contributing/coding_style.rst |   4 +-
 dts/README.md|  13 +
 dts/poetry.lock  | 351 +++
 dts/pyproject.toml   |  55 
 6 files changed, 430 insertions(+), 4 deletions(-)
 create mode 100644 dts/README.md
 create mode 100644 dts/poetry.lock
 create mode 100644 dts/pyproject.toml

diff --git a/.editorconfig b/.editorconfig
index ab41c95085..f20996f329 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -16,7 +16,7 @@ max_line_length = 100
 [*.py]
 indent_style = space
 indent_size = 4
-max_line_length = 79
+max_line_length = 88 # 
https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length
 
 [meson.build]
 indent_style = space
diff --git a/.gitignore b/.gitignore
index 212c7aa28e..460c5c6f21 100644
--- a/.gitignore
+++ b/.gitignore
@@ -33,8 +33,13 @@ GRTAGS
 tags
 TAGS
 
-# ignore python bytecode files
-*.pyc
+# python byte-compiled/optimized/dll files
+__pycache__/
+*.py[cod]
+*$py.class
+
+# DTS results
+dts/output
 
 # ignore default build directory, and directories from test-meson-builds.sh
 build
diff --git a/doc/guides/contributing/coding_style.rst 
b/doc/guides/contributing/coding_style.rst
index 89db6260cf..c86a03e7cc 100644
--- a/doc/guides/contributing/coding_style.rst
+++ b/doc/guides/contributing/coding_style.rst
@@ -851,7 +851,9 @@ Python Code
 All Python code should be compliant with
 `PEP8 (Style Guide for Python Code) 
`_.
 
-The ``pep8`` tool can be used for testing compliance with the guidelines.
+The ``pep8`` tool can be used for testing compliance with the guidelines. Note 
that the
+maximum line length is 88, as that is a good compromise between shorter files, 
usability
+with other tools (side-by-side diffs, docs, presentations) and disability 
accommodation.
 
 Integrating with the Build System
 -
diff --git a/dts/README.md b/dts/README.md
new file mode 100644
index 00..8a334746a7
--- /dev/null
+++ b/dts/README.md
@@ -0,0 +1,13 @@
+# [Poetry](https://python-poetry.org/docs/)
+The typical style of python dependency management, requirements.txt, has a few 
issues.
+The advantages of Poetry include specifying what python version is required 
and forcing
+you to specify versions, enforced by a lockfile, both of which help prevent 
broken
+dependencies. Another benefit is the use of pyproject.toml, which has become 
the
+standard config file for python projects, improving project organization.
+
+# Python Version
+The Python Version required by DTS is specified in [DTS python config 
file](./pyproject.toml)
+in the **[tool.poetry.dependencies]** section. Poetry doesn't install Python, 
so you may
+need to satisfy this requirement if your Python is not up-to-date. A tool such 
as
+[Pyenv](https://github.com/pyenv/pyenv) is a good way to get Python, though 
not the only
+one. However, DTS includes a development environment in the form of a Docker 
image.
diff --git a/dts/poetry.lock b/dts/poetry.lock
new file mode 100644
index 00..46dd5e8933
--- /dev/null
+++ b/dts/poetry.lock
@@ -0,0 +1,351 @@
+[[package]]
+name = "attrs"
+version = "22.1.0"
+description = "Classes Without Boilerplate"
+category = "main"
+optional = false
+python-versions = ">=3.5"
+
+[package.extras]
+dev = ["coverage[toml] (>=5.0.2)", "hypothesis", "pympler", "pytest 
(>=4.3.0)", "mypy (>=0.900,!=0.940)", "pytest-mypy-plugins", "zope.interface", 
"furo", "sphinx", "sphinx-notfound-page", "pre-commit", "cloudpickle"]
+docs = ["furo", "sphinx", "zope.interface", "sphinx-notfound-page"]
+tests = ["coverage[toml] (>=5.0.2)", "hypothesis", "pympler", "pytest 
(>=4.3.0)", "mypy (>=0.900,!=0.940)", "pytest-mypy-plugins", "zope.interface", 
"cloudpickle"]
+tests_no_zope = ["coverage[toml] (>=5.0.2)", "hypothesis", "pympler", "pytest 
(>=4.3.0)", "mypy (>=0.900,!=0.940)", "pytest-mypy-plugins", "cloudpickle"]
+
+[[package]]
+name = "black"
+version = "22.8.0"
+description = "The uncompromising code formatter."
+category = "dev"
+optional = false
+python-versions = ">=3.6.2"
+
+[package.dependencies]
+click = ">=8.0.0"
+mypy-extensions = ">=0.4.3"
+pathspec = ">=0.9.0"
+platformdirs = ">=2"
+tomli = {version = ">=1.1.0", markers = "python_full_version < \"3.11.0a7\""}
+
+[packa

[PATCH v6 02/10] dts: add developer tools

[Juraj Linkeš]

The Dockerfile contains basic image for CI and developers. There's also
an integration of the Dockerfile with Visual Studio.

The devtools that check Python code are Black and Isort to format the
code and Pylama to do static analysis.

Signed-off-by: Owen Hilyard 
Signed-off-by: Juraj Linkeš 
---
 devtools/python-checkpatch.sh   |  39 
 devtools/python-format.sh   |  54 +++
 devtools/python-lint.sh |  26 +
 dts/.devcontainer/devcontainer.json |  30 ++
 dts/Dockerfile  |  39 
 dts/README.md   | 141 
 6 files changed, 329 insertions(+)
 create mode 100755 devtools/python-checkpatch.sh
 create mode 100755 devtools/python-format.sh
 create mode 100755 devtools/python-lint.sh
 create mode 100644 dts/.devcontainer/devcontainer.json
 create mode 100644 dts/Dockerfile

diff --git a/devtools/python-checkpatch.sh b/devtools/python-checkpatch.sh
new file mode 100755
index 00..5d9cc6f52b
--- /dev/null
+++ b/devtools/python-checkpatch.sh
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2022 University of New Hampshire
+#
+
+function get_devtools_dir() {
+dirname "$0"
+}
+
+function main() {
+DEVTOOLS_DIR="$(get_devtools_dir)"
+ERRORS=0
+
+echo "Formatting:"
+env "$DEVTOOLS_DIR/python-format.sh" -c
+ERRORS=$(( ERRORS + $? ))
+
+echo -ne "\n\n"
+echo "Linting:"
+env "$DEVTOOLS_DIR/python-lint.sh"
+ERRORS=$(( ERRORS + $?))
+
+exit $ERRORS
+}
+
+function usage() {
+echo "Runs all of the dts devtools scripts."
+echo "$0 usage:" && grep -P " \w+\)\ #" "$0"
+exit 0
+}
+
+# There shouldn't be any arguments
+while getopts "" arg; do
+case $arg in
+*)
+esac
+done
+
+main
diff --git a/devtools/python-format.sh b/devtools/python-format.sh
new file mode 100755
index 00..6daf35bf9c
--- /dev/null
+++ b/devtools/python-format.sh
@@ -0,0 +1,54 @@
+#!/usr/bin/env bash
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2022 University of New Hampshire
+#
+
+function format() {
+echo "Formatting code with black."
+black .
+echo "Sorting imports with isort."
+isort .
+}
+
+function main() {
+format
+exit 0
+}
+
+function check_formatting() {
+git update-index --refresh
+retval=$?
+if [[ $retval -ne 0 ]]
+then
+echo 'The "needs update" files have been reformatted.'\
+'Please update your commit.'
+fi
+exit $retval
+}
+
+function usage() {
+echo "Automatically formats dts."
+echo "$0 usage:" && grep -P " \w+\)\ #" $0
+exit 0
+}
+
+while getopts "h,c,d:" arg; do
+case $arg in
+h) # Display this message
+usage
+;;
+
+# Unlike most of these other scripts, format has an argument to control the
+# non-zero exit code. This is to allow you to set it as your IDE's formatting
+# script, since many IDEs are not compatible with formatting scripts which
+# consider changing anything as a failure condition.
+c) # Exit with a non-zero exit code if any files were not properly 
formatted.
+format
+check_formatting
+;;
+*)
+esac
+done
+
+echo "Running formatting"
+main
diff --git a/devtools/python-lint.sh b/devtools/python-lint.sh
new file mode 100755
index 00..e9e17867a7
--- /dev/null
+++ b/devtools/python-lint.sh
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2022 University of New Hampshire
+#
+
+function main() {
+echo "Running static analysis (linting) using pylama."
+pylama .
+exit $?
+}
+
+function usage() {
+echo "Runs pylama, the linter for DTS."
+echo "Exits with a non-zero exit code if there were errors."
+exit 1
+}
+
+# There shouldn't be any arguments
+while getopts "" arg; do
+case $arg in
+*)
+usage
+esac
+done
+
+main
diff --git a/dts/.devcontainer/devcontainer.json 
b/dts/.devcontainer/devcontainer.json
new file mode 100644
index 00..41ca28fc17
--- /dev/null
+++ b/dts/.devcontainer/devcontainer.json
@@ -0,0 +1,30 @@
+// For format details, see https://aka.ms/devcontainer.json. For config 
options, see the README at:
+// 
https://github.com/microsoft/vscode-dev-containers/tree/v0.241.1/containers/docker-existing-dockerfile
+{
+   "name": "Existing Dockerfile",
+
+   // Sets the run context to one level up instead of the .devcontainer 
folder.
+   "context": "..",
+
+   // Update the 'dockerFile' property if you aren't using the standard 
'Dockerfile' filename.
+   "dockerFile": "../Dockerfile",
+
+   // Use 'forwardPorts' to make a list of ports inside the container 
available locally.
+   // "forwardPorts": [],
+
+   // Uncomment the next line to run commands after the container is 
created - for example installing curl.
+   "postCreateCommand": "poetry install",
+
+   "extensions": [
+   "ms-

[PATCH v6 03/10] dts: add config parser module

[Juraj Linkeš]

From: Owen Hilyard 

The configuration is split into two parts, one defining the parameters
of the test run and the other defining the topology to be used.

The format of the configuration is YAML. It is validated according to a
json schema which also server as detailed documentation of the various
configuration fields. This means that the complete set of allowed values
are tied to the schema as a source of truth. This enables making changes
to parts of DTS that interface with config files without a high risk of
breaking someone's configuration.

This configuration system uses immutable objects to represent the
configuration, making IDE/LSP autocomplete work properly.

There are two ways to specify the configuration file path, an
environment variable or a command line argument, applied in that order.

Signed-off-by: Owen Hilyard 
Signed-off-by: Juraj Linkeš 
---
 dts/conf.yaml  |   6 ++
 dts/framework/config/__init__.py   | 100 +
 dts/framework/config/conf_yaml_schema.json |  65 ++
 dts/framework/settings.py  |  84 +
 4 files changed, 255 insertions(+)
 create mode 100644 dts/conf.yaml
 create mode 100644 dts/framework/config/__init__.py
 create mode 100644 dts/framework/config/conf_yaml_schema.json
 create mode 100644 dts/framework/settings.py

diff --git a/dts/conf.yaml b/dts/conf.yaml
new file mode 100644
index 00..75947dc234
--- /dev/null
+++ b/dts/conf.yaml
@@ -0,0 +1,6 @@
+executions:
+  - system_under_test: "SUT 1"
+nodes:
+  - name: "SUT 1"
+hostname: sut1.change.me.localhost
+user: root
diff --git a/dts/framework/config/__init__.py b/dts/framework/config/__init__.py
new file mode 100644
index 00..47f7a8e3ff
--- /dev/null
+++ b/dts/framework/config/__init__.py
@@ -0,0 +1,100 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2021 Intel Corporation
+# Copyright(c) 2022 University of New Hampshire
+#
+
+"""
+Generic port and topology nodes configuration file load function
+"""
+
+import json
+import os.path
+import pathlib
+from dataclasses import dataclass
+from typing import Any, Optional
+
+import warlock
+import yaml
+
+from framework.settings import SETTINGS
+
+
+# Slots enables some optimizations, by pre-allocating space for the defined
+# attributes in the underlying data structure.
+#
+# Frozen makes the object immutable. This enables further optimizations,
+# and makes it thread safe should we every want to move in that direction.
+@dataclass(slots=True, frozen=True)
+class NodeConfiguration:
+name: str
+hostname: str
+user: str
+password: Optional[str]
+
+@staticmethod
+def from_dict(d: dict) -> "NodeConfiguration":
+return NodeConfiguration(
+name=d["name"],
+hostname=d["hostname"],
+user=d["user"],
+password=d.get("password"),
+)
+
+
+@dataclass(slots=True, frozen=True)
+class ExecutionConfiguration:
+system_under_test: NodeConfiguration
+
+@staticmethod
+def from_dict(d: dict, node_map: dict) -> "ExecutionConfiguration":
+sut_name = d["system_under_test"]
+assert sut_name in node_map, f"Unknown SUT {sut_name} in execution {d}"
+
+return ExecutionConfiguration(
+system_under_test=node_map[sut_name],
+)
+
+
+@dataclass(slots=True, frozen=True)
+class Configuration:
+executions: list[ExecutionConfiguration]
+
+@staticmethod
+def from_dict(d: dict) -> "Configuration":
+nodes: list[NodeConfiguration] = list(
+map(NodeConfiguration.from_dict, d["nodes"])
+)
+assert len(nodes) > 0, "There must be a node to test"
+
+node_map = {node.name: node for node in nodes}
+assert len(nodes) == len(node_map), "Duplicate node names are not 
allowed"
+
+executions: list[ExecutionConfiguration] = list(
+map(
+ExecutionConfiguration.from_dict, d["executions"], [node_map 
for _ in d]
+)
+)
+
+return Configuration(executions=executions)
+
+
+def load_config() -> Configuration:
+"""
+Loads the configuration file and the configuration file schema,
+validates the configuration file, and creates a configuration object.
+"""
+with open(SETTINGS.config_file_path, "r") as f:
+config_data = yaml.safe_load(f)
+
+schema_path = os.path.join(
+pathlib.Path(__file__).parent.resolve(), "conf_yaml_schema.json"
+)
+
+with open(schema_path, "r") as f:
+schema = json.load(f)
+config: dict[str, Any] = warlock.model_factory(schema, 
name="_Config")(config_data)
+config_obj: Configuration = Configuration.from_dict(dict(config))
+return config_obj
+
+
+CONFIGURATION = load_config()
diff --git a/dts/framework/config/conf_yaml_schema.json 
b/dts/framework/config/conf_yaml_schema.json
new file mode 100644
index 00..6b8d6ccd05
--- /dev/null
+++ b/dts/framework/

[PATCH v6 04/10] dts: add basic logging facility

[Juraj Linkeš]

The logging module provides loggers distinguished by two attributes,
a custom format and a verbosity switch. The loggers log to both console
and more verbosely to files.

Signed-off-by: Owen Hilyard 
Signed-off-by: Juraj Linkeš 
---
 dts/framework/__init__.py |   4 ++
 dts/framework/logger.py   | 114 ++
 dts/framework/settings.py |  23 
 3 files changed, 141 insertions(+)
 create mode 100644 dts/framework/__init__.py
 create mode 100644 dts/framework/logger.py

diff --git a/dts/framework/__init__.py b/dts/framework/__init__.py
new file mode 100644
index 00..6cdc0639db
--- /dev/null
+++ b/dts/framework/__init__.py
@@ -0,0 +1,4 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2022 PANTHEON.tech s.r.o.
+# Copyright(c) 2022 University of New Hampshire
+#
diff --git a/dts/framework/logger.py b/dts/framework/logger.py
new file mode 100644
index 00..5a9fb0490c
--- /dev/null
+++ b/dts/framework/logger.py
@@ -0,0 +1,114 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2014 Intel Corporation
+# Copyright(c) 2022 PANTHEON.tech s.r.o.
+# Copyright(c) 2022 University of New Hampshire
+#
+
+"""
+DTS logger module with several log level. DTS framework and TestSuite logs
+are saved in different log files.
+"""
+
+import logging
+import os.path
+from typing import TypedDict
+
+from .settings import SETTINGS
+
+date_fmt = "%Y/%m/%d %H:%M:%S"
+stream_fmt = "%(asctime)s - %(name)s - %(levelname)s - %(message)s"
+
+
+class LoggerDictType(TypedDict):
+logger: "DTSLOG"
+name: str
+node: str
+
+
+# List for saving all using loggers
+Loggers: list[LoggerDictType] = []
+
+
+class DTSLOG(logging.LoggerAdapter):
+"""
+DTS log class for framework and testsuite.
+"""
+
+logger: logging.Logger
+node: str
+sh: logging.StreamHandler
+fh: logging.FileHandler
+verbose_fh: logging.FileHandler
+
+def __init__(self, logger: logging.Logger, node: str = "suite"):
+self.logger = logger
+# 1 means log everything, this will be used by file handlers if their 
level
+# is not set
+self.logger.setLevel(1)
+
+self.node = node
+
+# add handler to emit to stdout
+sh = logging.StreamHandler()
+sh.setFormatter(logging.Formatter(stream_fmt, date_fmt))
+sh.setLevel(logging.INFO)  # console handler default level
+
+if SETTINGS.verbose is True:
+sh.setLevel(logging.DEBUG)
+
+self.logger.addHandler(sh)
+self.sh = sh
+
+logging_path_prefix = os.path.join(SETTINGS.output_dir, node)
+
+fh = logging.FileHandler(f"{logging_path_prefix}.log")
+fh.setFormatter(
+logging.Formatter(
+fmt="%(asctime)s - %(name)s - %(levelname)s - %(message)s",
+datefmt=date_fmt,
+)
+)
+
+self.logger.addHandler(fh)
+self.fh = fh
+
+# This outputs EVERYTHING, intended for post-mortem debugging
+# Also optimized for processing via AWK (awk -F '|' ...)
+verbose_fh = logging.FileHandler(f"{logging_path_prefix}.verbose.log")
+verbose_fh.setFormatter(
+logging.Formatter(
+
fmt="%(asctime)s|%(name)s|%(levelname)s|%(pathname)s|%(lineno)d|"
+
"%(funcName)s|%(process)d|%(thread)d|%(threadName)s|%(message)s",
+datefmt=date_fmt,
+)
+)
+
+self.logger.addHandler(verbose_fh)
+self.verbose_fh = verbose_fh
+
+super(DTSLOG, self).__init__(self.logger, dict(node=self.node))
+
+def logger_exit(self) -> None:
+"""
+Remove stream handler and logfile handler.
+"""
+for handler in (self.sh, self.fh, self.verbose_fh):
+handler.flush()
+self.logger.removeHandler(handler)
+
+
+def getLogger(name: str, node: str = "suite") -> DTSLOG:
+"""
+Get logger handler and if there's no handler for specified Node will 
create one.
+"""
+global Loggers
+# return saved logger
+logger: LoggerDictType
+for logger in Loggers:
+if logger["name"] == name and logger["node"] == node:
+return logger["logger"]
+
+# return new logger
+dts_logger: DTSLOG = DTSLOG(logging.getLogger(name), node)
+Loggers.append({"logger": dts_logger, "name": name, "node": node})
+return dts_logger
diff --git a/dts/framework/settings.py b/dts/framework/settings.py
index d1a955502b..c83d957e61 100644
--- a/dts/framework/settings.py
+++ b/dts/framework/settings.py
@@ -57,6 +57,8 @@ def __call__(
 @dataclass(slots=True, frozen=True)
 class _Settings:
 config_file_path: str
+output_dir: str
+verbose: bool
 
 
 def _get_parser() -> argparse.ArgumentParser:
@@ -71,6 +73,25 @@ def _get_parser() -> argparse.ArgumentParser:
 "and targets.",
 )
 
+parser.add_argument(
+"--output-dir",
+"--output",
+action=_env_arg("DTS_OUT

[PATCH v6 05/10] dts: add remote session abstraction

[Juraj Linkeš]

The abstraction allows for easy switching of implementations of remote
connections (ssh, telnet, etc.). It implements some common features,
such as logging of commands and their outputs and history bookkeeping
and defines methods that must be implemented by derived classes.

Signed-off-by: Owen Hilyard 
Signed-off-by: Juraj Linkeš 
---
 dts/framework/remote_session/__init__.py  |   5 +
 .../remote_session/remote_session.py  | 100 ++
 dts/framework/settings.py |  12 +++
 3 files changed, 117 insertions(+)
 create mode 100644 dts/framework/remote_session/__init__.py
 create mode 100644 dts/framework/remote_session/remote_session.py

diff --git a/dts/framework/remote_session/__init__.py 
b/dts/framework/remote_session/__init__.py
new file mode 100644
index 00..d924d8aaa9
--- /dev/null
+++ b/dts/framework/remote_session/__init__.py
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2022 PANTHEON.tech s.r.o.
+#
+
+from .remote_session import RemoteSession
diff --git a/dts/framework/remote_session/remote_session.py 
b/dts/framework/remote_session/remote_session.py
new file mode 100644
index 00..7c499c32e3
--- /dev/null
+++ b/dts/framework/remote_session/remote_session.py
@@ -0,0 +1,100 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2014 Intel Corporation
+# Copyright(c) 2022 PANTHEON.tech s.r.o.
+# Copyright(c) 2022 University of New Hampshire
+#
+
+import dataclasses
+from abc import ABC, abstractmethod
+from typing import Optional
+
+from framework.config import NodeConfiguration
+from framework.logger import DTSLOG
+from framework.settings import SETTINGS
+
+
+@dataclasses.dataclass(slots=True, frozen=True)
+class HistoryRecord:
+name: str
+command: str
+output: str | int
+
+
+class RemoteSession(ABC):
+name: str
+hostname: str
+ip: str
+port: Optional[int]
+username: str
+password: str
+logger: DTSLOG
+history: list[HistoryRecord]
+_node_config: NodeConfiguration
+
+def __init__(
+self,
+node_config: NodeConfiguration,
+session_name: str,
+logger: DTSLOG,
+):
+self._node_config = node_config
+
+self.name = session_name
+self.hostname = node_config.hostname
+self.ip = self.hostname
+self.port = None
+if ":" in self.hostname:
+self.ip, port = self.hostname.split(":")
+self.port = int(port)
+self.username = node_config.user
+self.password = node_config.password or ""
+self.logger = logger
+self.history = []
+
+self.logger.info(f"Connecting to {self.username}@{self.hostname}.")
+self._connect()
+self.logger.info(f"Connection to {self.username}@{self.hostname} 
successful.")
+
+def send_command(self, command: str, timeout: float = SETTINGS.timeout) -> 
str:
+self.logger.info(f"Sending: {command}")
+out = self._send_command(command, timeout)
+self.logger.debug(f"Received from {command}: {out}")
+self._history_add(command=command, output=out)
+return out
+
+def close(self, force: bool = False) -> None:
+self.logger.logger_exit()
+self._close(force)
+
+def _history_add(self, command: str, output: str) -> None:
+self.history.append(
+HistoryRecord(name=self.name, command=command, output=output)
+)
+
+@abstractmethod
+def is_alive(self) -> bool:
+"""
+Check whether the session is still responding.
+"""
+pass
+
+@abstractmethod
+def _connect(self) -> None:
+"""
+Create connection to assigned node.
+"""
+pass
+
+@abstractmethod
+def _send_command(self, command: str, timeout: float) -> str:
+"""
+Send a command and return the output.
+"""
+pass
+
+@abstractmethod
+def _close(self, force: bool = False) -> None:
+"""
+Close the remote session, freeing all used resources.
+"""
+pass
diff --git a/dts/framework/settings.py b/dts/framework/settings.py
index c83d957e61..2e0d428996 100644
--- a/dts/framework/settings.py
+++ b/dts/framework/settings.py
@@ -58,6 +58,7 @@ def __call__(
 class _Settings:
 config_file_path: str
 output_dir: str
+timeout: float
 verbose: bool
 
 
@@ -82,6 +83,16 @@ def _get_parser() -> argparse.ArgumentParser:
 help="[DTS_OUTPUT_DIR] Output directory where dts logs and results are 
saved.",
 )
 
+parser.add_argument(
+"-t",
+"--timeout",
+action=_env_arg("DTS_TIMEOUT"),
+default=15,
+required=False,
+help="[DTS_TIMEOUT] The default timeout for all DTS operations except 
for "
+"compiling DPDK.",
+)
+
 parser.add_argument(
 "-v",
 "--verbose",
@@ -100,6 +111,7 @@ def _get_settings() -> _Settings:
 return _Settings(

[PATCH v6 06/10] dts: add ssh session module

[Juraj Linkeš]

The module uses the pexpect python library and implements connection to
a node and two ways to interact with the node:
1. Send a string with specified prompt which will be matched after
   the string has been sent to the node.
2. Send a command to be executed. No prompt is specified here.

Signed-off-by: Owen Hilyard 
Signed-off-by: Juraj Linkeš 
---
 dts/framework/exception.py|  57 ++
 dts/framework/remote_session/__init__.py  |  10 +
 .../remote_session/remote_session.py  |  40 ++--
 dts/framework/remote_session/ssh_session.py   | 185 ++
 dts/framework/utils.py|  13 ++
 5 files changed, 285 insertions(+), 20 deletions(-)
 create mode 100644 dts/framework/exception.py
 create mode 100644 dts/framework/remote_session/ssh_session.py
 create mode 100644 dts/framework/utils.py

diff --git a/dts/framework/exception.py b/dts/framework/exception.py
new file mode 100644
index 00..8bff9cf9f6
--- /dev/null
+++ b/dts/framework/exception.py
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2014 Intel Corporation
+# Copyright(c) 2022 PANTHEON.tech s.r.o.
+# Copyright(c) 2022 University of New Hampshire
+#
+
+"""
+User-defined exceptions used across the framework.
+"""
+
+
+class SSHTimeoutError(Exception):
+"""
+Command execution timeout.
+"""
+
+command: str
+output: str
+
+def __init__(self, command: str, output: str):
+self.command = command
+self.output = output
+
+def __str__(self) -> str:
+return f"TIMEOUT on {self.command}"
+
+def get_output(self) -> str:
+return self.output
+
+
+class SSHConnectionError(Exception):
+"""
+SSH connection error.
+"""
+
+host: str
+
+def __init__(self, host: str):
+self.host = host
+
+def __str__(self) -> str:
+return f"Error trying to connect with {self.host}"
+
+
+class SSHSessionDeadError(Exception):
+"""
+SSH session is not alive.
+It can no longer be used.
+"""
+
+host: str
+
+def __init__(self, host: str):
+self.host = host
+
+def __str__(self) -> str:
+return f"SSH session with {self.host} has died"
diff --git a/dts/framework/remote_session/__init__.py 
b/dts/framework/remote_session/__init__.py
index d924d8aaa9..d7478e6800 100644
--- a/dts/framework/remote_session/__init__.py
+++ b/dts/framework/remote_session/__init__.py
@@ -2,4 +2,14 @@
 # Copyright(c) 2022 PANTHEON.tech s.r.o.
 #
 
+from framework.config import NodeConfiguration
+from framework.logger import DTSLOG
+
 from .remote_session import RemoteSession
+from .ssh_session import SSHSession
+
+
+def create_remote_session(
+node_config: NodeConfiguration, name: str, logger: DTSLOG
+) -> RemoteSession:
+return SSHSession(node_config, name, logger)
diff --git a/dts/framework/remote_session/remote_session.py 
b/dts/framework/remote_session/remote_session.py
index 7c499c32e3..eaa4fa7a42 100644
--- a/dts/framework/remote_session/remote_session.py
+++ b/dts/framework/remote_session/remote_session.py
@@ -55,6 +55,13 @@ def __init__(
 self._connect()
 self.logger.info(f"Connection to {self.username}@{self.hostname} 
successful.")
 
+@abstractmethod
+def _connect(self) -> None:
+"""
+Create connection to assigned node.
+"""
+pass
+
 def send_command(self, command: str, timeout: float = SETTINGS.timeout) -> 
str:
 self.logger.info(f"Sending: {command}")
 out = self._send_command(command, timeout)
@@ -62,39 +69,32 @@ def send_command(self, command: str, timeout: float = 
SETTINGS.timeout) -> str:
 self._history_add(command=command, output=out)
 return out
 
-def close(self, force: bool = False) -> None:
-self.logger.logger_exit()
-self._close(force)
+@abstractmethod
+def _send_command(self, command: str, timeout: float) -> str:
+"""
+Send a command and return the output.
+"""
+pass
 
 def _history_add(self, command: str, output: str) -> None:
 self.history.append(
 HistoryRecord(name=self.name, command=command, output=output)
 )
 
-@abstractmethod
-def is_alive(self) -> bool:
-"""
-Check whether the session is still responding.
-"""
-pass
-
-@abstractmethod
-def _connect(self) -> None:
-"""
-Create connection to assigned node.
-"""
-pass
+def close(self, force: bool = False) -> None:
+self.logger.logger_exit()
+self._close(force)
 
 @abstractmethod
-def _send_command(self, command: str, timeout: float) -> str:
+def _close(self, force: bool = False) -> None:
 """
-Send a command and return the output.
+Close the remote session, freeing all used resources.
 """
 pass
 
 @abstractmethod
-def _close(self, force: bool = False) -> 

[PATCH v6 07/10] dts: add node base class

[Juraj Linkeš]

The base class implements basic node management methods - connect and
execute commands.

Signed-off-by: Owen Hilyard 
Signed-off-by: Juraj Linkeš 
---
 dts/framework/testbed_model/__init__.py |  8 
 dts/framework/testbed_model/node.py | 63 +
 2 files changed, 71 insertions(+)
 create mode 100644 dts/framework/testbed_model/__init__.py
 create mode 100644 dts/framework/testbed_model/node.py

diff --git a/dts/framework/testbed_model/__init__.py 
b/dts/framework/testbed_model/__init__.py
new file mode 100644
index 00..7e8a1f7489
--- /dev/null
+++ b/dts/framework/testbed_model/__init__.py
@@ -0,0 +1,8 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2022 University of New Hampshire
+#
+
+"""
+This module contains the classes used to model the physical traffic generator,
+system under test and any other components that need to be interacted with.
+"""
diff --git a/dts/framework/testbed_model/node.py 
b/dts/framework/testbed_model/node.py
new file mode 100644
index 00..81b7f3ab83
--- /dev/null
+++ b/dts/framework/testbed_model/node.py
@@ -0,0 +1,63 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2014 Intel Corporation
+# Copyright(c) 2022 PANTHEON.tech s.r.o.
+# Copyright(c) 2022 University of New Hampshire
+#
+
+"""
+A node is a generic host that DTS connects to and manages.
+"""
+
+from framework.config import NodeConfiguration
+from framework.logger import DTSLOG, getLogger
+from framework.remote_session import RemoteSession, create_remote_session
+from framework.settings import SETTINGS
+
+
+class Node(object):
+"""
+Basic module for node management. This module implements methods that
+manage a node, such as information gathering (of CPU/PCI/NIC) and
+environment setup.
+"""
+
+name: str
+main_session: RemoteSession
+logger: DTSLOG
+_config: NodeConfiguration
+_other_sessions: list[RemoteSession]
+
+def __init__(self, node_config: NodeConfiguration):
+self._config = node_config
+self._other_sessions = []
+
+self.name = node_config.name
+self.logger = getLogger(self.name)
+self.logger.info(f"Created node: {self.name}")
+self.main_session = create_remote_session(self._config, self.name, 
self.logger)
+
+def send_command(self, cmds: str, timeout: float = SETTINGS.timeout) -> 
str:
+"""
+Send commands to node and return string before timeout.
+"""
+
+return self.main_session.send_command(cmds, timeout)
+
+def create_session(self, name: str) -> RemoteSession:
+connection = create_remote_session(
+self._config,
+name,
+getLogger(name, node=self.name),
+)
+self._other_sessions.append(connection)
+return connection
+
+def node_exit(self) -> None:
+"""
+Recover all resource before node exit
+"""
+if self.main_session:
+self.main_session.close()
+for session in self._other_sessions:
+session.close()
+self.logger.logger_exit()
-- 
2.30.2

[PATCH v6 08/10] dts: add dts workflow module

[Juraj Linkeš]

The module implements methods needed to run DTS. It handles the creation
of objects and eventually the whole DTS workflow, such as running node
setups, test gathering, setup and execution and various cleanups.

Signed-off-by: Owen Hilyard 
Signed-off-by: Juraj Linkeš 
---
 dts/framework/dts.py   | 68 ++
 dts/framework/utils.py | 18 +++
 2 files changed, 86 insertions(+)
 create mode 100644 dts/framework/dts.py

diff --git a/dts/framework/dts.py b/dts/framework/dts.py
new file mode 100644
index 00..4aad4a4e8b
--- /dev/null
+++ b/dts/framework/dts.py
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2019 Intel Corporation
+# Copyright(c) 2022 PANTHEON.tech s.r.o.
+# Copyright(c) 2022 University of New Hampshire
+#
+
+import sys
+import traceback
+from typing import Iterable, Optional
+
+from framework.testbed_model.node import Node
+
+from .config import CONFIGURATION
+from .logger import DTSLOG, getLogger
+from .utils import check_dts_python_version
+
+dts_logger: Optional[DTSLOG] = None
+
+
+def run_all() -> None:
+"""
+Main process of DTS, it will run all test suites in the config file.
+"""
+
+global dts_logger
+
+# check the python version of the server that run dts
+check_dts_python_version()
+
+dts_logger = getLogger("dts")
+
+nodes = {}
+# This try/finally block means "Run the try block, if there is an 
exception,
+# run the finally block before passing it upward. If there is not an 
exception,
+# run the finally block after the try block is finished." This helps avoid 
the
+# problem of python's interpreter exit context, which essentially prevents 
you
+# from making certain system calls. This makes cleaning up resources 
difficult,
+# since most of the resources in DTS are network-based, which is 
restricted.
+try:
+# for all Execution sections
+for execution in CONFIGURATION.executions:
+sut_config = execution.system_under_test
+if sut_config.name not in nodes:
+node = Node(sut_config)
+nodes[sut_config.name] = node
+node.send_command("echo Hello World")
+
+except Exception as e:
+# sys.exit() doesn't produce a stack trace, need to print it explicitly
+traceback.print_exc()
+raise e
+
+finally:
+quit_execution(nodes.values())
+
+
+def quit_execution(sut_nodes: Iterable[Node]) -> None:
+"""
+Close session to SUT and TG before quit.
+Return exit status when failure occurred.
+"""
+for sut_node in sut_nodes:
+# close all session
+sut_node.node_exit()
+
+if dts_logger is not None:
+dts_logger.info("DTS execution has ended.")
+sys.exit(0)
diff --git a/dts/framework/utils.py b/dts/framework/utils.py
index fe13ae5e77..3e77fea085 100644
--- a/dts/framework/utils.py
+++ b/dts/framework/utils.py
@@ -4,6 +4,24 @@
 # Copyright(c) 2022 University of New Hampshire
 #
 
+import sys
+
+
+def check_dts_python_version() -> None:
+if sys.version_info.major < 3 or (
+sys.version_info.major == 3 and sys.version_info.minor < 10
+):
+print(
+RED(
+(
+"WARNING: DTS execution node's python version is lower 
than"
+"python 3.10, is deprecated and will not work in future 
releases."
+)
+),
+file=sys.stderr,
+)
+print(RED("Please use Python >= 3.10 instead"), file=sys.stderr)
+
 
 def GREEN(text: str) -> str:
 return f"\u001B[32;1m{str(text)}\u001B[0m"
-- 
2.30.2

[PATCH v6 09/10] dts: add dts executable script

[Juraj Linkeš]

The script is an interface to run DTS.

Signed-off-by: Owen Hilyard 
Signed-off-by: Juraj Linkeš 
---
 dts/main.py | 24 
 1 file changed, 24 insertions(+)
 create mode 100755 dts/main.py

diff --git a/dts/main.py b/dts/main.py
new file mode 100755
index 00..a700707650
--- /dev/null
+++ b/dts/main.py
@@ -0,0 +1,24 @@
+#!/usr/bin/env python3
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2010-2014 Intel Corporation
+# Copyright(c) 2022 PANTHEON.tech s.r.o.
+# Copyright(c) 2022 University of New Hampshire
+#
+
+"""
+A test framework for testing DPDK.
+"""
+
+import logging
+
+from framework import dts
+
+
+def main() -> None:
+dts.run_all()
+
+
+# Main program begins here
+if __name__ == "__main__":
+logging.raiseExceptions = True
+main()
-- 
2.30.2

[PATCH v6 10/10] maintainers: add dts maintainers

[Juraj Linkeš]

Signed-off-by: Juraj Linkeš 
---
 MAINTAINERS | 5 +
 1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 51d77460ec..e018e396d0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -114,6 +114,11 @@ F: buildtools/symlink-drivers-solibs.py
 F: devtools/test-meson-builds.sh
 F: devtools/check-meson.py
 
+DTS
+M: Lijuan Tu 
+M: Owen Hilyard 
+F: dts/
+
 Public CI
 M: Aaron Conole 
 M: Michael Santana 
-- 
2.30.2

Re: [PATCH v8 1/9] memarea: introduce memarea library

[fengchengwen]

Sorry to self-reply.

On 2022/10/12 12:06, fengchengwen wrote:
> Hi Dmitry,
> 
> On 2022/10/11 23:58, Dmitry Kozlyuk wrote:
>> 2022-10-11 12:17 (UTC+), Chengwen Feng:
>> [...]
>>> diff --git a/doc/guides/prog_guide/memarea_lib.rst 
>>> b/doc/guides/prog_guide/memarea_lib.rst
>>> new file mode 100644
>>> index 00..85ad57145f
>>> --- /dev/null
>>> +++ b/doc/guides/prog_guide/memarea_lib.rst
>>> @@ -0,0 +1,39 @@
>>> +..  SPDX-License-Identifier: BSD-3-Clause
>>> +Copyright(c) 2022 HiSilicon Limited
>>> +
>>> +Memarea Library
>>> +===
>>> +
>>> +Introduction
>>> +
>>> +
>>> +The memarea library provides an allocator of variable-size objects, it is
>>> +oriented towards the application layer, which could provides 'region-based
>>> +memory management' function [1].
>>> +
>>> +The main features are as follows:
>>> +
>>> +* The allocated object aligned at ``RTE_CACHE_LINE_SIZE`` default.
>>
>> Isn't this an implementation detail?
>> Stating it in the API description limits optimization opportunities.
>> Cache line alignment is good in many cases,
>> but it can also be a waste of space,
>> e.g. for a thread-unsafe region for small objects.
>> Can this limitation only (temporarily?) apply to user memory?
>> Or can the minimal alignment be a property of memarea?
> 
> You are right, to be more general, I'll add the align parameter to 
> rte_memarea_alloc instead of stating it here.

The memarea is targeted to not so general usage, so v9 doesn't add align 
parameter to rte_memarea_alloc, at least from the internal feedback.
We could add rte_memarea_align_alloc() if the align requirement does exist.

> 
>>
>>> +
>>> +* The memory region can be initialized from the following memory sources:
>>> +  a) HEAP: e.g. invoke ``rte_malloc_socket``. b) LIBC: e.g. invoke
>>> +  posix_memalign to obtain. c) User memory: it can be from e.g. 
>>> rte_extmem_xxx
>>> +  as long as it is available. d) Another memarea: it can be allocated from
>>> +  another memarea.
>>
>> I think mentioning rte_extmem_xxx() is bogus
>> because user memory does not need to be registered with DPDK
>> (I understand it's an example, but still an unrelated reference).
>> Please format as a list.
> 
> okay
> 
>>
>>> +
>>> +* It provides refcnt feature which could be useful in multi-reader 
>>> scenario.
>>> +
>>> +* It supports MT-safe as long as it's specified at creation time.
>>> +
>>> +Library API Overview
>>> +
>>> +
>>> +The ``rte_memarea_create()`` function is used to create a memarea, the 
>>> function
>>> +returns the pointer to the created memarea or ``NULL`` if the creation 
>>> failed.
>>> +
>>> +The ``rte_memarea_destroy()`` function is used to destroy a memarea.
>>> +
>>> +Reference
>>> +-
>>> +
>>> +[1] https://en.wikipedia.org/wiki/Region-based_memory_management
>>> diff --git a/doc/guides/rel_notes/release_22_11.rst 
>>> b/doc/guides/rel_notes/release_22_11.rst
>>> index 2da8bc9661..f5a67cec7b 100644
>>> --- a/doc/guides/rel_notes/release_22_11.rst
>>> +++ b/doc/guides/rel_notes/release_22_11.rst
>>> @@ -63,6 +63,12 @@ New Features
>>>In theory this implementation should work with any target based on
>>>``LoongArch`` ISA.
>>>  
>>> +* **Added memarea library.**
>>> +
>>> +  The memarea library is an allocator of variable-size objects, it is 
>>> oriented
>>> +  towards the application layer, which could provides 'region-based memory
>>> +  management' function.
>>
>> "which could provides" -> "providing"
> 
> okay
> 
>>
>>> +
>>>  * **Added support for multiple mbuf pools per ethdev Rx queue.**
>>>  
>>>The capability allows application to provide many mempools
>> [...]
>> .
>>
> 
> .
> 

Re: [PATCH v6 00/10] dts: ssh connection to a node

[Bruce Richardson]

On Thu, Oct 13, 2022 at 10:35:07AM +, Juraj Linkeš wrote:
> All the necessary code needed to connect to a node in a topology with
> a bit more, such as basic logging and some extra useful methods.
> 
> To run the code, modify the config file, conf.yaml and execute ./main.py
> from the root dts folder. Here's an example config:
> executions:
>   - system_under_test: "SUT 1"
> nodes:
>   - name: "SUT 1"
> hostname: 127.0.0.1
> user: root
> 
> The framework will use the user's SSH key to authenticate. User password
> can be specified, in which case it will be used, but it's strongly
> discouraged.
> 
> There are configuration files with a README that help with setting up
> the execution/development environment.
> 
> The code only connects to a node. You'll see logs emitted to console
> saying where DTS connected.
> 
> There's only a bit of documentation, as there's not much to document.
> We'll add some real docs when there's enough functionality to document,
> when the HelloWorld testcases is in (point 4 in our roadmap below). What
> will be documented later is runtime dependencies and how to set up the DTS
> control node environment.
> 
> This is our current roadmap:
> 1. Review this patchset and do the rest of the items in parallel, if
> possible.
> 2. We have extracted the code needed to run the most basic testcase,
> HelloWorld, which runs the DPDK Hello World application. We'll split
> this along logical/functional boundaries and send after 1 is done.
> 3. Once we have 2 applied, we're planning on adding a basic functional
> testcase - pf_smoke. This send a bit of traffic, so the big addition is
> the software traffic generator, Scapy. There's some work already done on
> Traffic generators we'll be sending as a dependence on this patch
> series.
> 4. After 3, we'll add a basic performance testcase which doesn't use
> Scapy, but Trex or Ixia instead.
> 5. This is far in the future, but at this point we should have all of
> the core functionality in place. What then remains is adding the rest of
> the testcases.
> 
> We're already working on items 2-4 and we may send more patches even
> before this patch series is accepted if that's beneficial. The new
> patches would then depend on this patch.
> 
> This patch, as well as all others in the pipeline, are the result of
> extensive DTS workgroup review which happens internally. If you'd like
> us to make it more public we'd have no problem with that.
> 

Thanks for all the work on this, it's good to see DTS making its way slowly
towards mainline DPDK.

Series-acked-by: Bruce Richardson 

[PATCH v2] doc: fix support table for ETH and VLAN flow items

[Ilya Maximets]

'has_vlan' attribute is only supported by sfc, mlx5 and cnxk.
Other drivers doesn't support it.  Most of them (like i40e) just
ignore it silently.  Some drivers (like mlx4) never had a full
support of the eth item even before introduction of 'has_vlan'
(mlx4 allows to match on the destination MAC only).

Same for the 'has_more_vlan' flag of the vlan item.

'has_vlan' is part of 'rte_flow_item_eth', so changing 'eth'
field to 'partial support' in documentation for all such drivers.
'has_more_vlan' is part of 'rte_flow_item_vlan', so changing
'vlan' to 'partial support' as well.

This doesn't solve the issue, but at least marks the problematic
drivers.

Some details are available in:
  https://bugs.dpdk.org/show_bug.cgi?id=958

Fixes: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items")
Cc: sta...@dpdk.org

Signed-off-by: Ilya Maximets 
---

Version 2:
  - Rebased on a current main branch.
  - Added more clarifications to the commit message.

I added the stable in CC, but the patch should be extended while
backporting.  For 21.11 the cnxk driver should be also updated,
for 20.11, sfc driver should also be included.

 doc/guides/nics/features/bnxt.ini   | 4 ++--
 doc/guides/nics/features/cxgbe.ini  | 4 ++--
 doc/guides/nics/features/dpaa2.ini  | 4 ++--
 doc/guides/nics/features/e1000.ini  | 2 +-
 doc/guides/nics/features/enic.ini   | 4 ++--
 doc/guides/nics/features/hinic.ini  | 2 +-
 doc/guides/nics/features/hns3.ini   | 4 ++--
 doc/guides/nics/features/i40e.ini   | 4 ++--
 doc/guides/nics/features/iavf.ini   | 4 ++--
 doc/guides/nics/features/ice.ini| 4 ++--
 doc/guides/nics/features/igc.ini| 2 +-
 doc/guides/nics/features/ipn3ke.ini | 4 ++--
 doc/guides/nics/features/ixgbe.ini  | 4 ++--
 doc/guides/nics/features/mlx4.ini   | 4 ++--
 doc/guides/nics/features/mvpp2.ini  | 4 ++--
 doc/guides/nics/features/tap.ini| 4 ++--
 doc/guides/nics/features/txgbe.ini  | 4 ++--
 17 files changed, 31 insertions(+), 31 deletions(-)

diff --git a/doc/guides/nics/features/bnxt.ini 
b/doc/guides/nics/features/bnxt.ini
index b2d54f06aa..50a0b5bfa6 100644
--- a/doc/guides/nics/features/bnxt.ini
+++ b/doc/guides/nics/features/bnxt.ini
@@ -57,7 +57,7 @@ Perf doc = Y
 
 [rte_flow items]
 any  = Y
-eth  = Y
+eth  = P
 ipv4 = Y
 ipv6 = Y
 gre  = Y
@@ -68,7 +68,7 @@ port_representor = Y
 represented_port = Y
 tcp  = Y
 udp  = Y
-vlan = Y
+vlan = P
 vxlan= Y
 
 [rte_flow actions]
diff --git a/doc/guides/nics/features/cxgbe.ini 
b/doc/guides/nics/features/cxgbe.ini
index a9dbcd0573..0d67ca8720 100644
--- a/doc/guides/nics/features/cxgbe.ini
+++ b/doc/guides/nics/features/cxgbe.ini
@@ -36,12 +36,12 @@ x86-64   = Y
 Usage doc= Y
 
 [rte_flow items]
-eth  = Y
+eth  = P
 ipv4 = Y
 ipv6 = Y
 tcp  = Y
 udp  = Y
-vlan = Y
+vlan = P
 
 [rte_flow actions]
 count= Y
diff --git a/doc/guides/nics/features/dpaa2.ini 
b/doc/guides/nics/features/dpaa2.ini
index cedc234f26..26dc8c2178 100644
--- a/doc/guides/nics/features/dpaa2.ini
+++ b/doc/guides/nics/features/dpaa2.ini
@@ -31,7 +31,7 @@ ARMv8= Y
 Usage doc= Y
 
 [rte_flow items]
-eth  = Y
+eth  = P
 gre  = Y
 icmp = Y
 ipv4 = Y
@@ -41,7 +41,7 @@ raw  = Y
 sctp = Y
 tcp  = Y
 udp  = Y
-vlan = Y
+vlan = P
 
 [rte_flow actions]
 drop = Y
diff --git a/doc/guides/nics/features/e1000.ini 
b/doc/guides/nics/features/e1000.ini
index e4bdef6da9..a9cbed1c3c 100644
--- a/doc/guides/nics/features/e1000.ini
+++ b/doc/guides/nics/features/e1000.ini
@@ -31,7 +31,7 @@ x86-32   = Y
 x86-64   = Y
 
 [rte_flow items]
-eth  = Y
+eth  = P
 ipv4 = Y
 ipv6 = Y
 raw  = Y
diff --git a/doc/guides/nics/features/enic.ini 
b/doc/guides/nics/features/enic.ini
index 61bec4910e..6dbea9f36e 100644
--- a/doc/guides/nics/features/enic.ini
+++ b/doc/guides/nics/features/enic.ini
@@ -40,7 +40,7 @@ Usage doc= Y
 
 [rte_flow items]
 ecpri= Y
-eth  = Y
+eth  = P
 geneve   = Y
 geneve_opt   = Y
 gtp  = Y
@@ -52,7 +52,7 @@ raw  = Y
 sctp = Y
 tcp  = Y
 udp  = Y
-vlan = Y
+vlan = P
 vxlan= Y
 
 [rte_flow actions]
diff --git a/doc/guides/nics/features/hinic.ini 
b/doc/guides/nics/features/hinic.ini
index 9f6f0ebf3a..ada6607fe9 10064

Re: [PATCH] doc: fix support table for ETH and VLAN flow items

[Ilya Maximets]

On 10/12/22 17:30, Thomas Monjalon wrote:
> 07/10/2022 13:55, Ilya Maximets:
>> On 10/7/22 13:50, Ilya Maximets wrote:
>>> On 9/12/22 12:09, Thomas Monjalon wrote:
 16/03/2022 13:01, Ilya Maximets:
> 'has_vlan' attribute is only supported by sfc, mlx5 and cnxk.
> Other drivers doesn't support it.  Most of them (like i40e) just
> ignore it silently.  Some drivers (like mlx4) never had a full
> support of the eth item even before introduction of 'has_vlan'
> (mlx4 allows to match on the destination MAC only).
>
> Same for the 'has_more_vlan' flag of the vlan item.
>
> Changing the support level to 'partial' for all such drivers.
> This doesn't solve the issue, but at least marks the problematic
> drivers.

 You changed "eth" and "vlan" from "Y" to "P".
 The field "has_vlan" is part of "rte_flow_item_eth",
 and "has_more_vlan" is part of "rte_flow_item_vlan",
 so I agree we need to change both items to "partial support".
 It looks to be a good change, just needs to more explicit,
 adding this kind of explanation about the fields.
>>>
>>> I can add this to the commit message.  Should I also add
>>> some note alongside the table in that documentation page?
> 
> I'm afraid it can be long and complex to add notes in the page
> about what is missing to get complete support for each feature/PMD.
> I think you can just re-spin with a clear explanation in the commit,
> so PMD maintainers can refer to it.

OK.  v2 sent here:
  
https://patches.dpdk.org/project/dpdk/patch/20221013104849.2677995-1-i.maxim...@ovn.org/

Sorry, forgot about --in-reply-to.  Can re-post if necessary.

> 
 We missed this patch in 22.07, let's have some progress quickly.
>>>
>>> It was a busy month + PTO, sorry I didn't get to that patch faster.
> 
> No problem, we are still on time for 22.11.
> 
> Some details are available in:
>   https://bugs.dpdk.org/show_bug.cgi?id=958

 About rte_flow_item_eth.{src,dst}, I don't find a deprecation notice
 about it in the history of the file doc/guides/rel_notes/deprecation.rst
>>>
>>> It took some time to find the deprecation notice, but I did find it
>>> in the end.  It's in the doc/guides/rel_notes/deprecation.rst, and
>>> it says:
>>>
>>> * ethdev: The flow API matching pattern structures, ``struct 
>>> rte_flow_item_*``,
>>>   should start with relevant protocol header.
>>>   Some matching pattern structures implements this by duplicating protocol 
>>> header
>>>   fields in the struct. To clarify the intention and to be sure protocol 
>>> header
>>>   is intact, will replace those fields with relevant protocol header struct.
>>>   In v21.02 both individual protocol header fields and the protocol header 
>>> struct
>>>   will be added as union, target is switch usage to the protocol header by 
>>> time.
>>>   In v21.11 LTS, protocol header fields will be cleaned and only protocol 
>>> header
>>>   struct will remain.
> 
> You're right, this is the general notice for rte_flow_item_*.
> 
 This is what we have in the code:
 union {
 struct {
 /*
  * These fields are retained for compatibility.
  * Please switch to the new header field below.
  */
 struct rte_ether_addr dst; /**< Destination MAC. */
 struct rte_ether_addr src; /**< Source MAC. */
 rte_be16_t type; /**< EtherType or TPID. */
 };
 struct rte_ether_hdr hdr;
 };

 Do you think we should remove the old fields now?
>>>
>>> From the OVS perspective, we do not care much.  OVS is still using
>>> old fields, but it's fairly simple change that we can do while moving
>>> to a new version of DPDK.
>>>
>>> From the perspective of the API clarity, it's probably better to clean
>>> up these structures.
>>
>> There seems to be some outstanding work still though:
>>   
>> https://patches.dpdk.org/project/dpdk/patch/20210312110745.31721-1-ivan.ma...@oktetlabs.ru/#129161
> 
> I think nobody took care of it so far.
> I will send a patch to clean the easy ones,
> and I will follow up with Ori for a complete plan.
> 
> Thanks
> 
> 

[PATCH v2] eventdev: increase xstats ID width to 64 bits

[pbhagavatula]

From: Pavan Nikhilesh 

Increase xstats ID width from 32 to 64 bits. This also
fixes the xstats ID datatype discrepancy between reset and
rest of the xstats family.

Signed-off-by: Pavan Nikhilesh 
Acked-by: Morten Brørup 
Reviewed-by: Mattias Rönnblom 
---
 v2 Changes:
 - Fix compilation on 32 bit platforms. (Mattias)

 doc/guides/rel_notes/release_22_11.rst   |   5 ++
 drivers/event/cnxk/cnxk_eventdev.h   |   6 +-
 drivers/event/cnxk/cnxk_eventdev_stats.c |   6 +-
 drivers/event/dlb2/dlb2_priv.h   |   8 +-
 drivers/event/dlb2/dlb2_xstats.c |  18 ++--
 drivers/event/dsw/dsw_evdev.h|   6 +-
 drivers/event/dsw/dsw_xstats.c   |  32 +++
 drivers/event/opdl/opdl_evdev.h  |   8 +-
 drivers/event/opdl/opdl_evdev_xstats.c   |   8 +-
 drivers/event/opdl/opdl_test.c   |   4 +-
 drivers/event/sw/sw_evdev.h  |   8 +-
 drivers/event/sw/sw_evdev_selftest.c | 101 +++
 drivers/event/sw/sw_evdev_xstats.c   |  18 ++--
 lib/eventdev/eventdev_pmd.h  |   8 +-
 lib/eventdev/rte_eventdev.c  |  12 +--
 lib/eventdev/rte_eventdev.h  |   8 +-
 16 files changed, 128 insertions(+), 128 deletions(-)

diff --git a/doc/guides/rel_notes/release_22_11.rst 
b/doc/guides/rel_notes/release_22_11.rst
index 2da8bc9661..6b76ad5566 100644
--- a/doc/guides/rel_notes/release_22_11.rst
+++ b/doc/guides/rel_notes/release_22_11.rst
@@ -454,6 +454,11 @@ API Changes

 * raw/ifgpa: The function ``rte_pmd_ifpga_get_pci_bus`` has been removed.

+* eventdev: The datatype of the ID parameter in the functions
+  ``rte_event_dev_xstats_names_get``, ``rte_event_dev_xstats_get``,
+  ``rte_event_dev_xstats_by_name_get`` and ``rte_event_dev_xstats_reset``
+  is changed to ``uint64_t`` from ``unsigned int`` and ``uint32_t``.
+

 ABI Changes
 ---
diff --git a/drivers/event/cnxk/cnxk_eventdev.h 
b/drivers/event/cnxk/cnxk_eventdev.h
index f68c2aee23..738e335ea4 100644
--- a/drivers/event/cnxk/cnxk_eventdev.h
+++ b/drivers/event/cnxk/cnxk_eventdev.h
@@ -271,14 +271,14 @@ int cnxk_sso_xstats_get_names(const struct rte_eventdev 
*event_dev,
  enum rte_event_dev_xstats_mode mode,
  uint8_t queue_port_id,
  struct rte_event_dev_xstats_name *xstats_names,
- unsigned int *ids, unsigned int size);
+ uint64_t *ids, unsigned int size);
 int cnxk_sso_xstats_get(const struct rte_eventdev *event_dev,
enum rte_event_dev_xstats_mode mode,
-   uint8_t queue_port_id, const unsigned int ids[],
+   uint8_t queue_port_id, const uint64_t ids[],
uint64_t values[], unsigned int n);
 int cnxk_sso_xstats_reset(struct rte_eventdev *event_dev,
  enum rte_event_dev_xstats_mode mode,
- int16_t queue_port_id, const uint32_t ids[],
+ int16_t queue_port_id, const uint64_t ids[],
  uint32_t n);

 /* CN9K */
diff --git a/drivers/event/cnxk/cnxk_eventdev_stats.c 
b/drivers/event/cnxk/cnxk_eventdev_stats.c
index a3b548f462..715ca9cd8f 100644
--- a/drivers/event/cnxk/cnxk_eventdev_stats.c
+++ b/drivers/event/cnxk/cnxk_eventdev_stats.c
@@ -103,7 +103,7 @@ static struct cnxk_sso_xstats_name sso_hwgrp_xstats[] = {
 int
 cnxk_sso_xstats_get(const struct rte_eventdev *event_dev,
enum rte_event_dev_xstats_mode mode, uint8_t queue_port_id,
-   const unsigned int ids[], uint64_t values[], unsigned int n)
+   const uint64_t ids[], uint64_t values[], unsigned int n)
 {
struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev);
struct roc_sso_hwgrp_stats hwgrp_stats;
@@ -170,7 +170,7 @@ cnxk_sso_xstats_get(const struct rte_eventdev *event_dev,
 int
 cnxk_sso_xstats_reset(struct rte_eventdev *event_dev,
  enum rte_event_dev_xstats_mode mode,
- int16_t queue_port_id, const uint32_t ids[], uint32_t n)
+ int16_t queue_port_id, const uint64_t ids[], uint32_t n)
 {
struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev);
struct roc_sso_hwgrp_stats hwgrp_stats;
@@ -235,7 +235,7 @@ cnxk_sso_xstats_get_names(const struct rte_eventdev 
*event_dev,
  enum rte_event_dev_xstats_mode mode,
  uint8_t queue_port_id,
  struct rte_event_dev_xstats_name *xstats_names,
- unsigned int *ids, unsigned int size)
+ uint64_t *ids, unsigned int size)
 {
struct rte_event_dev_xstats_name xstats_names_copy[CNXK_SSO_NUM_XSTATS];
struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev);
diff --git a/drivers/event/dlb2/dlb2_priv.h b/drivers/event/dlb2/dlb2_priv.h
index 9ef5bcb901..52f0ab9935 100644
--- a/drive

[PATCH v2 02/13] common/cnxk: add devargs for soft expiry poll frequency

[Nithin Dabilpuram]

Add support to override soft expiry poll frequency via devargs.
Also provide helper API to indicate reassembly support on a chip
and documentation for devargs that are already present.

Fixes: 780b9c89241b ("net/cnxk: support zero AURA for inline meta")

Signed-off-by: Nithin Dabilpuram 
---
 doc/guides/nics/cnxk.rst  | 39 +++
 drivers/common/cnxk/roc_nix_inl.c |  7 +
 drivers/common/cnxk/roc_nix_inl.h |  3 ++-
 drivers/common/cnxk/roc_nix_inl_dev.c |  4 +--
 drivers/common/cnxk/version.map   |  1 +
 drivers/net/cnxk/cnxk_ethdev_sec.c| 17 +---
 6 files changed, 65 insertions(+), 6 deletions(-)

diff --git a/doc/guides/nics/cnxk.rst b/doc/guides/nics/cnxk.rst
index a1e3a4a965..7da6cb3967 100644
--- a/doc/guides/nics/cnxk.rst
+++ b/doc/guides/nics/cnxk.rst
@@ -494,6 +494,45 @@ Runtime Config Options for inline device
With the above configuration, application can enable inline IPsec processing
for inbound SA with max SPI of 128 for traffic aggregated on inline device.
 
+- ``Count of meta buffers for inline inbound IPsec second pass``
+
+   Number of meta buffers allocated for inline inbound IPsec second pass can
+   be specified by ``nb_meta_bufs`` ``devargs`` parameter. Default value is
+   computed runtime based on pkt mbuf pools created and in use. Number of meta
+   buffers should be at least equal to aggregated number of packet buffers of 
all
+   packet mbuf pools in use by Inline IPsec enabled ethernet devices.
+
+   For example::
+
+  -a 0002:1d:00.0,nb_meta_bufs=1024
+
+   With the above configuration, PMD would enable inline IPsec processing
+   for inbound with 1024 meta buffers available for second pass.
+
+- ``Meta buffer size for inline inbound IPsec second pass``
+
+   Size of meta buffer allocated for inline inbound IPsec second pass can
+   be specified by ``meta_buf_sz`` ``devargs`` parameter. Default value is
+   computed runtime based on pkt mbuf pools created and in use.
+
+   For example::
+
+  -a 0002:1d:00.0,meta_buf_sz=512
+
+   With the above configuration, PMD would allocate meta buffers of size 512 
for
+   inline inbound IPsec processing second pass.
+
+- ``Inline Outbound soft expiry poll frequency in usec`` (default ``100``)
+
+   Soft expiry poll frequency for Inline Outbound sessions can be specified by
+   ``soft_exp_poll_freq`` ``devargs`` parameter.
+
+   For example::
+
+  -a 0002:1d:00.0,soft_exp_poll_freq=1000
+
+   With the above configuration, driver would poll for soft expiry events every
+   1000 usec.
 
 Debugging Options
 -
diff --git a/drivers/common/cnxk/roc_nix_inl.c 
b/drivers/common/cnxk/roc_nix_inl.c
index cdf31b1f0c..213d71e684 100644
--- a/drivers/common/cnxk/roc_nix_inl.c
+++ b/drivers/common/cnxk/roc_nix_inl.c
@@ -480,6 +480,13 @@ nix_inl_rq_mask_cfg(struct roc_nix *roc_nix, bool enable)
return mbox_process(mbox);
 }
 
+bool
+roc_nix_has_reass_support(struct roc_nix *nix)
+{
+   PLT_SET_USED(nix);
+   return !!roc_model_is_cn10ka();
+}
+
 int
 roc_nix_inl_inb_init(struct roc_nix *roc_nix)
 {
diff --git a/drivers/common/cnxk/roc_nix_inl.h 
b/drivers/common/cnxk/roc_nix_inl.h
index 019cf6d28b..c537262819 100644
--- a/drivers/common/cnxk/roc_nix_inl.h
+++ b/drivers/common/cnxk/roc_nix_inl.h
@@ -183,7 +183,7 @@ struct roc_nix_inl_dev {
uint16_t wqe_skip;
uint8_t spb_drop_pc;
uint8_t lpb_drop_pc;
-   bool set_soft_exp_poll;
+   uint32_t soft_exp_poll_freq; /* Polling disabled if 0 */
uint32_t nb_meta_bufs;
uint32_t meta_buf_sz;
/* End of input parameters */
@@ -229,6 +229,7 @@ int __roc_api roc_nix_inl_ts_pkind_set(struct roc_nix 
*roc_nix, bool ts_ena,
   bool inb_inl_dev);
 int __roc_api roc_nix_inl_rq_ena_dis(struct roc_nix *roc_nix, bool ena);
 int __roc_api roc_nix_inl_meta_aura_check(struct roc_nix_rq *rq);
+bool __roc_api roc_nix_has_reass_support(struct roc_nix *nix);
 
 /* NIX Inline Outbound API */
 int __roc_api roc_nix_inl_outb_init(struct roc_nix *roc_nix);
diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c 
b/drivers/common/cnxk/roc_nix_inl_dev.c
index 4fe7b5180b..c3d94dd0da 100644
--- a/drivers/common/cnxk/roc_nix_inl_dev.c
+++ b/drivers/common/cnxk/roc_nix_inl_dev.c
@@ -789,7 +789,6 @@ nix_inl_outb_poll_thread_setup(struct nix_inl_dev *inl_dev)
 
soft_exp_consumer_cnt = 0;
soft_exp_poll_thread_exit = false;
-   inl_dev->soft_exp_poll_freq = 100;
rc = plt_ctrl_thread_create(&inl_dev->soft_exp_poll_thread,
"OUTB_SOFT_EXP_POLL_THREAD", NULL,
nix_inl_outb_poll_thread, inl_dev);
@@ -839,10 +838,11 @@ roc_nix_inl_dev_init(struct roc_nix_inl_dev *roc_inl_dev)
inl_dev->wqe_skip = roc_inl_dev->wqe_skip;
inl_dev->spb_drop_pc = NIX_AURA_DROP_PC_DFLT;
inl_dev->lpb_drop_pc = NIX_AURA_DROP_PC_DFLT;
-   inl_dev->set_soft_exp_pol

[PATCH v2 01/13] common/cnxk: set MTU size on SDP based on SoC type

[Nithin Dabilpuram]

From: Sathesh Edara 

Set maximum frame size on SDP NIX side to 16KB for T93 A0-B0,
F95N A0 and F95O A0 SOC type. Rest of the SoCs SDP NIX to 64KB.

Signed-off-by: Sathesh Edara 
---
v2:
- Add fixes line in patch 1/13
- Squash patch 8/13 to 7/13 as 7/13 is the patch that introduced the bug
- Add another patch to handle HARD SA expiry event for outbound inline.

 drivers/common/cnxk/hw/nix.h |  1 +
 drivers/common/cnxk/roc_errata.h |  8 
 drivers/common/cnxk/roc_model.h  | 12 
 drivers/common/cnxk/roc_nix.c|  5 -
 4 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/drivers/common/cnxk/hw/nix.h b/drivers/common/cnxk/hw/nix.h
index a5352644ca..425c335bf3 100644
--- a/drivers/common/cnxk/hw/nix.h
+++ b/drivers/common/cnxk/hw/nix.h
@@ -2118,6 +2118,7 @@ struct nix_lso_format {
 #define NIX_CN9K_MAX_HW_FRS 9212UL
 #define NIX_LBK_MAX_HW_FRS  65535UL
 #define NIX_SDP_MAX_HW_FRS  65535UL
+#define NIX_SDP_16K_HW_FRS  16380UL
 #define NIX_RPM_MAX_HW_FRS  16380UL
 #define NIX_MIN_HW_FRS 60UL
 
diff --git a/drivers/common/cnxk/roc_errata.h b/drivers/common/cnxk/roc_errata.h
index d3b32f1786..a39796e894 100644
--- a/drivers/common/cnxk/roc_errata.h
+++ b/drivers/common/cnxk/roc_errata.h
@@ -90,4 +90,12 @@ roc_errata_nix_no_meta_aura(void)
return roc_model_is_cn10ka_a0();
 }
 
+/* Errata IPBUNIXTX-35039 */
+static inline bool
+roc_errata_nix_sdp_send_has_mtu_size_16k(void)
+{
+   return (roc_model_is_cnf95xxn_a0() || roc_model_is_cnf95xxo_a0() ||
+   roc_model_is_cn96_a0() || roc_model_is_cn96_b0());
+}
+
 #endif /* _ROC_ERRATA_H_ */
diff --git a/drivers/common/cnxk/roc_model.h b/drivers/common/cnxk/roc_model.h
index 57a8af06fc..1985dd771d 100644
--- a/drivers/common/cnxk/roc_model.h
+++ b/drivers/common/cnxk/roc_model.h
@@ -140,6 +140,12 @@ roc_model_is_cn96_ax(void)
return (roc_model->flag & ROC_MODEL_CN96xx_Ax);
 }
 
+static inline uint64_t
+roc_model_is_cn96_b0(void)
+{
+   return (roc_model->flag & ROC_MODEL_CN96xx_B0);
+}
+
 static inline uint64_t
 roc_model_is_cn96_cx(void)
 {
@@ -170,6 +176,12 @@ roc_model_is_cnf95xxn_b0(void)
return roc_model->flag & ROC_MODEL_CNF95xxN_B0;
 }
 
+static inline uint64_t
+roc_model_is_cnf95xxo_a0(void)
+{
+   return roc_model->flag & ROC_MODEL_CNF95xxO_A0;
+}
+
 static inline uint16_t
 roc_model_is_cn95xxn_a0(void)
 {
diff --git a/drivers/common/cnxk/roc_nix.c b/drivers/common/cnxk/roc_nix.c
index 4bb306b60e..8fd8ec8461 100644
--- a/drivers/common/cnxk/roc_nix.c
+++ b/drivers/common/cnxk/roc_nix.c
@@ -127,8 +127,11 @@ roc_nix_max_pkt_len(struct roc_nix *roc_nix)
 {
struct nix *nix = roc_nix_to_nix_priv(roc_nix);
 
-   if (roc_nix_is_sdp(roc_nix))
+   if (roc_nix_is_sdp(roc_nix)) {
+   if (roc_errata_nix_sdp_send_has_mtu_size_16k())
+   return NIX_SDP_16K_HW_FRS;
return NIX_SDP_MAX_HW_FRS;
+   }
 
if (roc_model_is_cn9k())
return NIX_CN9K_MAX_HW_FRS;
-- 
2.25.1

[PATCH v2 03/13] net/cnxk: fix later skip to include mbuf priv

[Nithin Dabilpuram]

Fix later skip to include mbuf priv data as mbuf->buf_addr
is populated based on calculation including per-mbuf priv area.

Fixes: 706eeae60757 ("net/cnxk: add multi-segment Rx for CN10K")
cc: sta...@dpdk.org

Signed-off-by: Nithin Dabilpuram 
---
 drivers/net/cnxk/cn10k_rx.h| 4 +++-
 drivers/net/cnxk/cnxk_ethdev.c | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h
index 46488d442e..cf390a0361 100644
--- a/drivers/net/cnxk/cn10k_rx.h
+++ b/drivers/net/cnxk/cn10k_rx.h
@@ -682,6 +682,7 @@ nix_cqe_xtract_mseg(const union nix_rx_parse_u *rx, struct 
rte_mbuf *mbuf,
uint64_t rearm, const uint16_t flags)
 {
const rte_iova_t *iova_list;
+   uint16_t later_skip = 0;
struct rte_mbuf *head;
const rte_iova_t *eol;
uint8_t nb_segs;
@@ -720,10 +721,11 @@ nix_cqe_xtract_mseg(const union nix_rx_parse_u *rx, 
struct rte_mbuf *mbuf,
nb_segs--;
 
rearm = rearm & ~0x;
+   later_skip = (uintptr_t)mbuf->buf_addr - (uintptr_t)mbuf;
 
head = mbuf;
while (nb_segs) {
-   mbuf->next = ((struct rte_mbuf *)*iova_list) - 1;
+   mbuf->next = (struct rte_mbuf *)(*iova_list - later_skip);
mbuf = mbuf->next;
 
RTE_MEMPOOL_CHECK_COOKIES(mbuf->pool, (void **)&mbuf, 1, 1);
diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c
index 71c3f1666b..bf1585fe67 100644
--- a/drivers/net/cnxk/cnxk_ethdev.c
+++ b/drivers/net/cnxk/cnxk_ethdev.c
@@ -680,7 +680,7 @@ cnxk_nix_rx_queue_setup(struct rte_eth_dev *eth_dev, 
uint16_t qid,
first_skip += RTE_PKTMBUF_HEADROOM;
first_skip += rte_pktmbuf_priv_size(lpb_pool);
rq->first_skip = first_skip;
-   rq->later_skip = sizeof(struct rte_mbuf);
+   rq->later_skip = sizeof(struct rte_mbuf) + rte_pktmbuf_priv_size(mp);
rq->lpb_size = lpb_pool->elt_size;
if (roc_errata_nix_no_meta_aura())
rq->lpb_drop_ena = !(dev->rx_offloads & 
RTE_ETH_RX_OFFLOAD_SECURITY);
-- 
2.25.1

[PATCH v2 04/13] net/cnxk: use NIX Tx offset for cn10kb

[Nithin Dabilpuram]

In outbound inline case, use NIX Tx offset instead of
NIX Tx address for CN103XX as per new instruction format.

Signed-off-by: Nithin Dabilpuram 
---
 drivers/common/cnxk/roc_constants.h | 1 +
 drivers/event/cnxk/cn10k_worker.h   | 3 +++
 drivers/net/cnxk/cn10k_ethdev.c | 6 ++
 drivers/net/cnxk/cn10k_ethdev.h | 3 ++-
 drivers/net/cnxk/cn10k_ethdev_sec.c | 2 ++
 drivers/net/cnxk/cn10k_tx.h | 4 ++--
 6 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/drivers/common/cnxk/roc_constants.h 
b/drivers/common/cnxk/roc_constants.h
index c693dde62e..0495965daa 100644
--- a/drivers/common/cnxk/roc_constants.h
+++ b/drivers/common/cnxk/roc_constants.h
@@ -12,6 +12,7 @@
 /* [CN10K, .) */
 #define ROC_LMT_LINE_SZ128
 #define ROC_NUM_LMT_LINES  2048
+#define ROC_LMT_LINES_PER_STR_LOG2  4
 #define ROC_LMT_LINES_PER_CORE_LOG2 5
 #define ROC_LMT_LINE_SIZE_LOG2 7
 #define ROC_LMT_BASE_PER_CORE_LOG2 
\
diff --git a/drivers/event/cnxk/cn10k_worker.h 
b/drivers/event/cnxk/cn10k_worker.h
index 7a82dd352a..75a2ff244a 100644
--- a/drivers/event/cnxk/cn10k_worker.h
+++ b/drivers/event/cnxk/cn10k_worker.h
@@ -595,6 +595,9 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct rte_mbuf 
*m, uint64_t *cmd,
ws->gw_rdata = roc_sso_hws_head_wait(ws->base);
 
cn10k_sso_txq_fc_wait(txq);
+   if (flags & NIX_TX_OFFLOAD_SECURITY_F && sec)
+   cn10k_nix_sec_fc_wait_one(txq);
+
roc_lmt_submit_steorl(lmt_id, pa);
 
if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) {
diff --git a/drivers/net/cnxk/cn10k_ethdev.c b/drivers/net/cnxk/cn10k_ethdev.c
index 0b33b3a496..4658713591 100644
--- a/drivers/net/cnxk/cn10k_ethdev.c
+++ b/drivers/net/cnxk/cn10k_ethdev.c
@@ -538,6 +538,9 @@ cn10k_nix_reassembly_capability_get(struct rte_eth_dev 
*eth_dev,
int rc = -ENOTSUP;
RTE_SET_USED(eth_dev);
 
+   if (!roc_nix_has_reass_support(&dev->nix))
+   return -ENOTSUP;
+
if (dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SECURITY) {
reassembly_capa->timeout_ms = 60 * 1000;
reassembly_capa->max_frags = 4;
@@ -565,6 +568,9 @@ cn10k_nix_reassembly_conf_set(struct rte_eth_dev *eth_dev,
struct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);
int rc = 0;
 
+   if (!roc_nix_has_reass_support(&dev->nix))
+   return -ENOTSUP;
+
if (!conf->flags) {
/* Clear offload flags on disable */
dev->rx_offload_flags &= ~NIX_RX_REAS_F;
diff --git a/drivers/net/cnxk/cn10k_ethdev.h b/drivers/net/cnxk/cn10k_ethdev.h
index d0a5b136e3..948c8348ad 100644
--- a/drivers/net/cnxk/cn10k_ethdev.h
+++ b/drivers/net/cnxk/cn10k_ethdev.h
@@ -75,7 +75,8 @@ struct cn10k_sec_sess_priv {
uint16_t partial_len : 10;
uint16_t chksum : 2;
uint16_t dec_ttl : 1;
-   uint16_t rsvd : 3;
+   uint16_t nixtx_off : 1;
+   uint16_t rsvd : 2;
};
 
uint64_t u64;
diff --git a/drivers/net/cnxk/cn10k_ethdev_sec.c 
b/drivers/net/cnxk/cn10k_ethdev_sec.c
index 6de4a284da..3ca707f038 100644
--- a/drivers/net/cnxk/cn10k_ethdev_sec.c
+++ b/drivers/net/cnxk/cn10k_ethdev_sec.c
@@ -798,6 +798,8 @@ cn10k_eth_sec_session_create(void *device,
sess_priv.chksum = (!ipsec->options.ip_csum_enable << 1 |
!ipsec->options.l4_csum_enable);
sess_priv.dec_ttl = ipsec->options.dec_ttl;
+   if (roc_model_is_cn10kb_a0())
+   sess_priv.nixtx_off = 1;
 
/* Pointer from eth_sec -> outb_sa */
eth_sec->sa = outb_sa;
diff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h
index 36fa96f83f..d375183f90 100644
--- a/drivers/net/cnxk/cn10k_tx.h
+++ b/drivers/net/cnxk/cn10k_tx.h
@@ -397,7 +397,7 @@ cn10k_nix_prep_sec_vec(struct rte_mbuf *m, uint64x2_t 
*cmd0, uint64x2_t *cmd1,
/* DLEN passed is excluding L2 HDR */
pkt_len -= l2_len;
}
-   w0 |= nixtx;
+   w0 |= sess_priv.nixtx_off ? int64_t)nixtx - (int64_t)dptr) & 
0xF) << 32) : nixtx;
/* CPT word 0 and 1 */
cmd01 = vdupq_n_u64(0);
cmd01 = vsetq_lane_u64(w0, cmd01, 0);
@@ -539,7 +539,7 @@ cn10k_nix_prep_sec(struct rte_mbuf *m, uint64_t *cmd, 
uintptr_t *nixtx_addr,
sg->seg1_size = pkt_len + dlen_adj;
pkt_len -= l2_len;
}
-   w0 |= nixtx;
+   w0 |= sess_priv.nixtx_off ? int64_t)nixtx - (int64_t)dptr) & 
0xF) << 32) : nixtx;
/* CPT word 0 and 1 */
cmd01 = vdupq_n_u64(0);
cmd01 = vsetq_lane_u64(w0, cmd01, 0);
-- 
2.25.1

[PATCH v2 05/13] common/cnxk: fix RQ mask config for cn10kb chip

[Nithin Dabilpuram]

RQ mask config needs to enable SPB_ENA in order for Zero for
being able to override it with Meta aura.

Also fix flow control config to catch invalid rxchan config
errors.

Fixes: ddf955d3917e ("common/cnxk: support CPT second pass")
Fixes: da57d4589a6f ("common/cnxk: support NIX flow control")

Signed-off-by: Nithin Dabilpuram 
---
 drivers/common/cnxk/roc_nix_fc.c  |  4 ++-
 drivers/common/cnxk/roc_nix_inl.c | 43 +--
 2 files changed, 26 insertions(+), 21 deletions(-)

diff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c
index f4cfa11c0f..033e17a4bf 100644
--- a/drivers/common/cnxk/roc_nix_fc.c
+++ b/drivers/common/cnxk/roc_nix_fc.c
@@ -52,8 +52,10 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool enable)
req->bpid_per_chan = true;
 
rc = mbox_process_msg(mbox, (void *)&rsp);
-   if (rc || (req->chan_cnt != rsp->chan_cnt))
+   if (rc || (req->chan_cnt != rsp->chan_cnt)) {
+   rc = -EIO;
goto exit;
+   }
 
nix->chan_cnt = rsp->chan_cnt;
for (i = 0; i < rsp->chan_cnt; i++)
diff --git a/drivers/common/cnxk/roc_nix_inl.c 
b/drivers/common/cnxk/roc_nix_inl.c
index 213d71e684..0da097c9e9 100644
--- a/drivers/common/cnxk/roc_nix_inl.c
+++ b/drivers/common/cnxk/roc_nix_inl.c
@@ -454,27 +454,29 @@ nix_inl_rq_mask_cfg(struct roc_nix *roc_nix, bool enable)
msk_req->rq_set.lpb_drop_ena = 0;
msk_req->rq_set.spb_drop_ena = 0;
msk_req->rq_set.xqe_drop_ena = 0;
+   msk_req->rq_set.spb_ena = 1;
 
-   msk_req->rq_mask.len_ol3_dis = ~(msk_req->rq_set.len_ol3_dis);
-   msk_req->rq_mask.len_ol4_dis = ~(msk_req->rq_set.len_ol4_dis);
-   msk_req->rq_mask.len_il3_dis = ~(msk_req->rq_set.len_il3_dis);
+   msk_req->rq_mask.len_ol3_dis = 0;
+   msk_req->rq_mask.len_ol4_dis = 0;
+   msk_req->rq_mask.len_il3_dis = 0;
 
-   msk_req->rq_mask.len_il4_dis = ~(msk_req->rq_set.len_il4_dis);
-   msk_req->rq_mask.csum_ol4_dis = ~(msk_req->rq_set.csum_ol4_dis);
-   msk_req->rq_mask.csum_il4_dis = ~(msk_req->rq_set.csum_il4_dis);
+   msk_req->rq_mask.len_il4_dis = 0;
+   msk_req->rq_mask.csum_ol4_dis = 0;
+   msk_req->rq_mask.csum_il4_dis = 0;
 
-   msk_req->rq_mask.lenerr_dis = ~(msk_req->rq_set.lenerr_dis);
-   msk_req->rq_mask.port_ol4_dis = ~(msk_req->rq_set.port_ol4_dis);
-   msk_req->rq_mask.port_il4_dis = ~(msk_req->rq_set.port_il4_dis);
+   msk_req->rq_mask.lenerr_dis = 0;
+   msk_req->rq_mask.port_ol4_dis = 0;
+   msk_req->rq_mask.port_il4_dis = 0;
 
-   msk_req->rq_mask.lpb_drop_ena = ~(msk_req->rq_set.lpb_drop_ena);
-   msk_req->rq_mask.spb_drop_ena = ~(msk_req->rq_set.spb_drop_ena);
-   msk_req->rq_mask.xqe_drop_ena = ~(msk_req->rq_set.xqe_drop_ena);
+   msk_req->rq_mask.lpb_drop_ena = 0;
+   msk_req->rq_mask.spb_drop_ena = 0;
+   msk_req->rq_mask.xqe_drop_ena = 0;
+   msk_req->rq_mask.spb_ena = 0;
 
aura_handle = roc_npa_zero_aura_handle();
msk_req->ipsec_cfg1.spb_cpt_aura = 
roc_npa_aura_handle_to_aura(aura_handle);
msk_req->ipsec_cfg1.rq_mask_enable = enable;
-   msk_req->ipsec_cfg1.spb_cpt_sizem1 = inl_cfg->buf_sz;
+   msk_req->ipsec_cfg1.spb_cpt_sizem1 = (inl_cfg->buf_sz >> 7) - 1;
msk_req->ipsec_cfg1.spb_cpt_enable = enable;
 
return mbox_process(mbox);
@@ -544,13 +546,6 @@ roc_nix_inl_inb_init(struct roc_nix *roc_nix)
idev->inl_cfg.refs++;
}
 
-   if (roc_model_is_cn10kb_a0()) {
-   rc = nix_inl_rq_mask_cfg(roc_nix, true);
-   if (rc) {
-   plt_err("Failed to get rq mask rc=%d", rc);
-   return rc;
-   }
-   }
nix->inl_inb_ena = true;
return 0;
 }
@@ -1043,6 +1038,14 @@ roc_nix_inl_rq_ena_dis(struct roc_nix *roc_nix, bool 
enable)
if (!idev)
return -EFAULT;
 
+   if (roc_model_is_cn10kb_a0()) {
+   rc = nix_inl_rq_mask_cfg(roc_nix, true);
+   if (rc) {
+   plt_err("Failed to get rq mask rc=%d", rc);
+   return rc;
+   }
+   }
+
if (nix->inb_inl_dev) {
if (!inl_rq || !idev->nix_inl_dev)
return -EFAULT;
-- 
2.25.1

[PATCH v2 06/13] common/cnxk: fix schedule weight update

[Nithin Dabilpuram]

From: Satha Rao 

Each TX schedule config mail box supports maximum 20 register updates.
This patch will send node weight updates in multiple mailbox when
TM created with more than 20 scheduler nodes.

Fixes: 464c9f919321 ("common/cnxk: support NIX TM dynamic update")
Cc: ndabilpu...@marvell.com

Signed-off-by: Satha Rao 
---
 drivers/common/cnxk/roc_nix_queue.c  |  2 +-
 drivers/common/cnxk/roc_nix_tm_ops.c | 60 ++--
 2 files changed, 41 insertions(+), 21 deletions(-)

diff --git a/drivers/common/cnxk/roc_nix_queue.c 
b/drivers/common/cnxk/roc_nix_queue.c
index 368f1a52f7..7318f26b57 100644
--- a/drivers/common/cnxk/roc_nix_queue.c
+++ b/drivers/common/cnxk/roc_nix_queue.c
@@ -916,7 +916,7 @@ sqb_pool_populate(struct roc_nix *roc_nix, struct 
roc_nix_sq *sq)
nb_sqb_bufs += NIX_SQB_LIST_SPACE;
/* Clamp up the SQB count */
nb_sqb_bufs = PLT_MIN(roc_nix->max_sqb_count,
- PLT_MAX(NIX_DEF_SQB, nb_sqb_bufs));
+ (uint16_t)PLT_MAX(NIX_DEF_SQB, nb_sqb_bufs));
 
sq->nb_sqb_bufs = nb_sqb_bufs;
sq->sqes_per_sqb_log2 = (uint16_t)plt_log2_u32(sqes_per_sqb);
diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c 
b/drivers/common/cnxk/roc_nix_tm_ops.c
index 7036495ad8..4bf7b1e104 100644
--- a/drivers/common/cnxk/roc_nix_tm_ops.c
+++ b/drivers/common/cnxk/roc_nix_tm_ops.c
@@ -891,19 +891,29 @@ roc_nix_tm_node_parent_update(struct roc_nix *roc_nix, 
uint32_t node_id,
TAILQ_FOREACH(sibling, list, node) {
if (sibling->parent != node->parent)
continue;
-   k += nix_tm_sw_xoff_prep(sibling, true, &req->reg[k],
-&req->regval[k]);
+   k += nix_tm_sw_xoff_prep(sibling, true, &req->reg[k], 
&req->regval[k]);
+   if (k >= MAX_REGS_PER_MBOX_MSG) {
+   req->num_regs = k;
+   rc = mbox_process(mbox);
+   if (rc)
+   return rc;
+   k = 0;
+   req = mbox_alloc_msg_nix_txschq_cfg(mbox);
+   req->lvl = node->hw_lvl;
+   }
+   }
+
+   if (k) {
+   req->num_regs = k;
+   rc = mbox_process(mbox);
+   if (rc)
+   return rc;
+   /* Update new weight for current node */
+   req = mbox_alloc_msg_nix_txschq_cfg(mbox);
}
-   req->num_regs = k;
-   rc = mbox_process(mbox);
-   if (rc)
-   return rc;
 
-   /* Update new weight for current node */
-   req = mbox_alloc_msg_nix_txschq_cfg(mbox);
req->lvl = node->hw_lvl;
-   req->num_regs =
-   nix_tm_sched_reg_prep(nix, node, req->reg, req->regval);
+   req->num_regs = nix_tm_sched_reg_prep(nix, node, req->reg, 
req->regval);
rc = mbox_process(mbox);
if (rc)
return rc;
@@ -916,19 +926,29 @@ roc_nix_tm_node_parent_update(struct roc_nix *roc_nix, 
uint32_t node_id,
TAILQ_FOREACH(sibling, list, node) {
if (sibling->parent != node->parent)
continue;
-   k += nix_tm_sw_xoff_prep(sibling, false, &req->reg[k],
-&req->regval[k]);
+   k += nix_tm_sw_xoff_prep(sibling, false, &req->reg[k], 
&req->regval[k]);
+   if (k >= MAX_REGS_PER_MBOX_MSG) {
+   req->num_regs = k;
+   rc = mbox_process(mbox);
+   if (rc)
+   return rc;
+   k = 0;
+   req = mbox_alloc_msg_nix_txschq_cfg(mbox);
+   req->lvl = node->hw_lvl;
+   }
+   }
+
+   if (k) {
+   req->num_regs = k;
+   rc = mbox_process(mbox);
+   if (rc)
+   return rc;
+   /* XON Parent node */
+   req = mbox_alloc_msg_nix_txschq_cfg(mbox);
}
-   req->num_regs = k;
-   rc = mbox_process(mbox);
-   if (rc)
-   return rc;
 
-   /* XON Parent node */
-   req = mbox_alloc_msg_nix_txschq_cfg(mbox);
req->lvl = node->parent->hw_lvl;
-   req->num_regs = nix_tm_sw_xoff_prep(node->parent, false,
- 

[PATCH v2 07/13] common/cnxk: sync NIX HW info mbox structure with kernel

[Nithin Dabilpuram]

From: Satha Rao 

Sync nix_hw_info structure with kernel.

Maintain default RR_QUANTUM for VF TL2 same as kernel to make
equal distribution among all VFs.

Signed-off-by: Satha Rao 
---
 drivers/common/cnxk/roc_mbox.h |  8 +-
 drivers/common/cnxk/roc_nix.c  |  9 ++-
 drivers/common/cnxk/roc_nix.h  |  1 +
 drivers/common/cnxk/roc_nix_tm.c   |  4 ---
 drivers/common/cnxk/roc_nix_tm_utils.c | 34 +-
 5 files changed, 44 insertions(+), 12 deletions(-)

diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h
index a47e6a8f3b..e8d4ae283d 100644
--- a/drivers/common/cnxk/roc_mbox.h
+++ b/drivers/common/cnxk/roc_mbox.h
@@ -1215,7 +1215,13 @@ struct nix_inline_ipsec_lf_cfg {
 struct nix_hw_info {
struct mbox_msghdr hdr;
uint16_t __io vwqe_delay;
-   uint16_t __io rsvd[15];
+   uint16_t __io max_mtu;
+   uint16_t __io min_mtu;
+   uint32_t __io rpm_dwrr_mtu;
+   uint32_t __io sdp_dwrr_mtu;
+   uint32_t __io lbk_dwrr_mtu;
+   uint32_t __io rsvd32[1];
+   uint64_t __io rsvd[15]; /* Add reserved fields for future expansion */
 };
 
 struct nix_bandprof_alloc_req {
diff --git a/drivers/common/cnxk/roc_nix.c b/drivers/common/cnxk/roc_nix.c
index 8fd8ec8461..2a320cc291 100644
--- a/drivers/common/cnxk/roc_nix.c
+++ b/drivers/common/cnxk/roc_nix.c
@@ -303,8 +303,15 @@ roc_nix_get_hw_info(struct roc_nix *roc_nix)
 
mbox_alloc_msg_nix_get_hw_info(mbox);
rc = mbox_process_msg(mbox, (void *)&hw_info);
-   if (rc == 0)
+   if (rc == 0) {
nix->vwqe_interval = hw_info->vwqe_delay;
+   if (nix->lbk_link)
+   roc_nix->dwrr_mtu = hw_info->lbk_dwrr_mtu;
+   else if (nix->sdp_link)
+   roc_nix->dwrr_mtu = hw_info->sdp_dwrr_mtu;
+   else
+   roc_nix->dwrr_mtu = hw_info->rpm_dwrr_mtu;
+   }
 
return rc;
 }
diff --git a/drivers/common/cnxk/roc_nix.h b/drivers/common/cnxk/roc_nix.h
index 34cb2c717c..6636ee52c1 100644
--- a/drivers/common/cnxk/roc_nix.h
+++ b/drivers/common/cnxk/roc_nix.h
@@ -426,6 +426,7 @@ struct roc_nix {
uint32_t ipsec_in_min_spi;
uint32_t ipsec_in_max_spi;
uint32_t ipsec_out_max_sa;
+   uint32_t dwrr_mtu;
bool ipsec_out_sso_pffunc;
bool custom_sa_action;
/* End of input parameters */
diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c
index 81fa6b1d93..be8da714cd 100644
--- a/drivers/common/cnxk/roc_nix_tm.c
+++ b/drivers/common/cnxk/roc_nix_tm.c
@@ -256,10 +256,6 @@ nix_tm_node_add(struct roc_nix *roc_nix, struct 
nix_tm_node *node)
if (node->weight > roc_nix_tm_max_sched_wt_get())
return NIX_ERR_TM_WEIGHT_EXCEED;
 
-   /* Maintain minimum weight */
-   if (!node->weight)
-   node->weight = 1;
-
node->hw_lvl = nix_tm_lvl2nix(nix, lvl);
node->rr_prio = 0xF;
node->max_prio = UINT32_MAX;
diff --git a/drivers/common/cnxk/roc_nix_tm_utils.c 
b/drivers/common/cnxk/roc_nix_tm_utils.c
index 193f9df5ff..d33e793664 100644
--- a/drivers/common/cnxk/roc_nix_tm_utils.c
+++ b/drivers/common/cnxk/roc_nix_tm_utils.c
@@ -644,9 +644,25 @@ nix_tm_topology_reg_prep(struct nix *nix, struct 
nix_tm_node *node,
return k;
 }
 
+static inline int
+nix_tm_default_rr_weight(struct nix *nix)
+{
+   struct roc_nix *roc_nix = nix_priv_to_roc_nix(nix);
+   uint32_t max_pktlen = roc_nix_max_pkt_len(roc_nix);
+   uint32_t weight;
+
+   /* Reduce TX VTAG Insertions */
+   max_pktlen -= 8;
+   weight = max_pktlen / roc_nix->dwrr_mtu;
+   if (max_pktlen % roc_nix->dwrr_mtu)
+   weight += 1;
+
+   return weight;
+}
+
 uint8_t
-nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node,
- volatile uint64_t *reg, volatile uint64_t *regval)
+nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node *node, volatile 
uint64_t *reg,
+ volatile uint64_t *regval)
 {
uint64_t strict_prio = node->priority;
uint32_t hw_lvl = node->hw_lvl;
@@ -654,8 +670,14 @@ nix_tm_sched_reg_prep(struct nix *nix, struct nix_tm_node 
*node,
uint64_t rr_quantum;
uint8_t k = 0;
 
-   /* For CN9K, weight needs to be converted to quantum */
-   rr_quantum = nix_tm_weight_to_rr_quantum(node->weight);
+   /* If minimum weight not provided, then by default RR_QUANTUM
+* should be in sync with kernel, i.e., single MTU value
+*/
+   if (!node->weight)
+   rr_quantum = nix_tm_default_rr_weight(nix);
+   else
+   /* For CN9K, weight needs to be converted to quantum */
+   rr_quantum = nix_tm_weight_to_rr_quantum(node->weight);
 
/* For children to root, strict prio is default if either
 * device root is TL2 or TL1 Static Priority is disabled.
@@ -666,8 +688,8 @@

[PATCH v2 08/13] common/cnxk: set hysteresis bit to one

[Nithin Dabilpuram]

From: Satha Rao 

Setting non zero FC_HYST_BITS to reduce mesh traffic on HW.

Signed-off-by: Satha Rao 
---
 drivers/common/cnxk/roc_nix_queue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/common/cnxk/roc_nix_queue.c 
b/drivers/common/cnxk/roc_nix_queue.c
index 7318f26b57..1cb1fd2101 100644
--- a/drivers/common/cnxk/roc_nix_queue.c
+++ b/drivers/common/cnxk/roc_nix_queue.c
@@ -940,7 +940,7 @@ sqb_pool_populate(struct roc_nix *roc_nix, struct 
roc_nix_sq *sq)
else
aura.fc_stype = 0x3; /* STSTP */
aura.fc_addr = (uint64_t)sq->fc;
-   aura.fc_hyst_bits = 0; /* Store count on all updates */
+   aura.fc_hyst_bits = 1; /* Store count on all updates */
rc = roc_npa_pool_create(&sq->aura_handle, blk_sz, nb_sqb_bufs, &aura,
 &pool, 0);
if (rc)
-- 
2.25.1

[PATCH v2 09/13] net/cnxk: handle SA soft packet and byte expiry events

[Nithin Dabilpuram]

From: Vamsi Attunuru 

Handle SA soft packet and byte expiry event for Inline outbound SA.

Signed-off-by: Nithin Dabilpuram 
---
 drivers/net/cnxk/cn10k_ethdev_sec.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/cnxk/cn10k_ethdev_sec.c 
b/drivers/net/cnxk/cn10k_ethdev_sec.c
index 3ca707f038..ce1b10d885 100644
--- a/drivers/net/cnxk/cn10k_ethdev_sec.c
+++ b/drivers/net/cnxk/cn10k_ethdev_sec.c
@@ -428,7 +428,12 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args, 
uint32_t soft_exp_event)
sa = (struct roc_ot_ipsec_outb_sa *)args;
priv = roc_nix_inl_ot_ipsec_outb_sa_sw_rsvd(sa);
desc.metadata = (uint64_t)priv->userdata;
-   desc.subtype = RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY;
+   if (sa->w2.s.life_unit == ROC_IE_OT_SA_LIFE_UNIT_PKTS)
+   desc.subtype =
+   RTE_ETH_EVENT_IPSEC_SA_PKT_EXPIRY;
+   else
+   desc.subtype =
+   RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY;
eth_dev = &rte_eth_devices[soft_exp_event >> 8];
rte_eth_dev_callback_process(eth_dev,
RTE_ETH_EVENT_IPSEC, &desc);
-- 
2.25.1

[PATCH v2 10/13] common/cnxk: sync mailbox for channel and bpid map

[Nithin Dabilpuram]

From: Sunil Kumar Kori 

As per recent change in Linux-5.4.x, mailbox is updated to configure
mapping between channel and BPID. Due to mbox mismatch, PFC was broken.
Patch syncs mailbox definition for the same. Also fixes the PFC
configuration issues.

Signed-off-by: Sunil Kumar Kori 
---
 drivers/common/cnxk/roc_mbox.h | 6 +++---
 drivers/common/cnxk/roc_nix.h  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h
index e8d4ae283d..d47808e5ef 100644
--- a/drivers/common/cnxk/roc_mbox.h
+++ b/drivers/common/cnxk/roc_mbox.h
@@ -1164,10 +1164,10 @@ struct nix_bp_cfg_req {
/* bpid_per_chan = 1 assigns separate bp id for each channel */
 };
 
-/* PF can be mapped to either CGX or LBK interface,
- * so maximum 64 channels are possible.
+/* PF can be mapped to either CGX or LBK or SDP interface,
+ * so maximum 256 channels are possible.
  */
-#define NIX_MAX_CHAN64
+#define NIX_MAX_CHAN256
 #define NIX_CGX_MAX_CHAN 16
 #define NIX_LBK_MAX_CHAN 1
 struct nix_bp_cfg_rsp {
diff --git a/drivers/common/cnxk/roc_nix.h b/drivers/common/cnxk/roc_nix.h
index 6636ee52c1..6654a2df78 100644
--- a/drivers/common/cnxk/roc_nix.h
+++ b/drivers/common/cnxk/roc_nix.h
@@ -436,7 +436,7 @@ struct roc_nix {
bool rx_ptp_ena;
uint16_t cints;
 
-#define ROC_NIX_MEM_SZ (6 * 1024)
+#define ROC_NIX_MEM_SZ (6 * 1056)
uint8_t reserved[ROC_NIX_MEM_SZ] __plt_cache_aligned;
 } __plt_cache_aligned;
 
-- 
2.25.1

[PATCH v2 11/13] net/cnxk: remove unnecessary dptr update

[Nithin Dabilpuram]

Also remove ESN update from ucode command word 0 based on
latest ucode.

Signed-off-by: Nithin Dabilpuram 
Signed-off-by: Vidya Sagar Velumuri 
---
 drivers/event/cnxk/cn9k_worker.h | 1 -
 drivers/net/cnxk/cn10k_tx.h  | 4 
 2 files changed, 5 deletions(-)

diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h
index 881861f348..4c3932da47 100644
--- a/drivers/event/cnxk/cn9k_worker.h
+++ b/drivers/event/cnxk/cn9k_worker.h
@@ -718,7 +718,6 @@ cn9k_sso_hws_xmit_sec_one(const struct cn9k_eth_txq *txq, 
uint64_t base,
esn = outb_priv->esn;
outb_priv->esn = esn + 1;
 
-   ucode_cmd[0] |= (esn >> 32) << 16;
esn_lo = rte_cpu_to_be_32(esn & (BIT_ULL(32) - 1));
esn_hi = rte_cpu_to_be_32(esn >> 32);
 
diff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h
index d375183f90..815cd2ff1f 100644
--- a/drivers/net/cnxk/cn10k_tx.h
+++ b/drivers/net/cnxk/cn10k_tx.h
@@ -422,8 +422,6 @@ cn10k_nix_prep_sec_vec(struct rte_mbuf *m, uint64x2_t 
*cmd0, uint64x2_t *cmd1,
CNXK_ETHDEV_SEC_OUTB_EV_SUB << 20), cmd23, 0);
cmd23 = vsetq_lane_u64((uintptr_t)m | 1, cmd23, 1);
 
-   dptr += l2_len;
-
/* Move to our line */
laddr = LMT_OFF(lbase, *lnum, *loff ? 64 : 0);
 
@@ -564,8 +562,6 @@ cn10k_nix_prep_sec(struct rte_mbuf *m, uint64_t *cmd, 
uintptr_t *nixtx_addr,
CNXK_ETHDEV_SEC_OUTB_EV_SUB << 20), cmd23, 0);
cmd23 = vsetq_lane_u64((uintptr_t)m | 1, cmd23, 1);
 
-   dptr += l2_len;
-
/* Move to our line */
laddr = LMT_OFF(lbase, *lnum, *loff ? 64 : 0);
 
-- 
2.25.1

[PATCH v2 12/13] net/cnxk: remove duplicate mempool debug checks

[Nithin Dabilpuram]

Remove duplicate mempool debug checks for mbufs received.
Fixes: 592642c494b1 ("net/cnxk: align prefetches to CN10K cache model")

Signed-off-by: Nithin Dabilpuram 
---
 drivers/net/cnxk/cn10k_rx.h | 6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h
index cf390a0361..4e22ceda02 100644
--- a/drivers/net/cnxk/cn10k_rx.h
+++ b/drivers/net/cnxk/cn10k_rx.h
@@ -1307,12 +1307,6 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf 
**mbufs, uint16_t pkts,
ol_flags3 |= nix_rx_olflags_get(lookup_mem, cq3_w1);
}
 
-   /* Mark mempool obj as "get" as it is alloc'ed by NIX */
-   RTE_MEMPOOL_CHECK_COOKIES(mbuf0->pool, (void **)&mbuf0, 1, 1);
-   RTE_MEMPOOL_CHECK_COOKIES(mbuf1->pool, (void **)&mbuf1, 1, 1);
-   RTE_MEMPOOL_CHECK_COOKIES(mbuf2->pool, (void **)&mbuf2, 1, 1);
-   RTE_MEMPOOL_CHECK_COOKIES(mbuf3->pool, (void **)&mbuf3, 1, 1);
-
/* Translate meta to mbuf */
if (flags & NIX_RX_OFFLOAD_SECURITY_F) {
uint64_t cq0_w5 = *CQE_PTR_OFF(cq0, 0, 40, flags);
-- 
2.25.1

[PATCH v2 13/13] net/cnxk: handle hard expiry events

[Nithin Dabilpuram]

From: Vamsi Attunuru 

Based on the hard limits configured in the SA context,
PMD passes corresponding event subtype to the application
to notify hard expiry event

Signed-off-by: Vamsi Attunuru 
---
 drivers/net/cnxk/cn10k_ethdev_sec.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/cnxk/cn10k_ethdev_sec.c 
b/drivers/net/cnxk/cn10k_ethdev_sec.c
index ce1b10d885..ed5c335787 100644
--- a/drivers/net/cnxk/cn10k_ethdev_sec.c
+++ b/drivers/net/cnxk/cn10k_ethdev_sec.c
@@ -479,6 +479,12 @@ cn10k_eth_sec_sso_work_cb(uint64_t *gw, void *args, 
uint32_t soft_exp_event)
case ROC_IE_OT_UCC_ERR_SA_OVERFLOW:
desc.subtype = RTE_ETH_EVENT_IPSEC_ESN_OVERFLOW;
break;
+   case ROC_IE_OT_UCC_ERR_SA_EXPIRED:
+   if (sa->w2.s.life_unit == ROC_IE_OT_SA_LIFE_UNIT_PKTS)
+   desc.subtype = RTE_ETH_EVENT_IPSEC_SA_PKT_HARD_EXPIRY;
+   else
+   desc.subtype = RTE_ETH_EVENT_IPSEC_SA_BYTE_HARD_EXPIRY;
+   break;
case ROC_IE_OT_UCC_ERR_PKT_IP:
warn_cnt++;
if (warn_cnt % 1 == 0)
-- 
2.25.1

[PATCH] net/mana: disable driver by default

[Ferruh Yigit]

Driver is disabled by default because its dependencies are not
upstreamed yet, code is available for development and investigation.

When all dependencies are upstreamed, driver can be enabled back.

Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")

Signed-off-by: Ferruh Yigit 
---
Cc: Long Li 
Cc: Stephen Hemminger 
---
 MAINTAINERS| 2 +-
 doc/guides/nics/index.rst  | 1 -
 doc/guides/rel_notes/release_22_11.rst | 2 ++
 drivers/net/meson.build| 1 -
 4 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2bd4a55f1b0a..fe6c0a60b628 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -828,7 +828,7 @@ F: buildtools/options-ibverbs-static.sh
 F: doc/guides/nics/mlx5.rst
 F: doc/guides/nics/features/mlx5.ini
 
-Microsoft mana
+Microsoft mana - EXPERIMENTAL
 M: Long Li 
 F: drivers/net/mana/
 F: doc/guides/nics/mana.rst
diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst
index 32c754496827..f80906a97d1b 100644
--- a/doc/guides/nics/index.rst
+++ b/doc/guides/nics/index.rst
@@ -41,7 +41,6 @@ Network Interface Controller Drivers
 intel_vf
 kni
 liquidio
-mana
 memif
 mlx4
 mlx5
diff --git a/doc/guides/rel_notes/release_22_11.rst 
b/doc/guides/rel_notes/release_22_11.rst
index 2da8bc9661af..79bc36815659 100644
--- a/doc/guides/rel_notes/release_22_11.rst
+++ b/doc/guides/rel_notes/release_22_11.rst
@@ -142,6 +142,8 @@ New Features
 
 * **Added Microsoft mana driver.**
 
+  Disabled by default because of missing dependency.
+
 * **Updated Netronome nfp driver.**
 
   Added the needed data structures and logics to support flow API offload:
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 35bfa78dee66..37919eaf8b02 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -34,7 +34,6 @@ drivers = [
 'ixgbe',
 'kni',
 'liquidio',
-'mana',
 'memif',
 'mlx4',
 'mlx5',
-- 
2.25.1

RE: [v1] examples/fips_validation: remove unused include file

[Akhil Goyal]

> Subject: [v1] examples/fips_validation: remove unused include file
> 
> Remove invoking include for sys/random.h which is not actually used
> by app.
> 
> Signed-off-by: Gowrishankar Muthukrishnan 
> ---
Squashed with original commit.
Thanks.

Re: [PATCH] net/nfp: set the appropriate initialized value of flbufsz

[Ferruh Yigit]

On 10/10/2022 7:48 AM, Chaoyong He wrote:

From: Peng Zhang 

When the testpmd app start-up with parameter max-pkt-len, it will set MTU.
But the initialized value of flubfsz is inappropriate, if the value of
flbufsz is smaller than the valude of max-pkt-len, the testpmd app will
start fail.



What is the failure in the testpmd?

This patch is fixing something but it is not clear what is fixed, the 
concern is it may be changing driver to make something pass in test 
application (testpmd).


What is 'flubfsz', is it Hw configured frame buffer size?



Fixes: 5c305e218f15 ("net/nfp: fix initialization")
Cc: sta...@dpdk.org

Signed-off-by: Peng Zhang 
Reviewed-by: Chaoyong He 
Reviewed-by: Niklas Söderlund 
---
  drivers/net/nfp/nfp_ethdev.c| 2 +-
  drivers/net/nfp/nfp_ethdev_vf.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 5cdd34e588..b95e623f1f 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -517,7 +517,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)
hw->cap = nn_cfg_readl(hw, NFP_NET_CFG_CAP);
hw->max_mtu = nn_cfg_readl(hw, NFP_NET_CFG_MAX_MTU);
hw->mtu = RTE_ETHER_MTU;
-   hw->flbufsz = RTE_ETHER_MTU;
+   hw->flbufsz = hw->max_mtu;
  
  	/* VLAN insertion is incompatible with LSOv2 */

if (hw->cap & NFP_NET_CFG_CTRL_LSO2)
diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c
index d304d78d34..47acb4c60e 100644
--- a/drivers/net/nfp/nfp_ethdev_vf.c
+++ b/drivers/net/nfp/nfp_ethdev_vf.c
@@ -396,7 +396,7 @@ nfp_netvf_init(struct rte_eth_dev *eth_dev)
hw->cap = nn_cfg_readl(hw, NFP_NET_CFG_CAP);
hw->max_mtu = nn_cfg_readl(hw, NFP_NET_CFG_MAX_MTU);
hw->mtu = RTE_ETHER_MTU;
-   hw->flbufsz = RTE_ETHER_MTU;
+   hw->flbufsz = hw->max_mtu;
  
  	/* VLAN insertion is incompatible with LSOv2 */

if (hw->cap & NFP_NET_CFG_CTRL_LSO2)

Re: [PATCH] net/nfp: add the feature of RSS based on VXLAN inner layer

[Ferruh Yigit]

On 10/10/2022 7:28 AM, Chaoyong He wrote:

Add the logics to support the feature of RSS packets based on
the inner layer of VXLAN tunnel.

Signed-off-by: Chaoyong He 
Reviewed-by: Niklas Söderlund 

Depends-on: series-24819 ("preparation for the rte_flow offload of nfp PMD")

---
  drivers/net/nfp/flower/nfp_flower.c |   2 +-
  drivers/net/nfp/flower/nfp_flower_cmsg.c|   1 +
  drivers/net/nfp/flower/nfp_flower_ctrl.c|   2 +-
  drivers/net/nfp/flower/nfp_flower_representor.c |   2 +-
  drivers/net/nfp/nfp_common.c|  33 +++
  drivers/net/nfp/nfp_common.h|   4 +
  drivers/net/nfp/nfp_cpp_bridge.h|   2 -
  drivers/net/nfp/nfp_ethdev.c| 111 
  drivers/net/nfp/nfp_ethdev_vf.c |   1 +
  drivers/net/nfp/nfp_rxtx.c  |   1 +
  10 files changed, 154 insertions(+), 5 deletions(-)

diff --git a/drivers/net/nfp/flower/nfp_flower.c 
b/drivers/net/nfp/flower/nfp_flower.c
index 3e97f5c..da96d2f 100644
--- a/drivers/net/nfp/flower/nfp_flower.c
+++ b/drivers/net/nfp/flower/nfp_flower.c
@@ -10,9 +10,9 @@
  #include 
  #include 
  
+#include "../nfp_ctrl.h"

  #include "../nfp_common.h"
  #include "../nfp_logs.h"
-#include "../nfp_ctrl.h"
  #include "../nfp_cpp_bridge.h"
  #include "../nfp_rxtx.h"
  #include "../nfpcore/nfp_mip.h"
diff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.c 
b/drivers/net/nfp/flower/nfp_flower_cmsg.c
index 750a629..b719eb2 100644
--- a/drivers/net/nfp/flower/nfp_flower_cmsg.c
+++ b/drivers/net/nfp/flower/nfp_flower_cmsg.c
@@ -5,6 +5,7 @@
  
  #include "../nfpcore/nfp_nsp.h"

  #include "../nfp_logs.h"
+#include "../nfp_ctrl.h"
  #include "../nfp_common.h"
  #include "nfp_flower.h"
  #include "nfp_flower_cmsg.h"
diff --git a/drivers/net/nfp/flower/nfp_flower_ctrl.c 
b/drivers/net/nfp/flower/nfp_flower_ctrl.c
index df908ef..961ca34 100644
--- a/drivers/net/nfp/flower/nfp_flower_ctrl.c
+++ b/drivers/net/nfp/flower/nfp_flower_ctrl.c
@@ -6,9 +6,9 @@
  #include 
  #include 
  
+#include "../nfp_ctrl.h"

  #include "../nfp_common.h"
  #include "../nfp_logs.h"
-#include "../nfp_ctrl.h"
  #include "../nfp_rxtx.h"
  #include "nfp_flower.h"
  #include "nfp_flower_ctrl.h"
diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c 
b/drivers/net/nfp/flower/nfp_flower_representor.c
index 0e60f50..8db73e0 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -6,9 +6,9 @@
  #include 
  #include 
  
+#include "../nfp_ctrl.h"

  #include "../nfp_common.h"
  #include "../nfp_logs.h"
-#include "../nfp_ctrl.h"
  #include "../nfp_rxtx.h"
  #include "../nfpcore/nfp_mip.h"
  #include "../nfpcore/nfp_rtsym.h"
diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c
index 07781a1..ec6a669 100644
--- a/drivers/net/nfp/nfp_common.c
+++ b/drivers/net/nfp/nfp_common.c
@@ -37,6 +37,7 @@
  #include "nfpcore/nfp_rtsym.h"
  #include "nfpcore/nfp_nsp.h"
  
+#include "nfp_ctrl.h"

  #include "nfp_common.h"
  #include "nfp_ctrl.h"
  #include "nfp_rxtx.h"


Are above header inclusion changes related to this patch?

Re: [PATCH] doc: fix support table for ETH and VLAN flow items

[Thomas Monjalon]

13/10/2022 13:01, Ilya Maximets:
> On 10/12/22 17:30, Thomas Monjalon wrote:
> > 07/10/2022 13:55, Ilya Maximets:
> >> On 10/7/22 13:50, Ilya Maximets wrote:
> >>> On 9/12/22 12:09, Thomas Monjalon wrote:
>  16/03/2022 13:01, Ilya Maximets:
> > 'has_vlan' attribute is only supported by sfc, mlx5 and cnxk.
> > Other drivers doesn't support it.  Most of them (like i40e) just
> > ignore it silently.  Some drivers (like mlx4) never had a full
> > support of the eth item even before introduction of 'has_vlan'
> > (mlx4 allows to match on the destination MAC only).
> >
> > Same for the 'has_more_vlan' flag of the vlan item.
> >
> > Changing the support level to 'partial' for all such drivers.
> > This doesn't solve the issue, but at least marks the problematic
> > drivers.
> 
>  You changed "eth" and "vlan" from "Y" to "P".
>  The field "has_vlan" is part of "rte_flow_item_eth",
>  and "has_more_vlan" is part of "rte_flow_item_vlan",
>  so I agree we need to change both items to "partial support".
>  It looks to be a good change, just needs to more explicit,
>  adding this kind of explanation about the fields.
> >>>
> >>> I can add this to the commit message.  Should I also add
> >>> some note alongside the table in that documentation page?
> > 
> > I'm afraid it can be long and complex to add notes in the page
> > about what is missing to get complete support for each feature/PMD.
> > I think you can just re-spin with a clear explanation in the commit,
> > so PMD maintainers can refer to it.
> 
> OK.  v2 sent here:
>   
> https://patches.dpdk.org/project/dpdk/patch/20221013104849.2677995-1-i.maxim...@ovn.org/

Thank you, I'm currently working on the rte_flow_items to use structs from 
librte_net.

[PATCH 1/3] net/iavf: fix security session destroy

[Radu Nicolau]

Replace mempool_put with memset 0, the internal session memory block
is no longer allocated from a mempool

Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
Cc: gak...@marvell.com

Signed-off-by: Radu Nicolau 
---
 drivers/net/iavf/iavf_ipsec_crypto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_ipsec_crypto.c 
b/drivers/net/iavf/iavf_ipsec_crypto.c
index afd7f8f467..46a77afa27 100644
--- a/drivers/net/iavf/iavf_ipsec_crypto.c
+++ b/drivers/net/iavf/iavf_ipsec_crypto.c
@@ -1042,7 +1042,7 @@ iavf_ipsec_crypto_session_destroy(void *device,
return -EINVAL;
 
ret = iavf_ipsec_crypto_sa_del(adapter, iavf_sess);
-   rte_mempool_put(rte_mempool_from_obj(iavf_sess), (void *)iavf_sess);
+   memset(iavf_sess, 0, sizeof(struct iavf_security_session));
return ret;
 }
 
-- 
2.25.1

[PATCH 2/3] net/ixgbe: fix security session destroy

[Radu Nicolau]

Replace mempool_put with memset 0, the internal session memory block
is no longer allocated from a mempool

Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
Cc: gak...@marvell.com

Signed-off-by: Radu Nicolau 
---
 drivers/net/ixgbe/ixgbe_ipsec.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c
index 8a96a9f11a..0c75fd36da 100644
--- a/drivers/net/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ixgbe/ixgbe_ipsec.c
@@ -429,7 +429,6 @@ ixgbe_crypto_remove_session(void *device,
 {
struct rte_eth_dev *eth_dev = device;
struct ixgbe_crypto_session *ic_session = 
SECURITY_GET_SESS_PRIV(session);
-   struct rte_mempool *mempool = rte_mempool_from_obj(ic_session);
 
if (eth_dev != ic_session->dev) {
PMD_DRV_LOG(ERR, "Session not bound to this device\n");
@@ -441,8 +440,7 @@ ixgbe_crypto_remove_session(void *device,
return -EFAULT;
}
 
-   rte_mempool_put(mempool, (void *)ic_session);
-
+   memset(ic_session, 0, sizeof(struct ixgbe_crypto_session));
return 0;
 }
 
-- 
2.25.1

[PATCH 3/3] net/txgbe: fix security session destroy

[Radu Nicolau]

Replace mempool_put with memset 0, the internal session memory block
is no longer allocated from a mempool

Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
Cc: gak...@marvell.com

Signed-off-by: Radu Nicolau 
---
 drivers/net/txgbe/txgbe_ipsec.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/txgbe/txgbe_ipsec.c b/drivers/net/txgbe/txgbe_ipsec.c
index b458b3a922..f9f8108fb8 100644
--- a/drivers/net/txgbe/txgbe_ipsec.c
+++ b/drivers/net/txgbe/txgbe_ipsec.c
@@ -409,7 +409,6 @@ txgbe_crypto_remove_session(void *device,
 {
struct rte_eth_dev *eth_dev = device;
struct txgbe_crypto_session *ic_session = 
SECURITY_GET_SESS_PRIV(session);
-   struct rte_mempool *mempool = rte_mempool_from_obj(ic_session);
 
if (eth_dev != ic_session->dev) {
PMD_DRV_LOG(ERR, "Session not bound to this device\n");
@@ -421,7 +420,7 @@ txgbe_crypto_remove_session(void *device,
return -EFAULT;
}
 
-   rte_mempool_put(mempool, (void *)ic_session);
+   memset(ic_session, 0, sizeof(struct txgbe_crypto_session));
 
return 0;
 }
-- 
2.25.1

RE: [EXT] [PATCH 1/3] net/iavf: fix security session destroy

[Akhil Goyal]

> Replace mempool_put with memset 0, the internal session memory block
> is no longer allocated from a mempool
> 
> Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
> Cc: gak...@marvell.com
> 
> Signed-off-by: Radu Nicolau 
> ---
Acked-by: Akhil Goyal 

RE: [EXT] [PATCH 3/3] net/txgbe: fix security session destroy

[Akhil Goyal]

> Replace mempool_put with memset 0, the internal session memory block
> is no longer allocated from a mempool
> 
> Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
> Cc: gak...@marvell.com
> 
> Signed-off-by: Radu Nicolau 
Acked-by: Akhil Goyal 

RE: [EXT] [PATCH 2/3] net/ixgbe: fix security session destroy

[Akhil Goyal]

> Replace mempool_put with memset 0, the internal session memory block
> is no longer allocated from a mempool
> 
> Fixes: 3f3fc3308bd0 ("security: remove private mempool usage")
> Cc: gak...@marvell.com
> 
> Signed-off-by: Radu Nicolau 
Acked-by: Akhil Goyal 

[PATCH v13 5/5] net/bnxt: support proactive error handling mode

[Chengwen Feng]

From: Kalesh AP 

This patch supports proactive error handling mode.

Signed-off-by: Kalesh AP 
Signed-off-by: Somnath Kotur 
Reviewed-by: Ajit Khaparde 
Reviewed-by: Chengwen Feng 
---
 drivers/net/bnxt/bnxt_cpr.c|  4 
 drivers/net/bnxt/bnxt_ethdev.c | 13 -
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c
index 99af0f9e87..5bb376d4d5 100644
--- a/drivers/net/bnxt/bnxt_cpr.c
+++ b/drivers/net/bnxt/bnxt_cpr.c
@@ -180,6 +180,10 @@ void bnxt_handle_async_event(struct bnxt *bp,
return;
}
 
+   rte_eth_dev_callback_process(bp->eth_dev,
+RTE_ETH_EVENT_ERR_RECOVERING,
+NULL);
+
pthread_mutex_lock(&bp->err_recovery_lock);
event_data = data1;
/* timestamp_lo/hi values are in units of 100ms */
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 3dfe9efc09..b3de490d36 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1063,6 +1063,8 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev 
*eth_dev,
dev_info->vmdq_pool_base = 0;
dev_info->vmdq_queue_base = 0;
 
+   dev_info->err_handle_mode = RTE_ETH_ERROR_HANDLE_MODE_PROACTIVE;
+
return 0;
 }
 
@@ -4382,13 +4384,18 @@ static void bnxt_dev_recover(void *arg)
PMD_DRV_LOG(INFO, "Port: %u Recovered from FW reset\n",
bp->eth_dev->data->port_id);
pthread_mutex_unlock(&bp->err_recovery_lock);
-
+   rte_eth_dev_callback_process(bp->eth_dev,
+RTE_ETH_EVENT_RECOVERY_SUCCESS,
+NULL);
return;
 err_start:
bnxt_dev_stop(bp->eth_dev);
 err:
bp->flags |= BNXT_FLAG_FATAL_ERROR;
bnxt_uninit_resources(bp, false);
+   rte_eth_dev_callback_process(bp->eth_dev,
+RTE_ETH_EVENT_RECOVERY_FAILED,
+NULL);
if (bp->eth_dev->data->dev_conf.intr_conf.rmv)
rte_eth_dev_callback_process(bp->eth_dev,
 RTE_ETH_EVENT_INTR_RMV,
@@ -4560,6 +4567,10 @@ static void bnxt_check_fw_health(void *arg)
 
PMD_DRV_LOG(ERR, "Detected FW dead condition\n");
 
+   rte_eth_dev_callback_process(bp->eth_dev,
+RTE_ETH_EVENT_ERR_RECOVERING,
+NULL);
+
if (bnxt_is_primary_func(bp))
wait_msec = info->primary_func_wait_period;
else
-- 
2.17.1

[PATCH v13 1/5] ethdev: add error handling mode to device info

[Chengwen Feng]

This patch adds error handling mode to device info, currently, the
defined error handling modes include:

1) NONE: it means no error handling modes are supported by this port.

2) PASSIVE: passive error handling, after the PMD detect that a reset
is required, the PMD reports RTE_ETH_EVENT_INTR_RESET event, and
application invoke rte_eth_dev_reset() to recover the port.

Signed-off-by: Chengwen Feng 
Reviewed-by: Andrew Rybchenko 
---
 app/test-pmd/config.c   | 12 
 drivers/net/e1000/igb_ethdev.c  |  2 ++
 drivers/net/ena/ena_ethdev.c|  2 ++
 drivers/net/iavf/iavf_ethdev.c  |  2 ++
 drivers/net/ixgbe/ixgbe_ethdev.c|  2 ++
 drivers/net/txgbe/txgbe_ethdev_vf.c |  2 ++
 lib/ethdev/rte_ethdev.h | 18 ++
 7 files changed, 40 insertions(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index dec16a9049..4cddcd0bf7 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -921,6 +921,18 @@ port_infos_display(portid_t port_id)
printf("Switch Rx domain: %u\n",
   dev_info.switch_info.rx_domain);
}
+   printf("Device error handling mode: ");
+   switch (dev_info.err_handle_mode) {
+   case RTE_ETH_ERROR_HANDLE_MODE_NONE:
+   printf("none\n");
+   break;
+   case RTE_ETH_ERROR_HANDLE_MODE_PASSIVE:
+   printf("passive\n");
+   break;
+   default:
+   printf("unknown\n");
+   break;
+   }
 }
 
 void
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index d6bcc5bf58..8858f975f8 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -2341,6 +2341,8 @@ eth_igbvf_infos_get(struct rte_eth_dev *dev, struct 
rte_eth_dev_info *dev_info)
dev_info->rx_desc_lim = rx_desc_lim;
dev_info->tx_desc_lim = tx_desc_lim;
 
+   dev_info->err_handle_mode = RTE_ETH_ERROR_HANDLE_MODE_PASSIVE;
+
return 0;
 }
 
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 3e88bcda6c..efcb163027 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -2482,6 +2482,8 @@ static int ena_infos_get(struct rte_eth_dev *dev,
dev_info->default_rxportconf.ring_size = ENA_DEFAULT_RING_SIZE;
dev_info->default_txportconf.ring_size = ENA_DEFAULT_RING_SIZE;
 
+   dev_info->err_handle_mode = RTE_ETH_ERROR_HANDLE_MODE_PASSIVE;
+
return 0;
 }
 
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 782be82c7f..b1958e0474 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1179,6 +1179,8 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct 
rte_eth_dev_info *dev_info)
.nb_align = IAVF_ALIGN_RING_DESC,
};
 
+   dev_info->err_handle_mode = RTE_ETH_ERROR_HANDLE_MODE_PASSIVE;
+
return 0;
 }
 
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index bf70ee041d..fd06ddbe35 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4056,6 +4056,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
dev_info->rx_desc_lim = rx_desc_lim;
dev_info->tx_desc_lim = tx_desc_lim;
 
+   dev_info->err_handle_mode = RTE_ETH_ERROR_HANDLE_MODE_PASSIVE;
+
return 0;
 }
 
diff --git a/drivers/net/txgbe/txgbe_ethdev_vf.c 
b/drivers/net/txgbe/txgbe_ethdev_vf.c
index f52cd8bc19..3b1f7c913b 100644
--- a/drivers/net/txgbe/txgbe_ethdev_vf.c
+++ b/drivers/net/txgbe/txgbe_ethdev_vf.c
@@ -521,6 +521,8 @@ txgbevf_dev_info_get(struct rte_eth_dev *dev,
dev_info->rx_desc_lim = rx_desc_lim;
dev_info->tx_desc_lim = tx_desc_lim;
 
+   dev_info->err_handle_mode = RTE_ETH_ERROR_HANDLE_MODE_PASSIVE;
+
return 0;
 }
 
diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index d43a638aff..5de8e13866 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -1686,6 +1686,22 @@ enum rte_eth_representor_type {
RTE_ETH_REPRESENTOR_PF,   /**< representor of Physical Function. */
 };
 
+/**
+ * @warning
+ * @b EXPERIMENTAL: this enumeration may change without prior notice.
+ *
+ * Ethernet device error handling mode.
+ */
+enum rte_eth_err_handle_mode {
+   /** No error handling modes are supported. */
+   RTE_ETH_ERROR_HANDLE_MODE_NONE,
+   /** Passive error handling, after the PMD detect that a reset is
+* required, the PMD reports @see RTE_ETH_EVENT_INTR_RESET event, and
+* application invoke @see rte_eth_dev_reset to recover the port.
+*/
+   RTE_ETH_ERROR_HANDLE_MODE_PASSIVE,
+};
+
 /**
  * A structure used to retrieve the contextual information of
  * an Ethernet device, such as the controlling driver of the
@@ -1753,6 +1769,8 @@ struct rte_eth_dev_info {
 * embedded managed interconnect/switch.
 */
struct rte_eth_swit

[PATCH v13 0/5] support error handling mode

[Chengwen Feng]

This patchset introduce error handling mode concept, the supported modes
are as follows:

1) PASSIVE: passive error handling, after the PMD detect that a reset
is required, the PMD reports RTE_ETH_EVENT_INTR_RESET event, and
application invoke rte_eth_dev_reset to recover the port.
  
2) PROACTIVE: proactive error handling, after the PMD detect that a reset
is required, the PMD reports RTE_ETH_EVENT_ERR_RECOVERING event, and do
recovery internally, finally, reports the recovery result event.

Chengwen Feng (2):
  ethdev: add error handling mode to device info
  net/hns3: support proactive error handling mode

Kalesh AP (3):
  ethdev: support proactive error handling mode
  app/testpmd: support error handling mode event
  net/bnxt: support proactive error handling mode

---
v13: Address comments from Andrew (rework part of rst).
v12: Address comments from Andrew.
v11: Fix clang-static fail due wrong experimental placement.
v10: Accurately describe the recovery success scenario so that
 addressed comments from Ferruh.
v9: Introduce error handling mode concept.
Addressed comments from Thomas and Ray.
v8: Addressed comments from Thomas and Ferruh.
Also introduced RECOVER_FAIL event.
Add hns3 driver patch.
v7: Addressed comments from Thomas and Andrew.
v6: Addressed comments from Asaf Penso.
1. Updated 20.11 release notes with the new events added.
2. updated testpmd parse_event_printing_config function.
v5: Addressed comments from Ophir Munk.
1. Renamed the new event name to RTE_ETH_EVENT_ERR_RECOVERING.
2. Fixed testpmd logs.
3. Documented the new recovery events.
v4: Addressed comments from Thomas Monjalon
1. Added doxygen comments about new events.
V3: Fixed a typo in commit log.
V2: Added a new event RTE_ETH_EVENT_RESET instead of using the
RTE_ETH_EVENT_INTR_RESET to notify applications about device reset.

 app/test-pmd/config.c   | 15 +
 app/test-pmd/parameters.c   | 10 +++-
 app/test-pmd/testpmd.c  |  8 ++-
 doc/guides/prog_guide/poll_mode_drv.rst | 41 +
 doc/guides/rel_notes/release_22_11.rst  | 12 
 drivers/net/bnxt/bnxt_cpr.c |  4 ++
 drivers/net/bnxt/bnxt_ethdev.c  | 13 -
 drivers/net/e1000/igb_ethdev.c  |  2 +
 drivers/net/ena/ena_ethdev.c|  2 +
 drivers/net/hns3/hns3_common.c  |  2 +
 drivers/net/hns3/hns3_intr.c| 24 
 drivers/net/iavf/iavf_ethdev.c  |  2 +
 drivers/net/ixgbe/ixgbe_ethdev.c|  2 +
 drivers/net/txgbe/txgbe_ethdev_vf.c |  2 +
 lib/ethdev/rte_ethdev.h | 77 +
 15 files changed, 212 insertions(+), 4 deletions(-)

-- 
2.17.1

[PATCH v13 2/5] ethdev: support proactive error handling mode

[Chengwen Feng]

From: Kalesh AP 

Some PMDs (e.g. hns3) could detect hardware or firmware errors, one
error recovery mode is to report RTE_ETH_EVENT_INTR_RESET event, and
wait for application invoke rte_eth_dev_reset() to recover the port,
however, this mode has the following weaknesses:

1) Due to different hardware and software design, some NIC port recovery
process requires multiple handshakes with the firmware and PF (when the
port is VF). It takes a long time to complete the entire operation for
one port, If multiple ports (for example, multiple VFs of a PF) are
reset at the same time, other VFs may fail to be reset. (Because the
reset processing is serial, the previous VFs must be processed before
the subsequent VFs).

2) The impact on the application layer is great, and it should stop
working queues, stop calling Rx and Tx functions, and then call
rte_eth_dev_reset(), and re-setup all again.

This patch introduces proactive error handling mode, the PMD will try
to recover from the errors itself. In this process, the PMD sets the
data path pointers to dummy functions (which will prevent the crash),
and also make sure the control path operations failed with retcode
-EBUSY.

Because the PMD recovers automatically, the application can only sense
that the data flow is disconnected for a while and the control API
returns an error in this period.

In order to sense the error happening/recovering, three events were
introduced:

1) RTE_ETH_EVENT_ERR_RECOVERING: used to notify the application that it
detected an error and the recovery is being started. Upon receiving the
event, the application should not invoke any control path APIs until
receiving RTE_ETH_EVENT_RECOVERY_SUCCESS or
RTE_ETH_EVENT_RECOVERY_FAILED event.

2) RTE_ETH_EVENT_RECOVERY_SUCCESS: used to notify the application that
it recovers successful from the error, the PMD already re-configures the
port, and the effect is the same as that of the restart operation.

3) RTE_ETH_EVENT_RECOVERY_FAILED: used to notify the application that it
recovers failed from the error, the port should not usable anymore. The
application should close the port.

Signed-off-by: Kalesh AP 
Signed-off-by: Somnath Kotur 
Signed-off-by: Chengwen Feng 
Reviewed-by: Ajit Khaparde 
Acked-by: Andrew Rybchenko 
---
 app/test-pmd/config.c   |  3 ++
 doc/guides/prog_guide/poll_mode_drv.rst | 41 +
 doc/guides/rel_notes/release_22_11.rst  | 12 +
 lib/ethdev/rte_ethdev.h | 59 +
 4 files changed, 115 insertions(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 4cddcd0bf7..0f7dbd698f 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -929,6 +929,9 @@ port_infos_display(portid_t port_id)
case RTE_ETH_ERROR_HANDLE_MODE_PASSIVE:
printf("passive\n");
break;
+   case RTE_ETH_ERROR_HANDLE_MODE_PROACTIVE:
+   printf("proactive\n");
+   break;
default:
printf("unknown\n");
break;
diff --git a/doc/guides/prog_guide/poll_mode_drv.rst 
b/doc/guides/prog_guide/poll_mode_drv.rst
index 9d081b1cba..7a9c43d1cb 100644
--- a/doc/guides/prog_guide/poll_mode_drv.rst
+++ b/doc/guides/prog_guide/poll_mode_drv.rst
@@ -627,3 +627,44 @@ by application.
 The PMD itself should not call rte_eth_dev_reset(). The PMD can trigger
 the application to handle reset event. It is duty of application to
 handle all synchronization before it calls rte_eth_dev_reset().
+
+The above error handling mode is known as 
``RTE_ETH_ERROR_HANDLE_MODE_PASSIVE``.
+
+Proactive Error Handling Mode
+~
+
+This mode is known as ``RTE_ETH_ERROR_HANDLE_MODE_PROACTIVE``, different from
+the application invokes recovery in PASSIVE mode, the PMD automatically 
recovers
+from error in PROACTIVE mode, and only a small amount of work is required for
+the application.
+
+During error detection and automatic recovery, the PMD sets the data path
+pointers to dummy functions (which will prevent the crash), and also make sure
+the control path operations failed with retcode -EBUSY.
+
+Because the PMD recovers automatically, the application can only sense that the
+data flow is disconnected for a while and the control API returns an error in
+this period.
+
+In order to sense the error happening/recovering, as well as restore some
+additional configuration, three events were introduced:
+
+* RTE_ETH_EVENT_ERR_RECOVERING: used to notify the application that it detected
+  an error and the recovery is being started. Upon receiving the event, the
+  application should not invoke any control path APIs until receiving
+  RTE_ETH_EVENT_RECOVERY_SUCCESS or RTE_ETH_EVENT_RECOVERY_FAILED event.
+
+* RTE_ETH_EVENT_RECOVERY_SUCCESS: used to notify the application that it
+  recovers successful from the error, the PMD already re-configures the port,
+  and the effect is the same as that of the restart operation.
+
+* RTE_ETH_EVENT_RECOVE

[PATCH v13 3/5] app/testpmd: support error handling mode event

[Chengwen Feng]

From: Kalesh AP 

This patch supports error handling mode event process.

Signed-off-by: Kalesh AP 
Signed-off-by: Somnath Kotur 
Signed-off-by: Chengwen Feng 
Reviewed-by: Ajit Khaparde 
---
 app/test-pmd/parameters.c | 10 --
 app/test-pmd/testpmd.c|  8 +++-
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index ff760460ec..b56383dc4a 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -167,9 +167,9 @@ usage(char* progname)
printf("  --no-rmv-interrupt: disable device removal interrupt.\n");
printf("  --bitrate-stats=N: set the logical core N to perform "
"bit-rate calculation.\n");
-   printf("  --print-event 
:
 "
+   printf("  --print-event 
:
 "
   "enable print of designated event or all of them.\n");
-   printf("  --mask-event 
:
 "
+   printf("  --mask-event 
:
 "
   "disable print of designated event or all of them.\n");
printf("  --flow-isolate-all: "
   "requests flow API isolated mode on all ports at initialization 
time.\n");
@@ -453,6 +453,12 @@ parse_event_printing_config(const char *optarg, int enable)
mask = UINT32_C(1) << RTE_ETH_EVENT_DESTROY;
else if (!strcmp(optarg, "flow_aged"))
mask = UINT32_C(1) << RTE_ETH_EVENT_FLOW_AGED;
+   else if (!strcmp(optarg, "err_recovering"))
+   mask = UINT32_C(1) << RTE_ETH_EVENT_ERR_RECOVERING;
+   else if (!strcmp(optarg, "recovery_success"))
+   mask = UINT32_C(1) << RTE_ETH_EVENT_RECOVERY_SUCCESS;
+   else if (!strcmp(optarg, "recovery_failed"))
+   mask = UINT32_C(1) << RTE_ETH_EVENT_RECOVERY_FAILED;
else if (!strcmp(optarg, "all"))
mask = ~UINT32_C(0);
else {
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 5b0f0838dc..f4f1888446 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -426,6 +426,9 @@ static const char * const eth_event_desc[] = {
[RTE_ETH_EVENT_DESTROY] = "device released",
[RTE_ETH_EVENT_FLOW_AGED] = "flow aged",
[RTE_ETH_EVENT_RX_AVAIL_THRESH] = "RxQ available descriptors threshold 
reached",
+   [RTE_ETH_EVENT_ERR_RECOVERING] = "error recovering",
+   [RTE_ETH_EVENT_RECOVERY_SUCCESS] = "error recovery successful",
+   [RTE_ETH_EVENT_RECOVERY_FAILED] = "error recovery failed",
[RTE_ETH_EVENT_MAX] = NULL,
 };
 
@@ -440,7 +443,10 @@ uint32_t event_print_mask = (UINT32_C(1) << 
RTE_ETH_EVENT_UNKNOWN) |
(UINT32_C(1) << RTE_ETH_EVENT_IPSEC) |
(UINT32_C(1) << RTE_ETH_EVENT_MACSEC) |
(UINT32_C(1) << RTE_ETH_EVENT_INTR_RMV) |
-   (UINT32_C(1) << RTE_ETH_EVENT_FLOW_AGED);
+   (UINT32_C(1) << RTE_ETH_EVENT_FLOW_AGED) |
+   (UINT32_C(1) << RTE_ETH_EVENT_ERR_RECOVERING) |
+   (UINT32_C(1) << RTE_ETH_EVENT_RECOVERY_SUCCESS) |
+   (UINT32_C(1) << RTE_ETH_EVENT_RECOVERY_FAILED);
 /*
  * Decide if all memory are locked for performance.
  */
-- 
2.17.1

[PATCH v13 4/5] net/hns3: support proactive error handling mode

[Chengwen Feng]

This patch supports proactive error handling mode.

Signed-off-by: Chengwen Feng 
Acked-by: Dongdong Liu 
---
 drivers/net/hns3/hns3_common.c |  2 ++
 drivers/net/hns3/hns3_intr.c   | 24 
 2 files changed, 26 insertions(+)

diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c
index 14291193cb..7adc6a4972 100644
--- a/drivers/net/hns3/hns3_common.c
+++ b/drivers/net/hns3/hns3_common.c
@@ -149,6 +149,8 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct 
rte_eth_dev_info *info)
info->max_mac_addrs = HNS3_VF_UC_MACADDR_NUM;
}
 
+   info->err_handle_mode = RTE_ETH_ERROR_HANDLE_MODE_PROACTIVE;
+
return 0;
 }
 
diff --git a/drivers/net/hns3/hns3_intr.c b/drivers/net/hns3/hns3_intr.c
index 57679254ee..44a1119415 100644
--- a/drivers/net/hns3/hns3_intr.c
+++ b/drivers/net/hns3/hns3_intr.c
@@ -1480,6 +1480,27 @@ static const struct hns3_hw_err_type 
hns3_hw_error_type[] = {
}
 };
 
+static void
+hns3_report_reset_begin(struct hns3_hw *hw)
+{
+   struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
+   rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_ERR_RECOVERING, NULL);
+}
+
+static void
+hns3_report_reset_success(struct hns3_hw *hw)
+{
+   struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
+   rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_RECOVERY_SUCCESS, NULL);
+}
+
+static void
+hns3_report_reset_failed(struct hns3_hw *hw)
+{
+   struct rte_eth_dev *dev = &rte_eth_devices[hw->data->port_id];
+   rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_RECOVERY_FAILED, NULL);
+}
+
 static int
 hns3_config_ncsi_hw_err_int(struct hns3_adapter *hns, bool en)
 {
@@ -2642,6 +2663,7 @@ hns3_reset_pre(struct hns3_adapter *hns)
if (hw->reset.stage == RESET_STAGE_NONE) {
__atomic_store_n(&hns->hw.reset.resetting, 1, __ATOMIC_RELAXED);
hw->reset.stage = RESET_STAGE_DOWN;
+   hns3_report_reset_begin(hw);
ret = hw->reset.ops->stop_service(hns);
hns3_clock_gettime(&tv);
if (ret) {
@@ -2751,6 +2773,7 @@ hns3_reset_post(struct hns3_adapter *hns)
  hns3_clock_calctime_ms(&tv_delta),
  tv.tv_sec, tv.tv_usec);
hw->reset.level = HNS3_NONE_RESET;
+   hns3_report_reset_success(hw);
}
return 0;
 
@@ -2796,6 +2819,7 @@ hns3_reset_fail_handle(struct hns3_adapter *hns)
  hns3_clock_calctime_ms(&tv_delta),
  tv.tv_sec, tv.tv_usec);
hw->reset.level = HNS3_NONE_RESET;
+   hns3_report_reset_failed(hw);
 }
 
 /*
-- 
2.17.1

Re: [PATCH v12 2/5] ethdev: support proactive error handling mode

[fengchengwen]

Hi Andrew,

  I rework part of rst according your comments, sent by v13, please take a look.

Thanks.

On 2022/10/13 16:58, Andrew Rybchenko wrote:
> On 10/12/22 06:45, Chengwen Feng wrote:
>> From: Kalesh AP 
>>
>> Some PMDs (e.g. hns3) could detect hardware or firmware errors, one
>> error recovery mode is to report RTE_ETH_EVENT_INTR_RESET event, and
>> wait for application invoke rte_eth_dev_reset() to recover the port,
>> however, this mode has the following weaknesses:
>>
>> 1) Due to different hardware and software design, some NIC port recovery
>> process requires multiple handshakes with the firmware and PF (when the
>> port is VF). It takes a long time to complete the entire operation for
>> one port, If multiple ports (for example, multiple VFs of a PF) are
>> reset at the same time, other VFs may fail to be reset. (Because the
>> reset processing is serial, the previous VFs must be processed before
>> the subsequent VFs).
>>
>> 2) The impact on the application layer is great, and it should stop
>> working queues, stop calling Rx and Tx functions, and then call
>> rte_eth_dev_reset(), and re-setup all again.
>>
>> This patch introduces proactive error handling mode, the PMD will try
>> to recover from the errors itself. In this process, the PMD sets the
>> data path pointers to dummy functions (which will prevent the crash),
>> and also make sure the control path operations failed with retcode
>> -EBUSY.
>>
>> Because the PMD recovers automatically, the application can only sense
>> that the data flow is disconnected for a while and the control API
>> returns an error in this period.
>>
>> In order to sense the error happening/recovering, three events were
>> introduced:
>>
>> 1) RTE_ETH_EVENT_ERR_RECOVERING: used to notify the application that it
>> detected an error and the recovery is being started. Upon receiving the
>> event, the application should not invoke any control path APIs until
>> receiving RTE_ETH_EVENT_RECOVERY_SUCCESS or
>> RTE_ETH_EVENT_RECOVERY_FAILED event.
>>
>> 2) RTE_ETH_EVENT_RECOVERY_SUCCESS: used to notify the application that
>> it recovers successful from the error, the PMD already re-configures the
>> port, and the effect is the same as that of the restart operation.
>>
>> 3) RTE_ETH_EVENT_RECOVERY_FAILED: used to notify the application that it
>> recovers failed from the error, the port should not usable anymore. The
>> application should close the port.
>>
>> Signed-off-by: Kalesh AP 
>> Signed-off-by: Somnath Kotur 
>> Signed-off-by: Chengwen Feng 
>> Reviewed-by: Ajit Khaparde 
> 
> With few nits below,
> 
> Acked-by: Andrew Rybchenko 
> 
> [snip]
> 
>> diff --git a/doc/guides/prog_guide/poll_mode_drv.rst 
>> b/doc/guides/prog_guide/poll_mode_drv.rst
>> index 9d081b1cba..73941a74bd 100644
>> --- a/doc/guides/prog_guide/poll_mode_drv.rst
>> +++ b/doc/guides/prog_guide/poll_mode_drv.rst
>> @@ -627,3 +627,41 @@ by application.
>>   The PMD itself should not call rte_eth_dev_reset(). The PMD can trigger
>>   the application to handle reset event. It is duty of application to
>>   handle all synchronization before it calls rte_eth_dev_reset().
>> +
>> +The above error handling mode is known as 
>> ``RTE_ETH_ERROR_HANDLE_MODE_PASSIVE``.
>> +
>> +Proactive Error Handling Mode
>> +~
>> +
>> +If PMD supports ``RTE_ETH_ERROR_HANDLE_MODE_PROACTIVE``, it means once 
>> detect
>> +hardware or firmware errors, the PMD will try to recover from the errors. In
>> +this process, the PMD sets the data path pointers to dummy functions (which
>> +will prevent the crash), and also make sure the control path operations 
>> failed
>> +with retcode -EBUSY.
>> +
>> +Also in this process, from the perspective of application, services are
>> +affected. For example, the Rx/Tx bust APIs cannot receive and send packets,
> 
> bust -> burst
> 
>> +and the control plane API return failure.
> 
> I think we need to highlight here that the key advantage of the
> proactive error recover that it requires nothing from PMD by
> default. The recover simply happens.
> 
>> +
>> +In some service scenarios, application needs to be aware of the event to
>> +determine whether to migrate services. So three events were introduced:
>> +
>> +* RTE_ETH_EVENT_ERR_RECOVERING: used to notify the application that it 
>> detected
>> +  an error and the recovery is being started. Upon receiving the event, the
>> +  application should not invoke any control path APIs until receiving
>> +  RTE_ETH_EVENT_RECOVERY_SUCCESS or RTE_ETH_EVENT_RECOVERY_FAILED event.
>> +
>> +* RTE_ETH_EVENT_RECOVERY_SUCCESS: used to notify the application that it
>> +  recovers successful from the error, the PMD already re-configures the 
>> port,
>> +  and the effect is the same as that of the restart operation.
>> +
>> +* RTE_ETH_EVENT_RECOVERY_FAILED: used to notify the application that it
>> +  recovers failed from the error, the port should not usable anymore. the
>> +  application should close the port.
>> +
>> +

RE: [PATCH v2] build: increase minimum meson version to 0.53.2

[Tu, Lijuan]

> -Original Message-
> From: David Marchand 
> Sent: Monday, October 10, 2022 3:48 PM
> To: Tu, Lijuan 
> Cc: Richardson, Bruce ; Thomas Monjalon
> ; dev@dpdk.org; c...@dpdk.org; Lincoln Lavoie
> ; Chen, Zhaoyan ; Mcnamara,
> John 
> Subject: Re: [PATCH v2] build: increase minimum meson version to 0.53.2
> 
> On Mon, Oct 10, 2022 at 7:23 AM Tu, Lijuan  wrote:
> > > It seems the "intel-Testing" test is in ... berserk mode and spewing
> > > errors for all patches since 10/03.
> > > No clue if we have an issue in the main branch, and this test logs are 
> > > useless.
> > >
> > > I'll wait for Intel PRC to be back and ignore for now.
> >
> > Yes, the main branch had an issue and has been fixed now. Intel-Testing is 
> > back
> to normal. It works fine.
> 
> The only info we had was that "something" was broken.
> Example: http://mails.dpdk.org/archives/test-report/2022-
> October/313054.html
> 
> 
> When other CI report a failure, executed commands and logs are available in
> GHA and UNH dashboard, downloadable as zip files.
> So it is relatively easy to figure out if the issue was due to an 
> infrastructure
> problem or if it was a test failure.
> 
> 
> I don't think Intel CI provide such info. If this is the case, please 
> document it.
> Otherwise, please Intel CI team, work on providing the same kind of info.

Intel don't provide such info, and I don't think community provides API or 
services to support it. 
The https://lab.dpdk.org/results/dashboard/ is for UNH, If dashboard could 
provide a API for intel, we'd like to provide detail logs.
We need community 's help to set up this, I think we can discus it in CI 
meeting.

> 
> 
> 
> Thanks.
> --
> David Marchand

RE: [EXT] [PATCH v3 18/30] baseband/acc100: enable input validation by default

[Akhil Goyal]

> Enable validation functions by default and provide a new flag
> RTE_LIBRTE_SKIP_VALIDATE if the user wants to run without
> validating input to save cycles.
> 
> Signed-off-by: Hernan Vargas 
> 
> Reviewed-by: Maxime Coquelin 
> ---
>  drivers/baseband/acc/rte_acc100_pmd.c | 36 +--
>  1 file changed, 18 insertions(+), 18 deletions(-)
How will the user know about this new flag?
Can you update the driver documentation for this?

RE: [EXT] [PATCH v3 00/30] baseband/acc100: changes for 22.11

[Akhil Goyal]

> Hernan Vargas (30):
>   baseband/acc100: fix ring availability calculation
>   baseband/acc100: add function to check AQ availability
>   baseband/acc100: memory leak fix
>   baseband/acc100: add LDPC encoder padding function
>   baseband/acc100: check turbo dec/enc input
>   baseband/acc100: check for unlikely operation vals
>   baseband/acc100: enforce additional check on FCW
>   baseband/acc100: allocate ring/queue mem when NULL
>   baseband/acc100: reduce input length for CRC24B
>   baseband/acc100: fix clearing PF IR outside handler
>   baseband/acc100: set device min alignment to 1
>   baseband/acc100: add protection for NULL HARQ input
>   baseband/acc100: reset pointer after rte_free
>   baseband/acc100: fix debug print for LDPC FCW
>   baseband/acc100: add enqueue status
>   baseband/acc100: add scatter-gather support
>   baseband/acc100: add HARQ index helper function
>   baseband/acc100: enable input validation by default
>   baseband/acc100: added LDPC transport block support
>   baseband/acc100: update validate LDPC enc/dec
>   baseband/acc100: implement configurable queue depth
>   baseband/acc100: add queue stop operation
>   baseband/acc100: update uplink CB input length
>   baseband/acc100: rename ldpc encode function arg
>   baseband/acc100: update log messages
>   baseband/acc100: store FCW from first CB descriptor
>   baseband/acc100: update device info
>   baseband/acc100: add ring companion address
>   baseband/acc100: add workaround for deRM corner cases
>   baseband/acc100: configure PMON control registers
> 
>  drivers/baseband/acc/acc100_pmd.h |5 +
>  drivers/baseband/acc/acc_common.h |   10 +
>  drivers/baseband/acc/meson.build  |   21 +
>  drivers/baseband/acc/rte_acc100_pmd.c | 1197 -
>  4 files changed, 1010 insertions(+), 223 deletions(-)
> 
Hi Hernan/Nicolas,

I see some ifdefs being used in the code and there is no documentation for them
On when and how to enable/disable them.
It would be much like a dead code which is not compiled at all,
if any of the build target does not enable them.

Is it possible to replace them with runtime devargs instead of compile time 
ifdefs?

RE: [EXT] [PATCH v3 24/30] baseband/acc100: rename ldpc encode function arg

[Akhil Goyal]

> Rename total_enqueued_cbs to total_enqueued_descs in the
> enqueue_ldpc_enc_n_op_cb function. No functional impact.
> 

Can you specify the reason for rename in description?

> Signed-off-by: Hernan Vargas 
> 
> Reviewed-by: Maxime Coquelin 

RE: [EXT] [PATCH v3 29/30] baseband/acc100: add workaround for deRM corner cases

[Akhil Goyal]

> Add function to support de-ratematch pre-processing for SW corner cases.
> 
Please add more meaningful description.
Title says adding workaround. You should explain the issue and then what is 
done in this patch.

> Signed-off-by: Hernan Vargas 
> ---
>  drivers/baseband/acc/acc_common.h |   8 ++
>  drivers/baseband/acc/meson.build  |  21 +
>  drivers/baseband/acc/rte_acc100_pmd.c | 108 +-
>  3 files changed, 134 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/baseband/acc/acc_common.h
> b/drivers/baseband/acc/acc_common.h
> index 5a9929c336..4b947280c9 100644
> --- a/drivers/baseband/acc/acc_common.h
> +++ b/drivers/baseband/acc/acc_common.h
> @@ -122,6 +122,14 @@
>  #define ACC_HARQ_ALIGN_64B  64
>  #define ACC_MAX_ZC  384
> 
> +/* De-ratematch code rate limitation when padding is required */
> +#define ACC_LIM_03 2  /* 0.03 */
> +#define ACC_LIM_09 6  /* 0.09 */
> +#define ACC_LIM_14 9  /* 0.14 */
> +#define ACC_LIM_21 14 /* 0.21 */
> +#define ACC_LIM_31 20 /* 0.31 */
> +#define ACC_MAX_E (128 * 1024 - 2)
> +
>  /* Helper macro for logging */
>  #define rte_acc_log(level, fmt, ...) \
>   rte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt "\n", \
> diff --git a/drivers/baseband/acc/meson.build
> b/drivers/baseband/acc/meson.build
> index bece3a6e48..b147569d7e 100644
> --- a/drivers/baseband/acc/meson.build
> +++ b/drivers/baseband/acc/meson.build
> @@ -1,6 +1,27 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2020 Intel Corporation
> 
> +# Check for FlexRAN SDK libraries
> +dep_dec5g = dependency('flexran_sdk_ldpc_decoder_5gnr', required: false)
> +
> +if dep_dec5g.found()
> +ext_deps += cc.find_library('libstdc++', required: true)
> +ext_deps += cc.find_library('libirc', required: true)
> +ext_deps += cc.find_library('libimf', required: true)
> +ext_deps += cc.find_library('libipps', required: true)
> +ext_deps += cc.find_library('libsvml', required: true)
> +ext_deps += dep_dec5g
> +ext_deps += dependency('flexran_sdk_ldpc_encoder_5gnr', required: true)
> +ext_deps += dependency('flexran_sdk_LDPC_ratematch_5gnr', required:
> true)
> +ext_deps += dependency('flexran_sdk_rate_dematching_5gnr', required:
> true)
> +ext_deps += dependency('flexran_sdk_turbo', required: true)
> +ext_deps += dependency('flexran_sdk_crc', required: true)
> +ext_deps += dependency('flexran_sdk_rate_matching', required: true)
> +ext_deps += dependency('flexran_sdk_common', required: true)
> +cflags += ['-DRTE_BBDEV_SDK_AVX2']
> +cflags += ['-DRTE_BBDEV_SDK_AVX512']
> +endif
> +
>  deps += ['bbdev', 'bus_pci']
> 
>  sources = files('rte_acc100_pmd.c', 'rte_acc200_pmd.c')
> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c
> b/drivers/baseband/acc/rte_acc100_pmd.c
> index f93fd885a3..44fd0e9ad7 100644
> --- a/drivers/baseband/acc/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> @@ -24,6 +24,10 @@
>  #include "acc100_pmd.h"
>  #include "acc101_pmd.h"
> 
> +#ifdef RTE_BBDEV_SDK_AVX512
> +#include 
> +#endif
> +
>  #ifdef RTE_LIBRTE_BBDEV_DEBUG
>  RTE_LOG_REGISTER_DEFAULT(acc100_logtype, DEBUG);
>  #else
> @@ -748,6 +752,14 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t
> queue_id,
>   ret = -ENOMEM;
>   goto free_lb_out;
>   }
> + q->derm_buffer = rte_zmalloc_socket(dev->device->driver->name,
> + RTE_BBDEV_TURBO_MAX_CB_SIZE * 10,
> + RTE_CACHE_LINE_SIZE, conf->socket);
> + if (q->derm_buffer == NULL) {
> + rte_bbdev_log(ERR, "Failed to allocate derm_buffer memory");
> + ret = -ENOMEM;
> + goto free_companion_ring_addr;
> + }
> 
>   /*
>* Software queue ring wraps synchronously with the HW when it
> reaches
> @@ -768,7 +780,7 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t
> queue_id,
>   q_idx = acc100_find_free_queue_idx(dev, conf);
>   if (q_idx == -1) {
>   ret = -EINVAL;
> - goto free_companion_ring_addr;
> + goto free_derm_buffer;
>   }
> 
>   q->qgrp_id = (q_idx >> ACC100_GRP_ID_SHIFT) & 0xF;
> @@ -796,6 +808,9 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t
> queue_id,
>   dev->data->queues[queue_id].queue_private = q;
>   return 0;
> 
> +free_derm_buffer:
> + rte_free(q->derm_buffer);
> + q->derm_buffer = NULL;
>  free_companion_ring_addr:
>   rte_free(q->companion_ring_addr);
>   q->companion_ring_addr = NULL;
> @@ -882,6 +897,7 @@ acc100_queue_release(struct rte_bbdev *dev, uint16_t
> q_id)
>   /* Mark the Queue as un-assigned */
>   d->q_assigned_bit_map[q->qgrp_id] &= (0x -
>   (uint64_t) (1 << q->aq_id));
> + rte_free(q->derm_buffer);
>   rte_free(q->companion_ring_addr);
>   rte_free(q->lb_in);
>   rte_free(q->lb_out);
> @@ 

[PATCH] usertools/pmdinfo: remove dependency to ldd

[Robin Jarry]

Some environments (buildroot) do not have the ldd utility installed by
default. However, ldd is often only a wrapper shell script that actually
checks that the arguments are valid ELF files and executes them with
the LD_TRACE_LOADED_OBJECTS=1 variable set in the environment.

Since ld.so is the actual ELF interpreter which is loaded first when
executing a program, executing any dynamic ELF program/library with that
variable set will cause all dependent dynamic libraries to be printed
and ld.so will exit before even running main.

Excerpt from ld.so(7) man page:

  LD_TRACE_LOADED_OBJECTS
If set (to any value), causes the program to list its dynamic
dependencies, as if run by ldd(1), instead of running normally.

Change dpdk-pmdinfo.py to actually "execute" the files provided on the
command line with LD_TRACE_LOADED_OBJECTS=1 set. Ensure that the files
are valid dynamically executable ELF programs to avoid obscure and
confusing errors.

Reported-by: Olivier Matz 
Signed-off-by: Robin Jarry 
---
 doc/guides/tools/pmdinfo.rst |  4 ++--
 usertools/dpdk-pmdinfo.py| 34 +++---
 2 files changed, 25 insertions(+), 13 deletions(-)

diff --git a/doc/guides/tools/pmdinfo.rst b/doc/guides/tools/pmdinfo.rst
index a9217de4eef2..1406b9c442eb 100644
--- a/doc/guides/tools/pmdinfo.rst
+++ b/doc/guides/tools/pmdinfo.rst
@@ -37,8 +37,8 @@ Arguments
 
 .. option:: ELF_FILE
 
-   DPDK application binary or dynamic library.
-   Any linked ``librte_*.so`` library (as reported by ``ldd``) will also be 
analyzed.
+   Executable DPDK application binary or dynamic library.
+   Any linked ``librte_*.so`` library (as reported by ``ld.so``) will also be 
analyzed.
Can be specified multiple times.
 
 Environment Variables
diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py
index 67d023a04711..01bb90666bcc 100755
--- a/usertools/dpdk-pmdinfo.py
+++ b/usertools/dpdk-pmdinfo.py
@@ -97,9 +97,9 @@ def parse_args() -> argparse.Namespace:
 "elf_files",
 metavar="ELF_FILE",
 nargs="+",
-type=existing_file,
+type=executable_elf_file,
 help="""
-DPDK application binary or dynamic library.
+Executable DPDK application binary or dynamic library.
 """,
 )
 return parser.parse_args()
@@ -180,14 +180,24 @@ def get_plugin_libs(binaries: Iterable[Path]) -> 
Iterator[Path]:
 
 
 # 
-def existing_file(value: str) -> Path:
+def executable_elf_file(value: str) -> Path:
 """
-Argparse type= callback to ensure an argument points to a valid file path.
+Argparse type= callback to ensure an argument points to a valid ELF file
+path which can be executed.
 """
-path = Path(value)
-if not path.is_file():
-raise argparse.ArgumentTypeError(f"{value}: No such file")
-return path
+try:
+with open(value, "rb") as f:
+elf = ELFFile(f)
+if elf.header.e_type not in ("ET_DYN", "ET_EXEC"):
+raise ELFError(f"unknown type: {elf.header.e_type!r}")
+if not os.access(value, os.X_OK):
+raise OSError("is not executable")
+except ELFError as e:
+raise argparse.ArgumentTypeError(f"{value}: invalid ELF: {e}") from e
+except OSError as e:
+raise argparse.ArgumentTypeError(f"{value}: {e}") from e
+
+return Path(value)
 
 
 # 
@@ -270,7 +280,7 @@ def get_elf_strings(path: Path, section: str, prefix: str) 
-> Iterator[str]:
 
 
 # 
-LDD_LIB_RE = re.compile(
+LOADED_OBJECT_RE = re.compile(
 r"""
 ^  # beginning of line
 \t # tab
@@ -290,14 +300,16 @@ def get_needed_libs(path: Path) -> Iterator[Path]:
 """
 Extract the dynamic library dependencies from an ELF executable.
 """
+env = os.environ.copy()
+env["LD_TRACE_LOADED_OBJECTS"] = "1"
 with subprocess.Popen(
-["ldd", str(path)], stdout=subprocess.PIPE, stderr=subprocess.PIPE
+[str(path)], stdout=subprocess.PIPE, stderr=subprocess.PIPE, env=env
 ) as proc:
 out, err = proc.communicate()
 if proc.returncode != 0:
 err = err.decode("utf-8").splitlines()[-1].strip()
 raise Exception(f"cannot read ELF file: {err}")
-for match in LDD_LIB_RE.finditer(out.decode("utf-8")):
+for match in LOADED_OBJECT_RE.finditer(out.decode("utf-8")):
 libname, libpath = match.groups()
 if libname.startswith("librte_"):
 libpath = Path(libpath)
-- 
2.37.3

Re: [PATCH] trace: take live traces via telemetry

[Jerin Jacob]

On Thu, Oct 13, 2022 at 1:20 PM David Marchand
 wrote:
>

I would suggest to change the subject as "trace: enable trace
operations via telemetry" or so

> Register telemetry commands to list and configure trace points and later
> save traces for a running DPDK application.
>
> Note: trace point names contain a '.', so the list of valid characters
> used in telemetry commands and dictionary keys has been extended.
>
> Example with testpmd running with two net/null ports (startup command
> from devtools/test-null.sh):
>
> --> /trace/disable,*
> {"/trace/disable": {"Count": 2}}
>
> Signed-off-by: David Marchand 

> +}
> +
> +static int
> +trace_telemetry_list(const char *cmd __rte_unused,
> +   const char *params, struct rte_tel_data *d)
> +{
> +   struct trace_point *tp;
> +
> +   rte_tel_data_start_dict(d);
> +   STAILQ_FOREACH(tp, &tp_list, next) {
> +   if (params != NULL && fnmatch(params, tp->name, 0) != 0)
> +   continue;
> +
> +   rte_tel_data_add_dict_string(d, tp->name,
> +   rte_trace_point_is_enabled(tp->handle) ?  "Enabled" : 
> "Disabled");

Could be changed to "Ena" and "Dis" or similar to reduce traffic on wire.

Also, it may be good to add a few text in
doc/guides/prog_guide/trace_lib.rst to tell this feature.

Acked-by: Jerin Jacob 

Re: [PATCH] net/ixgbevf: fix promiscuous and allmulti

[Olivier Matz]

Hi Wenjun,

On Mon, Oct 10, 2022 at 01:30:54AM +, Wu, Wenjun1 wrote:
> Hi Olivier,
> 
> > -Original Message-
> > From: Olivier Matz 
> > Sent: Thursday, September 29, 2022 8:22 PM
> > To: dev@dpdk.org
> > Cc: Yang, Qiming ; Wu, Wenjun1
> > ; Zhao1, Wei 
> > Subject: [PATCH] net/ixgbevf: fix promiscuous and allmulti
> > 
> > The configuration of allmulti and promiscuous modes conflicts together. For
> > instance, if we enable promiscuous mode, then enable and disable allmulti,
> > then the promiscuous mode is wrongly disabled.
> > 
> > Fix this behavior by:
> > - doing nothing when we set/unset allmulti if promiscuous mode is on
> > - restorting the proper mode (none or allmulti) when we disable
> >   promiscuous mode
> > 
> > Fixes: 1f4564ed7696 ("net/ixgbevf: enable promiscuous mode")
> > 
> > Signed-off-by: Olivier Matz 
> > ---
> > 
> > Hi,
> > 
> > For reference, this was tested with this plan:
> > 
> > echo 8 > "/sys/bus/pci/devices/:01:00.1/sriov_numvfs"
> > ip link set dev eno2 up
> > ip link set dev eno2 promisc on
> > bridge link set dev eno2 hwmode veb
> > ip link set dev eno2 mtu 9000
> > 
> > ip link set dev eno2 vf 0 mac ac:1f:6b:fe:ba:b0 ip link set dev eno2 vf 0
> > spoofchk off ip link set dev eno2 vf 0 trust on
> > 
> > ip link set dev eno2 vf 1 mac ac:1f:6b:fe:ba:b1 ip link set dev eno2 vf 1
> > spoofchk off ip link set dev eno2 vf 1 trust on
> > 
> > python3 usertools/dpdk-devbind.py -s
> > python3 usertools/dpdk-devbind.py -b vfio-pci :01:10.1   # vf 0
> > python3 usertools/dpdk-devbind.py -b ixgbevf :01:10.3# vf 1
> > 
> > 
> > # in another terminal
> > scapy
> > while True:
> >   sendp(Ether(dst='ac:1f:6b:00:00:00'), iface='eno2v1')  # wrong mac
> >   sendp(Ether(dst='ac:1f:6b:fe:ba:b0'), iface='eno2v1')  # correct mac
> >   time.sleep(1)
> > 
> > 
> > ./build/app/dpdk-testpmd -l 1,2 -a :01:10.1 -- -i --total-num-
> > mbufs=32768 show port info all set fwd rxonly set verbose 1 set promisc all
> > off set allmulti all off start
> > 
> > # ok, only packets to dst='ac:1f:6b:fe:ba:b0' are received
> > 
> > 
> > # ok, both packets are received
> > set promisc all on
> > 
> > 
> > # nok, only packets to dst='ac:1f:6b:fe:ba:b0' are received set allmulti 
> > all on
> > set allmulti all off
> > 
> > 
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 12 +++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index 8cec951d94..cc8383c5a9 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -7785,9 +7785,13 @@ static int
> >  ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev)  {
> > struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
> > >dev_private);
> > +   int mode = IXGBEVF_XCAST_MODE_NONE;
> > int ret;
> > 
> > -   switch (hw->mac.ops.update_xcast_mode(hw,
> > IXGBEVF_XCAST_MODE_NONE)) {
> > +   if (dev->data->all_multicast)
> > +   mode = IXGBEVF_XCAST_MODE_ALLMULTI;
> > +
> > +   switch (hw->mac.ops.update_xcast_mode(hw, mode)) {
> > case IXGBE_SUCCESS:
> > ret = 0;
> > break;
> > @@ -7809,6 +7813,9 @@ ixgbevf_dev_allmulticast_enable(struct
> > rte_eth_dev *dev)
> > int ret;
> > int mode = IXGBEVF_XCAST_MODE_ALLMULTI;
> > 
> > +   if (dev->data->promiscuous)
> > +   return 0;
> > +
> > switch (hw->mac.ops.update_xcast_mode(hw, mode)) {
> > case IXGBE_SUCCESS:
> > ret = 0;
> > @@ -7830,6 +7837,9 @@ ixgbevf_dev_allmulticast_disable(struct
> > rte_eth_dev *dev)
> > struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
> > >dev_private);
> > int ret;
> > 
> > +   if (dev->data->promiscuous)
> > +   return 0;
> > +
> 
> It seems that we cannot actually turn off allmulticast mode when promiscuous
> mode is enabled, so can we return error and add a log message here as a
> reminder?

I think we should not return an error here: when we disable all_multi, there are
2 cases:

1/ promiscuous is off: no issue here, we do as before, we ask the PF to disable
   the all_multi mode

2/ promiscuous is on: we have nothing to ask to the PF, because we still want
   to stay in promisc mode. We just need to remember that all_multi is disabled,
   and this is done already done by the ethdev layer.

On the PF dpdk driver, the behavior is the same: we can enable or disable
promisc and all_multi independently, and changing the all_multi value when
promisc is enabled is allowed and does not impact the rx traffic.


Thanks,
Olivier

> Thanks,
> Wenjun
> 
> > switch (hw->mac.ops.update_xcast_mode(hw,
> > IXGBEVF_XCAST_MODE_MULTI)) {
> > case IXGBE_SUCCESS:
> > ret = 0;
> > --
> > 2.30.2
> 

RE: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

[Harman Kalra]

> -int
> +static int
>  trace_mkdir(void)
>  {
>   struct trace *trace = trace_obj_get();
>   char session[TRACE_DIR_STR_LEN];
> + static bool already_done;
>   char *dir_path;
>   int rc;
> 
> + if (already_done)
> + return 0;
> +
Hi David

I was trying out "trace: take live traces via telemetry" patch
I came across following scenario
- Started testpmd with trace=.*
- Executed /trace/save from telemetry script, trace file saved successfully
- Later after stopping application, rte_eal_cleanup() did not save the trace.

With this we lost traces after /trace/save executed

This happened because "already_done" was set after rte_trace_save() called via 
telemetry.
Later rte_eal_cleanup returned from this point without saving later traces.

What is the purpose of already_done flag?

Thanks
Harman


>   if (!trace->dir_offset) {
>   dir_path = calloc(1, sizeof(trace->dir));
>   if (dir_path == NULL) {
> @@ -365,6 +369,7 @@ trace_mkdir(void)
>   }
> 
>   RTE_LOG(INFO, EAL, "Trace dir: %s\n", trace->dir);
> + already_done = true;

[PATCH v2] common/qat: read hw slice configuration

[Arek Kusztal]

Read slice configuration of QAT capabilities.
This will allow to recognize if specific hw function
is available on particular device.

Signed-off-by: Arek Kusztal 
---
 drivers/common/qat/dev/qat_dev_gen1.c|  8 +++
 drivers/common/qat/dev/qat_dev_gen2.c|  8 +++
 drivers/common/qat/dev/qat_dev_gen3.c| 14 +
 drivers/common/qat/dev/qat_dev_gen4.c|  8 +++
 drivers/common/qat/qat_adf/icp_qat_hw.h  | 18 +++
 drivers/common/qat/qat_device.c  | 10 +++-
 drivers/common/qat/qat_device.h  |  5 ++
 drivers/crypto/qat/dev/qat_asym_pmd_gen1.c   | 42 ---
 drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c | 41 +++---
 drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 80 +---
 drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 41 +++---
 drivers/crypto/qat/dev/qat_crypto_pmd_gens.h |  5 +-
 drivers/crypto/qat/dev/qat_sym_pmd_gen1.c| 41 +++---
 drivers/crypto/qat/qat_asym.c| 49 -
 drivers/crypto/qat/qat_crypto.h  |  4 +-
 drivers/crypto/qat/qat_sym.c | 38 +
 16 files changed, 324 insertions(+), 88 deletions(-)

diff --git a/drivers/common/qat/dev/qat_dev_gen1.c 
b/drivers/common/qat/dev/qat_dev_gen1.c
index c34ae5a51c..0be5b9077c 100644
--- a/drivers/common/qat/dev/qat_dev_gen1.c
+++ b/drivers/common/qat/dev/qat_dev_gen1.c
@@ -241,12 +241,20 @@ qat_dev_get_extra_size_gen1(void)
return 0;
 }
 
+static int
+qat_get_slice_map_gen1(uint16_t *map __rte_unused,
+   const struct rte_pci_device *pci_dev __rte_unused)
+{
+   return 0;
+}
+
 static struct qat_dev_hw_spec_funcs qat_dev_hw_spec_gen1 = {
.qat_dev_reset_ring_pairs = qat_reset_ring_pairs_gen1,
.qat_dev_get_transport_bar = qat_dev_get_transport_bar_gen1,
.qat_dev_get_misc_bar = qat_dev_get_misc_bar_gen1,
.qat_dev_read_config = qat_dev_read_config_gen1,
.qat_dev_get_extra_size = qat_dev_get_extra_size_gen1,
+   .qat_get_slice_map = qat_get_slice_map_gen1,
 };
 
 RTE_INIT(qat_dev_gen_gen1_init)
diff --git a/drivers/common/qat/dev/qat_dev_gen2.c 
b/drivers/common/qat/dev/qat_dev_gen2.c
index f077fe9eef..cb60fe5309 100644
--- a/drivers/common/qat/dev/qat_dev_gen2.c
+++ b/drivers/common/qat/dev/qat_dev_gen2.c
@@ -21,12 +21,20 @@ static struct qat_qp_hw_spec_funcs qat_qp_hw_spec_gen2 = {
.qat_qp_get_hw_data = qat_qp_get_hw_data_gen1,
 };
 
+static int
+qat_get_slice_map_gen2(uint16_t *map __rte_unused,
+   const struct rte_pci_device *pci_dev __rte_unused)
+{
+   return 0;
+}
+
 static struct qat_dev_hw_spec_funcs qat_dev_hw_spec_gen2 = {
.qat_dev_reset_ring_pairs = qat_reset_ring_pairs_gen1,
.qat_dev_get_transport_bar = qat_dev_get_transport_bar_gen1,
.qat_dev_get_misc_bar = qat_dev_get_misc_bar_gen1,
.qat_dev_read_config = qat_dev_read_config_gen1,
.qat_dev_get_extra_size = qat_dev_get_extra_size_gen1,
+   .qat_get_slice_map = qat_get_slice_map_gen2,
 };
 
 RTE_INIT(qat_dev_gen_gen2_init)
diff --git a/drivers/common/qat/dev/qat_dev_gen3.c 
b/drivers/common/qat/dev/qat_dev_gen3.c
index de3fa17fa9..681c946ede 100644
--- a/drivers/common/qat/dev/qat_dev_gen3.c
+++ b/drivers/common/qat/dev/qat_dev_gen3.c
@@ -5,6 +5,7 @@
 #include "qat_device.h"
 #include "qat_qp.h"
 #include "adf_transport_access_macros.h"
+#include "icp_qat_hw.h"
 #include "qat_dev_gens.h"
 
 #include 
@@ -67,12 +68,25 @@ static struct qat_qp_hw_spec_funcs qat_qp_hw_spec_gen3 = {
.qat_qp_get_hw_data = qat_qp_get_hw_data_gen3
 };
 
+static int
+qat_get_slice_map_gen3(uint16_t *map,
+   const struct rte_pci_device *pci_dev)
+{
+   if (rte_pci_read_config(pci_dev, map,
+   ADF1_C4XXXIOV_VFLEGFUSES_LEN,
+   ADF_C4XXXIOV_VFLEGFUSES_OFFSET) < 0) {
+   return -1;
+   }
+   return 0;
+}
+
 static struct qat_dev_hw_spec_funcs qat_dev_hw_spec_gen3 = {
.qat_dev_reset_ring_pairs = qat_reset_ring_pairs_gen1,
.qat_dev_get_transport_bar = qat_dev_get_transport_bar_gen1,
.qat_dev_get_misc_bar = qat_dev_get_misc_bar_gen1,
.qat_dev_read_config = qat_dev_read_config_gen1,
.qat_dev_get_extra_size = qat_dev_get_extra_size_gen1,
+   .qat_get_slice_map = qat_get_slice_map_gen3,
 };
 
 RTE_INIT(qat_dev_gen_gen3_init)
diff --git a/drivers/common/qat/dev/qat_dev_gen4.c 
b/drivers/common/qat/dev/qat_dev_gen4.c
index 85d6ddfcf4..1683371433 100644
--- a/drivers/common/qat/dev/qat_dev_gen4.c
+++ b/drivers/common/qat/dev/qat_dev_gen4.c
@@ -283,6 +283,13 @@ qat_dev_get_misc_bar_gen4(struct rte_mem_resource 
**mem_resource,
 }
 
 static int
+qat_get_slice_map_gen4(uint16_t *map __rte_unused,
+   const struct rte_pci_device *pci_dev __rte_unused)
+{
+   return 0;
+}
+
+static int
 qat_dev_get_extra_size_gen4(void)
 {
return sizeof(struct qat_dev_gen4_extra);
@@ -294,6 +301,7 @@ static struct qat_dev_hw_spec

Re: [PATCH 1/2] build: allow to conditionally build apps

[Markus Theil]

On 10/12/22 17:19, Bruce Richardson wrote:

On Wed, Oct 12, 2022 at 04:47:03PM +0200, Markus Theil wrote:

Makes apps configureable from meson, like already
possible for drivers.

Signed-off-by: Markus Theil 
---
  app/meson.build   | 17 -
  meson_options.txt |  4 
  2 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/app/meson.build b/app/meson.build
index 93d8c15032..4d9c8ee814 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -1,6 +1,9 @@
  # SPDX-License-Identifier: BSD-3-Clause
  # Copyright(c) 2017-2019 Intel Corporation
  
+enabled_apps = get_option('enable_apps')

+disabled_apps = get_option('disable_apps')
+
  apps = [
  'dumpcap',
  'pdump',
@@ -27,7 +30,11 @@ if get_option('default_library') == 'static' and not 
is_windows
  endif
  
  foreach app:apps

-build = true
+build = enabled_apps == '' or enabled_apps.contains(app)
+# let disabled_apps override enabled_apps
+if disabled_apps != ''
+build = build and not disabled_apps.contains(app)
+endif
  name = app
  sources = []
  includes = []
@@ -41,6 +48,10 @@ foreach app:apps
  ext_deps = []
  deps = []
  
+if not build

+continue
+endif
+
  subdir(name)
  
  if build

@@ -56,10 +67,6 @@ foreach app:apps
  endforeach
  endif
  
-if not build

-continue
-endif
-

Does this block not still need to be kept? Is it possible that build could
be set to false in the subdir or other logic?
I will move the block to its old position in the next revision. Thanks 
for the hint.

/Bruce

Re: [PATCH 2/2] build: export dpdk_includes for subproject usage.

[Markus Theil]

On 10/12/22 17:21, Bruce Richardson wrote:

On Wed, Oct 12, 2022 at 04:47:04PM +0200, Markus Theil wrote:

From: Thorben Roemer 

In order to perform things like LTO more easily in
our DPDK applications, we use DPDK as a meson subproject.
Also export includes in order to be usable in this context.

Signed-off-by: Thorben Roemer 
---
  drivers/meson.build | 1 +
  lib/meson.build | 1 +
  meson.build | 1 +
  3 files changed, 3 insertions(+)

diff --git a/drivers/meson.build b/drivers/meson.build
index 216971f4e2..d19b47df12 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -95,6 +95,7 @@ foreach subpath:subdirs
  objs = []
  cflags = default_cflags
  includes = [include_directories(drv_path)]
+dpdk_includes += [include_directories(drv_path)]

I am not sure that by default we should include all the driver directories.
At most, we should only include those drivers which have header files to be
made public. I think initially though we should only export library paths.
I tried to only include libraries. At least for our DPDK-based 
application, the bonding and i40e includes are needed. I therefore tried 
to include all drivers exporting symbols to the dpdk_includes list in 
the following revision.

/Bruce

[PATCH v2 1/2] build: allow to conditionally build apps

[Markus Theil]

Makes apps configurable from meson, like already
possible for drivers.

Signed-off-by: Markus Theil 
---
 app/meson.build   | 9 -
 meson_options.txt | 4 
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/app/meson.build b/app/meson.build
index 93d8c15032..24096e8108 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -1,6 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2019 Intel Corporation
 
+enabled_apps = get_option('enable_apps')
+disabled_apps = get_option('disable_apps')
+
 apps = [
 'dumpcap',
 'pdump',
@@ -27,7 +30,11 @@ if get_option('default_library') == 'static' and not 
is_windows
 endif
 
 foreach app:apps
-build = true
+build = enabled_apps == '' or enabled_apps.contains(app)
+# let disabled_apps override enabled_apps
+if disabled_apps != ''
+build = build and not disabled_apps.contains(app)
+endif
 name = app
 sources = []
 includes = []
diff --git a/meson_options.txt b/meson_options.txt
index 0574dd0fff..9f032d454d 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -6,6 +6,8 @@ option('cpu_instruction_set', type: 'string', value: 'auto',
description: 'Set the target machine ISA (instruction set 
architecture). Will be set according to the platform option by default.')
 option('developer_mode', type: 'feature', description:
'turn on additional build checks relevant for DPDK developers')
+option('disable_apps', type: 'string', value: '', description:
+   'Comma-separated list of apps to explicitly disable.')
 option('disable_drivers', type: 'string', value: '', description:
'Comma-separated list of drivers to explicitly disable.')
 option('disable_libs', type: 'string', value: 'kni', description:
@@ -14,6 +16,8 @@ option('drivers_install_subdir', type: 'string', value: 
'dpdk/pmds-', d
'Subdirectory of libdir where to install PMDs. Defaults to using a 
versioned subdirectory.')
 option('enable_docs', type: 'boolean', value: false, description:
'build documentation')
+option('enable_apps', type: 'string', value: '', description:
+   'Comma-separated list of apps to build. If unspecified, build all 
apps.')
 option('enable_drivers', type: 'string', value: '', description:
'Comma-separated list of drivers to build. If unspecified, build all 
drivers.')
 option('enable_driver_sdk', type: 'boolean', value: false, description:
-- 
2.38.0

[PATCH v2 2/2] build: export dpdk_includes for subproject usage.

[Markus Theil]

From: Thorben Roemer 

In order to perform things like LTO more easily in
our DPDK applications, we use DPDK as a meson subproject.
Also export includes in order to be usable in this context.

Signed-off-by: Thorben Roemer 
---
 lib/meson.build | 1 +
 meson.build | 1 +
 2 files changed, 2 insertions(+)

diff --git a/lib/meson.build b/lib/meson.build
index f858844fa2..85113d0b47 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -190,6 +190,7 @@ foreach l:libraries
 
 libname = 'rte_' + name
 includes += include_directories(l)
+dpdk_includes += include_directories(l)
 
 if developer_mode and is_windows and use_function_versioning
 message('@0@: Function versioning is not supported by 
Windows.'.format(name))
diff --git a/meson.build b/meson.build
index 1d35a255c3..d1cf039297 100644
--- a/meson.build
+++ b/meson.build
@@ -32,6 +32,7 @@ cc = meson.get_compiler('c')
 dpdk_source_root = meson.current_source_dir()
 dpdk_build_root = meson.current_build_dir()
 dpdk_conf = configuration_data()
+dpdk_includes = []
 dpdk_libraries = []
 dpdk_static_libraries = []
 dpdk_shared_lib_deps = []
-- 
2.38.0

[PATCH v3 1/2] build: allow to conditionally build apps

[Markus Theil]

Makes apps configurable from meson, like already
possible for drivers.

Signed-off-by: Markus Theil 
---
 app/meson.build   | 9 -
 meson_options.txt | 4 
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/app/meson.build b/app/meson.build
index 93d8c15032..24096e8108 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -1,6 +1,9 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2019 Intel Corporation
 
+enabled_apps = get_option('enable_apps')
+disabled_apps = get_option('disable_apps')
+
 apps = [
 'dumpcap',
 'pdump',
@@ -27,7 +30,11 @@ if get_option('default_library') == 'static' and not 
is_windows
 endif
 
 foreach app:apps
-build = true
+build = enabled_apps == '' or enabled_apps.contains(app)
+# let disabled_apps override enabled_apps
+if disabled_apps != ''
+build = build and not disabled_apps.contains(app)
+endif
 name = app
 sources = []
 includes = []
diff --git a/meson_options.txt b/meson_options.txt
index 0574dd0fff..9f032d454d 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -6,6 +6,8 @@ option('cpu_instruction_set', type: 'string', value: 'auto',
description: 'Set the target machine ISA (instruction set 
architecture). Will be set according to the platform option by default.')
 option('developer_mode', type: 'feature', description:
'turn on additional build checks relevant for DPDK developers')
+option('disable_apps', type: 'string', value: '', description:
+   'Comma-separated list of apps to explicitly disable.')
 option('disable_drivers', type: 'string', value: '', description:
'Comma-separated list of drivers to explicitly disable.')
 option('disable_libs', type: 'string', value: 'kni', description:
@@ -14,6 +16,8 @@ option('drivers_install_subdir', type: 'string', value: 
'dpdk/pmds-', d
'Subdirectory of libdir where to install PMDs. Defaults to using a 
versioned subdirectory.')
 option('enable_docs', type: 'boolean', value: false, description:
'build documentation')
+option('enable_apps', type: 'string', value: '', description:
+   'Comma-separated list of apps to build. If unspecified, build all 
apps.')
 option('enable_drivers', type: 'string', value: '', description:
'Comma-separated list of drivers to build. If unspecified, build all 
drivers.')
 option('enable_driver_sdk', type: 'boolean', value: false, description:
-- 
2.38.0

[PATCH v3 2/2] build: export dpdk_includes for subproject usage.

[Markus Theil]

From: Thorben Roemer 

In order to perform things like LTO more easily in
our DPDK applications, we use DPDK as a meson subproject.
Also export includes in order to be usable in this context.

Signed-off-by: Thorben Roemer 
---
 drivers/baseband/fpga_5gnr_fec/meson.build | 2 ++
 drivers/dma/dpaa2/meson.build  | 2 ++
 drivers/event/dlb2/meson.build | 2 ++
 drivers/mempool/dpaa2/meson.build  | 2 ++
 drivers/net/atlantic/meson.build   | 2 ++
 drivers/net/bnxt/meson.build   | 2 ++
 drivers/net/bonding/meson.build| 2 ++
 drivers/net/cnxk/meson.build   | 2 ++
 drivers/net/dpaa/meson.build   | 2 ++
 drivers/net/dpaa2/meson.build  | 2 ++
 drivers/net/i40e/meson.build   | 2 ++
 drivers/net/iavf/meson.build   | 2 ++
 drivers/net/ixgbe/meson.build  | 2 ++
 drivers/net/memif/meson.build  | 2 ++
 drivers/net/mlx5/meson.build   | 2 ++
 drivers/net/ring/meson.build   | 2 ++
 drivers/net/softnic/meson.build| 2 ++
 drivers/net/vhost/meson.build  | 2 ++
 drivers/raw/cnxk_bphy/meson.build  | 2 ++
 drivers/raw/cnxk_gpio/meson.build  | 2 ++
 drivers/raw/dpaa2_cmdif/meson.build| 2 ++
 drivers/raw/ifpga/meson.build  | 2 ++
 drivers/raw/ntb/meson.build| 2 ++
 lib/meson.build| 1 +
 meson.build| 1 +
 25 files changed, 48 insertions(+)

diff --git a/drivers/baseband/fpga_5gnr_fec/meson.build 
b/drivers/baseband/fpga_5gnr_fec/meson.build
index 745cd271f2..b2b218e9f9 100644
--- a/drivers/baseband/fpga_5gnr_fec/meson.build
+++ b/drivers/baseband/fpga_5gnr_fec/meson.build
@@ -6,3 +6,5 @@ deps += ['bbdev', 'bus_vdev', 'ring', 'pci', 'bus_pci']
 sources = files('rte_fpga_5gnr_fec.c')
 
 headers = files('rte_pmd_fpga_5gnr_fec.h')
+
+dpdk_includes += include_directories('.')
diff --git a/drivers/dma/dpaa2/meson.build b/drivers/dma/dpaa2/meson.build
index a99151e2a5..672f820f16 100644
--- a/drivers/dma/dpaa2/meson.build
+++ b/drivers/dma/dpaa2/meson.build
@@ -16,3 +16,5 @@ if cc.has_argument('-Wno-pointer-arith')
 endif
 
 headers = files('rte_pmd_dpaa2_qdma.h')
+
+dpdk_includes += include_directories('.')
diff --git a/drivers/event/dlb2/meson.build b/drivers/event/dlb2/meson.build
index 20ef159ab3..aeffc5d4da 100644
--- a/drivers/event/dlb2/meson.build
+++ b/drivers/event/dlb2/meson.build
@@ -65,3 +65,5 @@ endif
 headers = files('rte_pmd_dlb2.h')
 
 deps += ['mbuf', 'mempool', 'ring', 'pci', 'bus_pci']
+
+dpdk_includes += include_directories('.')
diff --git a/drivers/mempool/dpaa2/meson.build 
b/drivers/mempool/dpaa2/meson.build
index 3d16d44158..559d36d9a8 100644
--- a/drivers/mempool/dpaa2/meson.build
+++ b/drivers/mempool/dpaa2/meson.build
@@ -10,3 +10,5 @@ deps += ['bus_fslmc']
 sources = files('dpaa2_hw_mempool.c')
 
 headers = files('rte_dpaa2_mempool.h')
+
+dpdk_includes += include_directories('.')
diff --git a/drivers/net/atlantic/meson.build b/drivers/net/atlantic/meson.build
index bf5e47eaaf..6a6d176b45 100644
--- a/drivers/net/atlantic/meson.build
+++ b/drivers/net/atlantic/meson.build
@@ -17,3 +17,5 @@ sources = files(
 'hw_atl/hw_atl_utils.c',
 'rte_pmd_atlantic.c',
 )
+
+dpdk_includes += include_directories('.')
diff --git a/drivers/net/bnxt/meson.build b/drivers/net/bnxt/meson.build
index 09d494e90f..af9a58ac9e 100644
--- a/drivers/net/bnxt/meson.build
+++ b/drivers/net/bnxt/meson.build
@@ -68,3 +68,5 @@ if arch_subdir == 'x86'
 elif arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')
 sources += files('bnxt_rxtx_vec_neon.c')
 endif
+
+dpdk_includes += include_directories('.')
diff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build
index 29022712cb..41b0903374 100644
--- a/drivers/net/bonding/meson.build
+++ b/drivers/net/bonding/meson.build
@@ -23,3 +23,5 @@ deps += ['ip_frag']
 
 headers = files('rte_eth_bond.h', 'rte_eth_bond_8023ad.h')
 pmd_supports_disable_iova_as_pa = true
+
+dpdk_includes += include_directories('.')
diff --git a/drivers/net/cnxk/meson.build b/drivers/net/cnxk/meson.build
index 5efb2000cf..d43f0b53d1 100644
--- a/drivers/net/cnxk/meson.build
+++ b/drivers/net/cnxk/meson.build
@@ -195,3 +195,5 @@ endforeach
 
 headers = files('rte_pmd_cnxk.h')
 pmd_supports_disable_iova_as_pa = true
+
+dpdk_includes += include_directories('.')
diff --git a/drivers/net/dpaa/meson.build b/drivers/net/dpaa/meson.build
index 42e1f8c2e2..6927c3644c 100644
--- a/drivers/net/dpaa/meson.build
+++ b/drivers/net/dpaa/meson.build
@@ -21,3 +21,5 @@ if cc.has_argument('-Wno-pointer-arith')
 endif
 
 headers = files('rte_pmd_dpaa.h')
+
+dpdk_includes += include_directories('.')
diff --git a/drivers/net/dpaa2/meson.build b/drivers/net/dpaa2/meson.build
index 51598c048c..d5f71deb29 100644
--- a/drivers/net/dpaa2/meson.build
+++ b/drivers/net/dpaa2/meson.build
@@ -27,3 +27,5 @@ sources = fil

DPDK Release Status Meeting 2022-10-13

[Mcnamara, John]

Release status meeting minutes 2022-10-13
=

Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens

Participants:
* ARM
* Canonical [No]
* Debian/Microsoft [No]
* Intel
* Marvell
* Nvidia
* Red Hat
* Xilinx/AMD


Release Dates
-

The following are the proposed current dates for 22.11:

* V1 deadline: 24 August   2022
* RC1:  7 October  2022 - Was 3 October
* RC2: 23 October  2022
* RC3: 31 October  2022
* Release: 16 November 2022

Subtrees



* next-net
  * RC1 out
  * Hairpin feature is merged
  * Ethdev - Dumping Rx/Tx descriptors - merged
  * Ethdev - Recovering events sent by driver - has comments that need to be 
addressed
  * New drivers in this release:
* Microsoft Azure Network Adapter (MANA) PMD
  * Merged in RC1
  * However, there is an issue due to dependencies not being available
  * Compilation will be disabled until dependencies become available
* Google Virtual Ethernet (GVE)
  * Some discussion on MIT licenced code
  * Went to governing board review
* idpf (Infrastructure Data Path Function) PMD
  * Under review
* net/qdma PMD
  * Awaiting reply from submitter
  * Memif driver needs reviews from maintainer

* next-net-intel
  * Some fixes merged

* next-net-mlx
  * Some big changes to come on hardware steering for RC2

* next-net-mrvl
  * 13 patches to merge. 2 merged.

* next-eventdev
  * 4 patches from Intel merged
  * 4 patches from E/// under review

* next-virtio
  * Actively reviewing patches, ~24 in queue

* next-crypto
  * QAT crypto driver patches need ack
  * Patches around BBDev
* 1 patchset merged and 1 pending
  * New Huawei UADK driver

* main
  * RC1 out. Features merged:
* LoongArch merged
* Windows Thread API merged
* Buffer split merge
* Member library with NitroSketch
* Power library
* See announce for full list: 
http://mails.dpdk.org/archives/announce/2022-October/000428.html
  * Telemetry series under discussion
  * Memarea postponed
* Needs other reviews
  * Mempool changes need tests and reviews prior to merge in RC2
  * Regression on unit tests due to mempool changes
  * Meson version upgraded to 0.53.2.
  * KNI deprecation warnings added for compile and runtime
  * We should also upgrade the minimum required kernel version for 22.11
* Suggestions welcome



Proposed Schedule for 2023

23.03
  * Proposal deadline (RFC/v1 patches): 30 December 2022
  * API freeze (-rc1): 10 February 2023
  * PMD features freeze (-rc2): 24 February 2023
  * Built-in applications features freeze (-rc3): 3 March 2023
  * Release: 10 March 2023
23.07
  * Proposal deadline (RFC/v1 patches): 7 April 2023
  * API freeze (-rc1): 26 May 2023
  * PMD features freeze (-rc2): 16 June 2023
  * Built-in applications features freeze (-rc3): 23 June 2023
  * Release: 14 July 2023
23.11
  * Proposal deadline (RFC/v1 patches): 11 August 2023
  * API freeze (-rc1): 29 September 2023
  * PMD features freeze (-rc2): 20 October 2023
  * Built-in applications features freeze (-rc3): 27 October 2023
  * Release: 17 November 2023


Other
-

* TBA

LTS
---

LTSes released on August 29th.

* 21.11.2

* 20.11.6

* 19.11.13

Discussion needed on whether we will continue the 3 year LTS cycle that
was trialed for 19.11 to the 20.11 LTS cycle.


* Distros
  * v20.11 in Debian 11
  * Ubuntu 22.04 contains 21.11

Defects
---

* Bugzilla links, 'Bugs',  added for hosted projects
  * https://www.dpdk.org/hosted-projects/


Opens
-

* None


DPDK Release Status Meetings


The DPDK Release Status Meeting is intended for DPDK Committers to discuss the
status of the master tree and sub-trees, and for project managers to track
progress or milestone dates.

The meeting occurs on every Thursday at 9:30 UTC. on https://meet.jit.si/DPDK

If you wish to attend just send an email to "John McNamara 
john.mcnam...@intel.com" for the invite.


Drafts/Notes
-

Re: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

[David Marchand]

On Thu, Oct 13, 2022 at 4:53 PM Harman Kalra  wrote:
>
>
> > -int
> > +static int
> >  trace_mkdir(void)
> >  {
> >   struct trace *trace = trace_obj_get();
> >   char session[TRACE_DIR_STR_LEN];
> > + static bool already_done;
> >   char *dir_path;
> >   int rc;
> >
> > + if (already_done)
> > + return 0;
> > +
> Hi David
>
> I was trying out "trace: take live traces via telemetry" patch
> I came across following scenario
> - Started testpmd with trace=.*
> - Executed /trace/save from telemetry script, trace file saved successfully
> - Later after stopping application, rte_eal_cleanup() did not save the trace.
>
> With this we lost traces after /trace/save executed

Sorry, I must be missing something.
What patches did you apply and how are you testing?

With the whole traces fixes series applied first, then the new "trace:
take live traces via telemetry" patch applied, I can't reproduce your
issue.


Here is what I did:
$ ./build/app/dpdk-testpmd -c 3 --no-huge -m 40 -a 0:0.0 -d
build-gcc/drivers --vdev net_null1 --vdev net_null2 --trace=.* --
--no-mlockall --total-num-mbufs=2048 -ia

--> /trace/save
{"/trace/save": {"Status": "OK", "Path":
"/home/dmarchan/dpdk-traces/rte-2022-10-13-PM-05-44-56"}}

At this point, the trace file contains events until:
...
[17:44:50.738892453] (+0.00154) lib.eal.mem.malloc: { cpu_id =
0x0, name = "dpdk-testpmd" }, { type = "", size = 0x0, align = 0x0,
socket = 0, ptr = 0x0 }
[17:44:50.738892470] (+0.00017) lib.eal.mem.zmalloc: { cpu_id =
0x0, name = "dpdk-testpmd" }, { type = "", size = 0x0, align = 0x0,
socket = 0, ptr = 0x0 }
[17:44:50.738894858] (+0.02388) lib.eal.mem.malloc: { cpu_id =
0x0, name = "dpdk-testpmd" }, { type = "", size = 0x0, align = 0x0,
socket = 0, ptr = 0x0 }
[17:44:50.738894881] (+0.00023) lib.eal.mem.zmalloc: { cpu_id =
0x0, name = "dpdk-testpmd" }, { type = "", size = 0x0, align = 0x0,
socket = 0, ptr = 0x0 }
[17:44:50.738894899] (+0.00018) lib.ethdev.rxq.setup: { cpu_id =
0x0, name = "dpdk-testpmd" }, { port_id = 0x1, rx_queue_id = 0x0,
nb_rx_desc = 0x200, mp = 0x101A9E540, rx_conf_rx_thresh_pthresh = 0x0,
rx_conf_rx_thresh_hthresh = 0x0, rx_conf_rx_thresh_wthresh = 0x0,
rx_conf_rx_drop_en = 0x0, rx_conf_rx_deferred_start = 0x0,
rx_conf_offloads = 0x0, rc = 0 }
[17:44:50.738895490] (+0.00591) lib.ethdev.start: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { port_id = 0x1 }
[17:44:50.738908652] (+0.13162) lib.eal.memzone.lookup: { cpu_id =
0x0, name = "dpdk-testpmd" }, { name = "RTE_METRICS", memzone = 0x0 }
[17:44:50.738912231] (+0.03579) lib.eal.memzone.reserve: { cpu_id
= 0x0, name = "dpdk-testpmd" }, { name = "RTE_METRICS", len = 0x15010,
socket_id = 0, flags = 0x0, align = 0x40, bound = 0x0, mz =
0x17168 }
[17:44:50.779538885] (+0.040626654) lib.eal.thread.remote.launch: {
cpu_id = 0x0, name = "dpdk-testpmd" }, { f = 0x458130, arg =
0x101C20780, worker_id = 0x1, rc = 0 }


Then, I stop testpmd, and look again at the same trace file:
...
[17:44:50.779538885] (+0.040626654) lib.eal.thread.remote.launch: {
cpu_id = 0x0, name = "dpdk-testpmd" }, { f = 0x458130, arg =
0x101C20780, worker_id = 0x1, rc = 0 }
[17:45:12.630581221] (+21.851042336) lib.ethdev.stop: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { port_id = 0x0, ret = 0 }
[17:45:12.630590961] (+0.09740) lib.ethdev.stop: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { port_id = 0x1, ret = 0 }
[17:45:12.630601415] (+0.10454) lib.ethdev.close: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { port_id = 0x0 }
[17:45:12.630606931] (+0.05516) lib.eal.mem.free: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { ptr = 0x10126D700 }
[17:45:12.630618608] (+0.11677) lib.eal.mem.free: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { ptr = 0x10126B680 }
[17:45:12.630621015] (+0.02407) lib.eal.mem.free: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { ptr = 0x0 }
[17:45:12.630621038] (+0.00023) lib.eal.mem.free: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { ptr = 0x0 }
[17:45:12.630621062] (+0.00024) lib.eal.mem.free: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { ptr = 0x102643B40 }
[17:45:12.630668837] (+0.47775) lib.ethdev.close: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { port_id = 0x1 }
[17:45:12.630671206] (+0.02369) lib.eal.mem.free: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { ptr = 0x101269480 }
[17:45:12.630673731] (+0.02525) lib.eal.mem.free: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { ptr = 0x101267400 }
[17:45:12.630675638] (+0.01907) lib.eal.mem.free: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { ptr = 0x0 }
[17:45:12.630675662] (+0.00024) lib.eal.mem.free: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { ptr = 0x0 }
[17:45:12.630675685] (+0.00023) lib.eal.mem.free: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { ptr = 0x10262F940 }
[17:45:12.630712155] (+0.36470) lib.eal.mem.free: { cpu_id = 0x0,
name = "dpdk-testpmd" }, { ptr = 0x101C206C0 }
[17:45:12.630712692] (+0.00537) lib.mempool.free: { cpu_id = 0x0,
name = "dpdk-testpm

RE: [PATCH] net/mana: disable driver by default

[Long Li]

> Subject: [PATCH] net/mana: disable driver by default
> 
> Driver is disabled by default because its dependencies are not upstreamed
> yet, code is available for development and investigation.
> 
> When all dependencies are upstreamed, driver can be enabled back.
> 
> Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment")
> 
> Signed-off-by: Ferruh Yigit 

Acked-by: Long Li 

> ---
> Cc: Long Li 
> Cc: Stephen Hemminger 
> ---
>  MAINTAINERS| 2 +-
>  doc/guides/nics/index.rst  | 1 -
>  doc/guides/rel_notes/release_22_11.rst | 2 ++
>  drivers/net/meson.build| 1 -
>  4 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2bd4a55f1b0a..fe6c0a60b628 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -828,7 +828,7 @@ F: buildtools/options-ibverbs-static.sh
>  F: doc/guides/nics/mlx5.rst
>  F: doc/guides/nics/features/mlx5.ini
> 
> -Microsoft mana
> +Microsoft mana - EXPERIMENTAL
>  M: Long Li 
>  F: drivers/net/mana/
>  F: doc/guides/nics/mana.rst
> diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst index
> 32c754496827..f80906a97d1b 100644
> --- a/doc/guides/nics/index.rst
> +++ b/doc/guides/nics/index.rst
> @@ -41,7 +41,6 @@ Network Interface Controller Drivers
>  intel_vf
>  kni
>  liquidio
> -mana
>  memif
>  mlx4
>  mlx5
> diff --git a/doc/guides/rel_notes/release_22_11.rst
> b/doc/guides/rel_notes/release_22_11.rst
> index 2da8bc9661af..79bc36815659 100644
> --- a/doc/guides/rel_notes/release_22_11.rst
> +++ b/doc/guides/rel_notes/release_22_11.rst
> @@ -142,6 +142,8 @@ New Features
> 
>  * **Added Microsoft mana driver.**
> 
> +  Disabled by default because of missing dependency.
> +
>  * **Updated Netronome nfp driver.**
> 
>Added the needed data structures and logics to support flow API offload:
> diff --git a/drivers/net/meson.build b/drivers/net/meson.build index
> 35bfa78dee66..37919eaf8b02 100644
> --- a/drivers/net/meson.build
> +++ b/drivers/net/meson.build
> @@ -34,7 +34,6 @@ drivers = [
>  'ixgbe',
>  'kni',
>  'liquidio',
> -'mana',
>  'memif',
>  'mlx4',
>  'mlx5',
> --
> 2.25.1

Re: [PATCH 1/2] build: allow to conditionally build apps

[Bruce Richardson]

On Thu, Oct 13, 2022 at 05:11:38PM +0200, Markus Theil wrote:
> On 10/12/22 17:19, Bruce Richardson wrote:
> > On Wed, Oct 12, 2022 at 04:47:03PM +0200, Markus Theil wrote:
> > > Makes apps configureable from meson, like already
> > > possible for drivers.
> > > 
> > > Signed-off-by: Markus Theil 
> > > ---
> > >   app/meson.build   | 17 -
> > >   meson_options.txt |  4 
> > >   2 files changed, 16 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/app/meson.build b/app/meson.build
> > > index 93d8c15032..4d9c8ee814 100644
> > > --- a/app/meson.build
> > > +++ b/app/meson.build
> > > @@ -1,6 +1,9 @@
> > >   # SPDX-License-Identifier: BSD-3-Clause
> > >   # Copyright(c) 2017-2019 Intel Corporation
> > > +enabled_apps = get_option('enable_apps')
> > > +disabled_apps = get_option('disable_apps')
> > > +
> > >   apps = [
> > >   'dumpcap',
> > >   'pdump',
> > > @@ -27,7 +30,11 @@ if get_option('default_library') == 'static' and not 
> > > is_windows
> > >   endif
> > >   foreach app:apps
> > > -build = true
> > > +build = enabled_apps == '' or enabled_apps.contains(app)
> > > +# let disabled_apps override enabled_apps
> > > +if disabled_apps != ''
> > > +build = build and not disabled_apps.contains(app)
> > > +endif
> > >   name = app
> > >   sources = []
> > >   includes = []
> > > @@ -41,6 +48,10 @@ foreach app:apps
> > >   ext_deps = []
> > >   deps = []
> > > +if not build
> > > +continue
> > > +endif
> > > +
> > >   subdir(name)
> > >   if build
> > > @@ -56,10 +67,6 @@ foreach app:apps
> > >   endforeach
> > >   endif
> > > -if not build
> > > -continue
> > > -endif
> > > -
> > Does this block not still need to be kept? Is it possible that build could
> > be set to false in the subdir or other logic?
> I will move the block to its old position in the next revision. Thanks for
> the hint.

Not sure you need to undo the move, you might just need two copies of the
check. If an app is explicitly disabled, you may want to skip the
"subdir()" call, so having two "if not build" checks would make sense.

/Bruce

Re: [PATCH v3 2/2] build: export dpdk_includes for subproject usage.

[Bruce Richardson]

On Thu, Oct 13, 2022 at 05:35:39PM +0200, Markus Theil wrote:
> From: Thorben Roemer 
> 
> In order to perform things like LTO more easily in
> our DPDK applications, we use DPDK as a meson subproject.
> Also export includes in order to be usable in this context.
> 
> Signed-off-by: Thorben Roemer 
> ---
>  drivers/baseband/fpga_5gnr_fec/meson.build | 2 ++
>  drivers/dma/dpaa2/meson.build  | 2 ++
>  drivers/event/dlb2/meson.build | 2 ++
>  drivers/mempool/dpaa2/meson.build  | 2 ++
>  drivers/net/atlantic/meson.build   | 2 ++
>  drivers/net/bnxt/meson.build   | 2 ++
>  drivers/net/bonding/meson.build| 2 ++
>  drivers/net/cnxk/meson.build   | 2 ++
>  drivers/net/dpaa/meson.build   | 2 ++
>  drivers/net/dpaa2/meson.build  | 2 ++
>  drivers/net/i40e/meson.build   | 2 ++
>  drivers/net/iavf/meson.build   | 2 ++
>  drivers/net/ixgbe/meson.build  | 2 ++
>  drivers/net/memif/meson.build  | 2 ++
>  drivers/net/mlx5/meson.build   | 2 ++
>  drivers/net/ring/meson.build   | 2 ++
>  drivers/net/softnic/meson.build| 2 ++
>  drivers/net/vhost/meson.build  | 2 ++
>  drivers/raw/cnxk_bphy/meson.build  | 2 ++
>  drivers/raw/cnxk_gpio/meson.build  | 2 ++
>  drivers/raw/dpaa2_cmdif/meson.build| 2 ++
>  drivers/raw/ifpga/meson.build  | 2 ++
>  drivers/raw/ntb/meson.build| 2 ++
>  lib/meson.build| 1 +
>  meson.build| 1 +
>  25 files changed, 48 insertions(+)
> 

Rather than changing all these meson.build files, I think we should be able
to check in drivers/meson.build if the "headers" array is empty. If not,
then add the include path, otherwise skip it.

/Bruce

RE: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

[Harman Kalra]

> -Original Message-
> From: David Marchand 
> Sent: Thursday, October 13, 2022 9:22 PM
> To: Harman Kalra 
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Sunil
> Kumar Kori ; sta...@dpdk.org
> Subject: Re: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points
> 
> On Thu, Oct 13, 2022 at 4:53 PM Harman Kalra  wrote:
> >
> >
> > > -int
> > > +static int
> > >  trace_mkdir(void)
> > >  {
> > >   struct trace *trace = trace_obj_get();
> > >   char session[TRACE_DIR_STR_LEN];
> > > + static bool already_done;
> > >   char *dir_path;
> > >   int rc;
> > >
> > > + if (already_done)
> > > + return 0;
> > > +
> > Hi David
> >
> > I was trying out "trace: take live traces via telemetry" patch I came
> > across following scenario
> > - Started testpmd with trace=.*
> > - Executed /trace/save from telemetry script, trace file saved
> > successfully
> > - Later after stopping application, rte_eal_cleanup() did not save the 
> > trace.
> >
> > With this we lost traces after /trace/save executed
> 
> Sorry, I must be missing something.
> What patches did you apply and how are you testing?

I applied the whole trace fixes series and then tested live traces

> 
> With the whole traces fixes series applied first, then the new "trace:
> take live traces via telemetry" patch applied, I can't reproduce your issue.
> 
> 

Yes, you replicated the same scenario what I tried.
Sorry, I realized that actually it's not an issue, traces generated after 
/trace/save are getting
appended but in the same file (timestamped on /trace/save) on rte_eal_cleanup().

I assumed that trace dir generated with a timestamp will include all the trace 
points emitted
before that timestamp. But in the above scenario same  trace dir includes trace 
points emitted
after this timestamp. I think this is bit confusing. Shall we add a logic where 
if already_done is
set, rename the original trace dir to latest timestamp?

Thanks
Harman

> 
> >
> > This happened because "already_done" was set after rte_trace_save()
> called via telemetry.
> > Later rte_eal_cleanup returned from this point without saving later traces.
> >
> > What is the purpose of already_done flag?
> 
> already_done is used to create the trace directory once, and log a message
> with this directory path once.
> 
> 
> --
> David Marchand

Invitation: DTS Working Group - DPDK @ Thu Oct 20, 2022 9am - 10am (EDT) (dev@dpdk.org)

[nsouthern]

BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VEVENT
DTSTART:20221020T13Z
DTEND:20221020T14Z
DTSTAMP:20221013T172653Z
ORGANIZER;CN=nsouth...@linuxfoundation.org:mailto:nsouthern@linuxfoundation
 .org
UID:6s3tlf8sg4soovm7bjkoqsg...@google.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=Lincoln Lavoie;X-NUM-GUESTS=0:mailto:lylav...@iol.unh.edu
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=lijuan...@intel.com;X-NUM-GUESTS=0:mailto:lijuan...@intel.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=n...@arm.com;X-NUM-GUESTS=0:mailto:n...@arm.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=honnappanagaraha...@gmail.com;X-NUM-GUESTS=0:mailto:honnappanagarah
 a...@gmail.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE
 ;CN=nsouth...@linuxfoundation.org;X-NUM-GUESTS=0:mailto:nsouthern@linuxfoun
 dation.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=honnappa.nagaraha...@arm.com;X-NUM-GUESTS=0:mailto:honnappa.nagarah
 a...@arm.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=dev@dpdk.org;X-NUM-GUESTS=0:mailto:dev@dpdk.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=d...@dpdk.org;X-NUM-GUESTS=0:mailto:d...@dpdk.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=juraj.lin...@pantheon.tech;X-NUM-GUESTS=0:mailto:juraj.linkes@panth
 eon.tech
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=ohily...@iol.unh.edu;X-NUM-GUESTS=0:mailto:ohily...@iol.unh.edu
X-MICROSOFT-CDO-OWNERAPPTID:398660684
CREATED:20221013T172652Z
LAST-MODIFIED:20221013T172652Z
LOCATION:https://zoom.us/j/4239143206?pwd=ajZMVWcvek5GMzJaOE1XM0s2bjhlUT09
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:DTS Working Group - DPDK
TRANSP:OPAQUE
END:VEVENT
END:VCALENDAR


invite.ics
Description: application/ics

Updated invitation: DTS Working Group - DPDK @ Every 2 weeks from 9am to 10am on Thursday (EDT) (dev@dpdk.org)

[nsouthern]

BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VTIMEZONE
TZID:America/Detroit
X-LIC-LOCATION:America/Detroit
BEGIN:DAYLIGHT
TZOFFSETFROM:-0500
TZOFFSETTO:-0400
TZNAME:EDT
DTSTART:19700308T02
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=2SU
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:-0400
TZOFFSETTO:-0500
TZNAME:EST
DTSTART:19701101T02
RRULE:FREQ=YEARLY;BYMONTH=11;BYDAY=1SU
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
DTSTART;TZID=America/Detroit:20221020T09
DTEND;TZID=America/Detroit:20221020T10
RRULE:FREQ=WEEKLY;WKST=SU;INTERVAL=2;BYDAY=TH
DTSTAMP:20221013T172907Z
ORGANIZER;CN=nsouth...@linuxfoundation.org:mailto:nsouthern@linuxfoundation
 .org
UID:6s3tlf8sg4soovm7bjkoqsg...@google.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=Lincoln Lavoie;X-NUM-GUESTS=0:mailto:lylav...@iol.unh.edu
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=lijuan...@intel.com;X-NUM-GUESTS=0:mailto:lijuan...@intel.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=n...@arm.com;X-NUM-GUESTS=0:mailto:n...@arm.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=honnappanagaraha...@gmail.com;X-NUM-GUESTS=0:mailto:honnappanagarah
 a...@gmail.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE
 ;CN=nsouth...@linuxfoundation.org;X-NUM-GUESTS=0:mailto:nsouthern@linuxfoun
 dation.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=honnappa.nagaraha...@arm.com;X-NUM-GUESTS=0:mailto:honnappa.nagarah
 a...@arm.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=dev@dpdk.org;X-NUM-GUESTS=0:mailto:dev@dpdk.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=d...@dpdk.org;X-NUM-GUESTS=0:mailto:d...@dpdk.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=juraj.lin...@pantheon.tech;X-NUM-GUESTS=0:mailto:juraj.linkes@panth
 eon.tech
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=ohily...@iol.unh.edu;X-NUM-GUESTS=0:mailto:ohily...@iol.unh.edu
X-MICROSOFT-CDO-OWNERAPPTID:398660684
CREATED:20221013T172652Z
DESCRIPTION:
LAST-MODIFIED:20221013T172905Z
LOCATION:https://zoom.us/j/4239143206?pwd=ajZMVWcvek5GMzJaOE1XM0s2bjhlUT09
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:DTS Working Group - DPDK
TRANSP:OPAQUE
END:VEVENT
END:VCALENDAR


invite.ics
Description: application/ics

Re: [PATCH] app/testpmd: fix slave port reset action

[Singh, Aman Deep]

On 10/12/2022 1:13 PM, Qiming Yang wrote:

As stop action has been forbidden in secondary process, so
the reset action should also not be allowed.

Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: sta...@dpdk.org

Signed-off-by: Qiming Yang 


Acked-by: Aman Singh


---
  app/test-pmd/testpmd.c| 18 ++
  doc/guides/testpmd_app_ug/run_app.rst |  1 +
  2 files changed, 11 insertions(+), 8 deletions(-)

Updated invitation: DTS Working Group - DPDK @ Every 2 weeks from 9am to 10am on Thursday (EDT) (dev@dpdk.org)

[nsouthern]

BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VTIMEZONE
TZID:America/Detroit
X-LIC-LOCATION:America/Detroit
BEGIN:DAYLIGHT
TZOFFSETFROM:-0500
TZOFFSETTO:-0400
TZNAME:EDT
DTSTART:19700308T02
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=2SU
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:-0400
TZOFFSETTO:-0500
TZNAME:EST
DTSTART:19701101T02
RRULE:FREQ=YEARLY;BYMONTH=11;BYDAY=1SU
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
DTSTART;TZID=America/Detroit:20221020T09
DTEND;TZID=America/Detroit:20221020T10
RRULE:FREQ=WEEKLY;WKST=SU;INTERVAL=2;BYDAY=TH
DTSTAMP:20221013T174900Z
ORGANIZER;CN=DPDK (Data Plane Development Kit):mailto:c_f567a7194b6c395c324
 36bd7b5fbb888db5102d6adfd5fd9f8f8eff1511a1...@group.calendar.google.com
UID:6s3tlf8sg4soovm7bjkoqsg...@google.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=TENTATIVE;RSVP=TRU
 E;CN=Lincoln Lavoie;X-NUM-GUESTS=0:mailto:lylav...@iol.unh.edu
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=lijuan...@intel.com;X-NUM-GUESTS=0:mailto:lijuan...@intel.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=n...@arm.com;X-NUM-GUESTS=0:mailto:n...@arm.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=honnappanagaraha...@gmail.com;X-NUM-GUESTS=0:mailto:honnappanagarah
 a...@gmail.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE
 ;CN=nsouth...@linuxfoundation.org;X-NUM-GUESTS=0:mailto:nsouthern@linuxfoun
 dation.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=honnappa.nagaraha...@arm.com;X-NUM-GUESTS=0:mailto:honnappa.nagarah
 a...@arm.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=dev@dpdk.org;X-NUM-GUESTS=0:mailto:dev@dpdk.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=d...@dpdk.org;X-NUM-GUESTS=0:mailto:d...@dpdk.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=juraj.lin...@pantheon.tech;X-NUM-GUESTS=0:mailto:juraj.linkes@panth
 eon.tech
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=ohily...@iol.unh.edu;X-NUM-GUESTS=0:mailto:ohily...@iol.unh.edu
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=TENTATIVE;RSVP=TRU
 E;CN="Boyer, Andrew";X-NUM-GUESTS=0:mailto:andrew.bo...@amd.com
X-MICROSOFT-CDO-OWNERAPPTID:398660684
CREATED:20221013T172652Z
DESCRIPTION:
LAST-MODIFIED:20221013T174859Z
LOCATION:https://zoom.us/j/4239143206?pwd=ajZMVWcvek5GMzJaOE1XM0s2bjhlUT09
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:DTS Working Group - DPDK
TRANSP:OPAQUE
END:VEVENT
END:VCALENDAR


invite.ics
Description: application/ics

Updated invitation: DTS Working Group - DPDK @ Thu Nov 3, 2022 9am - 10am (EDT) (dev@dpdk.org)

[nsouthern]

BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VTIMEZONE
TZID:America/Detroit
X-LIC-LOCATION:America/Detroit
BEGIN:DAYLIGHT
TZOFFSETFROM:-0500
TZOFFSETTO:-0400
TZNAME:EDT
DTSTART:19700308T02
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=2SU
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:-0400
TZOFFSETTO:-0500
TZNAME:EST
DTSTART:19701101T02
RRULE:FREQ=YEARLY;BYMONTH=11;BYDAY=1SU
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
DTSTART;TZID=America/Detroit:20221103T09
DTEND;TZID=America/Detroit:20221103T10
DTSTAMP:20221013T174901Z
ORGANIZER;CN=DPDK (Data Plane Development Kit):mailto:c_f567a7194b6c395c324
 36bd7b5fbb888db5102d6adfd5fd9f8f8eff1511a1...@group.calendar.google.com
UID:6s3tlf8sg4soovm7bjkoqsg...@google.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=TENTATIVE;RSVP=TRU
 E;CN=Lincoln Lavoie;X-NUM-GUESTS=0:mailto:lylav...@iol.unh.edu
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=lijuan...@intel.com;X-NUM-GUESTS=0:mailto:lijuan...@intel.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=n...@arm.com;X-NUM-GUESTS=0:mailto:n...@arm.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=honnappanagaraha...@gmail.com;X-NUM-GUESTS=0:mailto:honnappanagarah
 a...@gmail.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE
 ;CN=nsouth...@linuxfoundation.org;X-NUM-GUESTS=0:mailto:nsouthern@linuxfoun
 dation.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=honnappa.nagaraha...@arm.com;X-NUM-GUESTS=0:mailto:honnappa.nagarah
 a...@arm.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=ohily...@iol.unh.edu;X-NUM-GUESTS=0:mailto:ohily...@iol.unh.edu
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=dev@dpdk.org;X-NUM-GUESTS=0:mailto:dev@dpdk.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=d...@dpdk.org;X-NUM-GUESTS=0:mailto:d...@dpdk.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=juraj.lin...@pantheon.tech;X-NUM-GUESTS=0:mailto:juraj.linkes@panth
 eon.tech
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=TENTATIVE;RSVP=TRU
 E;CN="Boyer, Andrew";X-NUM-GUESTS=0:mailto:andrew.bo...@amd.com
X-MICROSOFT-CDO-OWNERAPPTID:77357111
RECURRENCE-ID;TZID=America/Detroit:20221103T09
CREATED:20221013T172652Z
DESCRIPTION:
LAST-MODIFIED:20221013T174859Z
LOCATION:https://zoom.us/j/4239143206?pwd=ajZMVWcvek5GMzJaOE1XM0s2bjhlUT09
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:DTS Working Group - DPDK
TRANSP:OPAQUE
END:VEVENT
END:VCALENDAR


invite.ics
Description: application/ics

Updated invitation: DTS Working Group - DPDK @ Every 2 weeks from 9am to 10am on Thursday (EDT) (dev@dpdk.org)

[nsouthern]

BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VTIMEZONE
TZID:America/Detroit
X-LIC-LOCATION:America/Detroit
BEGIN:DAYLIGHT
TZOFFSETFROM:-0500
TZOFFSETTO:-0400
TZNAME:EDT
DTSTART:19700308T02
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=2SU
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:-0400
TZOFFSETTO:-0500
TZNAME:EST
DTSTART:19701101T02
RRULE:FREQ=YEARLY;BYMONTH=11;BYDAY=1SU
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
DTSTART;TZID=America/Detroit:20221020T09
DTEND;TZID=America/Detroit:20221020T10
RRULE:FREQ=WEEKLY;WKST=SU;INTERVAL=2;BYDAY=TH
DTSTAMP:20221013T175603Z
ORGANIZER;CN=DPDK (Data Plane Development Kit):mailto:c_f567a7194b6c395c324
 36bd7b5fbb888db5102d6adfd5fd9f8f8eff1511a1...@group.calendar.google.com
UID:6s3tlf8sg4soovm7bjkoqsg...@google.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=TENTATIVE;RSVP=TRU
 E;CN=Lincoln Lavoie;X-NUM-GUESTS=0:mailto:lylav...@iol.unh.edu
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=lijuan...@intel.com;X-NUM-GUESTS=0:mailto:lijuan...@intel.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=n...@arm.com;X-NUM-GUESTS=0:mailto:n...@arm.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=honnappanagaraha...@gmail.com;X-NUM-GUESTS=0:mailto:honnappanagarah
 a...@gmail.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE
 ;CN=nsouth...@linuxfoundation.org;X-NUM-GUESTS=0:mailto:nsouthern@linuxfoun
 dation.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=honnappa.nagaraha...@arm.com;X-NUM-GUESTS=0:mailto:honnappa.nagarah
 a...@arm.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=ohily...@iol.unh.edu;X-NUM-GUESTS=0:mailto:ohily...@iol.unh.edu
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=dev@dpdk.org;X-NUM-GUESTS=0:mailto:dev@dpdk.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=d...@dpdk.org;X-NUM-GUESTS=0:mailto:d...@dpdk.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=juraj.lin...@pantheon.tech;X-NUM-GUESTS=0:mailto:juraj.linkes@panth
 eon.tech
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=TENTATIVE;RSVP=TRU
 E;CN="Boyer, Andrew";X-NUM-GUESTS=0:mailto:andrew.bo...@amd.com
X-MICROSOFT-CDO-OWNERAPPTID:398660684
CREATED:20221013T172652Z
DESCRIPTION:DPDK Project is inviting you to a scheduled Zoom meeting.Topic: DTS Working Group - DPDKTime: Oct 20\, 2022 09:00 AM Eastern T
 ime (US and Canada) \;  \;  \;  \; Every 2 weeks on Thu
 \, until Dec 14\, 2023\, 31 occurrence(s) \;  \;  \;  \
 ; Oct 20\, 2022 09:00 AM \;  \;  \;  \; Nov 3\, 2022 09
 :00 AM \;  \;  \;  \; Nov 17\, 2022 09:00 AM \;
   \;  \;  \; Dec 1\, 2022 09:00 AM \;  \;  \; &
 nbsp\; Dec 15\, 2022 09:00 AM \;  \;  \;  \; Dec 29\, 2
 022 09:00 AM \;  \;  \;  \; Jan 12\, 2023 09:00 AM&
 nbsp\;  \;  \;  \; Jan 26\, 2023 09:00 AM \;  \; &n
 bsp\;  \; Feb 9\, 2023 09:00 AM \;  \;  \;  \; Feb 
 23\, 2023 09:00 AM \;  \;  \;  \; Mar 9\, 2023 09:00 AM
  \;  \;  \;  \; Mar 23\, 2023 09:00 AM \;  
 \;  \;  \; Apr 6\, 2023 09:00 AM \;  \;  \;  \;
  Apr 20\, 2023 09:00 AM \;  \;  \;  \; May 4\, 2023 09:
 00 AM \;  \;  \;  \; May 18\, 2023 09:00 AM \; 
  \;  \;  \; Jun 1\, 2023 09:00 AM \;  \;  \; &n
 bsp\; Jun 15\, 2023 09:00 AM \;  \;  \;  \; Jun 29\, 20
 23 09:00 AM \;  \;  \;  \; Jul 13\, 2023 09:00 AM&n
 bsp\;  \;  \;  \; Jul 27\, 2023 09:00 AM \;  \; &nb
 sp\;  \; Aug 10\, 2023 09:00 AM \;  \;  \;  \; Aug 
 24\, 2023 09:00 AM \;  \;  \;  \; Sep 7\, 2023 09:00 AM
  \;  \;  \;  \; Sep 21\, 2023 09:00 AM \;  
 \;  \;  \; Oct 5\, 2023 09:00 AM \;  \;  \;  \;
  Oct 19\, 2023 09:00 AM \;  \;  \;  \; Nov 2\, 2023 09:
 00 AM \;  \;  \;  \; Nov 16\, 2023 09:00 AM \; 
  \;  \;  \; Nov 30\, 2023 09:00 AM \;  \;  \; &
 nbsp\; Dec 14\, 2023 09:00 AMPlease download and import the following i
 Calendar (.ics) files to your calendar system.Weekly: https://zoom.us/me
 eting/tJIodumhqDoiGddm__jlxmO14AUoLwAA_SST/ics?icsToken=98tyKuCuqzoqE9KUuBq
 ERowAGYj4c_Pwpn5HjadZkSDaCSxLbyynYsN3PZ5oMfnvJoin Zoom Meeting<
 br>https://zoom.us/j/96510961833?pwd=YUJHWXF0bjAzWHFkTnRRNThkT0xXQ
 T09">https://zoom.us/j/96510961833?pwd=YUJHWXF0bjAzWHFkTnRRNThkT0xXQT09
 Meeting ID: 965 1096 1833Passcode: 046886One tap mobile
 +13126266799\,\,96510961833#\,\,\,\,*046886# US (Chicago)+16465588656\,
 \,96510961833#\,\,\,\,*046886# US (New York)Dial by your location \;  \;  \;  \; +1 312 626 6799 US (Chicago) \; &
 nbsp\;  \;  \; +1 646 558 8656 US (New York) \;  \; &nb
 sp\;  \; +1 646 931 3860 US \;  \;  \;  \; +1 301 7
 15 8592 US (Washington DC) \;  \;  \;  \; +1 309 205 33
 25 US \;  \;  \;  \; +1 346 248 7799 US (Houston)&n
 bsp\;  \;  \;  \; +1 386 347 5053 US \;  \;  \;
   \; +1 564 217 2000 US \;  \;  \;  \; +1 669 444 9
 171 US \;  

Updated invitation: DTS Working Group - DPDK @ Thu Nov 3, 2022 9am - 10am (EDT) (dev@dpdk.org)

[nsouthern]

BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VTIMEZONE
TZID:America/Detroit
X-LIC-LOCATION:America/Detroit
BEGIN:DAYLIGHT
TZOFFSETFROM:-0500
TZOFFSETTO:-0400
TZNAME:EDT
DTSTART:19700308T02
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=2SU
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:-0400
TZOFFSETTO:-0500
TZNAME:EST
DTSTART:19701101T02
RRULE:FREQ=YEARLY;BYMONTH=11;BYDAY=1SU
END:STANDARD
END:VTIMEZONE
BEGIN:VEVENT
DTSTART;TZID=America/Detroit:20221103T09
DTEND;TZID=America/Detroit:20221103T10
DTSTAMP:20221013T175603Z
ORGANIZER;CN=DPDK (Data Plane Development Kit):mailto:c_f567a7194b6c395c324
 36bd7b5fbb888db5102d6adfd5fd9f8f8eff1511a1...@group.calendar.google.com
UID:6s3tlf8sg4soovm7bjkoqsg...@google.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=TENTATIVE;RSVP=TRU
 E;CN=Lincoln Lavoie;X-NUM-GUESTS=0:mailto:lylav...@iol.unh.edu
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=lijuan...@intel.com;X-NUM-GUESTS=0:mailto:lijuan...@intel.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=n...@arm.com;X-NUM-GUESTS=0:mailto:n...@arm.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=honnappanagaraha...@gmail.com;X-NUM-GUESTS=0:mailto:honnappanagarah
 a...@gmail.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE
 ;CN=nsouth...@linuxfoundation.org;X-NUM-GUESTS=0:mailto:nsouthern@linuxfoun
 dation.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=honnappa.nagaraha...@arm.com;X-NUM-GUESTS=0:mailto:honnappa.nagarah
 a...@arm.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=ohily...@iol.unh.edu;X-NUM-GUESTS=0:mailto:ohily...@iol.unh.edu
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=dev@dpdk.org;X-NUM-GUESTS=0:mailto:dev@dpdk.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=d...@dpdk.org;X-NUM-GUESTS=0:mailto:d...@dpdk.org
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=juraj.lin...@pantheon.tech;X-NUM-GUESTS=0:mailto:juraj.linkes@panth
 eon.tech
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=TENTATIVE;RSVP=TRU
 E;CN="Boyer, Andrew";X-NUM-GUESTS=0:mailto:andrew.bo...@amd.com
X-MICROSOFT-CDO-OWNERAPPTID:77357111
RECURRENCE-ID;TZID=America/Detroit:20221103T09
CREATED:20221013T172652Z
DESCRIPTION:DPDK Project is inviting you to a scheduled Zoom meeting.Topic: DTS Working Group - DPDKTime: Oct 20\, 2022 09:00 AM Eastern T
 ime (US and Canada) \;  \;  \;  \; Every 2 weeks on Thu
 \, until Dec 14\, 2023\, 31 occurrence(s) \;  \;  \;  \
 ; Oct 20\, 2022 09:00 AM \;  \;  \;  \; Nov 3\, 2022 09
 :00 AM \;  \;  \;  \; Nov 17\, 2022 09:00 AM \;
   \;  \;  \; Dec 1\, 2022 09:00 AM \;  \;  \; &
 nbsp\; Dec 15\, 2022 09:00 AM \;  \;  \;  \; Dec 29\, 2
 022 09:00 AM \;  \;  \;  \; Jan 12\, 2023 09:00 AM&
 nbsp\;  \;  \;  \; Jan 26\, 2023 09:00 AM \;  \; &n
 bsp\;  \; Feb 9\, 2023 09:00 AM \;  \;  \;  \; Feb 
 23\, 2023 09:00 AM \;  \;  \;  \; Mar 9\, 2023 09:00 AM
  \;  \;  \;  \; Mar 23\, 2023 09:00 AM \;  
 \;  \;  \; Apr 6\, 2023 09:00 AM \;  \;  \;  \;
  Apr 20\, 2023 09:00 AM \;  \;  \;  \; May 4\, 2023 09:
 00 AM \;  \;  \;  \; May 18\, 2023 09:00 AM \; 
  \;  \;  \; Jun 1\, 2023 09:00 AM \;  \;  \; &n
 bsp\; Jun 15\, 2023 09:00 AM \;  \;  \;  \; Jun 29\, 20
 23 09:00 AM \;  \;  \;  \; Jul 13\, 2023 09:00 AM&n
 bsp\;  \;  \;  \; Jul 27\, 2023 09:00 AM \;  \; &nb
 sp\;  \; Aug 10\, 2023 09:00 AM \;  \;  \;  \; Aug 
 24\, 2023 09:00 AM \;  \;  \;  \; Sep 7\, 2023 09:00 AM
  \;  \;  \;  \; Sep 21\, 2023 09:00 AM \;  
 \;  \;  \; Oct 5\, 2023 09:00 AM \;  \;  \;  \;
  Oct 19\, 2023 09:00 AM \;  \;  \;  \; Nov 2\, 2023 09:
 00 AM \;  \;  \;  \; Nov 16\, 2023 09:00 AM \; 
  \;  \;  \; Nov 30\, 2023 09:00 AM \;  \;  \; &
 nbsp\; Dec 14\, 2023 09:00 AMPlease download and import the following i
 Calendar (.ics) files to your calendar system.Weekly: https://zoom.us/me
 eting/tJIodumhqDoiGddm__jlxmO14AUoLwAA_SST/ics?icsToken=98tyKuCuqzoqE9KUuBq
 ERowAGYj4c_Pwpn5HjadZkSDaCSxLbyynYsN3PZ5oMfnvJoin Zoom Meeting<
 br>https://zoom.us/j/96510961833?pwd=YUJHWXF0bjAzWHFkTnRRNThkT0xXQ
 T09">https://zoom.us/j/96510961833?pwd=YUJHWXF0bjAzWHFkTnRRNThkT0xXQT09
 Meeting ID: 965 1096 1833Passcode: 046886One tap mobile
 +13126266799\,\,96510961833#\,\,\,\,*046886# US (Chicago)+16465588656\,
 \,96510961833#\,\,\,\,*046886# US (New York)Dial by your location \;  \;  \;  \; +1 312 626 6799 US (Chicago) \; &
 nbsp\;  \;  \; +1 646 558 8656 US (New York) \;  \; &nb
 sp\;  \; +1 646 931 3860 US \;  \;  \;  \; +1 301 7
 15 8592 US (Washington DC) \;  \;  \;  \; +1 309 205 33
 25 US \;  \;  \;  \; +1 346 248 7799 US (Houston)&n
 bsp\;  \;  \;  \; +1 386 347 5053 US \;  \;  \;
   \; +1 564 217 2000 US \;  \;  \;  \; +1 669 444 9
 171 US 

Re: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

[David Marchand]

On Thu, Oct 13, 2022 at 7:07 PM Harman Kalra  wrote:
> >
> > With the whole traces fixes series applied first, then the new "trace:
> > take live traces via telemetry" patch applied, I can't reproduce your issue.
> >
> >
>
> Yes, you replicated the same scenario what I tried.
> Sorry, I realized that actually it's not an issue, traces generated after 
> /trace/save are getting
> appended but in the same file (timestamped on /trace/save) on 
> rte_eal_cleanup().
>
> I assumed that trace dir generated with a timestamp will include all the 
> trace points emitted
> before that timestamp. But in the above scenario same  trace dir includes 
> trace points emitted
> after this timestamp. I think this is bit confusing. Shall we add a logic 
> where if already_done is
> set, rename the original trace dir to latest timestamp?

Afaiu, the behavior before this series was the same.
An application calling rte_trace_save() would always save to a single directory.
One thing that changed though is that the directory is timestamped
with the time of the first call to rte_trace_save.
Before the seriesn the timestamp was based on the time when the trace
subsystem was initialised.


We can go with what you describe (which makes sense to me).
But I'd like to get a ack from traces maintainers before looking into it.


-- 
David Marchand

Unsafe memory access in testpmd

[Stephen Hemminger]

Noticed that test-pmd is using a signal handler to exit.
And that signal handle clears a flag "f_quit".
But that variable is updated without atomic and is not volatile.

Simple fix to use atomic, would fix that part.
But the signal_handler is calling a bunch of functions that are not
safe in a signal handler.

The signal handler in testpmd should only be doing atomic
update of f_quit.  All the cleanup logic needs to be moved to
a place where thread is an safe state, like after exiting
the forwarding loop in main thread.

The problem is that testpmd has grown in complexity and not
sure if this won't break other things.

RE: [PATCH] net/nfp: add the feature of RSS based on VXLAN inner layer

[Chaoyong He]

> On 10/10/2022 7:28 AM, Chaoyong He wrote:
> > Add the logics to support the feature of RSS packets based on the
> > inner layer of VXLAN tunnel.
> >
> > Signed-off-by: Chaoyong He 
> > Reviewed-by: Niklas Söderlund 
> >
> > Depends-on: series-24819 ("preparation for the rte_flow offload of nfp
> > PMD")
> >
> > ---
> >   drivers/net/nfp/flower/nfp_flower.c |   2 +-
> >   drivers/net/nfp/flower/nfp_flower_cmsg.c|   1 +
> >   drivers/net/nfp/flower/nfp_flower_ctrl.c|   2 +-
> >   drivers/net/nfp/flower/nfp_flower_representor.c |   2 +-
> >   drivers/net/nfp/nfp_common.c|  33 +++
> >   drivers/net/nfp/nfp_common.h|   4 +
> >   drivers/net/nfp/nfp_cpp_bridge.h|   2 -
> >   drivers/net/nfp/nfp_ethdev.c| 111
> 
> >   drivers/net/nfp/nfp_ethdev_vf.c |   1 +
> >   drivers/net/nfp/nfp_rxtx.c  |   1 +
> >   10 files changed, 154 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/nfp/flower/nfp_flower.c
> > b/drivers/net/nfp/flower/nfp_flower.c
> > index 3e97f5c..da96d2f 100644
> > --- a/drivers/net/nfp/flower/nfp_flower.c
> > +++ b/drivers/net/nfp/flower/nfp_flower.c
> > @@ -10,9 +10,9 @@
> >   #include 
> >   #include 
> >
> > +#include "../nfp_ctrl.h"
> >   #include "../nfp_common.h"
> >   #include "../nfp_logs.h"
> > -#include "../nfp_ctrl.h"
> >   #include "../nfp_cpp_bridge.h"
> >   #include "../nfp_rxtx.h"
> >   #include "../nfpcore/nfp_mip.h"
> > diff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.c
> > b/drivers/net/nfp/flower/nfp_flower_cmsg.c
> > index 750a629..b719eb2 100644
> > --- a/drivers/net/nfp/flower/nfp_flower_cmsg.c
> > +++ b/drivers/net/nfp/flower/nfp_flower_cmsg.c
> > @@ -5,6 +5,7 @@
> >
> >   #include "../nfpcore/nfp_nsp.h"
> >   #include "../nfp_logs.h"
> > +#include "../nfp_ctrl.h"
> >   #include "../nfp_common.h"
> >   #include "nfp_flower.h"
> >   #include "nfp_flower_cmsg.h"
> > diff --git a/drivers/net/nfp/flower/nfp_flower_ctrl.c
> > b/drivers/net/nfp/flower/nfp_flower_ctrl.c
> > index df908ef..961ca34 100644
> > --- a/drivers/net/nfp/flower/nfp_flower_ctrl.c
> > +++ b/drivers/net/nfp/flower/nfp_flower_ctrl.c
> > @@ -6,9 +6,9 @@
> >   #include 
> >   #include 
> >
> > +#include "../nfp_ctrl.h"
> >   #include "../nfp_common.h"
> >   #include "../nfp_logs.h"
> > -#include "../nfp_ctrl.h"
> >   #include "../nfp_rxtx.h"
> >   #include "nfp_flower.h"
> >   #include "nfp_flower_ctrl.h"
> > diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c
> > b/drivers/net/nfp/flower/nfp_flower_representor.c
> > index 0e60f50..8db73e0 100644
> > --- a/drivers/net/nfp/flower/nfp_flower_representor.c
> > +++ b/drivers/net/nfp/flower/nfp_flower_representor.c
> > @@ -6,9 +6,9 @@
> >   #include 
> >   #include 
> >
> > +#include "../nfp_ctrl.h"
> >   #include "../nfp_common.h"
> >   #include "../nfp_logs.h"
> > -#include "../nfp_ctrl.h"
> >   #include "../nfp_rxtx.h"
> >   #include "../nfpcore/nfp_mip.h"
> >   #include "../nfpcore/nfp_rtsym.h"
> > diff --git a/drivers/net/nfp/nfp_common.c
> > b/drivers/net/nfp/nfp_common.c index 07781a1..ec6a669 100644
> > --- a/drivers/net/nfp/nfp_common.c
> > +++ b/drivers/net/nfp/nfp_common.c
> > @@ -37,6 +37,7 @@
> >   #include "nfpcore/nfp_rtsym.h"
> >   #include "nfpcore/nfp_nsp.h"
> >
> > +#include "nfp_ctrl.h"
> >   #include "nfp_common.h"
> >   #include "nfp_ctrl.h"
> >   #include "nfp_rxtx.h"
> 
> Are above header inclusion changes related to this patch?

Yes, it does relate.
In this patch, we use a macro in `nfp_common.h`, and this macro is defined in 
`nfp_ctrl.h`,
so import the dependency relations of this two header files.
If we don't modify the related files which use these two header files, the 
compile process will fail.

RE: [PATCH] net/ixgbevf: fix promiscuous and allmulti

[Wu, Wenjun1]

> -Original Message-
> From: Olivier Matz 
> Sent: Thursday, October 13, 2022 10:46 PM
> To: Wu, Wenjun1 
> Cc: dev@dpdk.org; Yang, Qiming ; Zhao1, Wei
> 
> Subject: Re: [PATCH] net/ixgbevf: fix promiscuous and allmulti
> 
> Hi Wenjun,
> 
> On Mon, Oct 10, 2022 at 01:30:54AM +, Wu, Wenjun1 wrote:
> > Hi Olivier,
> >
> > > -Original Message-
> > > From: Olivier Matz 
> > > Sent: Thursday, September 29, 2022 8:22 PM
> > > To: dev@dpdk.org
> > > Cc: Yang, Qiming ; Wu, Wenjun1
> > > ; Zhao1, Wei 
> > > Subject: [PATCH] net/ixgbevf: fix promiscuous and allmulti
> > >
> > > The configuration of allmulti and promiscuous modes conflicts
> > > together. For instance, if we enable promiscuous mode, then enable
> > > and disable allmulti, then the promiscuous mode is wrongly disabled.
> > >
> > > Fix this behavior by:
> > > - doing nothing when we set/unset allmulti if promiscuous mode is on
> > > - restorting the proper mode (none or allmulti) when we disable
> > >   promiscuous mode
> > >
> > > Fixes: 1f4564ed7696 ("net/ixgbevf: enable promiscuous mode")
> > >
> > > Signed-off-by: Olivier Matz 
> > > ---
> > >
> > > Hi,
> > >
> > > For reference, this was tested with this plan:
> > >
> > > echo 8 > "/sys/bus/pci/devices/:01:00.1/sriov_numvfs"
> > > ip link set dev eno2 up
> > > ip link set dev eno2 promisc on
> > > bridge link set dev eno2 hwmode veb
> > > ip link set dev eno2 mtu 9000
> > >
> > > ip link set dev eno2 vf 0 mac ac:1f:6b:fe:ba:b0 ip link set dev eno2
> > > vf 0 spoofchk off ip link set dev eno2 vf 0 trust on
> > >
> > > ip link set dev eno2 vf 1 mac ac:1f:6b:fe:ba:b1 ip link set dev eno2
> > > vf 1 spoofchk off ip link set dev eno2 vf 1 trust on
> > >
> > > python3 usertools/dpdk-devbind.py -s
> > > python3 usertools/dpdk-devbind.py -b vfio-pci :01:10.1   # vf 0
> > > python3 usertools/dpdk-devbind.py -b ixgbevf :01:10.3# vf 1
> > >
> > >
> > > # in another terminal
> > > scapy
> > > while True:
> > >   sendp(Ether(dst='ac:1f:6b:00:00:00'), iface='eno2v1')  # wrong mac
> > >   sendp(Ether(dst='ac:1f:6b:fe:ba:b0'), iface='eno2v1')  # correct mac
> > >   time.sleep(1)
> > >
> > >
> > > ./build/app/dpdk-testpmd -l 1,2 -a :01:10.1 -- -i --total-num-
> > > mbufs=32768 show port info all set fwd rxonly set verbose 1 set
> > > promisc all off set allmulti all off start
> > >
> > > # ok, only packets to dst='ac:1f:6b:fe:ba:b0' are received
> > >
> > >
> > > # ok, both packets are received
> > > set promisc all on
> > >
> > >
> > > # nok, only packets to dst='ac:1f:6b:fe:ba:b0' are received set
> > > allmulti all on set allmulti all off
> > >
> > >
> > >  drivers/net/ixgbe/ixgbe_ethdev.c | 12 +++-
> > >  1 file changed, 11 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > > index 8cec951d94..cc8383c5a9 100644
> > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > > @@ -7785,9 +7785,13 @@ static int
> > >  ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev)  {
> > >   struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
> > > >dev_private);
> > > + int mode = IXGBEVF_XCAST_MODE_NONE;
> > >   int ret;
> > >
> > > - switch (hw->mac.ops.update_xcast_mode(hw,
> > > IXGBEVF_XCAST_MODE_NONE)) {
> > > + if (dev->data->all_multicast)
> > > + mode = IXGBEVF_XCAST_MODE_ALLMULTI;
> > > +
> > > + switch (hw->mac.ops.update_xcast_mode(hw, mode)) {
> > >   case IXGBE_SUCCESS:
> > >   ret = 0;
> > >   break;
> > > @@ -7809,6 +7813,9 @@ ixgbevf_dev_allmulticast_enable(struct
> > > rte_eth_dev *dev)
> > >   int ret;
> > >   int mode = IXGBEVF_XCAST_MODE_ALLMULTI;
> > >
> > > + if (dev->data->promiscuous)
> > > + return 0;
> > > +
> > >   switch (hw->mac.ops.update_xcast_mode(hw, mode)) {
> > >   case IXGBE_SUCCESS:
> > >   ret = 0;
> > > @@ -7830,6 +7837,9 @@ ixgbevf_dev_allmulticast_disable(struct
> > > rte_eth_dev *dev)
> > >   struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
> > > >dev_private);
> > >   int ret;
> > >
> > > + if (dev->data->promiscuous)
> > > + return 0;
> > > +
> >
> > It seems that we cannot actually turn off allmulticast mode when
> > promiscuous mode is enabled, so can we return error and add a log
> > message here as a reminder?
> 
> I think we should not return an error here: when we disable all_multi, there
> are
> 2 cases:
> 
> 1/ promiscuous is off: no issue here, we do as before, we ask the PF to
> disable
>the all_multi mode
> 
> 2/ promiscuous is on: we have nothing to ask to the PF, because we still want
>to stay in promisc mode. We just need to remember that all_multi is
> disabled,
>and this is done already done by the ethdev layer.
> 
> On the PF dpdk driver, the behavior is the same: we can enable or disable
> promisc and all_multi independently, and changing the all_multi value when
> promisc is enabled is allowed and does not impact the rx traf

[RFC 0/1] baseband PMD API

[Nicolas Chautru]

Option to move PMD API into bbdev API.
For discussion only, not yet sure this is the
right way to go.

Nicolas Chautru (1):
  bbdev: device PF initialization helper through bbdev API

 app/test-bbdev/test_bbdev_perf.c  |  10 +-
 drivers/baseband/acc/acc100_pmd.h |   1 -
 drivers/baseband/acc/acc200_cfg.h |  32 --
 drivers/baseband/acc/acc200_pmd.h |   1 -
 drivers/baseband/acc/meson.build  |   2 +-
 drivers/baseband/acc/rte_acc100_pmd.c | 308 +-
 drivers/baseband/acc/rte_acc200_pmd.c | 256 +++
 drivers/baseband/acc/rte_acc_cfg.h|  49 ---
 drivers/baseband/acc/rte_acc_common_cfg.h |  15 +-
 drivers/baseband/acc/version.map  |   6 -
 .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 206 ++--
 .../fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h |  35 +-
 drivers/baseband/fpga_5gnr_fec/version.map|   7 -
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.c  | 202 ++--
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.h  |  35 +-
 drivers/baseband/fpga_lte_fec/version.map |   7 -
 lib/bbdev/rte_bbdev.c |  20 ++
 lib/bbdev/rte_bbdev.h |  17 +
 lib/bbdev/rte_bbdev_pmd.h |  10 +
 lib/bbdev/version.map |   1 +
 20 files changed, 535 insertions(+), 685 deletions(-)
 delete mode 100644 drivers/baseband/acc/acc200_cfg.h
 delete mode 100644 drivers/baseband/acc/rte_acc_cfg.h

-- 
2.37.1

[RFC 1/1] bbdev: device PF initialization helper through bbdev API

[Nicolas Chautru]

Moved from PMD API to bbdev API.
This API is only meant for bbdev-test usage (notably for OEMs).
The actual configuration structure still need to
be exposed as it is device specific.
RFI only

Signed-off-by: Nicolas Chautru 
---
 app/test-bbdev/test_bbdev_perf.c  |  10 +-
 drivers/baseband/acc/acc100_pmd.h |   1 -
 drivers/baseband/acc/acc200_cfg.h |  32 --
 drivers/baseband/acc/acc200_pmd.h |   1 -
 drivers/baseband/acc/meson.build  |   2 +-
 drivers/baseband/acc/rte_acc100_pmd.c | 308 +-
 drivers/baseband/acc/rte_acc200_pmd.c | 256 +++
 drivers/baseband/acc/rte_acc_cfg.h|  49 ---
 drivers/baseband/acc/rte_acc_common_cfg.h |  15 +-
 drivers/baseband/acc/version.map  |   6 -
 .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 206 ++--
 .../fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h |  35 +-
 drivers/baseband/fpga_5gnr_fec/version.map|   7 -
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.c  | 202 ++--
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.h  |  35 +-
 drivers/baseband/fpga_lte_fec/version.map |   7 -
 lib/bbdev/rte_bbdev.c |  20 ++
 lib/bbdev/rte_bbdev.h |  17 +
 lib/bbdev/rte_bbdev_pmd.h |  10 +
 lib/bbdev/version.map |   1 +
 20 files changed, 535 insertions(+), 685 deletions(-)
 delete mode 100644 drivers/baseband/acc/acc200_cfg.h
 delete mode 100644 drivers/baseband/acc/rte_acc_cfg.h

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 52396f1473..89a4f20b0b 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -54,7 +54,7 @@
 #endif
 
 #ifdef RTE_BASEBAND_ACC
-#include 
+#include 
 #define ACC100PF_DRIVER_NAME   ("intel_acc100_pf")
 #define ACC100VF_DRIVER_NAME   ("intel_acc100_vf")
 #define ACC100_QMGR_NUM_AQS 16
@@ -667,7 +667,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
conf.flr_time_out = FLR_4G_TIMEOUT;
 
/* setup FPGA PF with configuration information */
-   ret = rte_fpga_lte_fec_configure(info->dev_name, &conf);
+   ret = rte_bbdev_pf_init_helper(dev_id, (void *)&conf);
TEST_ASSERT_SUCCESS(ret,
"Failed to configure 4G FPGA PF for bbdev %s",
info->dev_name);
@@ -708,7 +708,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
conf.dl_load_balance = DL_5G_LOAD_BALANCE;
 
/* setup FPGA PF with configuration information */
-   ret = rte_fpga_5gnr_fec_configure(info->dev_name, &conf);
+   ret = rte_bbdev_pf_init_helper(dev_id, (void *)&conf);
TEST_ASSERT_SUCCESS(ret,
"Failed to configure 5G FPGA PF for bbdev %s",
info->dev_name);
@@ -765,7 +765,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
conf.q_dl_5g.aq_depth_log2 = ACC100_QMGR_AQ_DEPTH;
 
/* setup PF with configuration information */
-   ret = rte_acc_configure(info->dev_name, &conf);
+   ret = rte_bbdev_pf_init_helper(dev_id, (void *)&conf);
TEST_ASSERT_SUCCESS(ret,
"Failed to configure ACC100 PF for bbdev %s",
info->dev_name);
@@ -827,7 +827,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
conf.q_fft.aq_depth_log2 = ACC200_QMGR_AQ_DEPTH;
 
/* setup PF with configuration information */
-   ret = rte_acc_configure(info->dev_name, &conf);
+   ret = rte_bbdev_pf_init_helper(dev_id, (void *)&conf);
TEST_ASSERT_SUCCESS(ret,
"Failed to configure ACC200 PF for bbdev %s",
info->dev_name);
diff --git a/drivers/baseband/acc/acc100_pmd.h 
b/drivers/baseband/acc/acc100_pmd.h
index 9486e98521..56ae427092 100644
--- a/drivers/baseband/acc/acc100_pmd.h
+++ b/drivers/baseband/acc/acc100_pmd.h
@@ -7,7 +7,6 @@
 
 #include "acc100_pf_enum.h"
 #include "acc100_vf_enum.h"
-#include "rte_acc_cfg.h"
 #include "acc_common.h"
 
 /* Helper macro for logging */
diff --git a/drivers/baseband/acc/acc200_cfg.h 
b/drivers/baseband/acc/acc200_cfg.h
deleted file mode 100644
index d77506b560..00
--- a/drivers/baseband/acc/acc200_cfg.h
+++ /dev/null
@@ -1,32 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2022 Intel Corporation
- */
-
-#ifndef _ACC200_CFG_H_
-#define _ACC200_CFG_H_
-
-/**
- * @file acc200_cfg.h
- *
- * Functions for configuring ACC200 HW.
- * Configuration related to encoding/decoding is done through the
- * librte_bbdev library.
- */
-
-/**
- * Configure a ACC200 device.
- *
- * @param dev_name
- *   The name of the device. This is

RE: baseband PMD APIs

[Chautru, Nicolas]

Hi, 
There are a few options:
1) Keep as is, but not too scalable to keep on adding PMD APIs. Still there is 
no plan on adding more API, so no rush. 
2) Keep API internal only (but in that case only work with static lib I believe)
3) Take out off DPDK, but that is used by users notably OEMs and for test 
purpose (bbdev-test) and hence proven valuable to have everything in one place. 
4) Include under bbdev API, my concern is that this is not really meant to be 
used by something else than bbdev-test hence can be confusing to VRAN vendor by 
polluting the API. 

For the sake of discussion I have captured what 4) may look like here: 
https://patches.dpdk.org/project/dpdk/patch/20221014014205.38074-2-nicolas.chau...@intel.com/
Note that the actual configuration is just a void* since that configuration 
structure is device specific (we cannot standardize this really, nor would 
there be any value to do this here). 

Note that this is definitely not blocking migration from one driver to another 
Thomas. That companion function is purely to help bbdev-test.

Happy to discuss more, I don't believe we need a swift decision though. 

Thanks
Nic

> -Original Message-
> From: Thomas Monjalon 
> Sent: Thursday, October 13, 2022 2:25 AM
> To: Chautru, Nicolas ; Gagandeep Singh
> ; Hemant Agrawal 
> Cc: Akhil Goyal ; david.march...@redhat.com;
> maxime.coque...@redhat.com; Tom Rix ; dev@dpdk.org
> Subject: Re: baseband PMD APIs
> 
> To bbdev maintainers,
> 
> Do you think we can avoid having some PMD-specific configuration?
> It looks blocking migration from a driver to another.
> How do we manage that?
> 
> 
> 13/10/2022 11:07, Akhil Goyal:
> > There are 6 bbdev PMDs, out of which 3 have pmd APIs - all from Intel
> > These are the PMD APIs for baseband drivers.
> > rte_acc_configure -> this is being used by 2 drivers(acc100 and acc200)
> merged in a single folder.
> > rte_fpga_5gnr_fec_configure
> > rte_fpga_lte_fec_configure
> >
> > The fpga ones have almost same syntax.
> 
> 
> 

[PATCH v2] gro: fix gro with tcp push flag

[Jun Qiu]

TCP data packets sometimes carry a PUSH flag. Currently,
only the packets that do not have PUSH flag can be GROed.
The packets that have a PUSH flag cannot be GROed, the packets
that cannot be processed by GRO are placed last.
In this case, the received packets may be out of order.
For example, there are two packets mbuf1 and mbuf2. mbuf1
contains PUSH flag, mbuf2 does not contain PUSH flag.
After GRO processing, mbuf2 is sent for processing before mbuf1.
This out-of-order will affect TCP processing performance and
lead to unnecessary dup-ACK.

Referring to the Linux kernel implementation, packets with PUSH
flag can also perform GRO. And if one of the packets containing
PUSH flag, the packets after GRO will carry PUSH flag.

Fixes: 0d2cbe59b719 ("lib/gro: support TCP/IPv4")
Cc: sta...@dpdk.org

Signed-off-by: Jun Qiu 
---
 lib/gro/gro_tcp4.c   | 13 +
 lib/gro/gro_tcp4.h   |  5 -
 lib/gro/gro_vxlan_tcp4.c | 15 ++-
 lib/gro/gro_vxlan_tcp4.h |  3 ++-
 lib/gro/rte_gro.c| 12 
 lib/gro/rte_gro.h|  5 +
 6 files changed, 38 insertions(+), 15 deletions(-)

diff --git a/lib/gro/gro_tcp4.c b/lib/gro/gro_tcp4.c
index 0110db5748..b93eb5e6a4 100644
--- a/lib/gro/gro_tcp4.c
+++ b/lib/gro/gro_tcp4.c
@@ -6,6 +6,7 @@
 #include 
 #include 
 
+#include "rte_gro.h"
 #include "gro_tcp4.h"
 
 void *
@@ -191,7 +192,8 @@ update_header(struct gro_tcp4_item *item)
 int32_t
 gro_tcp4_reassemble(struct rte_mbuf *pkt,
struct gro_tcp4_tbl *tbl,
-   uint64_t start_time)
+   uint64_t start_time,
+   uint16_t flags)
 {
struct rte_ether_hdr *eth_hdr;
struct rte_ipv4_hdr *ipv4_hdr;
@@ -205,7 +207,7 @@ gro_tcp4_reassemble(struct rte_mbuf *pkt,
uint32_t cur_idx, prev_idx, item_idx;
uint32_t i, max_flow_num, remaining_flow_num;
int cmp;
-   uint8_t find;
+   uint8_t find, tcp_flags;
 
/*
 * Don't process the packet whose TCP header length is greater
@@ -221,9 +223,12 @@ gro_tcp4_reassemble(struct rte_mbuf *pkt,
 
/*
 * Don't process the packet which has FIN, SYN, RST, URG, ECE
-* or CWR set.
+* or CWR set, the PSH flag is ignored at the user's discretion.
 */
-   if (tcp_hdr->tcp_flags & (~(RTE_TCP_ACK_FLAG | RTE_TCP_PSH_FLAG)))
+   tcp_flags = tcp_hdr->tcp_flags & (~(RTE_TCP_ACK_FLAG));
+   if (flags & RTE_GRO_TCP_PUSH_IGNORE)
+   tcp_flags = tcp_flags & (~(RTE_TCP_PSH_FLAG));
+   if (tcp_flags)
return -1;
/*
 * Don't process the packet whose payload length is less than or
diff --git a/lib/gro/gro_tcp4.h b/lib/gro/gro_tcp4.h
index 2974faf228..b005bfe7a0 100644
--- a/lib/gro/gro_tcp4.h
+++ b/lib/gro/gro_tcp4.h
@@ -134,6 +134,8 @@ void gro_tcp4_tbl_destroy(void *tbl);
  *  Pointer pointing to the TCP/IPv4 reassembly table
  * @start_time
  *  The time when the packet is inserted into the table
+ * @flags
+ *  Functional flags for GRO
  *
  * @return
  *  - Return a positive value if the packet is merged.
@@ -143,7 +145,8 @@ void gro_tcp4_tbl_destroy(void *tbl);
  */
 int32_t gro_tcp4_reassemble(struct rte_mbuf *pkt,
struct gro_tcp4_tbl *tbl,
-   uint64_t start_time);
+   uint64_t start_time,
+   uint16_t flags);
 
 /**
  * This function flushes timeout packets in a TCP/IPv4 reassembly table,
diff --git a/lib/gro/gro_vxlan_tcp4.c b/lib/gro/gro_vxlan_tcp4.c
index 884802af0b..c7282139ee 100644
--- a/lib/gro/gro_vxlan_tcp4.c
+++ b/lib/gro/gro_vxlan_tcp4.c
@@ -7,6 +7,7 @@
 #include 
 #include 
 
+#include "rte_gro.h"
 #include "gro_vxlan_tcp4.h"
 
 void *
@@ -287,7 +288,8 @@ update_vxlan_header(struct gro_vxlan_tcp4_item *item)
 int32_t
 gro_vxlan_tcp4_reassemble(struct rte_mbuf *pkt,
struct gro_vxlan_tcp4_tbl *tbl,
-   uint64_t start_time)
+   uint64_t start_time,
+   uint16_t flags)
 {
struct rte_ether_hdr *outer_eth_hdr, *eth_hdr;
struct rte_ipv4_hdr *outer_ipv4_hdr, *ipv4_hdr;
@@ -304,7 +306,7 @@ gro_vxlan_tcp4_reassemble(struct rte_mbuf *pkt,
uint32_t i, max_flow_num, remaining_flow_num;
int cmp;
uint16_t hdr_len;
-   uint8_t find;
+   uint8_t find, tcp_flags;
 
/*
 * Don't process the packet whose TCP header length is greater
@@ -326,10 +328,13 @@ gro_vxlan_tcp4_reassemble(struct rte_mbuf *pkt,
tcp_hdr = (struct rte_tcp_hdr *)((char *)ipv4_hdr + pkt->l3_len);
 
/*
-* Don't process the packet which has FIN, SYN, RST, URG,
-* ECE or CWR set.
+* Don't process the packet which has FIN, SYN, RST, URG, ECE
+* or CWR set, the PSH flag is ignored at the user's discretion.
 */
-   if (tcp_hdr->tcp_flags & (~(RTE_TCP_ACK_FLAG | RTE_TCP_PSH_FLAG)))
+   tcp_flags = tcp_hdr->tcp_flags & (

[PATCH v13 0/1] bbdev-test extension

[Nicolas Chautru]

v13: Leftover commit 16 from the acc200 series (introduced in v10).
 Updated the commit message and documentation incl. rel notes
 and bbdev-test one suggested by Maxime.
 Modification of vector used. Thanks.

v12: Rebase between commits notably to avoid interim build issue and test
 vector format issue raised by Akhil. Thanks.
v11: Fixed clang compilation error introduced in v10 16/16. Thanks
v10: Update of patch 13 to expose a single configuration API for the ACC 
devices.
 New commit 15 to refactor PMD code using helper functions for the 
descriptor
 index management and improve readability.
 New commit 16 to extend bbdev-test capability to support new
 operations and capabilities in the new PMD.
 Formatting fixes. Note that the checkpatch warning are False-Alarms.
 Thanks
v9: I had missed a compilation error in debug mode. 
v8: Rebased to latest and fixed related compilation error. Added acc200.ini and 
updated rel_notes.
Formatting improvement in comments, docs and commit message.
v7: Additional update in commits 9,10,11 based on review from Maxime.
v5/v6:Updates based on Maxime reviews of v4/v5. Thanks.
v4: Rebase suggested by Maxime to split first commit and update the order 
within the series. No functional change. 
v3: Putting together ACC100 and ACC200 PMDs in common acc directory based on 
previous discussion on v2. 
v2: Includes now code refactory to have common structures and code reused with 
the parallel ACC1XX serie PMD which can be shared moving forward.
v1: This is targeting 22.11 and includes the PMD for the new serie integrated 
accelerator on Intel Xeon SPR-EEC.

Nic Chautru (1):
  test-bbdev: unit test extension including for FFT

 app/test-bbdev/test_bbdev_perf.c| 540 +++-
 app/test-bbdev/test_bbdev_vector.c  | 182 
 app/test-bbdev/test_bbdev_vector.h  |   1 +
 app/test-bbdev/test_vectors/fft_9.data  | 870 
 app/test-bbdev/test_vectors/fft_byp_28.data | 102 +++
 doc/guides/rel_notes/release_22_11.rst  |   6 +
 doc/guides/tools/testbbdev.rst  | 133 +++
 7 files changed, 1817 insertions(+), 17 deletions(-)
 create mode 100644 app/test-bbdev/test_vectors/fft_9.data
 create mode 100644 app/test-bbdev/test_vectors/fft_byp_28.data

-- 
2.37.1

[PATCH v13 1/1] test-bbdev: unit test extension including for FFT

[Nicolas Chautru]

From: Nic Chautru 

Added support for bbdev level unit test
for the FFT operations and for Soft-Output options.
Also added 2 small test vectors for the FFT operation.

Signed-off-by: Nic Chautru 
Reviewed-by: Maxime Coquelin 
---
 app/test-bbdev/test_bbdev_perf.c| 540 +++-
 app/test-bbdev/test_bbdev_vector.c  | 182 
 app/test-bbdev/test_bbdev_vector.h  |   1 +
 app/test-bbdev/test_vectors/fft_9.data  | 870 
 app/test-bbdev/test_vectors/fft_byp_28.data | 102 +++
 doc/guides/rel_notes/release_22_11.rst  |   6 +
 doc/guides/tools/testbbdev.rst  | 133 +++
 7 files changed, 1817 insertions(+), 17 deletions(-)
 create mode 100644 app/test-bbdev/test_vectors/fft_9.data
 create mode 100644 app/test-bbdev/test_vectors/fft_byp_28.data

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 52396f1473..8cf4359a2c 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -137,6 +137,7 @@ struct test_op_params {
struct rte_mempool *mp;
struct rte_bbdev_dec_op *ref_dec_op;
struct rte_bbdev_enc_op *ref_enc_op;
+   struct rte_bbdev_fft_op *ref_fft_op;
uint16_t burst_sz;
uint16_t num_to_process;
uint16_t num_lcores;
@@ -162,6 +163,7 @@ struct thread_params {
struct test_op_params *op_params;
struct rte_bbdev_dec_op *dec_ops[MAX_BURST];
struct rte_bbdev_enc_op *enc_ops[MAX_BURST];
+   struct rte_bbdev_fft_op *fft_ops[MAX_BURST];
 };
 
 #ifdef RTE_BBDEV_OFFLOAD_COST
@@ -449,6 +451,19 @@ check_dev_cap(const struct rte_bbdev_info *dev_info)
return TEST_FAILED;
}
return TEST_SUCCESS;
+   } else if (op_cap->type == RTE_BBDEV_OP_FFT) {
+   const struct rte_bbdev_op_cap_fft *cap = 
&op_cap->cap.fft;
+
+   if (!flags_match(test_vector.fft.op_flags, 
cap->capability_flags)) {
+   printf("Flag Mismatch\n");
+   return TEST_FAILED;
+   }
+   if (nb_inputs > cap->num_buffers_src) {
+   printf("Too many inputs defined: %u, max: %u\n",
+   nb_inputs, cap->num_buffers_src);
+   return TEST_FAILED;
+   }
+   return TEST_SUCCESS;
}
}
 
@@ -1050,7 +1065,7 @@ init_op_data_objs(struct rte_bbdev_op_data *bufs,
op_type, n * ref_entries->nb_segments,
mbuf_pool->size);
 
-   if (seg->length > RTE_BBDEV_LDPC_E_MAX_MBUF) {
+   if ((seg->length + RTE_PKTMBUF_HEADROOM) > 
RTE_BBDEV_LDPC_E_MAX_MBUF) {
/*
 * Special case when DPDK mbuf cannot handle
 * the required input size
@@ -1064,7 +1079,7 @@ init_op_data_objs(struct rte_bbdev_op_data *bufs,
bufs[i].length = 0;
 
if ((op_type == DATA_INPUT) || (op_type == DATA_HARQ_INPUT)) {
-   if ((op_type == DATA_INPUT) && large_input) {
+   if (large_input) {
/* Allocate a fake overused mbuf */
data = rte_malloc(NULL, seg->length, 0);
TEST_ASSERT_NOT_NULL(data,
@@ -1118,22 +1133,36 @@ init_op_data_objs(struct rte_bbdev_op_data *bufs,
op_type);
}
} else {
-
-   /* allocate chained-mbuf for output buffer */
-   for (j = 1; j < ref_entries->nb_segments; ++j) {
-   struct rte_mbuf *m_tail =
+   if (((op_type == DATA_HARD_OUTPUT) || (op_type == 
DATA_SOFT_OUTPUT))
+   && ((seg->length + RTE_PKTMBUF_HEADROOM)
+   > RTE_BBDEV_LDPC_E_MAX_MBUF)) {
+   /* Allocate a fake overused mbuf + margin */
+   data = rte_malloc(NULL, seg->length + 1024, 0);
+   TEST_ASSERT_NOT_NULL(data,
+   "rte malloc failed with %u bytes",
+   seg->length + 1024);
+   m_head->buf_addr = data;
+   m_head->buf_iova = rte_malloc_virt2iova(data);
+   m_head->data_off = 0;
+   m_head->data_len = seg->length;
+   } else {
+   /* allocate chained-mbuf for output buffer */
+   for (j = 1; j < ref_entries->nb_segments; ++j) {
+