[PATCH] vhost: fix physical address mapping

[xuan . ding]

From: Xuan Ding 

When choosing IOVA as PA mode, IOVA is likely to be discontinuous,
which requires page by page mapping for DMA devices. To be consistent,
this patch implements page by page mapping instead of mapping at the
region granularity for both IOVA as VA and PA mode.

Fixes: 7c61fa08b716 ("vhost: enable IOMMU for async vhost")

Signed-off-by: Xuan Ding 
Signed-off-by: Yuan Wang 
---
 lib/vhost/vhost.h  |   1 +
 lib/vhost/vhost_user.c | 116 -
 2 files changed, 57 insertions(+), 60 deletions(-)

diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
index 7085e0885c..d246538ca5 100644
--- a/lib/vhost/vhost.h
+++ b/lib/vhost/vhost.h
@@ -355,6 +355,7 @@ struct vring_packed_desc_event {
 struct guest_page {
uint64_t guest_phys_addr;
uint64_t host_phys_addr;
+   uint64_t host_user_addr;
uint64_t size;
 };
 
diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index a781346c4d..6d888766b0 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -143,57 +143,56 @@ get_blk_size(int fd)
return ret == -1 ? (uint64_t)-1 : (uint64_t)stat.st_blksize;
 }
 
-static int
-async_dma_map(struct rte_vhost_mem_region *region, bool do_map)
+static void
+async_dma_map(struct virtio_net *dev, bool do_map)
 {
-   uint64_t host_iova;
int ret = 0;
-
-   host_iova = rte_mem_virt2iova((void 
*)(uintptr_t)region->host_user_addr);
+   uint32_t i;
+   struct guest_page *page;
if (do_map) {
-   /* Add mapped region into the default container of DPDK. */
-   ret = rte_vfio_container_dma_map(RTE_VFIO_DEFAULT_CONTAINER_FD,
-region->host_user_addr,
-host_iova,
-region->size);
-   if (ret) {
-   /*
-* DMA device may bind with kernel driver, in this case,
-* we don't need to program IOMMU manually. However, if 
no
-* device is bound with vfio/uio in DPDK, and vfio 
kernel
-* module is loaded, the API will still be called and 
return
-* with ENODEV/ENOSUP.
-*
-* DPDK vfio only returns ENODEV/ENOSUP in very similar
-* situations(vfio either unsupported, or supported
-* but no devices found). Either way, no mappings could 
be
-* performed. We treat it as normal case in async path.
-*/
-   if (rte_errno == ENODEV || rte_errno == ENOTSUP)
-   return 0;
-
-   VHOST_LOG_CONFIG(ERR, "DMA engine map failed\n");
-   /* DMA mapping errors won't stop 
VHST_USER_SET_MEM_TABLE. */
-   return 0;
+   for (i = 0; i < dev->nr_guest_pages; i++) {
+   page = &dev->guest_pages[i];
+   ret = 
rte_vfio_container_dma_map(RTE_VFIO_DEFAULT_CONTAINER_FD,
+page->host_user_addr,
+page->host_phys_addr,
+page->size);
+   if (ret) {
+   /*
+* DMA device may bind with kernel driver, in 
this case,
+* we don't need to program IOMMU manually. 
However, if no
+* device is bound with vfio/uio in DPDK, and 
vfio kernel
+* module is loaded, the API will still be 
called and return
+* with ENODEV.
+*
+* DPDK vfio only returns ENODEV in very 
similar situations
+* (vfio either unsupported, or supported but 
no devices found).
+* Either way, no mappings could be performed. 
We treat it as
+* normal case in async path. This is a 
workaround.
+*/
+   if (rte_errno == ENODEV)
+   return;
+
+   /* DMA mapping errors won't stop 
VHOST_USER_SET_MEM_TABLE. */
+   VHOST_LOG_CONFIG(ERR, "DMA engine map 
failed\n");
+   }
}
 
} else {
-   /* Remove mapped region from the default container of DPDK. */
-   ret = 
rte_vfio_container_dma_unmap(RTE_VFIO_DEFAULT_CONTAINER_FD,
-  region->host_user_addr,
-  host_iova,
-

RE: [RFC] cryptodev: asymmetric crypto random number source

[Akhil Goyal]

++Ram for openssl

ECDSA op:
rte_crypto_param k;
   /**< The ECDSA per-message secret number, which is an integer
   * in the interval (1, n-1)
   */
DSA op:
   No 'k'.

This one I think have described some time ago:
Only PMD that verifies ECDSA is OCTEON which apparently needs 'k' provided by 
user.
Only PMD that verifies DSA is OpenSSL PMD which will generate its own random 
number internally.

So in case PMD supports one of these options (or especially when supports both) 
we need to give some information here.

The most obvious option would be to change rte_crypto_param k -> 
rte_crypto_param *k
In case (k == NULL) PMD should generate it itself if possible, otherwise it 
should push crypto_op to the response ring with appropriate error code.

Another options would be:

  *   Extend rte_cryptodev_config and rte_cryptodev_info with information about 
random number generator for specific device (though it would be ABI breakage)
  *   Provide some kind of callback to get random number from user (which could 
be useful for other things like RSA padding as well)

[PATCH v3 00/10] Add cnxk_gpio PMD

[Tomasz Duszynski]

This series introduces a new rawdevice PMD which allows
to manage userspace GPIOs and install custom GPIO interrupt
handlers which bypass kernel. This is especially useful for
applications that, besides providing standard dataplane functionality,
want to have fast and low latency access to GPIO pin state.

It'd be great to have that merged during 22.02 merge window.

v3:
- fix meson formatting
- fix cnxk_gpio_process_buf() return value

v2:
- do not trigger irq by writing to /dev/mem, use ioctl() instead

Tomasz Duszynski (10):
  raw/cnxk_gpio: add GPIO driver skeleton
  raw/cnxk_gpio: support reading default queue conf
  raw/cnxk_gpio: support reading queue count
  raw/cnxk_gpio: support queue setup
  raw/cnxk_gpio: support queue release
  raw/cnxk_gpio: support enqueuing buffers
  raw/cnxk_gpio: support dequeuing buffers
  raw/cnxk_gpio: support standard GPIO operations
  raw/cnxk_gpio: support custom irq handlers
  raw/cnxk_gpio: support selftest

 doc/guides/rawdevs/cnxk_gpio.rst   | 195 +++
 doc/guides/rawdevs/index.rst   |   1 +
 drivers/raw/cnxk_gpio/cnxk_gpio.c  | 633 +
 drivers/raw/cnxk_gpio/cnxk_gpio.h  |  33 ++
 drivers/raw/cnxk_gpio/cnxk_gpio_irq.c  | 216 +++
 drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c | 386 +
 drivers/raw/cnxk_gpio/meson.build  |  11 +
 drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h  | 429 ++
 drivers/raw/cnxk_gpio/version.map  |   3 +
 drivers/raw/meson.build|   1 +
 10 files changed, 1908 insertions(+)
 create mode 100644 doc/guides/rawdevs/cnxk_gpio.rst
 create mode 100644 drivers/raw/cnxk_gpio/cnxk_gpio.c
 create mode 100644 drivers/raw/cnxk_gpio/cnxk_gpio.h
 create mode 100644 drivers/raw/cnxk_gpio/cnxk_gpio_irq.c
 create mode 100644 drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c
 create mode 100644 drivers/raw/cnxk_gpio/meson.build
 create mode 100644 drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h
 create mode 100644 drivers/raw/cnxk_gpio/version.map

--
2.25.1

[PATCH v3 01/10] raw/cnxk_gpio: add GPIO driver skeleton

[Tomasz Duszynski]

Add initial support for PMD that allows to control particular pins form
userspace. Moreover PMD allows to attach custom interrupt handlers to
controllable GPIOs.

Main users of this PMD are dataplain applications requiring fast and low
latency access to pin state.

Signed-off-by: Tomasz Duszynski 
---
 doc/guides/rawdevs/cnxk_gpio.rst  |  65 +
 doc/guides/rawdevs/index.rst  |   1 +
 drivers/raw/cnxk_gpio/cnxk_gpio.c | 235 ++
 drivers/raw/cnxk_gpio/cnxk_gpio.h |  22 +++
 drivers/raw/cnxk_gpio/meson.build |   8 +
 drivers/raw/cnxk_gpio/version.map |   3 +
 drivers/raw/meson.build   |   1 +
 7 files changed, 335 insertions(+)
 create mode 100644 doc/guides/rawdevs/cnxk_gpio.rst
 create mode 100644 drivers/raw/cnxk_gpio/cnxk_gpio.c
 create mode 100644 drivers/raw/cnxk_gpio/cnxk_gpio.h
 create mode 100644 drivers/raw/cnxk_gpio/meson.build
 create mode 100644 drivers/raw/cnxk_gpio/version.map

diff --git a/doc/guides/rawdevs/cnxk_gpio.rst b/doc/guides/rawdevs/cnxk_gpio.rst
new file mode 100644
index 00..868302d07f
--- /dev/null
+++ b/doc/guides/rawdevs/cnxk_gpio.rst
@@ -0,0 +1,65 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2021 Marvell.
+
+Marvell CNXK GPIO Driver
+
+
+CNXK GPIO PMD configures and manages GPIOs available on the system using
+standard enqueue/dequeue mechanism offered by raw device abstraction. PMD 
relies
+both on standard sysfs GPIO interface provided by the Linux kernel and GPIO
+kernel driver custom interface allowing one to install userspace interrupt
+handlers.
+
+Features
+
+
+Following features are available:
+
+- export/unexport a GPIO
+- read/write specific value from/to exported GPIO
+- set GPIO direction
+- set GPIO edge that triggers interrupt
+- set GPIO active low
+- register interrupt handler for specific GPIO
+
+Requirements
+
+
+PMD relies on modified kernel GPIO driver which exposes ``ioctl()`` interface
+for installing interrupt handlers for low latency signal processing.
+
+Driver is shipped with Marvell SDK.
+
+Device Setup
+
+
+CNXK GPIO PMD binds to virtual device which gets created by passing
+`--vdev=cnxk_gpio,gpiochip=` command line to EAL. `gpiochip` parameter
+tells PMD which GPIO controller should be used. Available controllers are
+available under `/sys/class/gpio`. For further details on how Linux represents
+GPIOs in userspace please refer to
+`sysfs.txt `_.
+
+If `gpiochip=` was omitted then first gpiochip from the alphabetically
+sort list of available gpiochips is used.
+
+.. code-block:: console
+
+   $ ls /sys/class/gpio
+   export gpiochip448 unexport
+
+In above scenario only one GPIO controller is present hence
+`--vdev=cnxk_gpio,gpiochip=448` should be passed to EAL.
+
+Before performing actual data transfer one needs to call
+``rte_rawdev_queue_count()`` followed by ``rte_rawdev_queue_conf_get()``. The
+former returns number GPIOs available in the system irrespective of GPIOs
+being controllable or not. Thus it is user responsibility to pick the proper
+ones. The latter call simply returns queue capacity.
+
+Respective queue needs to be configured with ``rte_rawdev_queue_setup()``. This
+call barely exports GPIO to userspace.
+
+To perform actual data transfer use standard ``rte_rawdev_enqueue_buffers()``
+and ``rte_rawdev_dequeue_buffers()`` APIs. Not all messages produce sensible
+responses hence dequeueing is not always necessary.
diff --git a/doc/guides/rawdevs/index.rst b/doc/guides/rawdevs/index.rst
index b6cf917443..0c02da6e90 100644
--- a/doc/guides/rawdevs/index.rst
+++ b/doc/guides/rawdevs/index.rst
@@ -12,6 +12,7 @@ application through rawdev API.
 :numbered:
 
 cnxk_bphy
+cnxk_gpio
 dpaa2_cmdif
 dpaa2_qdma
 ifpga
diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio.c
new file mode 100644
index 00..bcce4b8fb7
--- /dev/null
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -0,0 +1,235 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2021 Marvell.
+ */
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#include "cnxk_gpio.h"
+
+#define CNXK_GPIO_BUFSZ 128
+#define CNXK_GPIO_CLASS_PATH "/sys/class/gpio"
+
+static const char *const cnxk_gpio_args[] = {
+#define CNXK_GPIO_ARG_GPIOCHIP "gpiochip"
+   CNXK_GPIO_ARG_GPIOCHIP,
+   NULL
+};
+
+static void
+cnxk_gpio_format_name(char *name, size_t len)
+{
+   snprintf(name, len, "cnxk_gpio");
+}
+
+static int
+cnxk_gpio_filter_gpiochip(const struct dirent *dirent)
+{
+   const char *pattern = "gpiochip";
+
+   return !strncmp(dirent->d_name, pattern, strlen(pattern));
+}
+
+static void
+cnxk_gpio_set_defaults(struct cnxk_gpiochip *gpiochip)
+{
+   struct dirent **namelist;
+   int n;
+
+   n = scandir(CNXK_GPIO_CLASS_PATH, &namelist, cnxk_gpio_filter_gpiochip,
+   

[PATCH v3 02/10] raw/cnxk_gpio: support reading default queue conf

[Tomasz Duszynski]

Add support for reading default queue configuration.

Signed-off-by: Tomasz Duszynski 
---
 drivers/raw/cnxk_gpio/cnxk_gpio.c | 19 +++
 1 file changed, 19 insertions(+)

diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio.c
index bcce4b8fb7..deedf98af2 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -134,7 +134,26 @@ cnxk_gpio_read_attr_int(char *attr, int *val)
return 0;
 }
 
+static int
+cnxk_gpio_queue_def_conf(struct rte_rawdev *dev, uint16_t queue_id,
+rte_rawdev_obj_t queue_conf, size_t queue_conf_size)
+{
+   unsigned int *conf;
+
+   RTE_SET_USED(dev);
+   RTE_SET_USED(queue_id);
+
+   if (queue_conf_size != sizeof(*conf))
+   return -EINVAL;
+
+   conf = (unsigned int *)queue_conf;
+   *conf = 1;
+
+   return 0;
+}
+
 static const struct rte_rawdev_ops cnxk_gpio_rawdev_ops = {
+   .queue_def_conf = cnxk_gpio_queue_def_conf,
 };
 
 static int
-- 
2.25.1

[PATCH v3 03/10] raw/cnxk_gpio: support reading queue count

[Tomasz Duszynski]

Add support for reading number of available queues. Single queue
corresponds to GPIO.

Signed-off-by: Tomasz Duszynski 
---
 drivers/raw/cnxk_gpio/cnxk_gpio.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio.c
index deedf98af2..84be7f861e 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -152,8 +152,17 @@ cnxk_gpio_queue_def_conf(struct rte_rawdev *dev, uint16_t 
queue_id,
return 0;
 }
 
+static uint16_t
+cnxk_gpio_queue_count(struct rte_rawdev *dev)
+{
+   struct cnxk_gpiochip *gpiochip = dev->dev_private;
+
+   return gpiochip->num_gpios;
+}
+
 static const struct rte_rawdev_ops cnxk_gpio_rawdev_ops = {
.queue_def_conf = cnxk_gpio_queue_def_conf,
+   .queue_count = cnxk_gpio_queue_count,
 };
 
 static int
-- 
2.25.1

[PATCH v3 04/10] raw/cnxk_gpio: support queue setup

[Tomasz Duszynski]

Add support for queue setup.

Signed-off-by: Tomasz Duszynski 
---
 drivers/raw/cnxk_gpio/cnxk_gpio.c | 80 +++
 1 file changed, 80 insertions(+)

diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio.c
index 84be7f861e..98b5dd9cd8 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -134,6 +134,85 @@ cnxk_gpio_read_attr_int(char *attr, int *val)
return 0;
 }
 
+static int
+cnxk_gpio_write_attr(const char *attr, const char *val)
+{
+   FILE *fp;
+   int ret;
+
+   if (!val)
+   return -EINVAL;
+
+   fp = fopen(attr, "w");
+   if (!fp)
+   return -errno;
+
+   ret = fprintf(fp, "%s", val);
+   if (ret < 0) {
+   fclose(fp);
+   return ret;
+   }
+
+   ret = fclose(fp);
+   if (ret)
+   return -errno;
+
+   return 0;
+}
+
+static int
+cnxk_gpio_write_attr_int(const char *attr, int val)
+{
+   char buf[CNXK_GPIO_BUFSZ];
+
+   snprintf(buf, sizeof(buf), "%d", val);
+
+   return cnxk_gpio_write_attr(attr, buf);
+}
+
+static struct cnxk_gpio *
+cnxk_gpio_lookup(struct cnxk_gpiochip *gpiochip, uint16_t queue)
+{
+   if (queue >= gpiochip->num_gpios)
+   return NULL;
+
+   return gpiochip->gpios[queue];
+}
+
+static int
+cnxk_gpio_queue_setup(struct rte_rawdev *dev, uint16_t queue_id,
+ rte_rawdev_obj_t queue_conf, size_t queue_conf_size)
+{
+   struct cnxk_gpiochip *gpiochip = dev->dev_private;
+   char buf[CNXK_GPIO_BUFSZ];
+   struct cnxk_gpio *gpio;
+   int ret;
+
+   RTE_SET_USED(queue_conf);
+   RTE_SET_USED(queue_conf_size);
+
+   gpio = cnxk_gpio_lookup(gpiochip, queue_id);
+   if (gpio)
+   return -EEXIST;
+
+   gpio = rte_zmalloc(NULL, sizeof(*gpio), 0);
+   if (!gpio)
+   return -ENOMEM;
+   gpio->num = queue_id + gpiochip->base;
+   gpio->gpiochip = gpiochip;
+
+   snprintf(buf, sizeof(buf), "%s/export", CNXK_GPIO_CLASS_PATH);
+   ret = cnxk_gpio_write_attr_int(buf, gpio->num);
+   if (ret) {
+   rte_free(gpio);
+   return ret;
+   }
+
+   gpiochip->gpios[queue_id] = gpio;
+
+   return 0;
+}
+
 static int
 cnxk_gpio_queue_def_conf(struct rte_rawdev *dev, uint16_t queue_id,
 rte_rawdev_obj_t queue_conf, size_t queue_conf_size)
@@ -163,6 +242,7 @@ cnxk_gpio_queue_count(struct rte_rawdev *dev)
 static const struct rte_rawdev_ops cnxk_gpio_rawdev_ops = {
.queue_def_conf = cnxk_gpio_queue_def_conf,
.queue_count = cnxk_gpio_queue_count,
+   .queue_setup = cnxk_gpio_queue_setup,
 };
 
 static int
-- 
2.25.1

[PATCH v3 05/10] raw/cnxk_gpio: support queue release

[Tomasz Duszynski]

Add support for queue release.

Signed-off-by: Tomasz Duszynski 
---
 drivers/raw/cnxk_gpio/cnxk_gpio.c | 34 +++
 1 file changed, 34 insertions(+)

diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio.c
index 98b5dd9cd8..8ac3c5e1be 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -213,6 +213,29 @@ cnxk_gpio_queue_setup(struct rte_rawdev *dev, uint16_t 
queue_id,
return 0;
 }
 
+static int
+cnxk_gpio_queue_release(struct rte_rawdev *dev, uint16_t queue_id)
+{
+   struct cnxk_gpiochip *gpiochip = dev->dev_private;
+   char buf[CNXK_GPIO_BUFSZ];
+   struct cnxk_gpio *gpio;
+   int ret;
+
+   gpio = cnxk_gpio_lookup(gpiochip, queue_id);
+   if (!gpio)
+   return -ENODEV;
+
+   snprintf(buf, sizeof(buf), "%s/unexport", CNXK_GPIO_CLASS_PATH);
+   ret = cnxk_gpio_write_attr_int(buf, gpiochip->base + queue_id);
+   if (ret)
+   return ret;
+
+   gpiochip->gpios[queue_id] = NULL;
+   rte_free(gpio);
+
+   return 0;
+}
+
 static int
 cnxk_gpio_queue_def_conf(struct rte_rawdev *dev, uint16_t queue_id,
 rte_rawdev_obj_t queue_conf, size_t queue_conf_size)
@@ -243,6 +266,7 @@ static const struct rte_rawdev_ops cnxk_gpio_rawdev_ops = {
.queue_def_conf = cnxk_gpio_queue_def_conf,
.queue_count = cnxk_gpio_queue_count,
.queue_setup = cnxk_gpio_queue_setup,
+   .queue_release = cnxk_gpio_queue_release,
 };
 
 static int
@@ -316,6 +340,8 @@ cnxk_gpio_remove(struct rte_vdev_device *dev)
char name[RTE_RAWDEV_NAME_MAX_LEN];
struct cnxk_gpiochip *gpiochip;
struct rte_rawdev *rawdev;
+   struct cnxk_gpio *gpio;
+   int i;
 
RTE_SET_USED(dev);
 
@@ -328,6 +354,14 @@ cnxk_gpio_remove(struct rte_vdev_device *dev)
return -ENODEV;
 
gpiochip = rawdev->dev_private;
+   for (i = 0; i < gpiochip->num_gpios; i++) {
+   gpio = gpiochip->gpios[i];
+   if (!gpio)
+   continue;
+
+   cnxk_gpio_queue_release(rawdev, gpio->num);
+   }
+
rte_free(gpiochip->gpios);
rte_rawdev_pmd_release(rawdev);
 
-- 
2.25.1

[PATCH v3 06/10] raw/cnxk_gpio: support enqueuing buffers

[Tomasz Duszynski]

Add dummy support for enqueuing buffers.

Signed-off-by: Tomasz Duszynski 
---
 drivers/raw/cnxk_gpio/cnxk_gpio.c | 46 +++
 drivers/raw/cnxk_gpio/cnxk_gpio.h |  1 +
 drivers/raw/cnxk_gpio/meson.build |  1 +
 drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h | 38 +++
 4 files changed, 86 insertions(+)
 create mode 100644 drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h

diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio.c
index 8ac3c5e1be..9477e7293a 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -14,6 +14,7 @@
 #include 
 
 #include "cnxk_gpio.h"
+#include "rte_pmd_cnxk_gpio.h"
 
 #define CNXK_GPIO_BUFSZ 128
 #define CNXK_GPIO_CLASS_PATH "/sys/class/gpio"
@@ -262,7 +263,52 @@ cnxk_gpio_queue_count(struct rte_rawdev *dev)
return gpiochip->num_gpios;
 }
 
+static int
+cnxk_gpio_process_buf(struct cnxk_gpio *gpio, struct rte_rawdev_buf *rbuf)
+{
+   struct cnxk_gpio_msg *msg = rbuf->buf_addr;
+   void *rsp = NULL;
+
+   switch (msg->type) {
+   default:
+   return -EINVAL;
+   }
+
+   /* get rid of last response if any */
+   if (gpio->rsp) {
+   RTE_LOG(WARNING, PMD, "previous response got overwritten\n");
+   rte_free(gpio->rsp);
+   }
+   gpio->rsp = rsp;
+
+   return ret;
+}
+
+static int
+cnxk_gpio_enqueue_bufs(struct rte_rawdev *dev, struct rte_rawdev_buf **buffers,
+  unsigned int count, rte_rawdev_obj_t context)
+{
+   struct cnxk_gpiochip *gpiochip = dev->dev_private;
+   unsigned int queue = (size_t)context;
+   struct cnxk_gpio *gpio;
+   int ret;
+
+   if (count == 0)
+   return 0;
+
+   gpio = cnxk_gpio_lookup(gpiochip, queue);
+   if (!gpio)
+   return -ENODEV;
+
+   ret = cnxk_gpio_process_buf(gpio, buffers[0]);
+   if (ret)
+   return ret;
+
+   return 1;
+}
+
 static const struct rte_rawdev_ops cnxk_gpio_rawdev_ops = {
+   .enqueue_bufs = cnxk_gpio_enqueue_bufs,
.queue_def_conf = cnxk_gpio_queue_def_conf,
.queue_count = cnxk_gpio_queue_count,
.queue_setup = cnxk_gpio_queue_setup,
diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.h 
b/drivers/raw/cnxk_gpio/cnxk_gpio.h
index 4dae8316ba..6b54ebe6e6 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.h
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.h
@@ -9,6 +9,7 @@ struct cnxk_gpiochip;
 
 struct cnxk_gpio {
struct cnxk_gpiochip *gpiochip;
+   void *rsp;
int num;
 };
 
diff --git a/drivers/raw/cnxk_gpio/meson.build 
b/drivers/raw/cnxk_gpio/meson.build
index 9a7e716c1e..3fbfdd838c 100644
--- a/drivers/raw/cnxk_gpio/meson.build
+++ b/drivers/raw/cnxk_gpio/meson.build
@@ -6,3 +6,4 @@ deps += ['bus_vdev', 'common_cnxk', 'rawdev', 'kvargs']
 sources = files(
 'cnxk_gpio.c',
 )
+headers = files('rte_pmd_cnxk_gpio.h')
diff --git a/drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h 
b/drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h
new file mode 100644
index 00..c71065e10c
--- /dev/null
+++ b/drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h
@@ -0,0 +1,38 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2021 Marvell.
+ */
+
+#ifndef _RTE_PMD_CNXK_GPIO_H_
+#define _RTE_PMD_CNXK_GPIO_H_
+
+/**
+ * @file rte_pmd_cnxk_gpio.h
+ *
+ * Marvell GPIO PMD specific structures and interface
+ *
+ * This API allows applications to manage GPIOs in user space along with
+ * installing interrupt handlers for low latency signal processing.
+ */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/** Available message types */
+enum cnxk_gpio_msg_type {
+   /** Invalid message type */
+   CNXK_GPIO_MSG_TYPE_INVALID,
+};
+
+struct cnxk_gpio_msg {
+   /** Message type */
+   enum cnxk_gpio_msg_type type;
+   /** Message data passed to PMD or received from PMD */
+   void *data;
+};
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* _RTE_PMD_CNXK_GPIO_H_ */
-- 
2.25.1

[PATCH v3 07/10] raw/cnxk_gpio: support dequeuing buffers

[Tomasz Duszynski]

Add support for dequeuing buffers.

Signed-off-by: Tomasz Duszynski 
---
 drivers/raw/cnxk_gpio/cnxk_gpio.c | 26 ++
 1 file changed, 26 insertions(+)

diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio.c
index 9477e7293a..570d9abb17 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -307,8 +307,34 @@ cnxk_gpio_enqueue_bufs(struct rte_rawdev *dev, struct 
rte_rawdev_buf **buffers,
return 1;
 }
 
+static int
+cnxk_gpio_dequeue_bufs(struct rte_rawdev *dev, struct rte_rawdev_buf **buffers,
+  unsigned int count, rte_rawdev_obj_t context)
+{
+   struct cnxk_gpiochip *gpiochip = dev->dev_private;
+   unsigned int queue = (size_t)context;
+   struct cnxk_gpio *gpio;
+
+   if (count == 0)
+   return 0;
+
+   gpio = cnxk_gpio_lookup(gpiochip, queue);
+   if (!gpio)
+   return -ENODEV;
+
+   if (gpio->rsp) {
+   buffers[0]->buf_addr = gpio->rsp;
+   gpio->rsp = NULL;
+
+   return 1;
+   }
+
+   return 0;
+}
+
 static const struct rte_rawdev_ops cnxk_gpio_rawdev_ops = {
.enqueue_bufs = cnxk_gpio_enqueue_bufs,
+   .dequeue_bufs = cnxk_gpio_dequeue_bufs,
.queue_def_conf = cnxk_gpio_queue_def_conf,
.queue_count = cnxk_gpio_queue_count,
.queue_setup = cnxk_gpio_queue_setup,
-- 
2.25.1

[PATCH v3 08/10] raw/cnxk_gpio: support standard GPIO operations

[Tomasz Duszynski]

Add support for standard GPIO operations i.e ones normally
provided by GPIO sysfs interface.

Signed-off-by: Tomasz Duszynski 
---
 doc/guides/rawdevs/cnxk_gpio.rst  |  98 
 drivers/raw/cnxk_gpio/cnxk_gpio.c | 146 +++
 drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h | 279 +-
 3 files changed, 521 insertions(+), 2 deletions(-)

diff --git a/doc/guides/rawdevs/cnxk_gpio.rst b/doc/guides/rawdevs/cnxk_gpio.rst
index 868302d07f..f6c3c942c5 100644
--- a/doc/guides/rawdevs/cnxk_gpio.rst
+++ b/doc/guides/rawdevs/cnxk_gpio.rst
@@ -63,3 +63,101 @@ call barely exports GPIO to userspace.
 To perform actual data transfer use standard ``rte_rawdev_enqueue_buffers()``
 and ``rte_rawdev_dequeue_buffers()`` APIs. Not all messages produce sensible
 responses hence dequeueing is not always necessary.
+
+CNXK GPIO PMD
+-
+
+PMD accepts ``struct cnxk_gpio_msg`` messages which differ by type and payload.
+Message types along with description are listed below. As for the usage 
examples
+please refer to ``cnxk_gpio_selftest()``. There's a set of convenient wrappers
+available, one for each existing command.
+
+Set GPIO value
+~~
+
+Message is used to set output to low or high. This does not work for GPIOs
+configured as input.
+
+Message must have type set to ``CNXK_GPIO_MSG_TYPE_SET_PIN_VALUE``.
+
+Payload must be an integer set to 0 (low) or 1 (high).
+
+Consider using ``rte_pmd_gpio_set_pin_value()`` wrapper.
+
+Set GPIO edge
+~
+
+Message is used to set edge that triggers interrupt.
+
+Message must have type set to ``CNXK_GPIO_MSG_TYPE_SET_PIN_EDGE``.
+
+Payload must be `enum cnxk_gpio_pin_edge`.
+
+Consider using ``rte_pmd_gpio_set_pin_edge()`` wrapper.
+
+Set GPIO direction
+~~
+
+Message is used to change GPIO direction to either input or output.
+
+Message must have type set to ``CNXK_GPIO_MSG_TYPE_SET_PIN_DIR``.
+
+Payload must be `enum cnxk_gpio_pin_dir`.
+
+Consider using ``rte_pmd_gpio_set_pin_dir()`` wrapper.
+
+Set GPIO active low
+~~~
+
+Message is used to set whether pin is active low.
+
+Message must have type set to ``CNXK_GPIO_MSG_TYPE_SET_PIN_ACTIVE_LOW``.
+
+Payload must be an integer set to 0 or 1. The latter activates inversion.
+
+Consider using ``rte_pmd_gpio_set_pin_active_low()`` wrapper.
+
+Get GPIO value
+~~
+
+Message is used to read GPIO value. Value can be 0 (low) or 1 (high).
+
+Message must have type set to ``CNXK_GPIO_MSG_TYPE_GET_PIN_VALUE``.
+
+Payload contains integer set to either 0 or 1.
+
+Consider using ``rte_pmd_gpio_get_pin_value()`` wrapper.
+
+Get GPIO edge
+~
+
+Message is used to read GPIO edge.
+
+Message must have type set to ``CNXK_GPIO_MSG_TYPE_GET_PIN_EDGE``.
+
+Payload contains `enum cnxk_gpio_pin_edge`.
+
+Consider using ``rte_pmd_gpio_get_pin_edge()`` wrapper.
+
+Get GPIO direction
+~~
+
+Message is used to read GPIO direction.
+
+Message must have type set to ``CNXK_GPIO_MSG_TYPE_GET_PIN_DIR``.
+
+Payload contains `enum cnxk_gpio_pin_dir`.
+
+Consider using ``rte_pmd_gpio_get_pin_dir()`` wrapper.
+
+Get GPIO active low
+~~~
+
+Message is used check whether inverted logic is active.
+
+Message must have type set to ``CNXK_GPIO_MSG_TYPE_GET_PIN_ACTIVE_LOW``.
+
+Payload contains an integer set to 0 or 1. The latter means inverted logic
+is turned on.
+
+Consider using ``rte_pmd_gpio_get_pin_active_low()`` wrapper.
diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio.c
index 570d9abb17..fa5b1359d0 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -263,13 +263,159 @@ cnxk_gpio_queue_count(struct rte_rawdev *dev)
return gpiochip->num_gpios;
 }
 
+static const struct {
+   enum cnxk_gpio_pin_edge edge;
+   const char *name;
+} cnxk_gpio_edge_name[] = {
+   { CNXK_GPIO_PIN_EDGE_NONE, "none" },
+   { CNXK_GPIO_PIN_EDGE_FALLING, "falling" },
+   { CNXK_GPIO_PIN_EDGE_RISING, "rising" },
+   { CNXK_GPIO_PIN_EDGE_BOTH, "both" },
+};
+
+static const char *
+cnxk_gpio_edge_to_name(enum cnxk_gpio_pin_edge edge)
+{
+   unsigned int i;
+
+   for (i = 0; i < RTE_DIM(cnxk_gpio_edge_name); i++) {
+   if (cnxk_gpio_edge_name[i].edge == edge)
+   return cnxk_gpio_edge_name[i].name;
+   }
+
+   return NULL;
+}
+
+static enum cnxk_gpio_pin_edge
+cnxk_gpio_name_to_edge(const char *name)
+{
+   unsigned int i;
+
+   for (i = 0; i < RTE_DIM(cnxk_gpio_edge_name); i++) {
+   if (!strcmp(cnxk_gpio_edge_name[i].name, name))
+   break;
+   }
+
+   return cnxk_gpio_edge_name[i].edge;
+}
+
+static const struct {
+   enum cnxk_gpio_pin_dir dir;
+   const char *name;
+} cnxk_gpio_dir_name[] = {
+   { CNXK_GPIO_PIN_DIR_IN, "in" },
+   { CNXK_GPIO_PIN_DIR_OUT, "out" },
+   { CNXK_GPIO_PIN_DIR_HIGH, "high" },
+   { CNXK_GPIO_PIN

[PATCH v3 09/10] raw/cnxk_gpio: support custom irq handlers

[Tomasz Duszynski]

Add support for custom interrupt handlers. Custom interrupt
handlers bypass kernel completely and are meant for fast
and low latency access to GPIO state.

Signed-off-by: Tomasz Duszynski 
---
 doc/guides/rawdevs/cnxk_gpio.rst  |  21 +++
 drivers/raw/cnxk_gpio/cnxk_gpio.c |  37 
 drivers/raw/cnxk_gpio/cnxk_gpio.h |   8 +
 drivers/raw/cnxk_gpio/cnxk_gpio_irq.c | 216 ++
 drivers/raw/cnxk_gpio/meson.build |   1 +
 drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h | 116 
 6 files changed, 399 insertions(+)
 create mode 100644 drivers/raw/cnxk_gpio/cnxk_gpio_irq.c

diff --git a/doc/guides/rawdevs/cnxk_gpio.rst b/doc/guides/rawdevs/cnxk_gpio.rst
index f6c3c942c5..ad93ec0d44 100644
--- a/doc/guides/rawdevs/cnxk_gpio.rst
+++ b/doc/guides/rawdevs/cnxk_gpio.rst
@@ -161,3 +161,24 @@ Payload contains an integer set to 0 or 1. The latter 
means inverted logic
 is turned on.
 
 Consider using ``rte_pmd_gpio_get_pin_active_low()`` wrapper.
+
+Request interrupt
+~
+
+Message is used to install custom interrupt handler.
+
+Message must have type set to ``CNXK_GPIO_MSG_TYPE_REGISTER_IRQ``.
+
+Payload needs to be set to ``struct cnxk_gpio_irq`` which describes interrupt
+being requested.
+
+Consider using ``rte_pmd_gpio_register_gpio()`` wrapper.
+
+Free interrupt
+~~
+
+Message is used to remove installed interrupt handler.
+
+Message must have type set to ``CNXK_GPIO_MSG_TYPE_UNREGISTER_IRQ``.
+
+Consider using ``rte_pmd_gpio_unregister_gpio()`` wrapper.
diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio.c
index fa5b1359d0..f3fdd5a380 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -335,6 +335,28 @@ cnxk_gpio_name_to_dir(const char *name)
return cnxk_gpio_dir_name[i].dir;
 }
 
+static int
+cnxk_gpio_register_irq(struct cnxk_gpio *gpio, struct cnxk_gpio_irq *irq)
+{
+   int ret;
+
+   ret = cnxk_gpio_irq_request(gpio->num - gpio->gpiochip->base, irq->cpu);
+   if (ret)
+   return ret;
+
+   gpio->handler = irq->handler;
+   gpio->data = irq->data;
+   gpio->cpu = irq->cpu;
+
+   return 0;
+}
+
+static int
+cnxk_gpio_unregister_irq(struct cnxk_gpio *gpio)
+{
+   return cnxk_gpio_irq_free(gpio->num - gpio->gpiochip->base);
+}
+
 static int
 cnxk_gpio_process_buf(struct cnxk_gpio *gpio, struct rte_rawdev_buf *rbuf)
 {
@@ -416,6 +438,13 @@ cnxk_gpio_process_buf(struct cnxk_gpio *gpio, struct 
rte_rawdev_buf *rbuf)
 
*(int *)rsp = val;
break;
+   case CNXK_GPIO_MSG_TYPE_REGISTER_IRQ:
+   ret = cnxk_gpio_register_irq(gpio,
+(struct cnxk_gpio_irq *)msg->data);
+   break;
+   case CNXK_GPIO_MSG_TYPE_UNREGISTER_IRQ:
+   ret = cnxk_gpio_unregister_irq(gpio);
+   break;
default:
return -EINVAL;
}
@@ -519,6 +548,10 @@ cnxk_gpio_probe(struct rte_vdev_device *dev)
if (ret)
goto out;
 
+   ret = cnxk_gpio_irq_init(gpiochip);
+   if (ret)
+   goto out;
+
/* read gpio base */
snprintf(buf, sizeof(buf), "%s/gpiochip%d/base", CNXK_GPIO_CLASS_PATH,
 gpiochip->num);
@@ -577,10 +610,14 @@ cnxk_gpio_remove(struct rte_vdev_device *dev)
if (!gpio)
continue;
 
+   if (gpio->handler)
+   cnxk_gpio_unregister_irq(gpio);
+
cnxk_gpio_queue_release(rawdev, gpio->num);
}
 
rte_free(gpiochip->gpios);
+   cnxk_gpio_irq_fini();
rte_rawdev_pmd_release(rawdev);
 
return 0;
diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.h 
b/drivers/raw/cnxk_gpio/cnxk_gpio.h
index 6b54ebe6e6..c052ca5735 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.h
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.h
@@ -11,6 +11,9 @@ struct cnxk_gpio {
struct cnxk_gpiochip *gpiochip;
void *rsp;
int num;
+   void (*handler)(int gpio, void *data);
+   void *data;
+   int cpu;
 };
 
 struct cnxk_gpiochip {
@@ -20,4 +23,9 @@ struct cnxk_gpiochip {
struct cnxk_gpio **gpios;
 };
 
+int cnxk_gpio_irq_init(struct cnxk_gpiochip *gpiochip);
+void cnxk_gpio_irq_fini(void);
+int cnxk_gpio_irq_request(int gpio, int cpu);
+int cnxk_gpio_irq_free(int gpio);
+
 #endif /* _CNXK_GPIO_H_ */
diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio_irq.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio_irq.c
new file mode 100644
index 00..2fa8e69899
--- /dev/null
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio_irq.c
@@ -0,0 +1,216 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2021 Marvell.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+
+#include 
+
+#include "cnxk_gpio.h"
+
+#define OTX_IOC_MAGIC 0xF2
+#define OTX_IOC_SET_GPIO_HANDLER   
\
+  

[PATCH v3 10/10] raw/cnxk_gpio: support selftest

[Tomasz Duszynski]

Add support for performing selftest.

Signed-off-by: Tomasz Duszynski 
---
 doc/guides/rawdevs/cnxk_gpio.rst   |  11 +
 drivers/raw/cnxk_gpio/cnxk_gpio.c  |   1 +
 drivers/raw/cnxk_gpio/cnxk_gpio.h  |   2 +
 drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c | 386 +
 drivers/raw/cnxk_gpio/meson.build  |   1 +
 5 files changed, 401 insertions(+)
 create mode 100644 drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c

diff --git a/doc/guides/rawdevs/cnxk_gpio.rst b/doc/guides/rawdevs/cnxk_gpio.rst
index ad93ec0d44..c03a5b937c 100644
--- a/doc/guides/rawdevs/cnxk_gpio.rst
+++ b/doc/guides/rawdevs/cnxk_gpio.rst
@@ -182,3 +182,14 @@ Message is used to remove installed interrupt handler.
 Message must have type set to ``CNXK_GPIO_MSG_TYPE_UNREGISTER_IRQ``.
 
 Consider using ``rte_pmd_gpio_unregister_gpio()`` wrapper.
+
+Self test
+-
+
+On EAL initialization CNXK GPIO device will be probed and populated into
+the list of raw devices on condition ``--vdev=cnxk_gpio,gpiochip=`` was
+passed. ``rte_rawdev_get_dev_id("CNXK_GPIO")`` returns unique device id. Use
+this identifier for further rawdev function calls.
+
+Selftest rawdev API can be used to verify the PMD functionality. Note it 
blindly
+assumes that all GPIOs are controllable so some errors during test are 
expected.
diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio.c
index f3fdd5a380..c9f87a315a 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
@@ -514,6 +514,7 @@ static const struct rte_rawdev_ops cnxk_gpio_rawdev_ops = {
.queue_count = cnxk_gpio_queue_count,
.queue_setup = cnxk_gpio_queue_setup,
.queue_release = cnxk_gpio_queue_release,
+   .dev_selftest = cnxk_gpio_selftest,
 };
 
 static int
diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.h 
b/drivers/raw/cnxk_gpio/cnxk_gpio.h
index c052ca5735..1b31b5a486 100644
--- a/drivers/raw/cnxk_gpio/cnxk_gpio.h
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio.h
@@ -23,6 +23,8 @@ struct cnxk_gpiochip {
struct cnxk_gpio **gpios;
 };
 
+int cnxk_gpio_selftest(uint16_t dev_id);
+
 int cnxk_gpio_irq_init(struct cnxk_gpiochip *gpiochip);
 void cnxk_gpio_irq_fini(void);
 int cnxk_gpio_irq_request(int gpio, int cpu);
diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c 
b/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c
new file mode 100644
index 00..6502902f86
--- /dev/null
+++ b/drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c
@@ -0,0 +1,386 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2021 Marvell.
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+#include "cnxk_gpio.h"
+#include "rte_pmd_cnxk_gpio.h"
+
+#define CNXK_GPIO_BUFSZ 128
+
+#define OTX_IOC_MAGIC 0xF2
+#define OTX_IOC_TRIGGER_GPIO_HANDLER   
\
+   _IO(OTX_IOC_MAGIC, 3)
+
+static int fd;
+
+static int
+cnxk_gpio_attr_exists(const char *attr)
+{
+   struct stat st;
+
+   return !stat(attr, &st);
+}
+
+static int
+cnxk_gpio_read_attr(char *attr, char *val)
+{
+   FILE *fp;
+   int ret;
+
+   fp = fopen(attr, "r");
+   if (!fp)
+   return -errno;
+
+   ret = fscanf(fp, "%s", val);
+   if (ret < 0)
+   return -errno;
+   if (ret != 1)
+   return -EIO;
+
+   ret = fclose(fp);
+   if (ret)
+   return -errno;
+
+   return 0;
+}
+
+#define CNXK_GPIO_ERR_STR(err, str, ...) do {  
\
+   if (err) { \
+   RTE_LOG(ERR, PMD, "%s:%d: " str " (%d)\n", __func__, __LINE__, \
+   ##__VA_ARGS__, err);   \
+   goto out;  \
+   }  \
+} while (0)
+
+static int
+cnxk_gpio_validate_attr(char *attr, const char *expected)
+{
+   char buf[CNXK_GPIO_BUFSZ];
+   int ret;
+
+   ret = cnxk_gpio_read_attr(attr, buf);
+   if (ret)
+   return ret;
+
+   if (strncmp(buf, expected, sizeof(buf)))
+   return -EIO;
+
+   return 0;
+}
+
+#define CNXK_GPIO_PATH_FMT "/sys/class/gpio/gpio%d"
+
+static int
+cnxk_gpio_test_input(uint16_t dev_id, int base, int gpio)
+{
+   char buf[CNXK_GPIO_BUFSZ];
+   int ret, n;
+
+   n = snprintf(buf, sizeof(buf), CNXK_GPIO_PATH_FMT, base + gpio);
+   snprintf(buf + n, sizeof(buf) - n, "/direction");
+
+   ret = rte_pmd_gpio_set_pin_dir(dev_id, gpio, CNXK_GPIO_PIN_DIR_IN);
+   CNXK_GPIO_ERR_STR(ret, "failed to set dir to input");
+   ret = cnxk_gpio_validate_attr(buf, "in");
+   CNXK_GPIO_ERR_STR(ret, "failed to validate %s", buf);
+
+   ret = rte_pmd_gpio_set_pin_value(dev_id, gpio, 1) |
+ rte_pmd_gpio_set_pin_value(dev_id, gpio, 0);
+   if (!re

[PATCH 2/8] net/cnxk: add CN9K template Rx functions to build

[pbhagavatula]

From: Pavan Nikhilesh 

Add CN9K seggeregated Rx and event dequeue functions to build,
add macros to make future modifications simpler.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/event/cnxk/cn9k_eventdev.c| 229 +
 drivers/event/cnxk/cn9k_worker.h  | 143 +-
 drivers/event/cnxk/cn9k_worker_deq.c  |  44 --
 drivers/event/cnxk/cn9k_worker_deq_burst.c|  29 --
 drivers/event/cnxk/cn9k_worker_deq_ca.c   |  65 ---
 drivers/event/cnxk/cn9k_worker_deq_tmo.c  |  72 ---
 drivers/event/cnxk/cn9k_worker_dual_deq.c |  53 --
 .../event/cnxk/cn9k_worker_dual_deq_burst.c   |  30 --
 drivers/event/cnxk/cn9k_worker_dual_deq_ca.c  |  74 ---
 drivers/event/cnxk/cn9k_worker_dual_deq_tmo.c |  87 
 drivers/event/cnxk/meson.build| 270 +-
 drivers/net/cnxk/cn9k_rx.h| 461 --
 drivers/net/cnxk/cn9k_rx_mseg.c   |  17 -
 drivers/net/cnxk/cn9k_rx_select.c |  67 +++
 drivers/net/cnxk/cn9k_rx_vec.c|  17 -
 drivers/net/cnxk/cn9k_rx_vec_mseg.c   |  18 -
 drivers/net/cnxk/meson.build  |  41 +-
 17 files changed, 845 insertions(+), 872 deletions(-)
 delete mode 100644 drivers/event/cnxk/cn9k_worker_deq.c
 delete mode 100644 drivers/event/cnxk/cn9k_worker_deq_burst.c
 delete mode 100644 drivers/event/cnxk/cn9k_worker_deq_ca.c
 delete mode 100644 drivers/event/cnxk/cn9k_worker_deq_tmo.c
 delete mode 100644 drivers/event/cnxk/cn9k_worker_dual_deq.c
 delete mode 100644 drivers/event/cnxk/cn9k_worker_dual_deq_burst.c
 delete mode 100644 drivers/event/cnxk/cn9k_worker_dual_deq_ca.c
 delete mode 100644 drivers/event/cnxk/cn9k_worker_dual_deq_tmo.c
 delete mode 100644 drivers/net/cnxk/cn9k_rx_mseg.c
 create mode 100644 drivers/net/cnxk/cn9k_rx_select.c
 delete mode 100644 drivers/net/cnxk/cn9k_rx_vec.c
 delete mode 100644 drivers/net/cnxk/cn9k_rx_vec_mseg.c

diff --git a/drivers/event/cnxk/cn9k_eventdev.c 
b/drivers/event/cnxk/cn9k_eventdev.c
index b68ce6c0a4..1d0e1288ce 100644
--- a/drivers/event/cnxk/cn9k_eventdev.c
+++ b/drivers/event/cnxk/cn9k_eventdev.c
@@ -10,13 +10,7 @@
 #define CN9K_DUAL_WS_PAIR_ID(x, id) (((x)*CN9K_DUAL_WS_NB_WS) + id)
 
 #define CN9K_SET_EVDEV_DEQ_OP(dev, deq_op, deq_ops)
\
-   (deq_op = deq_ops[!!(dev->rx_offloads & NIX_RX_OFFLOAD_SECURITY_F)]\
-[!!(dev->rx_offloads & NIX_RX_OFFLOAD_VLAN_STRIP_F)]  \
-[!!(dev->rx_offloads & NIX_RX_OFFLOAD_TSTAMP_F)]  \
-[!!(dev->rx_offloads & NIX_RX_OFFLOAD_MARK_UPDATE_F)] \
-[!!(dev->rx_offloads & NIX_RX_OFFLOAD_CHECKSUM_F)]\
-[!!(dev->rx_offloads & NIX_RX_OFFLOAD_PTYPE_F)]   \
-[!!(dev->rx_offloads & NIX_RX_OFFLOAD_RSS_F)])
+   deq_op = deq_ops[dev->rx_offloads & (NIX_RX_OFFLOAD_MAX - 1)]
 
 #define CN9K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops)
\
(enq_op = enq_ops[!!(dev->tx_offloads & NIX_TX_OFFLOAD_SECURITY_F)]\
@@ -316,188 +310,214 @@ cn9k_sso_fp_fns_set(struct rte_eventdev *event_dev)
 {
struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev);
/* Single WS modes */
-   const event_dequeue_t sso_hws_deq[2][2][2][2][2][2][2] = {
-#define R(name, f6, f5, f4, f3, f2, f1, f0, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn9k_sso_hws_deq_##name,
+   const event_dequeue_t sso_hws_deq[NIX_RX_OFFLOAD_MAX] = {
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_##name,
NIX_RX_FASTPATH_MODES
 #undef R
};
 
-   const event_dequeue_burst_t sso_hws_deq_burst[2][2][2][2][2][2][2] = {
-#define R(name, f6, f5, f4, f3, f2, f1, f0, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn9k_sso_hws_deq_burst_##name,
+   const event_dequeue_burst_t sso_hws_deq_burst[NIX_RX_OFFLOAD_MAX] = {
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_burst_##name,
NIX_RX_FASTPATH_MODES
 #undef R
};
 
-   const event_dequeue_t sso_hws_deq_tmo[2][2][2][2][2][2][2] = {
-#define R(name, f6, f5, f4, f3, f2, f1, f0, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn9k_sso_hws_deq_tmo_##name,
+   const event_dequeue_t sso_hws_deq_tmo[NIX_RX_OFFLOAD_MAX] = {
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_tmo_##name,
NIX_RX_FASTPATH_MODES
 #undef R
};
 
-   const event_dequeue_burst_t
-   sso_hws_deq_tmo_burst[2][2][2][2][2][2][2] = {
-#define R(name, f6, f5, f4, f3, f2, f1, f0, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn9k_sso_hws_deq_tmo_burst_##name,
-   NIX_RX_FASTPATH_MODES
+   const event_dequeue_burst_t sso_hws_deq_tmo_burst[NIX_RX_OFFLOAD_MAX] =
+   {
+#define R(name, flags) [flags] = cn9k_sso_hws_deq_tmo_burst_##name,
+

[PATCH 3/8] net/cnxk: add CN9K segregated Tx functions

[pbhagavatula]

From: Pavan Nikhilesh 

Add CN9K segregated Rx and event Tx enqueue template functions,
these help in parallelizing the build.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/event/cnxk/tx/cn9k/tx_0_15.c | 10 ++
 drivers/event/cnxk/tx/cn9k/tx_0_15_dual.c| 11 +++
 drivers/event/cnxk/tx/cn9k/tx_0_15_dual_seg.c| 11 +++
 drivers/event/cnxk/tx/cn9k/tx_0_15_seg.c | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_112_127.c  | 10 ++
 drivers/event/cnxk/tx/cn9k/tx_112_127_dual.c | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_112_127_dual_seg.c | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_112_127_seg.c  | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_16_31.c| 10 ++
 drivers/event/cnxk/tx/cn9k/tx_16_31_dual.c   | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_16_31_dual_seg.c   | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_16_31_seg.c| 11 +++
 drivers/event/cnxk/tx/cn9k/tx_32_47.c| 10 ++
 drivers/event/cnxk/tx/cn9k/tx_32_47_dual.c   | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_32_47_dual_seg.c   | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_32_47_seg.c| 11 +++
 drivers/event/cnxk/tx/cn9k/tx_48_63.c| 10 ++
 drivers/event/cnxk/tx/cn9k/tx_48_63_dual.c   | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_48_63_dual_seg.c   | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_48_63_seg.c| 11 +++
 drivers/event/cnxk/tx/cn9k/tx_64_79.c| 10 ++
 drivers/event/cnxk/tx/cn9k/tx_64_79_dual.c   | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_64_79_dual_seg.c   | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_64_79_seg.c| 11 +++
 drivers/event/cnxk/tx/cn9k/tx_80_95.c| 10 ++
 drivers/event/cnxk/tx/cn9k/tx_80_95_dual.c   | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_80_95_dual_seg.c   | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_80_95_seg.c| 11 +++
 drivers/event/cnxk/tx/cn9k/tx_96_111.c   | 10 ++
 drivers/event/cnxk/tx/cn9k/tx_96_111_dual.c  | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_96_111_dual_seg.c  | 11 +++
 drivers/event/cnxk/tx/cn9k/tx_96_111_seg.c   | 11 +++
 drivers/net/cnxk/tx/cn9k/tx_0_15.c   | 11 +++
 drivers/net/cnxk/tx/cn9k/tx_0_15_mseg.c  | 12 
 drivers/net/cnxk/tx/cn9k/tx_0_15_vec.c   | 12 
 drivers/net/cnxk/tx/cn9k/tx_0_15_vec_mseg.c  | 12 
 drivers/net/cnxk/tx/cn9k/tx_112_127.c| 11 +++
 drivers/net/cnxk/tx/cn9k/tx_112_127_mseg.c   | 12 
 drivers/net/cnxk/tx/cn9k/tx_112_127_vec.c| 12 
 drivers/net/cnxk/tx/cn9k/tx_112_127_vec_mseg.c   | 12 
 drivers/net/cnxk/tx/cn9k/tx_16_31.c  | 11 +++
 drivers/net/cnxk/tx/cn9k/tx_16_31_mseg.c | 12 
 drivers/net/cnxk/tx/cn9k/tx_16_31_vec.c  | 12 
 drivers/net/cnxk/tx/cn9k/tx_16_31_vec_mseg.c | 12 
 drivers/net/cnxk/tx/cn9k/tx_32_47.c  | 11 +++
 drivers/net/cnxk/tx/cn9k/tx_32_47_mseg.c | 12 
 drivers/net/cnxk/tx/cn9k/tx_32_47_vec.c  | 12 
 drivers/net/cnxk/tx/cn9k/tx_32_47_vec_mseg.c | 12 
 drivers/net/cnxk/tx/cn9k/tx_48_63.c  | 11 +++
 drivers/net/cnxk/tx/cn9k/tx_48_63_mseg.c | 12 
 drivers/net/cnxk/tx/cn9k/tx_48_63_vec.c  | 12 
 drivers/net/cnxk/tx/cn9k/tx_48_63_vec_mseg.c | 12 
 drivers/net/cnxk/tx/cn9k/tx_64_79.c  | 11 +++
 drivers/net/cnxk/tx/cn9k/tx_64_79_mseg.c | 12 
 drivers/net/cnxk/tx/cn9k/tx_64_79_vec.c  | 12 
 drivers/net/cnxk/tx/cn9k/tx_64_79_vec_mseg.c | 12 
 drivers/net/cnxk/tx/cn9k/tx_80_95.c  | 11 +++
 drivers/net/cnxk/tx/cn9k/tx_80_95_mseg.c | 12 
 drivers/net/cnxk/tx/cn9k/tx_80_95_vec.c  | 12 
 drivers/net/cnxk/tx/cn9k/tx_80_95_vec_mseg.c | 12 
 drivers/net/cnxk/tx/cn9k/tx_96_111.c | 11 +++
 drivers/net/cnxk/tx/cn9k/tx_96_111_mseg.c| 12 
 drivers/net/cnxk/tx/cn9k/tx_96_111_vec.c | 12 
 drivers/net/cnxk/tx/cn9k/tx_96_111_vec_mseg.c| 12 
 64 files changed, 720 insertions(+)
 create mode 100644 drivers/event/cnxk/tx/cn9k/tx_0_15.c
 create mode 100644 drivers/event/cnxk/tx/cn9k/tx_0_15_dual.c
 create mode 100644 drivers/event/cnxk/tx/cn9k/tx_0_15_dual_seg.c
 create mode 100644 drivers/event/cnxk/tx/cn9k/tx_0_15_seg.c
 create mode 100644 drivers/event/cnxk/tx/cn9k/tx_112_127.c
 create mode 100644 drivers/event/cnxk/tx/cn9k/tx_112_127_dual.c
 create mode 100644 drivers/event/cnxk/tx/cn9k/tx_112_127_dual_seg.c
 create mode 100644 drivers/event/cnxk/tx/cn9k/tx_112_

[PATCH 4/8] net/cnxk: add CN9K template Tx functions to build

[pbhagavatula]

From: Pavan Nikhilesh 

Add CN9K segregated Tx and event Tx functions to build,
add macros to make future modifications simpler.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/event/cnxk/cn9k_eventdev.c|  29 +-
 drivers/event/cnxk/cn9k_worker.h  |  62 ++-
 drivers/event/cnxk/cn9k_worker_dual_tx_enq.c  |  23 -
 .../event/cnxk/cn9k_worker_dual_tx_enq_seg.c  |  23 -
 drivers/event/cnxk/cn9k_worker_tx_enq.c   |  23 -
 drivers/event/cnxk/cn9k_worker_tx_enq_seg.c   |  23 -
 drivers/event/cnxk/meson.build|  42 +-
 drivers/net/cnxk/cn9k_tx.h| 519 +-
 drivers/net/cnxk/cn9k_tx_mseg.c   |  25 -
 drivers/net/cnxk/cn9k_tx_select.c |  59 ++
 drivers/net/cnxk/cn9k_tx_vec.c|  25 -
 drivers/net/cnxk/cn9k_tx_vec_mseg.c   |  24 -
 drivers/net/cnxk/meson.build  |  40 +-
 13 files changed, 459 insertions(+), 458 deletions(-)
 delete mode 100644 drivers/event/cnxk/cn9k_worker_dual_tx_enq.c
 delete mode 100644 drivers/event/cnxk/cn9k_worker_dual_tx_enq_seg.c
 delete mode 100644 drivers/event/cnxk/cn9k_worker_tx_enq.c
 delete mode 100644 drivers/event/cnxk/cn9k_worker_tx_enq_seg.c
 delete mode 100644 drivers/net/cnxk/cn9k_tx_mseg.c
 create mode 100644 drivers/net/cnxk/cn9k_tx_select.c
 delete mode 100644 drivers/net/cnxk/cn9k_tx_vec.c
 delete mode 100644 drivers/net/cnxk/cn9k_tx_vec_mseg.c

diff --git a/drivers/event/cnxk/cn9k_eventdev.c 
b/drivers/event/cnxk/cn9k_eventdev.c
index 1d0e1288ce..7858e37146 100644
--- a/drivers/event/cnxk/cn9k_eventdev.c
+++ b/drivers/event/cnxk/cn9k_eventdev.c
@@ -13,13 +13,7 @@
deq_op = deq_ops[dev->rx_offloads & (NIX_RX_OFFLOAD_MAX - 1)]

 #define CN9K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops)
\
-   (enq_op = enq_ops[!!(dev->tx_offloads & NIX_TX_OFFLOAD_SECURITY_F)]\
-   [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSTAMP_F)]   \
-   [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSO_F)]  \
-   [!!(dev->tx_offloads & NIX_TX_OFFLOAD_MBUF_NOFF_F)]\
-   [!!(dev->tx_offloads & NIX_TX_OFFLOAD_VLAN_QINQ_F)]\
-   [!!(dev->tx_offloads & NIX_TX_OFFLOAD_OL3_OL4_CSUM_F)] \
-   [!!(dev->tx_offloads & NIX_TX_OFFLOAD_L3_L4_CSUM_F)])
+   enq_op = enq_ops[dev->tx_offloads & (NIX_TX_OFFLOAD_MAX - 1)]

 static int
 cn9k_sso_hws_link(void *arg, void *port, uint16_t *map, uint16_t nb_link)
@@ -520,34 +514,29 @@ cn9k_sso_fp_fns_set(struct rte_eventdev *event_dev)

/* Tx modes */
const event_tx_adapter_enqueue_t
-   sso_hws_tx_adptr_enq[2][2][2][2][2][2][2] = {
-#define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn9k_sso_hws_tx_adptr_enq_##name,
+   sso_hws_tx_adptr_enq[NIX_TX_OFFLOAD_MAX] = {
+#define T(name, sz, flags) [flags] = cn9k_sso_hws_tx_adptr_enq_##name,
NIX_TX_FASTPATH_MODES
 #undef T
};

const event_tx_adapter_enqueue_t
-   sso_hws_tx_adptr_enq_seg[2][2][2][2][2][2][2] = {
-#define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn9k_sso_hws_tx_adptr_enq_seg_##name,
+   sso_hws_tx_adptr_enq_seg[NIX_TX_OFFLOAD_MAX] = {
+#define T(name, sz, flags) [flags] = cn9k_sso_hws_tx_adptr_enq_seg_##name,
NIX_TX_FASTPATH_MODES
 #undef T
};

const event_tx_adapter_enqueue_t
-   sso_hws_dual_tx_adptr_enq[2][2][2][2][2][2][2] = {
-#define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn9k_sso_hws_dual_tx_adptr_enq_##name,
+   sso_hws_dual_tx_adptr_enq[NIX_TX_OFFLOAD_MAX] = {
+#define T(name, sz, flags) [flags] = cn9k_sso_hws_dual_tx_adptr_enq_##name,
NIX_TX_FASTPATH_MODES
 #undef T
};

const event_tx_adapter_enqueue_t
-   sso_hws_dual_tx_adptr_enq_seg[2][2][2][2][2][2][2] = {
-#define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = \
-   cn9k_sso_hws_dual_tx_adptr_enq_seg_##name,
+   sso_hws_dual_tx_adptr_enq_seg[NIX_TX_OFFLOAD_MAX] = {
+#define T(name, sz, flags) [flags] = cn9k_sso_hws_dual_tx_adptr_enq_seg_##name,
NIX_TX_FASTPATH_MODES
 #undef T
};
diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h
index b421412adc..a46d4e786a 100644
--- a/drivers/event/cnxk/cn9k_worker.h
+++ b/drivers/event/cnxk/cn9k_worker.h
@@ -837,7 +837,7 @@ cn9k_sso_hws_event_tx(uint64_t base, struct rte_event *ev, 
uint64_t *cmd,
return 1;
 }

-#define T(name, f6, f5, f4, f3, f2, f1, f0, sz, f

[PATCH 5/8] net/cnxk: add CN10K segregated Rx functions

[pbhagavatula]

From: Pavan Nikhilesh 

Add CN10K segregated Rx and event dequeue template functions,
these help in parallelizing the build.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/event/cnxk/deq/cn10k/deq_0_15.c| 12 
 drivers/event/cnxk/deq/cn10k/deq_0_15_burst.c  | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_0_15_ca.c | 12 
 drivers/event/cnxk/deq/cn10k/deq_0_15_ca_burst.c   | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_0_15_ca_seg.c | 12 
 .../event/cnxk/deq/cn10k/deq_0_15_ca_seg_burst.c   | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_0_15_ca_tmo.c | 12 
 .../event/cnxk/deq/cn10k/deq_0_15_ca_tmo_burst.c   | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_0_15_ca_tmo_seg.c | 13 +
 .../cnxk/deq/cn10k/deq_0_15_ca_tmo_seg_burst.c | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_0_15_dual.c   | 12 
 drivers/event/cnxk/deq/cn10k/deq_0_15_seg.c| 12 
 drivers/event/cnxk/deq/cn10k/deq_0_15_seg_burst.c  | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_0_15_tmo.c| 12 
 drivers/event/cnxk/deq/cn10k/deq_0_15_tmo_burst.c  | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_0_15_tmo_seg.c| 12 
 .../event/cnxk/deq/cn10k/deq_0_15_tmo_seg_burst.c  | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_112_127.c | 12 
 drivers/event/cnxk/deq/cn10k/deq_112_127_burst.c   | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_112_127_ca.c  | 12 
 .../event/cnxk/deq/cn10k/deq_112_127_ca_burst.c| 14 ++
 drivers/event/cnxk/deq/cn10k/deq_112_127_ca_seg.c  | 12 
 .../cnxk/deq/cn10k/deq_112_127_ca_seg_burst.c  | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_112_127_ca_tmo.c  | 12 
 .../cnxk/deq/cn10k/deq_112_127_ca_tmo_burst.c  | 14 ++
 .../event/cnxk/deq/cn10k/deq_112_127_ca_tmo_seg.c  | 13 +
 .../cnxk/deq/cn10k/deq_112_127_ca_tmo_seg_burst.c  | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_112_127_dual.c| 12 
 drivers/event/cnxk/deq/cn10k/deq_112_127_seg.c | 12 
 .../event/cnxk/deq/cn10k/deq_112_127_seg_burst.c   | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_112_127_tmo.c | 12 
 .../event/cnxk/deq/cn10k/deq_112_127_tmo_burst.c   | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_112_127_tmo_seg.c | 12 
 .../cnxk/deq/cn10k/deq_112_127_tmo_seg_burst.c | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_16_31.c   | 12 
 drivers/event/cnxk/deq/cn10k/deq_16_31_burst.c | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_16_31_ca.c| 12 
 drivers/event/cnxk/deq/cn10k/deq_16_31_ca_burst.c  | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_16_31_ca_seg.c| 12 
 .../event/cnxk/deq/cn10k/deq_16_31_ca_seg_burst.c  | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_16_31_ca_tmo.c| 12 
 .../event/cnxk/deq/cn10k/deq_16_31_ca_tmo_burst.c  | 14 ++
 .../event/cnxk/deq/cn10k/deq_16_31_ca_tmo_seg.c| 13 +
 .../cnxk/deq/cn10k/deq_16_31_ca_tmo_seg_burst.c| 14 ++
 drivers/event/cnxk/deq/cn10k/deq_16_31_dual.c  | 12 
 drivers/event/cnxk/deq/cn10k/deq_16_31_seg.c   | 12 
 drivers/event/cnxk/deq/cn10k/deq_16_31_seg_burst.c | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_16_31_tmo.c   | 12 
 drivers/event/cnxk/deq/cn10k/deq_16_31_tmo_burst.c | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_16_31_tmo_seg.c   | 12 
 .../event/cnxk/deq/cn10k/deq_16_31_tmo_seg_burst.c | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_32_47.c   | 12 
 drivers/event/cnxk/deq/cn10k/deq_32_47_burst.c | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_32_47_ca.c| 12 
 drivers/event/cnxk/deq/cn10k/deq_32_47_ca_burst.c  | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_32_47_ca_seg.c| 12 
 .../event/cnxk/deq/cn10k/deq_32_47_ca_seg_burst.c  | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_32_47_ca_tmo.c| 12 
 .../event/cnxk/deq/cn10k/deq_32_47_ca_tmo_burst.c  | 14 ++
 .../event/cnxk/deq/cn10k/deq_32_47_ca_tmo_seg.c| 13 +
 .../cnxk/deq/cn10k/deq_32_47_ca_tmo_seg_burst.c| 14 ++
 drivers/event/cnxk/deq/cn10k/deq_32_47_dual.c  | 12 
 drivers/event/cnxk/deq/cn10k/deq_32_47_seg.c   | 12 
 drivers/event/cnxk/deq/cn10k/deq_32_47_seg_burst.c | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_32_47_tmo.c   | 12 
 drivers/event/cnxk/deq/cn10k/deq_32_47_tmo_burst.c | 14 ++
 drivers/event/cnxk/deq/cn10k/deq_32_47_tmo_seg.c   | 12 
 .../event/cnxk/deq/cn10k/deq_32_47_tmo_seg_burst.c | 14 ++
 drivers/

[PATCH 6/8] net/cnxk: add CN10K template Rx functions to build

[pbhagavatula]

From: Pavan Nikhilesh 

Add CN10K segregated Rx and event dequeue functions to build,
add macros to make future modifications simpler.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/event/cnxk/cn10k_eventdev.c | 114 +++--
 drivers/event/cnxk/cn10k_worker.h   |  71 ++-
 drivers/event/cnxk/cn10k_worker_deq.c   |  44 --
 drivers/event/cnxk/cn10k_worker_deq_burst.c |  29 --
 drivers/event/cnxk/cn10k_worker_deq_ca.c|  65 ---
 drivers/event/cnxk/cn10k_worker_deq_tmo.c   |  72 ---
 drivers/event/cnxk/meson.build  | 135 +-
 drivers/net/cnxk/cn10k_rx.h | 461 +---
 drivers/net/cnxk/cn10k_rx_mseg.c|  17 -
 drivers/net/cnxk/cn10k_rx_select.c  |  67 +++
 drivers/net/cnxk/cn10k_rx_vec.c |  19 -
 drivers/net/cnxk/cn10k_rx_vec_mseg.c|  18 -
 drivers/net/cnxk/meson.build|  40 +-
 13 files changed, 570 insertions(+), 582 deletions(-)
 delete mode 100644 drivers/event/cnxk/cn10k_worker_deq.c
 delete mode 100644 drivers/event/cnxk/cn10k_worker_deq_burst.c
 delete mode 100644 drivers/event/cnxk/cn10k_worker_deq_ca.c
 delete mode 100644 drivers/event/cnxk/cn10k_worker_deq_tmo.c
 delete mode 100644 drivers/net/cnxk/cn10k_rx_mseg.c
 create mode 100644 drivers/net/cnxk/cn10k_rx_select.c
 delete mode 100644 drivers/net/cnxk/cn10k_rx_vec.c
 delete mode 100644 drivers/net/cnxk/cn10k_rx_vec_mseg.c

diff --git a/drivers/event/cnxk/cn10k_eventdev.c 
b/drivers/event/cnxk/cn10k_eventdev.c
index c5a8c1ae8f..02f3d8235d 100644
--- a/drivers/event/cnxk/cn10k_eventdev.c
+++ b/drivers/event/cnxk/cn10k_eventdev.c
@@ -7,13 +7,7 @@
 #include "cnxk_worker.h"
 
 #define CN10K_SET_EVDEV_DEQ_OP(dev, deq_op, deq_ops)   
\
-   (deq_op = deq_ops[!!(dev->rx_offloads & NIX_RX_OFFLOAD_SECURITY_F)]\
-[!!(dev->rx_offloads & NIX_RX_OFFLOAD_VLAN_STRIP_F)]  \
-[!!(dev->rx_offloads & NIX_RX_OFFLOAD_TSTAMP_F)]  \
-[!!(dev->rx_offloads & NIX_RX_OFFLOAD_MARK_UPDATE_F)] \
-[!!(dev->rx_offloads & NIX_RX_OFFLOAD_CHECKSUM_F)]\
-[!!(dev->rx_offloads & NIX_RX_OFFLOAD_PTYPE_F)]   \
-[!!(dev->rx_offloads & NIX_RX_OFFLOAD_RSS_F)])
+   deq_op = deq_ops[dev->rx_offloads & (NIX_RX_OFFLOAD_MAX - 1)]
 
 #define CN10K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops)   
\
(enq_op =  \
@@ -291,95 +285,109 @@ static void
 cn10k_sso_fp_fns_set(struct rte_eventdev *event_dev)
 {
struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev);
-   const event_dequeue_t sso_hws_deq[2][2][2][2][2][2][2] = {
-#define R(name, f6, f5, f4, f3, f2, f1, f0, flags)\
-   [f6][f5][f4][f3][f2][f1][f0] = cn10k_sso_hws_deq_##name,
+   const event_dequeue_t sso_hws_deq[NIX_RX_OFFLOAD_MAX] = {
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_##name,
NIX_RX_FASTPATH_MODES
 #undef R
};
 
-   const event_dequeue_burst_t sso_hws_deq_burst[2][2][2][2][2][2][2] = {
-#define R(name, f6, f5, f4, f3, f2, f1, f0, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn10k_sso_hws_deq_burst_##name,
+   const event_dequeue_burst_t sso_hws_deq_burst[NIX_RX_OFFLOAD_MAX] = {
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_burst_##name,
NIX_RX_FASTPATH_MODES
 #undef R
};
 
-   const event_dequeue_t sso_hws_deq_tmo[2][2][2][2][2][2][2] = {
-#define R(name, f6, f5, f4, f3, f2, f1, f0, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn10k_sso_hws_deq_tmo_##name,
+   const event_dequeue_t sso_hws_deq_tmo[NIX_RX_OFFLOAD_MAX] = {
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_tmo_##name,
NIX_RX_FASTPATH_MODES
 #undef R
};
 
-   const event_dequeue_burst_t
-   sso_hws_deq_tmo_burst[2][2][2][2][2][2][2] = {
-#define R(name, f6, f5, f4, f3, f2, f1, f0, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn10k_sso_hws_deq_tmo_burst_##name,
-   NIX_RX_FASTPATH_MODES
+   const event_dequeue_burst_t sso_hws_deq_tmo_burst[NIX_RX_OFFLOAD_MAX] =
+   {
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_tmo_burst_##name,
+   NIX_RX_FASTPATH_MODES
 #undef R
-   };
+   };
 
-   const event_dequeue_t sso_hws_deq_ca[2][2][2][2][2][2][2] = {
-#define R(name, f6, f5, f4, f3, f2, f1, f0, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn10k_sso_hws_deq_ca_##name,
+   const event_dequeue_t sso_hws_deq_ca[NIX_RX_OFFLOAD_MAX] = {
+#define R(name, flags) [flags] = cn10k_sso_hws_deq_ca_##name,
NIX_RX_FASTPATH_MODES
 #undef R
};
 
-   const event_dequeue_burst_t
-   sso_hws_deq_ca_burs

[PATCH 7/8] net/cnxk: add CN10K segregated Tx functions

[pbhagavatula]

From: Pavan Nikhilesh 

Add CN10K segregated Rx and event Tx enqueue template functions,
these help in parallelizing the build.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/event/cnxk/tx/cn10k/tx_0_15.c   | 10 ++
 drivers/event/cnxk/tx/cn10k/tx_0_15_seg.c   | 11 +++
 drivers/event/cnxk/tx/cn10k/tx_112_127.c| 10 ++
 drivers/event/cnxk/tx/cn10k/tx_112_127_seg.c| 11 +++
 drivers/event/cnxk/tx/cn10k/tx_16_31.c  | 10 ++
 drivers/event/cnxk/tx/cn10k/tx_16_31_seg.c  | 11 +++
 drivers/event/cnxk/tx/cn10k/tx_32_47.c  | 10 ++
 drivers/event/cnxk/tx/cn10k/tx_32_47_seg.c  | 11 +++
 drivers/event/cnxk/tx/cn10k/tx_48_63.c  | 10 ++
 drivers/event/cnxk/tx/cn10k/tx_48_63_seg.c  | 11 +++
 drivers/event/cnxk/tx/cn10k/tx_64_79.c  | 10 ++
 drivers/event/cnxk/tx/cn10k/tx_64_79_seg.c  | 11 +++
 drivers/event/cnxk/tx/cn10k/tx_80_95.c  | 10 ++
 drivers/event/cnxk/tx/cn10k/tx_80_95_seg.c  | 11 +++
 drivers/event/cnxk/tx/cn10k/tx_96_111.c | 10 ++
 drivers/event/cnxk/tx/cn10k/tx_96_111_seg.c | 11 +++
 drivers/net/cnxk/tx/cn10k/tx_0_15.c | 11 +++
 drivers/net/cnxk/tx/cn10k/tx_0_15_mseg.c| 12 
 drivers/net/cnxk/tx/cn10k/tx_0_15_vec.c | 12 
 drivers/net/cnxk/tx/cn10k/tx_0_15_vec_mseg.c| 12 
 drivers/net/cnxk/tx/cn10k/tx_112_127.c  | 11 +++
 drivers/net/cnxk/tx/cn10k/tx_112_127_mseg.c | 12 
 drivers/net/cnxk/tx/cn10k/tx_112_127_vec.c  | 12 
 drivers/net/cnxk/tx/cn10k/tx_112_127_vec_mseg.c | 12 
 drivers/net/cnxk/tx/cn10k/tx_16_31.c| 11 +++
 drivers/net/cnxk/tx/cn10k/tx_16_31_mseg.c   | 12 
 drivers/net/cnxk/tx/cn10k/tx_16_31_vec.c| 12 
 drivers/net/cnxk/tx/cn10k/tx_16_31_vec_mseg.c   | 12 
 drivers/net/cnxk/tx/cn10k/tx_32_47.c| 11 +++
 drivers/net/cnxk/tx/cn10k/tx_32_47_mseg.c   | 12 
 drivers/net/cnxk/tx/cn10k/tx_32_47_vec.c| 12 
 drivers/net/cnxk/tx/cn10k/tx_32_47_vec_mseg.c   | 12 
 drivers/net/cnxk/tx/cn10k/tx_48_63.c| 11 +++
 drivers/net/cnxk/tx/cn10k/tx_48_63_mseg.c   | 12 
 drivers/net/cnxk/tx/cn10k/tx_48_63_vec.c| 12 
 drivers/net/cnxk/tx/cn10k/tx_48_63_vec_mseg.c   | 12 
 drivers/net/cnxk/tx/cn10k/tx_64_79.c| 11 +++
 drivers/net/cnxk/tx/cn10k/tx_64_79_mseg.c   | 12 
 drivers/net/cnxk/tx/cn10k/tx_64_79_vec.c| 12 
 drivers/net/cnxk/tx/cn10k/tx_64_79_vec_mseg.c   | 12 
 drivers/net/cnxk/tx/cn10k/tx_80_95.c| 11 +++
 drivers/net/cnxk/tx/cn10k/tx_80_95_mseg.c   | 12 
 drivers/net/cnxk/tx/cn10k/tx_80_95_vec.c| 12 
 drivers/net/cnxk/tx/cn10k/tx_80_95_vec_mseg.c   | 12 
 drivers/net/cnxk/tx/cn10k/tx_96_111.c   | 11 +++
 drivers/net/cnxk/tx/cn10k/tx_96_111_mseg.c  | 12 
 drivers/net/cnxk/tx/cn10k/tx_96_111_vec.c   | 12 
 drivers/net/cnxk/tx/cn10k/tx_96_111_vec_mseg.c  | 12 
 48 files changed, 544 insertions(+)
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_0_15.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_0_15_seg.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_112_127.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_112_127_seg.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_16_31.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_16_31_seg.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_32_47.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_32_47_seg.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_48_63.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_48_63_seg.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_64_79.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_64_79_seg.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_80_95.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_80_95_seg.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_96_111.c
 create mode 100644 drivers/event/cnxk/tx/cn10k/tx_96_111_seg.c
 create mode 100644 drivers/net/cnxk/tx/cn10k/tx_0_15.c
 create mode 100644 drivers/net/cnxk/tx/cn10k/tx_0_15_mseg.c
 create mode 100644 drivers/net/cnxk/tx/cn10k/tx_0_15_vec.c
 create mode 100644 drivers/net/cnxk/tx/cn10k/tx_0_15_vec_mseg.c
 create mode 100644 drivers/net/cnxk/tx/cn10k/tx_112_127.c
 create mode 100644 drivers/net/cnxk/tx/cn10k/tx_112_127_mseg.c
 create mode 100644 drivers/net/cnxk/tx/cn10k/tx_112_127_vec.c
 create mode 100644 drivers/net/cnxk/tx/cn10k/tx_112_127_vec_mseg.c
 create mode 100644 drivers/net/cnxk/tx/cn10k/tx_16_31.c
 create mode 100644 drivers/net/cnxk/tx/cn10k/tx_16_31_mseg.c
 create mode 10064

[PATCH 8/8] net/cnxk: add CN10K template Tx functions to build

[pbhagavatula]

From: Pavan Nikhilesh 

Add CN10K segregated Tx and event Tx template functions to build,
add macros to make future modifications simpler.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/event/cnxk/cn10k_eventdev.c  |  19 +-
 drivers/event/cnxk/cn10k_worker.h|  36 +-
 drivers/event/cnxk/cn10k_worker_tx_enq.c |  23 -
 drivers/event/cnxk/cn10k_worker_tx_enq_seg.c |  23 -
 drivers/event/cnxk/meson.build   |  21 +-
 drivers/net/cnxk/cn10k_tx.c  |  90 
 drivers/net/cnxk/cn10k_tx.h  | 522 +--
 drivers/net/cnxk/cn10k_tx_mseg.c |  26 -
 drivers/net/cnxk/cn10k_tx_select.c   |  63 +++
 drivers/net/cnxk/cn10k_tx_vec.c  |  25 -
 drivers/net/cnxk/cn10k_tx_vec_mseg.c |  24 -
 drivers/net/cnxk/meson.build |  41 +-
 12 files changed, 413 insertions(+), 500 deletions(-)
 delete mode 100644 drivers/event/cnxk/cn10k_worker_tx_enq.c
 delete mode 100644 drivers/event/cnxk/cn10k_worker_tx_enq_seg.c
 delete mode 100644 drivers/net/cnxk/cn10k_tx.c
 delete mode 100644 drivers/net/cnxk/cn10k_tx_mseg.c
 create mode 100644 drivers/net/cnxk/cn10k_tx_select.c
 delete mode 100644 drivers/net/cnxk/cn10k_tx_vec.c
 delete mode 100644 drivers/net/cnxk/cn10k_tx_vec_mseg.c

diff --git a/drivers/event/cnxk/cn10k_eventdev.c 
b/drivers/event/cnxk/cn10k_eventdev.c
index 02f3d8235d..b56426960a 100644
--- a/drivers/event/cnxk/cn10k_eventdev.c
+++ b/drivers/event/cnxk/cn10k_eventdev.c
@@ -10,14 +10,7 @@
deq_op = deq_ops[dev->rx_offloads & (NIX_RX_OFFLOAD_MAX - 1)]

 #define CN10K_SET_EVDEV_ENQ_OP(dev, enq_op, enq_ops)   
\
-   (enq_op =  \
-enq_ops[!!(dev->tx_offloads & NIX_TX_OFFLOAD_SECURITY_F)] \
-   [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSTAMP_F)]   \
-   [!!(dev->tx_offloads & NIX_TX_OFFLOAD_TSO_F)]  \
-   [!!(dev->tx_offloads & NIX_TX_OFFLOAD_MBUF_NOFF_F)]\
-   [!!(dev->tx_offloads & NIX_TX_OFFLOAD_VLAN_QINQ_F)]\
-   [!!(dev->tx_offloads & NIX_TX_OFFLOAD_OL3_OL4_CSUM_F)] \
-   [!!(dev->tx_offloads & NIX_TX_OFFLOAD_L3_L4_CSUM_F)])
+   enq_op = enq_ops[dev->tx_offloads & (NIX_TX_OFFLOAD_MAX - 1)]

 static uint32_t
 cn10k_sso_gw_mode_wdata(struct cnxk_sso_evdev *dev)
@@ -390,17 +383,15 @@ cn10k_sso_fp_fns_set(struct rte_eventdev *event_dev)

/* Tx modes */
const event_tx_adapter_enqueue_t
-   sso_hws_tx_adptr_enq[2][2][2][2][2][2][2] = {
-#define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn10k_sso_hws_tx_adptr_enq_##name,
+   sso_hws_tx_adptr_enq[NIX_TX_OFFLOAD_MAX] = {
+#define T(name, sz, flags) [flags] = cn10k_sso_hws_tx_adptr_enq_##name,
NIX_TX_FASTPATH_MODES
 #undef T
};

const event_tx_adapter_enqueue_t
-   sso_hws_tx_adptr_enq_seg[2][2][2][2][2][2][2] = {
-#define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) 
\
-   [f6][f5][f4][f3][f2][f1][f0] = cn10k_sso_hws_tx_adptr_enq_seg_##name,
+   sso_hws_tx_adptr_enq_seg[NIX_TX_OFFLOAD_MAX] = {
+#define T(name, sz, flags) [flags] = cn10k_sso_hws_tx_adptr_enq_seg_##name,
NIX_TX_FASTPATH_MODES
 #undef T
};
diff --git a/drivers/event/cnxk/cn10k_worker.h 
b/drivers/event/cnxk/cn10k_worker.h
index 160b90aa27..78d029baaa 100644
--- a/drivers/event/cnxk/cn10k_worker.h
+++ b/drivers/event/cnxk/cn10k_worker.h
@@ -613,17 +613,43 @@ cn10k_sso_hws_event_tx(struct cn10k_sso_hws *ws, struct 
rte_event *ev,
return 1;
 }

-#define T(name, f6, f5, f4, f3, f2, f1, f0, sz, flags) 
\
+#define T(name, sz, flags) 
\
uint16_t __rte_hot cn10k_sso_hws_tx_adptr_enq_##name(  \
void *port, struct rte_event ev[], uint16_t nb_events);\
uint16_t __rte_hot cn10k_sso_hws_tx_adptr_enq_seg_##name(  \
-   void *port, struct rte_event ev[], uint16_t nb_events);\
-   uint16_t __rte_hot cn10k_sso_hws_dual_tx_adptr_enq_##name( \
-   void *port, struct rte_event ev[], uint16_t nb_events);\
-   uint16_t __rte_hot cn10k_sso_hws_dual_tx_adptr_enq_seg_##name( \
void *port, struct rte_event ev[], uint16_t nb_events);

 NIX_TX_FASTPATH_MODES
 #undef T

+#define SSO_TX(fn, sz, flags)  
\
+   uint16_t __rte_hot fn(void *port, struct rte_event ev[],   \
+ uint16_t nb_events)  \
+   {  

[PATCH] eventdev: fix missing internal port checks

[pbhagavatula]

From: Pavan Nikhilesh 

When event delivery is through internal port, stats are mainitained
by HW and we should avoid reading SW data structures for stats.
Fix missing internal port checks.

Fixes: 995b150c1ae1 ("eventdev/eth_rx: add queue stats API")

Signed-off-by: Pavan Nikhilesh 
---
 lib/eventdev/rte_event_eth_rx_adapter.c | 24 ++--
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c 
b/lib/eventdev/rte_event_eth_rx_adapter.c
index 809416d9b7..da223aacac 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -2984,15 +2984,17 @@ rte_event_eth_rx_adapter_queue_stats_get(uint8_t id,
return -EINVAL;
}

-   queue_info = &dev_info->rx_queue[rx_queue_id];
-   event_buf = queue_info->event_buf;
-   q_stats = queue_info->stats;
+   if (dev_info->internal_event_port == 0) {
+   queue_info = &dev_info->rx_queue[rx_queue_id];
+   event_buf = queue_info->event_buf;
+   q_stats = queue_info->stats;

-   stats->rx_event_buf_count = event_buf->count;
-   stats->rx_event_buf_size = event_buf->events_size;
-   stats->rx_packets = q_stats->rx_packets;
-   stats->rx_poll_count = q_stats->rx_poll_count;
-   stats->rx_dropped = q_stats->rx_dropped;
+   stats->rx_event_buf_count = event_buf->count;
+   stats->rx_event_buf_size = event_buf->events_size;
+   stats->rx_packets = q_stats->rx_packets;
+   stats->rx_poll_count = q_stats->rx_poll_count;
+   stats->rx_dropped = q_stats->rx_dropped;
+   }

dev = &rte_eventdevs[rx_adapter->eventdev_id];
if (dev->dev_ops->eth_rx_adapter_queue_stats_get != NULL) {
@@ -3086,8 +3088,10 @@ rte_event_eth_rx_adapter_queue_stats_reset(uint8_t id,
return -EINVAL;
}

-   queue_info = &dev_info->rx_queue[rx_queue_id];
-   rxa_queue_stats_reset(queue_info);
+   if (dev_info->internal_event_port == 0) {
+   queue_info = &dev_info->rx_queue[rx_queue_id];
+   rxa_queue_stats_reset(queue_info);
+   }

dev = &rte_eventdevs[rx_adapter->eventdev_id];
if (dev->dev_ops->eth_rx_adapter_queue_stats_reset != NULL) {
--
2.34.0

[PATCH] vhost: rename field in guest page struct

[xuan . ding]

From: Xuan Ding 

This patch renames the host_phys_addr to host_iova in guest_page
struct. The host_phys_addr is iova, it depends on the DPDK
IOVA mode.

Signed-off-by: Xuan Ding 
---
 lib/vhost/vhost.h  | 10 +-
 lib/vhost/vhost_user.c | 24 
 lib/vhost/virtio_net.c | 11 ++-
 3 files changed, 23 insertions(+), 22 deletions(-)

diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
index d246538ca5..9521ae56da 100644
--- a/lib/vhost/vhost.h
+++ b/lib/vhost/vhost.h
@@ -354,7 +354,7 @@ struct vring_packed_desc_event {
 
 struct guest_page {
uint64_t guest_phys_addr;
-   uint64_t host_phys_addr;
+   uint64_t host_iova;
uint64_t host_user_addr;
uint64_t size;
 };
@@ -605,13 +605,13 @@ gpa_to_first_hpa(struct virtio_net *dev, uint64_t gpa,
if (gpa + gpa_size <=
page->guest_phys_addr + page->size) {
return gpa - page->guest_phys_addr +
-   page->host_phys_addr;
+   page->host_iova;
} else if (gpa < page->guest_phys_addr +
page->size) {
*hpa_size = page->guest_phys_addr +
page->size - gpa;
return gpa - page->guest_phys_addr +
-   page->host_phys_addr;
+   page->host_iova;
}
}
} else {
@@ -622,13 +622,13 @@ gpa_to_first_hpa(struct virtio_net *dev, uint64_t gpa,
if (gpa + gpa_size <=
page->guest_phys_addr + page->size) {
return gpa - page->guest_phys_addr +
-   page->host_phys_addr;
+   page->host_iova;
} else if (gpa < page->guest_phys_addr +
page->size) {
*hpa_size = page->guest_phys_addr +
page->size - gpa;
return gpa - page->guest_phys_addr +
-   page->host_phys_addr;
+   page->host_iova;
}
}
}
diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 6d888766b0..e2e56308b9 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -154,7 +154,7 @@ async_dma_map(struct virtio_net *dev, bool do_map)
page = &dev->guest_pages[i];
ret = 
rte_vfio_container_dma_map(RTE_VFIO_DEFAULT_CONTAINER_FD,
 page->host_user_addr,
-page->host_phys_addr,
+page->host_iova,
 page->size);
if (ret) {
/*
@@ -182,7 +182,7 @@ async_dma_map(struct virtio_net *dev, bool do_map)
page = &dev->guest_pages[i];
ret = 
rte_vfio_container_dma_unmap(RTE_VFIO_DEFAULT_CONTAINER_FD,
   page->host_user_addr,
-  page->host_phys_addr,
+  page->host_iova,
   page->size);
if (ret) {
/* like DMA map, ignore the kernel driver case 
when unmap. */
@@ -977,7 +977,7 @@ vhost_user_set_vring_base(struct virtio_net **pdev,
 
 static int
 add_one_guest_page(struct virtio_net *dev, uint64_t guest_phys_addr,
-  uint64_t host_phys_addr, uint64_t host_user_addr, uint64_t 
size)
+  uint64_t host_iova, uint64_t host_user_addr, uint64_t size)
 {
struct guest_page *page, *last_page;
struct guest_page *old_pages;
@@ -998,7 +998,7 @@ add_one_guest_page(struct virtio_net *dev, uint64_t 
guest_phys_addr,
if (dev->nr_guest_pages > 0) {
last_page = &dev->guest_pages[dev->nr_guest_pages - 1];
/* merge if the two pages are continuous */
-   if (host_phys_addr == last_page->host_phys_addr + 
last_page->size
+   if (host_iova == last_page->host_iova + last_page->size
&& guest_phys_addr == last_page->guest_phys_addr + 
last_page->size
&& host_user_addr == last_page->host_user_addr + 

[Bug 904] [dpdk-19.11.11] Meson build has some failures on Fedora35 with clang 13.0.0

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=904

Bug ID: 904
   Summary: [dpdk-19.11.11] Meson build has some failures on
Fedora35 with clang 13.0.0
   Product: DPDK
   Version: 19.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: meson
  Assignee: dev@dpdk.org
  Reporter: longfengx.li...@intel.com
  Target Milestone: ---

1.DPDK version:
commit 928100dd6d30e733be411380fdb78c68a061936c (HEAD, tag: v19.11.11-rc1,
origin/19.11)
Author: Christian Ehrhardt 
Date:   Thu Dec 9 15:33:57 2021 +0100

version: 19.11.11-rc1

Signed-off-by: Christian Ehrhardt 

2.OS version:
  OS: Fedora35 /5.14.17-301.fc35.x86_64
gcc version: gcc (GCC) 11.2.1 20210728 (Red Hat 11.2.1-1)
clang version: clang version 13.0.0 (Fedora 13.0.0~rc1-1.fc35)
ninja version: 1.10.2.git.kitware.jobserver-1
meson version: 0.60.1

3.build cmd:
CC=clang meson setup build-clang && ninja -C build-clang

4.Error info:

Found ninja-1.10.2.git.kitware.jobserver-1 at /usr/local/bin/ninja
Cleaning... 4 files.
[47/1915] Compiling C object lib/librte_eal.a.p/librte_eal_linux_eal_eal.c.o
../lib/librte_eal/linux/eal/eal.c:590:11: warning: variable 'total_mem' set but
not used [-Wunused-but-set-variable]
uint64_t total_mem = 0;
 ^
1 warning generated.
[208/1915] Compiling C object
lib/librte_power.a.p/librte_power_rte_power_empty_poll.c.o
../lib/librte_power/rte_power_empty_poll.c:210:25: warning: variable 'tot_ppi'
set but not used [-Wunused-but-set-variable]
uint64_t tot_edpi = 0, tot_ppi = 0;
   ^
1 warning generated.
[444/1915] Compiling C object
drivers/libtmp_rte_bus_fslmc.a.p/bus_fslmc_fslmc_bus.c.o
../drivers/bus/fslmc/fslmc_bus.c:311:6: warning: variable 'device_count' set
but not used [-Wunused-but-set-variable]
int device_count = 0;
^
1 warning generated.
[870/1915] Compiling C object
drivers/net/hinic/base/libhinic_base.a.p/hinic_pmd_mgmt.c.o
../drivers/net/hinic/base/hinic_pmd_mgmt.c:136:6: warning: variable
'cmd_buf_max' set but not used [-Wunused-but-set-variable]
u32 cmd_buf_max = MAX_PF_MGMT_BUF_SIZE;
^
../drivers/net/hinic/base/hinic_pmd_mgmt.c:613:6: warning: variable
'msg_buf_max' set but not used [-Wunused-but-set-variable]
u32 msg_buf_max = MAX_PF_MGMT_BUF_SIZE;
^
2 warnings generated.
[894/1915] Compiling C object app/test/dpdk-test.p/test_cmdline_ipaddr.c.o
../app/test/test_cmdline_ipaddr.c:259:3: warning: suspicious concatenation of
string literals in an array initialization; did you mean to separate the
elements with a comma? [-Wstring-concatenation]
"random invalid text",
^
../app/test/test_cmdline_ipaddr.c:258:3: note: place parentheses around the
string literal to silence warning
"1234:1234:1234:1234:1234:1234:1234:1234:1234:1234:1234"
^
1 warning generated.
[902/1915] Compiling C object app/test/dpdk-test.p/test_cmdline_num.c.o
../app/test/test_cmdline_num.c:204:5: warning: suspicious concatenation of
string literals in an array initialization; did you mean to separate the
elements with a comma? [-Wstring-concatenation]
 
"",
  ^
../app/test/test_cmdline_num.c:203:3: note: place parentheses around the string
literal to silence warning
   
"0b"
^
1 warning generated.
[958/1915] Compiling C object
drivers/libtmp_rte_pmd_ifc.a.p/net_ifc_ifcvf_vdpa.c.o
In file included from ../drivers/net/ifc/ifcvf_vdpa.c:25:
../drivers/net/ifc/base/ifcvf.h:16:9: warning: 'VIRTIO_F_IOMMU_PLATFORM' macro
redefined [-Wmacro-redefined]
#define VIRTIO_F_IOMMU_PLATFORM 33
^
/usr/include/linux/virtio_config.h:78:9: note: previous definition is here
#define VIRTIO_F_IOMMU_PLATFORM VIRTIO_F_ACCESS_PLATFORM
^
1 warning generated.
[1026/1915] Compiling C object
drivers/libtmp_rte_pmd_liquidio.a.p/net_liquidio_lio_rxtx.c.o
../drivers/net/liquidio/lio_rxtx.c:1053:11: warning: variable
'tot_inst_processed' set but not used [-Wunused-but-set-variable]
uint32_t tot_inst_processed = 0;
 ^
1 warning generated.
[1084/1915] Compiling C object
drivers/libtmp_rte_pmd_nfp.a.p/net_nfp_nfp_net.c.o
../drivers/net/nfp/nfp_net.c:2597:11: warning: variable 'rss_hf' set but not
used [-Wunused-but-set-variable]
uint64_t rss_hf;
 ^
../drivers/net/nfp/nfp_net.c:3014:24: warning: variable 'totlen' set but not
used [-Wunused-but-set-variable]
size_t count, curlen, totlen = 0;
  ^
../drivers/net/nfp/nfp_net.c:3116:24: warning: variable 'totlen' set but not
used [-Wunused-but-set-variable]
size_t count, curl

RE: [RFC] cryptodev: asymmetric crypto random number source

[Ramkumar Balu]

> ++Ram for openssl
> 
> > ECDSA op: 
> >rte_crypto_param k;
> >   /**< The ECDSA per-message secret number, which is an integer
> >   * in the interval (1, n-1)
> >   */
> > DSA op:
> >   No 'k'.
> >
> > This one I think have described some time ago:
> > Only PMD that verifies ECDSA is OCTEON which apparently needs 'k' provided 
> > by user.
> > Only PMD that verifies DSA is OpenSSL PMD which will generate its own 
> > random number internally.
> >
> > So in case PMD supports one of these options (or especially when supports 
> > both) we need to give some information here.

We can have a standard way to represent if a particular rte_crypto_param is set 
by the application or not.  Then, it is up to the PMD to perform the op or 
return error code if unable to proceed.

> >
> > The most obvious option would be to change rte_crypto_param k -> 
> > rte_crypto_param *k
> > In case (k == NULL) PMD should generate it itself if possible, otherwise it 
> > should push crypto_op to the response ring with appropriate error code.

This case could occur for other params as well. Having a few as nested 
variables and others as pointers could be confusing for memory alloc/dealloc. 
However, the rte_crypto_param already has a data pointer inside it which can be 
used in same manner. For example, in this case (k.data == NULL), PMD should 
generate random number if possible or push to response ring with error code. 
This can be done without breaking backward compatibility.
This can be the standard way for PMDs to find if a particular rte_crypto_param 
is valid or NULL.

> >
> > Another options would be:
> > - Extend rte_cryptodev_config and rte_cryptodev_info with information about 
> > random number generator for specific device (though it would be ABI 
> > breakage)
> > - Provide some kind of callback to get random number from user (which could 
> > be useful for other things like RSA padding as well)

I think the previous solution itself is more straightforward and simpler unless 
we want to have functionality to configure random number generator for each 
device.

Thanks,
Ramkumar Balu

RE: [RFC] Cryptodev: use rte_crypto_vec, group big-endian constraints

[Akhil Goyal]

Hi,
since DPDK 21.11 is out, we should start discussion to make asymmetric API 
stable.

-  Struct rte_crypto_vec vs struct rte_crypto_param_t

We have two almost identical functionally structs, one in _sym.h another in 
asym.h so we probably should pick one of them.
"rte_crypto_vec" additionally contains total length which will be useful 
information as PMD will overwrite "len" in many cases.
Unfortunately as "rte_crypto.h" includes "_sym.h" and "_asym.h" not other way 
around we cannot move it to "rte_crypto.h" but asymmetric will include 
symmetric anyway so it probably will not be that big of an issue.
[Akhil ] +1

-  Network byte order

   rte_crypto_param dP; /**<
   /**< dP - Private CRT component
   * Private CRT component of RSA parameter  required for CRT method
   * RSA private key operations in Octet-string network byte order
   * format.
   * dP = d mod ( p - 1 )
   */
We have plenty of these (sometimes in places where should not be, and not in 
places where should). Every member that contains this comment here is a big 
integer in big-endian format.
We could simplify it to:

/** Big integer in big-endian format */
typedef struct rte_crypto_vec rte_crypto_bigint;

   rte_crypto_bigint dP; /**< d mod ( p - 1 ) */

ED related algorithms like (EDDSA) will use little-endian bit integers so it 
will have to use different approach.

[Akhil] Using different approaches for endianness may not be a good idea. Why 
can't we use rte_crypto_vec for LE? It has a void * data. Right?

[PATCH] config/cn10k: align mempool elements to 128 bytes

[pbhagavatula]

From: Pavan Nikhilesh 

Mempool elements are by default aligned to CACHELINE_SIZE.
In CN10K cacheline size is 64B but the RoC requires buffers to be
aligned to 128B.
Set RTE_MEMPOOL_ALIGN to 128 to force mempool buffers to be aligned
128 bytes.

Signed-off-by: Pavan Nikhilesh 
---
 config/arm/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 213324d262..33afe1a9ad 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -276,7 +276,8 @@ soc_cn10k = {
 'implementer' : '0x41',
 'flags': [
 ['RTE_MAX_LCORE', 24],
-['RTE_MAX_NUMA_NODES', 1]
+['RTE_MAX_NUMA_NODES', 1],
+['RTE_MEMPOOL_ALIGN', 128]
 ],
 'part_number': '0xd49',
 'extra_march_features': ['crypto'],
-- 
2.17.1

Re: 19.11.11 patches review and test

[Ferruh Yigit]

On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:

Hi Christian,

We still see KNI build failure on SLES15 SP3 with dpdk-stable-19.11.11-rc1. Is 
there a plan to address that on 19.11.11 LTS?



Hi Kalesh,

I have sent a backport patch for 20.11, can you please check if it fixes
the build for the v19.11 too?

http://inbox.dpdk.org/stable/byapr11mb27110b5509d1c5b999bb3aa1fe...@byapr11mb2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f



Regards,
Kalesh

On Thu, Dec 9, 2021 at 8:13 PM mailto:christian.ehrha...@canonical.com>> wrote:

Hi all,

Here is a list of patches targeted for stable release 19.11.11.

The planned date for the final release is 7th January 2021.

Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 


These patches are located at branch 19.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/ 

Thanks.

Christian Ehrhardt mailto:christian.ehrha...@canonical.com>>

---
Ajit Khaparde (3):
       net/bnxt: fix Tx queue startup state
       net/bnxt: fix memzone free for Tx and Rx rings
       net/bnxt: fix tunnel port accounting

Alexander Bechikov (1):
       mbuf: fix dump of dynamic fields and flags

Alexander Kozyrev (2):
       net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
       net/mlx5: fix GRE flow item matching

Alvin Zhang (1):
       net/i40e: fix Rx packet statistics

Aman Singh (1):
       kni: fix build for SLES15-SP3

Anatoly Burakov (2):
       vfio: fix FreeBSD clear group stub
       vfio: fix FreeBSD documentation

Anoob Joseph (2):
       test/crypto: skip plain text compare for null cipher
       common/cpt: fix KASUMI input length

Arek Kusztal (2):
       crypto/qat: fix status in RSA decryption
       crypto/qat: fix uncleared cookies after operation

Ben Pfaff (1):
       doc: fix numbers power of 2 in LPM6 guide

Bing Zhao (2):
       net/mlx5: fix flow tables double release
       net/mlx5: fix RETA update without stopping device

Bruce Richardson (3):
       eal/freebsd: lock memory device to prevent conflicts
       test/mem: fix memory autotests on FreeBSD
       eal/freebsd: ignore in-memory option

Chengchang Tang (2):
       net/bonding: fix dedicated queue mode in vector burst
       net/bonding: fix RSS key length

Chengfeng Ye (1):
       net/axgbe: fix unreleased lock in I2C transfer

Chengwen Feng (1):
       kni: check error code of allmulticast mode switch

Cian Ferriter (1):
       ring: fix Doxygen comment of internal function

Ciara Loftus (1):
       net/af_xdp: disable secondary process support

Ciara Power (3):
       crypto/openssl: fix CCM processing 0 length source
       examples/fips_validation: remove unused allocation
       test/crypto: fix unnecessary stats retrieval

Conor Walsh (8):
       net/hinic/base: remove some unused variables
       bus/fslmc: remove unused device count
       event/sw: remove unused inflight events count
       net/liquidio: remove unused counter
       net/qede/base: remove unused message size
       net/vmxnet3: fix build with clang 13
       test/distributor: remove unused counter
       examples/performance-thread: remove unused hits count

Dapeng Yu (1):
       net/ice: save rule on switch filter creation

Dariusz Sosnowski (2):
       net/mlx5: fix MPLS tunnel outer layer overwrite
       doc: fix typo in coding style

David Christensen (3):
       eal/ppc: ignore GCC 10 stringop-overflow warnings
       config/ppc: ignore GCC 11 psabi warnings
       test/atomic: fix 128-bit atomic test with many cores

David Hunt (1):
       test/power: fix CPU frequency when turbo enabled

David Marchand (10):
       net/virtio: avoid unneeded link interrupt configuration
       net/virtio-user: fix Rx interrupts with multi-queue
       bus/vmbus: fix leak on device scan
       test/latency: fix loop boundary
       eal/x86: fix some CPU extended features definitions
       mbuf: enforce no option for dynamic fields and flags
       doc: fix default mempool option in guides
       eal/linux: fix uevent message parsing
       test/red: fix typo in test description
       examples/ntb: fix build dependency

Eli Britstein (4):
       net: avoid cast-align warning in VLAN insert function
       mbuf: avoid cast-align warning in data offset macro
       ea

[PATCH v5 1/2] event/cnxk: update min interval calculation

[pbhagavatula]

From: Pavan Nikhilesh 

Minimum supported interval should now be retrieved from
mailbox based on the clock source and clock frequency.

Signed-off-by: Pavan Nikhilesh 
---
v5:
- Rebase on master.
v4:
- Rebase on master, fix NULL checks.
v3:
- Add new mbox interface.
v2:
- Fixed devargs parsing and rebased.

 drivers/common/cnxk/roc_tim.c   | 32 +++-
 drivers/common/cnxk/roc_tim.h   |  9 +++-
 drivers/common/cnxk/version.map |  1 +
 drivers/event/cnxk/cnxk_tim_evdev.c | 69 +---
 drivers/event/cnxk/cnxk_tim_evdev.h | 81 +
 5 files changed, 138 insertions(+), 54 deletions(-)

diff --git a/drivers/common/cnxk/roc_tim.c b/drivers/common/cnxk/roc_tim.c
index 534b697bee..cefd9bc89d 100644
--- a/drivers/common/cnxk/roc_tim.c
+++ b/drivers/common/cnxk/roc_tim.c
@@ -145,7 +145,7 @@ int
 roc_tim_lf_config(struct roc_tim *roc_tim, uint8_t ring_id,
  enum roc_tim_clk_src clk_src, uint8_t ena_periodic,
  uint8_t ena_dfb, uint32_t bucket_sz, uint32_t chunk_sz,
- uint32_t interval)
+ uint32_t interval, uint64_t intervalns, uint64_t clockfreq)
 {
struct dev *dev = &roc_sso_to_sso_priv(roc_tim->roc_sso)->dev;
struct tim_config_req *req;
@@ -162,6 +162,8 @@ roc_tim_lf_config(struct roc_tim *roc_tim, uint8_t ring_id,
req->enableperiodic = ena_periodic;
req->enabledontfreebuffer = ena_dfb;
req->interval = interval;
+   req->intervalns = intervalns;
+   req->clockfreq = clockfreq;
req->gpioedge = TIM_GPIO_LTOH_TRANS;

rc = mbox_process(dev->mbox);
@@ -173,6 +175,34 @@ roc_tim_lf_config(struct roc_tim *roc_tim, uint8_t ring_id,
return 0;
 }

+int
+roc_tim_lf_interval(struct roc_tim *roc_tim, enum roc_tim_clk_src clk_src,
+   uint64_t clockfreq, uint64_t *intervalns,
+   uint64_t *interval)
+{
+   struct dev *dev = &roc_sso_to_sso_priv(roc_tim->roc_sso)->dev;
+   struct tim_intvl_req *req;
+   struct tim_intvl_rsp *rsp;
+   int rc = -ENOSPC;
+
+   req = mbox_alloc_msg_tim_get_min_intvl(dev->mbox);
+   if (req == NULL)
+   return rc;
+
+   req->clockfreq = clockfreq;
+   req->clocksource = clk_src;
+   rc = mbox_process_msg(dev->mbox, (void **)&rsp);
+   if (rc < 0) {
+   tim_err_desc(rc);
+   return rc;
+   }
+
+   *intervalns = rsp->intvl_ns;
+   *interval = rsp->intvl_cyc;
+
+   return 0;
+}
+
 int
 roc_tim_lf_alloc(struct roc_tim *roc_tim, uint8_t ring_id, uint64_t *clk)
 {
diff --git a/drivers/common/cnxk/roc_tim.h b/drivers/common/cnxk/roc_tim.h
index 159b021a31..392732eae2 100644
--- a/drivers/common/cnxk/roc_tim.h
+++ b/drivers/common/cnxk/roc_tim.h
@@ -10,6 +10,8 @@ enum roc_tim_clk_src {
ROC_TIM_CLK_SRC_GPIO,
ROC_TIM_CLK_SRC_GTI,
ROC_TIM_CLK_SRC_PTP,
+   ROC_TIM_CLK_SRC_SYNCE,
+   ROC_TIM_CLK_SRC_BTS,
ROC_TIM_CLK_SRC_INVALID,
 };

@@ -33,7 +35,12 @@ int __roc_api roc_tim_lf_config(struct roc_tim *roc_tim, 
uint8_t ring_id,
enum roc_tim_clk_src clk_src,
uint8_t ena_periodic, uint8_t ena_dfb,
uint32_t bucket_sz, uint32_t chunk_sz,
-   uint32_t interval);
+   uint32_t interval, uint64_t intervalns,
+   uint64_t clockfreq);
+int __roc_api roc_tim_lf_interval(struct roc_tim *roc_tim,
+ enum roc_tim_clk_src clk_src,
+ uint64_t clockfreq, uint64_t *intervalns,
+ uint64_t *interval);
 int __roc_api roc_tim_lf_alloc(struct roc_tim *roc_tim, uint8_t ring_id,
   uint64_t *clk);
 int __roc_api roc_tim_lf_free(struct roc_tim *roc_tim, uint8_t ring_id);
diff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map
index 07c6720f0c..5379ed2d39 100644
--- a/drivers/common/cnxk/version.map
+++ b/drivers/common/cnxk/version.map
@@ -346,6 +346,7 @@ INTERNAL {
roc_tim_lf_disable;
roc_tim_lf_enable;
roc_tim_lf_free;
+   roc_tim_lf_interval;
roc_se_ctx_swap;

local: *;
diff --git a/drivers/event/cnxk/cnxk_tim_evdev.c 
b/drivers/event/cnxk/cnxk_tim_evdev.c
index 99b3acee7c..becab1d1b1 100644
--- a/drivers/event/cnxk/cnxk_tim_evdev.c
+++ b/drivers/event/cnxk/cnxk_tim_evdev.c
@@ -2,6 +2,8 @@
  * Copyright(C) 2021 Marvell.
  */

+#include 
+
 #include "cnxk_eventdev.h"
 #include "cnxk_tim_evdev.h"

@@ -120,7 +122,10 @@ cnxk_tim_ring_create(struct rte_event_timer_adapter *adptr)
 {
struct rte_event_timer_adapter_conf *rcfg = &adptr->data->conf;
struct cnxk_tim_evdev *dev = cnxk_tim_priv_get();
+   uint64_t min_intvl_ns, min_intvl_cyc;
struct cnxk_tim_ring *tim_ring;
+   enum roc_tim_clk_src clk_sr

[PATCH v5 2/2] event/cnxk: add external clock support for timer

[pbhagavatula]

From: Pavan Nikhilesh 

Add external clock support for cnxk timer adapter.

External clock mapping is as follows:
RTE_EVENT_TIMER_ADAPTER_EXT_CLK0 = TIM_CLK_SRC_10NS,
RTE_EVENT_TIMER_ADAPTER_EXT_CLK1 = TIM_CLK_SRC_GPIO,
RTE_EVENT_TIMER_ADAPTER_EXT_CLK2 = TIM_CLK_SRC_PTP,
RTE_EVENT_TIMER_ADAPTER_EXT_CLK3 = TIM_CLK_SRC_SYNCE,

TIM supports clock input from external GPIO, PTP, SYNCE clocks.
Input resolution is adjusted based on CNTVCT frequency for better
estimation.

Since TIM is unaware of input clock frequency, application is
expected to pass the frequency.
Example:
-a 0002:0e:00.0,tim_eclk_freq=12288-0-0

The order of frequencies above is GPIO-PTP-SYNCE.

Signed-off-by: Shijith Thotton 
Signed-off-by: Pavan Nikhilesh 
---
 doc/guides/eventdevs/cnxk.rst   |  18 
 drivers/common/cnxk/roc_platform.h  |   1 +
 drivers/event/cnxk/cn10k_eventdev.c |   3 +-
 drivers/event/cnxk/cnxk_tim_evdev.c | 137 +++-
 drivers/event/cnxk/cnxk_tim_evdev.h |   4 +
 5 files changed, 160 insertions(+), 3 deletions(-)

diff --git a/doc/guides/eventdevs/cnxk.rst b/doc/guides/eventdevs/cnxk.rst
index 1c0ea988f2..8537f6257e 100644
--- a/doc/guides/eventdevs/cnxk.rst
+++ b/doc/guides/eventdevs/cnxk.rst
@@ -164,6 +164,24 @@ Runtime Config Options

 -a 0002:0e:00.0,tim_ring_ctl=[2-1023-1-0]

+- ``TIM external clock frequency``
+
+  The ``tim_eclk_freq`` devagrs can be used to pass external clock frequencies
+  when external clock source is selected.
+
+  External clock frequencies are mapped as follows::
+
+RTE_EVENT_TIMER_ADAPTER_EXT_CLK0 = TIM_CLK_SRC_10NS,
+RTE_EVENT_TIMER_ADAPTER_EXT_CLK1 = TIM_CLK_SRC_GPIO,
+RTE_EVENT_TIMER_ADAPTER_EXT_CLK2 = TIM_CLK_SRC_PTP,
+RTE_EVENT_TIMER_ADAPTER_EXT_CLK3 = TIM_CLK_SRC_SYNCE
+
+  The order of frequencies supplied to device args should be GPIO-PTP-SYNCE.
+
+  For Example::
+
+-a 0002:0e:00.0,tim_eclk_freq=12288-10-0
+
 Debugging Options
 -

diff --git a/drivers/common/cnxk/roc_platform.h 
b/drivers/common/cnxk/roc_platform.h
index 61d4781209..2742a09190 100644
--- a/drivers/common/cnxk/roc_platform.h
+++ b/drivers/common/cnxk/roc_platform.h
@@ -45,6 +45,7 @@
 #define PLT_MAX RTE_MAX
 #define PLT_DIM RTE_DIM
 #define PLT_SET_USEDRTE_SET_USED
+#define PLT_SWAPRTE_SWAP
 #define PLT_STATIC_ASSERT(s)_Static_assert(s, #s)
 #define PLT_ALIGN   RTE_ALIGN
 #define PLT_ALIGN_MUL_CEIL  RTE_ALIGN_MUL_CEIL
diff --git a/drivers/event/cnxk/cn10k_eventdev.c 
b/drivers/event/cnxk/cn10k_eventdev.c
index b56426960a..70e2aa 100644
--- a/drivers/event/cnxk/cn10k_eventdev.c
+++ b/drivers/event/cnxk/cn10k_eventdev.c
@@ -916,4 +916,5 @@ RTE_PMD_REGISTER_PARAM_STRING(event_cn10k, CNXK_SSO_XAE_CNT 
"="
  CNXK_TIM_DISABLE_NPA "=1"
  CNXK_TIM_CHNK_SLOTS "="
  CNXK_TIM_RINGS_LMT "="
- CNXK_TIM_STATS_ENA "=1");
+ CNXK_TIM_STATS_ENA "=1"
+ CNXK_TIM_EXT_CLK "=");
diff --git a/drivers/event/cnxk/cnxk_tim_evdev.c 
b/drivers/event/cnxk/cnxk_tim_evdev.c
index becab1d1b1..5d52a39752 100644
--- a/drivers/event/cnxk/cnxk_tim_evdev.c
+++ b/drivers/event/cnxk/cnxk_tim_evdev.c
@@ -117,6 +117,80 @@ cnxk_tim_ring_info_get(const struct 
rte_event_timer_adapter *adptr,
   sizeof(struct rte_event_timer_adapter_conf));
 }

+static inline void
+sort_multi_array(double ref_arr[], uint64_t arr1[], uint64_t arr2[],
+uint64_t arr3[], uint8_t sz)
+{
+   int x;
+
+   for (x = 0; x < sz - 1; x++) {
+   if (ref_arr[x] > ref_arr[x + 1]) {
+   PLT_SWAP(ref_arr[x], ref_arr[x + 1]);
+   PLT_SWAP(arr1[x], arr1[x + 1]);
+   PLT_SWAP(arr2[x], arr2[x + 1]);
+   PLT_SWAP(arr3[x], arr3[x + 1]);
+   x = -1;
+   }
+   }
+}
+
+static inline void
+populate_sample(uint64_t tck[], uint64_t ns[], double diff[], uint64_t dst[],
+   uint64_t req_tck, uint64_t clk_freq, double tck_ns, uint8_t sz,
+   bool mov_fwd)
+{
+   int i;
+
+   for (i = 0; i < sz; i++) {
+   tck[i] = i ? tck[i - 1] : req_tck;
+   do {
+   mov_fwd ? tck[i]++ : tck[i]--;
+   ns[i] = round((double)tck[i] * tck_ns);
+   if (round((double)tck[i] * tck_ns) >
+   ((double)tck[i] * tck_ns))
+   continue;
+   } while (ns[i] % (uint64_t)cnxk_tim_ns_per_tck(clk_freq));
+   diff[i] = PLT_MAX((double)ns[i], (double)tck[i] * tck_ns) -
+ PLT_MIN((double)ns[i], (double)tck[i] * tck_ns);
+   dst[i] = mov_fwd ? tck[i] - req_tck : req_tck - tck[i];
+   }
+}
+
+static 

dev@dpdk.org

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=905

Bug ID: 905
   Summary: [dpdk-19.11.11-rc1]Meson&Makefile build failed on
Freebsd13 with gcc10.3.0&clang11.0.1
   Product: DPDK
   Version: 19.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: meson
  Assignee: dev@dpdk.org
  Reporter: longfengx.li...@intel.com
  Target Milestone: ---

1.DPDK version:
commit 928100dd6d30e733be411380fdb78c68a061936c (HEAD, tag: v19.11.11-rc1,
origin/19.11)
Author: Christian Ehrhardt 
Date:   Thu Dec 9 15:33:57 2021 +0100

version: 19.11.11-rc1

Signed-off-by: Christian Ehrhardt 

2.OS version:
  OS: FreeBSD freebsd13-gcc 13.0-RELEASE FreeBSD 13.0-RELEASE
  gcc version:gcc (FreeBSD Ports Collection) 10.3.0
  clang version: FreeBSD clang version 11.0.1

3.And about "(internal_conf.in_memory)" error, bad commit is
"1f3a6bf92333f9c310ba6b7a9ebfc22e0c01b9a0 eal/freebsd: ignore in-memory option"
,other error "lib/librte_eal...",the dpdk 18.11.10 has the same error, Maybe
about New OS issue.

4.Meson GCC build error info:

#CC=gcc meson setup build-gcc && ninja -C build-gcc
Found ninja-1.10.2 at /usr/local/bin/ninja
ninja: Entering directory `build-gcc'
[54/1483] Compiling C object lib/librte_eal.a.p/librte_eal_freebsd_eal_eal.c.o
FAILED: lib/librte_eal.a.p/librte_eal_freebsd_eal_eal.c.o
gcc -Ilib/librte_eal.a.p -Ilib -I../lib -I. -I.. -Iconfig -I../config
-Ilib/librte_eal/common/include -I../lib/librte_eal/common/include
-I../lib/librte_eal/freebsd/eal/include -Ilib/librte_eal/common
-I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86
-I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal
-I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs
-fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3
-include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat
-Wformat-nonliteral -Wformat-security -Wmissing-declarations
-Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith
-Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings
-Wno-address-of-packed-member -Wno-packed-not-aligned
-Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE
-D__BSD_VISIBLE -fPIC -march=native -Wno-format-truncation
-DRTE_LIBEAL_USE_GETENTROPY -DALLOW_EXPERIMENTAL_API -MD -MQ
lib/librte_eal.a.p/librte_eal_freebsd_eal_eal.c.o -MF
lib/librte_eal.a.p/librte_eal_freebsd_eal_eal.c.o.d -o
lib/librte_eal.a.p/librte_eal_freebsd_eal_eal.c.o -c
../lib/librte_eal/freebsd/eal/eal.c
../lib/librte_eal/freebsd/eal/eal.c: In function 'rte_eal_init':
../lib/librte_eal/freebsd/eal/eal.c:746:6: error: 'internal_conf' undeclared
(first use in this function); did you mean 'internal_config'?
  746 |  if (internal_conf.in_memory) {
  |  ^
  |  internal_config
../lib/librte_eal/freebsd/eal/eal.c:746:6: note: each undeclared identifier is
reported only once for each function it appears in
[60/1483] Compiling C object
lib/librte_eal.a.p/librte_eal_common_eal_common_options.c.o
In file included from ../lib/librte_eal/common/include/rte_common.h:28,
 from ../lib/librte_eal/common/include/rte_string_fns.h:21,
 from ../lib/librte_eal/common/eal_common_options.c:19:
../lib/librte_eal/common/eal_common_options.c: In function
'compute_ctrl_threads_cpuset':
../lib/librte_eal/freebsd/eal/include/rte_os.h:35:2: warning: implicit
declaration of function 'CPU_NAND'; did you mean 'CPU_AND'?
[-Wimplicit-function-declaration]
   35 |  CPU_NAND(&tmp, src); \
  |  ^~~~
../lib/librte_eal/common/eal_common_options.c:1499:2: note: in expansion of
macro 'RTE_CPU_NOT'
 1499 |  RTE_CPU_NOT(cpuset, cpuset);
  |  ^~~
../lib/librte_eal/freebsd/eal/include/rte_os.h:35:2: warning: nested extern
declaration of 'CPU_NAND' [-Wnested-externs]
   35 |  CPU_NAND(&tmp, src); \
  |  ^~~~
../lib/librte_eal/common/eal_common_options.c:1499:2: note: in expansion of
macro 'RTE_CPU_NOT'
 1499 |  RTE_CPU_NOT(cpuset, cpuset);
  |  ^~~
[63/1483] Compiling C object
lib/librte_mempool.a.p/librte_mempool_rte_mempool.c.o
ninja: build stopped: subcommand failed.

5.Makefile GCC build error info:

OS: FreeBSD13-64
#
/root/FreeBSD13-64_K13_GCC10.3.0/x86_64-native-bsdapp-gcc/24a3f9888f6d4156818db4090c4ba50c/dpdk/lib/librte_eal/freebsd/eal/eal.c:
In function 'rte_eal_init':
/root/FreeBSD13-64_K13_GCC10.3.0/x86_64-native-bsdapp-gcc/24a3f9888f6d4156818db4090c4ba50c/dpdk/lib/librte_eal/freebsd/eal/eal.c:746:6:
error: 'internal_conf' undeclared (first use in this function); did you mean
'internal_config'?
  746 |  if (internal_conf.in_memory) {
  |  ^
  |  internal_config
/root/FreeBSD13-64_K13_GCC10.3.0/x86_64-native-bsdapp-gcc/24a3f9888f6d4156818db4090c4ba50c/dpdk/lib/librte_eal/freebsd/eal/eal.c:746:6:
note: each undeclared identifier 

Re: 19.11.11 patches review and test

[Christian Ehrhardt]

On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit  wrote:
>
> On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
> > Hi Christian,
> >
> > We still see KNI build failure on SLES15 SP3 with dpdk-stable-19.11.11-rc1. 
> > Is there a plan to address that on 19.11.11 LTS?
> >
>
> Hi Kalesh,
>
> I have sent a backport patch for 20.11, can you please check if it fixes
> the build for the v19.11 too?
>
> http://inbox.dpdk.org/stable/byapr11mb27110b5509d1c5b999bb3aa1fe...@byapr11mb2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f

This patch is already applied in 19.11.11 as [1], thereby at least
without backport adaptations it surely does not fix the problem.

Comparing the upstream, the 20.11 backport and the 19.11 kernel_dir
the difference is that 19.11 currently has it inside the check for
kernel_dir.
But both get initialized from ` get_option('kernel_dir')` so either
both or none would trigger and therefore it should be ok as-is.

I'm happy to consider a fix if someone looks deeper into it and let me
know what adaptations to try.
I can also test build SLES15SP3 (before this discussion I knew it was
"still broken").

[1]: 
https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366

> > Regards,
> > Kalesh
> >
> > On Thu, Dec 9, 2021 at 8:13 PM  > > wrote:
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 19.11.11.
> >
> > The planned date for the final release is 7th January 2021.
> >
> > Please help with testing and validation of your use cases and report
> > any issues/results with reply-all to this mail. For the final release
> > the fixes and reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 
> > 
> >
> > These patches are located at branch 19.11 of dpdk-stable repo:
> > https://dpdk.org/browse/dpdk-stable/ 
> > 
> >
> > Thanks.
> >
> > Christian Ehrhardt  > >
> >
> > ---
> > Ajit Khaparde (3):
> >net/bnxt: fix Tx queue startup state
> >net/bnxt: fix memzone free for Tx and Rx rings
> >net/bnxt: fix tunnel port accounting
> >
> > Alexander Bechikov (1):
> >mbuf: fix dump of dynamic fields and flags
> >
> > Alexander Kozyrev (2):
> >net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
> >net/mlx5: fix GRE flow item matching
> >
> > Alvin Zhang (1):
> >net/i40e: fix Rx packet statistics
> >
> > Aman Singh (1):
> >kni: fix build for SLES15-SP3
> >
> > Anatoly Burakov (2):
> >vfio: fix FreeBSD clear group stub
> >vfio: fix FreeBSD documentation
> >
> > Anoob Joseph (2):
> >test/crypto: skip plain text compare for null cipher
> >common/cpt: fix KASUMI input length
> >
> > Arek Kusztal (2):
> >crypto/qat: fix status in RSA decryption
> >crypto/qat: fix uncleared cookies after operation
> >
> > Ben Pfaff (1):
> >doc: fix numbers power of 2 in LPM6 guide
> >
> > Bing Zhao (2):
> >net/mlx5: fix flow tables double release
> >net/mlx5: fix RETA update without stopping device
> >
> > Bruce Richardson (3):
> >eal/freebsd: lock memory device to prevent conflicts
> >test/mem: fix memory autotests on FreeBSD
> >eal/freebsd: ignore in-memory option
> >
> > Chengchang Tang (2):
> >net/bonding: fix dedicated queue mode in vector burst
> >net/bonding: fix RSS key length
> >
> > Chengfeng Ye (1):
> >net/axgbe: fix unreleased lock in I2C transfer
> >
> > Chengwen Feng (1):
> >kni: check error code of allmulticast mode switch
> >
> > Cian Ferriter (1):
> >ring: fix Doxygen comment of internal function
> >
> > Ciara Loftus (1):
> >net/af_xdp: disable secondary process support
> >
> > Ciara Power (3):
> >crypto/openssl: fix CCM processing 0 length source
> >examples/fips_validation: remove unused allocation
> >test/crypto: fix unnecessary stats retrieval
> >
> > Conor Walsh (8):
> >net/hinic/base: remove some unused variables
> >bus/fslmc: remove unused device count
> >event/sw: remove unused inflight events count
> >net/liquidio: remove unused counter
> >net/qede/base: remove unused message size
> >net/vmxnet3: fix build with clang 13
> >test/distributor: remove unused counter
> >examples/performance-thread: remove unused hits count
> >
> > Dapeng Yu (1):
> >net/ice: save

Re: 19.11.11 patches review and test

[Ferruh Yigit]

On 12/13/2021 12:39 PM, Christian Ehrhardt wrote:

On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit  wrote:


On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:

Hi Christian,

We still see KNI build failure on SLES15 SP3 with dpdk-stable-19.11.11-rc1. Is 
there a plan to address that on 19.11.11 LTS?



Hi Kalesh,

I have sent a backport patch for 20.11, can you please check if it fixes
the build for the v19.11 too?

http://inbox.dpdk.org/stable/byapr11mb27110b5509d1c5b999bb3aa1fe...@byapr11mb2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f


This patch is already applied in 19.11.11 as [1], thereby at least
without backport adaptations it surely does not fix the problem.



It is indeed.

@Kalesh, can you please share more details related to the build error?



Comparing the upstream, the 20.11 backport and the 19.11 kernel_dir
the difference is that 19.11 currently has it inside the check for
kernel_dir.
But both get initialized from ` get_option('kernel_dir')` so either
both or none would trigger and therefore it should be ok as-is.

I'm happy to consider a fix if someone looks deeper into it and let me
know what adaptations to try.
I can also test build SLES15SP3 (before this discussion I knew it was
"still broken").



The above fix should fix the build for SLES15SP3, are you aware of any
build error after that patch?



[1]: 
https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366


Regards,
Kalesh

On Thu, Dec 9, 2021 at 8:13 PM mailto:christian.ehrha...@canonical.com>> wrote:

 Hi all,

 Here is a list of patches targeted for stable release 19.11.11.

 The planned date for the final release is 7th January 2021.

 Please help with testing and validation of your use cases and report
 any issues/results with reply-all to this mail. For the final release
 the fixes and reported validations will be added to the release notes.

 A release candidate tarball can be found at:

 https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 


 These patches are located at branch 19.11 of dpdk-stable repo:
 https://dpdk.org/browse/dpdk-stable/ 

 Thanks.

 Christian Ehrhardt mailto:christian.ehrha...@canonical.com>>

 ---
 Ajit Khaparde (3):
net/bnxt: fix Tx queue startup state
net/bnxt: fix memzone free for Tx and Rx rings
net/bnxt: fix tunnel port accounting

 Alexander Bechikov (1):
mbuf: fix dump of dynamic fields and flags

 Alexander Kozyrev (2):
net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
net/mlx5: fix GRE flow item matching

 Alvin Zhang (1):
net/i40e: fix Rx packet statistics

 Aman Singh (1):
kni: fix build for SLES15-SP3

 Anatoly Burakov (2):
vfio: fix FreeBSD clear group stub
vfio: fix FreeBSD documentation

 Anoob Joseph (2):
test/crypto: skip plain text compare for null cipher
common/cpt: fix KASUMI input length

 Arek Kusztal (2):
crypto/qat: fix status in RSA decryption
crypto/qat: fix uncleared cookies after operation

 Ben Pfaff (1):
doc: fix numbers power of 2 in LPM6 guide

 Bing Zhao (2):
net/mlx5: fix flow tables double release
net/mlx5: fix RETA update without stopping device

 Bruce Richardson (3):
eal/freebsd: lock memory device to prevent conflicts
test/mem: fix memory autotests on FreeBSD
eal/freebsd: ignore in-memory option

 Chengchang Tang (2):
net/bonding: fix dedicated queue mode in vector burst
net/bonding: fix RSS key length

 Chengfeng Ye (1):
net/axgbe: fix unreleased lock in I2C transfer

 Chengwen Feng (1):
kni: check error code of allmulticast mode switch

 Cian Ferriter (1):
ring: fix Doxygen comment of internal function

 Ciara Loftus (1):
net/af_xdp: disable secondary process support

 Ciara Power (3):
crypto/openssl: fix CCM processing 0 length source
examples/fips_validation: remove unused allocation
test/crypto: fix unnecessary stats retrieval

 Conor Walsh (8):
net/hinic/base: remove some unused variables
bus/fslmc: remove unused device count
event/sw: remove unused inflight events count
net/liquidio: remove unused counter
net/qede/base: remove unused message size
net/vmxnet3: fix build with clang 13
test/distributor: remove unused counter
examples/performance-thread: remove unused hits count

 Dapeng Yu (1):
net/ice: save rule on switch filter creation

 Dariusz Sosnowski (2):
net/mlx5: fix MPLS tunnel outer

Re: 19.11.11 patches review and test

[Christian Ehrhardt]

On Mon, Dec 13, 2021 at 1:59 PM Ferruh Yigit  wrote:
>
> On 12/13/2021 12:39 PM, Christian Ehrhardt wrote:
> > On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit  
> > wrote:
> >>
> >> On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
> >>> Hi Christian,
> >>>
> >>> We still see KNI build failure on SLES15 SP3 with 
> >>> dpdk-stable-19.11.11-rc1. Is there a plan to address that on 19.11.11 LTS?
> >>>
> >>
> >> Hi Kalesh,
> >>
> >> I have sent a backport patch for 20.11, can you please check if it fixes
> >> the build for the v19.11 too?
> >>
> >> http://inbox.dpdk.org/stable/byapr11mb27110b5509d1c5b999bb3aa1fe...@byapr11mb2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
> >
> > This patch is already applied in 19.11.11 as [1], thereby at least
> > without backport adaptations it surely does not fix the problem.
> >
>
> It is indeed.
>
> @Kalesh, can you please share more details related to the build error?
>
>
> > Comparing the upstream, the 20.11 backport and the 19.11 kernel_dir
> > the difference is that 19.11 currently has it inside the check for
> > kernel_dir.
> > But both get initialized from ` get_option('kernel_dir')` so either
> > both or none would trigger and therefore it should be ok as-is.
> >
> > I'm happy to consider a fix if someone looks deeper into it and let me
> > know what adaptations to try.
> > I can also test build SLES15SP3 (before this discussion I knew it was
> > "still broken").
> >
>
> The above fix should fix the build for SLES15SP3, are you aware of any
> build error after that patch?

As I said my SLES15SP3 test build kept failing [1] and it looked like
the very same issue as before.

[  351s]   CC
/home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/igb_uio/igb_uio.mod.o
[  351s] 
/home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/kni/kni_net.c:791:20:
error: initialization from incompatible pointer type
[-Werror=incompatible-pointer-types]
[  351s]   .ndo_tx_timeout = kni_net_tx_timeout,
[  351s] ^~

[1]: 
https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64

> > [1]: 
> > https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366
> >
> >>> Regards,
> >>> Kalesh
> >>>
> >>> On Thu, Dec 9, 2021 at 8:13 PM  >>> > wrote:
> >>>
> >>>  Hi all,
> >>>
> >>>  Here is a list of patches targeted for stable release 19.11.11.
> >>>
> >>>  The planned date for the final release is 7th January 2021.
> >>>
> >>>  Please help with testing and validation of your use cases and report
> >>>  any issues/results with reply-all to this mail. For the final release
> >>>  the fixes and reported validations will be added to the release 
> >>> notes.
> >>>
> >>>  A release candidate tarball can be found at:
> >>>
> >>>  https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 
> >>> 
> >>>
> >>>  These patches are located at branch 19.11 of dpdk-stable repo:
> >>>  https://dpdk.org/browse/dpdk-stable/ 
> >>> 
> >>>
> >>>  Thanks.
> >>>
> >>>  Christian Ehrhardt  >>> >
> >>>
> >>>  ---
> >>>  Ajit Khaparde (3):
> >>> net/bnxt: fix Tx queue startup state
> >>> net/bnxt: fix memzone free for Tx and Rx rings
> >>> net/bnxt: fix tunnel port accounting
> >>>
> >>>  Alexander Bechikov (1):
> >>> mbuf: fix dump of dynamic fields and flags
> >>>
> >>>  Alexander Kozyrev (2):
> >>> net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
> >>> net/mlx5: fix GRE flow item matching
> >>>
> >>>  Alvin Zhang (1):
> >>> net/i40e: fix Rx packet statistics
> >>>
> >>>  Aman Singh (1):
> >>> kni: fix build for SLES15-SP3
> >>>
> >>>  Anatoly Burakov (2):
> >>> vfio: fix FreeBSD clear group stub
> >>> vfio: fix FreeBSD documentation
> >>>
> >>>  Anoob Joseph (2):
> >>> test/crypto: skip plain text compare for null cipher
> >>> common/cpt: fix KASUMI input length
> >>>
> >>>  Arek Kusztal (2):
> >>> crypto/qat: fix status in RSA decryption
> >>> crypto/qat: fix uncleared cookies after operation
> >>>
> >>>  Ben Pfaff (1):
> >>> doc: fix numbers power of 2 in LPM6 guide
> >>>
> >>>  Bing Zhao (2):
> >>> net/mlx5: fix flow tables double release
> >>> net/mlx5: fix RETA update without stopping device
> >>>
> >>>  Bruce Richardson (3):
> >>> eal/freebsd: lock memory device to prevent conflicts
> >>> test/mem: fix memory autotests on FreeBSD
> >>> eal/freebsd: ignore in-mem

Re: 19.11.11 patches review and test

[Kalesh Anakkur Purayil]

Hi Christian/Ferruh,

On Mon, 13 Dec 2021 at 7:03 PM, Christian Ehrhardt <
christian.ehrha...@canonical.com> wrote:

> On Mon, Dec 13, 2021 at 1:59 PM Ferruh Yigit 
> wrote:
> >
> > On 12/13/2021 12:39 PM, Christian Ehrhardt wrote:
> > > On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit 
> wrote:
> > >>
> > >> On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
> > >>> Hi Christian,
> > >>>
> > >>> We still see KNI build failure on SLES15 SP3 with
> dpdk-stable-19.11.11-rc1. Is there a plan to address that on 19.11.11 LTS?
> > >>>
> > >>
> > >> Hi Kalesh,
> > >>
> > >> I have sent a backport patch for 20.11, can you please check if it
> fixes
> > >> the build for the v19.11 too?
> > >>
> > >>
> http://inbox.dpdk.org/stable/byapr11mb27110b5509d1c5b999bb3aa1fe...@byapr11mb2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
> > >
> > > This patch is already applied in 19.11.11 as [1], thereby at least
> > > without backport adaptations it surely does not fix the problem.
> > >
> >
> > It is indeed.
> >
> > @Kalesh, can you please share more details related to the build error?
> >
> >
> > > Comparing the upstream, the 20.11 backport and the 19.11 kernel_dir
> > > the difference is that 19.11 currently has it inside the check for
> > > kernel_dir.
> > > But both get initialized from ` get_option('kernel_dir')` so either
> > > both or none would trigger and therefore it should be ok as-is.
> > >
> > > I'm happy to consider a fix if someone looks deeper into it and let me
> > > know what adaptations to try.
> > > I can also test build SLES15SP3 (before this discussion I knew it was
> > > "still broken").
> > >
> >
> > The above fix should fix the build for SLES15SP3, are you aware of any
> > build error after that patch?
>
> As I said my SLES15SP3 test build kept failing [1] and it looked like
> the very same issue as before.
>
> [  351s]   CC
>
> /home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/igb_uio/igb_uio.mod.o
> [  351s]
> /home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/kni/kni_net.c:791:20:
> error: initialization from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> [  351s]   .ndo_tx_timeout = kni_net_tx_timeout,
> [  351s] ^~
>
> [1]:
> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64

[Kalesh] Yes, i am seeing the same error. I used make command to build
dpdk, not meson.
The back ported commit you mentioned takes care of meson build only I think.

Regards,
Kalesh

>
> 
>
> > > [1]:
> https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366
> > >
> > >>> Regards,
> > >>> Kalesh
> > >>>
> > >>> On Thu, Dec 9, 2021 at 8:13 PM  > wrote:
> > >>>
> > >>>  Hi all,
> > >>>
> > >>>  Here is a list of patches targeted for stable release 19.11.11.
> > >>>
> > >>>  The planned date for the final release is 7th January 2021.
> > >>>
> > >>>  Please help with testing and validation of your use cases and
> report
> > >>>  any issues/results with reply-all to this mail. For the final
> release
> > >>>  the fixes and reported validations will be added to the release
> notes.
> > >>>
> > >>>  A release candidate tarball can be found at:
> > >>>
> > >>>  https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 <
> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1>
> > >>>
> > >>>  These patches are located at branch 19.11 of dpdk-stable repo:
> > >>>  https://dpdk.org/browse/dpdk-stable/ <
> https://dpdk.org/browse/dpdk-stable/>
> > >>>
> > >>>  Thanks.
> > >>>
> > >>>  Christian Ehrhardt  christian.ehrha...@canonical.com>>
> > >>>
> > >>>  ---
> > >>>  Ajit Khaparde (3):
> > >>> net/bnxt: fix Tx queue startup state
> > >>> net/bnxt: fix memzone free for Tx and Rx rings
> > >>> net/bnxt: fix tunnel port accounting
> > >>>
> > >>>  Alexander Bechikov (1):
> > >>> mbuf: fix dump of dynamic fields and flags
> > >>>
> > >>>  Alexander Kozyrev (2):
> > >>> net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
> > >>> net/mlx5: fix GRE flow item matching
> > >>>
> > >>>  Alvin Zhang (1):
> > >>> net/i40e: fix Rx packet statistics
> > >>>
> > >>>  Aman Singh (1):
> > >>> kni: fix build for SLES15-SP3
> > >>>
> > >>>  Anatoly Burakov (2):
> > >>> vfio: fix FreeBSD clear group stub
> > >>> vfio: fix FreeBSD documentation
> > >>>
> > >>>  Anoob Joseph (2):
> > >>> test/crypto: skip plain text compare for null cipher
> > >>> common/cpt: fix KASUMI input length
> > >>>
> > >>>   

Re: 19.11.11 patches review and test

[Ferruh Yigit]

On 12/13/2021 1:49 PM, Kalesh Anakkur Purayil wrote:

Hi Christian/Ferruh,

On Mon, 13 Dec 2021 at 7:03 PM, Christian Ehrhardt mailto:christian.ehrha...@canonical.com>> wrote:

On Mon, Dec 13, 2021 at 1:59 PM Ferruh Yigit mailto:ferruh.yi...@intel.com>> wrote:
 >
 > On 12/13/2021 12:39 PM, Christian Ehrhardt wrote:
 > > On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit mailto:ferruh.yi...@intel.com>> wrote:
 > >>
 > >> On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
 > >>> Hi Christian,
 > >>>
 > >>> We still see KNI build failure on SLES15 SP3 with 
dpdk-stable-19.11.11-rc1. Is there a plan to address that on 19.11.11 LTS?
 > >>>
 > >>
 > >> Hi Kalesh,
 > >>
 > >> I have sent a backport patch for 20.11, can you please check if it 
fixes
 > >> the build for the v19.11 too?
 > >>
 > >> 
http://inbox.dpdk.org/stable/byapr11mb27110b5509d1c5b999bb3aa1fe...@byapr11mb2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
 

 > >
 > > This patch is already applied in 19.11.11 as [1], thereby at least
 > > without backport adaptations it surely does not fix the problem.
 > >
 >
 > It is indeed.
 >
 > @Kalesh, can you please share more details related to the build error?
 >
 >
 > > Comparing the upstream, the 20.11 backport and the 19.11 kernel_dir
 > > the difference is that 19.11 currently has it inside the check for
 > > kernel_dir.
 > > But both get initialized from ` get_option('kernel_dir')` so either
 > > both or none would trigger and therefore it should be ok as-is.
 > >
 > > I'm happy to consider a fix if someone looks deeper into it and let me
 > > know what adaptations to try.
 > > I can also test build SLES15SP3 (before this discussion I knew it was
 > > "still broken").
 > >
 >
 > The above fix should fix the build for SLES15SP3, are you aware of any
 > build error after that patch?

As I said my SLES15SP3 test build kept failing [1] and it looked like
the very same issue as before.

[  351s]   CC

/home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/igb_uio/igb_uio.mod.o
[  351s] 
/home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/kni/kni_net.c:791:20:
error: initialization from incompatible pointer type
[-Werror=incompatible-pointer-types]
[  351s]   .ndo_tx_timeout = kni_net_tx_timeout,
[  351s]                     ^~

[1]: 
https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64
 


[Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, 
not meson.
The back ported commit you mentioned takes care of meson build only I think.



I see, make build is failing, and yes the fix is only for the meson.
I will check the make build and will send a fix for it.


Regards,
Kalesh




 > > [1]: 
https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366
 

 > >
 > >>> Regards,
 > >>> Kalesh
 > >>>
 > >>> On Thu, Dec 9, 2021 at 8:13 PM mailto:christian.ehrha...@canonical.com> >> wrote:
 > >>>
 > >>>      Hi all,
 > >>>
 > >>>      Here is a list of patches targeted for stable release 19.11.11.
 > >>>
 > >>>      The planned date for the final release is 7th January 2021.
 > >>>
 > >>>      Please help with testing and validation of your use cases and 
report
 > >>>      any issues/results with reply-all to this mail. For the final 
release
 > >>>      the fixes and reported validations will be added to the release 
notes.
 > >>>
 > >>>      A release candidate tarball can be found at:
 > >>>
 > >>> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1 
 
>
 > >>>
 > >>>      These patches are located at branch 19.11 of dpdk-stable repo:
 > >>> https://dpdk.org/browse/dpdk-stable/  
>
 > >>>
 > >>>      Thanks.
 > >>>
 >

Re: 20.11.4 patches review and test

[Pei Zhang]

Hello Xueming,

The testing with dpdk 20.11.4-rc1 from Red Hat looks good. We tested below
20 scenarios and all got PASS on RHEL8:

(1)Guest with device assignment(PF) throughput testing(1G hugepage size):
PASS
(2)Guest with device assignment(PF) throughput testing(2M hugepage size) :
PASS
(3)Guest with device assignment(VF) throughput testing: PASS
(4)PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
(5)PVP vhost-user 2Q throughput testing: PASS
(6)PVP vhost-user 1Q - cross numa node throughput testing: PASS
(7)Guest with vhost-user 2Q throughput testing: PASS
(8)vhost-user reconnect with dpdk-client, qemu-server: qemu reconnect: PASS
(9)vhost-user reconnect with dpdk-client, qemu-server: ovs reconnect: PASS
(10)PVP 1Q live migration testing: PASS
(11)PVP 1Q post copy live migration testing: PASS
(12)PVP 1Q cross numa node live migration testing: PASS
(13)Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
(14)Guest with ovs+dpdk+vhost-user 1Q post copy live migration testing: PASS
(15)Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
(16)Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
(17)Guest with ovs+dpdk+vhost-user 2Q post copy live migration testing: PASS
(18)Guest with ovs+dpdk+vhost-user 4Q live migration testing: PASS
(19)Host PF + DPDK testing: PASS
(20)Host VF + DPDK testing: PASS

Versions:
kernel 4.18
qemu 6.1

dpdk: git://dpdk.org/dpdk-stable
branch: remotes/origin/20.11
# git log -1
commit bab4318634e0d2276e8bae5ea18789cfda813c70 (HEAD, tag: v20.11.4-rc1,
origin/20.11)
Author: Xueming Li 
Date:   Tue Dec 7 00:02:07 2021 +0800

version: 20.11.4-rc1

Signed-off-by: Xueming Li 


NICs: X540-AT2 NIC(ixgbe, 10G)

Best regards,

Pei



On Tue, Dec 7, 2021 at 12:16 AM Xueming Li  wrote:

> Hi all,
>
> Here is a list of patches targeted for stable release 20.11.4.
>
> The planned date for the final release is 31th December.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
> https://dpdk.org/browse/dpdk-stable/tag/?id=v20.11.4-rc1
>
> These patches are located at branch 20.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
>
> Thanks.
>
> Xueming Li 
>
> ---
> Ajit Khaparde (5):
>   net/bnxt: update ring group after ring stop start
>   net/bnxt: fix Tx queue startup state
>   net/bnxt: fix memzone free for Tx and Rx rings
>   net/bnxt: fix tunnel port accounting
>   doc: update NIC feature matrix for bnxt
>
> Alexander Bechikov (1):
>   mbuf: fix dump of dynamic fields and flags
>
> Alexander Kozyrev (3):
>   net/mlx5: fix mbuf replenishment check for zipped CQE
>   net/mlx5: fix GRE flow item matching
>   net/mlx5: fix GENEVE and VXLAN-GPE flow item matching
>
> Alvin Zhang (4):
>   app/testpmd: update forward engine beginning
>   app/testpmd: fix txonly forwarding
>   net/i40e: fix Rx packet statistics
>   net/iavf: fix pointer of meta data
>
> Anatoly Burakov (3):
>   vfio: fix FreeBSD clear group stub
>   vfio: fix FreeBSD documentation
>   vfio: set errno on unsupported OS
>
> Andrew Rybchenko (4):
>   mempool: deprecate unused physical page defines
>   drivers/net: remove queue xstats auto-fill flag
>   ethdev: forbid closing started device
>   common/sfc_efx: fix debug compilation control
>
> Anoob Joseph (4):
>   examples/ipsec-secgw: fix parsing of flow queue
>   test/crypto: skip plain text compare for null cipher
>   test/crypto: fix missing return checks
>   common/cpt: fix KASUMI input length
>
> Arek Kusztal (2):
>   crypto/qat: fix status in RSA decryption
>   crypto/qat: fix uncleared cookies after operation
>
> Baruch Siach (1):
>   net/af_xdp: fix zero-copy Tx queue drain
>
> Ben Magistro (2):
>   doc: fix bonding driver name
>   net/i40e: fix i40evf device initialization
>
> Ben Pfaff (1):
>   doc: fix numbers power of 2 in LPM6 guide
>
> Bing Zhao (3):
>   net/mlx5: fix flow tables double release
>   net/mlx5: fix RETA update without stopping device
>   vdpa/mlx5: fix mkey creation check
>
> Bruce Richardson (5):
>   usertools: fix handling EOF for telemetry input pipe
>   eal/freebsd: lock memory device to prevent conflicts
>   test/mem: fix memory autotests on FreeBSD
>   eal/freebsd: ignore in-memory option
>   doc: fix Doxygen examples build on FreeBSD
>
> Chengchang Tang (4):
>   net/hns3: fix queue flow action validation
>   net/hns3: fix taskqueue pair reset command
>   net/bonding: fix dedicated queue mode in vector burst
>   net/bonding: fix RSS key length
>
> Chengfeng Ye (2):
>   net/axgbe: fix unreleased lock in I2C transfer
>   net/mlx5: fix mutex unlock in Tx packet pacing cleanup
>
> Chengwen

[PATCH] crypto: use single buffer for asymmetric session

[Ciara Power]

Rather than using a session buffer that contains pointers to private
session data elsewhere, have a single session buffer.
This session is created for a driver ID, and the mempool element
contains space for the max session private data needed for any driver.

Signed-off-by: Ciara Power 

---
Hiding the asym session structure by moving it to an internal header
will be implemented in a later version of this patch.
---
 app/test-crypto-perf/cperf_ops.c  |  14 +-
 app/test/test_cryptodev_asym.c| 204 --
 drivers/crypto/cnxk/cn10k_cryptodev_ops.c |   6 +-
 drivers/crypto/cnxk/cn9k_cryptodev_ops.c  |   6 +-
 drivers/crypto/cnxk/cnxk_cryptodev_ops.c  |  11 +-
 drivers/crypto/octeontx/otx_cryptodev_ops.c   |  29 +--
 drivers/crypto/octeontx2/otx2_cryptodev_ops.c |  25 +--
 drivers/crypto/openssl/rte_openssl_pmd.c  |   5 +-
 drivers/crypto/openssl/rte_openssl_pmd_ops.c  |  23 +-
 drivers/crypto/qat/qat_asym.c |  35 +--
 lib/cryptodev/cryptodev_pmd.h |  11 +-
 lib/cryptodev/cryptodev_trace_points.c|   3 +
 lib/cryptodev/rte_cryptodev.c | 199 +++--
 lib/cryptodev/rte_cryptodev.h | 107 ++---
 lib/cryptodev/rte_cryptodev_trace.h   |  12 ++
 lib/cryptodev/version.map |   6 +-
 16 files changed, 302 insertions(+), 394 deletions(-)

diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cperf_ops.c
index d975ae1ab8..bdc5dc9544 100644
--- a/app/test-crypto-perf/cperf_ops.c
+++ b/app/test-crypto-perf/cperf_ops.c
@@ -735,7 +735,6 @@ cperf_create_session(struct rte_mempool *sess_mp,
struct rte_crypto_sym_xform aead_xform;
struct rte_cryptodev_sym_session *sess = NULL;
struct rte_crypto_asym_xform xform = {0};
-   int rc;
 
if (options->op_type == CPERF_ASYM_MODEX) {
xform.next = NULL;
@@ -745,19 +744,10 @@ cperf_create_session(struct rte_mempool *sess_mp,
xform.modex.exponent.data = perf_mod_e;
xform.modex.exponent.length = sizeof(perf_mod_e);
 
-   sess = (void *)rte_cryptodev_asym_session_create(sess_mp);
+   sess = (void *)rte_cryptodev_asym_session_create(sess_mp, 
dev_id, &xform);
if (sess == NULL)
return NULL;
-   rc = rte_cryptodev_asym_session_init(dev_id, (void *)sess,
-&xform, priv_mp);
-   if (rc < 0) {
-   if (sess != NULL) {
-   rte_cryptodev_asym_session_clear(dev_id,
-(void *)sess);
-   rte_cryptodev_asym_session_free((void *)sess);
-   }
-   return NULL;
-   }
+
return sess;
}
 #ifdef RTE_LIB_SECURITY
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 9d19a6d6d9..672260fb78 100644
--- a/app/test/test_cryptodev_asym.c
+++ b/app/test/test_cryptodev_asym.c
@@ -450,7 +450,8 @@ test_cryptodev_asym_op(struct crypto_testsuite_params_asym 
*ts_params,
}
 
if (!sessionless) {
-   sess = 
rte_cryptodev_asym_session_create(ts_params->session_mpool);
+   sess = 
rte_cryptodev_asym_session_create(ts_params->session_mpool,
+   dev_id, &xform_tc);
if (!sess) {
snprintf(test_msg, ASYM_TEST_MSG_LEN,
"line %u "
@@ -460,15 +461,6 @@ test_cryptodev_asym_op(struct crypto_testsuite_params_asym 
*ts_params,
goto error_exit;
}
 
-   if (rte_cryptodev_asym_session_init(dev_id, sess, &xform_tc,
-   ts_params->session_mpool) < 0) {
-   snprintf(test_msg, ASYM_TEST_MSG_LEN,
-   "line %u FAILED: %s",
-   __LINE__, "unabled to config sym 
session");
-   status = TEST_FAILED;
-   goto error_exit;
-   }
-
rte_crypto_op_attach_asym_session(op, sess);
} else {
asym_op->xform = &xform_tc;
@@ -667,18 +659,11 @@ test_rsa_sign_verify(void)
return TEST_SKIPPED;
}
 
-   sess = rte_cryptodev_asym_session_create(sess_mpool);
+   sess = rte_cryptodev_asym_session_create(sess_mpool, dev_id, 
&rsa_xform);
 
if (!sess) {
RTE_LOG(ERR, USER1, "Session creation failed for "
"sign_verify\n");
-   return TEST_FAILED;
-   }
-
-   if (rte_cryptodev_asym_session_init(dev_id, sess, &rsa_xform,
-   sess_mpool) < 0) {
-   RTE_LOG(ERR, USER1, "Unable to config asym session for 

RE: dev Digest, Vol 381, Issue 38

[McDaniel, Timothy]

> -Original Message-
> From: dev-requ...@dpdk.org 
> Sent: Tuesday, December 7, 2021 7:51 PM
> To: dev@dpdk.org
> Subject: dev Digest, Vol 381, Issue 38
> 
> Send dev mailing list submissions to
>   dev@dpdk.org
> 
> To subscribe or unsubscribe via the World Wide Web, visit
>   https://mails.dpdk.org/listinfo/dev
> or, via email, send a message with subject or body 'help' to
>   dev-requ...@dpdk.org
> 
> You can reach the person managing the list at
>   dev-ow...@dpdk.org
> 
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of dev digest..."
> 
> 
> Today's Topics:
> 
>1. [PATCH v12 02/11] app/test: remove POSIX-specific code (Jie Zhou)
>2. [PATCH v2] doc/dlb2: update dlb2 documentation (Rashmi Shetty)
>3. [PATCH v13 01/11] eal/windows: return ENOTSUP for not
>   supported API (Jie Zhou)
>4. [PATCH v13 03/11] app/test: fix incorrect errno variable
>   (Jie Zhou)
>5. [PATCH v13 04/11] app/test: skip interrupt tests on Windows
>   (Jie Zhou)
>6. [PATCH v13 00/11] app/test: enable subset of tests on Windows
>   (Jie Zhou)
> 
> 
> --
> 
> Message: 1
> Date: Tue,  7 Dec 2021 13:24:14 -0800
> From: Jie Zhou 
> To: dev@dpdk.org
> Cc: dmitry.kozl...@gmail.com, bruce.richard...@intel.com,
>   roret...@microsoft.com, navas...@linux.microsoft.com,
>   dmit...@microsoft.com, pallavi.ka...@intel.com,
> tal...@nvidia.com,
>   tho...@monjalon.net, acon...@redhat.com
> Subject: [PATCH v12 02/11] app/test: remove POSIX-specific code
> Message-ID:
>   <1638912263-7054-3-git-send-email-j...@linux.microsoft.com>
> 
> - Replace POSIX-specific code with DPDK equivalents or conditional platform
>   specific code, or conditionally disable it on Windows
> - Use NUL on Windows as /dev/null for Unix
> - Exclude tests not supported on Windows yet
>   * multi-process
>   * PMD performance statistics display on signal
> 
> Signed-off-by: Jie Zhou 
> Signed-off-by: Dmitry Kozlyuk 
> 
> ---
>  app/test/commands.c   |  2 --
>  app/test/packet_burst_generator.c |  1 +
>  app/test/process.h|  4 +++-
>  app/test/test.c   |  5 -
>  app/test/test_byteorder.c |  2 +-
>  app/test/test_cmdline_ipaddr.c| 19 +--
>  app/test/test_cmdline_lib.c   | 13 +
>  app/test/test_crc.c   |  1 -
>  app/test/test_memcpy_perf.c   | 28 ++--
>  app/test/test_pmd_perf.c  |  6 +-
>  app/test/test_ring_stress_impl.h  |  2 +-
>  app/test/test_telemetry_data.c|  2 ++
>  12 files changed, 49 insertions(+), 36 deletions(-)
> 
> diff --git a/app/test/commands.c b/app/test/commands.c
> index 2dced3bc44..887cabad64 100644
> --- a/app/test/commands.c
> +++ b/app/test/commands.c
> @@ -8,8 +8,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
> -#include 
>  #include 
>  #include 
>  #include 
> diff --git a/app/test/packet_burst_generator.c
> b/app/test/packet_burst_generator.c
> index 8ac24577ba..6b42b9b83b 100644
> --- a/app/test/packet_burst_generator.c
> +++ b/app/test/packet_burst_generator.c
> @@ -5,6 +5,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
> 
>  #include "packet_burst_generator.h"
> 
> diff --git a/app/test/process.h b/app/test/process.h
> index 5b10cf64df..1f073b9c5c 100644
> --- a/app/test/process.h
> +++ b/app/test/process.h
> @@ -7,12 +7,14 @@
> 
>  #include   /* errno */
>  #include  /* PATH_MAX */
> +#ifndef RTE_EXEC_ENV_WINDOWS
>  #include  /* basename et al */
> +#include 
> +#endif
>  #include  /* NULL */
>  #include  /* strerror */
>  #include  /* readlink */
>  #include 
> -#include 
> 
>  #include  /* strlcpy */
> 
> diff --git a/app/test/test.c b/app/test/test.c
> index 5194131026..e69cae3eea 100644
> --- a/app/test/test.c
> +++ b/app/test/test.c
> @@ -8,7 +8,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
>  #include 
>  #include 
> 
> @@ -63,7 +62,9 @@ do_recursive_call(void)
>   const char *env_var;
>   int (*action_fn)(void);
>   } actions[] =  {
> +#ifndef RTE_EXEC_ENV_WINDOWS
>   { "run_secondary_instances", test_mp_secondary },
> +#endif
>  #ifdef RTE_LIB_PDUMP
>  #ifdef RTE_NET_RING
>   { "run_pdump_server_tests", test_pdump },
> @@ -82,7 +83,9 @@ do_recursive_call(void)
>   { "test_file_prefix", no_action },
>   { "test_no_huge_flag", no_action },
>  #ifdef RTE_LIB_TIMER
> +#ifndef RTE_EXEC_ENV_WINDOWS
>   { "timer_secondary_spawn_wait",
> test_timer_secondary },
> +#endif
>  #endif
>   };
> 
> diff --git a/app/test/test_byteorder.c b/app/test/test_byteorder.c
> index 03c08d9abf..de14ed539e 100644
> --- a/app/test/test_byteorder.c
> +++ b/app/test/test_byteorder.c
> @@ -46,7 +46,7 @@ test_byteorder(void)
>   return -1;
> 
>   res_u16 =

RE: [EXT] [PATCH] crypto: use single buffer for asymmetric session

[Anoob Joseph]

Hi Ciara,

+1 to the overall approach. Few comments inline.

Thanks,
Anoob

> -Original Message-
> From: Ciara Power 
> Sent: Monday, December 13, 2021 8:34 PM
> To: dev@dpdk.org
> Cc: roy.fan.zh...@intel.com; Akhil Goyal ; Ciara
> Power ; Declan Doherty
> ; Ankur Dwivedi ;
> Anoob Joseph ; Tejasree Kondoj
> ; John Griffin ; Fiona
> Trahe ; Deepak Kumar Jain
> ; Ray Kinsella 
> Subject: [EXT] [PATCH] crypto: use single buffer for asymmetric session
> 
> External Email
> 
> --
> Rather than using a session buffer that contains pointers to private session
> data elsewhere, have a single session buffer.
> This session is created for a driver ID, and the mempool element contains
> space for the max session private data needed for any driver.
> 
> Signed-off-by: Ciara Power 
> 
> ---
> Hiding the asym session structure by moving it to an internal header will be
> implemented in a later version of this patch.
> ---
>  app/test-crypto-perf/cperf_ops.c  |  14 +-
>  app/test/test_cryptodev_asym.c| 204 --
>  drivers/crypto/cnxk/cn10k_cryptodev_ops.c |   6 +-
>  drivers/crypto/cnxk/cn9k_cryptodev_ops.c  |   6 +-
>  drivers/crypto/cnxk/cnxk_cryptodev_ops.c  |  11 +-
>  drivers/crypto/octeontx/otx_cryptodev_ops.c   |  29 +--
>  drivers/crypto/octeontx2/otx2_cryptodev_ops.c |  25 +--
>  drivers/crypto/openssl/rte_openssl_pmd.c  |   5 +-
>  drivers/crypto/openssl/rte_openssl_pmd_ops.c  |  23 +-
>  drivers/crypto/qat/qat_asym.c |  35 +--
>  lib/cryptodev/cryptodev_pmd.h |  11 +-
>  lib/cryptodev/cryptodev_trace_points.c|   3 +
>  lib/cryptodev/rte_cryptodev.c | 199 +++--
>  lib/cryptodev/rte_cryptodev.h | 107 ++---
>  lib/cryptodev/rte_cryptodev_trace.h   |  12 ++
>  lib/cryptodev/version.map |   6 +-
>  16 files changed, 302 insertions(+), 394 deletions(-)
> 

[snip]

> diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h
> index 59ea5a54df..11a62bb555 100644
> --- a/lib/cryptodev/rte_cryptodev.h
> +++ b/lib/cryptodev/rte_cryptodev.h
> @@ -919,9 +919,15 @@ struct rte_cryptodev_sym_session {  };
> 
>  /** Cryptodev asymmetric crypto session */ -struct
> rte_cryptodev_asym_session {
> - __extension__ void *sess_private_data[0];
> - /**< Private asymmetric session material */
> +__extension__ struct rte_cryptodev_asym_session {
> + uint8_t driver_id;
> + /**< Session driver ID. */
> + uint8_t max_priv_session_sz;
> + /**< size of private session data used when creating mempool */
> + uint16_t user_data_sz;
> + /**< session user data will be placed after sess_data */
> + uint8_t padding[4];
> + uint8_t sess_private_data[0];
>  };

[Anoob] Should we add a uint64_t member to hold IOVA address of, may be, 
rte_cryptodev_asym_session()? IOVA address could be required for hardware PMDs. 
And typically rte_mempool_virt2iova() used to help in that. Also, did you 
consider whether this layout of crypto session can be kept uniform across sym, 
asym & security? There is no asym specific field in this struct, right?

> 
>  /**
> @@ -956,6 +962,31 @@ rte_cryptodev_sym_session_pool_create(const
> char *name, uint32_t nb_elts,
>   uint32_t elt_size, uint32_t cache_size, uint16_t priv_size,
>   int socket_id);
> 
> +/**
> + * Create an asymmetric session mempool.
> + *
> + * @param name
> + *   The unique mempool name.
> + * @param nb_elts
> + *   The number of elements in the mempool.
> + * @param cache_size
> + *   The number of per-lcore cache elements
> + * @param user_data_size
> + *   The size of user data to be placed after session private data.
> + * @param socket_id
> + *   The *socket_id* argument is the socket identifier in the case of
> + *   NUMA. The value can be *SOCKET_ID_ANY* if there is no NUMA
> + *   constraint for the reserved zone.
> + *
> + * @return
> + *  - On success return size of the session
> + *  - On failure returns 0
> + */
> +__rte_experimental
> +struct rte_mempool *
> +rte_cryptodev_asym_session_pool_create(const char *name, uint32_t
> nb_elts,
> + uint32_t cache_size, uint16_t user_data_size, int socket_id);
> +
>  /**
>   * Create symmetric crypto session header (generic with no private data)
>   *
> @@ -973,13 +1004,17 @@ rte_cryptodev_sym_session_create(struct
> rte_mempool *mempool);
>   *
>   * @param   mempoolmempool to allocate asymmetric session
>   * objects from
> + * @param   dev_id   ID of device that we want the session to be used on
> + * @param   xforms   Asymmetric crypto transform operations to apply on
> flow
> + *   processed with this session
>   * @return
>   *  - On success return pointer to asym-session
>   *  - On failure returns NULL
>   */
>  __rte_experimental
>  struct rte_cryptodev_asym_session *
> -rte_cryptodev_asy

[PATCH 1/2] maintainers: fix stable maintainers list

[Kevin Traynor]

Christian and Xueming are both already maintaining LTS releases.

Update the MAINTAINERS file to reflect this.

Cc: sta...@dpdk.org

Signed-off-by: Kevin Traynor 
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 18d9edaf88..84d8e261d5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -65,4 +65,6 @@ Stable Branches
 M: Luca Boccassi 
 M: Kevin Traynor 
+M: Christian Ehrhardt 
+M: Xueming Li 
 T: git://dpdk.org/dpdk-stable
 
-- 
2.31.1

[PATCH 2/2] doc: update LTS release cadence

[Kevin Traynor]

Regular LTS releases have previously aligned to DPDK main branch
releases so that fixes being backported have already gone through
DPDK main branch release validation.

Now that DPDK main branch has moved to 3 releases per year, the LTS
releases should continue to align with it and follow a similar release
cadence.

Update stable docs to reflect this.

Signed-off-by: Kevin Traynor 
---
 doc/guides/contributing/stable.rst | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/doc/guides/contributing/stable.rst 
b/doc/guides/contributing/stable.rst
index 69d8312b47..9ee7b4b7cc 100644
--- a/doc/guides/contributing/stable.rst
+++ b/doc/guides/contributing/stable.rst
@@ -39,5 +39,5 @@ A Stable Release is used to backport fixes from an ``N`` 
release back to an
 ``N-1`` release, for example, from 16.11 to 16.07.
 
-The duration of a stable is one complete release cycle (3 months). It can be
+The duration of a stable is one complete release cycle (4 months). It can be
 longer, up to 1 year, if a maintainer continues to support the stable branch,
 or if users supply backported fixes, however the explicit commitment should be
@@ -62,6 +62,8 @@ A LTS release may align with the declaration of a new major 
ABI version,
 please read the :doc:`abi_policy` for more information.
 
-It is anticipated that there will be at least 4 releases per year of the LTS
-or approximately 1 every 3 months. However, the cadence can be shorter or
+It is anticipated that there will be at least 3 releases per year of the LTS
+or approximately 1 every 4 months. This is done to align with the DPDK main
+branch releases so that fixes have already gone through validation as part of
+the DPDK main branch release validation. However, the cadence can be shorter or
 longer depending on the number and criticality of the backported
 fixes. Releases should be coordinated with the validation engineers to ensure
-- 
2.31.1

Re: [PATCH v18 8/8] eal: implement functions for mutex management

[Narcisa Ana Maria Vasile]

On Wed, Nov 10, 2021 at 05:33:45PM -0800, Narcisa Ana Maria Vasile wrote:
> From: Narcisa Vasile 
> 
> Add functions for mutex init, destroy, lock, unlock, trylock.
> 
> Windows does not have a static initializer. Initialization
> is only done through InitializeCriticalSection(). To overcome this,
> RTE_INIT_MUTEX macro is added to replace static initialization
> of mutexes. The macro calls rte_thread_mutex_init().
> 
> Add unit tests to verify that the mutex correctly locks/unlocks
> and protects the data. Check both static and dynamic mutexes.
> 
> Signed-off-by: Narcisa Vasile 
> ---

Hi Bruce R., Stephen H., I've followed Bruce's suggestion and changed this 
patchset
to return ENOTSUP for realtime priority on Linux. Can you please take a look at
the latest version of the patchset?
Let me know if it needs any changes or if it's ready to be merged. Thank you!

[PATCH] event/cnxk: fix qos devargs parsing

[pbhagavatula]

From: Pavan Nikhilesh 

Fix qos devargs parsing using incorrect datatype for the
structure elements.

Fixes: 38c2e3240ba8 ("event/cnxk: add option to control SSO HWGRP QoS")

Signed-off-by: Pavan Nikhilesh 
---
 drivers/event/cnxk/cnxk_eventdev.c | 2 +-
 drivers/event/cnxk/cnxk_eventdev.h | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/event/cnxk/cnxk_eventdev.c 
b/drivers/event/cnxk/cnxk_eventdev.c
index f7a5026250..6ad4e23e2b 100644
--- a/drivers/event/cnxk/cnxk_eventdev.c
+++ b/drivers/event/cnxk/cnxk_eventdev.c
@@ -482,7 +482,7 @@ static void
 parse_queue_param(char *value, void *opaque)
 {
struct cnxk_sso_qos queue_qos = {0};
-   uint8_t *val = (uint8_t *)&queue_qos;
+   uint16_t *val = (uint16_t *)&queue_qos;
struct cnxk_sso_evdev *dev = opaque;
char *tok = strtok(value, "-");
struct cnxk_sso_qos *old_ptr;
diff --git a/drivers/event/cnxk/cnxk_eventdev.h 
b/drivers/event/cnxk/cnxk_eventdev.h
index 305c6a3b9e..4652b58a84 100644
--- a/drivers/event/cnxk/cnxk_eventdev.h
+++ b/drivers/event/cnxk/cnxk_eventdev.h
@@ -74,9 +74,9 @@ typedef void (*cnxk_sso_hws_flush_t)(void *ws, uint8_t 
queue_id, uintptr_t base,
 
 struct cnxk_sso_qos {
uint16_t queue;
-   uint8_t xaq_prcnt;
-   uint8_t taq_prcnt;
-   uint8_t iaq_prcnt;
+   uint16_t xaq_prcnt;
+   uint16_t taq_prcnt;
+   uint16_t iaq_prcnt;
 };
 
 struct cnxk_sso_evdev {
-- 
2.17.1

[PATCH] common/cnxk: add telemetry endpoints to SSO

[pbhagavatula]

From: Pavan Nikhilesh 

Add common telemetry endpoints for SSO.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/common/cnxk/cnxk_telemetry_sso.c | 50 
 drivers/common/cnxk/meson.build  |  4 +-
 drivers/common/cnxk/roc_idev.c   | 20 ++
 drivers/common/cnxk/roc_idev_priv.h  |  3 ++
 drivers/common/cnxk/roc_sso.c|  1 +
 drivers/common/cnxk/roc_sso_priv.h   |  1 +
 drivers/common/cnxk/roc_utils.c  |  3 ++
 7 files changed, 81 insertions(+), 1 deletion(-)
 create mode 100644 drivers/common/cnxk/cnxk_telemetry_sso.c

diff --git a/drivers/common/cnxk/cnxk_telemetry_sso.c 
b/drivers/common/cnxk/cnxk_telemetry_sso.c
new file mode 100644
index 00..822934ebd7
--- /dev/null
+++ b/drivers/common/cnxk/cnxk_telemetry_sso.c
@@ -0,0 +1,50 @@
+
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2021 Marvell.
+ */
+
+#include 
+
+#include "cnxk_telemetry.h"
+#include "roc_api.h"
+#include "roc_priv.h"
+
+static int
+cnxk_tel_sso(struct plt_tel_data *d)
+{
+   struct roc_sso *roc_sso;
+   struct sso *sso;
+
+   roc_sso = idev_sso_get();
+   if (roc_sso == NULL)
+   return SSO_ERR_DEVICE_NOT_BOUNDED;
+
+   sso = roc_sso_to_sso_priv(roc_sso);
+   plt_tel_data_add_dict_ptr(d, "roc_sso", roc_sso);
+   plt_tel_data_add_dict_ptr(d, "sso", sso);
+   plt_tel_data_add_dict_int(d, "max_hws", roc_sso->max_hws);
+   plt_tel_data_add_dict_int(d, "max_hwgrp", roc_sso->max_hwgrp);
+   plt_tel_data_add_dict_int(d, "nb_hws", roc_sso->nb_hws);
+   plt_tel_data_add_dict_int(d, "nb_hwgrp", roc_sso->nb_hwgrp);
+   plt_tel_data_add_dict_int(d, "pf_func", sso->dev.pf_func);
+   plt_tel_data_add_dict_int(d, "pid", getpid());
+
+   return 0;
+}
+
+static int
+cnxk_sso_tel_handle_info(const char *cmd __plt_unused,
+const char *params __plt_unused,
+struct plt_tel_data *d)
+{
+   plt_tel_data_start_dict(d);
+   cnxk_tel_sso(d);
+   return 0;
+}
+
+PLT_INIT(cnxk_telemetry_sso_init)
+{
+   plt_telemetry_register_cmd(
+   "/cnxk/sso/info", cnxk_sso_tel_handle_info,
+   "Returns sso information. Takes no parameters");
+}
diff --git a/drivers/common/cnxk/meson.build b/drivers/common/cnxk/meson.build
index 4928f7e549..88407af828 100644
--- a/drivers/common/cnxk/meson.build
+++ b/drivers/common/cnxk/meson.build
@@ -77,6 +77,8 @@ includes += include_directories('../../../lib/meter')
 # Telemetry common code
 sources += files('cnxk_telemetry_bphy.c',
  'cnxk_telemetry_npa.c',
- 'cnxk_telemetry_nix.c')
+ 'cnxk_telemetry_nix.c',
+ 'cnxk_telemetry_sso.c',
+)
 
 deps += ['bus_pci', 'net', 'telemetry']
diff --git a/drivers/common/cnxk/roc_idev.c b/drivers/common/cnxk/roc_idev.c
index 648f37b3bb..b1f38fb5fc 100644
--- a/drivers/common/cnxk/roc_idev.c
+++ b/drivers/common/cnxk/roc_idev.c
@@ -206,3 +206,23 @@ roc_idev_npa_nix_get(void)
dev = container_of(npa_lf, struct dev, npa);
return dev->roc_nix;
 }
+
+struct roc_sso *
+idev_sso_get(void)
+{
+   struct idev_cfg *idev = idev_get_cfg();
+
+   if (idev != NULL)
+   return __atomic_load_n(&idev->sso, __ATOMIC_ACQUIRE);
+
+   return NULL;
+}
+
+void
+idev_sso_set(struct roc_sso *sso)
+{
+   struct idev_cfg *idev = idev_get_cfg();
+
+   if (idev != NULL)
+   __atomic_store_n(&idev->sso, sso, __ATOMIC_RELEASE);
+}
diff --git a/drivers/common/cnxk/roc_idev_priv.h 
b/drivers/common/cnxk/roc_idev_priv.h
index 2c8309b8fd..46eebffcbb 100644
--- a/drivers/common/cnxk/roc_idev_priv.h
+++ b/drivers/common/cnxk/roc_idev_priv.h
@@ -21,6 +21,7 @@ struct idev_cfg {
uint64_t lmt_base_addr;
struct roc_bphy *bphy;
struct roc_cpt *cpt;
+   struct roc_sso *sso;
struct nix_inl_dev *nix_inl_dev;
plt_spinlock_t nix_inl_dev_lock;
 };
@@ -39,6 +40,8 @@ uint16_t idev_npa_lf_active(struct dev *dev);
 /* idev sso */
 void idev_sso_pffunc_set(uint16_t sso_pf_func);
 uint16_t idev_sso_pffunc_get(void);
+struct roc_sso *idev_sso_get(void);
+void idev_sso_set(struct roc_sso *sso);
 
 /* idev lmt */
 uint16_t idev_lmt_pffunc_get(void);
diff --git a/drivers/common/cnxk/roc_sso.c b/drivers/common/cnxk/roc_sso.c
index 45ff16ca0e..1b85f04970 100644
--- a/drivers/common/cnxk/roc_sso.c
+++ b/drivers/common/cnxk/roc_sso.c
@@ -726,6 +726,7 @@ roc_sso_dev_init(struct roc_sso *roc_sso)
link_mem = PLT_PTR_ADD(link_mem, link_map_sz);
}
idev_sso_pffunc_set(sso->dev.pf_func);
+   idev_sso_set(roc_sso);
sso->pci_dev = pci_dev;
sso->dev.drv_inited = true;
roc_sso->lmt_base = sso->dev.lmt_base;
diff --git a/drivers/common/cnxk/roc_sso_priv.h 
b/drivers/common/cnxk/roc_sso_priv.h
index 2e1b025d1c..09729d4f62 100644
--- a/drivers/common/cnxk/roc_sso_priv.h
+++ b/drivers/common/cnxk/roc_sso_priv.h
@@ -26,6

[PATCH] common/cnxk: add workaround for vWQE flush

[pbhagavatula]

From: Pavan Nikhilesh 

Due to an errata writing to vWQE flush register might hang NIX.
Add workaround for vWQE flush hang by waiting for the max
coalescing timeout to flush out any pending vWQEs.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/common/cnxk/roc_nix_inl.c  |  3 +--
 drivers/common/cnxk/roc_nix_inl_dev.c  | 12 
 drivers/common/cnxk/roc_nix_inl_priv.h |  1 +
 drivers/common/cnxk/roc_nix_priv.h |  1 +
 drivers/common/cnxk/roc_nix_queue.c| 19 +--
 5 files changed, 32 insertions(+), 4 deletions(-)

diff --git a/drivers/common/cnxk/roc_nix_inl.c 
b/drivers/common/cnxk/roc_nix_inl.c
index f0fc690417..e8981c4aa4 100644
--- a/drivers/common/cnxk/roc_nix_inl.c
+++ b/drivers/common/cnxk/roc_nix_inl.c
@@ -595,8 +595,7 @@ roc_nix_inl_dev_rq_put(struct roc_nix_rq *rq)
plt_err("Failed to disable inline device rq, rc=%d", rc);
 
/* Flush NIX LF for CN10K */
-   if (roc_model_is_cn10k())
-   plt_write64(0, inl_dev->nix_base + NIX_LF_OP_VWQE_FLUSH);
+   nix_rq_vwqe_flush(rq, inl_dev->vwqe_interval);
 
return rc;
 }
diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c 
b/drivers/common/cnxk/roc_nix_inl_dev.c
index a0fe6ecd82..10912a6c93 100644
--- a/drivers/common/cnxk/roc_nix_inl_dev.c
+++ b/drivers/common/cnxk/roc_nix_inl_dev.c
@@ -346,6 +346,7 @@ nix_inl_nix_setup(struct nix_inl_dev *inl_dev)
struct mbox *mbox = dev->mbox;
struct nix_lf_alloc_rsp *rsp;
struct nix_lf_alloc_req *req;
+   struct nix_hw_info *hw_info;
size_t inb_sa_sz;
int i, rc = -ENOSPC;
void *sa;
@@ -382,6 +383,17 @@ nix_inl_nix_setup(struct nix_inl_dev *inl_dev)
inl_dev->qints = rsp->qints;
inl_dev->cints = rsp->cints;
 
+   /* Get VWQE info if supported */
+   if (roc_model_is_cn10k()) {
+   mbox_alloc_msg_nix_get_hw_info(mbox);
+   rc = mbox_process_msg(mbox, (void *)&hw_info);
+   if (rc) {
+   plt_err("Failed to get HW info, rc=%d", rc);
+   goto lf_free;
+   }
+   inl_dev->vwqe_interval = hw_info->vwqe_delay;
+   }
+
/* Register nix interrupts */
rc = nix_inl_nix_register_irqs(inl_dev);
if (rc) {
diff --git a/drivers/common/cnxk/roc_nix_inl_priv.h 
b/drivers/common/cnxk/roc_nix_inl_priv.h
index 3dc526f929..be53a3fa81 100644
--- a/drivers/common/cnxk/roc_nix_inl_priv.h
+++ b/drivers/common/cnxk/roc_nix_inl_priv.h
@@ -35,6 +35,7 @@ struct nix_inl_dev {
/* NIX data */
uint8_t lf_tx_stats;
uint8_t lf_rx_stats;
+   uint16_t vwqe_interval;
uint16_t cints;
uint16_t qints;
struct roc_nix_rq rq;
diff --git a/drivers/common/cnxk/roc_nix_priv.h 
b/drivers/common/cnxk/roc_nix_priv.h
index 04575af295..deb2a6ba11 100644
--- a/drivers/common/cnxk/roc_nix_priv.h
+++ b/drivers/common/cnxk/roc_nix_priv.h
@@ -377,6 +377,7 @@ int nix_rq_cfg(struct dev *dev, struct roc_nix_rq *rq, 
uint16_t qints, bool cfg,
 int nix_rq_ena_dis(struct dev *dev, struct roc_nix_rq *rq, bool enable);
 int nix_tm_bp_config_get(struct roc_nix *roc_nix, bool *is_enabled);
 int nix_tm_bp_config_set(struct roc_nix *roc_nix, bool enable);
+void nix_rq_vwqe_flush(struct roc_nix_rq *rq, uint16_t vwqe_interval);
 
 /*
  * TM priv utils.
diff --git a/drivers/common/cnxk/roc_nix_queue.c 
b/drivers/common/cnxk/roc_nix_queue.c
index c8c8401d81..d5f6813e69 100644
--- a/drivers/common/cnxk/roc_nix_queue.c
+++ b/drivers/common/cnxk/roc_nix_queue.c
@@ -28,6 +28,22 @@ nix_qsize_clampup(uint32_t val)
return i;
 }
 
+void
+nix_rq_vwqe_flush(struct roc_nix_rq *rq, uint16_t vwqe_interval)
+{
+   uint64_t wait_ns;
+
+   if (!roc_model_is_cn10k())
+   return;
+   /* Due to HW errata writes to VWQE_FLUSH might hang, so instead
+* wait for max vwqe timeout interval.
+*/
+   if (rq->vwqe_ena) {
+   wait_ns = rq->vwqe_wait_tmo * (vwqe_interval + 1) * 100;
+   plt_delay_us((wait_ns / 1E3) + 1);
+   }
+}
+
 int
 nix_rq_ena_dis(struct dev *dev, struct roc_nix_rq *rq, bool enable)
 {
@@ -66,9 +82,8 @@ roc_nix_rq_ena_dis(struct roc_nix_rq *rq, bool enable)
int rc;
 
rc = nix_rq_ena_dis(&nix->dev, rq, enable);
+   nix_rq_vwqe_flush(rq, nix->vwqe_interval);
 
-   if (roc_model_is_cn10k())
-   plt_write64(rq->qid, nix->base + NIX_LF_OP_VWQE_FLUSH);
return rc;
 }
 
-- 
2.17.1

[PATCH] common/cnxk: use XAQ create API for inline device

[pbhagavatula]

From: Pavan Nikhilesh 

Use the XAQ aura create and free API while initializing the
inline device.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/common/cnxk/roc_nix_debug.c|  4 +-
 drivers/common/cnxk/roc_nix_inl_dev.c  | 53 ++
 drivers/common/cnxk/roc_nix_inl_priv.h |  3 +-
 3 files changed, 15 insertions(+), 45 deletions(-)

diff --git a/drivers/common/cnxk/roc_nix_debug.c 
b/drivers/common/cnxk/roc_nix_debug.c
index 266935a6c5..5886650d6e 100644
--- a/drivers/common/cnxk/roc_nix_debug.c
+++ b/drivers/common/cnxk/roc_nix_debug.c
@@ -1257,8 +1257,8 @@ roc_nix_inl_dev_dump(struct roc_nix_inl_dev *roc_inl_dev)
nix_dump("  \txaq_buf_size = %u", inl_dev->xaq_buf_size);
nix_dump("  \txae_waes = %u", inl_dev->xae_waes);
nix_dump("  \tiue = %u", inl_dev->iue);
-   nix_dump("  \txaq_aura = 0x%" PRIx64, inl_dev->xaq_aura);
-   nix_dump("  \txaq_mem = 0x%p", inl_dev->xaq_mem);
+   nix_dump("  \txaq_aura = 0x%" PRIx64, inl_dev->xaq.aura_handle);
+   nix_dump("  \txaq_mem = 0x%p", inl_dev->xaq.mem);
 
nix_dump("  \tinl_dev_rq:");
roc_nix_rq_dump(&inl_dev->rq);
diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c 
b/drivers/common/cnxk/roc_nix_inl_dev.c
index 10912a6c93..dd93765a2b 100644
--- a/drivers/common/cnxk/roc_nix_inl_dev.c
+++ b/drivers/common/cnxk/roc_nix_inl_dev.c
@@ -5,8 +5,6 @@
 #include "roc_api.h"
 #include "roc_priv.h"
 
-#define XAQ_CACHE_CNT 0x7
-
 /* Default Rx Config for Inline NIX LF */
 #define NIX_INL_LF_RX_CFG  
\
(ROC_NIX_LF_RX_CFG_DROP_RE | ROC_NIX_LF_RX_CFG_L2_LEN_ERR |\
@@ -220,10 +218,8 @@ nix_inl_sso_setup(struct nix_inl_dev *inl_dev)
 {
struct sso_lf_alloc_rsp *sso_rsp;
struct dev *dev = &inl_dev->dev;
-   uint32_t xaq_cnt, count, aura;
uint16_t hwgrp[1] = {0};
-   struct npa_pool_s pool;
-   uintptr_t iova;
+   uint32_t xae_cnt;
int rc;
 
/* Alloc SSOW LF */
@@ -244,41 +240,17 @@ nix_inl_sso_setup(struct nix_inl_dev *inl_dev)
inl_dev->xae_waes = sso_rsp->xaq_wq_entries;
inl_dev->iue = sso_rsp->in_unit_entries;
 
-   /* Create XAQ pool */
-   xaq_cnt = XAQ_CACHE_CNT;
-   xaq_cnt += inl_dev->iue / inl_dev->xae_waes;
-   plt_sso_dbg("Configuring %d xaq buffers", xaq_cnt);
-
-   inl_dev->xaq_mem = plt_zmalloc(inl_dev->xaq_buf_size * xaq_cnt,
-  inl_dev->xaq_buf_size);
-   if (!inl_dev->xaq_mem) {
-   rc = NIX_ERR_NO_MEM;
-   plt_err("Failed to alloc xaq buf mem");
-   goto free_sso;
-   }
-
-   memset(&pool, 0, sizeof(struct npa_pool_s));
-   pool.nat_align = 1;
-   rc = roc_npa_pool_create(&inl_dev->xaq_aura, inl_dev->xaq_buf_size,
-xaq_cnt, NULL, &pool);
+   xae_cnt = inl_dev->iue;
+   rc = sso_hwgrp_init_xaq_aura(dev, &inl_dev->xaq, xae_cnt,
+inl_dev->xae_waes, inl_dev->xaq_buf_size,
+1);
if (rc) {
-   plt_err("Failed to alloc aura for XAQ, rc=%d", rc);
-   goto free_mem;
-   }
-
-   /* Fill the XAQ buffers */
-   iova = (uint64_t)inl_dev->xaq_mem;
-   for (count = 0; count < xaq_cnt; count++) {
-   roc_npa_aura_op_free(inl_dev->xaq_aura, 0, iova);
-   iova += inl_dev->xaq_buf_size;
+   plt_err("Failed to alloc SSO XAQ aura, rc=%d", rc);
+   goto free_sso;
}
-   roc_npa_aura_op_range_set(inl_dev->xaq_aura, (uint64_t)inl_dev->xaq_mem,
- iova);
-
-   aura = roc_npa_aura_handle_to_aura(inl_dev->xaq_aura);
 
/* Setup xaq for hwgrps */
-   rc = sso_hwgrp_alloc_xaq(dev, aura, 1);
+   rc = sso_hwgrp_alloc_xaq(dev, inl_dev->xaq.aura_handle, 1);
if (rc) {
plt_err("Failed to setup hwgrp xaq aura, rc=%d", rc);
goto destroy_pool;
@@ -302,11 +274,7 @@ nix_inl_sso_setup(struct nix_inl_dev *inl_dev)
 release_xaq:
sso_hwgrp_release_xaq(&inl_dev->dev, 1);
 destroy_pool:
-   roc_npa_pool_destroy(inl_dev->xaq_aura);
-   inl_dev->xaq_aura = 0;
-free_mem:
-   plt_free(inl_dev->xaq_mem);
-   inl_dev->xaq_mem = NULL;
+   sso_hwgrp_free_xaq_aura(dev, &inl_dev->xaq, 0);
 free_sso:
sso_lf_free(dev, SSO_LF_TYPE_HWGRP, 1);
 free_ssow:
@@ -335,6 +303,9 @@ nix_inl_sso_release(struct nix_inl_dev *inl_dev)
sso_lf_free(&inl_dev->dev, SSO_LF_TYPE_HWS, 1);
sso_lf_free(&inl_dev->dev, SSO_LF_TYPE_HWGRP, 1);
 
+   /* Free the XAQ aura */
+   sso_hwgrp_free_xaq_aura(&inl_dev->dev, &inl_dev->xaq, 0);
+
return 0;
 }
 
diff --git a/drivers/common/cnxk/roc_nix_inl_priv.h 
b/drivers/common/cnxk/roc_nix_inl_priv.h
index be53a3fa81..2cdab6dc7a 100644
--- a/drivers/common/cnxk/roc_nix_inl_priv.h
+++ b/drivers/common/cnxk/roc_nix_

[PATCH 1/4] net/cnxk: avoid command copy from Tx queue

[pbhagavatula]

From: Pavan Nikhilesh 

Tx command is prepared based on offloads enabled and stored in
Tx queue structure at tx_queue_setup phase.
In fastpath the command is copied from Tx queue to LMT line for
all the packets.
Since, the command contents are mostly constants we can move the
command preparation to fastpath and avoid accessing Tx queue
memory.

Signed-off-by: Pavan Nikhilesh 
---
 Depends-on: Series-20922

 drivers/common/cnxk/roc_io.h |  33 -
 drivers/common/cnxk/roc_io_generic.h |  15 ++
 drivers/crypto/cnxk/cn9k_cryptodev_ops.c |   2 +-
 drivers/crypto/cnxk/cn9k_ipsec.c |   2 +-
 drivers/event/cnxk/cn10k_eventdev.c  |  26 +++-
 drivers/event/cnxk/cn10k_worker.h|  89 ++--
 drivers/event/cnxk/cn9k_eventdev.c   |  33 +++--
 drivers/event/cnxk/cn9k_worker.h |  64 -
 drivers/event/cnxk/cnxk_eventdev.h   |  13 +-
 drivers/event/cnxk/cnxk_eventdev_adptr.c | 141 ---
 drivers/net/cnxk/cn10k_ethdev.c  |  24 +---
 drivers/net/cnxk/cn10k_ethdev.h  |   3 +-
 drivers/net/cnxk/cn10k_tx.h  | 167 ---
 drivers/net/cnxk/cn9k_ethdev.c   |  36 ++---
 drivers/net/cnxk/cn9k_ethdev.h   |   3 +-
 drivers/net/cnxk/cn9k_tx.h   | 133 +++---
 16 files changed, 478 insertions(+), 306 deletions(-)

diff --git a/drivers/common/cnxk/roc_io.h b/drivers/common/cnxk/roc_io.h
index fe5f7f46d0..ea7fcd4e9a 100644
--- a/drivers/common/cnxk/roc_io.h
+++ b/drivers/common/cnxk/roc_io.h
@@ -152,13 +152,36 @@ roc_lmt_mov(void *out, const void *in, const uint32_t 
lmtext)
dst128[1] = src128[1];
/* lmtext receives following value:
 * 1: NIX_SUBDC_EXT needed i.e. tx vlan case
-* 2: NIX_SUBDC_EXT + NIX_SUBDC_MEM i.e. tstamp case
 */
-   if (lmtext) {
+   if (lmtext)
+   dst128[2] = src128[2];
+}
+
+static __plt_always_inline void
+roc_lmt_mov64(void *out, const void *in)
+{
+   volatile const __uint128_t *src128 = (const __uint128_t *)in;
+   volatile __uint128_t *dst128 = (__uint128_t *)out;
+
+   dst128[0] = src128[0];
+   dst128[1] = src128[1];
+   dst128[2] = src128[2];
+   dst128[3] = src128[3];
+}
+
+static __plt_always_inline void
+roc_lmt_mov_nv(void *out, const void *in, const uint32_t lmtext)
+{
+   const __uint128_t *src128 = (const __uint128_t *)in;
+   __uint128_t *dst128 = (__uint128_t *)out;
+
+   dst128[0] = src128[0];
+   dst128[1] = src128[1];
+   /* lmtext receives following value:
+* 1: NIX_SUBDC_EXT needed i.e. tx vlan case
+*/
+   if (lmtext)
dst128[2] = src128[2];
-   if (lmtext > 1)
-   dst128[3] = src128[3];
-   }
 }

 static __plt_always_inline void
diff --git a/drivers/common/cnxk/roc_io_generic.h 
b/drivers/common/cnxk/roc_io_generic.h
index ceaa3a38d8..af42e66345 100644
--- a/drivers/common/cnxk/roc_io_generic.h
+++ b/drivers/common/cnxk/roc_io_generic.h
@@ -97,6 +97,21 @@ roc_lmt_mov(void *out, const void *in, const uint32_t lmtext)
memset(out, 0, sizeof(__uint128_t) * (lmtext ? lmtext > 1 ? 4 : 3 : 2));
 }

+static __plt_always_inline void
+roc_lmt_mov64(void *out, const void *in)
+{
+   PLT_SET_USED(out);
+   PLT_SET_USED(in);
+}
+
+static __plt_always_inline void
+roc_lmt_mov_nv(void *out, const void *in, const uint32_t lmtext)
+{
+   PLT_SET_USED(in);
+   PLT_SET_USED(lmtext);
+   memset(out, 0, sizeof(__uint128_t) * (lmtext ? lmtext > 1 ? 4 : 3 : 2));
+}
+
 static __plt_always_inline void
 roc_lmt_mov_seg(void *out, const void *in, const uint16_t segdw)
 {
diff --git a/drivers/crypto/cnxk/cn9k_cryptodev_ops.c 
b/drivers/crypto/cnxk/cn9k_cryptodev_ops.c
index 449208da8f..53e427a3c1 100644
--- a/drivers/crypto/cnxk/cn9k_cryptodev_ops.c
+++ b/drivers/crypto/cnxk/cn9k_cryptodev_ops.c
@@ -161,7 +161,7 @@ cn9k_cpt_inst_submit(struct cpt_inst_s *inst, uint64_t 
lmtline,

do {
/* Copy CPT command to LMTLINE */
-   roc_lmt_mov((void *)lmtline, inst, 2);
+   roc_lmt_mov64((void *)lmtline, inst);

/*
 * Make sure compiler does not reorder memcpy and ldeor.
diff --git a/drivers/crypto/cnxk/cn9k_ipsec.c b/drivers/crypto/cnxk/cn9k_ipsec.c
index a81130b244..117e54cae7 100644
--- a/drivers/crypto/cnxk/cn9k_ipsec.c
+++ b/drivers/crypto/cnxk/cn9k_ipsec.c
@@ -53,7 +53,7 @@ cn9k_cpt_enq_sa_write(struct cn9k_ipsec_sa *sa, struct 
cnxk_cpt_qp *qp,

do {
/* Copy CPT command to LMTLINE */
-   roc_lmt_mov((void *)lmtline, &inst, 2);
+   roc_lmt_mov64((void *)lmtline, &inst);
lmt_status = roc_lmt_submit_ldeor(io_addr);
} while (lmt_status == 0);

diff --git a/drivers/event/cnxk/cn10k_eventdev.c 
b/drivers/event/cnxk/cn10k_eventdev.c
index 70e2aa..c57e45a118 100644
--- a/drivers/event/cnxk/cn10k_eventdev.c
+++ b/drive

[PATCH 2/4] event/cnxk: store and reuse workslot status

[pbhagavatula]

From: Pavan Nikhilesh 

Store and reuse workslot status for TT, GRP and HEAD status
instead of reading from GWC as reading from GWC imposes
additional latency.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/common/cnxk/roc_sso.h  | 11 ++-
 drivers/event/cnxk/cn10k_worker.h  | 17 ++---
 drivers/event/cnxk/cnxk_eventdev.h |  2 ++
 drivers/event/cnxk/cnxk_worker.h   | 11 +++
 drivers/net/cnxk/cn10k_tx.h| 12 ++--
 5 files changed, 31 insertions(+), 22 deletions(-)

diff --git a/drivers/common/cnxk/roc_sso.h b/drivers/common/cnxk/roc_sso.h
index 27d49c6c68..9c594f5c1c 100644
--- a/drivers/common/cnxk/roc_sso.h
+++ b/drivers/common/cnxk/roc_sso.h
@@ -54,12 +54,12 @@ struct roc_sso {
uint8_t reserved[ROC_SSO_MEM_SZ] __plt_cache_aligned;
 } __plt_cache_aligned;

-static __plt_always_inline void
+static __plt_always_inline uint64_t
 roc_sso_hws_head_wait(uintptr_t tag_op)
 {
-#ifdef RTE_ARCH_ARM64
uint64_t tag;

+#ifdef RTE_ARCH_ARM64
asm volatile(PLT_CPU_FEATURE_PREAMBLE
 "  ldr %[tag], [%[tag_op]] \n"
 "  tbnz %[tag], 35, done%= \n"
@@ -71,10 +71,11 @@ roc_sso_hws_head_wait(uintptr_t tag_op)
 : [tag] "=&r"(tag)
 : [tag_op] "r"(tag_op));
 #else
-   /* Wait for the SWTAG/SWTAG_FULL operation */
-   while (!(plt_read64(tag_op) & BIT_ULL(35)))
-   ;
+   do {
+   tag = plt_read64(tag_op);
+   } while (!(tag & BIT_ULL(35)));
 #endif
+   return tag;
 }

 /* SSO device initialization */
diff --git a/drivers/event/cnxk/cn10k_worker.h 
b/drivers/event/cnxk/cn10k_worker.h
index e80e4fb895..65602a632e 100644
--- a/drivers/event/cnxk/cn10k_worker.h
+++ b/drivers/event/cnxk/cn10k_worker.h
@@ -40,8 +40,7 @@ cn10k_sso_hws_fwd_swtag(struct cn10k_sso_hws *ws, const 
struct rte_event *ev)
 {
const uint32_t tag = (uint32_t)ev->event;
const uint8_t new_tt = ev->sched_type;
-   const uint8_t cur_tt =
-   CNXK_TT_FROM_TAG(plt_read64(ws->base + SSOW_LF_GWS_WQE0));
+   const uint8_t cur_tt = CNXK_TT_FROM_TAG(ws->gw_rdata);

/* CNXK model
 * cur_tt/new_tt SSO_TT_ORDERED SSO_TT_ATOMIC SSO_TT_UNTAGGED
@@ -81,7 +80,7 @@ cn10k_sso_hws_forward_event(struct cn10k_sso_hws *ws,
const uint8_t grp = ev->queue_id;

/* Group hasn't changed, Use SWTAG to forward the event */
-   if (CNXK_GRP_FROM_TAG(plt_read64(ws->base + SSOW_LF_GWS_WQE0)) == grp)
+   if (CNXK_GRP_FROM_TAG(ws->gw_rdata) == grp)
cn10k_sso_hws_fwd_swtag(ws, ev);
else
/*
@@ -211,6 +210,7 @@ cn10k_sso_hws_get_work(struct cn10k_sso_hws *ws, struct 
rte_event *ev,
} while (gw.u64[0] & BIT_ULL(63));
mbuf = (uint64_t)((char *)gw.u64[1] - sizeof(struct rte_mbuf));
 #endif
+   ws->gw_rdata = gw.u64[0];
gw.u64[0] = (gw.u64[0] & (0x3ull << 32)) << 6 |
(gw.u64[0] & (0x3FFull << 36)) << 4 |
(gw.u64[0] & 0x);
@@ -406,7 +406,8 @@ NIX_RX_FASTPATH_MODES
RTE_SET_USED(timeout_ticks);   \
if (ws->swtag_req) {   \
ws->swtag_req = 0; \
-   cnxk_sso_hws_swtag_wait(ws->base + SSOW_LF_GWS_WQE0);  \
+   ws->gw_rdata = cnxk_sso_hws_swtag_wait(\
+   ws->base + SSOW_LF_GWS_WQE0);  \
return 1;  \
}  \
return cn10k_sso_hws_get_work(ws, ev, flags, ws->lookup_mem);  \
@@ -426,7 +427,8 @@ NIX_RX_FASTPATH_MODES

\
if (ws->swtag_req) {   \
ws->swtag_req = 0; \
-   cnxk_sso_hws_swtag_wait(ws->base + SSOW_LF_GWS_WQE0);  \
+   ws->gw_rdata = cnxk_sso_hws_swtag_wait(\
+   ws->base + SSOW_LF_GWS_WQE0);  \
return ret;\
}  \
ret = cn10k_sso_hws_get_work(ws, ev, flags, ws->lookup_mem);   \
@@ -509,8 +511,9 @@ cn10k_sso_tx_one(struct cn10k_sso_hws *ws, struct rte_mbuf 
*m, uint64_t *cmd,
else
pa = txq->io_addr | ((segdw - 1) << 4);

-   if (!sched_type)
-   roc_sso_hws_head_wait(ws->base + SSOW_LF_GWS_TAG);
+   if (!CNXK_TAG_IS_HEAD(ws->gw_rdata) && !sched_type)
+   ws->gw_rdata =
+  

[PATCH 3/4] event/cnxk: disable default wait time for dequeue

[pbhagavatula]

From: Pavan Nikhilesh 

Setting WAITW bit enables default min dequeue timeout of 1us.
Avoid the min dequeue timeout by setting WAITW only when dequeue_timeout
is configured.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/event/cnxk/cn10k_eventdev.c |  8 +--
 drivers/event/cnxk/cn9k_eventdev.c  |  9 ++-
 drivers/event/cnxk/cn9k_worker.h| 37 +
 drivers/event/cnxk/cnxk_eventdev.c  |  2 +-
 drivers/event/cnxk/cnxk_eventdev.h  |  2 ++
 5 files changed, 34 insertions(+), 24 deletions(-)

diff --git a/drivers/event/cnxk/cn10k_eventdev.c 
b/drivers/event/cnxk/cn10k_eventdev.c
index c57e45a118..380d1ede69 100644
--- a/drivers/event/cnxk/cn10k_eventdev.c
+++ b/drivers/event/cnxk/cn10k_eventdev.c
@@ -15,7 +15,10 @@
 static uint32_t
 cn10k_sso_gw_mode_wdata(struct cnxk_sso_evdev *dev)
 {
-   uint32_t wdata = BIT(16) | 1;
+   uint32_t wdata = 1;
+
+   if (dev->deq_tmo_ns)
+   wdata |= BIT(16);

switch (dev->gw_mode) {
case CN10K_GW_MODE_NONE:
@@ -88,7 +91,8 @@ cn10k_sso_hws_setup(void *arg, void *hws, uintptr_t grp_base)
ws->xaq_lmt = dev->xaq_lmt;

/* Set get_work timeout for HWS */
-   val = NSEC2USEC(dev->deq_tmo_ns) - 1;
+   val = NSEC2USEC(dev->deq_tmo_ns);
+   val = val ? val - 1 : 0;
plt_write64(val, ws->base + SSOW_LF_GWS_NW_TIM);
 }

diff --git a/drivers/event/cnxk/cn9k_eventdev.c 
b/drivers/event/cnxk/cn9k_eventdev.c
index 98294be11f..eeacdf9439 100644
--- a/drivers/event/cnxk/cn9k_eventdev.c
+++ b/drivers/event/cnxk/cn9k_eventdev.c
@@ -72,7 +72,8 @@ cn9k_sso_hws_setup(void *arg, void *hws, uintptr_t grp_base)
uint64_t val;

/* Set get_work tmo for HWS */
-   val = dev->deq_tmo_ns ? NSEC2USEC(dev->deq_tmo_ns) - 1 : 0;
+   val = NSEC2USEC(dev->deq_tmo_ns);
+   val = val ? val - 1 : 0;
if (dev->dual_ws) {
dws = hws;
dws->grp_base = grp_base;
@@ -696,6 +697,9 @@ cn9k_sso_init_hws_mem(void *arg, uint8_t port_id)
dws->hws_id = port_id;
dws->swtag_req = 0;
dws->vws = 0;
+   if (dev->deq_tmo_ns)
+   dws->gw_wdata = BIT_ULL(16);
+   dws->gw_wdata |= 1;

data = dws;
} else {
@@ -714,6 +718,9 @@ cn9k_sso_init_hws_mem(void *arg, uint8_t port_id)
ws->base = roc_sso_hws_base_get(&dev->sso, port_id);
ws->hws_id = port_id;
ws->swtag_req = 0;
+   if (dev->deq_tmo_ns)
+   ws->gw_wdata = BIT_ULL(16);
+   ws->gw_wdata |= 1;

data = ws;
}
diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h
index 0f58e00e7f..32bf2345e7 100644
--- a/drivers/event/cnxk/cn9k_worker.h
+++ b/drivers/event/cnxk/cn9k_worker.h
@@ -149,10 +149,8 @@ cn9k_wqe_to_mbuf(uint64_t wqe, const uint64_t mbuf, 
uint8_t port_id,
 static __rte_always_inline uint16_t
 cn9k_sso_hws_dual_get_work(uint64_t base, uint64_t pair_base,
   struct rte_event *ev, const uint32_t flags,
-  const void *const lookup_mem,
-  struct cnxk_timesync_info *const tstamp)
+  struct cn9k_sso_hws_dual *dws)
 {
-   const uint64_t set_gw = BIT_ULL(16) | 1;
union {
__uint128_t get_work;
uint64_t u64[2];
@@ -161,7 +159,7 @@ cn9k_sso_hws_dual_get_work(uint64_t base, uint64_t 
pair_base,
uint64_t mbuf;

if (flags & NIX_RX_OFFLOAD_PTYPE_F)
-   rte_prefetch_non_temporal(lookup_mem);
+   rte_prefetch_non_temporal(dws->lookup_mem);
 #ifdef RTE_ARCH_ARM64
asm volatile(PLT_CPU_FEATURE_PREAMBLE
 "rty%=:\n"
@@ -175,14 +173,14 @@ cn9k_sso_hws_dual_get_work(uint64_t base, uint64_t 
pair_base,
 : [tag] "=&r"(gw.u64[0]), [wqp] "=&r"(gw.u64[1]),
   [mbuf] "=&r"(mbuf)
 : [tag_loc] "r"(base + SSOW_LF_GWS_TAG),
-  [wqp_loc] "r"(base + SSOW_LF_GWS_WQP), [gw] "r"(set_gw),
+  [wqp_loc] "r"(base + SSOW_LF_GWS_WQP), [gw] 
"r"(dws->gw_wdata),
   [pong] "r"(pair_base + SSOW_LF_GWS_OP_GET_WORK0));
 #else
gw.u64[0] = plt_read64(base + SSOW_LF_GWS_TAG);
while ((BIT_ULL(63)) & gw.u64[0])
gw.u64[0] = plt_read64(base + SSOW_LF_GWS_TAG);
gw.u64[1] = plt_read64(base + SSOW_LF_GWS_WQP);
-   plt_write64(set_gw, pair_base + SSOW_LF_GWS_OP_GET_WORK0);
+   plt_write64(dws->gw_wdata, pair_base + SSOW_LF_GWS_OP_GET_WORK0);
mbuf = (uint64_t)((char *)gw.u64[1] - sizeof(struct rte_mbuf));
 #endif

@@ -202,12 +200,13 @@ cn9k_sso_hws_dual_get_work(uint64_t base, uint64_t 
pair_base,
gw.u64[0] = CNXK_CLR_SUB_EVENT(gw.u64[0]);
cn9k_wqe_to_mbuf(gw.u

[PATCH 4/4] net/cnxk: improve Rx performance

[pbhagavatula]

From: Pavan Nikhilesh 

Improve vWQE and CQ Rx performance by tuning perfetches to 64B
cacheline size.
Also, prefetch the vWQE array offsets at cacheline boundaries.

Signed-off-by: Pavan Nikhilesh 
---
 drivers/event/cnxk/cn10k_worker.h | 25 +++--
 drivers/net/cnxk/cn10k_rx.h   |  8 
 drivers/net/cnxk/cn9k_rx.h| 20 ++--
 3 files changed, 29 insertions(+), 24 deletions(-)

diff --git a/drivers/event/cnxk/cn10k_worker.h 
b/drivers/event/cnxk/cn10k_worker.h
index 65602a632e..6e77d32827 100644
--- a/drivers/event/cnxk/cn10k_worker.h
+++ b/drivers/event/cnxk/cn10k_worker.h
@@ -118,11 +118,17 @@ cn10k_process_vwqe(uintptr_t vwqe, uint16_t port_id, 
const uint32_t flags,
uint8_t loff = 0;
uint64_t sa_base;
uint64_t **wqe;
+   int i;

mbuf_init |= ((uint64_t)port_id) << 48;
vec = (struct rte_event_vector *)vwqe;
wqe = vec->u64s;

+   rte_prefetch_non_temporal(&vec->ptrs[0]);
+#define OBJS_PER_CLINE (RTE_CACHE_LINE_SIZE / sizeof(void *))
+   for (i = OBJS_PER_CLINE; i < vec->nb_elem; i += OBJS_PER_CLINE)
+   rte_prefetch_non_temporal(&vec->ptrs[i]);
+
nb_mbufs = RTE_ALIGN_FLOOR(vec->nb_elem, NIX_DESCS_PER_LOOP);
nb_mbufs = cn10k_nix_recv_pkts_vector(&mbuf_init, vec->mbufs, nb_mbufs,
  flags | NIX_RX_VWQE_F, lookup_mem,
@@ -191,15 +197,13 @@ cn10k_sso_hws_get_work(struct cn10k_sso_hws *ws, struct 
rte_event *ev,
uint64_t u64[2];
} gw;
uint64_t tstamp_ptr;
-   uint64_t mbuf;

gw.get_work = ws->gw_wdata;
 #if defined(RTE_ARCH_ARM64) && !defined(__clang__)
asm volatile(
PLT_CPU_FEATURE_PREAMBLE
-   "caspl %[wdata], %H[wdata], %[wdata], %H[wdata], [%[gw_loc]]\n"
-   "sub %[mbuf], %H[wdata], #0x80  \n"
-   : [wdata] "+r"(gw.get_work), [mbuf] "=&r"(mbuf)
+   "caspal %[wdata], %H[wdata], %[wdata], %H[wdata], [%[gw_loc]]\n"
+   : [wdata] "+r"(gw.get_work)
: [gw_loc] "r"(ws->base + SSOW_LF_GWS_OP_GET_WORK0)
: "memory");
 #else
@@ -208,14 +212,12 @@ cn10k_sso_hws_get_work(struct cn10k_sso_hws *ws, struct 
rte_event *ev,
roc_load_pair(gw.u64[0], gw.u64[1],
  ws->base + SSOW_LF_GWS_WQE0);
} while (gw.u64[0] & BIT_ULL(63));
-   mbuf = (uint64_t)((char *)gw.u64[1] - sizeof(struct rte_mbuf));
 #endif
ws->gw_rdata = gw.u64[0];
-   gw.u64[0] = (gw.u64[0] & (0x3ull << 32)) << 6 |
-   (gw.u64[0] & (0x3FFull << 36)) << 4 |
-   (gw.u64[0] & 0x);
-
-   if (CNXK_TT_FROM_EVENT(gw.u64[0]) != SSO_TT_EMPTY) {
+   if (gw.u64[1]) {
+   gw.u64[0] = (gw.u64[0] & (0x3ull << 32)) << 6 |
+   (gw.u64[0] & (0x3FFull << 36)) << 4 |
+   (gw.u64[0] & 0x);
if ((flags & CPT_RX_WQE_F) &&
(CNXK_EVENT_TYPE_FROM_TAG(gw.u64[0]) ==
 RTE_EVENT_TYPE_CRYPTODEV)) {
@@ -223,7 +225,10 @@ cn10k_sso_hws_get_work(struct cn10k_sso_hws *ws, struct 
rte_event *ev,
} else if (CNXK_EVENT_TYPE_FROM_TAG(gw.u64[0]) ==
   RTE_EVENT_TYPE_ETHDEV) {
uint8_t port = CNXK_SUB_EVENT_FROM_TAG(gw.u64[0]);
+   uint64_t mbuf;

+   mbuf = gw.u64[1] - sizeof(struct rte_mbuf);
+   rte_prefetch0((void *)mbuf);
if (flags & NIX_RX_OFFLOAD_SECURITY_F) {
struct rte_mbuf *m;
uintptr_t sa_base;
diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h
index a2442d3726..9694a3080f 100644
--- a/drivers/net/cnxk/cn10k_rx.h
+++ b/drivers/net/cnxk/cn10k_rx.h
@@ -610,10 +610,10 @@ cn10k_nix_recv_pkts_vector(void *args, struct rte_mbuf 
**mbufs, uint16_t pkts,
}

/* Prefetch N desc ahead */
-   rte_prefetch_non_temporal(CQE_PTR_OFF(cq0, 8, 0, flags));
-   rte_prefetch_non_temporal(CQE_PTR_OFF(cq0, 9, 0, flags));
-   rte_prefetch_non_temporal(CQE_PTR_OFF(cq0, 10, 0, flags));
-   rte_prefetch_non_temporal(CQE_PTR_OFF(cq0, 11, 0, flags));
+   rte_prefetch_non_temporal(CQE_PTR_OFF(cq0, 4, 64, flags));
+   rte_prefetch_non_temporal(CQE_PTR_OFF(cq0, 5, 64, flags));
+   rte_prefetch_non_temporal(CQE_PTR_OFF(cq0, 6, 64, flags));
+   rte_prefetch_non_temporal(CQE_PTR_OFF(cq0, 7, 64, flags));

/* Get NIX_RX_SG_S for size and buffer pointer */
cq0_w8 = vld1q_u64(CQE_PTR_OFF(cq0, 0, 64, flags));
diff --git a/drivers/net/cnxk/cn9k_rx.h b/drivers/net/cnxk/cn9k_rx.h
index b038b1a6ef..fa4efbf80a 100644
--- a/drivers/net/cnxk/cn9k_rx.h
+++ b/dri

Re: [PATCH] build/eal: add OS defines for C conditional checks

[Dmitry Kozlyuk]

2021-12-10 14:53 (UTC+), Bruce Richardson:
[...]

Acked-by: Dmitry Kozlyuk 
with one typo below and some considerations for the future in the bottom.

> +Defines to Avoid Conditional Compilation
> +
> +
> +In many cases in DPDK, one wants to optionally compile code based on the 
> target platform,
> +or runtime environment.

"Compile" -> "run", that's the point to use conditionals instead of macros.

> +While this can be done using the conditional compilation directives,
> +e.g. ``#ifdef RTE_EXEC_ENV_LINUX``, present in DPDK for many releases,
> +this can also be done in many cases using regular ``if`` statements and the 
> following defines:

> +
> +* ``RTE_ENV_FREEBSD``, ``RTE_ENV_LINUX``, ``RTE_ENV_WINDOWS`` - these define 
> ids for each operating system environment.
> +* ``RTE_EXEC_ENV`` - this defines the id of the current environment, i.e. 
> one of the items in list above.
> +* ``RTE_EXEC_ENV_IS_FREEBSD``, ``RTE_EXEC_ENV_IS_LINUX``, 
> ``RTE_EXEC_ENV_IS_WINDOWS`` - 0/1 values indicating if the current 
> environment is that specified,
> +  shortcuts for checking e.g. ``RTE_EXEC_ENV == RTE_ENV_WINDOWS``
[...]

I wonder whether #if RTE_EXEC_ENV_IS_xxx
should be preferred over #ifdef RTE_EXEC_ENV_xxx,
so that all checks use the same symbol
(and then remove old macros one day).

Since C conditionals are preferred over #ifdef,
I suggest to give pointers when to use one or another mechanism:

If a code fragment can compile on all platforms,
but cannot run on some due to lack of support,
branch on constants.

If a code fragment cannot compile on all platforms
(e.g. use of OS-specific headers or macros),
but constitutes only a small fraction of the file,
use conditional compilation.

If a group of functions implement an interface
in an OS- or platform-specific way,
create a file for each of the supported environments
and plug an appropriate file from ``meson.build``.

[PATCH] ring: fix overflow in memory size calcuation

[Zhihong Wang]

Parameters count and esize are both unsigned int, and their product can
legally exceed unsigned int and lead to runtime access violation.

Fixes: cc4b218790f6 ("ring: support configurable element size")
Cc: sta...@dpdk.org

Signed-off-by: Zhihong Wang 
---
 lib/ring/rte_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c
index f17bd966be..d1b80597af 100644
--- a/lib/ring/rte_ring.c
+++ b/lib/ring/rte_ring.c
@@ -75,7 +75,7 @@ rte_ring_get_memsize_elem(unsigned int esize, unsigned int 
count)
return -EINVAL;
}
 
-   sz = sizeof(struct rte_ring) + count * esize;
+   sz = sizeof(struct rte_ring) + (ssize_t)count * esize;
sz = RTE_ALIGN(sz, RTE_CACHE_LINE_SIZE);
return sz;
 }
-- 
2.11.0

[PATCH 1/1] net/tap: add a check that Rx/Tx have the same num of queues

[Nobuhiro MIKI]

Users can create the desired number of RxQ and TxQ in DPDK. For
example, if the number of RxQ = 2 and the number of TxQ = 5,
a total of 8 file descriptors will be created for a tap device,
including RxQ, TxQ, and one for keepalive [1]. The RxQ and TxQ
with the same ID are paired by dup(2) [2].

In this scenario, Kernel will have 3 RxQ where packets are
incoming but not read. The reason for this is that there are only
2 RxQ that are polled by DPDK, while there are 5 queues in the
kernel. This patch add a checking if DPDK has appropriate numbers
of queues to avoid unexpected packet drop.

I had first discussed this issue in OVS [3], but changed my mind
that a fix in DPDK would be more appropriate.

[1]: 
https://github.com/DPDK/dpdk/blob/0c6e27549c/drivers/net/tap/rte_eth_tap.c#L1967-L1973
[2]: 
https://github.com/DPDK/dpdk/blob/0c6e27549c/drivers/net/tap/rte_eth_tap.c#L1465-L1466
[3]: https://mail.openvswitch.org/pipermail/ovs-dev/2021-November/389690.html

Signed-off-by: Nobuhiro MIKI 
---
 drivers/net/tap/rte_eth_tap.c | 8 
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index f1b48cae82..f0090a604d 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -940,6 +940,14 @@ tap_dev_configure(struct rte_eth_dev *dev)
RTE_PMD_TAP_MAX_QUEUES);
return -1;
}
+   if (dev->data->nb_rx_queues != dev->data->nb_tx_queues) {
+   TAP_LOG(ERR,
+   "%s: number of rx queues %d must be equal to number of 
tx queues %d",
+   dev->device->name,
+   dev->data->nb_rx_queues,
+   dev->data->nb_tx_queues);
+   return -1;
+   }
 
TAP_LOG(INFO, "%s: %s: TX configured queues number: %u",
dev->device->name, pmd->name, dev->data->nb_tx_queues);
-- 
2.24.4

Re: 19.11.11 patches review and test

[Kalesh Anakkur Purayil]

On Mon, Dec 13, 2021 at 7:42 PM Ferruh Yigit  wrote:

> On 12/13/2021 1:49 PM, Kalesh Anakkur Purayil wrote:
> > Hi Christian/Ferruh,
> >
> > On Mon, 13 Dec 2021 at 7:03 PM, Christian Ehrhardt <
> christian.ehrha...@canonical.com >
> wrote:
> >
> > On Mon, Dec 13, 2021 at 1:59 PM Ferruh Yigit  > wrote:
> >  >
> >  > On 12/13/2021 12:39 PM, Christian Ehrhardt wrote:
> >  > > On Mon, Dec 13, 2021 at 12:06 PM Ferruh Yigit <
> ferruh.yi...@intel.com > wrote:
> >  > >>
> >  > >> On 12/13/2021 4:14 AM, Kalesh Anakkur Purayil wrote:
> >  > >>> Hi Christian,
> >  > >>>
> >  > >>> We still see KNI build failure on SLES15 SP3 with
> dpdk-stable-19.11.11-rc1. Is there a plan to address that on 19.11.11 LTS?
> >  > >>>
> >  > >>
> >  > >> Hi Kalesh,
> >  > >>
> >  > >> I have sent a backport patch for 20.11, can you please check
> if it fixes
> >  > >> the build for the v19.11 too?
> >  > >>
> >  > >>
> http://inbox.dpdk.org/stable/byapr11mb27110b5509d1c5b999bb3aa1fe...@byapr11mb2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
> <
> http://inbox.dpdk.org/stable/byapr11mb27110b5509d1c5b999bb3aa1fe...@byapr11mb2711.namprd11.prod.outlook.com/T/#m3a451169c23b73d9f421fa0d7cf8da8c9f9e496f
> >
> >  > >
> >  > > This patch is already applied in 19.11.11 as [1], thereby at
> least
> >  > > without backport adaptations it surely does not fix the problem.
> >  > >
> >  >
> >  > It is indeed.
> >  >
> >  > @Kalesh, can you please share more details related to the build
> error?
> >  >
> >  >
> >  > > Comparing the upstream, the 20.11 backport and the 19.11
> kernel_dir
> >  > > the difference is that 19.11 currently has it inside the check
> for
> >  > > kernel_dir.
> >  > > But both get initialized from ` get_option('kernel_dir')` so
> either
> >  > > both or none would trigger and therefore it should be ok as-is.
> >  > >
> >  > > I'm happy to consider a fix if someone looks deeper into it and
> let me
> >  > > know what adaptations to try.
> >  > > I can also test build SLES15SP3 (before this discussion I knew
> it was
> >  > > "still broken").
> >  > >
> >  >
> >  > The above fix should fix the build for SLES15SP3, are you aware
> of any
> >  > build error after that patch?
> >
> > As I said my SLES15SP3 test build kept failing [1] and it looked like
> > the very same issue as before.
> >
> > [  351s]   CC
> >
>  
> /home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/igb_uio/igb_uio.mod.o
> > [  351s]
> /home/abuild/rpmbuild/BUILD/dpdk-1638972763.ee4ce5a57/x86_64-default-linux-gcc/build/kernel/linux/kni/kni_net.c:791:20:
> > error: initialization from incompatible pointer type
> > [-Werror=incompatible-pointer-types]
> > [  351s]   .ndo_tx_timeout = kni_net_tx_timeout,
> > [  351s] ^~
> >
> > [1]:
> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64
> <
> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64
> >
> >
> > [Kalesh] Yes, i am seeing the same error. I used make command to build
> dpdk, not meson.
> > The back ported commit you mentioned takes care of meson build only I
> think.
> >
>
> I see, make build is failing, and yes the fix is only for the meson.
> I will check the make build and will send a fix for it.
>
[Kalesh]: looks like the below changes fixes the issue. I tried only on
SLES15 SP3 and not on other SLES flavors.

diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
index 595bac2..bf0efab 100644
--- a/kernel/linux/kni/Makefile
+++ b/kernel/linux/kni/Makefile
@@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
 MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
 MODULE_CFLAGS += -Wall -Werror

+#
+# Use explicit 'source' folder for header path. In SUSE 'source' is not
linked to 'build' folder.
+#
+ifdef CONFIG_SUSE_KERNEL
+   KSRC = /lib/modules/$(shell uname -r)/source
+   ifneq ($(shell grep -A 1 "ndo_tx_timeout"
$(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
+  MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
+   endif
+endif
+
 -include /etc/lsb-release

 ifeq ($(DISTRIB_ID),Ubuntu)

Regards,
Kalesh

>
> > Regards,
> > Kalesh
> >
> > <
> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/SLE_15/x86_64
> >
> >
> >  > > [1]:
> https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366
> <
> https://github.com/cpaelzer/dpdk-stable-queue/commit/6c8f6b72f28c713a7017d0db9ce95b2377ce4366
> >
> >  > >
> >  > >>> Regards,
> >  > >>> Kalesh
> >  

RE: [PATCH] eventdev: fix missing internal port checks

[Jayatheerthan, Jay]

@Harish, could you take a look at this please ?

-Jay


> -Original Message-
> From: pbhagavat...@marvell.com 
> Sent: Monday, December 13, 2021 2:02 PM
> To: jer...@marvell.com; Jayatheerthan, Jay 
> Cc: dev@dpdk.org; Pavan Nikhilesh 
> Subject: [PATCH] eventdev: fix missing internal port checks
> 
> From: Pavan Nikhilesh 
> 
> When event delivery is through internal port, stats are mainitained
> by HW and we should avoid reading SW data structures for stats.
> Fix missing internal port checks.
> 
> Fixes: 995b150c1ae1 ("eventdev/eth_rx: add queue stats API")
> 
> Signed-off-by: Pavan Nikhilesh 
> ---
>  lib/eventdev/rte_event_eth_rx_adapter.c | 24 ++--
>  1 file changed, 14 insertions(+), 10 deletions(-)
> 
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c 
> b/lib/eventdev/rte_event_eth_rx_adapter.c
> index 809416d9b7..da223aacac 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -2984,15 +2984,17 @@ rte_event_eth_rx_adapter_queue_stats_get(uint8_t id,
>   return -EINVAL;
>   }
> 
> - queue_info = &dev_info->rx_queue[rx_queue_id];
> - event_buf = queue_info->event_buf;
> - q_stats = queue_info->stats;
> + if (dev_info->internal_event_port == 0) {
> + queue_info = &dev_info->rx_queue[rx_queue_id];
> + event_buf = queue_info->event_buf;
> + q_stats = queue_info->stats;
> 
> - stats->rx_event_buf_count = event_buf->count;
> - stats->rx_event_buf_size = event_buf->events_size;
> - stats->rx_packets = q_stats->rx_packets;
> - stats->rx_poll_count = q_stats->rx_poll_count;
> - stats->rx_dropped = q_stats->rx_dropped;
> + stats->rx_event_buf_count = event_buf->count;
> + stats->rx_event_buf_size = event_buf->events_size;
> + stats->rx_packets = q_stats->rx_packets;
> + stats->rx_poll_count = q_stats->rx_poll_count;
> + stats->rx_dropped = q_stats->rx_dropped;
> + }
> 
>   dev = &rte_eventdevs[rx_adapter->eventdev_id];
>   if (dev->dev_ops->eth_rx_adapter_queue_stats_get != NULL) {
> @@ -3086,8 +3088,10 @@ rte_event_eth_rx_adapter_queue_stats_reset(uint8_t id,
>   return -EINVAL;
>   }
> 
> - queue_info = &dev_info->rx_queue[rx_queue_id];
> - rxa_queue_stats_reset(queue_info);
> + if (dev_info->internal_event_port == 0) {
> + queue_info = &dev_info->rx_queue[rx_queue_id];
> + rxa_queue_stats_reset(queue_info);
> + }
> 
>   dev = &rte_eventdevs[rx_adapter->eventdev_id];
>   if (dev->dev_ops->eth_rx_adapter_queue_stats_reset != NULL) {
> --
> 2.34.0

RE: 19.11.11 patches review and test

[Jiang, YuX]

> -Original Message-
> From: christian.ehrha...@canonical.com 
> Sent: Thursday, December 9, 2021 10:43 PM
> To: sta...@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe ;
> Akhil Goyal ; Ali Alnubani ;
> Walker, Benjamin ; David Christensen
> ; Govindharajan, Hariprasad
> ; Hemant Agrawal
> ; Stokes, Ian ; Jerin
> Jacob ; Mcnamara, John ;
> Ju-Hyoung Lee ; Kevin Traynor
> ; Luca Boccassi ; Pei Zhang
> ; pingx...@intel.com; Xu, Qian Q
> ; Raslan Darawsheh ; Thomas
> Monjalon ; Peng, Yuan ;
> Chen, Zhaoyan 
> Subject: 19.11.11 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 19.11.11.
> 
> The planned date for the final release is 7th January 2021.
> 
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes 
> and
> reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
> https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
> 
> These patches are located at branch 19.11 of dpdk-stable repo:
> https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Christian Ehrhardt 
> 
> ---
Hi Christian,

We find many build issues on LTS19.11. But all of them have no fix yet. 
https://bugs.dpdk.org/show_bug.cgi?id=744   DPDKcoredev UNCO
--- [dpdk-19.11.9-rc3] make build failed on Fedora34 with GCC11 and build 
failed on Fedora35 with gcc11.2.1&clang13.0.0
https://bugs.dpdk.org/show_bug.cgi?id=747   DPDKcoredev UNCO
--- [dpdk-19.11.9-rc3] Meson build failed with ICC-19.1.1
https://bugs.dpdk.org/show_bug.cgi?id=900   DPDKethdev  dev UNCO
--- [19.11.11-rc1] net/nfp build failure with clang 13
https://bugs.dpdk.org/show_bug.cgi?id=901   DPDKethdev  dev UNCO
--- [19.11.11-rc1] net/i40e build failure with make and clang 13
https://bugs.dpdk.org/show_bug.cgi?id=902   DPDKethdev  dev UNCO
--- [19.11.11-rc1] net/ice build failure with make and clang 13
https://bugs.dpdk.org/show_bug.cgi?id=903   DPDKethdev  dev UNCO
--- [19.11.11-rc1] net/ixgbe build failure with make and clang 13
https://bugs.dpdk.org/show_bug.cgi?id=904   DPDKmeson   dev UNCO
--- [dpdk-19.11.11] Meson build has some failures on Fedora35 with clang 
13.0.0
https://bugs.dpdk.org/show_bug.cgi?id=905   DPDKmeson   dev UNCO
--- [dpdk-19.11.11-rc1]Meson&Makefile build failed on Freebsd13 with 
gcc10.3.0&clang11.0.1

RE: [PATCH v3] net/ixgbe: add vector Rx parameter check

[Wang, Haiyue]

> -Original Message-
> From: Rong, Leyi 
> Sent: Monday, December 13, 2021 11:03
> To: Bin Zheng ; dev@dpdk.org
> Cc: Wang, Haiyue ; lian...@liangbit.com; 
> sta...@dpdk.org; jia@intel.com
> Subject: RE: [PATCH v3] net/ixgbe: add vector Rx parameter check
> 
> 
> > -Original Message-
> > From: Bin Zheng 
> > Sent: Friday, December 10, 2021 4:22 PM
> > To: dev@dpdk.org
> > Cc: Wang, Haiyue ; lian...@liangbit.com;
> > sta...@dpdk.org; Rong, Leyi ; Bin Zheng
> > ; jia@intel.com
> > Subject: [PATCH v3] net/ixgbe: add vector Rx parameter check
> >
> > Under the circumstance that `rx_tail` wrap back to zero and the advance 
> > speed
> > of `rx_tail` is greater than `rxrearm_start`, `rx_tail` will catch up with
> > `rxrearm_start` and surpass it.
> > This may cause some mbufs be reused by application.
> >
> > So we need to make some restrictions to ensure that  `rx_tail` will not 
> > exceed
> > `rxrearm_start`.
> >
> > e.g.
> >
> > RDH: 972 RDT: 991 rxrearm_nb: 991 rxrearm_start: 992 rx_tail: 959
> > RDH: 1004 RDT: 1023 rxrearm_nb: 991 rxrearm_start: 0 rx_tail: 991
> > RDH: 12 RDT: 31 rxrearm_nb: 991 rxrearm_start: 32 rx_tail: 1023
> > RDH: 31 RDT: 63 rxrearm_nb: 960 rxrearm_start: 64 rx_tail: 0
> > RDH: 95 RDT: 95 rxrearm_nb: 1016 rxrearm_start: 96 rx_tail: 88
> > RDH: 95 RDT: 127 rxrearm_nb: 991 rxrearm_start: 128 rx_tail: 95 ...
> > RDH: 908 RDT: 927 rxrearm_nb: 991 rxrearm_start: 928 rx_tail: 895
> > RDH: 940 RDT: 959 rxrearm_nb: 991 rxrearm_start: 960 rx_tail: 927
> > RDH: 980 RDT: 991 rxrearm_nb: 991 rxrearm_start: 992 rx_tail: 959
> > RDH: 991 RDT: 991 rxrearm_nb: 1026 rxrearm_start: 992 rx_tail: 994
> >
> > when `rx_tail` catches up with `rxrearm_start`,
> > 2(994 - 992) mbufs be reused by application !
> >
> > Bugzilla ID: 882
> > Fixes: 5a3cca342417 ("net/ixgbe: fix vector Rx")
> > Cc: jia@intel.com
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Bin Zheng 
> > ---
> >  drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 11 +++
> >  1 file changed, 11 insertions(+)
> >


> 
> Acked-by: Leyi Rong 

Reviewed-by: Haiyue Wang 

Re: 19.11.11 patches review and test

[Christian Ehrhardt]

On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil
 wrote:

[snip]

>> > [Kalesh] Yes, i am seeing the same error. I used make command to build 
>> > dpdk, not meson.
>> > The back ported commit you mentioned takes care of meson build only I 
>> > think.
>> >
>>
>> I see, make build is failing, and yes the fix is only for the meson.
>> I will check the make build and will send a fix for it.
>
> [Kalesh]: looks like the below changes fixes the issue. I tried only on 
> SLES15 SP3 and not on other SLES flavors.
>
> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile
> index 595bac2..bf0efab 100644
> --- a/kernel/linux/kni/Makefile
> +++ b/kernel/linux/kni/Makefile
> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include
>  MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h
>  MODULE_CFLAGS += -Wall -Werror
>
> +#
> +# Use explicit 'source' folder for header path. In SUSE 'source' is not 
> linked to 'build' folder.
> +#
> +ifdef CONFIG_SUSE_KERNEL
> +   KSRC = /lib/modules/$(shell uname -r)/source
> +   ifneq ($(shell grep -A 1 "ndo_tx_timeout" 
> $(KSRC)/include/linux/netdevice.h | grep -o txqueue),)
> +  MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE
> +   endif
> +endif

Back in the day we tried various "is Suse and kernel version x.y"
approaches, but they failed as there was no clear version throughout
all of the Suse streams (leap, tumbleweed, sles) that worked well for
all.
This change here follows the upstream approach of "just check if it is there".

I've applied this to 19.11 and did test builds across various distributions:
1. no non-suse build changed
2. suse builds stayed as-is or improved
Formerly failing:
   openSUSE_Factory_ARM aarch64
   SLE_15  x86_64 -> now working
   openSUSE_Leap_15.3 x86_64 -> now working
   openSUSE_Tumbleweed  x86_64 -> still failing
Formerly working:
   SLE_12_SP4 x86_64 ppc64le -> still fine
   openSUSE_Factory_ARM armv7l  -> still fine
   openSUSE_Leap_15.2 x86_64  -> still fine

Past fixes always "inverted" the result, by fixing some but breaking others.
This new patch works in "not breaking any formerly working build" but
at the same time fixing a few builds.
Therefore -> applied & thanks!

I'll likely tag -rc2 before the end of the week.
The good thing is that (so far) we have:
1. a non functional change
2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues)
3. a change fixing sles15SP3 builds

Due to those, no current ongoing tests will have to be restarted.
Whoever was able to build, can continue the current tests.
Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a
failing build and can work with -rc2 then.
I'll explain the same in the mail about -rc2.

>  -include /etc/lsb-release
>
>  ifeq ($(DISTRIB_ID),Ubuntu)
>
> Regards,
> Kalesh

[snip]

-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Re: 19.11.11 patches review and test

[Christian Ehrhardt]

On Tue, Dec 14, 2021 at 8:14 AM Jiang, YuX  wrote:
>
> > -Original Message-
> > From: christian.ehrha...@canonical.com 
> > Sent: Thursday, December 9, 2021 10:43 PM
> > To: sta...@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe ;
> > Akhil Goyal ; Ali Alnubani ;
> > Walker, Benjamin ; David Christensen
> > ; Govindharajan, Hariprasad
> > ; Hemant Agrawal
> > ; Stokes, Ian ; Jerin
> > Jacob ; Mcnamara, John ;
> > Ju-Hyoung Lee ; Kevin Traynor
> > ; Luca Boccassi ; Pei Zhang
> > ; pingx...@intel.com; Xu, Qian Q
> > ; Raslan Darawsheh ; Thomas
> > Monjalon ; Peng, Yuan ;
> > Chen, Zhaoyan 
> > Subject: 19.11.11 patches review and test
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 19.11.11.
> >
> > The planned date for the final release is 7th January 2021.
> >
> > Please help with testing and validation of your use cases and report any
> > issues/results with reply-all to this mail. For the final release the fixes 
> > and
> > reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.11-rc1
> >
> > These patches are located at branch 19.11 of dpdk-stable repo:
> > https://dpdk.org/browse/dpdk-stable/
> >
> > Thanks.
> >
> > Christian Ehrhardt 
> >
> > ---
> Hi Christian,
>
> We find many build issues on LTS19.11. But all of them have no fix yet.

Hi,
thanks for the overview - that will be useful to extend the list of
known-issues eventually.

I agree with all of those reports, and some of them are older already,
not new to the current iteration.
But they all fall into the same category as some former build issues
we have seen.
As the 19.11 series gets older it fails to build in very new
compilers/distros for the new toolchains there being more strict.
I'm happy to backport patches for those, but as always we will only
block new LTS releases if we break build(environments) that formerly
worked.

> https://bugs.dpdk.org/show_bug.cgi?id=744   DPDKcoredev UNCO  
>   --- [dpdk-19.11.9-rc3] make build failed on Fedora34 with GCC11 and 
> build failed on Fedora35 with gcc11.2.1&clang13.0.0
> https://bugs.dpdk.org/show_bug.cgi?id=747   DPDKcoredev UNCO  
>   --- [dpdk-19.11.9-rc3] Meson build failed with ICC-19.1.1
> https://bugs.dpdk.org/show_bug.cgi?id=900   DPDKethdev  dev UNCO  
>   --- [19.11.11-rc1] net/nfp build failure with clang 13

^^ this one has (900) a fix which I already picked and will be in -rc2

> https://bugs.dpdk.org/show_bug.cgi?id=901   DPDKethdev  dev UNCO  
>   --- [19.11.11-rc1] net/i40e build failure with make and clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=902   DPDKethdev  dev UNCO  
>   --- [19.11.11-rc1] net/ice build failure with make and clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=903   DPDKethdev  dev UNCO  
>   --- [19.11.11-rc1] net/ixgbe build failure with make and clang 13
> https://bugs.dpdk.org/show_bug.cgi?id=904   DPDKmeson   dev UNCO  
>   --- [dpdk-19.11.11] Meson build has some failures on Fedora35 with 
> clang 13.0.0
> https://bugs.dpdk.org/show_bug.cgi?id=905   DPDKmeson   dev UNCO  
>   --- [dpdk-19.11.11-rc1]Meson&Makefile build failed on Freebsd13 with 
> gcc10.3.0&clang11.0.1

--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

[PATCH] mbuf: delete dynamic fields copy in hdr copy

[Gaoxiang Liu]

Because dynamic fields are registered by the DPDK application,
so it is up to the application to decide whether to copy the value of
dynamic fields.
So delete dynamic fields copy in __rte_pktmbuf_copy_hdr.
It's more flexible for the DPDK application,
and is useful for improving performance.

Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")

Signed-off-by: Gaoxiang Liu 
---
 lib/mbuf/rte_mbuf.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h
index dedf83c38d..e2dfd47442 100644
--- a/lib/mbuf/rte_mbuf.h
+++ b/lib/mbuf/rte_mbuf.h
@@ -1101,7 +1101,6 @@ __rte_pktmbuf_copy_hdr(struct rte_mbuf *mdst, const 
struct rte_mbuf *msrc)
mdst->tx_offload = msrc->tx_offload;
mdst->hash = msrc->hash;
mdst->packet_type = msrc->packet_type;
-   rte_mbuf_dynfield_copy(mdst, msrc);
 }
 
 /**
-- 
2.32.0