Re: [dpdk-dev] [PATCH] common/cnxk: fix build failure

[Anoob Joseph]

> Subject: [PATCH] common/cnxk: fix build failure
> 
> Fixing build failure with EXTRA_CFLAGS='-O1'.
> 
> Fixes: d85f9749f915 ("common/cnxk: add hash generation API")
> 
> Reported-by: Longfeng Liang 
> Signed-off-by: Tejasree Kondoj 

Acked-by: Anoob Joseph 

Re: [dpdk-dev] [PATCH v7 3/5] eal: use wait event scheme for mcslock

[Jerin Jacob]

On Thu, Oct 28, 2021 at 12:27 PM Feifei Wang  wrote:
>
> Instead of polling for mcslock to be updated, use wait event scheme
> for this case.
>
> Furthermore, use 'uintptr_t *' is for different size of pointer in 32/64
> bits architecture.
>
> And define a new pointer 'next' for the compilation error:
> ---
> 'dereferencing type-punned pointer will break strict-aliasing rules'
> ---
>
> Signed-off-by: Feifei Wang 
> Reviewed-by: Ruifeng Wang 
> ---
>  lib/eal/include/generic/rte_mcslock.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/lib/eal/include/generic/rte_mcslock.h 
> b/lib/eal/include/generic/rte_mcslock.h
> index 34f33c64a5..d5b9b293cd 100644
> --- a/lib/eal/include/generic/rte_mcslock.h
> +++ b/lib/eal/include/generic/rte_mcslock.h
> @@ -116,8 +116,9 @@ rte_mcslock_unlock(rte_mcslock_t **msl, rte_mcslock_t *me)
> /* More nodes added to the queue by other CPUs.
>  * Wait until the next pointer is set.
>  */
> -   while (__atomic_load_n(&me->next, __ATOMIC_RELAXED) == NULL)
> -   rte_pause();
> +   uintptr_t *next = NULL;

It is going to update in the next line. Why explicit NULL assignment?

> +   next = (uintptr_t *)&me->next;
> +   rte_wait_event(next, UINTPTR_MAX, ==, 0, __ATOMIC_RELAXED);
> }
>
> /* Pass lock to next waiter. */
> --
> 2.25.1
>

[dpdk-dev] [PATCH v2 1/3] eventdev/eth_rx: add queue stats get and reset APIs

[Naga Harish K S V]

This patch adds new api ``rte_event_eth_rx_adapter_queue_stats_get`` to
retrieve queue stats. The queue stats are in the format
``struct rte_event_eth_rx_adapter_queue_stats``.

For resetting the queue stats,
``rte_event_eth_rx_adapter_queue_stats_reset`` api is added.

The adapter stats_get and stats_reset apis are also updated to
handle queue level event buffer use case.

Signed-off-by: Naga Harish K S V 
---
v2:
* added pmd callback support for adapter queue_stats_get and
  queue_stats_reset apis.
---
 .../prog_guide/event_ethernet_rx_adapter.rst  |  11 +
 lib/eventdev/eventdev_pmd.h   |  52 
 lib/eventdev/rte_event_eth_rx_adapter.c   | 268 +++---
 lib/eventdev/rte_event_eth_rx_adapter.h   |  66 +
 lib/eventdev/version.map  |   2 +
 5 files changed, 356 insertions(+), 43 deletions(-)

diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst 
b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
index 8b58130fc5..67b11e1563 100644
--- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
+++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
@@ -166,6 +166,17 @@ flags for handling received packets, event queue 
identifier, scheduler type,
 event priority, polling frequency of the receive queue and flow identifier
 in struct ``rte_event_eth_rx_adapter_queue_conf``.
 
+Getting and resetting Adapter queue stats
+~
+
+The ``rte_event_eth_rx_adapter_queue_stats_get()`` function reports
+adapter queue counters defined in struct 
``rte_event_eth_rx_adapter_queue_stats``.
+This function reports queue level stats only when queue level event buffer is
+used otherwise it returns -EINVAL.
+
+The ``rte_event_eth_rx_adapter_queue_stats_reset`` function can be used to
+reset queue level stats when queue level event buffer is in use.
+
 Interrupt Based Rx Queues
 ~~
 
diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h
index d009e24309..3ba49d1fd4 100644
--- a/lib/eventdev/eventdev_pmd.h
+++ b/lib/eventdev/eventdev_pmd.h
@@ -749,6 +749,53 @@ typedef int (*eventdev_eth_rx_adapter_stats_get)
 typedef int (*eventdev_eth_rx_adapter_stats_reset)
(const struct rte_eventdev *dev,
const struct rte_eth_dev *eth_dev);
+
+struct rte_event_eth_rx_adapter_queue_stats;
+
+/**
+ * Retrieve ethernet Rx adapter queue statistics.
+ *
+ * @param dev
+ *   Event device pointer
+ *
+ * @param eth_dev
+ *   Ethernet device pointer
+ *
+ * @param rx_queue_id
+ *  Ethernet device receive queue index.
+ *
+ * @param[out] q_stats
+ *   Pointer to queue stats structure
+ *
+ * @return
+ *   Return 0 on success.
+ */
+typedef int (*eventdev_eth_rx_adapter_q_stats_get)
+   (const struct rte_eventdev *dev,
+const struct rte_eth_dev *eth_dev,
+uint16_t rx_queue_id,
+struct rte_event_eth_rx_adapter_queue_stats *q_stats);
+
+/**
+ * Reset ethernet Rx adapter queue statistics.
+ *
+ * @param dev
+ *   Event device pointer
+ *
+ * @param eth_dev
+ *   Ethernet device pointer
+ *
+ * @param rx_queue_id
+ *  Ethernet device receive queue index.
+ *
+ * @return
+ *   Return 0 on success.
+ */
+typedef int (*eventdev_eth_rx_adapter_q_stats_reset)
+   (const struct rte_eventdev *dev,
+const struct rte_eth_dev *eth_dev,
+uint16_t rx_queue_id);
+
 /**
  * Start eventdev selftest.
  *
@@ -1224,6 +1271,11 @@ struct eventdev_ops {
eventdev_crypto_adapter_stats_reset crypto_adapter_stats_reset;
/**< Reset crypto stats */
 
+   eventdev_eth_rx_adapter_q_stats_get eth_rx_adapter_queue_stats_get;
+   /**< Get ethernet Rx queue stats */
+   eventdev_eth_rx_adapter_q_stats_reset eth_rx_adapter_queue_stats_reset;
+   /**< Reset ethernet Rx queue stats */
+
eventdev_eth_tx_adapter_caps_get_t eth_tx_adapter_caps_get;
/**< Get ethernet Tx adapter capabilities */
 
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c 
b/lib/eventdev/rte_event_eth_rx_adapter.c
index a175c61551..31bbceb6c8 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -245,6 +245,10 @@ struct eth_rx_queue_info {
uint64_t event;
struct eth_rx_vector_data vector_data;
struct eth_event_enqueue_buffer *event_buf;
+   /* use adapter stats struct for queue level stats,
+* as same stats need to be updated for adapter and queue
+*/
+   struct rte_event_eth_rx_adapter_stats *stats;
 };
 
 static struct event_eth_rx_adapter **event_eth_rx_adapter;
@@ -268,14 +272,18 @@ rxa_validate_id(uint8_t id)
 
 static inline struct eth_event_enqueue_buffer *
 rxa_event_buf_get(struct event_eth_rx_adapter *rx_adapter, uint16_t eth_dev_id,
- uint16_t rx_queue_id)
+ uint16_t rx_queue_id,
+  

[dpdk-dev] [PATCH v2 2/3] eventdev/eth_rx: support telemetry

[Naga Harish K S V]

Added telemetry support for rxa_queue_stats and
rxa_queue_stats_reset to get and reset rx queue
stats respectively

Signed-off-by: Naga Harish K S V 
---
 lib/eventdev/rte_event_eth_rx_adapter.c | 124 
 1 file changed, 124 insertions(+)

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c 
b/lib/eventdev/rte_event_eth_rx_adapter.c
index 31bbceb6c8..8cfc10f0c2 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -3345,6 +3345,122 @@ handle_rxa_get_queue_conf(const char *cmd __rte_unused,
return 0;
 }
 
+static int
+handle_rxa_get_queue_stats(const char *cmd __rte_unused,
+  const char *params,
+  struct rte_tel_data *d)
+{
+   uint8_t rx_adapter_id;
+   uint16_t rx_queue_id;
+   int eth_dev_id;
+   char *token, *l_params;
+   struct rte_event_eth_rx_adapter_queue_stats q_stats;
+
+   if (params == NULL || strlen(params) == 0 || !isdigit(*params))
+   return -1;
+
+   /* Get Rx adapter ID from parameter string */
+   l_params = strdup(params);
+   token = strtok(l_params, ",");
+   rx_adapter_id = strtoul(token, NULL, 10);
+   RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(rx_adapter_id, -EINVAL);
+
+   token = strtok(NULL, ",");
+   if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+   return -1;
+
+   /* Get device ID from parameter string */
+   eth_dev_id = strtoul(token, NULL, 10);
+   RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(eth_dev_id, -EINVAL);
+
+   token = strtok(NULL, ",");
+   if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+   return -1;
+
+   /* Get Rx queue ID from parameter string */
+   rx_queue_id = strtoul(token, NULL, 10);
+   if (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {
+   RTE_EDEV_LOG_ERR("Invalid rx queue_id %u", rx_queue_id);
+   return -EINVAL;
+   }
+
+   token = strtok(NULL, "\0");
+   if (token != NULL)
+   RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
+" telemetry command, igrnoring");
+
+   if (rte_event_eth_rx_adapter_queue_stats_get(rx_adapter_id, eth_dev_id,
+   rx_queue_id, &q_stats)) {
+   RTE_EDEV_LOG_ERR("Failed to get Rx adapter queue stats");
+   return -1;
+   }
+
+   rte_tel_data_start_dict(d);
+   rte_tel_data_add_dict_u64(d, "rx_adapter_id", rx_adapter_id);
+   rte_tel_data_add_dict_u64(d, "eth_dev_id", eth_dev_id);
+   rte_tel_data_add_dict_u64(d, "rx_queue_id", rx_queue_id);
+   RXA_ADD_DICT(q_stats, rx_event_buf_count);
+   RXA_ADD_DICT(q_stats, rx_event_buf_size);
+   RXA_ADD_DICT(q_stats, rx_poll_count);
+   RXA_ADD_DICT(q_stats, rx_packets);
+   RXA_ADD_DICT(q_stats, rx_dropped);
+
+   return 0;
+}
+
+static int
+handle_rxa_queue_stats_reset(const char *cmd __rte_unused,
+const char *params,
+struct rte_tel_data *d __rte_unused)
+{
+   uint8_t rx_adapter_id;
+   uint16_t rx_queue_id;
+   int eth_dev_id;
+   char *token, *l_params;
+
+   if (params == NULL || strlen(params) == 0 || !isdigit(*params))
+   return -1;
+
+   /* Get Rx adapter ID from parameter string */
+   l_params = strdup(params);
+   token = strtok(l_params, ",");
+   rx_adapter_id = strtoul(token, NULL, 10);
+   RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(rx_adapter_id, -EINVAL);
+
+   token = strtok(NULL, ",");
+   if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+   return -1;
+
+   /* Get device ID from parameter string */
+   eth_dev_id = strtoul(token, NULL, 10);
+   RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(eth_dev_id, -EINVAL);
+
+   token = strtok(NULL, ",");
+   if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+   return -1;
+
+   /* Get Rx queue ID from parameter string */
+   rx_queue_id = strtoul(token, NULL, 10);
+   if (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {
+   RTE_EDEV_LOG_ERR("Invalid rx queue_id %u", rx_queue_id);
+   return -EINVAL;
+   }
+
+   token = strtok(NULL, "\0");
+   if (token != NULL)
+   RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
+" telemetry command, igrnoring");
+
+   if (rte_event_eth_rx_adapter_queue_stats_reset(rx_adapter_id,
+  eth_dev_id,
+  rx_queue_id)) {
+   RTE_EDEV_LOG_ERR("Failed to reset Rx adapter queue stats");
+   return -1;
+   }
+
+   return 0;
+}
+
 RTE_INIT(rxa_init_telemetry)
 {
rte_telemetry_register_c

[dpdk-dev] [PATCH v2 3/3] test/event: add unit test for Rx adapter

[Naga Harish K S V]

add unit test for rte_event_eth_rx_adapter_queue_stats_get() and
rte_event_eth_rx_adapter_queue_stats_reset() apis.

Signed-off-by: Naga Harish K S V 
---
 app/test/test_event_eth_rx_adapter.c | 60 
 1 file changed, 60 insertions(+)

diff --git a/app/test/test_event_eth_rx_adapter.c 
b/app/test/test_event_eth_rx_adapter.c
index 1419f6f64d..7cb91b152f 100644
--- a/app/test/test_event_eth_rx_adapter.c
+++ b/app/test/test_event_eth_rx_adapter.c
@@ -471,6 +471,64 @@ adapter_queue_event_buf_test(void)
return TEST_SUCCESS;
 }
 
+static int
+adapter_queue_stats_test(void)
+{
+   int err;
+   struct rte_event ev;
+   uint32_t cap;
+   struct rte_event_eth_rx_adapter_queue_conf queue_config = {0};
+   struct rte_event_eth_rx_adapter_queue_stats q_stats;
+
+   err = rte_event_eth_rx_adapter_queue_stats_get(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0,
+   &q_stats);
+   TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
+
+   err = rte_event_eth_rx_adapter_queue_stats_reset(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0);
+   TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
+
+   err = rte_event_eth_rx_adapter_caps_get(TEST_DEV_ID, TEST_ETHDEV_ID,
+&cap);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   ev.queue_id = 0;
+   ev.sched_type = RTE_SCHED_TYPE_ATOMIC;
+   ev.priority = 0;
+
+   queue_config.rx_queue_flags = 0;
+   if (cap & RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) {
+   ev.flow_id = 1;
+   queue_config.rx_queue_flags =
+   RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID;
+   }
+   queue_config.ev = ev;
+   queue_config.servicing_weight = 1;
+   queue_config.event_buf_size = 1024;
+
+   err = rte_event_eth_rx_adapter_queue_add(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0,
+   &queue_config);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   err = rte_event_eth_rx_adapter_queue_stats_get(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0,
+   &q_stats);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   err = rte_event_eth_rx_adapter_queue_stats_reset(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   err = rte_event_eth_rx_adapter_queue_del(TEST_INST_ID,
+   TEST_ETHDEV_ID,
+   0);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   return TEST_SUCCESS;
+}
+
 static void
 adapter_free(void)
 {
@@ -940,6 +998,8 @@ static struct unit_test_suite event_eth_rx_tests = {
TEST_CASE_ST(adapter_create, adapter_free, adapter_queue_conf),
TEST_CASE_ST(adapter_create_with_params, adapter_free,
 adapter_queue_event_buf_test),
+   TEST_CASE_ST(adapter_create_with_params, adapter_free,
+adapter_queue_stats_test),
TEST_CASES_END() /**< NULL terminate unit test array */
}
 };
-- 
2.25.1

Re: [dpdk-dev] [PATCH v1] test/crypto: fix: test vectors for zuc 256 bit key

[Akhil Goyal]

> Fix the IV and MAC in the test vectors added for zuc 256-bit key
> 
> Fixes: fa5bf9345d4e (test/crypto: add ZUC cases with 256-bit keys)
> 
> Signed-off-by: Vidya Sagar Velumuri 
> 
@Fan Zhang, @ciara.po...@intel.com: can you verify at your end?
And see if Bug 828 in Bugzilla gets resolved with this.

Re: [dpdk-dev] [dpdk-announce] release candidate 21.11-rc1

[Jiang, YuX]

> -Original Message-
> From: dev  On Behalf Of Thomas Monjalon
> Sent: Tuesday, October 26, 2021 5:41 AM
> To: annou...@dpdk.org
> Subject: [dpdk-dev] [dpdk-announce] release candidate 21.11-rc1
>
> A new DPDK release candidate is ready for testing:
>   https://git.dpdk.org/dpdk/tag/?id=v21.11-rc1
>
> There are 1171 new patches in this snapshot, big as expected.
>
> Release notes:
>   https://doc.dpdk.org/guides/rel_notes/release_21_11.html
>
> Highlights of 21.11-rc1:
> * General
>   - more than 512 MSI-X interrupts
>   - hugetlbfs subdirectories
>   - mempool flag for non-IO usages
>   - device class for DMA accelerators
>   - DMA drivers for Intel DSA and IOAT
> * Networking
>   - MTU handling rework
>   - get all MAC addresses of a port
>   - RSS based on L3/L4 checksum fields
>   - flow match on L2TPv2 and PPP
>   - flow flex parser for custom header
>   - control delivery of HW Rx metadata
>   - transfer flows API rework
>   - shared Rx queue
>   - Windows support of Intel e1000, ixgbe and iavf
>   - testpmd multi-process
>   - pcapng library and dumpcap tool
> * API/ABI
>   - API namespace improvements (mempool, mbuf, ethdev)
>   - API internals hidden (intr, ethdev, security, cryptodev, eventdev,
> cmdline)
>   - flags check for future ABI compatibility (memzone, mbuf, mempool)
>
> Please test and report issues on bugs.dpdk.org.
> DPDK 21.11-rc2 is expected in two weeks or less.
>
> Thank you everyone
>
Update the test status for Intel part. Till now dpdk21.11-rc1 test execution 
rate is 50%. No critical issue is found.
But one little high issue https://bugs.dpdk.org/show_bug.cgi?id=843 impacts 
cryptodev function and performance test.
Bad commit id is 8cb5d08db940a6b26f5c5ac03b49bac25e9a7022/Author: Harman Kalra 
. Please help to handle it.
# Basic Intel(R) NIC testing
* Build or compile:
*Build: cover the build test combination with latest GCC/Clang/ICC 
version and the popular OS revision such as Ubuntu20.04, Fedora34, RHEL8.4, etc.
- All test done.
*Compile: cover the CFLAGES(O0/O1/O2/O3) with popular OS such as 
Ubuntu20.04 and Fedora34.
- All test done.
- Find one bug: https://bugs.dpdk.org/show_bug.cgi?id=841 
Marvell Dev has provided patch and Intel validation team verify passed.
  Patch link: 
http://patchwork.dpdk.org/project/dpdk/patch/20211027131259.11775-1-ktejas...@marvell.com/
* PF(i40e, ixgbe): test scenarios including 
RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
- Execution rate is 60%. No new issue is found yet.
* VF(i40e, ixgbe): test scenarios including 
VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
- Execution rate is 60%.
- One bug https://bugs.dpdk.org/show_bug.cgi?id=845 about 
"vm_hotplug: vf testpmd core dumped after executing "device_del dev1" in qemu" 
is found.
Bad commit id is commit 
c2bd9367e18f5b00c1a3c5eb281a512ef52c5dfd Author: Harman Kalra 

* PF/VF(ice): test scenarios including Switch features/Package 
Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Share code 
update/Flexible Descriptor, etc.
- Execution rate is 60%.
- One bug about kni_autotest failed on Suse15.3. Trying to find 
bad commit id. Known issues, Intel dev is under investigating.
* Intel NIC single core/NIC performance: test scenarios including PF/VF 
single core performance test, RFC2544 Zero packet loss performance test, etc.
- Execution rate is 60%.
- One bug about nic single core performance drop 2% is found. 
Bad commit id is commit:  efc6f9104c80d39ec168/Author: Olivier Matz 

* Power and IPsec:
* Power: test scenarios including bi-direction/Telemetry/Empty 
Poll Lib/Priority Base Frequency, etc.
- All passed.
* IPsec: test scenarios including ipsec/ipsec-gw/ipsec library 
basic test - QAT&SW/FIB library, etc.
- Not Start.
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as 
PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE 
ESXI 7.0u3, etc.
- Execution rate is 80%.
- Two new bugs are found.
- One about VMware ESXI 7.0U3: failed to start port. 
Intel Dev is under investigating.
- One https://bugs.dpdk.org/show_bug.cgi?id=840 about 
"dpdk-pdump capture the pcap file content are wrong" is found.
Bad commit id: commit 
10f726efe26c55805cf0bf6ca1b80e97b98eb724//bad commit id Author: Stephen 
Hemminger 
* Cryptodev:
*Function test: test scenarios including Cryptodev API 
testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS,

[dpdk-dev] 回复: [PATCH v7 3/5] eal: use wait event scheme for mcslock

[Feifei Wang]

> -邮件原件-
> 发件人: dev  代表 Jerin Jacob
> 发送时间: Thursday, October 28, 2021 3:02 PM
> 收件人: Feifei Wang 
> 抄送: Honnappa Nagarahalli ; dpdk-dev
> ; nd ; Ananyev, Konstantin
> ; Stephen Hemminger
> ; David Marchand
> ; tho...@monjalon.net; Mattias Rönnblom
> ; Ruifeng Wang 
> 主题: Re: [dpdk-dev] [PATCH v7 3/5] eal: use wait event scheme for mcslock
> 
> On Thu, Oct 28, 2021 at 12:27 PM Feifei Wang 
> wrote:
> >
> > Instead of polling for mcslock to be updated, use wait event scheme
> > for this case.
> >
> > Furthermore, use 'uintptr_t *' is for different size of pointer in
> > 32/64 bits architecture.
> >
> > And define a new pointer 'next' for the compilation error:
> > ---
> > 'dereferencing type-punned pointer will break strict-aliasing rules'
> > ---
> >
> > Signed-off-by: Feifei Wang 
> > Reviewed-by: Ruifeng Wang 
> > ---
> >  lib/eal/include/generic/rte_mcslock.h | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/eal/include/generic/rte_mcslock.h
> > b/lib/eal/include/generic/rte_mcslock.h
> > index 34f33c64a5..d5b9b293cd 100644
> > --- a/lib/eal/include/generic/rte_mcslock.h
> > +++ b/lib/eal/include/generic/rte_mcslock.h
> > @@ -116,8 +116,9 @@ rte_mcslock_unlock(rte_mcslock_t **msl,
> rte_mcslock_t *me)
> > /* More nodes added to the queue by other CPUs.
> >  * Wait until the next pointer is set.
> >  */
> > -   while (__atomic_load_n(&me->next, __ATOMIC_RELAXED) ==
> NULL)
> > -   rte_pause();
> > +   uintptr_t *next = NULL;
> 
> It is going to update in the next line. Why explicit NULL assignment?
You are right, it is unnecessary to initialize it as NULL. I will update this.
> 
> > +   next = (uintptr_t *)&me->next;
> > +   rte_wait_event(next, UINTPTR_MAX, ==, 0,
> > + __ATOMIC_RELAXED);
> > }
> >
> > /* Pass lock to next waiter. */
> > --
> > 2.25.1
> >

Re: [dpdk-dev] [PATCH v7 1/5] eal: add new definitions for wait scheme

[Jerin Jacob]

On Thu, Oct 28, 2021 at 12:26 PM Feifei Wang  wrote:
>
> Introduce macros as generic interface for address monitoring.
> For different size, encapsulate '__LOAD_EXC_16', '__LOAD_EXC_32'
> and '__LOAD_EXC_64' into a new macro '__LOAD_EXC'.
>
> Furthermore, to prevent compilation warning in arm:
> --
> 'warning: implicit declaration of function ...'
> --
> Delete 'undef' constructions for '__LOAD_EXC_xx', '__SEVL' and '__WFE'.
> And add ‘__RTE_ARM’ for these macros to fix the namespace.
>
> This is because original macros are undefine at the end of the file.
> If new macro 'rte_wait_event' calls them in other files, they will be
> seen as 'not defined'.
>
> Signed-off-by: Feifei Wang 
> Reviewed-by: Ruifeng Wang 
> ---

> +static __rte_always_inline void
> +rte_wait_until_equal_16(volatile uint16_t *addr, uint16_t expected,
> +   int memorder)
> +{
> +   uint16_t value;
> +
> +   assert(memorder == __ATOMIC_ACQUIRE || memorder == __ATOMIC_RELAXED);

Assert is not good in the library, Why not RTE_BUILD_BUG_ON here


> +
> +   __RTE_ARM_LOAD_EXC_16(addr, value, memorder)
> if (value != expected) {
> -   __SEVL()
> +__RTE_ARM_SEVL()
> do {
> -   __WFE()
> -   __LOAD_EXC_16(addr, value, memorder)
> +   __RTE_ARM_WFE()
> +   __RTE_ARM_LOAD_EXC_16(addr, value, memorder)
> } while (value != expected);
> }
> -#undef __LOAD_EXC_16
>  }
>
>  static __rte_always_inline void
> @@ -77,34 +124,14 @@ rte_wait_until_equal_32(volatile uint32_t *addr, 
> uint32_t expected,
>
> assert(memorder == __ATOMIC_ACQUIRE || memorder == __ATOMIC_RELAXED);
>
> -   /*
> -* Atomic exclusive load from addr, it returns the 32-bit content of
> -* *addr while making it 'monitored',when it is written by someone
> -* else, the 'monitored' state is cleared and a event is generated
> -* implicitly to exit WFE.
> -*/
> -#define __LOAD_EXC_32(src, dst, memorder) {  \
> -   if (memorder == __ATOMIC_RELAXED) {  \
> -   asm volatile("ldxr %w[tmp], [%x[addr]]"  \
> -   : [tmp] "=&r" (dst)  \
> -   : [addr] "r"(src)\
> -   : "memory"); \
> -   } else { \
> -   asm volatile("ldaxr %w[tmp], [%x[addr]]" \
> -   : [tmp] "=&r" (dst)  \
> -   : [addr] "r"(src)\
> -   : "memory"); \
> -   } }
> -
> -   __LOAD_EXC_32(addr, value, memorder)
> +   __RTE_ARM_LOAD_EXC_32(addr, value, memorder)
> if (value != expected) {
> -   __SEVL()
> +   __RTE_ARM_SEVL()
> do {
> -   __WFE()
> -   __LOAD_EXC_32(addr, value, memorder)
> +   __RTE_ARM_WFE()
> +   __RTE_ARM_LOAD_EXC_32(addr, value, memorder)
> } while (value != expected);
> }
> -#undef __LOAD_EXC_32
>  }
>
>  static __rte_always_inline void
> @@ -115,38 +142,33 @@ rte_wait_until_equal_64(volatile uint64_t *addr, 
> uint64_t expected,
>
> assert(memorder == __ATOMIC_ACQUIRE || memorder == __ATOMIC_RELAXED);

remove assert and change to BUILD_BUG_ON

>
> -   /*
> -* Atomic exclusive load from addr, it returns the 64-bit content of
> -* *addr while making it 'monitored',when it is written by someone
> -* else, the 'monitored' state is cleared and a event is generated
> -* implicitly to exit WFE.
> -*/
> -#define __LOAD_EXC_64(src, dst, memorder) {  \
> -   if (memorder == __ATOMIC_RELAXED) {  \
> -   asm volatile("ldxr %x[tmp], [%x[addr]]"  \
> -   : [tmp] "=&r" (dst)  \
> -   : [addr] "r"(src)\
> -   : "memory"); \
> -   } else { \
> -   asm volatile("ldaxr %x[tmp], [%x[addr]]" \
> -   : [tmp] "=&r" (dst)  \
> -   : [addr] "r"(src)\
> -   : "memory"); \
> -   } }
> -
> -   __LOAD_EXC_64(addr, value, memorder)
> +   __RTE_ARM_LOAD_EXC_64(addr, value, memorder)
> if (value != expected) {
> -   __SEVL()
> +   __RTE_ARM_SEVL()
> do {
> -   __WFE()
> -   __LOAD_EXC_64(addr, value, memorder)
> +   __RTE_ARM_WFE()
> +   __RTE_ARM_LOAD_EXC_64(addr, v

[dpdk-dev] [PATCH] crypto/octeontx2: fix ESN seqhi

[Archana Muniganti]

For current pkt, previous seqhi is used instead of its
guessed seqhi. Fixed it.

Fixes: 5be562bc5b78 ("crypto/octeontx2: support IPsec ESN and anti-replay")
Cc: sta...@dpdk.org

Signed-off-by: Archana Muniganti 
---
 drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c 
b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c
index f0b72e05c2..4330cbd1c1 100644
--- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c
+++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c
@@ -736,6 +736,14 @@ otx2_cpt_enqueue_sec(struct otx2_cpt_qp *qp, struct 
rte_crypto_op *op,
otx2_err("Anti replay check failed");
return IPSEC_ANTI_REPLAY_FAILED;
}
+
+   if (esn) {
+   seq_in_sa = ((uint64_t)esn_hi << 32) | esn_low;
+   if (seq > seq_in_sa) {
+   sa->esn_low = rte_cpu_to_be_32(seql);
+   sa->esn_hi = rte_cpu_to_be_32(seqh);
+   }
+   }
}
 
ret = process_inb_sa(op, sess, &qp->meta_info, (void **)&req);
@@ -749,14 +757,6 @@ otx2_cpt_enqueue_sec(struct otx2_cpt_qp *qp, struct 
rte_crypto_op *op,
ret = otx2_cpt_enqueue_req(qp, pend_q, req, op, sess->cpt_inst_w7,
burst_index);
 
-   if (winsz && esn) {
-   seq_in_sa = ((uint64_t)esn_hi << 32) | esn_low;
-   if (seq > seq_in_sa) {
-   sa->esn_low = rte_cpu_to_be_32(seql);
-   sa->esn_hi = rte_cpu_to_be_32(seqh);
-   }
-   }
-
return ret;
 }
 
-- 
2.22.0

Re: [dpdk-dev] [PATCH] crypto/octeontx2: fix ESN seqhi

[Anoob Joseph]

> Subject: [PATCH] crypto/octeontx2: fix ESN seqhi
> 
> For current pkt, previous seqhi is used instead of its guessed seqhi. Fixed 
> it.
> 
> Fixes: 5be562bc5b78 ("crypto/octeontx2: support IPsec ESN and anti-replay")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Archana Muniganti 
> ---
>  drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 

Acked-by: Anoob Joseph 

[dpdk-dev] 回复: [PATCH v7 1/5] eal: add new definitions for wait scheme

[Feifei Wang]

> -邮件原件-
> 发件人: Jerin Jacob 
> 发送时间: Thursday, October 28, 2021 3:16 PM
> 收件人: Feifei Wang 
> 抄送: Ruifeng Wang ; dpdk-dev ;
> nd ; Ananyev, Konstantin ;
> Stephen Hemminger ; David Marchand
> ; tho...@monjalon.net; Mattias Rönnblom
> 
> 主题: Re: [PATCH v7 1/5] eal: add new definitions for wait scheme
> 
> On Thu, Oct 28, 2021 at 12:26 PM Feifei Wang 
> wrote:
> >
> > Introduce macros as generic interface for address monitoring.
> > For different size, encapsulate '__LOAD_EXC_16', '__LOAD_EXC_32'
> > and '__LOAD_EXC_64' into a new macro '__LOAD_EXC'.
> >
> > Furthermore, to prevent compilation warning in arm:
> > --
> > 'warning: implicit declaration of function ...'
> > --
> > Delete 'undef' constructions for '__LOAD_EXC_xx', '__SEVL' and '__WFE'.
> > And add ‘__RTE_ARM’ for these macros to fix the namespace.
> >
> > This is because original macros are undefine at the end of the file.
> > If new macro 'rte_wait_event' calls them in other files, they will be
> > seen as 'not defined'.
> >
> > Signed-off-by: Feifei Wang 
> > Reviewed-by: Ruifeng Wang 
> > ---
> 
> > +static __rte_always_inline void
> > +rte_wait_until_equal_16(volatile uint16_t *addr, uint16_t expected,
> > +   int memorder)
> > +{
> > +   uint16_t value;
> > +
> > +   assert(memorder == __ATOMIC_ACQUIRE || memorder ==
> > + __ATOMIC_RELAXED);
> 
> Assert is not good in the library, Why not RTE_BUILD_BUG_ON here
[Feifei] This line is the original code which has nothing to do with this 
patch, 
I can change it in the next version.
> 
> 
> > +
> > +   __RTE_ARM_LOAD_EXC_16(addr, value, memorder)
> > if (value != expected) {
> > -   __SEVL()
> > +__RTE_ARM_SEVL()
> > do {
> > -   __WFE()
> > -   __LOAD_EXC_16(addr, value, memorder)
> > +   __RTE_ARM_WFE()
> > +   __RTE_ARM_LOAD_EXC_16(addr, value, memorder)
> > } while (value != expected);
> > }
> > -#undef __LOAD_EXC_16
> >  }
> >
> >  static __rte_always_inline void
> > @@ -77,34 +124,14 @@ rte_wait_until_equal_32(volatile uint32_t *addr,
> > uint32_t expected,
> >
> > assert(memorder == __ATOMIC_ACQUIRE || memorder ==
> > __ATOMIC_RELAXED);
> >
> > -   /*
> > -* Atomic exclusive load from addr, it returns the 32-bit content of
> > -* *addr while making it 'monitored',when it is written by someone
> > -* else, the 'monitored' state is cleared and a event is generated
> > -* implicitly to exit WFE.
> > -*/
> > -#define __LOAD_EXC_32(src, dst, memorder) {  \
> > -   if (memorder == __ATOMIC_RELAXED) {  \
> > -   asm volatile("ldxr %w[tmp], [%x[addr]]"  \
> > -   : [tmp] "=&r" (dst)  \
> > -   : [addr] "r"(src)\
> > -   : "memory"); \
> > -   } else { \
> > -   asm volatile("ldaxr %w[tmp], [%x[addr]]" \
> > -   : [tmp] "=&r" (dst)  \
> > -   : [addr] "r"(src)\
> > -   : "memory"); \
> > -   } }
> > -
> > -   __LOAD_EXC_32(addr, value, memorder)
> > +   __RTE_ARM_LOAD_EXC_32(addr, value, memorder)
> > if (value != expected) {
> > -   __SEVL()
> > +   __RTE_ARM_SEVL()
> > do {
> > -   __WFE()
> > -   __LOAD_EXC_32(addr, value, memorder)
> > +   __RTE_ARM_WFE()
> > +   __RTE_ARM_LOAD_EXC_32(addr, value, memorder)
> > } while (value != expected);
> > }
> > -#undef __LOAD_EXC_32
> >  }
> >
> >  static __rte_always_inline void
> > @@ -115,38 +142,33 @@ rte_wait_until_equal_64(volatile uint64_t *addr,
> > uint64_t expected,
> >
> > assert(memorder == __ATOMIC_ACQUIRE || memorder ==
> > __ATOMIC_RELAXED);
> 
> remove assert and change to BUILD_BUG_ON
[Feifei] OK
> 
> >
> > -   /*
> > -* Atomic exclusive load from addr, it returns the 64-bit content of
> > -* *addr while making it 'monitored',when it is written by someone
> > -* else, the 'monitored' state is cleared and a event is generated
> > -* implicitly to exit WFE.
> > -*/
> > -#define __LOAD_EXC_64(src, dst, memorder) {  \
> > -   if (memorder == __ATOMIC_RELAXED) {  \
> > -   asm volatile("ldxr %x[tmp], [%x[addr]]"  \
> > -   : [tmp] "=&r" (dst)  \
> > -   : [addr] "r"(src)\
> > -   : "memory"); \
> > -   } else { \

Re: [dpdk-dev] [PATCH v7 1/5] eal: add new definitions for wait scheme

[Jerin Jacob]

On Thu, Oct 28, 2021 at 1:11 PM Feifei Wang  wrote:
>
>
>
> > -邮件原件-
> > 发件人: Jerin Jacob 
> > 发送时间: Thursday, October 28, 2021 3:16 PM
> > 收件人: Feifei Wang 
> > 抄送: Ruifeng Wang ; dpdk-dev ;
> > nd ; Ananyev, Konstantin ;
> > Stephen Hemminger ; David Marchand
> > ; tho...@monjalon.net; Mattias Rönnblom
> > 
> > 主题: Re: [PATCH v7 1/5] eal: add new definitions for wait scheme
> >
> > On Thu, Oct 28, 2021 at 12:26 PM Feifei Wang 
> > wrote:
> > >
> > > Introduce macros as generic interface for address monitoring.
> > > For different size, encapsulate '__LOAD_EXC_16', '__LOAD_EXC_32'
> > > and '__LOAD_EXC_64' into a new macro '__LOAD_EXC'.
> > >
> > > Furthermore, to prevent compilation warning in arm:
> > > --
> > > 'warning: implicit declaration of function ...'
> > > --
> > > Delete 'undef' constructions for '__LOAD_EXC_xx', '__SEVL' and '__WFE'.
> > > And add ‘__RTE_ARM’ for these macros to fix the namespace.
> > >
> > > This is because original macros are undefine at the end of the file.
> > > If new macro 'rte_wait_event' calls them in other files, they will be
> > > seen as 'not defined'.
> > >
> > > Signed-off-by: Feifei Wang 
> > > Reviewed-by: Ruifeng Wang 
> > > ---
> >
> > > +static __rte_always_inline void
> > > +rte_wait_until_equal_16(volatile uint16_t *addr, uint16_t expected,
> > > +   int memorder)
> > > +{
> > > +   uint16_t value;
> > > +
> > > +   assert(memorder == __ATOMIC_ACQUIRE || memorder ==
> > > + __ATOMIC_RELAXED);
> >
> > Assert is not good in the library, Why not RTE_BUILD_BUG_ON here
> [Feifei] This line is the original code which has nothing to do with this 
> patch,
> I can change it in the next version.
> >
> >
> > > +
> > > +   __RTE_ARM_LOAD_EXC_16(addr, value, memorder)
> > > if (value != expected) {
> > > -   __SEVL()
> > > +__RTE_ARM_SEVL()
> > > do {
> > > -   __WFE()
> > > -   __LOAD_EXC_16(addr, value, memorder)
> > > +   __RTE_ARM_WFE()
> > > +   __RTE_ARM_LOAD_EXC_16(addr, value, memorder)
> > > } while (value != expected);
> > > }
> > > -#undef __LOAD_EXC_16
> > >  }
> > >
> > >  static __rte_always_inline void
> > > @@ -77,34 +124,14 @@ rte_wait_until_equal_32(volatile uint32_t *addr,
> > > uint32_t expected,
> > >
> > > assert(memorder == __ATOMIC_ACQUIRE || memorder ==
> > > __ATOMIC_RELAXED);
> > >
> > > -   /*
> > > -* Atomic exclusive load from addr, it returns the 32-bit content 
> > > of
> > > -* *addr while making it 'monitored',when it is written by someone
> > > -* else, the 'monitored' state is cleared and a event is generated
> > > -* implicitly to exit WFE.
> > > -*/
> > > -#define __LOAD_EXC_32(src, dst, memorder) {  \
> > > -   if (memorder == __ATOMIC_RELAXED) {  \
> > > -   asm volatile("ldxr %w[tmp], [%x[addr]]"  \
> > > -   : [tmp] "=&r" (dst)  \
> > > -   : [addr] "r"(src)\
> > > -   : "memory"); \
> > > -   } else { \
> > > -   asm volatile("ldaxr %w[tmp], [%x[addr]]" \
> > > -   : [tmp] "=&r" (dst)  \
> > > -   : [addr] "r"(src)\
> > > -   : "memory"); \
> > > -   } }
> > > -
> > > -   __LOAD_EXC_32(addr, value, memorder)
> > > +   __RTE_ARM_LOAD_EXC_32(addr, value, memorder)
> > > if (value != expected) {
> > > -   __SEVL()
> > > +   __RTE_ARM_SEVL()
> > > do {
> > > -   __WFE()
> > > -   __LOAD_EXC_32(addr, value, memorder)
> > > +   __RTE_ARM_WFE()
> > > +   __RTE_ARM_LOAD_EXC_32(addr, value, memorder)
> > > } while (value != expected);
> > > }
> > > -#undef __LOAD_EXC_32
> > >  }
> > >
> > >  static __rte_always_inline void
> > > @@ -115,38 +142,33 @@ rte_wait_until_equal_64(volatile uint64_t *addr,
> > > uint64_t expected,
> > >
> > > assert(memorder == __ATOMIC_ACQUIRE || memorder ==
> > > __ATOMIC_RELAXED);
> >
> > remove assert and change to BUILD_BUG_ON
> [Feifei] OK
> >
> > >
> > > -   /*
> > > -* Atomic exclusive load from addr, it returns the 64-bit content 
> > > of
> > > -* *addr while making it 'monitored',when it is written by someone
> > > -* else, the 'monitored' state is cleared and a event is generated
> > > -* implicitly to exit WFE.
> > > -*/
> > > -#define __LOAD_EXC_64(src, dst, memorder) {  \
> > > -   if (memorder == __ATOMIC_RELAXED) {  \
> > > -

Re: [dpdk-dev] [PATCH v1 1/1] vfio: fix partial unmap check

[David Marchand]

On Thu, Oct 28, 2021 at 8:06 AM Ding, Xuan  wrote:
> >> Partial unmap support was introduced in commit c13ca4e81cac, and with it
> >> was added a check that dereferenced the IOMMU type to determine
> >whether
> >> partial ummapping is supported for currently configured IOMMU type. In
> >> certain circumstances (such as when VFIO is supported, but no devices
> >> were bound to the VFIO driver), the IOMMU type pointer can be NULL.
> >>
> >> However, dereferencing of IOMMU type was guarded by access to the user
> >> maps list - that is, we were always checking the user map list first,
> >> and then, if we found a memory region that encloses the one we're trying
> >> to unmap, we would have performed the IOMMU type check.
> >>
> >> This ensured that the IOMMU type check will not cause any NULL pointer
> >> dereferences, because in order for an IOMMU type check to have been
> >> performed, there necessarily must have been at least one memory region
> >> that was previously mapped successfully, and that implies having a
> >> defined IOMMU type.
> >>
> >> When 56259f7fc010 was introduced, the IOMMU type check was moved to
> >> before we were traversing the user mem maps list, thereby introducing a
> >> potential NULL dereference, because the IOMMU type access was no longer
> >> guarded by the user mem maps list traversal.
> >>
> >> Fix the issue by moving the IOMMU type check to after the user mem maps
> >> traversal, thereby ensuring that by the time the check happens, the
> >> IOMMU type is always valid.
> >>
> >> Fixes: 56259f7fc010 ("vfio: allow partially unmapping adjacent memory")
> >> Cc: xuan.d...@intel.com
> >>
> >> Signed-off-by: Anatoly Burakov 
> >Reviewed-by: David Marchand 
> Tested-by: Xuan Ding 

Applied, thanks.


-- 
David Marchand

[dpdk-dev] [PATCH v2 00/10] vdpa/sfc: introduce Xilinx vDPA driver

[Vijay Srivastava]

This patch series introduces vDPA driver for Xilinx devices.
The Xilinx vDPA (vhost data path acceleration) provides
support for the Xilinx SN1022 SmartNICs.

Vijay Kumar Srivastava (10):
  vdpa/sfc: introduce Xilinx vDPA driver
  vdpa/sfc: add support for device initialization
  vdpa/sfc: add support to get device and protocol features
  vdpa/sfc: get device supported max queue count
  vdpa/sfc: add support to get VFIO device fd
  vdpa/sfc: add support for dev conf and dev close ops
  vdpa/sfc: add support to get queue notify area info
  vdpa/sfc: add support for MAC filter config
  vdpa/sfc: add support to set vring state
  vdpa/sfc: set a multicast filter during vDPA init

 MAINTAINERS|   6 +
 doc/guides/rel_notes/release_21_11.rst |   5 +
 doc/guides/vdpadevs/features/sfc.ini   |  19 +
 doc/guides/vdpadevs/sfc.rst| 107 
 drivers/common/sfc_efx/efsys.h |   2 +-
 drivers/common/sfc_efx/version.map |  10 +
 drivers/vdpa/meson.build   |   1 +
 drivers/vdpa/sfc/meson.build   |  37 ++
 drivers/vdpa/sfc/sfc_vdpa.c| 367 +
 drivers/vdpa/sfc/sfc_vdpa.h| 163 ++
 drivers/vdpa/sfc/sfc_vdpa_debug.h  |  21 +
 drivers/vdpa/sfc/sfc_vdpa_filter.c | 159 ++
 drivers/vdpa/sfc/sfc_vdpa_hw.c | 419 +++
 drivers/vdpa/sfc/sfc_vdpa_log.h|  59 ++
 drivers/vdpa/sfc/sfc_vdpa_mcdi.c   |  74 +++
 drivers/vdpa/sfc/sfc_vdpa_ops.c| 947 +
 drivers/vdpa/sfc/sfc_vdpa_ops.h|  69 +++
 drivers/vdpa/sfc/version.map   |   3 +
 18 files changed, 2467 insertions(+), 1 deletion(-)
 create mode 100644 doc/guides/vdpadevs/features/sfc.ini
 create mode 100644 doc/guides/vdpadevs/sfc.rst
 create mode 100644 drivers/vdpa/sfc/meson.build
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa.h
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_debug.h
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_filter.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_hw.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_log.h
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_mcdi.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.h
 create mode 100644 drivers/vdpa/sfc/version.map

-- 
1.8.3.1

[dpdk-dev] [PATCH v2 01/10] vdpa/sfc: introduce Xilinx vDPA driver

[Vijay Srivastava]

From: Vijay Kumar Srivastava 

Add new vDPA PMD to support vDPA operation by Xilinx devices.
This patch implements probe and remove functions.

Signed-off-by: Vijay Kumar Srivastava 
---
v2:
* Updated logging mcaros to remove redundant code.

 MAINTAINERS|   6 +
 doc/guides/rel_notes/release_21_11.rst |   5 +
 doc/guides/vdpadevs/features/sfc.ini   |   9 ++
 doc/guides/vdpadevs/sfc.rst|  97 +++
 drivers/vdpa/meson.build   |   1 +
 drivers/vdpa/sfc/meson.build   |  33 
 drivers/vdpa/sfc/sfc_vdpa.c| 286 +
 drivers/vdpa/sfc/sfc_vdpa.h|  40 +
 drivers/vdpa/sfc/sfc_vdpa_log.h|  56 +++
 drivers/vdpa/sfc/version.map   |   3 +
 10 files changed, 536 insertions(+)
 create mode 100644 doc/guides/vdpadevs/features/sfc.ini
 create mode 100644 doc/guides/vdpadevs/sfc.rst
 create mode 100644 drivers/vdpa/sfc/meson.build
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa.h
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_log.h
 create mode 100644 drivers/vdpa/sfc/version.map

diff --git a/MAINTAINERS b/MAINTAINERS
index be2c9b6..5d12c49 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1236,6 +1236,12 @@ F: drivers/vdpa/mlx5/
 F: doc/guides/vdpadevs/mlx5.rst
 F: doc/guides/vdpadevs/features/mlx5.ini
 
+Xilinx sfc vDPA
+M: Vijay Kumar Srivastava 
+F: drivers/vdpa/sfc/
+F: doc/guides/vdpadevs/sfc.rst
+F: doc/guides/vdpadevs/features/sfc.ini
+
 
 Eventdev Drivers
 
diff --git a/doc/guides/rel_notes/release_21_11.rst 
b/doc/guides/rel_notes/release_21_11.rst
index 1ccac87..bd0a604 100644
--- a/doc/guides/rel_notes/release_21_11.rst
+++ b/doc/guides/rel_notes/release_21_11.rst
@@ -305,6 +305,11 @@ New Features
 * Pcapng format with timestamps and meta-data.
 * Fixes packet capture with stripped VLAN tags.
 
+* **Add new vDPA PMD based on Xilinx devices.**
+
+  Added a new Xilinx vDPA  (``sfc_vdpa``) PMD.
+  See the :doc:`../vdpadevs/sfc` guide for more details on this driver.
+
 
 Removed Items
 -
diff --git a/doc/guides/vdpadevs/features/sfc.ini 
b/doc/guides/vdpadevs/features/sfc.ini
new file mode 100644
index 000..71b6158
--- /dev/null
+++ b/doc/guides/vdpadevs/features/sfc.ini
@@ -0,0 +1,9 @@
+;
+; Supported features of the 'sfc' vDPA driver.
+;
+; Refer to default.ini for the full list of available driver features.
+;
+[Features]
+Linux  = Y
+x86-64 = Y
+Usage doc  = Y
diff --git a/doc/guides/vdpadevs/sfc.rst b/doc/guides/vdpadevs/sfc.rst
new file mode 100644
index 000..59f990b
--- /dev/null
+++ b/doc/guides/vdpadevs/sfc.rst
@@ -0,0 +1,97 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2021 Xilinx Corporation.
+
+Xilinx vDPA driver
+==
+
+The Xilinx vDPA (vhost data path acceleration) driver (**librte_pmd_sfc_vdpa**)
+provides support for the Xilinx SN1022 SmartNICs family of 10/25/40/50/100 Gbps
+adapters has support for latest Linux and FreeBSD operating systems.
+
+More information can be found at Xilinx website https://www.xilinx.com.
+
+
+Xilinx vDPA implementation
+--
+
+ef100 device can be configured in the net device or vDPA mode.
+Adding "class=vdpa" parameter helps to specify that this
+device is to be used in vDPA mode. If this parameter is not specified, device
+will be probed by net/sfc driver and will used as a net device.
+
+This PMD uses libefx (common/sfc_efx) code to access the device firmware.
+
+
+Supported NICs
+--
+
+- Xilinx SN1022 SmartNICs
+
+
+Features
+
+
+Features of the Xilinx vDPA driver are:
+
+- Compatibility with virtio 0.95 and 1.0
+
+
+Non-supported Features
+--
+
+- Control Queue
+- Multi queue
+- Live Migration
+
+
+Prerequisites
+-
+
+Requires firmware version: v1.0.7.0 or higher
+
+Visit `Xilinx Support Downloads `_
+to get Xilinx Utilities with the latest firmware.
+Follow instructions from Alveo SN1000 SmartNICs User Guide to
+update firmware and configure the adapter.
+
+
+Per-Device Parameters
+~
+
+The following per-device parameters can be passed via EAL PCI device
+whitelist option like "-w 02:00.0,arg1=value1,...".
+
+Case-insensitive 1/y/yes/on or 0/n/no/off may be used to specify
+boolean parameters value.
+
+- ``class`` [net|vdpa] (default **net**)
+
+  Choose the mode of operation of ef100 device.
+  **net** device will work as network device and will be probed by net/sfc 
driver.
+  **vdpa** device will work as vdpa device and will be probed by vdpa/sfc 
driver.
+  If this parameter is not specified then ef100 device will operate as network 
device.
+
+
+Dynamic Logging Parameters
+~~
+
+One may leverage EAL option "--log-level" to change default levels
+for the log types supported by the driver. The option is us

[dpdk-dev] [PATCH v2 02/10] vdpa/sfc: add support for device initialization

[Vijay Srivastava]

From: Vijay Kumar Srivastava 

Add HW initialization and vDPA device registration support.

Signed-off-by: Vijay Kumar Srivastava 
---
v2:
* Used rte_memzone_reserve_aligned for mcdi buffer allocation.
* Freeing mcdi buff when DMA map fails.
* Fixed one typo.

 doc/guides/vdpadevs/sfc.rst   |   6 +
 drivers/vdpa/sfc/meson.build  |   3 +
 drivers/vdpa/sfc/sfc_vdpa.c   |  23 +++
 drivers/vdpa/sfc/sfc_vdpa.h   |  49 +-
 drivers/vdpa/sfc/sfc_vdpa_debug.h |  21 +++
 drivers/vdpa/sfc/sfc_vdpa_hw.c| 327 ++
 drivers/vdpa/sfc/sfc_vdpa_log.h   |   3 +
 drivers/vdpa/sfc/sfc_vdpa_mcdi.c  |  74 +
 drivers/vdpa/sfc/sfc_vdpa_ops.c   | 129 +++
 drivers/vdpa/sfc/sfc_vdpa_ops.h   |  36 +
 10 files changed, 670 insertions(+), 1 deletion(-)
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_debug.h
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_hw.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_mcdi.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.h

diff --git a/doc/guides/vdpadevs/sfc.rst b/doc/guides/vdpadevs/sfc.rst
index 59f990b..abb5900 100644
--- a/doc/guides/vdpadevs/sfc.rst
+++ b/doc/guides/vdpadevs/sfc.rst
@@ -95,3 +95,9 @@ SFC vDPA PMD provides the following log types available for 
control:
   Matches a subset of per-port log types registered during runtime.
   A full name for a particular type may be obtained by appending a
   dot and a PCI device identifier (``:XX:XX.X``) to the prefix.
+
+- ``pmd.vdpa.sfc.mcdi`` (default level is **notice**)
+
+  Extra logging of the communication with the NIC's management CPU.
+  The format of the log is consumed by the netlogdecode cross-platform
+  tool. May be managed per-port, as explained above.
diff --git a/drivers/vdpa/sfc/meson.build b/drivers/vdpa/sfc/meson.build
index d916389..aac7c51 100644
--- a/drivers/vdpa/sfc/meson.build
+++ b/drivers/vdpa/sfc/meson.build
@@ -30,4 +30,7 @@ endforeach
 deps += ['common_sfc_efx', 'bus_pci']
 sources = files(
'sfc_vdpa.c',
+   'sfc_vdpa_hw.c',
+   'sfc_vdpa_mcdi.c',
+   'sfc_vdpa_ops.c',
 )
diff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c
index a6e1a9e..00fa94a 100644
--- a/drivers/vdpa/sfc/sfc_vdpa.c
+++ b/drivers/vdpa/sfc/sfc_vdpa.c
@@ -232,6 +232,19 @@ struct sfc_vdpa_adapter *
goto fail_vfio_setup;
}
 
+   sfc_vdpa_log_init(sva, "hw init");
+   if (sfc_vdpa_hw_init(sva) != 0) {
+   sfc_vdpa_err(sva, "failed to init HW %s", pci_dev->name);
+   goto fail_hw_init;
+   }
+
+   sfc_vdpa_log_init(sva, "dev init");
+   sva->ops_data = sfc_vdpa_device_init(sva, SFC_VDPA_AS_VF);
+   if (sva->ops_data == NULL) {
+   sfc_vdpa_err(sva, "failed vDPA dev init %s", pci_dev->name);
+   goto fail_dev_init;
+   }
+
pthread_mutex_lock(&sfc_vdpa_adapter_list_lock);
TAILQ_INSERT_TAIL(&sfc_vdpa_adapter_list, sva, next);
pthread_mutex_unlock(&sfc_vdpa_adapter_list_lock);
@@ -240,6 +253,12 @@ struct sfc_vdpa_adapter *
 
return 0;
 
+fail_dev_init:
+   sfc_vdpa_hw_fini(sva);
+
+fail_hw_init:
+   sfc_vdpa_vfio_teardown(sva);
+
 fail_vfio_setup:
 fail_set_log_prefix:
rte_free(sva);
@@ -266,6 +285,10 @@ struct sfc_vdpa_adapter *
TAILQ_REMOVE(&sfc_vdpa_adapter_list, sva, next);
pthread_mutex_unlock(&sfc_vdpa_adapter_list_lock);
 
+   sfc_vdpa_device_fini(sva->ops_data);
+
+   sfc_vdpa_hw_fini(sva);
+
sfc_vdpa_vfio_teardown(sva);
 
rte_free(sva);
diff --git a/drivers/vdpa/sfc/sfc_vdpa.h b/drivers/vdpa/sfc/sfc_vdpa.h
index 3b77900..046f25d 100644
--- a/drivers/vdpa/sfc/sfc_vdpa.h
+++ b/drivers/vdpa/sfc/sfc_vdpa.h
@@ -11,14 +11,38 @@
 
 #include 
 
+#include "sfc_efx.h"
+#include "sfc_efx_mcdi.h"
+#include "sfc_vdpa_debug.h"
 #include "sfc_vdpa_log.h"
+#include "sfc_vdpa_ops.h"
+
+#define SFC_VDPA_DEFAULT_MCDI_IOVA 0x2000
 
 /* Adapter private data */
 struct sfc_vdpa_adapter {
TAILQ_ENTRY(sfc_vdpa_adapter)   next;
+   /*
+* PMD setup and configuration is not thread safe. Since it is not
+* performance sensitive, it is better to guarantee thread-safety
+* and add device level lock. vDPA control operations which
+* change its state should acquire the lock.
+*/
+   rte_spinlock_t  lock;
struct rte_pci_device   *pdev;
struct rte_pci_addr pci_addr;
 
+   efx_family_tfamily;
+   efx_nic_t   *nic;
+   rte_spinlock_t  nic_lock;
+
+   efsys_bar_t mem_bar;
+
+   struct sfc_efx_mcdi mcdi;
+   size_t  mcdi_buff_size;
+
+   uint32_tmax_queue_count;
+
charlog_prefix[SFC_VDPA_LOG_PREFIX_MAX]

[dpdk-dev] [PATCH v2 03/10] vdpa/sfc: add support to get device and protocol features

[Vijay Srivastava]

From: Vijay Kumar Srivastava 

Implement vDPA ops get_feature and get_protocol_features.
This patch retrieves device supported features and enables
protocol features.

Signed-off-by: Vijay Kumar Srivastava 
---
 doc/guides/vdpadevs/features/sfc.ini | 10 
 drivers/common/sfc_efx/efsys.h   |  2 +-
 drivers/common/sfc_efx/version.map   | 10 
 drivers/vdpa/sfc/sfc_vdpa.c  | 20 
 drivers/vdpa/sfc/sfc_vdpa.h  |  2 +
 drivers/vdpa/sfc/sfc_vdpa_hw.c   | 13 ++
 drivers/vdpa/sfc/sfc_vdpa_ops.c  | 91 
 drivers/vdpa/sfc/sfc_vdpa_ops.h  |  3 ++
 8 files changed, 142 insertions(+), 9 deletions(-)

diff --git a/doc/guides/vdpadevs/features/sfc.ini 
b/doc/guides/vdpadevs/features/sfc.ini
index 71b6158..700d061 100644
--- a/doc/guides/vdpadevs/features/sfc.ini
+++ b/doc/guides/vdpadevs/features/sfc.ini
@@ -4,6 +4,16 @@
 ; Refer to default.ini for the full list of available driver features.
 ;
 [Features]
+csum   = Y
+guest csum = Y
+host tso4  = Y
+host tso6  = Y
+version 1  = Y
+mrg rxbuf  = Y
+any layout = Y
+in_order   = Y
+proto host notifier= Y
+IOMMU platform = Y
 Linux  = Y
 x86-64 = Y
 Usage doc  = Y
diff --git a/drivers/common/sfc_efx/efsys.h b/drivers/common/sfc_efx/efsys.h
index d133d61..37ec6b9 100644
--- a/drivers/common/sfc_efx/efsys.h
+++ b/drivers/common/sfc_efx/efsys.h
@@ -187,7 +187,7 @@
 
 #define EFSYS_OPT_MAE 1
 
-#define EFSYS_OPT_VIRTIO 0
+#define EFSYS_OPT_VIRTIO 1
 
 /* ID */
 
diff --git a/drivers/common/sfc_efx/version.map 
b/drivers/common/sfc_efx/version.map
index 642a62e..ec86220 100644
--- a/drivers/common/sfc_efx/version.map
+++ b/drivers/common/sfc_efx/version.map
@@ -247,6 +247,16 @@ INTERNAL {
efx_txq_nbufs;
efx_txq_size;
 
+   efx_virtio_fini;
+   efx_virtio_get_doorbell_offset;
+   efx_virtio_get_features;
+   efx_virtio_init;
+   efx_virtio_qcreate;
+   efx_virtio_qdestroy;
+   efx_virtio_qstart;
+   efx_virtio_qstop;
+   efx_virtio_verify_features;
+
sfc_efx_dev_class_get;
sfc_efx_family;
 
diff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c
index 00fa94a..4927698 100644
--- a/drivers/vdpa/sfc/sfc_vdpa.c
+++ b/drivers/vdpa/sfc/sfc_vdpa.c
@@ -43,6 +43,26 @@ struct sfc_vdpa_adapter *
return found ? sva : NULL;
 }
 
+struct sfc_vdpa_ops_data *
+sfc_vdpa_get_data_by_dev(struct rte_vdpa_device *vdpa_dev)
+{
+   bool found = false;
+   struct sfc_vdpa_adapter *sva;
+
+   pthread_mutex_lock(&sfc_vdpa_adapter_list_lock);
+
+   TAILQ_FOREACH(sva, &sfc_vdpa_adapter_list, next) {
+   if (vdpa_dev == sva->ops_data->vdpa_dev) {
+   found = true;
+   break;
+   }
+   }
+
+   pthread_mutex_unlock(&sfc_vdpa_adapter_list_lock);
+
+   return found ? sva->ops_data : NULL;
+}
+
 static int
 sfc_vdpa_vfio_setup(struct sfc_vdpa_adapter *sva)
 {
diff --git a/drivers/vdpa/sfc/sfc_vdpa.h b/drivers/vdpa/sfc/sfc_vdpa.h
index 046f25d..c10c3d3 100644
--- a/drivers/vdpa/sfc/sfc_vdpa.h
+++ b/drivers/vdpa/sfc/sfc_vdpa.h
@@ -60,6 +60,8 @@ struct sfc_vdpa_adapter {
 
 struct sfc_vdpa_adapter *
 sfc_vdpa_get_adapter_by_dev(struct rte_pci_device *pdev);
+struct sfc_vdpa_ops_data *
+sfc_vdpa_get_data_by_dev(struct rte_vdpa_device *vdpa_dev);
 
 int
 sfc_vdpa_hw_init(struct sfc_vdpa_adapter *sva);
diff --git a/drivers/vdpa/sfc/sfc_vdpa_hw.c b/drivers/vdpa/sfc/sfc_vdpa_hw.c
index 7c256ff..7a67bd8 100644
--- a/drivers/vdpa/sfc/sfc_vdpa_hw.c
+++ b/drivers/vdpa/sfc/sfc_vdpa_hw.c
@@ -278,10 +278,20 @@
if (rc != 0)
goto fail_estimate_rsrc_limits;
 
+   sfc_vdpa_log_init(sva, "init virtio");
+   rc = efx_virtio_init(enp);
+   if (rc != 0) {
+   sfc_vdpa_err(sva, "virtio init failed: %s", rte_strerror(rc));
+   goto fail_virtio_init;
+   }
+
sfc_vdpa_log_init(sva, "done");
 
return 0;
 
+fail_virtio_init:
+   efx_nic_fini(enp);
+
 fail_estimate_rsrc_limits:
 fail_nic_reset:
efx_nic_unprobe(enp);
@@ -310,6 +320,9 @@
 
sfc_vdpa_log_init(sva, "entry");
 
+   sfc_vdpa_log_init(sva, "virtio fini");
+   efx_virtio_fini(enp);
+
sfc_vdpa_log_init(sva, "unprobe nic");
efx_nic_unprobe(enp);
 
diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
index 71696be..5750944 100644
--- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
+++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
@@ -3,17 +3,31 @@
  * Copyright(c) 2020-2021 Xilinx, Inc.
  */
 
+#include 
 #include 
 #include 
 #include 
 #include 
 
+#include "efx.h"
 #include "sfc_vdpa_ops.h"
 #include "sfc_vdpa.h"
 
-/* Dummy functions for mandatory vDPA ops to pass vDPA device registration.
- * In subsequent patches these ops would be implemented.

[dpdk-dev] [PATCH v2 04/10] vdpa/sfc: get device supported max queue count

[Vijay Srivastava]

From: Vijay Kumar Srivastava 

Implement vDPA ops get_queue_num to get the maximum number
of queues supported by the device.

Signed-off-by: Vijay Kumar Srivastava 
---
 drivers/vdpa/sfc/sfc_vdpa_ops.c | 16 +---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
index 5750944..6c702e1 100644
--- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
+++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
@@ -31,10 +31,20 @@
 static int
 sfc_vdpa_get_queue_num(struct rte_vdpa_device *vdpa_dev, uint32_t *queue_num)
 {
-   RTE_SET_USED(vdpa_dev);
-   RTE_SET_USED(queue_num);
+   struct sfc_vdpa_ops_data *ops_data;
+   void *dev;
 
-   return -1;
+   ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
+   if (ops_data == NULL)
+   return -1;
+
+   dev = ops_data->dev_handle;
+   *queue_num = sfc_vdpa_adapter_by_dev_handle(dev)->max_queue_count;
+
+   sfc_vdpa_info(dev, "vDPA ops get_queue_num :: supported queue num : %d",
+ *queue_num);
+
+   return 0;
 }
 
 static int
-- 
1.8.3.1

[dpdk-dev] [PATCH v2 05/10] vdpa/sfc: add support to get VFIO device fd

[Vijay Srivastava]

From: Vijay Kumar Srivastava 

Implement vDPA ops get_vfio_device_fd to get the VFIO device fd.

Signed-off-by: Vijay Kumar Srivastava 
---
 drivers/vdpa/sfc/sfc_vdpa_ops.c | 24 
 1 file changed, 24 insertions(+)

diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
index 6c702e1..5253adb 100644
--- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
+++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
@@ -145,6 +145,29 @@
return -1;
 }
 
+static int
+sfc_vdpa_get_vfio_device_fd(int vid)
+{
+   struct rte_vdpa_device *vdpa_dev;
+   struct sfc_vdpa_ops_data *ops_data;
+   int vfio_dev_fd;
+   void *dev;
+
+   vdpa_dev = rte_vhost_get_vdpa_device(vid);
+
+   ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
+   if (ops_data == NULL)
+   return -1;
+
+   dev = ops_data->dev_handle;
+   vfio_dev_fd = sfc_vdpa_adapter_by_dev_handle(dev)->vfio_dev_fd;
+
+   sfc_vdpa_info(dev, "vDPA ops get_vfio_device_fd :: vfio fd : %d",
+ vfio_dev_fd);
+
+   return vfio_dev_fd;
+}
+
 static struct rte_vdpa_dev_ops sfc_vdpa_ops = {
.get_queue_num = sfc_vdpa_get_queue_num,
.get_features = sfc_vdpa_get_features,
@@ -153,6 +176,7 @@
.dev_close = sfc_vdpa_dev_close,
.set_vring_state = sfc_vdpa_set_vring_state,
.set_features = sfc_vdpa_set_features,
+   .get_vfio_device_fd = sfc_vdpa_get_vfio_device_fd,
 };
 
 struct sfc_vdpa_ops_data *
-- 
1.8.3.1

[dpdk-dev] [PATCH v2 06/10] vdpa/sfc: add support for dev conf and dev close ops

[Vijay Srivastava]

From: Vijay Kumar Srivastava 

Implement vDPA ops dev_conf and dev_close for DMA mapping,
interrupt and virtqueue configurations.

Signed-off-by: Vijay Kumar Srivastava 
---
v2:
* Removed redundant null check while calling free().
* Added error handling for rte_vhost_get_vhost_vring().

 drivers/vdpa/sfc/sfc_vdpa.c |   6 +
 drivers/vdpa/sfc/sfc_vdpa.h |  43 
 drivers/vdpa/sfc/sfc_vdpa_hw.c  |  69 ++
 drivers/vdpa/sfc/sfc_vdpa_ops.c | 530 ++--
 drivers/vdpa/sfc/sfc_vdpa_ops.h |  28 +++
 5 files changed, 656 insertions(+), 20 deletions(-)

diff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c
index 4927698..9ffea59 100644
--- a/drivers/vdpa/sfc/sfc_vdpa.c
+++ b/drivers/vdpa/sfc/sfc_vdpa.c
@@ -246,6 +246,8 @@ struct sfc_vdpa_ops_data *
 
sfc_vdpa_log_init(sva, "entry");
 
+   sfc_vdpa_adapter_lock_init(sva);
+
sfc_vdpa_log_init(sva, "vfio init");
if (sfc_vdpa_vfio_setup(sva) < 0) {
sfc_vdpa_err(sva, "failed to setup device %s", pci_dev->name);
@@ -280,6 +282,8 @@ struct sfc_vdpa_ops_data *
sfc_vdpa_vfio_teardown(sva);
 
 fail_vfio_setup:
+   sfc_vdpa_adapter_lock_fini(sva);
+
 fail_set_log_prefix:
rte_free(sva);
 
@@ -311,6 +315,8 @@ struct sfc_vdpa_ops_data *
 
sfc_vdpa_vfio_teardown(sva);
 
+   sfc_vdpa_adapter_lock_fini(sva);
+
rte_free(sva);
 
return 0;
diff --git a/drivers/vdpa/sfc/sfc_vdpa.h b/drivers/vdpa/sfc/sfc_vdpa.h
index c10c3d3..1bf96e7 100644
--- a/drivers/vdpa/sfc/sfc_vdpa.h
+++ b/drivers/vdpa/sfc/sfc_vdpa.h
@@ -80,10 +80,53 @@ struct sfc_vdpa_ops_data *
 void
 sfc_vdpa_dma_free(struct sfc_vdpa_adapter *sva, efsys_mem_t *esmp);
 
+int
+sfc_vdpa_dma_map(struct sfc_vdpa_ops_data *vdpa_data, bool do_map);
+
 static inline struct sfc_vdpa_adapter *
 sfc_vdpa_adapter_by_dev_handle(void *dev_handle)
 {
return (struct sfc_vdpa_adapter *)dev_handle;
 }
 
+/*
+ * Add wrapper functions to acquire/release lock to be able to remove or
+ * change the lock in one place.
+ */
+static inline void
+sfc_vdpa_adapter_lock_init(struct sfc_vdpa_adapter *sva)
+{
+   rte_spinlock_init(&sva->lock);
+}
+
+static inline int
+sfc_vdpa_adapter_is_locked(struct sfc_vdpa_adapter *sva)
+{
+   return rte_spinlock_is_locked(&sva->lock);
+}
+
+static inline void
+sfc_vdpa_adapter_lock(struct sfc_vdpa_adapter *sva)
+{
+   rte_spinlock_lock(&sva->lock);
+}
+
+static inline int
+sfc_vdpa_adapter_trylock(struct sfc_vdpa_adapter *sva)
+{
+   return rte_spinlock_trylock(&sva->lock);
+}
+
+static inline void
+sfc_vdpa_adapter_unlock(struct sfc_vdpa_adapter *sva)
+{
+   rte_spinlock_unlock(&sva->lock);
+}
+
+static inline void
+sfc_vdpa_adapter_lock_fini(__rte_unused struct sfc_vdpa_adapter *sva)
+{
+   /* Just for symmetry of the API */
+}
+
 #endif  /* _SFC_VDPA_H */
diff --git a/drivers/vdpa/sfc/sfc_vdpa_hw.c b/drivers/vdpa/sfc/sfc_vdpa_hw.c
index 7a67bd8..b473708 100644
--- a/drivers/vdpa/sfc/sfc_vdpa_hw.c
+++ b/drivers/vdpa/sfc/sfc_vdpa_hw.c
@@ -8,6 +8,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "efx.h"
 #include "sfc_vdpa.h"
@@ -109,6 +110,74 @@
memset(esmp, 0, sizeof(*esmp));
 }
 
+int
+sfc_vdpa_dma_map(struct sfc_vdpa_ops_data *ops_data, bool do_map)
+{
+   uint32_t i, j;
+   int rc;
+   struct rte_vhost_memory *vhost_mem = NULL;
+   struct rte_vhost_mem_region *mem_reg = NULL;
+   int vfio_container_fd;
+   void *dev;
+
+   dev = ops_data->dev_handle;
+   vfio_container_fd =
+   sfc_vdpa_adapter_by_dev_handle(dev)->vfio_container_fd;
+
+   rc = rte_vhost_get_mem_table(ops_data->vid, &vhost_mem);
+   if (rc < 0) {
+   sfc_vdpa_err(dev,
+"failed to get VM memory layout");
+   goto error;
+   }
+
+   for (i = 0; i < vhost_mem->nregions; i++) {
+   mem_reg = &vhost_mem->regions[i];
+
+   if (do_map) {
+   rc = rte_vfio_container_dma_map(vfio_container_fd,
+   mem_reg->host_user_addr,
+   mem_reg->guest_phys_addr,
+   mem_reg->size);
+   if (rc < 0) {
+   sfc_vdpa_err(dev,
+"DMA map failed : %s",
+rte_strerror(rte_errno));
+   goto failed_vfio_dma_map;
+   }
+   } else {
+   rc = rte_vfio_container_dma_unmap(vfio_container_fd,
+   mem_reg->host_user_addr,
+   mem_reg->guest_phys_addr,
+   mem_reg->size);
+   if (rc < 0) {
+   sfc_vdpa_err(dev,
+  

[dpdk-dev] [PATCH v2 07/10] vdpa/sfc: add support to get queue notify area info

[Vijay Srivastava]

From: Vijay Kumar Srivastava 

Implement the vDPA ops get_notify_area to get the notify
area info of the queue.

Signed-off-by: Vijay Kumar Srivastava 
---
v2:
* Added error log in sfc_vdpa_get_notify_area.

 drivers/vdpa/sfc/sfc_vdpa_ops.c | 168 ++--
 drivers/vdpa/sfc/sfc_vdpa_ops.h |   2 +
 2 files changed, 164 insertions(+), 6 deletions(-)

diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
index de1c81a..774d73e 100644
--- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
+++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
@@ -3,6 +3,8 @@
  * Copyright(c) 2020-2021 Xilinx, Inc.
  */
 
+#include 
+#include 
 #include 
 
 #include 
@@ -537,6 +539,67 @@
return 0;
 }
 
+static void *
+sfc_vdpa_notify_ctrl(void *arg)
+{
+   struct sfc_vdpa_ops_data *ops_data;
+   int vid;
+
+   ops_data = arg;
+   if (ops_data == NULL)
+   return NULL;
+
+   sfc_vdpa_adapter_lock(ops_data->dev_handle);
+
+   vid = ops_data->vid;
+
+   if (rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, true) != 0)
+   sfc_vdpa_info(ops_data->dev_handle,
+ "vDPA (%s): Notifier could not get configured",
+ ops_data->vdpa_dev->device->name);
+
+   sfc_vdpa_adapter_unlock(ops_data->dev_handle);
+
+   return NULL;
+}
+
+static int
+sfc_vdpa_setup_notify_ctrl(int vid)
+{
+   int ret;
+   struct rte_vdpa_device *vdpa_dev;
+   struct sfc_vdpa_ops_data *ops_data;
+
+   vdpa_dev = rte_vhost_get_vdpa_device(vid);
+
+   ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
+   if (ops_data == NULL) {
+   sfc_vdpa_err(ops_data->dev_handle,
+"invalid vDPA device : %p, vid : %d",
+vdpa_dev, vid);
+   return -1;
+   }
+
+   ops_data->is_notify_thread_started = false;
+
+   /*
+* Use rte_vhost_host_notifier_ctrl in a thread to avoid
+* dead lock scenario when multiple VFs are used in single vdpa
+* application and multiple VFs are passed to a single VM.
+*/
+   ret = pthread_create(&ops_data->notify_tid, NULL,
+sfc_vdpa_notify_ctrl, ops_data);
+   if (ret != 0) {
+   sfc_vdpa_err(ops_data->dev_handle,
+"failed to create notify_ctrl thread: %s",
+rte_strerror(ret));
+   return -1;
+   }
+   ops_data->is_notify_thread_started = true;
+
+   return 0;
+}
+
 static int
 sfc_vdpa_dev_config(int vid)
 {
@@ -570,18 +633,19 @@
if (rc != 0)
goto fail_vdpa_start;
 
-   sfc_vdpa_adapter_unlock(ops_data->dev_handle);
+   rc = sfc_vdpa_setup_notify_ctrl(vid);
+   if (rc != 0)
+   goto fail_vdpa_notify;
 
-   sfc_vdpa_log_init(ops_data->dev_handle, "vhost notifier ctrl");
-   if (rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, true) != 0)
-   sfc_vdpa_info(ops_data->dev_handle,
- "vDPA (%s): software relay for notify is used.",
- vdpa_dev->device->name);
+   sfc_vdpa_adapter_unlock(ops_data->dev_handle);
 
sfc_vdpa_log_init(ops_data->dev_handle, "done");
 
return 0;
 
+fail_vdpa_notify:
+   sfc_vdpa_stop(ops_data);
+
 fail_vdpa_start:
sfc_vdpa_close(ops_data);
 
@@ -594,6 +658,7 @@
 static int
 sfc_vdpa_dev_close(int vid)
 {
+   int ret;
struct rte_vdpa_device *vdpa_dev;
struct sfc_vdpa_ops_data *ops_data;
 
@@ -608,6 +673,23 @@
}
 
sfc_vdpa_adapter_lock(ops_data->dev_handle);
+   if (ops_data->is_notify_thread_started == true) {
+   void *status;
+   ret = pthread_cancel(ops_data->notify_tid);
+   if (ret != 0) {
+   sfc_vdpa_err(ops_data->dev_handle,
+"failed to cancel notify_ctrl thread: %s",
+rte_strerror(ret));
+   }
+
+   ret = pthread_join(ops_data->notify_tid, &status);
+   if (ret != 0) {
+   sfc_vdpa_err(ops_data->dev_handle,
+"failed to join terminated notify_ctrl 
thread: %s",
+rte_strerror(ret));
+   }
+   }
+   ops_data->is_notify_thread_started = false;
 
sfc_vdpa_stop(ops_data);
sfc_vdpa_close(ops_data);
@@ -658,6 +740,79 @@
return vfio_dev_fd;
 }
 
+static int
+sfc_vdpa_get_notify_area(int vid, int qid, uint64_t *offset, uint64_t *size)
+{
+   int ret;
+   efx_nic_t *nic;
+   int vfio_dev_fd;
+   efx_rc_t rc;
+   unsigned int bar_offset;
+   struct rte_vdpa_device *vdpa_dev;
+   struct sfc_vdpa_ops_data *ops_data;
+   struct vfio_region_info reg = { .argsz = sizeof(reg) };
+   const efx_nic_cfg_t *enc

[dpdk-dev] [PATCH v2 08/10] vdpa/sfc: add support for MAC filter config

[Vijay Srivastava]

From: Vijay Kumar Srivastava 

Add support for unicast and broadcast MAC filter configuration.

Signed-off-by: Vijay Kumar Srivastava 
---
 doc/guides/vdpadevs/sfc.rst|   4 ++
 drivers/vdpa/sfc/meson.build   |   1 +
 drivers/vdpa/sfc/sfc_vdpa.c|  32 +
 drivers/vdpa/sfc/sfc_vdpa.h|  30 
 drivers/vdpa/sfc/sfc_vdpa_filter.c | 144 +
 drivers/vdpa/sfc/sfc_vdpa_hw.c |  10 +++
 drivers/vdpa/sfc/sfc_vdpa_ops.c|  17 +
 7 files changed, 238 insertions(+)
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_filter.c

diff --git a/doc/guides/vdpadevs/sfc.rst b/doc/guides/vdpadevs/sfc.rst
index abb5900..ae5ef42 100644
--- a/doc/guides/vdpadevs/sfc.rst
+++ b/doc/guides/vdpadevs/sfc.rst
@@ -71,6 +71,10 @@ boolean parameters value.
   **vdpa** device will work as vdpa device and will be probed by vdpa/sfc 
driver.
   If this parameter is not specified then ef100 device will operate as network 
device.
 
+- ``mac`` [mac address]
+
+  Configures MAC address which would be used to setup MAC filters.
+
 
 Dynamic Logging Parameters
 ~~
diff --git a/drivers/vdpa/sfc/meson.build b/drivers/vdpa/sfc/meson.build
index aac7c51..f69cba9 100644
--- a/drivers/vdpa/sfc/meson.build
+++ b/drivers/vdpa/sfc/meson.build
@@ -33,4 +33,5 @@ sources = files(
'sfc_vdpa_hw.c',
'sfc_vdpa_mcdi.c',
'sfc_vdpa_ops.c',
+   'sfc_vdpa_filter.c',
 )
diff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c
index 9ffea59..012616b 100644
--- a/drivers/vdpa/sfc/sfc_vdpa.c
+++ b/drivers/vdpa/sfc/sfc_vdpa.c
@@ -8,7 +8,9 @@
 #include 
 
 #include 
+#include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -202,6 +204,31 @@ struct sfc_vdpa_ops_data *
return (ret < 0) ? RTE_LOGTYPE_PMD : ret;
 }
 
+static int
+sfc_vdpa_kvargs_parse(struct sfc_vdpa_adapter *sva)
+{
+   struct rte_pci_device *pci_dev = sva->pdev;
+   struct rte_devargs *devargs = pci_dev->device.devargs;
+   /*
+* To get the device class a mandatory param 'class' is being
+* used so included SFC_EFX_KVARG_DEV_CLASS in the param list.
+*/
+   const char **params = (const char *[]){
+   RTE_DEVARGS_KEY_CLASS,
+   SFC_VDPA_MAC_ADDR,
+   NULL,
+   };
+
+   if (devargs == NULL)
+   return 0;
+
+   sva->kvargs = rte_kvargs_parse(devargs->args, params);
+   if (sva->kvargs == NULL)
+   return -EINVAL;
+
+   return 0;
+}
+
 static struct rte_pci_id pci_id_sfc_vdpa_efx_map[] = {
{ RTE_PCI_DEVICE(EFX_PCI_VENID_XILINX, EFX_PCI_DEVID_RIVERHEAD_VF) },
{ .vendor_id = 0, /* sentinel */ },
@@ -244,6 +271,10 @@ struct sfc_vdpa_ops_data *
if (ret != 0)
goto fail_set_log_prefix;
 
+   ret = sfc_vdpa_kvargs_parse(sva);
+   if (ret != 0)
+   goto fail_kvargs_parse;
+
sfc_vdpa_log_init(sva, "entry");
 
sfc_vdpa_adapter_lock_init(sva);
@@ -284,6 +315,7 @@ struct sfc_vdpa_ops_data *
 fail_vfio_setup:
sfc_vdpa_adapter_lock_fini(sva);
 
+fail_kvargs_parse:
 fail_set_log_prefix:
rte_free(sva);
 
diff --git a/drivers/vdpa/sfc/sfc_vdpa.h b/drivers/vdpa/sfc/sfc_vdpa.h
index 1bf96e7..dbd099f 100644
--- a/drivers/vdpa/sfc/sfc_vdpa.h
+++ b/drivers/vdpa/sfc/sfc_vdpa.h
@@ -17,8 +17,29 @@
 #include "sfc_vdpa_log.h"
 #include "sfc_vdpa_ops.h"
 
+#define SFC_VDPA_MAC_ADDR  "mac"
 #define SFC_VDPA_DEFAULT_MCDI_IOVA 0x2000
 
+/* Broadcast & Unicast MAC filters are supported */
+#define SFC_MAX_SUPPORTED_FILTERS  2
+
+/*
+ * Get function-local index of the associated VI from the
+ * virtqueue number. Queue 0 is reserved for MCDI
+ */
+#define SFC_VDPA_GET_VI_INDEX(vq_num) (((vq_num) / 2) + 1)
+
+enum sfc_vdpa_filter_type {
+   SFC_VDPA_BCAST_MAC_FILTER = 0,
+   SFC_VDPA_UCAST_MAC_FILTER = 1,
+   SFC_VDPA_FILTER_NTYPE
+};
+
+typedef struct sfc_vdpa_filter_s {
+   int filter_cnt;
+   efx_filter_spec_t   spec[SFC_MAX_SUPPORTED_FILTERS];
+} sfc_vdpa_filter_t;
+
 /* Adapter private data */
 struct sfc_vdpa_adapter {
TAILQ_ENTRY(sfc_vdpa_adapter)   next;
@@ -32,6 +53,8 @@ struct sfc_vdpa_adapter {
struct rte_pci_device   *pdev;
struct rte_pci_addr pci_addr;
 
+   struct rte_kvargs   *kvargs;
+
efx_family_tfamily;
efx_nic_t   *nic;
rte_spinlock_t  nic_lock;
@@ -46,6 +69,8 @@ struct sfc_vdpa_adapter {
charlog_prefix[SFC_VDPA_LOG_PREFIX_MAX];
uint32_tlogtype_main;
 
+   sfc_vdpa_filter_t   filters;
+
int vfio_group_fd;
int vfio_dev_fd;
int

[dpdk-dev] [PATCH v2 09/10] vdpa/sfc: add support to set vring state

[Vijay Srivastava]

From: Vijay Kumar Srivastava 

Implements vDPA ops set_vring_state to configure vring state.

Signed-off-by: Vijay Kumar Srivastava 
---
 drivers/vdpa/sfc/sfc_vdpa_ops.c | 54 ++---
 1 file changed, 50 insertions(+), 4 deletions(-)

diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
index 8551b65..3430643 100644
--- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
+++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
@@ -719,11 +719,57 @@
 static int
 sfc_vdpa_set_vring_state(int vid, int vring, int state)
 {
-   RTE_SET_USED(vid);
-   RTE_SET_USED(vring);
-   RTE_SET_USED(state);
+   struct sfc_vdpa_ops_data *ops_data;
+   struct rte_vdpa_device *vdpa_dev;
+   efx_rc_t rc;
+   int vring_max;
+   void *dev;
 
-   return -1;
+   vdpa_dev = rte_vhost_get_vdpa_device(vid);
+
+   ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
+   if (ops_data == NULL)
+   return -1;
+
+   dev = ops_data->dev_handle;
+
+   sfc_vdpa_info(dev,
+ "vDPA ops set_vring_state: vid: %d, vring: %d, state:%d",
+ vid, vring, state);
+
+   vring_max = (sfc_vdpa_adapter_by_dev_handle(dev)->max_queue_count * 2);
+
+   if (vring < 0 || vring > vring_max) {
+   sfc_vdpa_err(dev, "received invalid vring id : %d to set state",
+vring);
+   return -1;
+   }
+
+   /*
+* Skip if device is not yet started. virtqueues state can be
+* changed once it is created and other configurations are done.
+*/
+   if (ops_data->state != SFC_VDPA_STATE_STARTED)
+   return 0;
+
+   if (ops_data->vq_cxt[vring].enable == state)
+   return 0;
+
+   if (state == 0) {
+   rc = sfc_vdpa_virtq_stop(ops_data, vring);
+   if (rc != 0) {
+   sfc_vdpa_err(dev, "virtqueue stop failed: %s",
+rte_strerror(rc));
+   }
+   } else {
+   rc = sfc_vdpa_virtq_start(ops_data, vring);
+   if (rc != 0) {
+   sfc_vdpa_err(dev, "virtqueue start failed: %s",
+rte_strerror(rc));
+   }
+   }
+
+   return rc;
 }
 
 static int
-- 
1.8.3.1

[dpdk-dev] [PATCH v2 10/10] vdpa/sfc: set a multicast filter during vDPA init

[Vijay Srivastava]

From: Vijay Kumar Srivastava 

Insert unknown multicast filter to allow IPv6 neighbor discovery

Signed-off-by: Vijay Kumar Srivastava 
---
 drivers/vdpa/sfc/sfc_vdpa.h|  3 ++-
 drivers/vdpa/sfc/sfc_vdpa_filter.c | 19 +--
 2 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/drivers/vdpa/sfc/sfc_vdpa.h b/drivers/vdpa/sfc/sfc_vdpa.h
index dbd099f..bedc76c 100644
--- a/drivers/vdpa/sfc/sfc_vdpa.h
+++ b/drivers/vdpa/sfc/sfc_vdpa.h
@@ -21,7 +21,7 @@
 #define SFC_VDPA_DEFAULT_MCDI_IOVA 0x2000
 
 /* Broadcast & Unicast MAC filters are supported */
-#define SFC_MAX_SUPPORTED_FILTERS  2
+#define SFC_MAX_SUPPORTED_FILTERS  3
 
 /*
  * Get function-local index of the associated VI from the
@@ -32,6 +32,7 @@
 enum sfc_vdpa_filter_type {
SFC_VDPA_BCAST_MAC_FILTER = 0,
SFC_VDPA_UCAST_MAC_FILTER = 1,
+   SFC_VDPA_MCAST_DST_FILTER = 2,
SFC_VDPA_FILTER_NTYPE
 };
 
diff --git a/drivers/vdpa/sfc/sfc_vdpa_filter.c 
b/drivers/vdpa/sfc/sfc_vdpa_filter.c
index 03b6a5d..74204d3 100644
--- a/drivers/vdpa/sfc/sfc_vdpa_filter.c
+++ b/drivers/vdpa/sfc/sfc_vdpa_filter.c
@@ -39,8 +39,12 @@
spec->efs_flags = EFX_FILTER_FLAG_RX;
spec->efs_dmaq_id = qid;
 
-   rc = efx_filter_spec_set_eth_local(spec, EFX_FILTER_SPEC_VID_UNSPEC,
-  eth_addr);
+   if (eth_addr == NULL)
+   rc = efx_filter_spec_set_mc_def(spec);
+   else
+   rc = efx_filter_spec_set_eth_local(spec,
+  EFX_FILTER_SPEC_VID_UNSPEC,
+  eth_addr);
if (rc != 0)
return rc;
 
@@ -114,6 +118,17 @@ int sfc_vdpa_filter_config(struct sfc_vdpa_ops_data 
*ops_data)
else
sva->filters.filter_cnt++;
 
+   sfc_vdpa_log_init(sva, "insert unknown mcast filter");
+   spec = &sva->filters.spec[SFC_VDPA_MCAST_DST_FILTER];
+
+   rc = sfc_vdpa_set_mac_filter(nic, spec, qid, NULL);
+   if (rc != 0)
+   sfc_vdpa_err(sva,
+"mcast filter insertion failed: %s",
+rte_strerror(rc));
+   else
+   sva->filters.filter_cnt++;
+
sfc_vdpa_log_init(sva, "done");
 
return rc;
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v8 0/5] Support power monitor in virtio/vhost PMD

[Maxime Coquelin]

Hi Chenbo,

On 10/25/21 09:06, Xia, Chenbo wrote:

Hi Ferruh,


-Original Message-
From: Li, Miao 
Sent: Monday, October 25, 2021 10:47 PM
To: dev@dpdk.org
Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Li, Miao

Subject: [PATCH v8 0/5] Support power monitor in virtio/vhost PMD

This patchset implements rte_power_monitor API in virtio and vhost PMD
to reduce power consumption when no packet come in. This API can be
called and tested in l3fwd-power after adding vhost and virtio support
in l3fwd-power and ignoring the rx queue information check in
queue_stopped().

v8:
-rebase on lastest repo
-update the release note
-modify some titles
-update commit log
-add the fixes and stable tags


The new version LGTM. Will you pick up directly to next-net if you also think
it's good?


I will pick it in my next pull request for -rc2.

Thanks,
Maxime


Thanks,
Chenbo


--
2.25.1

[dpdk-dev] [PATCH] net/ice: fix performance issue for Rx timestamp

[Simei Su]

In Rx data path, it reads hardware registers per packet, resulting in
big performance drop. This patch improves performance from two aspects:
(1) replace per packet hardware register read by per burst.
(2) reduce hardware register read time from 3 to 2 when the low value of
time is not close to overflow.

Meanwhile, this patch refines "ice_timesync_read_rx_timestamp" and
"ice_timesync_read_tx_timestamp" API in which "ice_tstamp_convert_32b_64b"
is also used.

Fixes: 953e74e6b73a ("net/ice: enable Rx timestamp on flex descriptor")
Fixes: 646dcbe6c701 ("net/ice: support IEEE 1588 PTP")

Suggested-by: Harry van Haaren 
Signed-off-by: Simei Su 
---
 drivers/net/ice/ice_ethdev.c |  4 +--
 drivers/net/ice/ice_ethdev.h |  1 +
 drivers/net/ice/ice_rxtx.c   | 59 ++--
 drivers/net/ice/ice_rxtx.h   | 34 +++--
 4 files changed, 59 insertions(+), 39 deletions(-)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index ef6ee1c..13a7a97 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -5560,7 +5560,7 @@ ice_timesync_read_rx_timestamp(struct rte_eth_dev *dev,
rxq = dev->data->rx_queues[flags];
 
ts_high = rxq->time_high;
-   ts_ns = ice_tstamp_convert_32b_64b(hw, ts_high);
+   ts_ns = ice_tstamp_convert_32b_64b(hw, ad, 1, ts_high);
ns = rte_timecounter_update(&ad->rx_tstamp_tc, ts_ns);
*timestamp = rte_ns_to_timespec(ns);
 
@@ -5587,7 +5587,7 @@ ice_timesync_read_tx_timestamp(struct rte_eth_dev *dev,
return -1;
}
 
-   ts_ns = ice_tstamp_convert_32b_64b(hw, (tstamp >> 8) & mask);
+   ts_ns = ice_tstamp_convert_32b_64b(hw, ad, 1, (tstamp >> 8) & mask);
ns = rte_timecounter_update(&ad->tx_tstamp_tc, ts_ns);
*timestamp = rte_ns_to_timespec(ns);
 
diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h
index 599e002..0e42c4c 100644
--- a/drivers/net/ice/ice_ethdev.h
+++ b/drivers/net/ice/ice_ethdev.h
@@ -509,6 +509,7 @@ struct ice_adapter {
struct rte_timecounter rx_tstamp_tc;
struct rte_timecounter tx_tstamp_tc;
bool ptp_ena;
+   uint64_t time_hw;
 #ifdef RTE_ARCH_X86
bool rx_use_avx2;
bool rx_use_avx512;
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index c3cad2f..2d771ea 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -1581,6 +1581,9 @@ ice_rx_scan_hw_ring(struct ice_rx_queue *rxq)
if (!(stat_err0 & (1 << ICE_RX_FLEX_DESC_STATUS0_DD_S)))
return 0;
 
+   if (rxq->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP)
+   rxq->hw_register_set = 1;
+
/**
 * Scan LOOK_AHEAD descriptors at a time to determine which
 * descriptors reference packets that are ready to be received.
@@ -1614,15 +1617,15 @@ ice_rx_scan_hw_ring(struct ice_rx_queue *rxq)
ice_rxd_to_vlan_tci(mb, &rxdp[j]);
rxd_to_pkt_fields_ops[rxq->rxdid](rxq, mb, &rxdp[j]);
 #ifndef RTE_LIBRTE_ICE_16BYTE_RX_DESC
-   if (rxq->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) {
-   ts_ns = ice_tstamp_convert_32b_64b(hw,
+   if (ice_timestamp_dynflag > 0) {
+   ts_ns = ice_tstamp_convert_32b_64b(hw, ad,
+   rxq->hw_register_set,

rte_le_to_cpu_32(rxdp[j].wb.flex_ts.ts_high));
-   if (ice_timestamp_dynflag > 0) {
-   *RTE_MBUF_DYNFIELD(mb,
-   ice_timestamp_dynfield_offset,
-   rte_mbuf_timestamp_t *) = ts_ns;
-   mb->ol_flags |= ice_timestamp_dynflag;
-   }
+   rxq->hw_register_set = 0;
+   *RTE_MBUF_DYNFIELD(mb,
+   ice_timestamp_dynfield_offset,
+   rte_mbuf_timestamp_t *) = ts_ns;
+   mb->ol_flags |= ice_timestamp_dynflag;
}
 
if (ad->ptp_ena && ((mb->packet_type &
@@ -1822,6 +1825,10 @@ ice_recv_scattered_pkts(void *rx_queue,
uint64_t ts_ns;
struct ice_adapter *ad = rxq->vsi->adapter;
 #endif
+
+   if (rxq->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP)
+   rxq->hw_register_set = 1;
+
while (nb_rx < nb_pkts) {
rxdp = &rx_ring[rx_id];
rx_stat_err0 = rte_le_to_cpu_16(rxdp->wb.status_error0);
@@ -1932,15 +1939,15 @@ ice_recv_scattered_pkts(void *rx_queue,
rxd_to_pkt_fields_ops[rxq->rxdid](rxq, first_seg, &rxd);
pkt_flags = ice_rxd_error_to_pkt_flags(rx_stat_err0);
 #ifndef RTE_LIBRTE_ICE_16BYTE

Re: [dpdk-dev] [PATCH v2 00/10] vdpa/sfc: introduce Xilinx vDPA driver

[Xia, Chenbo]

> -Original Message-
> From: Vijay Srivastava 
> Sent: Thursday, October 28, 2021 3:55 PM
> To: dev@dpdk.org
> Cc: maxime.coque...@redhat.com; Xia, Chenbo ;
> andrew.rybche...@oktetlabs.ru; Vijay Srivastava 
> Subject: [PATCH v2 00/10] vdpa/sfc: introduce Xilinx vDPA driver
> 
> This patch series introduces vDPA driver for Xilinx devices.
> The Xilinx vDPA (vhost data path acceleration) provides
> support for the Xilinx SN1022 SmartNICs.
> 
> Vijay Kumar Srivastava (10):
>   vdpa/sfc: introduce Xilinx vDPA driver
>   vdpa/sfc: add support for device initialization
>   vdpa/sfc: add support to get device and protocol features
>   vdpa/sfc: get device supported max queue count
>   vdpa/sfc: add support to get VFIO device fd
>   vdpa/sfc: add support for dev conf and dev close ops
>   vdpa/sfc: add support to get queue notify area info
>   vdpa/sfc: add support for MAC filter config
>   vdpa/sfc: add support to set vring state
>   vdpa/sfc: set a multicast filter during vDPA init
> 
> 1.8.3.1

I remember Maxime added R-by in some patches? And Andrew also acked
the whole series?

If yes, you should add those tags in new version.

Thanks,
Chenbo

Re: [dpdk-dev] [PATCH v2 1/3] eventdev/eth_rx: add queue stats get and reset APIs

[Jayatheerthan, Jay]

> -Original Message-
> From: Naga Harish K, S V 
> Sent: Thursday, October 28, 2021 12:37 PM
> To: jer...@marvell.com; Jayatheerthan, Jay 
> Cc: dev@dpdk.org
> Subject: [PATCH v2 1/3] eventdev/eth_rx: add queue stats get and reset APIs
> 
> This patch adds new api ``rte_event_eth_rx_adapter_queue_stats_get`` to
> retrieve queue stats. The queue stats are in the format
> ``struct rte_event_eth_rx_adapter_queue_stats``.
> 
> For resetting the queue stats,
> ``rte_event_eth_rx_adapter_queue_stats_reset`` api is added.
> 
> The adapter stats_get and stats_reset apis are also updated to
> handle queue level event buffer use case.
> 
> Signed-off-by: Naga Harish K S V 
> ---
> v2:
> * added pmd callback support for adapter queue_stats_get and
>   queue_stats_reset apis.
> ---
>  .../prog_guide/event_ethernet_rx_adapter.rst  |  11 +
>  lib/eventdev/eventdev_pmd.h   |  52 
>  lib/eventdev/rte_event_eth_rx_adapter.c   | 268 +++---
>  lib/eventdev/rte_event_eth_rx_adapter.h   |  66 +
>  lib/eventdev/version.map  |   2 +
>  5 files changed, 356 insertions(+), 43 deletions(-)
> 
> diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst 
> b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
> index 8b58130fc5..67b11e1563 100644
> --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
> +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
> @@ -166,6 +166,17 @@ flags for handling received packets, event queue 
> identifier, scheduler type,
>  event priority, polling frequency of the receive queue and flow identifier
>  in struct ``rte_event_eth_rx_adapter_queue_conf``.
> 
> +Getting and resetting Adapter queue stats
> +~
> +
> +The ``rte_event_eth_rx_adapter_queue_stats_get()`` function reports
> +adapter queue counters defined in struct 
> ``rte_event_eth_rx_adapter_queue_stats``.
> +This function reports queue level stats only when queue level event buffer is
> +used otherwise it returns -EINVAL.
> +
> +The ``rte_event_eth_rx_adapter_queue_stats_reset`` function can be used to
> +reset queue level stats when queue level event buffer is in use.
> +
>  Interrupt Based Rx Queues
>  ~~
> 
> diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h
> index d009e24309..3ba49d1fd4 100644
> --- a/lib/eventdev/eventdev_pmd.h
> +++ b/lib/eventdev/eventdev_pmd.h
> @@ -749,6 +749,53 @@ typedef int (*eventdev_eth_rx_adapter_stats_get)
>  typedef int (*eventdev_eth_rx_adapter_stats_reset)
>   (const struct rte_eventdev *dev,
>   const struct rte_eth_dev *eth_dev);
> +
> +struct rte_event_eth_rx_adapter_queue_stats;
> +
> +/**
> + * Retrieve ethernet Rx adapter queue statistics.
> + *
> + * @param dev
> + *   Event device pointer
> + *
> + * @param eth_dev
> + *   Ethernet device pointer
> + *
> + * @param rx_queue_id
> + *  Ethernet device receive queue index.
> + *
> + * @param[out] q_stats
> + *   Pointer to queue stats structure
> + *
> + * @return
> + *   Return 0 on success.
> + */
> +typedef int (*eventdev_eth_rx_adapter_q_stats_get)
> + (const struct rte_eventdev *dev,
> +  const struct rte_eth_dev *eth_dev,
> +  uint16_t rx_queue_id,
> +  struct rte_event_eth_rx_adapter_queue_stats *q_stats);
> +
> +/**
> + * Reset ethernet Rx adapter queue statistics.
> + *
> + * @param dev
> + *   Event device pointer
> + *
> + * @param eth_dev
> + *   Ethernet device pointer
> + *
> + * @param rx_queue_id
> + *  Ethernet device receive queue index.
> + *
> + * @return
> + *   Return 0 on success.
> + */
> +typedef int (*eventdev_eth_rx_adapter_q_stats_reset)
> + (const struct rte_eventdev *dev,
> +  const struct rte_eth_dev *eth_dev,
> +  uint16_t rx_queue_id);
> +
>  /**
>   * Start eventdev selftest.
>   *
> @@ -1224,6 +1271,11 @@ struct eventdev_ops {
>   eventdev_crypto_adapter_stats_reset crypto_adapter_stats_reset;
>   /**< Reset crypto stats */
> 
> + eventdev_eth_rx_adapter_q_stats_get eth_rx_adapter_queue_stats_get;
> + /**< Get ethernet Rx queue stats */
> + eventdev_eth_rx_adapter_q_stats_reset eth_rx_adapter_queue_stats_reset;
> + /**< Reset ethernet Rx queue stats */
> +
>   eventdev_eth_tx_adapter_caps_get_t eth_tx_adapter_caps_get;
>   /**< Get ethernet Tx adapter capabilities */
> 
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c 
> b/lib/eventdev/rte_event_eth_rx_adapter.c
> index a175c61551..31bbceb6c8 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -245,6 +245,10 @@ struct eth_rx_queue_info {
>   uint64_t event;
>   struct eth_rx_vector_data vector_data;
>   struct eth_event_enqueue_buffer *event_buf;
> + /* use adapter stats struct for queue level stats,
> +  *

Re: [dpdk-dev] [PATCH v2 00/10] vdpa/sfc: introduce Xilinx vDPA driver

[Maxime Coquelin]

On 10/28/21 10:08, Xia, Chenbo wrote:

-Original Message-
From: Vijay Srivastava 
Sent: Thursday, October 28, 2021 3:55 PM
To: dev@dpdk.org
Cc: maxime.coque...@redhat.com; Xia, Chenbo ;
andrew.rybche...@oktetlabs.ru; Vijay Srivastava 
Subject: [PATCH v2 00/10] vdpa/sfc: introduce Xilinx vDPA driver

This patch series introduces vDPA driver for Xilinx devices.
The Xilinx vDPA (vhost data path acceleration) provides
support for the Xilinx SN1022 SmartNICs.

Vijay Kumar Srivastava (10):
   vdpa/sfc: introduce Xilinx vDPA driver
   vdpa/sfc: add support for device initialization
   vdpa/sfc: add support to get device and protocol features
   vdpa/sfc: get device supported max queue count
   vdpa/sfc: add support to get VFIO device fd
   vdpa/sfc: add support for dev conf and dev close ops
   vdpa/sfc: add support to get queue notify area info
   vdpa/sfc: add support for MAC filter config
   vdpa/sfc: add support to set vring state
   vdpa/sfc: set a multicast filter during vDPA init

1.8.3.1


I remember Maxime added R-by in some patches? And Andrew also acked
the whole series?

If yes, you should add those tags in new version.


Agree with Chenbo, but I'd like to add that it should be done only on
patches that were not significantly reworked.

Maxime

Thanks,
Chenbo

Re: [dpdk-dev] [PATCH v2 1/1] doc: clarify VFIO doc for built-in modules

[David Marchand]

On Wed, Oct 27, 2021 at 5:39 PM Anatoly Burakov
 wrote:
>
> Currently, the documentation only contains instructions for enabling
> SRIOV support for VFIO compiled as a module, but doesn't have any
> instructions on how to do the same for cases where VFIO is built-in.
> Add these instructions.
>
> Signed-off-by: Anatoly Burakov 
> Acked-by: Bruce Richardson 
> Acked-by: Bernard Iremonger 

Applied, thanks.


-- 
David Marchand

Re: [dpdk-dev] [PATCH v1 1/1] vfio: add page-by-page mapping API

[David Marchand]

On Wed, Sep 29, 2021 at 12:19 PM Burakov, Anatoly
 wrote:
> > @@ -2179,7 +2208,29 @@ rte_vfio_container_dma_map(int container_fd, 
> > uint64_t vaddr, uint64_t iova,
> >   return -1;
> >   }
> >
> > - return container_dma_map(vfio_cfg, vaddr, iova, len);
> > + /* not having page size means we map entire segment */
> > + return container_dma_map(vfio_cfg, vaddr, iova, len, 0);
> > +}
> > +
> > +int
> > +rte_vfio_container_dma_map_paged(int container_fd, uint64_t vaddr,
> > + uint64_t iova, uint64_t len, uint64_t pagesz)
> > +{
> > + struct vfio_config *vfio_cfg;
> > +
> > + if (len == 0 || pagesz == 0 || !rte_is_power_of_2(pagesz) ||
> > + (len % pagesz) != 0) {
>
> This should also check if VA/IOVA is page-aligned. Will fix in v2.

Can you send v2?
Thanks.

-- 
David Marchand

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

[David Marchand]

On Wed, Sep 22, 2021 at 1:31 PM Xia, Chenbo  wrote:
>
> > -Original Message-
> > From: Yigit, Ferruh 
> > Sent: Wednesday, September 22, 2021 5:27 PM
> > To: Xia, Chenbo ; Burakov, Anatoly
> > ; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values 
> > consistent
> >
> > On 9/22/2021 4:30 AM, Xia, Chenbo wrote:
> > > Hi Anatoly,
> > >
> > >> -Original Message-
> > >> From: dev  On Behalf Of Anatoly Burakov
> > >> Sent: Thursday, September 16, 2021 6:37 PM
> > >> To: dev@dpdk.org
> > >> Subject: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values 
> > >> consistent
> > >>
> > >> Currently, when VFIO support is not compiled, FreeBSD and Linux have
> > >> different return values. Fix Linux implementation to follow FreeBSD one.
> > >>
> > >> Signed-off-by: Anatoly Burakov 
> > >> ---
> > >>
> > >> Notes:
> > >> Current minimum support Linux kernel is 4.4, and Meson build file 
> > >> sets
> > the
> > >
> > > Do you mean currently DPDK support linux >= 4.4? I am not aware of this,
> > could you
> > > show me where it is defined?
> > >
> >
> > https://git.dpdk.org/dpdk/tree/doc/guides/linux_gsg/sys_reqs.rst?h=v21.08#n124
> >
> > Commit d2feae68bf30 ("doc: update minimum supported Linux kernel")
>
> Thanks Ferruh!
>
> About removing the fallback or not, if we decide to remove, maybe for other 
> files
> that check linux kernel version, we also need to change some check because we 
> are
> assuming kernel version >= 4.4 here. If that's a strong requirement, I'll 
> vote for
> yes...

>From those comments, it is unclear I can merge this series.
Anatoly?


Thanks.

-- 
David Marchand

Re: [dpdk-dev] [PATCH v2 01/10] vdpa/sfc: introduce Xilinx vDPA driver

[Xia, Chenbo]

Hi Vijay,

> -Original Message-
> From: Vijay Srivastava 
> Sent: Thursday, October 28, 2021 3:55 PM
> To: dev@dpdk.org
> Cc: maxime.coque...@redhat.com; Xia, Chenbo ;
> andrew.rybche...@oktetlabs.ru; Vijay Kumar Srivastava 
> Subject: [PATCH v2 01/10] vdpa/sfc: introduce Xilinx vDPA driver
> 
> From: Vijay Kumar Srivastava 
> 
> Add new vDPA PMD to support vDPA operation by Xilinx devices.
> This patch implements probe and remove functions.
> 
> Signed-off-by: Vijay Kumar Srivastava 
> ---

I believe my comments (some grammar problems and 'use allowlist instead of
whiltelist') and Stephen's comments for v1 are not addressed.

Please address them in v1 first.

Thanks,
Chenbo

[dpdk-dev] [PATCH v6 0/4] enable protocol agnostic flow offloading in FDIR

[Junfeng Guo]

Protocol agnostic flow offloading in Flow Director is enabled by this
patch set based on the Parser Library using existing rte_flow raw API.

[PATCH v4 1/4] net/ice/base: add method to disable FDIR SWAP option.
[PATCH v4 2/4] net/ice/base: add function to set HW profile for raw flow.
[PATCH v4 3/4] app/testpmd: update Max RAW pattern size to 512.
[PATCH v4 4/4] net/ice: enable protocol agnostic flow offloading in FDIR.

Junfeng Guo (4):
  net/ice/base: add method to disable FDIR SWAP option
  net/ice/base: add function to set HW profile for raw flow
  app/testpmd: update Max RAW pattern size to 512
  net/ice: enable protocol agnostic flow offloading in FDIR

* v6:
Removed redundant code.

* v5:
Optimized some code logic.

* v4:
Added list to check inputset conflict.

* v3:
Added necessary base code for raw flow in FDIR.

* v2:
Enabled vxlan port add for raw flow and updated commit message

 app/test-pmd/cmdline_flow.c|   2 +-
 doc/guides/rel_notes/release_21_11.rst |   1 +
 drivers/net/ice/base/ice_flex_pipe.c   |  93 -
 drivers/net/ice/base/ice_flex_pipe.h   |   6 +-
 drivers/net/ice/base/ice_flow.c|  86 -
 drivers/net/ice/base/ice_flow.h|   4 +
 drivers/net/ice/ice_ethdev.h   |  17 ++
 drivers/net/ice/ice_fdir_filter.c  | 257 +
 drivers/net/ice/ice_generic_flow.c |   7 +
 drivers/net/ice/ice_generic_flow.h |   3 +
 10 files changed, 471 insertions(+), 5 deletions(-)

-- 
2.25.1

[dpdk-dev] [PATCH v6 1/4] net/ice/base: add method to disable FDIR SWAP option

[Junfeng Guo]

The SWAP Flag in the FDIR Programming Descriptor doesn't work, thus
add a method to disable the FDIR SWAP option by setting the swap and
inset register set with certain values. The boolean fd_swap is used
to enable/disable the SWAP option.

Signed-off-by: Junfeng Guo 
---
 drivers/net/ice/base/ice_flex_pipe.c | 44 ++--
 drivers/net/ice/base/ice_flex_pipe.h |  3 +-
 drivers/net/ice/base/ice_flow.c  |  2 +-
 3 files changed, 45 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ice/base/ice_flex_pipe.c 
b/drivers/net/ice/base/ice_flex_pipe.c
index f35d59f4f5..06a233990f 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -4952,6 +4952,43 @@ ice_add_prof_attrib(struct ice_prof_map *prof, u8 ptg, 
u16 ptype,
return ICE_SUCCESS;
 }
 
+/**
+ * ice_disable_fd_swap - set register appropriately to disable FD swap
+ * @hw: pointer to the HW struct
+ * @prof_id: profile ID
+ */
+void ice_disable_fd_swap(struct ice_hw *hw, u16 prof_id)
+{
+   u8 swap_val = ICE_SWAP_VALID;
+   u8 i;
+   /* Since the SWAP Flag in the Programming Desc doesn't work,
+* here add method to disable the SWAP Option via setting
+* certain SWAP and INSET register set.
+*/
+   for (i = 0; i < hw->blk[ICE_BLK_FD].es.fvw / 4; i++) {
+   u32 raw_swap = 0;
+   u32 raw_in = 0;
+   u8 j;
+
+   for (j = 0; j < 4; j++) {
+   raw_swap |= (swap_val++) << (j * BITS_PER_BYTE);
+   raw_in |= ICE_INSET_DFLT << (j * BITS_PER_BYTE);
+   }
+
+   /* write the FDIR swap register set */
+   wr32(hw, GLQF_FDSWAP(prof_id, i), raw_swap);
+
+   ice_debug(hw, ICE_DBG_INIT, "swap wr(%d, %d): %x = %08x\n",
+   prof_id, i, GLQF_FDSWAP(prof_id, i), raw_swap);
+
+   /* write the FDIR inset register set */
+   wr32(hw, GLQF_FDINSET(prof_id, i), raw_in);
+
+   ice_debug(hw, ICE_DBG_INIT, "inset wr(%d, %d): %x = %08x\n",
+   prof_id, i, GLQF_FDINSET(prof_id, i), raw_in);
+   }
+}
+
 /**
  * ice_add_prof - add profile
  * @hw: pointer to the HW struct
@@ -4962,6 +4999,7 @@ ice_add_prof_attrib(struct ice_prof_map *prof, u8 ptg, 
u16 ptype,
  * @attr_cnt: number of elements in attrib array
  * @es: extraction sequence (length of array is determined by the block)
  * @masks: mask for extraction sequence
+ * @fd_swap: enable/disable FDIR paired src/dst fields swap option
  *
  * This function registers a profile, which matches a set of PTYPES with a
  * particular extraction sequence. While the hardware profile is allocated
@@ -4971,7 +5009,7 @@ ice_add_prof_attrib(struct ice_prof_map *prof, u8 ptg, 
u16 ptype,
 enum ice_status
 ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
 const struct ice_ptype_attributes *attr, u16 attr_cnt,
-struct ice_fv_word *es, u16 *masks)
+struct ice_fv_word *es, u16 *masks, bool fd_swap)
 {
u32 bytes = DIVIDE_AND_ROUND_UP(ICE_FLOW_PTYPE_MAX, BITS_PER_BYTE);
ice_declare_bitmap(ptgs_used, ICE_XLT1_CNT);
@@ -4991,7 +5029,7 @@ ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 
id, u8 ptypes[],
status = ice_alloc_prof_id(hw, blk, &prof_id);
if (status)
goto err_ice_add_prof;
-   if (blk == ICE_BLK_FD) {
+   if (blk == ICE_BLK_FD && fd_swap) {
/* For Flow Director block, the extraction sequence may
 * need to be altered in the case where there are paired
 * fields that have no match. This is necessary because
@@ -5002,6 +5040,8 @@ ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 
id, u8 ptypes[],
status = ice_update_fd_swap(hw, prof_id, es);
if (status)
goto err_ice_add_prof;
+   } else if (blk == ICE_BLK_FD) {
+   ice_disable_fd_swap(hw, prof_id);
}
status = ice_update_prof_masking(hw, blk, prof_id, masks);
if (status)
diff --git a/drivers/net/ice/base/ice_flex_pipe.h 
b/drivers/net/ice/base/ice_flex_pipe.h
index 9733c4b214..dd332312dd 100644
--- a/drivers/net/ice/base/ice_flex_pipe.h
+++ b/drivers/net/ice/base/ice_flex_pipe.h
@@ -61,10 +61,11 @@ bool ice_hw_ptype_ena(struct ice_hw *hw, u16 ptype);
 /* XLT2/VSI group functions */
 enum ice_status
 ice_vsig_find_vsi(struct ice_hw *hw, enum ice_block blk, u16 vsi, u16 *vsig);
+void ice_disable_fd_swap(struct ice_hw *hw, u16 prof_id);
 enum ice_status
 ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
 const struct ice_ptype_attributes *attr, u16 attr_cnt,
-struct ice_fv_word *es, u16 *masks);
+struct ice_fv_

[dpdk-dev] [PATCH v6 3/4] app/testpmd: update Max RAW pattern size to 512

[Junfeng Guo]

Update max size for pattern in struct rte_flow_item_raw to enable
protocol agnostic flow offloading.

Signed-off-by: Junfeng Guo 
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index d8218771fb..ef24710bd8 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -495,7 +495,7 @@ enum index {
 };
 
 /** Maximum size for pattern in struct rte_flow_item_raw. */
-#define ITEM_RAW_PATTERN_SIZE 40
+#define ITEM_RAW_PATTERN_SIZE 512
 
 /** Maximum size for GENEVE option data pattern in bytes. */
 #define ITEM_GENEVE_OPT_DATA_SIZE 124
-- 
2.25.1

[dpdk-dev] [PATCH v6 2/4] net/ice/base: add function to set HW profile for raw flow

[Junfeng Guo]

Based on the parser library, we can directly set HW profile and
associate the main/ctrl vsi.

Signed-off-by: Junfeng Guo 
---
 drivers/net/ice/base/ice_flex_pipe.c | 49 
 drivers/net/ice/base/ice_flex_pipe.h |  3 +
 drivers/net/ice/base/ice_flow.c  | 84 
 drivers/net/ice/base/ice_flow.h  |  4 ++
 4 files changed, 140 insertions(+)

diff --git a/drivers/net/ice/base/ice_flex_pipe.c 
b/drivers/net/ice/base/ice_flex_pipe.c
index 06a233990f..395787806b 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -6365,3 +6365,52 @@ ice_rem_prof_id_flow(struct ice_hw *hw, enum ice_block 
blk, u16 vsi, u64 hdl)
 
return status;
 }
+
+/**
+ * ice_flow_assoc_hw_prof - add profile id flow for main/ctrl VSI flow entry
+ * @hw: pointer to the HW struct
+ * @blk: HW block
+ * @dest_vsi_handle: dest VSI handle
+ * @fdir_vsi_handle: fdir programming VSI handle
+ * @id: profile id (handle)
+ *
+ * Calling this function will update the hardware tables to enable the
+ * profile indicated by the ID parameter for the VSIs specified in the VSI
+ * array. Once successfully called, the flow will be enabled.
+ */
+enum ice_status
+ice_flow_assoc_hw_prof(struct ice_hw *hw, enum ice_block blk,
+  u16 dest_vsi_handle, u16 fdir_vsi_handle, int id)
+{
+   enum ice_status status = ICE_SUCCESS;
+   u16 vsi_num;
+
+   vsi_num = ice_get_hw_vsi_num(hw, dest_vsi_handle);
+   status = ice_add_prof_id_flow(hw, blk, vsi_num, id);
+   if (status) {
+   ice_debug(hw, ICE_DBG_FLOW, "HW profile add failed for main VSI 
flow entry, %d\n",
+ status);
+   goto err_add_prof;
+   }
+
+   if (blk != ICE_BLK_FD)
+   return status;
+
+   vsi_num = ice_get_hw_vsi_num(hw, fdir_vsi_handle);
+   status = ice_add_prof_id_flow(hw, blk, vsi_num, id);
+   if (status) {
+   ice_debug(hw, ICE_DBG_FLOW, "HW profile add failed for ctrl VSI 
flow entry, %d\n",
+ status);
+   goto err_add_entry;
+   }
+
+   return status;
+
+err_add_entry:
+   vsi_num = ice_get_hw_vsi_num(hw, dest_vsi_handle);
+   ice_rem_prof_id_flow(hw, blk, vsi_num, id);
+err_add_prof:
+   ice_flow_rem_prof(hw, blk, id);
+
+   return status;
+}
diff --git a/drivers/net/ice/base/ice_flex_pipe.h 
b/drivers/net/ice/base/ice_flex_pipe.h
index dd332312dd..23ba45564a 100644
--- a/drivers/net/ice/base/ice_flex_pipe.h
+++ b/drivers/net/ice/base/ice_flex_pipe.h
@@ -76,6 +76,9 @@ enum ice_status
 ice_add_prof_id_flow(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl);
 enum ice_status
 ice_rem_prof_id_flow(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl);
+enum ice_status
+ice_flow_assoc_hw_prof(struct ice_hw *hw, enum ice_block blk,
+  u16 dest_vsi_handle, u16 fdir_vsi_handle, int id);
 enum ice_status ice_init_pkg(struct ice_hw *hw, u8 *buff, u32 len);
 enum ice_status
 ice_copy_and_init_pkg(struct ice_hw *hw, const u8 *buf, u32 len);
diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
index 77b6b130c1..f699dbbc74 100644
--- a/drivers/net/ice/base/ice_flow.c
+++ b/drivers/net/ice/base/ice_flow.c
@@ -2524,6 +2524,90 @@ ice_flow_disassoc_prof(struct ice_hw *hw, enum ice_block 
blk,
return status;
 }
 
+#define FLAG_GTP_EH_PDU_LINK   BIT_ULL(13)
+#define FLAG_GTP_EH_PDUBIT_ULL(14)
+
+#define FLAG_GTPU_MSK  \
+   (FLAG_GTP_EH_PDU | FLAG_GTP_EH_PDU_LINK)
+#define FLAG_GTPU_DW   \
+   (FLAG_GTP_EH_PDU | FLAG_GTP_EH_PDU_LINK)
+#define FLAG_GTPU_UP   \
+   (FLAG_GTP_EH_PDU)
+/**
+ * ice_flow_set_hw_prof - Set HW flow profile based on the parsed profile info
+ * @hw: pointer to the HW struct
+ * @dest_vsi_handle: dest VSI handle
+ * @fdir_vsi_handle: fdir programming VSI handle
+ * @prof: stores parsed profile info from raw flow
+ * @blk: classification stage
+ */
+enum ice_status
+ice_flow_set_hw_prof(struct ice_hw *hw, u16 dest_vsi_handle,
+u16 fdir_vsi_handle, struct ice_parser_profile *prof,
+enum ice_block blk)
+{
+   int id = ice_find_first_bit(prof->ptypes, UINT16_MAX);
+   struct ice_flow_prof_params *params;
+   u8 fv_words = hw->blk[blk].es.fvw;
+   enum ice_status status;
+   u16 vsi_num;
+   int i, idx;
+
+   params = (struct ice_flow_prof_params *)ice_malloc(hw, sizeof(*params));
+   if (!params)
+   return ICE_ERR_NO_MEMORY;
+
+   for (i = 0; i < ICE_MAX_FV_WORDS; i++) {
+   params->es[i].prot_id = ICE_PROT_INVALID;
+   params->es[i].off = ICE_FV_OFFSET_INVAL;
+   }
+
+   for (i = 0; i < prof->fv_num; i++) {
+   if (hw->blk[blk].es.reverse)
+   idx = fv_words - i - 1;
+   else
+   idx = i;
+   params->es[idx].prot_id = prof->fv[i].p

[dpdk-dev] [PATCH v6 4/4] net/ice: enable protocol agnostic flow offloading in FDIR

[Junfeng Guo]

Protocol agnostic flow offloading in Flow Director is enabled by this
patch based on the Parser Library, using existing rte_flow raw API.

Note that the raw flow requires:
1. byte string of raw target packet bits.
2. byte string of mask of target packet.

Here is an example:
FDIR matching ipv4 dst addr with 1.2.3.4 and redirect to queue 3:

flow create 0 ingress pattern raw \
pattern spec \
080045144000401001020304 \
pattern mask \
 \
/ end actions queue index 3 / mark id 3 / end

Note that mask of some key bits (e.g., 0x0800 to indicate ipv4 proto)
is optional in our cases. To avoid redundancy, we just omit the mask
of 0x0800 (with 0x) in the mask byte string example. The prefix
'0x' for the spec and mask byte (hex) strings are also omitted here.

Signed-off-by: Junfeng Guo 
---
 doc/guides/rel_notes/release_21_11.rst |   1 +
 drivers/net/ice/ice_ethdev.h   |  17 ++
 drivers/net/ice/ice_fdir_filter.c  | 257 +
 drivers/net/ice/ice_generic_flow.c |   7 +
 drivers/net/ice/ice_generic_flow.h |   3 +
 5 files changed, 285 insertions(+)

diff --git a/doc/guides/rel_notes/release_21_11.rst 
b/doc/guides/rel_notes/release_21_11.rst
index 9c13ceed1c..cc449a4340 100644
--- a/doc/guides/rel_notes/release_21_11.rst
+++ b/doc/guides/rel_notes/release_21_11.rst
@@ -167,6 +167,7 @@ New Features
 
 * **Updated Intel ice driver.**
 
+  * Added protocol agnostic flow offloading support in Flow Director.
   * Added 1PPS out support by a devargs.
   * Added IPv4 and L4 (TCP/UDP/SCTP) checksum hash support in RSS flow.
   * Added DEV_RX_OFFLOAD_TIMESTAMP support.
diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h
index 599e0028f7..441242ee89 100644
--- a/drivers/net/ice/ice_ethdev.h
+++ b/drivers/net/ice/ice_ethdev.h
@@ -318,6 +318,11 @@ struct ice_fdir_filter_conf {
uint64_t input_set_o; /* used for non-tunnel or tunnel outer fields */
uint64_t input_set_i; /* only for tunnel inner fields */
uint32_t mark_flag;
+
+   struct ice_parser_profile *prof;
+   const u8 *pkt_buf;
+   bool parser_ena;
+   u8 pkt_len;
 };
 
 #define ICE_MAX_FDIR_FILTER_NUM(1024 * 16)
@@ -487,6 +492,17 @@ struct ice_devargs {
uint8_t pps_out_ena;
 };
 
+/**
+ * Structure to store fdir fv entry.
+ */
+struct ice_fdir_prof_info {
+   struct LIST_ENTRY_TYPE l_entry;
+
+   struct ice_parser_profile prof;
+   u16 ptg;
+   u64 fdir_actived_cnt;
+};
+
 /**
  * Structure to store private data for each PF/VF instance.
  */
@@ -509,6 +525,7 @@ struct ice_adapter {
struct rte_timecounter rx_tstamp_tc;
struct rte_timecounter tx_tstamp_tc;
bool ptp_ena;
+   struct LIST_HEAD_TYPE fdir_prof_list;
 #ifdef RTE_ARCH_X86
bool rx_use_avx2;
bool rx_use_avx512;
diff --git a/drivers/net/ice/ice_fdir_filter.c 
b/drivers/net/ice/ice_fdir_filter.c
index bd627e3aa8..d5ae84b86d 100644
--- a/drivers/net/ice/ice_fdir_filter.c
+++ b/drivers/net/ice/ice_fdir_filter.c
@@ -107,6 +107,7 @@
ICE_INSET_NAT_T_ESP_SPI)
 
 static struct ice_pattern_match_item ice_fdir_pattern_list[] = {
+   {pattern_raw,   ICE_INSET_NONE, 
ICE_INSET_NONE, ICE_INSET_NONE},
{pattern_ethertype, ICE_FDIR_INSET_ETH, 
ICE_INSET_NONE, ICE_INSET_NONE},
{pattern_eth_ipv4,  
ICE_FDIR_INSET_ETH_IPV4,ICE_INSET_NONE, ICE_INSET_NONE},
{pattern_eth_ipv4_udp,  
ICE_FDIR_INSET_ETH_IPV4_UDP,ICE_INSET_NONE, ICE_INSET_NONE},
@@ -1158,6 +1159,8 @@ ice_fdir_init(struct ice_adapter *ad)
if (ret)
return ret;
 
+   INIT_LIST_HEAD(&ad->fdir_prof_list);
+
parser = &ice_fdir_parser;
 
return ice_register_parser(parser, ad);
@@ -1188,6 +1191,24 @@ ice_fdir_is_tunnel_profile(enum ice_fdir_tunnel_type 
tunnel_type)
return 0;
 }
 
+static int
+ice_fdir_add_del_raw(struct ice_pf *pf,
+struct ice_fdir_filter_conf *filter,
+bool add)
+{
+   struct ice_hw *hw = ICE_PF_TO_HW(pf);
+
+   unsigned char *pkt = (unsigned char *)pf->fdir.prg_pkt;
+   rte_memcpy(pkt, filter->pkt_buf, filter->pkt_len);
+
+   struct ice_fltr_desc desc;
+   memset(&desc, 0, sizeof(desc));
+   filter->input.comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW;
+   ice_fdir_get_prgm_desc(hw, &filter->input, &desc, add);
+
+   return ice_fdir_programming(pf, &desc);
+}
+
 static int
 ice_fdir_add_del_filter(struct ice_pf *pf,
struct ice_fdir_filter_conf *filter,
@@ -1303,6 +1324,97 @@ ice_fdir_create_filter(struct ice_adapter *ad,
struct ice_fdir_fltr_pattern key;
b

[dpdk-dev] [PATCH] ethdev: promote port ownership API as stable

[Thomas Monjalon]

The port ownership concept was introduced in ethdev in DPDK 18.02.
Not sure it is used by applications except those using failsafe or netvsc.
It can also be used by libraries or applications to sort out
how ports are controlled.

Hiding sub-ports controlled by failsafe or netvsc look to be enough
justification to promote this API as stable.

Signed-off-by: Thomas Monjalon 
---
 doc/guides/prog_guide/poll_mode_drv.rst |  6 +-
 lib/ethdev/rte_ethdev.h | 20 
 lib/ethdev/version.map  | 12 +---
 3 files changed, 10 insertions(+), 28 deletions(-)

diff --git a/doc/guides/prog_guide/poll_mode_drv.rst 
b/doc/guides/prog_guide/poll_mode_drv.rst
index 6831289844..9d081b1cba 100644
--- a/doc/guides/prog_guide/poll_mode_drv.rst
+++ b/doc/guides/prog_guide/poll_mode_drv.rst
@@ -146,14 +146,18 @@ Based on their PCI identifier, NIC ports are assigned two 
other identifiers:
 
 Port Ownership
 ~~
+
 The Ethernet devices ports can be owned by a single DPDK entity (application, 
library, PMD, process, etc).
 The ownership mechanism is controlled by ethdev APIs and allows to 
set/remove/get a port owner by DPDK entities.
-Allowing this should prevent any multiple management of Ethernet port by 
different entities.
+It prevents Ethernet ports to be managed by different entities.
 
 .. note::
 
 It is the DPDK entity responsibility to set the port owner before using it 
and to manage the port usage synchronization between different threads or 
processes.
 
+It is recommended to set port ownership early,
+like during the probing notification ``RTE_ETH_EVENT_NEW``.
+
 Device Configuration
 
 
diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 09d60351a3..154465c3ab 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -2193,9 +2193,6 @@ rte_eth_find_next_sibling(uint16_t port_id_start, 
uint16_t ref_port_id);
port_id = rte_eth_find_next_sibling(port_id + 1, ref_port_id))
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Get a new unique owner identifier.
  * An owner identifier is used to owns Ethernet devices by only one DPDK entity
  * to avoid multiple management of device by different entities.
@@ -2205,13 +2202,9 @@ rte_eth_find_next_sibling(uint16_t port_id_start, 
uint16_t ref_port_id);
  * @return
  *   Negative errno value on error, 0 on success.
  */
-__rte_experimental
 int rte_eth_dev_owner_new(uint64_t *owner_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Set an Ethernet device owner.
  *
  * @param  port_id
@@ -2221,14 +2214,10 @@ int rte_eth_dev_owner_new(uint64_t *owner_id);
  * @return
  *  Negative errno value on error, 0 on success.
  */
-__rte_experimental
 int rte_eth_dev_owner_set(const uint16_t port_id,
const struct rte_eth_dev_owner *owner);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Unset Ethernet device owner to make the device ownerless.
  *
  * @param  port_id
@@ -2238,14 +2227,10 @@ int rte_eth_dev_owner_set(const uint16_t port_id,
  * @return
  *  0 on success, negative errno value on error.
  */
-__rte_experimental
 int rte_eth_dev_owner_unset(const uint16_t port_id,
const uint64_t owner_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Remove owner from all Ethernet devices owned by a specific owner.
  *
  * @param  owner_id
@@ -2253,13 +2238,9 @@ int rte_eth_dev_owner_unset(const uint16_t port_id,
  * @return
  *  0 on success, negative errno value on error.
  */
-__rte_experimental
 int rte_eth_dev_owner_delete(const uint64_t owner_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Get the owner of an Ethernet device.
  *
  * @param  port_id
@@ -2269,7 +2250,6 @@ int rte_eth_dev_owner_delete(const uint64_t owner_id);
  * @return
  *  0 on success, negative errno value on error..
  */
-__rte_experimental
 int rte_eth_dev_owner_get(const uint16_t port_id,
struct rte_eth_dev_owner *owner);
 
diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
index c2fb0669a4..15a69e67eb 100644
--- a/lib/ethdev/version.map
+++ b/lib/ethdev/version.map
@@ -36,6 +36,11 @@ DPDK_22 {
rte_eth_dev_logtype;
rte_eth_dev_mac_addr_add;
rte_eth_dev_mac_addr_remove;
+   rte_eth_dev_owner_delete;
+   rte_eth_dev_owner_get;
+   rte_eth_dev_owner_new;
+   rte_eth_dev_owner_set;
+   rte_eth_dev_owner_unset;
rte_eth_dev_pool_ops_supported;
rte_eth_dev_priority_flow_ctrl_set;
rte_eth_dev_reset;
@@ -148,13 +153,6 @@ EXPERIMENTAL {
rte_mtr_stats_read;
rte_mtr_stats_update;
 
-   # added in 18.02
-   rte_eth_dev_owner_delete;
-   rte_eth_dev_owner_get;
-   rte_eth_dev_owner_new;
-   rte_eth

[dpdk-dev] [PATCH] ethdev: promote device removal check function as stable

[Thomas Monjalon]

The function rte_eth_dev_is_removed() was introduced in DPDK 18.02,
and is integrated in error checks of ethdev library.

It is promoted as stable ABI.

Signed-off-by: Thomas Monjalon 
---
 lib/ethdev/rte_ethdev.h | 4 
 lib/ethdev/version.map  | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 24f30b4b28..09d60351a3 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -2385,9 +2385,6 @@ int rte_eth_dev_configure(uint16_t port_id, uint16_t 
nb_rx_queue,
uint16_t nb_tx_queue, const struct rte_eth_conf *eth_conf);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Check if an Ethernet device was physically removed.
  *
  * @param port_id
@@ -2395,7 +2392,6 @@ int rte_eth_dev_configure(uint16_t port_id, uint16_t 
nb_rx_queue,
  * @return
  *   1 when the Ethernet device is removed, otherwise 0.
  */
-__rte_experimental
 int
 rte_eth_dev_is_removed(uint16_t port_id);
 
diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
index e1abe99729..c2fb0669a4 100644
--- a/lib/ethdev/version.map
+++ b/lib/ethdev/version.map
@@ -31,6 +31,7 @@ DPDK_22 {
rte_eth_dev_get_supported_ptypes;
rte_eth_dev_get_vlan_offload;
rte_eth_dev_info_get;
+   rte_eth_dev_is_removed;
rte_eth_dev_is_valid_port;
rte_eth_dev_logtype;
rte_eth_dev_mac_addr_add;
@@ -148,7 +149,6 @@ EXPERIMENTAL {
rte_mtr_stats_update;
 
# added in 18.02
-   rte_eth_dev_is_removed;
rte_eth_dev_owner_delete;
rte_eth_dev_owner_get;
rte_eth_dev_owner_new;
-- 
2.33.0

Re: [dpdk-dev] [PATCH] ethdev: promote port ownership API as stable

[Kinsella, Ray]

On 28/10/2021 09:34, Thomas Monjalon wrote:

The port ownership concept was introduced in ethdev in DPDK 18.02.
Not sure it is used by applications except those using failsafe or netvsc.
It can also be used by libraries or applications to sort out
how ports are controlled.

Hiding sub-ports controlled by failsafe or netvsc look to be enough
justification to promote this API as stable.

Signed-off-by: Thomas Monjalon 
---
  doc/guides/prog_guide/poll_mode_drv.rst |  6 +-
  lib/ethdev/rte_ethdev.h | 20 
  lib/ethdev/version.map  | 12 +---
  3 files changed, 10 insertions(+), 28 deletions(-)


Acked-by: Ray Kinsella 

Re: [dpdk-dev] [PATCH] ethdev: promote device removal check function as stable

[Kinsella, Ray]

On 28/10/2021 09:35, Thomas Monjalon wrote:

The function rte_eth_dev_is_removed() was introduced in DPDK 18.02,
and is integrated in error checks of ethdev library.

It is promoted as stable ABI.

Signed-off-by: Thomas Monjalon 
---
  lib/ethdev/rte_ethdev.h | 4 
  lib/ethdev/version.map  | 2 +-
  2 files changed, 1 insertion(+), 5 deletions(-)


Acked-by: Ray Kinsella 

[dpdk-dev] [Bug 846] ipsec build issue with gcc 11

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=846

Bug ID: 846
   Summary: ipsec build issue with gcc 11
   Product: DPDK
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: examples
  Assignee: dev@dpdk.org
  Reporter: david.march...@redhat.com
  Target Milestone: ---

The issue is probably generic, but I can see it when enabling ASan (passing
-Db_sanitize=address meson option):

FAILED: examples/dpdk-ipsec-secgw.p/ipsec-secgw_ipsec.c.o 
cc -Iexamples/dpdk-ipsec-secgw.p -Iexamples -I../../dpdk/examples
-Iexamples/ipsec-secgw -I../../dpdk/examples/ipsec-secgw -I. -I../../dpdk
-Iconfig -I../../dpdk/config -Ilib/eal/include -I../../dpdk/lib/eal/include
-Ilib/eal/linux/include -I../../dpdk/lib/eal/linux/include
-Ilib/eal/x86/include -I../../dpdk/lib/eal/x86/include -Ilib/eal/common
-I../../dpdk/lib/eal/common -Ilib/eal -I../../dpdk/lib/eal -Ilib/kvargs
-I../../dpdk/lib/kvargs -Ilib/metrics -I../../dpdk/lib/metrics -Ilib/telemetry
-I../../dpdk/lib/telemetry -Ilib/mempool -I../../dpdk/lib/mempool -Ilib/ring
-I../../dpdk/lib/ring -Ilib/net -I../../dpdk/lib/net -Ilib/mbuf
-I../../dpdk/lib/mbuf -Ilib/ethdev -I../../dpdk/lib/ethdev -Ilib/meter
-I../../dpdk/lib/meter -Ilib/cmdline -I../../dpdk/lib/cmdline -Ilib/security
-I../../dpdk/lib/security -Ilib/cryptodev -I../../dpdk/lib/cryptodev -Ilib/rcu
-I../../dpdk/lib/rcu -Ilib/lpm -I../../dpdk/lib/lpm -Ilib/hash
-I../../dpdk/lib/hash -Ilib/acl -I../../dpdk/lib/acl -Ilib/ip_frag
-I../../dpdk/lib/ip_frag -Ilib/ipsec -I../../dpdk/lib/ipsec -Ilib/eventdev
-I../../dpdk/lib/eventdev -Ilib/timer -I../../dpdk/lib/timer
-fdiagnostics-color=always -fsanitize=address -fno-omit-frame-pointer
-D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O2 -g -include rte_config.h
-Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security
-Wmissing-declarations -Wmissing-prototypes -Wnested-externs
-Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes
-Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned
-Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE
-march=nehalem -Wno-format-truncation -DALLOW_EXPERIMENTAL_API -MD -MQ
examples/dpdk-ipsec-secgw.p/ipsec-secgw_ipsec.c.o -MF
examples/dpdk-ipsec-secgw.p/ipsec-secgw_ipsec.c.o.d -o
examples/dpdk-ipsec-secgw.p/ipsec-secgw_ipsec.c.o -c
../../dpdk/examples/ipsec-secgw/ipsec.c
../../dpdk/examples/ipsec-secgw/ipsec.c: In function ‘create_inline_session’:
../../dpdk/examples/ipsec-secgw/ipsec.c:314:31: error: ‘rte_flow_validate’
reading 32 bytes from a region of size 4 [-Werror=stringop-overread]
  314 | ret = rte_flow_validate(sa->portid, &sa->attr,
  |   ^~~~
  315 | sa->pattern,
sa->action,
  |

  316 | &err);
  | ~
../../dpdk/examples/ipsec-secgw/ipsec.c:314:31: note: referencing argument 3 of
type ‘const struct rte_flow_item *’
../../dpdk/examples/ipsec-secgw/ipsec.c:314:31: error: ‘rte_flow_validate’
reading 16 bytes from a region of size 4 [-Werror=stringop-overread]
../../dpdk/examples/ipsec-secgw/ipsec.c:314:31: note: referencing argument 4 of
type ‘const struct rte_flow_action *’
In file included from ../../dpdk/lib/ethdev/rte_eth_ctrl.h:11,
 from ../../dpdk/lib/ethdev/rte_ethdev.h:1421,
 from ../../dpdk/examples/ipsec-secgw/ipsec.c:14:
../../dpdk/lib/ethdev/rte_flow.h:4043:1: note: in a call to function
‘rte_flow_validate’
 4043 | rte_flow_validate(uint16_t port_id,
  | ^
../../dpdk/examples/ipsec-secgw/ipsec.c:325:31: error: ‘rte_flow_validate’
reading 32 bytes from a region of size 4 [-Werror=stringop-overread]
  325 | ret = rte_flow_validate(sa->portid, &sa->attr,
  |   ^~~~
  326 | sa->pattern,
sa->action,
  |

  327 | &err);
  | ~
../../dpdk/examples/ipsec-secgw/ipsec.c:325:31: note: referencing argument 3 of
type ‘const struct rte_flow_item *’
../../dpdk/examples/ipsec-secgw/ipsec.c:325:31: error: ‘rte_flow_validate’
reading 16 bytes from a region of size 4 [-Werror=stringop-overread]
../../dpdk/examples/ipsec-secgw/ipsec.c:325:31: note: referencing argument 4 of
type ‘const struct rte_flow_action *’
In file included from ../../dpdk/lib/ethdev/rte_eth_ctrl.h:11,
 from ../../dpdk/lib/ethde

Re: [dpdk-dev] [dpdk-dev v7 8/9] crypto/qat: add gen specific data and function

[Power, Ciara]

>-Original Message-
>From: dev  On Behalf Of Kai Ji
>Sent: Wednesday 27 October 2021 16:51
>To: dev@dpdk.org
>Cc: Zhang, Roy Fan ; Kusztal, ArkadiuszX
>; Ji, Kai 
>Subject: [dpdk-dev] [dpdk-dev v7 8/9] crypto/qat: add gen specific data and
>function
>
>From: Fan Zhang 
>
>This patch adds the symmetric and asymmetric crypto data
>structure and function prototypes for different QAT
>generations.
>
>Signed-off-by: Arek Kusztal 
>Signed-off-by: Fan Zhang 
>Signed-off-by: Kai Ji 

Acked-by: Ciara Power 

Re: [dpdk-dev] [PATCH] ethdev: promote port ownership API as stable

[Andrew Rybchenko]

On 10/28/21 11:37 AM, Kinsella, Ray wrote:



On 28/10/2021 09:34, Thomas Monjalon wrote:

The port ownership concept was introduced in ethdev in DPDK 18.02.
Not sure it is used by applications except those using failsafe or 
netvsc.

It can also be used by libraries or applications to sort out
how ports are controlled.

Hiding sub-ports controlled by failsafe or netvsc look to be enough
justification to promote this API as stable.

Signed-off-by: Thomas Monjalon 
---
  doc/guides/prog_guide/poll_mode_drv.rst |  6 +-
  lib/ethdev/rte_ethdev.h | 20 
  lib/ethdev/version.map  | 12 +---
  3 files changed, 10 insertions(+), 28 deletions(-)


Acked-by: Ray Kinsella 


Acked-by: Andrew Rybchenko 

Re: [dpdk-dev] [PATCH] ethdev: promote device removal check function as stable

[Andrew Rybchenko]

On 10/28/21 11:38 AM, Kinsella, Ray wrote:



On 28/10/2021 09:35, Thomas Monjalon wrote:

The function rte_eth_dev_is_removed() was introduced in DPDK 18.02,
and is integrated in error checks of ethdev library.

It is promoted as stable ABI.

Signed-off-by: Thomas Monjalon 
---
  lib/ethdev/rte_ethdev.h | 4 
  lib/ethdev/version.map  | 2 +-
  2 files changed, 1 insertion(+), 5 deletions(-)


Acked-by: Ray Kinsella 


Acked-by: Andrew Rybchenko 

Re: [dpdk-dev] [PATCH] net/ice: fix performance issue for Rx timestamp

[Zhang, Qi Z]

> -Original Message-
> From: Su, Simei 
> Sent: Thursday, October 28, 2021 3:58 PM
> To: Zhang, Qi Z 
> Cc: dev@dpdk.org; Van Haaren, Harry ; Wu,
> Wenjun1 ; Su, Simei 
> Subject: [PATCH] net/ice: fix performance issue for Rx timestamp
> 
> In Rx data path, it reads hardware registers per packet, resulting in big
> performance drop. This patch improves performance from two aspects:
> (1) replace per packet hardware register read by per burst.
> (2) reduce hardware register read time from 3 to 2 when the low value of
> time is not close to overflow.
> 
> Meanwhile, this patch refines "ice_timesync_read_rx_timestamp" and
> "ice_timesync_read_tx_timestamp" API in which
> "ice_tstamp_convert_32b_64b"
> is also used.
> 
> Fixes: 953e74e6b73a ("net/ice: enable Rx timestamp on flex descriptor")
> Fixes: 646dcbe6c701 ("net/ice: support IEEE 1588 PTP")
> 
> Suggested-by: Harry van Haaren 
> Signed-off-by: Simei Su 
> ---
>  drivers/net/ice/ice_ethdev.c |  4 +--
>  drivers/net/ice/ice_ethdev.h |  1 +
>  drivers/net/ice/ice_rxtx.c   | 59 
> ++--
>  drivers/net/ice/ice_rxtx.h   | 34 +++--
>  4 files changed, 59 insertions(+), 39 deletions(-)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index
> ef6ee1c..13a7a97 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -5560,7 +5560,7 @@ ice_timesync_read_rx_timestamp(struct
> rte_eth_dev *dev,
>   rxq = dev->data->rx_queues[flags];
> 
>   ts_high = rxq->time_high;
> - ts_ns = ice_tstamp_convert_32b_64b(hw, ts_high);
> + ts_ns = ice_tstamp_convert_32b_64b(hw, ad, 1, ts_high);
>   ns = rte_timecounter_update(&ad->rx_tstamp_tc, ts_ns);
>   *timestamp = rte_ns_to_timespec(ns);
> 
> @@ -5587,7 +5587,7 @@ ice_timesync_read_tx_timestamp(struct
> rte_eth_dev *dev,
>   return -1;
>   }
> 
> - ts_ns = ice_tstamp_convert_32b_64b(hw, (tstamp >> 8) & mask);
> + ts_ns = ice_tstamp_convert_32b_64b(hw, ad, 1, (tstamp >> 8) & mask);
>   ns = rte_timecounter_update(&ad->tx_tstamp_tc, ts_ns);
>   *timestamp = rte_ns_to_timespec(ns);
> 
> diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h index
> 599e002..0e42c4c 100644
> --- a/drivers/net/ice/ice_ethdev.h
> +++ b/drivers/net/ice/ice_ethdev.h
> @@ -509,6 +509,7 @@ struct ice_adapter {
>   struct rte_timecounter rx_tstamp_tc;
>   struct rte_timecounter tx_tstamp_tc;
>   bool ptp_ena;
> + uint64_t time_hw;
>  #ifdef RTE_ARCH_X86
>   bool rx_use_avx2;
>   bool rx_use_avx512;
> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index
> c3cad2f..2d771ea 100644
> --- a/drivers/net/ice/ice_rxtx.c
> +++ b/drivers/net/ice/ice_rxtx.c
> @@ -1581,6 +1581,9 @@ ice_rx_scan_hw_ring(struct ice_rx_queue *rxq)
>   if (!(stat_err0 & (1 << ICE_RX_FLEX_DESC_STATUS0_DD_S)))
>   return 0;
> 
> + if (rxq->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP)
> + rxq->hw_register_set = 1;
> +
>   /**
>* Scan LOOK_AHEAD descriptors at a time to determine which
>* descriptors reference packets that are ready to be received.
> @@ -1614,15 +1617,15 @@ ice_rx_scan_hw_ring(struct ice_rx_queue *rxq)
>   ice_rxd_to_vlan_tci(mb, &rxdp[j]);
>   rxd_to_pkt_fields_ops[rxq->rxdid](rxq, mb, &rxdp[j]);  
> #ifndef
> RTE_LIBRTE_ICE_16BYTE_RX_DESC
> - if (rxq->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) {
> - ts_ns = ice_tstamp_convert_32b_64b(hw,
> + if (ice_timestamp_dynflag > 0) {
> + ts_ns = ice_tstamp_convert_32b_64b(hw, ad,
> + rxq->hw_register_set,
>   
> rte_le_to_cpu_32(rxdp[j].wb.flex_ts.ts_high));
> - if (ice_timestamp_dynflag > 0) {
> - *RTE_MBUF_DYNFIELD(mb,
> - ice_timestamp_dynfield_offset,
> - rte_mbuf_timestamp_t *) = ts_ns;
> - mb->ol_flags |= ice_timestamp_dynflag;
> - }
> + rxq->hw_register_set = 0;
> + *RTE_MBUF_DYNFIELD(mb,
> + ice_timestamp_dynfield_offset,
> + rte_mbuf_timestamp_t *) = ts_ns;
> + mb->ol_flags |= ice_timestamp_dynflag;
>   }
> 
>   if (ad->ptp_ena && ((mb->packet_type & @@ -1822,6 
> +1825,10
> @@ ice_recv_scattered_pkts(void *rx_queue,
>   uint64_t ts_ns;
>   struct ice_adapter *ad = rxq->vsi->adapter;  #endif
> +
> + if (rxq->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP)
> + rxq->hw_register_set = 1;
> +
>   while (nb_rx 

[dpdk-dev] [PATCH v7 0/4] enable protocol agnostic flow offloading in FDIR

[Junfeng Guo]

Protocol agnostic flow offloading in Flow Director is enabled by this
patch set based on the Parser Library using existing rte_flow raw API.

[PATCH v7 1/4] net/ice/base: add method to disable FDIR SWAP option.
[PATCH v7 2/4] net/ice/base: add function to set HW profile for raw flow.
[PATCH v7 3/4] app/testpmd: update Max RAW pattern size to 512.
[PATCH v7 4/4] net/ice: enable protocol agnostic flow offloading in FDIR.

Junfeng Guo (4):
  net/ice/base: add method to disable FDIR SWAP option
  net/ice/base: add function to set HW profile for raw flow
  app/testpmd: update Max RAW pattern size to 512
  net/ice: enable protocol agnostic flow offloading in FDIR

* v7:
Fix LIST_FOR_EACH_ENTRY logic.

* v6:
Removed redundant code.

* v5:
Optimized some code logic.

* v4:
Added list to check inputset conflict.

* v3:
Added necessary base code for raw flow in FDIR.

* v2:
Enabled vxlan port add for raw flow and updated commit message

 app/test-pmd/cmdline_flow.c|   2 +-
 doc/guides/rel_notes/release_21_11.rst |   1 +
 drivers/net/ice/base/ice_flex_pipe.c   |  93 -
 drivers/net/ice/base/ice_flex_pipe.h   |   6 +-
 drivers/net/ice/base/ice_flow.c|  86 +++-
 drivers/net/ice/base/ice_flow.h|   4 +
 drivers/net/ice/ice_ethdev.h   |  17 ++
 drivers/net/ice/ice_fdir_filter.c  | 260 +
 drivers/net/ice/ice_generic_flow.c |   7 +
 drivers/net/ice/ice_generic_flow.h |   3 +
 10 files changed, 474 insertions(+), 5 deletions(-)

-- 
2.25.1

[dpdk-dev] [PATCH v7 1/4] net/ice/base: add method to disable FDIR SWAP option

[Junfeng Guo]

The SWAP Flag in the FDIR Programming Descriptor doesn't work, thus
add a method to disable the FDIR SWAP option by setting the swap and
inset register set with certain values. The boolean fd_swap is used
to enable/disable the SWAP option.

Signed-off-by: Junfeng Guo 
---
 drivers/net/ice/base/ice_flex_pipe.c | 44 ++--
 drivers/net/ice/base/ice_flex_pipe.h |  3 +-
 drivers/net/ice/base/ice_flow.c  |  2 +-
 3 files changed, 45 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ice/base/ice_flex_pipe.c 
b/drivers/net/ice/base/ice_flex_pipe.c
index f35d59f4f5..06a233990f 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -4952,6 +4952,43 @@ ice_add_prof_attrib(struct ice_prof_map *prof, u8 ptg, 
u16 ptype,
return ICE_SUCCESS;
 }
 
+/**
+ * ice_disable_fd_swap - set register appropriately to disable FD swap
+ * @hw: pointer to the HW struct
+ * @prof_id: profile ID
+ */
+void ice_disable_fd_swap(struct ice_hw *hw, u16 prof_id)
+{
+   u8 swap_val = ICE_SWAP_VALID;
+   u8 i;
+   /* Since the SWAP Flag in the Programming Desc doesn't work,
+* here add method to disable the SWAP Option via setting
+* certain SWAP and INSET register set.
+*/
+   for (i = 0; i < hw->blk[ICE_BLK_FD].es.fvw / 4; i++) {
+   u32 raw_swap = 0;
+   u32 raw_in = 0;
+   u8 j;
+
+   for (j = 0; j < 4; j++) {
+   raw_swap |= (swap_val++) << (j * BITS_PER_BYTE);
+   raw_in |= ICE_INSET_DFLT << (j * BITS_PER_BYTE);
+   }
+
+   /* write the FDIR swap register set */
+   wr32(hw, GLQF_FDSWAP(prof_id, i), raw_swap);
+
+   ice_debug(hw, ICE_DBG_INIT, "swap wr(%d, %d): %x = %08x\n",
+   prof_id, i, GLQF_FDSWAP(prof_id, i), raw_swap);
+
+   /* write the FDIR inset register set */
+   wr32(hw, GLQF_FDINSET(prof_id, i), raw_in);
+
+   ice_debug(hw, ICE_DBG_INIT, "inset wr(%d, %d): %x = %08x\n",
+   prof_id, i, GLQF_FDINSET(prof_id, i), raw_in);
+   }
+}
+
 /**
  * ice_add_prof - add profile
  * @hw: pointer to the HW struct
@@ -4962,6 +4999,7 @@ ice_add_prof_attrib(struct ice_prof_map *prof, u8 ptg, 
u16 ptype,
  * @attr_cnt: number of elements in attrib array
  * @es: extraction sequence (length of array is determined by the block)
  * @masks: mask for extraction sequence
+ * @fd_swap: enable/disable FDIR paired src/dst fields swap option
  *
  * This function registers a profile, which matches a set of PTYPES with a
  * particular extraction sequence. While the hardware profile is allocated
@@ -4971,7 +5009,7 @@ ice_add_prof_attrib(struct ice_prof_map *prof, u8 ptg, 
u16 ptype,
 enum ice_status
 ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
 const struct ice_ptype_attributes *attr, u16 attr_cnt,
-struct ice_fv_word *es, u16 *masks)
+struct ice_fv_word *es, u16 *masks, bool fd_swap)
 {
u32 bytes = DIVIDE_AND_ROUND_UP(ICE_FLOW_PTYPE_MAX, BITS_PER_BYTE);
ice_declare_bitmap(ptgs_used, ICE_XLT1_CNT);
@@ -4991,7 +5029,7 @@ ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 
id, u8 ptypes[],
status = ice_alloc_prof_id(hw, blk, &prof_id);
if (status)
goto err_ice_add_prof;
-   if (blk == ICE_BLK_FD) {
+   if (blk == ICE_BLK_FD && fd_swap) {
/* For Flow Director block, the extraction sequence may
 * need to be altered in the case where there are paired
 * fields that have no match. This is necessary because
@@ -5002,6 +5040,8 @@ ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 
id, u8 ptypes[],
status = ice_update_fd_swap(hw, prof_id, es);
if (status)
goto err_ice_add_prof;
+   } else if (blk == ICE_BLK_FD) {
+   ice_disable_fd_swap(hw, prof_id);
}
status = ice_update_prof_masking(hw, blk, prof_id, masks);
if (status)
diff --git a/drivers/net/ice/base/ice_flex_pipe.h 
b/drivers/net/ice/base/ice_flex_pipe.h
index 9733c4b214..dd332312dd 100644
--- a/drivers/net/ice/base/ice_flex_pipe.h
+++ b/drivers/net/ice/base/ice_flex_pipe.h
@@ -61,10 +61,11 @@ bool ice_hw_ptype_ena(struct ice_hw *hw, u16 ptype);
 /* XLT2/VSI group functions */
 enum ice_status
 ice_vsig_find_vsi(struct ice_hw *hw, enum ice_block blk, u16 vsi, u16 *vsig);
+void ice_disable_fd_swap(struct ice_hw *hw, u16 prof_id);
 enum ice_status
 ice_add_prof(struct ice_hw *hw, enum ice_block blk, u64 id, u8 ptypes[],
 const struct ice_ptype_attributes *attr, u16 attr_cnt,
-struct ice_fv_word *es, u16 *masks);
+struct ice_fv_

[dpdk-dev] [PATCH v7 2/4] net/ice/base: add function to set HW profile for raw flow

[Junfeng Guo]

Based on the parser library, we can directly set HW profile and
associate the main/ctrl vsi.

Signed-off-by: Junfeng Guo 
---
 drivers/net/ice/base/ice_flex_pipe.c | 49 
 drivers/net/ice/base/ice_flex_pipe.h |  3 +
 drivers/net/ice/base/ice_flow.c  | 84 
 drivers/net/ice/base/ice_flow.h  |  4 ++
 4 files changed, 140 insertions(+)

diff --git a/drivers/net/ice/base/ice_flex_pipe.c 
b/drivers/net/ice/base/ice_flex_pipe.c
index 06a233990f..395787806b 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -6365,3 +6365,52 @@ ice_rem_prof_id_flow(struct ice_hw *hw, enum ice_block 
blk, u16 vsi, u64 hdl)
 
return status;
 }
+
+/**
+ * ice_flow_assoc_hw_prof - add profile id flow for main/ctrl VSI flow entry
+ * @hw: pointer to the HW struct
+ * @blk: HW block
+ * @dest_vsi_handle: dest VSI handle
+ * @fdir_vsi_handle: fdir programming VSI handle
+ * @id: profile id (handle)
+ *
+ * Calling this function will update the hardware tables to enable the
+ * profile indicated by the ID parameter for the VSIs specified in the VSI
+ * array. Once successfully called, the flow will be enabled.
+ */
+enum ice_status
+ice_flow_assoc_hw_prof(struct ice_hw *hw, enum ice_block blk,
+  u16 dest_vsi_handle, u16 fdir_vsi_handle, int id)
+{
+   enum ice_status status = ICE_SUCCESS;
+   u16 vsi_num;
+
+   vsi_num = ice_get_hw_vsi_num(hw, dest_vsi_handle);
+   status = ice_add_prof_id_flow(hw, blk, vsi_num, id);
+   if (status) {
+   ice_debug(hw, ICE_DBG_FLOW, "HW profile add failed for main VSI 
flow entry, %d\n",
+ status);
+   goto err_add_prof;
+   }
+
+   if (blk != ICE_BLK_FD)
+   return status;
+
+   vsi_num = ice_get_hw_vsi_num(hw, fdir_vsi_handle);
+   status = ice_add_prof_id_flow(hw, blk, vsi_num, id);
+   if (status) {
+   ice_debug(hw, ICE_DBG_FLOW, "HW profile add failed for ctrl VSI 
flow entry, %d\n",
+ status);
+   goto err_add_entry;
+   }
+
+   return status;
+
+err_add_entry:
+   vsi_num = ice_get_hw_vsi_num(hw, dest_vsi_handle);
+   ice_rem_prof_id_flow(hw, blk, vsi_num, id);
+err_add_prof:
+   ice_flow_rem_prof(hw, blk, id);
+
+   return status;
+}
diff --git a/drivers/net/ice/base/ice_flex_pipe.h 
b/drivers/net/ice/base/ice_flex_pipe.h
index dd332312dd..23ba45564a 100644
--- a/drivers/net/ice/base/ice_flex_pipe.h
+++ b/drivers/net/ice/base/ice_flex_pipe.h
@@ -76,6 +76,9 @@ enum ice_status
 ice_add_prof_id_flow(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl);
 enum ice_status
 ice_rem_prof_id_flow(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64 hdl);
+enum ice_status
+ice_flow_assoc_hw_prof(struct ice_hw *hw, enum ice_block blk,
+  u16 dest_vsi_handle, u16 fdir_vsi_handle, int id);
 enum ice_status ice_init_pkg(struct ice_hw *hw, u8 *buff, u32 len);
 enum ice_status
 ice_copy_and_init_pkg(struct ice_hw *hw, const u8 *buf, u32 len);
diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
index 77b6b130c1..f699dbbc74 100644
--- a/drivers/net/ice/base/ice_flow.c
+++ b/drivers/net/ice/base/ice_flow.c
@@ -2524,6 +2524,90 @@ ice_flow_disassoc_prof(struct ice_hw *hw, enum ice_block 
blk,
return status;
 }
 
+#define FLAG_GTP_EH_PDU_LINK   BIT_ULL(13)
+#define FLAG_GTP_EH_PDUBIT_ULL(14)
+
+#define FLAG_GTPU_MSK  \
+   (FLAG_GTP_EH_PDU | FLAG_GTP_EH_PDU_LINK)
+#define FLAG_GTPU_DW   \
+   (FLAG_GTP_EH_PDU | FLAG_GTP_EH_PDU_LINK)
+#define FLAG_GTPU_UP   \
+   (FLAG_GTP_EH_PDU)
+/**
+ * ice_flow_set_hw_prof - Set HW flow profile based on the parsed profile info
+ * @hw: pointer to the HW struct
+ * @dest_vsi_handle: dest VSI handle
+ * @fdir_vsi_handle: fdir programming VSI handle
+ * @prof: stores parsed profile info from raw flow
+ * @blk: classification stage
+ */
+enum ice_status
+ice_flow_set_hw_prof(struct ice_hw *hw, u16 dest_vsi_handle,
+u16 fdir_vsi_handle, struct ice_parser_profile *prof,
+enum ice_block blk)
+{
+   int id = ice_find_first_bit(prof->ptypes, UINT16_MAX);
+   struct ice_flow_prof_params *params;
+   u8 fv_words = hw->blk[blk].es.fvw;
+   enum ice_status status;
+   u16 vsi_num;
+   int i, idx;
+
+   params = (struct ice_flow_prof_params *)ice_malloc(hw, sizeof(*params));
+   if (!params)
+   return ICE_ERR_NO_MEMORY;
+
+   for (i = 0; i < ICE_MAX_FV_WORDS; i++) {
+   params->es[i].prot_id = ICE_PROT_INVALID;
+   params->es[i].off = ICE_FV_OFFSET_INVAL;
+   }
+
+   for (i = 0; i < prof->fv_num; i++) {
+   if (hw->blk[blk].es.reverse)
+   idx = fv_words - i - 1;
+   else
+   idx = i;
+   params->es[idx].prot_id = prof->fv[i].p

[dpdk-dev] [PATCH v7 3/4] app/testpmd: update Max RAW pattern size to 512

[Junfeng Guo]

Update max size for pattern in struct rte_flow_item_raw to enable
protocol agnostic flow offloading.

Signed-off-by: Junfeng Guo 
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index d8218771fb..ef24710bd8 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -495,7 +495,7 @@ enum index {
 };
 
 /** Maximum size for pattern in struct rte_flow_item_raw. */
-#define ITEM_RAW_PATTERN_SIZE 40
+#define ITEM_RAW_PATTERN_SIZE 512
 
 /** Maximum size for GENEVE option data pattern in bytes. */
 #define ITEM_GENEVE_OPT_DATA_SIZE 124
-- 
2.25.1

[dpdk-dev] [PATCH v7 4/4] net/ice: enable protocol agnostic flow offloading in FDIR

[Junfeng Guo]

Protocol agnostic flow offloading in Flow Director is enabled by this
patch based on the Parser Library, using existing rte_flow raw API.

Note that the raw flow requires:
1. byte string of raw target packet bits.
2. byte string of mask of target packet.

Here is an example:
FDIR matching ipv4 dst addr with 1.2.3.4 and redirect to queue 3:

flow create 0 ingress pattern raw \
pattern spec \
080045144000401001020304 \
pattern mask \
 \
/ end actions queue index 3 / mark id 3 / end

Note that mask of some key bits (e.g., 0x0800 to indicate ipv4 proto)
is optional in our cases. To avoid redundancy, we just omit the mask
of 0x0800 (with 0x) in the mask byte string example. The prefix
'0x' for the spec and mask byte (hex) strings are also omitted here.

Signed-off-by: Junfeng Guo 
---
 doc/guides/rel_notes/release_21_11.rst |   1 +
 drivers/net/ice/ice_ethdev.h   |  17 ++
 drivers/net/ice/ice_fdir_filter.c  | 260 +
 drivers/net/ice/ice_generic_flow.c |   7 +
 drivers/net/ice/ice_generic_flow.h |   3 +
 5 files changed, 288 insertions(+)

diff --git a/doc/guides/rel_notes/release_21_11.rst 
b/doc/guides/rel_notes/release_21_11.rst
index 9c13ceed1c..cc449a4340 100644
--- a/doc/guides/rel_notes/release_21_11.rst
+++ b/doc/guides/rel_notes/release_21_11.rst
@@ -167,6 +167,7 @@ New Features
 
 * **Updated Intel ice driver.**
 
+  * Added protocol agnostic flow offloading support in Flow Director.
   * Added 1PPS out support by a devargs.
   * Added IPv4 and L4 (TCP/UDP/SCTP) checksum hash support in RSS flow.
   * Added DEV_RX_OFFLOAD_TIMESTAMP support.
diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h
index 599e0028f7..441242ee89 100644
--- a/drivers/net/ice/ice_ethdev.h
+++ b/drivers/net/ice/ice_ethdev.h
@@ -318,6 +318,11 @@ struct ice_fdir_filter_conf {
uint64_t input_set_o; /* used for non-tunnel or tunnel outer fields */
uint64_t input_set_i; /* only for tunnel inner fields */
uint32_t mark_flag;
+
+   struct ice_parser_profile *prof;
+   const u8 *pkt_buf;
+   bool parser_ena;
+   u8 pkt_len;
 };
 
 #define ICE_MAX_FDIR_FILTER_NUM(1024 * 16)
@@ -487,6 +492,17 @@ struct ice_devargs {
uint8_t pps_out_ena;
 };
 
+/**
+ * Structure to store fdir fv entry.
+ */
+struct ice_fdir_prof_info {
+   struct LIST_ENTRY_TYPE l_entry;
+
+   struct ice_parser_profile prof;
+   u16 ptg;
+   u64 fdir_actived_cnt;
+};
+
 /**
  * Structure to store private data for each PF/VF instance.
  */
@@ -509,6 +525,7 @@ struct ice_adapter {
struct rte_timecounter rx_tstamp_tc;
struct rte_timecounter tx_tstamp_tc;
bool ptp_ena;
+   struct LIST_HEAD_TYPE fdir_prof_list;
 #ifdef RTE_ARCH_X86
bool rx_use_avx2;
bool rx_use_avx512;
diff --git a/drivers/net/ice/ice_fdir_filter.c 
b/drivers/net/ice/ice_fdir_filter.c
index bd627e3aa8..bcf105d1bd 100644
--- a/drivers/net/ice/ice_fdir_filter.c
+++ b/drivers/net/ice/ice_fdir_filter.c
@@ -107,6 +107,7 @@
ICE_INSET_NAT_T_ESP_SPI)
 
 static struct ice_pattern_match_item ice_fdir_pattern_list[] = {
+   {pattern_raw,   ICE_INSET_NONE, 
ICE_INSET_NONE, ICE_INSET_NONE},
{pattern_ethertype, ICE_FDIR_INSET_ETH, 
ICE_INSET_NONE, ICE_INSET_NONE},
{pattern_eth_ipv4,  
ICE_FDIR_INSET_ETH_IPV4,ICE_INSET_NONE, ICE_INSET_NONE},
{pattern_eth_ipv4_udp,  
ICE_FDIR_INSET_ETH_IPV4_UDP,ICE_INSET_NONE, ICE_INSET_NONE},
@@ -1158,6 +1159,8 @@ ice_fdir_init(struct ice_adapter *ad)
if (ret)
return ret;
 
+   INIT_LIST_HEAD(&ad->fdir_prof_list);
+
parser = &ice_fdir_parser;
 
return ice_register_parser(parser, ad);
@@ -1188,6 +1191,24 @@ ice_fdir_is_tunnel_profile(enum ice_fdir_tunnel_type 
tunnel_type)
return 0;
 }
 
+static int
+ice_fdir_add_del_raw(struct ice_pf *pf,
+struct ice_fdir_filter_conf *filter,
+bool add)
+{
+   struct ice_hw *hw = ICE_PF_TO_HW(pf);
+
+   unsigned char *pkt = (unsigned char *)pf->fdir.prg_pkt;
+   rte_memcpy(pkt, filter->pkt_buf, filter->pkt_len);
+
+   struct ice_fltr_desc desc;
+   memset(&desc, 0, sizeof(desc));
+   filter->input.comp_report = ICE_FXD_FLTR_QW0_COMP_REPORT_SW;
+   ice_fdir_get_prgm_desc(hw, &filter->input, &desc, add);
+
+   return ice_fdir_programming(pf, &desc);
+}
+
 static int
 ice_fdir_add_del_filter(struct ice_pf *pf,
struct ice_fdir_filter_conf *filter,
@@ -1303,6 +1324,100 @@ ice_fdir_create_filter(struct ice_adapter *ad,
struct ice_fdir_fltr_pattern key;

[dpdk-dev] [PATCH] regex/octeontx2: use cnxk infrastructure

[lironh]

From: Liron Himi 

update driver to use the REE cnxk code

Signed-off-by: Liron Himi 
---
 drivers/regex/octeontx2/meson.build   |   6 +-
 drivers/regex/octeontx2/otx2_regexdev.c   | 261 +---
 drivers/regex/octeontx2/otx2_regexdev.h   |  75 +---
 .../regex/octeontx2/otx2_regexdev_compiler.c  |   8 +-
 .../regex/octeontx2/otx2_regexdev_hw_access.c | 167 
 .../regex/octeontx2/otx2_regexdev_hw_access.h | 202 -
 drivers/regex/octeontx2/otx2_regexdev_mbox.c  | 401 --
 drivers/regex/octeontx2/otx2_regexdev_mbox.h  |  38 --
 8 files changed, 111 insertions(+), 1047 deletions(-)
 delete mode 100644 drivers/regex/octeontx2/otx2_regexdev_hw_access.c
 delete mode 100644 drivers/regex/octeontx2/otx2_regexdev_hw_access.h
 delete mode 100644 drivers/regex/octeontx2/otx2_regexdev_mbox.c
 delete mode 100644 drivers/regex/octeontx2/otx2_regexdev_mbox.h

diff --git a/drivers/regex/octeontx2/meson.build 
b/drivers/regex/octeontx2/meson.build
index 3f81add5bf..0e00867ec0 100644
--- a/drivers/regex/octeontx2/meson.build
+++ b/drivers/regex/octeontx2/meson.build
@@ -18,10 +18,8 @@ endif
 sources = files(
 'otx2_regexdev.c',
 'otx2_regexdev_compiler.c',
-'otx2_regexdev_hw_access.c',
-'otx2_regexdev_mbox.c',
 )
 
-deps += ['bus_pci', 'common_octeontx2', 'regexdev']
+deps += ['bus_pci', 'regexdev']
+deps += ['common_cnxk', 'mempool_cnxk']
 
-includes += include_directories('../../common/octeontx2')
diff --git a/drivers/regex/octeontx2/otx2_regexdev.c 
b/drivers/regex/octeontx2/otx2_regexdev.c
index b6e55853e9..8ae5001f70 100644
--- a/drivers/regex/octeontx2/otx2_regexdev.c
+++ b/drivers/regex/octeontx2/otx2_regexdev.c
@@ -13,12 +13,8 @@
 
 
 /* REE common headers */
-#include "otx2_common.h"
-#include "otx2_dev.h"
 #include "otx2_regexdev.h"
 #include "otx2_regexdev_compiler.h"
-#include "otx2_regexdev_hw_access.h"
-#include "otx2_regexdev_mbox.h"
 
 
 /* HW matches are at offset 0x80 from RES_PTR_ADDR
@@ -35,9 +31,6 @@
 #define REE_MAX_RULES_PER_GROUP 0x
 #define REE_MAX_GROUPS 0x
 
-/* This is temporarily here */
-#define REE0_PF19
-#define REE1_PF20
 
 #define REE_RULE_DB_VERSION2
 #define REE_RULE_DB_REVISION   0
@@ -61,29 +54,29 @@ qp_memzone_name_get(char *name, int size, int dev_id, int 
qp_id)
snprintf(name, size, "otx2_ree_lf_mem_%u:%u", dev_id, qp_id);
 }
 
-static struct otx2_ree_qp *
+static struct roc_ree_qp *
 ree_qp_create(const struct rte_regexdev *dev, uint16_t qp_id)
 {
struct otx2_ree_data *data = dev->data->dev_private;
uint64_t pg_sz = sysconf(_SC_PAGESIZE);
-   struct otx2_ree_vf *vf = &data->vf;
+   struct roc_ree_vf *vf = &data->vf;
const struct rte_memzone *lf_mem;
uint32_t len, iq_len, size_div2;
char name[RTE_MEMZONE_NAMESIZE];
uint64_t used_len, iova;
-   struct otx2_ree_qp *qp;
+   struct roc_ree_qp *qp;
uint8_t *va;
int ret;
 
/* Allocate queue pair */
qp = rte_zmalloc("OCTEON TX2 Regex PMD Queue Pair", sizeof(*qp),
-   OTX2_ALIGN);
+   ROC_ALIGN);
if (qp == NULL) {
otx2_err("Could not allocate queue pair");
return NULL;
}
 
-   iq_len = OTX2_REE_IQ_LEN;
+   iq_len = REE_IQ_LEN;
 
/*
 * Queue size must be in units of 128B 2 * REE_INST_S (which is 64B),
@@ -93,13 +86,13 @@ ree_qp_create(const struct rte_regexdev *dev, uint16_t 
qp_id)
size_div2 = iq_len >> 1;
 
/* For pending queue */
-   len = iq_len * RTE_ALIGN(sizeof(struct otx2_ree_rid), 8);
+   len = iq_len * RTE_ALIGN(sizeof(struct roc_ree_rid), 8);
 
/* So that instruction queues start as pg size aligned */
len = RTE_ALIGN(len, pg_sz);
 
/* For instruction queues */
-   len += OTX2_REE_IQ_LEN * sizeof(union otx2_ree_inst);
+   len += REE_IQ_LEN * sizeof(union roc_ree_inst);
 
/* Waste after instruction queues */
len = RTE_ALIGN(len, pg_sz);
@@ -107,7 +100,7 @@ ree_qp_create(const struct rte_regexdev *dev, uint16_t 
qp_id)
qp_memzone_name_get(name, RTE_MEMZONE_NAMESIZE, dev->data->dev_id,
qp_id);
 
-   lf_mem = rte_memzone_reserve_aligned(name, len, vf->otx2_dev.node,
+   lf_mem = rte_memzone_reserve_aligned(name, len, rte_socket_id(),
RTE_MEMZONE_SIZE_HINT_ONLY | RTE_MEMZONE_256MB,
RTE_CACHE_LINE_SIZE);
if (lf_mem == NULL) {
@@ -121,22 +114,22 @@ ree_qp_create(const struct rte_regexdev *dev, uint16_t 
qp_id)
memset(va, 0, len);
 
/* Initialize pending queue */
-   qp->pend_q.rid_queue = (struct otx2_ree_rid *)va;
+   qp->pend_q.rid_queue = (struct roc_ree_rid *)va;
qp->pend_q.enq_tail = 0;
qp->pend_q.deq_head = 0;
qp->pend_q.pending_count = 0;
 
-   used_len = iq_len * RTE_ALIGN(sizeo

[dpdk-dev] 回复: [PATCH v7 1/5] eal: add new definitions for wait scheme

[Feifei Wang]

> -邮件原件-
> 发件人: Jerin Jacob 
> 发送时间: Thursday, October 28, 2021 3:51 PM
> 收件人: Feifei Wang 
> 抄送: Ruifeng Wang ; dpdk-dev ;
> nd ; Ananyev, Konstantin ;
> Stephen Hemminger ; David Marchand
> ; tho...@monjalon.net; Mattias Rönnblom
> 
> 主题: Re: [PATCH v7 1/5] eal: add new definitions for wait scheme
> 
> On Thu, Oct 28, 2021 at 1:11 PM Feifei Wang 
> wrote:
> >
> >
> >
> > > -邮件原件-
> > > 发件人: Jerin Jacob 
> > > 发送时间: Thursday, October 28, 2021 3:16 PM
> > > 收件人: Feifei Wang 
> > > 抄送: Ruifeng Wang ; dpdk-dev
> ; nd
> > > ; Ananyev, Konstantin ;
> > > Stephen Hemminger ; David Marchand
> > > ; tho...@monjalon.net; Mattias
> Rönnblom
> > > 
> > > 主题: Re: [PATCH v7 1/5] eal: add new definitions for wait scheme
> > >
> > > On Thu, Oct 28, 2021 at 12:26 PM Feifei Wang 
> > > wrote:
> > > >
> > > > Introduce macros as generic interface for address monitoring.
> > > > For different size, encapsulate '__LOAD_EXC_16', '__LOAD_EXC_32'
> > > > and '__LOAD_EXC_64' into a new macro '__LOAD_EXC'.
> > > >
> > > > Furthermore, to prevent compilation warning in arm:
> > > > --
> > > > 'warning: implicit declaration of function ...'
> > > > --
> > > > Delete 'undef' constructions for '__LOAD_EXC_xx', '__SEVL' and
> '__WFE'.
> > > > And add ‘__RTE_ARM’ for these macros to fix the namespace.
> > > >
> > > > This is because original macros are undefine at the end of the file.
> > > > If new macro 'rte_wait_event' calls them in other files, they will
> > > > be seen as 'not defined'.
> > > >
> > > > Signed-off-by: Feifei Wang 
> > > > Reviewed-by: Ruifeng Wang 
> > > > ---
> > >
> > > > +static __rte_always_inline void
> > > > +rte_wait_until_equal_16(volatile uint16_t *addr, uint16_t expected,
> > > > +   int memorder)
> > > > +{
> > > > +   uint16_t value;
> > > > +
> > > > +   assert(memorder == __ATOMIC_ACQUIRE || memorder ==
> > > > + __ATOMIC_RELAXED);
> > >
> > > Assert is not good in the library, Why not RTE_BUILD_BUG_ON here
> > [Feifei] This line is the original code which has nothing to do with
> > this patch, I can change it in the next version.
> > >
> > >
> > > > +
> > > > +   __RTE_ARM_LOAD_EXC_16(addr, value, memorder)
> > > > if (value != expected) {
> > > > -   __SEVL()
> > > > +__RTE_ARM_SEVL()
> > > > do {
> > > > -   __WFE()
> > > > -   __LOAD_EXC_16(addr, value, memorder)
> > > > +   __RTE_ARM_WFE()
> > > > +   __RTE_ARM_LOAD_EXC_16(addr, value,
> > > > + memorder)
> > > > } while (value != expected);
> > > > }
> > > > -#undef __LOAD_EXC_16
> > > >  }
> > > >
> > > >  static __rte_always_inline void
> > > > @@ -77,34 +124,14 @@ rte_wait_until_equal_32(volatile uint32_t
> > > > *addr, uint32_t expected,
> > > >
> > > > assert(memorder == __ATOMIC_ACQUIRE || memorder ==
> > > > __ATOMIC_RELAXED);
> > > >
> > > > -   /*
> > > > -* Atomic exclusive load from addr, it returns the 32-bit 
> > > > content of
> > > > -* *addr while making it 'monitored',when it is written by 
> > > > someone
> > > > -* else, the 'monitored' state is cleared and a event is 
> > > > generated
> > > > -* implicitly to exit WFE.
> > > > -*/
> > > > -#define __LOAD_EXC_32(src, dst, memorder) {  \
> > > > -   if (memorder == __ATOMIC_RELAXED) {  \
> > > > -   asm volatile("ldxr %w[tmp], [%x[addr]]"  \
> > > > -   : [tmp] "=&r" (dst)  \
> > > > -   : [addr] "r"(src)\
> > > > -   : "memory"); \
> > > > -   } else { \
> > > > -   asm volatile("ldaxr %w[tmp], [%x[addr]]" \
> > > > -   : [tmp] "=&r" (dst)  \
> > > > -   : [addr] "r"(src)\
> > > > -   : "memory"); \
> > > > -   } }
> > > > -
> > > > -   __LOAD_EXC_32(addr, value, memorder)
> > > > +   __RTE_ARM_LOAD_EXC_32(addr, value, memorder)
> > > > if (value != expected) {
> > > > -   __SEVL()
> > > > +   __RTE_ARM_SEVL()
> > > > do {
> > > > -   __WFE()
> > > > -   __LOAD_EXC_32(addr, value, memorder)
> > > > +   __RTE_ARM_WFE()
> > > > +   __RTE_ARM_LOAD_EXC_32(addr, value,
> > > > + memorder)
> > > > } while (value != expected);
> > > > }
> > > > -#undef __LOAD_EXC_32
> > > >  }
> > > >
> > > >  static __rte_always_inline void
> > > > @@ -115,38 +142,33 @@ rte_wait_until_equal_64(volatile uint64_t
> > > > *addr, uint64_t expected,
> > > >
> > > > assert(memorder == __ATOMIC_ACQU

Re: [dpdk-dev] [PATCH] common/cnxk: add REE support

[Jerin Jacob]

On Sun, Oct 3, 2021 at 11:53 AM  wrote:
>
> From: Liron Himi 
>
> Adding REE definitions and related ROC code

# Mention the full form of REE in the git commit message.

#Patch looks good to me. Some minor comments below

# Also, Please send a patch for switching drivers/regex/octeontx2/ to
the new RoC driver. We will plan to merge it on RC2.

# Please split this patch a 3 or 4 more logical patches for
device-specific, rules API, etc


>
> Signed-off-by: Liron Himi 
> ---
>  drivers/common/cnxk/hw/ree.h| 165 +++
>  drivers/common/cnxk/hw/rvu.h|   5 +
>  drivers/common/cnxk/meson.build |   1 +
>  drivers/common/cnxk/roc_api.h   |   4 +
>  drivers/common/cnxk/roc_constants.h |   2 +
>  drivers/common/cnxk/roc_mbox.h  | 100 +
>  drivers/common/cnxk/roc_platform.c  |   1 +
>  drivers/common/cnxk/roc_platform.h  |   2 +
>  drivers/common/cnxk/roc_priv.h  |   3 +
>  drivers/common/cnxk/roc_ree.c   | 647 
>  drivers/common/cnxk/roc_ree.h   | 137 ++
>  drivers/common/cnxk/roc_ree_priv.h  |  18 +
>  drivers/common/cnxk/version.map |  18 +-
>  13 files changed, 1102 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/common/cnxk/hw/ree.h
>  create mode 100644 drivers/common/cnxk/roc_ree.c
>  create mode 100644 drivers/common/cnxk/roc_ree.h
>  create mode 100644 drivers/common/cnxk/roc_ree_priv.h
>
> diff --git a/drivers/common/cnxk/hw/ree.h b/drivers/common/cnxk/hw/ree.h
> new file mode 100644
> index 00..0766d35e52
> --- /dev/null
> +++ b/drivers/common/cnxk/hw/ree.h
> @@ -0,0 +1,165 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(C) 2021 Marvell.
> + */
> +
> +#ifndef __REE_HW_H__
> +#define __REE_HW_H__
> +
> +/* REE instruction queue length */
> +#define REE_IQ_LEN (1 << 13)
> +
> +#define REE_DEFAULT_CMD_QLEN REE_IQ_LEN
> +
> +/* Status register bits */
> +#define REE_STATUS_PMI_EOJ_BIT(1 << 14)
> +#define REE_STATUS_PMI_SOJ_BIT(1 << 13)
> +#define REE_STATUS_MP_CNT_DET_BIT  (1 << 7)
> +#define REE_STATUS_MM_CNT_DET_BIT  (1 << 6)
> +#define REE_STATUS_ML_CNT_DET_BIT  (1 << 5)
> +#define REE_STATUS_MST_CNT_DET_BIT (1 << 4)
> +#define REE_STATUS_MPT_CNT_DET_BIT (1 << 3)

Use macros in drivers/common/cnxk/roc_bits.h


> +
> +/* Register offsets */
> +/* REE LF registers */
> +#define REE_LF_DONE_INT0x120ull
> +#define REE_LF_DONE_INT_W1S0x130ull
> +#define REE_LF_DONE_INT_ENA_W1S 0x138ull
> +#define REE_LF_DONE_INT_ENA_W1C 0x140ull
> +#define REE_LF_MISC_INT0x300ull
> +#define REE_LF_MISC_INT_W1S0x310ull
> +#define REE_LF_MISC_INT_ENA_W1S 0x320ull
> +#define REE_LF_MISC_INT_ENA_W1C 0x330ull
> +#define REE_LF_ENA 0x10ull
> +#define REE_LF_SBUF_ADDR   0x20ull
> +#define REE_LF_DONE0x100ull
> +#define REE_LF_DONE_ACK0x110ull
> +#define REE_LF_DONE_WAIT   0x148ull
> +#define REE_LF_DOORBELL0x400ull
> +#define REE_LF_OUTSTAND_JOB0x410ull
> +
> +/* BAR 0 */
> +#define REE_AF_REEXM_MAX_MATCH (0x80c8ull)
> +#define REE_AF_QUE_SBUF_CTL(a) (0x1200ull | (uint64_t)(a) << 3)
> +#define REE_PRIV_LF_CFG(a) (0x41000ull | (uint64_t)(a) << 3)
> +
> +#define REE_AF_QUEX_GMCTL(a) (0x800 | (a) << 3)
> +
> +#define REE_AF_INT_VEC_RAS (0x0ull)
> +#define REE_AF_INT_VEC_RVU (0x1ull)
> +#define REE_AF_INT_VEC_QUE_DONE (0x2ull)
> +#define REE_AF_INT_VEC_AQ  (0x3ull)
> +
> +/* ENUMS */
> +
> +#define REE_LF_INT_VEC_QUE_DONE (0x0ull)
> +#define REE_LF_INT_VEC_MISC(0x1ull)
> +
> +#define REE_LF_BAR2(vf, q_id)
>   \
> +   ((vf)->dev->bar2 + (((vf)->block_address << 20) | ((q_id) << 12)))
> +
> +#define REE_QUEUE_HI_PRIO 0x1
> +
> +enum ree_desc_type_e {
> +   REE_TYPE_JOB_DESC = 0x0,
> +   REE_TYPE_RESULT_DESC = 0x1,
> +   REE_TYPE_ENUM_LAST = 0x2
> +};
> +
> +union ree_priv_lf_cfg {
> +   uint64_t u;
> +   struct {
> +   uint64_t slot : 8;
> +   uint64_t pf_func : 16;
> +   uint64_t reserved_24_62 : 39;
> +   uint64_t ena : 1;
> +   } s;
> +};
> +
> +union ree_lf_sbuf_addr {
> +   uint64_t u;
> +   struct {
> +   uint64_t off : 7;
> +   uint64_t ptr : 46;
> +   uint64_t reserved_53_63 : 11;
> +   } s;
> +};
> +
> +union ree_lf_ena {
> +   uint64_t u;
> +   struct {
> +   uint64_t ena : 1;
> +   uint64_t reserved_1_63 : 63;
> +   } s;
> +};
> +
> +union ree_af_reexm_max_match {
> +   uint64_t u;
> +   struct {
> +   uint64_t max : 8;
> +   uint64_t reserved_8_63 : 56;
> +   } s;
> +};
> +
> +union ree_lf_done {
> +   uint64_t u;
> +   struct {
> +   uint64_t done : 20;
> +   uint64_t reserved_20_63 : 44;
> +   } s;
> +};

All the register definitions above use bitfield APIs in
drivers/common/cnxk/roc_bitfield.h

context str

Re: [dpdk-dev] [dpdk-dev v7 7/9] crypto/qat: unified device private data structure

[Power, Ciara]

>-Original Message-
>From: dev  On Behalf Of Kai Ji
>Sent: Wednesday 27 October 2021 16:51
>To: dev@dpdk.org
>Cc: Zhang, Roy Fan ; Kusztal, ArkadiuszX
>; Ji, Kai 
>Subject: [dpdk-dev] [dpdk-dev v7 7/9] crypto/qat: unified device private data
>structure
>
>From: Fan Zhang 
>
>This patch unifies the QAT symmetric and asymmetric device private data
>structures and functions.
>
>Signed-off-by: Arek Kusztal 
>Signed-off-by: Fan Zhang 
>Signed-off-by: Kai Ji 
>---

Acked-by: Ciara Power 

Re: [dpdk-dev] [dpdk-dev v7 2/9] common/qat: add gen specific device implementation

[Power, Ciara]

>-Original Message-
>From: dev  On Behalf Of Kai Ji
>Sent: Wednesday 27 October 2021 16:51
>To: dev@dpdk.org
>Cc: Zhang, Roy Fan ; Kusztal, ArkadiuszX
>; Ji, Kai 
>Subject: [dpdk-dev] [dpdk-dev v7 2/9] common/qat: add gen specific device
>implementation
>
>From: Fan Zhang 
>
>This patch replaces the mixed QAT device configuration implementation by
>separate files with shared or individual implementation for specific QAT
>generation.
>
>Signed-off-by: Arek Kusztal 
>Signed-off-by: Fan Zhang 
>Signed-off-by: Kai Ji 

Acked-by: Ciara Power 

[dpdk-dev] [PATCH] net/ice: remove VSI update on DCF reset by PF

[dapengx . yu]

From: Dapeng Yu 

After DCF is reset by PF, the VSI update service is unable to be
completed since the DCF resource is invalid.

This patch removes the call to service that updates VSI since it is
useless and output too many error messages.

Fixes: c7e1a1a3bfeb ("net/ice: refactor DCF VLAN handling")
Cc: sta...@dpdk.org

Signed-off-by: Dapeng Yu 
---
 drivers/net/ice/ice_dcf_parent.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c
index 04078345eb..1ff2c47172 100644
--- a/drivers/net/ice/ice_dcf_parent.c
+++ b/drivers/net/ice/ice_dcf_parent.c
@@ -233,7 +233,6 @@ ice_dcf_handle_pf_event_msg(struct ice_dcf_hw *dcf_hw,
switch (pf_msg->event) {
case VIRTCHNL_EVENT_RESET_IMPENDING:
PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_RESET_IMPENDING event");
-   start_vsi_reset_thread(dcf_hw, false, 0);
dcf_hw->resetting = true;
break;
case VIRTCHNL_EVENT_LINK_CHANGE:
-- 
2.27.0

[dpdk-dev] [PATCH v2] net: fix build with sparse on L2TPv2 bitfields

[David Marchand]

An external project that wants to do additional checks on fields
endianness can remap rte_beXX types to instrumented types and use
sparse.

The current code breaks OVS build with sparse:
../../lib/ofp-packet.c: note: in included file (through
  .../ovs/dpdk-dir/build/include/rte_flow.h, ../../lib/netdev-dpdk.h,
  ../../lib/dp-packet.h):
.../ovs/dpdk-dir/build/include/rte_l2tpv2.h:92:37:
  error: invalid bitfield specifier for type restricted ovs_be16.
.../ovs/dpdk-dir/build/include/rte_l2tpv2.h:93:37:
  error: invalid bitfield specifier for type restricted ovs_be16.
.../ovs/dpdk-dir/build/include/rte_l2tpv2.h:94:40:
  error: invalid bitfield specifier for type restricted ovs_be16.
.../ovs/dpdk-dir/build/include/rte_l2tpv2.h:95:37:
  error: invalid bitfield specifier for type restricted ovs_be16.
.../ovs/dpdk-dir/build/include/rte_l2tpv2.h:96:40:
  error: invalid bitfield specifier for type restricted ovs_be16.
.../ovs/dpdk-dir/build/include/rte_l2tpv2.h:97:37:
  error: invalid bitfield specifier for type restricted ovs_be16.
.../ovs/dpdk-dir/build/include/rte_l2tpv2.h:98:37:
  error: invalid bitfield specifier for type restricted ovs_be16.
.../ovs/dpdk-dir/build/include/rte_l2tpv2.h:99:40:
  error: invalid bitfield specifier for type restricted ovs_be16.
.../ovs/dpdk-dir/build/include/rte_l2tpv2.h:100:39:
  error: invalid bitfield specifier for type restricted ovs_be16.
make[3]: *** [lib/ofp-packet.lo] Error 1

Use simple uint16_t types for bitfields in L2TPv2 struct.

Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol")

Signed-off-by: David Marchand 
---
 lib/net/rte_l2tpv2.h | 36 ++--
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/lib/net/rte_l2tpv2.h b/lib/net/rte_l2tpv2.h
index 670fe5470e..b90e36cf12 100644
--- a/lib/net/rte_l2tpv2.h
+++ b/lib/net/rte_l2tpv2.h
@@ -89,25 +89,25 @@ struct rte_l2tpv2_common_hdr {
__extension__
struct {
 #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
-   rte_be16_t t:1; /**< message Type */
-   rte_be16_t l:1; /**< length option bit */
-   rte_be16_t res1:2;  /**< reserved */
-   rte_be16_t s:1; /**< ns/nr option bit */
-   rte_be16_t res2:1;  /**< reserved */
-   rte_be16_t o:1; /**< offset option bit */
-   rte_be16_t p:1; /**< priority option bit */
-   rte_be16_t res3:4;  /**< reserved */
-   rte_be16_t ver:4;   /**< protocol version */
+   uint16_t t:1;   /**< message Type */
+   uint16_t l:1;   /**< length option bit */
+   uint16_t res1:2;/**< reserved */
+   uint16_t s:1;   /**< ns/nr option bit */
+   uint16_t res2:1;/**< reserved */
+   uint16_t o:1;   /**< offset option bit */
+   uint16_t p:1;   /**< priority option bit */
+   uint16_t res3:4;/**< reserved */
+   uint16_t ver:4; /**< protocol version */
 #elif RTE_BYTE_ORDER == RTE_BIG_ENDIAN
-   rte_be16_t ver:4;   /**< protocol version */
-   rte_be16_t res3:4;  /**< reserved */
-   rte_be16_t p:1; /**< priority option bit */
-   rte_be16_t o:1; /**< offset option bit */
-   rte_be16_t res2:1;  /**< reserved */
-   rte_be16_t s:1; /**< ns/nr option bit */
-   rte_be16_t res1:2;  /**< reserved */
-   rte_be16_t l:1; /**< length option bit */
-   rte_be16_t t:1; /**< message Type */
+   uint16_t ver:4; /**< protocol version */
+   uint16_t res3:4;/**< reserved */
+   uint16_t p:1;   /**< priority option bit */
+   uint16_t o:1;   /**< offset option bit */
+   uint16_t res2:1;/**< reserved */
+   uint16_t s:1;   /**< ns/nr option bit */
+   uint16_t res1:2;/**< reserved */
+   uint16_t l:1;   /**< length option bit */
+   uint16_t t:1;   /**< message Type */
 #endif
};
};
-- 
2.23.0

[dpdk-dev] [PATCH] crypto/octeontx2: fix lookaside IPsec IPv6 support

[Tejasree Kondoj]

Fixing IPv6 mixed tunnel mode support by updating
inputs to firmware.

Fixes: 4edede7bc6ee ("crypto/octeontx2: support lookaside IPsec IPv6")
Cc: sta...@dpdk.org

Signed-off-by: Tejasree Kondoj 
---
 drivers/crypto/octeontx2/otx2_cryptodev_ops.c |  9 
 drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 22 +++
 drivers/crypto/octeontx2/otx2_cryptodev_sec.h |  2 --
 drivers/crypto/octeontx2/otx2_ipsec_po.h  |  8 ---
 drivers/crypto/octeontx2/otx2_ipsec_po_ops.h  | 10 +++--
 5 files changed, 15 insertions(+), 36 deletions(-)

diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c 
b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c
index e6274bea42..e0ae3e161e 100644
--- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c
+++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c
@@ -993,13 +993,12 @@ otx2_cpt_sec_post_process(struct rte_crypto_op *cop, 
uintptr_t *rsp)
 
if (word0->s.opcode.major == OTX2_IPSEC_PO_PROCESS_IPSEC_INB) {
data = rte_pktmbuf_mtod(m, char *);
+   ip = (struct rte_ipv4_hdr *)(data +
+   OTX2_IPSEC_PO_INB_RPTR_HDR);
 
-   if (rsp[4] == OTX2_IPSEC_PO_TRANSPORT ||
-   rsp[4] == OTX2_IPSEC_PO_TUNNEL_IPV4) {
-   ip = (struct rte_ipv4_hdr *)(data +
-   OTX2_IPSEC_PO_INB_RPTR_HDR);
+   if ((ip->version_ihl >> 4) == 4) {
m_len = rte_be_to_cpu_16(ip->total_length);
-   } else if (rsp[4] == OTX2_IPSEC_PO_TUNNEL_IPV6) {
+   } else {
ip6 = (struct rte_ipv6_hdr *)(data +
OTX2_IPSEC_PO_INB_RPTR_HDR);
m_len = rte_be_to_cpu_16(ip6->payload_len) +
diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c 
b/drivers/crypto/octeontx2/otx2_cryptodev_sec.c
index a5db40047d..9a4f84f8d8 100644
--- a/drivers/crypto/octeontx2/otx2_cryptodev_sec.c
+++ b/drivers/crypto/octeontx2/otx2_cryptodev_sec.c
@@ -194,9 +194,6 @@ set_session_misc_attributes(struct 
otx2_sec_session_ipsec_lp *sess,
sess->auth_iv_length = auth_xform->auth.iv.length;
sess->mac_len = auth_xform->auth.digest_length;
}
-
-   sess->ucmd_param1 = OTX2_IPSEC_PO_PER_PKT_IV;
-   sess->ucmd_param2 = 0;
 }
 
 static int
@@ -232,7 +229,6 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev 
*crypto_dev,
memset(sa, 0, sizeof(struct otx2_ipsec_po_out_sa));
 
/* Initialize lookaside ipsec private data */
-   lp->mode_type = OTX2_IPSEC_PO_TRANSPORT;
lp->ip_id = 0;
lp->seq_lo = 1;
lp->seq_hi = 0;
@@ -285,7 +281,6 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev 
*crypto_dev,
 
if (ipsec->mode == RTE_SECURITY_IPSEC_SA_MODE_TUNNEL) {
if (ipsec->tunnel.type == RTE_SECURITY_IPSEC_TUNNEL_IPV4) {
-   lp->mode_type = OTX2_IPSEC_PO_TUNNEL_IPV4;
ip->version_ihl = RTE_IPV4_VHL_DEF;
ip->time_to_live = ipsec->tunnel.ipv4.ttl;
ip->type_of_service |= (ipsec->tunnel.ipv4.dscp << 2);
@@ -298,7 +293,6 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev 
*crypto_dev,
} else if (ipsec->tunnel.type ==
RTE_SECURITY_IPSEC_TUNNEL_IPV6) {
 
-   lp->mode_type = OTX2_IPSEC_PO_TUNNEL_IPV6;
if (ctl->enc_type == OTX2_IPSEC_PO_SA_ENC_AES_GCM) {
template = &sa->aes_gcm.template;
ctx_len = offsetof(struct otx2_ipsec_po_out_sa,
@@ -387,6 +381,10 @@ crypto_sec_ipsec_outb_session_create(struct rte_cryptodev 
*crypto_dev,
lp->ucmd_opcode = (lp->ctx_len << 8) |
(OTX2_IPSEC_PO_PROCESS_IPSEC_OUTB);
 
+   /* Set per packet IV and IKEv2 bits */
+   lp->ucmd_param1 = BIT(11) | BIT(9);
+   lp->ucmd_param2 = 0;
+
set_session_misc_attributes(lp, crypto_xform,
auth_xform, cipher_xform);
 
@@ -429,20 +427,12 @@ crypto_sec_ipsec_inb_session_create(struct rte_cryptodev 
*crypto_dev,
if (ret)
return ret;
 
-   lp->mode_type = OTX2_IPSEC_PO_TRANSPORT;
-
auth_xform = crypto_xform;
cipher_xform = crypto_xform->next;
 
cipher_key_len = 0;
auth_key_len = 0;
 
-   if (ipsec->mode == RTE_SECURITY_IPSEC_SA_MODE_TUNNEL)
-   lp->mode_type = (ipsec->tunnel.type ==
-   RTE_SECURITY_IPSEC_TUNNEL_IPV4) ?
-   OTX2_IPSEC_PO_TUNNEL_IPV4 :
-   OTX2_IPSEC_PO_TUNNEL_IPV6;
-
if (crypto_xform->type == RTE_CRYPTO_SYM_XFORM_AEAD) {
if (crypto_xform->aead.algo == RTE_CRYPTO_AEAD_AES_GCM)
memcpy(sa->iv.gcm.nonce, &ipsec->salt, 4);
@@ -482,6 +472,10 @@ crypt

[dpdk-dev] [PATCH v19 0/5] Add PIE support for HQoS library

[Liguzinski, WojciechX]

DPDK sched library is equipped with mechanism that secures it from the 
bufferbloat problem
which is a situation when excess buffers in the network cause high latency and 
latency
variation. Currently, it supports RED for active queue management. However, more
advanced queue management is required to address this problem and provide 
desirable
quality of service to users.

This solution (RFC) proposes usage of new algorithm called "PIE" (Proportional 
Integral
controller Enhanced) that can effectively and directly control queuing latency 
to address
the bufferbloat problem.

The implementation of mentioned functionality includes modification of existing 
and
adding a new set of data structures to the library, adding PIE related APIs.
This affects structures in public API/ABI. That is why deprecation notice is 
going
to be prepared and sent.

Liguzinski, WojciechX (5):
  sched: add PIE based congestion management
  example/qos_sched: add PIE support
  example/ip_pipeline: add PIE support
  doc/guides/prog_guide: added PIE
  app/test: add tests for PIE

 app/test/meson.build |4 +
 app/test/test_pie.c  | 1065 ++
 config/rte_config.h  |1 -
 doc/guides/prog_guide/glossary.rst   |3 +
 doc/guides/prog_guide/qos_framework.rst  |   64 +-
 doc/guides/prog_guide/traffic_management.rst |   13 +-
 drivers/net/softnic/rte_eth_softnic_tm.c |6 +-
 examples/ip_pipeline/tmgr.c  |  142 +--
 examples/qos_sched/cfg_file.c|  127 ++-
 examples/qos_sched/cfg_file.h|5 +
 examples/qos_sched/init.c|   27 +-
 examples/qos_sched/main.h|3 +
 examples/qos_sched/profile.cfg   |  196 ++--
 lib/sched/meson.build|3 +-
 lib/sched/rte_pie.c  |   86 ++
 lib/sched/rte_pie.h  |  398 +++
 lib/sched/rte_sched.c|  241 ++--
 lib/sched/rte_sched.h|   63 +-
 lib/sched/version.map|4 +
 19 files changed, 2172 insertions(+), 279 deletions(-)
 create mode 100644 app/test/test_pie.c
 create mode 100644 lib/sched/rte_pie.c
 create mode 100644 lib/sched/rte_pie.h

-- 
2.25.1

[dpdk-dev] [PATCH v19 1/5] sched: add PIE based congestion management

[Liguzinski, WojciechX]

Implement PIE based congestion management based on rfc8033

Signed-off-by: Liguzinski, WojciechX 
Acked-by: Cristian Dumitrescu 
Acked-by: Jasvinder Singh 

--
Changes in V19:
- ACKs included in patches

Changes in V18:
- Resolved merge conflict in lib/sched/meson.build after rebasing ontop of main
- Reverted whitespace change in app_thread.c - comment from Stephen Hemminger

Changes in V17:
- Corrected paragraph link naming in qos_framework.rst to fix CI builds

Changes in V16:
- Fixed 'title underline too short' error in qos_framework.rst
- Applied __rte_unused macro to parameters in rte_sched_port_pie_dequeue()

---
 drivers/net/softnic/rte_eth_softnic_tm.c |   6 +-
 lib/sched/meson.build|   3 +-
 lib/sched/rte_pie.c  |  82 +
 lib/sched/rte_pie.h  | 393 +++
 lib/sched/rte_sched.c| 241 +-
 lib/sched/rte_sched.h|  63 +++-
 lib/sched/version.map|   4 +
 7 files changed, 702 insertions(+), 90 deletions(-)
 create mode 100644 lib/sched/rte_pie.c
 create mode 100644 lib/sched/rte_pie.h

diff --git a/drivers/net/softnic/rte_eth_softnic_tm.c 
b/drivers/net/softnic/rte_eth_softnic_tm.c
index 90baba15ce..e74092ce7f 100644
--- a/drivers/net/softnic/rte_eth_softnic_tm.c
+++ b/drivers/net/softnic/rte_eth_softnic_tm.c
@@ -420,7 +420,7 @@ pmd_tm_node_type_get(struct rte_eth_dev *dev,
return 0;
 }
 
-#ifdef RTE_SCHED_RED
+#ifdef RTE_SCHED_CMAN
 #define WRED_SUPPORTED 1
 #else
 #define WRED_SUPPORTED 0
@@ -2306,7 +2306,7 @@ tm_tc_wred_profile_get(struct rte_eth_dev *dev, uint32_t 
tc_id)
return NULL;
 }
 
-#ifdef RTE_SCHED_RED
+#ifdef RTE_SCHED_CMAN
 
 static void
 wred_profiles_set(struct rte_eth_dev *dev, uint32_t subport_id)
@@ -2321,7 +2321,7 @@ wred_profiles_set(struct rte_eth_dev *dev, uint32_t 
subport_id)
for (tc_id = 0; tc_id < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; tc_id++)
for (color = RTE_COLOR_GREEN; color < RTE_COLORS; color++) {
struct rte_red_params *dst =
-   &pp->red_params[tc_id][color];
+   &pp->cman_params->red_params[tc_id][color];
struct tm_wred_profile *src_wp =
tm_tc_wred_profile_get(dev, tc_id);
struct rte_tm_red_params *src =
diff --git a/lib/sched/meson.build b/lib/sched/meson.build
index 8ced4547aa..df75db51ed 100644
--- a/lib/sched/meson.build
+++ b/lib/sched/meson.build
@@ -7,11 +7,12 @@ if is_windows
 subdir_done()
 endif
 
-sources = files('rte_sched.c', 'rte_red.c', 'rte_approx.c')
+sources = files('rte_sched.c', 'rte_red.c', 'rte_approx.c', 'rte_pie.c')
 headers = files(
 'rte_approx.h',
 'rte_red.h',
 'rte_sched.h',
 'rte_sched_common.h',
+'rte_pie.h',
 )
 deps += ['mbuf', 'meter']
diff --git a/lib/sched/rte_pie.c b/lib/sched/rte_pie.c
new file mode 100644
index 00..2fcecb2db4
--- /dev/null
+++ b/lib/sched/rte_pie.c
@@ -0,0 +1,82 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2020 Intel Corporation
+ */
+
+#include 
+
+#include "rte_pie.h"
+#include 
+#include 
+#include 
+
+#ifdef __INTEL_COMPILER
+#pragma warning(disable:2259) /* conversion may lose significant bits */
+#endif
+
+void
+rte_pie_rt_data_init(struct rte_pie *pie)
+{
+   if (pie == NULL) {
+   /* Allocate memory to use the PIE data structure */
+   pie = rte_malloc(NULL, sizeof(struct rte_pie), 0);
+
+   if (pie == NULL)
+   RTE_LOG(ERR, SCHED, "%s: Memory allocation fails\n", 
__func__);
+   }
+
+   pie->active = 0;
+   pie->in_measurement = 0;
+   pie->departed_bytes_count = 0;
+   pie->start_measurement = 0;
+   pie->last_measurement = 0;
+   pie->qlen = 0;
+   pie->avg_dq_time = 0;
+   pie->burst_allowance = 0;
+   pie->qdelay_old = 0;
+   pie->drop_prob = 0;
+   pie->accu_prob = 0;
+}
+
+int
+rte_pie_config_init(struct rte_pie_config *pie_cfg,
+   const uint16_t qdelay_ref,
+   const uint16_t dp_update_interval,
+   const uint16_t max_burst,
+   const uint16_t tailq_th)
+{
+   uint64_t tsc_hz = rte_get_tsc_hz();
+
+   if (pie_cfg == NULL)
+   return -1;
+
+   if (qdelay_ref <= 0) {
+   RTE_LOG(ERR, SCHED,
+   "%s: Incorrect value for qdelay_ref\n", __func__);
+   return -EINVAL;
+   }
+
+   if (dp_update_interval <= 0) {
+   RTE_LOG(ERR, SCHED,
+   "%s: Incorrect value for dp_update_interval\n", 
__func__);
+   return -EINVAL;
+   }
+
+   if (max_burst <= 0) {
+   RTE_LOG(ERR, SCHED,
+   "%s: Incorrect value for max_burst\n", __func__);
+

[dpdk-dev] [PATCH v19 3/5] example/ip_pipeline: add PIE support

[Liguzinski, WojciechX]

Adding the PIE support for IP Pipeline

Signed-off-by: Liguzinski, WojciechX 
Acked-by: Cristian Dumitrescu 
Acked-by: Jasvinder Singh 
---
 examples/ip_pipeline/tmgr.c | 142 +++-
 1 file changed, 74 insertions(+), 68 deletions(-)

diff --git a/examples/ip_pipeline/tmgr.c b/examples/ip_pipeline/tmgr.c
index e4e364cbc0..b138e885cf 100644
--- a/examples/ip_pipeline/tmgr.c
+++ b/examples/ip_pipeline/tmgr.c
@@ -17,6 +17,77 @@ static uint32_t n_subport_profiles;
 static struct rte_sched_pipe_params
pipe_profile[TMGR_PIPE_PROFILE_MAX];
 
+#ifdef RTE_SCHED_CMAN
+static struct rte_sched_cman_params cman_params = {
+   .red_params = {
+   /* Traffic Class 0 Colors Green / Yellow / Red */
+   [0][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [0][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [0][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+
+   /* Traffic Class 1 - Colors Green / Yellow / Red */
+   [1][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [1][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [1][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+
+   /* Traffic Class 2 - Colors Green / Yellow / Red */
+   [2][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [2][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [2][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+
+   /* Traffic Class 3 - Colors Green / Yellow / Red */
+   [3][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [3][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [3][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+
+   /* Traffic Class 4 - Colors Green / Yellow / Red */
+   [4][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [4][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [4][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+
+   /* Traffic Class 5 - Colors Green / Yellow / Red */
+   [5][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [5][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [5][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+
+   /* Traffic Class 6 - Colors Green / Yellow / Red */
+   [6][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [6][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [6][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+
+   /* Traffic Class 7 - Colors Green / Yellow / Red */
+   [7][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [7][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [7][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+
+   /* Traffic Class 8 - Colors Green / Yellow / Red */
+   [8][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [8][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [8][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+
+   /* Traffic Class 9 - Colors Green / Yellow / Red */
+   [9][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [9][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [9][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+
+   /* Traffic Class 10 - Colors Green / Yellow / Red */
+   [10][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [10][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [10][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+
+   /* Traffic Class 11 - Colors Green / Yellow / Red */
+   [11][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [11][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [11][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+
+   /* Traffic Class 12 - Colors Green / Yellow / Red */
+   [12][0] = {.min_th = 48, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [12][1] = {.min_th = 40, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   [12][2] = {.min_th = 32, .max_th = 64, .maxp_inv = 10, .wq_log2 
= 9},
+   },
+};
+#endif /* RTE_SCHED_CMAN 

[dpdk-dev] [PATCH v19 2/5] example/qos_sched: add PIE support

[Liguzinski, WojciechX]

patch add support enable PIE or RED by
parsing config file.

Signed-off-by: Liguzinski, WojciechX 
Acked-by: Cristian Dumitrescu 
Acked-by: Jasvinder Singh 
---
 config/rte_config.h|   1 -
 examples/qos_sched/cfg_file.c  | 127 +++--
 examples/qos_sched/cfg_file.h  |   5 +
 examples/qos_sched/init.c  |  27 +++--
 examples/qos_sched/main.h  |   3 +
 examples/qos_sched/profile.cfg | 196 ++---
 6 files changed, 250 insertions(+), 109 deletions(-)

diff --git a/config/rte_config.h b/config/rte_config.h
index 1a66b42fcc..6ec687a555 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -89,7 +89,6 @@
 #define RTE_MAX_LCORE_FREQS 64
 
 /* rte_sched defines */
-#undef RTE_SCHED_RED
 #undef RTE_SCHED_COLLECT_STATS
 #undef RTE_SCHED_SUBPORT_TC_OV
 #define RTE_SCHED_PORT_N_GRINDERS 8
diff --git a/examples/qos_sched/cfg_file.c b/examples/qos_sched/cfg_file.c
index cd167bd8e6..450482f07d 100644
--- a/examples/qos_sched/cfg_file.c
+++ b/examples/qos_sched/cfg_file.c
@@ -229,6 +229,40 @@ cfg_load_subport_profile(struct rte_cfgfile *cfg,
return 0;
 }
 
+#ifdef RTE_SCHED_CMAN
+void set_subport_cman_params(struct rte_sched_subport_params *subport_p,
+   struct rte_sched_cman_params cman_p)
+{
+   int j, k;
+   subport_p->cman_params->cman_mode = cman_p.cman_mode;
+
+   for (j = 0; j < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; j++) {
+   if (subport_p->cman_params->cman_mode ==
+   RTE_SCHED_CMAN_RED) {
+   for (k = 0; k < RTE_COLORS; k++) {
+   subport_p->cman_params->red_params[j][k].min_th 
=
+   cman_p.red_params[j][k].min_th;
+   subport_p->cman_params->red_params[j][k].max_th 
=
+   cman_p.red_params[j][k].max_th;
+   
subport_p->cman_params->red_params[j][k].maxp_inv =
+   cman_p.red_params[j][k].maxp_inv;
+   
subport_p->cman_params->red_params[j][k].wq_log2 =
+   cman_p.red_params[j][k].wq_log2;
+   }
+   } else {
+   subport_p->cman_params->pie_params[j].qdelay_ref =
+   cman_p.pie_params[j].qdelay_ref;
+   
subport_p->cman_params->pie_params[j].dp_update_interval =
+   cman_p.pie_params[j].dp_update_interval;
+   subport_p->cman_params->pie_params[j].max_burst =
+   cman_p.pie_params[j].max_burst;
+   subport_p->cman_params->pie_params[j].tailq_th =
+   cman_p.pie_params[j].tailq_th;
+   }
+   }
+}
+#endif
+
 int
 cfg_load_subport(struct rte_cfgfile *cfg, struct rte_sched_subport_params 
*subport_params)
 {
@@ -242,25 +276,26 @@ cfg_load_subport(struct rte_cfgfile *cfg, struct 
rte_sched_subport_params *subpo
memset(active_queues, 0, sizeof(active_queues));
n_active_queues = 0;
 
-#ifdef RTE_SCHED_RED
-   char sec_name[CFG_NAME_LEN];
-   struct rte_red_params 
red_params[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE][RTE_COLORS];
+#ifdef RTE_SCHED_CMAN
+   struct rte_sched_cman_params cman_params = {
+   .cman_mode = RTE_SCHED_CMAN_RED,
+   .red_params = { },
+   };
 
-   snprintf(sec_name, sizeof(sec_name), "red");
-
-   if (rte_cfgfile_has_section(cfg, sec_name)) {
+   if (rte_cfgfile_has_section(cfg, "red")) {
+   cman_params.cman_mode = RTE_SCHED_CMAN_RED;
 
for (i = 0; i < RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE; i++) {
char str[32];
 
-   /* Parse WRED min thresholds */
-   snprintf(str, sizeof(str), "tc %d wred min", i);
-   entry = rte_cfgfile_get_entry(cfg, sec_name, str);
+   /* Parse RED min thresholds */
+   snprintf(str, sizeof(str), "tc %d red min", i);
+   entry = rte_cfgfile_get_entry(cfg, "red", str);
if (entry) {
char *next;
/* for each packet colour (green, yellow, red) 
*/
for (j = 0; j < RTE_COLORS; j++) {
-   red_params[i][j].min_th
+   cman_params.red_params[i][j].min_th
= (uint16_t)strtol(entry, 
&next, 10);
if (next == NULL)
break;
@@ -268,14 +303,14 @@ cfg_load_subport(struct rte_cfgfile *cfg, struct 
rte_sched_subport_params *subpo
}
 

[dpdk-dev] [PATCH v19 4/5] doc/guides/prog_guide: added PIE

[Liguzinski, WojciechX]

Added PIE related information to documentation.

Signed-off-by: Liguzinski, WojciechX 
Acked-by: Cristian Dumitrescu 
Acked-by: Jasvinder Singh 
---
 doc/guides/prog_guide/glossary.rst   |  3 +
 doc/guides/prog_guide/qos_framework.rst  | 64 +---
 doc/guides/prog_guide/traffic_management.rst | 13 +++-
 3 files changed, 68 insertions(+), 12 deletions(-)

diff --git a/doc/guides/prog_guide/glossary.rst 
b/doc/guides/prog_guide/glossary.rst
index 7044a7df2a..fb0910ba5b 100644
--- a/doc/guides/prog_guide/glossary.rst
+++ b/doc/guides/prog_guide/glossary.rst
@@ -158,6 +158,9 @@ PCI
 PHY
An abbreviation for the physical layer of the OSI model.
 
+PIE
+   Proportional Integral Controller Enhanced (RFC8033)
+
 pktmbuf
An *mbuf* carrying a network packet.
 
diff --git a/doc/guides/prog_guide/qos_framework.rst 
b/doc/guides/prog_guide/qos_framework.rst
index 3b8a1184b0..7c37b78804 100644
--- a/doc/guides/prog_guide/qos_framework.rst
+++ b/doc/guides/prog_guide/qos_framework.rst
@@ -56,7 +56,8 @@ A functional description of each block is provided in the 
following table.
|   ||  
  |

+---+++
| 7 | Dropper| Congestion management using the Random Early 
Detection (RED) algorithm |
-   |   || (specified by the Sally Floyd - Van Jacobson 
paper) or Weighted RED (WRED).|
+   |   || (specified by the Sally Floyd - Van Jacobson 
paper) or Weighted RED (WRED) |
+   |   || or Proportional Integral Controller Enhanced 
(PIE).|
|   || Drop packets based on the current scheduler 
queue load level and packet|
|   || priority. When congestion is experienced, 
lower priority packets are dropped   |
|   || first.   
  |
@@ -421,7 +422,7 @@ No input packet can be part of more than one pipeline stage 
at a given time.
 The congestion management scheme implemented by the enqueue pipeline described 
above is very basic:
 packets are enqueued until a specific queue becomes full,
 then all the packets destined to the same queue are dropped until packets are 
consumed (by the dequeue operation).
-This can be improved by enabling RED/WRED as part of the enqueue pipeline 
which looks at the queue occupancy and
+This can be improved by enabling RED/WRED or PIE as part of the enqueue 
pipeline which looks at the queue occupancy and
 packet priority in order to yield the enqueue/drop decision for a specific 
packet
 (as opposed to enqueuing all packets / dropping all packets indiscriminately).
 
@@ -1155,13 +1156,13 @@ If the number of queues is small,
 then the performance of the port scheduler for the same level of active 
traffic is expected to be worse than
 the performance of a small set of message passing queues.
 
-.. _Dropper:
+.. _Droppers:
 
-Dropper

+Droppers
+
 
 The purpose of the DPDK dropper is to drop packets arriving at a packet 
scheduler to avoid congestion.
-The dropper supports the Random Early Detection (RED),
+The dropper supports the Proportional Integral Controller Enhanced (PIE), 
Random Early Detection (RED),
 Weighted Random Early Detection (WRED) and tail drop algorithms.
 :numref:`figure_blk_diag_dropper` illustrates how the dropper integrates with 
the scheduler.
 The DPDK currently does not support congestion management
@@ -1174,9 +1175,13 @@ so the dropper provides the only method for congestion 
avoidance.
High-level Block Diagram of the DPDK Dropper
 
 
-The dropper uses the Random Early Detection (RED) congestion avoidance 
algorithm as documented in the reference publication.
-The purpose of the RED algorithm is to monitor a packet queue,
+The dropper uses one of two congestion avoidance algorithms:
+   - the Random Early Detection (RED) as documented in the reference 
publication.
+   - the Proportional Integral Controller Enhanced (PIE) as documented in 
RFC8033 publication.
+
+The purpose of the RED/PIE algorithm is to monitor a packet queue,
 determine the current congestion level in the queue and decide whether an 
arriving packet should be enqueued or dropped.
+
 The RED algorithm uses an Exponential Weighted Moving Average (EWMA) filter to 
compute average queue size which
 gives an indication of the current congestion level in the queue.
 
@@ -1192,7 +1197,7 @@ This occurs when a packet queue has reached maximum 
capacity and cannot store an
 In this situation, all arriving packets are dropped.
 
 The flow through the dropper is illustrated in 
:numref:`figure_flow_tru_droppper`.
-The RED/WRED algorithm is exercised first and tail drop second.
+T

[dpdk-dev] [PATCH v19 5/5] app/test: add tests for PIE

[Liguzinski, WojciechX]

Tests for PIE code added to test application.

Signed-off-by: Liguzinski, WojciechX 
Acked-by: Cristian Dumitrescu 
Acked-by: Jasvinder Singh 
---
 app/test/meson.build |4 +
 app/test/test_pie.c  | 1065 ++
 lib/sched/rte_pie.c  |6 +-
 lib/sched/rte_pie.h  |   17 +-
 4 files changed, 1085 insertions(+), 7 deletions(-)
 create mode 100644 app/test/test_pie.c

diff --git a/app/test/meson.build b/app/test/meson.build
index 20f36a1803..2ac716629b 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -115,6 +115,7 @@ test_sources = files(
 'test_reciprocal_division.c',
 'test_reciprocal_division_perf.c',
 'test_red.c',
+'test_pie.c',
 'test_reorder.c',
 'test_rib.c',
 'test_rib6.c',
@@ -249,6 +250,7 @@ fast_tests = [
 ['prefetch_autotest', true],
 ['rcu_qsbr_autotest', true],
 ['red_autotest', true],
+['pie_autotest', true],
 ['rib_autotest', true],
 ['rib6_autotest', true],
 ['ring_autotest', true],
@@ -300,6 +302,7 @@ perf_test_names = [
 'fib_slow_autotest',
 'fib_perf_autotest',
 'red_all',
+'pie_all',
 'barrier_autotest',
 'hash_multiwriter_autotest',
 'timer_racecond_autotest',
@@ -313,6 +316,7 @@ perf_test_names = [
 'fib6_perf_autotest',
 'rcu_qsbr_perf_autotest',
 'red_perf',
+'pie_perf',
 'distributor_perf_autotest',
 'pmd_perf_autotest',
 'stack_perf_autotest',
diff --git a/app/test/test_pie.c b/app/test/test_pie.c
new file mode 100644
index 00..dfa69d1c7e
--- /dev/null
+++ b/app/test/test_pie.c
@@ -0,0 +1,1065 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2014 Intel Corporation
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "test.h"
+
+#include 
+
+#ifdef __INTEL_COMPILER
+#pragma warning(disable:2259)   /* conversion may lose significant bits */
+#pragma warning(disable:181)/* Arg incompatible with format string */
+#endif
+
+/**< structures for testing rte_pie performance and function */
+struct test_rte_pie_config {/**< Test structure for RTE_PIE config */
+   struct rte_pie_config *pconfig; /**< RTE_PIE configuration parameters */
+   uint8_t num_cfg;/**< Number of RTE_PIE configs to test 
*/
+   uint16_t qdelay_ref;/**< Latency Target (milliseconds) */
+   uint16_t *dp_update_interval;   /**< Update interval for drop 
probability
+ * (milliseconds)
+ */
+   uint16_t *max_burst;/**< Max Burst Allowance (milliseconds) 
*/
+   uint16_t tailq_th;  /**< Tailq drop threshold (packet 
counts) */
+};
+
+struct test_queue { /**< Test structure for RTE_PIE Queues */
+   struct rte_pie *pdata_in;   /**< RTE_PIE runtime data input */
+   struct rte_pie *pdata_out;  /**< RTE_PIE runtime data 
output*/
+   uint32_t num_queues;/**< Number of RTE_PIE queues to test */
+   uint32_t *qlen; /**< Queue size */
+   uint32_t q_ramp_up; /**< Num of enqueues to ramp up the 
queue */
+   double drop_tolerance;  /**< Drop tolerance of packets not 
enqueued */
+};
+
+struct test_var {   /**< Test variables used for testing 
RTE_PIE */
+   uint32_t num_iterations;/**< Number of test iterations */
+   uint32_t num_ops;   /**< Number of test operations */
+   uint64_t clk_freq;  /**< CPU clock frequency */
+   uint32_t *dropped;  /**< Test operations dropped */
+   uint32_t *enqueued; /**< Test operations enqueued */
+   uint32_t *dequeued; /**< Test operations dequeued */
+};
+
+struct test_config {/**< Primary test structure for RTE_PIE */
+   const char *ifname; /**< Interface name */
+   const char *msg;/**< Test message for display */
+   const char *htxt;   /**< Header txt display for result 
output */
+   struct test_rte_pie_config *tconfig; /**< Test structure for RTE_PIE 
config */
+   struct test_queue *tqueue;  /**< Test structure for RTE_PIE Queues 
*/
+   struct test_var *tvar;  /**< Test variables used for testing 
RTE_PIE */
+   uint32_t *tlevel;   /**< Queue levels */
+};
+
+enum test_result {
+   FAIL = 0,
+   PASS
+};
+
+/**< Test structure to define tests to run */
+struct tests {
+   struct test_config *testcfg;
+   enum test_result (*testfn)(struct test_config *cfg);
+};
+
+struct rdtsc_prof {
+   uint64_t clk_start;
+   uint64_t clk_min;   /**< min clocks */
+   uint64_t clk_max;   /**< max 

[dpdk-dev] [PATCH] examples/fips_validation: fix device start

[Fan Zhang]

Fixes: 261bbff75e34 ("examples: use separate crypto session mempools")
Cc: roy.fan.zh...@intel.com

Bugzilla Link: https://bugs.dpdk.org/show_bug.cgi?id=842

This patch fixes the missing device start for fips validation
sample app.

Signed-off-by: Fan Zhang 
---
 examples/fips_validation/main.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index b0de3d269a..dc40bffe7d 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -134,6 +134,10 @@ cryptodev_fips_validate_app_int(void)
if (ret < 0)
goto error_exit;
 
+   ret = rte_cryptodev_start(env.dev_id);
+   if (ret < 0)
+   goto error_exit;
+
return 0;
 
 error_exit:
-- 
2.25.1

Re: [dpdk-dev] [PATCH] ethdev: promote port ownership API as stable

[Ferruh Yigit]

On 10/28/2021 9:34 AM, Thomas Monjalon wrote:

The port ownership concept was introduced in ethdev in DPDK 18.02.
Not sure it is used by applications except those using failsafe or netvsc.
It can also be used by libraries or applications to sort out
how ports are controlled.

Hiding sub-ports controlled by failsafe or netvsc look to be enough
justification to promote this API as stable.

Signed-off-by: Thomas Monjalon 


There is a defect in the 'rte_eth_dev_owner_delete()', which cause a crash,
it is fixed in my ethdev unit test patch:
https://patches.dpdk.org/project/dpdk/patch/20210716142800.3853651-8-ferruh.yi...@intel.com/

I think we should get the fix first.

And the crash not detected/reported until now makes me think API is still
not used much, I wonder if we should wait a little more to mature them.


Also only internal user of the  API is 'drivers/net/netvsc', I wonder if
PMD detect the crash?

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

[Burakov, Anatoly]

Hi Chenbo,


And do we need backport? As 'return -1' does not align with the API doxygen.

Thanks,
Chenbo

Maybe it's the FreeBSD implementation that needs to be adjusted then, 
because none of those functions are valid on FreeBSD, and the 
documentation for VFIO functions explicitly mentions that on FreeBSD, 
they should return an error. I went with adjusting Linux implementation 
to minimize the amount of changes we have to make (and only change code 
path that no one uses in the first place), but maybe that was a wrong 
decision.


I'm not sure if changing the API return value to match what was 
documented counts as an API change, so maybe backport to stable is not 
advised here.


--
Thanks,
Anatoly

Re: [dpdk-dev] [PATCH] test/crypto: refactor docsis to show hidden cases

[Coyle, David]

Hi Rebecca, see below


> -Original Message-
> From: Troy, Rebecca 
> 
> In the current implementation, the docsis test cases are running and being
> reported as one test, despite the fact that multiple test cases are hidden
> inside i.e. "test_DOCSIS_PROTO_all" runs
> 52 test cases. Each docsis test case should be reported individually instead.

[DC] Should make "docsis" all uppercase in the commit message - "DOCSIS"

> 
> This commit achieves this by removing the use of the
> test_DOCSIS_PROTO_all function and statically listing the test cases to run
> when building the test suite, which are then reported to the user by
> description.
> 
> Signed-off-by: Rebecca Troy 
> ---
>  app/test/test_cryptodev.c | 265 +++---
>  ...t_cryptodev_security_docsis_test_vectors.h | 159 +--
>  2 files changed, 241 insertions(+), 183 deletions(-)
> 
> 



> +
>  static struct unit_test_suite docsis_proto_testsuite  = {
>   .suite_name = "Docsis Proto Unit Test Suite",

[DC] Outside the specific changes of this patch, but "Docsis" should be all 
uppercase in the
suite name too - "DOCSIS"... could take this opportunity to fix up this minor 
one

>   .setup = docsis_proto_testsuite_setup,
>   .unit_test_cases = {
> - TEST_CASE_ST(ut_setup_security, ut_teardown,
> - test_DOCSIS_PROTO_all),
> + /* Uplink */
> + ADD_UPLINK_TESTCASE(docsis_test_case_1)
> + ADD_UPLINK_TESTCASE(docsis_test_case_2)
> + ADD_UPLINK_TESTCASE(docsis_test_case_3)
> + ADD_UPLINK_TESTCASE(docsis_test_case_4)



> 
> -struct docsis_test_data docsis_test_case_1 = {
> +const struct docsis_test_data docsis_test_case_1 = {
> + .test_descr_uplink = {"AES-DOCSIS-BPI-128 and CRC Verify (24-byte "
> + "frame, Small offset and runt block encryption)"},
> + .test_descr_downlink = {"CRC Generate and AES-DOCSIS-BPI-128
> (24-byte "
> + "frame, Small offset and runt block encryption)"},

[DC] This one is my fault when I supplied the descriptions, so apologies about 
this,
but all the uplink descriptions should say "decryption" instead of "encryption"

Also I think all the descriptions should say "Uplink" or "Downlink" at the 
start.
This can be inferred from the order of AES-DOCSIS-BPI and CRC in the 
description, but
when I ran the test cases, I still had to think are these Uplink or Downlink 
tests.
It would be much clearer if it's stated explicitly

Regards,
David

[dpdk-dev] [PATCH v3 1/3] eventdev/eth_rx: add queue stats get and reset APIs

[Naga Harish K S V]

This patch adds new api ``rte_event_eth_rx_adapter_queue_stats_get`` to
retrieve queue stats. The queue stats are in the format
``struct rte_event_eth_rx_adapter_queue_stats``.

For resetting the queue stats,
``rte_event_eth_rx_adapter_queue_stats_reset`` api is added.

The adapter stats_get and stats_reset apis are also updated to
handle queue level event buffer use case.

Signed-off-by: Naga Harish K S V 
Acked-by: Jay Jayatheerthan 
---
v2:
* added pmd callback support for adapter queue_stats_get and
  queue_stats_reset apis.

v3:
* addressed coding style review comments
---
 .../prog_guide/event_ethernet_rx_adapter.rst  |  11 +
 lib/eventdev/eventdev_pmd.h   |  52 
 lib/eventdev/rte_event_eth_rx_adapter.c   | 268 +++---
 lib/eventdev/rte_event_eth_rx_adapter.h   |  66 +
 lib/eventdev/version.map  |   2 +
 5 files changed, 356 insertions(+), 43 deletions(-)

diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst 
b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
index 8b58130fc5..67b11e1563 100644
--- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
+++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
@@ -166,6 +166,17 @@ flags for handling received packets, event queue 
identifier, scheduler type,
 event priority, polling frequency of the receive queue and flow identifier
 in struct ``rte_event_eth_rx_adapter_queue_conf``.
 
+Getting and resetting Adapter queue stats
+~
+
+The ``rte_event_eth_rx_adapter_queue_stats_get()`` function reports
+adapter queue counters defined in struct 
``rte_event_eth_rx_adapter_queue_stats``.
+This function reports queue level stats only when queue level event buffer is
+used otherwise it returns -EINVAL.
+
+The ``rte_event_eth_rx_adapter_queue_stats_reset`` function can be used to
+reset queue level stats when queue level event buffer is in use.
+
 Interrupt Based Rx Queues
 ~~
 
diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h
index d009e24309..3ba49d1fd4 100644
--- a/lib/eventdev/eventdev_pmd.h
+++ b/lib/eventdev/eventdev_pmd.h
@@ -749,6 +749,53 @@ typedef int (*eventdev_eth_rx_adapter_stats_get)
 typedef int (*eventdev_eth_rx_adapter_stats_reset)
(const struct rte_eventdev *dev,
const struct rte_eth_dev *eth_dev);
+
+struct rte_event_eth_rx_adapter_queue_stats;
+
+/**
+ * Retrieve ethernet Rx adapter queue statistics.
+ *
+ * @param dev
+ *   Event device pointer
+ *
+ * @param eth_dev
+ *   Ethernet device pointer
+ *
+ * @param rx_queue_id
+ *  Ethernet device receive queue index.
+ *
+ * @param[out] q_stats
+ *   Pointer to queue stats structure
+ *
+ * @return
+ *   Return 0 on success.
+ */
+typedef int (*eventdev_eth_rx_adapter_q_stats_get)
+   (const struct rte_eventdev *dev,
+const struct rte_eth_dev *eth_dev,
+uint16_t rx_queue_id,
+struct rte_event_eth_rx_adapter_queue_stats *q_stats);
+
+/**
+ * Reset ethernet Rx adapter queue statistics.
+ *
+ * @param dev
+ *   Event device pointer
+ *
+ * @param eth_dev
+ *   Ethernet device pointer
+ *
+ * @param rx_queue_id
+ *  Ethernet device receive queue index.
+ *
+ * @return
+ *   Return 0 on success.
+ */
+typedef int (*eventdev_eth_rx_adapter_q_stats_reset)
+   (const struct rte_eventdev *dev,
+const struct rte_eth_dev *eth_dev,
+uint16_t rx_queue_id);
+
 /**
  * Start eventdev selftest.
  *
@@ -1224,6 +1271,11 @@ struct eventdev_ops {
eventdev_crypto_adapter_stats_reset crypto_adapter_stats_reset;
/**< Reset crypto stats */
 
+   eventdev_eth_rx_adapter_q_stats_get eth_rx_adapter_queue_stats_get;
+   /**< Get ethernet Rx queue stats */
+   eventdev_eth_rx_adapter_q_stats_reset eth_rx_adapter_queue_stats_reset;
+   /**< Reset ethernet Rx queue stats */
+
eventdev_eth_tx_adapter_caps_get_t eth_tx_adapter_caps_get;
/**< Get ethernet Tx adapter capabilities */
 
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c 
b/lib/eventdev/rte_event_eth_rx_adapter.c
index a175c61551..3adec52eac 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -245,6 +245,10 @@ struct eth_rx_queue_info {
uint64_t event;
struct eth_rx_vector_data vector_data;
struct eth_event_enqueue_buffer *event_buf;
+   /* use adapter stats struct for queue level stats,
+* as same stats need to be updated for adapter and queue
+*/
+   struct rte_event_eth_rx_adapter_stats *stats;
 };
 
 static struct event_eth_rx_adapter **event_eth_rx_adapter;
@@ -268,14 +272,18 @@ rxa_validate_id(uint8_t id)
 
 static inline struct eth_event_enqueue_buffer *
 rxa_event_buf_get(struct event_eth_rx_adapter *rx_adapter, uint16_t eth_dev_id,
-   

[dpdk-dev] [PATCH v3 2/3] eventdev/eth_rx: support telemetry

[Naga Harish K S V]

Added telemetry support for rxa_queue_stats and
rxa_queue_stats_reset to get and reset rx queue
stats respectively

Signed-off-by: Naga Harish K S V 
Acked-by: Jay Jayatheerthan 
---
 lib/eventdev/rte_event_eth_rx_adapter.c | 124 
 1 file changed, 124 insertions(+)

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c 
b/lib/eventdev/rte_event_eth_rx_adapter.c
index 3adec52eac..4e0829c492 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -3345,6 +3345,122 @@ handle_rxa_get_queue_conf(const char *cmd __rte_unused,
return 0;
 }
 
+static int
+handle_rxa_get_queue_stats(const char *cmd __rte_unused,
+  const char *params,
+  struct rte_tel_data *d)
+{
+   uint8_t rx_adapter_id;
+   uint16_t rx_queue_id;
+   int eth_dev_id;
+   char *token, *l_params;
+   struct rte_event_eth_rx_adapter_queue_stats q_stats;
+
+   if (params == NULL || strlen(params) == 0 || !isdigit(*params))
+   return -1;
+
+   /* Get Rx adapter ID from parameter string */
+   l_params = strdup(params);
+   token = strtok(l_params, ",");
+   rx_adapter_id = strtoul(token, NULL, 10);
+   RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(rx_adapter_id, -EINVAL);
+
+   token = strtok(NULL, ",");
+   if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+   return -1;
+
+   /* Get device ID from parameter string */
+   eth_dev_id = strtoul(token, NULL, 10);
+   RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(eth_dev_id, -EINVAL);
+
+   token = strtok(NULL, ",");
+   if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+   return -1;
+
+   /* Get Rx queue ID from parameter string */
+   rx_queue_id = strtoul(token, NULL, 10);
+   if (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {
+   RTE_EDEV_LOG_ERR("Invalid rx queue_id %u", rx_queue_id);
+   return -EINVAL;
+   }
+
+   token = strtok(NULL, "\0");
+   if (token != NULL)
+   RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
+" telemetry command, igrnoring");
+
+   if (rte_event_eth_rx_adapter_queue_stats_get(rx_adapter_id, eth_dev_id,
+   rx_queue_id, &q_stats)) {
+   RTE_EDEV_LOG_ERR("Failed to get Rx adapter queue stats");
+   return -1;
+   }
+
+   rte_tel_data_start_dict(d);
+   rte_tel_data_add_dict_u64(d, "rx_adapter_id", rx_adapter_id);
+   rte_tel_data_add_dict_u64(d, "eth_dev_id", eth_dev_id);
+   rte_tel_data_add_dict_u64(d, "rx_queue_id", rx_queue_id);
+   RXA_ADD_DICT(q_stats, rx_event_buf_count);
+   RXA_ADD_DICT(q_stats, rx_event_buf_size);
+   RXA_ADD_DICT(q_stats, rx_poll_count);
+   RXA_ADD_DICT(q_stats, rx_packets);
+   RXA_ADD_DICT(q_stats, rx_dropped);
+
+   return 0;
+}
+
+static int
+handle_rxa_queue_stats_reset(const char *cmd __rte_unused,
+const char *params,
+struct rte_tel_data *d __rte_unused)
+{
+   uint8_t rx_adapter_id;
+   uint16_t rx_queue_id;
+   int eth_dev_id;
+   char *token, *l_params;
+
+   if (params == NULL || strlen(params) == 0 || !isdigit(*params))
+   return -1;
+
+   /* Get Rx adapter ID from parameter string */
+   l_params = strdup(params);
+   token = strtok(l_params, ",");
+   rx_adapter_id = strtoul(token, NULL, 10);
+   RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(rx_adapter_id, -EINVAL);
+
+   token = strtok(NULL, ",");
+   if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+   return -1;
+
+   /* Get device ID from parameter string */
+   eth_dev_id = strtoul(token, NULL, 10);
+   RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(eth_dev_id, -EINVAL);
+
+   token = strtok(NULL, ",");
+   if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+   return -1;
+
+   /* Get Rx queue ID from parameter string */
+   rx_queue_id = strtoul(token, NULL, 10);
+   if (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {
+   RTE_EDEV_LOG_ERR("Invalid rx queue_id %u", rx_queue_id);
+   return -EINVAL;
+   }
+
+   token = strtok(NULL, "\0");
+   if (token != NULL)
+   RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
+" telemetry command, igrnoring");
+
+   if (rte_event_eth_rx_adapter_queue_stats_reset(rx_adapter_id,
+  eth_dev_id,
+  rx_queue_id)) {
+   RTE_EDEV_LOG_ERR("Failed to reset Rx adapter queue stats");
+   return -1;
+   }
+
+   return 0;
+}
+
 RTE_INIT(rxa_init_telemetry)
 {
   

[dpdk-dev] [PATCH v3 3/3] test/event: add unit test for Rx adapter

[Naga Harish K S V]

add unit test for rte_event_eth_rx_adapter_queue_stats_get() and
rte_event_eth_rx_adapter_queue_stats_reset() apis.

Signed-off-by: Naga Harish K S V 
Acked-by: Jay Jayatheerthan 
---
 app/test/test_event_eth_rx_adapter.c | 60 
 1 file changed, 60 insertions(+)

diff --git a/app/test/test_event_eth_rx_adapter.c 
b/app/test/test_event_eth_rx_adapter.c
index 1419f6f64d..7cb91b152f 100644
--- a/app/test/test_event_eth_rx_adapter.c
+++ b/app/test/test_event_eth_rx_adapter.c
@@ -471,6 +471,64 @@ adapter_queue_event_buf_test(void)
return TEST_SUCCESS;
 }
 
+static int
+adapter_queue_stats_test(void)
+{
+   int err;
+   struct rte_event ev;
+   uint32_t cap;
+   struct rte_event_eth_rx_adapter_queue_conf queue_config = {0};
+   struct rte_event_eth_rx_adapter_queue_stats q_stats;
+
+   err = rte_event_eth_rx_adapter_queue_stats_get(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0,
+   &q_stats);
+   TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
+
+   err = rte_event_eth_rx_adapter_queue_stats_reset(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0);
+   TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
+
+   err = rte_event_eth_rx_adapter_caps_get(TEST_DEV_ID, TEST_ETHDEV_ID,
+&cap);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   ev.queue_id = 0;
+   ev.sched_type = RTE_SCHED_TYPE_ATOMIC;
+   ev.priority = 0;
+
+   queue_config.rx_queue_flags = 0;
+   if (cap & RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) {
+   ev.flow_id = 1;
+   queue_config.rx_queue_flags =
+   RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID;
+   }
+   queue_config.ev = ev;
+   queue_config.servicing_weight = 1;
+   queue_config.event_buf_size = 1024;
+
+   err = rte_event_eth_rx_adapter_queue_add(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0,
+   &queue_config);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   err = rte_event_eth_rx_adapter_queue_stats_get(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0,
+   &q_stats);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   err = rte_event_eth_rx_adapter_queue_stats_reset(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   err = rte_event_eth_rx_adapter_queue_del(TEST_INST_ID,
+   TEST_ETHDEV_ID,
+   0);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   return TEST_SUCCESS;
+}
+
 static void
 adapter_free(void)
 {
@@ -940,6 +998,8 @@ static struct unit_test_suite event_eth_rx_tests = {
TEST_CASE_ST(adapter_create, adapter_free, adapter_queue_conf),
TEST_CASE_ST(adapter_create_with_params, adapter_free,
 adapter_queue_event_buf_test),
+   TEST_CASE_ST(adapter_create_with_params, adapter_free,
+adapter_queue_stats_test),
TEST_CASES_END() /**< NULL terminate unit test array */
}
 };
-- 
2.25.1

Re: [dpdk-dev] [PATCH] ethdev: promote port ownership API as stable

[Thomas Monjalon]

28/10/2021 12:22, Ferruh Yigit:
> On 10/28/2021 9:34 AM, Thomas Monjalon wrote:
> > The port ownership concept was introduced in ethdev in DPDK 18.02.
> > Not sure it is used by applications except those using failsafe or netvsc.
> > It can also be used by libraries or applications to sort out
> > how ports are controlled.
> > 
> > Hiding sub-ports controlled by failsafe or netvsc look to be enough
> > justification to promote this API as stable.
> > 
> > Signed-off-by: Thomas Monjalon 
> 
> There is a defect in the 'rte_eth_dev_owner_delete()', which cause a crash,
> it is fixed in my ethdev unit test patch:
> https://patches.dpdk.org/project/dpdk/patch/20210716142800.3853651-8-ferruh.yi...@intel.com/
> 
> I think we should get the fix first.

I think such fix should be sent separately.
OK to get the fix first.

> And the crash not detected/reported until now makes me think API is still
> not used much, I wonder if we should wait a little more to mature them.

It is not a surprise that the delete operation is not used much.
But the set operation is used.
I am not sure about waiting more. I have no strong opinion.

> Also only internal user of the  API is 'drivers/net/netvsc', I wonder if
> PMD detect the crash?

Question for Long Li?

[dpdk-dev] [PATCH v3 1/3] eventdev/eth_rx: add queue stats get and reset APIs

[Naga Harish K S V]

This patch adds new api ``rte_event_eth_rx_adapter_queue_stats_get`` to
retrieve queue stats. The queue stats are in the format
``struct rte_event_eth_rx_adapter_queue_stats``.

For resetting the queue stats,
``rte_event_eth_rx_adapter_queue_stats_reset`` api is added.

The adapter stats_get and stats_reset apis are also updated to
handle queue level event buffer use case.

Signed-off-by: Naga Harish K S V 
Acked-by: Jay Jayatheerthan 
---
v2:
* added pmd callback support for adapter queue_stats_get and
  queue_stats_reset apis.

v3:
* addressed coding style review comments
---
 .../prog_guide/event_ethernet_rx_adapter.rst  |  11 +
 lib/eventdev/eventdev_pmd.h   |  52 
 lib/eventdev/rte_event_eth_rx_adapter.c   | 268 +++---
 lib/eventdev/rte_event_eth_rx_adapter.h   |  66 +
 lib/eventdev/version.map  |   2 +
 5 files changed, 356 insertions(+), 43 deletions(-)

diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst 
b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
index 8b58130fc5..67b11e1563 100644
--- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
+++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
@@ -166,6 +166,17 @@ flags for handling received packets, event queue 
identifier, scheduler type,
 event priority, polling frequency of the receive queue and flow identifier
 in struct ``rte_event_eth_rx_adapter_queue_conf``.
 
+Getting and resetting Adapter queue stats
+~
+
+The ``rte_event_eth_rx_adapter_queue_stats_get()`` function reports
+adapter queue counters defined in struct 
``rte_event_eth_rx_adapter_queue_stats``.
+This function reports queue level stats only when queue level event buffer is
+used otherwise it returns -EINVAL.
+
+The ``rte_event_eth_rx_adapter_queue_stats_reset`` function can be used to
+reset queue level stats when queue level event buffer is in use.
+
 Interrupt Based Rx Queues
 ~~
 
diff --git a/lib/eventdev/eventdev_pmd.h b/lib/eventdev/eventdev_pmd.h
index d009e24309..3ba49d1fd4 100644
--- a/lib/eventdev/eventdev_pmd.h
+++ b/lib/eventdev/eventdev_pmd.h
@@ -749,6 +749,53 @@ typedef int (*eventdev_eth_rx_adapter_stats_get)
 typedef int (*eventdev_eth_rx_adapter_stats_reset)
(const struct rte_eventdev *dev,
const struct rte_eth_dev *eth_dev);
+
+struct rte_event_eth_rx_adapter_queue_stats;
+
+/**
+ * Retrieve ethernet Rx adapter queue statistics.
+ *
+ * @param dev
+ *   Event device pointer
+ *
+ * @param eth_dev
+ *   Ethernet device pointer
+ *
+ * @param rx_queue_id
+ *  Ethernet device receive queue index.
+ *
+ * @param[out] q_stats
+ *   Pointer to queue stats structure
+ *
+ * @return
+ *   Return 0 on success.
+ */
+typedef int (*eventdev_eth_rx_adapter_q_stats_get)
+   (const struct rte_eventdev *dev,
+const struct rte_eth_dev *eth_dev,
+uint16_t rx_queue_id,
+struct rte_event_eth_rx_adapter_queue_stats *q_stats);
+
+/**
+ * Reset ethernet Rx adapter queue statistics.
+ *
+ * @param dev
+ *   Event device pointer
+ *
+ * @param eth_dev
+ *   Ethernet device pointer
+ *
+ * @param rx_queue_id
+ *  Ethernet device receive queue index.
+ *
+ * @return
+ *   Return 0 on success.
+ */
+typedef int (*eventdev_eth_rx_adapter_q_stats_reset)
+   (const struct rte_eventdev *dev,
+const struct rte_eth_dev *eth_dev,
+uint16_t rx_queue_id);
+
 /**
  * Start eventdev selftest.
  *
@@ -1224,6 +1271,11 @@ struct eventdev_ops {
eventdev_crypto_adapter_stats_reset crypto_adapter_stats_reset;
/**< Reset crypto stats */
 
+   eventdev_eth_rx_adapter_q_stats_get eth_rx_adapter_queue_stats_get;
+   /**< Get ethernet Rx queue stats */
+   eventdev_eth_rx_adapter_q_stats_reset eth_rx_adapter_queue_stats_reset;
+   /**< Reset ethernet Rx queue stats */
+
eventdev_eth_tx_adapter_caps_get_t eth_tx_adapter_caps_get;
/**< Get ethernet Tx adapter capabilities */
 
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c 
b/lib/eventdev/rte_event_eth_rx_adapter.c
index a175c61551..3adec52eac 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -245,6 +245,10 @@ struct eth_rx_queue_info {
uint64_t event;
struct eth_rx_vector_data vector_data;
struct eth_event_enqueue_buffer *event_buf;
+   /* use adapter stats struct for queue level stats,
+* as same stats need to be updated for adapter and queue
+*/
+   struct rte_event_eth_rx_adapter_stats *stats;
 };
 
 static struct event_eth_rx_adapter **event_eth_rx_adapter;
@@ -268,14 +272,18 @@ rxa_validate_id(uint8_t id)
 
 static inline struct eth_event_enqueue_buffer *
 rxa_event_buf_get(struct event_eth_rx_adapter *rx_adapter, uint16_t eth_dev_id,
-   

[dpdk-dev] [PATCH v3 2/3] eventdev/eth_rx: support telemetry

[Naga Harish K S V]

Added telemetry support for rxa_queue_stats and
rxa_queue_stats_reset to get and reset rx queue
stats respectively

Signed-off-by: Naga Harish K S V 
Acked-by: Jay Jayatheerthan 
---
 lib/eventdev/rte_event_eth_rx_adapter.c | 124 
 1 file changed, 124 insertions(+)

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c 
b/lib/eventdev/rte_event_eth_rx_adapter.c
index 3adec52eac..4e0829c492 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -3345,6 +3345,122 @@ handle_rxa_get_queue_conf(const char *cmd __rte_unused,
return 0;
 }
 
+static int
+handle_rxa_get_queue_stats(const char *cmd __rte_unused,
+  const char *params,
+  struct rte_tel_data *d)
+{
+   uint8_t rx_adapter_id;
+   uint16_t rx_queue_id;
+   int eth_dev_id;
+   char *token, *l_params;
+   struct rte_event_eth_rx_adapter_queue_stats q_stats;
+
+   if (params == NULL || strlen(params) == 0 || !isdigit(*params))
+   return -1;
+
+   /* Get Rx adapter ID from parameter string */
+   l_params = strdup(params);
+   token = strtok(l_params, ",");
+   rx_adapter_id = strtoul(token, NULL, 10);
+   RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(rx_adapter_id, -EINVAL);
+
+   token = strtok(NULL, ",");
+   if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+   return -1;
+
+   /* Get device ID from parameter string */
+   eth_dev_id = strtoul(token, NULL, 10);
+   RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(eth_dev_id, -EINVAL);
+
+   token = strtok(NULL, ",");
+   if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+   return -1;
+
+   /* Get Rx queue ID from parameter string */
+   rx_queue_id = strtoul(token, NULL, 10);
+   if (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {
+   RTE_EDEV_LOG_ERR("Invalid rx queue_id %u", rx_queue_id);
+   return -EINVAL;
+   }
+
+   token = strtok(NULL, "\0");
+   if (token != NULL)
+   RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
+" telemetry command, igrnoring");
+
+   if (rte_event_eth_rx_adapter_queue_stats_get(rx_adapter_id, eth_dev_id,
+   rx_queue_id, &q_stats)) {
+   RTE_EDEV_LOG_ERR("Failed to get Rx adapter queue stats");
+   return -1;
+   }
+
+   rte_tel_data_start_dict(d);
+   rte_tel_data_add_dict_u64(d, "rx_adapter_id", rx_adapter_id);
+   rte_tel_data_add_dict_u64(d, "eth_dev_id", eth_dev_id);
+   rte_tel_data_add_dict_u64(d, "rx_queue_id", rx_queue_id);
+   RXA_ADD_DICT(q_stats, rx_event_buf_count);
+   RXA_ADD_DICT(q_stats, rx_event_buf_size);
+   RXA_ADD_DICT(q_stats, rx_poll_count);
+   RXA_ADD_DICT(q_stats, rx_packets);
+   RXA_ADD_DICT(q_stats, rx_dropped);
+
+   return 0;
+}
+
+static int
+handle_rxa_queue_stats_reset(const char *cmd __rte_unused,
+const char *params,
+struct rte_tel_data *d __rte_unused)
+{
+   uint8_t rx_adapter_id;
+   uint16_t rx_queue_id;
+   int eth_dev_id;
+   char *token, *l_params;
+
+   if (params == NULL || strlen(params) == 0 || !isdigit(*params))
+   return -1;
+
+   /* Get Rx adapter ID from parameter string */
+   l_params = strdup(params);
+   token = strtok(l_params, ",");
+   rx_adapter_id = strtoul(token, NULL, 10);
+   RTE_EVENT_ETH_RX_ADAPTER_ID_VALID_OR_ERR_RET(rx_adapter_id, -EINVAL);
+
+   token = strtok(NULL, ",");
+   if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+   return -1;
+
+   /* Get device ID from parameter string */
+   eth_dev_id = strtoul(token, NULL, 10);
+   RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(eth_dev_id, -EINVAL);
+
+   token = strtok(NULL, ",");
+   if (token == NULL || strlen(token) == 0 || !isdigit(*token))
+   return -1;
+
+   /* Get Rx queue ID from parameter string */
+   rx_queue_id = strtoul(token, NULL, 10);
+   if (rx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_rx_queues) {
+   RTE_EDEV_LOG_ERR("Invalid rx queue_id %u", rx_queue_id);
+   return -EINVAL;
+   }
+
+   token = strtok(NULL, "\0");
+   if (token != NULL)
+   RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
+" telemetry command, igrnoring");
+
+   if (rte_event_eth_rx_adapter_queue_stats_reset(rx_adapter_id,
+  eth_dev_id,
+  rx_queue_id)) {
+   RTE_EDEV_LOG_ERR("Failed to reset Rx adapter queue stats");
+   return -1;
+   }
+
+   return 0;
+}
+
 RTE_INIT(rxa_init_telemetry)
 {
   

[dpdk-dev] [PATCH v3 3/3] test/event: add unit test for Rx adapter

[Naga Harish K S V]

add unit test for rte_event_eth_rx_adapter_queue_stats_get() and
rte_event_eth_rx_adapter_queue_stats_reset() apis.

Signed-off-by: Naga Harish K S V 
Acked-by: Jay Jayatheerthan 
---
 app/test/test_event_eth_rx_adapter.c | 60 
 1 file changed, 60 insertions(+)

diff --git a/app/test/test_event_eth_rx_adapter.c 
b/app/test/test_event_eth_rx_adapter.c
index 1419f6f64d..7cb91b152f 100644
--- a/app/test/test_event_eth_rx_adapter.c
+++ b/app/test/test_event_eth_rx_adapter.c
@@ -471,6 +471,64 @@ adapter_queue_event_buf_test(void)
return TEST_SUCCESS;
 }
 
+static int
+adapter_queue_stats_test(void)
+{
+   int err;
+   struct rte_event ev;
+   uint32_t cap;
+   struct rte_event_eth_rx_adapter_queue_conf queue_config = {0};
+   struct rte_event_eth_rx_adapter_queue_stats q_stats;
+
+   err = rte_event_eth_rx_adapter_queue_stats_get(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0,
+   &q_stats);
+   TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
+
+   err = rte_event_eth_rx_adapter_queue_stats_reset(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0);
+   TEST_ASSERT(err == -EINVAL, "Expected -EINVAL got %d", err);
+
+   err = rte_event_eth_rx_adapter_caps_get(TEST_DEV_ID, TEST_ETHDEV_ID,
+&cap);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   ev.queue_id = 0;
+   ev.sched_type = RTE_SCHED_TYPE_ATOMIC;
+   ev.priority = 0;
+
+   queue_config.rx_queue_flags = 0;
+   if (cap & RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) {
+   ev.flow_id = 1;
+   queue_config.rx_queue_flags =
+   RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID;
+   }
+   queue_config.ev = ev;
+   queue_config.servicing_weight = 1;
+   queue_config.event_buf_size = 1024;
+
+   err = rte_event_eth_rx_adapter_queue_add(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0,
+   &queue_config);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   err = rte_event_eth_rx_adapter_queue_stats_get(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0,
+   &q_stats);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   err = rte_event_eth_rx_adapter_queue_stats_reset(TEST_INST_ID,
+   TEST_ETHDEV_ID, 0);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   err = rte_event_eth_rx_adapter_queue_del(TEST_INST_ID,
+   TEST_ETHDEV_ID,
+   0);
+   TEST_ASSERT(err == 0, "Expected 0 got %d", err);
+
+   return TEST_SUCCESS;
+}
+
 static void
 adapter_free(void)
 {
@@ -940,6 +998,8 @@ static struct unit_test_suite event_eth_rx_tests = {
TEST_CASE_ST(adapter_create, adapter_free, adapter_queue_conf),
TEST_CASE_ST(adapter_create_with_params, adapter_free,
 adapter_queue_event_buf_test),
+   TEST_CASE_ST(adapter_create_with_params, adapter_free,
+adapter_queue_stats_test),
TEST_CASES_END() /**< NULL terminate unit test array */
}
 };
-- 
2.25.1

Re: [dpdk-dev] [PATCH] test/crypto: refactor docsis to show hidden cases

[Troy, Rebecca]

> -Original Message-
> From: Coyle, David 
> Sent: Thursday 28 October 2021 11:34
> To: Troy, Rebecca ; dev@dpdk.org
> Cc: Power, Ciara ; Zhang, Roy Fan
> ; Akhil Goyal ; Doherty,
> Declan 
> Subject: RE: [PATCH] test/crypto: refactor docsis to show hidden cases
> 
> Hi Rebecca, see below
> 
> 
> > -Original Message-
> > From: Troy, Rebecca 
> >
> > In the current implementation, the docsis test cases are running and
> > being reported as one test, despite the fact that multiple test cases
> > are hidden inside i.e. "test_DOCSIS_PROTO_all" runs
> > 52 test cases. Each docsis test case should be reported individually 
> > instead.
> 
> [DC] Should make "docsis" all uppercase in the commit message - "DOCSIS"
> 
> >
> > This commit achieves this by removing the use of the
> > test_DOCSIS_PROTO_all function and statically listing the test cases
> > to run when building the test suite, which are then reported to the
> > user by description.
> >
> > Signed-off-by: Rebecca Troy 
> > ---
> >  app/test/test_cryptodev.c | 265 +++---
> >  ...t_cryptodev_security_docsis_test_vectors.h | 159 +--
> >  2 files changed, 241 insertions(+), 183 deletions(-)
> >
> >
> 
> 
> 
> > +
> >  static struct unit_test_suite docsis_proto_testsuite  = {
> > .suite_name = "Docsis Proto Unit Test Suite",
> 
> [DC] Outside the specific changes of this patch, but "Docsis" should be all
> uppercase in the suite name too - "DOCSIS"... could take this opportunity to
> fix up this minor one
> 
> > .setup = docsis_proto_testsuite_setup,
> > .unit_test_cases = {
> > -   TEST_CASE_ST(ut_setup_security, ut_teardown,
> > -   test_DOCSIS_PROTO_all),
> > +   /* Uplink */
> > +   ADD_UPLINK_TESTCASE(docsis_test_case_1)
> > +   ADD_UPLINK_TESTCASE(docsis_test_case_2)
> > +   ADD_UPLINK_TESTCASE(docsis_test_case_3)
> > +   ADD_UPLINK_TESTCASE(docsis_test_case_4)
> 
> 
> 
> >
> > -struct docsis_test_data docsis_test_case_1 = {
> > +const struct docsis_test_data docsis_test_case_1 = {
> > +   .test_descr_uplink = {"AES-DOCSIS-BPI-128 and CRC Verify (24-byte "
> > +   "frame, Small offset and runt block encryption)"},
> > +   .test_descr_downlink = {"CRC Generate and AES-DOCSIS-BPI-128
> > (24-byte "
> > +   "frame, Small offset and runt block encryption)"},
> 
> [DC] This one is my fault when I supplied the descriptions, so apologies about
> this, but all the uplink descriptions should say "decryption" instead of
> "encryption"
> 
> Also I think all the descriptions should say "Uplink" or "Downlink" at the
> start.
> This can be inferred from the order of AES-DOCSIS-BPI and CRC in the
> description, but when I ran the test cases, I still had to think are these 
> Uplink
> or Downlink tests.
> It would be much clearer if it's stated explicitly
> 
> Regards,
> David

Great, thanks for the feedback David! Will look at implementing these changes 
in a v2.

Thanks,
Rebecca.

Re: [dpdk-dev] [PATCH v7 4/4] net/ice: enable protocol agnostic flow offloading in FDIR

[Zhang, Qi Z]

> -Original Message-
> From: Guo, Junfeng 
> Sent: Thursday, October 28, 2021 5:14 PM
> To: Zhang, Qi Z ; Wu, Jingjing ;
> Xing, Beilei 
> Cc: dev@dpdk.org; Yigit, Ferruh ; Xu, Ting
> ; Guo, Junfeng 
> Subject: [PATCH v7 4/4] net/ice: enable protocol agnostic flow offloading in
> FDIR
> 
> Protocol agnostic flow offloading in Flow Director is enabled by this patch
> based on the Parser Library, using existing rte_flow raw API.
> 
> Note that the raw flow requires:
> 1. byte string of raw target packet bits.
> 2. byte string of mask of target packet.
> 
> Here is an example:
> FDIR matching ipv4 dst addr with 1.2.3.4 and redirect to queue 3:
> 
> flow create 0 ingress pattern raw \
> pattern spec \
> 08004514400040100
> 1020304 \ pattern mask \
> ff
> ff \ / end actions queue index 3 / mark id 3 / end
> 
> Note that mask of some key bits (e.g., 0x0800 to indicate ipv4 proto) is
> optional in our cases. To avoid redundancy, we just omit the mask of 0x0800
> (with 0x) in the mask byte string example. The prefix '0x' for the spec 
> and
> mask byte (hex) strings are also omitted here.
> 
> Signed-off-by: Junfeng Guo 
> ---
>  doc/guides/rel_notes/release_21_11.rst |   1 +
>  drivers/net/ice/ice_ethdev.h   |  17 ++
>  drivers/net/ice/ice_fdir_filter.c  | 260 +
>  drivers/net/ice/ice_generic_flow.c |   7 +
>  drivers/net/ice/ice_generic_flow.h |   3 +
>  5 files changed, 288 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_21_11.rst
> b/doc/guides/rel_notes/release_21_11.rst
> index 9c13ceed1c..cc449a4340 100644
> --- a/doc/guides/rel_notes/release_21_11.rst
> +++ b/doc/guides/rel_notes/release_21_11.rst
> @@ -167,6 +167,7 @@ New Features
> 
>  * **Updated Intel ice driver.**
> 
> +  * Added protocol agnostic flow offloading support in Flow Director.
>* Added 1PPS out support by a devargs.
>* Added IPv4 and L4 (TCP/UDP/SCTP) checksum hash support in RSS flow.
>* Added DEV_RX_OFFLOAD_TIMESTAMP support.
> diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h index
> 599e0028f7..441242ee89 100644
> --- a/drivers/net/ice/ice_ethdev.h
> +++ b/drivers/net/ice/ice_ethdev.h
> @@ -318,6 +318,11 @@ struct ice_fdir_filter_conf {
>   uint64_t input_set_o; /* used for non-tunnel or tunnel outer fields */
>   uint64_t input_set_i; /* only for tunnel inner fields */
>   uint32_t mark_flag;
> +
> + struct ice_parser_profile *prof;
> + const u8 *pkt_buf;
> + bool parser_ena;
> + u8 pkt_len;
>  };
> 
>  #define ICE_MAX_FDIR_FILTER_NUM  (1024 * 16)
> @@ -487,6 +492,17 @@ struct ice_devargs {
>   uint8_t pps_out_ena;
>  };
> 
> +/**
> + * Structure to store fdir fv entry.
> + */
> +struct ice_fdir_prof_info {
> + struct LIST_ENTRY_TYPE l_entry;
> +
> + struct ice_parser_profile prof;
> + u16 ptg;
> + u64 fdir_actived_cnt;
> +};
> +
>  /**
>   * Structure to store private data for each PF/VF instance.
>   */
> @@ -509,6 +525,7 @@ struct ice_adapter {
>   struct rte_timecounter rx_tstamp_tc;
>   struct rte_timecounter tx_tstamp_tc;
>   bool ptp_ena;
> + struct LIST_HEAD_TYPE fdir_prof_list;
>  #ifdef RTE_ARCH_X86
>   bool rx_use_avx2;
>   bool rx_use_avx512;
> diff --git a/drivers/net/ice/ice_fdir_filter.c 
> b/drivers/net/ice/ice_fdir_filter.c
> index bd627e3aa8..bcf105d1bd 100644
> --- a/drivers/net/ice/ice_fdir_filter.c
> +++ b/drivers/net/ice/ice_fdir_filter.c
> @@ -107,6 +107,7 @@
>   ICE_INSET_NAT_T_ESP_SPI)
> 
>  static struct ice_pattern_match_item ice_fdir_pattern_list[] = {
> + {pattern_raw,   ICE_INSET_NONE,
>   ICE_INSET_NONE, ICE_INSET_NONE},
>   {pattern_ethertype, ICE_FDIR_INSET_ETH,
>   ICE_INSET_NONE, ICE_INSET_NONE},
>   {pattern_eth_ipv4,  ICE_FDIR_INSET_ETH_IPV4,
>   ICE_INSET_NONE, ICE_INSET_NONE},
>   {pattern_eth_ipv4_udp,  
> ICE_FDIR_INSET_ETH_IPV4_UDP,
>   ICE_INSET_NONE, ICE_INSET_NONE},
> @@ -1158,6 +1159,8 @@ ice_fdir_init(struct ice_adapter *ad)
>   if (ret)
>   return ret;
> 
> + INIT_LIST_HEAD(&ad->fdir_prof_list);
> +
>   parser = &ice_fdir_parser;
> 
>   return ice_register_parser(parser, ad); @@ -1188,6 +1191,24 @@
> ice_fdir_is_tunnel_profile(enum ice_fdir_tunnel_type tunnel_type)
>   return 0;
>  }
> 
> +static int
> +ice_fdir_add_del_raw(struct ice_pf *pf,
> +  struct ice_fdir_filter_conf *filter,
> +  bool add)
> +{
> + struct ice_hw *hw = ICE_PF_TO_HW(pf);
> +
> + unsigned char *pkt = (unsigned char *)pf->fdir.prg_pkt;
> + rte_memcpy(pkt, filter->pkt_buf, filter->pkt_len);
> +
> + struct ice_fltr_desc desc;
> + 

Re: [dpdk-dev] [PATCH] net/iavf: fix build error

[Zhang, Qi Z]

> -Original Message-
> From: Nicolau, Radu 
> Sent: Wednesday, October 27, 2021 5:51 PM
> To: Wu, Jingjing ; Xing, Beilei 
> Cc: dev@dpdk.org; Zhang, Qi Z ; Nicolau, Radu
> 
> Subject: [PATCH] net/iavf: fix build error
> 
> Fix Freebsd13 and Win10 build error.
> 
> Fixes: 9e84ce6ecd27 ("net/iavf: add iAVF IPsec inline crypto support")
> 
> Signed-off-by: Radu Nicolau 
> ---
>  drivers/net/iavf/iavf_ipsec_crypto.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_ipsec_crypto.c
> b/drivers/net/iavf/iavf_ipsec_crypto.c
> index 4d4830f4c9..a8022f8ed7 100644
> --- a/drivers/net/iavf/iavf_ipsec_crypto.c
> +++ b/drivers/net/iavf/iavf_ipsec_crypto.c
> @@ -509,7 +509,7 @@ iavf_ipsec_crypto_security_association_add(struct
> iavf_adapter *adapter,
>   htonl(conf->ipsec.tunnel.ipv4.dst_ip.s_addr);
>   } else {
>   uint32_t *v6_dst_addr =
> - conf->ipsec.tunnel.ipv6.dst_addr.s6_addr32;
> + (uint32_t *)conf->ipsec.tunnel.ipv6.dst_addr.s6_addr;
> 
>   sa_cfg->virtchnl_ip_type = VIRTCHNL_IPV6;
> 
> --
> 2.25.1

Acked-by: Qi Zhang 

Applied to dpdk-next-net-intel.

Thanks
Qi

Re: [dpdk-dev] [PATCH v7 1/4] net/ice/base: add method to disable FDIR SWAP option

[Zhang, Qi Z]

> -Original Message-
> From: Guo, Junfeng 
> Sent: Thursday, October 28, 2021 5:14 PM
> To: Zhang, Qi Z ; Wu, Jingjing ;
> Xing, Beilei 
> Cc: dev@dpdk.org; Yigit, Ferruh ; Xu, Ting
> ; Guo, Junfeng 
> Subject: [PATCH v7 1/4] net/ice/base: add method to disable FDIR SWAP
> option
> 
> The SWAP Flag in the FDIR Programming Descriptor doesn't work, thus add a
> method to disable the FDIR SWAP option by setting the swap and inset register
> set with certain values. The boolean fd_swap is used to enable/disable the
> SWAP option.
> 
> Signed-off-by: Junfeng Guo 

Acked-by: Qi Zhang 

Applied to dpdk-next-net-intel.

Thanks.
Qi

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

[Xia, Chenbo]

> -Original Message-
> From: Burakov, Anatoly 
> Sent: Thursday, October 28, 2021 6:30 PM
> To: Xia, Chenbo ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent
> 
> Hi Chenbo,
> 
> > And do we need backport? As 'return -1' does not align with the API doxygen.
> >
> > Thanks,
> > Chenbo
> >
> Maybe it's the FreeBSD implementation that needs to be adjusted then,
> because none of those functions are valid on FreeBSD, and the
> documentation for VFIO functions explicitly mentions that on FreeBSD,
> they should return an error. I went with adjusting Linux implementation
> to minimize the amount of changes we have to make (and only change code
> path that no one uses in the first place), but maybe that was a wrong
> decision.
> 
> I'm not sure if changing the API return value to match what was
> documented counts as an API change, so maybe backport to stable is not
> advised here.

It's not a API change. My point is whether VFIO is present, users just use
the API to check if vfio support is there. In a kernel version that does not
support VFIO, he uses 'if(rte_vfio_is_enabled(XXX))' to check as the doxygen
says its return value should be 1 as true or 0 as false. He will get true (-1)
but VFIO is not there. That's why I think it's a bug and should be backported.

But I think we can first discuss if we should drop the dummy implementation
as DPDK requires Linux kernel version >= 4.4 now so VFIO is always present.
I think it depends on by saying 'DPDK requires kernel version >= 4.4'. It's
a real _requirement_ or only a recommendation? 

Ferruh, David & Thomas, What do you think?

Thanks,
Chenbo

> 
> --
> Thanks,
> Anatoly

Re: [dpdk-dev] [PATCH v7 2/4] net/ice/base: add function to set HW profile for raw flow

[Zhang, Qi Z]

> -Original Message-
> From: Guo, Junfeng 
> Sent: Thursday, October 28, 2021 5:14 PM
> To: Zhang, Qi Z ; Wu, Jingjing ;
> Xing, Beilei 
> Cc: dev@dpdk.org; Yigit, Ferruh ; Xu, Ting
> ; Guo, Junfeng 
> Subject: [PATCH v7 2/4] net/ice/base: add function to set HW profile for raw
> flow
> 
> Based on the parser library, we can directly set HW profile and associate the
> main/ctrl vsi.
> 
> Signed-off-by: Junfeng Guo 

Acked-by: Qi Zhang 

As this is the last base code patch for DPDK 21.11, update FreeBSD release 
version in driver/net/ice/base/README during merge.

Applied to dpdk-next-net-intel.

Thanks
Qi

> ---
>  drivers/net/ice/base/ice_flex_pipe.c | 49 
> drivers/net/ice/base/ice_flex_pipe.h |  3 +
>  drivers/net/ice/base/ice_flow.c  | 84 
>  drivers/net/ice/base/ice_flow.h  |  4 ++
>  4 files changed, 140 insertions(+)
> 
> diff --git a/drivers/net/ice/base/ice_flex_pipe.c
> b/drivers/net/ice/base/ice_flex_pipe.c
> index 06a233990f..395787806b 100644
> --- a/drivers/net/ice/base/ice_flex_pipe.c
> +++ b/drivers/net/ice/base/ice_flex_pipe.c
> @@ -6365,3 +6365,52 @@ ice_rem_prof_id_flow(struct ice_hw *hw, enum
> ice_block blk, u16 vsi, u64 hdl)
> 
>   return status;
>  }
> +
> +/**
> + * ice_flow_assoc_hw_prof - add profile id flow for main/ctrl VSI flow
> +entry
> + * @hw: pointer to the HW struct
> + * @blk: HW block
> + * @dest_vsi_handle: dest VSI handle
> + * @fdir_vsi_handle: fdir programming VSI handle
> + * @id: profile id (handle)
> + *
> + * Calling this function will update the hardware tables to enable the
> + * profile indicated by the ID parameter for the VSIs specified in the
> +VSI
> + * array. Once successfully called, the flow will be enabled.
> + */
> +enum ice_status
> +ice_flow_assoc_hw_prof(struct ice_hw *hw, enum ice_block blk,
> +u16 dest_vsi_handle, u16 fdir_vsi_handle, int id) {
> + enum ice_status status = ICE_SUCCESS;
> + u16 vsi_num;
> +
> + vsi_num = ice_get_hw_vsi_num(hw, dest_vsi_handle);
> + status = ice_add_prof_id_flow(hw, blk, vsi_num, id);
> + if (status) {
> + ice_debug(hw, ICE_DBG_FLOW, "HW profile add failed for main VSI
> flow entry, %d\n",
> +   status);
> + goto err_add_prof;
> + }
> +
> + if (blk != ICE_BLK_FD)
> + return status;
> +
> + vsi_num = ice_get_hw_vsi_num(hw, fdir_vsi_handle);
> + status = ice_add_prof_id_flow(hw, blk, vsi_num, id);
> + if (status) {
> + ice_debug(hw, ICE_DBG_FLOW, "HW profile add failed for ctrl VSI
> flow entry, %d\n",
> +   status);
> + goto err_add_entry;
> + }
> +
> + return status;
> +
> +err_add_entry:
> + vsi_num = ice_get_hw_vsi_num(hw, dest_vsi_handle);
> + ice_rem_prof_id_flow(hw, blk, vsi_num, id);
> +err_add_prof:
> + ice_flow_rem_prof(hw, blk, id);
> +
> + return status;
> +}
> diff --git a/drivers/net/ice/base/ice_flex_pipe.h
> b/drivers/net/ice/base/ice_flex_pipe.h
> index dd332312dd..23ba45564a 100644
> --- a/drivers/net/ice/base/ice_flex_pipe.h
> +++ b/drivers/net/ice/base/ice_flex_pipe.h
> @@ -76,6 +76,9 @@ enum ice_status
>  ice_add_prof_id_flow(struct ice_hw *hw, enum ice_block blk, u16 vsi, u64
> hdl);  enum ice_status  ice_rem_prof_id_flow(struct ice_hw *hw, enum
> ice_block blk, u16 vsi, u64 hdl);
> +enum ice_status
> +ice_flow_assoc_hw_prof(struct ice_hw *hw, enum ice_block blk,
> +u16 dest_vsi_handle, u16 fdir_vsi_handle, int id);
>  enum ice_status ice_init_pkg(struct ice_hw *hw, u8 *buff, u32 len);  enum
> ice_status  ice_copy_and_init_pkg(struct ice_hw *hw, const u8 *buf, u32 len);
> diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
> index 77b6b130c1..f699dbbc74 100644
> --- a/drivers/net/ice/base/ice_flow.c
> +++ b/drivers/net/ice/base/ice_flow.c
> @@ -2524,6 +2524,90 @@ ice_flow_disassoc_prof(struct ice_hw *hw, enum
> ice_block blk,
>   return status;
>  }
> 
> +#define FLAG_GTP_EH_PDU_LINK BIT_ULL(13)
> +#define FLAG_GTP_EH_PDU  BIT_ULL(14)
> +
> +#define FLAG_GTPU_MSK\
> + (FLAG_GTP_EH_PDU | FLAG_GTP_EH_PDU_LINK)
> +#define FLAG_GTPU_DW \
> + (FLAG_GTP_EH_PDU | FLAG_GTP_EH_PDU_LINK)
> +#define FLAG_GTPU_UP \
> + (FLAG_GTP_EH_PDU)
> +/**
> + * ice_flow_set_hw_prof - Set HW flow profile based on the parsed
> +profile info
> + * @hw: pointer to the HW struct
> + * @dest_vsi_handle: dest VSI handle
> + * @fdir_vsi_handle: fdir programming VSI handle
> + * @prof: stores parsed profile info from raw flow
> + * @blk: classification stage
> + */
> +enum ice_status
> +ice_flow_set_hw_prof(struct ice_hw *hw, u16 dest_vsi_handle,
> +  u16 fdir_vsi_handle, struct ice_parser_profile *prof,
> +  enum ice_block blk)
> +{
> + int id = ice_find_first_bit(prof->ptypes, UINT16_MAX);
> + struct ice_flow_prof_params *params;
> + u8 fv_words = hw->b

Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

[Ferruh Yigit]

On 10/28/2021 12:11 PM, Xia, Chenbo wrote:

-Original Message-
From: Burakov, Anatoly 
Sent: Thursday, October 28, 2021 6:30 PM
To: Xia, Chenbo ; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent

Hi Chenbo,


And do we need backport? As 'return -1' does not align with the API doxygen.

Thanks,
Chenbo


Maybe it's the FreeBSD implementation that needs to be adjusted then,
because none of those functions are valid on FreeBSD, and the
documentation for VFIO functions explicitly mentions that on FreeBSD,
they should return an error. I went with adjusting Linux implementation
to minimize the amount of changes we have to make (and only change code
path that no one uses in the first place), but maybe that was a wrong
decision.

I'm not sure if changing the API return value to match what was
documented counts as an API change, so maybe backport to stable is not
advised here.


It's not a API change. My point is whether VFIO is present, users just use
the API to check if vfio support is there. In a kernel version that does not
support VFIO, he uses 'if(rte_vfio_is_enabled(XXX))' to check as the doxygen
says its return value should be 1 as true or 0 as false. He will get true (-1)
but VFIO is not there. That's why I think it's a bug and should be backported.

But I think we can first discuss if we should drop the dummy implementation
as DPDK requires Linux kernel version >= 4.4 now so VFIO is always present.
I think it depends on by saying 'DPDK requires kernel version >= 4.4'. It's
a real _requirement_ or only a recommendation?

Ferruh, David & Thomas, What do you think?



My understanding is, it is a requirement. DPDK does not guarantee support for
kernels < 4.4.

Re: [dpdk-dev] [PATCH v4 2/2] examples/ipsec-secgw: add support for TCP TSO

[Ananyev, Konstantin]

> Add support to allow user to specific MSS for TCP TSO offload on a per SA
> basis. MSS configuration in the context of IPsec is only supported for
> outbound SA's in the context of an inline IPsec Crypto offload.
> 
> Signed-off-by: Declan Doherty 
> Signed-off-by: Radu Nicolau 
> ---
>  doc/guides/rel_notes/release_21_11.rst   |  4 
>  doc/guides/sample_app_ug/ipsec_secgw.rst | 11 +++
>  examples/ipsec-secgw/ipsec-secgw.c   |  4 
>  examples/ipsec-secgw/ipsec.h |  1 +
>  examples/ipsec-secgw/ipsec_process.c | 22 +
>  examples/ipsec-secgw/sa.c| 25 +---
>  6 files changed, 64 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_21_11.rst 
> b/doc/guides/rel_notes/release_21_11.rst
> index b5b5abadee..35ececc3f2 100644
> --- a/doc/guides/rel_notes/release_21_11.rst
> +++ b/doc/guides/rel_notes/release_21_11.rst
> @@ -306,6 +306,10 @@ New Features
>  * Pcapng format with timestamps and meta-data.
>  * Fixes packet capture with stripped VLAN tags.
> 
> +* **IPsec Security Gateway sample application new features.**
> +
> +  * Added support for TSO (only for inline crypto TCP packets)
> +
> 
>  Removed Items
>  -
> diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst 
> b/doc/guides/sample_app_ug/ipsec_secgw.rst
> index 782574dd39..639d309a6e 100644
> --- a/doc/guides/sample_app_ug/ipsec_secgw.rst
> +++ b/doc/guides/sample_app_ug/ipsec_secgw.rst
> @@ -720,6 +720,17 @@ where each options means:
> 
> * *udp-encap*
> 
> + 
> +
> + * Maximum segment size for TSO offload, available for egress SAs only.
> +
> + * Optional: Yes, TSO offload not set by default
> +
> + * Syntax:
> +
> +   * *mss N* N is the segment size in bytes
> +
> +
>  Example SA rules:
> 
>  .. code-block:: console
> diff --git a/examples/ipsec-secgw/ipsec-secgw.c 
> b/examples/ipsec-secgw/ipsec-secgw.c
> index 4bdf99b62b..5fcf424efe 100644
> --- a/examples/ipsec-secgw/ipsec-secgw.c
> +++ b/examples/ipsec-secgw/ipsec-secgw.c
> @@ -398,6 +398,10 @@ prepare_one_packet(struct rte_mbuf *pkt, struct 
> ipsec_traffic *t)
>   pkt->l2_len = 0;
>   pkt->l3_len = sizeof(*iph4);
>   pkt->packet_type |= RTE_PTYPE_L3_IPV4;
> + if  (pkt->packet_type & RTE_PTYPE_L4_TCP)
> + pkt->l4_len = sizeof(struct rte_tcp_hdr);
> + else if (pkt->packet_type & RTE_PTYPE_L4_UDP)
> + pkt->l4_len = sizeof(struct rte_udp_hdr);
>   } else if (eth->ether_type == rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV6)) {
>   int next_proto;
>   size_t l3len, ext_len;
> diff --git a/examples/ipsec-secgw/ipsec.h b/examples/ipsec-secgw/ipsec.h
> index 8405c48171..2c3640833d 100644
> --- a/examples/ipsec-secgw/ipsec.h
> +++ b/examples/ipsec-secgw/ipsec.h
> @@ -137,6 +137,7 @@ struct ipsec_sa {
>   enum rte_security_ipsec_sa_direction direction;
>   uint8_t udp_encap;
>   uint16_t portid;
> + uint16_t mss;
>   uint8_t fdir_qid;
>   uint8_t fdir_flag;
> 
> diff --git a/examples/ipsec-secgw/ipsec_process.c 
> b/examples/ipsec-secgw/ipsec_process.c
> index 5012e1a6a4..bb56e97ad7 100644
> --- a/examples/ipsec-secgw/ipsec_process.c
> +++ b/examples/ipsec-secgw/ipsec_process.c
> @@ -222,6 +222,28 @@ prep_process_group(void *sa, struct rte_mbuf *mb[], 
> uint32_t cnt)
>   for (j = 0; j != cnt; j++) {
>   priv = get_priv(mb[j]);
>   priv->sa = sa;
> + /* setup TSO related fields if TSO enabled*/
> + if (priv->sa->mss) {
> + /* TCP only */
> + uint32_t ptype = mb[j]->packet_type;
> + if  (ptype & (RTE_PTYPE_L4_TCP == 0))

It should be:
if  ((ptype & RTE_PTYPE_L4_MASK) == RTE_PTYPE_L4_TCP)
...

With that fixed:
Acked-by: Konstantin Ananyev 


> + continue;
> +
> + mb[j]->tso_segsz = priv->sa->mss;
> + if ((IS_TUNNEL(priv->sa->flags))) {
> + mb[j]->outer_l3_len = mb[j]->l3_len;
> + mb[j]->outer_l2_len = mb[j]->l2_len;
> + mb[j]->ol_flags |=
> + (RTE_MBUF_F_TX_OUTER_IP_CKSUM |
> + RTE_MBUF_F_TX_TUNNEL_ESP);
> + }
> + mb[j]->ol_flags |= (RTE_MBUF_F_TX_TCP_SEG |
> + RTE_MBUF_F_TX_TCP_CKSUM);
> + if (RTE_ETH_IS_IPV4_HDR(ptype))
> + mb[j]->ol_flags |= RTE_MBUF_F_TX_OUTER_IPV4;
> + else
> + mb[j]->ol_flags |= RTE_MBUF_F_TX_OUTER_IPV6;
> + }
>   }
>  }
> 
> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
> index 88dd30464f..97f265cc7b 100644
> --- a/examples/ipsec-secgw/sa.c
> +++ b/examples/ipse

Re: [dpdk-dev] [PATCH v7 3/4] app/testpmd: update Max RAW pattern size to 512

[Zhang, Qi Z]

> -Original Message-
> From: Guo, Junfeng 
> Sent: Thursday, October 28, 2021 5:14 PM
> To: Zhang, Qi Z ; Wu, Jingjing ;
> Xing, Beilei 
> Cc: dev@dpdk.org; Yigit, Ferruh ; Xu, Ting
> ; Guo, Junfeng 
> Subject: [PATCH v7 3/4] app/testpmd: update Max RAW pattern size to 512
> 
> Update max size for pattern in struct rte_flow_item_raw to enable protocol
> agnostic flow offloading.
> 
> Signed-off-by: Junfeng Guo 

Reviewed-by: Qi Zhang 


> ---
>  app/test-pmd/cmdline_flow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index
> d8218771fb..ef24710bd8 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -495,7 +495,7 @@ enum index {
>  };
> 
>  /** Maximum size for pattern in struct rte_flow_item_raw. */ -#define
> ITEM_RAW_PATTERN_SIZE 40
> +#define ITEM_RAW_PATTERN_SIZE 512
> 
>  /** Maximum size for GENEVE option data pattern in bytes. */  #define
> ITEM_GENEVE_OPT_DATA_SIZE 124
> --
> 2.25.1

[dpdk-dev] [PATCH v2] ip_frag: promote APIs to stable

[Konstantin Ananyev]

Promote rte_frag_table_del_expired_entries() function to stable.
It was around for few years by now without any changes.

Signed-off-by: Konstantin Ananyev 
---
 lib/ip_frag/rte_ip_frag.h | 1 -
 lib/ip_frag/version.map   | 7 +--
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/lib/ip_frag/rte_ip_frag.h b/lib/ip_frag/rte_ip_frag.h
index 08555fde6a..d856f87e6c 100644
--- a/lib/ip_frag/rte_ip_frag.h
+++ b/lib/ip_frag/rte_ip_frag.h
@@ -326,7 +326,6 @@ rte_ip_frag_table_statistics_dump(FILE * f, const struct 
rte_ip_frag_tbl *tbl);
  * @param tms
  *   Current timestamp
  */
-__rte_experimental
 void
 rte_frag_table_del_expired_entries(struct rte_ip_frag_tbl *tbl,
struct rte_ip_frag_death_row *dr, uint64_t tms);
diff --git a/lib/ip_frag/version.map b/lib/ip_frag/version.map
index 33f231fb31..2e13bef645 100644
--- a/lib/ip_frag/version.map
+++ b/lib/ip_frag/version.map
@@ -1,6 +1,7 @@
 DPDK_22 {
global:
 
+   rte_frag_table_del_expired_entries;
rte_ip_frag_free_death_row;
rte_ip_frag_table_create;
rte_ip_frag_table_destroy;
@@ -12,9 +13,3 @@ DPDK_22 {
 
local: *;
 };
-
-EXPERIMENTAL {
-   global:
-
-   rte_frag_table_del_expired_entries;
-};
-- 
2.26.3

[dpdk-dev] [PATCH] net/hns3: fix mailbox communication with HW

[Min Hu (Connor)]

Mailbox is the communication mechanism between SW and HW. There exist two
approaches for SW to recongnize mailbox message from HW. One way is using
match_id, the other is to compare the message code. The two approaches are
independent and used in different scenarios.

But for the second approache, "next_to_use" should be updated and written
to HW register. If it not done, HW do not know the position SW steps, then,
the communication between SW and HW will turn to be failed.

Fixes: dbbbad23e380 ("net/hns3: fix VF handling LSC event in secondary process")
Cc: sta...@dpdk.org

Signed-off-by: Min Hu (Connor) 
---
 drivers/net/hns3/hns3_mbx.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c
index a47622b8a6..245652e2ed 100644
--- a/drivers/net/hns3/hns3_mbx.c
+++ b/drivers/net/hns3/hns3_mbx.c
@@ -435,6 +435,9 @@ hns3_handle_mbx_msg_out_intr(struct hns3_hw *hw)
 scan_next:
next_to_use = (next_to_use + 1) % hw->cmq.crq.desc_num;
}
+
+   crq->next_to_use = next_to_use;
+   hns3_write_dev(hw, HNS3_CMDQ_RX_HEAD_REG, crq->next_to_use);
 }
 
 void
-- 
2.33.0

[dpdk-dev] [Bug 848] gcc12 build error, app/test

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=848

Bug ID: 848
   Summary: gcc12 build error, app/test
   Product: DPDK
   Version: 20.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: other
  Assignee: dev@dpdk.org
  Reporter: ferruh.yi...@intel.com
  Target Milestone: ---

With gcc 12.0.0 "gcc (GCC) 12.0.0 20211024 (experimental)"

In file included from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/immintrin.h:43,
 from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/x86intrin.h:32,
 from ../lib/eal/x86/include/rte_vect.h:31,
 from ../lib/eal/x86/include/rte_memcpy.h:17,
 from ../lib/mempool/rte_mempool.h:50,
 from ../lib/mbuf/rte_mbuf.h:38,
 from ../app/test/test_ipsec.c:9:
In function ‘_mm256_loadu_si256’,
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:319:9,
inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:344:2,
inlined from ‘rte_memcpy_generic’ at
../lib/eal/x86/include/rte_memcpy.h:438:4,
inlined from ‘rte_memcpy’ at ../lib/eal/x86/include/rte_memcpy.h:882:10,
inlined from ‘setup_test_string.constprop’ at
../app/test/test_ipsec.c:561:4:
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/avxintrin.h:929:10:
warning: array subscript ‘__m256i_u[3]’ is partly outside array bounds of
‘const char[108]’ [-Warray-bounds]
  929 |   return *__P;
  |  ^~~~
../app/test/test_ipsec.c: In function ‘setup_test_string.constprop’:
../app/test/test_ipsec.c:528:12: note: at offset 96 into object
‘null_plain_data’ of size 108
  528 | const char null_plain_data[] =
  |^~~
In file included from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/immintrin.h:43,
 from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/x86intrin.h:32,
 from ../lib/eal/x86/include/rte_vect.h:31,
 from ../lib/eal/x86/include/rte_memcpy.h:17,
 from ../lib/mempool/rte_mempool.h:50,
 from ../lib/mbuf/rte_mbuf.h:38,
 from ../app/test/test_ipsec.c:9:
In function ‘_mm256_loadu_si256’,
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:319:9,
inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:344:2,
inlined from ‘rte_memcpy_generic’ at
../lib/eal/x86/include/rte_memcpy.h:438:4,
inlined from ‘rte_memcpy’ at ../lib/eal/x86/include/rte_memcpy.h:882:10,
inlined from ‘setup_test_string’ at ../app/test/test_ipsec.c:561:4,
inlined from ‘test_ipsec_lksd_proto_inb_burst_null_null’ at
../app/test/test_ipsec.c:1806:24:
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/avxintrin.h:929:10:
warning: array subscript ‘__m256i_u[3]’ is partly outside array bounds of
‘const char[108]’ [-Warray-bounds]
  929 |   return *__P;
  |  ^~~~
../app/test/test_ipsec.c: In function
‘test_ipsec_lksd_proto_inb_burst_null_null’:
../app/test/test_ipsec.c:532:12: note: at offset 96 into object
‘null_encrypted_data’ of size 108
  532 | const char null_encrypted_data[] =
  |^~~

-- 
You are receiving this mail because:
You are the assignee for the bug.

[dpdk-dev] [PATCH] vhost: mark vDPA driver API as internal

[Maxime Coquelin]

This patch marks the vDPA driver APIs as internal and
rename the corresponding header file.

Signed-off-by: Maxime Coquelin 
---
 drivers/vdpa/ifc/ifcvf_vdpa.c|  2 +-
 drivers/vdpa/mlx5/mlx5_vdpa.h|  2 +-
 lib/vhost/meson.build|  4 +++-
 lib/vhost/vdpa.c |  2 +-
 lib/vhost/{rte_vdpa_dev.h => vdpa_dev.h} |  6 ++
 lib/vhost/version.map| 13 +
 lib/vhost/vhost.h|  2 +-
 7 files changed, 22 insertions(+), 9 deletions(-)
 rename lib/vhost/{rte_vdpa_dev.h => vdpa_dev.h} (97%)

diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index dd5251d382..b80825fcd8 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -17,7 +17,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.h b/drivers/vdpa/mlx5/mlx5_vdpa.h
index cf4f384fa4..e2db6d432f 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa.h
+++ b/drivers/vdpa/mlx5/mlx5_vdpa.h
@@ -12,7 +12,7 @@
 #pragma GCC diagnostic ignored "-Wpedantic"
 #endif
 #include 
-#include 
+#include 
 #include 
 #ifdef PEDANTIC
 #pragma GCC diagnostic error "-Wpedantic"
diff --git a/lib/vhost/meson.build b/lib/vhost/meson.build
index 2d8fe0239f..6d2d061141 100644
--- a/lib/vhost/meson.build
+++ b/lib/vhost/meson.build
@@ -29,9 +29,11 @@ sources = files(
 )
 headers = files(
 'rte_vdpa.h',
-'rte_vdpa_dev.h',
 'rte_vhost.h',
 'rte_vhost_async.h',
 'rte_vhost_crypto.h',
 )
+driver_sdk_headers = files(
+'vdpa_dev.h',
+)
 deps += ['ethdev', 'cryptodev', 'hash', 'pci']
diff --git a/lib/vhost/vdpa.c b/lib/vhost/vdpa.c
index 6dd91859ac..778835e14e 100644
--- a/lib/vhost/vdpa.c
+++ b/lib/vhost/vdpa.c
@@ -17,7 +17,7 @@
 #include 
 
 #include "rte_vdpa.h"
-#include "rte_vdpa_dev.h"
+#include "vdpa_dev.h"
 #include "vhost.h"
 
 /** Double linked list of vDPA devices. */
diff --git a/lib/vhost/rte_vdpa_dev.h b/lib/vhost/vdpa_dev.h
similarity index 97%
rename from lib/vhost/rte_vdpa_dev.h
rename to lib/vhost/vdpa_dev.h
index b0f494815f..2bdd12b3e1 100644
--- a/lib/vhost/rte_vdpa_dev.h
+++ b/lib/vhost/vdpa_dev.h
@@ -7,6 +7,8 @@
 
 #include 
 
+#include 
+
 #include "rte_vhost.h"
 #include "rte_vdpa.h"
 
@@ -88,6 +90,7 @@ struct rte_vdpa_device {
  * @return
  *  vDPA device pointer on success, NULL on failure
  */
+__rte_internal
 struct rte_vdpa_device *
 rte_vdpa_register_device(struct rte_device *rte_dev,
struct rte_vdpa_dev_ops *ops);
@@ -100,6 +103,7 @@ rte_vdpa_register_device(struct rte_device *rte_dev,
  * @return
  *  device id on success, -1 on failure
  */
+__rte_internal
 int
 rte_vdpa_unregister_device(struct rte_vdpa_device *dev);
 
@@ -115,6 +119,7 @@ rte_vdpa_unregister_device(struct rte_vdpa_device *dev);
  * @return
  *  0 on success, -1 on failure
  */
+__rte_internal
 int
 rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool enable);
 
@@ -132,6 +137,7 @@ rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool 
enable);
  * @return
  *  number of synced used entries on success, -1 on failure
  */
+__rte_internal
 int
 rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m);
 
diff --git a/lib/vhost/version.map b/lib/vhost/version.map
index 8ebde3f694..f3f1a3c93b 100644
--- a/lib/vhost/version.map
+++ b/lib/vhost/version.map
@@ -8,10 +8,7 @@ DPDK_22 {
rte_vdpa_get_rte_device;
rte_vdpa_get_stats;
rte_vdpa_get_stats_names;
-   rte_vdpa_register_device;
-   rte_vdpa_relay_vring_used;
rte_vdpa_reset_stats;
-   rte_vdpa_unregister_device;
rte_vhost_avail_entries;
rte_vhost_clr_inflight_desc_packed;
rte_vhost_clr_inflight_desc_split;
@@ -52,7 +49,6 @@ DPDK_22 {
rte_vhost_get_vring_base_from_inflight;
rte_vhost_get_vring_num;
rte_vhost_gpa_to_vva;
-   rte_vhost_host_notifier_ctrl;
rte_vhost_log_used_vring;
rte_vhost_log_write;
rte_vhost_rx_queue_count;
@@ -86,3 +82,12 @@ EXPERIMENTAL {
rte_vhost_async_channel_unregister_thread_unsafe;
rte_vhost_clear_queue_thread_unsafe;
 };
+
+INTERNAL {
+   global;
+
+   rte_vdpa_register_device;
+   rte_vdpa_unregister_device;
+   rte_vhost_host_notifier_ctrl;
+   rte_vdpa_relay_vring_used;
+};
diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
index 6c6a2da2c9..521a21b5b6 100644
--- a/lib/vhost/vhost.h
+++ b/lib/vhost/vhost.h
@@ -22,7 +22,7 @@
 
 #include "rte_vhost.h"
 #include "rte_vdpa.h"
-#include "rte_vdpa_dev.h"
+#include "vdpa_dev.h"
 
 #include "rte_vhost_async.h"
 
-- 
2.31.1

[dpdk-dev] [Bug 849] gcc12 build error, net/ena

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=849

Bug ID: 849
   Summary: gcc12 build error, net/ena
   Product: DPDK
   Version: 20.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: other
  Assignee: dev@dpdk.org
  Reporter: ferruh.yi...@intel.com
  Target Milestone: ---

With gcc 12.0.0 "gcc (GCC) 12.0.0 20211024 (experimental)"

[73/183] Compiling C object drivers/libtmp_rte_net_ena.a.p/net_ena_ena_rss.c.o
In file included from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/immintrin.h:43,
 from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/x86intrin.h:32,
 
 from ../lib/eal/x86/include/rte_vect.h:31, 
 from ../lib/eal/x86/include/rte_memcpy.h:17,   
 from ../lib/net/rte_ether.h:21,
 from ../drivers/net/ena/ena_ethdev.h:10,   
 from ../drivers/net/ena/ena_rss.c:6:   
In function ‘_mm256_loadu_si256’,   
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:319:9,  
inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:342:2, 
inlined from ‘rte_memcpy_generic’ at
../lib/eal/x86/include/rte_memcpy.h:438:4,
inlined from ‘rte_memcpy’ at ../lib/eal/x86/include/rte_memcpy.h:882:10,
inlined from ‘ena_rss_key_fill’ at ../drivers/net/ena/ena_rss.c:62:2:
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/avxintrin.h:929:10:
warning: array subscript ‘__m256i_u[1]’ is partly outside array bounds of
‘uint8_t[40]’ {aka ‘unsigned char[40]’} [-Warray-bounds]
  929 |   return *__P;
  |  ^~~~
../drivers/net/ena/ena_rss.c: In function ‘ena_rss_key_fill’:
../drivers/net/ena/ena_rss.c:51:24: note: at offset 32 into object
‘default_key’ of size 40
   51 | static uint8_t default_key[ENA_HASH_KEY_SIZE];
  |^~~
In file included from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/immintrin.h:43,
 from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/x86intrin.h:32,
 from ../lib/eal/x86/include/rte_vect.h:31,
 from ../lib/eal/x86/include/rte_memcpy.h:17,
 from ../lib/net/rte_ether.h:21,
 from ../drivers/net/ena/ena_ethdev.h:10,
 from ../drivers/net/ena/ena_rss.c:6:
In function ‘_mm256_loadu_si256’,
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:319:9,
inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:343:2,
inlined from ‘rte_memcpy_generic’ at
../lib/eal/x86/include/rte_memcpy.h:438:4,
inlined from ‘rte_memcpy’ at ../lib/eal/x86/include/rte_memcpy.h:882:10,
inlined from ‘ena_rss_key_fill’ at ../drivers/net/ena/ena_rss.c:62:2:
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/avxintrin.h:929:10:
warning: array subscript 2 is outside array bounds of ‘uint8_t[40]’ {aka
‘unsigned char[40]’} [-Warray-bounds]
  929 |   return *__P;
  |  ^~~~
../drivers/net/ena/ena_rss.c: In function ‘ena_rss_key_fill’:
../drivers/net/ena/ena_rss.c:51:24: note: at offset 64 into object
‘default_key’ of size 40
   51 | static uint8_t default_key[ENA_HASH_KEY_SIZE];
  |^~~
In file included from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/immintrin.h:43,
 from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/x86intrin.h:32,
 from ../lib/eal/x86/include/rte_vect.h:31,
 from ../lib/eal/x86/include/rte_memcpy.h:17,
 from ../lib/net/rte_ether.h:21,
 from ../drivers/net/ena/ena_ethdev.h:10,
 from ../drivers/net/ena/ena_rss.c:6:
In function ‘_mm256_loadu_si256’,
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:319:9,
inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:344:2,
inlined from ‘rte_memcpy_generic’ at
../lib/eal/x86/include/rte_memcpy.h:438:4,
inlined from ‘rte_memcpy’ at ../lib/eal/x86/include/rte_memcpy.h:882:10,
inlined from ‘ena_rss_key_fill’ at ../drivers/net/ena/ena_rss.c:62:2:
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/avxintrin.h:929:10:
warning: array subscript 3 is outside array bounds of ‘uint8_t[40]’ {aka
‘unsigned char[40]’} [-Warray-bounds]
  929 |   return *__P;
  |  ^~~~
../drivers/net/ena/ena_rss.c: In function ‘ena_rss_key_fill’:
../drivers/net/ena/ena_rss.c:51:24: note: at offset 96 into object
‘default_key’ of size 40
   51 | static uint8_t default_key[ENA_HASH_KEY_SIZE];
  |^~~
In

Re: [dpdk-dev] [PATCH v2 02/15] vhost: hide inflight async structure

[Xia, Chenbo]

> -Original Message-
> From: Maxime Coquelin 
> Sent: Wednesday, October 27, 2021 12:29 AM
> To: dev@dpdk.org; Xia, Chenbo ; Hu, Jiayu
> ; Wang, YuanX ; Ma, WenwuX
> ; Richardson, Bruce ;
> Mcnamara, John 
> Cc: Maxime Coquelin 
> Subject: [PATCH v2 02/15] vhost: hide inflight async structure
> 
> This patch moves async_inflight_info struct to internal
> header since it should not be part of the API.
> 
> Signed-off-by: Maxime Coquelin 
> ---
>  lib/vhost/rte_vhost_async.h | 9 -
>  lib/vhost/vhost.h   | 9 +
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h
> index ad71555a7f..789b80f5a0 100644
> --- a/lib/vhost/rte_vhost_async.h
> +++ b/lib/vhost/rte_vhost_async.h
> @@ -83,15 +83,6 @@ struct rte_vhost_async_channel_ops {
>   uint16_t max_packets);
>  };
> 
> -/**
> - * inflight async packet information
> - */
> -struct async_inflight_info {
> - struct rte_mbuf *mbuf;
> - uint16_t descs; /* num of descs inflight */
> - uint16_t nr_buffers; /* num of buffers inflight for packed ring */
> -};
> -
>  /**
>   *  async channel features
>   */
> diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
> index a556d61063..8c1c33c852 100644
> --- a/lib/vhost/vhost.h
> +++ b/lib/vhost/vhost.h
> @@ -119,6 +119,15 @@ struct vring_used_elem_packed {
>   uint32_t count;
>  };
> 
> +/**
> + * inflight async packet information
> + */
> +struct async_inflight_info {
> + struct rte_mbuf *mbuf;
> + uint16_t descs; /* num of descs inflight */
> + uint16_t nr_buffers; /* num of buffers inflight for packed ring */
> +};
> +
>  struct vhost_async {
>   /* operation callbacks for DMA */
>   struct rte_vhost_async_channel_ops ops;
> --
> 2.31.1

Reviewed-by: Chenbo Xia 

Re: [dpdk-dev] [PATCH v2 01/15] vhost: move async data in a dedicated structure

[Xia, Chenbo]

Hi Maxime,

> -Original Message-
> From: Maxime Coquelin 
> Sent: Wednesday, October 27, 2021 12:29 AM
> To: dev@dpdk.org; Xia, Chenbo ; Hu, Jiayu
> ; Wang, YuanX ; Ma, WenwuX
> ; Richardson, Bruce ;
> Mcnamara, John 
> Cc: Maxime Coquelin 
> Subject: [PATCH v2 01/15] vhost: move async data in a dedicated structure
> 
> This patch moves async-related metadata from vhost_virtqueue
> to a dedicated struct. It makes it clear which fields are
> async related, and also saves some memory when async feature
> is not in use.
> 
> Signed-off-by: Maxime Coquelin 
> ---
>  lib/vhost/vhost.c  | 130 +
>  lib/vhost/vhost.h  |  53 -
>  lib/vhost/vhost_user.c |   4 +-
>  lib/vhost/virtio_net.c | 114 +++-
>  4 files changed, 142 insertions(+), 159 deletions(-)
> 
> diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
> index 3b674ac320..452583f68d 100644
> --- a/lib/vhost/vhost.c
> +++ b/lib/vhost/vhost.c
> @@ -340,19 +340,18 @@ cleanup_device(struct virtio_net *dev, int destroy)
>  static void
>  vhost_free_async_mem(struct vhost_virtqueue *vq)
>  {
> - rte_free(vq->async_pkts_info);
> + if (!vq->async)
> + return;
> 
> - rte_free(vq->async_buffers_packed);
> - vq->async_buffers_packed = NULL;
> - rte_free(vq->async_descs_split);
> - vq->async_descs_split = NULL;
> + rte_free(vq->async->pkts_info);
> 
> - rte_free(vq->it_pool);
> - rte_free(vq->vec_pool);
> + rte_free(vq->async->buffers_packed);
> + vq->async->buffers_packed = NULL;
> + rte_free(vq->async->descs_split);
> + vq->async->descs_split = NULL;
> 
> - vq->async_pkts_info = NULL;
> - vq->it_pool = NULL;
> - vq->vec_pool = NULL;
> + rte_free(vq->async);
> + vq->async = NULL;
>  }
> 
>  void
> @@ -1632,77 +1631,63 @@ async_channel_register(int vid, uint16_t queue_id,
>  {
>   struct virtio_net *dev = get_device(vid);
>   struct vhost_virtqueue *vq = dev->virtqueue[queue_id];
> + struct vhost_async *async;
> + int node = vq->numa_node;
> 
> - if (unlikely(vq->async_registered)) {
> + if (unlikely(vq->async)) {
>   VHOST_LOG_CONFIG(ERR,
> - "async register failed: channel already registered "
> - "(vid %d, qid: %d)\n", vid, queue_id);
> + "async register failed: already registered (vid 
> %d,
> qid: %d)\n",

qid: %u. It’s not related to your patch and there're other 'qid: %d'. So we
can send another patch to fix all.

For this patch:

Reviewed-by: Chenbo Xia 

[dpdk-dev] [Bug 850] gcc12 build error, net/ice

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=850

Bug ID: 850
   Summary: gcc12 build error, net/ice
   Product: DPDK
   Version: 20.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: other
  Assignee: dev@dpdk.org
  Reporter: ferruh.yi...@intel.com
  Target Milestone: ---

With gcc 12.0.0 "gcc (GCC) 12.0.0 20211024 (experimental)"

In file included from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/immintrin.h:43,
 from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/x86intrin.h:32,
 from ../lib/eal/x86/include/rte_vect.h:31,
 from ../lib/eal/x86/include/rte_memcpy.h:17,   
 from ../lib/net/rte_ether.h:21,
 from ../lib/ethdev/rte_ethdev.h:166,   
 from ../lib/ethdev/ethdev_driver.h:18, 
 from ../lib/ethdev/ethdev_pci.h:13,
 from ../drivers/net/ice/ice_ethdev.c:6:
In function ‘_mm256_storeu_si256’,  
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:320:2,  
inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:342:2,
inlined from ‘rte_memcpy_generic’ at
../lib/eal/x86/include/rte_memcpy.h:438:4,
inlined from ‘rte_memcpy’ at ../lib/eal/x86/include/rte_memcpy.h:882:10,
inlined from ‘ice_init_rss’ at ../drivers/net/ice/ice_ethdev.c:3238:2,  
inlined from ‘ice_dev_configure’ at ../drivers/net/ice/ice_ethdev.c:3292:9: 
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/avxintrin.h:935:8:
warning: array subscript ‘__m256i_u[1]’ is partly outside array bounds of
‘struct ice_aqc_get_set_rss_keys[1]’ [-Warray-bounds]
  935 |   *__P = __A;   
  |   ~^
../drivers/net/ice/ice_ethdev.c: In function ‘ice_dev_configure’:
../drivers/net/ice/ice_ethdev.c:3190:41: note: at offset 32 into object ‘key’
of size 52
 3190 | struct ice_aqc_get_set_rss_keys key;  
  | ^~~  
In file included from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/immintrin.h:43,
 from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/x86intrin.h:32,
 from ../lib/eal/x86/include/rte_vect.h:31,
 from ../lib/eal/x86/include/rte_memcpy.h:17,
 from ../lib/net/rte_ether.h:21,
 from ../lib/ethdev/rte_ethdev.h:166,
 from ../lib/ethdev/ethdev_driver.h:18,
 from ../lib/ethdev/ethdev_pci.h:13,
 from ../drivers/net/ice/ice_ethdev.c:6:
In function ‘_mm256_storeu_si256’,
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:320:2,
inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:343:2,
inlined from ‘rte_memcpy_generic’ at
../lib/eal/x86/include/rte_memcpy.h:438:4,
inlined from ‘rte_memcpy’ at ../lib/eal/x86/include/rte_memcpy.h:882:10,
inlined from ‘ice_init_rss’ at ../drivers/net/ice/ice_ethdev.c:3238:2,
inlined from ‘ice_dev_configure’ at ../drivers/net/ice/ice_ethdev.c:3292:9:
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/avxintrin.h:935:8:
warning: array subscript 2 is outside array bounds of ‘struct
ice_aqc_get_set_rss_keys[1]’ [-Warray-bounds]
  935 |   *__P = __A;
  |   ~^
../drivers/net/ice/ice_ethdev.c: In function ‘ice_dev_configure’:
../drivers/net/ice/ice_ethdev.c:3190:41: note: at offset 64 into object ‘key’
of size 52
 3190 | struct ice_aqc_get_set_rss_keys key;
  | ^~~
In file included from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/immintrin.h:43,
 from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/x86intrin.h:32,
 from ../lib/eal/x86/include/rte_vect.h:31,
 from ../lib/eal/x86/include/rte_memcpy.h:17,
 from ../lib/net/rte_ether.h:21,
 from ../lib/ethdev/rte_ethdev.h:166,
 from ../lib/ethdev/ethdev_driver.h:18,
 from ../lib/ethdev/ethdev_pci.h:13,
 from ../drivers/net/ice/ice_ethdev.c:6:
In function ‘_mm256_storeu_si256’,
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:320:2,
inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:344:2,
inlined from ‘rte_memcpy_generic’ at
../lib/eal/x86/include/rte_memcpy.h:438:4,
inlined from ‘rte_memcpy’ at ../lib/eal/x86/include/r

[dpdk-dev] [Bug 851] gcc12 build error, net/qede/base

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=851

Bug ID: 851
   Summary: gcc12 build error, net/qede/base
   Product: DPDK
   Version: 20.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: other
  Assignee: dev@dpdk.org
  Reporter: ferruh.yi...@intel.com
  Target Milestone: ---

In file included from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/immintrin.h:43,
 from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/x86intrin.h:32,
 from ../lib/eal/x86/include/rte_vect.h:31,
 from ../lib/eal/x86/include/rte_memcpy.h:17,
 from ../drivers/net/qede/base/bcm_osal.h:17,
 from ../drivers/net/qede/base/ecore_vf.c:7:
In function ‘_mm256_storeu_si256’,
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:320:2,
inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:343:2,
inlined from ‘rte_memcpy_generic’ at
../lib/eal/x86/include/rte_memcpy.h:438:4,
inlined from ‘rte_memcpy’ at ../lib/eal/x86/include/rte_memcpy.h:882:10,
inlined from ‘ecore_vf_read_bulletin’ at
../drivers/net/qede/base/ecore_vf.c:1764:2:
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/avxintrin.h:935:8:
warning: array subscript ‘__m256i_u[2]’ is partly outside array bounds of
‘struct ecore_bulletin_content[1]’ [-Warray-bounds]
  935 |   *__P = __A;
  |   ~^
../drivers/net/qede/base/ecore_vf.c: In function ‘ecore_vf_read_bulletin’:
../drivers/net/qede/base/ecore_vf.c:1757:39: note: at offset 64 into object
‘shadow’ of size 80
 1757 | struct ecore_bulletin_content shadow;
  |   ^~
In file included from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/immintrin.h:43,
 from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/x86intrin.h:32,
 from ../lib/eal/x86/include/rte_vect.h:31,
 from ../lib/eal/x86/include/rte_memcpy.h:17,
 from ../drivers/net/qede/base/bcm_osal.h:17,
 from ../drivers/net/qede/base/ecore_vf.c:7:
In function ‘_mm256_storeu_si256’,
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:320:2,
inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:344:2,
inlined from ‘rte_memcpy_generic’ at
../lib/eal/x86/include/rte_memcpy.h:438:4,
inlined from ‘rte_memcpy’ at ../lib/eal/x86/include/rte_memcpy.h:882:10,
inlined from ‘ecore_vf_read_bulletin’ at
../drivers/net/qede/base/ecore_vf.c:1764:2:
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/avxintrin.h:935:8:
warning: array subscript 3 is outside array bounds of ‘struct
ecore_bulletin_content[1]’ [-Warray-bounds]
  935 |   *__P = __A;
  |   ~^
../drivers/net/qede/base/ecore_vf.c: In function ‘ecore_vf_read_bulletin’:
../drivers/net/qede/base/ecore_vf.c:1757:39: note: at offset 96 into object
‘shadow’ of size 80
 1757 | struct ecore_bulletin_content shadow;
  |   ^~
In file included from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/immintrin.h:43,
 from
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/x86intrin.h:32,
 from ../lib/eal/x86/include/rte_vect.h:31,
 from ../lib/eal/x86/include/rte_memcpy.h:17,
 from ../drivers/net/qede/base/bcm_osal.h:17,
 from ../drivers/net/qede/base/ecore_vf.c:7:
In function ‘_mm256_storeu_si256’,
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:320:2,
inlined from ‘rte_memcpy_generic’ at
../lib/eal/x86/include/rte_memcpy.h:450:4,
inlined from ‘rte_memcpy’ at ../lib/eal/x86/include/rte_memcpy.h:882:10,
inlined from ‘ecore_vf_read_bulletin’ at
../drivers/net/qede/base/ecore_vf.c:1764:2:
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/avxintrin.h:935:8:
warning: array subscript ‘__m256i_u[2]’ is partly outside array bounds of
‘void[80]’ [-Warray-bounds]
  935 |   *__P = __A;
  |   ~^
In function ‘_mm256_storeu_si256’,
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:320:2,
inlined from ‘rte_memcpy_generic’ at
../lib/eal/x86/include/rte_memcpy.h:451:4,
inlined from ‘rte_memcpy’ at ../lib/eal/x86/include/rte_memcpy.h:882:10,
inlined from ‘ecore_vf_read_bulletin’ at
../drivers/net/qede/base/ecore_vf.c:1764:2:
/usr/local/gcc-latest/lib/gcc/x86_64-pc-linux-gnu/12.0.0/include/avxintrin.h:935:8:
warning: array subscript ‘__m256i_u[2]’ is partly outside array bounds of
‘void[80]’ [-Warray-bounds]
  935 |   *__P = __A;
  |   ~^
In function ‘_mm256_loadu_si256’,
inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:319:9,
inlined f

[dpdk-dev] [Bug 852] gcc12 build error, net/ice/base

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=852

Bug ID: 852
   Summary: gcc12 build error, net/ice/base
   Product: DPDK
   Version: 20.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: other
  Assignee: dev@dpdk.org
  Reporter: ferruh.yi...@intel.com
  Target Milestone: ---

With gcc 12.0.0 "gcc (GCC) 12.0.0 20211024 (experimental)"

../drivers/net/ice/base/ice_switch.c: In function ‘ice_add_sw_recipe’:
../drivers/net/ice/base/ice_switch.c:7219:61: warning: writing 1 byte into a
region of size 0 [-Wstringop-overflow=]
 7219 | buf[recps].content.lkup_indx[i + 1] =
entry->fv_idx[i];
  |
^~
In file included from ../drivers/net/ice/base/ice_controlq.h:8,
 from ../drivers/net/ice/base/ice_type.h:54,
 from ../drivers/net/ice/base/ice_common.h:8,
 from ../drivers/net/ice/base/ice_switch.h:8,
 from ../drivers/net/ice/base/ice_switch.c:5:
../drivers/net/ice/base/ice_adminq_cmd.h:744:12: note: at offset 5 into
destination object ‘lkup_indx’ of size 5
  744 | u8 lkup_indx[5];
  |^
../drivers/net/ice/base/ice_switch.c:7219:61: warning: writing 1 byte into a
region of size 0 [-Wstringop-overflow=]
 7219 | buf[recps].content.lkup_indx[i + 1] =
entry->fv_idx[i];
  |
^~
In file included from ../drivers/net/ice/base/ice_controlq.h:8,
 from ../drivers/net/ice/base/ice_type.h:54,
 from ../drivers/net/ice/base/ice_common.h:8,
 from ../drivers/net/ice/base/ice_switch.h:8,
 from ../drivers/net/ice/base/ice_switch.c:5:
../drivers/net/ice/base/ice_adminq_cmd.h:744:12: note: at offset [6, 254] into
destination object ‘lkup_indx’ of size 5
  744 | u8 lkup_indx[5];
  |^
../drivers/net/ice/base/ice_switch.c:7219:61: warning: writing 1 byte into a
region of size 0 [-Wstringop-overflow=]
 7219 | buf[recps].content.lkup_indx[i + 1] =
entry->fv_idx[i];
  |
^~
In file included from ../drivers/net/ice/base/ice_controlq.h:8,
 from ../drivers/net/ice/base/ice_type.h:54,
 from ../drivers/net/ice/base/ice_common.h:8,
 from ../drivers/net/ice/base/ice_switch.h:8,
 from ../drivers/net/ice/base/ice_switch.c:5:
../drivers/net/ice/base/ice_adminq_cmd.h:744:12: note: at offset [7, 255] into
destination object ‘lkup_indx’ of size 5
  744 | u8 lkup_indx[5];
  |^

-- 
You are receiving this mail because:
You are the assignee for the bug.

[dpdk-dev] [Bug 853] gcc12 build error, common/cnxk

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=853

Bug ID: 853
   Summary: gcc12 build error, common/cnxk
   Product: DPDK
   Version: 20.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: other
  Assignee: dev@dpdk.org
  Reporter: ferruh.yi...@intel.com
  Target Milestone: ---

With gcc 12.0.0 "gcc (GCC) 12.0.0 20211024 (experimental)"

In file included from ../drivers/common/cnxk/cnxk_telemetry_nix.c:5:
In function ‘nix_sq_ctx’,   
inlined from ‘cnxk_tel_nix_sq_ctx’ at
../drivers/common/cnxk/cnxk_telemetry_nix.c:703:3,   
inlined from ‘cnxk_nix_tel_handle_info_x’ at
../drivers/common/cnxk/cnxk_telemetry_nix.c:812:9:  
../drivers/common/cnxk/cnxk_telemetry.h:12:38: warning: array subscript ‘struct
nix_cn10k_sq_ctx_s[0]’ is partly outside array bounds of ‘volatile void[8]’
[-Warray-bounds]
   12 |   (p)->s)   
../drivers/common/cnxk/cnxk_telemetry_nix.c:603:9: note: in expansion of macro
‘CNXK_TEL_DICT_INT’ 
  603 | CNXK_TEL_DICT_INT(d, ctx, sqe_way_mask, w0_);   
  | ^   
../drivers/common/cnxk/cnxk_telemetry_nix.c: In function
‘cnxk_nix_tel_handle_info_x’:   
../drivers/common/cnxk/cnxk_telemetry_nix.c:687:24: note: object ‘qctx’ of size
8   
  687 | volatile void *qctx;
  |^~~~ 
In file included from ../drivers/common/cnxk/cnxk_telemetry_nix.c:5:
In function ‘nix_sq_ctx’,   
inlined from ‘cnxk_tel_nix_sq_ctx’ at
../drivers/common/cnxk/cnxk_telemetry_nix.c:703:3,   
inlined from ‘cnxk_nix_tel_handle_info_x’ at
../drivers/common/cnxk/cnxk_telemetry_nix.c:812:9:
../drivers/common/cnxk/cnxk_telemetry.h:12:38: warning: array subscript ‘struct
nix_cn10k_sq_ctx_s[0]’ is partly outside array bounds of ‘volatile void[8]’
[-Warray-bounds]
   12 |   (p)->s)   
../drivers/common/cnxk/cnxk_telemetry_nix.c:604:9: note: in expansion of macro
‘CNXK_TEL_DICT_INT’ 
  604 | CNXK_TEL_DICT_INT(d, ctx, cq, w0_); 
  | ^   
../drivers/common/cnxk/cnxk_telemetry_nix.c: In function
‘cnxk_nix_tel_handle_info_x’: 
../drivers/common/cnxk/cnxk_telemetry_nix.c:687:24: note: object ‘qctx’ of size
8   
  687 | volatile void *qctx;
  |^~~~ 
In file included from ../drivers/common/cnxk/cnxk_telemetry_nix.c:5:
In function ‘nix_sq_ctx’,   
inlined from ‘cnxk_tel_nix_sq_ctx’ at
../drivers/common/cnxk/cnxk_telemetry_nix.c:703:3,  
inlined from ‘cnxk_nix_tel_handle_info_x’ at
../drivers/common/cnxk/cnxk_telemetry_nix.c:812:9:  
../drivers/common/cnxk/cnxk_telemetry.h:12:38: warning: array subscript ‘struct
nix_cn10k_sq_ctx_s[0]’ is partly outside array bounds of ‘volatile void[8]’
[-Warray-bounds]
   12 |   (p)->s)   
../drivers/common/cnxk/cnxk_telemetry_nix.c:605:9: note: in expansion of macro
‘CNXK_TEL_DICT_INT’ 
  605 | CNXK_TEL_DICT_INT(d, ctx, sdp_mcast, w0_);
  | ^
../drivers/common/cnxk/cnxk_telemetry_nix.c: In function
‘cnxk_nix_tel_handle_info_x’:
../drivers/common/cnxk/cnxk_telemetry_nix.c:687:24: note: object ‘qctx’ of size
8
  687 | volatile void *qctx;
  |^~~~
In file included from ../drivers/common/cnxk/cnxk_telemetry_nix.c:5:   
   
  [2696/177712]
In function ‘nix_sq_ctx’,
inlined from 

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

[Ananyev, Konstantin]

> Add the test content of the fragment_offset(offset and MF)
> to the test_ip_frag function. Add test data for a fragment
> that is not the last fragment.
> 
> Signed-off-by: huichao cai 
> ---
>  app/test/test_ipfrag.c | 95 
> +-
>  1 file changed, 79 insertions(+), 16 deletions(-)
> 
> diff --git a/app/test/test_ipfrag.c b/app/test/test_ipfrag.c
> index da8c212..1ced25a 100644
> --- a/app/test/test_ipfrag.c
> +++ b/app/test/test_ipfrag.c
> @@ -89,12 +89,14 @@ static void ut_teardown(void)
>  }
> 
>  static void
> -v4_allocate_packet_of(struct rte_mbuf *b, int fill, size_t s, int df,
> +v4_allocate_packet_of(struct rte_mbuf *b, int fill,
> +   size_t s, int df, uint8_t mf, uint16_t off,
> uint8_t ttl, uint8_t proto, uint16_t pktid)
>  {
>   /* Create a packet, 2k bytes long */
>   b->data_off = 0;
>   char *data = rte_pktmbuf_mtod(b, char *);
> + rte_be16_t fragment_offset = 0; /**< fragmentation offset */
> 
>   memset(data, fill, sizeof(struct rte_ipv4_hdr) + s);
> 
> @@ -106,9 +108,17 @@ static void ut_teardown(void)
>   b->data_len = b->pkt_len;
>   hdr->total_length = rte_cpu_to_be_16(b->pkt_len);
>   hdr->packet_id = rte_cpu_to_be_16(pktid);
> - hdr->fragment_offset = 0;
> +
>   if (df)
> - hdr->fragment_offset = rte_cpu_to_be_16(0x4000);
> + fragment_offset |= 0x4000;
> +
> + if (mf)
> + fragment_offset |= 0x2000;
> +
> + if (off)
> + fragment_offset |= off;
> +
> + hdr->fragment_offset = rte_cpu_to_be_16(fragment_offset);
> 
>   if (!ttl)
>   ttl = 64; /* default to 64 */
> @@ -155,38 +165,73 @@ static void ut_teardown(void)
>   rte_pktmbuf_free(mb[i]);
>  }
> 
> +static inline void
> +test_get_offset(struct rte_mbuf **mb, int32_t len,
> + uint16_t *offset, int ipv)
> +{
> + int32_t i;
> +
> + for (i = 0; i < len; i++) {
> + if (ipv == 4) {
> + struct rte_ipv4_hdr *iph =
> + rte_pktmbuf_mtod(mb[i], struct rte_ipv4_hdr *);
> + offset[i] = iph->fragment_offset;
> + } else if (ipv == 6) {
> + struct ipv6_extension_fragment *fh =
> + rte_pktmbuf_mtod_offset(
> + mb[i],
> + struct ipv6_extension_fragment *,
> + sizeof(struct rte_ipv6_hdr));
> + offset[i] = fh->frag_data;
> + }
> + }
> +}
> +
>  static int
>  test_ip_frag(void)
>  {
>   static const uint16_t RND_ID = UINT16_MAX;
>   int result = TEST_SUCCESS;
> - size_t i;
> + size_t i, j;
> 
>   struct test_ip_frags {
>   int  ipv;
>   size_t   mtu_size;
>   size_t   pkt_size;
>   int  set_df;
> + uint8_t  set_mf;
> + uint16_t set_of;
>   uint8_t  ttl;
>   uint8_t  proto;
>   uint16_t pkt_id;
>   int  expected_frags;
> + uint16_t expected_fragment_offset[BURST];
>   } tests[] = {
> -  {4, 1280, 1400, 0, 64, IPPROTO_ICMP, RND_ID, 2},
> -  {4, 1280, 1400, 0, 64, IPPROTO_ICMP, 0,  2},
> -  {4,  600, 1400, 0, 64, IPPROTO_ICMP, RND_ID, 3},
> -  {4,4, 1400, 0, 64, IPPROTO_ICMP, RND_ID, -EINVAL},
> -  {4,  600, 1400, 1, 64, IPPROTO_ICMP, RND_ID, -ENOTSUP},
> -  {4,  600, 1400, 0,  0, IPPROTO_ICMP, RND_ID, 3},
> -
> -  {6, 1280, 1400, 0, 64, IPPROTO_ICMP, RND_ID, 2},
> -  {6, 1300, 1400, 0, 64, IPPROTO_ICMP, RND_ID, 2},
> -  {6,4, 1400, 0, 64, IPPROTO_ICMP, RND_ID, -EINVAL},
> -  {6, 1300, 1400, 0,  0, IPPROTO_ICMP, RND_ID, 2},
> +  {4, 1280, 1400, 0, 0, 0, 64, IPPROTO_ICMP, RND_ID,   2,
> +   {0x2000, 0x009D}},
> +  {4, 1280, 1400, 0, 0, 0, 64, IPPROTO_ICMP, 0,2,
> +   {0x2000, 0x009D}},
> +  {4,  600, 1400, 0, 0, 0, 64, IPPROTO_ICMP, RND_ID,   3,
> +   {0x2000, 0x2048, 0x0090}},
> +  {4, 4, 1400, 0, 0, 0, 64, IPPROTO_ICMP, RND_ID,-EINVAL},
> +  {4, 600, 1400, 1, 0, 0, 64, IPPROTO_ICMP, RND_ID, -ENOTSUP},
> +  {4, 600, 1400, 0, 0, 0, 0, IPPROTO_ICMP, RND_ID, 3,
> +   {0x2000, 0x2048, 0x0090}},
> +  {4, 68, 104, 0, 1, 13, 0, IPPROTO_ICMP, RND_ID,  3,
> +   {0x200D, 0x2013, 0x2019}},
> +
> +  {6, 1280, 1400, 0, 0, 0, 64, IPPROTO_ICMP, RND_ID,   2,
> +   {0x0001, 0x04D0}},
> +  {6, 1300, 1400, 0, 0, 0, 64, IPPROTO_ICMP, RND_ID,   2,
> +   {0x0001, 0x04E0}},
> +  {6, 4, 1400, 0, 0, 0, 64, I

[dpdk-dev] [Bug 854] gcc12 build error, common/cnxk

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=854

Bug ID: 854
   Summary: gcc12 build error, common/cnxk
   Product: DPDK
   Version: 20.11
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: Normal
 Component: other
  Assignee: dev@dpdk.org
  Reporter: ferruh.yi...@intel.com
  Target Milestone: ---

With gcc 12.0.0 "gcc (GCC) 12.0.0 20211024 (experimental)"

In function ‘npc_prep_mcam_ldata’,
inlined from ‘npc_update_extraction_data’ at
../drivers/common/cnxk/roc_npc_utils.c:195:2:
../drivers/common/cnxk/roc_npc_utils.c:13:26: warning: writing 32 bytes into a
region of size 0 [-Wstringop-overflow=]
   13 | ptr[idx] = data[len - 1 - idx];
  | ~^
../drivers/common/cnxk/roc_npc_utils.c: In function
‘npc_update_extraction_data’:
../drivers/common/cnxk/roc_npc_utils.c:163:17: note: at offset 64 into
destination object ‘int_info’ of size 64
  163 | uint8_t int_info[NPC_MAX_EXTRACT_DATA_LEN];
  | ^~~~
In function ‘npc_prep_mcam_ldata’,
inlined from ‘npc_update_extraction_data’ at
../drivers/common/cnxk/roc_npc_utils.c:195:2:
../drivers/common/cnxk/roc_npc_utils.c:13:26: warning: writing 32 bytes into a
region of size 0 [-Wstringop-overflow=]
   13 | ptr[idx] = data[len - 1 - idx];
  | ~^
../drivers/common/cnxk/roc_npc_utils.c: In function
‘npc_update_extraction_data’:
../drivers/common/cnxk/roc_npc_utils.c:163:17: note: at offset [96, 127] into
destination object ‘int_info’ of size 64
  163 | uint8_t int_info[NPC_MAX_EXTRACT_DATA_LEN];
  | ^~~~
In function ‘npc_prep_mcam_ldata’,
inlined from ‘npc_update_extraction_data’ at
../drivers/common/cnxk/roc_npc_utils.c:195:2:
../drivers/common/cnxk/roc_npc_utils.c:13:26: warning: writing 32 bytes into a
region of size 0 [-Wstringop-overflow=]
   13 | ptr[idx] = data[len - 1 - idx];
  | ~^
../drivers/common/cnxk/roc_npc_utils.c: In function
‘npc_update_extraction_data’:
../drivers/common/cnxk/roc_npc_utils.c:163:17: note: at offset [128, 159] into
destination object ‘int_info’ of size 64
  163 | uint8_t int_info[NPC_MAX_EXTRACT_DATA_LEN];
  | ^~~~
In function ‘npc_prep_mcam_ldata’,
inlined from ‘npc_update_extraction_data’ at
../drivers/common/cnxk/roc_npc_utils.c:195:2:
../drivers/common/cnxk/roc_npc_utils.c:13:26: warning: writing 32 bytes into a
region of size 0 [-Wstringop-overflow=]
   13 | ptr[idx] = data[len - 1 - idx];
  | ~^
../drivers/common/cnxk/roc_npc_utils.c: In function
‘npc_update_extraction_data’:
../drivers/common/cnxk/roc_npc_utils.c:163:17: note: at offset [160, 191] into
destination object ‘int_info’ of size 64
  163 | uint8_t int_info[NPC_MAX_EXTRACT_DATA_LEN];
  | ^~~~
In function ‘npc_prep_mcam_ldata’,
inlined from ‘npc_update_extraction_data’ at
../drivers/common/cnxk/roc_npc_utils.c:195:2:
../drivers/common/cnxk/roc_npc_utils.c:13:26: warning: writing 32 bytes into a
region of size 0 [-Wstringop-overflow=]
   13 | ptr[idx] = data[len - 1 - idx];
  | ~^
../drivers/common/cnxk/roc_npc_utils.c: In function
‘npc_update_extraction_data’:
../drivers/common/cnxk/roc_npc_utils.c:163:17: note: at offset [192, 223] into
destination object ‘int_info’ of size 64
  163 | uint8_t int_info[NPC_MAX_EXTRACT_DATA_LEN];
  | ^~~~
In function ‘npc_prep_mcam_ldata’,
inlined from ‘npc_update_extraction_data’ at
../drivers/common/cnxk/roc_npc_utils.c:197:2:
../drivers/common/cnxk/roc_npc_utils.c:13:26: warning: writing 32 bytes into a
region of size 0 [-Wstringop-overflow=]
   13 | ptr[idx] = data[len - 1 - idx];
  | ~^
../drivers/common/cnxk/roc_npc_utils.c: In function
‘npc_update_extraction_data’:
../drivers/common/cnxk/roc_npc_utils.c:162:17: note: at offset 64 into
destination object ‘int_info_mask’ of size 64
  162 | uint8_t int_info_mask[NPC_MAX_EXTRACT_DATA_LEN];
  | ^
In function ‘npc_prep_mcam_ldata’,
inlined from ‘npc_update_extraction_data’ at
../drivers/common/cnxk/roc_npc_utils.c:197:2:
../drivers/common/cnxk/roc_npc_utils.c:13:26: warning: writing 32 bytes into a
region of size 0 [-Wstringop-overflow=]
   13 | ptr[idx] = data[len - 1 - idx];
  | ~^
../drivers/common/cnxk/roc_npc_utils.c: In function
‘npc_update_extraction_data’:
../drivers/common/cnxk/roc_npc_utils.c:162:17: note: at offset [96, 127] into
destination object ‘int_info_mask’ of size 64
  162 |