[dpdk-dev] [PATCH] vdpa/ifc: fix build issue with recent kernels

[Maxime Coquelin]

VIRTIO_F_IOMMU_PLATFORM is now defined in recent kernel
headers, causing build issue.

Le's define it in IFC vDPA driver only if wasn't already.

Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
Cc: sta...@dpdk.org

Reported-by: Brandon Lo 
Signed-off-by: Maxime Coquelin 
---
 drivers/vdpa/ifc/base/ifcvf.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
index a288ce57dc..573a35ffb4 100644
--- a/drivers/vdpa/ifc/base/ifcvf.h
+++ b/drivers/vdpa/ifc/base/ifcvf.h
@@ -13,7 +13,10 @@
 #define IFCVF_SUBSYS_DEVICE_ID 0x001A
 
 #define IFCVF_MAX_QUEUES   1
+
+#ifndef VIRTIO_F_IOMMU_PLATFORM
 #define VIRTIO_F_IOMMU_PLATFORM33
+#endif
 
 /* Common configuration */
 #define IFCVF_PCI_CAP_COMMON_CFG   1
-- 
2.26.2

Re: [dpdk-dev] [PATCH v3 1/1] net/mlx5: support match ICMP identifier fields

[Li Zhang]

Hi Ori,

Thanks for your comments.
My answer inline.
I will update them in V4 patch.

Regards,
Li Zhang

> -Original Message-
> From: Ori Kam 
> Sent: Thursday, October 1, 2020 4:14 PM
> To: Li Zhang ; Dekel Peled ; Slava
> Ovsiienko ; Matan Azrad 
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon
> ; Raslan Darawsheh 
> Subject: RE: [dpdk-dev] [PATCH v3 1/1] net/mlx5: support match ICMP
> identifier fields
> 
> Hi
> Sorry I didn't see that you sent V3 and responded on V2 So just rewriting my
> comments.
> 
> Best,
> Ori
> 
> > -Original Message-
> > From: dev  On Behalf Of Li Zhang
> > Subject: [dpdk-dev] [PATCH v3 1/1] net/mlx5: support match ICMP
> > identifier fields
> >
> > PRM expose fields "Icmp_header_data" in IPv4 ICMP.
> > Update ICMP mask parameter with ICMP identifier and sequence number
> > fields.
> > ICMP sequence number spec with mask, Icmp_header_data low 16 bits are
> set.
> > ICMP identifier spec with mask, Icmp_header_data high 16 bits are set.
> >
> > Signed-off-by: Li Zhang 
> > ---
> >  doc/guides/nics/mlx5.rst   |  4 ++--
> >  doc/guides/rel_notes/release_20_11.rst |  2 +-
> >  drivers/net/mlx5/mlx5_flow.c   | 10 --
> >  drivers/net/mlx5/mlx5_flow_dv.c| 16 +++-
> >  4 files changed, 26 insertions(+), 6 deletions(-)
> >
> > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index
> > 211c0c5a6c..576dbe5efd 100644
> > --- a/doc/guides/nics/mlx5.rst
> > +++ b/doc/guides/nics/mlx5.rst
> > @@ -288,7 +288,7 @@ Limitations
> >- The input buffer, providing the removal size, is not validated.
> >- The buffer size must match the length of the headers to be removed.
> >
> > -- ICMP/ICMP6 code/type matching, IP-in-IP and MPLS flow matching are
> > all
> > +- ICMP(code/type/identifier/sequence number) / ICMP6(code/type)
> > +matching,
> > IP-in-IP and MPLS flow matching are all
> >mutually exclusive features which cannot be supported together
> >(see :ref:`mlx5_firmware_config`).
> >
> > @@ -1009,7 +1009,7 @@ Below are some firmware configurations listed.
> >
> >  FLEX_PARSER_PROFILE_ENABLE=1
> >
> > -- enable ICMP/ICMP6 code/type fields matching::
> > +- enable ICMP(code/type/identifier/sequence number) /
> > +ICMP6(code/type)
> > fields matching::
> >
> >  FLEX_PARSER_PROFILE_ENABLE=2
> >
> > diff --git a/doc/guides/rel_notes/release_20_11.rst
> > b/doc/guides/rel_notes/release_20_11.rst
> > index c6642f5f94..791f133d8f 100644
> > --- a/doc/guides/rel_notes/release_20_11.rst
> > +++ b/doc/guides/rel_notes/release_20_11.rst
> > @@ -73,7 +73,7 @@ New Features
> >* Added flag action.
> >* Added raw encap/decap actions.
> >* Added VXLAN encap/decap actions.
> > -  * Added ICMP and ICMP6 matching items.
> > +  * Added ICMP(code/type/identifier/sequence number) and
> > ICMP6(code/type) matching items.
> >* Added option to set port mask for insertion/deletion:
> >  ``--portmask=N``
> >  where N represents the hexadecimal bitmask of ports used.
> > diff --git a/drivers/net/mlx5/mlx5_flow.c
> > b/drivers/net/mlx5/mlx5_flow.c index 416505f1c8..3cabfd4627 100644
> > --- a/drivers/net/mlx5/mlx5_flow.c
> > +++ b/drivers/net/mlx5/mlx5_flow.c
> > @@ -1303,6 +1303,12 @@ mlx5_flow_validate_item_icmp(const struct
> > rte_flow_item *item,
> >  struct rte_flow_error *error)  {
> > const struct rte_flow_item_icmp *mask = item->mask;
> > +   const struct rte_flow_item_icmp nic_mask = {
> > +   .hdr.icmp_type = 0xff,
> > +   .hdr.icmp_code = 0xff,
> > +   .hdr.icmp_ident = RTE_BE16(0x),
> > +   .hdr.icmp_seq_nb = RTE_BE16(0x),
> > +   };
> > const int tunnel = !!(item_flags & MLX5_FLOW_LAYER_TUNNEL);
> > const uint64_t l3m = tunnel ? MLX5_FLOW_LAYER_INNER_L3_IPV4 :
> >   MLX5_FLOW_LAYER_OUTER_L3_IPV4;
> @@ -1325,10 +1331,10 @@
> > mlx5_flow_validate_item_icmp(const struct rte_flow_item *item,
> >   RTE_FLOW_ERROR_TYPE_ITEM,
> > item,
> >   "multiple L4 layers not supported");
> > if (!mask)
> > -   mask = &rte_flow_item_icmp_mask;
> > +   mask = &nic_mask;
> > ret = mlx5_flow_item_acceptable
> > (item, (const uint8_t *)mask,
> > -(const uint8_t *)&rte_flow_item_icmp_mask,
> > +(const uint8_t *)&nic_mask,
> >  sizeof(struct rte_flow_item_icmp), error);
> > if (ret < 0)
> > return ret;
> > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> > b/drivers/net/mlx5/mlx5_flow_dv.c index 3819cdb266..b5d6455067
> 100644
> > --- a/drivers/net/mlx5/mlx5_flow_dv.c
> > +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> > @@ -7378,6 +7378,8 @@ flow_dv_translate_item_icmp(void *matcher,
> void
> > *key,  {
> > const struct rte_flow_item_icmp *icmp_m = item->mask;
> > const struct rte_flow_item_icmp *icmp_v = item->spec;
> > +   uint32_t icmp_header_data_

[dpdk-dev] [PATCH] pipeline: fix build with glibc < 2.26

[David Marchand]

reallocarray has been introduced in glibc 2.26 but we still support
glibc >= 2.7.
Simply replace with realloc, as the considered sizes are unlikely to
overflow.

"""
The reallocarray() function changes the size of the memory block
pointed to by ptr to be large enough for an array of nmemb elements,
each of which is size bytes.  It is equivalent to the call

   realloc(ptr, nmemb * size);

However, unlike that realloc() call, reallocarray() fails safely in
the case where the multiplication would overflow.  If such an over‐
flow occurs, reallocarray() returns NULL, sets errno to ENOMEM, and
leaves the original block of memory unchanged.
"""

Fixes: 3ca60ceed79a ("pipeline: add SWX pipeline specification file")

Signed-off-by: David Marchand 
---
 lib/librte_pipeline/rte_swx_pipeline_spec.c | 25 +
 1 file changed, 10 insertions(+), 15 deletions(-)

diff --git a/lib/librte_pipeline/rte_swx_pipeline_spec.c 
b/lib/librte_pipeline/rte_swx_pipeline_spec.c
index d72badd03d..95de8f983d 100644
--- a/lib/librte_pipeline/rte_swx_pipeline_spec.c
+++ b/lib/librte_pipeline/rte_swx_pipeline_spec.c
@@ -213,9 +213,8 @@ struct_block_parse(struct struct_spec *s,
return -ENOMEM;
}
 
-   new_fields = reallocarray(s->fields,
- s->n_fields + 1,
- sizeof(struct rte_swx_field_params));
+   new_fields = realloc(s->fields,
+(s->n_fields + 1) * sizeof(struct 
rte_swx_field_params));
if (!new_fields) {
free(name);
 
@@ -452,9 +451,8 @@ action_block_parse(struct action_spec *s,
return -ENOMEM;
}
 
-   new_instructions = reallocarray(s->instructions,
-   s->n_instructions + 1,
-   sizeof(char *));
+   new_instructions = realloc(s->instructions,
+  (s->n_instructions + 1) * sizeof(char *));
if (!new_instructions) {
free(instr);
 
@@ -620,9 +618,8 @@ table_key_block_parse(struct table_spec *s,
return -ENOMEM;
}
 
-   new_fields = reallocarray(s->params.fields,
- s->params.n_fields + 1,
- sizeof(struct rte_swx_match_field_params));
+   new_fields = realloc(s->params.fields,
+(s->params.n_fields + 1) * sizeof(struct 
rte_swx_match_field_params));
if (!new_fields) {
free(name);
 
@@ -700,9 +697,8 @@ table_actions_block_parse(struct table_spec *s,
return -ENOMEM;
}
 
-   new_action_names = reallocarray(s->params.action_names,
-   s->params.n_actions + 1,
-   sizeof(char *));
+   new_action_names = realloc(s->params.action_names,
+  (s->params.n_actions + 1) * sizeof(char *));
if (!new_action_names) {
free(name);
 
@@ -1019,9 +1015,8 @@ apply_block_parse(struct apply_spec *s,
return -ENOMEM;
}
 
-   new_instructions = reallocarray(s->instructions,
-   s->n_instructions + 1,
-   sizeof(char *));
+   new_instructions = realloc(s->instructions,
+  (s->n_instructions + 1) * sizeof(char *));
if (!new_instructions) {
free(instr);
 
-- 
2.23.0

Re: [dpdk-dev] [PATCH] vdpa/ifc: fix build issue with recent kernels

[David Marchand]

On Fri, Oct 2, 2020 at 9:54 AM Maxime Coquelin
 wrote:
>
> VIRTIO_F_IOMMU_PLATFORM is now defined in recent kernel
> headers, causing build issue.
>
> Le's define it in IFC vDPA driver only if wasn't already.

Let's* define it in the* IFC vDPA driver only if it* wasn't already.

>
> Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> Cc: sta...@dpdk.org
>
> Reported-by: Brandon Lo 
> Signed-off-by: Maxime Coquelin 
> ---
>  drivers/vdpa/ifc/base/ifcvf.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
> index a288ce57dc..573a35ffb4 100644
> --- a/drivers/vdpa/ifc/base/ifcvf.h
> +++ b/drivers/vdpa/ifc/base/ifcvf.h
> @@ -13,7 +13,10 @@
>  #define IFCVF_SUBSYS_DEVICE_ID 0x001A
>
>  #define IFCVF_MAX_QUEUES   1
> +
> +#ifndef VIRTIO_F_IOMMU_PLATFORM
>  #define VIRTIO_F_IOMMU_PLATFORM33
> +#endif
>
>  /* Common configuration */
>  #define IFCVF_PCI_CAP_COMMON_CFG   1
> --
> 2.26.2
>

Acked-by: David Marchand 


-- 
David Marchand

[dpdk-dev] vhost/crypto: fix initialization.

[Fan Zhang]

This patch fixes the problem that vhost crypto cannot be
initialized due to the different requirement between
built-in virtio-net and virtio-crypto. The fix includes
the following change:

- Added new internal enum type virtio_backend_type to
distinguish virtio-net, virtio-crypto, and external
device types.
- Added new API rte_vhost_crypto_driver_start to
distinguish between virtio-net and virtio-crypto built-in
drivers initialization.
- Added new internal function for the vhost library
to use different feature flags when initializing
virtio-crypto.

Fixes: 2ab58f20db51 ("vhost: refactor virtio ready check")
Cc: maxime.coque...@redhat.com

Signed-off-by: Fan Zhang 
---
 examples/vhost_crypto/main.c   |  3 +-
 lib/librte_vhost/rte_vhost_crypto.h| 12 +++
 lib/librte_vhost/rte_vhost_version.map |  1 +
 lib/librte_vhost/socket.c  | 44 +-
 lib/librte_vhost/vhost.h   |  1 -
 lib/librte_vhost/vhost_crypto.c| 35 
 lib/librte_vhost/vhost_user.h  | 12 +++
 7 files changed, 84 insertions(+), 24 deletions(-)

diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
index 11b022e81..ef64e96de 100644
--- a/examples/vhost_crypto/main.c
+++ b/examples/vhost_crypto/main.c
@@ -598,7 +598,8 @@ main(int argc, char *argv[])
rte_vhost_driver_callback_register(lo->socket_files[j],
&virtio_crypto_device_ops);
 
-   ret = rte_vhost_driver_start(lo->socket_files[j]);
+   ret = rte_vhost_crypto_driver_start(
+   lo->socket_files[j]);
if (ret < 0)  {
RTE_LOG(ERR, USER1, "failed to start vhost.\n");
goto error_exit;
diff --git a/lib/librte_vhost/rte_vhost_crypto.h 
b/lib/librte_vhost/rte_vhost_crypto.h
index b54d61db6..c809c46a2 100644
--- a/lib/librte_vhost/rte_vhost_crypto.h
+++ b/lib/librte_vhost/rte_vhost_crypto.h
@@ -20,6 +20,18 @@ enum rte_vhost_crypto_zero_copy {
RTE_VHOST_CRYPTO_MAX_ZERO_COPY_OPTIONS
 };
 
+/**
+ * Start vhost crypto driver
+ *
+ * @param path
+ *  The vhost-user socket file path
+ * @return
+ *  0 on success, -1 on failure
+ */
+__rte_experimental
+int
+rte_vhost_crypto_driver_start(const char *path);
+
 /**
  *  Create Vhost-crypto instance
  *
diff --git a/lib/librte_vhost/rte_vhost_version.map 
b/lib/librte_vhost/rte_vhost_version.map
index 20b4abcb4..a454d5f41 100644
--- a/lib/librte_vhost/rte_vhost_version.map
+++ b/lib/librte_vhost/rte_vhost_version.map
@@ -48,6 +48,7 @@ EXPERIMENTAL {
rte_vhost_get_vring_base;
rte_vhost_set_vring_base;
rte_vhost_crypto_create;
+   rte_vhost_crypto_driver_start;
rte_vhost_crypto_free;
rte_vhost_crypto_fetch_requests;
rte_vhost_crypto_finalize_requests;
diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
index 73e1dca95..3de2da836 100644
--- a/lib/librte_vhost/socket.c
+++ b/lib/librte_vhost/socket.c
@@ -39,7 +39,7 @@ struct vhost_user_socket {
bool reconnect;
bool dequeue_zero_copy;
bool iommu_support;
-   bool use_builtin_virtio_net;
+   enum virtio_backend_type backend_type;
bool extbuf;
bool linearbuf;
bool async_copy;
@@ -225,7 +225,15 @@ vhost_user_add_connection(int fd, struct vhost_user_socket 
*vsocket)
size = strnlen(vsocket->path, PATH_MAX);
vhost_set_ifname(vid, vsocket->path, size);
 
-   vhost_set_builtin_virtio_net(vid, vsocket->use_builtin_virtio_net);
+   vhost_set_builtin_virtio_net(vid,
+   vsocket->backend_type == VIRTIO_DEV_BUILTIN_NET ?
+   true : false);
+
+   if (vsocket->backend_type == VIRTIO_DEV_BUILTIN_CRYPTO) {
+   vhost_crypto_set_feature_flags(&vsocket->supported_features,
+   &vsocket->protocol_features);
+   vsocket->features = vsocket->supported_features;
+   }
 
vhost_attach_vdpa_device(vid, vsocket->vdpa_dev);
 
@@ -636,7 +644,7 @@ rte_vhost_driver_disable_features(const char *path, 
uint64_t features)
pthread_mutex_lock(&vhost_user.mutex);
vsocket = find_vhost_user_socket(path);
 
-   /* Note that use_builtin_virtio_net is not affected by this function
+   /* Note that backend type is not affected by this function
 * since callers may want to selectively disable features of the
 * built-in vhost net device backend.
 */
@@ -685,7 +693,7 @@ rte_vhost_driver_set_features(const char *path, uint64_t 
features)
/* Anyone setting feature bits is implementing their own vhost
 * device backend.
 */
-   vsocket->use_builtin_virtio_net = false;
+   vsocket->backend_type = VIRTIO_DEV_UNKNOWN;
}
pthread_mut

[dpdk-dev] [PATCH v4 1/1] net/mlx5: support match ICMP identifier fields

[Li Zhang]

PRM expose fields "Icmp_header_data" in IPv4 ICMP.
Update ICMP mask parameter with ICMP identifier and sequence number fields.
ICMP sequence number spec with mask, Icmp_header_data low 16 bits are set.
ICMP identifier spec with mask, Icmp_header_data high 16 bits are set.

Signed-off-by: Li Zhang 
---
 doc/guides/nics/mlx5.rst   |  4 ++--
 doc/guides/rel_notes/release_20_11.rst |  2 +-
 drivers/net/mlx5/mlx5_flow.c   | 10 --
 drivers/net/mlx5/mlx5_flow_dv.c| 24 ++--
 4 files changed, 33 insertions(+), 7 deletions(-)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 211c0c5a6c..576dbe5efd 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -288,7 +288,7 @@ Limitations
   - The input buffer, providing the removal size, is not validated.
   - The buffer size must match the length of the headers to be removed.
 
-- ICMP/ICMP6 code/type matching, IP-in-IP and MPLS flow matching are all
+- ICMP(code/type/identifier/sequence number) / ICMP6(code/type) matching, 
IP-in-IP and MPLS flow matching are all
   mutually exclusive features which cannot be supported together
   (see :ref:`mlx5_firmware_config`).
 
@@ -1009,7 +1009,7 @@ Below are some firmware configurations listed.
 
 FLEX_PARSER_PROFILE_ENABLE=1
 
-- enable ICMP/ICMP6 code/type fields matching::
+- enable ICMP(code/type/identifier/sequence number) / ICMP6(code/type) fields 
matching::
 
 FLEX_PARSER_PROFILE_ENABLE=2
 
diff --git a/doc/guides/rel_notes/release_20_11.rst 
b/doc/guides/rel_notes/release_20_11.rst
index c6642f5f94..791f133d8f 100644
--- a/doc/guides/rel_notes/release_20_11.rst
+++ b/doc/guides/rel_notes/release_20_11.rst
@@ -73,7 +73,7 @@ New Features
   * Added flag action.
   * Added raw encap/decap actions.
   * Added VXLAN encap/decap actions.
-  * Added ICMP and ICMP6 matching items.
+  * Added ICMP(code/type/identifier/sequence number) and ICMP6(code/type) 
matching items.
   * Added option to set port mask for insertion/deletion:
 ``--portmask=N``
 where N represents the hexadecimal bitmask of ports used.
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 416505f1c8..3cabfd4627 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1303,6 +1303,12 @@ mlx5_flow_validate_item_icmp(const struct rte_flow_item 
*item,
 struct rte_flow_error *error)
 {
const struct rte_flow_item_icmp *mask = item->mask;
+   const struct rte_flow_item_icmp nic_mask = {
+   .hdr.icmp_type = 0xff,
+   .hdr.icmp_code = 0xff,
+   .hdr.icmp_ident = RTE_BE16(0x),
+   .hdr.icmp_seq_nb = RTE_BE16(0x),
+   };
const int tunnel = !!(item_flags & MLX5_FLOW_LAYER_TUNNEL);
const uint64_t l3m = tunnel ? MLX5_FLOW_LAYER_INNER_L3_IPV4 :
  MLX5_FLOW_LAYER_OUTER_L3_IPV4;
@@ -1325,10 +1331,10 @@ mlx5_flow_validate_item_icmp(const struct rte_flow_item 
*item,
  RTE_FLOW_ERROR_TYPE_ITEM, item,
  "multiple L4 layers not supported");
if (!mask)
-   mask = &rte_flow_item_icmp_mask;
+   mask = &nic_mask;
ret = mlx5_flow_item_acceptable
(item, (const uint8_t *)mask,
-(const uint8_t *)&rte_flow_item_icmp_mask,
+(const uint8_t *)&nic_mask,
 sizeof(struct rte_flow_item_icmp), error);
if (ret < 0)
return ret;
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 3819cdb266..a0b78934fd 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -7378,6 +7378,14 @@ flow_dv_translate_item_icmp(void *matcher, void *key,
 {
const struct rte_flow_item_icmp *icmp_m = item->mask;
const struct rte_flow_item_icmp *icmp_v = item->spec;
+   const struct rte_flow_item_icmp nic_mask = {
+   .hdr.icmp_type = 0xff,
+   .hdr.icmp_code = 0xff,
+   .hdr.icmp_ident = RTE_BE16(0x),
+   .hdr.icmp_seq_nb = RTE_BE16(0x),
+   };
+   uint32_t icmp_header_data_m = 0;
+   uint32_t icmp_header_data_v = 0;
void *headers_m;
void *headers_v;
void *misc3_m = MLX5_ADDR_OF(fte_match_param, matcher,
@@ -7396,8 +7404,14 @@ flow_dv_translate_item_icmp(void *matcher, void *key,
MLX5_SET(fte_match_set_lyr_2_4, headers_v, ip_protocol, IPPROTO_ICMP);
if (!icmp_v)
return;
-   if (!icmp_m)
-   icmp_m = &rte_flow_item_icmp_mask;
+   if (!icmp_m) {
+   icmp_m = &nic_mask;
+   icmp_header_data_m = UINT32_MAX;
+   } else {
+   icmp_header_data_m = rte_be_to_cpu_16(icmp_m->hdr.icmp_seq_nb);
+   icmp_header_data_m |=
+   rte_be_to_c

[dpdk-dev] [PATCH 2/2] baseband/fpga_lte_fec: fix API naming

[Maxime Coquelin]

DPDK APIs have to be prefixed with "rte_" in order to avoid
namespace pollution.

Let's fix it while fpga_lte_fec API is still experimental.

Signed-off-by: Maxime Coquelin 
---
 app/test-bbdev/test_bbdev_perf.c   |  6 +++---
 doc/guides/bbdevs/fpga_lte_fec.rst | 14 +++---
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.c   | 10 +-
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.h   |  6 +++---
 .../rte_pmd_bbdev_fpga_lte_fec_version.map |  2 +-
 5 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 14f150704e..d4a3681344 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -568,14 +568,14 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
 #ifdef RTE_LIBRTE_PMD_BBDEV_FPGA_LTE_FEC
if ((get_init_device() == true) &&
(!strcmp(info->drv.driver_name, FPGA_LTE_PF_DRIVER_NAME))) {
-   struct fpga_lte_fec_conf conf;
+   struct rte_fpga_lte_fec_conf conf;
unsigned int i;
 
printf("Configure FPGA LTE FEC Driver %s with default values\n",
info->drv.driver_name);
 
/* clear default configuration before initialization */
-   memset(&conf, 0, sizeof(struct fpga_lte_fec_conf));
+   memset(&conf, 0, sizeof(struct rte_fpga_lte_fec_conf));
 
/* Set PF mode :
 * true if PF is used for data plane
@@ -603,7 +603,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
conf.flr_time_out = FLR_4G_TIMEOUT;
 
/* setup FPGA PF with configuration information */
-   ret = fpga_lte_fec_configure(info->dev_name, &conf);
+   ret = rte_fpga_lte_fec_configure(info->dev_name, &conf);
TEST_ASSERT_SUCCESS(ret,
"Failed to configure 4G FPGA PF for bbdev %s",
info->dev_name);
diff --git a/doc/guides/bbdevs/fpga_lte_fec.rst 
b/doc/guides/bbdevs/fpga_lte_fec.rst
index fdc8a76981..a8cc3c58a8 100644
--- a/doc/guides/bbdevs/fpga_lte_fec.rst
+++ b/doc/guides/bbdevs/fpga_lte_fec.rst
@@ -169,12 +169,12 @@ queues, priorities, load balance, bandwidth and other 
settings necessary for the
 device to perform FEC functions.
 
 This configuration needs to be executed at least once after reboot or PCI FLR 
and can
-be achieved by using the function ``fpga_lte_fec_configure()``, which sets up 
the
-parameters defined in ``fpga_lte_fec_conf`` structure:
+be achieved by using the function ``rte_fpga_lte_fec_configure()``, which sets 
up the
+parameters defined in ``rte_fpga_lte_fec_conf`` structure:
 
 .. code-block:: c
 
-  struct fpga_lte_fec_conf {
+  struct rte_fpga_lte_fec_conf {
   bool pf_mode_en;
   uint8_t vf_ul_queues_number[FPGA_LTE_FEC_NUM_VFS];
   uint8_t vf_dl_queues_number[FPGA_LTE_FEC_NUM_VFS];
@@ -213,15 +213,15 @@ parameters defined in ``fpga_lte_fec_conf`` structure:
   the FLR time out then set this setting to 0x262=610.
 
 
-An example configuration code calling the function 
``fpga_lte_fec_configure()`` is shown
+An example configuration code calling the function 
``rte_fpga_lte_fec_configure()`` is shown
 below:
 
 .. code-block:: c
 
-  struct fpga_lte_fec_conf conf;
+  struct rte_fpga_lte_fec_conf conf;
   unsigned int i;
 
-  memset(&conf, 0, sizeof(struct fpga_lte_fec_conf));
+  memset(&conf, 0, sizeof(struct rte_fpga_lte_fec_conf));
   conf.pf_mode_en = 1;
 
   for (i = 0; i < FPGA_LTE_FEC_NUM_VFS; ++i) {
@@ -234,7 +234,7 @@ below:
   conf.ul_load_balance = 64;
 
   /* setup FPGA PF */
-  ret = fpga_lte_fec_configure(info->dev_name, &conf);
+  ret = rte_fpga_lte_fec_configure(info->dev_name, &conf);
   TEST_ASSERT_SUCCESS(ret,
   "Failed to configure 4G FPGA PF for bbdev %s",
   info->dev_name);
diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c 
b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
index 37018b9c7f..71de399eef 100644
--- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
+++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
@@ -2432,10 +2432,10 @@ fpga_lte_fec_remove(struct rte_pci_device *pci_dev)
 }
 
 static inline void
-set_default_fpga_conf(struct fpga_lte_fec_conf *def_conf)
+set_default_fpga_conf(struct rte_fpga_lte_fec_conf *def_conf)
 {
/* clear default configuration before initialization */
-   memset(def_conf, 0, sizeof(struct fpga_lte_fec_conf));
+   memset(def_conf, 0, sizeof(struct rte_fpga_lte_fec_conf));
/* Set pf mode to true */
def_conf->pf_mode_en = true;
 
@@ -2450,15 +2450,15 @@ set_default_fpga_conf(struct fpga_lte_fec_conf 
*def_conf)
 
 /* Initial configuration of FPGA LTE FEC device */
 int
-fpga_lte_fec_configure(const char *dev_name,
-   const struct fpga_lte_fec_conf *conf)
+rte_fpga_lte_fec_configure(const char *dev_name,
+

[dpdk-dev] [PATCH 0/2] baseband: fix drivers API

[Maxime Coquelin]

The series prefixes drivers APIs with rte__ in
order to avoid namespace pollution.

These APIs are experimental, so no need to follow the 
deprecation process.

Maxime Coquelin (2):
  baseband/fpga_5gnr_fec: fix API naming
  baseband/fpga_lte_fec: fix API naming

 app/test-bbdev/test_bbdev_perf.c   | 12 ++--
 doc/guides/bbdevs/fpga_5gnr_fec.rst| 14 +++---
 doc/guides/bbdevs/fpga_lte_fec.rst | 14 +++---
 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 10 +-
 .../rte_pmd_bbdev_fpga_5gnr_fec_version.map|  2 +-
 .../baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h |  6 +++---
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.c   | 10 +-
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.h   |  6 +++---
 .../rte_pmd_bbdev_fpga_lte_fec_version.map |  2 +-
 9 files changed, 38 insertions(+), 38 deletions(-)

-- 
2.26.2

[dpdk-dev] [PATCH 1/2] baseband/fpga_5gnr_fec: fix API naming

[Maxime Coquelin]

DPDK APIs have to be prefixed with "rte_" in order to avoid
namespace pollution.

Let's fix it while fpga_5gnr_fec API is still experimental.

Signed-off-by: Maxime Coquelin 
---
 app/test-bbdev/test_bbdev_perf.c   |  6 +++---
 doc/guides/bbdevs/fpga_5gnr_fec.rst| 14 +++---
 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 10 +-
 .../rte_pmd_bbdev_fpga_5gnr_fec_version.map|  2 +-
 .../baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h |  6 +++---
 5 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index 45c0d62aca..14f150704e 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -612,14 +612,14 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
 #ifdef RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC
if ((get_init_device() == true) &&
(!strcmp(info->drv.driver_name, FPGA_5GNR_PF_DRIVER_NAME))) {
-   struct fpga_5gnr_fec_conf conf;
+   struct rte_fpga_5gnr_fec_conf conf;
unsigned int i;
 
printf("Configure FPGA 5GNR FEC Driver %s with default 
values\n",
info->drv.driver_name);
 
/* clear default configuration before initialization */
-   memset(&conf, 0, sizeof(struct fpga_5gnr_fec_conf));
+   memset(&conf, 0, sizeof(struct rte_fpga_5gnr_fec_conf));
 
/* Set PF mode :
 * true if PF is used for data plane
@@ -647,7 +647,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,
conf.flr_time_out = FLR_5G_TIMEOUT;
 
/* setup FPGA PF with configuration information */
-   ret = fpga_5gnr_fec_configure(info->dev_name, &conf);
+   ret = rte_fpga_5gnr_fec_configure(info->dev_name, &conf);
TEST_ASSERT_SUCCESS(ret,
"Failed to configure 5G FPGA PF for bbdev %s",
info->dev_name);
diff --git a/doc/guides/bbdevs/fpga_5gnr_fec.rst 
b/doc/guides/bbdevs/fpga_5gnr_fec.rst
index 6760391e8c..5849b31857 100644
--- a/doc/guides/bbdevs/fpga_5gnr_fec.rst
+++ b/doc/guides/bbdevs/fpga_5gnr_fec.rst
@@ -170,12 +170,12 @@ queues, priorities, load balance, bandwidth and other 
settings necessary for the
 device to perform FEC functions.
 
 This configuration needs to be executed at least once after reboot or PCI FLR 
and can
-be achieved by using the function ``fpga_5gnr_fec_configure()``, which sets up 
the
-parameters defined in ``fpga_5gnr_fec_conf`` structure:
+be achieved by using the function ``rte_fpga_5gnr_fec_configure()``, which 
sets up the
+parameters defined in ``rte_fpga_5gnr_fec_conf`` structure:
 
 .. code-block:: c
 
-  struct fpga_5gnr_fec_conf {
+  struct rte_fpga_5gnr_fec_conf {
   bool pf_mode_en;
   uint8_t vf_ul_queues_number[FPGA_5GNR_FEC_NUM_VFS];
   uint8_t vf_dl_queues_number[FPGA_5GNR_FEC_NUM_VFS];
@@ -214,15 +214,15 @@ parameters defined in ``fpga_5gnr_fec_conf`` structure:
   the FLR time out then set this setting to 0x262=610.
 
 
-An example configuration code calling the function 
``fpga_5gnr_fec_configure()`` is shown
+An example configuration code calling the function 
``rte_fpga_5gnr_fec_configure()`` is shown
 below:
 
 .. code-block:: c
 
-  struct fpga_5gnr_fec_conf conf;
+  struct rte_fpga_5gnr_fec_conf conf;
   unsigned int i;
 
-  memset(&conf, 0, sizeof(struct fpga_5gnr_fec_conf));
+  memset(&conf, 0, sizeof(struct rte_fpga_5gnr_fec_conf));
   conf.pf_mode_en = 1;
 
   for (i = 0; i < FPGA_5GNR_FEC_NUM_VFS; ++i) {
@@ -235,7 +235,7 @@ below:
   conf.ul_load_balance = 64;
 
   /* setup FPGA PF */
-  ret = fpga_5gnr_fec_configure(info->dev_name, &conf);
+  ret = rte_fpga_5gnr_fec_configure(info->dev_name, &conf);
   TEST_ASSERT_SUCCESS(ret,
   "Failed to configure 4G FPGA PF for bbdev %s",
   info->dev_name);
diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c 
b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
index 61f9c04ba2..1d73f9540e 100644
--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
@@ -1944,10 +1944,10 @@ fpga_5gnr_fec_remove(struct rte_pci_device *pci_dev)
 }
 
 static inline void
-set_default_fpga_conf(struct fpga_5gnr_fec_conf *def_conf)
+set_default_fpga_conf(struct rte_fpga_5gnr_fec_conf *def_conf)
 {
/* clear default configuration before initialization */
-   memset(def_conf, 0, sizeof(struct fpga_5gnr_fec_conf));
+   memset(def_conf, 0, sizeof(struct rte_fpga_5gnr_fec_conf));
/* Set pf mode to true */
def_conf->pf_mode_en = true;
 
@@ -1962,15 +1962,15 @@ set_default_fpga_conf(struct fpga_5gnr_fec_conf 
*def_conf)
 
 /* Initial configuration of FPGA 5GNR FEC device */
 int
-fpga_5gnr_fec_configure(const char *dev_name,
-   const struct fpga_5gnr_fec_c

Re: [dpdk-dev] [PATCH v5 13/20] doc: remove references to make from compressdevs guides

[Daly, Lee]

> -Original Message-
> From: Power, Ciara 
> Sent: Monday, September 21, 2020 2:59 PM
> To: dev@dpdk.org
> Cc: Power, Ciara ; Daly, Lee ;
> Mcnamara, John ; Kovacevic, Marko
> ; Ashish Gupta ;
> Sunila Sahu 
> Subject: [PATCH v5 13/20] doc: remove references to make from compressdevs
> guides
> 
> Make is no longer supported for compiling DPDK, references are now removed
> in the documentation.
> 
> Signed-off-by: Ciara Power 
> Reviewed-by: Kevin Laatz 
> ---
>  doc/guides/compressdevs/isal.rst |  4 
>  doc/guides/compressdevs/octeontx.rst | 24 ++--
>  doc/guides/compressdevs/zlib.rst |  4 
>  3 files changed, 2 insertions(+), 30 deletions(-)
> 
> diff --git a/doc/guides/compressdevs/isal.rst
> b/doc/guides/compressdevs/isal.rst
> index af1f41f240..1d146fb4a6 100644
> --- a/doc/guides/compressdevs/isal.rst
> +++ b/doc/guides/compressdevs/isal.rst
> @@ -133,10 +133,6 @@ Installation
>  Initialization
>  --
> 
> -In order to enable this virtual compression PMD, user must:
> -
> -* Set ``CONFIG_RTE_LIBRTE_PMD_ISAL=y`` in config/common_base.
> -
>  To use the PMD in an application, user must:
> 
>  * Call ``rte_vdev_init("compress_isal")`` within the application.
<>

ISA-L change looks good, thanks for work.
Acked-by: Lee Daly 

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

[David Marchand]

On Thu, Sep 17, 2020 at 4:47 PM David Marchand
 wrote:
>
> On Thu, Sep 17, 2020 at 4:17 PM Burakov, Anatoly
>  wrote:
> > Anonymous hugepages shouldn't matter, yes, but single-file segments mode
> > does fallocate() and remove - you have the remove part covered, but i'm
> > just curious if fallocate() would also cause any issues with SELinux.
>
> I found no hook in the kernel for fallocate + selinux...
> Looked into fallocate itself and it ends up validating lsm write
> access on the file.
>
> I don't have the full setup atm but since I could truncate and write
> to it, I'd say we are good.

I could not gain access to the same setup again.

FWIW, I tried with my reproducer:
- no issue with --in-memory option (with or without patch)

- error correctly detected (with this patch) in normal mode after restarting:

# \rm /dev/hugepages/rtemap_*
# LD_PRELOAD=libwrap.so dpdk-testpmd -w :01:00.0 -- -i
[... working fine ...]
# LD_PRELOAD=libwrap.so dpdk-testpmd -w :01:00.0 -- -i
EAL: Detected 28 lcore(s)
EAL: Detected 1 NUMA nodes
### called unlink for /var/run/dpdk/rte/mp_socket
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
### refused unlinkat for rtemap_0
EAL: Probing VFIO support...
EAL: VFIO support initialized
### refused unlink for /dev/hugepages/rtemap_0
EAL: Couldn't get fd on hugepage file
EAL: error allocating rte services array
EAL: FATAL: rte_service_init() failed
EAL: rte_service_init() failed
EAL: Error - exiting with code: 1
  Cause: Cannot init EAL: Exec format error
### called unlink for /var/run/dpdk/rte/mp_socket

- error detected with legacy mode from first try (with or without
patch), since the memory allocator tries to remove unneeded hugepage
files in this mode, and reports failures for this:

# \rm /dev/hugepages/rtemap_*
# LD_PRELOAD=libwrap.so dpdk-testpmd -w :01:00.0 --legacy-mem -m 2048 -- -i
EAL: Detected 28 lcore(s)
EAL: Detected 1 NUMA nodes
### called unlink for /var/run/dpdk/rte/mp_socket
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: Probing VFIO support...
EAL: VFIO support initialized
### refused unlink for /dev/hugepages/rtemap_2
EAL: unmap_unneeded_hugepages(): Removing /dev/hugepages/rtemap_2
failed: Permission denied
EAL: Unmapping and locking hugepages failed!
EAL: FATAL: Cannot init memory
EAL: Cannot init memory
EAL: Error - exiting with code: 1
  Cause: Cannot init EAL: Cannot allocate memory
### called unlink for /var/run/dpdk/rte/mp_socket


-- 
David Marchand

[dpdk-dev] [PATCH v3 0/3] aarch64 clang cross compilation

[Juraj Linkeš]

Use clang/LLVM toolchain with gcc stdlib to cross compile aarch64
target.

v3:
Removed AARCH_GCC and AARCH_CLANG variables in favor of CC_FOR_BUILD.

Juraj Linkeš (3):
  build: add aarch64 clang to meson cross-compile
  ci: add aarch64 clang cross-compilation builds
  doc: add clang to aarch64 cross build guide

 .ci/linux-build.sh|   6 +-
 .travis.yml   |  18 ++
 config/arm/arm64_armv8_linux_clang_ubuntu1804 |  20 ++
 .../linux_gsg/cross_build_dpdk_for_arm64.rst  | 183 +-
 4 files changed, 175 insertions(+), 52 deletions(-)
 create mode 100644 config/arm/arm64_armv8_linux_clang_ubuntu1804

-- 
2.20.1

[dpdk-dev] [PATCH v3 2/3] ci: add aarch64 clang cross-compilation builds

[Juraj Linkeš]

Mirror the existing gcc jobs - build static and shared libs.
Use arm64_armv8_linux_clang_ubuntu1804 meson cross file.

Signed-off-by: Juraj Linkeš 
---
 .ci/linux-build.sh |  6 +-
 .travis.yml| 18 ++
 2 files changed, 23 insertions(+), 1 deletion(-)

diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index d079801d7..d9bdd1503 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -30,7 +30,11 @@ install_libabigail() {
 
 if [ "$AARCH64" = "1" ]; then
 # convert the arch specifier
-OPTS="$OPTS --cross-file config/arm/arm64_armv8_linux_gcc"
+if [ "$CC_FOR_BUILD" = "gcc" ]; then
+   OPTS="$OPTS --cross-file config/arm/arm64_armv8_linux_gcc"
+elif [ "$CC_FOR_BUILD" = "clang" ]; then
+   OPTS="$OPTS --cross-file config/arm/arm64_armv8_linux_clang_ubuntu1804"
+fi
 fi
 
 if [ "$BUILD_DOCS" = "1" ]; then
diff --git a/.travis.yml b/.travis.yml
index d6eeab371..cc3d49218 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -18,6 +18,10 @@ _aarch64_packages: &aarch64_packages
   - *required_packages
   - [gcc-aarch64-linux-gnu, libc6-dev-arm64-cross, 
pkg-config-aarch64-linux-gnu]
 
+_aarch64_clang_packages: &aarch64_clang_packages
+  - *required_packages
+  - [libgcc-8-dev-arm64-cross, libatomic1-arm64-cross, libc6-dev-arm64-cross, 
pkg-config-aarch64-linux-gnu]
+
 _build_32b_packages: &build_32b_packages
   - *required_packages
   - [gcc-multilib]
@@ -83,6 +87,20 @@ jobs:
   apt:
 packages:
   - *aarch64_packages
+  - env: DEF_LIB="static" AARCH64=1
+arch: amd64
+compiler: clang
+addons:
+  apt:
+packages:
+  - *aarch64_clang_packages
+  - env: DEF_LIB="shared" AARCH64=1
+arch: amd64
+compiler: clang
+addons:
+  apt:
+packages:
+  - *aarch64_clang_packages
   # aarch64 gcc jobs
   - env: DEF_LIB="static"
 arch: arm64
-- 
2.20.1

[dpdk-dev] [PATCH v3 1/3] build: add aarch64 clang to meson cross-compile

[Juraj Linkeš]

Create meson cross file arm64_armv8_linux_clang_ubuntu1804.
Use clang/LLVM toolchain with sysroot pointing to gcc cross stdlib.

Signed-off-by: Juraj Linkeš 
---
 config/arm/arm64_armv8_linux_clang_ubuntu1804 | 20 +++
 1 file changed, 20 insertions(+)
 create mode 100644 config/arm/arm64_armv8_linux_clang_ubuntu1804

diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804 
b/config/arm/arm64_armv8_linux_clang_ubuntu1804
new file mode 100644
index 0..67f475eb0
--- /dev/null
+++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804
@@ -0,0 +1,20 @@
+[binaries]
+c = 'clang'
+cpp = 'clang++'
+ar = 'llvm-ar'
+strip = 'llvm-strip'
+llvm-config = 'llvm-config'
+pcap-config = 'llvm-config'
+pkgconfig = 'aarch64-linux-gnu-pkg-config'
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+implementor_id = 'generic'
+implementor_pn = 'default'
+c_args = ['-target', 'aarch64-linux-gnu', '--sysroot', 
'/usr/aarch64-linux-gnu', '--gcc-toolchain=/usr']
+c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld']
-- 
2.20.1

[dpdk-dev] [PATCH v3 3/3] doc: add clang to aarch64 cross build guide

[Juraj Linkeš]

Reorganize and update the aarch64 cross guide with clang cross
compilation. Update the GNU toolchain version which clang also uses.
Reorganize into common part, GNU part and clang part.

Signed-off-by: Juraj Linkeš 
---
 .../linux_gsg/cross_build_dpdk_for_arm64.rst  | 183 +-
 1 file changed, 132 insertions(+), 51 deletions(-)

diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst 
b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
index 8a1d0e88b..c936a3d7a 100644
--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -1,101 +1,182 @@
 ..  SPDX-License-Identifier: BSD-3-Clause
-Copyright(c) 2018 ARM Corporation.
+Copyright(c) 2020 ARM Corporation.
 
-Cross compile DPDK for ARM64
-
+Cross compiling DPDK for ARM64
+==
 This chapter describes how to cross compile DPDK for ARM64 from x86 build 
hosts.
 
 .. note::
 
Whilst it is recommended to natively build DPDK on ARM64 (just
-   like with x86), it is also possible to cross-build DPDK for ARM64. An
-   ARM64 cross compile GNU toolchain is used for this.
+   like with x86), it is also possible to cross compile DPDK for ARM64.
+   An ARM64 cross compiler GNU toolchain or an LLVM/clang toolchain
+   may be used for cross-compilation.
 
-Obtain the cross tool chain

-The latest cross compile tool chain can be downloaded from:
+
+Prerequisites
+-
+
+NUMA library
+
+
+NUMA is required by most modern machines, not needed for non-NUMA 
architectures.
+
+.. note::
+
+   For compiling the NUMA lib, run libtool --version to ensure the libtool 
version >= 2.2,
+   otherwise the compilation will fail with errors.
+
+.. code-block:: console
+
+   git clone https://github.com/numactl/numactl.git
+   cd numactl
+   git checkout v2.0.13 -b v2.0.13
+   ./autogen.sh
+   autoconf -i
+   ./configure --host=aarch64-linux-gnu CC= --prefix=
+   make install
+
+.. note::
+
+   The compiler above can be either aarch64-linux-gnu-gcc or clang.
+   See below for information on how to get the compiler of your choice.
+
+The numa header files and lib file is generated in the include and lib folder 
respectively under .
+
+Meson prerequisites
+~~~
+
+Meson depends on pkgconfig to find the dependencies.
+The package ``pkg-config-aarch64-linux-gnu`` is required for aarch64.
+To install it in Ubuntu::
+
+   sudo apt install pkg-config-aarch64-linux-gnu
+
+
+GNU toolchain
+-
+
+.. _obtain_GNU_toolchain:
+
+Obtain the cross toolchain
+~~
+The latest GNU cross compiler toolchain can be downloaded from:
 https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads.
 
 It is always recommended to check and get the latest compiler tool from the 
page and use
-it to generate better code. As of this writing 8.3-2019.03 is the newest, the 
following
+it to generate better code. As of this writing 9.2-2019.12 is the newest, the 
following
 description is an example of this version.
 
 .. code-block:: console
 
-   wget 
https://developer.arm.com/-/media/Files/downloads/gnu-a/8.3-2019.03/binrel/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz
+   wget 
https://developer.arm.com/-/media/Files/downloads/gnu-a/9.2-2019.12/binrel/gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu.tar.xz
 
 Unzip and add into the PATH

+~~~
 
 .. code-block:: console
 
-   tar -xvf gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz
-   export 
PATH=$PATH:/gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu/bin
+   tar -xvf gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu.tar.xz
+   export 
PATH=$PATH:/gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu/bin
 
 .. note::
 
For the host requirements and other info, refer to the release note 
section: https://releases.linaro.org/components/toolchain/binaries/
 
-.. _arm_cross_build_getting_the_prerequisite_library:
+.. _augment_the_gnu_toolchain_with_numa_support:
 
-Getting the prerequisite library
-
-
-NUMA is required by most modern machines, not needed for non-NUMA 
architectures.
+Augment the GNU toolchain with NUMA support
+~~~
 
 .. note::
 
-   For compiling the NUMA lib, run libtool --version to ensure the libtool 
version >= 2.2,
-   otherwise the compilation will fail with errors.
+   This way is optional, an alternative is to use extra CFLAGS and LDFLAGS.
+
+Copy the NUMA header files and lib to the cross compiler's directories:
 
 .. code-block:: console
 
-   git clone https://github.com/numactl/numactl.git
-   cd numactl
-   git checkout v2.0.13 -b v2.0.13
-   ./autogen.sh
-   autoconf -i
-   ./configure --host=aarch64-linux-gnu CC=aarch64-linux-gnu-gcc 
--prefix=
-   make install
+   cp /include/numa*.h 
/gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu/aarch64-none-linux-g

Re: [dpdk-dev] [PATCH v10 04/11] usertools/cpu_layout: support python3 only

[David Marchand]

On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz  wrote:
>
> From: Louise Kilheeney 
>
> Changed script to explicitly use python3 only to avoid
> maintaining python 2 and removed deprecation notice.
>
> Signed-off-by: Louise Kilheeney 
> Reviewed-by: Bruce Richardson 
> Acked-by: Robin Jarry 
> Acked-by: Stephen Hemminger 
> ---
>  usertools/cpu_layout.py | 13 ++---
>  1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py
> index 5423c7965f..89a48cec46 100755
> --- a/usertools/cpu_layout.py
> +++ b/usertools/cpu_layout.py
> @@ -1,18 +1,9 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2010-2014 Intel Corporation
>  # Copyright(c) 2017 Cavium, Inc. All rights reserved.
>
> -from __future__ import print_function
>  import sys

sys is not needed anymore.
Fixed while applying.


> -try:
> -xrange # Python 2
> -except NameError:
> -xrange = range # Python 3
> -
> -if sys.version_info.major < 3:
> -print("WARNING: Python 2 is deprecated for use in DPDK, and will not 
> work in future releases.", file=sys.stderr)
> -print("Please use Python 3 instead", file=sys.stderr)
>
>  sockets = []
>  cores = []


-- 
David Marchand

Re: [dpdk-dev] [PATCH] pipeline: fix build with glibc < 2.26

[Dumitrescu, Cristian]

> -Original Message-
> From: David Marchand 
> Sent: Friday, October 2, 2020 9:29 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian 
> Subject: [PATCH] pipeline: fix build with glibc < 2.26
> 
> reallocarray has been introduced in glibc 2.26 but we still support
> glibc >= 2.7.
> Simply replace with realloc, as the considered sizes are unlikely to
> overflow.
> 
> """
> The reallocarray() function changes the size of the memory block
> pointed to by ptr to be large enough for an array of nmemb elements,
> each of which is size bytes.  It is equivalent to the call
> 
>realloc(ptr, nmemb * size);
> 
> However, unlike that realloc() call, reallocarray() fails safely in
> the case where the multiplication would overflow.  If such an over‐
> flow occurs, reallocarray() returns NULL, sets errno to ENOMEM, and
> leaves the original block of memory unchanged.
> """
> 
> Fixes: 3ca60ceed79a ("pipeline: add SWX pipeline specification file")
> 
> Signed-off-by: David Marchand 
> ---
>  lib/librte_pipeline/rte_swx_pipeline_spec.c | 25 +
>  1 file changed, 10 insertions(+), 15 deletions(-)
> 
> diff --git a/lib/librte_pipeline/rte_swx_pipeline_spec.c
> b/lib/librte_pipeline/rte_swx_pipeline_spec.c
> index d72badd03d..95de8f983d 100644
> --- a/lib/librte_pipeline/rte_swx_pipeline_spec.c
> +++ b/lib/librte_pipeline/rte_swx_pipeline_spec.c
> @@ -213,9 +213,8 @@ struct_block_parse(struct struct_spec *s,
>   return -ENOMEM;
>   }
> 
> - new_fields = reallocarray(s->fields,
> -   s->n_fields + 1,
> -   sizeof(struct rte_swx_field_params));
> + new_fields = realloc(s->fields,
> +  (s->n_fields + 1) * sizeof(struct
> rte_swx_field_params));
>   if (!new_fields) {
>   free(name);
> 
> @@ -452,9 +451,8 @@ action_block_parse(struct action_spec *s,
>   return -ENOMEM;
>   }
> 
> - new_instructions = reallocarray(s->instructions,
> - s->n_instructions + 1,
> - sizeof(char *));
> + new_instructions = realloc(s->instructions,
> +(s->n_instructions + 1) * sizeof(char *));
>   if (!new_instructions) {
>   free(instr);
> 
> @@ -620,9 +618,8 @@ table_key_block_parse(struct table_spec *s,
>   return -ENOMEM;
>   }
> 
> - new_fields = reallocarray(s->params.fields,
> -   s->params.n_fields + 1,
> -   sizeof(struct
> rte_swx_match_field_params));
> + new_fields = realloc(s->params.fields,
> +  (s->params.n_fields + 1) * sizeof(struct
> rte_swx_match_field_params));
>   if (!new_fields) {
>   free(name);
> 
> @@ -700,9 +697,8 @@ table_actions_block_parse(struct table_spec *s,
>   return -ENOMEM;
>   }
> 
> - new_action_names = reallocarray(s->params.action_names,
> - s->params.n_actions + 1,
> - sizeof(char *));
> + new_action_names = realloc(s->params.action_names,
> +(s->params.n_actions + 1) * sizeof(char *));
>   if (!new_action_names) {
>   free(name);
> 
> @@ -1019,9 +1015,8 @@ apply_block_parse(struct apply_spec *s,
>   return -ENOMEM;
>   }
> 
> - new_instructions = reallocarray(s->instructions,
> - s->n_instructions + 1,
> - sizeof(char *));
> + new_instructions = realloc(s->instructions,
> +(s->n_instructions + 1) * sizeof(char *));
>   if (!new_instructions) {
>   free(instr);
> 
> --
> 2.23.0


Acked-by: Cristian Dumitrescu 

[dpdk-dev] mlx5: match broadcast and multicast packets using flows

[Carasec Elena]

Hello,

I am trying to create flow rules that will match broadcast and multicast 
packets using testpmd
on mlx5 'MT27800 Family [ConnectX-5] 1017'. However, after creating the 
following rules, they do not match any packets.


My testpmd script is:

port stop all
port config all rss none
set promisc 0 on
set allmulti 0 on
port start all
set link-up port all
flow create 0 group 0 ingress pattern eth dst is ff:ff:ff:ff:ff:ff / 
ipv4 / end actions mark id 1 / count / queue index 1 / end
flow create 0 group 0 ingress pattern eth dst is ff:ff:ff:ff:ff:ff / 
ipv6 / end actions mark id 1 / count / queue index 1 / end
flow create 0 group 0 ingress pattern eth dst spec 01:00:00:00:00:00 dst 
mask 01:00:00:00:00:00 / ipv4 / end actions mark id 2 / count / queue 
index 2 / end
flow create 0 group 0 ingress pattern eth dst spec 01:00:00:00:00:00 dst 
mask 01:00:00:00:00:00 / ipv6 / end actions mark id 2 / count / queue 
index 2 / end
flow create 0 group 0 priority 1 ingress pattern end actions queue index 
3 / count / end

start

All the packets will match the last rule.

Also, creating only the rule
flow create 0 group 0 ingress pattern eth dst spec 01:00:00:00:00:00 dst 
mask 01:00:00:00:00:00 / end actions mark id 2 / count / queue index 2 / 
end
fails with error "port_flow_complain(): Caught PMD error type 1 (cause 
unspecified): hardware refuses to create flow: File exists"


What may be the reason of it? Is there another way to match broadcast 
and multicast packets using flow?


Thank you.
Elena Carasec

Re: [dpdk-dev] [PATCH v10 11/11] doc: support python3 only

[David Marchand]

On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz  wrote:
> diff --git a/doc/guides/conf.py b/doc/guides/conf.py
> index 9ebc26ed3f..ef550f68c0 100644
> --- a/doc/guides/conf.py
> +++ b/doc/guides/conf.py
> @@ -1,7 +1,7 @@
> +#!/usr/bin/env python3
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2010-2015 Intel Corporation
>
> -from __future__ import print_function
>  from docutils import nodes
>  from distutils.version import LooseVersion
>  from sphinx import __version__ as sphinx_version
> @@ -13,12 +13,7 @@
>  from os.path import dirname
>  from os.path import join as path_join
>
> -try:
> -# Python 2.
> -import ConfigParser as configparser
> -except:
> -# Python 3.
> -import configparser
> +import configparser

I am ok with dropping this part: the doc generation with python 2 / an
old sphinx is already broken since 20.02 with meson.
I can give details for people interested.


>
>  try:
>  import sphinx_rtd_theme
> diff --git a/doc/guides/contributing/coding_style.rst 
> b/doc/guides/contributing/coding_style.rst
> index 0be9546a6a..4fc010ca49 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -765,7 +765,7 @@ specializations, run the ``app/test`` binary, and use the 
> ``dump_log_types``
>  Python Code
>  ---
>
> -All Python code should work with Python 2.7+ and 3.2+ and be compliant with
> +All Python code should work with 3.2+ and be compliant with
>  `PEP8 (Style Guide for Python Code) 
> `_.

I am for dropping any mention of a version here.
On current HEAD of the main branch, the requirements already ask for a
3.5 version.
I would simply ask for PEP8 compliance in this doc.

Opinion?


>
>  The ``pep8`` tool can be used for testing compliance with the guidelines.
> diff --git a/doc/guides/linux_gsg/sys_reqs.rst 
> b/doc/guides/linux_gsg/sys_reqs.rst
> index 6b9f573fce..66d9723dd6 100644
> --- a/doc/guides/linux_gsg/sys_reqs.rst
> +++ b/doc/guides/linux_gsg/sys_reqs.rst
> @@ -47,7 +47,7 @@ Compilation of the DPDK
>
>  * Python v3.5+ is needed to build DPDK using meson and ninja
>
> -* Python 2.7+ or 3.2+, to use various helper scripts included in the 
> DPDK package.
> +* Python 3.2+, to use various helper scripts included in the DPDK 
> package.

Dropped this hunk, as it has already been updated with the "make
removal" series.


-- 
David Marchand

Re: [dpdk-dev] [PATCH v10 11/11] doc: support python3 only

[Kevin Laatz]

On 02/10/2020 12:01, David Marchand wrote:

On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz  wrote:


[...]

  try:
  import sphinx_rtd_theme
diff --git a/doc/guides/contributing/coding_style.rst 
b/doc/guides/contributing/coding_style.rst
index 0be9546a6a..4fc010ca49 100644
--- a/doc/guides/contributing/coding_style.rst
+++ b/doc/guides/contributing/coding_style.rst
@@ -765,7 +765,7 @@ specializations, run the ``app/test`` binary, and use the 
``dump_log_types``
  Python Code
  ---

-All Python code should work with Python 2.7+ and 3.2+ and be compliant with
+All Python code should work with 3.2+ and be compliant with
  `PEP8 (Style Guide for Python Code) 
`_.

I am for dropping any mention of a version here.
On current HEAD of the main branch, the requirements already ask for a
3.5 version.
I would simply ask for PEP8 compliance in this doc.

Opinion?

+1 That was something i concidered while making the patch - saves 
someone maitaining the versions here in future.


- Kevin

Re: [dpdk-dev] [PATCH v10 11/11] doc: support python3 only

[Bruce Richardson]

On Fri, Oct 02, 2020 at 01:01:13PM +0200, David Marchand wrote:
> On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz  wrote:
> > diff --git a/doc/guides/conf.py b/doc/guides/conf.py
> > index 9ebc26ed3f..ef550f68c0 100644
> > --- a/doc/guides/conf.py
> > +++ b/doc/guides/conf.py
> > @@ -1,7 +1,7 @@
> > +#!/usr/bin/env python3
> >  # SPDX-License-Identifier: BSD-3-Clause
> >  # Copyright(c) 2010-2015 Intel Corporation
> >
> > -from __future__ import print_function
> >  from docutils import nodes
> >  from distutils.version import LooseVersion
> >  from sphinx import __version__ as sphinx_version
> > @@ -13,12 +13,7 @@
> >  from os.path import dirname
> >  from os.path import join as path_join
> >
> > -try:
> > -# Python 2.
> > -import ConfigParser as configparser
> > -except:
> > -# Python 3.
> > -import configparser
> > +import configparser
> 
> I am ok with dropping this part: the doc generation with python 2 / an
> old sphinx is already broken since 20.02 with meson.
> I can give details for people interested.
> 

I'm ok with this. I suspect most non-developers of DPDK just use the
published docs on the website.

> 
> >
> >  try:
> >  import sphinx_rtd_theme
> > diff --git a/doc/guides/contributing/coding_style.rst 
> > b/doc/guides/contributing/coding_style.rst
> > index 0be9546a6a..4fc010ca49 100644
> > --- a/doc/guides/contributing/coding_style.rst
> > +++ b/doc/guides/contributing/coding_style.rst
> > @@ -765,7 +765,7 @@ specializations, run the ``app/test`` binary, and use 
> > the ``dump_log_types``
> >  Python Code
> >  ---
> >
> > -All Python code should work with Python 2.7+ and 3.2+ and be compliant with
> > +All Python code should work with 3.2+ and be compliant with
> >  `PEP8 (Style Guide for Python Code) 
> > `_.
> 
> I am for dropping any mention of a version here.
> On current HEAD of the main branch, the requirements already ask for a
> 3.5 version.
> I would simply ask for PEP8 compliance in this doc.
> 
> Opinion?
>

Ok with this too.

Re: [dpdk-dev] [PATCH v4 2/8] test/distributor: synchronize lcores statistics

[Lukasz Wojciechowski]

Hi Honnappa,

Many thanks for the review!

I'll write my answers here not inline as it would be easier to read them 
in one place, I think.
So first of all I agree with you in 2 things:
1) all uses of statistics must be atomic and lack of that caused most of 
the problems
2) it would be better to replace barrier and memset in 
clear_packet_count() with atomic stores as you suggested

So I will apply both of above.

However I wasn't not fully convinced on changing acquire/release to 
relaxed. It wood be perfectly ok
if it would look like in this Herb Sutter's example: 
https://youtu.be/KeLBd2EJLOU?t=4170
But in his case the counters are cleared before worker threads start and 
are printout after they are completed.

In case of the dpdk distributor tests both worker and main cores are 
running at the same time. In the sanity_test, the statistics are cleared 
and verified few times for different hashes of packages. The worker 
cores are not stopped at this time and they continue their loops in 
handle procedure. Verification made in main core is an exchange of data 
as the current statistics indicate how the test will result.

So as I wasn't convinced, I run some tests with both both relaxed and 
acquire/release modes and they both fail :(
The failures caused by statistics errors to number of tests ratio for 
20 tests was:
for relaxed: 0,000790562
for acq/rel: 0,91321


That's why I'm going to modify tests in such way, that they would:
1) clear statistics
2) launch worker threads
3) run test
4) wait for workers procedures to complete
5) check stats, verify results and print them out

This way worker main core will use (clear or verify) stats only when 
there are no worker threads. This would make things simpler and allowing 
to focus on testing the distributor not tests. And of course relaxed 
mode would be enough!


Best regards
Lukasz


W dniu 29.09.2020 o 07:49, Honnappa Nagarahalli pisze:
> 
>
>> Statistics of handled packets are cleared and read on main lcore, while they
>> are increased in workers handlers on different lcores.
>>
>> Without synchronization occasionally showed invalid values.
>> This patch uses atomic acquire/release mechanisms to synchronize.
> In general, load-acquire and store-release memory orderings are required 
> while synchronizing data (that cannot be updated atomically) between threads. 
> In the situation, making counters atomic is enough.
>
>> Fixes: c3eabff124e6 ("distributor: add unit tests")
>> Cc: bruce.richard...@intel.com
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Lukasz Wojciechowski 
>> Acked-by: David Hunt 
>> ---
>>   app/test/test_distributor.c | 39 -
>>   1 file changed, 26 insertions(+), 13 deletions(-)
>>
>> diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index
>> 35b25463a..0e49e3714 100644
>> --- a/app/test/test_distributor.c
>> +++ b/app/test/test_distributor.c
>> @@ -43,7 +43,8 @@ total_packet_count(void)  {
>>  unsigned i, count = 0;
>>  for (i = 0; i < worker_idx; i++)
>> -count += worker_stats[i].handled_packets;
>> +count +=
>> __atomic_load_n(&worker_stats[i].handled_packets,
>> +__ATOMIC_ACQUIRE);
> RELAXED memory order is sufficient. For ex: the worker threads are not 
> 'releasing' any data that is not atomically updated to the main thread.
>
>>  return count;
>>   }
>>
>> @@ -52,6 +53,7 @@ static inline void
>>   clear_packet_count(void)
>>   {
>>  memset(&worker_stats, 0, sizeof(worker_stats));
>> +rte_atomic_thread_fence(__ATOMIC_RELEASE);
> Ideally, the counters should be set to 0 atomically rather than using a 
> memset.
>
>>   }
>>
>>   /* this is the basic worker function for sanity test @@ -72,13 +74,13 @@
>> handle_work(void *arg)
>>  num = rte_distributor_get_pkt(db, id, buf, buf, num);
>>  while (!quit) {
>>  __atomic_fetch_add(&worker_stats[id].handled_packets,
>> num,
>> -__ATOMIC_RELAXED);
>> +__ATOMIC_ACQ_REL);
> Using the __ATOMIC_ACQ_REL order does not mean anything to the main thread. 
> The main thread might still see the updates from different threads in 
> different order.
>
>>  count += num;
>>  num = rte_distributor_get_pkt(db, id,
>>  buf, buf, num);
>>  }
>>  __atomic_fetch_add(&worker_stats[id].handled_packets, num,
>> -__ATOMIC_RELAXED);
>> +__ATOMIC_ACQ_REL);
> Same here, do not see why this change is required.
>
>>  count += num;
>>  rte_distributor_return_pkt(db, id, buf, num);
>>  return 0;
>> @@ -134,7 +136,8 @@ sanity_test(struct worker_params *wp, struct
>> rte_mempool *p)
>>
>>  for (i = 0; i < rte_lcore_count() - 1; i++)
>>  printf("Worker %u handled %u packets\n", i,
>> -worker_stats[i].handled_packets);
>> +__atomic_load_n(&work

Re: [dpdk-dev] [PATCH] pipeline: fix build with glibc < 2.26

[David Marchand]

On Fri, Oct 2, 2020 at 12:38 PM Dumitrescu, Cristian
 wrote:
> > -Original Message-
> > From: David Marchand 
> > Sent: Friday, October 2, 2020 9:29 AM
> > To: dev@dpdk.org
> > Cc: Dumitrescu, Cristian 
> > Subject: [PATCH] pipeline: fix build with glibc < 2.26
> >
> > reallocarray has been introduced in glibc 2.26 but we still support
> > glibc >= 2.7.
> > Simply replace with realloc, as the considered sizes are unlikely to
> > overflow.
> >
> > """
> > The reallocarray() function changes the size of the memory block
> > pointed to by ptr to be large enough for an array of nmemb elements,
> > each of which is size bytes.  It is equivalent to the call
> >
> >realloc(ptr, nmemb * size);
> >
> > However, unlike that realloc() call, reallocarray() fails safely in
> > the case where the multiplication would overflow.  If such an over‐
> > flow occurs, reallocarray() returns NULL, sets errno to ENOMEM, and
> > leaves the original block of memory unchanged.
> > """
> >
> > Fixes: 3ca60ceed79a ("pipeline: add SWX pipeline specification file")
> >
> > Signed-off-by: David Marchand 
> Acked-by: Cristian Dumitrescu 

Applied.


-- 
David Marchand

[dpdk-dev] [PATCH] l3fwd-power: make interrupt wakeup log thread safe

[Anatoly Burakov]

Currently, the interrupt status notification prevents log spam by
remembering whether previous interrupt wakeup was due to traffic or due
to timeout expiring. However, it is a single variable that can
potentially be accessed from multiple threads, so it is not thread-safe.

Fix it by having per-lcore interrupt status.

Fixes: f4d1e19c293d ("examples/l3fwd-power: add Rx interrupt timeout")
Cc: anatoly.bura...@intel.com

Signed-off-by: Anatoly Burakov 
---
 examples/l3fwd-power/main.c | 19 ---
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index d0e6c9bd77..46eac7c3e0 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -821,20 +821,23 @@ power_freq_scaleup_heuristic(unsigned lcore_id,
  *  0 on success
  */
 static int
-sleep_until_rx_interrupt(int num)
+sleep_until_rx_interrupt(int num, int lcore)
 {
/*
 * we want to track when we are woken up by traffic so that we can go
-* back to sleep again without log spamming.
+* back to sleep again without log spamming. Avoid cache line sharing
+* to prevent threads stepping on each others' toes.
 */
-   static bool timeout;
+   static struct {
+   bool wakeup;
+   } __rte_cache_aligned status[RTE_MAX_LCORE];
struct rte_epoll_event event[num];
int n, i;
uint16_t port_id;
uint8_t queue_id;
void *data;
 
-   if (!timeout) {
+   if (!status[lcore].wakeup) {
RTE_LOG(INFO, L3FWD_POWER,
"lcore %u sleeps until interrupt triggers\n",
rte_lcore_id());
@@ -851,7 +854,7 @@ sleep_until_rx_interrupt(int num)
" port %d queue %d\n",
rte_lcore_id(), port_id, queue_id);
}
-   timeout = n == 0;
+   status[lcore].wakeup = n == 0;
 
return 0;
 }
@@ -1050,7 +1053,8 @@ static int main_intr_loop(__rte_unused void *dummy)
if (intr_en) {
turn_on_off_intr(qconf, 1);
sleep_until_rx_interrupt(
-   qconf->n_rx_queue);
+   qconf->n_rx_queue,
+   lcore_id);
turn_on_off_intr(qconf, 0);
/**
 * start receiving packets immediately
@@ -1473,7 +1477,8 @@ main_legacy_loop(__rte_unused void *dummy)
if (intr_en) {
turn_on_off_intr(qconf, 1);
sleep_until_rx_interrupt(
-   qconf->n_rx_queue);
+   qconf->n_rx_queue,
+   lcore_id);
turn_on_off_intr(qconf, 0);
/**
 * start receiving packets immediately
-- 
2.17.1

[dpdk-dev] [PATCH v2] l3fwd-power: make interrupt wakeup log thread safe

[Anatoly Burakov]

Currently, the interrupt status notification prevents log spam by
remembering whether previous interrupt wakeup was due to traffic or due
to timeout expiring. However, it is a single variable that can
potentially be accessed from multiple threads, so it is not thread-safe.

Fix it by having per-lcore interrupt status.

Fixes: f4d1e19c293d ("examples/l3fwd-power: add Rx interrupt timeout")
Cc: anatoly.bura...@intel.com

Signed-off-by: Anatoly Burakov 
---

Notes:
v2:
- Fix confusing variable naming

 examples/l3fwd-power/main.c | 19 ---
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index d0e6c9bd77..526af0db29 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -821,20 +821,23 @@ power_freq_scaleup_heuristic(unsigned lcore_id,
  *  0 on success
  */
 static int
-sleep_until_rx_interrupt(int num)
+sleep_until_rx_interrupt(int num, int lcore)
 {
/*
 * we want to track when we are woken up by traffic so that we can go
-* back to sleep again without log spamming.
+* back to sleep again without log spamming. Avoid cache line sharing
+* to prevent threads stepping on each others' toes.
 */
-   static bool timeout;
+   static struct {
+   bool wakeup;
+   } __rte_cache_aligned status[RTE_MAX_LCORE];
struct rte_epoll_event event[num];
int n, i;
uint16_t port_id;
uint8_t queue_id;
void *data;
 
-   if (!timeout) {
+   if (status[lcore].wakeup) {
RTE_LOG(INFO, L3FWD_POWER,
"lcore %u sleeps until interrupt triggers\n",
rte_lcore_id());
@@ -851,7 +854,7 @@ sleep_until_rx_interrupt(int num)
" port %d queue %d\n",
rte_lcore_id(), port_id, queue_id);
}
-   timeout = n == 0;
+   status[lcore].wakeup = n != 0;
 
return 0;
 }
@@ -1050,7 +1053,8 @@ static int main_intr_loop(__rte_unused void *dummy)
if (intr_en) {
turn_on_off_intr(qconf, 1);
sleep_until_rx_interrupt(
-   qconf->n_rx_queue);
+   qconf->n_rx_queue,
+   lcore_id);
turn_on_off_intr(qconf, 0);
/**
 * start receiving packets immediately
@@ -1473,7 +1477,8 @@ main_legacy_loop(__rte_unused void *dummy)
if (intr_en) {
turn_on_off_intr(qconf, 1);
sleep_until_rx_interrupt(
-   qconf->n_rx_queue);
+   qconf->n_rx_queue,
+   lcore_id);
turn_on_off_intr(qconf, 0);
/**
 * start receiving packets immediately
-- 
2.17.1

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

[Burakov, Anatoly]

On 02-Oct-20 10:36 AM, David Marchand wrote:

On Thu, Sep 17, 2020 at 4:47 PM David Marchand
 wrote:


On Thu, Sep 17, 2020 at 4:17 PM Burakov, Anatoly
 wrote:

Anonymous hugepages shouldn't matter, yes, but single-file segments mode
does fallocate() and remove - you have the remove part covered, but i'm
just curious if fallocate() would also cause any issues with SELinux.


I found no hook in the kernel for fallocate + selinux...
Looked into fallocate itself and it ends up validating lsm write
access on the file.

I don't have the full setup atm but since I could truncate and write
to it, I'd say we are good.


I could not gain access to the same setup again.

FWIW, I tried with my reproducer:
- no issue with --in-memory option (with or without patch)

- error correctly detected (with this patch) in normal mode after restarting:



Acked-by: Anatoly Burakov 

--
Thanks,
Anatoly

Re: [dpdk-dev] vhost/crypto: fix initialization.

[Maxime Coquelin]

Hi Fan,

Thanks for working on this.

The commit message should not contain dot, please remove it in v2.

On 10/2/20 10:36 AM, Fan Zhang wrote:
> This patch fixes the problem that vhost crypto cannot be
> initialized due to the different requirement between
> built-in virtio-net and virtio-crypto. The fix includes
> the following change:
> 
> - Added new internal enum type virtio_backend_type to
> distinguish virtio-net, virtio-crypto, and external
> device types.
> - Added new API rte_vhost_crypto_driver_start to
> distinguish between virtio-net and virtio-crypto built-in
> drivers initialization.
> - Added new internal function for the vhost library
> to use different feature flags when initializing
> virtio-crypto.

This last one should be part of a dedicated patch.


> Fixes: 2ab58f20db51 ("vhost: refactor virtio ready check")
Please remove that Fixes tag.
Looking in this patch, we can see it worked by luck. Thanks to the
v20.08 refactoring, we spotted that Vhost crypto was broken.

> Cc: maxime.coque...@redhat.com
> 
> Signed-off-by: Fan Zhang 
> ---
>  examples/vhost_crypto/main.c   |  3 +-
>  lib/librte_vhost/rte_vhost_crypto.h| 12 +++
>  lib/librte_vhost/rte_vhost_version.map |  1 +
>  lib/librte_vhost/socket.c  | 44 +-
>  lib/librte_vhost/vhost.h   |  1 -
>  lib/librte_vhost/vhost_crypto.c| 35 
>  lib/librte_vhost/vhost_user.h  | 12 +++
>  7 files changed, 84 insertions(+), 24 deletions(-)
> 
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index 11b022e81..ef64e96de 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -598,7 +598,8 @@ main(int argc, char *argv[])
>   rte_vhost_driver_callback_register(lo->socket_files[j],
>   &virtio_crypto_device_ops);
>  
> - ret = rte_vhost_driver_start(lo->socket_files[j]);
> + ret = rte_vhost_crypto_driver_start(
> + lo->socket_files[j]);
>   if (ret < 0)  {
>   RTE_LOG(ERR, USER1, "failed to start vhost.\n");
>   goto error_exit;
> diff --git a/lib/librte_vhost/rte_vhost_crypto.h 
> b/lib/librte_vhost/rte_vhost_crypto.h
> index b54d61db6..c809c46a2 100644
> --- a/lib/librte_vhost/rte_vhost_crypto.h
> +++ b/lib/librte_vhost/rte_vhost_crypto.h
> @@ -20,6 +20,18 @@ enum rte_vhost_crypto_zero_copy {
>   RTE_VHOST_CRYPTO_MAX_ZERO_COPY_OPTIONS
>  };
>  
> +/**
> + * Start vhost crypto driver
> + *
> + * @param path
> + *  The vhost-user socket file path
> + * @return
> + *  0 on success, -1 on failure
> + */
> +__rte_experimental
> +int
> +rte_vhost_crypto_driver_start(const char *path);
> +
>  /**
>   *  Create Vhost-crypto instance
>   *
> diff --git a/lib/librte_vhost/rte_vhost_version.map 
> b/lib/librte_vhost/rte_vhost_version.map
> index 20b4abcb4..a454d5f41 100644
> --- a/lib/librte_vhost/rte_vhost_version.map
> +++ b/lib/librte_vhost/rte_vhost_version.map
> @@ -48,6 +48,7 @@ EXPERIMENTAL {
>   rte_vhost_get_vring_base;
>   rte_vhost_set_vring_base;
>   rte_vhost_crypto_create;
> + rte_vhost_crypto_driver_start;
>   rte_vhost_crypto_free;
>   rte_vhost_crypto_fetch_requests;
>   rte_vhost_crypto_finalize_requests;
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index 73e1dca95..3de2da836 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -39,7 +39,7 @@ struct vhost_user_socket {
>   bool reconnect;
>   bool dequeue_zero_copy;
>   bool iommu_support;
> - bool use_builtin_virtio_net;
> + enum virtio_backend_type backend_type;
>   bool extbuf;
>   bool linearbuf;
>   bool async_copy;
> @@ -225,7 +225,15 @@ vhost_user_add_connection(int fd, struct 
> vhost_user_socket *vsocket)
>   size = strnlen(vsocket->path, PATH_MAX);
>   vhost_set_ifname(vid, vsocket->path, size);
>  
> - vhost_set_builtin_virtio_net(vid, vsocket->use_builtin_virtio_net);
> + vhost_set_builtin_virtio_net(vid,
> + vsocket->backend_type == VIRTIO_DEV_BUILTIN_NET ?
> + true : false);
> +
> + if (vsocket->backend_type == VIRTIO_DEV_BUILTIN_CRYPTO) {
> + vhost_crypto_set_feature_flags(&vsocket->supported_features,
> + &vsocket->protocol_features);

It should not be done like that, we have API for that.
We don't want to call vhost_crypto API in socket.c

Features supported by the application/backend have to be set between
rte_vhost_driver_register() and rte_vhost_driver_start() calls.

It think it can be done in rte_vhost_crypto_driver_start() function,
please see below.

> + vsocket->features = vsocket->supported_features;
> + }
>  
>   vhost_attach_vdpa_device(vid, vsocket->vdpa_dev);
> 

Re: [dpdk-dev] vhost/crypto: fix initialization.

[Zhang, Roy Fan]

Hi Maxime,

> -Original Message-
> From: Maxime Coquelin 
> Sent: Friday, October 2, 2020 1:18 PM
> To: Zhang, Roy Fan ; dev@dpdk.org
> Cc: Xia, Chenbo ; Liu, Changpeng
> ; Yigit, Ferruh ;
> sta...@dpdk.org
> Subject: Re: [dpdk-dev] vhost/crypto: fix initialization.
> 
> Hi Fan,
> 
> Thanks for working on this.
> 
> The commit message should not contain dot, please remove it in v2.
> 
> On 10/2/20 10:36 AM, Fan Zhang wrote:
> > This patch fixes the problem that vhost crypto cannot be
> > initialized due to the different requirement between
> > built-in virtio-net and virtio-crypto. The fix includes
> > the following change:
> >
> > - Added new internal enum type virtio_backend_type to
> > distinguish virtio-net, virtio-crypto, and external
> > device types.
> > - Added new API rte_vhost_crypto_driver_start to
> > distinguish between virtio-net and virtio-crypto built-in
> > drivers initialization.
> > - Added new internal function for the vhost library
> > to use different feature flags when initializing
> > virtio-crypto.
> 
> This last one should be part of a dedicated patch.
Will do.
> 
> 
> > Fixes: 2ab58f20db51 ("vhost: refactor virtio ready check")
> Please remove that Fixes tag.
> Looking in this patch, we can see it worked by luck. Thanks to the
> v20.08 refactoring, we spotted that Vhost crypto was broken.
> 
> > Cc: maxime.coque...@redhat.com
> >
> > Signed-off-by: Fan Zhang 
> > ---
> >  examples/vhost_crypto/main.c   |  3 +-
> >  lib/librte_vhost/rte_vhost_crypto.h| 12 +++
> >  lib/librte_vhost/rte_vhost_version.map |  1 +
> >  lib/librte_vhost/socket.c  | 44 +-
> >  lib/librte_vhost/vhost.h   |  1 -
> >  lib/librte_vhost/vhost_crypto.c| 35 
> >  lib/librte_vhost/vhost_user.h  | 12 +++
> >  7 files changed, 84 insertions(+), 24 deletions(-)
> >
> > diff --git a/examples/vhost_crypto/main.c
> b/examples/vhost_crypto/main.c
> > index 11b022e81..ef64e96de 100644
> > --- a/examples/vhost_crypto/main.c
> > +++ b/examples/vhost_crypto/main.c
> > @@ -598,7 +598,8 @@ main(int argc, char *argv[])
> > rte_vhost_driver_callback_register(lo-
> >socket_files[j],
> > &virtio_crypto_device_ops);
> >
> > -   ret = rte_vhost_driver_start(lo->socket_files[j]);
> > +   ret = rte_vhost_crypto_driver_start(
> > +   lo->socket_files[j]);
> > if (ret < 0)  {
> > RTE_LOG(ERR, USER1, "failed to start
> vhost.\n");
> > goto error_exit;
> > diff --git a/lib/librte_vhost/rte_vhost_crypto.h
> b/lib/librte_vhost/rte_vhost_crypto.h
> > index b54d61db6..c809c46a2 100644
> > --- a/lib/librte_vhost/rte_vhost_crypto.h
> > +++ b/lib/librte_vhost/rte_vhost_crypto.h
> > @@ -20,6 +20,18 @@ enum rte_vhost_crypto_zero_copy {
> > RTE_VHOST_CRYPTO_MAX_ZERO_COPY_OPTIONS
> >  };
> >
> > +/**
> > + * Start vhost crypto driver
> > + *
> > + * @param path
> > + *  The vhost-user socket file path
> > + * @return
> > + *  0 on success, -1 on failure
> > + */
> > +__rte_experimental
> > +int
> > +rte_vhost_crypto_driver_start(const char *path);
> > +
> >  /**
> >   *  Create Vhost-crypto instance
> >   *
> > diff --git a/lib/librte_vhost/rte_vhost_version.map
> b/lib/librte_vhost/rte_vhost_version.map
> > index 20b4abcb4..a454d5f41 100644
> > --- a/lib/librte_vhost/rte_vhost_version.map
> > +++ b/lib/librte_vhost/rte_vhost_version.map
> > @@ -48,6 +48,7 @@ EXPERIMENTAL {
> > rte_vhost_get_vring_base;
> > rte_vhost_set_vring_base;
> > rte_vhost_crypto_create;
> > +   rte_vhost_crypto_driver_start;
> > rte_vhost_crypto_free;
> > rte_vhost_crypto_fetch_requests;
> > rte_vhost_crypto_finalize_requests;
> > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> > index 73e1dca95..3de2da836 100644
> > --- a/lib/librte_vhost/socket.c
> > +++ b/lib/librte_vhost/socket.c
> > @@ -39,7 +39,7 @@ struct vhost_user_socket {
> > bool reconnect;
> > bool dequeue_zero_copy;
> > bool iommu_support;
> > -   bool use_builtin_virtio_net;
> > +   enum virtio_backend_type backend_type;
> > bool extbuf;
> > bool linearbuf;
> > bool async_copy;
> > @@ -225,7 +225,15 @@ vhost_user_add_connection(int fd, struct
> vhost_user_socket *vsocket)
> > size = strnlen(vsocket->path, PATH_MAX);
> > vhost_set_ifname(vid, vsocket->path, size);
> >
> > -   vhost_set_builtin_virtio_net(vid, vsocket->use_builtin_virtio_net);
> > +   vhost_set_builtin_virtio_net(vid,
> > +   vsocket->backend_type ==
> VIRTIO_DEV_BUILTIN_NET ?
> > +   true : false);
> > +
> > +   if (vsocket->backend_type == VIRTIO_DEV_BUILTIN_CRYPTO) {
> > +   vhost_crypto_set_feature_flags(&vsocket-
> >supported_features,
> > +   &vsocket->protocol_features);
> 
> It should

Re: [dpdk-dev] [PATCH] ethdev: add VLAN attributes to ETH and VLAN items

[Maxime Leroy]

Hi Dekel,

On Thu, Oct 1, 2020 at 8:49 PM Dekel Peled  wrote:
>
> From: Dekel Peled 
>
> This patch implements the change proposes in RFC [1], adding dedicated
> fields to ETH and VLAN items structs, to clearly define the required
> characteristic of a packet, and enable precise match criteria.
>
> [1] https://mails.dpdk.org/archives/dev/2020-August/177536.html
>
> Signed-off-by: Dekel Peled 
> ---
>  doc/guides/rel_notes/release_20_11.rst |  7 +++
>  lib/librte_ethdev/rte_flow.h   | 16 +---
>  2 files changed, 20 insertions(+), 3 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_20_11.rst 
> b/doc/guides/rel_notes/release_20_11.rst
> index 7f9d0dd..199c60b 100644
> --- a/doc/guides/rel_notes/release_20_11.rst
> +++ b/doc/guides/rel_notes/release_20_11.rst
> @@ -173,6 +173,13 @@ API Changes
>* ``_rte_eth_dev_callback_process()`` -> ``rte_eth_dev_callback_process()``
>* ``_rte_eth_dev_reset`` -> ``rte_eth_dev_internal_reset()``
>
> +* ethdev: Added new field ``vlan_exist`` to structure ``rte_flow_item_eth``,
> +  indicating that at least one VLAN exists in the packet header.
> +
> +* ethdev: Added new field ``more_vlans_exist`` to structure
> +  ``rte_flow_item_vlan``, indicating that at least one more VLAN exists in
> +  packet header, following this VLAN.
> +
>  * rawdev: Added a structure size parameter to the functions
>``rte_rawdev_queue_setup()``, ``rte_rawdev_queue_conf_get()``,
>``rte_rawdev_info_get()`` and ``rte_rawdev_configure()``,
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index da8bfa5..39d04ef 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -723,14 +723,18 @@ struct rte_flow_item_raw {
>   * If the @p type field contains a TPID value, then only tagged packets with 
> the
>   * specified TPID will match the pattern.
>   * Otherwise, only untagged packets will match the pattern.
> - * If the @p ETH item is the only item in the pattern, and the @p type field
> - * is not specified, then both tagged and untagged packets will match the
> - * pattern.
> + * The field @p vlan_exist can be used to match specific packet types, 
> instead
> + * of using the @p type field.
> + * This can be used to match any type of tagged packets.
> + * If the @p type and @p vlan_exist fields are not specified, then both 
> tagged
> + * and untagged packets will match the pattern.
>   */
>  struct rte_flow_item_eth {
> struct rte_ether_addr dst; /**< Destination MAC. */
> struct rte_ether_addr src; /**< Source MAC. */
> rte_be16_t type; /**< EtherType or TPID. */
> +   uint32_t vlan_exist:1; /**< At least one VLAN exist in header. */
> +   uint32_t reserved:31; /**< Reserved, must be zero. */
>  };

To resume:
- type and vlan_exists fields not specified:  tag and untagged matched
- with vlan_exists, match only tag or untagged
- with type matching specific ethernet type
- vlan_exists and type should not setted at the same time ?

With this new specification, I think you address all the use cases.
That's great !

>
>  /** Default mask for RTE_FLOW_ITEM_TYPE_ETH. */
> @@ -752,10 +756,16 @@ struct rte_flow_item_eth {
>   * the preceding pattern item.
>   * If a @p VLAN item is present in the pattern, then only tagged packets will
>   * match the pattern.
> + * The field @p more_vlans_exist can be used to match specific packet types,
> + * instead of using the @p inner_type field.
> + * This can be used to match any type of tagged packets.
>   */

Could you please specify what the expected behavior when inner_type
and more_vlans_exist are not specified .
What is the default behavior ?

>  struct rte_flow_item_vlan {
> rte_be16_t tci; /**< Tag control information. */
> rte_be16_t inner_type; /**< Inner EtherType or TPID. */
> +   uint32_t more_vlans_exist:1;
> +   /**< At least one more VLAN exist in header, following this VLAN. */
> +   uint32_t reserved:31; /**< Reserved, must be zero. */
>  };
>
>  /** Default mask for RTE_FLOW_ITEM_TYPE_VLAN. */
> --
> 1.8.3.1
>

I am still wondering, why not using a new item 'NOT' for example to
match only eth packet not tagged ?
example: eth / not vlan. It's a more generic solution.

Here in this commit, we add a reference on VLAN fields on ethernet header.
But tomorrow, we could do the same for mpls by adding mpls_exists in
the eth item and so on.

In fact, we  have the same needs for IPv6 options. To match for
example, ipv6 packet with no fragment option.
With a NOT field, it can be easily done: > eth / ipv6 / no ipv6_frag.

Adding new fields 'item'_exists into eth and ipv6 do the jobs, but
having a NOT attribute is a more generic solution.

It could address many other use cases like matching any udp packets
that are not vxlan ( eth / ipv4 / vxlan / not udp),

Let me know what you think about that.

Regards,

Maxime

Re: [dpdk-dev] [PATCH v10 00/11] adding support for python 3 only

[David Marchand]

On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz  wrote:
>
> This patch set converts all python scripts in the project to use
> python3 only and removes all deprecation notices associated with these
> changes. This is due to python2 being EOL in January 2020.
>

Squashed all as one patch (all commit logs were clones and the changes
on the files were mechanical).
Updated coding style guide as commented in the thread.

Applied, thanks Kevin and Louise!


-- 
David Marchand

Re: [dpdk-dev] [PATCH v4 00/25] raw/ioat: enhancements and new hardware support

[Nicolau, Radu]

On 9/28/2020 5:42 PM, Bruce Richardson wrote:

This patchset adds some small enhancements, some rework and also support
for new hardware to the ioat rawdev driver. Most rework and enhancements
are largely self-explanatory from the individual patches.

The new hardware support is for the Intel(R) DSA accelerator which will be
present in future Intel processors. A description of this new hardware is
covered in [1]. Functions specific to the new hardware use the "idxd"
prefix, for consistency with the kernel driver.

[1] https://01.org/blogs/2019/introducing-intel-data-streaming-accelerator

---
V4:
  * Fixed compile with FreeBSD clang
  * Improved autotests for fill operation

V3:
  * More doc updates including release note updates throughout the set
  * Added in fill operation
  * Added in fix for missing close operation
  * Added in fix for doc building to ensure ioat is in in the index

V2:
  * Included documentation additions in the set
  * Split off the rawdev unit test changes to a separate patchset for easier
review
  * General code improvements and cleanups

Bruce Richardson (19):
   doc/api: add ioat driver to index
   raw/ioat: enable use from C++ code
   raw/ioat: include extra info in error messages
   raw/ioat: split header for readability
   raw/ioat: rename functions to be operation-agnostic
   raw/ioat: add separate API for fence call
   raw/ioat: make the HW register spec private
   raw/ioat: add skeleton for VFIO/UIO based DSA device
   raw/ioat: include example configuration script
   raw/ioat: create rawdev instances on idxd PCI probe
   raw/ioat: add datapath data structures for idxd devices
   raw/ioat: add configure function for idxd devices
   raw/ioat: add start and stop functions for idxd devices
   raw/ioat: add data path for idxd devices
   raw/ioat: add info function for idxd devices
   raw/ioat: create separate statistics structure
   raw/ioat: move xstats functions to common file
   raw/ioat: add xstats tracking for idxd devices
   raw/ioat: clean up use of common test function

Cheng Jiang (1):
   raw/ioat: add a flag to control copying handle parameters

Kevin Laatz (5):
   raw/ioat: fix missing close function
   usertools/dpdk-devbind.py: add support for DSA HW
   raw/ioat: add vdev probe for DSA/idxd devices
   raw/ioat: create rawdev instances for idxd vdevs
   raw/ioat: add fill operation

  doc/api/doxy-api-index.md |   1 +
  doc/api/doxy-api.conf.in  |   1 +
  doc/guides/rawdevs/ioat.rst   | 163 +++--
  doc/guides/rel_notes/release_20_11.rst|  23 +
  doc/guides/sample_app_ug/ioat.rst |   8 +-
  drivers/raw/ioat/dpdk_idxd_cfg.py |  79 +++
  drivers/raw/ioat/idxd_pci.c   | 345 ++
  drivers/raw/ioat/idxd_vdev.c  | 233 +++
  drivers/raw/ioat/ioat_common.c| 244 +++
  drivers/raw/ioat/ioat_private.h   |  82 +++
  drivers/raw/ioat/ioat_rawdev.c|  92 +--
  drivers/raw/ioat/ioat_rawdev_test.c   | 130 +++-
  .../raw/ioat/{rte_ioat_spec.h => ioat_spec.h} |  90 ++-
  drivers/raw/ioat/meson.build  |  15 +-
  drivers/raw/ioat/rte_ioat_rawdev.h| 221 +++
  drivers/raw/ioat/rte_ioat_rawdev_fns.h| 595 ++
  examples/ioat/ioatfwd.c   |  16 +-
  lib/librte_eal/include/rte_common.h   |   1 +
  usertools/dpdk-devbind.py |   4 +-
  19 files changed, 1989 insertions(+), 354 deletions(-)
  create mode 100755 drivers/raw/ioat/dpdk_idxd_cfg.py
  create mode 100644 drivers/raw/ioat/idxd_pci.c
  create mode 100644 drivers/raw/ioat/idxd_vdev.c
  create mode 100644 drivers/raw/ioat/ioat_common.c
  create mode 100644 drivers/raw/ioat/ioat_private.h
  rename drivers/raw/ioat/{rte_ioat_spec.h => ioat_spec.h} (74%)
  create mode 100644 drivers/raw/ioat/rte_ioat_rawdev_fns.h



Series Acked-by: Radu Nicolau 

[dpdk-dev] [PATCH v4 01/10] eal: add new x86 cpuid support for WAITPKG

[Liang Ma]

Add new x86 cpuid support for WAITPKG.
This flag indicate processor support umwait/umonitor/tpause
instruction.

Signed-off-by: Liang Ma 
Signed-off-by: Anatoly Burakov 
---
 lib/librte_eal/x86/include/rte_cpuflags.h | 2 ++
 lib/librte_eal/x86/rte_cpuflags.c | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/lib/librte_eal/x86/include/rte_cpuflags.h 
b/lib/librte_eal/x86/include/rte_cpuflags.h
index c1d20364d1..5041a830a7 100644
--- a/lib/librte_eal/x86/include/rte_cpuflags.h
+++ b/lib/librte_eal/x86/include/rte_cpuflags.h
@@ -132,6 +132,8 @@ enum rte_cpu_flag_t {
RTE_CPUFLAG_MOVDIR64B,  /**< Direct Store Instructions 64B 
*/
RTE_CPUFLAG_AVX512VP2INTERSECT, /**< AVX512 Two Register 
Intersection */
 
+   /**< UMWAIT/TPAUSE Instructions */
+   RTE_CPUFLAG_WAITPKG,/**< UMINITOR/UMWAIT/TPAUSE */
/* The last item */
RTE_CPUFLAG_NUMFLAGS,   /**< This should always be the 
last! */
 };
diff --git a/lib/librte_eal/x86/rte_cpuflags.c 
b/lib/librte_eal/x86/rte_cpuflags.c
index 30439e7951..0325c4b93b 100644
--- a/lib/librte_eal/x86/rte_cpuflags.c
+++ b/lib/librte_eal/x86/rte_cpuflags.c
@@ -110,6 +110,8 @@ const struct feature_entry rte_cpu_feature_table[] = {
FEAT_DEF(AVX512F, 0x0007, 0, RTE_REG_EBX, 16)
FEAT_DEF(RDSEED, 0x0007, 0, RTE_REG_EBX, 18)
 
+   FEAT_DEF(WAITPKG, 0x0007, 0, RTE_REG_ECX, 5)
+
FEAT_DEF(LAHF_SAHF, 0x8001, 0, RTE_REG_ECX,  0)
FEAT_DEF(LZCNT, 0x8001, 0, RTE_REG_ECX,  4)
 
-- 
2.17.1

[dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

[Liang Ma]

Add two new power management intrinsics, and provide an implementation
in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions
are implemented as raw byte opcodes because there is not yet widespread
compiler support for these instructions.

The power management instructions provide an architecture-specific
function to either wait until a specified TSC timestamp is reached, or
optionally wait until either a TSC timestamp is reached or a memory
location is written to. The monitor function also provides an optional
comparison, to avoid sleeping when the expected write has already
happened, and no more writes are expected.

For more details, Please reference Intel SDM Volume 2.

Signed-off-by: Liang Ma 
Signed-off-by: Anatoly Burakov 
---
 .../include/generic/rte_power_intrinsics.h|  64 
 lib/librte_eal/include/meson.build|   1 +
 lib/librte_eal/x86/include/meson.build|   1 +
 .../x86/include/rte_power_intrinsics.h| 143 ++
 4 files changed, 209 insertions(+)
 create mode 100644 lib/librte_eal/include/generic/rte_power_intrinsics.h
 create mode 100644 lib/librte_eal/x86/include/rte_power_intrinsics.h

diff --git a/lib/librte_eal/include/generic/rte_power_intrinsics.h 
b/lib/librte_eal/include/generic/rte_power_intrinsics.h
new file mode 100644
index 00..cd7f8070ac
--- /dev/null
+++ b/lib/librte_eal/include/generic/rte_power_intrinsics.h
@@ -0,0 +1,64 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2020 Intel Corporation
+ */
+
+#ifndef _RTE_POWER_INTRINSIC_H_
+#define _RTE_POWER_INTRINSIC_H_
+
+#include 
+
+/**
+ * @file
+ * Advanced power management operations.
+ *
+ * This file define APIs for advanced power management,
+ * which are architecture-dependent.
+ */
+
+/**
+ * Monitor specific address for changes. This will cause the CPU to enter an
+ * architecture-defined optimized power state until either the specified
+ * memory address is written to, or a certain TSC timestamp is reached.
+ *
+ * Additionally, an `expected` 64-bit value and 64-bit mask are provided. If
+ * mask is non-zero, the current value pointed to by the `p` pointer will be
+ * checked against the expected value, and if they match, the entering of
+ * optimized power state may be aborted.
+ *
+ * @param p
+ *   Address to monitor for changes. Must be aligned on an 64-byte boundary.
+ * @param expected_value
+ *   Before attempting the monitoring, the `p` address may be read and compared
+ *   against this value. If `value_mask` is zero, this step will be skipped.
+ * @param value_mask
+ *   The 64-bit mask to use to extract current value from `p`.
+ * @param state
+ *   Architecture-dependent optimized power state number
+ * @param tsc_timestamp
+ *   Maximum TSC timestamp to wait for. Note that the wait behavior is
+ *   architecture-dependent.
+ *
+ * @return
+ *   Architecture-dependent return value.
+ */
+static inline int rte_power_monitor(const volatile void *p,
+   const uint64_t expected_value, const uint64_t value_mask,
+   const uint32_t state, const uint64_t tsc_timestamp);
+
+/**
+ * Enter an architecture-defined optimized power state until a certain TSC
+ * timestamp is reached.
+ *
+ * @param state
+ *   Architecture-dependent optimized power state number
+ * @param tsc_timestamp
+ *   Maximum TSC timestamp to wait for. Note that the wait behavior is
+ *   architecture-dependent.
+ *
+ * @return
+ *   Architecture-dependent return value.
+ */
+static inline int rte_power_pause(const uint32_t state,
+   const uint64_t tsc_timestamp);
+
+#endif /* _RTE_POWER_INTRINSIC_H_ */
diff --git a/lib/librte_eal/include/meson.build 
b/lib/librte_eal/include/meson.build
index cd09027958..3a12e87e19 100644
--- a/lib/librte_eal/include/meson.build
+++ b/lib/librte_eal/include/meson.build
@@ -60,6 +60,7 @@ generic_headers = files(
'generic/rte_memcpy.h',
'generic/rte_pause.h',
'generic/rte_prefetch.h',
+   'generic/rte_power_intrinsics.h',
'generic/rte_rwlock.h',
'generic/rte_spinlock.h',
'generic/rte_ticketlock.h',
diff --git a/lib/librte_eal/x86/include/meson.build 
b/lib/librte_eal/x86/include/meson.build
index f0e998c2fe..494a8142a2 100644
--- a/lib/librte_eal/x86/include/meson.build
+++ b/lib/librte_eal/x86/include/meson.build
@@ -13,6 +13,7 @@ arch_headers = files(
'rte_io.h',
'rte_memcpy.h',
'rte_prefetch.h',
+   'rte_power_intrinsics.h',
'rte_pause.h',
'rte_rtm.h',
'rte_rwlock.h',
diff --git a/lib/librte_eal/x86/include/rte_power_intrinsics.h 
b/lib/librte_eal/x86/include/rte_power_intrinsics.h
new file mode 100644
index 00..6dd1cdc939
--- /dev/null
+++ b/lib/librte_eal/x86/include/rte_power_intrinsics.h
@@ -0,0 +1,143 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2020 Intel Corporation
+ */
+
+#ifndef _RTE_POWER_INTRINSIC_X86_64_H_
+#define _RTE_POWER_INTRINSIC_X86_64_H_
+
+#ifdef _

[dpdk-dev] [PATCH v4 04/10] power: add simple power management API and callback

[Liang Ma]

Add a simple on/off switch that will enable saving power when no
packets are arriving. It is based on counting the number of empty
polls and, when the number reaches a certain threshold, entering an
architecture-defined optimized power state that will either wait
until a TSC timestamp expires, or when packets arrive.

This API support 1 port to multiple core use case.

This design leverage RX Callback mechnaism which allow three
different power management methodology co exist.

1. umwait/umonitor:

   The TSC timestamp is automatically calculated using current
   link speed and RX descriptor ring size, such that the sleep
   time is not longer than it would take for a NIC to fill its
   entire RX descriptor ring.

2. Pause instruction

   Instead of move the core into deeper C state, this lightweight
   method use Pause instruction to relief the processor from
   busy polling.

3. Frequency Scaling
   Reuse exist rte power library to scale up/down core frequency
   depend on traffic volume.

Signed-off-by: Liang Ma 
Signed-off-by: Anatoly Burakov 
---
 lib/librte_power/meson.build   |   5 +-
 lib/librte_power/pmd_mgmt.h|  49 ++
 lib/librte_power/rte_power_pmd_mgmt.c  | 208 +
 lib/librte_power/rte_power_pmd_mgmt.h  |  88 +++
 lib/librte_power/rte_power_version.map |   4 +
 5 files changed, 352 insertions(+), 2 deletions(-)
 create mode 100644 lib/librte_power/pmd_mgmt.h
 create mode 100644 lib/librte_power/rte_power_pmd_mgmt.c
 create mode 100644 lib/librte_power/rte_power_pmd_mgmt.h

diff --git a/lib/librte_power/meson.build b/lib/librte_power/meson.build
index 78c031c943..cc3c7a8646 100644
--- a/lib/librte_power/meson.build
+++ b/lib/librte_power/meson.build
@@ -9,6 +9,7 @@ sources = files('rte_power.c', 'power_acpi_cpufreq.c',
'power_kvm_vm.c', 'guest_channel.c',
'rte_power_empty_poll.c',
'power_pstate_cpufreq.c',
+   'rte_power_pmd_mgmt.c',
'power_common.c')
-headers = files('rte_power.h','rte_power_empty_poll.h')
-deps += ['timer']
+headers = files('rte_power.h','rte_power_empty_poll.h','rte_power_pmd_mgmt.h')
+deps += ['timer' ,'ethdev']
diff --git a/lib/librte_power/pmd_mgmt.h b/lib/librte_power/pmd_mgmt.h
new file mode 100644
index 00..756fbe20f7
--- /dev/null
+++ b/lib/librte_power/pmd_mgmt.h
@@ -0,0 +1,49 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2020 Intel Corporation
+ */
+
+#ifndef _PMD_MGMT_H
+#define _PMD_MGMT_H
+
+/**
+ * @file
+ * Power Management
+ */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * Possible power management states of an ethdev port.
+ */
+enum pmd_mgmt_state {
+   /** Device power management is disabled. */
+   PMD_MGMT_DISABLED = 0,
+   /** Device power management is enabled. */
+   PMD_MGMT_ENABLED,
+};
+
+struct pmd_queue_cfg {
+   enum pmd_mgmt_state pwr_mgmt_state;
+   /**< Power mgmt Callback mode */
+   enum rte_power_pmd_mgmt_type cb_mode;
+   /**< Empty poll number */
+   uint16_t empty_poll_stats;
+   /**< Callback instance  */
+   const struct rte_eth_rxtx_callback *cur_cb;
+} __rte_cache_aligned;
+
+struct pmd_port_cfg {
+   int  ref_cnt;
+   struct pmd_queue_cfg *queue_cfg;
+} __rte_cache_aligned;
+
+
+
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif
diff --git a/lib/librte_power/rte_power_pmd_mgmt.c 
b/lib/librte_power/rte_power_pmd_mgmt.c
new file mode 100644
index 00..35d2af46a4
--- /dev/null
+++ b/lib/librte_power/rte_power_pmd_mgmt.c
@@ -0,0 +1,208 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2010-2020 Intel Corporation
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "rte_power_pmd_mgmt.h"
+#include "pmd_mgmt.h"
+
+
+#define EMPTYPOLL_MAX  512
+#define PAUSE_NUM  64
+
+static struct pmd_port_cfg port_cfg[RTE_MAX_ETHPORTS];
+
+static uint16_t
+rte_power_mgmt_umwait(uint16_t port_id, uint16_t qidx,
+   struct rte_mbuf **pkts __rte_unused, uint16_t nb_rx,
+   uint16_t max_pkts __rte_unused, void *_  __rte_unused)
+{
+
+   struct pmd_queue_cfg *q_conf;
+   q_conf = &port_cfg[port_id].queue_cfg[qidx];
+
+   if (unlikely(nb_rx == 0)) {
+   q_conf->empty_poll_stats++;
+   if (unlikely(q_conf->empty_poll_stats > EMPTYPOLL_MAX)) {
+   volatile void *target_addr;
+   uint64_t expected, mask;
+   uint16_t ret;
+
+   /*
+* get address of next descriptor in the RX
+* ring for this queue, as well as expected
+* value and a mask.
+*/
+   ret = rte_eth_get_wake_addr(port_id, qidx,
+   &target_addr, &expected,
+   &mask);
+   if (ret == 0)
+ 

[dpdk-dev] [PATCH v4 07/10] net/ice: implement power management API

[Liang Ma]

Implement support for the power management API by implementing a
`get_wake_addr` function that will return an address of an RX ring's
status bit.

Signed-off-by: Liang Ma 
Signed-off-by: Anatoly Burakov 
---
 drivers/net/ice/ice_ethdev.c |  1 +
 drivers/net/ice/ice_rxtx.c   | 23 +++
 drivers/net/ice/ice_rxtx.h   |  2 ++
 3 files changed, 26 insertions(+)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index d8ce09d28f..260de5dfd7 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -216,6 +216,7 @@ static const struct eth_dev_ops ice_eth_dev_ops = {
.udp_tunnel_port_add  = ice_dev_udp_tunnel_port_add,
.udp_tunnel_port_del  = ice_dev_udp_tunnel_port_del,
.tx_done_cleanup  = ice_tx_done_cleanup,
+   .get_wake_addr= ice_get_wake_addr,
 };
 
 /* store statistics names and its offset in stats structure */
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 93a0ac6918..9e55eca942 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -25,6 +25,29 @@ uint64_t rte_net_ice_dynflag_proto_xtr_ipv6_flow_mask;
 uint64_t rte_net_ice_dynflag_proto_xtr_tcp_mask;
 uint64_t rte_net_ice_dynflag_proto_xtr_ip_offset_mask;
 
+int ice_get_wake_addr(void *rx_queue, volatile void **tail_desc_addr,
+   uint64_t *expected, uint64_t *mask)
+{
+   volatile union ice_rx_flex_desc *rxdp;
+   struct ice_rx_queue *rxq = rx_queue;
+   uint16_t desc;
+
+   desc = rxq->rx_tail;
+   rxdp = &rxq->rx_ring[desc];
+   /* watch for changes in status bit */
+   *tail_desc_addr = &rxdp->wb.status_error0;
+
+   /*
+* we expect the DD bit to be set to 1 if this descriptor was already
+* written to.
+*/
+   *expected = rte_cpu_to_le_16(1 << ICE_RX_FLEX_DESC_STATUS0_DD_S);
+   *mask = rte_cpu_to_le_16(1 << ICE_RX_FLEX_DESC_STATUS0_DD_S);
+
+   return 0;
+}
+
+
 static inline uint8_t
 ice_proto_xtr_type_to_rxdid(uint8_t xtr_type)
 {
diff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h
index 1c23c7541e..c729e474c9 100644
--- a/drivers/net/ice/ice_rxtx.h
+++ b/drivers/net/ice/ice_rxtx.h
@@ -250,6 +250,8 @@ uint16_t ice_xmit_pkts_vec_avx2(void *tx_queue, struct 
rte_mbuf **tx_pkts,
uint16_t nb_pkts);
 int ice_fdir_programming(struct ice_pf *pf, struct ice_fltr_desc *fdir_desc);
 int ice_tx_done_cleanup(void *txq, uint32_t free_cnt);
+int ice_get_wake_addr(void *rx_queue, volatile void **tail_desc_addr,
+ uint64_t *expected, uint64_t *mask);
 
 #define FDIR_PARSING_ENABLE_PER_QUEUE(ad, on) do { \
int i; \
-- 
2.17.1

[dpdk-dev] [PATCH v4 10/10] doc: update the programming guide for PMD power management

[Liang Ma]

Update programming guide and sample application l3fwd-power document
for PMD power management

Signed-off-by: Liang Ma 
---
 doc/guides/prog_guide/power_man.rst   | 40 +++
 .../sample_app_ug/l3_forward_power_man.rst| 15 ++-
 2 files changed, 54 insertions(+), 1 deletion(-)

diff --git a/doc/guides/prog_guide/power_man.rst 
b/doc/guides/prog_guide/power_man.rst
index 0a3755a901..c95b948874 100644
--- a/doc/guides/prog_guide/power_man.rst
+++ b/doc/guides/prog_guide/power_man.rst
@@ -188,6 +188,43 @@ API Overview for Empty Poll Power Management
 
 * **Detect empty poll state change**: empty poll state change detection 
algorithm then take action.
 
+PMD Power Management API
+
+
+Abstract
+
+Given existing power management mechanism, developer need change application 
design or code to use it.
+In order to solve the problem, it's very helpful to make the design 
transparent to application.
+The proposed solution is to leverage RX_CALLBACK mechanism which allow three 
different power management
+methodology co exist. The trigger condition is empty poll number beyond 
defined threshold.
+
+  * umwait/umonitor
+
+   The new umwait/umonitor instruction monitoring the wake address then 
transfer processor to sub-state.
+   Once the content of address is changed, the processor will be wake up from 
the sub-state. Timeout is
+   setup as well, in case, there is no wake event happen, processor still will 
wake up after timeout
+   timer expired.
+
+  * Pause instruction
+
+   Instead of move the core into deeper C state, this lightweight method use 
Pause instruction
+   to relief the processor from busy polling.
+
+  * Frequency Scaling
+
+   Reuse exist rte power library to scale up/down core frequency
+   depend on traffic volume.
+
+The proposed solution support multiple port and each port can map to multiple 
core. But 1 core only can map
+1 queue(regardless which port). In theory, each queue belongs to same port can 
apply different power scheme.
+It's strongly recommend to use same power scheme for all queues belong to same 
port.
+
+API Overview for PMD Power Management
+
+* **Queue Enable**: Enable specific power scheme for certain queue/port/core
+
+* **Queue Disable**: Disable power scheme for certain queue/port/core
+
 User Cases
 --
 The mechanism can applied to any device which is based on polling. e.g. NIC, 
FPGA.
@@ -200,3 +237,6 @@ References
 
 *   The :doc:`../sample_app_ug/vm_power_management`
 chapter in the :doc:`../sample_app_ug/index` section.
+
+*   The :doc:`../sample_app_ug/rxtx_callbacks`
+chapter in the :doc:`../sample_app_ug/index` section.
diff --git a/doc/guides/sample_app_ug/l3_forward_power_man.rst 
b/doc/guides/sample_app_ug/l3_forward_power_man.rst
index 0cc6f2e62e..82f9ac849c 100644
--- a/doc/guides/sample_app_ug/l3_forward_power_man.rst
+++ b/doc/guides/sample_app_ug/l3_forward_power_man.rst
@@ -107,7 +107,9 @@ where,
 
 *   --empty-poll: Traffic Aware power management. See below for details
 
-*   --telemetry:  Telemetry mode.
+*   --telemetry: Telemetry mode.
+
+*   --pmd-mgmt: PMD power management mode.
 
 See :doc:`l3_forward` for details.
 The L3fwd-power example reuses the L3fwd command line options.
@@ -459,3 +461,14 @@ reference cycles and accordingly busy rate is set  to 
either 0% or
 
 The new stats ``empty_poll`` , ``full_poll`` and ``busy_percent`` can be 
viewed by running the script
 ``/usertools/dpdk-telemetry-client.py`` and selecting the menu option ``Send 
for global Metrics``.
+
+PMD power management Mode
+-
+
+The PMD power management  mode support for ``l3fwd-power`` is a standalone 
mode, in this mode
+``l3fwd-power`` does simple l3fwding along with enable the power saving scheme 
on specific
+port/queue/lcore. Main purpose for this mode is to demonstrate how to use the 
PMD power management API.
+
+.. code-block:: console
+
+./examples/l3fwd-power/build/l3fwd-power --pmd-mgmt -l 1-3 -- -p 0x0f 
--config="(0,0,2),(0,1,3)"
-- 
2.17.1

[dpdk-dev] [PATCH v4 06/10] net/i40e: implement power management API

[Liang Ma]

Implement support for the power management API by implementing a
`get_wake_addr` function that will return an address of an RX ring's
status bit.

Signed-off-by: Liang Ma 
Signed-off-by: Anatoly Burakov 
---
 drivers/net/i40e/i40e_ethdev.c |  1 +
 drivers/net/i40e/i40e_rxtx.c   | 23 +++
 drivers/net/i40e/i40e_rxtx.h   |  2 ++
 3 files changed, 26 insertions(+)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 943cfe71dc..cab86f8ec9 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -513,6 +513,7 @@ static const struct eth_dev_ops i40e_eth_dev_ops = {
.mtu_set  = i40e_dev_mtu_set,
.tm_ops_get   = i40e_tm_ops_get,
.tx_done_cleanup  = i40e_tx_done_cleanup,
+   .get_wake_addr= i40e_get_wake_addr,
 };
 
 /* store statistics names and its offset in stats structure */
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 322fc1ed75..c17f27292f 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -71,6 +71,29 @@
 #define I40E_TX_OFFLOAD_NOTSUP_MASK \
(PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK)
 
+int
+i40e_get_wake_addr(void *rx_queue, volatile void **tail_desc_addr,
+   uint64_t *expected, uint64_t *mask)
+{
+   struct i40e_rx_queue *rxq = rx_queue;
+   volatile union i40e_rx_desc *rxdp;
+   uint16_t desc;
+
+   desc = rxq->rx_tail;
+   rxdp = &rxq->rx_ring[desc];
+   /* watch for changes in status bit */
+   *tail_desc_addr = &rxdp->wb.qword1.status_error_len;
+
+   /*
+* we expect the DD bit to be set to 1 if this descriptor was already
+* written to.
+*/
+   *expected = rte_cpu_to_le_64(1 << I40E_RX_DESC_STATUS_DD_SHIFT);
+   *mask = rte_cpu_to_le_64(1 << I40E_RX_DESC_STATUS_DD_SHIFT);
+
+   return 0;
+}
+
 static inline void
 i40e_rxd_to_vlan_tci(struct rte_mbuf *mb, volatile union i40e_rx_desc *rxdp)
 {
diff --git a/drivers/net/i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.h
index 57d7b4160b..f23a2073e3 100644
--- a/drivers/net/i40e/i40e_rxtx.h
+++ b/drivers/net/i40e/i40e_rxtx.h
@@ -248,6 +248,8 @@ uint16_t i40e_recv_scattered_pkts_vec_avx2(void *rx_queue,
struct rte_mbuf **rx_pkts, uint16_t nb_pkts);
 uint16_t i40e_xmit_pkts_vec_avx2(void *tx_queue, struct rte_mbuf **tx_pkts,
uint16_t nb_pkts);
+int i40e_get_wake_addr(void *rx_queue, volatile void **tail_desc_addr,
+   uint64_t *expected, uint64_t *value);
 
 /* For each value it means, datasheet of hardware can tell more details
  *
-- 
2.17.1

[dpdk-dev] [PATCH v4 05/10] net/ixgbe: implement power management API

[Liang Ma]

Implement support for the power management API by implementing a
`get_wake_addr` function that will return an address of an RX ring's
status bit.

Signed-off-by: Anatoly Burakov 
Signed-off-by: Liang Ma 
---
 drivers/net/ixgbe/ixgbe_ethdev.c |  1 +
 drivers/net/ixgbe/ixgbe_rxtx.c   | 22 ++
 drivers/net/ixgbe/ixgbe_rxtx.h   |  2 ++
 3 files changed, 25 insertions(+)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 0b98e210e7..30b3f416d4 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -588,6 +588,7 @@ static const struct eth_dev_ops ixgbe_eth_dev_ops = {
.udp_tunnel_port_del  = ixgbe_dev_udp_tunnel_port_del,
.tm_ops_get   = ixgbe_tm_ops_get,
.tx_done_cleanup  = ixgbe_dev_tx_done_cleanup,
+   .get_wake_addr= ixgbe_get_wake_addr,
 };
 
 /*
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index 977ecf5137..7a9fd2aec6 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -1366,6 +1366,28 @@ const uint32_t
RTE_PTYPE_INNER_L3_IPV4_EXT | RTE_PTYPE_INNER_L4_UDP,
 };
 
+int ixgbe_get_wake_addr(void *rx_queue, volatile void **tail_desc_addr,
+   uint64_t *expected, uint64_t *mask)
+{
+   volatile union ixgbe_adv_rx_desc *rxdp;
+   struct ixgbe_rx_queue *rxq = rx_queue;
+   uint16_t desc;
+
+   desc = rxq->rx_tail;
+   rxdp = &rxq->rx_ring[desc];
+   /* watch for changes in status bit */
+   *tail_desc_addr = &rxdp->wb.upper.status_error;
+
+   /*
+* we expect the DD bit to be set to 1 if this descriptor was already
+* written to.
+*/
+   *expected = rte_cpu_to_le_32(IXGBE_RXDADV_STAT_DD);
+   *mask = rte_cpu_to_le_32(IXGBE_RXDADV_STAT_DD);
+
+   return 0;
+}
+
 /* @note: fix ixgbe_dev_supported_ptypes_get() if any change here. */
 static inline uint32_t
 ixgbe_rxd_pkt_info_to_pkt_type(uint32_t pkt_info, uint16_t ptype_mask)
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxtx.h
index 7e09291b22..75020fa2fc 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.h
+++ b/drivers/net/ixgbe/ixgbe_rxtx.h
@@ -299,5 +299,7 @@ uint64_t ixgbe_get_tx_port_offloads(struct rte_eth_dev 
*dev);
 uint64_t ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev);
 uint64_t ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev);
 uint64_t ixgbe_get_tx_queue_offloads(struct rte_eth_dev *dev);
+int ixgbe_get_wake_addr(void *rx_queue, volatile void **tail_desc_addr,
+   uint64_t *expected, uint64_t *mask);
 
 #endif /* _IXGBE_RXTX_H_ */
-- 
2.17.1

[dpdk-dev] [PATCH v4 08/10] examples/l3fwd-power: enable PMD power mgmt

[Liang Ma]

Add pmd power mgmt feature support.

Signed-off-by: Liang Ma 
---
 examples/l3fwd-power/main.c | 44 -
 1 file changed, 43 insertions(+), 1 deletion(-)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index d0e6c9bd77..b1b139129a 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -47,6 +47,8 @@
 #include 
 #include 
 #include 
+#include 
+
 
 #include "perf_core.h"
 #include "main.h"
@@ -199,7 +201,8 @@ enum appmode {
APP_MODE_LEGACY,
APP_MODE_EMPTY_POLL,
APP_MODE_TELEMETRY,
-   APP_MODE_INTERRUPT
+   APP_MODE_INTERRUPT,
+   APP_MODE_PMD_MGMT
 };
 
 enum appmode app_mode;
@@ -1750,6 +1753,7 @@ parse_ep_config(const char *q_arg)
 #define CMD_LINE_OPT_EMPTY_POLL "empty-poll"
 #define CMD_LINE_OPT_INTERRUPT_ONLY "interrupt-only"
 #define CMD_LINE_OPT_TELEMETRY "telemetry"
+#define CMD_LINE_OPT_PMD_MGMT "pmd-mgmt"
 
 /* Parse the argument given in the command line of the application */
 static int
@@ -1771,6 +1775,7 @@ parse_args(int argc, char **argv)
{CMD_LINE_OPT_LEGACY, 0, 0, 0},
{CMD_LINE_OPT_TELEMETRY, 0, 0, 0},
{CMD_LINE_OPT_INTERRUPT_ONLY, 0, 0, 0},
+   {CMD_LINE_OPT_PMD_MGMT, 0, 0, 0},
{NULL, 0, 0, 0}
};
 
@@ -1881,6 +1886,16 @@ parse_args(int argc, char **argv)
printf("telemetry mode is enabled\n");
}
 
+   if (!strncmp(lgopts[option_index].name,
+   CMD_LINE_OPT_PMD_MGMT,
+   sizeof(CMD_LINE_OPT_PMD_MGMT))) {
+   if (app_mode != APP_MODE_DEFAULT) {
+   printf(" power mgmt mode is mutually 
exclusive with other modes\n");
+   return -1;
+   }
+   app_mode = APP_MODE_PMD_MGMT;
+   printf("PMD power mgmt  mode is enabled\n");
+   }
if (!strncmp(lgopts[option_index].name,
CMD_LINE_OPT_INTERRUPT_ONLY,
sizeof(CMD_LINE_OPT_INTERRUPT_ONLY))) {
@@ -2437,6 +2452,9 @@ mode_to_str(enum appmode mode)
return "telemetry";
case APP_MODE_INTERRUPT:
return "interrupt-only";
+   case APP_MODE_PMD_MGMT:
+   return "pmd mgmt";
+
default:
return "invalid";
}
@@ -2705,6 +2723,12 @@ main(int argc, char **argv)
} else if (!check_ptype(portid))
rte_exit(EXIT_FAILURE,
 "PMD can not provide needed ptypes\n");
+   if (app_mode == APP_MODE_PMD_MGMT) {
+   rte_power_pmd_mgmt_queue_enable(lcore_id,
+   portid, queueid,
+   RTE_POWER_MGMT_TYPE_SCALE);
+
+   }
}
}
 
@@ -2790,8 +2814,12 @@ main(int argc, char **argv)
SKIP_MASTER);
} else if (app_mode == APP_MODE_INTERRUPT) {
rte_eal_mp_remote_launch(main_intr_loop, NULL, CALL_MASTER);
+   } else if (app_mode == APP_MODE_PMD_MGMT) {
+   rte_eal_mp_remote_launch(main_telemetry_loop, NULL,
+CALL_MASTER);
}
 
+
if (app_mode == APP_MODE_EMPTY_POLL || app_mode == APP_MODE_TELEMETRY)
launch_timer(rte_lcore_id());
 
@@ -2812,6 +2840,20 @@ main(int argc, char **argv)
if (app_mode == APP_MODE_EMPTY_POLL)
rte_power_empty_poll_stat_free();
 
+   if (app_mode == APP_MODE_PMD_MGMT) {
+   for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+   if (rte_lcore_is_enabled(lcore_id) == 0)
+   continue;
+   qconf = &lcore_conf[lcore_id];
+   for (queue = 0; queue < qconf->n_rx_queue; ++queue) {
+   portid = qconf->rx_queue_list[queue].port_id;
+   queueid = qconf->rx_queue_list[queue].queue_id;
+   rte_power_pmd_mgmt_queue_disable(lcore_id,
+   portid, queueid);
+   }
+   }
+   }
+
if ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) &&
deinit_power_library())
rte_exit(EXIT_FAILURE, "deinit_power_library failed\n");
-- 
2.17.1

[dpdk-dev] [PATCH v4 03/10] ethdev: add simple power management API

[Liang Ma]

Add a simple API allow ethdev get wake up address from PMD.
Also include internal structure update.

Signed-off-by: Liang Ma 
Signed-off-by: Anatoly Burakov 
---
 lib/librte_ethdev/rte_ethdev.c   | 19 
 lib/librte_ethdev/rte_ethdev.h   | 24 
 lib/librte_ethdev/rte_ethdev_driver.h| 28 
 lib/librte_ethdev/rte_ethdev_version.map |  1 +
 4 files changed, 72 insertions(+)

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index d7668114ca..88253d95f9 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -4804,6 +4804,25 @@ rte_eth_tx_burst_mode_get(uint16_t port_id, uint16_t 
queue_id,
   dev->dev_ops->tx_burst_mode_get(dev, queue_id, mode));
 }
 
+int
+rte_eth_get_wake_addr(uint16_t port_id, uint16_t queue_id,
+ volatile void **wake_addr,
+ uint64_t *expected, uint64_t *mask)
+{
+   struct rte_eth_dev *dev;
+   uint16_t ret;
+
+   RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
+
+   dev = &rte_eth_devices[port_id];
+
+   ret = (*dev->dev_ops->get_wake_addr)
+   (dev->data->rx_queues[queue_id],
+wake_addr, expected, mask);
+
+   return ret;
+}
+
 int
 rte_eth_dev_set_mc_addr_list(uint16_t port_id,
 struct rte_ether_addr *mc_addr_set,
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index d2bf74f128..a6cfe3cd57 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -4014,6 +4014,30 @@ __rte_experimental
 int rte_eth_tx_burst_mode_get(uint16_t port_id, uint16_t queue_id,
struct rte_eth_burst_mode *mode);
 
+/**
+ * Retrieve the wake up address from specific queue
+ *
+ * @param port_id
+ *   The port identifier of the Ethernet device.
+ * @param queue_id
+ *   The Tx queue on the Ethernet device for which information
+ *   will be retrieved.
+ * @param wake_addr
+ *   The pointer point to the address which is used for monitoring.
+ * @param expected
+ *   The pointer point to value to be expected when descriptor is set.
+ * @param mask
+ *   The pointer point to comparison bitmask for the expected value.
+ *
+ * @return
+ *   - 0: Success.
+ *   -EINVAL: Failed to get wake address.
+ */
+__rte_experimental
+int rte_eth_get_wake_addr(uint16_t port_id, uint16_t queue_id,
+ volatile void **wake_addr,
+ uint64_t *expected, uint64_t *mask);
+
 /**
  * Retrieve device registers and register attributes (number of registers and
  * register size)
diff --git a/lib/librte_ethdev/rte_ethdev_driver.h 
b/lib/librte_ethdev/rte_ethdev_driver.h
index c3062c246c..935d46f25c 100644
--- a/lib/librte_ethdev/rte_ethdev_driver.h
+++ b/lib/librte_ethdev/rte_ethdev_driver.h
@@ -574,6 +574,31 @@ typedef int (*eth_tx_hairpin_queue_setup_t)
 uint16_t nb_tx_desc,
 const struct rte_eth_hairpin_conf *hairpin_conf);
 
+/**
+ * @internal
+ * Get the Wake up address.
+ *
+ * @param rxq
+ *   Ethdev queue pointer.
+ * @param tail_desc_addr
+ *   The pointer point to descriptor address var.
+ * @param expected
+ *   The pointer point to value to be expected when descriptor is set.
+ * @param mask
+ *   The pointer point to comparison bitmask for the expected value.
+ * @return
+ *   Negative errno value on error, 0 on success.
+ *
+ * @retval 0
+ *   Success.
+ * @retval -EINVAL
+ *   Failed to get descriptor address.
+ */
+typedef int (*eth_get_wake_addr_t)
+   (void *rxq, volatile void **tail_desc_addr,
+uint64_t *expected, uint64_t *mask);
+
+
 /**
  * @internal A structure containing the functions exported by an Ethernet 
driver.
  */
@@ -713,6 +738,9 @@ struct eth_dev_ops {
/**< Set up device RX hairpin queue. */
eth_tx_hairpin_queue_setup_t tx_hairpin_queue_setup;
/**< Set up device TX hairpin queue. */
+   eth_get_wake_addr_t get_wake_addr;
+   /**< Get wake up address. */
+
 };
 
 /**
diff --git a/lib/librte_ethdev/rte_ethdev_version.map 
b/lib/librte_ethdev/rte_ethdev_version.map
index c95ef5157a..3cb2093980 100644
--- a/lib/librte_ethdev/rte_ethdev_version.map
+++ b/lib/librte_ethdev/rte_ethdev_version.map
@@ -229,6 +229,7 @@ EXPERIMENTAL {
# added in 20.11
rte_eth_link_speed_to_str;
rte_eth_link_to_str;
+   rte_eth_get_wake_addr;
 };
 
 INTERNAL {
-- 
2.17.1

[dpdk-dev] [PATCH v4 09/10] doc: update release notes for PMD power management

[Liang Ma]

Add release notes for PMD power management

Signed-off-by: Liang Ma 
---
 doc/guides/rel_notes/release_20_11.rst | 16 
 1 file changed, 16 insertions(+)

diff --git a/doc/guides/rel_notes/release_20_11.rst 
b/doc/guides/rel_notes/release_20_11.rst
index c2175f37f3..57ac73722a 100644
--- a/doc/guides/rel_notes/release_20_11.rst
+++ b/doc/guides/rel_notes/release_20_11.rst
@@ -55,6 +55,11 @@ New Features
  Also, make sure to start the actual text at the margin.
  ===
 
+* **ethdev: add 1 new EXPERIMENTAL API for PMD power management.**
+
+  * ``rte_eth_get_wake_addr()``
+  * add new eth_dev_ops ``get_wake_addr``
+
 * **Updated Broadcom bnxt driver.**
 
   Updated the Broadcom bnxt driver with new features and improvements, 
including:
@@ -107,6 +112,17 @@ New Features
   * Extern objects and functions can be plugged into the pipeline.
   * Transaction-oriented table updates.
 
+* **Add PMD power management mechanism**
+
+  3 new PMD power managmeent mechanism is added through existing
+  RX_ETH_CALLBACK infrastructure.
+
+  * Add umwait power saving scheme
+  * Add pause power saving scheme
+  * Add frequency scaling power saving scheme
+  * Add new EXPERIMENTAL API ``rte_power_pmd_mgmt_queue_enable()``
+  * Add new EXPERIMENTAL API ``rte_power_pmd_mgmt_queue_disable()``
+
 
 Removed Items
 -
-- 
2.17.1

Re: [dpdk-dev] [PATCH] net/netvsc: fix txq leak in error path

[Yunjian Wang]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Long Li
> Sent: Thursday, October 1, 2020 6:27 AM
> To: wangyunjian ; dev@dpdk.org
> Cc: Stephen Hemminger ; KY Srinivasan
> ; Haiyang Zhang ;
> jerry.lili...@huawei.com; xudin...@huawei.com; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/netvsc: fix txq leak in error path
> 
> >Subject: [dpdk-dev] [PATCH] net/netvsc: fix txq leak in error path
> >
> >From: Yunjian Wang 
> >
> >In hn_dev_tx_queue_setup() allocated memory for txq, we should free it
> >when error happens, otherwise it will lead to memory leak.
> >
> >Fixes: cc0251813277 ("net/netvsc: split send buffers from Tx
> >descriptors")
> >Cc: sta...@dpdk.org
> >
> >Signed-off-by: Yunjian Wang 
> >---
> > drivers/net/netvsc/hn_rxtx.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/net/netvsc/hn_rxtx.c
> >b/drivers/net/netvsc/hn_rxtx.c index 65f1abae5..8c94e7ee3 100644
> >--- a/drivers/net/netvsc/hn_rxtx.c
> >+++ b/drivers/net/netvsc/hn_rxtx.c
> >@@ -273,6 +273,7 @@ hn_dev_tx_queue_setup(struct rte_eth_dev *dev,
> >  " (tx_free_thresh=%u port=%u queue=%u)\n",
> >  nb_desc - 3,
> >  tx_free_thresh, dev->data->port_id, queue_idx);
> >+rte_free(txq);
> > return -EINVAL;
> > }
> >
> >--
> >2.23.0
> 
> How about checking for tx_free_thresh at the beginning of the function,
> before calling txq = rte_zmalloc_socket()?
> 
> This way, you don't' need to call rte_free() on error.

OK, I will fix it in next version.

Thanks,
Yunjian

> 
> Long

Re: [dpdk-dev] [PATCH] ethdev: add VLAN attributes to ETH and VLAN items

[Thomas Monjalon]

02/10/2020 14:39, Maxime Leroy:
> Hi Dekel,
> 
> On Thu, Oct 1, 2020 at 8:49 PM Dekel Peled  wrote:
> >
> > From: Dekel Peled 
> >
> > This patch implements the change proposes in RFC [1], adding dedicated
> > fields to ETH and VLAN items structs, to clearly define the required
> > characteristic of a packet, and enable precise match criteria.

Please add more explanations, without relying on what is in RFC.
We need to clearly understand the motivation and why
this implementation is chosen.

If you correctly thread your patch with previous ones,
it should not be needed to mention RFC.

> >
> > [1] https://mails.dpdk.org/archives/dev/2020-August/177536.html
> >
> > Signed-off-by: Dekel Peled 
> 
> I am still wondering, why not using a new item 'NOT' for example to
> match only eth packet not tagged ?
> example: eth / not vlan. It's a more generic solution.
> 
> Here in this commit, we add a reference on VLAN fields on ethernet header.
> But tomorrow, we could do the same for mpls by adding mpls_exists in
> the eth item and so on.
> 
> In fact, we  have the same needs for IPv6 options. To match for
> example, ipv6 packet with no fragment option.
> With a NOT field, it can be easily done: > eth / ipv6 / no ipv6_frag.
> 
> Adding new fields 'item'_exists into eth and ipv6 do the jobs, but
> having a NOT attribute is a more generic solution.
> 
> It could address many other use cases like matching any udp packets
> that are not vxlan ( eth / ipv4 / vxlan / not udp),
> 
> Let me know what you think about that.

You're right Maxime, a NOT operator looks better for the user,
but it is expected to be very hard to implement and offload.

Re: [dpdk-dev] [PATCH v4 01/10] eal: add new x86 cpuid support for WAITPKG

[Bruce Richardson]

On Fri, Oct 02, 2020 at 03:11:50PM +0100, Liang Ma wrote:
> Add new x86 cpuid support for WAITPKG.
> This flag indicate processor support umwait/umonitor/tpause
> instruction.
> 
> Signed-off-by: Liang Ma 
> Signed-off-by: Anatoly Burakov 
> ---
>  lib/librte_eal/x86/include/rte_cpuflags.h | 2 ++
>  lib/librte_eal/x86/rte_cpuflags.c | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/lib/librte_eal/x86/include/rte_cpuflags.h 
> b/lib/librte_eal/x86/include/rte_cpuflags.h
> index c1d20364d1..5041a830a7 100644
> --- a/lib/librte_eal/x86/include/rte_cpuflags.h
> +++ b/lib/librte_eal/x86/include/rte_cpuflags.h
> @@ -132,6 +132,8 @@ enum rte_cpu_flag_t {
>   RTE_CPUFLAG_MOVDIR64B,  /**< Direct Store Instructions 64B 
> */
>   RTE_CPUFLAG_AVX512VP2INTERSECT, /**< AVX512 Two Register 
> Intersection */
>  
> + /**< UMWAIT/TPAUSE Instructions */
> + RTE_CPUFLAG_WAITPKG,/**< UMINITOR/UMWAIT/TPAUSE */
Typo: UMINITOR

>   /* The last item */
>   RTE_CPUFLAG_NUMFLAGS,   /**< This should always be the 
> last! */
>  };
> diff --git a/lib/librte_eal/x86/rte_cpuflags.c 
> b/lib/librte_eal/x86/rte_cpuflags.c
> index 30439e7951..0325c4b93b 100644
> --- a/lib/librte_eal/x86/rte_cpuflags.c
> +++ b/lib/librte_eal/x86/rte_cpuflags.c
> @@ -110,6 +110,8 @@ const struct feature_entry rte_cpu_feature_table[] = {
>   FEAT_DEF(AVX512F, 0x0007, 0, RTE_REG_EBX, 16)
>   FEAT_DEF(RDSEED, 0x0007, 0, RTE_REG_EBX, 18)
>  
> + FEAT_DEF(WAITPKG, 0x0007, 0, RTE_REG_ECX, 5)
> +
>   FEAT_DEF(LAHF_SAHF, 0x8001, 0, RTE_REG_ECX,  0)
>   FEAT_DEF(LZCNT, 0x8001, 0, RTE_REG_ECX,  4)
>  
> -- 
> 2.17.1
> 

Re: [dpdk-dev] [PATCH v5 15/20] doc: remove references to make from rawdevs guides

[Xu, Rosen]

Hi,

> -Original Message-
> From: Power, Ciara 
> Sent: Monday, September 21, 2020 21:59
> To: dev@dpdk.org
> Cc: Power, Ciara ; Nipun Gupta
> ; Mcnamara, John ;
> Kovacevic, Marko ; Xu, Rosen
> ; Zhang, Tianfei ;
> Richardson, Bruce ; Li, Xiaoyun
> ; Wu, Jingjing ; Satha Rao
> ; Mahipal Challa 
> Subject: [PATCH v5 15/20] doc: remove references to make from rawdevs
> guides
> 
> Make is no longer supported for compiling DPDK, references are now
> removed in the documentation.
> 
> Signed-off-by: Ciara Power 
> Reviewed-by: Kevin Laatz 
> ---
>  doc/guides/rawdevs/dpaa2_cmdif.rst   | 21 -
>  doc/guides/rawdevs/dpaa2_qdma.rst| 21 -
>  doc/guides/rawdevs/ifpga.rst | 10 --
>  doc/guides/rawdevs/ioat.rst  |  8 +---
>  doc/guides/rawdevs/ntb.rst   |  6 --
>  doc/guides/rawdevs/octeontx2_dma.rst | 12 
> doc/guides/rawdevs/octeontx2_ep.rst  |  8 
>  7 files changed, 1 insertion(+), 85 deletions(-)
> 
> diff --git a/doc/guides/rawdevs/dpaa2_cmdif.rst
> b/doc/guides/rawdevs/dpaa2_cmdif.rst
> index be9805874b..7ac3963938 100644
> --- a/doc/guides/rawdevs/dpaa2_cmdif.rst
> +++ b/doc/guides/rawdevs/dpaa2_cmdif.rst
> @@ -44,17 +44,6 @@ Currently supported by DPDK:
> Some part of fslmc bus code (mc flib - object library) routines are
> dual licensed (BSD & GPLv2).
> 
> -Pre-Installation Configuration
> ---
> -
> -Config File Options
> -~~~
> -
> -The following options can be modified in the ``config`` file.
> -
> -- ``CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV`` (default ``y``)
> -
> -  Toggle compilation of the ``lrte_pmd_dpaa2_cmdif`` driver.
> 
>  Enabling logs
>  -
> @@ -68,16 +57,6 @@ For enabling logs, use the following EAL parameter:
>  Using ``pmd.raw.dpaa2.cmdif`` as log matching criteria, all Event PMD logs
> can be  enabled which are lower than logging ``level``.
> 
> -Driver Compilation
> -~~
> -
> -To compile the DPAA2 CMDIF PMD for Linux arm64 gcc target, run the -
> following ``make`` command:
> -
> -.. code-block:: console
> -
> -   cd 
> -   make config T=arm64-dpaa-linux-gcc install
> 
>  Initialization
>  --
> diff --git a/doc/guides/rawdevs/dpaa2_qdma.rst
> b/doc/guides/rawdevs/dpaa2_qdma.rst
> index 129e83d5ef..92921fafdd 100644
> --- a/doc/guides/rawdevs/dpaa2_qdma.rst
> +++ b/doc/guides/rawdevs/dpaa2_qdma.rst
> @@ -48,17 +48,6 @@ Currently supported by DPDK:
> Some part of fslmc bus code (mc flib - object library) routines are
> dual licensed (BSD & GPLv2).
> 
> -Pre-Installation Configuration
> ---
> -
> -Config File Options
> -~~~
> -
> -The following options can be modified in the ``config`` file.
> -
> -- ``CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV`` (default ``y``)
> -
> -  Toggle compilation of the ``lrte_pmd_dpaa2_qdma`` driver.
> 
>  Enabling logs
>  -
> @@ -72,16 +61,6 @@ For enabling logs, use the following EAL parameter:
>  Using ``pmd.raw.dpaa2.qdma`` as log matching criteria, all Event PMD logs
> can be  enabled which are lower than logging ``level``.
> 
> -Driver Compilation
> -~~
> -
> -To compile the DPAA2 QDMA PMD for Linux arm64 gcc target, run the -
> following ``make`` command:
> -
> -.. code-block:: console
> -
> -   cd 
> -   make config T=arm64-dpaa-linux-gcc install
> 
>  Initialization
>  --
> diff --git a/doc/guides/rawdevs/ifpga.rst b/doc/guides/rawdevs/ifpga.rst
> index a3d92a62ea..dbd0d6e37d 100644
> --- a/doc/guides/rawdevs/ifpga.rst
> +++ b/doc/guides/rawdevs/ifpga.rst
> @@ -76,16 +76,6 @@ summarized by the following block diagram::
>   |vdev_ifpga_cfg driver   ||  Intel FpgaDev  |
>   +++-+
> 
> -Build options
> --
> -
> -- ``CONFIG_RTE_LIBRTE_IFPGA_BUS`` (default ``y``)
> -
> -   Toggle compilation of IFPGA Bus library.
> -
> -- ``CONFIG_RTE_LIBRTE_IFPGA_RAWDEV`` (default ``y``)
> -
> -   Toggle compilation of the ``ifpga_rawdev`` driver.
> 
>  Run-time parameters
>  ---
> diff --git a/doc/guides/rawdevs/ioat.rst b/doc/guides/rawdevs/ioat.rst index
> c46460ff45..b1b10c7fad 100644
> --- a/doc/guides/rawdevs/ioat.rst
> +++ b/doc/guides/rawdevs/ioat.rst
> @@ -54,13 +54,7 @@ shows:
>  Compilation
>  
> 
> -For builds done with ``make``, the driver compilation is enabled by the -
> ``CONFIG_RTE_LIBRTE_PMD_IOAT_RAWDEV`` build configuration option.
> This is -enabled by default in builds for x86 platforms, and disabled in 
> other -
> configurations.
> -
> -For builds using ``meson`` and ``ninja``, the driver will be built when the -
> target platform is x86-based.
> +The driver will be built when the target platform is x86-based.
> 
>  Device Setup
>  -
> diff --git a/doc/guides/rawdevs/ntb.rst b/doc/guides/rawdevs/ntb.rst index
> aa7d809649..0589

Re: [dpdk-dev] [PATCH] maintainers: New Reviewer entry type added to MAINTAINERS

[Tom Rix]

On 10/1/20 2:54 PM, Thomas Monjalon wrote:
> 01/10/2020 23:22, Chautru, Nicolas:
>> From: t...@redhat.com 
>>> From: Tom Rix 
>>>
>>> Copied from the Linux kernel MAINTAINERS file.
>>> A Reviewer is designated person who wishes to review changes in areas of
>>> interest.
>>>
>>> Added self as Reviewer for baseband.
>>>
>>> I am a Linux kernel Reviewer for the fpga n3000/vista creek which has
>>> several bitstream based baseband devices.  So I want to help out here as
>>> well.
>>>
>>> Signed-off-by: Tom Rix 
>> Thanks for the help. 
>> Note that they are a few other BBDEV patches in flight for 20.11 on top of 
>> the acc100 PMD that you may want to be aware of. 
>> https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=
>>
>> Acked-by: Nicolas Chautru 
> [...]
>>>  Baseband API - EXPERIMENTAL
>>>  M: Nicolas Chautru 
>>> +R: Tom Rix 
> I don't understand the need of differenciating maintainer and reviewer.
> If you are trusted enough, why not just being co-maintainer?
>
I want to help out with the reviews, the reviewer type makes clear this level 
of commitment.

Maintainer is the next, higher level of commitment.


Trust wise, this would allow the maintainer verify the reviewer does have the 
bandwidth to be responsive

and effective before committing to sharing responsibility.

Tom

>

Re: [dpdk-dev] [PATCH v3 1/2] net: add run-time architecture specific CRC selection

[Singh, Jasvinder]

> -Original Message-
> From: O'loingsigh, Mairtin 
> Sent: Tuesday, September 29, 2020 4:36 PM
> To: Singh, Jasvinder ; Richardson, Bruce
> ; De Lara Guarch, Pablo
> 
> Cc: dev@dpdk.org; Ryan, Brendan ; Coyle, David
> ; O'loingsigh, Mairtin
> 
> Subject: [PATCH v3 1/2] net: add run-time architecture specific CRC selection
> 
> This patch adds support for run-time selection of the optimal architecture-
> specific CRC path, based on the supported instruction set(s) of the CPU.
> 
> The compiler option checks have been moved from the C files to the meson
> script. The rte_cpu_get_flag_enabled function is called automatically by the
> library at process initialization time to determine which instructions the CPU
> supports, with the most optimal supported CRC path ultimately selected.
> 
> Signed-off-by: Mairtin o Loingsigh 
> Signed-off-by: David Coyle 
> ---
>  doc/guides/rel_notes/release_20_11.rst|  4 ++
>  lib/librte_net/meson.build| 34 +++-
>  lib/librte_net/net_crc.h  | 34 
>  lib/librte_net/{net_crc_neon.h => net_crc_neon.c} | 27 +++--
>  lib/librte_net/{net_crc_sse.h => net_crc_sse.c}   | 34 
>  lib/librte_net/rte_net_crc.c  | 67 
> ++-
>  6 files changed, 132 insertions(+), 68 deletions(-)  create mode 100644
> lib/librte_net/net_crc.h  rename lib/librte_net/{net_crc_neon.h =>
> net_crc_neon.c} (95%)  rename lib/librte_net/{net_crc_sse.h =>
> net_crc_sse.c} (94%)
> 
> diff --git a/doc/guides/rel_notes/release_20_11.rst
> b/doc/guides/rel_notes/release_20_11.rst
> index 4eb3224a7..6bd222dca 100644
> --- a/doc/guides/rel_notes/release_20_11.rst
> +++ b/doc/guides/rel_notes/release_20_11.rst
> @@ -55,6 +55,10 @@ New Features
>   Also, make sure to start the actual text at the margin.
>   ===




_t *data, uint32_t data_len);
> +
> +#endif /* _NET_CRC_H_ */
> diff --git a/lib/librte_net/net_crc_neon.h b/lib/librte_net/net_crc_neon.c
> similarity index 95% rename from lib/librte_net/net_crc_neon.h rename to
> lib/librte_net/net_crc_neon.c index 63fa1d4a1..b79684ec2 100644
> --- a/lib/librte_net/net_crc_neon.h
> +++ b/lib/librte_net/net_crc_neon.c
> @@ -1,18 +1,17 @@
>  /* SPDX-License-Identifier: BSD-3-Clause
>   * Copyright(c) 2017 Cavium, Inc
> + * Copyright(c) 2020 Intel Corporation
>   */

Could you please remove intel copyright as there is no change in this file? 

> -#ifndef _NET_CRC_NEON_H_
> -#define _NET_CRC_NEON_H_
> +#include 
> 
> +#include 
>  #include 
>  #include 
>  #include 
>  #include 
> 
> -#ifdef __cplusplus
> -extern "C" {
> -#endif
> +#include "net_crc.h"
> 
>  /** PMULL CRC computation context structure */  struct crc_pmull_ctx { @@
> -218,7 +217,7 @@ crc32_eth_calc_pmull(
>   return n;
>  }
> 
> -static inline void
> +void
>  rte_net_crc_neon_init(void)
>  {
>   /* Initialize CRC16 data */
> @@ -242,9 +241,8 @@ rte_net_crc_neon_init(void)
>   crc32_eth_pmull.rk7_rk8 = vld1q_u64(eth_k7_k8);  }
> 
> -static inline uint32_t
> -rte_crc16_ccitt_neon_handler(const uint8_t *data,
> - uint32_t data_len)
> +uint32_t
> +rte_crc16_ccitt_neon_handler(const uint8_t *data, uint32_t data_len)
>  {
>   return (uint16_t)~crc32_eth_calc_pmull(data,
>   data_len,
> @@ -252,18 +250,11 @@ rte_crc16_ccitt_neon_handler(const uint8_t *data,
>   &crc16_ccitt_pmull);
>  }
> 
> -static inline uint32_t
> -rte_crc32_eth_neon_handler(const uint8_t *data,
> - uint32_t data_len)
> +uint32_t
> +rte_crc32_eth_neon_handler(const uint8_t *data, uint32_t data_len)
>  {
>   return ~crc32_eth_calc_pmull(data,
>   data_len,
>   0xUL,
>   &crc32_eth_pmull);
>  }
> -
> -#ifdef __cplusplus
> -}
> -#endif
> -
> -#endif /* _NET_CRC_NEON_H_ */
> diff --git a/lib/librte_net/net_crc_sse.h b/lib/librte_net/net_crc_sse.c
> similarity index 94% rename from lib/librte_net/net_crc_sse.h rename to
> lib/librte_net/net_crc_sse.c index 1c7b7a548..053b54b39 100644
> --- a/lib/librte_net/net_crc_sse.h
> +++ b/lib/librte_net/net_crc_sse.c
> @@ -1,18 +1,16 @@
>  /* SPDX-License-Identifier: BSD-3-Clause
> - * Copyright(c) 2017 Intel Corporation
> + * Copyright(c) 2017-2020 Intel Corporation
>   */
> 
> -#ifndef _RTE_NET_CRC_SSE_H_
> -#define _RTE_NET_CRC_SSE_H_
> +#include 
> 
> +#include 
>  #include 
> +#include 
> 
> -#include 
> -#include 
> +#include "net_crc.h"
> 
> -#ifdef __cplusplus
> -extern "C" {
> -#endif
> +#include 
> 
>  /** PCLMULQDQ CRC computation context structure */  struct
> crc_pclmulqdq_ctx { @@ -259,8 +257,7 @@ crc32_eth_calc_pclmulqdq(
>   return n;
>  }
> 
> -
> -static inline void
> +void
>  rte_net_crc_sse42_init(void)
>  {
>   uint64_t k1, k2, k5, k6;
> @@ -303,12 +300,10 @@ rte_net_crc_sse42_init(void)
>* use other data types such as float, double, etc.
>*/
>   _mm_empty();
> -
>  }
> 

[dpdk-dev] [dpdk-dev v2 1/2] vhost: add backend type in driver start

[Fan Zhang]

This patch adds an internal driver start function with a newly
added backend type identifier as parameter. With this way
different built-in driver types (net, crypto) can be identified.

Signed-off-by: Fan Zhang 
---
 lib/librte_vhost/socket.c | 39 ---
 lib/librte_vhost/vhost_user.h |  8 +++
 2 files changed, 39 insertions(+), 8 deletions(-)

diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
index 0169d3648..a53e536ac 100644
--- a/lib/librte_vhost/socket.c
+++ b/lib/librte_vhost/socket.c
@@ -38,7 +38,7 @@ struct vhost_user_socket {
bool is_server;
bool reconnect;
bool iommu_support;
-   bool use_builtin_virtio_net;
+   enum virtio_backend_type backend_type;
bool extbuf;
bool linearbuf;
bool async_copy;
@@ -224,7 +224,9 @@ vhost_user_add_connection(int fd, struct vhost_user_socket 
*vsocket)
size = strnlen(vsocket->path, PATH_MAX);
vhost_set_ifname(vid, vsocket->path, size);
 
-   vhost_set_builtin_virtio_net(vid, vsocket->use_builtin_virtio_net);
+   vhost_set_builtin_virtio_net(vid,
+   vsocket->backend_type == VIRTIO_DEV_BUILTIN_NET ?
+   true : false);
 
vhost_attach_vdpa_device(vid, vsocket->vdpa_dev);
 
@@ -632,7 +634,7 @@ rte_vhost_driver_disable_features(const char *path, 
uint64_t features)
pthread_mutex_lock(&vhost_user.mutex);
vsocket = find_vhost_user_socket(path);
 
-   /* Note that use_builtin_virtio_net is not affected by this function
+   /* Note that backend type is not affected by this function
 * since callers may want to selectively disable features of the
 * built-in vhost net device backend.
 */
@@ -681,7 +683,8 @@ rte_vhost_driver_set_features(const char *path, uint64_t 
features)
/* Anyone setting feature bits is implementing their own vhost
 * device backend.
 */
-   vsocket->use_builtin_virtio_net = false;
+   if (vsocket->backend_type == VIRTIO_DEV_BUILTIN_NET)
+   vsocket->backend_type = VIRTIO_DEV_UNKNOWN;
}
pthread_mutex_unlock(&vhost_user.mutex);
 
@@ -899,7 +902,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
 * rte_vhost_driver_set_features(), which will overwrite following
 * two values.
 */
-   vsocket->use_builtin_virtio_net = true;
+   vsocket->backend_type = VIRTIO_DEV_BUILTIN_NET;
vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;
vsocket->features   = VIRTIO_NET_SUPPORTED_FEATURES;
vsocket->protocol_features  = VHOST_USER_PROTOCOL_FEATURES;
@@ -1117,10 +1120,17 @@ vhost_driver_callback_get(const char *path)
 }
 
 int
-rte_vhost_driver_start(const char *path)
+vhost_driver_start(const char *path, enum virtio_backend_type backend_type)
 {
struct vhost_user_socket *vsocket;
static pthread_t fdset_tid;
+   int ret;
+
+   if (backend_type <= VIRTIO_DEV_UNKNOWN ||
+   backend_type > VIRTIO_DEV_BUILTIN_CRYPTO) {
+   VHOST_LOG_CONFIG(ERR, "Wrong backend type\n");
+   return -1;
+   }
 
pthread_mutex_lock(&vhost_user.mutex);
vsocket = find_vhost_user_socket(path);
@@ -1153,7 +1163,20 @@ rte_vhost_driver_start(const char *path)
}
 
if (vsocket->is_server)
-   return vhost_user_start_server(vsocket);
+   ret = vhost_user_start_server(vsocket);
else
-   return vhost_user_start_client(vsocket);
+   ret = vhost_user_start_client(vsocket);
+
+   if (ret < 0)
+   return ret;
+
+   vsocket->backend_type = backend_type;
+
+   return 0;
+}
+
+int
+rte_vhost_driver_start(const char *path)
+{
+   return vhost_driver_start(path, VIRTIO_DEV_BUILTIN_NET);
 }
diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
index 16fe03f88..9f526e676 100644
--- a/lib/librte_vhost/vhost_user.h
+++ b/lib/librte_vhost/vhost_user.h
@@ -158,6 +158,12 @@ typedef struct VhostUserMsg {
 /* The version of the protocol we support */
 #define VHOST_USER_VERSION0x1
 
+/* virtio backend types */
+enum virtio_backend_type {
+   VIRTIO_DEV_UNKNOWN = 0, /* Likely external */
+   VIRTIO_DEV_BUILTIN_NET, /* Virtio-net device */
+   VIRTIO_DEV_BUILTIN_CRYPTO, /* Virtio-crypto device */
+};
 
 /* vhost_user.c */
 int vhost_user_msg_handler(int vid, int fd);
@@ -167,5 +173,7 @@ int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t 
iova, uint8_t perm);
 int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
int *fd_num);
 int send_fd_message(int sockfd, char *buf, int buflen, int *fds, int fd_num);
+int vhost_driver_start(const char *path,
+   enum virtio_backend_type backend_type);
 
 #endif
-- 
2.20.1

[dpdk-dev] [dpdk-dev v2 0/2] vhost/crypto: fix initialization

[Fan Zhang]

This patch fixes the problem that vhost crypto cannot be
initialized due to the different requirement between
built-in virtio-net and virtio-crypto. The fix includes
the following change:

- Added new internal enum type virtio_backend_type to
distinguish virtio-net, virtio-crypto, and external
device types.
- Added new API rte_vhost_crypto_driver_start to
distinguish between virtio-net and virtio-crypto built-in
drivers initialization.

v2:
- Removed socket.c setting vhost crypto features.
- Fixed incorrect feature flag.
- Rebased on top of latest master.

Fan Zhang (2):
  vhost: add backend type in driver start
  vhost/crypto: fix feature negotiation

 examples/vhost_crypto/main.c   |  3 +-
 lib/librte_vhost/rte_vhost_crypto.h| 12 
 lib/librte_vhost/rte_vhost_version.map |  1 +
 lib/librte_vhost/socket.c  | 39 +++-
 lib/librte_vhost/vhost_crypto.c| 41 +-
 lib/librte_vhost/vhost_user.h  |  8 +
 6 files changed, 81 insertions(+), 23 deletions(-)

-- 
2.20.1

[dpdk-dev] [dpdk-dev v2 2/2] vhost/crypto: fix feature negotiation

[Fan Zhang]

This patch fixes the feature negotiation for vhost crypto during
initialization. The patch uses the newly created driver start
function to inform the driver type with the fixed vhost features.
In addtion the patch provides a new API specifically used by
the application to start a vhost-crypto driver.

Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: roy.fan.zh...@intel.com

Signed-off-by: Fan Zhang 
---
 examples/vhost_crypto/main.c   |  3 +-
 lib/librte_vhost/rte_vhost_crypto.h| 12 
 lib/librte_vhost/rte_vhost_version.map |  1 +
 lib/librte_vhost/vhost_crypto.c| 41 +-
 4 files changed, 42 insertions(+), 15 deletions(-)

diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
index d78fd9b81..11ad49159 100644
--- a/examples/vhost_crypto/main.c
+++ b/examples/vhost_crypto/main.c
@@ -598,7 +598,8 @@ main(int argc, char *argv[])
rte_vhost_driver_callback_register(lo->socket_files[j],
&virtio_crypto_device_ops);
 
-   ret = rte_vhost_driver_start(lo->socket_files[j]);
+   ret = rte_vhost_crypto_driver_start(
+   lo->socket_files[j]);
if (ret < 0)  {
RTE_LOG(ERR, USER1, "failed to start vhost.\n");
goto error_exit;
diff --git a/lib/librte_vhost/rte_vhost_crypto.h 
b/lib/librte_vhost/rte_vhost_crypto.h
index b54d61db6..c809c46a2 100644
--- a/lib/librte_vhost/rte_vhost_crypto.h
+++ b/lib/librte_vhost/rte_vhost_crypto.h
@@ -20,6 +20,18 @@ enum rte_vhost_crypto_zero_copy {
RTE_VHOST_CRYPTO_MAX_ZERO_COPY_OPTIONS
 };
 
+/**
+ * Start vhost crypto driver
+ *
+ * @param path
+ *  The vhost-user socket file path
+ * @return
+ *  0 on success, -1 on failure
+ */
+__rte_experimental
+int
+rte_vhost_crypto_driver_start(const char *path);
+
 /**
  *  Create Vhost-crypto instance
  *
diff --git a/lib/librte_vhost/rte_vhost_version.map 
b/lib/librte_vhost/rte_vhost_version.map
index 55e98e557..9183d6f2f 100644
--- a/lib/librte_vhost/rte_vhost_version.map
+++ b/lib/librte_vhost/rte_vhost_version.map
@@ -55,6 +55,7 @@ EXPERIMENTAL {
rte_vhost_driver_get_protocol_features;
rte_vhost_driver_get_queue_num;
rte_vhost_crypto_create;
+   rte_vhost_crypto_driver_start;
rte_vhost_crypto_free;
rte_vhost_crypto_fetch_requests;
rte_vhost_crypto_finalize_requests;
diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
index e08f9c6d7..6195958d2 100644
--- a/lib/librte_vhost/vhost_crypto.c
+++ b/lib/librte_vhost/vhost_crypto.c
@@ -35,13 +35,12 @@
 #define VC_LOG_DBG(fmt, args...)
 #endif
 
-#define VIRTIO_CRYPTO_FEATURES ((1 << VIRTIO_F_NOTIFY_ON_EMPTY) |  \
-   (1 << VIRTIO_RING_F_INDIRECT_DESC) |\
-   (1 << VIRTIO_RING_F_EVENT_IDX) |\
-   (1 << VIRTIO_CRYPTO_SERVICE_CIPHER) |   \
-   (1 << VIRTIO_CRYPTO_SERVICE_MAC) |  \
-   (1 << VIRTIO_NET_F_CTRL_VQ) |   \
-   (1 << VHOST_USER_PROTOCOL_F_CONFIG))
+#define VIRTIO_CRYPTO_FEATURES ((1ULL << VIRTIO_F_NOTIFY_ON_EMPTY) |   \
+   (1ULL << VIRTIO_RING_F_INDIRECT_DESC) | \
+   (1ULL << VIRTIO_RING_F_EVENT_IDX) | \
+   (1ULL << VIRTIO_NET_F_CTRL_VQ) |\
+   (1ULL << VIRTIO_F_VERSION_1) |  \
+   (1ULL << VHOST_USER_F_PROTOCOL_FEATURES))
 
 #define IOVA_TO_VVA(t, r, a, l, p) \
((t)(uintptr_t)vhost_iova_to_vva(r->dev, r->vq, a, l, p))
@@ -1400,6 +1399,27 @@ vhost_crypto_complete_one_vm_requests(struct 
rte_crypto_op **ops,
return processed;
 }
 
+int
+rte_vhost_crypto_driver_start(const char *path)
+{
+   uint64_t protocol_features;
+   int ret;
+
+   ret = rte_vhost_driver_set_features(path, VIRTIO_CRYPTO_FEATURES);
+   if (ret)
+   return -1;
+
+   ret = rte_vhost_driver_get_protocol_features(path, &protocol_features);
+   if (ret)
+   return -1;
+   protocol_features |= (1ULL << VHOST_USER_PROTOCOL_F_CONFIG);
+   ret = rte_vhost_driver_set_protocol_features(path, protocol_features);
+   if (ret)
+   return -1;
+
+   return vhost_driver_start(path, VIRTIO_DEV_BUILTIN_CRYPTO);
+}
+
 int
 rte_vhost_crypto_create(int vid, uint8_t cryptodev_id,
struct rte_mempool *sess_pool,
@@ -1417,13 +1437,6 @@ rte_vhost_crypto_create(int vid, uint8_t cryptodev_id,
return -EINVAL;
}
 
-   ret = rte_vhost_driver_set_features(dev->ifname,
-   VIRTIO_CRYPTO_FEATURES);
-   if (ret < 0) {
-   VC_LOG_ERR("E

Re: [dpdk-dev] [PATCH] maintainers: New Reviewer entry type added to MAINTAINERS

[Thomas Monjalon]

02/10/2020 16:59, Tom Rix:
> 
> On 10/1/20 2:54 PM, Thomas Monjalon wrote:
> > 01/10/2020 23:22, Chautru, Nicolas:
> >> From: t...@redhat.com 
> >>> From: Tom Rix 
> >>>
> >>> Copied from the Linux kernel MAINTAINERS file.
> >>> A Reviewer is designated person who wishes to review changes in areas of
> >>> interest.
> >>>
> >>> Added self as Reviewer for baseband.
> >>>
> >>> I am a Linux kernel Reviewer for the fpga n3000/vista creek which has
> >>> several bitstream based baseband devices.  So I want to help out here as
> >>> well.
> >>>
> >>> Signed-off-by: Tom Rix 
> >> Thanks for the help. 
> >> Note that they are a few other BBDEV patches in flight for 20.11 on top of 
> >> the acc100 PMD that you may want to be aware of. 
> >> https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=
> >>
> >> Acked-by: Nicolas Chautru 
> > [...]
> >>>  Baseband API - EXPERIMENTAL
> >>>  M: Nicolas Chautru 
> >>> +R: Tom Rix 
> > I don't understand the need of differenciating maintainer and reviewer.
> > If you are trusted enough, why not just being co-maintainer?
> >
> I want to help out with the reviews, the reviewer type makes clear this level 
> of commitment.
> 
> Maintainer is the next, higher level of commitment.
> 
> 
> Trust wise, this would allow the maintainer verify the reviewer does have the 
> bandwidth to be responsive
> 
> and effective before committing to sharing responsibility.

Sorry I fail to understand.
My understanding is that you want to be Cc
but not committing for responsibility.
Would it be the same if you create a mail filter on your side?

This model is really not clear to me so I'm reluctant to add
such new category until I understand the benefit.

[dpdk-dev] [PATCH] doc: remove references to python 2

[Robin Jarry]

Python 2 support has now been dropped. Remove references to it in the
documentation.

Since all python scripts now have a proper shebang that calls python3,
execute the scripts directly without specifying the interpreter.

Sphinx version from most Linux distros is OK in 2020, do not encourage
people to break their system by installing with pip. Use the distros
official packages.

Signed-off-by: Robin Jarry 
---
 doc/guides/conf.py| 2 +-
 doc/guides/contributing/documentation.rst | 8 ++--
 doc/guides/howto/telemetry.rst| 2 +-
 doc/guides/nics/virtio.rst| 4 ++--
 doc/guides/rel_notes/deprecation.rst  | 4 ++--
 doc/guides/tools/testbbdev.rst| 2 +-
 6 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/doc/guides/conf.py b/doc/guides/conf.py
index ef550f68c056..270754b90131 100644
--- a/doc/guides/conf.py
+++ b/doc/guides/conf.py
@@ -22,7 +22,7 @@
 html_theme_path = [sphinx_rtd_theme.get_html_theme_path()]
 except:
 print('Install the sphinx ReadTheDocs theme for improved html 
documentation '
-  'layout: pip install sphinx_rtd_theme')
+  'layout: https://sphinx-rtd-theme.readthedocs.io/')
 pass
 
 project = 'Data Plane Development Kit'
diff --git a/doc/guides/contributing/documentation.rst 
b/doc/guides/contributing/documentation.rst
index 375ea64ba8ee..be985e6cf87a 100644
--- a/doc/guides/contributing/documentation.rst
+++ b/doc/guides/contributing/documentation.rst
@@ -164,14 +164,10 @@ For full support with figure and table captioning the 
latest version of Sphinx c
 .. code-block:: console
 
# Ubuntu/Debian.
-   sudo apt-get -y install python-pip
-   sudo pip install --upgrade sphinx
-   sudo pip install --upgrade sphinx_rtd_theme
+   sudo apt-get -y install python3-sphinx python3-sphinx-rtd-theme
 
# Red Hat/Fedora.
-   sudo dnf -y install python-pip
-   sudo pip install --upgrade sphinx
-   sudo pip install --upgrade sphinx_rtd_theme
+   sudo dnf -y install python3-sphinx python3-sphinx_rtd_theme
 
 For further information on getting started with Sphinx see the
 `Sphinx Getting Started 
`_.
diff --git a/doc/guides/howto/telemetry.rst b/doc/guides/howto/telemetry.rst
index e7b5434152de..cf73dc41ce6b 100644
--- a/doc/guides/howto/telemetry.rst
+++ b/doc/guides/howto/telemetry.rst
@@ -50,7 +50,7 @@ and query information using the telemetry client python 
script.
 
 #. Launch the telemetry client script::
 
-  python usertools/dpdk-telemetry.py
+  ./usertools/dpdk-telemetry.py
 
 #. When connected, the script displays the following, waiting for user input::
 
diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
index 33ce0c247e5f..4477c1c16088 100644
--- a/doc/guides/nics/virtio.rst
+++ b/doc/guides/nics/virtio.rst
@@ -154,7 +154,7 @@ Host2VM communication example
 modprobe uio
 echo 512 > 
/sys/devices/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages
 modprobe uio_pci_generic
-python usertools/dpdk-devbind.py -b uio_pci_generic 00:03.0
+./usertools/dpdk-devbind.py -b uio_pci_generic 00:03.0
 
 We use testpmd as the forwarding application in this example.
 
@@ -329,7 +329,7 @@ To support Rx interrupts,
 
 .. code-block:: console
 
-python usertools/dpdk-devbind.py -b vfio-pci 00:03.0
+./usertools/dpdk-devbind.py -b vfio-pci 00:03.0
 
 Example
 ~~~
diff --git a/doc/guides/rel_notes/deprecation.rst 
b/doc/guides/rel_notes/deprecation.rst
index 0be208edcad8..8080a28896ad 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -14,8 +14,8 @@ Deprecation Notices
 * meson: The minimum supported version of meson for configuring and building
   DPDK will be increased to v0.47.1 (from 0.41) from DPDK 19.05 onwards. For
   those users with a version earlier than 0.47.1, an updated copy of meson
-  can be got using the ``pip``, or ``pip3``, tool for downloading python
-  packages.
+  can be got using the ``pip3`` tool (or ``python3 -m pip``) for downloading
+  python packages.
 
 * kvargs: The function ``rte_kvargs_process`` will get a new parameter
   for returning key match count. It will ease handling of no-match case.
diff --git a/doc/guides/tools/testbbdev.rst b/doc/guides/tools/testbbdev.rst
index 393c3e9d0d24..99692314513f 100644
--- a/doc/guides/tools/testbbdev.rst
+++ b/doc/guides/tools/testbbdev.rst
@@ -43,7 +43,7 @@ The tool application has a number of command line options:
 
 .. code-block:: console
 
-  python test-bbdev.py [-h] [-p TESTAPP_PATH] [-e EAL_PARAMS] [-t TIMEOUT]
+test-bbdev.py [-h] [-p TESTAPP_PATH] [-e EAL_PARAMS] [-t TIMEOUT]
[-c TEST_CASE [TEST_CASE ...]]
[-v TEST_VECTOR [TEST_VECTOR...]] [-n NUM_OPS]
[-b BURST_SIZE [BURST_SIZE ...]] [-l NUM_LCORES]
-- 
2.28.0

Re: [dpdk-dev] [PATCH] doc: remove references to python 2

[Bruce Richardson]

On Fri, Oct 02, 2020 at 05:47:53PM +0200, Robin Jarry wrote:
> Python 2 support has now been dropped. Remove references to it in the
> documentation.
> 
> Since all python scripts now have a proper shebang that calls python3,
> execute the scripts directly without specifying the interpreter.
> 
> Sphinx version from most Linux distros is OK in 2020, do not encourage
> people to break their system by installing with pip. Use the distros
> official packages.
> 
> Signed-off-by: Robin Jarry 
> ---
>  doc/guides/conf.py| 2 +-
>  doc/guides/contributing/documentation.rst | 8 ++--
>  doc/guides/howto/telemetry.rst| 2 +-
>  doc/guides/nics/virtio.rst| 4 ++--
>  doc/guides/rel_notes/deprecation.rst  | 4 ++--
>  doc/guides/tools/testbbdev.rst| 2 +-
>  6 files changed, 9 insertions(+), 13 deletions(-)
> 
> diff --git a/doc/guides/conf.py b/doc/guides/conf.py
> index ef550f68c056..270754b90131 100644
> --- a/doc/guides/conf.py
> +++ b/doc/guides/conf.py
> @@ -22,7 +22,7 @@
>  html_theme_path = [sphinx_rtd_theme.get_html_theme_path()]
>  except:
>  print('Install the sphinx ReadTheDocs theme for improved html 
> documentation '
> -  'layout: pip install sphinx_rtd_theme')
> +  'layout: https://sphinx-rtd-theme.readthedocs.io/')
>  pass
>  
>  project = 'Data Plane Development Kit'
> diff --git a/doc/guides/contributing/documentation.rst 
> b/doc/guides/contributing/documentation.rst
> index 375ea64ba8ee..be985e6cf87a 100644
> --- a/doc/guides/contributing/documentation.rst
> +++ b/doc/guides/contributing/documentation.rst
> @@ -164,14 +164,10 @@ For full support with figure and table captioning the 
> latest version of Sphinx c
>  .. code-block:: console
>  
> # Ubuntu/Debian.
> -   sudo apt-get -y install python-pip
> -   sudo pip install --upgrade sphinx
> -   sudo pip install --upgrade sphinx_rtd_theme
> +   sudo apt-get -y install python3-sphinx python3-sphinx-rtd-theme
>  
> # Red Hat/Fedora.
> -   sudo dnf -y install python-pip
> -   sudo pip install --upgrade sphinx
> -   sudo pip install --upgrade sphinx_rtd_theme
> +   sudo dnf -y install python3-sphinx python3-sphinx_rtd_theme

Minor nit, I see no reason to preserve the big whitespace gap here.

>  
>  For further information on getting started with Sphinx see the
>  `Sphinx Getting Started 
> `_.
> diff --git a/doc/guides/howto/telemetry.rst b/doc/guides/howto/telemetry.rst
> index e7b5434152de..cf73dc41ce6b 100644
> --- a/doc/guides/howto/telemetry.rst
> +++ b/doc/guides/howto/telemetry.rst
> @@ -50,7 +50,7 @@ and query information using the telemetry client python 
> script.
>  
>  #. Launch the telemetry client script::
>  
> -  python usertools/dpdk-telemetry.py
> +  ./usertools/dpdk-telemetry.py
>  
>  #. When connected, the script displays the following, waiting for user 
> input::
>  
> diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
> index 33ce0c247e5f..4477c1c16088 100644
> --- a/doc/guides/nics/virtio.rst
> +++ b/doc/guides/nics/virtio.rst
> @@ -154,7 +154,7 @@ Host2VM communication example
>  modprobe uio
>  echo 512 > 
> /sys/devices/system/node/node0/hugepages/hugepages-2048kB/nr_hugepages
>  modprobe uio_pci_generic
> -python usertools/dpdk-devbind.py -b uio_pci_generic 00:03.0
> +./usertools/dpdk-devbind.py -b uio_pci_generic 00:03.0
>  
>  We use testpmd as the forwarding application in this example.
>  
> @@ -329,7 +329,7 @@ To support Rx interrupts,
>  
>  .. code-block:: console
>  
> -python usertools/dpdk-devbind.py -b vfio-pci 00:03.0
> +./usertools/dpdk-devbind.py -b vfio-pci 00:03.0
>  
>  Example
>  ~~~
> diff --git a/doc/guides/rel_notes/deprecation.rst 
> b/doc/guides/rel_notes/deprecation.rst
> index 0be208edcad8..8080a28896ad 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -14,8 +14,8 @@ Deprecation Notices
>  * meson: The minimum supported version of meson for configuring and building
>DPDK will be increased to v0.47.1 (from 0.41) from DPDK 19.05 onwards. For
>those users with a version earlier than 0.47.1, an updated copy of meson
> -  can be got using the ``pip``, or ``pip3``, tool for downloading python
> -  packages.
> +  can be got using the ``pip3`` tool (or ``python3 -m pip``) for downloading
> +  python packages.
>  
>  * kvargs: The function ``rte_kvargs_process`` will get a new parameter
>for returning key match count. It will ease handling of no-match case.
> diff --git a/doc/guides/tools/testbbdev.rst b/doc/guides/tools/testbbdev.rst
> index 393c3e9d0d24..99692314513f 100644
> --- a/doc/guides/tools/testbbdev.rst
> +++ b/doc/guides/tools/testbbdev.rst
> @@ -43,7 +43,7 @@ The tool application has a number of command line options:
>  
>  .. code-block:: console
>  
> -  python test-bbd

Re: [dpdk-dev] [PATCH] doc: remove references to python 2

[Robin Jarry]

2020-10-02, Bruce Richardson:
> > +   sudo dnf -y install python3-sphinx python3-sphinx_rtd_theme
> 
> Minor nit, I see no reason to preserve the big whitespace gap here.

I thought about removing it but all the file is like this. I left it
as-is for consistency.

-- 
Robin

[dpdk-dev] [RFC PATCH v2 0/8] Rework build macros

[Bruce Richardson]

Following on from discussion in v1 of this RFC, this second RFC looks to
completely rework the automated macros defined by meson to indicate a
particular library or driver is enabled in the build. However, while it
does so, it also maintains compatibility with previous releases to ease the
transition for any apps using the older macros, which already has to
contend with a change in DPDK build-system and to switch over to picking up
the library names from pkg-config.

[For completeness though, a draft 21.02 patch removing those backward
compatibility macros is included in the set, done while the work is fresh
in my mind. :-)]

Advantages of this rework:
* Much cleaner having standard macros
* No need for defining the format of macros for each class
* Shorter macros (for the most part)

Disadvantages:
* Potentially requires application changes
* Inconsistency between the auto-defined macros and the other feature-set
  ones.

Bruce Richardson (8):
  app: fix missing dependencies
  examples/l2fwd-crypto: fix missing dependency
  build: add defines for compatibility with make build
  qat: build from common folder
  build: remove library name from version map filename
  build: standardize component names and defines
  build: replace use of old build macros
  [v21.02] build: remove compatibility build defines

 app/proc-info/main.c  |   4 +-
 app/test-bbdev/meson.build|   8 +-
 app/test-bbdev/test_bbdev_perf.c  |   8 +-
 app/test-crypto-perf/cperf_ops.c  |   6 +-
 app/test-crypto-perf/cperf_options.h  |   6 +-
 app/test-crypto-perf/cperf_options_parsing.c  |  16 +-
 .../cperf_test_pmd_cyclecount.c   |   2 +-
 app/test-crypto-perf/cperf_test_throughput.c  |   2 +-
 app/test-crypto-perf/main.c   |   6 +-
 app/test-crypto-perf/meson.build  |   3 +
 app/test-pipeline/main.c  |   2 +-
 app/test-pmd/bpf_cmd.h|   4 +-
 app/test-pmd/cmdline.c| 190 +-
 app/test-pmd/config.c |  18 +-
 app/test-pmd/meson.build  |  34 +++-
 app/test-pmd/parameters.c |  30 +--
 app/test-pmd/testpmd.c|  38 ++--
 app/test-pmd/testpmd.h|   4 +-
 app/test/meson.build  |  33 +--
 app/test/process.h|  16 +-
 app/test/test.c   |  20 +-
 app/test/test_cryptodev.c |  26 +--
 app/test/test_cryptodev_hash_test_vectors.h   |   2 +-
 app/test/test_eal_flags.c |   4 +-
 app/test/test_func_reentrancy.c   |  24 +--
 app/test/test_kni.c   |   2 +-
 app/test/test_mp_secondary.c  |  12 +-
 app/test/test_power.c |   2 +-
 app/test/test_power_cpufreq.c |   2 +-
 app/test/test_power_kvm_vm.c  |   2 +-
 app/test/test_table.c |   2 +-
 app/test/test_table.h |   2 +-
 app/test/test_table_combined.h|   2 +-
 app/test/test_table_tables.h  |   2 +-
 config/arm/meson.build|   6 +-
 config/meson.build|   3 +-
 doc/guides/rel_notes/deprecation.rst  |   8 +
 ..._fpga_5gnr_fec_version.map => version.map} |   0
 ...v_fpga_lte_fec_version.map => version.map} |   0
 drivers/baseband/meson.build  |   3 -
 ...pmd_bbdev_null_version.map => version.map} |   0
 ...bbdev_turbo_sw_version.map => version.map} |   0
 .../{rte_bus_dpaa_version.map => version.map} |   0
 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c  |   6 +-
 ...{rte_bus_fslmc_version.map => version.map} |   0
 ...{rte_bus_ifpga_version.map => version.map} |   0
 drivers/bus/meson.build   |   2 -
 .../{rte_bus_pci_version.map => version.map}  |   0
 .../{rte_bus_vdev_version.map => version.map} |   0
 ...{rte_bus_vmbus_version.map => version.map} |   0
 ...rte_common_cpt_version.map => version.map} |   0
 ...e_common_dpaax_version.map => version.map} |   0
 ...te_common_iavf_version.map => version.map} |   0
 drivers/common/meson.build|   4 +-
 drivers/common/mlx5/meson.build   |   1 -
 ...te_common_mlx5_version.map => version.map} |   0
 ...te_common_mvep_version.map => version.map} |   0
 ...ommon_octeontx_version.map => version.map} |   0
 ...mmon_octeontx2_version.map => version.map} |   0
 drivers/common/qat/meson.build|  68 ++-
 .../qat/version.map}  |   0
 ...common_sfc_efx_version.map => version.map} |   0
 .../version.map}  |   0
 drivers/compress/meson.build  |   4 +-
 drivers/compress/octeontx/meson.build |   1 -
 .../version.map}  |   0
 drivers/compress/

[dpdk-dev] [RFC PATCH v2 1/8] app: fix missing dependencies

[Bruce Richardson]

A number of lib and driver dependencies for various apps were missed on
build because the proper macro names for their use were mismatched between
meson and make build systems. Before adding in equivalent compatibility
macros we need to ensure to add the proper dependencies to ensure a valid
build.

Fixes: 16ade738fd0d ("app/testpmd: build with meson")
Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test")
Fixes: 996ef1176111 ("app: add all remaining apps to meson build")
Cc: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 app/test-crypto-perf/meson.build |  3 +++
 app/test-pmd/meson.build | 12 
 app/test/meson.build |  3 +++
 3 files changed, 18 insertions(+)

diff --git a/app/test-crypto-perf/meson.build b/app/test-crypto-perf/meson.build
index f394b75ba5..4bd71510dc 100644
--- a/app/test-crypto-perf/meson.build
+++ b/app/test-crypto-perf/meson.build
@@ -12,3 +12,6 @@ sources = files('cperf_ops.c',
'cperf_test_verify.c',
'main.c')
 deps += ['cryptodev', 'net', 'security']
+if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
+   deps += 'pmd_crypto_scheduler'
+endif
diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
index f52ab148f6..0d9e450494 100644
--- a/app/test-pmd/meson.build
+++ b/app/test-pmd/meson.build
@@ -31,6 +31,18 @@ endif
 if dpdk_conf.has('RTE_LIBRTE_PDUMP')
deps += 'pdump'
 endif
+if dpdk_conf.has('RTE_LIBRTE_BITRATESTATS')
+   deps += 'bitratestats'
+endif
+if dpdk_conf.has('RTE_LIBRTE_LATENCYSTATS')
+   deps += 'latencystats'
+endif
+if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
+   deps += 'pmd_crypto_scheduler'
+endif
+if dpdk_conf.has('RTE_LIBRTE_BOND_PMD')
+   deps += 'pmd_bond'
+endif
 if dpdk_conf.has('RTE_LIBRTE_BNXT_PMD')
deps += 'pmd_bnxt'
 endif
diff --git a/app/test/meson.build b/app/test/meson.build
index 181e870290..781555f9de 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -346,6 +346,9 @@ endif
 if dpdk_conf.has('RTE_LIBRTE_SKELETON_EVENTDEV_PMD')
test_deps += 'pmd_skeleton_event'
 endif
+if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
+   test_deps += 'pmd_crypto_scheduler'
+endif
 if dpdk_conf.has('RTE_LIBRTE_TELEMETRY')
test_sources += 'test_telemetry_json.c'
fast_tests += [['telemetry_json_autotest', true]]
-- 
2.25.1

[dpdk-dev] [RFC PATCH v2 3/8] build: add defines for compatibility with make build

[Bruce Richardson]

The defines used to indicate what crypto, compression and eventdev drivers
were being built were different to those used in the make build, with meson
defining them with "_PMD" at the end, while make defined them with "_PMD"
in the middle and the specific driver name at the end. This might cause
compatibility issues for applications which used the older defines, which
switching to build against new DPDK releases.

As well as changing the default to match that of make, meson also
special-cases the crypto/compression/event drivers to have both defines
provided. This ensures compatibility for these macros with both meson and
make from older versions.

For a selection of other libraries and drivers, there were other
incompatibilities between the meson and make-defined macros which were not
previously highlighted in a deprecation notice, so we add per-macro
compatibility defines for these to ease the transition from make to meson.

Fixes: 5b9656b157d3 ("lib: build with meson")
Fixes: 9314afb68a53 ("drivers: add infrastructure for meson build")
Fixes: dcadbbde8e61 ("crypto/null: build with meson")
Fixes: 3c32e89f68e1 ("compress/isal: add skeleton ISA-L compression PMD")
Fixes: eca504f318db ("drivers/event: build skeleton and SW drivers with meson")

Cc: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 config/meson.build |   3 +-
 config/rte_compatibility_defines.h | 129 +
 config/rte_config.h|   1 +
 drivers/compress/meson.build   |   2 +-
 drivers/crypto/meson.build |   2 +-
 drivers/event/meson.build  |   2 +-
 drivers/meson.build|  15 
 7 files changed, 150 insertions(+), 4 deletions(-)
 create mode 100644 config/rte_compatibility_defines.h

diff --git a/config/meson.build b/config/meson.build
index 69f2aeb605..3a36d9dd4c 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -254,7 +254,8 @@ dpdk_conf.set('RTE_COMPILE_TIME_CPUFLAGS', 
','.join(compile_time_cpuflags))
 # set the install path for the drivers
 dpdk_conf.set_quoted('RTE_EAL_PMD_PATH', eal_pmd_path)
 
-install_headers('rte_config.h', subdir: get_option('include_subdir_arch'))
+install_headers(['rte_config.h', 'rte_compatibility_defines.h'],
+   subdir: get_option('include_subdir_arch'))
 
 # enable VFIO only if it is linux OS
 dpdk_conf.set('RTE_EAL_VFIO', is_linux)
diff --git a/config/rte_compatibility_defines.h 
b/config/rte_compatibility_defines.h
new file mode 100644
index 00..47600052b6
--- /dev/null
+++ b/config/rte_compatibility_defines.h
@@ -0,0 +1,129 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2017 Intel Corporation
+ */
+
+#ifndef _RTE_CONFIG_H_
+#error "This file should only be included via rte_config.h"
+#endif
+
+/*
+ * NOTE: these defines are for compatibility only and will be removed in a
+ * future DPDK release.
+ */
+
+#ifdef RTE_LIBRTE_BITRATESTATS
+#define RTE_LIBRTE_BITRATE
+#endif
+
+#ifdef RTE_LIBRTE_LATENCYSTATS
+#define RTE_LIBRTE_LATENCY_STATS
+#endif
+
+#ifdef RTE_LIBRTE_DPAAX_COMMON
+#define RTE_LIBRTE_COMMON_DPAAX
+#endif
+
+#ifdef RTE_LIBRTE_VMBUS_BUS
+#define RTE_LIBRTE_VMBUS
+#endif
+
+#ifdef RTE_LIBRTE_BUCKET_MEMPOOL
+#define RTE_DRIVER_MEMPOOL_BUCKET
+#endif
+
+#ifdef RTE_LIBRTE_RING_MEMPOOL
+#define RTE_DRIVER_MEMPOOL_RING
+#endif
+
+#ifdef RTE_LIBRTE_STACK_MEMPOOL
+#define RTE_DRIVER_MEMPOOL_STACK
+#endif
+
+#ifdef RTE_LIBRTE_AF_PACKET_PMD
+#define RTE_LIBRTE_PMD_AF_PACKET
+#endif
+
+#ifdef RTE_LIBRTE_AF_XDP_PMD
+#define RTE_LIBRTE_PMD_AF_XDP
+#endif
+
+#ifdef RTE_LIBRTE_BOND_PMD
+#define RTE_LIBRTE_PMD_BOND
+#endif
+
+#ifdef RTE_LIBRTE_E1000_PMD
+#define RTE_LIBRTE_EM_PMD
+#endif
+
+#ifdef RTE_LIBRTE_E1000_PMD
+#define RTE_LIBRTE_IGB_PMD
+#endif
+
+#ifdef RTE_LIBRTE_FAILSAFE_PMD
+#define RTE_LIBRTE_PMD_FAILSAFE
+#endif
+
+#ifdef RTE_LIBRTE_KNI_PMD
+#define RTE_LIBRTE_PMD_KNI
+#endif
+
+#ifdef RTE_LIBRTE_LIQUIDIO_PMD
+#define RTE_LIBRTE_LIO_PMD
+#endif
+
+#ifdef RTE_LIBRTE_MEMIF_PMD
+#define RTE_LIBRTE_PMD_MEMIF
+#endif
+
+#ifdef RTE_LIBRTE_NULL_PMD
+#define RTE_LIBRTE_PMD_NULL
+#endif
+
+#ifdef RTE_LIBRTE_PCAP_PMD
+#define RTE_LIBRTE_PMD_PCAP
+#endif
+
+#ifdef RTE_LIBRTE_RING_PMD
+#define RTE_LIBRTE_PMD_RING
+#endif
+
+#ifdef RTE_LIBRTE_SFC_PMD
+#define RTE_LIBRTE_SFC_EFX_PMD
+#endif
+
+#ifdef RTE_LIBRTE_SOFTNIC_PMD
+#define RTE_LIBRTE_PMD_SOFTNIC
+#endif
+
+#ifdef RTE_LIBRTE_SZEDATA2_PMD
+#define RTE_LIBRTE_PMD_SZEDATA2
+#endif
+
+#ifdef RTE_LIBRTE_TAP_PMD
+#define RTE_LIBRTE_PMD_TAP
+#endif
+
+#ifdef RTE_LIBRTE_THUNDERX_PMD
+#define RTE_LIBRTE_THUNDERX_NICVF_PMD
+#endif
+
+#ifdef RTE_LIBRTE_VHOST_PMD
+#define RTE_LIBRTE_PMD_VHOST
+#endif
+
+#ifdef RTE_LIBRTE_PMD_ARMV8
+#define RTE_LIBRTE_PMD_ARMV8_CRYPTO
+#endif
+
+#ifdef RTE_LIBRTE_PMD_MVSAM
+#define RTE_LIBRTE_PMD_MVSAM_CRYPTO
+#endif
+
+#ifdef RTE_LIBRTE_PMD_OCTEONTX_COMPRESS
+#define RTE_LIBRTE_PMD_OCTEONTX_ZIPVF
+#endif
+
+#ifdef RTE_LIBRTE_PMD_OCTEONTX_EVENTDEV
+#define RTE_LIBRTE_PMD_OCTEONTX_SSOVF
+#endi

[dpdk-dev] [RFC PATCH v2 2/8] examples/l2fwd-crypto: fix missing dependency

[Bruce Richardson]

When the crypto-scheduler support is enabled, we were missing the
dependency on it as part of the meson build.

Fixes: 89f0711f9ddf ("examples: build some samples with meson")
Cc: sta...@dpdk.org

Signed-off-by: Bruce Richardson 
---
 examples/l2fwd-crypto/meson.build | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/l2fwd-crypto/meson.build 
b/examples/l2fwd-crypto/meson.build
index 6c852ad199..39e1604fac 100644
--- a/examples/l2fwd-crypto/meson.build
+++ b/examples/l2fwd-crypto/meson.build
@@ -7,6 +7,9 @@
 # DPDK instance, use 'make'
 
 deps += 'cryptodev'
+if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
+   deps += 'pmd_crypto_scheduler'
+endif
 allow_experimental_apis = true
 sources = files(
'main.c'
-- 
2.25.1

[dpdk-dev] [RFC PATCH v2 4/8] qat: build from common folder

[Bruce Richardson]

Since the drivers in the common directory can be processed out of order, in
this case following the "bus" directory, we can simplify somewhat the build
of the QAT driver to be done entirely from the "common/qat" folder rather
than having it's build distributed across 3 folders.

This also opens up the possibility of building the QAT driver with crypto
only and the compression part disabled. It further allows more sensible
naming of the resulting shared library in case of standardizing library
names based on device class; i.e. common_qat is more descriptive for a
combined crypto/compression driver than either of the other two prefixes
individually.

Signed-off-by: Bruce Richardson 
---
 drivers/common/meson.build|  2 +-
 drivers/common/qat/meson.build| 69 ---
 .../qat/rte_common_qat_version.map}   |  0
 drivers/compress/meson.build  |  2 +-
 drivers/compress/qat/meson.build  | 17 -
 drivers/crypto/meson.build|  1 -
 drivers/crypto/qat/meson.build| 23 ---
 drivers/meson.build   |  1 +
 8 files changed, 63 insertions(+), 52 deletions(-)
 rename drivers/{compress/qat/rte_pmd_qat_version.map => 
common/qat/rte_common_qat_version.map} (100%)
 delete mode 100644 drivers/compress/qat/meson.build
 delete mode 100644 drivers/crypto/qat/meson.build

diff --git a/drivers/common/meson.build b/drivers/common/meson.build
index 7ac1ca73a2..abb4f1529a 100644
--- a/drivers/common/meson.build
+++ b/drivers/common/meson.build
@@ -6,6 +6,6 @@ if is_windows
 endif
 
 std_deps = ['eal']
-drivers = ['cpt', 'dpaax', 'iavf', 'mvep', 'octeontx', 'octeontx2', 'qat', 
'sfc_efx']
+drivers = ['cpt', 'dpaax', 'iavf', 'mvep', 'octeontx', 'octeontx2', 'sfc_efx']
 config_flag_fmt = 'RTE_LIBRTE_@0@_COMMON'
 driver_name_fmt = 'rte_common_@0@'
diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build
index 8de2492893..3409162d03 100644
--- a/drivers/common/qat/meson.build
+++ b/drivers/common/qat/meson.build
@@ -1,15 +1,66 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2018 Intel Corporation
 
-# This does not build a driver, but instead holds common files for
-# the crypto and compression drivers.
-build = false
-reason = '' # sentinal value to suppress printout
-qat_deps = ['bus_pci']
-qat_sources = files('qat_common.c',
+config_flag_fmt = 'RTE_LIBRTE_@0@_COMMON'
+driver_name_fmt = 'rte_common_@0@'
+
+qat_crypto = true
+qat_crypto_path = 'crypto/qat'
+qat_crypto_relpath = '../../' + qat_crypto_path
+qat_compress = true
+qat_compress_path = 'compress/qat'
+qat_compress_relpath = '../../' + qat_compress_path
+
+if disabled_drivers.contains(qat_crypto_path)
+   qat_crypto = false
+   dpdk_drvs_disabled += qat_crypto_path
+   set_variable(qat_crypto_path.underscorify() + '_disable_reason',
+   'Explicitly disabled via build config')
+endif
+if disabled_drivers.contains(qat_compress_path)
+   qat_compress = false
+   dpdk_drvs_disabled += qat_compress_path
+   set_variable(qat_compress_path.underscorify() + '_disable_reason',
+   'Explicitly disabled via build config')
+endif
+
+libcrypto = dependency('libcrypto', required: false)
+if qat_crypto and not libcrypto.found()
+   qat_crypto = false
+   dpdk_drvs_disabled += qat_crypto_path
+   set_variable(qat_crypto_path.underscorify() + '_disable_reason',
+   'missing dependency, libcrypto')
+endif
+
+# The driver should not build if both compression and crypto are disabled
+#FIXME common code depends on compression files so check only compress!
+if not qat_compress # and not qat_crypto
+   build = false
+   reason = '' # rely on reason for compress/crypto above
+   subdir_done()
+endif
+
+deps += ['bus_pci', 'cryptodev', 'net', 'compressdev']
+sources += files('qat_common.c',
'qat_qp.c',
'qat_device.c',
'qat_logs.c')
-qat_includes = [include_directories('.', 'qat_adf')]
-qat_ext_deps = []
-qat_cflags = []
+includes += include_directories('qat_adf',
+   qat_crypto_relpath,
+   qat_compress_relpath)
+
+if qat_compress
+   foreach f: ['qat_comp_pmd.c', 'qat_comp.c']
+   sources += files(join_paths(qat_compress_relpath, f))
+   endforeach
+endif
+
+if qat_crypto
+   foreach f: ['qat_sym_pmd.c', 'qat_sym.c', 'qat_sym_session.c',
+   'qat_asym_pmd.c', 'qat_asym.c']
+   sources += files(join_paths(qat_crypto_relpath, f))
+   endforeach
+   deps += ['security']
+   ext_deps += libcrypto
+   cflags += ['-DBUILD_QAT_SYM', '-DBUILD_QAT_ASYM']
+endif
diff --git a/drivers/compress/qat/rte_pmd_qat_version.map 
b/drivers/common/qat/rte_common_qat_version.map
similarity index 100%
rename from drivers/compress/qat/rte_pmd_qat_version.map
rename to drivers/common/qat/rte_common_q

[dpdk-dev] [RFC PATCH v2 5/8] build: remove library name from version map filename

[Bruce Richardson]

Since each version map file is contained in the subdirectory of the library
it refers to, there is no need to include the library name in the filename.
This makes things simpler in case of library renaming.

Signed-off-by: Bruce Richardson 
---
 .../{rte_pmd_bbdev_fpga_5gnr_fec_version.map => version.map}  | 0
 .../{rte_pmd_bbdev_fpga_lte_fec_version.map => version.map}   | 0
 .../null/{rte_pmd_bbdev_null_version.map => version.map}  | 0
 .../{rte_pmd_bbdev_turbo_sw_version.map => version.map}   | 0
 drivers/bus/dpaa/{rte_bus_dpaa_version.map => version.map}| 0
 drivers/bus/fslmc/{rte_bus_fslmc_version.map => version.map}  | 0
 drivers/bus/ifpga/{rte_bus_ifpga_version.map => version.map}  | 0
 drivers/bus/pci/{rte_bus_pci_version.map => version.map}  | 0
 drivers/bus/vdev/{rte_bus_vdev_version.map => version.map}| 0
 drivers/bus/vmbus/{rte_bus_vmbus_version.map => version.map}  | 0
 .../common/cpt/{rte_common_cpt_version.map => version.map}| 0
 .../dpaax/{rte_common_dpaax_version.map => version.map}   | 0
 .../common/iavf/{rte_common_iavf_version.map => version.map}  | 0
 .../common/mlx5/{rte_common_mlx5_version.map => version.map}  | 0
 .../common/mvep/{rte_common_mvep_version.map => version.map}  | 0
 .../octeontx/{rte_common_octeontx_version.map => version.map} | 0
 .../{rte_common_octeontx2_version.map => version.map} | 0
 .../common/qat/{rte_common_qat_version.map => version.map}| 0
 .../sfc_efx/{rte_common_sfc_efx_version.map => version.map}   | 0
 .../compress/isal/{rte_pmd_isal_version.map => version.map}   | 0
 .../{rte_pmd_octeontx_compress_version.map => version.map}| 0
 .../compress/zlib/{rte_pmd_zlib_version.map => version.map}   | 0
 .../aesni_gcm/{rte_pmd_aesni_gcm_version.map => version.map}  | 0
 .../aesni_mb/{rte_pmd_aesni_mb_version.map => version.map}| 0
 .../crypto/armv8/{rte_pmd_armv8_version.map => version.map}   | 0
 .../caam_jr/{rte_pmd_caam_jr_version.map => version.map}  | 0
 drivers/crypto/ccp/{rte_pmd_ccp_version.map => version.map}   | 0
 .../dpaa2_sec/{rte_pmd_dpaa2_sec_version.map => version.map}  | 0
 .../dpaa_sec/{rte_pmd_dpaa_sec_version.map => version.map}| 0
 .../crypto/kasumi/{rte_pmd_kasumi_version.map => version.map} | 0
 .../crypto/mvsam/{rte_pmd_mvsam_version.map => version.map}   | 0
 .../crypto/nitrox/{rte_pmd_nitrox_version.map => version.map} | 0
 .../null/{rte_pmd_null_crypto_version.map => version.map} | 0
 .../{rte_pmd_octeontx_crypto_version.map => version.map}  | 0
 .../{rte_pmd_octeontx2_crypto_version.map => version.map} | 0
 .../openssl/{rte_pmd_openssl_version.map => version.map}  | 0
 .../{rte_pmd_crypto_scheduler_version.map => version.map} | 0
 .../crypto/snow3g/{rte_pmd_snow3g_version.map => version.map} | 0
 .../virtio/{rte_pmd_virtio_crypto_version.map => version.map} | 0
 drivers/crypto/zuc/{rte_pmd_zuc_version.map => version.map}   | 0
 .../dpaa/{rte_pmd_dpaa_event_version.map => version.map}  | 0
 .../dpaa2/{rte_pmd_dpaa2_event_version.map => version.map}| 0
 .../event/dsw/{rte_pmd_dsw_event_version.map => version.map}  | 0
 .../{rte_pmd_octeontx_event_version.map => version.map}   | 0
 .../{rte_pmd_octeontx2_event_version.map => version.map}  | 0
 .../opdl/{rte_pmd_opdl_event_version.map => version.map}  | 0
 .../{rte_pmd_skeleton_event_version.map => version.map}   | 0
 .../event/sw/{rte_pmd_sw_event_version.map => version.map}| 0
 .../bucket/{rte_mempool_bucket_version.map => version.map}| 0
 .../dpaa/{rte_mempool_dpaa_version.map => version.map}| 0
 .../dpaa2/{rte_mempool_dpaa2_version.map => version.map}  | 0
 .../{rte_mempool_octeontx_version.map => version.map} | 0
 .../{rte_mempool_octeontx2_version.map => version.map}| 0
 .../ring/{rte_mempool_ring_version.map => version.map}| 0
 .../stack/{rte_mempool_stack_version.map => version.map}  | 0
 drivers/meson.build   | 4 ++--
 .../af_packet/{rte_pmd_af_packet_version.map => version.map}  | 0
 .../net/af_xdp/{rte_pmd_af_xdp_version.map => version.map}| 0
 drivers/net/ark/{rte_pmd_ark_version.map => version.map}  | 0
 .../atlantic/{rte_pmd_atlantic_version.map => version.map}| 0
 drivers/net/avp/{rte_pmd_avp_version.map => version.map}  | 0
 drivers/net/axgbe/{rte_pmd_axgbe_version.map => version.map}  | 0
 drivers/net/bnx2x/{rte_pmd_bnx2x_version.map => version.map}  | 0
 drivers/net/bnxt/{rte_pmd_bnxt_version.map => version.map}| 0
 drivers/net/bonding/{rte_pmd_bond_version.map => version.map} | 0
 drivers/net/cxgbe/{rte_pmd_cxgbe_version.map => version.map}  | 0
 drivers/net/dpaa/{rte_pmd_dpaa_version.map => version.map}| 0
 drivers/net/dpaa2/{rte_pmd_dpaa2_version.map => version.map}  | 0
 drivers/net/e1000/{rte_pmd_e1000_version.map => version.map}  | 0
 drivers/net/ena/{rte_pmd_ena_version.map => version.map}  | 0
 drivers/net/enetc/{rte_pmd_enetc_version.map => version.ma

[dpdk-dev] [RFC PATCH v2 6/8] build: standardize component names and defines

[Bruce Richardson]

As discussed on the dpdk-dev mailing list[1], we can make some easy
improvements in standardizing the naming of the various components in DPDK,
and their associated feature-enabled macros.

Following this patch, each library will have the name in format,
'librte_.so', and the macro indicating that library is enabled in the
build will have the form 'RTE_LIB_'.

Similarly, for libraries, the equivalent name formats and macros are:
'librte__.so' and 'RTE__', where class is the
device type taken from the relevant driver subdirectory name, i.e. 'net',
'crypto' etc.

To avoid too many changes at once for end applications, the old macro names
will still be provided in the build in this release, but will be removed
subsequently.

Signed-off-by: Bruce Richardson 

[1] 
http://inbox.dpdk.org/dev/ef7c1a87-79ab-e405-4202-39b7ad6b0...@solarflare.com/t/#u
---
 app/test-bbdev/meson.build|  4 ++--
 app/test-crypto-perf/meson.build  |  2 +-
 app/test-pmd/meson.build  | 12 ++--
 app/test/meson.build  |  8 
 doc/guides/rel_notes/deprecation.rst  |  8 
 drivers/baseband/meson.build  |  1 -
 drivers/bus/meson.build   |  1 -
 drivers/common/meson.build|  1 -
 drivers/common/mlx5/meson.build   |  1 -
 drivers/common/qat/meson.build|  1 -
 drivers/compress/meson.build  |  1 -
 drivers/compress/octeontx/meson.build |  2 +-
 drivers/crypto/meson.build|  1 -
 drivers/crypto/null/meson.build   |  2 +-
 drivers/crypto/octeontx/meson.build   |  2 +-
 drivers/crypto/octeontx2/meson.build  |  2 +-
 drivers/crypto/scheduler/meson.build  |  2 +-
 drivers/crypto/virtio/meson.build |  2 +-
 drivers/event/dpaa/meson.build|  2 +-
 drivers/event/dpaa2/meson.build   |  2 +-
 drivers/event/meson.build |  1 -
 drivers/event/octeontx/meson.build|  2 +-
 drivers/event/octeontx2/meson.build   |  2 +-
 drivers/mempool/meson.build   |  1 -
 drivers/meson.build   |  9 -
 drivers/net/meson.build   |  1 -
 drivers/net/mlx4/meson.build  |  2 +-
 drivers/raw/ifpga/meson.build |  2 +-
 drivers/raw/meson.build   |  1 -
 drivers/regex/meson.build |  1 -
 drivers/vdpa/meson.build  |  1 -
 examples/bond/meson.build |  2 +-
 examples/ethtool/meson.build  |  2 +-
 examples/ioat/meson.build |  2 +-
 examples/l2fwd-crypto/meson.build |  2 +-
 examples/ntb/meson.build  |  2 +-
 examples/vm_power_manager/meson.build |  6 +++---
 lib/librte_ethdev/meson.build |  1 -
 lib/librte_graph/meson.build  |  2 --
 lib/meson.build   |  3 ++-
 40 files changed, 47 insertions(+), 55 deletions(-)

diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build
index 18ab6a8c6c..178306b08c 100644
--- a/app/test-bbdev/meson.build
+++ b/app/test-bbdev/meson.build
@@ -7,8 +7,8 @@ sources = files('main.c',
'test_bbdev_vector.c')
 deps += ['bbdev', 'bus_vdev']
 if dpdk_conf.has('RTE_LIBRTE_PMD_BBDEV_FPGA_LTE_FEC')
-   deps += ['pmd_bbdev_fpga_lte_fec']
+   deps += ['baseband_fpga_lte_fec']
 endif
 if dpdk_conf.has('RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC')
-   deps += ['pmd_bbdev_fpga_5gnr_fec']
+   deps += ['baseband_fpga_5gnr_fec']
 endif
diff --git a/app/test-crypto-perf/meson.build b/app/test-crypto-perf/meson.build
index 4bd71510dc..e6ddda6f0c 100644
--- a/app/test-crypto-perf/meson.build
+++ b/app/test-crypto-perf/meson.build
@@ -13,5 +13,5 @@ sources = files('cperf_ops.c',
'main.c')
 deps += ['cryptodev', 'net', 'security']
 if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
-   deps += 'pmd_crypto_scheduler'
+   deps += 'crypto_scheduler'
 endif
diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
index 0d9e450494..2e8b9f8a99 100644
--- a/app/test-pmd/meson.build
+++ b/app/test-pmd/meson.build
@@ -38,22 +38,22 @@ if dpdk_conf.has('RTE_LIBRTE_LATENCYSTATS')
deps += 'latencystats'
 endif
 if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
-   deps += 'pmd_crypto_scheduler'
+   deps += 'crypto_scheduler'
 endif
 if dpdk_conf.has('RTE_LIBRTE_BOND_PMD')
-   deps += 'pmd_bond'
+   deps += 'net_bond'
 endif
 if dpdk_conf.has('RTE_LIBRTE_BNXT_PMD')
-   deps += 'pmd_bnxt'
+   deps += 'net_bnxt'
 endif
 if dpdk_conf.has('RTE_LIBRTE_I40E_PMD')
-   deps += 'pmd_i40e'
+   deps += 'net_i40e'
 endif
 if dpdk_conf.has('RTE_LIBRTE_IXGBE_PMD')
-   deps += 'pmd_ixgbe'
+   deps += 'net_ixgbe'
 endif
 if dpdk_conf.has('RTE_LIBRTE_DPAA_PMD')
-   deps += ['bus_dpaa', 'mempool_dpaa', 'pmd_dpaa']
+   deps += ['bus_dpaa', 'mempool_dpaa', 'net_dpaa']
 endif
 if dpdk_conf.has('RTE_LIBRTE_BPF')
sources += files('bpf_cmd.c')
diff --git a/app/test/meson.build b/app/test/meson.build
index 781555f9de..d3ae9c91ac 100644
--- a/app/test/meson

[dpdk-dev] [RFC PATCH v2 8/8] [v21.02] build: remove compatibility build defines

[Bruce Richardson]

As announced in the deprecation note, remove all compatibility build
defines from previous make/meson versions and use only the standardized
ones - RTE_LIB_ for libraries, and RTE__ for drivers.

Signed-off-by: Bruce Richardson 
---
 config/meson.build|   2 +-
 config/rte_compatibility_defines.h| 129 --
 config/rte_config.h   |   1 -
 drivers/baseband/meson.build  |   2 -
 drivers/bus/meson.build   |   1 -
 drivers/common/meson.build|   1 -
 drivers/compress/meson.build  |   1 -
 drivers/compress/octeontx/meson.build |   1 -
 drivers/crypto/meson.build|   1 -
 drivers/crypto/null/meson.build   |   1 -
 drivers/crypto/octeontx/meson.build   |   1 -
 drivers/crypto/octeontx2/meson.build  |   1 -
 drivers/crypto/scheduler/meson.build  |   1 -
 drivers/crypto/virtio/meson.build |   1 -
 drivers/event/meson.build |   1 -
 drivers/mempool/meson.build   |   1 -
 drivers/meson.build   |  23 -
 drivers/net/meson.build   |   1 -
 drivers/raw/meson.build   |   1 -
 drivers/regex/meson.build |   1 -
 drivers/regex/mlx5/meson.build|   1 -
 drivers/vdpa/meson.build  |   1 -
 drivers/vdpa/mlx5/meson.build |   1 -
 lib/meson.build   |   3 +-
 24 files changed, 2 insertions(+), 176 deletions(-)
 delete mode 100644 config/rte_compatibility_defines.h

diff --git a/config/meson.build b/config/meson.build
index 3a36d9dd4c..860dfd2e67 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -254,7 +254,7 @@ dpdk_conf.set('RTE_COMPILE_TIME_CPUFLAGS', 
','.join(compile_time_cpuflags))
 # set the install path for the drivers
 dpdk_conf.set_quoted('RTE_EAL_PMD_PATH', eal_pmd_path)
 
-install_headers(['rte_config.h', 'rte_compatibility_defines.h'],
+install_headers(['rte_config.h'],
subdir: get_option('include_subdir_arch'))
 
 # enable VFIO only if it is linux OS
diff --git a/config/rte_compatibility_defines.h 
b/config/rte_compatibility_defines.h
deleted file mode 100644
index 47600052b6..00
--- a/config/rte_compatibility_defines.h
+++ /dev/null
@@ -1,129 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2017 Intel Corporation
- */
-
-#ifndef _RTE_CONFIG_H_
-#error "This file should only be included via rte_config.h"
-#endif
-
-/*
- * NOTE: these defines are for compatibility only and will be removed in a
- * future DPDK release.
- */
-
-#ifdef RTE_LIBRTE_BITRATESTATS
-#define RTE_LIBRTE_BITRATE
-#endif
-
-#ifdef RTE_LIBRTE_LATENCYSTATS
-#define RTE_LIBRTE_LATENCY_STATS
-#endif
-
-#ifdef RTE_LIBRTE_DPAAX_COMMON
-#define RTE_LIBRTE_COMMON_DPAAX
-#endif
-
-#ifdef RTE_LIBRTE_VMBUS_BUS
-#define RTE_LIBRTE_VMBUS
-#endif
-
-#ifdef RTE_LIBRTE_BUCKET_MEMPOOL
-#define RTE_DRIVER_MEMPOOL_BUCKET
-#endif
-
-#ifdef RTE_LIBRTE_RING_MEMPOOL
-#define RTE_DRIVER_MEMPOOL_RING
-#endif
-
-#ifdef RTE_LIBRTE_STACK_MEMPOOL
-#define RTE_DRIVER_MEMPOOL_STACK
-#endif
-
-#ifdef RTE_LIBRTE_AF_PACKET_PMD
-#define RTE_LIBRTE_PMD_AF_PACKET
-#endif
-
-#ifdef RTE_LIBRTE_AF_XDP_PMD
-#define RTE_LIBRTE_PMD_AF_XDP
-#endif
-
-#ifdef RTE_LIBRTE_BOND_PMD
-#define RTE_LIBRTE_PMD_BOND
-#endif
-
-#ifdef RTE_LIBRTE_E1000_PMD
-#define RTE_LIBRTE_EM_PMD
-#endif
-
-#ifdef RTE_LIBRTE_E1000_PMD
-#define RTE_LIBRTE_IGB_PMD
-#endif
-
-#ifdef RTE_LIBRTE_FAILSAFE_PMD
-#define RTE_LIBRTE_PMD_FAILSAFE
-#endif
-
-#ifdef RTE_LIBRTE_KNI_PMD
-#define RTE_LIBRTE_PMD_KNI
-#endif
-
-#ifdef RTE_LIBRTE_LIQUIDIO_PMD
-#define RTE_LIBRTE_LIO_PMD
-#endif
-
-#ifdef RTE_LIBRTE_MEMIF_PMD
-#define RTE_LIBRTE_PMD_MEMIF
-#endif
-
-#ifdef RTE_LIBRTE_NULL_PMD
-#define RTE_LIBRTE_PMD_NULL
-#endif
-
-#ifdef RTE_LIBRTE_PCAP_PMD
-#define RTE_LIBRTE_PMD_PCAP
-#endif
-
-#ifdef RTE_LIBRTE_RING_PMD
-#define RTE_LIBRTE_PMD_RING
-#endif
-
-#ifdef RTE_LIBRTE_SFC_PMD
-#define RTE_LIBRTE_SFC_EFX_PMD
-#endif
-
-#ifdef RTE_LIBRTE_SOFTNIC_PMD
-#define RTE_LIBRTE_PMD_SOFTNIC
-#endif
-
-#ifdef RTE_LIBRTE_SZEDATA2_PMD
-#define RTE_LIBRTE_PMD_SZEDATA2
-#endif
-
-#ifdef RTE_LIBRTE_TAP_PMD
-#define RTE_LIBRTE_PMD_TAP
-#endif
-
-#ifdef RTE_LIBRTE_THUNDERX_PMD
-#define RTE_LIBRTE_THUNDERX_NICVF_PMD
-#endif
-
-#ifdef RTE_LIBRTE_VHOST_PMD
-#define RTE_LIBRTE_PMD_VHOST
-#endif
-
-#ifdef RTE_LIBRTE_PMD_ARMV8
-#define RTE_LIBRTE_PMD_ARMV8_CRYPTO
-#endif
-
-#ifdef RTE_LIBRTE_PMD_MVSAM
-#define RTE_LIBRTE_PMD_MVSAM_CRYPTO
-#endif
-
-#ifdef RTE_LIBRTE_PMD_OCTEONTX_COMPRESS
-#define RTE_LIBRTE_PMD_OCTEONTX_ZIPVF
-#endif
-
-#ifdef RTE_LIBRTE_PMD_OCTEONTX_EVENTDEV
-#define RTE_LIBRTE_PMD_OCTEONTX_SSOVF
-#endif
-
diff --git a/config/rte_config.h b/config/rte_config.h
index cacc1837cf..0bae630fd9 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -13,7 +13,6 @@
 #define _RTE_CONFIG_H_
 
 #include 
-#include 
 
 /* legacy defines */
 #ifdef RTE_EXEC_ENV_LINUX
diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
index 7e1b64f

[dpdk-dev] [RFC PATCH v2 7/8] build: replace use of old build macros

[Bruce Richardson]

Use the newer macros defined by meson in all DPDK source code, to ensure
there are no errors when the old non-standard macros are removed.

Signed-off-by: Bruce Richardson 
---
 app/proc-info/main.c  |   4 +-
 app/test-bbdev/meson.build|   4 +-
 app/test-bbdev/test_bbdev_perf.c  |   8 +-
 app/test-crypto-perf/cperf_ops.c  |   6 +-
 app/test-crypto-perf/cperf_options.h  |   6 +-
 app/test-crypto-perf/cperf_options_parsing.c  |  16 +-
 .../cperf_test_pmd_cyclecount.c   |   2 +-
 app/test-crypto-perf/cperf_test_throughput.c  |   2 +-
 app/test-crypto-perf/main.c   |   6 +-
 app/test-crypto-perf/meson.build  |   2 +-
 app/test-pipeline/main.c  |   2 +-
 app/test-pmd/bpf_cmd.h|   4 +-
 app/test-pmd/cmdline.c| 190 +-
 app/test-pmd/config.c |  18 +-
 app/test-pmd/meson.build  |  22 +-
 app/test-pmd/parameters.c |  30 +--
 app/test-pmd/testpmd.c|  38 ++--
 app/test-pmd/testpmd.h|   4 +-
 app/test/meson.build  |  26 +--
 app/test/process.h|  16 +-
 app/test/test.c   |  20 +-
 app/test/test_cryptodev.c |  26 +--
 app/test/test_cryptodev_hash_test_vectors.h   |   2 +-
 app/test/test_eal_flags.c |   4 +-
 app/test/test_func_reentrancy.c   |  24 +--
 app/test/test_kni.c   |   2 +-
 app/test/test_mp_secondary.c  |  12 +-
 app/test/test_power.c |   2 +-
 app/test/test_power_cpufreq.c |   2 +-
 app/test/test_power_kvm_vm.c  |   2 +-
 app/test/test_table.c |   2 +-
 app/test/test_table.h |   2 +-
 app/test/test_table_combined.h|   2 +-
 app/test/test_table_tables.h  |   2 +-
 config/arm/meson.build|   6 +-
 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c  |   6 +-
 drivers/compress/qat/qat_comp.h   |   2 +-
 drivers/compress/qat/qat_comp_pmd.h   |   2 +-
 .../crypto/aesni_mb/aesni_mb_pmd_private.h|   2 +-
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c   |  22 +-
 drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h |   8 +-
 drivers/crypto/dpaa_sec/dpaa_sec.c|  24 +--
 drivers/crypto/dpaa_sec/dpaa_sec.h|   8 +-
 drivers/crypto/qat/qat_sym.c  |   2 +-
 drivers/crypto/qat/qat_sym.h  |   8 +-
 drivers/crypto/qat/qat_sym_capabilities.h |   2 +-
 drivers/crypto/qat/qat_sym_pmd.c  |  12 +-
 drivers/crypto/qat/qat_sym_pmd.h  |   2 +-
 drivers/crypto/qat/qat_sym_session.c  |   4 +-
 drivers/crypto/qat/qat_sym_session.h  |   4 +-
 drivers/net/ixgbe/ixgbe_ethdev.c  |   6 +-
 drivers/net/ixgbe/ixgbe_ethdev.h  |   4 +-
 drivers/net/ixgbe/ixgbe_flow.c|   6 +-
 drivers/net/ixgbe/ixgbe_rxtx.c|  26 +--
 drivers/net/ixgbe/ixgbe_rxtx.h|   6 +-
 drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c|   6 +-
 drivers/net/kni/meson.build   |   2 +-
 drivers/net/netvsc/meson.build|   2 +-
 drivers/net/vhost/meson.build |   2 +-
 drivers/raw/dpaa2_cmdif/meson.build   |   2 +-
 drivers/raw/dpaa2_qdma/meson.build|   2 +-
 drivers/raw/ifpga/base/opae_osdep.h   |   2 +-
 drivers/vdpa/ifc/meson.build  |   2 +-
 examples/distributor/meson.build  |   2 +-
 examples/ethtool/lib/rte_ethtool.c|   4 +-
 examples/ethtool/meson.build  |   2 +-
 examples/ioat/meson.build |   2 +-
 examples/ip_pipeline/kni.c|   4 +-
 examples/ip_pipeline/kni.h|   4 +-
 examples/ip_pipeline/pipeline.c   |  14 +-
 examples/kni/meson.build  |   2 +-
 examples/l2fwd-crypto/main.c  |   4 +-
 examples/l2fwd-crypto/meson.build |   2 +-
 examples/l3fwd-power/meson.build  |   2 +-
 examples/ntb/meson.build  |   2 +-
 examples/vhost_crypto/meson.build |   2 +-
 examples/vm_power_manager/channel_monitor.c   |   8 +-
 .../vm_power_manager/guest_cli/meson.build|   2 +-
 examples/vm_power_manager/main.c  |  12 +-
 examples/vm_power_manager/meson.build |   8 +-
 lib/librte_eal/linux/eal.c|   4 +-
 lib/librte_metrics/rte_metrics_telemetry.c|   4 +-
 lib/librte_metrics/rte_metrics_telemetry.h|   2 +-
 lib/librte_port/meson.build   |   2 +-
 lib/meson.build   |   2 +-
 85 files changed, 391 insertions(+), 

Re: [dpdk-dev] [PATCH] doc: remove references to python 2

[Kevin Laatz]

On 02/10/2020 16:47, Robin Jarry wrote:

Python 2 support has now been dropped. Remove references to it in the
documentation.

Since all python scripts now have a proper shebang that calls python3,
execute the scripts directly without specifying the interpreter.

Sphinx version from most Linux distros is OK in 2020, do not encourage
people to break their system by installing with pip. Use the distros
official packages.

Signed-off-by: Robin Jarry 
---
  doc/guides/conf.py| 2 +-
  doc/guides/contributing/documentation.rst | 8 ++--
  doc/guides/howto/telemetry.rst| 2 +-
  doc/guides/nics/virtio.rst| 4 ++--
  doc/guides/rel_notes/deprecation.rst  | 4 ++--
  doc/guides/tools/testbbdev.rst| 2 +-
  6 files changed, 9 insertions(+), 13 deletions(-)


Acked-by: Kevin Laatz 

Re: [dpdk-dev] [PATCH] doc: remove references to python 2

[Bruce Richardson]

On Fri, Oct 02, 2020 at 05:55:22PM +0200, Robin Jarry wrote:
> 2020-10-02, Bruce Richardson:
> > > +   sudo dnf -y install python3-sphinx python3-sphinx_rtd_theme
> > 
> > Minor nit, I see no reason to preserve the big whitespace gap here.
> 
> I thought about removing it but all the file is like this. I left it
> as-is for consistency.
> 
Ok. Keep my ack, either way. :-)

Re: [dpdk-dev] [PATCH] maintainers: New Reviewer entry type added to MAINTAINERS

[Tom Rix]

On 10/2/20 8:41 AM, Thomas Monjalon wrote:
> 02/10/2020 16:59, Tom Rix:
>> On 10/1/20 2:54 PM, Thomas Monjalon wrote:
>>> 01/10/2020 23:22, Chautru, Nicolas:
 From: t...@redhat.com 
> From: Tom Rix 
>
> Copied from the Linux kernel MAINTAINERS file.
> A Reviewer is designated person who wishes to review changes in areas of
> interest.
>
> Added self as Reviewer for baseband.
>
> I am a Linux kernel Reviewer for the fpga n3000/vista creek which has
> several bitstream based baseband devices.  So I want to help out here as
> well.
>
> Signed-off-by: Tom Rix 
 Thanks for the help. 
 Note that they are a few other BBDEV patches in flight for 20.11 on top of 
 the acc100 PMD that you may want to be aware of. 
 https://patches.dpdk.org/project/dpdk/list/?series=&submitter=chautru&state=&q=&archive=&delegate=

 Acked-by: Nicolas Chautru 
>>> [...]
>  Baseband API - EXPERIMENTAL
>  M: Nicolas Chautru 
> +R: Tom Rix 
>>> I don't understand the need of differenciating maintainer and reviewer.
>>> If you are trusted enough, why not just being co-maintainer?
>>>
>> I want to help out with the reviews, the reviewer type makes clear this 
>> level of commitment.
>>
>> Maintainer is the next, higher level of commitment.
>>
>>
>> Trust wise, this would allow the maintainer verify the reviewer does have 
>> the bandwidth to be responsive
>>
>> and effective before committing to sharing responsibility.
> Sorry I fail to understand.
> My understanding is that you want to be Cc
> but not committing for responsibility.
> Would it be the same if you create a mail filter on your side?
>
> This model is really not clear to me so I'm reluctant to add
> such new category until I understand the benefit.
>
That's fine, i will change the patch and use the existing process.

Tom

Re: [dpdk-dev] [PATCH] vdpa/ifc: fix build issue with recent kernels

[David Marchand]

On Fri, Oct 2, 2020 at 10:33 AM David Marchand
 wrote:
>
> On Fri, Oct 2, 2020 at 9:54 AM Maxime Coquelin
>  wrote:
> >
> > VIRTIO_F_IOMMU_PLATFORM is now defined in recent kernel
> > headers, causing build issue.
> >
> > Le's define it in IFC vDPA driver only if wasn't already.
>
> Let's* define it in the* IFC vDPA driver only if it* wasn't already.
>
> >
> > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> > Cc: sta...@dpdk.org
> >
> > Reported-by: Brandon Lo 
> > Signed-off-by: Maxime Coquelin 
> Acked-by: David Marchand 

Applied directly in main to avoid noise coming from the Fedora Rawhide job.


-- 
David Marchand

Re: [dpdk-dev] [dpdk-ci] Fedora Rawhide Meson Compile Testing - DPDK Compile Warning

[David Marchand]

On Fri, Oct 2, 2020 at 8:51 AM David Marchand  wrote:
>
> On Thu, Oct 1, 2020 at 8:24 PM Brandon Lo  wrote:
> > We have successfully added Fedora Rawhide to our production pipeline
> > for Meson compile testing.
> > The image for the container will be updated on a weekly basis.
> >
> > The version of GCC that it is currently running (10.2) catches that
> > the drivers/vdpa/ifc/base/ifcvf.h file redefines
> > VIRTIO_F_IOMMU_PLATFORM, originally from
> > /usr/include/linux/virtio_config.h.
> > I am just giving you guys a heads-up before the failure report catches
> > anyone off guard.
>
> Brandon,
>
> Before putting this new job online, the build issue should have been
> fixed on the dpdk side.
> All new submitted series are now getting a fail flag that we must
> inspect to check whether it is because of this known issue or
> something else.
>
> Please, disable this job.

The vdpa/ifc issue should be fixed in the main branch now (thanks to Maxime).
But next-net and other subtrees will still have the issue until they
catch on this fix.


>
> There is also the OpenSuse job failing.
> Can you investigate?

Still failing.


-- 
David Marchand

[dpdk-dev] [PATCH v2] net/bnxt: support fast mbuf free

[Lance Richardson]

Add support for DEV_TX_OFFLOAD_MBUF_FAST_FREE to bnxt
vector mode transmit. This offload may be enabled
only when multi-segment transmit is not needed, all
transmitted mbufs for a given queue will be allocated
from the same pool, and all transmitted mbufs will
have a reference count of 1.

Since this offload is only supported in vector mode at
this time, support in the features list is indicated
as "partial".

Signed-off-by: Lance Richardson 
---
- v2:
  Fixed mangling of advertised tx offload capabilities.

 doc/guides/nics/features/bnxt.ini |  1 +
 drivers/net/bnxt/bnxt_ethdev.c| 11 +++
 drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 28 ++-
 drivers/net/bnxt/bnxt_rxtx_vec_sse.c  | 28 ++-
 drivers/net/bnxt/bnxt_txq.c   |  2 ++
 drivers/net/bnxt/bnxt_txq.h   |  1 +
 6 files changed, 65 insertions(+), 6 deletions(-)

diff --git a/doc/guides/nics/features/bnxt.ini 
b/doc/guides/nics/features/bnxt.ini
index f1f300c8b..7cb873dd0 100644
--- a/doc/guides/nics/features/bnxt.ini
+++ b/doc/guides/nics/features/bnxt.ini
@@ -8,6 +8,7 @@ Speed capabilities   = Y
 Link status  = Y
 Link status event= Y
 Rx interrupt = Y
+Fast mbuf free   = P
 Queue start/stop = Y
 Burst mode info  = Y
 MTU update   = Y
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 624cb2031..c2a9f80e2 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -920,7 +920,9 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
dev_info->rx_offload_capa = BNXT_DEV_RX_OFFLOAD_SUPPORT;
if (bp->flags & BNXT_FLAG_PTP_SUPPORTED)
dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_TIMESTAMP;
-   dev_info->tx_offload_capa = BNXT_DEV_TX_OFFLOAD_SUPPORT;
+   dev_info->tx_queue_offload_capa = DEV_TX_OFFLOAD_MBUF_FAST_FREE;
+   dev_info->tx_offload_capa = BNXT_DEV_TX_OFFLOAD_SUPPORT |
+   dev_info->tx_queue_offload_capa;
dev_info->flow_type_rss_offloads = BNXT_ETH_RSS_SUPPORT;
 
dev_info->speed_capa = bnxt_get_speed_capabilities(bp);
@@ -1191,6 +1193,7 @@ bnxt_transmit_function(__rte_unused struct rte_eth_dev 
*eth_dev)
 {
 #if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)
 #ifndef RTE_LIBRTE_IEEE1588
+   uint64_t offloads = eth_dev->data->dev_conf.txmode.offloads;
struct bnxt *bp = eth_dev->data->dev_private;
 
/*
@@ -1198,7 +1201,7 @@ bnxt_transmit_function(__rte_unused struct rte_eth_dev 
*eth_dev)
 * or tx offloads.
 */
if (!eth_dev->data->scattered_rx &&
-   !eth_dev->data->dev_conf.txmode.offloads &&
+   !(offloads & ~DEV_TX_OFFLOAD_MBUF_FAST_FREE) &&
!BNXT_TRUFLOW_EN(bp)) {
PMD_DRV_LOG(INFO, "Using vector mode transmit for port %d\n",
eth_dev->data->port_id);
@@ -1210,7 +1213,7 @@ bnxt_transmit_function(__rte_unused struct rte_eth_dev 
*eth_dev)
"Port %d scatter: %d tx offload: %" PRIX64 "\n",
eth_dev->data->port_id,
eth_dev->data->scattered_rx,
-   eth_dev->data->dev_conf.txmode.offloads);
+   offloads);
 #endif
 #endif
return bnxt_xmit_pkts;
@@ -2685,7 +2688,7 @@ bnxt_txq_info_get_op(struct rte_eth_dev *dev, uint16_t 
queue_id,
qinfo->conf.tx_free_thresh = txq->tx_free_thresh;
qinfo->conf.tx_rs_thresh = 0;
qinfo->conf.tx_deferred_start = txq->tx_deferred_start;
-   qinfo->conf.offloads = dev->data->dev_conf.txmode.offloads;
+   qinfo->conf.offloads = txq->offloads;
 }
 
 static const struct {
diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c 
b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c
index 299b6b86d..a70055fce 100644
--- a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c
+++ b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c
@@ -338,6 +338,29 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf 
**rx_pkts,
return nb_rx_pkts;
 }
 
+static void
+bnxt_tx_cmp_vec_fast(struct bnxt_tx_queue *txq, int nr_pkts)
+{
+   struct bnxt_tx_ring_info *txr = txq->tx_ring;
+   struct rte_mbuf **free = txq->free;
+   uint16_t cons = txr->tx_cons;
+   unsigned int blk = 0;
+   uint32_t ring_mask = txr->tx_ring_struct->ring_mask;
+
+   while (nr_pkts--) {
+   struct bnxt_sw_tx_bd *tx_buf;
+
+   tx_buf = &txr->tx_buf_ring[cons];
+   cons = (cons + 1) & ring_mask;
+   free[blk++] = tx_buf->mbuf;
+   tx_buf->mbuf = NULL;
+   }
+   if (blk)
+   rte_mempool_put_bulk(free[0]->pool, (void **)free, blk);
+
+   txr->tx_cons = cons;
+}
+
 static void
 bnxt_tx_cmp_vec(struct bnxt_tx_queue *txq, int nr_pkts)
 {
@@ -399,7 +422,10 @@ bnxt_handle_tx_cp_vec(struct bnxt_tx_queue *txq)
 
cpr->valid = !!(raw_cons & cp_ring_struct->ring_size);
if (nb_tx_pkts) {
-

Re: [dpdk-dev] [PATCH v5] windows/netuio: add Windows NetUIO kernel driver

[Ranjit Menon]

On 10/1/2020 3:55 PM, Narcisa Ana Maria Vasile wrote:

From: Narcisa Vasile 

The Windows netuio kernel driver provides the DPDK userspace application
with direct access to hardware, by mapping the HW registers in userspace
and allowing read/write operations from/to the device
configuration space.

Two IOCTLs are defined by the netuio interface:
   * IOCTL_NETUIO_MAP_HW_INTO_USERSPACE
   - used for mapping the device registers into userspace
   * IOCTL_NETUIO_PCI_CONFIG_IO
   - used to read/write from/into the device configuration space

Note:
Requests to map the device BARs into userspace need to be processed
in the thread context of the process that initiated the mapping request.
Otherwise, the BARs might end up mapped into an arbitrary process
address space.
EvtIoInCallerContext is used to ensure the requests are handled
in the right user thread context. Other requests (PCI config)
are sent back to the framework and processed by the EvtIoDeviceControl
callback.

Cc: Harini Ramakrishnan 
Cc: Omar Cardona 
Cc: Dmitry Malloy 
Signed-off-by: Narcisa Vasile 
---

v5:
* Changed the name of the IOCTL for clarity

  windows/.gitattributes|   4 +
  windows/.gitignore|   2 +
  windows/netuio/README.rst |  58 +
  windows/netuio/netuio.inf |  77 ++
  windows/netuio/netuio.sln |  24 ++
  windows/netuio/netuio.vcxproj | 113 +
  windows/netuio/netuio.vcxproj.filters |  54 +
  windows/netuio/netuio_dev.c   | 273 +
  windows/netuio/netuio_dev.h   |  66 +
  windows/netuio/netuio_drv.c   | 131 ++
  windows/netuio/netuio_drv.h   |  30 +++
  windows/netuio/netuio_interface.h |  88 +++
  windows/netuio/netuio_queue.c | 334 ++
  windows/netuio/netuio_queue.h |  21 ++
  14 files changed, 1275 insertions(+)
  create mode 100644 windows/.gitattributes
  create mode 100644 windows/.gitignore
  create mode 100644 windows/netuio/README.rst
  create mode 100644 windows/netuio/netuio.inf
  create mode 100644 windows/netuio/netuio.sln
  create mode 100644 windows/netuio/netuio.vcxproj
  create mode 100644 windows/netuio/netuio.vcxproj.filters
  create mode 100644 windows/netuio/netuio_dev.c
  create mode 100644 windows/netuio/netuio_dev.h
  create mode 100644 windows/netuio/netuio_drv.c
  create mode 100644 windows/netuio/netuio_drv.h
  create mode 100644 windows/netuio/netuio_interface.h
  create mode 100644 windows/netuio/netuio_queue.c
  create mode 100644 windows/netuio/netuio_queue.h


We'll need to do a code-style cleanup at some point, but for now:

Reviewed-by: Ranjit Menon 

Acked-by: Ranjit Menon 

Re: [dpdk-dev] [PATCH v5] windows/netuio: add Windows NetUIO kernel driver

[Dmitry Kozlyuk]

On Thu,  1 Oct 2020 15:55:08 -0700, Narcisa Ana Maria Vasile wrote:
> From: Narcisa Vasile 
> 
> The Windows netuio kernel driver provides the DPDK userspace application
> with direct access to hardware, by mapping the HW registers in userspace
> and allowing read/write operations from/to the device
> configuration space.
> 
> Two IOCTLs are defined by the netuio interface:
>   * IOCTL_NETUIO_MAP_HW_INTO_USERSPACE
>   - used for mapping the device registers into userspace
>   * IOCTL_NETUIO_PCI_CONFIG_IO
>   - used to read/write from/into the device configuration space
> 
> Note:
> Requests to map the device BARs into userspace need to be processed
> in the thread context of the process that initiated the mapping request.
> Otherwise, the BARs might end up mapped into an arbitrary process
> address space.
> EvtIoInCallerContext is used to ensure the requests are handled
> in the right user thread context. Other requests (PCI config)
> are sent back to the framework and processed by the EvtIoDeviceControl
> callback.
> 
> Cc: Harini Ramakrishnan 
> Cc: Omar Cardona 
> Cc: Dmitry Malloy 
> Signed-off-by: Narcisa Vasile 

Reviewed-by: Dmitry Kozlyuk 

[dpdk-dev] [PATCH] eal/windows: export all built functions for clang

[Tal Shnaiderman]

export for clang build all the functions currently built
on Windows and listed in rte_eal_version.map by adding
them to rte_eal_exports.def.

Signed-off-by: Tal Shnaiderman 
---
 lib/librte_eal/rte_eal_exports.def | 156 -
 1 file changed, 152 insertions(+), 4 deletions(-)

diff --git a/lib/librte_eal/rte_eal_exports.def 
b/lib/librte_eal/rte_eal_exports.def
index cda3e0c79f..d7a47d0929 100644
--- a/lib/librte_eal/rte_eal_exports.def
+++ b/lib/librte_eal/rte_eal_exports.def
@@ -3,33 +3,83 @@ EXPORTS
per_lcore__lcore_id
per_lcore__rte_errno
per_lcore__thread_id
+   rte_bus_dump
+   rte_bus_find
+   rte_bus_find_by_device
+   rte_bus_find_by_name
+   rte_bus_get_iommu_class
+   rte_bus_probe
rte_bus_register
+   rte_bus_scan
+   rte_bus_unregister
rte_calloc
rte_calloc_socket
+   rte_cpu_get_flag_enabled
+   rte_cpu_get_flag_name
+   rte_ctrl_thread_create
+   rte_delay_us
+   rte_delay_us_block
+   rte_delay_us_callback_register
rte_dev_is_probed
+   rte_dev_probe
+   rte_dev_remove
+   rte_devargs_add
+   rte_devargs_dump
rte_devargs_insert
rte_devargs_next
rte_devargs_parse
+   rte_devargs_parsef
rte_devargs_remove
+   rte_devargs_type_count
+   rte_dump_physmem_layout
+   rte_dump_registers
+   rte_dump_stack
+   rte_dump_tailq
+   rte_eal_cleanup
+   rte_eal_get_lcore_state
+   rte_eal_get_physmem_size
+   rte_eal_get_runtime_dir
rte_eal_has_hugepages
rte_eal_has_pci
+   rte_eal_hotplug_add
+   rte_eal_hotplug_remove
rte_eal_init
rte_eal_iova_mode
+   rte_eal_lcore_role
rte_eal_mbuf_user_pool_ops
rte_eal_mp_remote_launch
rte_eal_mp_wait_lcore
rte_eal_process_type
rte_eal_remote_launch
-   rte_log
rte_eal_tailq_lookup
rte_eal_tailq_register
rte_eal_using_phys_addrs
+   rte_eal_wait_lcore
+   rte_exit
rte_free
+   rte_get_master_lcore
+   rte_get_next_lcore
rte_get_tsc_hz
rte_hexdump
+   rte_hypervisor_get
rte_intr_rx_ctl
+   rte_lcore_count
+   rte_lcore_has_role
+   rte_lcore_index
+   rte_lcore_is_enabled
+   rte_lcore_to_socket_id
+   rte_log
+   rte_log_cur_msg_loglevel
+   rte_log_cur_msg_logtype
+   rte_log_dump
+   rte_log_get_global_level
+   rte_log_get_level
+   rte_log_get_stream
rte_log_register
+   rte_log_set_global_level
rte_log_set_level
+   rte_log_set_level_pattern
+   rte_log_set_level_regexp
rte_malloc
rte_malloc_dump_stats
rte_malloc_get_socket_stats
@@ -52,6 +102,7 @@ EXPORTS
rte_mem_lock_page
rte_mem_virt2iova
rte_mem_virt2phy
+   rte_memdump
rte_memory_get_nchannel
rte_memory_get_nrank
rte_memzone_dump
@@ -61,15 +112,53 @@ EXPORTS
rte_memzone_reserve_aligned
rte_memzone_reserve_bounded
rte_memzone_walk
+   rte_openlog_stream
+   rte_realloc
+   rte_rtm_supported
+   rte_service_attr_get
+   rte_service_attr_reset_all
+   rte_service_component_register
+   rte_service_component_runstate_set
+   rte_service_component_unregister
+   rte_service_dump
+   rte_service_finalize
+   rte_service_get_by_name
+   rte_service_get_count
+   rte_service_get_name
+   rte_service_lcore_add
+   rte_service_lcore_attr_get
+   rte_service_lcore_attr_reset_all
+   rte_service_lcore_count
+   rte_service_lcore_count_services
+   rte_service_lcore_del
+   rte_service_lcore_list
+   rte_service_lcore_reset_all
+   rte_service_lcore_start
+   rte_service_lcore_stop
+   rte_service_map_lcore_get
+   rte_service_map_lcore_set
+   rte_service_may_be_active
+   rte_service_probe_capability
+   rte_service_run_iter_on_app_lcore
+   rte_service_runstate_get
+   rte_service_runstate_set
+   rte_service_set_runstate_mapped_check
+   rte_service_set_stats_enable
+   rte_service_start_with_defaults
+   rte_set_application_usage_hook
+   rte_socket_count
rte_socket_id
+   rte_socket_id_by_idx
rte_strerror
+   rte_strscpy
rte_strsplit
rte_sys_gettid
+   rte_thread_get_affinity
+   rte_thread_set_affinity
+   rte_thread_setname
rte_vfio_container_dma_map
rte_vfio_container_dma_unmap
rte_vlog
-   rte_realloc
-   rte_strscpy
rte_zmalloc
rte_zmalloc_socket
 
@@ -78,6 +167,8 @@ EXPORTS
rte_mp_reply
rte_mp_sendmsg
 
+   rte_dev_event_callback_register
+   rte_dev_event_callback_unregister
rte_fbarray_attach
rte_fbarray_destroy
rte_fbarray_detach
@@ -110,8 +201,12 @@ EXPORTS
 

[dpdk-dev] [PATCH v2] net/qede: fix get link details

[Rasesh Mody]

This patch fixes get current link details, without this change the link
details can be inaccurate if proper lock is not acquired.

Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler")
Cc: sta...@dpdk.org

Reported-by: Ferruh Yigit 
Signed-off-by: Rasesh Mody 
Signed-off-by: Igor Russkikh 
---
 drivers/net/qede/qede_main.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index aecb98261..1ae10d99d 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -584,13 +584,12 @@ qed_get_current_link(struct ecore_dev *edev, struct 
qed_link_output *if_link)
hwfn = &edev->hwfns[0];
if (IS_PF(edev)) {
ptt = ecore_ptt_acquire(hwfn);
-   if (!ptt)
-   DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
-
+   if (ptt) {
qed_fill_link(hwfn, ptt, if_link);
-
-   if (ptt)
ecore_ptt_release(hwfn, ptt);
+   } else {
+   DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
+   }
} else {
qed_fill_link(hwfn, NULL, if_link);
}
-- 
2.18.1

Re: [dpdk-dev] [PATCH] net/qede: fix get link details

[Rasesh Mody]

Hi Jerin - please use v2, which addresses the build issues.

On 10/1/20, 3:41 PM, "Rasesh Mody"  wrote:

This patch fixes get current link details, without this change the link
details can be inaccurate if proper lock is not acquired.

Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler")
Cc: sta...@dpdk.org

Reported-by: Ferruh Yigit 
Signed-off-by: Rasesh Mody 
Signed-off-by: Igor Russkikh  
---
 drivers/net/qede/qede_main.c | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index aecb98261..f0ca3373f 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -584,13 +584,12 @@ qed_get_current_link(struct ecore_dev *edev, struct 
qed_link_output *if_link)
hwfn = &edev->hwfns[0];
if (IS_PF(edev)) {
ptt = ecore_ptt_acquire(hwfn);
-   if (!ptt)
-   DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
-
+   if (ptt) {
qed_fill_link(hwfn, ptt, if_link);
-
-   if (ptt)
ecore_ptt_release(hwfn, ptt);
+   } else {
+   DP_NOTICE(hwfn, "Failed to fill link; No PTT\n");
+   }
} else {
qed_fill_link(hwfn, NULL, if_link);
}
-- 
2.18.1

Re: [dpdk-dev] [PATCH] eal/windows: export all built functions for clang

[Ranjit Menon]

Hi Tal,

On 10/2/2020 12:18 PM, Tal Shnaiderman wrote:

export for clang build all the functions currently built
on Windows and listed in rte_eal_version.map by adding
them to rte_eal_exports.def.

Signed-off-by: Tal Shnaiderman 
---
  lib/librte_eal/rte_eal_exports.def | 156 -
  1 file changed, 152 insertions(+), 4 deletions(-)

diff --git a/lib/librte_eal/rte_eal_exports.def 
b/lib/librte_eal/rte_eal_exports.def
index cda3e0c79f..d7a47d0929 100644
--- a/lib/librte_eal/rte_eal_exports.def
+++ b/lib/librte_eal/rte_eal_exports.def
@@ -3,33 +3,83 @@ EXPORTS
per_lcore__lcore_id
per_lcore__rte_errno
per_lcore__thread_id
+   rte_bus_dump
+   rte_bus_find
+   rte_bus_find_by_device
+   rte_bus_find_by_name
+   rte_bus_get_iommu_class
+   rte_bus_probe
rte_bus_register
+   rte_bus_scan
+   rte_bus_unregister
rte_calloc
rte_calloc_socket
+   rte_cpu_get_flag_enabled
+   rte_cpu_get_flag_name
+   rte_ctrl_thread_create
+   rte_delay_us
+   rte_delay_us_block
+   rte_delay_us_callback_register
rte_dev_is_probed
+   rte_dev_probe
+   rte_dev_remove
+   rte_devargs_add
+   rte_devargs_dump
rte_devargs_insert
rte_devargs_next
rte_devargs_parse
+   rte_devargs_parsef
rte_devargs_remove
+   rte_devargs_type_count
+   rte_dump_physmem_layout
+   rte_dump_registers
+   rte_dump_stack
+   rte_dump_tailq
+   rte_eal_cleanup
+   rte_eal_get_lcore_state
+   rte_eal_get_physmem_size
+   rte_eal_get_runtime_dir
rte_eal_has_hugepages
rte_eal_has_pci
+   rte_eal_hotplug_add
+   rte_eal_hotplug_remove
rte_eal_init
rte_eal_iova_mode
+   rte_eal_lcore_role
rte_eal_mbuf_user_pool_ops
rte_eal_mp_remote_launch
rte_eal_mp_wait_lcore
rte_eal_process_type
rte_eal_remote_launch
-   rte_log
rte_eal_tailq_lookup
rte_eal_tailq_register
rte_eal_using_phys_addrs
+   rte_eal_wait_lcore
+   rte_exit
rte_free
+   rte_get_master_lcore
+   rte_get_next_lcore
rte_get_tsc_hz
rte_hexdump
+   rte_hypervisor_get
rte_intr_rx_ctl
+   rte_lcore_count
+   rte_lcore_has_role
+   rte_lcore_index
+   rte_lcore_is_enabled
+   rte_lcore_to_socket_id
+   rte_log
+   rte_log_cur_msg_loglevel
+   rte_log_cur_msg_logtype
+   rte_log_dump
+   rte_log_get_global_level
+   rte_log_get_level
+   rte_log_get_stream
rte_log_register
+   rte_log_set_global_level
rte_log_set_level
+   rte_log_set_level_pattern
+   rte_log_set_level_regexp
rte_malloc
rte_malloc_dump_stats
rte_malloc_get_socket_stats
@@ -52,6 +102,7 @@ EXPORTS
rte_mem_lock_page
rte_mem_virt2iova
rte_mem_virt2phy
+   rte_memdump
rte_memory_get_nchannel
rte_memory_get_nrank
rte_memzone_dump
@@ -61,15 +112,53 @@ EXPORTS
rte_memzone_reserve_aligned
rte_memzone_reserve_bounded
rte_memzone_walk
+   rte_openlog_stream
+   rte_realloc
+   rte_rtm_supported
+   rte_service_attr_get
+   rte_service_attr_reset_all
+   rte_service_component_register
+   rte_service_component_runstate_set
+   rte_service_component_unregister
+   rte_service_dump
+   rte_service_finalize
+   rte_service_get_by_name
+   rte_service_get_count
+   rte_service_get_name
+   rte_service_lcore_add
+   rte_service_lcore_attr_get
+   rte_service_lcore_attr_reset_all
+   rte_service_lcore_count
+   rte_service_lcore_count_services
+   rte_service_lcore_del
+   rte_service_lcore_list
+   rte_service_lcore_reset_all
+   rte_service_lcore_start
+   rte_service_lcore_stop
+   rte_service_map_lcore_get
+   rte_service_map_lcore_set
+   rte_service_may_be_active
+   rte_service_probe_capability
+   rte_service_run_iter_on_app_lcore
+   rte_service_runstate_get
+   rte_service_runstate_set
+   rte_service_set_runstate_mapped_check
+   rte_service_set_stats_enable
+   rte_service_start_with_defaults
+   rte_set_application_usage_hook
+   rte_socket_count
rte_socket_id
+   rte_socket_id_by_idx
rte_strerror
+   rte_strscpy
rte_strsplit
rte_sys_gettid
+   rte_thread_get_affinity
+   rte_thread_set_affinity
+   rte_thread_setname
rte_vfio_container_dma_map
rte_vfio_container_dma_unmap
rte_vlog
-   rte_realloc
-   rte_strscpy
rte_zmalloc
rte_zmalloc_socket
  
@@ -78,6 +167,8 @@ EXPORTS

rte_mp_reply
rte_mp_sendmsg
  
+	rte_dev_event_callback_register

+   rte_dev_event_callback_unregister
rte_fbarray_attach
rte_fbarray_destroy

[dpdk-dev] [PATCH 2/2] net/ring: prevent nodeaction arg create multiple ethdev

[Ferruh Yigit]

PMD accepts multiple 'nodeaction' arguments per vdev, for each instance
of the devarg an ethdev is created.
Like:
"--vdev net_ring0,nodeaction=r1:0:CREATE,nodeaction=r2:0:CREATE"
allocates two ethdevs.
Here ethdev names will be 'r1' and 'r2' respectively (each ethdev with
hardcoded number of queues).

If multiple ring ethdev is required, this can already be achieved by
providing multiple '--vdev'.

This patch updates the multiple 'nodeaction' arguments behavior, it now
creates single ethdev per a '--vdev' and each 'nodeaction' argument used
to define a queue of the ethdev. Number of 'nodeaction' argument defines
number of the queues in device.
Like for above sample:
"--vdev net_ring0,nodeaction=r1:0:CREATE,nodeaction=r2:0:CREATE",
creates an ethdev named 'net_ring0' with two queues from newly created
rings. Ring names are 'r1' and 'r2'.
For ethdev device 'node' and 'action' values are used from first
instance of the 'nodeaction' argument.

The behavior of the single 'nodeaction' argument behavior is slightly
changed, it now allocates (create or attach) single queue, instead of
hardcoded number of queues as done before.

The behavior without 'nodeaction' argument, "--vdev net_ring0", has not
been changed at all.

This also allows following, which was broken before:
"--vdev net_ring0,nodeaction=r1:0:CREATE,nodeaction=r2:0:CREATE \
--vdev net_ring1,nodeaction=r1:0:ATTACH,nodeaction=r2:0:ATTACH"

Signed-off-by: Ferruh Yigit 
---
 drivers/net/ring/rte_eth_ring.c | 53 +
 1 file changed, 40 insertions(+), 13 deletions(-)

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 6d3deaa81a..fd02c06c56 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -495,6 +495,38 @@ struct node_action_list {
struct node_action_pair *list;
 };
 
+static int
+eth_dev_ring_create_nodeaction(const char *name,
+   struct rte_vdev_device *vdev,
+   const unsigned int numa_node,
+   enum dev_action action,
+   struct rte_eth_dev **eth_dev,
+   struct node_action_list *info)
+{
+   struct rte_ring *rxtx[RTE_PMD_RING_MAX_RX_RINGS];
+   unsigned int num_rings;
+   unsigned int i;
+
+   num_rings = info->total;
+
+   for (i = 0; i < num_rings; i++) {
+   if (action == DEV_CREATE)
+   rxtx[i] = rte_ring_create(info->list[i].name, 1024,
+   numa_node,
+   RING_F_SP_ENQ|RING_F_SC_DEQ);
+   else
+   rxtx[i] = rte_ring_lookup(info->list[i].name);
+   if (rxtx[i] == NULL)
+   return -1;
+   }
+
+   if (do_eth_dev_ring_create(name, vdev, rxtx, num_rings, rxtx,
+   num_rings, numa_node, action, eth_dev) < 0)
+   return -1;
+
+   return 0;
+}
+
 static int parse_kvlist(const char *key __rte_unused,
const char *value, void *data)
 {
@@ -657,22 +689,17 @@ rte_pmd_ring_probe(struct rte_vdev_device *dev)
 
ret = rte_kvargs_process(kvlist, ETH_RING_NUMA_NODE_ACTION_ARG,
 parse_kvlist, info);
-
if (ret < 0)
goto out_free;
 
-   for (info->count = 0; info->count < info->total; info->count++) {
-   ret = eth_dev_ring_create(info->list[info->count].name, dev,
-   info->list[info->count].node,
-   info->list[info->count].action,
-   ð_dev);
-   if ((ret == -1) && (info->list[info->count].action == 
DEV_CREATE)) {
-   PMD_LOG(INFO, "Attach to pmd_ring for %s", name);
-   ret = eth_dev_ring_create(name, dev,
-   info->list[info->count].node,
-   DEV_ATTACH,
-   ð_dev);
-   }
+   ret = eth_dev_ring_create_nodeaction(name, dev,
+   info->list[0].node,
+   info->list[0].action, ð_dev, info);
+   if ((ret == -1) && (info->list[0].action == DEV_CREATE)) {
+   PMD_LOG(INFO, "Attach to pmd_ring for %s", name);
+   ret = eth_dev_ring_create_nodeaction(name, dev,
+   info->list[0].node,
+   DEV_ATTACH, ð_dev, info);
}
 
 out_free:
-- 
2.26.2

[dpdk-dev] [PATCH 1/2] net/ring: refactor to reduce indentation in probe

[Ferruh Yigit]

No functional change.

Signed-off-by: Ferruh Yigit 
---
 drivers/net/ring/rte_eth_ring.c | 137 +++-
 1 file changed, 66 insertions(+), 71 deletions(-)

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 83c5502123..6d3deaa81a 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -598,85 +598,80 @@ rte_pmd_ring_probe(struct rte_vdev_device *dev)
PMD_LOG(INFO, "Initializing pmd_ring for %s", name);
 
if (params == NULL || params[0] == '\0') {
-   ret = eth_dev_ring_create(name, dev, rte_socket_id(), 
DEV_CREATE,
-   ð_dev);
+   ret = eth_dev_ring_create(name, dev, rte_socket_id(),
+   DEV_CREATE, ð_dev);
if (ret == -1) {
-   PMD_LOG(INFO,
-   "Attach to pmd_ring for %s", name);
+   PMD_LOG(INFO, "Attach to pmd_ring for %s", name);
ret = eth_dev_ring_create(name, dev, rte_socket_id(),
- DEV_ATTACH, ð_dev);
+   DEV_ATTACH, ð_dev);
}
-   } else {
-   kvlist = rte_kvargs_parse(params, valid_arguments);
 
-   if (!kvlist) {
-   PMD_LOG(INFO,
-   "Ignoring unsupported parameters when 
creatingrings-backed ethernet device");
+   return ret;
+   }
+
+   kvlist = rte_kvargs_parse(params, valid_arguments);
+   if (!kvlist) {
+   PMD_LOG(INFO,
+   "Ignoring unsupported parameters when 
creatingrings-backed ethernet device");
+   ret = eth_dev_ring_create(name, dev, rte_socket_id(),
+   DEV_CREATE, ð_dev);
+   if (ret == -1) {
+   PMD_LOG(INFO, "Attach to pmd_ring for %s", name);
ret = eth_dev_ring_create(name, dev, rte_socket_id(),
- DEV_CREATE, ð_dev);
-   if (ret == -1) {
-   PMD_LOG(INFO,
-   "Attach to pmd_ring for %s",
-   name);
-   ret = eth_dev_ring_create(name, dev, 
rte_socket_id(),
- DEV_ATTACH, ð_dev);
-   }
-
-   return ret;
+   DEV_ATTACH, ð_dev);
}
 
-   if (rte_kvargs_count(kvlist, ETH_RING_INTERNAL_ARG) == 1) {
-   ret = rte_kvargs_process(kvlist, ETH_RING_INTERNAL_ARG,
-parse_internal_args,
-&internal_args);
-   if (ret < 0)
-   goto out_free;
-
-   ret = do_eth_dev_ring_create(name, dev,
-   internal_args->rx_queues,
-   internal_args->nb_rx_queues,
-   internal_args->tx_queues,
-   internal_args->nb_tx_queues,
-   internal_args->numa_node,
-   DEV_ATTACH,
+   return ret;
+   }
+
+   if (rte_kvargs_count(kvlist, ETH_RING_INTERNAL_ARG) == 1) {
+   ret = rte_kvargs_process(kvlist, ETH_RING_INTERNAL_ARG,
+parse_internal_args,
+&internal_args);
+   if (ret < 0)
+   goto out_free;
+
+   ret = do_eth_dev_ring_create(name, dev,
+   internal_args->rx_queues,
+   internal_args->nb_rx_queues,
+   internal_args->tx_queues,
+   internal_args->nb_tx_queues,
+   internal_args->numa_node,
+   DEV_ATTACH,
+   ð_dev);
+   if (ret >= 0)
+   ret = 0;
+   goto out_free;
+   }
+
+   ret = rte_kvargs_count(kvlist, ETH_RING_NUMA_NODE_ACTION_ARG);
+   info = rte_zmalloc("struct node_action_list",
+  sizeof(struct node_action_list) +
+  (sizeof(struct node_action_pair) * ret),
+  0);
+   if (!info)
+   goto out_free;
+
+   info->total = ret;
+   info->list = (struct node_action_pair *)(info + 1);
+
+   ret = rte_kvargs_process(kvlist, ETH_RING_NUMA_NODE_ACTION_ARG,
+parse_kvlist, info);
+
+   if (ret < 0)
+   goto out_free;
+
+   for (info->count = 0; info->count < info->total; info->count++) {
+   ret = eth_de

Re: [dpdk-dev] [PATCH] eal/windows: export all built functions for clang

[Tal Shnaiderman]

> From: Ranjit Menon 
> Subject: Re: [PATCH] eal/windows: export all built functions for clang 
> 
> Hi Tal,
> 
> On 10/2/2020 12:18 PM, Tal Shnaiderman wrote:
> > export for clang build all the functions currently built on Windows
> > and listed in rte_eal_version.map by adding them to
> > rte_eal_exports.def.
> >
> > Signed-off-by: Tal Shnaiderman 
> > ---
> 
> While you are at this, can we sort and re-order the functions alphabetically?
> 
> For instance, I can see some rte_fbarray*, rte_mem*, per_lcore* functions
> in multiple locations.
> 
> Also as an aside, Bruce (in cc:) had suggested in a private thread that we
> should start looking into auto-generating this .def file now that it has most 
> of
> the functions defined in the .map file.
> 
> ranjit m.

Hi Ranjit,

I tried to keep the file structure similar to the original rte_eal_version.map 
file, in the map file each DPDK release exported additional functions so the 
whole file isn't sorted but each release section is.

I not sure however if you can add the comments separating the sections to the 
def file.

Regarding autogenerating this file, there is actually an open task on it, MSFT 
team are on it and DmitryK even suggested a way to generate it using DUMPBIN, 
however until this is done we should have all the exported functions updated in 
the def file.

[dpdk-dev] [PATCH] net/failsafe: check correct error code while handling sub-device add

[Long Li]

From: Long Li 

When adding a sub-device, it's possible that the sub-device is configured
successfully but later fails to start. This error should not be masked.
The driver needs to check the error status to prevent endless loop of
trying to start the sub-device.

fixes (ae80146c5a1b net/failsafe: fix removed device handling)

cc: sta...@dpdk.org
Signed-off-by: Long Li 
---
 drivers/net/failsafe/failsafe_private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/failsafe/failsafe_private.h 
b/drivers/net/failsafe/failsafe_private.h
index 651578a..c58c0de 100644
--- a/drivers/net/failsafe/failsafe_private.h
+++ b/drivers/net/failsafe/failsafe_private.h
@@ -497,7 +497,7 @@ int failsafe_eth_new_event_callback(uint16_t port_id,
 fs_err(struct sub_device *sdev, int err)
 {
/* A device removal shouldn't be reported as an error. */
-   if (sdev->remove == 1 || err == -EIO)
+   if (sdev->remove == 1 && err == -EIO)
return rte_errno = 0;
return err;
 }
-- 
1.8.3.1