[dpdk-dev] [PATCH] rte_thash: replace license text with SPDX tag
Signed-off-by: Vladimir Medvedkin --- lib/librte_hash/rte_thash.h | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/lib/librte_hash/rte_thash.h b/lib/librte_hash/rte_thash.h index a6ddb7bf7..1b33f4813 100644 --- a/lib/librte_hash/rte_thash.h +++ b/lib/librte_hash/rte_thash.h @@ -1,34 +1,5 @@ -/*- - * BSD LICENSE - * - * Copyright(c) 2015 Vladimir Medvedkin - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * - * * Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * * Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in - * the documentation and/or other materials provided with the - * distribution. - * * Neither the name of Intel Corporation nor the names of its - * contributors may be used to endorse or promote products derived - * from this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS - * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT - * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR - * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT - * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, - * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT - * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE - * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2015-2019 Vladimir Medvedkin */ #ifndef _RTE_THASH_H -- 2.17.1 -- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
[dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM
Signed-off-by: Vladimir Medvedkin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 835d8a201..eef480ab5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1133,6 +1133,7 @@ F: test/test/test_func_reentrancy.c LPM M: Bruce Richardson +M: Vladimir Medvedkin F: lib/librte_lpm/ F: doc/guides/prog_guide/lpm* F: test/test/test_lpm* -- 2.17.1 -- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
[dpdk-dev] [PATCH] maintainers: claim maintainership of Toeplitz hash
Signed-off-by: Vladimir Medvedkin --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index eef480ab5..81affda53 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1131,6 +1131,9 @@ F: doc/guides/prog_guide/hash_lib.rst F: test/test/test_*hash* F: test/test/test_func_reentrancy.c +M: Vladimir Medvedkin +F: lib/librte_hash/rte_thash.h + LPM M: Bruce Richardson M: Vladimir Medvedkin -- 2.17.1 -- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
[dpdk-dev] DPDK techboard minutes of January 30
Meeting notes for the DPDK technical board meeting held on 2019-01-30 Attendees: 8/9 - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Thomas Monjalon 1) Windows compilers for DPDK Windows Port Techboard suggests using following tools for Windows development unless they are proven to not satisfying our needs: - Compiler: clang for Windows - Build system: meson - Development concerns: - Windows port should use common code as much as possible - If some part is not common for Windows, it needs to be reworked - Thomas will spend some time on Windows code reviews 2) Community Survey on Tools and Process Pain Points - Honnappa is managing the effort - Will go with two surveys, first one is for collecting problem statement - Second one will be for solutions - Questions will be both open ended and multiple choice - Deadline is February 6 3) Security Process - A draft is prepared by Thomas, need to work more on details on steps - Maxime will review draft and collect more information - Progress will be discussed in next techboard meeting 4) Google Summer Of Code - Stephen sent an email about it - Deadline is close - Maxime will follow the issue with Stephen 5) Next techboard meeting - It will be on February 13 - Hemant Agrawal will chair it 6) Next Meeting - Static Analysis Issues - Security Process - Google Summer Of Code
[dpdk-dev] [PATCH v2] test/pmd_perf: fix the way to drain the port
If the port has received less than ``pkt_per_port`` packets (for
example, the port has missed some packets), the test is in an infinite
loop.
Instead of expecting a number of packet to receive, let the port to be
drained by itself. If no more packets are received, the test can
continue.
Fixes: 002ade70e933 ("app/test: measure cycles per packet in Rx/Tx")
Cc: sta...@dpdk.org
Signed-off-by: Julien Meunier
---
v2:
* rename commit title
* fix nb_free display
---
test/test/test_pmd_perf.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/test/test/test_pmd_perf.c b/test/test/test_pmd_perf.c
index f5095c8..c7e2df3 100644
--- a/test/test/test_pmd_perf.c
+++ b/test/test/test_pmd_perf.c
@@ -493,16 +493,16 @@ main_loop(__rte_unused void *args)
for (i = 0; i < conf->nb_ports; i++) {
portid = conf->portlist[i];
- int nb_free = pkt_per_port;
+ int nb_free = 0;
do { /* dry out */
nb_rx = rte_eth_rx_burst(portid, 0,
pkts_burst, MAX_PKT_BURST);
nb_tx = 0;
while (nb_tx < nb_rx)
rte_pktmbuf_free(pkts_burst[nb_tx++]);
- nb_free -= nb_rx;
- } while (nb_free != 0);
- printf("free %d mbuf left in port %u\n", pkt_per_port, portid);
+ nb_free += nb_rx;
+ } while (nb_rx != 0);
+ printf("free %d mbuf left in port %u\n", nb_free, portid);
}
if (count == 0)
--
2.10.2
Re: [dpdk-dev] [Bug 204] Crash on Vmware esxi host when dpdk guest reboots.
Anything that crashes a host is a host bug. The host can never trust the guest to be well behaved. These are serious often with security implications. Hopefully VMware will or has already addressed it. On Sat, Feb 2, 2019, 6:18 AM https://bugs.dpdk.org/show_bug.cgi?id=204 > > Bug ID: 204 >Summary: Crash on Vmware esxi host when dpdk guest reboots. >Product: DPDK >Version: 18.11 > Hardware: x86 > OS: Other > Status: CONFIRMED > Severity: major > Priority: Normal > Component: core > Assignee: dev@dpdk.org > Reporter: girish_po...@affirmednetworks.com > Target Milestone: --- > > Running Vmware esxi 6.5 with i40en driver 1.7.11 . Guest running debian8.0 > with > either dpdk 18.05.1 or dpdk18.11 (lts) . > > When the guest is rebooted occasionally we see the crash on esxi host and > the > guest is shut down. > > vmware-9.log:2018-09-24T00:57:09.434Z| vmx| I120+ PCI passthru device > :03:0e.0 caused an IOMMU fault type 4 at address 0x7881ba04e3000. > Powering > off the virtual machine. If the problem persists please contact the > device's > vendor.``` > > The Device :03:0e.0 is a fortville 25g nic. The guests have vfs as > adapters > running dpdk. > > If we dont have dpdk running on guest(just the linux vfs driver) this > issue > doesnt happen on host. > > -- > You are receiving this mail because: > You are the assignee for the bug.
[dpdk-dev] [PATCH] kni: fix sprintf with snprintf
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: 3fc5ca2f63 ("kni: initial import")
Fixes: b9ee370557 ("kni: update kernel driver ethtool baseline")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
kernel/linux/kni/ethtool/igb/igb_ethtool.c| 41 +++
kernel/linux/kni/ethtool/igb/igb_main.c | 12 --
.../linux/kni/ethtool/ixgbe/ixgbe_ethtool.c | 30 --
3 files changed, 50 insertions(+), 33 deletions(-)
diff --git a/kernel/linux/kni/ethtool/igb/igb_ethtool.c
b/kernel/linux/kni/ethtool/igb/igb_ethtool.c
index b6bddc025..d82ecec41 100644
--- a/kernel/linux/kni/ethtool/igb/igb_ethtool.c
+++ b/kernel/linux/kni/ethtool/igb/igb_ethtool.c
@@ -2115,39 +2115,48 @@ static void igb_get_strings(struct net_device *netdev,
u32 stringset, u8 *data)
p += ETH_GSTRING_LEN;
}
for (i = 0; i < adapter->num_tx_queues; i++) {
- sprintf(p, "tx_queue_%u_packets", i);
+ snprintf(p, ETH_GSTRING_LEN, "tx_queue_%u_packets", i);
p += ETH_GSTRING_LEN;
- sprintf(p, "tx_queue_%u_bytes", i);
+ snprintf(p, ETH_GSTRING_LEN "tx_queue_%u_bytes", i);
p += ETH_GSTRING_LEN;
- sprintf(p, "tx_queue_%u_restart", i);
+ snprintf(p, ETH_GSTRING_LEN, "tx_queue_%u_restart", i);
p += ETH_GSTRING_LEN;
}
for (i = 0; i < adapter->num_rx_queues; i++) {
- sprintf(p, "rx_queue_%u_packets", i);
+ snprintf(p, ETH_GSTRING_LEN, "rx_queue_%u_packets", i);
p += ETH_GSTRING_LEN;
- sprintf(p, "rx_queue_%u_bytes", i);
+ snprintf(p, ETH_GSTRING_LEN, "rx_queue_%u_bytes", i);
p += ETH_GSTRING_LEN;
- sprintf(p, "rx_queue_%u_drops", i);
+ snprintf(p, ETH_GSTRING_LEN, "rx_queue_%u_drops", i);
p += ETH_GSTRING_LEN;
- sprintf(p, "rx_queue_%u_csum_err", i);
+ snprintf(p, ETH_GSTRING_LEN, "rx_queue_%u_csum_err", i);
p += ETH_GSTRING_LEN;
- sprintf(p, "rx_queue_%u_alloc_failed", i);
+ snprintf(p, ETH_GSTRING_LEN, "rx_queue_%u_alloc_failed",
+ i);
p += ETH_GSTRING_LEN;
- sprintf(p, "rx_queue_%u_ipv4_packets", i);
+ snprintf(p, ETH_GSTRING_LEN, "rx_queue_%u_ipv4_packets",
+ i);
p += ETH_GSTRING_LEN;
- sprintf(p, "rx_queue_%u_ipv4e_packets", i);
+ snprintf(p, ETH_GSTRING_LEN,
+ "rx_queue_%u_ipv4e_packets", i);
p += ETH_GSTRING_LEN;
- sprintf(p, "rx_queue_%u_ipv6_packets", i);
+ snprintf(p, ETH_GSTRING_LEN, "rx_queue_%u_ipv6_packets",
+ i);
p += ETH_GSTRING_LEN;
- sprintf(p, "rx_queue_%u_ipv6e_packets", i);
+ snprintf(p, ETH_GSTRING_LEN,
+ "rx_queue_%u_ipv6e_packets", i);
p += ETH_GSTRING_LEN;
- sprintf(p, "rx_queue_%u_tcp_packets", i);
+ snprintf(p, ETH_GSTRING_LEN, "rx_queue_%u_tcp_packets",
+ i);
p += ETH_GSTRING_LEN;
- sprintf(p, "rx_queue_%u_udp_packets", i);
+ snprintf(p, ETH_GSTRING_LEN, "rx_queue_%u_udp_packets",
+ i);
p += ETH_GSTRING_LEN;
- sprintf(p, "rx_queue_%u_sctp_packets", i);
+ snprintf(p, ETH_GSTRING_LEN, "rx_queue_%u_sctp_packets",
+ i);
p += ETH_GSTRING_LEN;
- sprintf(p, "rx_queue_%u_nfs_packets", i);
+ snprintf(p, ETH_GSTRING_LEN, "rx_queue_%u_nfs_packets",
+ i);
p += ETH_GSTRING_LEN;
}
/* BUG_ON(p - data != IGB_STATS_LEN * ETH_GSTRING_LEN); */
diff --git a/kernel/linux/kni/ethtool/igb/igb_main.c
b/kernel/linux/kni/ethtool/igb/igb_main.c
index 0b4faeae5..e6765b4dd 100644
--- a/kernel/linux/kni/ethtool/igb/igb_main.c
+++ b/kernel/linux/kni/ethtool/igb/igb_main.c
@@ -679,16 +679,20 @@ static int igb_request_msix(struct igb_adapter *adapter)
q_vector->itr_register = hw->hw_addr + E1000_EITR(vector);
[dpdk-dev] [PATCH] app/testbbdev: fix sprintf with snprintf
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: f714a18885 ("app/testbbdev: add test application for bbdev")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
app/test-bbdev/test_bbdev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/test-bbdev/test_bbdev.c b/app/test-bbdev/test_bbdev.c
index a914817bc..b9fc750d3 100644
--- a/app/test-bbdev/test_bbdev.c
+++ b/app/test-bbdev/test_bbdev.c
@@ -788,14 +788,14 @@ test_bbdev_driver_init(void)
/* Initialize the maximum amount of devices */
do {
- sprintf(name_tmp, "%s%i", "name_", num_devs);
+ snprintf(name_tmp, sizeof(name_tmp), "%s%i", "name_", num_devs);
dev2 = rte_bbdev_allocate(name_tmp);
TEST_ASSERT(dev2 != NULL,
"Failed to initialize bbdev driver");
++num_devs;
} while (num_devs < (RTE_BBDEV_MAX_DEVS - 1));
- sprintf(name_tmp, "%s%i", "name_", num_devs);
+ snprintf(name_tmp, sizeof(name_tmp), "%s%i", "name_", num_devs);
dev2 = rte_bbdev_allocate(name_tmp);
TEST_ASSERT(dev2 == NULL, "Failed to initialize bbdev driver number %d "
"more drivers than RTE_BBDEV_MAX_DEVS: %d ", num_devs,
@@ -804,7 +804,7 @@ test_bbdev_driver_init(void)
num_devs--;
while (num_devs >= num_devs_tmp) {
- sprintf(name_tmp, "%s%i", "name_", num_devs);
+ snprintf(name_tmp, sizeof(name_tmp), "%s%i", "name_", num_devs);
dev2 = rte_bbdev_get_named_dev(name_tmp);
TEST_ASSERT_SUCCESS(rte_bbdev_release(dev2),
"Failed to uninitialize bbdev driver %s ",
@@ -825,7 +825,7 @@ test_bbdev_driver_init(void)
TEST_ASSERT_FAIL(rte_bbdev_release(NULL),
"Failed to uninitialize bbdev driver with NULL bbdev");
- sprintf(name_tmp, "%s", "invalid_name");
+ snprintf(name_tmp, sizeof(name_tmp), "%s", "invalid_name");
dev2 = rte_bbdev_get_named_dev(name_tmp);
TEST_ASSERT_FAIL(rte_bbdev_release(dev2),
"Failed to uninitialize bbdev driver with invalid
name");
--
2.17.2
[dpdk-dev] [PATCH] event/opdl: fix sprintf with snprintf
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: 3c7f3dcfb0 ("event/opdl: add PMD main body and helper function")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
drivers/event/opdl/opdl_evdev.c| 7 ---
drivers/event/opdl/opdl_evdev_xstats.c | 7 +++
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c
index a4f0bc8b6..d2d2be44b 100644
--- a/drivers/event/opdl/opdl_evdev.c
+++ b/drivers/event/opdl/opdl_evdev.c
@@ -422,16 +422,17 @@ opdl_dump(struct rte_eventdev *dev, FILE *f)
else
p_type = "";
- sprintf(queue_id, "%02u", port->external_qid);
+ snprintf(queue_id, sizeof(queue_id), "%02u",
+ port->external_qid);
if (port->p_type == OPDL_REGULAR_PORT ||
port->p_type == OPDL_ASYNC_PORT)
- sprintf(total_cyc,
+ snprintf(total_cyc, sizeof(total_cyc),
" %'16"PRIu64"",
(cpg != 0 ?
port->port_stat[total_cycles] / cpg
: 0));
else
- sprintf(total_cyc,
+ snprintf(total_cyc, sizeof(total_cyc),
" ");
fprintf(f,
"%4s %10u %8u %9s %'16"PRIu64" %'16"PRIu64" %s "
diff --git a/drivers/event/opdl/opdl_evdev_xstats.c
b/drivers/event/opdl/opdl_evdev_xstats.c
index 0e6c6bd5e..27b3d8802 100644
--- a/drivers/event/opdl/opdl_evdev_xstats.c
+++ b/drivers/event/opdl/opdl_evdev_xstats.c
@@ -32,10 +32,9 @@ opdl_xstats_init(struct rte_eventdev *dev)
uint32_t index = (i * max_num_port_xstat) + j;
/* Name */
- sprintf(device->port_xstat[index].stat.name,
- "port_%02u_%s",
- i,
- port_xstat_str[j]);
+ snprintf(device->port_xstat[index].stat.name,
+ sizeof(device->port_xstat[index].stat.name),
+ "port_%02u_%s", i, port_xstat_str[j]);
/* ID */
device->port_xstat[index].id = index;
--
2.17.2
[dpdk-dev] [PATCH] net/nfp: fix sprintf with snprintf
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: 896c265ef9 ("net/nfp: use new CPP interface")
Fixes: c4171b520b ("net/nfp: support PF multiport")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
drivers/net/nfp/nfp_net.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index a791e95e2..dd8cae135 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -3318,9 +3318,9 @@ nfp_pf_create_dev(struct rte_pci_device *dev, int port,
int ports,
return -ENOMEM;
if (ports > 1)
- sprintf(port_name, "%s_port%d", dev->device.name, port);
+ snprintf(port_name, 100, "%s_port%d", dev->device.name, port);
else
- sprintf(port_name, "%s", dev->device.name);
+ snprintf(port_name, 100, "%s", dev->device.name);
if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
@@ -3433,12 +3433,14 @@ nfp_fw_upload(struct rte_pci_device *dev, struct
nfp_nsp *nsp, char *card)
/* Looking for firmware file in order of priority */
/* First try to find a firmware image specific for this device */
- sprintf(serial, "serial-%02x-%02x-%02x-%02x-%02x-%02x-%02x-%02x",
+ snprintf(serial, sizeof(serial),
+ "serial-%02x-%02x-%02x-%02x-%02x-%02x-%02x-%02x",
cpp->serial[0], cpp->serial[1], cpp->serial[2], cpp->serial[3],
cpp->serial[4], cpp->serial[5], cpp->interface >> 8,
cpp->interface & 0xff);
- sprintf(fw_name, "%s/%s.nffw", DEFAULT_FW_PATH, serial);
+ snprintf(fw_name, sizeof(fw_name), "%s/%s.nffw", DEFAULT_FW_PATH,
+ serial);
PMD_DRV_LOG(DEBUG, "Trying with fw file: %s", fw_name);
fw_f = open(fw_name, O_RDONLY);
@@ -3446,7 +3448,8 @@ nfp_fw_upload(struct rte_pci_device *dev, struct nfp_nsp
*nsp, char *card)
goto read_fw;
/* Then try the PCI name */
- sprintf(fw_name, "%s/pci-%s.nffw", DEFAULT_FW_PATH, dev->device.name);
+ snprintf(fw_name, sizeof(fw_name), "%s/pci-%s.nffw", DEFAULT_FW_PATH,
+ dev->device.name);
PMD_DRV_LOG(DEBUG, "Trying with fw file: %s", fw_name);
fw_f = open(fw_name, O_RDONLY);
@@ -3454,7 +3457,7 @@ nfp_fw_upload(struct rte_pci_device *dev, struct nfp_nsp
*nsp, char *card)
goto read_fw;
/* Finally try the card type and media */
- sprintf(fw_name, "%s/%s", DEFAULT_FW_PATH, card);
+ snprintf(fw_name, sizeof(fw_name), "%s/%s", DEFAULT_FW_PATH, card);
PMD_DRV_LOG(DEBUG, "Trying with fw file: %s", fw_name);
fw_f = open(fw_name, O_RDONLY);
if (fw_f < 0) {
@@ -3530,8 +3533,9 @@ nfp_fw_setup(struct rte_pci_device *dev, struct nfp_cpp
*cpp,
PMD_DRV_LOG(INFO, "Port speed: %u", nfp_eth_table->ports[0].speed);
- sprintf(card_desc, "nic_%s_%dx%d.nffw", nfp_fw_model,
- nfp_eth_table->count, nfp_eth_table->ports[0].speed / 1000);
+ snprintf(card_desc, sizeof(card_desc), "nic_%s_%dx%d.nffw",
+ nfp_fw_model, nfp_eth_table->count,
+ nfp_eth_table->ports[0].speed / 1000);
nsp = nfp_nsp_open(cpp);
if (!nsp) {
--
2.17.2
[dpdk-dev] [PATCH] net/softnic: fix sprintf with snprintf
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: daabf2fb94 ("net/softnic: map flow action to table action")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
drivers/net/softnic/rte_eth_softnic_flow.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c
b/drivers/net/softnic/rte_eth_softnic_flow.c
index 21e753001..aefc384dc 100644
--- a/drivers/net/softnic/rte_eth_softnic_flow.c
+++ b/drivers/net/softnic/rte_eth_softnic_flow.c
@@ -1283,7 +1283,8 @@ flow_rule_action_get(struct pmd_internals *softnic,
action,
"QUEUE: Invalid RX queue ID");
- sprintf(name, "RXQ%u", (uint32_t)conf->index);
+ snprintf(name, sizeof(name), "RXQ%u",
+ (uint32_t)conf->index);
status = softnic_pipeline_port_out_find(softnic,
pipeline->name,
@@ -1373,7 +1374,7 @@ flow_rule_action_get(struct pmd_internals *softnic,
action,
"RSS: Invalid RX queue ID");
- sprintf(name, "RXQ%u",
+ snprintf(name, sizeof(name), "RXQ%u",
(uint32_t)conf->queue[i]);
status = softnic_pipeline_port_out_find(softnic,
--
2.17.2
[dpdk-dev] [PATCH] power: fix sprintf with snprintf
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: 450f079131 ("power: add traffic pattern aware power control")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
lib/librte_power/rte_power_empty_poll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_power/rte_power_empty_poll.c
b/lib/librte_power/rte_power_empty_poll.c
index e6145462f..df00a3968 100644
--- a/lib/librte_power/rte_power_empty_poll.c
+++ b/lib/librte_power/rte_power_empty_poll.c
@@ -159,7 +159,7 @@ update_training_stats(struct priority_worker *poll_stats,
char pfi_str[32];
uint64_t p0_empty_deq;
- sprintf(pfi_str, "%02d", freq);
+ snprintf(pfi_str, sizeof(pfi_str), "%02d", freq);
if (poll_stats->cur_freq == freq &&
poll_stats->thresh[freq].trained == false) {
--
2.17.2
[dpdk-dev] [PATCH] vhost: fix sprintf with snprintf
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.
Fixes: d7280c9fff ("vhost: support selective datapath")
Cc: sta...@dpdk.org
Signed-off-by: Pallantla Poornima
---
lib/librte_vhost/vdpa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c
index 02083bb8a..fcc2c73a3 100644
--- a/lib/librte_vhost/vdpa.c
+++ b/lib/librte_vhost/vdpa.c
@@ -66,7 +66,7 @@ rte_vdpa_register_device(struct rte_vdpa_dev_addr *addr,
if (i == MAX_VHOST_DEVICE)
return -1;
- sprintf(device_name, "vdpa-dev-%d", i);
+ snprintf(device_name, sizeof(device_name), "vdpa-dev-%d", i);
dev = rte_zmalloc(device_name, sizeof(struct rte_vdpa_device),
RTE_CACHE_LINE_SIZE);
if (!dev)
--
2.17.2
[dpdk-dev] A Question about the necessity of DPDK VF for Ethernet PMDs
Hello all, Now that DPDK 19.02 was released three days ago (on time!!), hopefully there will be time for people to answer the following question: According to the "DPDK Getting Started Guide", "If UEFI secure boot is enabled, the Linux kernel may disallow the use of UIO on the system. Therefore, devices for use by DPDK should be bound to the vfio-pci kernel module rather than igb_uio or uio_pci_generic. For more details see Binding and Unbinding Network Ports to/from the Kernel Modules." See: http://doc.dpdk.org/guides/linux_gsg/sys_reqs.html#bios-setting-prerequisite-on-x86 Now, when you bind a PCI device with vfio-pci, then the "max_vfs" entry is *not* created under /sys/bus/pci/devices// (as opposed to the case when you bind with igb_uio). This means that you cannot create DPDK VFS in this case (as you cannot write num_vfs to the non existing max_vfs entry). You can however create Kernel VFs (by echoing into the sriov_num_vfs sysfs entry). So I assume there are deployments of DPDK (with secure boot) when the PMDs are being binded not by igb_uio but by vfio_pci. So the question is: As explained above, t probably there are setups when you cannot generated PMD VFs. Most PMD Ethernet Vendors *do* provide VF PMDs in the DPDK official repo; but what are the benefits of providing DPDK VFs PMD? is it mandatory in some use cases ? Is there any advantage for using a DPDK PF/DPDK VF combination over using Kernel VF? Regards, Rami Rosen
