[dpdk-dev] [PATCH] net/e1000: correct queue number in RSS configuration

[Beilei Xing]

RSS configuration works for all e1000 NICs except 82576.
This patch fixes this issue by correcting queue number
in RSS configuration.

Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API")
Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
Cc: sta...@dpdk.org

Signed-off-by: Beilei Xing 
---
 drivers/net/e1000/e1000_ethdev.h |  6 --
 drivers/net/e1000/igb_flow.c | 10 +++---
 drivers/net/e1000/igb_rxtx.c | 12 +---
 3 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/drivers/net/e1000/e1000_ethdev.h b/drivers/net/e1000/e1000_ethdev.h
index 902001f..94edff0 100644
--- a/drivers/net/e1000/e1000_ethdev.h
+++ b/drivers/net/e1000/e1000_ethdev.h
@@ -236,7 +236,8 @@ struct igb_ethertype_filter {
 struct igb_rte_flow_rss_conf {
struct rte_flow_action_rss conf; /**< RSS parameters. */
uint8_t key[IGB_HKEY_MAX_INDEX * sizeof(uint32_t)]; /* Hash key. */
-   uint16_t queue[IGB_MAX_RX_QUEUE_NUM]; /**< Queues indices to use. */
+   /* Queues indices to use. */
+   uint16_t queue[IGB_MAX_RX_QUEUE_NUM_82576];
 };
 
 /*
@@ -506,7 +507,8 @@ int eth_igb_syn_filter_set(struct rte_eth_dev *dev,
 int eth_igb_add_del_flex_filter(struct rte_eth_dev *dev,
struct rte_eth_flex_filter *filter,
bool add);
-int igb_rss_conf_init(struct igb_rte_flow_rss_conf *out,
+int igb_rss_conf_init(struct rte_eth_dev *dev,
+ struct igb_rte_flow_rss_conf *out,
  const struct rte_flow_action_rss *in);
 int igb_action_rss_same(const struct rte_flow_action_rss *comp,
const struct rte_flow_action_rss *with);
diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c
index 0738529..3368349 100644
--- a/drivers/net/e1000/igb_flow.c
+++ b/drivers/net/e1000/igb_flow.c
@@ -1307,6 +1307,7 @@ igb_parse_rss_filter(struct rte_eth_dev *dev,
struct igb_rte_flow_rss_conf *rss_conf,
struct rte_flow_error *error)
 {
+   struct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
const struct rte_flow_action *act;
const struct rte_flow_action_rss *rss;
uint16_t n, index;
@@ -1357,11 +1358,14 @@ igb_parse_rss_filter(struct rte_eth_dev *dev,
return rte_flow_error_set
(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,
 "RSS hash key must be exactly 40 bytes");
-   if (rss->queue_num > RTE_DIM(rss_conf->queue))
+   if (((hw->mac.type == e1000_82576) &&
+(rss->queue_num > IGB_MAX_RX_QUEUE_NUM_82576)) ||
+   ((hw->mac.type != e1000_82576) &&
+(rss->queue_num > IGB_MAX_RX_QUEUE_NUM)))
return rte_flow_error_set
(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,
 "too many queues for RSS context");
-   if (igb_rss_conf_init(rss_conf, rss))
+   if (igb_rss_conf_init(dev, rss_conf, rss))
return rte_flow_error_set
(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, act,
 "RSS context initialization failure");
@@ -1574,7 +1578,7 @@ igb_flow_create(struct rte_eth_dev *dev,
PMD_DRV_LOG(ERR, "failed to allocate memory");
goto out;
}
-   igb_rss_conf_init(&rss_filter_ptr->filter_info,
+   igb_rss_conf_init(dev, &rss_filter_ptr->filter_info,
  &rss_conf.conf);
TAILQ_INSERT_TAIL(&igb_filter_rss_list,
rss_filter_ptr, entries);
diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index b955068..dce42e6 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -2852,11 +2852,17 @@ igb_txq_info_get(struct rte_eth_dev *dev, uint16_t 
queue_id,
 }
 
 int
-igb_rss_conf_init(struct igb_rte_flow_rss_conf *out,
+igb_rss_conf_init(struct rte_eth_dev *dev,
+ struct igb_rte_flow_rss_conf *out,
  const struct rte_flow_action_rss *in)
 {
+   struct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
if (in->key_len > RTE_DIM(out->key) ||
-   in->queue_num > RTE_DIM(out->queue))
+   ((hw->mac.type == e1000_82576) &&
+(in->queue_num > IGB_MAX_RX_QUEUE_NUM_82576)) ||
+   ((hw->mac.type != e1000_82576) &&
+(in->queue_num > IGB_MAX_RX_QUEUE_NUM)))
return -EINVAL;
out->conf = (struct rte_flow_action_rss){
.func = in->func,
@@ -2945,7 +2951,7 @@ igb_config_rss_filter(struct rte_eth_dev *dev,
rss_conf.rss_key = rss_intel_key; /* Default hash key */
igb_hw_rss_hash_set(hw, &rss_conf);
 
-   if (igb_rss_conf_init(&filter_info->rss_info, &conf->conf))
+   if (i

Re: [dpdk-dev] [PATCH] net/ifc: do not notify before HW ready

[Wang, Xiao W]

Hi Xiaolong,

> -Original Message-
> From: Ye, Xiaolong
> Sent: Thursday, September 13, 2018 8:55 PM
> To: Wang, Xiao W 
> Cc: Bie, Tiwei ; dev@dpdk.org
> Subject: Re: [PATCH] net/ifc: do not notify before HW ready
> 
> Hi, Xiao
> 
> On 09/10, Xiao Wang wrote:
> >Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> 
> Could you help describe what problem is without this fix in commit log?

Generally a driver should finish all the device configurations first then 
notify the HW for data processing.
Without this fix, the potential problems are:
1. If the device is not clearly reset by the previous driver and holds some 
invalid ring addr, and the vDPA relay thread kicks it, a bad DMA request may 
happen.
2. The notify_addr which is used by the relay thread is set in the 
vdpa_ifcvf_start function. If there's really a kick relay before 
vdpa_ifcvf_start finishes, a null addr is accessed.

Would add the description in the commit log in v2.

Thanks for the comment,
Xiao
> 
> Thanks,
> Xiaolong
> >
> >Signed-off-by: Xiao Wang 
> >---
> > drivers/net/ifc/ifcvf_vdpa.c | 8 
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> >diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c
> >index 3c5430dc0..7d3085d8d 100644
> >--- a/drivers/net/ifc/ifcvf_vdpa.c
> >+++ b/drivers/net/ifc/ifcvf_vdpa.c
> >@@ -503,11 +503,11 @@ update_datapath(struct ifcvf_internal *internal)
> > if (ret)
> > goto err;
> >
> >-ret = setup_notify_relay(internal);
> >+ret = vdpa_ifcvf_start(internal);
> > if (ret)
> > goto err;
> >
> >-ret = vdpa_ifcvf_start(internal);
> >+ret = setup_notify_relay(internal);
> > if (ret)
> > goto err;
> >
> >@@ -515,12 +515,12 @@ update_datapath(struct ifcvf_internal *internal)
> > } else if (rte_atomic32_read(&internal->running) &&
> >(!rte_atomic32_read(&internal->started) ||
> > !rte_atomic32_read(&internal->dev_attached))) {
> >-vdpa_ifcvf_stop(internal);
> >-
> > ret = unset_notify_relay(internal);
> > if (ret)
> > goto err;
> >
> >+vdpa_ifcvf_stop(internal);
> >+
> > ret = vdpa_disable_vfio_intr(internal);
> > if (ret)
> > goto err;
> >--
> >2.15.1
> >

Re: [dpdk-dev] [PATCH 00/16] Support externally allocated memory in DPDK

[Shahaf Shuler]

Hi Anatoly,

First thanks for the patchset, it is a great enhancement. 

See question below. 

Tuesday, September 4, 2018 4:12 PM, Anatoly Burakov:
> Subject: [dpdk-dev] [PATCH 00/16] Support externally allocated memory in
> DPDK
> 
> This is a proposal to enable using externally allocated memory in DPDK.
> 
> In a nutshell, here is what is being done here:
> 
> - Index internal malloc heaps by NUMA node index, rather than NUMA
>   node itself (external heaps will have ID's in order of creation)
> - Add identifier string to malloc heap, to uniquely identify it
>   - Each new heap will receive a unique socket ID that will be used by
> allocator to decide from which heap (internal or external) to
> allocate requested amount of memory
> - Allow creating named heaps and add/remove memory to/from those
> heaps
> - Allocate memseg lists at runtime, to keep track of IOVA addresses
>   of externally allocated memory
>   - If IOVA addresses aren't provided, use RTE_BAD_IOVA
> - Allow malloc and memzones to allocate from external heaps
> - Allow other data structures to allocate from externall heaps
> 
> The responsibility to ensure memory is accessible before using it is on the
> shoulders of the user - there is no checking done with regards to validity of
> the memory (nor could there be...).

That makes sense. However who should be in-charge of mapping this memory for 
dma access?
The user or internally be the PMD when encounter the first packet or while 
traversing the existing mempools? 

> 
> The general approach is to create heap and add memory into it. For any other
> process wishing to use the same memory, said memory must first be
> attached (otherwise some things will not work).
> 
> A design decision was made to make multiprocess synchronization a manual
> process. Due to underlying issues with attaching to fbarrays in secondary
> processes, this design was deemed to be better because we don't want to
> fail to create external heap in the primary because something in the
> secondary has failed when in fact we may not eve have wanted this memory
> to be accessible in the secondary in the first place.
> 
> Using external memory in multiprocess is *hard*, because not only memory
> space needs to be preallocated, but it also needs to be attached in each
> process to allow other processes to access the page table. The attach API call
> may or may not succeed, depending on memory layout, for reasons similar to
> other multiprocess failures. This is treated as a "known issue" for this 
> release.
> 
> RFC -> v1 changes:
> - Removed the "named heaps" API, allocate using fake socket ID instead
> - Added multiprocess support
> - Everything is now thread-safe
> - Numerous bugfixes and API improvements
> 
> Anatoly Burakov (16):
>   mem: add length to memseg list
>   mem: allow memseg lists to be marked as external
>   malloc: index heaps using heap ID rather than NUMA node
>   mem: do not check for invalid socket ID
>   flow_classify: do not check for invalid socket ID
>   pipeline: do not check for invalid socket ID
>   sched: do not check for invalid socket ID
>   malloc: add name to malloc heaps
>   malloc: add function to query socket ID of named heap
>   malloc: allow creating malloc heaps
>   malloc: allow destroying heaps
>   malloc: allow adding memory to named heaps
>   malloc: allow removing memory from named heaps
>   malloc: allow attaching to external memory chunks
>   malloc: allow detaching from external memory
>   test: add unit tests for external memory support
> 
>  config/common_base|   1 +
>  config/rte_config.h   |   1 +
>  drivers/bus/fslmc/fslmc_vfio.c|   7 +-
>  drivers/bus/pci/linux/pci.c   |   2 +-
>  drivers/net/mlx4/mlx4_mr.c|   3 +
>  drivers/net/mlx5/mlx5.c   |   5 +-
>  drivers/net/mlx5/mlx5_mr.c|   3 +
>  drivers/net/virtio/virtio_user/vhost_kernel.c |   5 +-
>  lib/librte_eal/bsdapp/eal/eal.c   |   3 +
>  lib/librte_eal/bsdapp/eal/eal_memory.c|   9 +-
>  lib/librte_eal/common/eal_common_memory.c |   9 +-
>  lib/librte_eal/common/eal_common_memzone.c|   8 +-
>  .../common/include/rte_eal_memconfig.h|   6 +-
>  lib/librte_eal/common/include/rte_malloc.h| 181 +
>  .../common/include/rte_malloc_heap.h  |   3 +
>  lib/librte_eal/common/include/rte_memory.h|   9 +
>  lib/librte_eal/common/malloc_heap.c   | 287 +++--
>  lib/librte_eal/common/malloc_heap.h   |  17 +
>  lib/librte_eal/common/rte_malloc.c| 383 -
>  lib/librte_eal/linuxapp/eal/eal.c |   3 +
>  lib/librte_eal/linuxapp/eal/eal_memalloc.c|  12 +-
>  lib/librte_eal/linuxapp/eal/eal_memory.c  |   4 +-
>  lib/librte_eal/linuxapp/eal/eal_vfio.c|  17 +-
>  lib/librte_eal/rte_eal_version.map|   7 +
>  lib/librte_flow_classify/rte_flow_cl

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: add multi-core support

[Maxime Coquelin]

On 06/22/2018 02:36 PM, Fan Zhang wrote:

Originally vhost_crypto sample application only supports single
core. This patch adds the multi-core support with more flexible
options.

Signed-off-by: Fan Zhang 
---
  doc/guides/sample_app_ug/vhost_crypto.rst |  26 +-
  examples/vhost_crypto/main.c  | 480 +-
  2 files changed, 282 insertions(+), 224 deletions(-)



Applied to dpdk-next-virtio/master.

Thanks,
Maxime

Re: [dpdk-dev] [PATCH 2/8] net/ixgbe/base: cleanup codes

[Ferruh Yigit]

On 9/10/2018 5:37 PM, Xiaoyun Li wrote:
> Cleanup UNREFERENCED_1PARAMETER() macro because "hw" is used.
> And remove Light Spring codes because the device was never
> productised. And cleanup unused bypass codes.
> 
> Signed-off-by: Xiaoyun Li 

This patch breaks the build because IXGBE_DEV_ID_82599_LS removed, the code
using it removed at patch 7/8 but in between build is broken.

Please send a new version patches re-arranged, thanks.

Re: [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir

[Bruce Richardson]

On Wed, Sep 12, 2018 at 06:21:34PM +0100, Luca Boccassi wrote:
> Add -r option to ln, otherwise the link will be absolute and contain
> the build path and break packaging among other things:
> 
> lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
>   -> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
>  drivers/librte_mempool_dpaa.so.1.1
> 
> With -r:
> 
> lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
>   -> dpdk/drivers/librte_pmd_zlib.so.1.1
> 
> Fixes: ed4d43d73e2b ("build: symlink drivers to library directory")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Luca Boccassi 
> ---
>  buildtools/symlink-drivers-solibs.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/buildtools/symlink-drivers-solibs.sh 
> b/buildtools/symlink-drivers-solibs.sh
> index 803dfec491..9826c6ae37 100644
> --- a/buildtools/symlink-drivers-solibs.sh
> +++ b/buildtools/symlink-drivers-solibs.sh
> @@ -9,4 +9,4 @@
>  # parameters to script are paths relative to install prefix:
>  # 1. directory containing driver files e.g. lib64/dpdk/drivers
>  # 2. directory for installed regular libs e.g. lib64
> -ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* 
> ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
> +ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* 
> ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
> -- 

Acked-by: Bruce Richardson 

Re: [dpdk-dev] [PATCH v5 07/11] net/virtio: implement transmit path for packed queues

[Tiwei Bie]

On Thu, Sep 06, 2018 at 07:19:43PM +0100, Jens Freimann wrote:
> This implements the transmit path for devices with
> support for packed virtqueues.
> 
> Add the feature bit and enable code to
> add buffers to vring and mark descriptors as available.
> 
> Signed-off-by: Jens Freiman 
> ---
>  drivers/net/virtio/virtio_ethdev.c |   8 +-
>  drivers/net/virtio/virtio_ethdev.h |   2 +
>  drivers/net/virtio/virtio_rxtx.c   | 113 -
>  3 files changed, 121 insertions(+), 2 deletions(-)
[...]
> +
> +uint16_t
> +virtio_xmit_pkts_packed(void *tx_queue, struct rte_mbuf **tx_pkts,
> +  uint16_t nb_pkts)
> +{
> + struct virtnet_tx *txvq = tx_queue;
> + struct virtqueue *vq = txvq->vq;
> + uint16_t i;
> + struct vring_desc_packed *desc = vq->vq_ring.desc_packed;
> + uint16_t idx, prev;
> + struct vq_desc_extra *dxp;
> +
> + if (unlikely(nb_pkts < 1))
> + return nb_pkts;
> +
> + PMD_TX_LOG(DEBUG, "%d packets to xmit", nb_pkts);
> +
> + if (likely(vq->vq_free_cnt < vq->vq_free_thresh))
> + virtio_xmit_cleanup_packed(vq);
> +
> + for (i = 0; i < nb_pkts; i++) {
> + struct rte_mbuf *txm = tx_pkts[i];
> + struct virtio_tx_region *txr = txvq->virtio_net_hdr_mz->addr;
> + uint16_t head_idx;
> + int wrap_counter;
> + int descs_used;
> +
> + if (unlikely(txm->nb_segs + 1 > vq->vq_free_cnt)) {
> + virtio_xmit_cleanup_packed(vq);
> +
> + if (unlikely(txm->nb_segs + 1 > vq->vq_free_cnt)) {
> + PMD_TX_LOG(ERR,
> +"No free tx descriptors to 
> transmit");
> + break;
> + }
> + }
> +
> + txvq->stats.bytes += txm->pkt_len;
> +

We also need to update the stats by calling
virtio_update_packet_stats()

We also need to handle the offloads. See
virtqueue_xmit_offload().

> + vq->vq_free_cnt -= txm->nb_segs + 1;
> +
> + wrap_counter = vq->vq_ring.avail_wrap_counter;
> + idx = vq->vq_avail_idx; 
> + head_idx = idx;
> +
> + dxp = &vq->vq_descx[idx];
> + if (dxp->cookie != NULL)
> + rte_pktmbuf_free(dxp->cookie);
> + dxp->cookie = txm;
> +
> + desc[idx].addr  = txvq->virtio_net_hdr_mem +
> +   RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
> + desc[idx].len   = vq->hw->vtnet_hdr_size;
> + desc[idx].flags = VRING_DESC_F_NEXT |
> + VRING_DESC_F_AVAIL(vq->vq_ring.avail_wrap_counter) |
> + VRING_DESC_F_USED(!vq->vq_ring.avail_wrap_counter);
> + descs_used = 1;
> +
> + do {
> + idx = update_pq_avail_index(vq);
> + desc[idx].addr  = VIRTIO_MBUF_DATA_DMA_ADDR(txm, vq);
> + desc[idx].len   = txm->data_len;
> + desc[idx].flags = VRING_DESC_F_NEXT |
> + 
> VRING_DESC_F_AVAIL(vq->vq_ring.avail_wrap_counter) |
> + 
> VRING_DESC_F_USED(!vq->vq_ring.avail_wrap_counter);
> + descs_used++;
> + } while ((txm = txm->next) != NULL);
> +
> + desc[idx].flags &= ~VRING_DESC_F_NEXT;
> +
> + rte_smp_wmb();
> + prev = (idx > 0 ? idx : vq->vq_nentries) - 1;
> + desc[prev].index = head_idx; //FIXME
> + desc[head_idx].flags =
> + (VRING_DESC_F_AVAIL(wrap_counter) |
> +  VRING_DESC_F_USED(!wrap_counter));
> +
> + vq->vq_descx[head_idx].ndescs = descs_used;
> + idx = update_pq_avail_index(vq);
> + }
> +
> + txvq->stats.packets += i;
> + txvq->stats.errors  += nb_pkts - i;
> +
> + return i;
> +}
> +
>  int
>  virtio_dev_rx_queue_done(void *rxq, uint16_t offset)
>  {
> @@ -736,7 +842,12 @@ virtio_dev_tx_queue_setup_finish(struct rte_eth_dev *dev,
>   if (hw->use_inorder_tx)
>   vq->vq_ring.desc[vq->vq_nentries - 1].next = 0;
>  
> - VIRTQUEUE_DUMP(vq);
> + if (vtpci_packed_queue(hw)) {
> + vq->vq_ring.avail_wrap_counter = 1;
> + }
> +
> + if (!vtpci_packed_queue(hw))
> + VIRTQUEUE_DUMP(vq);
>  
>   return 0;
>  }
> -- 
> 2.17.1
> 

Re: [dpdk-dev] [PATCH v5] net/mlx: add meson build support

[Bruce Richardson]

On Fri, Sep 07, 2018 at 11:34:29AM +0100, Bruce Richardson wrote:
> On Wed, Sep 05, 2018 at 02:47:46PM +0300, Shahaf Shuler wrote:
> > From: Nelio Laranjeiro 
> > 
> > Compile Mellanox drivers when their external dependencies are met.  A
> > glue version of the driver can still be requested by using the
> > -Denable_driver_mlx_glue=true
> > 
> > To avoid modifying the whole sources and keep the compatibility with
> > current build systems (e.g. make), the mlx{4,5}_autoconf.h is still
> > generated.
> > 
> > Meson will try to find the required external libraries.  When they are
> > not installed system wide, they can be provided though CFLAGS, LDFLAGS
> > and LD_LIBRARY_PATH environment variables, example (considering
> > RDMA-Core is installed in /tmp/rdma-core):
> > 
> >  # CLFAGS=-I/tmp/rdma-core/build/include \
> >LDFLAGS=-L/tmp/rdma-core/build/lib \
> >LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \
> >meson output
> >  # LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \
> >ninja -C output install
> > 
> > Note: LD_LIBRARY_PATH before ninja is necessary when the meson
> > configuration has changed (e.g. meson configure has been called), in
> > such situation the LD_LIBRARY_PATH is necessary to invoke the
> > autoconfiguration script.
> > 
> > Signed-off-by: Nelio Laranjeiro 
> > Signed-off-by: Shahaf Shuler 
> > Acked-by: Bruce Richardson 
> > ---
> > Changes in v5:
> > 
> > - use meson tool to generate Mellanox config file instead of DPDK custom 
> > scripts.
> > 
> 
> 
> 
> > +# To maintain the compatibility with the make build system
> > +# mlx5_autoconf.h file is still generated.
> > +# input array for meson symbol search:
> > +# [ "MACRO to define if found", "header for the search",
> > +#   "type/enum/define", "symbol to search",
> > +#   "struct member to search (type only)]
> > +#
> > +args = [
> > +[ 'HAVE_IBV_DEVICE_STRIDING_RQ_SUPPORT', 
> > 'infiniband/mlx5dv.h',
> > +  'enum', 'MLX5DV_CQE_RES_FORMAT_CSUM_STRIDX' ],
> > +[ 'HAVE_IBV_DEVICE_TUNNEL_SUPPORT', 'infiniband/mlx5dv.h',
> > +  'enum', 'MLX5DV_CONTEXT_MASK_TUNNEL_OFFLOADS' ],
> > +[ 'HAVE_IBV_MLX5_MOD_MPW', 'infiniband/mlx5dv.h',
> > +  'enum', 'MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED' ],
> > +[ 'HAVE_IBV_MLX5_MOD_SWP', 'infiniband/mlx5dv.h',
> > +  'type', 'struct mlx5dv_sw_parsing_caps',
> > +  'sw_parsing_offloads' ],
> > +[ 'HAVE_IBV_MLX5_MOD_CQE_128B_COMP', 'infiniband/mlx5dv.h',
> > +  'enum', 'MLX5DV_CONTEXT_FLAGS_CQE_128B_COMP' ],
> > +[ 'HAVE_IBV_DEVICE_MPLS_SUPPORT', 'infiniband/verbs.h',
> > +  'enum', 'IBV_FLOW_SPEC_MPLS' ],
> > +[ 'HAVE_IBV_WQ_FLAG_RX_END_PADDING', 'infiniband/verbs.h',
> > +  'enum', 'IBV_WQ_FLAG_RX_END_PADDING' ],
> > +[ 'HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT', 
> > 'infiniband/verbs.h',
> > +  'type', 'struct ibv_counter_set_init_attr',
> > +  'counter_set_id' ],
> > +[ 'HAVE_SUPPORTED_4baseKR4_Full', 'linux/ethtool.h',
> > +  'define', 'SUPPORTED_4baseKR4_Full' ],
> > +[ 'HAVE_SUPPORTED_4baseCR4_Full', 'linux/ethtool.h',
> > +  'define', 'SUPPORTED_4baseCR4_Full' ],
> > +[ 'HAVE_SUPPORTED_4baseSR4_Full', 'linux/ethtool.h',
> > +  'define', 'SUPPORTED_4baseSR4_Full' ],
> > +[ 'HAVE_SUPPORTED_4baseLR4_Full', 'linux/ethtool.h',
> > +  'define', 'SUPPORTED_4baseLR4_Full' ],
> > +[ 'HAVE_SUPPORTED_56000baseKR4_Full', 'linux/ethtool.h',
> > +  'define', 'SUPPORTED_56000baseKR4_Full' ],
> > +[ 'HAVE_SUPPORTED_56000baseCR4_Full', 'linux/ethtool.h',
> > +  'define', 'SUPPORTED_56000baseCR4_Full' ],
> > +[ 'HAVE_SUPPORTED_56000baseSR4_Full', 'linux/ethtool.h',
> > +  'define', 'SUPPORTED_56000baseSR4_Full' ],
> > +[ 'HAVE_SUPPORTED_56000baseLR4_Full', 'linux/ethtool.h',
> > +  'define', 'SUPPORTED_56000baseLR4_Full' ],
> > +[ 'HAVE_ETHTOOL_LINK_MODE_25G', 'linux/ethtool.h',
> > +  'enum', 'ETHTOOL_LINK_MODE_25000baseCR_Full_BIT' ],
> > +[ 'HAVE_ETHTOOL_LINK_MODE_50G', 'linux/ethtool.h',
> > +  'enum', 'ETHTOOL_LINK_MODE_5baseCR2_Full_BIT' ],
> > +[ 'HAVE_ETHTOOL_LINK_MODE_100G', 'linux/ethtool.h',
> > +  'enum', 'ETHTOOL_LINK_MODE_10baseKR4_Full_BIT' ],
> > +[ 'HAVE_IFLA_PHYS_SWITCH_ID', 'linux/if_link.h',
> > +  'enum', 'IFLA_PHYS_SWITCH_ID' ],
> > +[ 'HAVE_IFLA_PHYS_PORT_NAME', 'linux/if_link.h',
> > +  'enum', 'IFLA_P

[dpdk-dev] [PATCH v2 0/3] introduces the enetc PMD driver

[Gagandeep Singh]

*ENETC* PMD driver which integrates with the existing PCI bus.
Document is also part of the set

Change-log:
document improvement
checkpatch warnings removed

Gagandeep Singh (3):
  doc: add usage doc for ENETC PMD
  net/enetc: add ENETC PMD with basic operations
  net/enetc: enable Rx and Tx

 MAINTAINERS |   7 +
 config/common_base  |   5 +
 config/common_linuxapp  |   5 +
 doc/guides/nics/enetc.rst   | 154 +++
 doc/guides/nics/features/enetc.ini  |  10 +
 doc/guides/nics/index.rst   |   1 +
 drivers/net/Makefile|   1 +
 drivers/net/enetc/Makefile  |  25 ++
 drivers/net/enetc/base/enetc_hw.h   | 220 ++
 drivers/net/enetc/enetc.h   | 111 +
 drivers/net/enetc/enetc_ethdev.c| 271 
 drivers/net/enetc/enetc_logs.h  |  40 ++
 drivers/net/enetc/enetc_rxtx.c  | 447 
 drivers/net/enetc/meson.build   |  11 +
 drivers/net/enetc/rte_pmd_enetc_version.map |   4 +
 drivers/net/meson.build |   1 +
 mk/rte.app.mk   |   1 +
 17 files changed, 1314 insertions(+)
 create mode 100644 doc/guides/nics/enetc.rst
 create mode 100644 doc/guides/nics/features/enetc.ini
 create mode 100644 drivers/net/enetc/Makefile
 create mode 100644 drivers/net/enetc/base/enetc_hw.h
 create mode 100644 drivers/net/enetc/enetc.h
 create mode 100644 drivers/net/enetc/enetc_ethdev.c
 create mode 100644 drivers/net/enetc/enetc_logs.h
 create mode 100644 drivers/net/enetc/enetc_rxtx.c
 create mode 100644 drivers/net/enetc/meson.build
 create mode 100644 drivers/net/enetc/rte_pmd_enetc_version.map

-- 
2.17.1

[dpdk-dev] [PATCH v2 1/3] doc: add usage doc for ENETC PMD

[Gagandeep Singh]

Add enetc usage document to compile and run the
DPDK application on enetc supported platform.
This document introduces the enetc driver, supported
platforms and supported features.

Signed-off-by: Gagandeep Singh 
---
 MAINTAINERS|   5 +
 doc/guides/nics/enetc.rst  | 153 +
 doc/guides/nics/features/enetc.ini |   8 ++
 doc/guides/nics/index.rst  |   1 +
 4 files changed, 167 insertions(+)
 create mode 100644 doc/guides/nics/enetc.rst
 create mode 100644 doc/guides/nics/features/enetc.ini

diff --git a/MAINTAINERS b/MAINTAINERS
index 9fd258fad..b999230cc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -643,6 +643,11 @@ F: drivers/net/dpaa2/
 F: doc/guides/nics/dpaa2.rst
 F: doc/guides/nics/features/dpaa2.ini
 
+NXP enetc
+M: Gagandeep Singh 
+F: doc/guides/nics/enetc.rst
+F: doc/guides/nics/features/enetc.ini
+
 QLogic bnx2x
 M: Harish Patil 
 M: Rasesh Mody 
diff --git a/doc/guides/nics/enetc.rst b/doc/guides/nics/enetc.rst
new file mode 100644
index 0..da775ebeb
--- /dev/null
+++ b/doc/guides/nics/enetc.rst
@@ -0,0 +1,153 @@
+.. SPDX-License-Identifier: BSD-3-Clause
+   Copyright 2018 NXP
+
+ENETC Poll Mode Driver
+==
+
+The ENETC NIC PMD (**librte_pmd_enetc**) provides poll mode driver
+support for the inbuilt NIC found in the **NXP LS1028** SoC.
+
+More information can be found at `NXP Official Website
+`_.
+
+ENETC
+-
+
+This section provides an overview of the NXP ENETC
+and how it is integrated into the DPDK.
+
+Contents summary
+
+- ENETC overview
+- ENETC features
+- PCI bus driver
+- NIC driver
+- Supported ENETC SoCs
+- Prerequisites
+- Driver compilation and testing
+
+ENETC Overview
+~~
+
+ENETC is a PCI Integrated End Point(IEP). IEP implements
+peripheral devices in an SoC such that software sees them as PCIe device.
+ENETC is an evolution of BDR(Buffer Descriptor Ring) based networking
+IPs.
+
+This infrastructure simplifies adding support for IEP and facilitates in 
following:
+
+- Device discovery and location
+- Resource requirement discovery and allocation (e.g. interrupt assignment,
+  device register address)
+- Event reporting
+
+ENETC Features
+~~
+
+
+NIC Driver (PMD)
+
+
+ENETC PMD is traditional DPDK PMD which provides necessary interface between
+RTE framework and ENETC internal drivers.
+
+- Driver registers the device vendor table in PCI subsystem.
+- RTE framework scans the PCI bus for connected devices.
+- This scanning will invoke the probe function of ENETC driver.
+- The probe function will set the basic device registers and also setups BD 
rings.
+- On packet Rx the respective BD Ring status bit is set which is then used for
+  packet processing.
+- Then Tx is done first followed by Rx.
+
+Supported ENETC SoCs
+
+
+- LS1028
+
+Prerequisites
+~
+
+There are three main pre-requisities for executing ENETC PMD on a ENETC
+compatible board:
+
+1. **ARM 64 Tool Chain**
+
+   For example, the `*aarch64* Linaro Toolchain 
`_.
+
+2. **Linux Kernel**
+
+   It can be obtained from `NXP's Github hosting 
`_.
+
+3. **Rootfile system**
+
+   Any *aarch64* supporting filesystem can be used. For example,
+   Ubuntu 16.04 LTS (Xenial) or 18.04 (Bionic) userland which can be obtained
+   from `here 
`_.
+
+The following dependencies are not part of DPDK and must be installed
+separately:
+
+- **NXP Linux LSDK**
+
+  NXP Layerscape software development kit (LSDK) includes support for family
+  of QorIQ® ARM-Architecture-based system on chip (SoC) processors
+  and corresponding boards.
+
+  It includes the Linux board support packages (BSPs) for NXP SoCs,
+  a fully operational tool chain, kernel and board specific modules.
+
+  LSDK and related information can be obtained from:  `LSDK 
`_
+
+Driver compilation and testing
+~~
+
+#. Please refer the document :ref:`compiling and testing a PMD for a NIC 
`
+   to compile the driver. Use target "arm64-armv8a-linuxapp-gcc" in make 
command
+
+#. Refer to the document :ref:`cross build dpdk for arm64 
` to
+   disable flags and for cross compilation
+
+#. To compile in performance mode, please set ``CONFIG_RTE_CACHE_LINE_SIZE=64``
+
+#. Running l2fwd:
+
+   Follow instructions available in the document
+   :

[dpdk-dev] [PATCH v2 2/3] net/enetc: add ENETC PMD with basic operations

[Gagandeep Singh]

This patch introduces the enetc PMD with basic
initialisation functions includes probe, teardown,
hardware initialisation

Signed-off-by: Gagandeep Singh 
---
 MAINTAINERS |   1 +
 config/common_base  |   5 +
 config/common_linuxapp  |   5 +
 doc/guides/nics/enetc.rst   |   1 +
 doc/guides/nics/features/enetc.ini  |   2 +
 drivers/net/Makefile|   1 +
 drivers/net/enetc/Makefile  |  24 ++
 drivers/net/enetc/base/enetc_hw.h   | 220 
 drivers/net/enetc/enetc.h   | 111 
 drivers/net/enetc/enetc_ethdev.c| 269 
 drivers/net/enetc/enetc_logs.h  |  40 +++
 drivers/net/enetc/meson.build   |  10 +
 drivers/net/enetc/rte_pmd_enetc_version.map |   4 +
 drivers/net/meson.build |   1 +
 mk/rte.app.mk   |   1 +
 15 files changed, 695 insertions(+)
 create mode 100644 drivers/net/enetc/Makefile
 create mode 100644 drivers/net/enetc/base/enetc_hw.h
 create mode 100644 drivers/net/enetc/enetc.h
 create mode 100644 drivers/net/enetc/enetc_ethdev.c
 create mode 100644 drivers/net/enetc/enetc_logs.h
 create mode 100644 drivers/net/enetc/meson.build
 create mode 100644 drivers/net/enetc/rte_pmd_enetc_version.map

diff --git a/MAINTAINERS b/MAINTAINERS
index b999230cc..fc70ac049 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -645,6 +645,7 @@ F: doc/guides/nics/features/dpaa2.ini
 
 NXP enetc
 M: Gagandeep Singh 
+F: drivers/net/enetc/
 F: doc/guides/nics/enetc.rst
 F: doc/guides/nics/features/enetc.ini
 
diff --git a/config/common_base b/config/common_base
index 4bcbaf923..a7fc48667 100644
--- a/config/common_base
+++ b/config/common_base
@@ -217,6 +217,11 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y
 CONFIG_RTE_LIBRTE_DPAA2_PMD=n
 CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n
 
+#
+# Compile NXP ENETC PMD Driver
+#
+CONFIG_RTE_LIBRTE_ENETC_PMD=n
+
 #
 # Compile burst-oriented Amazon ENA PMD driver
 #
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 9c5ea9d89..485e1467d 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -44,3 +44,8 @@ CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=y
+
+#
+# NXP ENETC PMD Driver
+#
+CONFIG_RTE_LIBRTE_ENETC_PMD=y
diff --git a/doc/guides/nics/enetc.rst b/doc/guides/nics/enetc.rst
index da775ebeb..9d30e8373 100644
--- a/doc/guides/nics/enetc.rst
+++ b/doc/guides/nics/enetc.rst
@@ -44,6 +44,7 @@ This infrastructure simplifies adding support for IEP and 
facilitates in followi
 ENETC Features
 ~~
 
+- Link Status
 
 NIC Driver (PMD)
 
diff --git a/doc/guides/nics/features/enetc.ini 
b/doc/guides/nics/features/enetc.ini
index fb1bf5989..83b20845a 100644
--- a/doc/guides/nics/features/enetc.ini
+++ b/doc/guides/nics/features/enetc.ini
@@ -4,5 +4,7 @@
 ; Refer to default.ini for the full list of available PMD features.
 ;
 [Features]
+Link status  = Y
+Linux VFIO   = Y
 ARMv8= Y
 Usage doc= Y
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 664398de9..3ad436045 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -24,6 +24,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += dpaa2
 endif
 DIRS-$(CONFIG_RTE_LIBRTE_E1000_PMD) += e1000
 DIRS-$(CONFIG_RTE_LIBRTE_ENA_PMD) += ena
+DIRS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc
 DIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += enic
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_FAILSAFE) += failsafe
 DIRS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += fm10k
diff --git a/drivers/net/enetc/Makefile b/drivers/net/enetc/Makefile
new file mode 100644
index 0..3f4ba97da
--- /dev/null
+++ b/drivers/net/enetc/Makefile
@@ -0,0 +1,24 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2018 NXP
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+#
+# library name
+#
+LIB = librte_pmd_enetc.a
+
+CFLAGS += -O3
+EXPORT_MAP := rte_pmd_enetc_version.map
+LIBABIVER := 1
+
+#
+# all source are stored in SRCS-y
+#
+SRCS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc_ethdev.c
+
+LDLIBS += -lrte_eal
+LDLIBS += -lrte_ethdev
+LDLIBS += -lrte_bus_pci
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/net/enetc/base/enetc_hw.h 
b/drivers/net/enetc/base/enetc_hw.h
new file mode 100644
index 0..1ec16fec9
--- /dev/null
+++ b/drivers/net/enetc/base/enetc_hw.h
@@ -0,0 +1,220 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2018 NXP
+ */
+
+#ifndef _ENETC_HW_H_
+#define _ENETC_HW_H_
+#include 
+
+#define BIT(x) ((uint64_t)1 << ((x)))
+
+/* ENETC device IDs */
+#define ENETC_DEV_ID_VF0xef00
+#define ENETC_DEV_ID   0xe100
+
+/* ENETC register block BAR */
+#define ENETC_BAR_REGS 0x0
+
+/* SI regs, offset: 0h */
+#define ENETC_SIMR 0x0
+#define 

[dpdk-dev] [PATCH v2 3/3] net/enetc: enable Rx and Tx

[Gagandeep Singh]

Add RX and TX queue setup, datapath functions
and enable the packet parsing

Signed-off-by: Gagandeep Singh 
---
 MAINTAINERS  |   1 +
 drivers/net/enetc/Makefile   |   3 +-
 drivers/net/enetc/enetc_ethdev.c |   6 +-
 drivers/net/enetc/enetc_rxtx.c   | 447 +++
 drivers/net/enetc/meson.build|   3 +-
 5 files changed, 456 insertions(+), 4 deletions(-)
 create mode 100644 drivers/net/enetc/enetc_rxtx.c

diff --git a/MAINTAINERS b/MAINTAINERS
index fc70ac049..b67f2afa4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -645,6 +645,7 @@ F: doc/guides/nics/features/dpaa2.ini
 
 NXP enetc
 M: Gagandeep Singh 
+M: Pankaj Chauhan 
 F: drivers/net/enetc/
 F: doc/guides/nics/enetc.rst
 F: doc/guides/nics/features/enetc.ini
diff --git a/drivers/net/enetc/Makefile b/drivers/net/enetc/Makefile
index 3f4ba97da..1f886831a 100644
--- a/drivers/net/enetc/Makefile
+++ b/drivers/net/enetc/Makefile
@@ -16,8 +16,9 @@ LIBABIVER := 1
 # all source are stored in SRCS-y
 #
 SRCS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc_ethdev.c
+SRCS-$(CONFIG_RTE_LIBRTE_ENETC_PMD) += enetc_rxtx.c
 
-LDLIBS += -lrte_eal
+LDLIBS += -lrte_eal -lrte_mempool
 LDLIBS += -lrte_ethdev
 LDLIBS += -lrte_bus_pci
 
diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c
index 06438835d..67106593f 100644
--- a/drivers/net/enetc/enetc_ethdev.c
+++ b/drivers/net/enetc/enetc_ethdev.c
@@ -37,6 +37,8 @@ static const struct eth_dev_ops enetc_ops = {
.dev_close= enetc_dev_close,
.link_update  = enetc_link_update,
.dev_infos_get= enetc_dev_infos_get,
+   .rx_queue_setup   = enetc_rx_queue_setup,
+   .tx_queue_setup   = enetc_tx_queue_setup,
 };
 
 /**
@@ -61,8 +63,8 @@ enetc_dev_init(struct rte_eth_dev *eth_dev)
 
PMD_INIT_FUNC_TRACE();
eth_dev->dev_ops = &enetc_ops;
-   eth_dev->rx_pkt_burst = NULL;
-   eth_dev->tx_pkt_burst = NULL;
+   eth_dev->rx_pkt_burst = &enetc_recv_pkts;
+   eth_dev->tx_pkt_burst = &enetc_xmit_pkts;
 
rte_eth_copy_pci_info(eth_dev, pci_dev);
 
diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c
new file mode 100644
index 0..b01f64b0c
--- /dev/null
+++ b/drivers/net/enetc/enetc_rxtx.c
@@ -0,0 +1,447 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2018 NXP
+ */
+
+#include 
+#include 
+#include 
+
+#include "rte_ethdev.h"
+#include "rte_malloc.h"
+#include "rte_memzone.h"
+
+#include "base/enetc_hw.h"
+#include "enetc.h"
+#include "enetc_logs.h"
+
+#define ENETC_RXBD_BUNDLE 8 /* Number of BDs to update at once */
+
+static inline int enetc_bd_unused(struct enetc_bdr *bdr)
+{
+   if (bdr->next_to_clean > bdr->next_to_use)
+   return bdr->next_to_clean - bdr->next_to_use - 1;
+
+   return bdr->bd_count + bdr->next_to_clean - bdr->next_to_use - 1;
+}
+
+static bool enetc_clean_tx_ring(struct enetc_bdr *tx_ring)
+{
+   int tx_frm_cnt = 0;
+   struct enetc_swbd *tx_swbd;
+   int i;
+
+   i = tx_ring->next_to_clean;
+   tx_swbd = &tx_ring->q_swbd[i];
+   while ((int)(enetc_rd_reg(tx_ring->tcisr) & ENETC_TBCISR_IDX_MASK) != 
i) {
+   rte_pktmbuf_free(tx_swbd->buffer_addr);
+   tx_swbd->buffer_addr = NULL;
+   tx_swbd++;
+   i++;
+   if (unlikely(i == tx_ring->bd_count)) {
+   i = 0;
+   tx_swbd = &tx_ring->q_swbd[0];
+   }
+
+   tx_frm_cnt++;
+   }
+   tx_ring->next_to_clean = i;
+   return tx_frm_cnt++;
+}
+
+uint16_t enetc_xmit_pkts(void *tx_queue,
+   struct rte_mbuf **tx_pkts,
+   uint16_t nb_pkts)
+{
+   struct enetc_swbd *tx_swbd;
+   int i, start;
+   struct enetc_tx_bd *txbd;
+   struct enetc_bdr *tx_ring = (struct enetc_bdr *)tx_queue;
+
+   i = tx_ring->next_to_use;
+   start = 0;
+   while (nb_pkts--) {
+   enetc_clean_tx_ring(tx_ring);
+
+   tx_ring->q_swbd[i].buffer_addr = tx_pkts[start];
+
+   txbd = ENETC_TXBD(*tx_ring, i);
+   tx_swbd = &tx_ring->q_swbd[i];
+   txbd->frm_len = tx_pkts[start]->pkt_len;
+   txbd->buf_len = txbd->frm_len;
+   txbd->flags = rte_cpu_to_le_16(ENETC_TXBD_FLAGS_F);
+   txbd->addr =
+   (uint64_t)rte_cpu_to_le_64(tx_swbd->buffer_addr->buf_addr +
+   tx_swbd->buffer_addr->data_off);
+   i++;
+   start++;
+   if (unlikely(i == tx_ring->bd_count))
+   i = 0;
+   }
+   tx_ring->next_to_use = i;
+   enetc_wr_reg(tx_ring->tcir, i);
+   return start;
+}
+
+static int enetc_refill_rx_ring(struct enetc_bdr *rx_ring, const int buff_cnt)
+{
+   struct enetc_swbd *rx_swbd;
+   union enetc_rx_bd *rxbd;
+   int i, j;
+
+   i = rx_rin

Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_power: traffic pattern aware power control

[Kevin Traynor]

On 09/11/2018 10:19 AM, Hunt, David wrote:
> Hi Kevin,
> 

Hi Dave,

> 
> On 27/6/2018 6:33 PM, Kevin Traynor wrote:
>> On 06/26/2018 12:40 PM, Radu Nicolau wrote:
>>> From: Liang Ma 
>>>
>>> 1. Abstract
> 
> --snip--
> 
>>> 2.2 There are two phases to establish the power management system:
>>>
>>> a.Initialization/Training phase. There is no traffic pass-through,
>>>   the system will test average empty poll numbers  with
>>>   LOW/MED/HIGH  power state. Those average empty poll numbers
>>>   will be the baseline
>>>   for the normal phase. The system will collect all core's counter
>>>   every 100ms. The Training phase will take 5 seconds.
>>>
>> This is requiring an application to sit for 5 secs in order to train and
>> align poll numbers with states? That doesn't seem realistic to me.
> 
> 
> Thanks for the discussion at DPDK Userspace conference. Since we got
> back, Liang and
> I have discussed the feedback we received, and we have a proposal.
> 
> We can split out the training phase into a separate run of the application
> which does the training, spits out the threshold numbers, and then
> the actual runs will start instantly once the threshold parameters are
> provided on the command line, or falls back to hard-coded defaults if
> no command line parameters are given.
> 
> So there are three ways of running the app
>   1. Run without any threshold parameters, in which case the algorithm
>   runs with default numbers calculated based on the min and max
> available frequency.
>   2. Run with --train option, which requires no traffic on the NICS, and
>   runs the training algorithm, prints out the thresholds for the
> host CPU, and exits.
>   3. Take the output of the train phase, and provide the thresholds on
> the command
>   line, and the app runs with the best fit to the running CPU.
> 
> That would eliminate the training period at startup, unless the user
> wanted to fine-tune
> for a particular host CPU.
> 
> Would that be an adequate solution to the training period concerns?
> 

Thanks for following up. It's allowing it to run without a training
phase which is what I thought could be problematic from an application
view, so that's nice. I'm not sure if it's much less effective without
that training phase etc, but the comment was focused on having a forced
training phase, so that is resolved now as it is not required.

I'm still not sure I see the use cases for the options where there *is*
a training type phase but it's difficult to know and considering it's
experimental, if you feel there are some potential use cases and
justification to add it, then fine with me.

I have a few comments on the API, which I'll reply directly to the patch.

thanks,
Kevin.

> Regards,
> Dave.
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 

Re: [dpdk-dev] [PATCH v5] net/mlx: add meson build support

[Shahaf Shuler]

Hi Bruce,

Sorry for the late reply. Holiday time in Israel. 

Thursday, September 13, 2018 12:22 PM, Bruce Richardson:
> Subject: Re: [dpdk-dev] [PATCH v5] net/mlx: add meson build support
> 
> On Fri, Sep 07, 2018 at 11:34:29AM +0100, Bruce Richardson wrote:
> > On Wed, Sep 05, 2018 at 02:47:46PM +0300, Shahaf Shuler wrote:
> > > From: Nelio Laranjeiro 

[...]

> > couple of minor points:
> > * These new additions use tab rather than space for indent. The standard
> >   with meson I think is normally spaces, but I (inadvertently) added all
> >   other DPDK meson.build files with tabs, so for consistency I think it
> >   would be good if the whole file used tabs i.e. change all the other lines
> >   apart from your new ones in v5.

OK, all indentation will be with tab.  

> >
> > * is the "rm" command really necessary? I would expect the
> configure_file()
> >   function to just do the right thing here when replacing the file.

Yep it is not needed. Also from meson sources:
output = kwargs['output']   
 
ofile_rpath = os.path.join(self.subdir, output) 
 
if not isinstance(output, str): 
 
raise InterpreterException('Output file name must be a string') 
 
if ofile_rpath in self.configure_file_outputs:  
 
mesonbuildfile = os.path.join(self.subdir, 'meson.build')   
 
current_call = "{}:{}".format(mesonbuildfile, self.current_lineno)  
 
first_call = "{}:{}".format(mesonbuildfile, 
self.configure_file_outputs[ofile_rpath])
mlog.warning('Output file', mlog.bold(ofile_rpath, True), 'for 
configure_file() at', current_call, 'o
verwrites configure_file() output at', first_call)  
 

> >
> > * Would you consider splitting the args array into two arrays, one for the
> >   "type" values and another for the enum/define ones? This would mean
> >   having two loops, but the loops themselves would be clearer and shorter -
> >   as would the arrays.  Especially since according to
> >
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmes
> onbuild.com%2FConfiguration.html&data=02%7C01%7Cshahafs%40mell
> anox.com%7C38f62333815c48eaea6e08d6195a908a%7Ca652971c7d2e4d9ba6
> a4d149256f461b%7C0%7C0%7C636724274091500993&sdata=fZvTg16D8K
> TsE7Q0DWsS9hiNnB%2BhHPuHi%2FFC7wrk8x8%3D&reserved=0
> >   a boolean false converts to an "undef", rather than a 0/1 value.
> >   For example:
> >
> > foreach arg:has_sym_args
> > config.set(arg[0], cc.has_header_symbol(arg[1], arg[3]))
> > endforeach
> >

Done.

> > * Very minor suggestion: is it neater to use "args: '-include ' + arg[1]",
> >   instead of using prefix with the #include syntax? [Assuming the former
> >   works]

I don't understand the benefit with this change. Is there? 

> >
> 
> Any plans for a new version of this? If so, can I also suggest splitting the 
> patch
> into two, one for mlx4 and the other for mlx5.

No problem to split.

Another change in plans: 
diff --git a/meson_options.txt b/meson_options.txt
index 484f3e2601..444a380d97 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -1,7 +1,7 @@
 option('allow_invalid_socket_id', type: 'boolean', value: false,
description: 'allow out-of-range NUMA socket id\'s for platforms that 
don\'t report the value correctly')
 option('enable_driver_mlx_glue', type: 'boolean', value: false,
-   description: 'Enable glue library for Mellanox ConnectX-3/4/5 NIC PMD')
+   description: 'Enable glue library for Mellanox PMDs')
 option('enable_kmods', type: 'boolean', value: true,
description: 'build kernel modules')
 option('examples', type: 'string', value: '',

I don't see the need to constantly update with each device being added.  

> 
> Regards,
> /Bruce

[dpdk-dev] [PATCH] net/i40e: remove invalid comment

[Ferruh Yigit]

Comments says "no csum error report support" but there is no check
related csum offloads. Removing the comment.

Signed-off-by: Ferruh Yigit 

---
Patch can be other way around too, adding the csum check mentioned in
the comment.
Please comment if this is the correct thing to do.
---
 drivers/net/i40e/i40e_rxtx_vec_common.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h 
b/drivers/net/i40e/i40e_rxtx_vec_common.h
index 63cb17742..f00f6d648 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
@@ -199,9 +199,7 @@ i40e_rx_vec_dev_conf_condition_check_default(struct 
rte_eth_dev *dev)
if (fconf->mode != RTE_FDIR_MODE_NONE)
return -1;
 
-/* - no csum error report support
-* - no header split support
-*/
+/* no header split support */
if (rxmode->offloads & DEV_RX_OFFLOAD_HEADER_SPLIT)
return -1;
 
-- 
2.17.1

[dpdk-dev] [PATCH] net/mlx5: support e-switch flow count action

[Moti Haimovsky]

This commit adds support for configuring flows destined to the mlx5
eswitch with 'count' action and for querying these counts at runtime.

It is possible to offload an interface flow rules to the hardware
using DPDK flow commands.
With mlx5 it is also possible to offload a limited set of flow rules to
the mlxsw (or e-switch) using the same DPDK flow commands using the
'transfer' attribute in the flow rule creation command.
The commands destined for the switch are transposed to TC flower rules
and are sent, as Netlink messages, to the mlx5 driver (or more precisely
to the netdev which represent the mlxsw port).
Each flow rule configured by the mlx5 driver is also assigned with a set
of flow counters implicitly. These counters can be retrieved when querying
the flow rule via Netlink, they can be found in each flow action section
of the reply.
Currently the limited set of eswitch flow rules does not contain the
'count' action but since every rule contains a count we can still retrieve
these values as if we configured a 'count' action.

Supporting the 'count' action in the flow configuration command is
straight-forward. When transposing the command to a tc flower Netlink
message we just ignore it instead of rejecting it.
So the following two commands will have the same affect and behavior:
  testpmd> flow create 0 transfer ingress pattern eth src is
   11:22:33:44:55:77 dst is 11:22:33:44:55:88 / end
   actions drop / end
  testpmd> flow create 0 transfer ingress pattern eth src is
   11:22:33:44:55:77 dst is 11:22:33:44:55:88 / end
   actions count / drop / end
In the flow query side, the command now also returns the counts the
above flow via using tc Netlink query command.
Special care was taken in order to prevent Netlink messages truncation
due to short buffers by using MNL_SOCKET_BUFFER_SIZE buffers which are
pre-allocate per port instance.

Signed-off-by: Moti Haimovsky 
---
Note:
 This patch should be applied on top of the new flow engine commits
 by orika and yskoh
---
 drivers/net/mlx5/mlx5.c|   9 +-
 drivers/net/mlx5/mlx5.h|   3 +
 drivers/net/mlx5/mlx5_flow.c   |  29 +++-
 drivers/net/mlx5/mlx5_flow.h   |  16 +-
 drivers/net/mlx5/mlx5_flow_dv.c|   1 +
 drivers/net/mlx5/mlx5_flow_tcf.c   | 339 +
 drivers/net/mlx5/mlx5_flow_verbs.c |   1 +
 7 files changed, 392 insertions(+), 6 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index e3c3671..b03ca7d 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -289,6 +289,8 @@
close(priv->nl_socket_rdma);
if (priv->mnl_socket)
mlx5_flow_tcf_socket_destroy(priv->mnl_socket);
+   if (priv->mnl_rcvbuf)
+   mlx5_flow_tcf_rcv_buf_destroy(priv->mnl_rcvbuf);
ret = mlx5_hrxq_ibv_verify(dev);
if (ret)
DRV_LOG(WARNING, "port %u some hash Rx queue still remain",
@@ -1139,7 +1141,8 @@
if (vf && config.vf_nl_en)
mlx5_nl_mac_addr_sync(eth_dev);
priv->mnl_socket = mlx5_flow_tcf_socket_create();
-   if (!priv->mnl_socket) {
+   priv->mnl_rcvbuf = mlx5_flow_tcf_rcv_buf_create();
+   if (!priv->mnl_socket || !priv->mnl_rcvbuf) {
err = -rte_errno;
DRV_LOG(WARNING,
"flow rules relying on switch offloads will not be"
@@ -1163,7 +1166,9 @@
" not be supported: %s: %s",
error.message, strerror(rte_errno));
mlx5_flow_tcf_socket_destroy(priv->mnl_socket);
+   mlx5_flow_tcf_rcv_buf_destroy(priv->mnl_rcvbuf);
priv->mnl_socket = NULL;
+   priv->mnl_rcvbuf = NULL;
}
}
TAILQ_INIT(&priv->flows);
@@ -1220,6 +1225,8 @@
close(priv->nl_socket_rdma);
if (priv->mnl_socket)
mlx5_flow_tcf_socket_destroy(priv->mnl_socket);
+   if (priv->mnl_rcvbuf)
+   mlx5_flow_tcf_rcv_buf_destroy(priv->mnl_rcvbuf);
if (own_domain_id)
claim_zero(rte_eth_switch_domain_free(priv->domain_id));
rte_free(priv);
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 46942e2..4e9cf1d 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -158,6 +158,7 @@ struct mlx5_drop {
 };
 
 struct mnl_socket;
+struct mlx5_flow_tcf_rbuf;
 
 struct priv {
LIST_ENTRY(priv) mem_event_cb; /* Called by memory event callback. */
@@ -225,6 +226,8 @@ struct priv {
/* UAR same-page access control required in 32bit implementations. */
 #endif
struct mnl_socket *mnl_socket; /* Libmnl socket. */
+   struct mlx5_flow_tcf_rbuf *mnl_rcvbuf;
+   /* Buffer for receiving libmnl messages. */
 };
 
 #define PORT_ID(priv) ((priv)->dev_d

[dpdk-dev] [PATCH] net/mlx5: support e-switch TCP-flags flow filter

[Moti Haimovsky]

This patch adds support for offloading flow rules with tcp-flags
filter to mlx5 eswitch hardwrae.

Today, it is possible to offload an interface flow rules to the hardware
using DPDK flow commands.
With mlx5 it is also possible to offload a limited set of flow rules to
the mlxsw (or e-switch) using the same DPDK flow commands.
A 'transfer' attribute was added to the flow rule creation command in
order to distinguish between configuring port flows and E-switch flows.
The commands destined for the switch are transposed to TC flower rules
and are send, as Netlink messages, to the mlx5 driver, or more precisely
to the netdev which represent the mlxsw port.
The limited set of e-switch flow rules also supports filtering according
to the values found in the TCP flags. This patch implements this offload
capability in the mlx5 PMD.

Signed-off-by: Moti Haimovsky 
---
Note:
 This patch should be applied on top of the new flow engine commits
 by orika and yskoh
---
 drivers/net/mlx5/Makefile| 10 ++
 drivers/net/mlx5/mlx5_flow.c |  9 -
 drivers/net/mlx5/mlx5_flow_tcf.c | 19 +++
 3 files changed, 37 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
index ca1de9f..9097456 100644
--- a/drivers/net/mlx5/Makefile
+++ b/drivers/net/mlx5/Makefile
@@ -342,6 +342,16 @@ mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto-config-h.sh
enum TCA_FLOWER_KEY_VLAN_ETH_TYPE \
$(AUTOCONF_OUTPUT)
$Q sh -- '$<' '$@' \
+   HAVE_TCA_FLOWER_KEY_TCP_FLAGS \
+   linux/pkt_cls.h \
+   enum TCA_FLOWER_KEY_TCP_FLAGS \
+   $(AUTOCONF_OUTPUT)
+   $Q sh -- '$<' '$@' \
+   HAVE_TCA_FLOWER_KEY_TCP_FLAGS_MASK \
+   linux/pkt_cls.h \
+   enum TCA_FLOWER_KEY_TCP_FLAGS_MASK \
+   $(AUTOCONF_OUTPUT)
+   $Q sh -- '$<' '$@' \
HAVE_TC_ACT_VLAN \
linux/tc_act/tc_vlan.h \
enum TCA_VLAN_PUSH_VLAN_PRIORITY \
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index f9a64d3..c8cc8fe 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1241,6 +1241,13 @@ int mlx5_flow_validate_item_tcp(uint64_t item_flags,
struct rte_flow_error *error)
 {
const struct rte_flow_item_tcp *mask = item->mask;
+   const struct rte_flow_item_tcp nic_mask = {
+   .hdr = {
+   .src_port = RTE_BE16(0x),
+   .dst_port = RTE_BE16(0x),
+   .tcp_flags = 0xff,
+   },
+   };
const int tunnel = !!(item_flags & MLX5_FLOW_LAYER_TUNNEL);
int ret;
 
@@ -1266,7 +1273,7 @@ int mlx5_flow_validate_item_tcp(uint64_t item_flags,
mask = &rte_flow_item_tcp_mask;
ret = mlx5_flow_item_acceptable
(item, (const uint8_t *)mask,
-(const uint8_t *)&rte_flow_item_tcp_mask,
+(const uint8_t *)&nic_mask,
 sizeof(struct rte_flow_item_tcp), error);
if (ret < 0)
return ret;
diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c
index 769a13a..5034862 100644
--- a/drivers/net/mlx5/mlx5_flow_tcf.c
+++ b/drivers/net/mlx5/mlx5_flow_tcf.c
@@ -148,6 +148,12 @@ struct tc_vlan {
 #ifndef HAVE_TCA_FLOWER_KEY_VLAN_ETH_TYPE
 #define TCA_FLOWER_KEY_VLAN_ETH_TYPE 25
 #endif
+#ifndef TCA_FLOWER_KEY_TCP_FLAGS
+#define TCA_FLOWER_KEY_TCP_FLAGS 71
+#endif
+#ifndef TCA_FLOWER_KEY_TCP_FLAGS_MASK
+#define TCA_FLOWER_KEY_TCP_FLAGS_MASK 72
+#endif
 
 #ifndef IPV6_ADDR_LEN
 #define IPV6_ADDR_LEN 16
@@ -204,6 +210,7 @@ struct tc_vlan {
.tcp.hdr = {
.src_port = RTE_BE16(0x),
.dst_port = RTE_BE16(0x),
+   .tcp_flags = 0xff,
},
.udp.hdr = {
.src_port = RTE_BE16(0x),
@@ -1271,6 +1278,18 @@ struct flow_tcf_ptoi {
 TCA_FLOWER_KEY_TCP_DST_MASK,
 mask.tcp->hdr.dst_port);
}
+   if (mask.tcp->hdr.tcp_flags) {
+   mnl_attr_put_u16
+   (nlh,
+TCA_FLOWER_KEY_TCP_FLAGS,
+rte_cpu_to_be_16
+   (spec.tcp->hdr.tcp_flags));
+   mnl_attr_put_u16
+   (nlh,
+TCA_FLOWER_KEY_TCP_FLAGS_MASK,
+rte_cpu_to_be_16
+   (mask.tcp->hdr.tcp_flags));
+   }
break;
default:
return rte_flow_

Re: [dpdk-dev] [PATCH v7 1/4] lib/librte_power: traffic pattern aware power control

[Kevin Traynor]

On 09/04/2018 03:10 PM, Liang Ma wrote:
> 1. Abstract
> 

Hi Liang,

I didn't review the code, but some comments on API below,

> For packet processing workloads such as DPDK polling is continuous.
> This means CPU cores always show 100% busy independent of how much work
> those cores are doing. It is critical to accurately determine how busy
> a core is hugely important for the following reasons:
> 
>* No indication of overload conditions
> 
>* User do not know how much real load is on a system meaning resulted in
>  wasted energy as no power management is utilized
> 
> Compared to the original l3fwd-power design, instead of going to sleep
> after detecting an empty poll, the new mechanism just lowers the core
> frequency. As a result, the application does not stop polling the device,
> which leads to improved handling of bursts of traffic.
> 
> When the system become busy, the empty poll mechanism can also increase the
> core frequency (including turbo) to do best effort for intensive traffic.
> This gives us more flexible and balanced traffic awareness over the
> standard l3fwd-power application.
> 
> 2. Proposed solution
> 
> The proposed solution focuses on how many times empty polls are executed.
> The less the number of empty polls, means current core is busy with
> processing workload, therefore, the higher frequency is needed. The high
> empty poll number indicates the current core not doing any real work
> therefore, we can lower the frequency to safe power.
> 
> In the current implementation, each core has 1 empty-poll counter which
> assume 1 core is dedicated to 1 queue. This will need to be expanded in the
> future to support multiple queues per core.
> 
> 2.1 Power state definition:
> 
>   LOW:  Not currently used, reserved for future use.
> 
>   MED:  the frequency is used to process modest traffic workload.
> 
>   HIGH: the frequency is used to process busy traffic workload.
> 
> 2.2 There are two phases to establish the power management system:
> 
>   a.Initialization/Training phase. The training phase is necessary
> in order to figure out the system polling baseline numbers from
> idle to busy. The highest poll count will be during idle, where
> all polls are empty. These poll counts will be different between
> systems due to the many possible processor micro-arch, cache
> and device configurations, hence the training phase.
> In the training phase, traffic is blocked so the training

When you say 'traffic is blocked' is this something that the application
can do through DPDK API, or you mean no external packets are sent into
that port?

> algorithm can average the empty-poll numbers for the LOW, MED and
> HIGH  power states in order to create a baseline.
> The core's counter are collected every 10ms, and the Training
>  phase will take 2 seconds.
> 
>   b.Normal phase. When the training phase is complete, traffic is
> started. The run-time poll counts are compared with the
> baseline and the decision will be taken to move to MED power
> state or HIGH power state. The counters are calculated every 10ms.
> 
> 3. Proposed  API
> 
> 1.  rte_power_empty_poll_stat_init(void);
> which is used to initialize the power management system.
>  
> 2.  rte_power_empty_poll_stat_free(void);
> which is used to free the resource hold by power management system.
>  
> 3.  rte_power_empty_poll_stat_update(unsigned int lcore_id);
> which is used to update specific core empty poll counter, not thread safe
>  
> 4.  rte_power_poll_stat_update(unsigned int lcore_id, uint8_t nb_pkt);
> which is used to update specific core valid poll counter, not thread safe
>  

is uint8_t enough to cover the max burst size for an rx poll? I didn't check

> 5.  rte_power_empty_poll_stat_fetch(unsigned int lcore_id);
> which is used to get specific core empty poll counter.
>  
> 6.  rte_power_poll_stat_fetch(unsigned int lcore_id);
> which is used to get specific core valid poll counter.
> 

How about replacing 1-6 with something like below..(not sure what would
be best prefix)

rte_power_poll_stat_init(void);
rte_power_poll_stat_free(void);
rte_power_poll_stat_update(unsigned int lcore, uint8_t nb_pkts)
rte_power_poll_stat_fetch(unsigned int lcore, uint8_t stat)

This would mean combining 3./4. as per previous suggestion so the
application could just call a single function with nb_pkt (which could
be 0). It also makes it more extensible if you want to add new stats in
the future, rather than having to add more functions.

It doesn't do anything different, so perhaps it's just a matter of
personal tastes.

> 7.  rte_empty_poll_detection(void);
> which is used to detect empty poll state changes.
> 

s/rte/rte_power/ ?

I think this needs some better docs/doxygen and maybe name. It seems to
not just detect state change but take some actions so that should be
documented, even in a general way.

th

Re: [dpdk-dev] [PATCH v5] net/mlx: add meson build support

[Bruce Richardson]

On Thu, Sep 13, 2018 at 10:12:18AM +, Shahaf Shuler wrote:
> Hi Bruce,
> 
> Sorry for the late reply. Holiday time in Israel. 
> 
No problem! Hope you had a good break. :-)

> Thursday, September 13, 2018 12:22 PM, Bruce Richardson:
> > Subject: Re: [dpdk-dev] [PATCH v5] net/mlx: add meson build support
> > 
> > On Fri, Sep 07, 2018 at 11:34:29AM +0100, Bruce Richardson wrote:
> > > On Wed, Sep 05, 2018 at 02:47:46PM +0300, Shahaf Shuler wrote:
> > > > From: Nelio Laranjeiro 
> 

> 
> > > * Very minor suggestion: is it neater to use "args: '-include ' + arg[1]",
> > >   instead of using prefix with the #include syntax? [Assuming the former
> > >   works]
> 
> I don't understand the benefit with this change. Is there? 
> 

No, it was just a suggestion as to what looked neater in the code. Use
whatever you prefer.

> > >
> > 
> > Any plans for a new version of this? If so, can I also suggest splitting 
> > the patch
> > into two, one for mlx4 and the other for mlx5.
> 
> No problem to split.
> 
> Another change in plans: 
> diff --git a/meson_options.txt b/meson_options.txt
> index 484f3e2601..444a380d97 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -1,7 +1,7 @@
>  option('allow_invalid_socket_id', type: 'boolean', value: false,
> description: 'allow out-of-range NUMA socket id\'s for platforms that 
> don\'t report the value correctly')
>  option('enable_driver_mlx_glue', type: 'boolean', value: false,
> -   description: 'Enable glue library for Mellanox ConnectX-3/4/5 NIC 
> PMD')
> +   description: 'Enable glue library for Mellanox PMDs')
>  option('enable_kmods', type: 'boolean', value: true,
> description: 'build kernel modules')
>  option('examples', type: 'string', value: '',
> 
> I don't see the need to constantly update with each device being added.  
> 
Good idea!

/Bruce

[dpdk-dev] [PATCH v2 1/2] vhost: introduce API to get vDPA device number

[Xiaolong Ye]

Signed-off-by: Xiaolong Ye 
---
 lib/librte_vhost/rte_vdpa.h | 3 +++
 lib/librte_vhost/vdpa.c | 6 ++
 2 files changed, 9 insertions(+)

diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h
index 90465ca26..b8223e337 100644
--- a/lib/librte_vhost/rte_vdpa.h
+++ b/lib/librte_vhost/rte_vdpa.h
@@ -84,4 +84,7 @@ rte_vdpa_find_device_id(struct rte_vdpa_dev_addr *addr);
 struct rte_vdpa_device * __rte_experimental
 rte_vdpa_get_device(int did);
 
+/* Get current available vdpa device number */
+int __rte_experimental
+rte_vdpa_get_device_num(void);
 #endif /* _RTE_VDPA_H_ */
diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c
index c82fd4370..c2c5dff1d 100644
--- a/lib/librte_vhost/vdpa.c
+++ b/lib/librte_vhost/vdpa.c
@@ -113,3 +113,9 @@ rte_vdpa_get_device(int did)
 
return vdpa_devices[did];
 }
+
+int
+rte_vdpa_get_device_num(void)
+{
+   return vdpa_device_num;
+}
-- 
2.17.1

[dpdk-dev] [PATCH v2 2/2] examples/vdpa: introduce a new sample for vDPA

[Xiaolong Ye]

The vdpa sample application creates vhost-user sockets by using the
vDPA backend. vDPA stands for vhost Data Path Acceleration which utilizes
virtio ring compatible devices to serve virtio driver directly to enable
datapath acceleration. As vDPA driver can help to set up vhost datapath,
this application doesn't need to launch dedicated worker threads for vhost
enqueue/dequeue operations.

Signed-off-by: Xiao Wang 
Signed-off-by: Xiaolong Ye 
---

v2 changes:

* fix a compilation error reported by Rosen
* improve create cmd in interactive mode and add two new cmds: list,
* quit
* add application documentation

 MAINTAINERS|   2 +
 doc/guides/sample_app_ug/index.rst |   1 +
 doc/guides/sample_app_ug/vdpa.rst  | 115 
 examples/Makefile  |   2 +-
 examples/vdpa/Makefile |  32 +++
 examples/vdpa/main.c   | 437 +
 examples/vdpa/meson.build  |  16 ++
 7 files changed, 604 insertions(+), 1 deletion(-)
 create mode 100644 doc/guides/sample_app_ug/vdpa.rst
 create mode 100644 examples/vdpa/Makefile
 create mode 100644 examples/vdpa/main.c
 create mode 100644 examples/vdpa/meson.build

diff --git a/MAINTAINERS b/MAINTAINERS
index 9fd258fad..f84dbf2a7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -682,6 +682,8 @@ F: doc/guides/sample_app_ug/vhost.rst
 F: examples/vhost_scsi/
 F: doc/guides/sample_app_ug/vhost_scsi.rst
 F: examples/vhost_crypto/
+F: examples/vdpa/
+F: doc/guides/sample_app_ug/vdpa.rst
 
 Vhost PMD
 M: Maxime Coquelin 
diff --git a/doc/guides/sample_app_ug/index.rst 
b/doc/guides/sample_app_ug/index.rst
index 5bedf4f6f..74b12af85 100644
--- a/doc/guides/sample_app_ug/index.rst
+++ b/doc/guides/sample_app_ug/index.rst
@@ -45,6 +45,7 @@ Sample Applications User Guides
 vhost
 vhost_scsi
 vhost_crypto
+vdpa
 netmap_compatibility
 ip_pipeline
 test_pipeline
diff --git a/doc/guides/sample_app_ug/vdpa.rst 
b/doc/guides/sample_app_ug/vdpa.rst
new file mode 100644
index 0..ab222731e
--- /dev/null
+++ b/doc/guides/sample_app_ug/vdpa.rst
@@ -0,0 +1,115 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2018 Intel Corporation.
+
+Vdpa Sample Application
+===
+
+The vdpa sample application creates vhost-user sockets by using the
+vDPA backend. vDPA stands for vhost Data Path Acceleration which utilizes
+virtio ring compatible devices to serve virtio driver directly to enable
+datapath acceleration. As vDPA driver can help to set up vhost datapath,
+this application doesn't need to launch dedicated worker threads for vhost
+enqueue/dequeue operations.
+
+Testing steps
+-
+
+This section shows the steps of how to start VMs with vDPA vhost-user
+backend and verify network connection & live migration.
+
+Build
+~
+
+To compile the sample application see :doc:`compiling`.
+
+The application is located in the ``vdpa`` sub-directory.
+
+Start the vdpa example
+~~
+
+.. code-block:: console
+
+./vdpa [EAL options]  -- [--interactive|-i] or [--iface SOCKET_PATH]
+
+where
+
+* iface specifies the path prefix of the UNIX domain socket file, e.g.
+  /tmp/vhost-user-, then the socket files will be named as /tmp/vhost-user-
+  (n starts from 0).
+* interactive means run the vdpa sample in interactive mode, currently 4
+  internal cmds are supported:
+
+  1. help: show help message
+  2. list: list all available vdpa devices
+  3. create: create a new vdpa port with socket file and vdpa device address
+  4. quit: unregister vhost driver and exit the application
+
+Take IFCVF driver for example:
+
+.. code-block:: console
+
+./vdpa --log-level=9 -c 0x6 -n 4 --socket-mem 1024,1024 \
+-w :06:00.2,vdpa=1 -w :06:00.3,vdpa=1 \
+-- --interactive
+
+.. note::
+We need to bind VFIO-pci to VFs before running vdpa sample.
+
+* modprobe vfio-pci
+* ./usertools/dpdk-devbind.py -b vfio-pci 06:00.2 06:00.3
+
+Then we can create 2 vdpa ports in interactive cmdline.
+
+.. code-block:: console
+
+vdpa> list
+device id   device address
+0   :06:00.2
+1   :06:00.3
+vdpa> create /tmp/vdpa-socket0 :06:00.2
+vdpa> create /tmp/vdpa-socket1 :06:00.3
+
+.. _vdpa_app_run_vm:
+
+Start the VMs
+~
+
+.. code-block:: console
+
+   qemu-system-x86_64 -cpu host -enable-kvm \
+   
+   -mem-prealloc \
+   -chardev socket,id=char0,path= \
+   -netdev type=vhost-user,id=vdpa,chardev=char0 \
+   -device virtio-net-pci,netdev=vdpa,mac=00:aa:bb:cc:dd:ee \
+
+After the VMs launches, we can login the VMs and configure the ip, verify the
+network connection via ping or netperf.
+
+.. note::
+Suggest to use QEMU 3.0.0 which extends vhost-user for vDPA.
+
+Live Migration
+~~
+vDPA supports cross-backend live migration, user can migrate SW vhost backend
+VM 

[dpdk-dev] [PATCH v2 01/21] net/atlantic: atlantic PMD driver skeleton

[Igor Russkikh]

From: Pavel Belous 

Makefile/meson build infrastructure, atl_ethdev minimal skeleton,
header with aquantia aQtion NIC device and vendor IDs.

Signed-off-by: Igor Russkikh 
---
 config/common_base|   9 +
 drivers/net/Makefile  |   2 +
 drivers/net/atlantic/Makefile |  36 +++
 drivers/net/atlantic/atl_common.h |  96 
 drivers/net/atlantic/atl_ethdev.c | 281 ++
 drivers/net/atlantic/atl_ethdev.h |  28 +++
 drivers/net/atlantic/meson.build  |  19 ++
 drivers/net/atlantic/rte_pmd_atlantic_version.map |   4 +
 drivers/net/meson.build   |   1 +
 mk/rte.app.mk |   1 +
 10 files changed, 477 insertions(+)
 create mode 100644 drivers/net/atlantic/Makefile
 create mode 100644 drivers/net/atlantic/atl_common.h
 create mode 100644 drivers/net/atlantic/atl_ethdev.c
 create mode 100644 drivers/net/atlantic/atl_ethdev.h
 create mode 100644 drivers/net/atlantic/meson.build
 create mode 100644 drivers/net/atlantic/rte_pmd_atlantic_version.map

diff --git a/config/common_base b/config/common_base
index 4bcbaf923..3b5fc8e71 100644
--- a/config/common_base
+++ b/config/common_base
@@ -635,6 +635,15 @@ CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=n
 CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=n
 
 #
+# Compile Aquantia Atlantic PMD driver
+#
+CONFIG_RTE_LIBRTE_ATLANTIC_PMD=y
+CONFIG_RTE_LIBRTE_ATLANTIC_DEBUG=n
+CONFIG_RTE_LIBRTE_ATLANTIC_DEBUG_RX=n
+CONFIG_RTE_LIBRTE_ATLANTIC_DEBUG_TX=n
+CONFIG_RTE_LIBRTE_ATLANTIC_DEBUG_TX_FREE=n
+
+#
 # Compile raw device support
 # EXPERIMENTAL: API may change without prior notice
 #
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index 664398de9..3d4a1ae59 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -70,4 +70,6 @@ $(error "RTE_LIBRTE_CFGFILE must be enabled in 
configuration!")
 endif
 endif
 
+DIRS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += atlantic
+
 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/drivers/net/atlantic/Makefile b/drivers/net/atlantic/Makefile
new file mode 100644
index 0..9e3c17ac9
--- /dev/null
+++ b/drivers/net/atlantic/Makefile
@@ -0,0 +1,36 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Aquantia Corporation
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+#
+# library name
+#
+LIB = librte_pmd_atlantic.a
+
+CFLAGS += -O3
+CFLAGS += $(WERROR_FLAGS)
+
+EXPORT_MAP := rte_pmd_atlantic_version.map
+
+LIBABIVER := 1
+
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
+LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
+LDLIBS += -lrte_bus_pci
+
+#
+# Add extra flags for base driver files (also known as shared code)
+# to disable warnings in them
+#
+BASE_DRIVER_OBJS=$(sort $(patsubst %.c,%.o,$(notdir $(wildcard 
$(SRCDIR)/base/*.c
+$(foreach obj, $(BASE_DRIVER_OBJS), $(eval 
CFLAGS_$(obj)+=$(CFLAGS_BASE_DRIVER)))
+
+VPATH += $(SRCDIR)/hw_atl
+
+#
+# all source are stored in SRCS-y
+#
+SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += atl_ethdev.c
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/net/atlantic/atl_common.h 
b/drivers/net/atlantic/atl_common.h
new file mode 100644
index 0..b3a0aa5cd
--- /dev/null
+++ b/drivers/net/atlantic/atl_common.h
@@ -0,0 +1,96 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Aquantia Corporation
+ */
+
+#ifndef AQ_COMMON_H
+#define AQ_COMMON_H
+
+#define ATL_PMD_DRIVER_VERSION "0.4.1"
+
+#define PCI_VENDOR_ID_AQUANTIA  0x1D6A
+
+#define AQ_DEVICE_ID_0001  0x0001
+#define AQ_DEVICE_ID_D100  0xD100
+#define AQ_DEVICE_ID_D107  0xD107
+#define AQ_DEVICE_ID_D108  0xD108
+#define AQ_DEVICE_ID_D109  0xD109
+
+#define AQ_DEVICE_ID_AQC1000x00B1
+#define AQ_DEVICE_ID_AQC1070x07B1
+#define AQ_DEVICE_ID_AQC1080x08B1
+#define AQ_DEVICE_ID_AQC1090x09B1
+#define AQ_DEVICE_ID_AQC1110x11B1
+#define AQ_DEVICE_ID_AQC1120x12B1
+
+#define AQ_DEVICE_ID_AQC100S   0x80B1
+#define AQ_DEVICE_ID_AQC107S   0x87B1
+#define AQ_DEVICE_ID_AQC108S   0x88B1
+#define AQ_DEVICE_ID_AQC109S   0x89B1
+#define AQ_DEVICE_ID_AQC111S   0x91B1
+#define AQ_DEVICE_ID_AQC112S   0x92B1
+
+#define AQ_DEVICE_ID_AQC111E   0x51B1
+#define AQ_DEVICE_ID_AQC112E   0x52B1
+
+#define HW_ATL_NIC_NAME "aQuantia AQtion 10Gbit Network Adapter"
+
+#define AQ_HWREV_ANY   0
+#define AQ_HWREV_1 1
+#define AQ_HWREV_2 2
+
+#define AQ_NIC_RATE_10GBIT(0)
+#define AQ_NIC_RATE_5G BIT(1)
+#define AQ_NIC_RATE_5G5R   BIT(2)
+#define AQ_NIC_RATE_2G5BIT(3)
+#define AQ_NIC_RATE_1G BIT(4)
+#define AQ_NIC_RATE_100M   BIT(5)
+
+#define AQ_NIC_RATE_EEE_10GBIT(6)
+#define AQ_NIC_RATE_EEE_5G BIT(7)
+#define AQ_NIC_RATE_EEE_2G5BIT(8)
+#define AQ_NIC_RATE_EEE_1G BIT(9)
+
+
+#define ATL_MAX_RING_DESC  (8 * 1024 - 8)
+#define ATL_MIN_RING_DESC  32
+#define ATL_RXD_ALIGN  8
+#define ATL_TXD_AL

[dpdk-dev] [PATCH v2 02/21] net/atlantic: documentation and rel notes

[Igor Russkikh]

Signed-off-by: Igor Russkikh 
---
 doc/guides/nics/atlantic.rst   | 59 ++
 doc/guides/nics/features/atlantic.ini  | 37 +
 doc/guides/nics/index.rst  |  1 +
 doc/guides/rel_notes/release_18_11.rst |  5 +++
 4 files changed, 102 insertions(+)
 create mode 100644 doc/guides/nics/atlantic.rst
 create mode 100644 doc/guides/nics/features/atlantic.ini

diff --git a/doc/guides/nics/atlantic.rst b/doc/guides/nics/atlantic.rst
new file mode 100644
index 0..b65916fea
--- /dev/null
+++ b/doc/guides/nics/atlantic.rst
@@ -0,0 +1,59 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2018 Aquantia Corporation.
+
+Aquantia Atlantic DPDK Driver
+=
+
+Atlantic DPDK driver provides DPDK support for Aquantia's AQtion family of 
chipsets: AQC107/AQC108/AQC109
+
+Supported features
+^^
+
+
+- Base L2 features
+- Promiscuous mode
+- Port statistics
+- Multicast mode
+- RSS (Receive Side Scaling)
+- Checksum offload
+- Jumbo Frame upto 16K
+
+Configuration Information
+^
+
+- ``CONFIG_RTE_LIBRTE_ATLANTIC_PMD`` (default ``y``)
+
+- Various debug (default ``n``):
+- ``CONFIG_RTE_LIBRTE_ATLANTIC_DEBUG``
+- ``CONFIG_RTE_LIBRTE_ATLANTIC_DEBUG_RX``
+- ``CONFIG_RTE_LIBRTE_ATLANTIC_DEBUG_TX``
+- ``CONFIG_RTE_LIBRTE_ATLANTIC_DEBUG_TX_FREE``
+
+Not yet supported features
+^^
+
+NOP
+
+Application Programming Interface
+-
+
+Atlantic NIC supports custom LED pin configuration interface.
+For details, refer rte_pmd_atlantic.h header file
+
+Limitations or Known issues
+---
+
+Statistics
+~~
+
+MTU setting
+~~~
+
+Atlantic NIC supports up to 16K jumbo frame size
+
+Supported Chipsets and NICs
+---
+
+- Aquantia AQtion AQC107 10 Gigabit Ethernet Controller
+- Aquantia AQtion AQC108 5 Gigabit Ethernet Controller
+- Aquantia AQtion AQC109 2.5 Gigabit Ethernet Controller
diff --git a/doc/guides/nics/features/atlantic.ini 
b/doc/guides/nics/features/atlantic.ini
new file mode 100644
index 0..2d943ce13
--- /dev/null
+++ b/doc/guides/nics/features/atlantic.ini
@@ -0,0 +1,37 @@
+;
+; Supported features of the 'atlantic' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Speed capabilities   = Y
+Link status  = Y
+Link status event= Y
+MTU update   = Y
+Jumbo frame  = Y
+Promiscuous mode = Y
+Allmulticast mode= Y
+Unicast MAC filter   = Y
+VLAN filter  = Y
+Flow control = Y
+CRC offload  = Y
+VLAN offload = Y
+L3 checksum offload  = Y
+L4 checksum offload  = Y
+Rx descriptor status = Y
+Tx descriptor status = Y
+Basic stats  = Y
+Extended stats   = Y
+Stats per queue  = Y
+Linux UIO= Y
+x86-32   = Y
+x86-64   = Y
+Queue start/stop = Y
+RSS hash = Y
+RSS key update   = Y
+RSS reta update  = Y
+Packet type parsing  = Y
+FW version   = Y
+EEPROM dump  = Y
+Registers dump   = Y
+LED  = Y
diff --git a/doc/guides/nics/index.rst b/doc/guides/nics/index.rst
index 59f6063dc..7925c2bd8 100644
--- a/doc/guides/nics/index.rst
+++ b/doc/guides/nics/index.rst
@@ -12,6 +12,7 @@ Network Interface Controller Drivers
 features
 build_and_test
 ark
+atlantic
 avp
 axgbe
 bnx2x
diff --git a/doc/guides/rel_notes/release_18_11.rst 
b/doc/guides/rel_notes/release_18_11.rst
index 3ae6b3f58..5a68ff8c3 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -54,6 +54,11 @@ New Features
  Also, make sure to start the actual text at the margin.
  =
 
+* **Added Ethernet poll mode driver for Aquantia aQtion family of 10G 
devices.**
+
+  Added the new ``atlantic`` ethernet poll mode driver for Aquantia XGBE 
devices.
+  See the :doc:`../nics/atlantic` nic driver guide for more details on this
+  driver.
 
 API Changes
 ---
-- 
2.13.3.windows.1

[dpdk-dev] [PATCH v2 03/21] net/atlantic: logging macroes and some typedefs

[Igor Russkikh]

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.c | 18 +--
 drivers/net/atlantic/atl_logs.h   | 68 +++
 drivers/net/atlantic/atl_types.h  | 35 
 3 files changed, 118 insertions(+), 3 deletions(-)
 create mode 100644 drivers/net/atlantic/atl_logs.h
 create mode 100644 drivers/net/atlantic/atl_types.h

diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index a1b1002ec..951e0f386 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -146,6 +146,8 @@ eth_atl_dev_init(struct rte_eth_dev *eth_dev)
struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
int err = 0;
 
+   PMD_INIT_FUNC_TRACE();
+
eth_dev->dev_ops = &atl_eth_dev_ops;
eth_dev->rx_pkt_burst = &atl_recv_pkts;
eth_dev->tx_pkt_burst = &atl_xmit_pkts;
@@ -165,6 +167,8 @@ eth_atl_dev_uninit(struct rte_eth_dev *eth_dev)
struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
struct aq_hw_s *hw;
 
+   PMD_INIT_FUNC_TRACE();
+
if (rte_eal_process_type() != RTE_PROC_PRIMARY)
return -EPERM;
 
@@ -220,17 +224,25 @@ atl_dev_start(struct rte_eth_dev *dev)
!RTE_ETH_DEV_SRIOV(dev).active) &&
dev->data->dev_conf.intr_conf.rxq != 0) {
intr_vector = dev->data->nb_rx_queues;
-   if (intr_vector > ATL_MAX_INTR_QUEUE_NUM)
+   if (intr_vector > ATL_MAX_INTR_QUEUE_NUM) {
+   PMD_INIT_LOG(ERR, "At most %d intr queues supported",
+   ATL_MAX_INTR_QUEUE_NUM);
return -ENOTSUP;
-   if (rte_intr_efd_enable(intr_handle, intr_vector))
+   }
+   if (rte_intr_efd_enable(intr_handle, intr_vector)) {
+   PMD_INIT_LOG(ERR, "rte_intr_efd_enable failed");
return -1;
+   }
}
 
if (rte_intr_dp_is_en(intr_handle) && !intr_handle->intr_vec) {
intr_handle->intr_vec = rte_zmalloc("intr_vec",
dev->data->nb_rx_queues * sizeof(int), 0);
-   if (intr_handle->intr_vec == NULL)
+   if (intr_handle->intr_vec == NULL) {
+   PMD_INIT_LOG(ERR, "Failed to allocate %d rx_queues"
+" intr_vec", dev->data->nb_rx_queues);
return -ENOMEM;
+   }
}
 
return 0;
diff --git a/drivers/net/atlantic/atl_logs.h b/drivers/net/atlantic/atl_logs.h
new file mode 100644
index 0..b6e566190
--- /dev/null
+++ b/drivers/net/atlantic/atl_logs.h
@@ -0,0 +1,68 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Aquantia Corporation
+ */
+#ifndef ATL_LOGS_H
+#define ATL_LOGS_H
+
+#include 
+
+extern int atl_logtype_init;
+
+#ifndef RTE_LIBRTE_ATLANTIC_DEBUG
+#define RTE_LIBRTE_ATLANTIC_DEBUG 0
+#endif
+
+#ifndef RTE_LIBRTE_ATLANTIC_DEBUG_RX
+#define RTE_LIBRTE_ATLANTIC_DEBUG_RX 0
+#endif
+
+#ifndef RTE_LIBRTE_ATLANTIC_DEBUG_TX
+#define RTE_LIBRTE_ATLANTIC_DEBUG_TX 0
+#endif
+
+#ifndef RTE_LIBRTE_ATLANTIC_DEBUG_TX_FREE
+#define RTE_LIBRTE_ATLANTIC_DEBUG_TX_FREE 0
+#endif
+
+
+
+#if RTE_LIBRTE_ATLANTIC_DEBUG
+#define PMD_INIT_LOG(level, fmt, args...) \
+   rte_log(RTE_LOG_ ## level, atl_logtype_init, \
+   "%s(): " fmt "\n", __func__, ##args)
+#else
+#define PMD_INIT_LOG(level, fmt, args...) do { } while (0)
+#endif
+
+#define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>")
+
+#if RTE_LIBRTE_ATLANTIC_DEBUG_RX
+#define PMD_RX_LOG(level, fmt, args...) \
+   RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
+#else
+#define PMD_RX_LOG(level, fmt, args...) do { } while (0)
+#endif
+
+#if RTE_LIBRTE_ATLANTIC_DEBUG_TX
+#define PMD_TX_LOG(level, fmt, args...) \
+   RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
+#else
+#define PMD_TX_LOG(level, fmt, args...) do { } while (0)
+#endif
+
+#if RTE_LIBRTE_ATLANTIC_DEBUG_TX_FREE
+#define PMD_TX_FREE_LOG(level, fmt, args...) \
+   RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
+#else
+#define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)
+#endif
+
+extern int atl_logtype_driver;
+#define PMD_DRV_LOG_RAW(level, fmt, args...) \
+   rte_log(RTE_LOG_ ## level, atl_logtype_driver, "%s(): " fmt, \
+   __func__, ## args)
+
+#define PMD_DRV_LOG(level, fmt, args...) \
+   PMD_DRV_LOG_RAW(level, fmt "\n", ## args)
+
+#endif
diff --git a/drivers/net/atlantic/atl_types.h b/drivers/net/atlantic/atl_types.h
new file mode 100644
index 0..1684c8cd8
--- /dev/null
+++ b/drivers/net/atlantic/atl_types.h
@@ -0,0 +1,35 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Aquantia Corporation
+ */
+#ifndef ATL_TYPES_H
+#define ATL_TYPES_H
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+typedef 

[dpdk-dev] [PATCH v2 06/21] net/atlantic: firmware operations layer

[Igor Russkikh]

AQC NICs comes in fields with two major
FW generations: 1x and 3x.

This is part of linux atlantic driver shared code,
responsible for internal NIC firmware interactions,
including link management ops, FW initialization,
various lifecycle features.

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/hw_atl/hw_atl_utils.c  | 942 
 drivers/net/atlantic/hw_atl/hw_atl_utils.h  | 510 +
 drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 618 
 3 files changed, 2070 insertions(+)
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_utils.c
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_utils.h
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c

diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c 
b/drivers/net/atlantic/hw_atl/hw_atl_utils.c
new file mode 100644
index 0..c465a77a0
--- /dev/null
+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils.c
@@ -0,0 +1,942 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (C) 2014-2017 aQuantia Corporation. */
+
+/* File hw_atl_utils.c: Definition of common functions for Atlantic hardware
+ * abstraction layer.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "../atl_hw_regs.h"
+
+#include "hw_atl_llh.h"
+#include "hw_atl_llh_internal.h"
+#include "../atl_logs.h"
+
+#define HW_ATL_UCP_0X370_REG0x0370U
+
+#define HW_ATL_MIF_CMD  0x0200U
+#define HW_ATL_MIF_ADDR 0x0208U
+#define HW_ATL_MIF_VAL  0x020CU
+
+#define HW_ATL_FW_SM_RAM0x2U
+#define HW_ATL_MPI_FW_VERSION  0x18
+#define HW_ATL_MPI_CONTROL_ADR  0x0368U
+#define HW_ATL_MPI_STATE_ADR0x036CU
+
+#define HW_ATL_MPI_STATE_MSK  0x00FFU
+#define HW_ATL_MPI_STATE_SHIFT0U
+#define HW_ATL_MPI_SPEED_MSK  0x00FFU
+#define HW_ATL_MPI_SPEED_SHIFT16U
+#define HW_ATL_MPI_DIRTY_WAKE_MSK 0x0200U
+
+#define HW_ATL_MPI_DAISY_CHAIN_STATUS  0x704
+#define HW_ATL_MPI_BOOT_EXIT_CODE  0x388
+
+#define HW_ATL_MAC_PHY_CONTROL 0x4000
+#define HW_ATL_MAC_PHY_MPI_RESET_BIT 0x1D
+
+#define HW_ATL_FW_VER_1X 0x01050006U
+#define HW_ATL_FW_VER_2X 0x0200U
+#define HW_ATL_FW_VER_3X 0x0300U
+
+#define FORCE_FLASHLESS 0
+
+static int hw_atl_utils_ver_match(u32 ver_expected, u32 ver_actual);
+static int hw_atl_utils_mpi_set_state(struct aq_hw_s *self,
+   enum hal_atl_utils_fw_state_e state);
+
+
+int hw_atl_utils_initfw(struct aq_hw_s *self, const struct aq_fw_ops **fw_ops)
+{
+   int err = 0;
+
+   err = hw_atl_utils_soft_reset(self);
+   if (err)
+   return err;
+
+   hw_atl_utils_hw_chip_features_init(self,
+  &self->chip_features);
+
+   hw_atl_utils_get_fw_version(self, &self->fw_ver_actual);
+
+   if (hw_atl_utils_ver_match(HW_ATL_FW_VER_1X,
+  self->fw_ver_actual) == 0) {
+   *fw_ops = &aq_fw_1x_ops;
+   } else if (hw_atl_utils_ver_match(HW_ATL_FW_VER_2X,
+   self->fw_ver_actual) == 0) {
+   *fw_ops = &aq_fw_2x_ops;
+   } else if (hw_atl_utils_ver_match(HW_ATL_FW_VER_3X,
+   self->fw_ver_actual) == 0) {
+   *fw_ops = &aq_fw_2x_ops;
+   } else {
+   PMD_DRV_LOG(ERR, "Bad FW version detected: %x\n",
+ self->fw_ver_actual);
+   return -EOPNOTSUPP;
+   }
+   self->aq_fw_ops = *fw_ops;
+   err = self->aq_fw_ops->init(self);
+   return err;
+}
+
+static int hw_atl_utils_soft_reset_flb(struct aq_hw_s *self)
+{
+   u32 gsr, val;
+   int k = 0;
+
+   aq_hw_write_reg(self, 0x404, 0x40e1);
+   AQ_HW_SLEEP(50);
+
+   /* Cleanup SPI */
+   val = aq_hw_read_reg(self, 0x53C);
+   aq_hw_write_reg(self, 0x53C, val | 0x10);
+
+   gsr = aq_hw_read_reg(self, HW_ATL_GLB_SOFT_RES_ADR);
+   aq_hw_write_reg(self, HW_ATL_GLB_SOFT_RES_ADR, (gsr & 0xBFFF) | 0x8000);
+
+   /* Kickstart MAC */
+   aq_hw_write_reg(self, 0x404, 0x80e0);
+   aq_hw_write_reg(self, 0x32a8, 0x0);
+   aq_hw_write_reg(self, 0x520, 0x1);
+
+   /* Reset SPI again because of possible interrupted SPI burst */
+   val = aq_hw_read_reg(self, 0x53C);
+   aq_hw_write_reg(self, 0x53C, val | 0x10);
+   AQ_HW_SLEEP(10);
+   /* Clear SPI reset state */
+   aq_hw_write_reg(self, 0x53C, val & ~0x10);
+
+   aq_hw_write_reg(self, 0x404, 0x180e0);
+
+   for (k = 0; k < 1000; k++) {
+   u32 flb_status = aq_hw_read_reg(self,
+   HW_ATL_MPI_DAISY_CHAIN_STATUS);
+
+   flb_status = flb_status & 0x10;
+   if (flb_status)
+   break;
+   AQ_HW_SLEEP(10);
+   }
+   if (k == 1000) {
+   PMD_DRV_LOG(ERR, "MAC kickstart failed\n");
+   return -EIO;
+   }
+
+   

[dpdk-dev] [PATCH v2 08/21] net/atlantic: rte device start, stop, initial configuration

[Igor Russkikh]

Start, stop and reset are all done via hw_atl layer.
Link interrupt configuration is also done here.

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.c | 256 ++
 drivers/net/atlantic/atl_ethdev.h |   2 +
 2 files changed, 258 insertions(+)

diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index 951e0f386..5de295f6f 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -39,6 +39,9 @@
 #include "atl_common.h"
 #include "atl_hw_regs.h"
 #include "atl_logs.h"
+#include "hw_atl/hw_atl_llh.h"
+#include "hw_atl/hw_atl_b0.h"
+#include "hw_atl/hw_atl_b0_internal.h"
 
 static int eth_atl_dev_init(struct rte_eth_dev *eth_dev);
 static int eth_atl_dev_uninit(struct rte_eth_dev *eth_dev);
@@ -126,6 +129,26 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
.dev_reset= atl_dev_reset,
 };
 
+static inline int32_t
+atl_reset_hw(struct aq_hw_s *hw)
+{
+   return hw_atl_b0_hw_reset(hw);
+}
+
+static inline void
+atl_enable_intr(struct rte_eth_dev *dev)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   hw_atl_itr_irq_msk_setlsw_set(hw, 0x);
+}
+
+static void
+atl_disable_intr(struct aq_hw_s *hw)
+{
+   PMD_INIT_FUNC_TRACE();
+   hw_atl_itr_irq_msk_clearlsw_set(hw, 0x);
+}
 
 static int
 atl_get_bus_info(struct aq_hw_s *hw)
@@ -136,6 +159,16 @@ atl_get_bus_info(struct aq_hw_s *hw)
return 0;
 }
 
+static void
+atl_print_adapter_info(struct aq_hw_s *hw __rte_unused)
+{
+   PMD_INIT_LOG(DEBUG, "FW version: %u.%u.%u",
+   hw->fw_ver_actual >> 24,
+   (hw->fw_ver_actual >> 16) & 0xFF,
+   hw->fw_ver_actual & 0x);
+   PMD_INIT_LOG(DEBUG, "Driver version: %s", ATL_PMD_DRIVER_VERSION);
+}
+
 static int
 eth_atl_dev_init(struct rte_eth_dev *eth_dev)
 {
@@ -157,6 +190,62 @@ eth_atl_dev_init(struct rte_eth_dev *eth_dev)
if (rte_eal_process_type() != RTE_PROC_PRIMARY)
return 0;
 
+   rte_eth_copy_pci_info(eth_dev, pci_dev);
+
+   /* Vendor and Device ID need to be set before init of shared code */
+   hw->device_id = pci_dev->id.device_id;
+   hw->vendor_id = pci_dev->id.vendor_id;
+   hw->mmio = (void *)pci_dev->mem_resource[0].addr;
+   hw->allow_unsupported_sfp = 1;
+
+   /* Hardware configuration - hardcode */
+   adapter->hw_cfg.is_lro = false;
+   adapter->hw_cfg.is_rss = false;
+   adapter->hw_cfg.num_rss_queues = HW_ATL_B0_RSS_MAX;
+   adapter->hw_cfg.wol = false;
+   adapter->hw_cfg.link_speed_msk = AQ_NIC_RATE_10G |
+ AQ_NIC_RATE_5G |
+ AQ_NIC_RATE_2G5 |
+ AQ_NIC_RATE_1G |
+ AQ_NIC_RATE_100M;
+
+   adapter->hw_cfg.flow_control = (AQ_NIC_FC_RX | AQ_NIC_FC_TX);
+   adapter->hw_cfg.aq_rss.indirection_table_size =
+   HW_ATL_B0_RSS_REDIRECTION_MAX;
+
+   hw->aq_nic_cfg = &adapter->hw_cfg;
+
+   /* pick up the PCI bus settings for reporting later */
+   atl_get_bus_info(hw);
+
+   /* disable interrupt */
+   atl_disable_intr(hw);
+
+   /* Allocate memory for storing MAC addresses */
+   eth_dev->data->mac_addrs = rte_zmalloc("atlantic", ETHER_ADDR_LEN, 0);
+   if (eth_dev->data->mac_addrs == NULL) {
+   PMD_INIT_LOG(ERR, "MAC Malloc failed");
+   return -ENOMEM;
+   }
+
+   err = hw_atl_utils_initfw(hw, &hw->aq_fw_ops);
+   if (err)
+   return err;
+
+   /* Copy the permanent MAC address */
+   if (hw->aq_fw_ops->get_mac_permanent(hw,
+   (u8 *)ð_dev->data->mac_addrs[0]) != 0)
+   return -EINVAL;
+
+   rte_intr_callback_register(intr_handle,
+  atl_dev_interrupt_handler, eth_dev);
+
+   /* enable uio/vfio intr/eventfd mapping */
+   rte_intr_enable(intr_handle);
+
+   /* enable support intr */
+   atl_enable_intr(eth_dev);
+
return err;
 }
 
@@ -172,10 +261,30 @@ eth_atl_dev_uninit(struct rte_eth_dev *eth_dev)
if (rte_eal_process_type() != RTE_PROC_PRIMARY)
return -EPERM;
 
+   hw = ATL_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private);
+
+   if (hw->adapter_stopped == 0)
+   atl_dev_close(eth_dev);
+
eth_dev->dev_ops = NULL;
eth_dev->rx_pkt_burst = NULL;
eth_dev->tx_pkt_burst = NULL;
 
+   /* disable uio intr before callback unregister */
+   rte_intr_disable(intr_handle);
+   rte_intr_callback_unregister(intr_handle,
+atl_dev_interrupt_handler, eth_dev);
+
+   rte_free(eth_dev->data->mac_addrs);
+   eth_dev->data->mac_addrs = NULL;
+
+   rte_free(eth_dev->data->hash_mac_addrs);
+   eth_dev->data->hash_mac_addrs = NULL;
+
+#ifdef RTE_LIBRTE_SECURITY
+   

[dpdk-dev] [PATCH v2 07/21] net/atlantic: hardware register access routines

[Igor Russkikh]

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_hw_regs.c | 52 +
 drivers/net/atlantic/atl_hw_regs.h | 53 ++
 2 files changed, 105 insertions(+)
 create mode 100644 drivers/net/atlantic/atl_hw_regs.c
 create mode 100644 drivers/net/atlantic/atl_hw_regs.h

diff --git a/drivers/net/atlantic/atl_hw_regs.c 
b/drivers/net/atlantic/atl_hw_regs.c
new file mode 100644
index 0..231dc712f
--- /dev/null
+++ b/drivers/net/atlantic/atl_hw_regs.c
@@ -0,0 +1,52 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (C) 2014-2017 aQuantia Corporation. */
+
+/* File aq_hw_utils.c: Definitions of helper functions used across
+ * hardware layer.
+ */
+
+#include "atl_hw_regs.h"
+
+#include 
+#include 
+
+void aq_hw_write_reg_bit(struct aq_hw_s *aq_hw, u32 addr, u32 msk,
+u32 shift, u32 val)
+{
+   if (msk ^ ~0) {
+   u32 reg_old, reg_new;
+
+   reg_old = aq_hw_read_reg(aq_hw, addr);
+   reg_new = (reg_old & (~msk)) | (val << shift);
+
+   if (reg_old != reg_new)
+   aq_hw_write_reg(aq_hw, addr, reg_new);
+   } else {
+   aq_hw_write_reg(aq_hw, addr, val);
+   }
+}
+
+u32 aq_hw_read_reg_bit(struct aq_hw_s *aq_hw, u32 addr, u32 msk, u32 shift)
+{
+   return ((aq_hw_read_reg(aq_hw, addr) & msk) >> shift);
+}
+
+u32 aq_hw_read_reg(struct aq_hw_s *hw, u32 reg)
+{
+   return rte_le_to_cpu_32(rte_read32((u8 *)hw->mmio + reg));
+}
+
+void aq_hw_write_reg(struct aq_hw_s *hw, u32 reg, u32 value)
+{
+   rte_write32((rte_cpu_to_le_32(value)), (u8 *)hw->mmio + reg);
+}
+
+int aq_hw_err_from_flags(struct aq_hw_s *hw)
+{
+   int err = 0;
+
+   if (aq_hw_read_reg(hw, 0x10U) == ~0U)
+   return -ENXIO;
+
+   return err;
+}
diff --git a/drivers/net/atlantic/atl_hw_regs.h 
b/drivers/net/atlantic/atl_hw_regs.h
new file mode 100644
index 0..fc109f5d8
--- /dev/null
+++ b/drivers/net/atlantic/atl_hw_regs.h
@@ -0,0 +1,53 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright (C) 2014-2017 aQuantia Corporation. */
+
+/* File aq_hw_utils.h: Declaration of helper functions used across hardware
+ * layer.
+ */
+
+#ifndef AQ_HW_UTILS_H
+#define AQ_HW_UTILS_H
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "atl_common.h"
+#include "atl_types.h"
+
+
+#ifndef HIDWORD
+#define LODWORD(_qw)((u32)(_qw))
+#define HIDWORD(_qw)((u32)(((_qw) >> 32) & 0x))
+#endif
+
+#define AQ_HW_SLEEP(_US_) rte_delay_ms(_US_)
+
+#define mdelay rte_delay_ms
+#define udelay rte_delay_us
+#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
+#define BIT(x) (1UL << (x))
+
+#define AQ_HW_WAIT_FOR(_B_, _US_, _N_) \
+do { \
+   unsigned int AQ_HW_WAIT_FOR_i; \
+   for (AQ_HW_WAIT_FOR_i = _N_; (!(_B_)) && (AQ_HW_WAIT_FOR_i);\
+   --AQ_HW_WAIT_FOR_i) {\
+   udelay(_US_); \
+   } \
+   if (!AQ_HW_WAIT_FOR_i) {\
+   err = -ETIMEDOUT; \
+   } \
+} while (0)
+
+#define ATL_WRITE_FLUSH(aq_hw) { (void)aq_hw_read_reg(aq_hw, 0x10); }
+
+void aq_hw_write_reg_bit(struct aq_hw_s *aq_hw, u32 addr, u32 msk,
+u32 shift, u32 val);
+u32 aq_hw_read_reg_bit(struct aq_hw_s *aq_hw, u32 addr, u32 msk, u32 shift);
+u32 aq_hw_read_reg(struct aq_hw_s *hw, u32 reg);
+void aq_hw_write_reg(struct aq_hw_s *hw, u32 reg, u32 value);
+int aq_hw_err_from_flags(struct aq_hw_s *hw);
+
+#endif /* AQ_HW_UTILS_H */
-- 
2.13.3.windows.1

[dpdk-dev] [PATCH v2 10/21] net/atlantic: add hw adapter structures and defines

[Igor Russkikh]

From: Pavel Belous 

These declare statistic structures, hw internal structures and variables.

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.h |   9 ++
 drivers/net/atlantic/atl_types.h  | 200 ++
 2 files changed, 209 insertions(+)

diff --git a/drivers/net/atlantic/atl_ethdev.h 
b/drivers/net/atlantic/atl_ethdev.h
index 5b9fc63c6..ce4bc9544 100644
--- a/drivers/net/atlantic/atl_ethdev.h
+++ b/drivers/net/atlantic/atl_ethdev.h
@@ -16,12 +16,18 @@
 #define ATL_FLAG_NEED_LINK_UPDATE (uint32_t)(1 << 0)
 #define ATL_FLAG_NEED_LINK_CONFIG (uint32_t)(4 << 0)
 
+struct atl_interrupt {
+   uint32_t flags;
+   uint32_t mask;
+};
+
 /*
  * Structure to store private data for each driver instance (for each port).
  */
 struct atl_adapter {
struct aq_hw_s hw;
struct aq_hw_cfg_s hw_cfg;
+   struct atl_sw_statssw_stats;
struct atl_interrupt   intr;
 };
 
@@ -31,6 +37,9 @@ struct atl_adapter {
 #define ATL_DEV_PRIVATE_TO_HW(adapter) \
(&((struct atl_adapter *)adapter)->hw)
 
+#define ATL_DEV_PRIVATE_TO_STATS(adapter) \
+   (&((struct atl_adapter *)adapter)->sw_stats)
+
 #define ATL_DEV_PRIVATE_TO_INTR(adapter) \
(&((struct atl_adapter *)adapter)->intr)
 
diff --git a/drivers/net/atlantic/atl_types.h b/drivers/net/atlantic/atl_types.h
index 1684c8cd8..6f58b79c9 100644
--- a/drivers/net/atlantic/atl_types.h
+++ b/drivers/net/atlantic/atl_types.h
@@ -32,4 +32,204 @@ typedef int bool;
 /* Memory barrier */
 #define wmb()  rte_wmb()
 
+#include "hw_atl/hw_atl_b0_internal.h"
+#include "hw_atl/hw_atl_utils.h"
+
+struct aq_hw_link_status_s {
+   unsigned int mbps;
+};
+
+struct aq_stats_s {
+   u64 uprc;
+   u64 mprc;
+   u64 bprc;
+   u64 erpt;
+   u64 uptc;
+   u64 mptc;
+   u64 bptc;
+   u64 erpr;
+   u64 mbtc;
+   u64 bbtc;
+   u64 mbrc;
+   u64 bbrc;
+   u64 ubrc;
+   u64 ubtc;
+   u64 dpc;
+   u64 dma_pkt_rc;
+   u64 dma_pkt_tc;
+   u64 dma_oct_rc;
+   u64 dma_oct_tc;
+};
+
+enum atl_bus_speed {
+   atl_bus_speed_unknown = 0,
+   atl_bus_speed_2500,
+   atl_bus_speed_5000,
+   atl_bus_speed_reserved
+};
+
+enum atl_bus_width {
+   atl_bus_width_unknown = 0,
+   atl_bus_width_pcie_x1,
+   atl_bus_width_pcie_x2,
+   atl_bus_width_pcie_x4 = 4,
+   atl_bus_width_pcie_x8 = 8,
+   atl_bus_width_reserved
+};
+
+struct atl_bus_info {
+   enum atl_bus_speed speed;
+   enum atl_bus_width width;
+
+   u16 func;
+   u16 pci_cmd_word;
+};
+
+struct aq_rss_parameters {
+   u16 base_cpu_number;
+   u16 indirection_table_size;
+   u16 hash_secret_key_size;
+   u32 hash_secret_key[HW_ATL_B0_RSS_HASHKEY_BITS / 8];
+   u8 indirection_table[HW_ATL_B0_RSS_REDIRECTION_MAX];
+};
+
+struct aq_hw_cfg_s {
+   bool is_lro;
+   bool is_rss;
+   unsigned int num_rss_queues;
+   int wol;
+
+   int link_speed_msk;
+   int irq_type;
+   int irq_mask;
+   unsigned int vecs;
+
+   bool vlan_strip;
+   uint32_t vlan_filter[HW_ATL_B0_MAX_VLAN_IDS];
+   uint32_t flow_control;
+
+   struct aq_rss_parameters aq_rss;
+};
+
+struct aq_hw_s {
+   void *back;
+
+   struct atl_bus_info bus;
+
+   const u32 *mvals;
+   u16 device_id;
+   u16 vendor_id;
+   u16 subsystem_device_id;
+   u16 subsystem_vendor_id;
+   u8 revision_id;
+   bool adapter_stopped;
+   int api_version;
+   bool force_full_reset;
+   bool allow_unsupported_sfp;
+   bool wol_enabled;
+   bool need_crosstalk_fix;
+
+   u8 rbl_enabled:1;
+   struct aq_hw_cfg_s *aq_nic_cfg;
+   const struct aq_fw_ops *aq_fw_ops;
+   void *mmio;
+
+   struct aq_hw_link_status_s aq_link_status;
+   bool is_autoneg;
+
+   struct hw_aq_atl_utils_mbox mbox;
+   struct hw_atl_stats_s last_stats;
+   struct aq_stats_s curr_stats;
+
+   u64 speed;
+   u32 itr_tx;
+   u32 itr_rx;
+   unsigned int chip_features;
+   u32 fw_ver_actual;
+   u32 mbox_addr;
+   u32 rpc_addr;
+   u32 rpc_tid;
+   struct hw_aq_atl_utils_fw_rpc rpc;
+};
+
+struct aq_fw_ops {
+   int (*init)(struct aq_hw_s *self);
+
+   int (*deinit)(struct aq_hw_s *self);
+
+   int (*reset)(struct aq_hw_s *self);
+
+   int (*get_mac_permanent)(struct aq_hw_s *self, u8 *mac);
+
+   int (*set_link_speed)(struct aq_hw_s *self, u32 speed);
+
+   int (*set_state)(struct aq_hw_s *self,
+   enum hal_atl_utils_fw_state_e state);
+
+   int (*update_link_status)(struct aq_hw_s *self);
+
+   int (*update_stats)(struct aq_hw_s *self);
+
+   int (*set_power)(struct aq_hw_s *self, unsigned int power_state,
+   u8 *mac);
+
+   int (*get_temp)(struct aq_hw_s *self, int *temp);
+
+   int (*get_cable_len)(struct aq_h

[dpdk-dev] [PATCH v2 11/21] net/atlantic: RSS and RETA manipulation API

[Igor Russkikh]

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.c   | 99 +
 drivers/net/atlantic/hw_atl/hw_atl_b0.c | 29 +-
 2 files changed, 100 insertions(+), 28 deletions(-)

diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index 71f4e8e0a..b58f684f6 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -75,6 +75,19 @@ static int atl_dev_interrupt_action(struct rte_eth_dev *dev,
 static void atl_dev_interrupt_handler(void *param);
 
 
+/* RSS */
+static int atl_reta_update(struct rte_eth_dev *dev,
+struct rte_eth_rss_reta_entry64 *reta_conf,
+uint16_t reta_size);
+static int atl_reta_query(struct rte_eth_dev *dev,
+   struct rte_eth_rss_reta_entry64 *reta_conf,
+   uint16_t reta_size);
+static int atl_rss_hash_update(struct rte_eth_dev *dev,
+struct rte_eth_rss_conf *rss_conf);
+static int atl_rss_hash_conf_get(struct rte_eth_dev *dev,
+  struct rte_eth_rss_conf *rss_conf);
+
+
 static int eth_atl_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
struct rte_pci_device *pci_dev);
 static int eth_atl_pci_remove(struct rte_pci_device *pci_dev);
@@ -143,6 +156,12 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
.dev_reset= atl_dev_reset,
/* Link */
.link_update  = atl_dev_link_update,
+
+   .reta_update  = atl_reta_update,
+   .reta_query   = atl_reta_query,
+   .rss_hash_update  = atl_rss_hash_update,
+   .rss_hash_conf_get= atl_rss_hash_conf_get,
+
 };
 
 /**
@@ -802,6 +821,86 @@ atl_dev_interrupt_handler(void *param)
atl_dev_interrupt_action(dev, dev->intr_handle);
 }
 
+
+static int
+atl_reta_update(struct rte_eth_dev *dev,
+  struct rte_eth_rss_reta_entry64 *reta_conf,
+  uint16_t reta_size)
+{
+   int i;
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   struct aq_hw_cfg_s *cf = ATL_DEV_PRIVATE_TO_CFG(dev->data->dev_private);
+
+   for (i = 0; i < reta_size && i < cf->aq_rss.indirection_table_size; i++)
+   cf->aq_rss.indirection_table[i] = min(reta_conf->reta[i],
+   dev->data->nb_rx_queues - 1);
+
+   hw_atl_b0_hw_rss_set(hw, &cf->aq_rss);
+   return 0;
+}
+
+static int
+atl_reta_query(struct rte_eth_dev *dev,
+   struct rte_eth_rss_reta_entry64 *reta_conf,
+   uint16_t reta_size)
+{
+   int i;
+   struct aq_hw_cfg_s *cf = ATL_DEV_PRIVATE_TO_CFG(dev->data->dev_private);
+
+   for (i = 0; i < reta_size && i < cf->aq_rss.indirection_table_size; i++)
+   reta_conf->reta[i] = cf->aq_rss.indirection_table[i];
+   reta_conf->mask = ~0U;
+   return 0;
+}
+
+static int
+atl_rss_hash_update(struct rte_eth_dev *dev,
+struct rte_eth_rss_conf *rss_conf)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   struct aq_hw_cfg_s *cfg =
+   ATL_DEV_PRIVATE_TO_CFG(dev->data->dev_private);
+   static u8 def_rss_key[40] = {
+   0x1e, 0xad, 0x71, 0x87, 0x65, 0xfc, 0x26, 0x7d,
+   0x0d, 0x45, 0x67, 0x74, 0xcd, 0x06, 0x1a, 0x18,
+   0xb6, 0xc1, 0xf0, 0xc7, 0xbb, 0x18, 0xbe, 0xf8,
+   0x19, 0x13, 0x4b, 0xa9, 0xd0, 0x3e, 0xfe, 0x70,
+   0x25, 0x03, 0xab, 0x50, 0x6a, 0x8b, 0x82, 0x0c
+   };
+
+   cfg->is_rss = !!rss_conf->rss_hf;
+   if (rss_conf->rss_key) {
+   memcpy(cfg->aq_rss.hash_secret_key, rss_conf->rss_key,
+  rss_conf->rss_key_len);
+   cfg->aq_rss.hash_secret_key_size = rss_conf->rss_key_len;
+   } else {
+   memcpy(cfg->aq_rss.hash_secret_key, def_rss_key,
+  sizeof(def_rss_key));
+   cfg->aq_rss.hash_secret_key_size = sizeof(def_rss_key);
+   }
+
+   hw_atl_b0_hw_rss_set(hw, &cfg->aq_rss);
+   hw_atl_b0_hw_rss_hash_set(hw, &cfg->aq_rss);
+   return 0;
+}
+
+static int
+atl_rss_hash_conf_get(struct rte_eth_dev *dev,
+struct rte_eth_rss_conf *rss_conf)
+{
+   struct aq_hw_cfg_s *cfg =
+   ATL_DEV_PRIVATE_TO_CFG(dev->data->dev_private);
+
+   rss_conf->rss_hf = cfg->is_rss ? ATL_RSS_OFFLOAD_ALL : 0;
+   if (rss_conf->rss_key) {
+   rss_conf->rss_key_len = cfg->aq_rss.hash_secret_key_size;
+   memcpy(rss_conf->rss_key, cfg->aq_rss.hash_secret_key,
+  rss_conf->rss_key_len);
+   }
+
+   return 0;
+}
+
 RTE_PMD_REGISTER_PCI(net_atlantic, rte_atl_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(net_atlantic, pci_id_atl_map);
 RTE_PMD_REGISTER_KMOD_DEP(net_atlantic, "* igb_uio | uio_pci_generic

[dpdk-dev] [PATCH v2 12/21] net/atlantic: flow control configuration

[Igor Russkikh]

From: Pavel Belous 

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.c | 50 +++
 1 file changed, 50 insertions(+)

diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index b58f684f6..72acb053d 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -66,6 +66,11 @@ static void atl_dev_info_get(struct rte_eth_dev *dev,
 
 static const uint32_t *atl_dev_supported_ptypes_get(struct rte_eth_dev *dev);
 
+/* Flow control */
+static int atl_flow_ctrl_get(struct rte_eth_dev *dev,
+  struct rte_eth_fc_conf *fc_conf);
+static int atl_flow_ctrl_set(struct rte_eth_dev *dev,
+  struct rte_eth_fc_conf *fc_conf);
 /* Interrupts */
 static int atl_dev_rxq_interrupt_setup(struct rte_eth_dev *dev);
 static int atl_dev_lsc_interrupt_setup(struct rte_eth_dev *dev, uint8_t on);
@@ -157,6 +162,10 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
/* Link */
.link_update  = atl_dev_link_update,
 
+
+   /* Flow Control */
+   .flow_ctrl_get= atl_flow_ctrl_get,
+   .flow_ctrl_set= atl_flow_ctrl_set,
.reta_update  = atl_reta_update,
.reta_query   = atl_reta_query,
.rss_hash_update  = atl_rss_hash_update,
@@ -821,6 +830,47 @@ atl_dev_interrupt_handler(void *param)
atl_dev_interrupt_action(dev, dev->intr_handle);
 }
 
+static int
+atl_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   if (hw->aq_nic_cfg->flow_control == AQ_NIC_FC_OFF)
+   fc_conf->mode = RTE_FC_NONE;
+   else if (hw->aq_nic_cfg->flow_control & (AQ_NIC_FC_RX | AQ_NIC_FC_TX))
+   fc_conf->mode = RTE_FC_FULL;
+   else if (hw->aq_nic_cfg->flow_control & AQ_NIC_FC_RX)
+   fc_conf->mode = RTE_FC_RX_PAUSE;
+   else if (hw->aq_nic_cfg->flow_control & AQ_NIC_FC_RX)
+   fc_conf->mode = RTE_FC_TX_PAUSE;
+
+   return 0;
+}
+
+static int
+atl_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   uint32_t old_flow_control = hw->aq_nic_cfg->flow_control;
+
+
+   if (hw->aq_fw_ops->set_flow_control == NULL)
+   return -ENOTSUP;
+
+   if (fc_conf->mode == RTE_FC_NONE)
+   hw->aq_nic_cfg->flow_control = AQ_NIC_FC_OFF;
+   else if (fc_conf->mode == RTE_FC_RX_PAUSE)
+   hw->aq_nic_cfg->flow_control = AQ_NIC_FC_RX;
+   else if (fc_conf->mode == RTE_FC_TX_PAUSE)
+   hw->aq_nic_cfg->flow_control = AQ_NIC_FC_TX;
+   else if (fc_conf->mode == RTE_FC_FULL)
+   hw->aq_nic_cfg->flow_control = (AQ_NIC_FC_RX | AQ_NIC_FC_TX);
+
+   if (old_flow_control != hw->aq_nic_cfg->flow_control)
+   return hw->aq_fw_ops->set_flow_control(hw);
+
+   return 0;
+}
 
 static int
 atl_reta_update(struct rte_eth_dev *dev,
-- 
2.13.3.windows.1

[dpdk-dev] [PATCH v2 09/21] net/atlantic: link status and interrupt management

[Igor Russkikh]

From: Pavel Belous 

Implement link interrupt, link info, link polling

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.c | 258 ++
 drivers/net/atlantic/atl_ethdev.h |  10 ++
 2 files changed, 268 insertions(+)

diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index 5de295f6f..71f4e8e0a 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -49,8 +49,11 @@ static int eth_atl_dev_uninit(struct rte_eth_dev *eth_dev);
 static int  atl_dev_configure(struct rte_eth_dev *dev);
 static int  atl_dev_start(struct rte_eth_dev *dev);
 static void atl_dev_stop(struct rte_eth_dev *dev);
+static int  atl_dev_set_link_up(struct rte_eth_dev *dev);
+static int  atl_dev_set_link_down(struct rte_eth_dev *dev);
 static void atl_dev_close(struct rte_eth_dev *dev);
 static int  atl_dev_reset(struct rte_eth_dev *dev);
+static int  atl_dev_link_update(struct rte_eth_dev *dev, int wait);
 
 static int atl_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev,
 uint16_t queue_id,
@@ -63,6 +66,15 @@ static void atl_dev_info_get(struct rte_eth_dev *dev,
 
 static const uint32_t *atl_dev_supported_ptypes_get(struct rte_eth_dev *dev);
 
+/* Interrupts */
+static int atl_dev_rxq_interrupt_setup(struct rte_eth_dev *dev);
+static int atl_dev_lsc_interrupt_setup(struct rte_eth_dev *dev, uint8_t on);
+static int atl_dev_interrupt_get_status(struct rte_eth_dev *dev);
+static int atl_dev_interrupt_action(struct rte_eth_dev *dev,
+   struct rte_intr_handle *handle);
+static void atl_dev_interrupt_handler(void *param);
+
+
 static int eth_atl_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
struct rte_pci_device *pci_dev);
 static int eth_atl_pci_remove(struct rte_pci_device *pci_dev);
@@ -125,10 +137,66 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
.dev_configure= atl_dev_configure,
.dev_start= atl_dev_start,
.dev_stop = atl_dev_stop,
+   .dev_set_link_up  = atl_dev_set_link_up,
+   .dev_set_link_down= atl_dev_set_link_down,
.dev_close= atl_dev_close,
.dev_reset= atl_dev_reset,
+   /* Link */
+   .link_update  = atl_dev_link_update,
 };
 
+/**
+ * Atomically reads the link status information from global
+ * structure rte_eth_dev.
+ *
+ * @param dev
+ *   - Pointer to the structure rte_eth_dev to read from.
+ *   - Pointer to the buffer to be saved with the link status.
+ *
+ * @return
+ *   - On success, zero.
+ *   - On failure, negative value.
+ */
+static inline int
+rte_atl_dev_atomic_read_link_status(struct rte_eth_dev *dev,
+   struct rte_eth_link *link)
+{
+   struct rte_eth_link *dst = link;
+   struct rte_eth_link *src = &dev->data->dev_link;
+
+   if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
+   *(uint64_t *)src) == 0)
+   return -1;
+
+   return 0;
+}
+
+/**
+ * Atomically writes the link status information into global
+ * structure rte_eth_dev.
+ *
+ * @param dev
+ *   - Pointer to the structure rte_eth_dev to read from.
+ *   - Pointer to the buffer to be saved with the link status.
+ *
+ * @return
+ *   - On success, zero.
+ *   - On failure, negative value.
+ */
+static inline int
+rte_atl_dev_atomic_write_link_status(struct rte_eth_dev *dev,
+   struct rte_eth_link *link)
+{
+   struct rte_eth_link *dst = &dev->data->dev_link;
+   struct rte_eth_link *src = link;
+
+   if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
+   *(uint64_t *)src) == 0)
+   return -1;
+
+   return 0;
+}
+
 static inline int32_t
 atl_reset_hw(struct aq_hw_s *hw)
 {
@@ -385,6 +453,37 @@ atl_dev_start(struct rte_eth_dev *dev)
}
}
 
+
+   err = hw->aq_fw_ops->update_link_status(hw);
+
+   if (err)
+   goto error;
+
+   dev->data->dev_link.link_status = hw->aq_link_status.mbps != 0;
+
+   link_speeds = &dev->data->dev_conf.link_speeds;
+
+   speed = 0x0;
+
+   if (*link_speeds == ETH_LINK_SPEED_AUTONEG) {
+   speed = hw->aq_nic_cfg->link_speed_msk;
+   } else {
+   if (*link_speeds & ETH_LINK_SPEED_10G)
+   speed |= AQ_NIC_RATE_10G;
+   if (*link_speeds & ETH_LINK_SPEED_5G)
+   speed |= AQ_NIC_RATE_5G;
+   if (*link_speeds & ETH_LINK_SPEED_1G)
+   speed |= AQ_NIC_RATE_1G;
+   if (*link_speeds & ETH_LINK_SPEED_2_5G)
+   speed |=  AQ_NIC_RATE_2G5;
+   if (*link_speeds & ETH_LINK_SPEED_100M)
+   speed |= AQ_NIC_RATE_100M;
+   }
+
+   err = hw->aq_fw_ops->set_link_speed(h

[dpdk-dev] [PATCH v2 13/21] net/atlantic: MAC address manipulations

[Igor Russkikh]

From: Pavel Belous 

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.c | 108 ++
 1 file changed, 108 insertions(+)

diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index 72acb053d..940fd83d9 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -80,6 +80,19 @@ static int atl_dev_interrupt_action(struct rte_eth_dev *dev,
 static void atl_dev_interrupt_handler(void *param);
 
 
+static int atl_add_mac_addr(struct rte_eth_dev *dev,
+   struct ether_addr *mac_addr,
+   uint32_t index, uint32_t pool);
+static void atl_remove_mac_addr(struct rte_eth_dev *dev, uint32_t index);
+static int atl_set_default_mac_addr(struct rte_eth_dev *dev,
+  struct ether_addr *mac_addr);
+static bool is_device_supported(struct rte_eth_dev *dev,
+   struct rte_pci_driver *drv);
+
+static int atl_dev_set_mc_addr_list(struct rte_eth_dev *dev,
+   struct ether_addr *mc_addr_set,
+   uint32_t nb_mc_addr);
+
 /* RSS */
 static int atl_reta_update(struct rte_eth_dev *dev,
 struct rte_eth_rss_reta_entry64 *reta_conf,
@@ -166,6 +179,12 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
/* Flow Control */
.flow_ctrl_get= atl_flow_ctrl_get,
.flow_ctrl_set= atl_flow_ctrl_set,
+
+   /* MAC */
+   .mac_addr_add = atl_add_mac_addr,
+   .mac_addr_remove  = atl_remove_mac_addr,
+   .mac_addr_set = atl_set_default_mac_addr,
+   .set_mc_addr_list = atl_dev_set_mc_addr_list,
.reta_update  = atl_reta_update,
.reta_query   = atl_reta_query,
.rss_hash_update  = atl_rss_hash_update,
@@ -873,6 +892,95 @@ atl_flow_ctrl_set(struct rte_eth_dev *dev, struct 
rte_eth_fc_conf *fc_conf)
 }
 
 static int
+atl_update_mac_addr(struct rte_eth_dev *dev, uint32_t index,
+   u8 *mac_addr, bool enable)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   unsigned int h = 0U;
+   unsigned int l = 0U;
+   int err;
+
+   if (mac_addr) {
+   h = (mac_addr[0] << 8) | (mac_addr[1]);
+   l = (mac_addr[2] << 24) | (mac_addr[3] << 16) |
+   (mac_addr[4] << 8) | mac_addr[5];
+   }
+
+   hw_atl_rpfl2_uc_flr_en_set(hw, 0U, index);
+   hw_atl_rpfl2unicast_dest_addresslsw_set(hw, l, index);
+   hw_atl_rpfl2unicast_dest_addressmsw_set(hw, h, index);
+
+   if (enable)
+   hw_atl_rpfl2_uc_flr_en_set(hw, 1U, index);
+
+   err = aq_hw_err_from_flags(hw);
+
+   return err;
+}
+
+static int
+atl_add_mac_addr(struct rte_eth_dev *dev, struct ether_addr *mac_addr,
+   uint32_t index __rte_unused, uint32_t pool __rte_unused)
+{
+   if (is_zero_ether_addr(mac_addr)) {
+   PMD_DRV_LOG(ERR, "Invalid Ethernet Address");
+   return -EINVAL;
+   }
+
+   return atl_update_mac_addr(dev, index, (u8 *)mac_addr, TRUE);
+}
+
+static void
+atl_remove_mac_addr(struct rte_eth_dev *dev, uint32_t index)
+{
+   atl_update_mac_addr(dev, index, NULL, FALSE);
+}
+
+static int
+atl_set_default_mac_addr(struct rte_eth_dev *dev, struct ether_addr *addr)
+{
+   atl_remove_mac_addr(dev, 0);
+   atl_add_mac_addr(dev, addr, 0, 0);
+   return 0;
+}
+
+
+static int
+atl_dev_set_mc_addr_list(struct rte_eth_dev *dev,
+ struct ether_addr *mc_addr_set,
+ uint32_t nb_mc_addr)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   u32 i;
+
+   if (nb_mc_addr > AQ_HW_MULTICAST_ADDRESS_MAX - HW_ATL_B0_MAC_MIN)
+   return -EINVAL;
+
+   /* Update whole uc filters table */
+   for (i = 0; i < AQ_HW_MULTICAST_ADDRESS_MAX - HW_ATL_B0_MAC_MIN; i++) {
+   u8 *mac_addr = NULL;
+   u32 l = 0, h = 0;
+
+   if (i < nb_mc_addr) {
+   mac_addr = mc_addr_set[i].addr_bytes;
+   l = (mac_addr[2] << 24) | (mac_addr[3] << 16) |
+   (mac_addr[4] << 8) | mac_addr[5];
+   h = (mac_addr[0] << 8) | mac_addr[1];
+   }
+
+   hw_atl_rpfl2_uc_flr_en_set(hw, 0U, HW_ATL_B0_MAC_MIN + i);
+   hw_atl_rpfl2unicast_dest_addresslsw_set(hw, l,
+   HW_ATL_B0_MAC_MIN + i);
+   hw_atl_rpfl2unicast_dest_addressmsw_set(hw, h,
+   HW_ATL_B0_MAC_MIN + i);
+   hw_atl_rpfl2_uc_flr_en_set(hw, !!mac_addr,
+  HW_ATL_B0_MAC_MIN + i);
+   }
+
+   return 0;
+}
+
+static int
 at

[dpdk-dev] [PATCH v2 14/21] net/atlantic: eeprom and register manipulation routines

[Igor Russkikh]

From: Pavel Belous 

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.c | 79 +++
 1 file changed, 79 insertions(+)

diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index 940fd83d9..c16d179fd 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -66,6 +66,17 @@ static void atl_dev_info_get(struct rte_eth_dev *dev,
 
 static const uint32_t *atl_dev_supported_ptypes_get(struct rte_eth_dev *dev);
 
+/* EEPROM */
+static int atl_dev_get_eeprom_length(struct rte_eth_dev *dev);
+static int atl_dev_get_eeprom(struct rte_eth_dev *dev,
+ struct rte_dev_eeprom_info *eeprom);
+static int atl_dev_set_eeprom(struct rte_eth_dev *dev,
+ struct rte_dev_eeprom_info *eeprom);
+
+/* Regs */
+static int atl_dev_get_regs(struct rte_eth_dev *dev,
+   struct rte_dev_reg_info *regs);
+
 /* Flow control */
 static int atl_flow_ctrl_get(struct rte_eth_dev *dev,
   struct rte_eth_fc_conf *fc_conf);
@@ -175,6 +186,12 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
/* Link */
.link_update  = atl_dev_link_update,
 
+   .get_reg  = atl_dev_get_regs,
+
+   /* EEPROM */
+   .get_eeprom_length= atl_dev_get_eeprom_length,
+   .get_eeprom   = atl_dev_get_eeprom,
+   .set_eeprom   = atl_dev_set_eeprom,
 
/* Flow Control */
.flow_ctrl_get= atl_flow_ctrl_get,
@@ -849,6 +866,68 @@ atl_dev_interrupt_handler(void *param)
atl_dev_interrupt_action(dev, dev->intr_handle);
 }
 
+#define SFP_EEPROM_SIZE 0xff
+
+static int
+atl_dev_get_eeprom_length(struct rte_eth_dev *dev __rte_unused)
+{
+   return SFP_EEPROM_SIZE;
+}
+
+static int
+atl_dev_get_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   if (hw->aq_fw_ops->get_eeprom == NULL)
+   return -ENOTSUP;
+
+   if (eeprom->length != SFP_EEPROM_SIZE || eeprom->data == NULL)
+   return -EINVAL;
+
+   return hw->aq_fw_ops->get_eeprom(hw, eeprom->data, eeprom->length);
+}
+
+static int
+atl_dev_set_eeprom(struct rte_eth_dev *dev, struct rte_dev_eeprom_info *eeprom)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   if (hw->aq_fw_ops->set_eeprom == NULL)
+   return -ENOTSUP;
+
+   if (eeprom->length != SFP_EEPROM_SIZE || eeprom->data == NULL)
+   return -EINVAL;
+
+   return hw->aq_fw_ops->set_eeprom(hw, eeprom->data, eeprom->length);
+}
+
+static int
+atl_dev_get_regs(struct rte_eth_dev *dev, struct rte_dev_reg_info *regs)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   u32 mif_id;
+   int err;
+
+   if (regs->data == NULL) {
+   regs->length = hw_atl_utils_hw_get_reg_length();
+   regs->width = sizeof(u32);
+   return 0;
+   }
+
+   /* Only full register dump is supported */
+   if (regs->length && regs->length != hw_atl_utils_hw_get_reg_length())
+   return -ENOTSUP;
+
+   err = hw_atl_utils_hw_get_regs(hw, regs->data);
+
+   /* Device version */
+   mif_id = hw_atl_reg_glb_mif_id_get(hw);
+   regs->version = mif_id & 0xFFU;
+
+   return err;
+}
+
 static int
 atl_flow_ctrl_get(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
 {
-- 
2.13.3.windows.1

[dpdk-dev] [PATCH v2 16/21] net/atlantic: promisc and allmulti configuration

[Igor Russkikh]

From: Pavel Belous 

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.c | 46 +++
 1 file changed, 46 insertions(+)

diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index 08f1a07c8..44bdbcbb3 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -53,6 +53,10 @@ static int  atl_dev_set_link_up(struct rte_eth_dev *dev);
 static int  atl_dev_set_link_down(struct rte_eth_dev *dev);
 static void atl_dev_close(struct rte_eth_dev *dev);
 static int  atl_dev_reset(struct rte_eth_dev *dev);
+static void atl_dev_promiscuous_enable(struct rte_eth_dev *dev);
+static void atl_dev_promiscuous_disable(struct rte_eth_dev *dev);
+static void atl_dev_allmulticast_enable(struct rte_eth_dev *dev);
+static void atl_dev_allmulticast_disable(struct rte_eth_dev *dev);
 static int  atl_dev_link_update(struct rte_eth_dev *dev, int wait);
 
 static int atl_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev,
@@ -188,6 +192,13 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
.dev_set_link_down= atl_dev_set_link_down,
.dev_close= atl_dev_close,
.dev_reset= atl_dev_reset,
+
+   /* PROMISC */
+   .promiscuous_enable   = atl_dev_promiscuous_enable,
+   .promiscuous_disable  = atl_dev_promiscuous_disable,
+   .allmulticast_enable  = atl_dev_allmulticast_enable,
+   .allmulticast_disable = atl_dev_allmulticast_disable,
+
/* Link */
.link_update  = atl_dev_link_update,
 
@@ -735,6 +746,41 @@ atl_dev_link_update(struct rte_eth_dev *dev, int wait 
__rte_unused)
return 0;
 }
 
+static void
+atl_dev_promiscuous_enable(struct rte_eth_dev *dev)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   hw_atl_rpfl2promiscuous_mode_en_set(hw, true);
+}
+
+static void
+atl_dev_promiscuous_disable(struct rte_eth_dev *dev)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   hw_atl_rpfl2promiscuous_mode_en_set(hw, false);
+}
+
+static void
+atl_dev_allmulticast_enable(struct rte_eth_dev *dev)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   hw_atl_rpfl2_accept_all_mc_packets_set(hw, true);
+}
+
+static void
+atl_dev_allmulticast_disable(struct rte_eth_dev *dev)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   if (dev->data->promiscuous == 1)
+   return; /* must remain in all_multicast mode */
+
+   hw_atl_rpfl2_accept_all_mc_packets_set(hw, false);
+}
+
 /**
  * It clears the interrupt causes and enables the interrupt.
  * It will be called once only during nic initialized.
-- 
2.13.3.windows.1

[dpdk-dev] [PATCH v2 15/21] net/atlantic: LED control DPDK and private APIs

[Igor Russkikh]

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/Makefile   |  4 +++
 drivers/net/atlantic/atl_ethdev.c   | 55 +
 drivers/net/atlantic/atl_ethdev.h   |  2 ++
 drivers/net/atlantic/meson.build|  3 ++
 drivers/net/atlantic/rte_pmd_atlantic.c | 19 
 drivers/net/atlantic/rte_pmd_atlantic.h | 44 ++
 6 files changed, 127 insertions(+)
 create mode 100644 drivers/net/atlantic/rte_pmd_atlantic.c
 create mode 100644 drivers/net/atlantic/rte_pmd_atlantic.h

diff --git a/drivers/net/atlantic/Makefile b/drivers/net/atlantic/Makefile
index 9e3c17ac9..8af64d082 100644
--- a/drivers/net/atlantic/Makefile
+++ b/drivers/net/atlantic/Makefile
@@ -32,5 +32,9 @@ VPATH += $(SRCDIR)/hw_atl
 # all source are stored in SRCS-y
 #
 SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += atl_ethdev.c
+SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += rte_pmd_atlantic.c
+
+# install this header file
+SYMLINK-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD)-include := rte_pmd_atlantic.h
 
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index c16d179fd..08f1a07c8 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -66,6 +66,11 @@ static void atl_dev_info_get(struct rte_eth_dev *dev,
 
 static const uint32_t *atl_dev_supported_ptypes_get(struct rte_eth_dev *dev);
 
+
+/* LEDs */
+static int atl_dev_led_on(struct rte_eth_dev *dev);
+static int atl_dev_led_off(struct rte_eth_dev *dev);
+
 /* EEPROM */
 static int atl_dev_get_eeprom_length(struct rte_eth_dev *dev);
 static int atl_dev_get_eeprom(struct rte_eth_dev *dev,
@@ -188,6 +193,11 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
 
.get_reg  = atl_dev_get_regs,
 
+
+   /* LEDs */
+   .dev_led_on   = atl_dev_led_on,
+   .dev_led_off  = atl_dev_led_off,
+
/* EEPROM */
.get_eeprom_length= atl_dev_get_eeprom_length,
.get_eeprom   = atl_dev_get_eeprom,
@@ -866,6 +876,51 @@ atl_dev_interrupt_handler(void *param)
atl_dev_interrupt_action(dev, dev->intr_handle);
 }
 
+/**
+ * LED ON Enables software controllable LED blinking.
+ * LED status then is independent of link status or traffic
+ */
+static int
+atl_dev_led_on(struct rte_eth_dev *dev)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   if (hw->aq_fw_ops->led_control == NULL)
+   return -ENOTSUP;
+
+   return hw->aq_fw_ops->led_control(hw,
+   AQ_HW_LED_BLINK |
+   (AQ_HW_LED_BLINK << 2) |
+   (AQ_HW_LED_BLINK << 4));
+}
+
+/**
+ * LED OFF disables software controllable LED blinking
+ * LED is controlled by default logic and depends on link status and
+ * traffic activity
+ */
+static int
+atl_dev_led_off(struct rte_eth_dev *dev)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   if (hw->aq_fw_ops->led_control == NULL)
+   return -ENOTSUP;
+
+   return hw->aq_fw_ops->led_control(hw, AQ_HW_LED_DEFAULT);
+}
+
+int
+atl_dev_led_control(struct rte_eth_dev *dev, int control)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   if (hw->aq_fw_ops->led_control == NULL)
+   return -ENOTSUP;
+
+   return hw->aq_fw_ops->led_control(hw, control);
+}
+
 #define SFP_EEPROM_SIZE 0xff
 
 static int
diff --git a/drivers/net/atlantic/atl_ethdev.h 
b/drivers/net/atlantic/atl_ethdev.h
index ce4bc9544..3ebef1f43 100644
--- a/drivers/net/atlantic/atl_ethdev.h
+++ b/drivers/net/atlantic/atl_ethdev.h
@@ -46,4 +46,6 @@ struct atl_adapter {
 #define ATL_DEV_PRIVATE_TO_CFG(adapter) \
(&((struct atl_adapter *)adapter)->hw_cfg)
 
+int
+atl_dev_led_control(struct rte_eth_dev *dev, int control);
 #endif /* _ATLANTIC_ETHDEV_H_ */
diff --git a/drivers/net/atlantic/meson.build b/drivers/net/atlantic/meson.build
index 187ca9808..19fa41cd3 100644
--- a/drivers/net/atlantic/meson.build
+++ b/drivers/net/atlantic/meson.build
@@ -5,6 +5,7 @@
 
 sources = files(
'atl_ethdev.c',
+   'rte_pmd_atlantic.c',
 )
 
 deps += ['hash', 'eal']
@@ -17,3 +18,5 @@ if get_option('buildtype') == 'debug'
 endif
 
 allow_experimental_apis = true
+
+install_headers('rte_pmd_atlantic.h')
diff --git a/drivers/net/atlantic/rte_pmd_atlantic.c 
b/drivers/net/atlantic/rte_pmd_atlantic.c
new file mode 100644
index 0..4cb09baf2
--- /dev/null
+++ b/drivers/net/atlantic/rte_pmd_atlantic.c
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Aquantia Corporation
+ */
+
+#include 
+
+#include "rte_pmd_atlantic.h"
+#include "atl_ethdev.h"
+
+int rte_pmd_atl_dev_led_control(int port, int control)
+{
+   struct rte_eth_dev *dev;
+
+   RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
+
+   dev = &rte_eth_devices[port];
+
+   return atl_d

[dpdk-dev] [PATCH v2 17/21] net/atlantic: device statistics, xstats

[Igor Russkikh]

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.c | 136 ++
 1 file changed, 136 insertions(+)

diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index 44bdbcbb3..37f32c421 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -59,6 +59,19 @@ static void atl_dev_allmulticast_enable(struct rte_eth_dev 
*dev);
 static void atl_dev_allmulticast_disable(struct rte_eth_dev *dev);
 static int  atl_dev_link_update(struct rte_eth_dev *dev, int wait);
 
+static int atl_dev_xstats_get_names(struct rte_eth_dev *dev __rte_unused,
+   struct rte_eth_xstat_name *xstats_names,
+   unsigned int size);
+
+static int atl_dev_stats_get(struct rte_eth_dev *dev,
+   struct rte_eth_stats *stats);
+
+static int atl_dev_xstats_get(struct rte_eth_dev *dev,
+ struct rte_eth_xstat *stats, unsigned int n);
+
+static void atl_dev_stats_reset(struct rte_eth_dev *dev);
+static void atl_dev_xstats_reset(struct rte_eth_dev *dev);
+
 static int atl_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev,
 uint16_t queue_id,
 uint8_t stat_idx,
@@ -184,6 +197,34 @@ static const struct rte_eth_desc_lim tx_desc_lim = {
.nb_mtu_seg_max = ATL_TX_MAX_SEG,
 };
 
+#define ATL_XSTATS_FIELD(name) { \
+   #name, \
+   offsetof(struct aq_stats_s, name) \
+}
+
+struct atl_xstats_tbl_s {
+   const char *name;
+   unsigned int offset;
+};
+
+static struct atl_xstats_tbl_s atl_xstats_tbl[] = {
+   ATL_XSTATS_FIELD(uprc),
+   ATL_XSTATS_FIELD(mprc),
+   ATL_XSTATS_FIELD(bprc),
+   ATL_XSTATS_FIELD(erpt),
+   ATL_XSTATS_FIELD(uptc),
+   ATL_XSTATS_FIELD(mptc),
+   ATL_XSTATS_FIELD(bptc),
+   ATL_XSTATS_FIELD(erpr),
+   ATL_XSTATS_FIELD(ubrc),
+   ATL_XSTATS_FIELD(ubtc),
+   ATL_XSTATS_FIELD(mbrc),
+   ATL_XSTATS_FIELD(mbtc),
+   ATL_XSTATS_FIELD(bbrc),
+   ATL_XSTATS_FIELD(bbtc),
+};
+
+
 static const struct eth_dev_ops atl_eth_dev_ops = {
.dev_configure= atl_dev_configure,
.dev_start= atl_dev_start,
@@ -204,6 +245,12 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
 
.get_reg  = atl_dev_get_regs,
 
+   /* Stats */
+   .stats_get= atl_dev_stats_get,
+   .xstats_get   = atl_dev_xstats_get,
+   .xstats_get_names = atl_dev_xstats_get_names,
+   .stats_reset  = atl_dev_stats_reset,
+   .xstats_reset = atl_dev_xstats_reset,
 
/* LEDs */
.dev_led_on   = atl_dev_led_on,
@@ -390,6 +437,9 @@ eth_atl_dev_init(struct rte_eth_dev *eth_dev)
(u8 *)ð_dev->data->mac_addrs[0]) != 0)
return -EINVAL;
 
+   /* Reset the hw statistics */
+   atl_dev_stats_reset(eth_dev);
+
rte_intr_callback_register(intr_handle,
   atl_dev_interrupt_handler, eth_dev);
 
@@ -699,6 +749,92 @@ atl_dev_reset(struct rte_eth_dev *dev)
 }
 
 
+static int
+atl_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
+{
+   struct atl_adapter *adapter =
+   (struct atl_adapter *)dev->data->dev_private;
+   struct aq_hw_s *hw = &adapter->hw;
+   struct atl_sw_stats *swstats = &adapter->sw_stats;
+   unsigned int i;
+
+   hw->aq_fw_ops->update_stats(hw);
+
+   /* Fill out the rte_eth_stats statistics structure */
+   stats->ipackets = hw->curr_stats.dma_pkt_rc;
+   stats->ibytes = hw->curr_stats.dma_oct_rc;
+   stats->imissed = hw->curr_stats.dpc;
+   stats->ierrors = hw->curr_stats.erpt;
+
+   stats->opackets = hw->curr_stats.dma_pkt_tc;
+   stats->obytes = hw->curr_stats.dma_oct_tc;
+   stats->oerrors = 0;
+
+   stats->rx_nombuf = swstats->rx_nombuf;
+
+   for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS; i++) {
+   stats->q_ipackets[i] = swstats->q_ipackets[i];
+   stats->q_opackets[i] = swstats->q_opackets[i];
+   stats->q_ibytes[i] = swstats->q_ibytes[i];
+   stats->q_obytes[i] = swstats->q_obytes[i];
+   stats->q_errors[i] = swstats->q_errors[i];
+   }
+   return 0;
+}
+
+static void
+atl_dev_stats_reset(struct rte_eth_dev *dev)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+
+   hw->aq_fw_ops->update_stats(hw);
+
+   /* Reset software totals */
+   memset(&hw->curr_stats, 0, sizeof(hw->curr_stats));
+}
+
+static int
+atl_dev_xstats_get_names(struct rte_eth_dev *dev __rte_unused,
+struct rte_eth_xstat_name *xstats_names,
+unsigned int size)
+{
+   unsigned int i;
+
+   if (!xstats_names)
+   return RTE_DIM(at

[dpdk-dev] [PATCH v2 20/21] net/atlantic: RX side structures and implementation

[Igor Russkikh]

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/Makefile |   6 +
 drivers/net/atlantic/atl_ethdev.c |  44 +++
 drivers/net/atlantic/atl_ethdev.h |  82 
 drivers/net/atlantic/atl_rxtx.c   | 787 ++
 drivers/net/atlantic/meson.build  |   6 +
 5 files changed, 925 insertions(+)
 create mode 100644 drivers/net/atlantic/atl_rxtx.c

diff --git a/drivers/net/atlantic/Makefile b/drivers/net/atlantic/Makefile
index 8af64d082..b84c8a988 100644
--- a/drivers/net/atlantic/Makefile
+++ b/drivers/net/atlantic/Makefile
@@ -31,7 +31,13 @@ VPATH += $(SRCDIR)/hw_atl
 #
 # all source are stored in SRCS-y
 #
+SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += atl_rxtx.c
 SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += atl_ethdev.c
+SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += atl_hw_regs.c
+SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += hw_atl_utils.c
+SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += hw_atl_llh.c
+SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += hw_atl_utils_fw2x.c
+SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += hw_atl_b0.c
 SRCS-$(CONFIG_RTE_LIBRTE_ATLANTIC_PMD) += rte_pmd_atlantic.c
 
 # install this header file
diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index 01700b4ad..8f81761f3 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -284,6 +284,8 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
.xstats_get_names = atl_dev_xstats_get_names,
.stats_reset  = atl_dev_stats_reset,
.xstats_reset = atl_dev_xstats_reset,
+   .queue_stats_mapping_set = atl_dev_queue_stats_mapping_set,
+
.fw_version_get   = atl_fw_version_get,
.dev_infos_get= atl_dev_info_get,
.dev_supported_ptypes_get = atl_dev_supported_ptypes_get,
@@ -296,6 +298,20 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
.vlan_tpid_set= atl_vlan_tpid_set,
.vlan_strip_queue_set = atl_vlan_strip_queue_set,
 
+   /* Queue Control */
+   .rx_queue_start   = atl_rx_queue_start,
+   .rx_queue_stop= atl_rx_queue_stop,
+   .rx_queue_setup   = atl_rx_queue_setup,
+   .rx_queue_release = atl_rx_queue_release,
+
+   .rx_queue_intr_enable = atl_dev_rx_queue_intr_enable,
+   .rx_queue_intr_disable = atl_dev_rx_queue_intr_disable,
+
+   .rx_queue_count   = atl_rx_queue_count,
+   .rx_descriptor_done   = atl_dev_rx_descriptor_done,
+   .rx_descriptor_status = atl_dev_rx_descriptor_status,
+   .tx_descriptor_status = atl_dev_tx_descriptor_status,
+
/* LEDs */
.dev_led_on   = atl_dev_led_on,
.dev_led_off  = atl_dev_led_off,
@@ -314,6 +330,7 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
.mac_addr_remove  = atl_remove_mac_addr,
.mac_addr_set = atl_set_default_mac_addr,
.set_mc_addr_list = atl_dev_set_mc_addr_list,
+   .rxq_info_get = atl_rxq_info_get,
.reta_update  = atl_reta_update,
.reta_query   = atl_reta_query,
.rss_hash_update  = atl_rss_hash_update,
@@ -631,6 +648,19 @@ atl_dev_start(struct rte_eth_dev *dev)
}
}
 
+   /* This can fail when allocating mbufs for descriptor rings */
+   err = atl_rx_init(dev);
+   if (err) {
+   PMD_INIT_LOG(ERR, "Unable to initialize RX hardware");
+   goto error;
+   }
+
+   err = atl_start_queues(dev);
+   if (err < 0) {
+   PMD_INIT_LOG(ERR, "Unable to start rxtx queues");
+   goto error;
+   }
+
err = hw->aq_fw_ops->update_link_status(hw);
 
if (err)
@@ -716,6 +746,9 @@ atl_dev_stop(struct rte_eth_dev *dev)
/* reset the NIC */
atl_reset_hw(hw);
hw->adapter_stopped = 0;
+
+   atl_stop_queues(dev);
+
/* Clear stored conf */
dev->data->scattered_rx = 0;
dev->data->lro = 0;
@@ -775,6 +808,8 @@ atl_dev_close(struct rte_eth_dev *dev)
 
atl_dev_stop(dev);
hw->adapter_stopped = 1;
+
+   atl_free_queues(dev);
 }
 
 static int
@@ -879,6 +914,15 @@ atl_dev_xstats_reset(struct rte_eth_dev *dev __rte_unused)
 {
 }
 
+static int
+atl_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev __rte_unused,
+uint16_t queue_id __rte_unused,
+uint8_t stat_idx __rte_unused,
+uint8_t is_rx __rte_unused)
+{
+   /* The mapping is hardcoded: queue 0 -> stat 0, etc */
+   return 0;
+}
 
 static int
 atl_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)
diff --git a/drivers/net/atlantic/atl_ethdev.h 
b/drivers/net/atlantic/atl_ethdev.h
index 3ebef1f43..614757b7a 100644
--- a/drivers/net/atlantic/atl_ethdev.h
+++ b/drivers/net/atlantic/atl_ethdev.h
@@ -13,6 +13,17 @@
 #include "atl_types.h"
 #include "hw

[dpdk-dev] [PATCH v2 21/21] net/atlantic: TX side structures and implementation

[Igor Russkikh]

From: Pavel Belous 

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.c |  10 +
 drivers/net/atlantic/atl_rxtx.c   | 578 ++
 2 files changed, 588 insertions(+)

diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index 8f81761f3..1a5ec8907 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -304,6 +304,11 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
.rx_queue_setup   = atl_rx_queue_setup,
.rx_queue_release = atl_rx_queue_release,
 
+   .tx_queue_start   = atl_tx_queue_start,
+   .tx_queue_stop= atl_tx_queue_stop,
+   .tx_queue_setup   = atl_tx_queue_setup,
+   .tx_queue_release = atl_tx_queue_release,
+
.rx_queue_intr_enable = atl_dev_rx_queue_intr_enable,
.rx_queue_intr_disable = atl_dev_rx_queue_intr_disable,
 
@@ -331,6 +336,8 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
.mac_addr_set = atl_set_default_mac_addr,
.set_mc_addr_list = atl_dev_set_mc_addr_list,
.rxq_info_get = atl_rxq_info_get,
+   .txq_info_get = atl_txq_info_get,
+
.reta_update  = atl_reta_update,
.reta_query   = atl_reta_query,
.rss_hash_update  = atl_rss_hash_update,
@@ -648,6 +655,9 @@ atl_dev_start(struct rte_eth_dev *dev)
}
}
 
+   /* initialize transmission unit */
+   atl_tx_init(dev);
+
/* This can fail when allocating mbufs for descriptor rings */
err = atl_rx_init(dev);
if (err) {
diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c
index 77009e095..5b9e216cd 100644
--- a/drivers/net/atlantic/atl_rxtx.c
+++ b/drivers/net/atlantic/atl_rxtx.c
@@ -46,6 +46,20 @@
 #include "hw_atl/hw_atl_b0.h"
 #include "hw_atl/hw_atl_b0_internal.h"
 
+#define ATL_TX_CKSUM_OFFLOAD_MASK ( \
+   PKT_TX_IP_CKSUM |\
+   PKT_TX_L4_MASK | \
+   PKT_TX_TCP_SEG)
+
+#define ATL_TX_OFFLOAD_MASK (  \
+   PKT_TX_VLAN_PKT |\
+   PKT_TX_IP_CKSUM |\
+   PKT_TX_L4_MASK | \
+   PKT_TX_TCP_SEG)
+
+#define ATL_TX_OFFLOAD_NOTSUP_MASK \
+   (PKT_TX_OFFLOAD_MASK ^ ATL_TX_OFFLOAD_MASK)
+
 /**
  * Structure associated with each descriptor of the RX ring of a RX queue.
  */
@@ -54,6 +68,15 @@ struct atl_rx_entry {
 };
 
 /**
+ * Structure associated with each descriptor of the TX ring of a TX queue.
+ */
+struct atl_tx_entry {
+   struct rte_mbuf *mbuf;
+   uint16_t next_id;
+   uint16_t last_id;
+};
+
+/**
  * Structure associated with each RX queue.
  */
 struct atl_rx_queue {
@@ -72,6 +95,22 @@ struct atl_rx_queue {
booll4_csum_enabled;
 };
 
+/**
+ * Structure associated with each TX queue.
+ */
+struct atl_tx_queue {
+   struct hw_atl_txd_s *hw_ring;
+   uint64_thw_ring_phys_addr;
+   struct atl_tx_entry *sw_ring;
+   uint16_tnb_tx_desc;
+   uint16_ttx_tail;
+   uint16_ttx_head;
+   uint16_tqueue_id;
+   uint16_tport_id;
+   uint16_ttx_free_thresh;
+   uint16_ttx_free;
+};
+
 static inline void
 atl_reset_rx_queue(struct atl_rx_queue *rxq)
 {
@@ -174,6 +213,140 @@ atl_rx_queue_setup(struct rte_eth_dev *dev, uint16_t 
rx_queue_id,
return 0;
 }
 
+static inline void
+atl_reset_tx_queue(struct atl_tx_queue *txq)
+{
+   struct atl_tx_entry *tx_entry;
+   union hw_atl_txc_s *txc;
+   uint16_t i;
+
+   PMD_INIT_FUNC_TRACE();
+
+   if (!txq) {
+   PMD_DRV_LOG(ERR, "Pointer to txq is NULL");
+   return;
+   }
+
+   tx_entry = txq->sw_ring;
+
+   for (i = 0; i < txq->nb_tx_desc; i++) {
+   txc = (union hw_atl_txc_s *)&txq->hw_ring[i];
+   txc->flags1 = 0;
+   txc->flags2 = 2;
+   }
+
+   for (i = 0; i < txq->nb_tx_desc; i++) {
+   txq->hw_ring[i].dd = 1;
+   tx_entry[i].mbuf = NULL;
+   }
+
+   txq->tx_tail = 0;
+   txq->tx_head = 0;
+   txq->tx_free = txq->nb_tx_desc - 1;
+}
+
+int
+atl_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,
+  uint16_t nb_tx_desc, unsigned int socket_id,
+  const struct rte_eth_txconf *tx_conf)
+{
+   struct atl_tx_queue *txq;
+   const struct rte_memzone *mz;
+
+   PMD_INIT_FUNC_TRACE();
+
+   /* make sure a valid number of descriptors have been requested */
+   if (nb_tx_desc < AQ_HW_MIN_TX_RING_SIZE ||
+   nb_tx_desc > AQ_HW_MAX_TX_RING_SIZE) {
+   PMD_INIT_LOG(ERR, "Number of Tx descriptors 

[dpdk-dev] [PATCH v2 19/21] net/atlantic: device MTU and statuses

[Igor Russkikh]

From: Pavel Belous 

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.c | 162 ++
 1 file changed, 162 insertions(+)

diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index 7ff1126d7..01700b4ad 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -78,11 +78,15 @@ static int atl_dev_queue_stats_mapping_set(struct 
rte_eth_dev *eth_dev,
 uint8_t is_rx);
 
 
+static int atl_fw_version_get(struct rte_eth_dev *dev, char *fw_version,
+ size_t fw_size);
 static void atl_dev_info_get(struct rte_eth_dev *dev,
   struct rte_eth_dev_info *dev_info);
 
 static const uint32_t *atl_dev_supported_ptypes_get(struct rte_eth_dev *dev);
 
+static int atl_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
+
 
 /* VLAN stuff */
 static int atl_vlan_filter_set(struct rte_eth_dev *dev,
@@ -116,6 +120,9 @@ static int atl_flow_ctrl_get(struct rte_eth_dev *dev,
   struct rte_eth_fc_conf *fc_conf);
 static int atl_flow_ctrl_set(struct rte_eth_dev *dev,
   struct rte_eth_fc_conf *fc_conf);
+
+static void atl_dev_link_status_print(struct rte_eth_dev *dev);
+
 /* Interrupts */
 static int atl_dev_rxq_interrupt_setup(struct rte_eth_dev *dev);
 static int atl_dev_lsc_interrupt_setup(struct rte_eth_dev *dev, uint8_t on);
@@ -195,6 +202,20 @@ static struct rte_pci_driver rte_atl_pmd = {
.remove = eth_atl_pci_remove,
 };
 
+#define ATL_RX_OFFLOADS (DEV_RX_OFFLOAD_VLAN_STRIP \
+   | DEV_RX_OFFLOAD_IPV4_CKSUM \
+   | DEV_RX_OFFLOAD_UDP_CKSUM \
+   | DEV_RX_OFFLOAD_TCP_CKSUM \
+   | DEV_RX_OFFLOAD_JUMBO_FRAME \
+   | DEV_RX_OFFLOAD_CRC_STRIP)
+
+#define ATL_TX_OFFLOADS (DEV_TX_OFFLOAD_VLAN_INSERT \
+   | DEV_TX_OFFLOAD_IPV4_CKSUM \
+   | DEV_TX_OFFLOAD_UDP_CKSUM \
+   | DEV_TX_OFFLOAD_TCP_CKSUM \
+   | DEV_TX_OFFLOAD_TCP_TSO \
+   | DEV_TX_OFFLOAD_MULTI_SEGS)
+
 static const struct rte_eth_desc_lim rx_desc_lim = {
.nb_max = ATL_MAX_RING_DESC,
.nb_min = ATL_MIN_RING_DESC,
@@ -263,6 +284,12 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
.xstats_get_names = atl_dev_xstats_get_names,
.stats_reset  = atl_dev_stats_reset,
.xstats_reset = atl_dev_xstats_reset,
+   .fw_version_get   = atl_fw_version_get,
+   .dev_infos_get= atl_dev_info_get,
+   .dev_supported_ptypes_get = atl_dev_supported_ptypes_get,
+
+   .mtu_set  = atl_dev_mtu_set,
+
/* VLAN */
.vlan_filter_set  = atl_vlan_filter_set,
.vlan_offload_set = atl_vlan_offload_set,
@@ -664,6 +691,7 @@ atl_dev_start(struct rte_eth_dev *dev)
return 0;
 
 error:
+   PMD_INIT_LOG(ERR, "failure in atl_dev_start(): %d", err);
atl_stop_queues(dev);
return -EIO;
 }
@@ -850,6 +878,95 @@ static void
 atl_dev_xstats_reset(struct rte_eth_dev *dev __rte_unused)
 {
 }
+
+
+static int
+atl_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   uint32_t fw_ver = 0;
+   unsigned int ret = 0;
+
+   ret = hw_atl_utils_get_fw_version(hw, &fw_ver);
+   if (ret)
+   return 0;
+
+   ret = snprintf(fw_version, fw_size, "%u.%u.%u", fw_ver >> 24,
+  (fw_ver >> 16) & 0xFFU, fw_ver & 0xU);
+
+   ret += 1; /* add string null-terminator */
+
+   if (fw_size < ret)
+   return ret;
+
+   return 0;
+}
+
+static void
+atl_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
+{
+   struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
+
+   dev_info->max_rx_queues = AQ_HW_MAX_RX_QUEUES;
+   dev_info->max_tx_queues = AQ_HW_MAX_TX_QUEUES;
+
+   dev_info->min_rx_bufsize = 1024;
+   dev_info->max_rx_pktlen = HW_ATL_B0_MTU_JUMBO;
+   dev_info->max_mac_addrs = HW_ATL_B0_MAC_MAX;
+   dev_info->max_vfs = pci_dev->max_vfs;
+
+   dev_info->max_hash_mac_addrs = 0;
+   dev_info->max_vmdq_pools = 0;
+   dev_info->vmdq_queue_num = 0;
+
+   dev_info->rx_offload_capa = ATL_RX_OFFLOADS;
+
+   dev_info->tx_offload_capa = ATL_TX_OFFLOADS;
+
+
+   dev_info->default_rxconf = (struct rte_eth_rxconf) {
+   .rx_free_thresh = ATL_DEFAULT_RX_FREE_THRESH,
+   };
+
+   dev_info->default_txconf = (struct rte_eth_txconf) {
+   .tx_free_thresh = ATL_DEFAULT_TX_FREE_THRESH,
+   };
+
+   dev_info->rx_desc_lim = rx_desc_lim;
+   dev_info->tx_desc_lim = tx_desc_lim;
+
+   dev_info->hash_key_size = HW_ATL_B0_RSS_HASHKEY_BITS /

[dpdk-dev] [PATCH v2 05/21] net/atlantic: b0 hardware layer main logic

[Igor Russkikh]

This is hw_atl logic layer derived from linux atlantic
driver. It contains RX/TX hardware initialization
sequences, various hw configuration.

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/hw_atl/hw_atl_b0.c  | 537 +++
 drivers/net/atlantic/hw_atl/hw_atl_b0.h  |  40 ++
 drivers/net/atlantic/hw_atl/hw_atl_b0_internal.h | 145 ++
 3 files changed, 722 insertions(+)
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_b0.c
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_b0.h
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_b0_internal.h

diff --git a/drivers/net/atlantic/hw_atl/hw_atl_b0.c 
b/drivers/net/atlantic/hw_atl/hw_atl_b0.c
new file mode 100644
index 0..1df60719b
--- /dev/null
+++ b/drivers/net/atlantic/hw_atl/hw_atl_b0.c
@@ -0,0 +1,537 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (C) 2014-2017 aQuantia Corporation. */
+
+/* File hw_atl_b0.c: Definition of Atlantic hardware specific functions. */
+
+#include "../atl_types.h"
+#include "hw_atl_b0.h"
+
+#include "../atl_hw_regs.h"
+#include "hw_atl_utils.h"
+#include "hw_atl_llh.h"
+#include "hw_atl_b0_internal.h"
+#include "hw_atl_llh_internal.h"
+#include "../atl_logs.h"
+
+int hw_atl_b0_hw_reset(struct aq_hw_s *self)
+{
+   int err = 0;
+
+   err = hw_atl_utils_soft_reset(self);
+   if (err)
+   return err;
+
+   self->aq_fw_ops->set_state(self, MPI_RESET);
+
+   return err;
+}
+
+static int hw_atl_b0_hw_qos_set(struct aq_hw_s *self)
+{
+   u32 tc = 0U;
+   u32 buff_size = 0U;
+   unsigned int i_priority = 0U;
+   bool is_rx_flow_control = false;
+
+   /* TPS Descriptor rate init */
+   hw_atl_tps_tx_pkt_shed_desc_rate_curr_time_res_set(self, 0x0U);
+   hw_atl_tps_tx_pkt_shed_desc_rate_lim_set(self, 0xA);
+
+   /* TPS VM init */
+   hw_atl_tps_tx_pkt_shed_desc_vm_arb_mode_set(self, 0U);
+
+   /* TPS TC credits init */
+   hw_atl_tps_tx_pkt_shed_desc_tc_arb_mode_set(self, 0U);
+   hw_atl_tps_tx_pkt_shed_data_arb_mode_set(self, 0U);
+
+   hw_atl_tps_tx_pkt_shed_tc_data_max_credit_set(self, 0xFFF, 0U);
+   hw_atl_tps_tx_pkt_shed_tc_data_weight_set(self, 0x64, 0U);
+   hw_atl_tps_tx_pkt_shed_desc_tc_max_credit_set(self, 0x50, 0U);
+   hw_atl_tps_tx_pkt_shed_desc_tc_weight_set(self, 0x1E, 0U);
+
+   /* Tx buf size */
+   buff_size = HW_ATL_B0_TXBUF_MAX;
+
+   hw_atl_tpb_tx_pkt_buff_size_per_tc_set(self, buff_size, tc);
+   hw_atl_tpb_tx_buff_hi_threshold_per_tc_set(self,
+  (buff_size *
+  (1024 / 32U) * 66U) /
+  100U, tc);
+   hw_atl_tpb_tx_buff_lo_threshold_per_tc_set(self,
+  (buff_size *
+  (1024 / 32U) * 50U) /
+  100U, tc);
+
+   /* QoS Rx buf size per TC */
+   tc = 0;
+   is_rx_flow_control = 0;
+   buff_size = HW_ATL_B0_RXBUF_MAX;
+
+   hw_atl_rpb_rx_pkt_buff_size_per_tc_set(self, buff_size, tc);
+   hw_atl_rpb_rx_buff_hi_threshold_per_tc_set(self,
+  (buff_size *
+  (1024U / 32U) * 66U) /
+  100U, tc);
+   hw_atl_rpb_rx_buff_lo_threshold_per_tc_set(self,
+  (buff_size *
+  (1024U / 32U) * 50U) /
+  100U, tc);
+   hw_atl_rpb_rx_xoff_en_per_tc_set(self,
+is_rx_flow_control ? 1U : 0U,
+tc);
+
+   /* QoS 802.1p priority -> TC mapping */
+   for (i_priority = 8U; i_priority--;)
+   hw_atl_rpf_rpb_user_priority_tc_map_set(self, i_priority, 0U);
+
+   return aq_hw_err_from_flags(self);
+}
+
+/* calc hash only in IPv4 header, regardless of presence of TCP */
+#define pif_rpf_rss_ipv4_hdr_only_i (1 << 4)
+/* calc hash only if TCP header and IPv4 */
+#define pif_rpf_rss_ipv4_tcp_hdr_only_i (1 << 3)
+/* calc hash only in IPv6 header, regardless of presence of TCP */
+#define pif_rpf_rss_ipv6_hdr_only_i (1 << 2)
+/* calc hash only if TCP header and IPv4 */
+#define pif_rpf_rss_ipv6_tcp_hdr_only_i (1 << 1)
+/* bug 5124 - rss hashing types - FIXME */
+#define pif_rpf_rss_dont_use_udp_i  (1 << 0)
+
+
+int hw_atl_b0_hw_rss_hash_type_set(struct aq_hw_s *self)
+{
+   /* misc */
+   unsigned int control_reg_val =
+   IS_CHIP_FEATURE(RPF2) ? 0x000FU : 0xU;
+
+   /* RSS hash type set for IP/TCP */
+   control_reg_val |= pif_rpf_rss_ipv4_hdr_only_i;//0x1EU;
+
+   aq_hw_write_reg(self, 0x5040U, control_reg_val);
+
+ 

[dpdk-dev] [PATCH v2 18/21] net/atlantic: VLAN filters and offloads

[Igor Russkikh]

From: Pavel Belous 

Signed-off-by: Igor Russkikh 
---
 drivers/net/atlantic/atl_ethdev.c | 159 +-
 1 file changed, 157 insertions(+), 2 deletions(-)

diff --git a/drivers/net/atlantic/atl_ethdev.c 
b/drivers/net/atlantic/atl_ethdev.c
index 37f32c421..7ff1126d7 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -84,6 +84,18 @@ static void atl_dev_info_get(struct rte_eth_dev *dev,
 static const uint32_t *atl_dev_supported_ptypes_get(struct rte_eth_dev *dev);
 
 
+/* VLAN stuff */
+static int atl_vlan_filter_set(struct rte_eth_dev *dev,
+   uint16_t vlan_id, int on);
+
+static int atl_vlan_offload_set(struct rte_eth_dev *dev, int mask);
+
+static void atl_vlan_strip_queue_set(struct rte_eth_dev *dev,
+uint16_t queue_id, int on);
+
+static int atl_vlan_tpid_set(struct rte_eth_dev *dev,
+enum rte_vlan_type vlan_type, uint16_t tpid);
+
 /* LEDs */
 static int atl_dev_led_on(struct rte_eth_dev *dev);
 static int atl_dev_led_off(struct rte_eth_dev *dev);
@@ -251,6 +263,11 @@ static const struct eth_dev_ops atl_eth_dev_ops = {
.xstats_get_names = atl_dev_xstats_get_names,
.stats_reset  = atl_dev_stats_reset,
.xstats_reset = atl_dev_xstats_reset,
+   /* VLAN */
+   .vlan_filter_set  = atl_vlan_filter_set,
+   .vlan_offload_set = atl_vlan_offload_set,
+   .vlan_tpid_set= atl_vlan_tpid_set,
+   .vlan_strip_queue_set = atl_vlan_strip_queue_set,
 
/* LEDs */
.dev_led_on   = atl_dev_led_on,
@@ -532,7 +549,6 @@ atl_dev_start(struct rte_eth_dev *dev)
uint32_t intr_vector = 0;
uint32_t *link_speeds;
uint32_t speed = 0;
-   int vlan_mask = 0;
int status;
int err;
 
@@ -588,7 +604,6 @@ atl_dev_start(struct rte_eth_dev *dev)
}
}
 
-
err = hw->aq_fw_ops->update_link_status(hw);
 
if (err)
@@ -1260,6 +1275,146 @@ atl_set_default_mac_addr(struct rte_eth_dev *dev, 
struct ether_addr *addr)
return 0;
 }
 
+static int
+atl_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
+{
+   struct aq_hw_cfg_s *cfg =
+   ATL_DEV_PRIVATE_TO_CFG(dev->data->dev_private);
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   int err = 0;
+   int i = 0;
+
+   PMD_INIT_FUNC_TRACE();
+
+   for (i = 0; i < HW_ATL_B0_MAX_VLAN_IDS; i++) {
+   if (cfg->vlan_filter[i] == vlan_id) {
+   if (!on) {
+   /* Disable VLAN filter. */
+   hw_atl_rpf_vlan_flr_en_set(hw, 0U, i);
+
+   /* Clear VLAN filter entry */
+   cfg->vlan_filter[i] = 0;
+   }
+   break;
+   }
+   }
+
+   /* VLAN_ID was not found. So, nothing to delete. */
+   if (i == HW_ATL_B0_MAX_VLAN_IDS && !on)
+   goto exit;
+
+   /* VLAN_ID already exist, or already removed above. Nothing to do. */
+   if (i != HW_ATL_B0_MAX_VLAN_IDS)
+   goto exit;
+
+   /* Try to found free VLAN filter to add new VLAN_ID */
+   for (i = 0; i < HW_ATL_B0_MAX_VLAN_IDS; i++) {
+   if (cfg->vlan_filter[i] == 0)
+   break;
+   }
+
+   if (i == HW_ATL_B0_MAX_VLAN_IDS) {
+   /* We have no free VLAN filter to add new VLAN_ID*/
+   err = -ENOMEM;
+   goto exit;
+   }
+
+   cfg->vlan_filter[i] = vlan_id;
+   hw_atl_rpf_vlan_flr_act_set(hw, 1U, i);
+   hw_atl_rpf_vlan_id_flr_set(hw, vlan_id, i);
+   hw_atl_rpf_vlan_flr_en_set(hw, 1U, i);
+
+exit:
+   /* Enable VLAN promisc mode if vlan_filter empty  */
+   for (i = 0; i < HW_ATL_B0_MAX_VLAN_IDS; i++) {
+   if (cfg->vlan_filter[i] != 0)
+   break;
+   }
+
+   hw_atl_rpf_vlan_prom_mode_en_set(hw, i == HW_ATL_B0_MAX_VLAN_IDS);
+
+   return err;
+}
+
+static int
+atl_enable_vlan_filter(struct rte_eth_dev *dev, int en)
+{
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   struct aq_hw_cfg_s *cfg =
+   ATL_DEV_PRIVATE_TO_CFG(dev->data->dev_private);
+   int i;
+
+   PMD_INIT_FUNC_TRACE();
+
+   for (i = 0; i < HW_ATL_B0_MAX_VLAN_IDS; i++) {
+   if (cfg->vlan_filter[i])
+   hw_atl_rpf_vlan_flr_en_set(hw, en, i);
+   }
+   return 0;
+}
+
+static int
+atl_vlan_offload_set(struct rte_eth_dev *dev, int mask)
+{
+   struct aq_hw_cfg_s *cfg =
+   ATL_DEV_PRIVATE_TO_CFG(dev->data->dev_private);
+   struct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+   int ret = 0;
+   int i;
+
+   PMD_INIT_FUNC_TRACE();
+
+   ret = atl_enable_vlan_filter(dev, 

[dpdk-dev] [PATCH v6 1/2] net/mlx5: support meson build

[Shahaf Shuler]

From: Nelio Laranjeiro 

Compile Mellanox driver when its external dependencies are met.  A
glue version of the driver can still be requested by using the
-Denable_driver_mlx_glue=true

To avoid modifying the whole sources and keep the compatibility with
current build systems (e.g. make), the mlx5_autoconf.h is still
generated by invoking DPDK scripts though meson's run_command() instead
of using has_types, has_members, ... commands.

Meson will try to find the required external libraries.  When they are
not installed system wide, they can be provided though CFLAGS, LDFLAGS
and LD_LIBRARY_PATH environment variables, example (considering
RDMA-Core is installed in /tmp/rdma-core):

 # CLFAGS=-I/tmp/rdma-core/build/include \
   LDFLAGS=-L/tmp/rdma-core/build/lib \
   LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \
   meson output
 # LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \
   ninja -C output install

Note: LD_LIBRARY_PATH before ninja is necessary when the meson
configuration has changed (e.g. meson configure has been called), in
such situation the LD_LIBRARY_PATH is necessary to invoke the
autoconfiguration script.

Signed-off-by: Nelio Laranjeiro 
Acked-by: Bruce Richardson 
Signed-off-by: Shahaf Shuler 
---
Changes in v6:
- split into two patches for mlx5 and mlx4
- ident with tabs instead of spaces
- no need to remove the confiugration file, meson will override it
- split configuration file creation into two loops: symbols and structs
- rewrite enable_driver_mlx_glue description

Changes in v5:

- use meson tool to generate Mellanox config file instead of DPDK custom 
scripts.

Changes in v4:

- remove implicit -Wall flag (set by default by meson),
- add item information in the autoconfiguration failure error message,
- reword the help for the glue library option,

Changes in v3:

Sanitize the build files:
- remove enable_driver_mlx{4,5} options,
- test cflags capabilities before using them,
- remove old autoconfiguration file,
- use an array for autoconfiguration and put them in the build directory,
- use dependencies in shared_library for link arguments.

Changes in v2:

- dropped patch https://patches.dpdk.org/patch/43897/
- remove extra_{cflags,ldflags} as already honored by meson through
environment variables.

---
 drivers/net/meson.build  |   1 +
 drivers/net/mlx5/meson.build | 228 +++
 meson_options.txt|   2 +
 3 files changed, 231 insertions(+)
 create mode 100644 drivers/net/mlx5/meson.build

diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 9c28ed4da4..d444c3287f 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -18,6 +18,7 @@ drivers = ['af_packet',
'ixgbe',
'kni',
'liquidio',
+   'mlx5',
'mvpp2',
'netvsc',
'nfp',
diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
new file mode 100644
index 00..289c7a4c07
--- /dev/null
+++ b/drivers/net/mlx5/meson.build
@@ -0,0 +1,228 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2018 6WIND S.A.
+# Copyright 2018 Mellanox Technologies, Ltd
+
+pmd_dlopen = get_option('enable_driver_mlx_glue')
+LIB_GLUE_BASE = 'librte_pmd_mlx5_glue.so'
+LIB_GLUE_VERSION = '18.05.0'
+LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
+if pmd_dlopen
+   dpdk_conf.set('RTE_LIBRTE_MLX5_DLOPEN_DEPS', 1)
+   cflags += [
+   '-DMLX5_GLUE="@0@"'.format(LIB_GLUE),
+   '-DMLX5_GLUE_VERSION="@0@"'.format(LIB_GLUE_VERSION),
+   ]
+endif
+libs = [
+   cc.find_library('mnl', required:false),
+   cc.find_library('mlx5', required:false),
+   cc.find_library('ibverbs', required:false),
+]
+build = true
+foreach lib:libs
+   if not lib.found()
+   build = false
+   endif
+endforeach
+if build
+   allow_experimental_apis = true
+   ext_deps += libs
+   sources = files(
+   'mlx5.c',
+   'mlx5_ethdev.c',
+   'mlx5_flow.c',
+   'mlx5_mac.c',
+   'mlx5_mr.c',
+   'mlx5_nl.c',
+   'mlx5_nl_flow.c',
+   'mlx5_rss.c',
+   'mlx5_rxmode.c',
+   'mlx5_rxq.c',
+   'mlx5_rxtx.c',
+   'mlx5_socket.c',
+   'mlx5_stats.c',
+   'mlx5_trigger.c',
+   'mlx5_txq.c',
+   'mlx5_vlan.c',
+   )
+   if dpdk_conf.has('RTE_ARCH_X86_64') or dpdk_conf.has('RTE_ARCH_ARM64')
+   sources += files('mlx5_rxtx_vec.c')
+   endif
+   if not pmd_dlopen
+   sources += files('mlx5_glue.c')
+   endif
+   cflags_options = [
+   '-Wextra',
+   '-std=c11',
+   '-Wno-strict-prototypes',
+   '-D_BSD_SOURCE',
+   '-D_DEFAULT_SOURCE',
+   '-D_XOPEN_SOURCE=600'
+   ]
+   foreach option:cflags_options
+   if cc.has_argument(option)
+   cfla

[dpdk-dev] [PATCH v2 00/21] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver

[Igor Russkikh]

Hello DPDK community!

Aquantia would like to contribute PMD for aQtion AQC10X NIC family:
https://www.aquantia.com/products/aqtion/chips/
These are 10G ethernet NICs with various features.

We do base this work on parts of the existing native linux kernel
driver source (atlantic). Shared code is hw_atl hardware and registers access 
module.

We'd like to target this driver for 18.11 DPDK release timeline,
it'd be good to hear comments from the community on how feasible is this.

This patchset implements basic driver infrastructure,
vlan offloads, checksumm offloads, rss control,
multiring, jumbo frames and other features.

Later on, we plan to share HW MACSEC offloads, rxflows and other features.

version 2 changes:
- fixed build on freebsd (no ETIME const)
- fixed a bunch of checkpatch failures and warnings
- removed extra CFLAGS disabled warning
- making static arrays const

Igor Russkikh (11):
  net/atlantic: documentation and rel notes
  net/atlantic: logging macroes and some typedefs
  net/atlantic: hw_atl register declarations
  net/atlantic: b0 hardware layer main logic
  net/atlantic: firmware operations layer
  net/atlantic: hardware register access routines
  net/atlantic: rte device start, stop, initial configuration
  net/atlantic: RSS and RETA manipulation API
  net/atlantic: LED control DPDK and private APIs
  net/atlantic: device statistics, xstats
  net/atlantic: RX side structures and implementation

Pavel Belous (10):
  net/atlantic: atlantic PMD driver skeleton
  net/atlantic: link status and interrupt management
  net/atlantic: add hw adapter structures and defines
  net/atlantic: flow control configuration
  net/atlantic: MAC address manipulations
  net/atlantic: eeprom and register manipulation routines
  net/atlantic: promisc and allmulti configuration
  net/atlantic: VLAN filters and offloads
  net/atlantic: device MTU and statuses
  net/atlantic: TX side structures and implementation

 config/common_base|9 +
 doc/guides/nics/atlantic.rst  |   59 +
 doc/guides/nics/features/atlantic.ini |   37 +
 doc/guides/nics/index.rst |1 +
 doc/guides/rel_notes/release_18_11.rst|5 +
 drivers/net/Makefile  |2 +
 drivers/net/atlantic/Makefile |   46 +
 drivers/net/atlantic/atl_common.h |   96 +
 drivers/net/atlantic/atl_ethdev.c | 1751 +++
 drivers/net/atlantic/atl_ethdev.h |  133 ++
 drivers/net/atlantic/atl_hw_regs.c|   52 +
 drivers/net/atlantic/atl_hw_regs.h|   53 +
 drivers/net/atlantic/atl_logs.h   |   68 +
 drivers/net/atlantic/atl_rxtx.c   | 1365 
 drivers/net/atlantic/atl_types.h  |  235 ++
 drivers/net/atlantic/hw_atl/hw_atl_b0.c   |  510 +
 drivers/net/atlantic/hw_atl/hw_atl_b0.h   |   40 +
 drivers/net/atlantic/hw_atl/hw_atl_b0_internal.h  |  145 ++
 drivers/net/atlantic/hw_atl/hw_atl_llh.c  | 1490 +
 drivers/net/atlantic/hw_atl/hw_atl_llh.h  |  714 ++
 drivers/net/atlantic/hw_atl/hw_atl_llh_internal.h | 2407 +
 drivers/net/atlantic/hw_atl/hw_atl_utils.c|  942 
 drivers/net/atlantic/hw_atl/hw_atl_utils.h|  510 +
 drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c   |  618 ++
 drivers/net/atlantic/meson.build  |   28 +
 drivers/net/atlantic/rte_pmd_atlantic.c   |   19 +
 drivers/net/atlantic/rte_pmd_atlantic.h   |   44 +
 drivers/net/atlantic/rte_pmd_atlantic_version.map |4 +
 drivers/net/meson.build   |1 +
 mk/rte.app.mk |1 +
 30 files changed, 11385 insertions(+)
 create mode 100644 doc/guides/nics/atlantic.rst
 create mode 100644 doc/guides/nics/features/atlantic.ini
 create mode 100644 drivers/net/atlantic/Makefile
 create mode 100644 drivers/net/atlantic/atl_common.h
 create mode 100644 drivers/net/atlantic/atl_ethdev.c
 create mode 100644 drivers/net/atlantic/atl_ethdev.h
 create mode 100644 drivers/net/atlantic/atl_hw_regs.c
 create mode 100644 drivers/net/atlantic/atl_hw_regs.h
 create mode 100644 drivers/net/atlantic/atl_logs.h
 create mode 100644 drivers/net/atlantic/atl_rxtx.c
 create mode 100644 drivers/net/atlantic/atl_types.h
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_b0.c
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_b0.h
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_b0_internal.h
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_llh.c
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_llh.h
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_llh_internal.h
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_utils.c
 create mode 100644 drivers/net/atlantic/hw_atl/hw_atl_utils.h
 create mode 100644 drivers/net/atlant

[dpdk-dev] [PATCH v6 2/2] net/mlx4: support meson build

[Shahaf Shuler]

From: Nelio Laranjeiro 

Compile Mellanox driver when their external dependencies are met.  A
glue version of the driver can still be requested by using the
-Denable_driver_mlx_glue=true

To avoid modifying the whole sources and keep the compatibility with
current build systems (e.g. make), the mlx4_autoconf.h is still
generated by invoking DPDK scripts though meson's run_command() instead
of using has_types, has_members, ... commands.

Meson will try to find the required external libraries.  When they are
not installed system wide, they can be provided though CFLAGS, LDFLAGS
and LD_LIBRARY_PATH environment variables, example (considering
RDMA-Core is installed in /tmp/rdma-core):

 # CLFAGS=-I/tmp/rdma-core/build/include \
   LDFLAGS=-L/tmp/rdma-core/build/lib \
   LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \
   meson output
 # LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \
   ninja -C output install

Note: LD_LIBRARY_PATH before ninja is necessary when the meson
configuration has changed (e.g. meson configure has been called), in
such situation the LD_LIBRARY_PATH is necessary to invoke the
autoconfiguration script.

Signed-off-by: Nelio Laranjeiro 
Acked-by: Bruce Richardson 
Signed-off-by: Shahaf Shuler 

---
Changes in v6:
- split into two patches for mlx5 and mlx4
- ident with tabs instead of spaces
- no need to remove the confiugration file, meson will override it
- split configuration file creation into two loops: symbols and structs

Changes in v5:

- use meson tool to generate Mellanox config file instead of DPDK custom 
scripts.

Changes in v4:

- remove implicit -Wall flag (set by default by meson),
- add item information in the autoconfiguration failure error message,
- reword the help for the glue library option,

Changes in v3:

Sanitize the build files:
- remove enable_driver_mlx{4,5} options,
- test cflags capabilities before using them,
- remove old autoconfiguration file,
- use an array for autoconfiguration and put them in the build directory,
- use dependencies in shared_library for link arguments.

Changes in v2:

- dropped patch https://patches.dpdk.org/patch/43897/
- remove extra_{cflags,ldflags} as already honored by meson through
environment variables.
---
 drivers/net/meson.build  |   1 +
 drivers/net/mlx4/meson.build | 102 +++
 2 files changed, 103 insertions(+)
 create mode 100644 drivers/net/mlx4/meson.build

diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index d444c3287f..c7a2d0e7db 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -18,6 +18,7 @@ drivers = ['af_packet',
'ixgbe',
'kni',
'liquidio',
+   'mlx4',
'mlx5',
'mvpp2',
'netvsc',
diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
new file mode 100644
index 00..7de571e2a2
--- /dev/null
+++ b/drivers/net/mlx4/meson.build
@@ -0,0 +1,102 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2018 6WIND S.A.
+# Copyright 2018 Mellanox Technologies, Ltd
+
+pmd_dlopen = get_option('enable_driver_mlx_glue')
+LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'
+LIB_GLUE_VERSION = '18.02.0'
+LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
+if pmd_dlopen
+   dpdk_conf.set('RTE_LIBRTE_MLX4_DLOPEN_DEPS', 1)
+   cflags += [
+   '-DMLX4_GLUE="@0@"'.format(LIB_GLUE),
+   '-DMLX4_GLUE_VERSION="@0@"'.format(LIB_GLUE_VERSION),
+   ]
+endif
+libs = [
+   cc.find_library('mnl', required:false),
+   cc.find_library('mlx4', required:false),
+   cc.find_library('ibverbs', required:false),
+]
+build = true
+foreach lib:libs
+   if not lib.found()
+   build = false
+   endif
+endforeach
+# Compile PMD
+if build
+   allow_experimental_apis = true
+   ext_deps += libs
+   sources = files(
+   'mlx4.c',
+   'mlx4_ethdev.c',
+   'mlx4_flow.c',
+   'mlx4_intr.c',
+   'mlx4_mr.c',
+   'mlx4_rxq.c',
+   'mlx4_rxtx.c',
+   'mlx4_txq.c',
+   'mlx4_utils.c',
+   )
+   if not pmd_dlopen
+   sources += files('mlx4_glue.c')
+   endif
+   cflags_options = [
+   '-Wextra',
+   '-std=c11',
+   '-Wno-strict-prototypes',
+   '-D_BSD_SOURCE',
+   '-D_DEFAULT_SOURCE',
+   '-D_XOPEN_SOURCE=600'
+   ]
+   foreach option:cflags_options
+   if cc.has_argument(option)
+   cflags += option
+   endif
+   endforeach
+   if get_option('buildtype').contains('debug')
+   cflags += [ '-pedantic', '-UNDEBUG', '-DPEDANTIC' ]
+   else
+   cflags += [ '-DNDEBUG', '-UPEDANTIC' ]
+   endif
+   # To maintain the compatibility with the make build system
+   # mlx4_autoconf.h file is still generated.
+   # input array for meson member search:
+   # [

Re: [dpdk-dev] [PATCH v2] net/i40e: stop lldp before setting local lldp MIB

[Zhang, Qi Z]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams
> Sent: Tuesday, August 7, 2018 4:06 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei ; Zhang, Qi Z ;
> Charles (Chas) Williams 
> Subject: [dpdk-dev] [PATCH v2] net/i40e: stop lldp before setting local lldp 
> MIB
> 
> From: "Charles (Chas) Williams" 
> 
> From the Intel Ethernet Controller X710/XXV710/XL710 Specifiction
> Update:
> 
> Starting from NVM 5.02, if the Set Local LLDP MIB command is
> received while the DCBx specific agent is stopped, the command
> returns an EPERM error. If the command is received while the
> LLDP agent is stopped, it sets the local MIB without exchanging
> LLDP with peer, and returns SUCCESS.
> 
> This results in the harmless, but annoying, diagnostic:
> 
> default dcb config fails. err = -53, aq_err = 1.
> 
> So, if possible (older firmwares cannot safely stop LLDP), stop the lldp 
> daemon
> when we are in software mod before we attempt to call i40e_set_dcb_config.
> 
> Signed-off-by: Chas Williams 

Acked-by: Qi Zhang 

Applied to dpdk-next-net-intel

Thanks
Qi

Re: [dpdk-dev] [PATCH v6 1/2] net/mlx5: support meson build

[Bruce Richardson]

On Thu, Sep 13, 2018 at 03:11:05PM +0300, Shahaf Shuler wrote:
> From: Nelio Laranjeiro 
> 
> Compile Mellanox driver when its external dependencies are met.  A
> glue version of the driver can still be requested by using the
> -Denable_driver_mlx_glue=true
> 
> To avoid modifying the whole sources and keep the compatibility with
> current build systems (e.g. make), the mlx5_autoconf.h is still
> generated by invoking DPDK scripts though meson's run_command() instead
> of using has_types, has_members, ... commands.
> 

This part of the commit message is no longer accurate.

> Meson will try to find the required external libraries.  When they are
> not installed system wide, they can be provided though CFLAGS, LDFLAGS
> and LD_LIBRARY_PATH environment variables, example (considering
> RDMA-Core is installed in /tmp/rdma-core):
> 
>  # CLFAGS=-I/tmp/rdma-core/build/include \
>LDFLAGS=-L/tmp/rdma-core/build/lib \
>LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \
>meson output
>  # LD_LIBRARY_PATH=/tmp/rdma-core/build/lib \
>ninja -C output install
> 
> Note: LD_LIBRARY_PATH before ninja is necessary when the meson
> configuration has changed (e.g. meson configure has been called), in
> such situation the LD_LIBRARY_PATH is necessary to invoke the
> autoconfiguration script.
> 
> Signed-off-by: Nelio Laranjeiro 
> Acked-by: Bruce Richardson 
> Signed-off-by: Shahaf Shuler 

The signoffs should be together, followed by the ack.

Otherwise LGTM (for both patches)

/Bruce

Re: [dpdk-dev] [PATCH] net/i40e: remove invalid comment

[Zhang, Qi Z]

> -Original Message-
> From: Yigit, Ferruh
> Sent: Thursday, September 13, 2018 7:21 PM
> To: Xing, Beilei ; Zhang, Qi Z 
> Cc: dev@dpdk.org; Yigit, Ferruh 
> Subject: [PATCH] net/i40e: remove invalid comment
> 
> Comments says "no csum error report support" but there is no check related
> csum offloads. Removing the comment.
> 
> Signed-off-by: Ferruh Yigit 

Acked-by: Qi Zhang 

Applied to dpdk-next-net-intel.

Thanks
Qi

Re: [dpdk-dev] [PATCH v3 1/9] fbarray: fix detach in noshconf mode

[Maxime Coquelin]

On 09/04/2018 05:15 PM, Anatoly Burakov wrote:

In noshconf mode, no shared files are created, but we're still trying
to unlink them, resulting in detach/destroy failure even though it
should have succeeded. Fix it by exiting early in noshconf mode.

Fixes: 3ee2cde248a7 ("fbarray: support --no-shconf mode")
Cc: sta...@dpdk.org

Signed-off-by: Anatoly Burakov 
---
  lib/librte_eal/common/eal_common_fbarray.c | 4 
  1 file changed, 4 insertions(+)


Reviewed-by: Maxime Coquelin 

Re: [dpdk-dev] [PATCH v3 2/9] eal: don't allow legacy mode with in-memory mode

[Maxime Coquelin]

On 09/04/2018 05:15 PM, Anatoly Burakov wrote:

In-memory mode was never meant to support legacy mode, because we
cannot sort anonymous pages anyway.

Fixes: 72b49ff623c4 ("mem: support --in-memory mode")
Cc: sta...@dpdk.org

Signed-off-by: Anatoly Burakov 
---
  lib/librte_eal/common/eal_common_options.c | 6 ++
  1 file changed, 6 insertions(+)

diff --git a/lib/librte_eal/common/eal_common_options.c 
b/lib/librte_eal/common/eal_common_options.c
index dd5f97402..873099acc 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -1390,6 +1390,12 @@ eal_check_common_options(struct internal_config 
*internal_cfg)
"--"OPT_HUGE_UNLINK"\n");
return -1;
}
+   if (internal_cfg->legacy_mem &&
+   internal_cfg->in_memory) {
+   RTE_LOG(ERR, EAL, "Option --"OPT_LEGACY_MEM" is not compatible "
+   "with --"OPT_IN_MEMORY"\n");


This is a general comment, as it is consistent with the style of the
file. I generally prefer not splitting error strings into multiple lines
even if it is longer than 80 chars, because it makes grepping for the 
error string more difficult.



+   return -1;
+   }
  
  	return 0;

  }



Other than that:
Reviewed-by: Maxime Coquelin 

Thanks,
Maxime

Re: [dpdk-dev] [PATCH v3 3/9] mem: raise maximum fd limit unconditionally

[Maxime Coquelin]

On 09/04/2018 05:15 PM, Anatoly Burakov wrote:

Previously, when we allocated hugepages, we closed the fd's corresponding
to them after we've done our mappings. Since we did mmap(), we didn't
actually lose the reference, but file descriptors used for mmap() do not
count against the fd limit. Since we are going to store all of our fd's,
we will hit the fd limit much more often when using smaller page sizes.

Fix this to raise the fd limit to maximum unconditionally.

Signed-off-by: Anatoly Burakov 
---
  lib/librte_eal/linuxapp/eal/eal_memory.c | 20 
  1 file changed, 20 insertions(+)

diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c 
b/lib/librte_eal/linuxapp/eal/eal_memory.c
index dbf19499e..dfb537f59 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memory.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
@@ -17,6 +17,7 @@
  #include 
  #include 
  #include 
+#include 
  #include 
  #include 
  #include 
@@ -2204,6 +2205,25 @@ memseg_secondary_init(void)
  int
  rte_eal_memseg_init(void)
  {
+   /* increase rlimit to maximum */
+   struct rlimit lim;
+
+   if (getrlimit(RLIMIT_NOFILE, &lim) == 0) {
+   /* set limit to maximum */
+   lim.rlim_cur = lim.rlim_max;
+
+   if (setrlimit(RLIMIT_NOFILE, &lim) < 0) {
+   RTE_LOG(DEBUG, EAL, "Setting maximum number of open files 
failed: %s\n",
+   strerror(errno));
+   } else {
+   RTE_LOG(DEBUG, EAL, "Setting maximum number of open files to 
%"
+   PRIu64 "\n",
+   (uint64_t)lim.rlim_cur);
+   }
+   } else {
+   RTE_LOG(ERR, EAL, "Cannot get current resource limits\n");
+   }
+
return rte_eal_process_type() == RTE_PROC_PRIMARY ?
  #ifndef RTE_ARCH_64
memseg_primary_init_32() :



Reviewed-by: Maxime Coquelin 

Re: [dpdk-dev] [PATCH v2 1/9] build: add Meson file for TAP PMD

[Bruce Richardson]

On Tue, Sep 11, 2018 at 05:08:55PM +0100, Luca Boccassi wrote:
> Use same autoconf generation mechanism as the MLX4/5 PMDs
> 
> Signed-off-by: Luca Boccassi 
> ---
>  drivers/net/meson.build |  1 +
>  drivers/net/tap/meson.build | 41 +
>  2 files changed, 42 insertions(+)
>  create mode 100644 drivers/net/tap/meson.build
> 
> diff --git a/drivers/net/meson.build b/drivers/net/meson.build
> index c7a2d0e7db..b7b4870eb8 100644
> --- a/drivers/net/meson.build
> +++ b/drivers/net/meson.build
> @@ -27,6 +27,7 @@ drivers = ['af_packet',
>   'sfc',
>   'softnic',
>   'szedata2',
> + 'tap',
>   'thunderx',
>   'vhost',
>   'virtio']
> diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build
> new file mode 100644
> index 00..ef3c6e1fee
> --- /dev/null
> +++ b/drivers/net/tap/meson.build
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright 2018 Luca Boccassi 
> +
> +sources = files(
> + 'rte_eth_tap.c',
> + 'tap_bpf_api.c',
> + 'tap_flow.c',
> + 'tap_intr.c',
> + 'tap_netlink.c',
> + 'tap_tcmsgs.c',
> +)
> +
> +deps = ['bus_vdev', 'gso', 'hash']
> +
> +cflags += '-DTAP_MAX_QUEUES=16'
> +
> +# To maintain the compatibility with the make build system
> +# tap_autoconf.h file is still generated.
> +# input array for meson symbol search:
> +# [ "MACRO to define if found", "header for the search",
> +#   "enum/define", "symbol to search" ]
> +#
> +args = [
> + [ 'HAVE_TC_FLOWER', 'linux/pkt_cls.h',
> +   'enum', 'TCA_FLOWER_UNSPEC' ],
> + [ 'HAVE_TC_VLAN_ID', 'linux/pkt_cls.h',
> +   'enum', 'TCA_FLOWER_KEY_VLAN_PRIO' ],
> + [ 'HAVE_TC_BPF', 'linux/pkt_cls.h',
> +   'enum', 'TCA_BPF_UNSPEC' ],
> + [ 'HAVE_TC_BPF_FD', 'linux/pkt_cls.h',
> +   'enum', 'TCA_BPF_FD' ],
> + [ 'HAVE_TC_ACT_BPF', 'linux/tc_act/tc_bpf.h',
> +   'enum', 'TCA_ACT_BPF_UNSPEC' ],
> + [ 'HAVE_TC_ACT_BPF_FD', 'linux/tc_act/tc_bpf.h',
> +   'enum', 'TCA_ACT_BPF_FD' ],
> +]
> +config = configuration_data()
> +foreach arg:args
> + config.set(arg[0], cc.has_header_symbol(arg[1], arg[3]))
> +endforeach
> +configure_file(output : 'tap_autoconf.h', configuration : config)
> -- 

Minor nit, arg 2 is unused, and this could be dropped, as is done in the
latest version of the mlnx meson build files.

/Bruce

Re: [dpdk-dev] [PATCH v2 4/9] build: add Meson files for avf PMD

[Bruce Richardson]

On Tue, Sep 11, 2018 at 05:08:58PM +0100, Luca Boccassi wrote:
> Signed-off-by: Luca Boccassi 
> ---
>  drivers/net/avf/base/meson.build | 20 
>  drivers/net/avf/meson.build  | 15 +++
>  drivers/net/meson.build  |  1 +
>  3 files changed, 36 insertions(+)
>  create mode 100644 drivers/net/avf/base/meson.build
>  create mode 100644 drivers/net/avf/meson.build
> 

After applying this patch, I get lots of unused variable warnings. Gcc 6.3
on debian, you'll be glad to know.

/Bruce

Re: [dpdk-dev] [PATCH v5] net/i40e: add interface to choose latest vector path

[Ferruh Yigit]

On 9/12/2018 11:12 AM, Xiaoyun Li wrote:
> Right now, vector path is limited to only use on later platform.

i40e supports vector instructions for intel, arm and powerpc,
this behavior is only for Intel vector drivers, can be good to clarify,
also it can better to explain a little more what "limited to only use on later
platform" means.

> This patch adds a devarg use-latest-vec to allow the users to
> use the latest vector path that the platform supported. Namely,
> using AVX2 vector path on broadwell is possible.

Again, this is for intel only, and can you put a matrix to clarify what is
supported:

no devarg:
Machine PMD
avx512  avx2
avx2sse4.2
sse4.2  sse4.2
< sse4.2not supported

with devarg:
Machine PMD
avx512  avx2
avx2avx2
sse4.2  sse4.2
< sse4.2not supported


And I am not sure about name of the devarg "use-latest-vec", I can see it has
been discussed already.
What about "use-latest-supported-vec"? Too verbose?
Do you have any other suggestion?

<...>

> @@ -163,6 +163,14 @@ Runtime Config Options
>Currently hot-plugging of representor ports is not supported so all 
> required
>representors must be specified on the creation of the PF.
>  
> +- ``Use latest vector`` (default ``disable``)
> +
> +  Vector path was limited to use only on later platform. But users may want 
> the
> +  latest vector path. For example, VPP users may want to use AVX2 vector 
> path on HSW/BDW
> +  because it can get better perf. So ``devargs`` parameter 
> ``use-latest-vec`` is
> +  introduced, for example::
> +-w 84:00.0,use-latest-vec=1

Do we need to name a specific consumer of DPDK on i40e document? Why not say any
application?

> +
>  Driver compilation and testing
>  --
>  
> diff --git a/doc/guides/rel_notes/release_18_11.rst 
> b/doc/guides/rel_notes/release_18_11.rst
> index 3ae6b3f58..34af591a2 100644
> --- a/doc/guides/rel_notes/release_18_11.rst
> +++ b/doc/guides/rel_notes/release_18_11.rst
> @@ -54,6 +54,10 @@ New Features
>   Also, make sure to start the actual text at the margin.
>   =
>  
> +* **Added a devarg to use the latest vector path.**
> +  A new devarg ``use-latest-vec`` was introduced to allow users to choose
> +  the latest vector path that the platform supported. For example, VPP users
> +  can use AVX2 vector path on BDW/HSW to get better performance.

Same, do we need to name a specific consumer of DPDK on release notes?

<...>

> @@ -1201,6 +1203,46 @@ i40e_aq_debug_write_global_register(struct i40e_hw *hw,
>   return i40e_aq_debug_write_register(hw, reg_addr, reg_val, cmd_details);
>  }
>  
> +static int
> +i40e_parse_latest_vec(struct rte_eth_dev *dev)
> +{
> + struct i40e_adapter *ad =
> + I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
> + int kvargs_count, use_latest_vec;
> + struct rte_kvargs *kvlist;
> +
> + ad->use_latest_vec = false;
> +
> + if (!dev->device->devargs)
> + return 0;
> +
> + kvlist = rte_kvargs_parse(dev->device->devargs->args, valid_keys);
> + if (!kvlist)
> + return -EINVAL;

Agree with Qi to prevent rte_kvargs_parse() call for each devarg, in the future.

> +
> + kvargs_count = rte_kvargs_count(kvlist, ETH_I40E_USE_LATEST_VEC);
> + if (!kvargs_count) {
> + rte_kvargs_free(kvlist);
> + return 0;
> + }
> +
> + if (kvargs_count > 1)
> + PMD_DRV_LOG(WARNING, "More than one argument \"%s\" and only "
> + "the first one is used !",
> + ETH_I40E_USE_LATEST_VEC);
> +
> + use_latest_vec = atoi((&kvlist->pairs[0])->value);

Instead of accessing directly kvlist internals, please use rte_kvargs_process()

<...>

> @@ -12527,4 +12570,5 @@ RTE_PMD_REGISTER_PARAM_STRING(net_i40e,
> ETH_I40E_FLOATING_VEB_ARG "=1"
> ETH_I40E_FLOATING_VEB_LIST_ARG "="
> ETH_I40E_QUEUE_NUM_PER_VF_ARG "=1|2|4|8|16"
> -   ETH_I40E_SUPPORT_MULTI_DRIVER "=1");
> +   ETH_I40E_SUPPORT_MULTI_DRIVER "=1"
> +   ETH_I40E_USE_LATEST_VEC "=1");

= 0|1 ?

Re: [dpdk-dev] [PATCH v2 1/9] build: add Meson file for TAP PMD

[Luca Boccassi]

On Thu, 2018-09-13 at 14:11 +0100, Bruce Richardson wrote:
> On Tue, Sep 11, 2018 at 05:08:55PM +0100, Luca Boccassi wrote:
> > Use same autoconf generation mechanism as the MLX4/5 PMDs
> > 
> > Signed-off-by: Luca Boccassi 
> > ---
> >  drivers/net/meson.build |  1 +
> >  drivers/net/tap/meson.build | 41
> > +
> >  2 files changed, 42 insertions(+)
> >  create mode 100644 drivers/net/tap/meson.build
> > 
> > diff --git a/drivers/net/meson.build b/drivers/net/meson.build
> > index c7a2d0e7db..b7b4870eb8 100644
> > --- a/drivers/net/meson.build
> > +++ b/drivers/net/meson.build
> > @@ -27,6 +27,7 @@ drivers = ['af_packet',
> >     'sfc',
> >     'softnic',
> >     'szedata2',
> > +   'tap',
> >     'thunderx',
> >     'vhost',
> >     'virtio']
> > diff --git a/drivers/net/tap/meson.build
> > b/drivers/net/tap/meson.build
> > new file mode 100644
> > index 00..ef3c6e1fee
> > --- /dev/null
> > +++ b/drivers/net/tap/meson.build
> > @@ -0,0 +1,41 @@
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright 2018 Luca Boccassi 
> > +
> > +sources = files(
> > +   'rte_eth_tap.c',
> > +   'tap_bpf_api.c',
> > +   'tap_flow.c',
> > +   'tap_intr.c',
> > +   'tap_netlink.c',
> > +   'tap_tcmsgs.c',
> > +)
> > +
> > +deps = ['bus_vdev', 'gso', 'hash']
> > +
> > +cflags += '-DTAP_MAX_QUEUES=16'
> > +
> > +# To maintain the compatibility with the make build system
> > +# tap_autoconf.h file is still generated.
> > +# input array for meson symbol search:
> > +# [ "MACRO to define if found", "header for the search",
> > +#   "enum/define", "symbol to search" ]
> > +#
> > +args = [
> > +   [ 'HAVE_TC_FLOWER', 'linux/pkt_cls.h',
> > +     'enum', 'TCA_FLOWER_UNSPEC' ],
> > +   [ 'HAVE_TC_VLAN_ID', 'linux/pkt_cls.h',
> > +     'enum', 'TCA_FLOWER_KEY_VLAN_PRIO' ],
> > +   [ 'HAVE_TC_BPF', 'linux/pkt_cls.h',
> > +     'enum', 'TCA_BPF_UNSPEC' ],
> > +   [ 'HAVE_TC_BPF_FD', 'linux/pkt_cls.h',
> > +     'enum', 'TCA_BPF_FD' ],
> > +   [ 'HAVE_TC_ACT_BPF', 'linux/tc_act/tc_bpf.h',
> > +     'enum', 'TCA_ACT_BPF_UNSPEC' ],
> > +   [ 'HAVE_TC_ACT_BPF_FD', 'linux/tc_act/tc_bpf.h',
> > +     'enum', 'TCA_ACT_BPF_FD' ],
> > +]
> > +config = configuration_data()
> > +foreach arg:args
> > +   config.set(arg[0], cc.has_header_symbol(arg[1], arg[3]))
> > +endforeach
> > +configure_file(output : 'tap_autoconf.h', configuration : config)
> > -- 
> 
> Minor nit, arg 2 is unused, and this could be dropped, as is done in
> the
> latest version of the mlnx meson build files.
> 
> /Bruce

Ok, will fix in v3

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] [PATCH v2 4/9] build: add Meson files for avf PMD

[Luca Boccassi]

On Thu, 2018-09-13 at 14:24 +0100, Bruce Richardson wrote:
> On Tue, Sep 11, 2018 at 05:08:58PM +0100, Luca Boccassi wrote:
> > Signed-off-by: Luca Boccassi 
> > ---
> >  drivers/net/avf/base/meson.build | 20 
> >  drivers/net/avf/meson.build  | 15 +++
> >  drivers/net/meson.build  |  1 +
> >  3 files changed, 36 insertions(+)
> >  create mode 100644 drivers/net/avf/base/meson.build
> >  create mode 100644 drivers/net/avf/meson.build
> > 
> 
> After applying this patch, I get lots of unused variable warnings.
> Gcc 6.3
> on debian, you'll be glad to know.
> 
> /Bruce

Yep got the same, but I'll leave that for the AVF maintainers to have
fun with :-)

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] [PATCH v7] linuxapp, eal: Fix the memory leak issue of logid

[Aaron Conole]

On second thought - please just fold in the patch I
proposed back in July that I was told would be merged:

  http://mails.dpdk.org/archives/dev/2018-July/108445.html
  http://mails.dpdk.org/archives/dev/2018-August/109177.html

It doesn't include the issues calling rte_atomic32_clear (that I have
concerns about) and preserves an arbitrary length value being passed
through argv/argc.

:-)

-Aaron

"Ananyev, Konstantin"  writes:

>> -Original Message-
>> From: Aaron Conole [mailto:acon...@redhat.com]
>> Sent: Tuesday, September 11, 2018 2:47 PM
>> To: Yang, Ziye 
>> Cc: dev@dpdk.org; Ananyev, Konstantin
>> ; Ziye Yang 
>> Subject: Re: [dpdk-dev] [PATCH v7] linuxapp, eal: Fix the memory
>> leak issue of logid
>> 
>> Ziye Yang  writes:
>> 
>> > From: Ziye Yang 
>> >
>> > This patch is used to fix the memory leak issue of logid.
>> > We use the ASAN test in SPDK when intergrating DPDK and
>> > find this memory leak issue.
>> >
>> > By the way, we also fix several missed function call of
>> > rte_atomic32_clear.
>> 
>> This part I don't understand.  It should be a separate proposal.
>> 
>> > Signed-off-by: Ziye Yang 
>> > ---
>> >  lib/librte_eal/linuxapp/eal/eal.c | 11 +++
>> >  1 file changed, 7 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/lib/librte_eal/linuxapp/eal/eal.c 
>> > b/lib/librte_eal/linuxapp/eal/eal.c
>> > index e59ac65..a5129e5 100644
>> > --- a/lib/librte_eal/linuxapp/eal/eal.c
>> > +++ b/lib/librte_eal/linuxapp/eal/eal.c
>> > @@ -793,7 +793,8 @@ static void rte_eal_init_alert(const char *msg)
>> >int i, fctret, ret;
>> >pthread_t thread_id;
>> >static rte_atomic32_t run_once = RTE_ATOMIC32_INIT(0);
>> > -  const char *logid;
>> > +  const char *p;
>> > +  static char logid[PATH_MAX];
>> 
>> On a linux system, PATH_MAX is 4096, but an argument may be
>> MAX_ARG_STRLEN which is significantly higher.
>
> But we only interested here in 'basename(argv[0])'.
> Surely it shouldn't be bigger than PATH_MAX unless something is
> terribly wrong here.
>
>> 
>> Have you thought about an alternative where you keep the strdup and add
>> an atexit() handler to do the free?  Otherwise, you'll need to add code
>> to check the string length as well and enforce some kind of size
>> restriction.
>
> snprintf() below will do a safe truncation for us.
>
>> 
>> >char cpuset[RTE_CPU_AFFINITY_STR_LEN];
>> >char thread_name[RTE_MAX_THREAD_NAME_LEN];
>> >
>> > @@ -810,9 +811,8 @@ static void rte_eal_init_alert(const char *msg)
>> >return -1;
>> >}
>> >
>> > -  logid = strrchr(argv[0], '/');
>> > -  logid = strdup(logid ? logid + 1: argv[0]);
>> > -
>> > +  p = strrchr(argv[0], '/');
>> > +  snprintf(logid, sizeof(logid), "%s", (p ? p + 1 : argv[0]));
>> >thread_id = pthread_self();
>> >
>> >eal_reset_internal_config(&internal_config);
>> > @@ -823,6 +823,7 @@ static void rte_eal_init_alert(const char *msg)
>> >if (rte_eal_cpu_init() < 0) {
>> >rte_eal_init_alert("Cannot detect lcores.");
>> >rte_errno = ENOTSUP;
>> > +  rte_atomic32_clear(&run_once);
>> 
>> This is not recoverable.  No amount of retry will allow the user to
>> re-init the eal - the hardware isn't supported.  Why clear the run_once
>> flag?
>> 
>> >return -1;
>> >}
>> >
>> > @@ -851,6 +852,7 @@ static void rte_eal_init_alert(const char *msg)
>> >
>> >if (rte_eal_intr_init() < 0) {
>> >rte_eal_init_alert("Cannot init interrupt-handling thread\n");
>> > +  rte_atomic32_clear(&run_once);
>> 
>> Arguable whether or not this is recoverable.  IIRC, the eal_intr_init
>> spawns a thread - if it fails to spawn the likelihood is the process
>> won't be able to continue.
>> 
>> >return -1;
>> >}
>> >
>> > @@ -861,6 +863,7 @@ static void rte_eal_init_alert(const char *msg)
>> >rte_eal_init_alert("failed to init mp channel\n");
>> >if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
>> >rte_errno = EFAULT;
>> > +  rte_atomic32_clear(&run_once);
>> 
>> This is also not recoverable.  Why clear the run_once flag?
>> 
>> >return -1;
>> >}
>> >}

Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_power: traffic pattern aware power control

[Liang, Ma]

Hi Kevin,
 Many thanks for your feedback.
 Please check my comments below. 

On 13 Sep 10:46, Kevin Traynor wrote:
> 
> Thanks for following up. It's allowing it to run without a training
> phase which is what I thought could be problematic from an application
> view, so that's nice. I'm not sure if it's much less effective without
> that training phase etc, but the comment was focused on having a forced
> training phase, so that is resolved now as it is not required.
> 
I have re-worked the patch, therefore,  the simple app will run without 
training as default option
> I'm still not sure I see the use cases for the options where there *is*
> a training type phase but it's difficult to know and considering it's
> experimental, if you feel there are some potential use cases and
> justification to add it, then fine with me.
> 
However, the Training  still is necessary. 
The mechanism need 2 anchor point. 
1.  The max empty poll the system can reach without any real traffic. 
That's is Maximum capability we use as a base line. 
2.  When the empty poll number drop to zero, that indicate the system 
is 100% busy due to always get work to do. 
3.  When the empty poll number drop to certain point(e.g. 30% of Max)
the mechanism will move to next frequency.

Without the Training phase, it's very hard to use normal traffic payload 
to get the absolute anchor point due to the traffic type, payload size, 
processor micro-arch, cache size etc, too many moving parts. 

I use default value which I think will be OK for mainstream xeon. 
if user use a very different system(e.g. arm), they still need re-run training 
phase.

the training can be triggered by a parameter option. 

> I have a few comments on the API, which I'll reply directly to the patch.
> 
> thanks,
> Kevin.
> 
> > Regards,
> > Dave.
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> 

Re: [dpdk-dev] [PATCH v7 1/4] lib/librte_power: traffic pattern aware power control

[Liang, Ma]

Hi Kevin,
   Many thanks for your comments.
   I will send v8 patch soon. 
   Please check comments below. 

On 13 Sep 11:54, Kevin Traynor wrote:
> On 09/04/2018 03:10 PM, Liang Ma wrote:
> > 1. Abstract
> > 
> 
> Hi Liang,
> 
> I didn't review the code, but some comments on API below,
> 
> > For packet processing workloads such as DPDK polling is continuous.
> > This means CPU cores always show 100% busy independent of how much work
> > those cores are doing. It is critical to accurately determine how busy
> > a core is hugely important for the following reasons:
> > 
> >* No indication of overload conditions
> > 
> >* User do not know how much real load is on a system meaning resulted in
> >  wasted energy as no power management is utilized
> > 
> > Compared to the original l3fwd-power design, instead of going to sleep
> > after detecting an empty poll, the new mechanism just lowers the core
> > frequency. As a result, the application does not stop polling the device,
> > which leads to improved handling of bursts of traffic.
> > 
> > When the system become busy, the empty poll mechanism can also increase the
> > core frequency (including turbo) to do best effort for intensive traffic.
> > This gives us more flexible and balanced traffic awareness over the
> > standard l3fwd-power application.
> > 
> > 2. Proposed solution
> > 
> > The proposed solution focuses on how many times empty polls are executed.
> > The less the number of empty polls, means current core is busy with
> > processing workload, therefore, the higher frequency is needed. The high
> > empty poll number indicates the current core not doing any real work
> > therefore, we can lower the frequency to safe power.
> > 
> > In the current implementation, each core has 1 empty-poll counter which
> > assume 1 core is dedicated to 1 queue. This will need to be expanded in the
> > future to support multiple queues per core.
> > 
> > 2.1 Power state definition:
> > 
> > LOW:  Not currently used, reserved for future use.
> > 
> > MED:  the frequency is used to process modest traffic workload.
> > 
> > HIGH: the frequency is used to process busy traffic workload.
> > 
> > 2.2 There are two phases to establish the power management system:
> > 
> > a.Initialization/Training phase. The training phase is necessary
> >   in order to figure out the system polling baseline numbers from
> >   idle to busy. The highest poll count will be during idle, where
> >   all polls are empty. These poll counts will be different between
> >   systems due to the many possible processor micro-arch, cache
> >   and device configurations, hence the training phase.
> >   In the training phase, traffic is blocked so the training
> 
> When you say 'traffic is blocked' is this something that the application
> can do through DPDK API, or you mean no external packets are sent into
> that port?a
training is disabled as default. if user enable it, that mean no external packet
are sent to the port. 

> 
> >   algorithm can average the empty-poll numbers for the LOW, MED and
> >   HIGH  power states in order to create a baseline.
> >   The core's counter are collected every 10ms, and the Training
> >phase will take 2 seconds.
> > 
> > b.Normal phase. When the training phase is complete, traffic is
> >   started. The run-time poll counts are compared with the
> >   baseline and the decision will be taken to move to MED power
> >   state or HIGH power state. The counters are calculated every 10ms.
> > 
> > 3. Proposed  API
> > 
> > 1.  rte_power_empty_poll_stat_init(void);
> > which is used to initialize the power management system.
> >  
> > 2.  rte_power_empty_poll_stat_free(void);
> > which is used to free the resource hold by power management system.
> >  
> > 3.  rte_power_empty_poll_stat_update(unsigned int lcore_id);
> > which is used to update specific core empty poll counter, not thread safe
> >  
> > 4.  rte_power_poll_stat_update(unsigned int lcore_id, uint8_t nb_pkt);
> > which is used to update specific core valid poll counter, not thread safe
> >  
> 
> is uint8_t enough to cover the max burst size for an rx poll? I didn't checka
most comment max burst size is 32. correct me if I'm wrong. 
> 
> > 5.  rte_power_empty_poll_stat_fetch(unsigned int lcore_id);
> > which is used to get specific core empty poll counter.
> >  
> > 6.  rte_power_poll_stat_fetch(unsigned int lcore_id);
> > which is used to get specific core valid poll counter.
> > 
> 
> How about replacing 1-6 with something like below..(not sure what would
> be best prefix)
> 
> rte_power_poll_stat_init(void);
> rte_power_poll_stat_free(void);
> rte_power_poll_stat_update(unsigned int lcore, uint8_t nb_pkts)
> rte_power_poll_stat_fetch(unsigned int lcore, uint8_t stat)
> 
> This would mean combining 3./4. as per previous suggestion so the
> application could just call a single function with nb_pkt (which could
> be 0). It al

Re: [dpdk-dev] [PATCH] net/ifc: do not notify before HW ready

[Ye Xiaolong]

On 09/13, Wang, Xiao W wrote:
>Hi Xiaolong,
>
>> -Original Message-
>> From: Ye, Xiaolong
>> Sent: Thursday, September 13, 2018 8:55 PM
>> To: Wang, Xiao W 
>> Cc: Bie, Tiwei ; dev@dpdk.org
>> Subject: Re: [PATCH] net/ifc: do not notify before HW ready
>> 
>> Hi, Xiao
>> 
>> On 09/10, Xiao Wang wrote:
>> >Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
>> 
>> Could you help describe what problem is without this fix in commit log?
>
>Generally a driver should finish all the device configurations first then 
>notify the HW for data processing.
>Without this fix, the potential problems are:
>1. If the device is not clearly reset by the previous driver and holds some 
>invalid ring addr, and the vDPA relay thread kicks it, a bad DMA request may 
>happen.
>2. The notify_addr which is used by the relay thread is set in the 
>vdpa_ifcvf_start function. If there's really a kick relay before 
>vdpa_ifcvf_start finishes, a null addr is accessed.
>

Thanks for the explanation.

Thanks,
Xiaolong
>Would add the description in the commit log in v2.
>
>Thanks for the comment,
>Xiao
>> 
>> Thanks,
>> Xiaolong
>> >
>> >Signed-off-by: Xiao Wang 
>> >---
>> > drivers/net/ifc/ifcvf_vdpa.c | 8 
>> > 1 file changed, 4 insertions(+), 4 deletions(-)
>> >
>> >diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c
>> >index 3c5430dc0..7d3085d8d 100644
>> >--- a/drivers/net/ifc/ifcvf_vdpa.c
>> >+++ b/drivers/net/ifc/ifcvf_vdpa.c
>> >@@ -503,11 +503,11 @@ update_datapath(struct ifcvf_internal *internal)
>> >if (ret)
>> >goto err;
>> >
>> >-   ret = setup_notify_relay(internal);
>> >+   ret = vdpa_ifcvf_start(internal);
>> >if (ret)
>> >goto err;
>> >
>> >-   ret = vdpa_ifcvf_start(internal);
>> >+   ret = setup_notify_relay(internal);
>> >if (ret)
>> >goto err;
>> >
>> >@@ -515,12 +515,12 @@ update_datapath(struct ifcvf_internal *internal)
>> >} else if (rte_atomic32_read(&internal->running) &&
>> >   (!rte_atomic32_read(&internal->started) ||
>> >!rte_atomic32_read(&internal->dev_attached))) {
>> >-   vdpa_ifcvf_stop(internal);
>> >-
>> >ret = unset_notify_relay(internal);
>> >if (ret)
>> >goto err;
>> >
>> >+   vdpa_ifcvf_stop(internal);
>> >+
>> >ret = vdpa_disable_vfio_intr(internal);
>> >if (ret)
>> >goto err;
>> >--
>> >2.15.1
>> >

[dpdk-dev] [PATCH v3 1/9] build: add Meson file for TAP PMD

[Luca Boccassi]

Use same autoconf generation mechanism as the MLX4/5 PMDs

Signed-off-by: Luca Boccassi 
---
 drivers/net/meson.build |  1 +
 drivers/net/tap/meson.build | 41 +
 2 files changed, 42 insertions(+)
 create mode 100644 drivers/net/tap/meson.build

diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index c7a2d0e7db..b7b4870eb8 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -27,6 +27,7 @@ drivers = ['af_packet',
'sfc',
'softnic',
'szedata2',
+   'tap',
'thunderx',
'vhost',
'virtio']
diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build
new file mode 100644
index 00..37f65b75c2
--- /dev/null
+++ b/drivers/net/tap/meson.build
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2018 Luca Boccassi 
+
+sources = files(
+   'rte_eth_tap.c',
+   'tap_bpf_api.c',
+   'tap_flow.c',
+   'tap_intr.c',
+   'tap_netlink.c',
+   'tap_tcmsgs.c',
+)
+
+deps = ['bus_vdev', 'gso', 'hash']
+
+cflags += '-DTAP_MAX_QUEUES=16'
+
+# To maintain the compatibility with the make build system
+# tap_autoconf.h file is still generated.
+# input array for meson symbol search:
+# [ "MACRO to define if found", "header for the search",
+#   "enum/define", "symbol to search" ]
+#
+args = [
+   [ 'HAVE_TC_FLOWER', 'linux/pkt_cls.h',
+ 'TCA_FLOWER_UNSPEC' ],
+   [ 'HAVE_TC_VLAN_ID', 'linux/pkt_cls.h',
+ 'TCA_FLOWER_KEY_VLAN_PRIO' ],
+   [ 'HAVE_TC_BPF', 'linux/pkt_cls.h',
+ 'TCA_BPF_UNSPEC' ],
+   [ 'HAVE_TC_BPF_FD', 'linux/pkt_cls.h',
+ 'TCA_BPF_FD' ],
+   [ 'HAVE_TC_ACT_BPF', 'linux/tc_act/tc_bpf.h',
+ 'TCA_ACT_BPF_UNSPEC' ],
+   [ 'HAVE_TC_ACT_BPF_FD', 'linux/tc_act/tc_bpf.h',
+ 'TCA_ACT_BPF_FD' ],
+]
+config = configuration_data()
+foreach arg:args
+   config.set(arg[0], cc.has_header_symbol(arg[1], arg[2]))
+endforeach
+configure_file(output : 'tap_autoconf.h', configuration : config)
-- 
2.18.0

[dpdk-dev] [PATCH v3 2/9] build: add Meson file for vdev_netvsc PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/net/meson.build |  1 +
 drivers/net/vdev_netvsc/meson.build | 19 +++
 2 files changed, 20 insertions(+)
 create mode 100644 drivers/net/vdev_netvsc/meson.build

diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index b7b4870eb8..68ac42d67c 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -29,6 +29,7 @@ drivers = ['af_packet',
'szedata2',
'tap',
'thunderx',
+   'vdev_netvsc',
'vhost',
'virtio']
 std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc
diff --git a/drivers/net/vdev_netvsc/meson.build 
b/drivers/net/vdev_netvsc/meson.build
new file mode 100644
index 00..cc956e7b27
--- /dev/null
+++ b/drivers/net/vdev_netvsc/meson.build
@@ -0,0 +1,19 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+sources = files('vdev_netvsc.c')
+
+allow_experimental_apis = true
+
+cflags_options = [
+'-Wall',
+'-Wextra',
+'-D_BSD_SOURCE',
+'-D_DEFAULT_SOURCE',
+'-D_XOPEN_SOURCE=600'
+]
+foreach option:cflags_options
+if cc.has_argument(option)
+cflags += option
+endif
+endforeach
-- 
2.18.0

[dpdk-dev] [PATCH v3 3/9] build: add Meson file for crypto scheduler PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/crypto/meson.build   |  2 +-
 drivers/crypto/scheduler/meson.build | 19 +++
 2 files changed, 20 insertions(+), 1 deletion(-)
 create mode 100644 drivers/crypto/scheduler/meson.build

diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index d64ca418bc..6ed853b7ab 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -2,7 +2,7 @@
 # Copyright(c) 2017 Intel Corporation
 
 drivers = ['ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
-   'null', 'openssl', 'qat', 'virtio']
+   'null', 'openssl', 'qat', 'scheduler', 'virtio']
 
 std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
 config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
diff --git a/drivers/crypto/scheduler/meson.build 
b/drivers/crypto/scheduler/meson.build
new file mode 100644
index 00..c5ba2d6804
--- /dev/null
+++ b/drivers/crypto/scheduler/meson.build
@@ -0,0 +1,19 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+deps += ['bus_vdev', 'reorder']
+name = 'crypto_scheduler'
+sources = files(
+   'rte_cryptodev_scheduler.c',
+   'scheduler_failover.c',
+   'scheduler_multicore.c',
+   'scheduler_pkt_size_distr.c',
+   'scheduler_pmd.c',
+   'scheduler_pmd_ops.c',
+   'scheduler_roundrobin.c',
+)
+
+headers = files(
+   'rte_cryptodev_scheduler.h',
+   'rte_cryptodev_scheduler_operations.h',
+)
-- 
2.18.0

[dpdk-dev] [PATCH v3 4/9] build: add Meson files for avf PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/net/avf/base/meson.build | 20 
 drivers/net/avf/meson.build  | 15 +++
 drivers/net/meson.build  |  1 +
 3 files changed, 36 insertions(+)
 create mode 100644 drivers/net/avf/base/meson.build
 create mode 100644 drivers/net/avf/meson.build

diff --git a/drivers/net/avf/base/meson.build b/drivers/net/avf/base/meson.build
new file mode 100644
index 00..90fd6b445f
--- /dev/null
+++ b/drivers/net/avf/base/meson.build
@@ -0,0 +1,20 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+sources = [
+   'avf_adminq.c',
+   'avf_common.c',
+]
+
+error_cflags = ['-Wno-pointer-to-int-cast']
+c_args = cflags
+foreach flag: error_cflags
+   if cc.has_argument(flag)
+   c_args += flag
+   endif
+endforeach
+
+base_lib = static_library('avf_base', sources,
+   dependencies: static_rte_eal,
+   c_args: c_args)
+base_objs = base_lib.extract_all_objects()
diff --git a/drivers/net/avf/meson.build b/drivers/net/avf/meson.build
new file mode 100644
index 00..d341f029b2
--- /dev/null
+++ b/drivers/net/avf/meson.build
@@ -0,0 +1,15 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+subdir('base')
+objs = [base_objs]
+
+sources = files(
+   'avf_ethdev.c',
+   'avf_rxtx.c',
+   'avf_rxtx_vec_sse.c',
+   'avf_vchnl.c',
+)
+if arch_subdir == 'x86'
+   sources += files('avf_rxtx_vec_sse.c')
+endif
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 68ac42d67c..28efeda0b6 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -3,6 +3,7 @@
 
 drivers = ['af_packet',
'ark',
+   'avf',
'avp',
'axgbe', 'bonding',
'bnx2x',
-- 
2.18.0

[dpdk-dev] [PATCH v3 6/9] build: add Meson file for bbdev_null PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/baseband/meson.build  | 7 +++
 drivers/baseband/null/meson.build | 7 +++
 drivers/meson.build   | 1 +
 3 files changed, 15 insertions(+)
 create mode 100644 drivers/baseband/meson.build
 create mode 100644 drivers/baseband/null/meson.build

diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
new file mode 100644
index 00..52489df354
--- /dev/null
+++ b/drivers/baseband/meson.build
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+drivers = ['null']
+
+config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
+driver_name_fmt = 'rte_pmd_@0@'
diff --git a/drivers/baseband/null/meson.build 
b/drivers/baseband/null/meson.build
new file mode 100644
index 00..64c29d8600
--- /dev/null
+++ b/drivers/baseband/null/meson.build
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+deps += ['bbdev', 'bus_vdev', 'ring']
+name = 'bbdev_null'
+allow_experimental_apis = true
+sources = files('bbdev_null.c')
diff --git a/drivers/meson.build b/drivers/meson.build
index f94e2fe672..14e335ec1d 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -9,6 +9,7 @@ driver_classes = ['common',
   'crypto',  # depends on common, bus and mempool (net in future).
   'compress', # depends on common, bus, mempool.
   'event',   # depends on common, bus, mempool and net.
+  'baseband', # depends on common and bus.
   'raw'] # depends on common, bus, mempool, net and event.
 
 default_cflags = machine_args
-- 
2.18.0

[dpdk-dev] [PATCH v3 7/9] event/opdl: rename map file to match library name

[Luca Boccassi]

So that it can be used from Meson as well

Signed-off-by: Luca Boccassi 
---
 drivers/event/opdl/Makefile | 2 +-
 ...md_evdev_opdl_version.map => rte_pmd_opdl_event_version.map} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/event/opdl/{rte_pmd_evdev_opdl_version.map => 
rte_pmd_opdl_event_version.map} (100%)

diff --git a/drivers/event/opdl/Makefile b/drivers/event/opdl/Makefile
index cea8118d36..bf50a60a0b 100644
--- a/drivers/event/opdl/Makefile
+++ b/drivers/event/opdl/Makefile
@@ -24,7 +24,7 @@ LDLIBS += -lrte_bus_vdev -lrte_mbuf -lrte_mempool
 LIBABIVER := 1
 
 # versioning export map
-EXPORT_MAP := rte_pmd_evdev_opdl_version.map
+EXPORT_MAP := rte_pmd_opdl_event_version.map
 
 # library source files
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV) += opdl_ring.c
diff --git a/drivers/event/opdl/rte_pmd_evdev_opdl_version.map 
b/drivers/event/opdl/rte_pmd_opdl_event_version.map
similarity index 100%
rename from drivers/event/opdl/rte_pmd_evdev_opdl_version.map
rename to drivers/event/opdl/rte_pmd_opdl_event_version.map
-- 
2.18.0

[dpdk-dev] [PATCH v3 8/9] build: add Meson file for opdl_event PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/event/meson.build  |  2 +-
 drivers/event/opdl/meson.build | 11 +++
 2 files changed, 12 insertions(+), 1 deletion(-)
 create mode 100644 drivers/event/opdl/meson.build

diff --git a/drivers/event/meson.build b/drivers/event/meson.build
index e951199358..ed56d20062 100644
--- a/drivers/event/meson.build
+++ b/drivers/event/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-drivers = ['dpaa', 'dpaa2', 'octeontx', 'skeleton', 'sw']
+drivers = ['dpaa', 'dpaa2', 'octeontx', 'opdl', 'skeleton', 'sw']
 std_deps = ['eventdev', 'kvargs']
 config_flag_fmt = 'RTE_LIBRTE_@0@_EVENTDEV_PMD'
 driver_name_fmt = 'rte_pmd_@0@_event'
diff --git a/drivers/event/opdl/meson.build b/drivers/event/opdl/meson.build
new file mode 100644
index 00..cc6029c6f0
--- /dev/null
+++ b/drivers/event/opdl/meson.build
@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+sources = files(
+   'opdl_evdev.c',
+   'opdl_evdev_init.c',
+   'opdl_evdev_xstats.c',
+   'opdl_ring.c',
+   'opdl_test.c',
+)
+deps += ['bus_vdev']
-- 
2.18.0

[dpdk-dev] [PATCH v3 5/9] build: add Meson files for qede PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
Acked-by: Shahed Shaikh 
---
 config/rte_config.h   |  3 ++
 drivers/net/meson.build   |  2 +-
 drivers/net/qede/base/meson.build | 57 +++
 drivers/net/qede/meson.build  | 12 +++
 4 files changed, 73 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/qede/base/meson.build
 create mode 100644 drivers/net/qede/meson.build

diff --git a/config/rte_config.h b/config/rte_config.h
index 46775a8419..ee84f04977 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -116,4 +116,7 @@
 #define RTE_PMD_RING_MAX_RX_RINGS 16
 #define RTE_PMD_RING_MAX_TX_RINGS 16
 
+/* QEDE PMD defines */
+#define RTE_LIBRTE_QEDE_FW ""
+
 #endif /* _RTE_CONFIG_H_ */
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 28efeda0b6..74f4109161 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -24,7 +24,7 @@ drivers = ['af_packet',
'mvpp2',
'netvsc',
'nfp',
-   'null', 'octeontx', 'pcap', 'ring',
+   'null', 'octeontx', 'pcap', 'qede', 'ring',
'sfc',
'softnic',
'szedata2',
diff --git a/drivers/net/qede/base/meson.build 
b/drivers/net/qede/base/meson.build
new file mode 100644
index 00..59b41c895d
--- /dev/null
+++ b/drivers/net/qede/base/meson.build
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+sources = [
+   'bcm_osal.c',
+   'ecore_cxt.c',
+   'ecore_dcbx.c',
+   'ecore_dev.c',
+   'ecore_hw.c',
+   'ecore_init_fw_funcs.c',
+   'ecore_init_ops.c',
+   'ecore_int.c',
+   'ecore_l2.c',
+   'ecore_mcp.c',
+   'ecore_sp_commands.c',
+   'ecore_spq.c',
+   'ecore_sriov.c',
+   'ecore_vf.c',
+]
+
+
+error_cflags = [
+   '-Wno-unused-parameter',
+   '-Wno-sign-compare',
+   '-Wno-missing-prototypes',
+   '-Wno-cast-qual',
+   '-Wno-unused-function',
+   '-Wno-unused-variable',
+   '-Wno-strict-aliasing',
+   '-Wno-missing-prototypes',
+   '-Wno-unused-value',
+   '-Wno-format-nonliteral',
+   '-Wno-shift-negative-value',
+   '-Wno-unused-but-set-variable',
+   '-Wno-missing-declarations',
+   '-Wno-maybe-uninitialized',
+   '-Wno-strict-prototypes',
+   '-Wno-shift-negative-value',
+   '-Wno-implicit-fallthrough',
+   '-Wno-format-extra-args',
+   '-Wno-visibility',
+   '-Wno-empty-body',
+   '-Wno-invalid-source-encoding',
+   '-Wno-sometimes-uninitialized',
+   '-Wno-pointer-bool-conversion',
+]
+c_args = cflags
+foreach flag: error_cflags
+if cc.has_argument(flag)
+c_args += flag
+endif
+endforeach
+
+base_lib = static_library('qede_base', sources,
+   dependencies: static_rte_net,
+   c_args: c_args)
+base_objs = base_lib.extract_all_objects()
diff --git a/drivers/net/qede/meson.build b/drivers/net/qede/meson.build
new file mode 100644
index 00..6280073a56
--- /dev/null
+++ b/drivers/net/qede/meson.build
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+subdir('base')
+objs = [base_objs]
+
+sources = files(
+   'qede_ethdev.c',
+   'qede_fdir.c',
+   'qede_main.c',
+   'qede_rxtx.c',
+)
-- 
2.18.0

Re: [dpdk-dev] [PATCH] doc/fix: add CCM to the QAT feature list

[Kovacevic, Marko]

> Signed-off-by: Tomasz Cel 
> ---
>  doc/guides/cryptodevs/features/qat.ini | 3 +++
>  doc/guides/cryptodevs/qat.rst  | 1 +
>  2 files changed, 4 insertions(+)


Hi Tomasz,

 I think the patch is ok there is just a few things as this is a fix you need 
to add a fixes
tag into the commit message here is a reference to the guides for it.
https://doc.dpdk.org/guides/contributing/patches.html?highlight=commit%20message

Excepted output:
-
doc: fix some parameter description

Update the docs, fixing description of some parameter.

Fixes: abcdefgh1234 ("doc: add some parameter")
Cc: aut...@example.com

Signed-off-by: Alex Smith 
---

Other thing is try and keep the sizes in order

 +AES CCM (128) = Y   > +AES CCM (128) = Y   
 +AES CCM (256) = Y   > +AES CCM (192) = Y
 +AES CCM (192) = Y   > +AES CCM (256) = Y



Marko K.


 

[dpdk-dev] [PATCH v3 9/9] build: add Meson file for vmxnet3_uio PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/net/meson.build |  4 +++-
 drivers/net/vmxnet3/meson.build | 18 ++
 2 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/vmxnet3/meson.build

diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 74f4109161..5906283c2f 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -32,7 +32,9 @@ drivers = ['af_packet',
'thunderx',
'vdev_netvsc',
'vhost',
-   'virtio']
+   'virtio',
+   'vmxnet3',
+]
 std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc
 std_deps += ['bus_pci'] # very many PMDs depend on PCI, so make std
 std_deps += ['bus_vdev']# same with vdev bus
diff --git a/drivers/net/vmxnet3/meson.build b/drivers/net/vmxnet3/meson.build
new file mode 100644
index 00..a92bd28680
--- /dev/null
+++ b/drivers/net/vmxnet3/meson.build
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+allow_experimental_apis = true
+sources += files(
+   'vmxnet3_ethdev.c',
+   'vmxnet3_rxtx.c',
+)
+
+error_cflags = [
+   '-Wno-unused-parameter', '-Wno-unused-value',
+'-Wno-strict-aliasing', '-Wno-format-extra-args',
+]
+foreach flag: error_cflags
+if cc.has_argument(flag)
+cflags += flag
+endif
+endforeach
-- 
2.18.0

[dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support

[Jerin Jacob]

Signed-off-by: Jerin Jacob 
---
 app/test-pmd/config.c  | 9 +
 doc/guides/nics/features.rst   | 4 ++--
 lib/librte_ethdev/rte_ethdev.c | 1 +
 lib/librte_ethdev/rte_ethdev.h | 1 +
 4 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 14ccd6864..c4ed8d474 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -576,6 +576,15 @@ port_offload_cap_display(portid_t port_id)
printf("off\n");
}
 
+   if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_SCTP_CKSUM) {
+   printf("RX SCTP checksum:   ");
+   if (ports[port_id].dev_conf.rxmode.offloads &
+   DEV_RX_OFFLOAD_SCTP_CKSUM)
+   printf("on\n");
+   else
+   printf("off\n");
+   }
+
if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM) {
printf("RX Outer IPv4 checksum:   ");
if (ports[port_id].dev_conf.rxmode.offloads &
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index cddc877d4..a98356a16 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -575,7 +575,7 @@ L4 checksum offload
 
 Supports L4 checksum offload.
 
-* **[uses] rte_eth_rxconf,rte_eth_rxmode**: 
``offloads:DEV_RX_OFFLOAD_UDP_CKSUM,DEV_RX_OFFLOAD_TCP_CKSUM``.
+* **[uses] rte_eth_rxconf,rte_eth_rxmode**: 
``offloads:DEV_RX_OFFLOAD_UDP_CKSUM,DEV_RX_OFFLOAD_TCP_CKSUM,DEV_RX_OFFLOAD_SCTP_CKSUM``.
 * **[uses] rte_eth_txconf,rte_eth_txmode**: 
``offloads:DEV_TX_OFFLOAD_UDP_CKSUM,DEV_TX_OFFLOAD_TCP_CKSUM,DEV_TX_OFFLOAD_SCTP_CKSUM``.
 * **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``,
   ``mbuf.ol_flags:PKT_TX_L4_NO_CKSUM`` | ``PKT_TX_TCP_CKSUM`` |
@@ -583,7 +583,7 @@ Supports L4 checksum offload.
 * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_L4_CKSUM_UNKNOWN`` |
   ``PKT_RX_L4_CKSUM_BAD`` | ``PKT_RX_L4_CKSUM_GOOD`` |
   ``PKT_RX_L4_CKSUM_NONE``.
-* **[provides] rte_eth_dev_info**: 
``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_UDP_CKSUM,DEV_RX_OFFLOAD_TCP_CKSUM``,
+* **[provides] rte_eth_dev_info**: 
``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_UDP_CKSUM,DEV_RX_OFFLOAD_TCP_CKSUM,DEV_RX_OFFLOAD_SCTP_CKSUM``,
   
``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_UDP_CKSUM,DEV_TX_OFFLOAD_TCP_CKSUM,DEV_TX_OFFLOAD_SCTP_CKSUM``.
 
 .. _nic_features_hw_timestamp:
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 4c3202505..d91870e90 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -127,6 +127,7 @@ static const struct {
RTE_RX_OFFLOAD_BIT2STR(TIMESTAMP),
RTE_RX_OFFLOAD_BIT2STR(SECURITY),
RTE_RX_OFFLOAD_BIT2STR(KEEP_CRC),
+   RTE_RX_OFFLOAD_BIT2STR(SCTP_CKSUM),
 };
 
 #undef RTE_RX_OFFLOAD_BIT2STR
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 7070e9ab4..adbe936a4 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -900,6 +900,7 @@ struct rte_eth_conf {
  * No DEV_RX_OFFLOAD_CRC_STRIP flag means keep CRC
  */
 #define DEV_RX_OFFLOAD_KEEP_CRC0x0001
+#define DEV_RX_OFFLOAD_SCTP_CKSUM  0x0002
 #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \
 DEV_RX_OFFLOAD_UDP_CKSUM | \
 DEV_RX_OFFLOAD_TCP_CKSUM)
-- 
2.19.0

[dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask

[Jerin Jacob]

Fixes missing PKT_TX_UDP_SEG value in PKT_TX_OFFLOAD_MASK.

Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload")
Cc: sta...@dpdk.org
Cc: jiayu...@intel.com

Signed-off-by: Jerin Jacob 
---
 lib/librte_mbuf/rte_mbuf.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 9ce5d76d7..6a5dbbc8f 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -343,7 +343,8 @@ extern "C" {
PKT_TX_VLAN_PKT |\
PKT_TX_TUNNEL_MASK | \
PKT_TX_MACSEC |  \
-   PKT_TX_SEC_OFFLOAD)
+   PKT_TX_SEC_OFFLOAD |\
+   PKT_TX_UDP_SEG)
 
 /**
  * Mbuf having an external buffer attached. shinfo in mbuf must be filled.
-- 
2.19.0

[dpdk-dev] [PATCH 3/4] ethdev: add Rx offload outer L4 checksum definitions

[Jerin Jacob]

Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM, DEV_RX_OFFLOAD_OUTER_TCP_CKSUM
and DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM offload flags and

PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to enable outer Rx L4 checksum
offload.

# To use hardware Rx outer L4 checksum offload, the user needs to
configure DEV_RX_OFFLOAD_OUTER_* offload flags in slowpath.

# Driver updates the PKT_RX_EL4_CKSUM_BAD mbuf ol_flag on checksum failure
similar to the outer L3 PKT_RX_EIP_CKSUM_BAD flag.

Signed-off-by: Jerin Jacob 
---
 app/test-pmd/config.c  | 27 +++
 doc/guides/nics/features.rst   |  3 +++
 lib/librte_ethdev/rte_ethdev.c |  3 +++
 lib/librte_ethdev/rte_ethdev.h |  9 +
 lib/librte_mbuf/rte_mbuf.c |  2 ++
 lib/librte_mbuf/rte_mbuf.h |  3 +++
 6 files changed, 47 insertions(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index c4ed8d474..92a177e29 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -594,6 +594,33 @@ port_offload_cap_display(portid_t port_id)
printf("off\n");
}
 
+   if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_OUTER_UDP_CKSUM) {
+   printf("RX Outer UDP checksum:   ");
+   if (ports[port_id].dev_conf.rxmode.offloads &
+   DEV_RX_OFFLOAD_OUTER_UDP_CKSUM)
+   printf("on\n");
+   else
+   printf("off\n");
+   }
+
+   if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_OUTER_TCP_CKSUM) {
+   printf("RX Outer TCP checksum:   ");
+   if (ports[port_id].dev_conf.rxmode.offloads &
+   DEV_RX_OFFLOAD_OUTER_TCP_CKSUM)
+   printf("on\n");
+   else
+   printf("off\n");
+   }
+
+   if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM) {
+   printf("RX Outer SCTP checksum:   ");
+   if (ports[port_id].dev_conf.rxmode.offloads &
+   DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM)
+   printf("on\n");
+   else
+   printf("off\n");
+   }
+
if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TCP_LRO) {
printf("Large receive offload: ");
if (ports[port_id].dev_conf.rxmode.offloads &
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index a98356a16..68420d196 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -638,6 +638,9 @@ Inner L4 checksum
 
 Supports inner packet L4 checksum.
 
+* **[uses] rte_eth_rxconf,rte_eth_rxmode**: 
``offloads:DEV_RX_OFFLOAD_OUTER_UDP_CKSUM,DEV_RX_OFFLOAD_OUTER_TCP_CKSUM,DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM``.
+* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_EL4_CKSUM_BAD``.
+* **[provides] rte_eth_dev_info**: 
``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_OUTER_UDP_CKSUM,DEV_RX_OFFLOAD_OUTER_TCP_CKSUM,DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM``,
 
 .. _nic_features_packet_type_parsing:
 
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index d91870e90..547132a8c 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -128,6 +128,9 @@ static const struct {
RTE_RX_OFFLOAD_BIT2STR(SECURITY),
RTE_RX_OFFLOAD_BIT2STR(KEEP_CRC),
RTE_RX_OFFLOAD_BIT2STR(SCTP_CKSUM),
+   RTE_RX_OFFLOAD_BIT2STR(OUTER_UDP_CKSUM),
+   RTE_RX_OFFLOAD_BIT2STR(OUTER_TCP_CKSUM),
+   RTE_RX_OFFLOAD_BIT2STR(OUTER_SCTP_CKSUM),
 };
 
 #undef RTE_RX_OFFLOAD_BIT2STR
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index adbe936a4..4665bd6f7 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -901,6 +901,10 @@ struct rte_eth_conf {
  */
 #define DEV_RX_OFFLOAD_KEEP_CRC0x0001
 #define DEV_RX_OFFLOAD_SCTP_CKSUM  0x0002
+#define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x0004
+#define DEV_RX_OFFLOAD_OUTER_TCP_CKSUM 0x0008
+#define DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM0x0010
+
 #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \
 DEV_RX_OFFLOAD_UDP_CKSUM | \
 DEV_RX_OFFLOAD_TCP_CKSUM)
@@ -908,6 +912,11 @@ struct rte_eth_conf {
 DEV_RX_OFFLOAD_VLAN_FILTER | \
 DEV_RX_OFFLOAD_VLAN_EXTEND)
 
+#define DEV_RX_OFFLOAD_OUTER_CHECKSUM (DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | \
+   DEV_RX_OFFLOAD_OUTER_UDP_CKSUM | \
+   DEV_RX_OFFLOAD_OUTER_TCP_CKSUM | \
+   DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM)
+
 /*
  * If new Rx offload capabilities are defined, they also must be
  * mentioned in rte_rx_offload_names in rte_ethdev.c file.
diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
index e714c5a59..022e92b3c 100644
--- a/lib/librte_mbuf/rte_mbuf.c
+++ b/lib/libr

[dpdk-dev] [PATCH 4/4] ethdev: add Tx offload outer L4 checksum definitions

[Jerin Jacob]

Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM, DEV_TX_OFFLOAD_OUTER_TCP_CKSUM
and DEV_TX_OFFLOAD_OUTER_SCTP_CKSUM offload flags and

PKT_TX_OUTER_L4_NO_CKSUM, PKT_TX_OUTER_TCP_CKSUM, PKT_TX_OUTER_SCTP_CKSUM
and PKT_TX_OUTER_UDP_CKSUM mbuf ol_flags to enable Tx outer L4 checksum
offload.

To use hardware Tx outer L4 checksum offload, the user needs to.
# enable following in mbuff:
- fill outer_l2_len and outer_l3_len in mbuf
- set the flags PKT_TX_OUTER_TCP_CKSUM, PKT_TX_OUTER_SCTP_CKSUM or
PKT_TX_OUTER_UDP_CKSUM
- set the flag PKT_TX_OUTER_IPV4 or PKT_TX_OUTER_IPV6

# configure DEV_TX_OFFLOAD_OUTER_* offload flags in slow path.

Signed-off-by: Jerin Jacob 
---
 app/test-pmd/config.c  | 27 +++
 doc/guides/nics/features.rst   |  6 ++
 lib/librte_ethdev/rte_ethdev.c |  3 +++
 lib/librte_ethdev/rte_ethdev.h |  6 ++
 lib/librte_mbuf/rte_mbuf.c |  5 +
 lib/librte_mbuf/rte_mbuf.h | 23 ++-
 6 files changed, 69 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 92a177e29..85f832bf0 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -773,6 +773,33 @@ port_offload_cap_display(portid_t port_id)
else
printf("off\n");
}
+
+   if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) {
+   printf("TX Outer UDP checksum:   ");
+   if (ports[port_id].dev_conf.txmode.offloads &
+   DEV_TX_OFFLOAD_OUTER_UDP_CKSUM)
+   printf("on\n");
+   else
+   printf("off\n");
+   }
+
+   if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_OUTER_TCP_CKSUM) {
+   printf("TX Outer TCP checksum:   ");
+   if (ports[port_id].dev_conf.txmode.offloads &
+   DEV_TX_OFFLOAD_OUTER_TCP_CKSUM)
+   printf("on\n");
+   else
+   printf("off\n");
+   }
+
+   if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_OUTER_SCTP_CKSUM) {
+   printf("TX Outer SCTP checksum:   ");
+   if (ports[port_id].dev_conf.txmode.offloads &
+   DEV_TX_OFFLOAD_OUTER_SCTP_CKSUM)
+   printf("on\n");
+   else
+   printf("off\n");
+   }
 }
 
 int
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 68420d196..884dbd7a5 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -639,8 +639,14 @@ Inner L4 checksum
 Supports inner packet L4 checksum.
 
 * **[uses] rte_eth_rxconf,rte_eth_rxmode**: 
``offloads:DEV_RX_OFFLOAD_OUTER_UDP_CKSUM,DEV_RX_OFFLOAD_OUTER_TCP_CKSUM,DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM``.
+* **[uses] rte_eth_txconf,rte_eth_txmode**: 
``offloads:DEV_TX_OFFLOAD_OUTER_UDP_CKSUM,DEV_TX_OFFLOAD_OUTER_TCP_CKSUM,DEV_TX_OFFLOAD_OUTER_SCTP_CKSUM``.
+* **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_OUTER_IPV4`` | 
``PKT_TX_OUTER_IPV6``.
+  ``mbuf.ol_flags:PKT_TX_OUTER_L4_NO_CKSUM`` | ``PKT_TX_OUTER_TCP_CKSUM`` |
+  ``PKT_TX_OUTER_SCTP_CKSUM`` | ``PKT_TX_OUTER_UDP_CKSUM``.
+* **[uses] mbuf**: ``mbuf.outer_l2_len``, ``mbuf.outer_l3_len``.
 * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_EL4_CKSUM_BAD``.
 * **[provides] rte_eth_dev_info**: 
``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_OUTER_UDP_CKSUM,DEV_RX_OFFLOAD_OUTER_TCP_CKSUM,DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM``,
+  
``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_OUTER_UDP_CKSUM,DEV_TX_OFFLOAD_OUTER_TCP_CKSUM,DEV_TX_OFFLOAD_OUTER_SCTP_CKSUM``.
 
 .. _nic_features_packet_type_parsing:
 
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 547132a8c..6cc5ad055 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -160,6 +160,9 @@ static const struct {
RTE_TX_OFFLOAD_BIT2STR(MULTI_SEGS),
RTE_TX_OFFLOAD_BIT2STR(MBUF_FAST_FREE),
RTE_TX_OFFLOAD_BIT2STR(SECURITY),
+   RTE_TX_OFFLOAD_BIT2STR(OUTER_UDP_CKSUM),
+   RTE_TX_OFFLOAD_BIT2STR(OUTER_TCP_CKSUM),
+   RTE_TX_OFFLOAD_BIT2STR(OUTER_SCTP_CKSUM),
 };
 
 #undef RTE_TX_OFFLOAD_BIT2STR
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 4665bd6f7..a5b33a27f 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -963,6 +963,12 @@ struct rte_eth_conf {
  * for tunnel TSO.
  */
 #define DEV_TX_OFFLOAD_IP_TNL_TSO   0x0008
+/** Device supports outer UDP checksum */
+#define DEV_TX_OFFLOAD_OUTER_UDP_CKSUM  0x0010
+/** Device supports outer TCP checksum */
+#define DEV_TX_OFFLOAD_OUTER_TCP_CKSUM  0x0020
+/** Device supports outer SCTP checksum */
+#define DEV_TX_OFFLOAD_OUTER_SCTP_CKSUM 0x0040
 
 #define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x0001
 /**< Device supports Rx queue setup after device started*/
diff --git a/lib/librte_mbuf/rte_mbuf.c b/li

Re: [dpdk-dev] [PATCH] net/ifc: add live migration support

[Ye Xiaolong]

Reviewed-and-Tested-by: Ye Xiaolong 

Thanks,
Xiaolong

On 09/10, Xiao Wang wrote:
>IFCVF can help to log dirty page in live migration stage,
>each queue's index can be read and configured to support
>VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_VRING_BASE.
>
>Signed-off-by: Xiao Wang 
>---
> drivers/net/ifc/base/ifcvf.c | 33 +++-
> drivers/net/ifc/base/ifcvf.h |  7 +
> drivers/net/ifc/ifcvf_vdpa.c | 71 ++--
> 3 files changed, 108 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/net/ifc/base/ifcvf.c b/drivers/net/ifc/base/ifcvf.c
>index 4b22d9ed1..3c0b2dff6 100644
>--- a/drivers/net/ifc/base/ifcvf.c
>+++ b/drivers/net/ifc/base/ifcvf.c
>@@ -249,7 +249,7 @@ ifcvf_hw_disable(struct ifcvf_hw *hw)
>   IFCVF_WRITE_REG16(IFCVF_MSI_NO_VECTOR, &cfg->queue_msix_vector);
>   ring_state = *(u32 *)(hw->lm_cfg + IFCVF_LM_RING_STATE_OFFSET +
>   (i / 2) * IFCVF_LM_CFG_SIZE + (i % 2) * 4);
>-  hw->vring[i].last_avail_idx = (u16)ring_state;
>+  hw->vring[i].last_avail_idx = (u16)(ring_state >> 16);
>   hw->vring[i].last_used_idx = (u16)(ring_state >> 16);
>   }
> }
>@@ -278,6 +278,37 @@ ifcvf_stop_hw(struct ifcvf_hw *hw)
>   ifcvf_reset(hw);
> }
> 
>+void
>+ifcvf_enable_logging(struct ifcvf_hw *hw, u64 log_base, u64 log_size)
>+{
>+  u8 *lm_cfg;
>+
>+  lm_cfg = hw->lm_cfg;
>+
>+  *(u32 *)(lm_cfg + IFCVF_LM_BASE_ADDR_LOW) =
>+  log_base & IFCVF_32_BIT_MASK;
>+
>+  *(u32 *)(lm_cfg + IFCVF_LM_BASE_ADDR_HIGH) =
>+  (log_base >> 32) & IFCVF_32_BIT_MASK;
>+
>+  *(u32 *)(lm_cfg + IFCVF_LM_END_ADDR_LOW) =
>+  (log_base + log_size) & IFCVF_32_BIT_MASK;
>+
>+  *(u32 *)(lm_cfg + IFCVF_LM_END_ADDR_HIGH) =
>+  ((log_base + log_size) >> 32) & IFCVF_32_BIT_MASK;
>+
>+  *(u32 *)(lm_cfg + IFCVF_LM_LOGGING_CTRL) = IFCVF_LM_ENABLE_VF;
>+}
>+
>+void
>+ifcvf_disable_logging(struct ifcvf_hw *hw)
>+{
>+  u8 *lm_cfg;
>+
>+  lm_cfg = hw->lm_cfg;
>+  *(u32 *)(lm_cfg + IFCVF_LM_LOGGING_CTRL) = IFCVF_LM_DISABLE;
>+}
>+
> void
> ifcvf_notify_queue(struct ifcvf_hw *hw, u16 qid)
> {
>diff --git a/drivers/net/ifc/base/ifcvf.h b/drivers/net/ifc/base/ifcvf.h
>index badacb615..f026c70ab 100644
>--- a/drivers/net/ifc/base/ifcvf.h
>+++ b/drivers/net/ifc/base/ifcvf.h
>@@ -49,6 +49,7 @@
> #define IFCVF_LM_DISABLE  0x0
> #define IFCVF_LM_ENABLE_VF0x1
> #define IFCVF_LM_ENABLE_PF0x3
>+#define IFCVF_LOG_BASE0x1000
> 
> #define IFCVF_32_BIT_MASK 0x
> 
>@@ -142,6 +143,12 @@ ifcvf_start_hw(struct ifcvf_hw *hw);
> void
> ifcvf_stop_hw(struct ifcvf_hw *hw);
> 
>+void
>+ifcvf_enable_logging(struct ifcvf_hw *hw, u64 log_base, u64 log_size);
>+
>+void
>+ifcvf_disable_logging(struct ifcvf_hw *hw);
>+
> void
> ifcvf_notify_queue(struct ifcvf_hw *hw, u16 qid);
> 
>diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c
>index 88d814037..3c5430dc0 100644
>--- a/drivers/net/ifc/ifcvf_vdpa.c
>+++ b/drivers/net/ifc/ifcvf_vdpa.c
>@@ -7,6 +7,7 @@
> #include 
> #include 
> #include 
>+#include 
> 
> #include 
> #include 
>@@ -276,12 +277,30 @@ vdpa_ifcvf_start(struct ifcvf_internal *internal)
>   return ifcvf_start_hw(&internal->hw);
> }
> 
>+static void
>+ifcvf_used_ring_log(struct ifcvf_hw *hw, uint32_t queue, uint8_t *log_buf)
>+{
>+  uint32_t i, size;
>+  uint64_t pfn;
>+
>+  pfn = hw->vring[queue].used / PAGE_SIZE;
>+  size = hw->vring[queue].size * sizeof(struct vring_used_elem) +
>+  sizeof(__virtio16) * 3;
>+
>+  for (i = 0; i <= size / PAGE_SIZE; i++)
>+  __sync_fetch_and_or_8(&log_buf[(pfn + i) / 8],
>+  1 << ((pfn + i) % 8));
>+}
>+
> static void
> vdpa_ifcvf_stop(struct ifcvf_internal *internal)
> {
>   struct ifcvf_hw *hw = &internal->hw;
>   uint32_t i;
>   int vid;
>+  uint64_t features;
>+  uint64_t log_base, log_size;
>+  uint8_t *log_buf;
> 
>   vid = internal->vid;
>   ifcvf_stop_hw(hw);
>@@ -289,6 +308,21 @@ vdpa_ifcvf_stop(struct ifcvf_internal *internal)
>   for (i = 0; i < hw->nr_vring; i++)
>   rte_vhost_set_vring_base(vid, i, hw->vring[i].last_avail_idx,
>   hw->vring[i].last_used_idx);
>+
>+  rte_vhost_get_negotiated_features(vid, &features);
>+  if (RTE_VHOST_NEED_LOG(features)) {
>+  ifcvf_disable_logging(hw);
>+  rte_vhost_get_log_base(internal->vid, &log_base, &log_size);
>+  rte_vfio_container_dma_unmap(internal->vfio_container_fd,
>+  log_base, IFCVF_LOG_BASE, log_size);
>+  /*
>+   * IFCVF marks dirty memory pages for only packet buffer,
>+   * SW helps to mark the used ring as dirty after device stops.
>+   */
>+  

Re: [dpdk-dev] [PATCH 0/4] net/cxgbe: add destination MAC match and VLAN rewrite support for flow API

[Ferruh Yigit]

On 8/27/2018 1:52 PM, Rahul Lakkireddy wrote:
> This series of patches add support to offload flows with destination MAC
> match item and VLAN push/pop/rewrite actions.
> 
> Patch 1 adds API to program and manage hardware Layer 2 Table (L2T).
> L2T holds destination node information to be used for VLAN rewrite.
> 
> Patch 2 implements offloading VLAN push/pop/rewrite actions.
> 
> Patch 3 adds API to program and manage hardware Multi Port Switch (MPS)
> table. MPS holds the destination MAC addresses to be matched against
> incoming packets.
> 
> Patch 4 implements offloading destination MAC match item.
> 
> Thanks,
> Rahul
> 
> Shagun Agrawal (4):
>   net/cxgbe: add API to program hardware layer 2 table
>   net/cxgbe: add flow operations to offload vlan actions
>   net/cxgbe: add API to program hardware MPS table
>   net/cxgbe: add flow operations to match based on destination MAC
> address

Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v7 1/4] lib/librte_power: traffic pattern aware power control

[Hunt, David]

On 13/9/2018 2:37 PM, Liang, Ma wrote:

Hi Kevin,
Many thanks for your comments.
I will send v8 patch soon.
Please check comments below.

On 13 Sep 11:54, Kevin Traynor wrote:

On 09/04/2018 03:10 PM, Liang Ma wrote:


--snip--


HIGH: the frequency is used to process busy traffic workload.

2.2 There are two phases to establish the power management system:

a.Initialization/Training phase. The training phase is necessary
  in order to figure out the system polling baseline numbers from
  idle to busy. The highest poll count will be during idle, where
  all polls are empty. These poll counts will be different between
  systems due to the many possible processor micro-arch, cache
  and device configurations, hence the training phase.
  In the training phase, traffic is blocked so the training

When you say 'traffic is blocked' is this something that the application
can do through DPDK API, or you mean no external packets are sent into
that port?a

training is disabled as default. if user enable it, that mean no external packet
are sent to the port.


I think the correct term would be 'traffic should be blocked'. The 
application has no
capability to block traffic itself, so the user needs to ensure that no 
traffic is coming into the

application during the training period.

Rgds,
Dave.

--snip--

Re: [dpdk-dev] [PATCH 1/2] net/sfc: support runtime Rx queue setup

[Ferruh Yigit]

On 8/29/2018 8:35 AM, Andrew Rybchenko wrote:
> From: Igor Romanov 
> 
> Signed-off-by: Igor Romanov 
> Signed-off-by: Andrew Rybchenko 

Series applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH] net/avf: remove unused variables and label

[Bruce Richardson]

Compiling with all warnings turned on causes errors about unused variables
and an unused label. Remove these to allow building without having to
disable those warnings.

Signed-off-by: Bruce Richardson 
---
 drivers/net/avf/avf_ethdev.c | 15 +--
 drivers/net/avf/avf_rxtx.c   | 17 +
 drivers/net/avf/avf_vchnl.c  |  2 --
 3 files changed, 6 insertions(+), 28 deletions(-)

diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 3a2baaf28..be9f163be 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -154,7 +154,6 @@ static int
 avf_init_rss(struct avf_adapter *adapter)
 {
struct avf_info *vf =  AVF_DEV_PRIVATE_TO_VF(adapter);
-   struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(adapter);
struct rte_eth_rss_conf *rss_conf;
uint8_t i, j, nb_q;
int ret;
@@ -259,11 +258,8 @@ avf_init_rxq(struct rte_eth_dev *dev, struct avf_rx_queue 
*rxq)
 static int
 avf_init_queues(struct rte_eth_dev *dev)
 {
-   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
struct avf_rx_queue **rxq =
(struct avf_rx_queue **)dev->data->rx_queues;
-   struct avf_tx_queue **txq =
-   (struct avf_tx_queue **)dev->data->tx_queues;
int i, ret = AVF_SUCCESS;
 
for (i = 0; i < dev->data->nb_rx_queues; i++) {
@@ -415,7 +411,6 @@ avf_dev_start(struct rte_eth_dev *dev)
AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-   struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct rte_intr_handle *intr_handle = dev->intr_handle;
 
PMD_INIT_FUNC_TRACE();
@@ -476,9 +471,7 @@ avf_dev_stop(struct rte_eth_dev *dev)
struct avf_adapter *adapter =
AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-   struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct rte_intr_handle *intr_handle = dev->intr_handle;
-   int ret, i;
 
PMD_INIT_FUNC_TRACE();
 
@@ -503,8 +496,6 @@ avf_dev_stop(struct rte_eth_dev *dev)
 static void
 avf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 {
-   struct avf_adapter *adapter =
-   AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 
memset(dev_info, 0, sizeof(*dev_info));
@@ -915,7 +906,6 @@ avf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,
 static int
 avf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 {
-   struct avf_info *vf = AVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
uint32_t frame_size = mtu + AVF_ETH_OVERHEAD;
int ret = 0;
 
@@ -1045,8 +1035,6 @@ avf_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, 
uint16_t queue_id)
 static int
 avf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id)
 {
-   struct avf_adapter *adapter =
-   AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
uint16_t msix_intr;
@@ -1089,7 +1077,7 @@ avf_check_vf_reset_done(struct avf_hw *hw)
 static int
 avf_init_vf(struct rte_eth_dev *dev)
 {
-   int i, err, bufsz;
+   int err, bufsz;
struct avf_adapter *adapter =
AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
@@ -1198,7 +1186,6 @@ avf_dev_interrupt_handler(void *param)
 
avf_handle_virtchnl_msg(dev);
 
-done:
avf_enable_irq0(hw);
 }
 
diff --git a/drivers/net/avf/avf_rxtx.c b/drivers/net/avf/avf_rxtx.c
index e03a136fc..edff48d27 100644
--- a/drivers/net/avf/avf_rxtx.c
+++ b/drivers/net/avf/avf_rxtx.c
@@ -247,7 +247,6 @@ alloc_rxq_mbufs(struct avf_rx_queue *rxq)
 static inline void
 release_rxq_mbufs(struct avf_rx_queue *rxq)
 {
-   struct rte_mbuf *mbuf;
uint16_t i;
 
if (!rxq->sw_ring)
@@ -310,9 +309,8 @@ avf_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t 
queue_idx,
struct avf_rx_queue *rxq;
const struct rte_memzone *mz;
uint32_t ring_size;
-   uint16_t len, i;
+   uint16_t len;
uint16_t rx_free_thresh;
-   uint16_t base, bsf, tc_mapping;
 
PMD_INIT_FUNC_TRACE();
 
@@ -428,13 +426,10 @@ avf_dev_tx_queue_setup(struct rte_eth_dev *dev,
   const struct rte_eth_txconf *tx_conf)
 {
struct avf_hw *hw = AVF_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-   struct avf_adapter *ad =
-   AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
struct avf_tx_queue *txq;
const struct rte_memzone *mz;
uint32_t r

Re: [dpdk-dev] [PATCH 1/3] event: add function for reading unlink in progress

[Jerin Jacob]

-Original Message-
> Date: Wed, 12 Sep 2018 17:16:14 +0100
> From: Harry van Haaren 
> To: dev@dpdk.org
> CC: jerin.ja...@caviumnetworks.com, matias@nokia.com, Harry van Haaren
>  
> Subject: [PATCH 1/3] event: add function for reading unlink in progress
> X-Mailer: git-send-email 2.17.1
> 
> 
> This commit introduces a new function in the eventdev API,
> which allows applications to read the number of unlink requests
> in progress on a particular port of an eventdev instance.
> 
> This information allows applications to verify when no more packets
> from a particular queue (or any queue) will arrive at a port.
> The application could decide to stop polling, or put the core into
> a sleep state if it wishes, as it is ensured that no new packets
> will arrive at a particular port anymore if all queues are unlinked.
> 
> Suggested-by: Matias Elo 
> Signed-off-by: Harry van Haaren 
> 
> ---
> 
> Cc: jerin.ja...@caviumnetworks.com
> 
> Hey, I've added this API as __rte_experimental, so we should be OK to
> include in 18.11, and then possibly remove the experimental tag in
> a later release, assuming it serves its purpose correctly.
> 
> For context, see thread here:
> http://mails.dpdk.org/archives/dev/2018-September/111499.html
> 
> @Matias, is that workable for you?
> @Jerin, is this acceptable as maintainer?


Yes.

Overall patch looks good to me. Please find inline a minor comment.

# There is build error in this series(not in this patch), please check error log

/export/dpdk-next-eventdev/drivers/event/sw/sw_evdev.c: In function
‘sw_port_unlinks_in_progress’:
/export/dpdk-next-eventdev/drivers/event/sw/sw_evdev.c:124:50: error:
unused parameter ‘dev’ [-Werror=unused-parameter]
 sw_port_unlinks_in_progress(struct rte_eventdev *dev, void *port)


With above changes:

Acked-by: Jerin Jacob  
> Cheers, -Harry
> ---
>  lib/librte_eventdev/rte_eventdev.c   | 22 +++
>  lib/librte_eventdev/rte_eventdev.h   | 28 ++--
>  lib/librte_eventdev/rte_eventdev_pmd.h   | 19 +
>  lib/librte_eventdev/rte_eventdev_version.map |  1 +
>  4 files changed, 68 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_eventdev/rte_eventdev.c 
> b/lib/librte_eventdev/rte_eventdev.c
> index 801810edd..0a8572b7b 100644
> --- a/lib/librte_eventdev/rte_eventdev.c
> +++ b/lib/librte_eventdev/rte_eventdev.c
> @@ -980,6 +980,28 @@ rte_event_port_unlink(uint8_t dev_id, uint8_t port_id,
> return diag;
>  }
> 
> +int __rte_experimental
> +rte_event_port_unlinks_in_progress(uint8_t dev_id, uint8_t port_id)
> +{
> +   struct rte_eventdev *dev;
> +
> +   RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
> +   dev = &rte_eventdevs[dev_id];
> +   if (!is_valid_port(dev, port_id)) {
> +   RTE_EDEV_LOG_ERR("Invalid port_id=%" PRIu8, port_id);
> +   return -EINVAL;
> +   }
> +
> +   /* Return 0 if the PMD does not implement unlinks in progress.
> +* This allows PMDs which handle unlink synchronously to not implement
> +* this function at all.
> +*/
> +   RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->port_unlinks_in_progress, 0);
> +
> +   return (*dev->dev_ops->port_unlinks_in_progress)(dev,
> +   dev->data->ports[port_id]);
> +}
> +
>  int
>  rte_event_port_links_get(uint8_t dev_id, uint8_t port_id,
>  uint8_t queues[], uint8_t priorities[])
> diff --git a/lib/librte_eventdev/rte_eventdev.h 
> b/lib/librte_eventdev/rte_eventdev.h
> index b6fd6ee7f..d07e297bc 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -1656,8 +1656,9 @@ rte_event_port_link(uint8_t dev_id, uint8_t port_id,
>   * event port designated by its *port_id* on the event device designated
>   * by its *dev_id*.
>   *
> - * The unlink establishment shall disable the event port *port_id* from
> - * receiving events from the specified event queue *queue_id*
> + * The unlink call issues an async request to disable the event port 
> *port_id*
> + * from receiving events from the specified event queue *queue_id*. See
> + * *rte_event_port_unlinks_in_progress* to poll for completed unlinks.

use @see rte_event_port_unlinks_in_progress() like reset of file.


>   *
>   * Event queue(s) to event port unlink establishment can be changed at 
> runtime
>   * without re-configuring the device.
> @@ -1694,6 +1695,29 @@ int
>  rte_event_port_unlink(uint8_t dev_id, uint8_t port_id,
>   uint8_t queues[], uint16_t nb_unlinks);
> 
> +/**
> + * Returns the number of unlinks in progress.
> + *
> + * This function provides the application with a method to detect when an
> + * unlink has been completed by the implementation. See 
> *rte_event_port_unlink*
> + * on how to issue unlink requests.

Same as above comment.

> + *
> + * @param dev_id
> + *   The indentifier of the device.
> + *
> + * @param port_id
> + *   Event port identifier to se

Re: [dpdk-dev] [PATCH v2 4/9] build: add Meson files for avf PMD

[Bruce Richardson]

On Thu, Sep 13, 2018 at 02:27:54PM +0100, Luca Boccassi wrote:
> On Thu, 2018-09-13 at 14:24 +0100, Bruce Richardson wrote:
> > On Tue, Sep 11, 2018 at 05:08:58PM +0100, Luca Boccassi wrote:
> > > Signed-off-by: Luca Boccassi 
> > > ---
> > >  drivers/net/avf/base/meson.build | 20 
> > >  drivers/net/avf/meson.build  | 15 +++
> > >  drivers/net/meson.build  |  1 +
> > >  3 files changed, 36 insertions(+)
> > >  create mode 100644 drivers/net/avf/base/meson.build
> > >  create mode 100644 drivers/net/avf/meson.build
> > > 
> > 
> > After applying this patch, I get lots of unused variable warnings.
> > Gcc 6.3
> > on debian, you'll be glad to know.
> > 
> > /Bruce
> 
> Yep got the same, but I'll leave that for the AVF maintainers to have
> fun with :-)
> 
Ok, I've sent a patch to remove the unused stuff.
http://patches.dpdk.org/patch/44694/

I think this file still needs "cflags += '-Wno-strict-aliasing'" to make it
work though, since those errors are tougher to remove. There also needs to
be an "INC_VECTOR" define inside the x86-specific block, as is done for the
IXGBE and I40E drivers.

/Bruce

Re: [dpdk-dev] [PATCH v3 4/9] build: add Meson files for avf PMD

[Bruce Richardson]

On Thu, Sep 13, 2018 at 02:41:35PM +0100, Luca Boccassi wrote:
> Signed-off-by: Luca Boccassi 
> ---
>  drivers/net/avf/base/meson.build | 20 
>  drivers/net/avf/meson.build  | 15 +++
>  drivers/net/meson.build  |  1 +
>  3 files changed, 36 insertions(+)
>  create mode 100644 drivers/net/avf/base/meson.build
>  create mode 100644 drivers/net/avf/meson.build
> 
> diff --git a/drivers/net/avf/base/meson.build 
> b/drivers/net/avf/base/meson.build
> new file mode 100644
> index 00..90fd6b445f
> --- /dev/null
> +++ b/drivers/net/avf/base/meson.build
> @@ -0,0 +1,20 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2018 Luca Boccassi 
> +
> +sources = [
> + 'avf_adminq.c',
> + 'avf_common.c',
> +]
> +
> +error_cflags = ['-Wno-pointer-to-int-cast']
> +c_args = cflags
> +foreach flag: error_cflags
> + if cc.has_argument(flag)
> + c_args += flag
> + endif
> +endforeach
> +
> +base_lib = static_library('avf_base', sources,
> + dependencies: static_rte_eal,
> + c_args: c_args)
> +base_objs = base_lib.extract_all_objects()
> diff --git a/drivers/net/avf/meson.build b/drivers/net/avf/meson.build
> new file mode 100644
> index 00..d341f029b2
> --- /dev/null
> +++ b/drivers/net/avf/meson.build
> @@ -0,0 +1,15 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2018 Luca Boccassi 
> +
> +subdir('base')
> +objs = [base_objs]
> +
> +sources = files(
> + 'avf_ethdev.c',
> + 'avf_rxtx.c',
> + 'avf_rxtx_vec_sse.c',
> + 'avf_vchnl.c',
> +)
> +if arch_subdir == 'x86'
> + sources += files('avf_rxtx_vec_sse.c')
> +endif

Missed this set had been sent, so please see comment on V2 re. needed
warning-disable flag, and need for VECTOR define flag for x86.

/Bruce

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: use evenly distributed default RSS RETA

[Ferruh Yigit]

On 9/4/2018 2:29 PM, Chas Williams wrote:
> On Wed, Aug 29, 2018 at 3:48 AM Andrew Rybchenko 
> wrote:
> 
>> From: Igor Romanov 
>>
>> Default Redirection Table that is set in bonding driver is distributed
>> evenly over all Rx queues only within every RETA group (the first RETA
>> entries in every group are always start with zero). But in the most
>> drivers, default RETA is distributed over all Rx queues without sequence
>> resets in the beginning of a new group, which implies more balanced
>> per-core load.
>>
>> Change the default RETA to be evenly distributed over all Rx queues
>> considering the whole table.
>>
>> Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration")
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Igor Romanov 
>> Signed-off-by: Andrew Rybchenko 
>>
> 
> Acked-by: Chas Williams 

Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

[Chas Williams]

On Wed, Sep 12, 2018 at 1:56 AM Matan Azrad  wrote:
>
> Hi Chas
>
> From:  Chas Williams
> > On Mon, Aug 6, 2018 at 3:35 PM Matan Azrad 
> > wrote:
> > >
> > >
> > > Hi Chas
> > >
> > > From: Chas Williams
> > > >On Mon, Aug 6, 2018 at 1:46 PM Matan Azrad
> >  wrote:
> > > >Hi Chas
> > > >
> > > >From: Chas Williams
> > > >>On Fri, Aug 3, 2018 at 1:47 AM Matan Azrad
> >  wrote:
> > > >>Hi Chas
> > > >>
> > > >> From: Chas Williams [mailto:mailto:mailto:mailto:3ch...@gmail.com]
> > > >> On Thu, Aug 2, 2018 at 1:33
> > > >>> PM Matan Azrad  wrote:
> > > >>> >
> > > >>> > > I suggest to do it like next,
> > > >>> > > To add one more parameter for LACP which means how to
> > > >>> > > configure the
> > > >>> > LACP MC group - lacp_mc_grp_conf:
> > > >>> > > 1. rte_flow.
> > > >>> > > 2. flow director.
> > > >>> > > 3. add_mac.
> > > >>> > > 3. set_mc_add_list
> > > >>> > > 4. allmulti
> > > >>> > > 5. promiscuous
> > > >>> > > Maybe more... or less :)
> > > >>> > >
> > > >>> > > By this way the user decides how to do it, if it's fail for a
> > > >>> > > slave, the salve
> > > >>> > should be rejected.
> > > >>> > > Conflict with another configuration(for example calling to
> > > >>> > > promiscuous
> > > >>> > disable while running LACP lacp_mc_grp_conf=5) should raise an
> > error.
> > > >>> > >
> > > >>> > > What do you think?
> > > >>> > >
> > > >>> >
> > > >>> > Supporting an LACP mc group specific configuration does make
> > > >>> > sense, but I wonder if this could just be handled by default during
> > slave add.
> > > >>> >
> > > >>> >
> > > >>> > 1 and 2 are essentially the same hardware filtering offload
> > > >>> > mode, and the other modes are irrelevant if this is enabled, it
> > > >>> > should not be possible to add the slave if the bond is
> > > >>> > configured for this mode, or possible to change the bond into
> > > >>> > this mode if an existing slave doesn't support it.
> > > >>>
> > > >>> >
> > > >>> > 3 should be the default expected behavior, but
> > > >>> > rte_eth_bond_slave_add() should fail if the slave being added
> > > >>> > doesn't support either adding the MAC to the slave or adding the
> > LACP MC address.
> > > >>> >
> > > >>> > Then the user could try either rte_eth_allmulticast_enable() on
> > > >>> > the bond port and then try to add the slave again, which should
> > > >>> > fail if existing slave didn't support allmulticast or the add
> > > >>> > slave would fail again if the slave didn't support allmulticast
> > > >>> > and finally just call
> > > >>> > rte_eth_promiscuous_enable() on the bond and then try to re-add
> > > >>> > the that slave.
> > > >>> >
> > > >>> > but maybe having a explicit configuration parameter would be
> > better.
> > > >>>
> > > >>> I don't sure you understand exactly what I’m suggesting here, again:
> > > >>> I suggest to add a new parameter to the LACP mode called
> > > >>> lacp_mc_grp_conf(or something else).
> > > >>> So, when the user configures LACP (mode 4) it must to configure
> > > >>> the lacp_mc_grp_conf parameter to one of the options I suggested.
> > > >>> This parameter is not per slave means the bond PMD will use the
> > > >>> selected option to configure the LACP MC group for all the slave 
> > > >>> ports.
> > > >>>
> > > >>> If one of the slaves doesn't support the selected option it should be
> > rejected.
> > > >>> Conflicts should rais an error.
> > > >>>
> > > >>> I agree here.  Yes, if a slave can't manage to subscribe to the
> > > >>> multicast group, an error should be raised.  The only way for this
> > > >>> to happen is that you don't have promisc support which is the ultimate
> > fallback.
> > > >>
> > > >>> The advantages are:
> > > >>> The user knows which option is better to synchronize with his
> > application.
> > > >>> The user knows better than the bond PMD what is the slaves
> > capabilities.
> > > >>> All the slaves are configured by the same way - consistent traffic.
> > > >>>
> > > >>>
> > > >>> It would be ideal if all the slaves would have the same features
> > > >>> and capabilities.  There wasn't enforced before, so this would be
> > > >>> a new restriction that would be less flexible than what we
> > > >>> currently have.  That doesn't seem like an improvement.
> > > >>
> > > >>> The bonding user probably doesn't care which mode is used.
> > > >>> The bonding user just wants bonding to work.  He doesn't care about
> > the details.   If I am writing
> > > >>> an application with this proposed API, I need to make a list of
> > > >>> adapters and what they support (and keep this up to date as DPDK
> > evolves).  Ugh.
> > > >>
> > > >>The applications commonly know what are the nics capabilities they
> > work with.
> > > >>
> > > >>I know at least an one big application which really suffering
> > > >>because the bond configures promiscuous in mode 4 without the
> > application asking (it's considered there as a bug i

Re: [dpdk-dev] [PATCH v3 4/9] memalloc: rename lock list to fd list

[Maxime Coquelin]

On 09/04/2018 05:15 PM, Anatoly Burakov wrote:

Previously, we were only using lock lists to store per-page lock fd's
because we cannot use modern fcntl() file description locks to lock
parts of the page in single file segments mode.

Now, we will be using this list to store either lock fd's (along with
memseg list fd) in single file segments mode, or per-page fd's (and set
memseg list fd to -1), so rename the list accordingly.

Signed-off-by: Anatoly Burakov 
---
  lib/librte_eal/linuxapp/eal/eal_memalloc.c | 66 --
  1 file changed, 37 insertions(+), 29 deletions(-)



Reviewed-by: Maxime Coquelin 

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: don't ignore RSS key on device configuration

[Ferruh Yigit]

On 9/4/2018 2:27 PM, Chas Williams wrote:
> On Wed, Aug 29, 2018 at 3:51 AM Andrew Rybchenko 
> wrote:
> 
>> From: Igor Romanov 
>>
>> Bonding driver ignores the value of RSS key (that is set in the port RSS
>> configuration) in bond_ethdev_configure(). So the only way to set
>> non-default RSS key is by using rss_hash_update(). This is not an
>> expected behaviour.
>>
>> Make the bond_ethdev_configure() set default RSS key only if
>> requested key is set to NULL.
>>
>> Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration")
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Igor Romanov 
>> Signed-off-by: Andrew Rybchenko 
>>
> 
> Acked-by: Chas Williams 

Replaced with:
Acked-by: Chas Williams 

Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

[Matan Azrad]

Hi Chas

From:  Chas Williams
> On Wed, Sep 12, 2018 at 1:56 AM Matan Azrad 
> wrote:
> >
> > Hi Chas
> >
> > From:  Chas Williams
> > > On Mon, Aug 6, 2018 at 3:35 PM Matan Azrad 
> > > wrote:
> > > >
> > > >
> > > > Hi Chas
> > > >
> > > > From: Chas Williams
> > > > >On Mon, Aug 6, 2018 at 1:46 PM Matan Azrad
> > >  wrote:
> > > > >Hi Chas
> > > > >
> > > > >From: Chas Williams
> > > > >>On Fri, Aug 3, 2018 at 1:47 AM Matan Azrad
> > >  wrote:
> > > > >>Hi Chas
> > > > >>
> > > > >> From: Chas Williams
> > > > >> [mailto:mailto:mailto:mailto:3ch...@gmail.com]
> > > > >> On Thu, Aug 2, 2018 at 1:33
> > > > >>> PM Matan Azrad  wrote:
> > > > >>> >
> > > > >>> > > I suggest to do it like next, To add one more parameter
> > > > >>> > > for LACP which means how to configure the
> > > > >>> > LACP MC group - lacp_mc_grp_conf:
> > > > >>> > > 1. rte_flow.
> > > > >>> > > 2. flow director.
> > > > >>> > > 3. add_mac.
> > > > >>> > > 3. set_mc_add_list
> > > > >>> > > 4. allmulti
> > > > >>> > > 5. promiscuous
> > > > >>> > > Maybe more... or less :)
> > > > >>> > >
> > > > >>> > > By this way the user decides how to do it, if it's fail
> > > > >>> > > for a slave, the salve
> > > > >>> > should be rejected.
> > > > >>> > > Conflict with another configuration(for example calling to
> > > > >>> > > promiscuous
> > > > >>> > disable while running LACP lacp_mc_grp_conf=5) should raise
> > > > >>> > an
> > > error.
> > > > >>> > >
> > > > >>> > > What do you think?
> > > > >>> > >
> > > > >>> >
> > > > >>> > Supporting an LACP mc group specific configuration does make
> > > > >>> > sense, but I wonder if this could just be handled by default
> > > > >>> > during
> > > slave add.
> > > > >>> >
> > > > >>> >
> > > > >>> > 1 and 2 are essentially the same hardware filtering offload
> > > > >>> > mode, and the other modes are irrelevant if this is enabled,
> > > > >>> > it should not be possible to add the slave if the bond is
> > > > >>> > configured for this mode, or possible to change the bond
> > > > >>> > into this mode if an existing slave doesn't support it.
> > > > >>>
> > > > >>> >
> > > > >>> > 3 should be the default expected behavior, but
> > > > >>> > rte_eth_bond_slave_add() should fail if the slave being
> > > > >>> > added doesn't support either adding the MAC to the slave or
> > > > >>> > adding the
> > > LACP MC address.
> > > > >>> >
> > > > >>> > Then the user could try either rte_eth_allmulticast_enable()
> > > > >>> > on the bond port and then try to add the slave again, which
> > > > >>> > should fail if existing slave didn't support allmulticast or
> > > > >>> > the add slave would fail again if the slave didn't support
> > > > >>> > allmulticast and finally just call
> > > > >>> > rte_eth_promiscuous_enable() on the bond and then try to
> > > > >>> > re-add the that slave.
> > > > >>> >
> > > > >>> > but maybe having a explicit configuration parameter would be
> > > better.
> > > > >>>
> > > > >>> I don't sure you understand exactly what I’m suggesting here,
> again:
> > > > >>> I suggest to add a new parameter to the LACP mode called
> > > > >>> lacp_mc_grp_conf(or something else).
> > > > >>> So, when the user configures LACP (mode 4) it must to
> > > > >>> configure the lacp_mc_grp_conf parameter to one of the options I
> suggested.
> > > > >>> This parameter is not per slave means the bond PMD will use
> > > > >>> the selected option to configure the LACP MC group for all the
> slave ports.
> > > > >>>
> > > > >>> If one of the slaves doesn't support the selected option it
> > > > >>> should be
> > > rejected.
> > > > >>> Conflicts should rais an error.
> > > > >>>
> > > > >>> I agree here.  Yes, if a slave can't manage to subscribe to
> > > > >>> the multicast group, an error should be raised.  The only way
> > > > >>> for this to happen is that you don't have promisc support
> > > > >>> which is the ultimate
> > > fallback.
> > > > >>
> > > > >>> The advantages are:
> > > > >>> The user knows which option is better to synchronize with his
> > > application.
> > > > >>> The user knows better than the bond PMD what is the slaves
> > > capabilities.
> > > > >>> All the slaves are configured by the same way - consistent traffic.
> > > > >>>
> > > > >>>
> > > > >>> It would be ideal if all the slaves would have the same
> > > > >>> features and capabilities.  There wasn't enforced before, so
> > > > >>> this would be a new restriction that would be less flexible
> > > > >>> than what we currently have.  That doesn't seem like an
> improvement.
> > > > >>
> > > > >>> The bonding user probably doesn't care which mode is used.
> > > > >>> The bonding user just wants bonding to work.  He doesn't care
> > > > >>> about
> > > the details.   If I am writing
> > > > >>> an application with this proposed API, I need to make a list
> > > > >>> of adapters and what they support (and keep this up to date as
> > >

Re: [dpdk-dev] [PATCH v3 5/9] memalloc: track page fd's in non-single file mode

[Maxime Coquelin]

On 09/04/2018 05:15 PM, Anatoly Burakov wrote:

Previously, we were only tracking lock file fd's in single-file
segments mode, but did not track fd's in non-single file mode
because we didn't need to (mmap() call still kept the lock). Now
that we are going to expose these fd's to the world, we need to
have access to them, so track them even in non-single file
segments mode.

We don't need to close fd's after mmap() because we're still
tracking them in an fd list. Also, for anonymous hugepages mode,
fd will always be -1 so exit early on error.

Signed-off-by: Anatoly Burakov 
---
  lib/librte_eal/linuxapp/eal/eal_memalloc.c | 44 --
  1 file changed, 25 insertions(+), 19 deletions(-)



Reviewed-by: Maxime Coquelin 

[dpdk-dev] [PATCH v4 2/9] build: add Meson file for vdev_netvsc PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/net/meson.build |  1 +
 drivers/net/vdev_netvsc/meson.build | 19 +++
 2 files changed, 20 insertions(+)
 create mode 100644 drivers/net/vdev_netvsc/meson.build

diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index b7b4870eb8..68ac42d67c 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -29,6 +29,7 @@ drivers = ['af_packet',
'szedata2',
'tap',
'thunderx',
+   'vdev_netvsc',
'vhost',
'virtio']
 std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc
diff --git a/drivers/net/vdev_netvsc/meson.build 
b/drivers/net/vdev_netvsc/meson.build
new file mode 100644
index 00..cc956e7b27
--- /dev/null
+++ b/drivers/net/vdev_netvsc/meson.build
@@ -0,0 +1,19 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+sources = files('vdev_netvsc.c')
+
+allow_experimental_apis = true
+
+cflags_options = [
+'-Wall',
+'-Wextra',
+'-D_BSD_SOURCE',
+'-D_DEFAULT_SOURCE',
+'-D_XOPEN_SOURCE=600'
+]
+foreach option:cflags_options
+if cc.has_argument(option)
+cflags += option
+endif
+endforeach
-- 
2.18.0

[dpdk-dev] [PATCH v4 1/9] build: add Meson file for TAP PMD

[Luca Boccassi]

Use same autoconf generation mechanism as the MLX4/5 PMDs

Signed-off-by: Luca Boccassi 
---
 drivers/net/meson.build |  1 +
 drivers/net/tap/meson.build | 41 +
 2 files changed, 42 insertions(+)
 create mode 100644 drivers/net/tap/meson.build

diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index c7a2d0e7db..b7b4870eb8 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -27,6 +27,7 @@ drivers = ['af_packet',
'sfc',
'softnic',
'szedata2',
+   'tap',
'thunderx',
'vhost',
'virtio']
diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build
new file mode 100644
index 00..37f65b75c2
--- /dev/null
+++ b/drivers/net/tap/meson.build
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2018 Luca Boccassi 
+
+sources = files(
+   'rte_eth_tap.c',
+   'tap_bpf_api.c',
+   'tap_flow.c',
+   'tap_intr.c',
+   'tap_netlink.c',
+   'tap_tcmsgs.c',
+)
+
+deps = ['bus_vdev', 'gso', 'hash']
+
+cflags += '-DTAP_MAX_QUEUES=16'
+
+# To maintain the compatibility with the make build system
+# tap_autoconf.h file is still generated.
+# input array for meson symbol search:
+# [ "MACRO to define if found", "header for the search",
+#   "enum/define", "symbol to search" ]
+#
+args = [
+   [ 'HAVE_TC_FLOWER', 'linux/pkt_cls.h',
+ 'TCA_FLOWER_UNSPEC' ],
+   [ 'HAVE_TC_VLAN_ID', 'linux/pkt_cls.h',
+ 'TCA_FLOWER_KEY_VLAN_PRIO' ],
+   [ 'HAVE_TC_BPF', 'linux/pkt_cls.h',
+ 'TCA_BPF_UNSPEC' ],
+   [ 'HAVE_TC_BPF_FD', 'linux/pkt_cls.h',
+ 'TCA_BPF_FD' ],
+   [ 'HAVE_TC_ACT_BPF', 'linux/tc_act/tc_bpf.h',
+ 'TCA_ACT_BPF_UNSPEC' ],
+   [ 'HAVE_TC_ACT_BPF_FD', 'linux/tc_act/tc_bpf.h',
+ 'TCA_ACT_BPF_FD' ],
+]
+config = configuration_data()
+foreach arg:args
+   config.set(arg[0], cc.has_header_symbol(arg[1], arg[2]))
+endforeach
+configure_file(output : 'tap_autoconf.h', configuration : config)
-- 
2.18.0

[dpdk-dev] [PATCH v4 3/9] build: add Meson file for crypto scheduler PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/crypto/meson.build   |  2 +-
 drivers/crypto/scheduler/meson.build | 19 +++
 2 files changed, 20 insertions(+), 1 deletion(-)
 create mode 100644 drivers/crypto/scheduler/meson.build

diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index d64ca418bc..6ed853b7ab 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -2,7 +2,7 @@
 # Copyright(c) 2017 Intel Corporation
 
 drivers = ['ccp', 'dpaa_sec', 'dpaa2_sec', 'mvsam',
-   'null', 'openssl', 'qat', 'virtio']
+   'null', 'openssl', 'qat', 'scheduler', 'virtio']
 
 std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
 config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
diff --git a/drivers/crypto/scheduler/meson.build 
b/drivers/crypto/scheduler/meson.build
new file mode 100644
index 00..c5ba2d6804
--- /dev/null
+++ b/drivers/crypto/scheduler/meson.build
@@ -0,0 +1,19 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+deps += ['bus_vdev', 'reorder']
+name = 'crypto_scheduler'
+sources = files(
+   'rte_cryptodev_scheduler.c',
+   'scheduler_failover.c',
+   'scheduler_multicore.c',
+   'scheduler_pkt_size_distr.c',
+   'scheduler_pmd.c',
+   'scheduler_pmd_ops.c',
+   'scheduler_roundrobin.c',
+)
+
+headers = files(
+   'rte_cryptodev_scheduler.h',
+   'rte_cryptodev_scheduler_operations.h',
+)
-- 
2.18.0

[dpdk-dev] [PATCH v4 4/9] build: add Meson files for avf PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/net/avf/base/meson.build | 20 
 drivers/net/avf/meson.build  | 19 +++
 drivers/net/meson.build  |  1 +
 3 files changed, 40 insertions(+)
 create mode 100644 drivers/net/avf/base/meson.build
 create mode 100644 drivers/net/avf/meson.build

diff --git a/drivers/net/avf/base/meson.build b/drivers/net/avf/base/meson.build
new file mode 100644
index 00..90fd6b445f
--- /dev/null
+++ b/drivers/net/avf/base/meson.build
@@ -0,0 +1,20 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+sources = [
+   'avf_adminq.c',
+   'avf_common.c',
+]
+
+error_cflags = ['-Wno-pointer-to-int-cast']
+c_args = cflags
+foreach flag: error_cflags
+   if cc.has_argument(flag)
+   c_args += flag
+   endif
+endforeach
+
+base_lib = static_library('avf_base', sources,
+   dependencies: static_rte_eal,
+   c_args: c_args)
+base_objs = base_lib.extract_all_objects()
diff --git a/drivers/net/avf/meson.build b/drivers/net/avf/meson.build
new file mode 100644
index 00..b5ad9cc673
--- /dev/null
+++ b/drivers/net/avf/meson.build
@@ -0,0 +1,19 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+cflags += ['-Wno-strict-aliasing']
+
+subdir('base')
+objs = [base_objs]
+
+sources = files(
+   'avf_ethdev.c',
+   'avf_rxtx.c',
+   'avf_rxtx_vec_sse.c',
+   'avf_vchnl.c',
+)
+
+if arch_subdir == 'x86'
+   dpdk_conf.set('RTE_LIBRTE_AVF_INC_VECTOR', 1)
+   sources += files('avf_rxtx_vec_sse.c')
+endif
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 68ac42d67c..28efeda0b6 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -3,6 +3,7 @@
 
 drivers = ['af_packet',
'ark',
+   'avf',
'avp',
'axgbe', 'bonding',
'bnx2x',
-- 
2.18.0

[dpdk-dev] [PATCH v4 5/9] build: add Meson files for qede PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
Acked-by: Shahed Shaikh 
---
 config/rte_config.h   |  3 ++
 drivers/net/meson.build   |  2 +-
 drivers/net/qede/base/meson.build | 57 +++
 drivers/net/qede/meson.build  | 12 +++
 4 files changed, 73 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/qede/base/meson.build
 create mode 100644 drivers/net/qede/meson.build

diff --git a/config/rte_config.h b/config/rte_config.h
index 46775a8419..ee84f04977 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -116,4 +116,7 @@
 #define RTE_PMD_RING_MAX_RX_RINGS 16
 #define RTE_PMD_RING_MAX_TX_RINGS 16
 
+/* QEDE PMD defines */
+#define RTE_LIBRTE_QEDE_FW ""
+
 #endif /* _RTE_CONFIG_H_ */
diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 28efeda0b6..74f4109161 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -24,7 +24,7 @@ drivers = ['af_packet',
'mvpp2',
'netvsc',
'nfp',
-   'null', 'octeontx', 'pcap', 'ring',
+   'null', 'octeontx', 'pcap', 'qede', 'ring',
'sfc',
'softnic',
'szedata2',
diff --git a/drivers/net/qede/base/meson.build 
b/drivers/net/qede/base/meson.build
new file mode 100644
index 00..59b41c895d
--- /dev/null
+++ b/drivers/net/qede/base/meson.build
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+sources = [
+   'bcm_osal.c',
+   'ecore_cxt.c',
+   'ecore_dcbx.c',
+   'ecore_dev.c',
+   'ecore_hw.c',
+   'ecore_init_fw_funcs.c',
+   'ecore_init_ops.c',
+   'ecore_int.c',
+   'ecore_l2.c',
+   'ecore_mcp.c',
+   'ecore_sp_commands.c',
+   'ecore_spq.c',
+   'ecore_sriov.c',
+   'ecore_vf.c',
+]
+
+
+error_cflags = [
+   '-Wno-unused-parameter',
+   '-Wno-sign-compare',
+   '-Wno-missing-prototypes',
+   '-Wno-cast-qual',
+   '-Wno-unused-function',
+   '-Wno-unused-variable',
+   '-Wno-strict-aliasing',
+   '-Wno-missing-prototypes',
+   '-Wno-unused-value',
+   '-Wno-format-nonliteral',
+   '-Wno-shift-negative-value',
+   '-Wno-unused-but-set-variable',
+   '-Wno-missing-declarations',
+   '-Wno-maybe-uninitialized',
+   '-Wno-strict-prototypes',
+   '-Wno-shift-negative-value',
+   '-Wno-implicit-fallthrough',
+   '-Wno-format-extra-args',
+   '-Wno-visibility',
+   '-Wno-empty-body',
+   '-Wno-invalid-source-encoding',
+   '-Wno-sometimes-uninitialized',
+   '-Wno-pointer-bool-conversion',
+]
+c_args = cflags
+foreach flag: error_cflags
+if cc.has_argument(flag)
+c_args += flag
+endif
+endforeach
+
+base_lib = static_library('qede_base', sources,
+   dependencies: static_rte_net,
+   c_args: c_args)
+base_objs = base_lib.extract_all_objects()
diff --git a/drivers/net/qede/meson.build b/drivers/net/qede/meson.build
new file mode 100644
index 00..6280073a56
--- /dev/null
+++ b/drivers/net/qede/meson.build
@@ -0,0 +1,12 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+subdir('base')
+objs = [base_objs]
+
+sources = files(
+   'qede_ethdev.c',
+   'qede_fdir.c',
+   'qede_main.c',
+   'qede_rxtx.c',
+)
-- 
2.18.0

[dpdk-dev] [PATCH v4 6/9] build: add Meson file for bbdev_null PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/baseband/meson.build  | 7 +++
 drivers/baseband/null/meson.build | 7 +++
 drivers/meson.build   | 1 +
 3 files changed, 15 insertions(+)
 create mode 100644 drivers/baseband/meson.build
 create mode 100644 drivers/baseband/null/meson.build

diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
new file mode 100644
index 00..52489df354
--- /dev/null
+++ b/drivers/baseband/meson.build
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+drivers = ['null']
+
+config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
+driver_name_fmt = 'rte_pmd_@0@'
diff --git a/drivers/baseband/null/meson.build 
b/drivers/baseband/null/meson.build
new file mode 100644
index 00..64c29d8600
--- /dev/null
+++ b/drivers/baseband/null/meson.build
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+deps += ['bbdev', 'bus_vdev', 'ring']
+name = 'bbdev_null'
+allow_experimental_apis = true
+sources = files('bbdev_null.c')
diff --git a/drivers/meson.build b/drivers/meson.build
index f94e2fe672..14e335ec1d 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -9,6 +9,7 @@ driver_classes = ['common',
   'crypto',  # depends on common, bus and mempool (net in future).
   'compress', # depends on common, bus, mempool.
   'event',   # depends on common, bus, mempool and net.
+  'baseband', # depends on common and bus.
   'raw'] # depends on common, bus, mempool, net and event.
 
 default_cflags = machine_args
-- 
2.18.0

[dpdk-dev] [PATCH v4 7/9] event/opdl: rename map file to match library name

[Luca Boccassi]

So that it can be used from Meson as well

Signed-off-by: Luca Boccassi 
---
 drivers/event/opdl/Makefile | 2 +-
 ...md_evdev_opdl_version.map => rte_pmd_opdl_event_version.map} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/event/opdl/{rte_pmd_evdev_opdl_version.map => 
rte_pmd_opdl_event_version.map} (100%)

diff --git a/drivers/event/opdl/Makefile b/drivers/event/opdl/Makefile
index cea8118d36..bf50a60a0b 100644
--- a/drivers/event/opdl/Makefile
+++ b/drivers/event/opdl/Makefile
@@ -24,7 +24,7 @@ LDLIBS += -lrte_bus_vdev -lrte_mbuf -lrte_mempool
 LIBABIVER := 1
 
 # versioning export map
-EXPORT_MAP := rte_pmd_evdev_opdl_version.map
+EXPORT_MAP := rte_pmd_opdl_event_version.map
 
 # library source files
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV) += opdl_ring.c
diff --git a/drivers/event/opdl/rte_pmd_evdev_opdl_version.map 
b/drivers/event/opdl/rte_pmd_opdl_event_version.map
similarity index 100%
rename from drivers/event/opdl/rte_pmd_evdev_opdl_version.map
rename to drivers/event/opdl/rte_pmd_opdl_event_version.map
-- 
2.18.0

[dpdk-dev] [PATCH v4 9/9] build: add Meson file for vmxnet3_uio PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/net/meson.build |  4 +++-
 drivers/net/vmxnet3/meson.build | 18 ++
 2 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 drivers/net/vmxnet3/meson.build

diff --git a/drivers/net/meson.build b/drivers/net/meson.build
index 74f4109161..5906283c2f 100644
--- a/drivers/net/meson.build
+++ b/drivers/net/meson.build
@@ -32,7 +32,9 @@ drivers = ['af_packet',
'thunderx',
'vdev_netvsc',
'vhost',
-   'virtio']
+   'virtio',
+   'vmxnet3',
+]
 std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc
 std_deps += ['bus_pci'] # very many PMDs depend on PCI, so make std
 std_deps += ['bus_vdev']# same with vdev bus
diff --git a/drivers/net/vmxnet3/meson.build b/drivers/net/vmxnet3/meson.build
new file mode 100644
index 00..a92bd28680
--- /dev/null
+++ b/drivers/net/vmxnet3/meson.build
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+allow_experimental_apis = true
+sources += files(
+   'vmxnet3_ethdev.c',
+   'vmxnet3_rxtx.c',
+)
+
+error_cflags = [
+   '-Wno-unused-parameter', '-Wno-unused-value',
+'-Wno-strict-aliasing', '-Wno-format-extra-args',
+]
+foreach flag: error_cflags
+if cc.has_argument(flag)
+cflags += flag
+endif
+endforeach
-- 
2.18.0

[dpdk-dev] [PATCH v4 8/9] build: add Meson file for opdl_event PMD

[Luca Boccassi]

Signed-off-by: Luca Boccassi 
---
 drivers/event/meson.build  |  2 +-
 drivers/event/opdl/meson.build | 11 +++
 2 files changed, 12 insertions(+), 1 deletion(-)
 create mode 100644 drivers/event/opdl/meson.build

diff --git a/drivers/event/meson.build b/drivers/event/meson.build
index e951199358..ed56d20062 100644
--- a/drivers/event/meson.build
+++ b/drivers/event/meson.build
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-drivers = ['dpaa', 'dpaa2', 'octeontx', 'skeleton', 'sw']
+drivers = ['dpaa', 'dpaa2', 'octeontx', 'opdl', 'skeleton', 'sw']
 std_deps = ['eventdev', 'kvargs']
 config_flag_fmt = 'RTE_LIBRTE_@0@_EVENTDEV_PMD'
 driver_name_fmt = 'rte_pmd_@0@_event'
diff --git a/drivers/event/opdl/meson.build b/drivers/event/opdl/meson.build
new file mode 100644
index 00..cc6029c6f0
--- /dev/null
+++ b/drivers/event/opdl/meson.build
@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Luca Boccassi 
+
+sources = files(
+   'opdl_evdev.c',
+   'opdl_evdev_init.c',
+   'opdl_evdev_xstats.c',
+   'opdl_ring.c',
+   'opdl_test.c',
+)
+deps += ['bus_vdev']
-- 
2.18.0

Re: [dpdk-dev] [PATCH v3 4/9] build: add Meson files for avf PMD

[Luca Boccassi]

On Thu, 2018-09-13 at 15:49 +0100, Bruce Richardson wrote:
> On Thu, Sep 13, 2018 at 02:41:35PM +0100, Luca Boccassi wrote:
> > Signed-off-by: Luca Boccassi 
> > ---
> >  drivers/net/avf/base/meson.build | 20 
> >  drivers/net/avf/meson.build  | 15 +++
> >  drivers/net/meson.build  |  1 +
> >  3 files changed, 36 insertions(+)
> >  create mode 100644 drivers/net/avf/base/meson.build
> >  create mode 100644 drivers/net/avf/meson.build
> > 
> > diff --git a/drivers/net/avf/base/meson.build
> > b/drivers/net/avf/base/meson.build
> > new file mode 100644
> > index 00..90fd6b445f
> > --- /dev/null
> > +++ b/drivers/net/avf/base/meson.build
> > @@ -0,0 +1,20 @@
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2018 Luca Boccassi 
> > +
> > +sources = [
> > +   'avf_adminq.c',
> > +   'avf_common.c',
> > +]
> > +
> > +error_cflags = ['-Wno-pointer-to-int-cast']
> > +c_args = cflags
> > +foreach flag: error_cflags
> > +   if cc.has_argument(flag)
> > +   c_args += flag
> > +   endif
> > +endforeach
> > +
> > +base_lib = static_library('avf_base', sources,
> > +   dependencies: static_rte_eal,
> > +   c_args: c_args)
> > +base_objs = base_lib.extract_all_objects()
> > diff --git a/drivers/net/avf/meson.build
> > b/drivers/net/avf/meson.build
> > new file mode 100644
> > index 00..d341f029b2
> > --- /dev/null
> > +++ b/drivers/net/avf/meson.build
> > @@ -0,0 +1,15 @@
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2018 Luca Boccassi 
> > +
> > +subdir('base')
> > +objs = [base_objs]
> > +
> > +sources = files(
> > +   'avf_ethdev.c',
> > +   'avf_rxtx.c',
> > +   'avf_rxtx_vec_sse.c',
> > +   'avf_vchnl.c',
> > +)
> > +if arch_subdir == 'x86'
> > +   sources += files('avf_rxtx_vec_sse.c')
> > +endif
> 
> Missed this set had been sent, so please see comment on V2 re. needed
> warning-disable flag, and need for VECTOR define flag for x86.
> 
> /Bruce

Ok, thanks, done in v4

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] [PATCH] net/avf: remove unused variables and label

[Luca Boccassi]

On Thu, 2018-09-13 at 15:44 +0100, Bruce Richardson wrote:
> Compiling with all warnings turned on causes errors about unused
> variables
> and an unused label. Remove these to allow building without having to
> disable those warnings.
> 
> Signed-off-by: Bruce Richardson 
> ---
>  drivers/net/avf/avf_ethdev.c | 15 +--
>  drivers/net/avf/avf_rxtx.c   | 17 +
>  drivers/net/avf/avf_vchnl.c  |  2 --
>  3 files changed, 6 insertions(+), 28 deletions(-)

Acked-by: Luca Boccassi 

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets

[David Marchand]

On Wed, Sep 12, 2018 at 10:06 AM, Raslan Darawsheh  wrote:
> use the generic function to dump packets for several forwarding
> engines.

Rather than patching some engines, how about putting this in rx/tx callbacks ?
A bit like something I sent earlier ?

http://patches.dpdk.org/patch/44465/


-- 
David Marchand

Re: [dpdk-dev] [PATCH 3/4] ethdev: add Rx offload outer L4 checksum definitions

[Shahaf Shuler]

Thursday, September 13, 2018 4:47 PM, Jerin Jacob:
> Subject: [dpdk-dev] [PATCH 3/4] ethdev: add Rx offload outer L4 checksum
> definitions
> 
> Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM,
> DEV_RX_OFFLOAD_OUTER_TCP_CKSUM and
> DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM offload flags and

Out of curiosity, which TCP based tunnels you target with this current 
patchset? 

> 
> PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to enable outer Rx L4 checksum
> offload.
> 
> # To use hardware Rx outer L4 checksum offload, the user needs to
> configure DEV_RX_OFFLOAD_OUTER_* offload flags in slowpath.
> 
> # Driver updates the PKT_RX_EL4_CKSUM_BAD mbuf ol_flag on checksum
> failure similar to the outer L3 PKT_RX_EIP_CKSUM_BAD flag.
> 
> Signed-off-by: Jerin Jacob