On Thu, Sep 13, 2018 at 10:12:18AM +0000, Shahaf Shuler wrote:
> Hi Bruce,
>
> Sorry for the late reply. Holiday time in Israel.
>
No problem! Hope you had a good break. :-)
> Thursday, September 13, 2018 12:22 PM, Bruce Richardson:
> > Subject: Re: [dpdk-dev] [PATCH v5] net/mlx: add meson build support
> >
> > On Fri, Sep 07, 2018 at 11:34:29AM +0100, Bruce Richardson wrote:
> > > On Wed, Sep 05, 2018 at 02:47:46PM +0300, Shahaf Shuler wrote:
> > > > From: Nelio Laranjeiro <nelio.laranje...@6wind.com>
>
<snip>
>
> > > * Very minor suggestion: is it neater to use "args: '-include ' + arg[1]",
> > > instead of using prefix with the #include syntax? [Assuming the former
> > > works]
>
> I don't understand the benefit with this change. Is there?
>
No, it was just a suggestion as to what looked neater in the code. Use
whatever you prefer.
> > >
> >
> > Any plans for a new version of this? If so, can I also suggest splitting
> > the patch
> > into two, one for mlx4 and the other for mlx5.
>
> No problem to split.
>
> Another change in plans:
> diff --git a/meson_options.txt b/meson_options.txt
> index 484f3e2601..444a380d97 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -1,7 +1,7 @@
> option('allow_invalid_socket_id', type: 'boolean', value: false,
> description: 'allow out-of-range NUMA socket id\'s for platforms that
> don\'t report the value correctly')
> option('enable_driver_mlx_glue', type: 'boolean', value: false,
> - description: 'Enable glue library for Mellanox ConnectX-3/4/5 NIC
> PMD')
> + description: 'Enable glue library for Mellanox PMDs')
> option('enable_kmods', type: 'boolean', value: true,
> description: 'build kernel modules')
> option('examples', type: 'string', value: '',
>
> I don't see the need to constantly update with each device being added.
>
Good idea!
/Bruce
