Re: [dpdk-dev] [PATCH v1] lib/metrics: add check for invalid metric keys

[Remy Horton]

Harry,

Can you add the following to the cheat-sheet? Don't do many patches 
these days, and I'm not the only one to miss these recently..


..Remy

On 26/07/2018 19:11, Thomas Monjalon wrote:

Remy,
You are not new to DPDK. Please pay attention to details:
- subject does not start with lib/
- fixes of old commits must have Cc: sta...@dpdk.org

20/07/2018 17:31, Ferruh Yigit:

On 7/6/2018 2:21 PM, Remy Horton wrote:

This patchset adds a check to rte_metrics_update_values()
that prevents the updating of metrics when presented with
an invalid metric key. Previously, doing the latter could
result in a crash.

Fixes: 349950ddb9c5 ("metrics: add information metrics library")

Signed-off-by: Remy Horton 


Acked-by: Ferruh Yigit 


Applied, thanks

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

[Alejandro Lucero]

Hi Thomas,

Why deferred? This patch is only to be applied to 17.11.3. Because the
changes the memory code has gone through the last months, the same fix will
be different for newer versions.

I'm working on it but waiting all the current patches from Anatoly being
accepted for creating the final patchset.



On Thu, Jul 26, 2018 at 5:41 PM, Thomas Monjalon 
wrote:

> 10/07/2018 19:25, Alejandro Lucero:
> > This patchset applies on 17.11.3.
> >
> > Similar changes will be submitted to main DPDK branch soon.
>
> In patchwork, I mark this patchset as Deferred,
> waiting a new version for 18.11.
>
>
>

Re: [dpdk-dev] [PATCH v7 1/4] test: add ring pmd based packet rx/tx for UT

[Burakov, Anatoly]

On 26-Jul-18 5:43 PM, Pattan, Reshma wrote:

Hi,


-Original Message-
From: Somarowthu, Naga SureshX
Sent: Thursday, July 26, 2018 1:50 PM
To: dev@dpdk.org
Cc: Horton, Remy ; Pattan, Reshma
; Somarowthu, Naga SureshX

Subject: [PATCH v7 1/4] test: add ring pmd based packet rx/tx for UT



dpdk-dpdk]$ ./devtools/check-git-log.sh
Wrong headline lowercase:
 test: add ring pmd based packet rx/tx for UT

Thanks,
Reshma



Suggestion: do not refer to "unit tests" as "UT" as it may not be 
immediately clear what you mean by that. IME they tend to be referred to 
as autotests or just tests :) So, suggested rewording would be:


test: add helper functions for tests using ring-pmd rx/tx

or something like that.

--
Thanks,
Anatoly

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

[Thomas Monjalon]

27/07/2018 09:03, Alejandro Lucero:
> Hi Thomas,
> 
> Why deferred? This patch is only to be applied to 17.11.3. Because the
> changes the memory code has gone through the last months, the same fix will
> be different for newer versions.

OK, I can change them to "Not Applicable".

> I'm working on it but waiting all the current patches from Anatoly being
> accepted for creating the final patchset.

Is there still some patches which are not applied?



> On Thu, Jul 26, 2018 at 5:41 PM, Thomas Monjalon 
> wrote:
> 
> > 10/07/2018 19:25, Alejandro Lucero:
> > > This patchset applies on 17.11.3.
> > >
> > > Similar changes will be submitted to main DPDK branch soon.
> >
> > In patchwork, I mark this patchset as Deferred,
> > waiting a new version for 18.11.
> >
> >
> >
> 

Re: [dpdk-dev] [PATCH v2] net/i40e: fix max frame size checking

[Ananyev, Konstantin]

> -Original Message-
> From: Wu, Yanglong
> Sent: Friday, July 27, 2018 5:40 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z ; Ananyev, Konstantin 
> ; Yao, Lei A ;
> Wu, Yanglong 
> Subject: [PATCH v2] net/i40e: fix max frame size checking
> 
> Check patcket size according to TSO or no-TSO.
> 
> Fixes: bfeed0262b0c ("net/i40e: check illegal packets")
> 
> Signed-off-by: Yanglong Wu 
> ---
> v2:
> change as comments.
> ---
>  drivers/net/i40e/i40e_ethdev.h | 1 +
>  drivers/net/i40e/i40e_rxtx.c   | 9 +
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h
> index cb5e5b5d8..3fffe5a55 100644
> --- a/drivers/net/i40e/i40e_ethdev.h
> +++ b/drivers/net/i40e/i40e_ethdev.h
> @@ -28,6 +28,7 @@
>  #define I40E_NUM_DESC_ALIGN   32
>  #define I40E_BUF_SIZE_MIN 1024
>  #define I40E_FRAME_SIZE_MAX   9728
> +#define I40E_TSO_FRAME_SIZE_MAX   262144
>  #define I40E_QUEUE_BASE_ADDR_UNIT 128
>  /* number of VSIs and queue default setting */
>  #define I40E_MAX_QP_NUM_PER_VF16
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
> index 3be87fe6a..1bbc0340b 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -1439,13 +1439,15 @@ i40e_prep_pkts(__rte_unused void *tx_queue, struct 
> rte_mbuf **tx_pkts,
> 
>   /* Check for m->nb_segs to not exceed the limits. */
>   if (!(ol_flags & PKT_TX_TCP_SEG)) {
> - if (m->nb_segs > I40E_TX_MAX_MTU_SEG) {
> + if (m->nb_segs > I40E_TX_MAX_MTU_SEG ||
> + m->pkt_len > I40E_FRAME_SIZE_MAX) {
>   rte_errno = -EINVAL;
>   return i;
>   }
>   } else if (m->nb_segs > I40E_TX_MAX_SEG ||
>  m->tso_segsz < I40E_MIN_TSO_MSS ||
> -m->tso_segsz > I40E_MAX_TSO_MSS) {
> +m->tso_segsz > I40E_MAX_TSO_MSS ||
> +m->pkt_len > I40E_TSO_FRAME_SIZE_MAX) {
>   /* MSS outside the range (256B - 9674B) are considered
>* malicious
>*/
> @@ -1459,8 +1461,7 @@ i40e_prep_pkts(__rte_unused void *tx_queue, struct 
> rte_mbuf **tx_pkts,
>   }
> 
>   /* check the size of packet */
> - if (m->pkt_len > I40E_FRAME_SIZE_MAX ||
> - m->pkt_len < I40E_TX_MIN_PKT_LEN) {
> + if (m->pkt_len < I40E_TX_MIN_PKT_LEN) {
>   rte_errno = -EINVAL;
>   return i;
>   }
> --

Acked-by: Konstantin Ananyev 

> 2.11.0

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

[Alejandro Lucero]

On Fri, Jul 27, 2018 at 10:01 AM, Thomas Monjalon 
wrote:

> 27/07/2018 09:03, Alejandro Lucero:
> > Hi Thomas,
> >
> > Why deferred? This patch is only to be applied to 17.11.3. Because the
> > changes the memory code has gone through the last months, the same fix
> will
> > be different for newer versions.
>
> OK, I can change them to "Not Applicable".
>
>
It is not applicable to master but it should for 17.11.3. Adding
sta...@dpdk.org to this thread.


> > I'm working on it but waiting all the current patches from Anatoly being
> > accepted for creating the final patchset.
>
> Is there still some patches which are not applied?
>
>
>
Uhmm, maybe a patch for 18.11 could be created now. I was thinking about
these ones:

Support externally allocated memory in DPDK


Support running DPDK without hugetlbfs mountpoint

But they are not going to be in 18.11, so I will submit the patch asap, but
I'm afraid it will be for stable 18.11.1
Next three weeks I'm on PTO, so hopefully I can submit the patch early
September.



> > On Thu, Jul 26, 2018 at 5:41 PM, Thomas Monjalon 
> > wrote:
> >
> > > 10/07/2018 19:25, Alejandro Lucero:
> > > > This patchset applies on 17.11.3.
> > > >
> > > > Similar changes will be submitted to main DPDK branch soon.
> > >
> > > In patchwork, I mark this patchset as Deferred,
> > > waiting a new version for 18.11.
> > >
> > >
> > >
> >
>
>
>
>
>
>

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 10/10] mk: remove unnecessary make rules of test

[Pattan, Reshma]

Hi,

> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, July 26, 2018 9:08 PM
> To: Pattan, Reshma 
> Cc: sta...@dpdk.org; dev@dpdk.org; Burakov, Anatoly
> ; Parthasarathy, JananeeX M
> ; Yigit, Ferruh
> 
> Subject: Re: [dpdk-stable] [PATCH v5 10/10] mk: remove unnecessary make
> rules of test
> 
> 17/07/2018 18:00, Reshma Pattan:
> > make rule test-basic is duplicate of test rule.
> > removed unused test-mempool and test-ring make rules.
> >
> > Fixes: a3df7f8d9c ("mk: rename test related rules")
> > Fixes: a3df7f8d9c ("mk: rename test related rules")
> > CC: sta...@dpdk.org
> > CC: ferruh.yi...@intel.com
> >
> > Signed-off-by: Reshma Pattan 
> > ---
> > -.PHONY: test test-basic test-fast test-ring test-mempool test-perf
> > coverage test-drivers test-dump -test test-basic test-fast test-ring test-
> mempool test-perf coverage test-drivers test-dump:
> > +.PHONY: test test-fast test-perf coverage test-drivers test-dump test
> > +test-fast test-perf coverage test-drivers test-dump:
> 
> Why keeping test-ring test-mempool ?
> 

Test-ring and test-mempool are removed now. As they were unused from the past.

Thanks,
Reshma

[dpdk-dev] [PATCH] eal/bsd: silence not supported error in interrupts

[Anatoly Burakov]

Currently, nic_uio driver does not support interrupts, so any
attempts to install an interrupt handler will fail with a
not supported error, which will cause an error message that is
confusing to the user.

Silence this error by moving it to debug log level, and reword
the message to avoid containing the word "Error", to avoid
triggering DTS test failures [1].

[1] https://git.dpdk.org/tools/dts/tree/tests/
TestSuite_scatter.py?#n110

Fixes: 23150bd8d8a8 ("eal/bsd: add interrupt thread")

Signed-off-by: Anatoly Burakov 
---
 lib/librte_eal/bsdapp/eal/eal_interrupts.c | 14 --
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/bsdapp/eal/eal_interrupts.c 
b/lib/librte_eal/bsdapp/eal/eal_interrupts.c
index 29356f320..2feee2d52 100644
--- a/lib/librte_eal/bsdapp/eal/eal_interrupts.c
+++ b/lib/librte_eal/bsdapp/eal/eal_interrupts.c
@@ -156,8 +156,18 @@ rte_intr_callback_register(const struct rte_intr_handle 
*intr_handle,
 * add the intr file descriptor into wait list.
 */
if (kevent(kq, &ke, 1, NULL, 0, NULL) < 0) {
-   RTE_LOG(ERR, EAL, "Error adding fd %d kevent, %s\n",
-   src->intr_handle.fd, strerror(errno));
+   /* currently, nic_uio does not support interrupts, so
+* this error will always be triggered and output to the
+* user. so, don't output it unless debug log level set.
+*/
+   if (errno == ENODEV)
+   RTE_LOG(DEBUG, EAL, "Interrupt handle %d not 
supported\n",
+   src->intr_handle.fd);
+   else
+   RTE_LOG(ERR, EAL, "Error adding fd %d "
+   "kevent, %s\n",
+   src->intr_handle.fd,
+   strerror(errno));
ret = -errno;
goto fail;
}
-- 
2.17.1

Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again

[Pattan, Reshma]

Hi,

> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, July 26, 2018 9:05 PM
> To: Pattan, Reshma 
> Cc: dev@dpdk.org; Burakov, Anatoly ;
> Parthasarathy, JananeeX M 
> Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again
> 
> 17/07/2018 18:00, Reshma Pattan:
> > Previously, unit tests were running in groups. There were technical reasons
> why that was the case (mostly having to do with limiting memory), but it was
> hard to maintain and update the autotest script.
> >
> > In 18.05, limiting of memory at DPDK startup was no longer necessary, as
> DPDK allocates memory at runtime as needed. This has the implication that
> the old test grouping can now be retired and replaced with a more sensible
> way of running unit tests (using multiprocessing pool of workers and a queue
> of tests). This patchset accomplishes exactly that.
> >
> > This patchset merges changes done in [1], [2]
> >
> > [1] http://dpdk.org/dev/patchwork/patch/40370/
> > [2] http://patches.dpdk.org/patch/40373/
> >
> > Removed unused and duplicate make rules for test-basic, test-mempool,
> > test-ring from make file system in patch 10/10.
> >
> > v4: Removed unused and duplicate make rules for test-basic,
> > test-mempool, test-ring from make file system in patch 10/10.
> >
> > Reshma Pattan (10):
> >   autotest: fix printing
> >   autotest: fix invalid code on reports
> >   autotest: make autotest runner python 2/3 compliant
> >   autotest: visually separate different test categories
> >   autotest: improve filtering
> >   autotest: remove autotest grouping
> >   autotest: properly parallelize unit tests
> >   autotest: update autotest test case list
> >   mk: update make targets for classified testcases
> >   mk: remove unnecessary make rules of test
> 
> Patches 1 to 7 are from Anatoly.
> Patches 8 and 9 were initiated by Jananee.

The respective patches have i.e 1 to 7 have Anatolys Signed--off
And 8 and 9 have Jananees Signed-off along with mine. 

I have used git-am. What I am missing here?

Thanks,
Reshma

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 10/10] mk: remove unnecessary make rules of test

[Thomas Monjalon]

27/07/2018 10:22, Pattan, Reshma:
> Hi,
> 
> > -Original Message-
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > Sent: Thursday, July 26, 2018 9:08 PM
> > To: Pattan, Reshma 
> > Cc: sta...@dpdk.org; dev@dpdk.org; Burakov, Anatoly
> > ; Parthasarathy, JananeeX M
> > ; Yigit, Ferruh
> > 
> > Subject: Re: [dpdk-stable] [PATCH v5 10/10] mk: remove unnecessary make
> > rules of test
> > 
> > 17/07/2018 18:00, Reshma Pattan:
> > > make rule test-basic is duplicate of test rule.
> > > removed unused test-mempool and test-ring make rules.
> > >
> > > Fixes: a3df7f8d9c ("mk: rename test related rules")
> > > Fixes: a3df7f8d9c ("mk: rename test related rules")
> > > CC: sta...@dpdk.org
> > > CC: ferruh.yi...@intel.com
> > >
> > > Signed-off-by: Reshma Pattan 
> > > ---
> > > -.PHONY: test test-basic test-fast test-ring test-mempool test-perf
> > > coverage test-drivers test-dump -test test-basic test-fast test-ring test-
> > mempool test-perf coverage test-drivers test-dump:
> > > +.PHONY: test test-fast test-perf coverage test-drivers test-dump test
> > > +test-fast test-perf coverage test-drivers test-dump:
> > 
> > Why keeping test-ring test-mempool ?
> > 
> 
> Test-ring and test-mempool are removed now. As they were unused from the past.

Reading again, yes, this commit is about removing them.
Sorry, my question is a non-sense :)

Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again

[Burakov, Anatoly]

On 27-Jul-18 9:36 AM, Pattan, Reshma wrote:

Hi,


-Original Message-
From: Thomas Monjalon [mailto:tho...@monjalon.net]
Sent: Thursday, July 26, 2018 9:05 PM
To: Pattan, Reshma 
Cc: dev@dpdk.org; Burakov, Anatoly ;
Parthasarathy, JananeeX M 
Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again

17/07/2018 18:00, Reshma Pattan:

Previously, unit tests were running in groups. There were technical reasons

why that was the case (mostly having to do with limiting memory), but it was
hard to maintain and update the autotest script.


In 18.05, limiting of memory at DPDK startup was no longer necessary, as

DPDK allocates memory at runtime as needed. This has the implication that
the old test grouping can now be retired and replaced with a more sensible
way of running unit tests (using multiprocessing pool of workers and a queue
of tests). This patchset accomplishes exactly that.


This patchset merges changes done in [1], [2]

[1] http://dpdk.org/dev/patchwork/patch/40370/
[2] http://patches.dpdk.org/patch/40373/

Removed unused and duplicate make rules for test-basic, test-mempool,
test-ring from make file system in patch 10/10.

v4: Removed unused and duplicate make rules for test-basic,
test-mempool, test-ring from make file system in patch 10/10.

Reshma Pattan (10):
   autotest: fix printing
   autotest: fix invalid code on reports
   autotest: make autotest runner python 2/3 compliant
   autotest: visually separate different test categories
   autotest: improve filtering
   autotest: remove autotest grouping
   autotest: properly parallelize unit tests
   autotest: update autotest test case list
   mk: update make targets for classified testcases
   mk: remove unnecessary make rules of test


Patches 1 to 7 are from Anatoly.
Patches 8 and 9 were initiated by Jananee.


The respective patches have i.e 1 to 7 have Anatolys Signed--off
And 8 and 9 have Jananees Signed-off along with mine.

I have used git-am. What I am missing here?

Thanks,
Reshma



The signoff is part of commit message, but the author name is part of 
commit metadata. I.e. as it stands, if these patches are applied, the 
commit message says i am the author, but the actual commit metadata says 
it's you.


Use "git show --pretty=fuller" to see who is the author and who is the 
committer of each commit. To fix each commit, do an interactive rebase, 
stop after each commit (i.e. mark each commit as "edit") and do


git commit --amend --author="Author Name "

(this is a brute force way - a "smarter" way would be to use git 
filter-branch, but IMO it's overkill unless you do that often and 
already have all necessary scripts ready and set up :) )


--
Thanks,
Anatoly

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

[Thomas Monjalon]

27/07/2018 10:22, Alejandro Lucero:
> Thomas Monjalon  wrote:
> > 27/07/2018 09:03, Alejandro Lucero:
> > > Thomas Monjalon  wrote:
> > > > 10/07/2018 19:25, Alejandro Lucero:
> > > > > This patchset applies on 17.11.3.
> > > > >
> > > > > Similar changes will be submitted to main DPDK branch soon.
> > > >
> > > > In patchwork, I mark this patchset as Deferred,
> > > > waiting a new version for 18.11.

> > > Hi Thomas,
> > >
> > > Why deferred? This patch is only to be applied to 17.11.3. Because the
> > > changes the memory code has gone through the last months, the same fix
> > will
> > > be different for newer versions.
> >
> > OK, I can change them to "Not Applicable".
> >
> It is not applicable to master but it should for 17.11.3. Adding
> sta...@dpdk.org to this thread.

The process is to send the patches to sta...@dpdk.org with
[PATCH 17.11] in the subject.
Then it must decided of accepting the exception or not.

> > > I'm working on it but waiting all the current patches from Anatoly being
> > > accepted for creating the final patchset.
> >
> > Is there still some patches which are not applied?
> >
> Uhmm, maybe a patch for 18.11 could be created now. I was thinking about
> these ones:
> 
> Support externally allocated memory in DPDK
> Support running DPDK without hugetlbfs mountpoint
> 
> But they are not going to be in 18.11, so I will submit the patch asap, but
> I'm afraid it will be for stable 18.11.1
> Next three weeks I'm on PTO, so hopefully I can submit the patch early
> September.

We are not going to apply them to 18.11.1. It should be in 18.11.0.
If you send them really early September, it can be fine.

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

[Burakov, Anatoly]

On 27-Jul-18 9:22 AM, Alejandro Lucero wrote:



On Fri, Jul 27, 2018 at 10:01 AM, Thomas Monjalon > wrote:


27/07/2018 09:03, Alejandro Lucero:
> Hi Thomas,
> 
> Why deferred? This patch is only to be applied to 17.11.3. Because the

> changes the memory code has gone through the last months, the same fix 
will
> be different for newer versions.

OK, I can change them to "Not Applicable".


It is not applicable to master but it should for 17.11.3. Adding 
sta...@dpdk.org  to this thread.


> I'm working on it but waiting all the current patches from Anatoly being
> accepted for creating the final patchset.

Is there still some patches which are not applied?



Uhmm, maybe a patch for 18.11 could be created now. I was thinking about 
these ones:


Support externally allocated memory in DPDK


Support running DPDK without hugetlbfs mountpoint


External memory allocators is an RFC intended for 18.11. In-memory mode 
patches are already applied IIRC.





But they are not going to be in 18.11, so I will submit the patch asap, 
but I'm afraid it will be for stable 18.11.1
Next three weeks I'm on PTO, so hopefully I can submit the patch early 
September.




 > On Thu, Jul 26, 2018 at 5:41 PM, Thomas Monjalon
mailto:tho...@monjalon.net>>
 > wrote:
 >
 > > 10/07/2018 19:25, Alejandro Lucero:
 > > > This patchset applies on 17.11.3.
 > > >
 > > > Similar changes will be submitted to main DPDK branch soon.
 > >
 > > In patchwork, I mark this patchset as Deferred,
 > > waiting a new version for 18.11.
 > >
 > >
 > >
 >









--
Thanks,
Anatoly

Re: [dpdk-dev] [PATCH v4 0/5] use IOVAs check based on DMA mask

[Alejandro Lucero]

On Fri, Jul 27, 2018 at 10:52 AM, Thomas Monjalon 
wrote:

> 27/07/2018 10:22, Alejandro Lucero:
> > Thomas Monjalon  wrote:
> > > 27/07/2018 09:03, Alejandro Lucero:
> > > > Thomas Monjalon  wrote:
> > > > > 10/07/2018 19:25, Alejandro Lucero:
> > > > > > This patchset applies on 17.11.3.
> > > > > >
> > > > > > Similar changes will be submitted to main DPDK branch soon.
> > > > >
> > > > > In patchwork, I mark this patchset as Deferred,
> > > > > waiting a new version for 18.11.
>
> > > > Hi Thomas,
> > > >
> > > > Why deferred? This patch is only to be applied to 17.11.3. Because
> the
> > > > changes the memory code has gone through the last months, the same
> fix
> > > will
> > > > be different for newer versions.
> > >
> > > OK, I can change them to "Not Applicable".
> > >
> > It is not applicable to master but it should for 17.11.3. Adding
> > sta...@dpdk.org to this thread.
>
> The process is to send the patches to sta...@dpdk.org with
> [PATCH 17.11] in the subject.
> Then it must decided of accepting the exception or not.
>
>
OK. I'll do that then.


> > > > I'm working on it but waiting all the current patches from Anatoly
> being
> > > > accepted for creating the final patchset.
> > >
> > > Is there still some patches which are not applied?
> > >
> > Uhmm, maybe a patch for 18.11 could be created now. I was thinking about
> > these ones:
> >
> > Support externally allocated memory in DPDK
> > Support running DPDK without hugetlbfs mountpoint
> >
> > But they are not going to be in 18.11, so I will submit the patch asap,
> but
> > I'm afraid it will be for stable 18.11.1
> > Next three weeks I'm on PTO, so hopefully I can submit the patch early
> > September.
>
> We are not going to apply them to 18.11.1. It should be in 18.11.0.
> If you send them really early September, it can be fine.
>
>
Good. Thanks!

[dpdk-dev] [PATCH v6 00/10] Make unit tests great again

[Reshma Pattan]

Previously, unit tests were running in groups. There were technical
reasons why that was the case (mostly having to do with limiting memory),
but it was hard to maintain and update the autotest script.
In 18.05, limiting of memory at DPDK startup was no longer necessary,
as DPDK allocates memory at runtime as needed. This has the implication
that the old test grouping can now be retired and replaced with a more
sensible way of running unit tests (using multiprocessing pool of workers
and a queue of tests). This patchset accomplishes exactly that.

This patchset merges changes done in [1], [2]

[1] http://dpdk.org/dev/patchwork/patch/40370/
[2] http://patches.dpdk.org/patch/40373/

Removed unused and duplicate make rules for test-basic, 
test-mempool, test-ring from make file system in patch 10/10.

v5: Corrected the patch Authorship.


Anatoly Burakov (7):
  autotest: fix printing
  autotest: fix invalid code on reports
  autotest: make autotest runner python 2/3 compliant
  autotest: visually separate different test categories
  autotest: improve filtering
  autotest: remove autotest grouping
  autotest: properly parallelize unit tests

Jananee Parthasarathy (2):
  autotest: update autotest test case list
  mk: update make targets for classified testcases

Reshma Pattan (1):
  mk: remove unnecessary make rules of test

 mk/rte.sdkroot.mk|4 +-
 mk/rte.sdktest.mk|   32 +-
 test/test/autotest.py|   13 +-
 test/test/autotest_data.py   | 1081 +-
 test/test/autotest_runner.py |  519 ++--
 5 files changed, 947 insertions(+), 702 deletions(-)

-- 
2.14.4

[dpdk-dev] [PATCH v6 01/10] autotest: fix printing

[Reshma Pattan]

From: Anatoly Burakov 

Previously, printing was done using tuple syntax, which caused
output to appear as a tuple as opposed to being one string. Fix
this by using addition operator instead.

Fixes: 54ca545dce4b ("make python scripts python2/3 compliant")
Cc: john.mcnam...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Anatoly Burakov 
---
 test/test/autotest_runner.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py
index a692f0697..b09b57876 100644
--- a/test/test/autotest_runner.py
+++ b/test/test/autotest_runner.py
@@ -247,7 +247,7 @@ def __process_results(self, results):
 
 # don't print out total time every line, it's the same anyway
 if i == len(results) - 1:
-print(result,
+print(result +
   "[%02dm %02ds]" % (total_time / 60, total_time % 60))
 else:
 print(result)
@@ -332,8 +332,8 @@ def run_all_tests(self):
 
 # create table header
 print("")
-print("Test name".ljust(30), "Test result".ljust(29),
-  "Test".center(9), "Total".center(9))
+print("Test name".ljust(30) + "Test result".ljust(29) +
+  "Test".center(9) + "Total".center(9))
 print("=" * 80)
 
 # make a note of tests start time
-- 
2.14.4

[dpdk-dev] [PATCH v6 02/10] autotest: fix invalid code on reports

[Reshma Pattan]

From: Anatoly Burakov 

There are no reports defined for any test, so this codepath was
never triggered, but it's still wrong because it's referencing
variables that aren't there. Fix it by passing target into the
test function, and reference correct log variable.

Fixes: e2cc79b75d9f ("app: rework autotest.py")
Cc: sta...@dpdk.org

Signed-off-by: Anatoly Burakov 
---
 test/test/autotest_runner.py | 12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py
index b09b57876..bdc32da5d 100644
--- a/test/test/autotest_runner.py
+++ b/test/test/autotest_runner.py
@@ -41,7 +41,7 @@ def wait_prompt(child):
 # quite a bit of effort to make it work).
 
 
-def run_test_group(cmdline, test_group):
+def run_test_group(cmdline, target, test_group):
 results = []
 child = None
 start_time = time.time()
@@ -128,14 +128,15 @@ def run_test_group(cmdline, test_group):
 # make a note when the test was finished
 end_time = time.time()
 
+log = logfile.getvalue()
+
 # append test data to the result tuple
-result += (test["Name"], end_time - start_time,
-   logfile.getvalue())
+result += (test["Name"], end_time - start_time, log)
 
 # call report function, if any defined, and supply it with
 # target and complete log for test run
 if test["Report"]:
-report = test["Report"](self.target, log)
+report = test["Report"](target, log)
 
 # append report to results tuple
 result += (report,)
@@ -343,6 +344,7 @@ def run_all_tests(self):
 for test_group in self.parallel_test_groups:
 result = pool.apply_async(run_test_group,
   [self.__get_cmdline(test_group),
+   self.target,
test_group])
 results.append(result)
 
@@ -367,7 +369,7 @@ def run_all_tests(self):
 # run non_parallel tests. they are run one by one, synchronously
 for test_group in self.non_parallel_test_groups:
 group_result = run_test_group(
-self.__get_cmdline(test_group), test_group)
+self.__get_cmdline(test_group), self.target, test_group)
 
 self.__process_results(group_result)
 
-- 
2.14.4

[dpdk-dev] [PATCH v6 05/10] autotest: improve filtering

[Reshma Pattan]

From: Anatoly Burakov 

Improve code for filtering test groups. Also, move reading binary
symbols into filtering stage, so that tests that are meant to be
skipped are never attempted to be executed in the first place.
Before running tests, print out any tests that were skipped because
they weren't compiled.

Cc: sta...@dpdk.org

Signed-off-by: Anatoly Burakov 
---
 test/test/autotest_runner.py | 118 ---
 1 file changed, 66 insertions(+), 52 deletions(-)

diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py
index d9d5f7a97..c98ec2a57 100644
--- a/test/test/autotest_runner.py
+++ b/test/test/autotest_runner.py
@@ -95,13 +95,6 @@ def run_test_group(cmdline, target, test_group):
 results.append((0, "Success", "Start %s" % test_group["Prefix"],
 time.time() - start_time, startuplog.getvalue(), None))
 
-# parse the binary for available test commands
-binary = cmdline.split()[0]
-stripped = 'not stripped' not in subprocess.check_output(['file', binary])
-if not stripped:
-symbols = subprocess.check_output(['nm', binary]).decode('utf-8')
-avail_cmds = re.findall('test_register_(\w+)', symbols)
-
 # run all tests in test group
 for test in test_group["Tests"]:
 
@@ -121,10 +114,7 @@ def run_test_group(cmdline, target, test_group):
 print("\n%s %s\n" % ("-" * 20, test["Name"]), file=logfile)
 
 # run test function associated with the test
-if stripped or test["Command"] in avail_cmds:
-result = test["Func"](child, test["Command"])
-else:
-result = (0, "Skipped [Not Available]")
+result = test["Func"](child, test["Command"])
 
 # make a note when the test was finished
 end_time = time.time()
@@ -186,8 +176,10 @@ class AutotestRunner:
 def __init__(self, cmdline, target, blacklist, whitelist):
 self.cmdline = cmdline
 self.target = target
+self.binary = cmdline.split()[0]
 self.blacklist = blacklist
 self.whitelist = whitelist
+self.skipped = []
 
 # log file filename
 logfile = "%s.log" % target
@@ -276,53 +268,58 @@ def __process_results(self, results):
 if i != 0:
 self.csvwriter.writerow([test_name, test_result, result_str])
 
-# this function iterates over test groups and removes each
-# test that is not in whitelist/blacklist
-def __filter_groups(self, test_groups):
-groups_to_remove = []
-
-# filter out tests from parallel test groups
-for i, test_group in enumerate(test_groups):
-
-# iterate over a copy so that we could safely delete individual
-# tests
-for test in test_group["Tests"][:]:
-test_id = test["Command"]
-
-# dump tests are specified in full e.g. "Dump_mempool"
-if "_autotest" in test_id:
-test_id = test_id[:-len("_autotest")]
-
-# filter out blacklisted/whitelisted tests
-if self.blacklist and test_id in self.blacklist:
-test_group["Tests"].remove(test)
-continue
-if self.whitelist and test_id not in self.whitelist:
-test_group["Tests"].remove(test)
-continue
-
-# modify or remove original group
-if len(test_group["Tests"]) > 0:
-test_groups[i] = test_group
-else:
-# remember which groups should be deleted
-# put the numbers backwards so that we start
-# deleting from the end, not from the beginning
-groups_to_remove.insert(0, i)
+# this function checks individual test and decides if this test should be 
in
+# the group by comparing it against  whitelist/blacklist. it also checks if
+# the test is compiled into the binary, and marks it as skipped if 
necessary
+def __filter_test(self, test):
+test_cmd = test["Command"]
+test_id = test_cmd
+
+# dump tests are specified in full e.g. "Dump_mempool"
+if "_autotest" in test_id:
+test_id = test_id[:-len("_autotest")]
+
+# filter out blacklisted/whitelisted tests
+if self.blacklist and test_id in self.blacklist:
+return False
+if self.whitelist and test_id not in self.whitelist:
+return False
+
+# if test wasn't compiled in, remove it as well
+
+# parse the binary for available test commands
+stripped = 'not stripped' not in \
+   subprocess.check_output(['file', self.binary])
+if not stripped:
+symbols = subprocess.check_output(['nm',
+   self.binary]).decode('utf-8')
+avail_cmds = re.findall('test_register_(\w+)', symbols)
+

[dpdk-dev] [PATCH v6 03/10] autotest: make autotest runner python 2/3 compliant

[Reshma Pattan]

From: Anatoly Burakov 

Autotest runner was still using python 2-style print syntax. Fix
it by importing print function from the future, and fix the calls
to be python-3 style.

Fixes: 54ca545dce4b ("make python scripts python2/3 compliant")
Cc: john.mcnam...@intel.com
Cc: sta...@dpdk.org

Signed-off-by: Anatoly Burakov 
---
 test/test/autotest_runner.py | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py
index bdc32da5d..f6b669a2e 100644
--- a/test/test/autotest_runner.py
+++ b/test/test/autotest_runner.py
@@ -3,6 +3,7 @@
 
 # The main logic behind running autotests in parallel
 
+from __future__ import print_function
 import StringIO
 import csv
 import multiprocessing
@@ -52,8 +53,8 @@ def run_test_group(cmdline, target, test_group):
 # prepare logging of init
 startuplog = StringIO.StringIO()
 
-print >>startuplog, "\n%s %s\n" % ("=" * 20, test_group["Prefix"])
-print >>startuplog, "\ncmdline=%s" % cmdline
+print("\n%s %s\n" % ("=" * 20, test_group["Prefix"]), file=startuplog)
+print("\ncmdline=%s" % cmdline, file=startuplog)
 
 child = pexpect.spawn(cmdline, logfile=startuplog)
 
@@ -117,7 +118,7 @@ def run_test_group(cmdline, target, test_group):
 
 try:
 # print test name to log buffer
-print >>logfile, "\n%s %s\n" % ("-" * 20, test["Name"])
+print("\n%s %s\n" % ("-" * 20, test["Name"]), file=logfile)
 
 # run test function associated with the test
 if stripped or test["Command"] in avail_cmds:
-- 
2.14.4

[dpdk-dev] [PATCH v6 04/10] autotest: visually separate different test categories

[Reshma Pattan]

From: Anatoly Burakov 

Help visually identify parallel vs. non-parallel autotests.

Cc: sta...@dpdk.org

Signed-off-by: Anatoly Burakov 
---
 test/test/autotest_runner.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py
index f6b669a2e..d9d5f7a97 100644
--- a/test/test/autotest_runner.py
+++ b/test/test/autotest_runner.py
@@ -341,6 +341,7 @@ def run_all_tests(self):
 # make a note of tests start time
 self.start = time.time()
 
+print("Parallel autotests:")
 # assign worker threads to run test groups
 for test_group in self.parallel_test_groups:
 result = pool.apply_async(run_test_group,
@@ -367,6 +368,7 @@ def run_all_tests(self):
 # remove result from results list once we're done with it
 results.remove(group_result)
 
+print("Non-parallel autotests:")
 # run non_parallel tests. they are run one by one, synchronously
 for test_group in self.non_parallel_test_groups:
 group_result = run_test_group(
-- 
2.14.4

[dpdk-dev] [PATCH v6 06/10] autotest: remove autotest grouping

[Reshma Pattan]

From: Anatoly Burakov 

Previously, all autotests were grouped into (seemingly arbitrary)
groups. The goal was to run all tests in parallel (so that autotest
finishes faster), but we couldn't just do it willy-nilly because
DPDK couldn't allocate and free hugepages on-demand, so we had to
find autotest groupings that could work memory-wise and still be
fast enough to not hold up shorter tests. The inflexibility of
memory subsystem has now been fixed for 18.05, so grouping
autotests is no longer necessary.

Thus, this commit moves all autotests into two groups -
parallel(izable) autotests, and non-arallel(izable) autotests
(typically performance tests). Note that this particular commit
makes running autotests dog slow because while the tests are now
in a single group, the test function itself hasn't changed much,
so all autotests are now run one-by-one, starting and stopping
the DPDK test application.

Signed-off-by: Anatoly Burakov 
---
 test/test/autotest.py|   7 +-
 test/test/autotest_data.py   | 749 +--
 test/test/autotest_runner.py | 271 ++--
 3 files changed, 408 insertions(+), 619 deletions(-)

diff --git a/test/test/autotest.py b/test/test/autotest.py
index 1cfd8cf22..ae27daef7 100644
--- a/test/test/autotest.py
+++ b/test/test/autotest.py
@@ -39,11 +39,8 @@ def usage():
 runner = autotest_runner.AutotestRunner(cmdline, target, test_blacklist,
 test_whitelist)
 
-for test_group in autotest_data.parallel_test_group_list:
-runner.add_parallel_test_group(test_group)
-
-for test_group in autotest_data.non_parallel_test_group_list:
-runner.add_non_parallel_test_group(test_group)
+runner.parallel_tests = autotest_data.parallel_test_list[:]
+runner.non_parallel_tests = autotest_data.non_parallel_test_list[:]
 
 num_fails = runner.run_all_tests()
 
diff --git a/test/test/autotest_data.py b/test/test/autotest_data.py
index aacfe0a66..c24e7bc25 100644
--- a/test/test/autotest_data.py
+++ b/test/test/autotest_data.py
@@ -3,465 +3,322 @@
 
 # Test data for autotests
 
-from glob import glob
 from autotest_test_funcs import *
 
-
-# quick and dirty function to find out number of sockets
-def num_sockets():
-result = len(glob("/sys/devices/system/node/node*"))
-if result == 0:
-return 1
-return result
-
-
-# Assign given number to each socket
-# e.g. 32 becomes 32,32 or 32,32,32,32
-def per_sockets(num):
-return ",".join([str(num)] * num_sockets())
-
 # groups of tests that can be run in parallel
 # the grouping has been found largely empirically
-parallel_test_group_list = [
-{
-"Prefix":"group_1",
-"Memory":per_sockets(8),
-"Tests":
-[
-{
-"Name":"Cycles autotest",
-"Command": "cycles_autotest",
-"Func":default_autotest,
-"Report":  None,
-},
-{
-"Name":"Timer autotest",
-"Command": "timer_autotest",
-"Func":timer_autotest,
-"Report":   None,
-},
-{
-"Name":"Debug autotest",
-"Command": "debug_autotest",
-"Func":default_autotest,
-"Report":  None,
-},
-{
-"Name":"Errno autotest",
-"Command": "errno_autotest",
-"Func":default_autotest,
-"Report":  None,
-},
-{
-"Name":"Meter autotest",
-"Command": "meter_autotest",
-"Func":default_autotest,
-"Report":  None,
-},
-{
-"Name":"Common autotest",
-"Command": "common_autotest",
-"Func":default_autotest,
-"Report":  None,
-},
-{
-"Name":"Resource autotest",
-"Command": "resource_autotest",
-"Func":default_autotest,
-"Report":  None,
-},
-]
-},
-{
-"Prefix":"group_2",
-"Memory":"16",
-"Tests":
-[
-{
-"Name":"Memory autotest",
-"Command": "memory_autotest",
-"Func":memory_autotest,
-"Report":  None,
-},
-{
-"Name":"Read/write lock autotest",
-"Command": "rwlock_autotest",
-"Func":rwlock_autotest,
-"Report":  None,
-},
-{
-"Name":"Logs autotest",
-"Command": "logs_autotest",
-"Func":logs_autotest,
-"Report":  None,
-},
-{
-"Name":"CPU flags autotest",
-"Com

[dpdk-dev] [PATCH v6 07/10] autotest: properly parallelize unit tests

[Reshma Pattan]

From: Anatoly Burakov 

Now that everything else is in place, we can run unit tests in a
different fashion to what they were running as before. Previously,
we had all autotests as part of groups (largely obtained through
trial and error) to ensure parallel execution while still limiting
amounts of memory used by those tests.

This is no longer necessary, and as of previous commit, all tests
are now in the same group (still broken into two categories). They
still run one-by-one though. Fix this by initializing child
processes in multiprocessing Pool initialization, and putting all
tests on the queue, so that tests are executed by the first idle
worker. Tests are also affinitized to different NUMA nodes using
taskset in a round-robin fashion, to prevent over-exhausting
memory on any given NUMA node.

Non-parallel tests are executed in similar fashion, but on a
separate queue which will have only one pool worker, ensuring
non-parallel execution.

Support for FreeBSD is also added to ensure that on FreeBSD, all
tests are run sequentially even for the parallel section.

Cc: sta...@dpdk.org

Signed-off-by: Anatoly Burakov 
---
 test/test/autotest.py|   6 +-
 test/test/autotest_runner.py | 277 +++
 2 files changed, 183 insertions(+), 100 deletions(-)

diff --git a/test/test/autotest.py b/test/test/autotest.py
index ae27daef7..12997fdf0 100644
--- a/test/test/autotest.py
+++ b/test/test/autotest.py
@@ -36,8 +36,12 @@ def usage():
 
 print(cmdline)
 
+# how many workers to run tests with. FreeBSD doesn't support multiple primary
+# processes, so make it 1, otherwise make it 4. ignored for non-parallel tests
+n_processes = 1 if "bsdapp" in target else 4
+
 runner = autotest_runner.AutotestRunner(cmdline, target, test_blacklist,
-test_whitelist)
+test_whitelist, n_processes)
 
 runner.parallel_tests = autotest_data.parallel_test_list[:]
 runner.non_parallel_tests = autotest_data.non_parallel_test_list[:]
diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py
index d6ae57e76..36941a40a 100644
--- a/test/test/autotest_runner.py
+++ b/test/test/autotest_runner.py
@@ -6,16 +6,16 @@
 from __future__ import print_function
 import StringIO
 import csv
-import multiprocessing
+from multiprocessing import Pool, Queue
 import pexpect
 import re
 import subprocess
 import sys
 import time
+import glob
+import os
 
 # wait for prompt
-
-
 def wait_prompt(child):
 try:
 child.sendline()
@@ -28,22 +28,47 @@ def wait_prompt(child):
 else:
 return False
 
-# run a test group
-# each result tuple in results list consists of:
-#   result value (0 or -1)
-#   result string
-#   test name
-#   total test run time (double)
-#   raw test log
-#   test report (if not available, should be None)
-#
-# this function needs to be outside AutotestRunner class
-# because otherwise Pool won't work (or rather it will require
-# quite a bit of effort to make it work).
+
+# get all valid NUMA nodes
+def get_numa_nodes():
+return [
+int(
+re.match(r"node(\d+)", os.path.basename(node))
+.group(1)
+)
+for node in glob.glob("/sys/devices/system/node/node*")
+]
+
+
+# find first (or any, really) CPU on a particular node, will be used to spread
+# processes around NUMA nodes to avoid exhausting memory on particular node
+def first_cpu_on_node(node_nr):
+cpu_path = glob.glob("/sys/devices/system/node/node%d/cpu*" % node_nr)[0]
+cpu_name = os.path.basename(cpu_path)
+m = re.match(r"cpu(\d+)", cpu_name)
+return int(m.group(1))
+
+
+pool_child = None  # per-process child
 
 
-def run_test_group(cmdline, prefix, target, test):
+# we initialize each worker with a queue because we need per-pool unique
+# command-line arguments, but we cannot do different arguments in an 
initializer
+# because the API doesn't allow per-worker initializer arguments. so, instead,
+# we will initialize with a shared queue, and dequeue command-line arguments
+# from this queue
+def pool_init(queue, result_queue):
+global pool_child
+
+cmdline, prefix = queue.get()
 start_time = time.time()
+name = ("Start %s" % prefix) if prefix != "" else "Start"
+
+# use default prefix if no prefix was specified
+prefix_cmdline = "--file-prefix=%s" % prefix if prefix != "" else ""
+
+# append prefix to cmdline
+cmdline = "%s %s" % (cmdline, prefix_cmdline)
 
 # prepare logging of init
 startuplog = StringIO.StringIO()
@@ -54,24 +79,60 @@ def run_test_group(cmdline, prefix, target, test):
 print("\n%s %s\n" % ("=" * 20, prefix), file=startuplog)
 print("\ncmdline=%s" % cmdline, file=startuplog)
 
-child = pexpect.spawn(cmdline, logfile=startuplog)
+pool_child = pexpect.spawn(cmdline, logfile=startuplog)
 
 # wait for target to boot
-if not wait_prompt(child):
-chi

[dpdk-dev] [PATCH v6 08/10] autotest: update autotest test case list

[Reshma Pattan]

From: Jananee Parthasarathy 

Autotest is enhanced with additional test cases
being added to autotest_data.py

Removed non existing PCI autotest.

Cc: sta...@dpdk.org

Signed-off-by: Reshma Pattan 
Signed-off-by: Jananee Parthasarathy 
Reviewed-by: Anatoly Burakov 
---
 test/test/autotest_data.py | 350 +++--
 1 file changed, 342 insertions(+), 8 deletions(-)

diff --git a/test/test/autotest_data.py b/test/test/autotest_data.py
index c24e7bc25..3f856ff57 100644
--- a/test/test/autotest_data.py
+++ b/test/test/autotest_data.py
@@ -134,12 +134,6 @@
 "Func":default_autotest,
 "Report":  None,
 },
-{
-"Name":"PCI autotest",
-"Command": "pci_autotest",
-"Func":default_autotest,
-"Report":  None,
-},
 {
 "Name":"Malloc autotest",
 "Command": "malloc_autotest",
@@ -248,6 +242,291 @@
 "Func":default_autotest,
 "Report":  None,
 },
+{
+"Name":"Eventdev selftest octeontx",
+"Command": "eventdev_selftest_octeontx",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Event ring autotest",
+"Command": "event_ring_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Table autotest",
+"Command": "table_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Flow classify autotest",
+"Command": "flow_classify_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Event eth rx adapter autotest",
+"Command": "event_eth_rx_adapter_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"User delay",
+"Command": "user_delay_us",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Rawdev autotest",
+"Command": "rawdev_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Kvargs autotest",
+"Command": "kvargs_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Devargs autotest",
+"Command": "devargs_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Link bonding autotest",
+"Command": "link_bonding_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Link bonding mode4 autotest",
+"Command": "link_bonding_mode4_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Link bonding rssconf autotest",
+"Command": "link_bonding_rssconf_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Crc autotest",
+"Command": "crc_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Distributor autotest",
+"Command": "distributor_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Reorder autotest",
+"Command": "reorder_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Barrier autotest",
+"Command": "barrier_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Bitmap test",
+"Command": "bitmap_test",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Hash scaling autotest",
+"Command": "hash_scaling_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Hash multiwriter autotest",
+"Command": "hash_multiwriter_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Service autotest",
+"Command": "service_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Timer racecond autotest",
+"Command": "timer_racecond_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Member autotest",
+"Command": "member_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":   "Efd_autotest",
+"Command": "efd_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Thash autotest",
+"Command": "thash_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
+"Name":"Hash function autotest",
+"Comm

[dpdk-dev] [PATCH v6 09/10] mk: update make targets for classified testcases

[Reshma Pattan]

From: Jananee Parthasarathy 

Makefiles are updated with new test case lists.
Test cases are classified as -
P1 - Main test cases,
P2 - Cryptodev/driver test cases,
P3 - Perf test cases which takes longer than 10s,
P4 - Logging/Dump test cases.

Makefile is updated with different targets
for the above classified groups.
Test cases for different targets are listed accordingly.

Cc: sta...@dpdk.org

Signed-off-by: Jananee Parthasarathy 
Reviewed-by: Reshma Pattan 
Reviewed-by: Anatoly Burakov 
---
 mk/rte.sdkroot.mk |  4 ++--
 mk/rte.sdktest.mk | 33 +++--
 2 files changed, 29 insertions(+), 8 deletions(-)

diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
index f43cc7829..ea3473ebf 100644
--- a/mk/rte.sdkroot.mk
+++ b/mk/rte.sdkroot.mk
@@ -68,8 +68,8 @@ config defconfig showconfigs showversion showversionum:
 cscope gtags tags etags:
$(Q)$(RTE_SDK)/devtools/build-tags.sh $@ $T
 
-.PHONY: test test-basic test-fast test-ring test-mempool test-perf coverage
-test test-basic test-fast test-ring test-mempool test-perf coverage:
+.PHONY: test test-basic test-fast test-ring test-mempool test-perf coverage 
test-drivers test-dump
+test test-basic test-fast test-ring test-mempool test-perf coverage 
test-drivers test-dump:
$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@
 
 test: test-build
diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk
index ee1fe0c7e..13d1efb6a 100644
--- a/mk/rte.sdktest.mk
+++ b/mk/rte.sdktest.mk
@@ -18,14 +18,35 @@ DIR := $(shell basename $(RTE_OUTPUT))
 #
 # test: launch auto-tests, very simple for now.
 #
-.PHONY: test test-basic test-fast test-perf coverage
+.PHONY: test test-basic test-fast test-perf test-drivers test-dump coverage
 
-PERFLIST=ring_perf,mempool_perf,memcpy_perf,hash_perf,timer_perf
-coverage: BLACKLIST=-$(PERFLIST)
-test-fast: BLACKLIST=-$(PERFLIST)
-test-perf: WHITELIST=$(PERFLIST)
+PERFLIST=ring_perf,mempool_perf,memcpy_perf,hash_perf,timer_perf,\
+ reciprocal_division,reciprocal_division_perf,lpm_perf,red_all,\
+ barrier,hash_multiwriter,timer_racecond,efd,hash_functions,\
+ eventdev_selftest_sw,member_perf,efd_perf,lpm6_perf,red_perf,\
+ distributor_perf,ring_pmd_perf,pmd_perf,ring_perf
+DRIVERSLIST=link_bonding,link_bonding_mode4,link_bonding_rssconf,\
+cryptodev_sw_mrvl,cryptodev_dpaa2_sec,cryptodev_dpaa_sec,\
+cryptodev_qat,cryptodev_aesni_mb,cryptodev_openssl,\
+cryptodev_scheduler,cryptodev_aesni_gcm,cryptodev_null,\
+cryptodev_sw_snow3g,cryptodev_sw_kasumi,cryptodev_sw_zuc
+DUMPLIST=dump_struct_sizes,dump_mempool,dump_malloc_stats,dump_devargs,\
+ dump_log_types,dump_ring,quit,dump_physmem,dump_memzone,\
+ devargs_autotest
 
-test test-basic test-fast test-perf:
+SPACESTR:=
+SPACESTR+=
+STRIPPED_PERFLIST=$(subst $(SPACESTR),,$(PERFLIST))
+STRIPPED_DRIVERSLIST=$(subst $(SPACESTR),,$(DRIVERSLIST))
+STRIPPED_DUMPLIST=$(subst $(SPACESTR),,$(DUMPLIST))
+
+coverage: BLACKLIST=-$(STRIPPED_PERFLIST)
+test-fast: 
BLACKLIST=-$(STRIPPED_PERFLIST),$(STRIPPED_DRIVERSLIST),$(STRIPPED_DUMPLIST)
+test-perf: WHITELIST=$(STRIPPED_PERFLIST)
+test-drivers: WHITELIST=$(STRIPPED_DRIVERSLIST)
+test-dump: WHITELIST=$(STRIPPED_DUMPLIST)
+
+test test-basic test-fast test-perf test-drivers test-dump:
@mkdir -p $(AUTOTEST_DIR) ; \
cd $(AUTOTEST_DIR) ; \
if [ -f $(RTE_OUTPUT)/app/test ]; then \
-- 
2.14.4

[dpdk-dev] [PATCH v6 10/10] mk: remove unnecessary make rules of test

[Reshma Pattan]

From: Reshma Pattan 

make rule test-basic is duplicate of test rule.
removed unused test-mempool and test-ring make rules.

Fixes: a3df7f8d9c ("mk: rename test related rules")
CC: sta...@dpdk.org
CC: ferruh.yi...@intel.com

Signed-off-by: Reshma Pattan 
Reviewed-by: Anatoly Burakov 
---
 mk/rte.sdkroot.mk | 4 ++--
 mk/rte.sdktest.mk | 7 +++
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
index ea3473ebf..18c88017e 100644
--- a/mk/rte.sdkroot.mk
+++ b/mk/rte.sdkroot.mk
@@ -68,8 +68,8 @@ config defconfig showconfigs showversion showversionum:
 cscope gtags tags etags:
$(Q)$(RTE_SDK)/devtools/build-tags.sh $@ $T
 
-.PHONY: test test-basic test-fast test-ring test-mempool test-perf coverage 
test-drivers test-dump
-test test-basic test-fast test-ring test-mempool test-perf coverage 
test-drivers test-dump:
+.PHONY: test test-fast test-perf coverage test-drivers test-dump
+test test-fast test-perf coverage test-drivers test-dump:
$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@
 
 test: test-build
diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk
index 13d1efb6a..295592809 100644
--- a/mk/rte.sdktest.mk
+++ b/mk/rte.sdktest.mk
@@ -18,7 +18,7 @@ DIR := $(shell basename $(RTE_OUTPUT))
 #
 # test: launch auto-tests, very simple for now.
 #
-.PHONY: test test-basic test-fast test-perf test-drivers test-dump coverage
+.PHONY: test test-fast test-perf test-drivers test-dump coverage
 
 PERFLIST=ring_perf,mempool_perf,memcpy_perf,hash_perf,timer_perf,\
  reciprocal_division,reciprocal_division_perf,lpm_perf,red_all,\
@@ -31,8 +31,7 @@ 
DRIVERSLIST=link_bonding,link_bonding_mode4,link_bonding_rssconf,\
 cryptodev_scheduler,cryptodev_aesni_gcm,cryptodev_null,\
 cryptodev_sw_snow3g,cryptodev_sw_kasumi,cryptodev_sw_zuc
 DUMPLIST=dump_struct_sizes,dump_mempool,dump_malloc_stats,dump_devargs,\
- dump_log_types,dump_ring,quit,dump_physmem,dump_memzone,\
- devargs_autotest
+ dump_log_types,dump_ring,dump_physmem,dump_memzone
 
 SPACESTR:=
 SPACESTR+=
@@ -46,7 +45,7 @@ test-perf: WHITELIST=$(STRIPPED_PERFLIST)
 test-drivers: WHITELIST=$(STRIPPED_DRIVERSLIST)
 test-dump: WHITELIST=$(STRIPPED_DUMPLIST)
 
-test test-basic test-fast test-perf test-drivers test-dump:
+test test-fast test-perf test-drivers test-dump:
@mkdir -p $(AUTOTEST_DIR) ; \
cd $(AUTOTEST_DIR) ; \
if [ -f $(RTE_OUTPUT)/app/test ]; then \
-- 
2.14.4

Re: [dpdk-dev] [PATCH] examples/l3fw-power: do not exit on power lib init failure

[Radu Nicolau]

On 7/26/2018 6:39 PM, De Lara Guarch, Pablo wrote:

Hi Radu,


-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau
Sent: Wednesday, July 18, 2018 2:50 PM
To: dev@dpdk.org
Cc: Hunt, David ; Yao, Lei A ;
Nicolau, Radu 
Subject: [dpdk-dev] [PATCH] examples/l3fw-power: do not exit on power lib init
failure

Do not exit the application if power library fails to initialize or high 
performance
cores configuration cannot be used.

I would say this deserves more explanation. It doesn't look correct to me to 
keep log an error that
the power library couldn't be initialized and still the sample application 
keeps running.
The application can also be used without the power library features, and 
this was also the previous behavior, before high/regular performance 
core feature was added.


Actually, the way init_power_library is coded, it returns the output of the 
call of rte_power_init on the last core
(ret is overwritten for each core), which looks wrong to me.
I will update init_power_library to return -1 if rte_power_init fails 
for at least one core.


Thanks,
Pablo

Signed-off-by: Radu Nicolau 
---

[dpdk-dev] [PATCH v2] examples/l3fw-power: do not exit on power lib init failure

[Radu Nicolau]

Do not exit the application if power library fails to initialize
or high performance cores configuration cannot be used.

Signed-off-by: Radu Nicolau 
---
v2: updated init_power_library to return error code if any core init fails


 examples/l3fwd-power/main.c | 10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index d15cd52..e73b853 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1638,11 +1638,13 @@ init_power_library(void)
for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
if (rte_lcore_is_enabled(lcore_id)) {
/* init power management library */
-   ret = rte_power_init(lcore_id);
-   if (ret)
+   int cpi_ret = rte_power_init(lcore_id);
+   if (cpi_ret) {
RTE_LOG(ERR, POWER,
"Library initialization failed on core %u\n",
lcore_id);
+   ret = -1;
+   }
}
}
return ret;
@@ -1683,10 +1685,10 @@ main(int argc, char **argv)
rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n");
 
if (init_power_library())
-   rte_exit(EXIT_FAILURE, "init_power_library failed\n");
+   RTE_LOG(ERR, POWER, "init_power_library failed\n");
 
if (update_lcore_params() < 0)
-   rte_exit(EXIT_FAILURE, "update_lcore_params failed\n");
+   RTE_LOG(ERR, POWER, "update_lcore_params failed\n");
 
if (check_lcore_params() < 0)
rte_exit(EXIT_FAILURE, "check_lcore_params failed\n");
-- 
2.7.5

Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again

[Pattan, Reshma]

Hi,

> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, July 26, 2018 9:05 PM
> To: Pattan, Reshma 
> Cc: dev@dpdk.org; Burakov, Anatoly ;
> Parthasarathy, JananeeX M 
> Subject: Re: [dpdk-dev] [PATCH v5 00/10] Make unit tests great again
> > Reshma Pattan (10):
> >   autotest: fix printing
> >   autotest: fix invalid code on reports
> >   autotest: make autotest runner python 2/3 compliant
> >   autotest: visually separate different test categories
> >   autotest: improve filtering
> >   autotest: remove autotest grouping
> >   autotest: properly parallelize unit tests
> >   autotest: update autotest test case list
> >   mk: update make targets for classified testcases
> >   mk: remove unnecessary make rules of test
> 
> Patches 1 to 7 are from Anatoly.
> Patches 8 and 9 were initiated by Jananee.
> 
> Please fix authorship of these patches.
> Note: it should not happen if you use git-am to get the patches.
> 

Addressed in v6 and sent.

Thanks,
Reshma

Re: [dpdk-dev] [PATCH v2] net/bonding: fix race condition

[Chas Williams]

On Wed, Jul 25, 2018 at 5:46 AM Radu Nicolau  wrote:

> Race condition can appear in the bond_mode_8023ad_periodic_cb()
> callback when bonding port is stopped, reconfigured and restarted.
>
> Re-ordered calls in bond_ethdev_start() to have callback alarm set
> after slave ports are reconfigured.
>
> Fixes: 2efb58cbab6e ("bond: new link bonding library")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Radu Nicolau 
>

Acked-by: Chas Williams 


> ---
> v2: reworked patch
>
>  drivers/net/bonding/rte_eth_bond_pmd.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> b/drivers/net/bonding/rte_eth_bond_pmd.c
> index fc4d4fd..70ec728 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -2113,10 +2113,6 @@ bond_ethdev_start(struct rte_eth_dev *eth_dev)
> }
> }
>
> -   /* Update all slave devices MACs*/
> -   if (mac_address_slaves_update(eth_dev) != 0)
> -   goto out_err;
> -
> /* If bonded device is configure in promiscuous mode then re-apply
> config */
> if (internals->promiscuous_en)
> bond_ethdev_promiscuous_enable(eth_dev);
> @@ -2157,6 +2153,10 @@ bond_ethdev_start(struct rte_eth_dev *eth_dev)
> (void *)&rte_eth_devices[internals->port_id]);
> }
>
> +   /* Update all slave devices MACs*/
> +   if (mac_address_slaves_update(eth_dev) != 0)
> +   goto out_err;
> +
> if (internals->user_defined_primary_port)
> bond_ethdev_primary_set(internals,
> internals->primary_port);
>
> --
> 2.7.5
>
>

[dpdk-dev] [PATCH v2 2/2] mempool: fold memory size calculation helper

[Andrew Rybchenko]

rte_mempool_calc_mem_size_helper() was introduced to avoid
code duplication and used in deprecated rte_mempool_mem_size() and
rte_mempool_op_calc_mem_size_default(). Now the first one is removed
and it is better to fold the helper into the second one to make it
more readable.

Signed-off-by: Andrew Rybchenko 
---
 lib/librte_mempool/rte_mempool.c | 25 
 lib/librte_mempool/rte_mempool.h | 22 -
 lib/librte_mempool/rte_mempool_ops_default.c | 25 +---
 3 files changed, 22 insertions(+), 50 deletions(-)

diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index d48e53c7e..52bc97a75 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -225,31 +225,6 @@ rte_mempool_calc_obj_size(uint32_t elt_size, uint32_t 
flags,
return sz->total_size;
 }
 
-
-/*
- * Internal function to calculate required memory chunk size.
- */
-size_t
-rte_mempool_calc_mem_size_helper(uint32_t elt_num, size_t total_elt_sz,
-uint32_t pg_shift)
-{
-   size_t obj_per_page, pg_num, pg_sz;
-
-   if (total_elt_sz == 0)
-   return 0;
-
-   if (pg_shift == 0)
-   return total_elt_sz * elt_num;
-
-   pg_sz = (size_t)1 << pg_shift;
-   obj_per_page = pg_sz / total_elt_sz;
-   if (obj_per_page == 0)
-   return RTE_ALIGN_CEIL(total_elt_sz, pg_sz) * elt_num;
-
-   pg_num = (elt_num + obj_per_page - 1) / obj_per_page;
-   return pg_num << pg_shift;
-}
-
 /* free a memchunk allocated with rte_memzone_reserve() */
 static void
 rte_mempool_memchunk_mz_free(__rte_unused struct rte_mempool_memhdr *memhdr,
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 5d1602555..7c9cd9a2f 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -487,28 +487,6 @@ ssize_t rte_mempool_op_calc_mem_size_default(const struct 
rte_mempool *mp,
uint32_t obj_num, uint32_t pg_shift,
size_t *min_chunk_size, size_t *align);
 
-/**
- * @internal Helper function to calculate memory size required to store
- * specified number of objects in assumption that the memory buffer will
- * be aligned at page boundary.
- *
- * Note that if object size is bigger than page size, then it assumes
- * that pages are grouped in subsets of physically continuous pages big
- * enough to store at least one object.
- *
- * @param elt_num
- *   Number of elements.
- * @param total_elt_sz
- *   The size of each element, including header and trailer, as returned
- *   by rte_mempool_calc_obj_size().
- * @param pg_shift
- *   LOG2 of the physical pages size. If set to 0, ignore page boundaries.
- * @return
- *   Required memory size aligned at page boundary.
- */
-size_t rte_mempool_calc_mem_size_helper(uint32_t elt_num, size_t total_elt_sz,
-   uint32_t pg_shift);
-
 /**
  * Function to be called for each populated object.
  *
diff --git a/lib/librte_mempool/rte_mempool_ops_default.c 
b/lib/librte_mempool/rte_mempool_ops_default.c
index fd63ca137..4e2bfc82d 100644
--- a/lib/librte_mempool/rte_mempool_ops_default.c
+++ b/lib/librte_mempool/rte_mempool_ops_default.c
@@ -12,12 +12,31 @@ rte_mempool_op_calc_mem_size_default(const struct 
rte_mempool *mp,
 size_t *min_chunk_size, size_t *align)
 {
size_t total_elt_sz;
+   size_t obj_per_page, pg_num, pg_sz;
size_t mem_size;
 
total_elt_sz = mp->header_size + mp->elt_size + mp->trailer_size;
-
-   mem_size = rte_mempool_calc_mem_size_helper(obj_num, total_elt_sz,
-   pg_shift);
+   if (total_elt_sz == 0) {
+   mem_size = 0;
+   } else if (pg_shift == 0) {
+   mem_size = total_elt_sz * obj_num;
+   } else {
+   pg_sz = (size_t)1 << pg_shift;
+   obj_per_page = pg_sz / total_elt_sz;
+   if (obj_per_page == 0) {
+   /*
+* Note that if object size is bigger than page size,
+* then it is assumed that pages are grouped in subsets
+* of physically continuous pages big enough to store
+* at least one object.
+*/
+   mem_size =
+   RTE_ALIGN_CEIL(total_elt_sz, pg_sz) * obj_num;
+   } else {
+   pg_num = (obj_num + obj_per_page - 1) / obj_per_page;
+   mem_size = pg_num << pg_shift;
+   }
+   }
 
*min_chunk_size = RTE_MAX((size_t)1 << pg_shift, total_elt_sz);
 
-- 
2.17.1

Re: [dpdk-dev] [PATCH 1/2] mempool: remove deprecated functions

[Andrew Rybchenko]

On 27.07.2018 00:34, Thomas Monjalon wrote:

11/07/2018 12:59, Andrew Rybchenko:

Functions rte_mempool_populate_phys(), rte_mempool_virt2phy() and
rte_mempool_populate_phys_tab() are just wrappers for corresponding
IOVA functions and were deprecated in v17.11.

Functions rte_mempool_xmem_create(), rte_mempool_xmem_size(),
rte_mempool_xmem_usage() and rte_mempool_populate_iova_tab() were
deprecated in v18.05 and removal was announced earlier in v18.02.

Signed-off-by: Andrew Rybchenko 
---
  lib/librte_mempool/Makefile|   3 -
  lib/librte_mempool/meson.build |   4 -
  lib/librte_mempool/rte_mempool.c   | 181 +
  lib/librte_mempool/rte_mempool.h   | 179 
  lib/librte_mempool/rte_mempool_version.map |   6 -
  5 files changed, 1 insertion(+), 372 deletions(-)

Please update the release notes, deprecation notice, and bump ABI version.


Will do. Deprecation notice which schedules removal of xmem functions
was removed on previous release when these function are deprecated.
Is it a problem? Should removal of already deprecated function pass
deprecation (removal) announcement procedure once again?

Andrew.

[dpdk-dev] [PATCH v2 1/2] mempool: remove deprecated functions

[Andrew Rybchenko]

Functions rte_mempool_populate_phys(), rte_mempool_virt2phy() and
rte_mempool_populate_phys_tab() are just wrappers for corresponding
IOVA functions and were deprecated in v17.11.

Functions rte_mempool_xmem_create(), rte_mempool_xmem_size(),
rte_mempool_xmem_usage() and rte_mempool_populate_iova_tab() were
deprecated in v18.05 and removal was announced earlier in v18.02.

Signed-off-by: Andrew Rybchenko 
---
 doc/guides/rel_notes/release_18_08.rst |  12 +-
 lib/librte_mempool/Makefile|   5 +-
 lib/librte_mempool/meson.build |   6 +-
 lib/librte_mempool/rte_mempool.c   | 181 +
 lib/librte_mempool/rte_mempool.h   | 179 
 lib/librte_mempool/rte_mempool_version.map |   6 -
 6 files changed, 14 insertions(+), 375 deletions(-)

diff --git a/doc/guides/rel_notes/release_18_08.rst 
b/doc/guides/rel_notes/release_18_08.rst
index 5f2401401..165e413f0 100644
--- a/doc/guides/rel_notes/release_18_08.rst
+++ b/doc/guides/rel_notes/release_18_08.rst
@@ -166,6 +166,16 @@ API Changes
   - ``RTE_COMP_FF_OOP_SGL_IN_LB_OUT``
   - ``RTE_COMP_FF_OOP_LB_IN_SGL_OUT``
 
+* mempool: Following functions were deprecated and are removed in 18.08:
+
+  - ``rte_mempool_populate_iova_tab``
+  - ``rte_mempool_populate_phys_tab``
+  - ``rte_mempool_populate_phys`` (``rte_mempool_populate_iova`` should be 
used)
+  - ``rte_mempool_virt2phy`` (``rte_mempool_virt2iova`` should be used)
+  - ``rte_mempool_xmem_create``
+  - ``rte_mempool_xmem_size``
+  - ``rte_mempool_xmem_usage``
+
 
 ABI Changes
 ---
@@ -241,7 +251,7 @@ The libraries prepended with a plus sign were incremented 
in this version.
  librte_latencystats.so.1
  librte_lpm.so.2
  librte_mbuf.so.4
- librte_mempool.so.4
+   + librte_mempool.so.5
  librte_meter.so.2
  librte_metrics.so.1
  librte_net.so.1
diff --git a/lib/librte_mempool/Makefile b/lib/librte_mempool/Makefile
index e3c32b14f..20bf63fbc 100644
--- a/lib/librte_mempool/Makefile
+++ b/lib/librte_mempool/Makefile
@@ -7,15 +7,12 @@ include $(RTE_SDK)/mk/rte.vars.mk
 LIB = librte_mempool.a
 
 CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) -O3
-# Allow deprecated symbol to use deprecated rte_mempool_populate_iova_tab()
-# from earlier deprecated rte_mempool_populate_phys_tab()
-CFLAGS += -Wno-deprecated-declarations
 CFLAGS += -DALLOW_EXPERIMENTAL_API
 LDLIBS += -lrte_eal -lrte_ring
 
 EXPORT_MAP := rte_mempool_version.map
 
-LIBABIVER := 4
+LIBABIVER := 5
 
 # memseg walk is not yet part of stable API
 CFLAGS += -DALLOW_EXPERIMENTAL_API
diff --git a/lib/librte_mempool/meson.build b/lib/librte_mempool/meson.build
index d507e5511..38d7ae890 100644
--- a/lib/librte_mempool/meson.build
+++ b/lib/librte_mempool/meson.build
@@ -5,17 +5,13 @@ allow_experimental_apis = true
 
 extra_flags = []
 
-# Allow deprecated symbol to use deprecated rte_mempool_populate_iova_tab()
-# from earlier deprecated rte_mempool_populate_phys_tab()
-extra_flags += '-Wno-deprecated-declarations'
-
 foreach flag: extra_flags
if cc.has_argument(flag)
cflags += flag
endif
 endforeach
 
-version = 4
+version = 5
 sources = files('rte_mempool.c', 'rte_mempool_ops.c',
'rte_mempool_ops_default.c')
 headers = files('rte_mempool.h')
diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index 8c8b9f809..d48e53c7e 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -227,9 +227,7 @@ rte_mempool_calc_obj_size(uint32_t elt_size, uint32_t flags,
 
 
 /*
- * Internal function to calculate required memory chunk size shared
- * by default implementation of the corresponding callback and
- * deprecated external function.
+ * Internal function to calculate required memory chunk size.
  */
 size_t
 rte_mempool_calc_mem_size_helper(uint32_t elt_num, size_t total_elt_sz,
@@ -252,66 +250,6 @@ rte_mempool_calc_mem_size_helper(uint32_t elt_num, size_t 
total_elt_sz,
return pg_num << pg_shift;
 }
 
-/*
- * Calculate maximum amount of memory required to store given number of 
objects.
- */
-size_t
-rte_mempool_xmem_size(uint32_t elt_num, size_t total_elt_sz, uint32_t pg_shift,
- __rte_unused unsigned int flags)
-{
-   return rte_mempool_calc_mem_size_helper(elt_num, total_elt_sz,
-   pg_shift);
-}
-
-/*
- * Calculate how much memory would be actually required with the
- * given memory footprint to store required number of elements.
- */
-ssize_t
-rte_mempool_xmem_usage(__rte_unused void *vaddr, uint32_t elt_num,
-   size_t total_elt_sz, const rte_iova_t iova[], uint32_t pg_num,
-   uint32_t pg_shift, __rte_unused unsigned int flags)
-{
-   uint32_t elt_cnt = 0;
-   rte_iova_t start, end;
-   uint32_t iova_idx;
-   size_t pg_sz = (size_t)1 << pg_shift;
-
-   /* if iova is NULL, assume contiguous memory */
-   if (iova == NULL) {
-   start 

Re: [dpdk-dev] DPDK and forked processes

[Eads, Gage]

As this discussion has broad implications for DPDK, is it a good candidate for 
a techboard meeting topic? 

> -Original Message-
> From: Burakov, Anatoly
> Sent: Monday, July 16, 2018 10:09 AM
> To: Eads, Gage ; dev@dpdk.org
> Subject: Re: DPDK and forked processes
> 
> On 16-Jul-18 4:00 PM, Eads, Gage wrote:
> > Hi all,
> >
> > Does DPDK support forking secondary processes after executing
> > rte_eal_init()? The l2fwd_fork example and at least one application
> > (OpenEM: https://sourceforge.net/projects/eventmachine/) use this
> > model, and they do so by fixing up the EAL internals (e.g. manually
> > changing process_type from primary to secondary) at the start of the
> > child process. This feels like a hack, and I can’t find any
> > documentation describing this model.
> >
> > Moreover, this approach doesn’t appear to be compatible with recent
> > EAL changes. For instance, the multi-process communication creates a
> > couple handler threads (“rte_mp_handle” and “rte_mp_async”) during EAL
> > initialization. The child processes won’t inherit these threads, and
> > so won’t be able to participate in multi-process comms. This means the
> > reworked memory subsystem and upcoming device hotplug support
> > (http://mails.dpdk.org/archives/dev/2018-July/107704.html) won’t work
> > with this fork-after-init model.
> >
> > This is just one example – there may be other features/subsystems that
> > won’t work. As far as I can tell there is no official stance (though
> > the l2fwd_fork example implies it’s supported, IMO); I think either
> > DPDK should either drop the example and not support this model, or
> > support it and either document its limitations or resolve them. This
> > model could be an interesting way to run multi-process DPDK on an
> > ASLR-enabled system, but supporting this wouldn’t be trivial.
> >
> > Thanks,
> >
> > Gage
> >
> 
> I think it's a very bad idea to use such a model in recent versions of DPDK. 
> As you
> have correctly pointed out, IPC will not work in such a scenario, and given 
> how
> our memory subsystem relies on IPC, this is a recipe for memory corruption and
> divergent memory maps (since technically both initial and forked processes
> believe they are primary).
> 
> Even hacking rte_config to make DPDK think it's a secondary process will not
> work, because the initialization has already completed, but all of the threads
> (IPC, interrupt, etc.) are gone and correct IPC socket was not created, which
> means the process becomes invisible to the primary for all intents and 
> purposes.
> 
> We _could_ introduce some kind of "official DPDK fork" function that would 
> fork
> the process and then restart interrupt, IPC etc. stuff on an already running
> instance of DPDK, but that seems like a workaround for a problem that 
> shouldn't
> exist in the first place, because such usage is fundamentally incompatible 
> with
> DPDK as it stands now.
> 
> --
> Thanks,
> Anatoly

[dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

[Cody Doucette]

Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any
other IPv6 extension headers when finding the fragment header.

According to RFC 8200, there is no guarantee that the IPv6
Fragment extension header will come before any other extension
header, even though it is recommended.

Signed-off-by: Cody Doucette 
Signed-off-by: Qiaobin Fu 
Reviewed-by: Michel Machado 
---
v3:
* Removed compilation flag D_XOPEN_SOURCE=700 from the
  failsafe driver to allow compilation on freebsd.

v2:
* Moved IPv6 extension header definitions to lib_net.

 drivers/net/failsafe/Makefile   |  1 -
 drivers/net/failsafe/meson.build|  1 -
 examples/ip_reassembly/main.c   |  6 ++--
 lib/librte_ip_frag/rte_ip_frag.h| 23 ++---
 lib/librte_ip_frag/rte_ip_frag_version.map  |  1 +
 lib/librte_ip_frag/rte_ipv6_fragmentation.c | 38 +
 lib/librte_ip_frag/rte_ipv6_reassembly.c|  4 +--
 lib/librte_net/rte_ip.h | 27 +++
 lib/librte_port/rte_port_ras.c  |  6 ++--
 9 files changed, 86 insertions(+), 21 deletions(-)

diff --git a/drivers/net/failsafe/Makefile b/drivers/net/failsafe/Makefile
index 81802d092..eb9292425 100644
--- a/drivers/net/failsafe/Makefile
+++ b/drivers/net/failsafe/Makefile
@@ -34,7 +34,6 @@ CFLAGS += -std=gnu99 -Wextra
 CFLAGS += -O3
 CFLAGS += -I.
 CFLAGS += -D_DEFAULT_SOURCE
-CFLAGS += -D_XOPEN_SOURCE=700
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -Wno-strict-prototypes
 CFLAGS += -pedantic
diff --git a/drivers/net/failsafe/meson.build b/drivers/net/failsafe/meson.build
index a249ff4af..d47a52acd 100644
--- a/drivers/net/failsafe/meson.build
+++ b/drivers/net/failsafe/meson.build
@@ -3,7 +3,6 @@
 
 cflags += '-std=gnu99'
 cflags += '-D_DEFAULT_SOURCE'
-cflags += '-D_XOPEN_SOURCE=700'
 cflags += '-pedantic'
 if host_machine.system() == 'linux'
cflags += '-DLINUX'
diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c
index b830f67a5..58c388708 100644
--- a/examples/ip_reassembly/main.c
+++ b/examples/ip_reassembly/main.c
@@ -366,12 +366,14 @@ reassemble(struct rte_mbuf *m, uint16_t portid, uint32_t 
queue,
eth_hdr->ether_type = rte_be_to_cpu_16(ETHER_TYPE_IPv4);
} else if (RTE_ETH_IS_IPV6_HDR(m->packet_type)) {
/* if packet is IPv6 */
-   struct ipv6_extension_fragment *frag_hdr;
+   const struct ipv6_extension_fragment *frag_hdr;
+   struct ipv6_extension_fragment frag_hdr_buf;
struct ipv6_hdr *ip_hdr;
 
ip_hdr = (struct ipv6_hdr *)(eth_hdr + 1);
 
-   frag_hdr = rte_ipv6_frag_get_ipv6_fragment_header(ip_hdr);
+   frag_hdr = rte_ipv6_frag_get_ipv6_fragment_header(m,
+   ip_hdr, &frag_hdr_buf);
 
if (frag_hdr != NULL) {
struct rte_mbuf *mo;
diff --git a/lib/librte_ip_frag/rte_ip_frag.h b/lib/librte_ip_frag/rte_ip_frag.h
index b3f3f78df..bd6f02a16 100644
--- a/lib/librte_ip_frag/rte_ip_frag.h
+++ b/lib/librte_ip_frag/rte_ip_frag.h
@@ -208,28 +208,25 @@ rte_ipv6_fragment_packet(struct rte_mbuf *pkt_in,
 struct rte_mbuf *rte_ipv6_frag_reassemble_packet(struct rte_ip_frag_tbl *tbl,
struct rte_ip_frag_death_row *dr,
struct rte_mbuf *mb, uint64_t tms, struct ipv6_hdr *ip_hdr,
-   struct ipv6_extension_fragment *frag_hdr);
+   const struct ipv6_extension_fragment *frag_hdr);
 
 /**
  * Return a pointer to the packet's fragment header, if found.
- * It only looks at the extension header that's right after the fixed IPv6
- * header, and doesn't follow the whole chain of extension headers.
  *
- * @param hdr
+ * @param pkt
+ *   Pointer to the mbuf of the packet.
+ * @param ip_hdr
  *   Pointer to the IPv6 header.
+ * @param frag_hdr
+ *   A pointer to the buffer where the fragment header
+ *   will be copied if it is not contiguous in mbuf data.
  * @return
  *   Pointer to the IPv6 fragment extension header, or NULL if it's not
  *   present.
  */
-static inline struct ipv6_extension_fragment *
-rte_ipv6_frag_get_ipv6_fragment_header(struct ipv6_hdr *hdr)
-{
-   if (hdr->proto == IPPROTO_FRAGMENT) {
-   return (struct ipv6_extension_fragment *) ++hdr;
-   }
-   else
-   return NULL;
-}
+const struct ipv6_extension_fragment *rte_ipv6_frag_get_ipv6_fragment_header(
+   struct rte_mbuf *pkt, const struct ipv6_hdr *ip_hdr,
+   struct ipv6_extension_fragment *frag_hdr);
 
 /**
  * IPv4 fragmentation.
diff --git a/lib/librte_ip_frag/rte_ip_frag_version.map 
b/lib/librte_ip_frag/rte_ip_frag_version.map
index d1acf07cb..98fe4f2d4 100644
--- a/lib/librte_ip_frag/rte_ip_frag_version.map
+++ b/lib/librte_ip_frag/rte_ip_frag_version.map
@@ -8,6 +8,7 @@ DPDK_2.0 {
rte_ipv4_fragment_packet;
rte_ipv6_frag_reassemble_packet;
rte_ipv6_fragment_packet;
+   rte_ipv6_

[dpdk-dev] [PATCH v8 2/4] test: add unit tests for bitrate library

[Naga Suresh Somarowthu]

Unit Test Cases for BitRate library.

Signed-off-by: Naga Suresh Somarowthu 
Reviewed-by: Reshma Pattan 
Reviewed-by: Remy Horton 
---
 test/test/Makefile|   1 +
 test/test/autotest_data.py|   6 ++
 test/test/test_bitratestats.c | 229 ++
 3 files changed, 236 insertions(+)
 create mode 100644 test/test/test_bitratestats.c

diff --git a/test/test/Makefile b/test/test/Makefile
index 9f7d398e4..c619877f0 100644
--- a/test/test/Makefile
+++ b/test/test/Makefile
@@ -183,6 +183,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) += test_pmd_ring_perf.c
 SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev_blockcipher.c
 SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev.c
 SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev_asym.c
+SRCS-$(CONFIG_RTE_LIBRTE_BITRATE) += test_bitratestats.c
 
 ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)
 SRCS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV) += test_compressdev.c
diff --git a/test/test/autotest_data.py b/test/test/autotest_data.py
index aacfe0a66..419520342 100644
--- a/test/test/autotest_data.py
+++ b/test/test/autotest_data.py
@@ -293,6 +293,12 @@ def per_sockets(num):
 "Tests":
 [
 {
+"Name":"Bitratestats autotest",
+"Command": "bitratestats_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
 "Name":"PMD ring autotest",
 "Command": "ring_pmd_autotest",
 "Func":default_autotest,
diff --git a/test/test/test_bitratestats.c b/test/test/test_bitratestats.c
new file mode 100644
index 0..38f7da4b5
--- /dev/null
+++ b/test/test/test_bitratestats.c
@@ -0,0 +1,229 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Intel Corporation
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "test.h"
+#include "sample_packet_forward.h"
+
+#define BIT_NUM_PACKETS 10
+#define QUEUE_ID 0
+
+uint16_t portid;
+struct rte_stats_bitrates *bitrate_data;
+struct rte_ring *ring;
+
+/* To test whether rte_stats_bitrate_create is successful */
+static int
+test_stats_bitrate_create(void)
+{
+   bitrate_data = rte_stats_bitrate_create();
+   TEST_ASSERT(bitrate_data != NULL, "rte_stats_bitrate_create failed");
+
+   return TEST_SUCCESS;
+}
+
+/* To test bit rate registration */
+static int
+test_stats_bitrate_reg(void)
+{
+   int ret = 0;
+
+   /* Test to register bit rate without metrics init */
+   ret = rte_stats_bitrate_reg(bitrate_data);
+   TEST_ASSERT(ret < 0, "Test Failed: rte_stats_bitrate_reg succeeded "
+   "without metrics init, ret:%d", ret);
+
+   /* Metrics initialization */
+   rte_metrics_init(rte_socket_id());
+   /* Test to register bit rate after metrics init */
+   ret = rte_stats_bitrate_reg(bitrate_data);
+   TEST_ASSERT((ret >= 0), "Test Failed: rte_stats_bitrate_reg %d", ret);
+
+   return TEST_SUCCESS;
+}
+
+/* To test the bit rate registration with invalid pointer */
+static int
+test_stats_bitrate_reg_invalidpointer(void)
+{
+   int ret = 0;
+
+   ret = rte_stats_bitrate_reg(NULL);
+   TEST_ASSERT(ret < 0, "Test Failed: Expected failure < 0 but "
+   "got %d", ret);
+
+   return TEST_SUCCESS;
+}
+
+/* To test bit rate calculation with invalid bit rate data pointer */
+static int
+test_stats_bitrate_calc_invalid_bitrate_data(void)
+{
+   int ret = 0;
+
+   ret = rte_stats_bitrate_calc(NULL, portid);
+   TEST_ASSERT(ret < 0, "Test Failed: rte_stats_bitrate_calc "
+   "ret:%d", ret);
+
+   return TEST_SUCCESS;
+}
+
+/* To test the bit rate calculation with invalid portid
+ * (higher than max ports)
+ */
+static int
+test_stats_bitrate_calc_invalid_portid_1(void)
+{
+   int ret = 0;
+
+   ret = rte_stats_bitrate_calc(bitrate_data, 33);
+   TEST_ASSERT(ret == -EINVAL, "Test Failed: Expected -%d for higher "
+   "portid rte_stats_bitrate_calc ret:%d", EINVAL, ret);
+
+   return TEST_SUCCESS;
+}
+
+/* To test the bit rate calculation with invalid portid (lesser than 0) */
+static int
+test_stats_bitrate_calc_invalid_portid_2(void)
+{
+   int ret = 0;
+
+   ret = rte_stats_bitrate_calc(bitrate_data, -1);
+   TEST_ASSERT(ret == -EINVAL, "Test Failed: Expected -%d for invalid "
+   "portid rte_stats_bitrate_calc ret:%d", EINVAL, ret);
+
+   return TEST_SUCCESS;
+}
+
+/* To test the bit rate calculation with non-existing portid */
+static int
+test_stats_bitrate_calc_non_existing_portid(void)
+{
+   int ret = 0;
+
+   ret = rte_stats_bitrate_calc(bitrate_data, 31);
+   TEST_ASSERT(ret ==  -EINVAL, "Test Failed: Expected -%d for "
+   "non-existing portid rte_stats_bitrate_calc ret:%d",
+   

[dpdk-dev] [PATCH v8 0/4] add unit tests for bitrate, latency and pdump libraries

[Naga Suresh Somarowthu]

1/4: add helper functions for tests using ring-PMD Rx/Tx
2/4: unit test cases added for bitrate library
3/4: unit test cases added for latencystats library   
4/4: unit test cases added for pdump library 

Patches 2/4,3/4 depends on 1/4  
Patch 4/4 depends on 1/4 and the below patch
http://patches.dpdk.org/patch/43354/

Signed-off-by: Naga Suresh Somarowthu  
Reviewed-by: Reshma Pattan   
Reviewed-by: Remy Horton   
Reviewed-by: Anatoly Burakov 
Acked-by: Reshma Pattan 
  
--- 
v8: renamed commit headline and freed the metrics memzone for bitrate ut
v7: removed unused macros and corrected the comment
v6: updated ring variable appropriately   
v5: rebased, freed pools and rings, created common patch set  
---   
 
Naga Suresh Somarowthu (4):
  test: add helper functions for tests using ring-PMD Rx/Tx
  test: add unit tests for bitrate library
  test: add unit tests for latencystats library
  test: add unit test for pdump library

 test/test/Makefile|   9 ++
 test/test/autotest_data.py|  12 ++
 test/test/process.h   |  12 ++
 test/test/sample_packet_forward.c | 115 +++
 test/test/sample_packet_forward.h |  40 +++
 test/test/test.c  |   2 +
 test/test/test_bitratestats.c | 229 +
 test/test/test_latencystats.c | 216 +++
 test/test/test_pdump.c| 232 ++
 test/test/test_pdump.h|  31 +
 10 files changed, 898 insertions(+)
 create mode 100644 test/test/sample_packet_forward.c
 create mode 100644 test/test/sample_packet_forward.h
 create mode 100644 test/test/test_bitratestats.c
 create mode 100644 test/test/test_latencystats.c
 create mode 100644 test/test/test_pdump.c
 create mode 100644 test/test/test_pdump.h

-- 
2.13.6

[dpdk-dev] [PATCH v8 4/4] test: add unit test for pdump library

[Naga Suresh Somarowthu]

Unit test cases are added for pdump library.
Primary process will act as server, forks a child secondary process.
Secondary process acts as client.
Server will do pdump init to serve any pdump client requests.
Server will create a vdev, send/receive packets continuously
in a separate thread.
Client will create virtual rings to receive the packet dump.
Client sends pdump enable/disable requests using either port/device id.
Packet flow direction can be tx/rx/tx&rx.
In Server, appropriate pdump callbacks are triggered,
when packets are transmitted/received.
Pdump packet is copied to client rings.

Signed-off-by: Naga Suresh Somarowthu 
Reviewed-by: Reshma Pattan 
---
 test/test/Makefile |   6 ++
 test/test/process.h|  12 +++
 test/test/test.c   |   2 +
 test/test/test_pdump.c | 232 +
 test/test/test_pdump.h |  31 +++
 5 files changed, 283 insertions(+)
 create mode 100644 test/test/test_pdump.c
 create mode 100644 test/test/test_pdump.h

diff --git a/test/test/Makefile b/test/test/Makefile
index bba3be1be..3e7baef76 100644
--- a/test/test/Makefile
+++ b/test/test/Makefile
@@ -185,6 +185,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev.c
 SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev_asym.c
 SRCS-$(CONFIG_RTE_LIBRTE_BITRATE) += test_bitratestats.c
 SRCS-$(CONFIG_RTE_LIBRTE_LATENCY_STATS) += test_latencystats.c
+SRCS-$(CONFIG_RTE_LIBRTE_PDUMP) += test_pdump.c
 
 ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)
 SRCS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV) += test_compressdev.c
@@ -214,6 +215,11 @@ CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -D_GNU_SOURCE
 
 LDLIBS += -lm
+
+ifeq ($(CONFIG_RTE_LIBRTE_PDUMP),y)
+LDLIBS += -lpthread
+endif
+
 ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)
 ifeq ($(CONFIG_RTE_LIBRTE_COMPRESSDEV),y)
 LDLIBS += -lz
diff --git a/test/test/process.h b/test/test/process.h
index 11986d5c2..1e7adde0e 100644
--- a/test/test/process.h
+++ b/test/test/process.h
@@ -13,6 +13,10 @@
 #define exe "exe"
 #endif
 
+#include 
+extern void *send_pkts(void *empty);
+extern uint16_t flag_for_send_pkts;
+
 /*
  * launches a second copy of the test process using the given argv parameters,
  * which should include argv[0] as the process name. To identify in the
@@ -26,6 +30,7 @@ process_dup(const char *const argv[], int numargs, const char 
*env_value)
char *argv_cpy[numargs + 1];
int i, fd, status;
char path[32];
+   pthread_t thread;
 
pid_t pid = fork();
if (pid < 0)
@@ -56,8 +61,15 @@ process_dup(const char *const argv[], int numargs, const 
char *env_value)
rte_panic("Cannot exec\n");
}
/* parent process does a wait */
+   if ((strcmp(env_value, "run_pdump_server_tests") == 0))
+   pthread_create(&thread, NULL, &send_pkts, NULL);
+
while (wait(&status) != pid)
;
+   if ((strcmp(env_value, "run_pdump_server_tests") == 0)) {
+   flag_for_send_pkts = 0;
+   pthread_join(thread, NULL);
+   }
return status;
 }
 
diff --git a/test/test/test.c b/test/test/test.c
index 44dfe20ef..a54b0d142 100644
--- a/test/test/test.c
+++ b/test/test/test.c
@@ -30,6 +30,7 @@ extern cmdline_parse_ctx_t main_ctx[];
 #endif
 
 #include "test.h"
+#include "test_pdump.h"
 
 #define RTE_LOGTYPE_APP RTE_LOGTYPE_USER1
 
@@ -49,6 +50,7 @@ do_recursive_call(void)
int (*action_fn)(void);
} actions[] =  {
{ "run_secondary_instances", test_mp_secondary },
+   { "run_pdump_server_tests", test_pdump },
{ "test_missing_c_flag", no_action },
{ "test_master_lcore_flag", no_action },
{ "test_invalid_n_flag", no_action },
diff --git a/test/test/test_pdump.c b/test/test/test_pdump.c
new file mode 100644
index 0..cfdda4d39
--- /dev/null
+++ b/test/test/test_pdump.c
@@ -0,0 +1,232 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Intel Corporation
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "test.h"
+#include "sample_packet_forward.h"
+#include "test_pdump.h"
+#include "process.h"
+
+#define launch_p(ARGV) process_dup(ARGV, \
+   sizeof(ARGV)/(sizeof(ARGV[0])), __func__)
+
+struct rte_ring *ring_server;
+uint16_t portid;
+uint16_t flag_for_send_pkts = 1;
+
+int
+test_pdump_init(void)
+{
+   int ret = 0;
+
+   ret = rte_pdump_init(NULL);
+   if (ret < 0) {
+   printf("rte_pdump_init failed\n");
+   return -1;
+   }
+   ret = test_ring_setup(&ring_server, &portid);
+   if (ret < 0) {
+   printf("test_ring_setup failed\n");
+   return -1;
+   }
+   printf("pdump_init su

[dpdk-dev] [PATCH v8 3/4] test: add unit tests for latencystats library

[Naga Suresh Somarowthu]

Unit Test Cases added for latencystats library.

Signed-off-by: Naga Suresh Somarowthu 
Reviewed-by: Reshma Pattan 
---
 test/test/Makefile|   1 +
 test/test/autotest_data.py|   6 ++
 test/test/test_latencystats.c | 216 ++
 3 files changed, 223 insertions(+)
 create mode 100644 test/test/test_latencystats.c

diff --git a/test/test/Makefile b/test/test/Makefile
index c619877f0..bba3be1be 100644
--- a/test/test/Makefile
+++ b/test/test/Makefile
@@ -184,6 +184,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += 
test_cryptodev_blockcipher.c
 SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev.c
 SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev_asym.c
 SRCS-$(CONFIG_RTE_LIBRTE_BITRATE) += test_bitratestats.c
+SRCS-$(CONFIG_RTE_LIBRTE_LATENCY_STATS) += test_latencystats.c
 
 ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)
 SRCS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV) += test_compressdev.c
diff --git a/test/test/autotest_data.py b/test/test/autotest_data.py
index 419520342..3eccc4e1a 100644
--- a/test/test/autotest_data.py
+++ b/test/test/autotest_data.py
@@ -299,6 +299,12 @@ def per_sockets(num):
 "Report":  None,
 },
 {
+"Name":"Latencystats autotest",
+"Command": "latencystats_autotest",
+"Func":default_autotest,
+"Report":  None,
+},
+{
 "Name":"PMD ring autotest",
 "Command": "ring_pmd_autotest",
 "Func":default_autotest,
diff --git a/test/test/test_latencystats.c b/test/test/test_latencystats.c
new file mode 100644
index 0..f2287a2b7
--- /dev/null
+++ b/test/test/test_latencystats.c
@@ -0,0 +1,216 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Intel Corporation
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "test.h"
+#include "sample_packet_forward.h"
+#define NUM_STATS 4
+#define LATENCY_NUM_PACKETS 10
+#define QUEUE_ID 0
+
+uint16_t portid;
+struct rte_ring *ring;
+
+struct rte_metric_name lat_stats_strings[] = {
+   {"min_latency_ns"},
+   {"avg_latency_ns"},
+   {"max_latency_ns"},
+   {"jitter_ns"},
+};
+
+/* Test case for latency init with metrics init */
+static int test_latency_init(void)
+{
+   int ret = 0;
+
+   /* Metrics Initialization */
+   rte_metrics_init(rte_socket_id());
+
+   ret = rte_latencystats_init(1, NULL);
+   TEST_ASSERT(ret >= 0, "Test Failed: rte_latencystats_init failed");
+
+   return TEST_SUCCESS;
+}
+
+/* Test case to update the latency stats */
+static int test_latency_update(void)
+{
+   int ret = 0;
+
+   ret = rte_latencystats_update();
+   TEST_ASSERT(ret >= 0, "Test Failed: rte_latencystats_update failed");
+
+   return TEST_SUCCESS;
+}
+
+/* Test case to uninit latency stats */
+static int test_latency_uninit(void)
+{
+   int ret = 0;
+
+   ret = rte_latencystats_uninit();
+   TEST_ASSERT(ret >= 0, "Test Failed: rte_latencystats_uninit failed");
+
+   return TEST_SUCCESS;
+}
+
+/* Test case to get names of latency stats */
+static int test_latencystats_get_names(void)
+{
+   int ret = 0;
+   int size = 0;
+   struct rte_metric_name names[NUM_STATS] = { 0 };
+   struct rte_metric_name wrongnames[NUM_STATS - 2] = { 0 };
+
+   /* Success Test: Valid names and size */
+   size = NUM_STATS;
+   ret = rte_latencystats_get_names(names, size);
+   for (int i = 0; i <= NUM_STATS; i++) {
+   if (strcmp(lat_stats_strings[i].name, names[i].name) == 0)
+   printf(" %s\n", names[i].name);
+   else
+   printf("Failed: Names are not matched\n");
+   }
+   TEST_ASSERT((ret == NUM_STATS), "Test Failed to get metrics names");
+
+   /* Failure Test: Invalid names and valid size */
+   ret = rte_latencystats_get_names(NULL, size);
+   TEST_ASSERT((ret == NUM_STATS), "Test Failed to get the metrics count,"
+   "Actual: %d Expected: %d", ret, NUM_STATS);
+
+   /* Failure Test: Valid names and invalid size */
+   size = 0;
+   ret = rte_latencystats_get_names(names, size);
+   TEST_ASSERT((ret == NUM_STATS), "Test Failed to get the metrics count,"
+   "Actual: %d Expected: %d", ret, NUM_STATS);
+
+   /* Failure Test: Invalid names (array size lesser than size) */
+   size = NUM_STATS + 1;
+   ret = rte_latencystats_get_names(wrongnames, size);
+   TEST_ASSERT((ret == NUM_STATS), "Test Failed to get metrics names");
+   return TEST_SUCCESS;
+}
+
+/* Test case to get latency stats values */
+static int test_latencystats_get(void)
+{
+   int ret = 0;
+   int size = 0;
+   struct rte_metric_value values[NUM_STATS] = { 0 };
+   struct rte_metric_value wrongvalues[NUM_STATS - 2] = { 0 };
+
+   

[dpdk-dev] [PATCH v8 1/4] test: add helper functions for tests using ring-PMD Rx/Tx

[Naga Suresh Somarowthu]

Added ring pmd based packet rx/tx helper functions
for verifying Latency, Bitrate and pdump lib UTs.

Signed-off-by: Naga Suresh Somarowthu 
Reviewed-by: Reshma Pattan 
Reviewed-by: Anatoly Burakov 
---
 test/test/Makefile|   1 +
 test/test/sample_packet_forward.c | 115 ++
 test/test/sample_packet_forward.h |  40 +
 3 files changed, 156 insertions(+)
 create mode 100644 test/test/sample_packet_forward.c
 create mode 100644 test/test/sample_packet_forward.h

diff --git a/test/test/Makefile b/test/test/Makefile
index e6967bab6..9f7d398e4 100644
--- a/test/test/Makefile
+++ b/test/test/Makefile
@@ -165,6 +165,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_REORDER) += test_reorder.c
 
 SRCS-y += virtual_pmd.c
 SRCS-y += packet_burst_generator.c
+SRCS-y += sample_packet_forward.c
 SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c
 
 ifeq ($(CONFIG_RTE_LIBRTE_PMD_RING),y)
diff --git a/test/test/sample_packet_forward.c 
b/test/test/sample_packet_forward.c
new file mode 100644
index 0..3822577b9
--- /dev/null
+++ b/test/test/sample_packet_forward.c
@@ -0,0 +1,115 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Intel Corporation
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include "sample_packet_forward.h"
+#include "test.h"
+
+/* Sample test to create virtual rings and tx,rx portid from rings */
+int
+test_ring_setup(struct rte_ring **ring, uint16_t *portid)
+{
+   *ring = rte_ring_create("R0", RING_SIZE, rte_socket_id(),
+ RING_F_SP_ENQ | RING_F_SC_DEQ);
+   if (*ring == NULL) {
+   printf("%s() line %u: rte_ring_create R0 failed",
+  __func__, __LINE__);
+   return -1;
+   }
+   *portid = rte_eth_from_rings("net_ringa", ring, NUM_QUEUES,
+   ring, NUM_QUEUES, rte_socket_id());
+
+   return 0;
+}
+
+/* Sample test to free the mempool */
+void
+test_mp_free(struct rte_mempool *mp)
+{
+   rte_mempool_free(mp);
+}
+
+/* Sample test to free the virtual rings */
+void
+test_ring_free(struct rte_ring *rxtx)
+{
+   rte_ring_free(rxtx);
+}
+
+/* Sample test to release the vdev */
+void
+test_vdev_uninit(const char *vdev)
+{
+   rte_vdev_uninit(vdev);
+}
+
+/* sample test to allocate the mempool */
+int
+test_get_mempool(struct rte_mempool **mp, char *poolname)
+{
+   *mp = rte_pktmbuf_pool_create(poolname, NB_MBUF, 32, 0,
+   RTE_MBUF_DEFAULT_BUF_SIZE, rte_socket_id());
+   if (*mp == NULL)
+   return -1;
+   return 0;
+}
+
+/* sample test to allocate buffer for pkts */
+int
+test_get_mbuf_from_pool(struct rte_mempool **mp, struct rte_mbuf **pbuf,
+   char *poolname)
+{
+   int ret = 0;
+
+   ret = test_get_mempool(mp, poolname);
+   if (ret < 0)
+   return -1;
+   if (rte_pktmbuf_alloc_bulk(*mp, pbuf, NUM_PACKETS) != 0) {
+   printf("%s() line %u: rte_pktmbuf_alloc_bulk failed", __func__,
+  __LINE__);
+   return -1;
+   }
+   return 0;
+}
+
+/* sample test to deallocate the allocated buffers and mempool */
+void
+test_put_mbuf_to_pool(struct rte_mempool *mp, struct rte_mbuf **pbuf)
+{
+   int itr = 0;
+
+   for (itr = 0; itr < NUM_PACKETS; itr++)
+   rte_pktmbuf_free(pbuf[itr]);
+   rte_mempool_free(mp);
+}
+
+/* Sample test to forward packets using virtual portids */
+int
+test_packet_forward(struct rte_mbuf **pbuf, uint16_t portid, uint16_t queue_id)
+{
+   /* send and receive packet and check for stats update */
+   if (rte_eth_tx_burst(portid, queue_id, pbuf, NUM_PACKETS)
+   < NUM_PACKETS) {
+   printf("%s() line %u: Error sending packet to"
+  " port %d\n", __func__, __LINE__, portid);
+   return -1;
+   }
+   if (rte_eth_rx_burst(portid, queue_id, pbuf, NUM_PACKETS)
+   < NUM_PACKETS) {
+   printf("%s() line %u: Error receiving packet from"
+  " port %d\n", __func__, __LINE__, portid);
+   return -1;
+   }
+   return 0;
+}
diff --git a/test/test/sample_packet_forward.h 
b/test/test/sample_packet_forward.h
new file mode 100644
index 0..433bd3ba2
--- /dev/null
+++ b/test/test/sample_packet_forward.h
@@ -0,0 +1,40 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2018 Intel Corporation
+ */
+
+#ifndef _SAMPLE_PACKET_FORWARD_H_
+#define _SAMPLE_PACKET_FORWARD_H_
+
+/* MACROS to support virtual ring creation */
+#define RING_SIZE 256
+#define NUM_QUEUES 1
+#define NB_MBUF 512
+
+#define NUM_PACKETS 10
+
+/* Sample test to create virtual rings and tx,rx portid from rings */
+int test_ring_setup(struct rte_ring **ring, uint16_t *portid);
+
+/* Sample test to free the virtual rings */
+void test_ring_free(struct rte_ring *rxtx);
+
+/* S

Re: [dpdk-dev] [PATCH 1/2] mempool: remove deprecated functions

[Thomas Monjalon]

27/07/2018 15:45, Andrew Rybchenko:
> On 27.07.2018 00:34, Thomas Monjalon wrote:
> > 11/07/2018 12:59, Andrew Rybchenko:
> >> Functions rte_mempool_populate_phys(), rte_mempool_virt2phy() and
> >> rte_mempool_populate_phys_tab() are just wrappers for corresponding
> >> IOVA functions and were deprecated in v17.11.
> >>
> >> Functions rte_mempool_xmem_create(), rte_mempool_xmem_size(),
> >> rte_mempool_xmem_usage() and rte_mempool_populate_iova_tab() were
> >> deprecated in v18.05 and removal was announced earlier in v18.02.
> >>
> >> Signed-off-by: Andrew Rybchenko 
> >> ---
> >>   lib/librte_mempool/Makefile|   3 -
> >>   lib/librte_mempool/meson.build |   4 -
> >>   lib/librte_mempool/rte_mempool.c   | 181 +
> >>   lib/librte_mempool/rte_mempool.h   | 179 
> >>   lib/librte_mempool/rte_mempool_version.map |   6 -
> >>   5 files changed, 1 insertion(+), 372 deletions(-)
> > Please update the release notes, deprecation notice, and bump ABI version.
> 
> Will do. Deprecation notice which schedules removal of xmem functions
> was removed on previous release when these function are deprecated.
> Is it a problem? Should removal of already deprecated function pass
> deprecation (removal) announcement procedure once again?

No, it's OK.
We should have left the notice about removal but it's too late :)

Re: [dpdk-dev] DPDK and forked processes

[Thomas Monjalon]

27/07/2018 15:46, Eads, Gage:
> As this discussion has broad implications for DPDK, is it a good candidate 
> for a techboard meeting topic? 

We can discuss it in techboard, but usually we prefer discussing topics
whose resolution is not clear.
In this case, I think everybody agree with Anatoly, isn't it?


> > -Original Message-
> > From: Burakov, Anatoly
> > Sent: Monday, July 16, 2018 10:09 AM
> > To: Eads, Gage ; dev@dpdk.org
> > Subject: Re: DPDK and forked processes
> > 
> > On 16-Jul-18 4:00 PM, Eads, Gage wrote:
> > > Hi all,
> > >
> > > Does DPDK support forking secondary processes after executing
> > > rte_eal_init()? The l2fwd_fork example and at least one application
> > > (OpenEM: https://sourceforge.net/projects/eventmachine/) use this
> > > model, and they do so by fixing up the EAL internals (e.g. manually
> > > changing process_type from primary to secondary) at the start of the
> > > child process. This feels like a hack, and I can’t find any
> > > documentation describing this model.
> > >
> > > Moreover, this approach doesn’t appear to be compatible with recent
> > > EAL changes. For instance, the multi-process communication creates a
> > > couple handler threads (“rte_mp_handle” and “rte_mp_async”) during EAL
> > > initialization. The child processes won’t inherit these threads, and
> > > so won’t be able to participate in multi-process comms. This means the
> > > reworked memory subsystem and upcoming device hotplug support
> > > (http://mails.dpdk.org/archives/dev/2018-July/107704.html) won’t work
> > > with this fork-after-init model.
> > >
> > > This is just one example – there may be other features/subsystems that
> > > won’t work. As far as I can tell there is no official stance (though
> > > the l2fwd_fork example implies it’s supported, IMO); I think either
> > > DPDK should either drop the example and not support this model, or
> > > support it and either document its limitations or resolve them. This
> > > model could be an interesting way to run multi-process DPDK on an
> > > ASLR-enabled system, but supporting this wouldn’t be trivial.
> > >
> > > Thanks,
> > >
> > > Gage
> > >
> > 
> > I think it's a very bad idea to use such a model in recent versions of 
> > DPDK. As you
> > have correctly pointed out, IPC will not work in such a scenario, and given 
> > how
> > our memory subsystem relies on IPC, this is a recipe for memory corruption 
> > and
> > divergent memory maps (since technically both initial and forked processes
> > believe they are primary).
> > 
> > Even hacking rte_config to make DPDK think it's a secondary process will not
> > work, because the initialization has already completed, but all of the 
> > threads
> > (IPC, interrupt, etc.) are gone and correct IPC socket was not created, 
> > which
> > means the process becomes invisible to the primary for all intents and 
> > purposes.
> > 
> > We _could_ introduce some kind of "official DPDK fork" function that would 
> > fork
> > the process and then restart interrupt, IPC etc. stuff on an already running
> > instance of DPDK, but that seems like a workaround for a problem that 
> > shouldn't
> > exist in the first place, because such usage is fundamentally incompatible 
> > with
> > DPDK as it stands now.
> > 
> > --
> > Thanks,
> > Anatoly
> 

[dpdk-dev] [PATCH] net/bnx2x: fix copyright

[Rasesh Mody]

Originally the PMD had "QLogic Corporation" copyright. When we submitted
commit e3de5dad2a5d ("net/bnx2x: change copyright info to Cavium"),
the "Qlogic Corporation" copyright was accidentally replaced
with "Cavium Inc". So now we see multiple Cavium copyright messages.
We're changing it to "Broadcom Corporation" copyright.

Fixes: e3de5dad2a5d ("net/bnx2x: change copyright info to Cavium")
Cc: sta...@dpdk.org

Signed-off-by: Rasesh Mody 
---
 drivers/net/bnx2x/bnx2x_stats.c|2 +-
 drivers/net/bnx2x/bnx2x_stats.h|2 +-
 drivers/net/bnx2x/ecore_fw_defs.h  |2 +-
 drivers/net/bnx2x/ecore_hsi.h  |2 +-
 drivers/net/bnx2x/ecore_init.h |2 +-
 drivers/net/bnx2x/ecore_init_ops.h |2 +-
 drivers/net/bnx2x/ecore_mfw_req.h  |2 +-
 drivers/net/bnx2x/ecore_reg.h  |2 +-
 drivers/net/bnx2x/ecore_sp.c   |2 +-
 drivers/net/bnx2x/ecore_sp.h   |2 +-
 drivers/net/bnx2x/elink.c  |2 +-
 drivers/net/bnx2x/elink.h  |2 +-
 12 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c
index e3880ab..b67a711 100644
--- a/drivers/net/bnx2x/bnx2x_stats.c
+++ b/drivers/net/bnx2x/bnx2x_stats.c
@@ -1,5 +1,5 @@
 /*-
- * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
+ * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis
  * David Christensen 
diff --git a/drivers/net/bnx2x/bnx2x_stats.h b/drivers/net/bnx2x/bnx2x_stats.h
index 6fcaf60..0ffd308 100644
--- a/drivers/net/bnx2x/bnx2x_stats.h
+++ b/drivers/net/bnx2x/bnx2x_stats.h
@@ -1,5 +1,5 @@
 /*-
- * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
+ * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis
  * David Christensen 
diff --git a/drivers/net/bnx2x/ecore_fw_defs.h 
b/drivers/net/bnx2x/ecore_fw_defs.h
index d10dd10..544ec23 100644
--- a/drivers/net/bnx2x/ecore_fw_defs.h
+++ b/drivers/net/bnx2x/ecore_fw_defs.h
@@ -1,5 +1,5 @@
 /*-
- * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
+ * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis
  * David Christensen 
diff --git a/drivers/net/bnx2x/ecore_hsi.h b/drivers/net/bnx2x/ecore_hsi.h
index 0220e5f..c9c5ba7 100644
--- a/drivers/net/bnx2x/ecore_hsi.h
+++ b/drivers/net/bnx2x/ecore_hsi.h
@@ -1,5 +1,5 @@
 /*-
- * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
+ * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis
  * David Christensen 
diff --git a/drivers/net/bnx2x/ecore_init.h b/drivers/net/bnx2x/ecore_init.h
index 8d00abb..dcf409d 100644
--- a/drivers/net/bnx2x/ecore_init.h
+++ b/drivers/net/bnx2x/ecore_init.h
@@ -1,5 +1,5 @@
 /*-
- * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
+ * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis
  * David Christensen 
diff --git a/drivers/net/bnx2x/ecore_init_ops.h 
b/drivers/net/bnx2x/ecore_init_ops.h
index dd5df3d..5cc6730 100644
--- a/drivers/net/bnx2x/ecore_init_ops.h
+++ b/drivers/net/bnx2x/ecore_init_ops.h
@@ -1,5 +1,5 @@
 /*-
- * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
+ * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis
  * David Christensen 
diff --git a/drivers/net/bnx2x/ecore_mfw_req.h 
b/drivers/net/bnx2x/ecore_mfw_req.h
index c798c74..fe7fe0e 100644
--- a/drivers/net/bnx2x/ecore_mfw_req.h
+++ b/drivers/net/bnx2x/ecore_mfw_req.h
@@ -1,5 +1,5 @@
 /*-
- * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
+ * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis
  * David Christensen 
diff --git a/drivers/net/bnx2x/ecore_reg.h b/drivers/net/bnx2x/ecore_reg.h
index 9800baf..87a98b5 100644
--- a/drivers/net/bnx2x/ecore_reg.h
+++ b/drivers/net/bnx2x/ecore_reg.h
@@ -1,5 +1,5 @@
 /*-
- * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
+ * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis
  * David Christensen 
diff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c
index 7532967..b790400 100644
--- a/drivers/net/bnx2x/ecore_sp.c
+++ b/drivers/net/bnx2x/ecore_sp.c
@@ -1,5 +1,5 @@
 /*-
- * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
+ * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis
  * David Christensen 
diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h
index 772c8b1..d0d4082 100644
--- a/drivers/net/bnx2x/ecore_sp.h
+++ b/drivers/net/bnx2x/ecore_sp.h
@@ -1,5 +1,5 @@
 /*-
- * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
+ * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis
  * David Christensen 
diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
index 34a2937..f7e097a 100644
--- a/drivers/net/bnx2x/elink.c
+++ b/drivers/net/bnx2x/elink.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2007-2013 Cavium Inc. All rights reserved.
+ * Copyright (c) 2007-2013 Broadcom Corporatio

[dpdk-dev] [PATCH v3] net/bnx2x: move SPDX tags to source files

[Rasesh Mody]

We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX licensing
tag from all the source file. Remove the LICENSE.bnx2x_pmd file and
directly include SPDX tags in source files.

Signed-off-by: Rasesh Mody 
Acked-by: Hemant Agrawal 
---
 drivers/net/bnx2x/LICENSE.bnx2x_pmd |3 ---
 drivers/net/bnx2x/Makefile  |9 -
 drivers/net/bnx2x/bnx2x.c   |4 +---
 drivers/net/bnx2x/bnx2x.h   |4 +---
 drivers/net/bnx2x/bnx2x_ethdev.c|5 +
 drivers/net/bnx2x/bnx2x_ethdev.h|5 +
 drivers/net/bnx2x/bnx2x_logs.h  |5 +
 drivers/net/bnx2x/bnx2x_rxtx.c  |5 +
 drivers/net/bnx2x/bnx2x_rxtx.h  |5 +
 drivers/net/bnx2x/bnx2x_stats.c |4 +---
 drivers/net/bnx2x/bnx2x_stats.h |4 +---
 drivers/net/bnx2x/bnx2x_vfpf.c  |5 +
 drivers/net/bnx2x/bnx2x_vfpf.h  |5 +
 drivers/net/bnx2x/ecore_fw_defs.h   |4 +---
 drivers/net/bnx2x/ecore_hsi.h   |4 +---
 drivers/net/bnx2x/ecore_init.h  |4 +---
 drivers/net/bnx2x/ecore_init_ops.h  |4 +---
 drivers/net/bnx2x/ecore_mfw_req.h   |4 +---
 drivers/net/bnx2x/ecore_reg.h   |4 +---
 drivers/net/bnx2x/ecore_sp.c|4 +---
 drivers/net/bnx2x/ecore_sp.h|4 +---
 drivers/net/bnx2x/elink.c   |4 +---
 drivers/net/bnx2x/elink.h   |4 +---
 23 files changed, 25 insertions(+), 78 deletions(-)
 delete mode 100644 drivers/net/bnx2x/LICENSE.bnx2x_pmd

diff --git a/drivers/net/bnx2x/LICENSE.bnx2x_pmd 
b/drivers/net/bnx2x/LICENSE.bnx2x_pmd
deleted file mode 100644
index 64c6ef2..000
--- a/drivers/net/bnx2x/LICENSE.bnx2x_pmd
+++ /dev/null
@@ -1,3 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2014-2018 Cavium Inc.
- */
diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile
index 150b4cf..55d1ad6 100644
--- a/drivers/net/bnx2x/Makefile
+++ b/drivers/net/bnx2x/Makefile
@@ -1,8 +1,7 @@
-#Copyright (c) 2014 - 2018 Cavium Inc.
-#All rights reserved.
-#www.cavium.com
-#
-#See LICENSE.bnx2x_pmd for copyright and licensing details.
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (c) 2014 - 2018 Cavium Inc.
+# All rights reserved.
+# www.cavium.com
 include $(RTE_SDK)/mk/rte.vars.mk
 
 #
diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 84ade5f..317578c 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #define BNX2X_DRIVER_VERSION "1.78.18"
diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h
index 4150fd8..34a5d65 100644
--- a/drivers/net/bnx2x/bnx2x.h
+++ b/drivers/net/bnx2x/bnx2x.h
@@ -1,4 +1,4 @@
-/*-
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2007-2013 Broadcom Corporation.
  *
  * Eric Davis
@@ -9,8 +9,6 @@
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef __BNX2X_H__
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c
index 3a554b8..0949330 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.c
+++ b/drivers/net/bnx2x/bnx2x_ethdev.c
@@ -1,11 +1,8 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
- *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #include "bnx2x.h"
diff --git a/drivers/net/bnx2x/bnx2x_ethdev.h b/drivers/net/bnx2x/bnx2x_ethdev.h
index f05be7e..3178245 100644
--- a/drivers/net/bnx2x/bnx2x_ethdev.h
+++ b/drivers/net/bnx2x/bnx2x_ethdev.h
@@ -1,11 +1,8 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
- *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef PMD_BNX2X_ETHDEV_H
diff --git a/drivers/net/bnx2x/bnx2x_logs.h b/drivers/net/bnx2x/bnx2x_logs.h
index 69a2fe1..9e232a9 100644
--- a/drivers/net/bnx2x/bnx2x_logs.h
+++ b/drivers/net/bnx2x/bnx2x_logs.h
@@ -1,11 +1,8 @@
-/*
+/* SPDX-License-Identifier: BSD-3-Clause
  * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
- *
  * Copyright (c) 2015-2018 Cavium Inc.
  * All rights reserved.
  * www.cavium.com
- *
- * See LICENSE.bnx2x_pmd for copyright and licensing details.
  */
 
 #ifndef _PMD_LOGS_H_
diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c
index 331884c..d9a4127 100644
--- a/drivers/net/bnx2x/bnx2x_rxtx.c
+++ b/drivers/net/bnx2x/bnx2x_rxtx.c
@@ -1,11 +1,8 @@

Re: [dpdk-dev] DPDK and forked processes

[Stephen Hemminger]

On Fri, 27 Jul 2018 17:03:48 +0200
Thomas Monjalon  wrote:

> 27/07/2018 15:46, Eads, Gage:
> > As this discussion has broad implications for DPDK, is it a good candidate 
> > for a techboard meeting topic?   
> 
> We can discuss it in techboard, but usually we prefer discussing topics
> whose resolution is not clear.
> In this case, I think everybody agree with Anatoly, isn't it?

I would prefer that decisions like this be done by rough consensus on the 
mailing list.

As far as applications messing with internals, in reality any application can 
change
anything. Just don't come crying to DPDK community for help.
 

Re: [dpdk-dev] DPDK and forked processes

[Eads, Gage]

Agreed on both points. I'll submit a patchset to remove the l2fwd_fork example 
and its user-guide, so it doesn't appear that DPDK supports this model. If 
anyone on the ML disagrees, they can respond here or on the patch thread.

> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Friday, July 27, 2018 11:00 AM
> To: Thomas Monjalon 
> Cc: Eads, Gage ; Burakov, Anatoly
> ; dev@dpdk.org; Richardson, Bruce
> ; jerin.ja...@caviumnetworks.com; Yigit, Ferruh
> ; hemant.agra...@nxp.com; Ananyev, Konstantin
> ; Olivier Matz 
> Subject: Re: DPDK and forked processes
> 
> On Fri, 27 Jul 2018 17:03:48 +0200
> Thomas Monjalon  wrote:
> 
> > 27/07/2018 15:46, Eads, Gage:
> > > As this discussion has broad implications for DPDK, is it a good 
> > > candidate for
> a techboard meeting topic?
> >
> > We can discuss it in techboard, but usually we prefer discussing
> > topics whose resolution is not clear.
> > In this case, I think everybody agree with Anatoly, isn't it?
> 
> I would prefer that decisions like this be done by rough consensus on the 
> mailing
> list.
> 
> As far as applications messing with internals, in reality any application can
> change anything. Just don't come crying to DPDK community for help.
> 

[dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

[Luca Boccassi]

rx_drop_en is an optimization that does nothing on single-queue
devices like e1000. Do not force applications that do not care to
select per-devices optimizations flags by returning an error, just
log it and carry on.

Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)")
Cc: sta...@dpdk.org

Signed-off-by: Luca Boccassi 
---
 drivers/net/e1000/em_rxtx.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c
index a6b3e92a6..81dc41efb 100644
--- a/drivers/net/e1000/em_rxtx.c
+++ b/drivers/net/e1000/em_rxtx.c
@@ -1416,12 +1416,13 @@ eth_em_rx_queue_setup(struct rte_eth_dev *dev,
}
 
/*
-* EM devices don't support drop_en functionality
+* EM devices don't support drop_en functionality.
+* It's an optimization that does nothing on single-queue devices,
+* so just log the issue and carry on.
 */
if (rx_conf->rx_drop_en) {
-   PMD_INIT_LOG(ERR, "drop_en functionality not supported by "
+   PMD_INIT_LOG(NOTICE, "drop_en functionality not supported by "
 "device");
-   return -EINVAL;
}
 
/* Free memory prior to re-allocation if needed. */
-- 
2.18.0

[dpdk-dev] [PATCH] net/e1000: enable MSI-x for linkup and other events in 82574

[Luca Boccassi]

Linux supports 82574 MSI-x interrupt for linkup and other link
conditions. Enable the same feature in the e1000 PMD in order to
allow this card to work properly, as it requires interrupt
handling for link negotiations among other things.

Signed-off-by: Luca Boccassi 
---

Hi Wenzhuo - just to make it clear, this patch and the previous are
not targeted for 18.08, just clearing my queue.

 drivers/net/e1000/base/e1000_82571.c | 5 +
 drivers/net/e1000/em_ethdev.c| 5 +++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/net/e1000/base/e1000_82571.c 
b/drivers/net/e1000/base/e1000_82571.c
index 7c279dbb3..397dd9482 100644
--- a/drivers/net/e1000/base/e1000_82571.c
+++ b/drivers/net/e1000/base/e1000_82571.c
@@ -1257,6 +1257,11 @@ STATIC s32 e1000_init_hw_82571(struct e1000_hw *hw)
 */
e1000_clear_hw_cntrs_82571(hw);
 
+   /* MSI-X configure for 82574 */
+   if (mac->type == e1000_82574)
+   E1000_WRITE_REG(hw, E1000_IVAR,
+   (E1000_IVAR_INT_ALLOC_VALID << 16));
+
return ret_val;
 }
 
diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index 7039dc100..bd05e4de0 100644
--- a/drivers/net/e1000/em_ethdev.c
+++ b/drivers/net/e1000/em_ethdev.c
@@ -1444,7 +1444,8 @@ eth_em_interrupt_setup(struct rte_eth_dev *dev)
/* clear interrupt */
E1000_READ_REG(hw, E1000_ICR);
regval = E1000_READ_REG(hw, E1000_IMS);
-   E1000_WRITE_REG(hw, E1000_IMS, regval | E1000_ICR_LSC);
+   E1000_WRITE_REG(hw, E1000_IMS,
+   regval | E1000_ICR_LSC | E1000_ICR_OTHER);
return 0;
 }
 
@@ -1494,7 +1495,7 @@ em_rxq_intr_enable(struct e1000_hw *hw)
 static void
 em_lsc_intr_disable(struct e1000_hw *hw)
 {
-   E1000_WRITE_REG(hw, E1000_IMC, E1000_IMS_LSC);
+   E1000_WRITE_REG(hw, E1000_IMC, E1000_IMS_LSC | E1000_IMS_OTHER);
E1000_WRITE_FLUSH(hw);
 }
 
-- 
2.18.0

[dpdk-dev] Questions about TX descriptors run out occasionally

[Hui Liu]

Hi Experts,

I'm developing my own dpdk-based application via Intel 82599ES port. My
Application is doing a job to send ICMP requests (packet size varies from
64 bytes to 1472 bytes, 200,000 pps, 1.1Gbps) and receive responses, with
ARP request/response and ICMP response handling when necessary. It was
working pretty fine in 5 hours to 10 days  randomly and then TX descriptors
run out and cannot be freed by ixgbe_tx_free_bufs() due to DD bit is not
set:

/* check DD bit on threshold descriptor */
status = txq->tx_ring[txq->tx_next_dd].wb.status;
if (!(status & IXGBE_ADVTXD_STAT_DD))
return 0;

My tx queue setup is:
tx_conf->tx_thresh.pthresh = 64;
tx_conf->tx_thresh.hthresh = 0;
tx_conf->tx_thresh.wthresh = 0;
tx_conf->tx_free_thresh = 256;
tx_conf->tx_rs_thresh = 32;
tx_conf->txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |
ETH_TXQ_FLAGS_NOOFFLOADS;


I tried to read code to see if there is any case to take these descriptors
and never set IXGBE_ADVTXD_STAT_DD back but no luck yet. And I have not
even found the related code when IXGBE_ADVTXD_STAT_DD is set/unset when
descriptor is taken/released other than reset queues... So may I ask:
1. where do we set/unset IXGBE_ADVTXD_STAT_DD when descriptor is
taken/released?
2. any suggestion or information I should focus on to debug this issue? Is
this typically because of my upper application not alloc/free correctly or
any other problem?
3. another friend in dpdk-user list raised same issue in fm10k driver, but
later he mentioned his problem was because of overheating of NIC
(temperature was close to 85 degree Celsius). After setting system FAN to
full speed, he made it work perfectly. Since in my system I don't have
fan/temp sensors so I could not check this. Might this problem be caused by
high temperature in case?

Regards,
Hui