27/07/2018 15:45, Andrew Rybchenko: > On 27.07.2018 00:34, Thomas Monjalon wrote: > > 11/07/2018 12:59, Andrew Rybchenko: > >> Functions rte_mempool_populate_phys(), rte_mempool_virt2phy() and > >> rte_mempool_populate_phys_tab() are just wrappers for corresponding > >> IOVA functions and were deprecated in v17.11. > >> > >> Functions rte_mempool_xmem_create(), rte_mempool_xmem_size(), > >> rte_mempool_xmem_usage() and rte_mempool_populate_iova_tab() were > >> deprecated in v18.05 and removal was announced earlier in v18.02. > >> > >> Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com> > >> --- > >> lib/librte_mempool/Makefile | 3 - > >> lib/librte_mempool/meson.build | 4 - > >> lib/librte_mempool/rte_mempool.c | 181 +-------------------- > >> lib/librte_mempool/rte_mempool.h | 179 -------------------- > >> lib/librte_mempool/rte_mempool_version.map | 6 - > >> 5 files changed, 1 insertion(+), 372 deletions(-) > > Please update the release notes, deprecation notice, and bump ABI version. > > Will do. Deprecation notice which schedules removal of xmem functions > was removed on previous release when these function are deprecated. > Is it a problem? Should removal of already deprecated function pass > deprecation (removal) announcement procedure once again?
No, it's OK. We should have left the notice about removal but it's too late :)