Re: [dpdk-dev] [PATCH 1/2] ring: fix declaration after code

[Gavin Hu]

Hi Andy,

See my inline comments.

-Gavin

-Original Message-
From: dev  On Behalf Of Andy Green
Sent: Monday, May 28, 2018 10:29 AM
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] ring: fix declaration after code

On gcc 5.4.0 / native aarch64 from Ubuntu 16.04:

/home/agreen/lagopus/src/dpdk/build/include/
rte_ring_c11_mem.h: In function
'__rte_ring_move_prod_head':
/home/agreen/lagopus/src/dpdk/build/include/
rte_ring_c11_mem.h:69:3: warning: ISO C90 forbids mixed declarations and code 
[-Wdeclaration-after-statement]
   const uint32_t cons_tail = r->cons.tail;
   ^
/home/agreen/lagopus/src/dpdk/build/include/
rte_ring_c11_mem.h: In function
'__rte_ring_move_cons_head':
/home/agreen/lagopus/src/dpdk/build/include/
rte_ring_c11_mem.h:136:3: warning: ISO C90 forbids mixed declarations and code 
[-Wdeclaration-after-statement]
   const uint32_t prod_tail = r->prod.tail;
   ^

Signed-off-by: Andy Green 
Fixes: 39368ebfc6 ("ring: introduce C11 memory model barrier option")
---
 lib/librte_ring/rte_ring_c11_mem.h |8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ring/rte_ring_c11_mem.h 
b/lib/librte_ring/rte_ring_c11_mem.h
index cb3f82b1a..3cc339558 100644
--- a/lib/librte_ring/rte_ring_c11_mem.h
+++ b/lib/librte_ring/rte_ring_c11_mem.h
@@ -61,12 +61,14 @@ __rte_ring_move_prod_head(struct rte_ring *r, unsigned int 
is_sp,
 int success;

 do {
+const uint32_t cons_tail = r->cons.tail;
+
 /* Reset n to the initial burst count */
 n = max;

 *old_head = __atomic_load_n(&r->prod.head,
 __ATOMIC_ACQUIRE);
-const uint32_t cons_tail = r->cons.tail;
+
[Gavin Hu] The ACQUIRE and RELEASE pair protects anything that between the two 
must be visible to other threads when they perform an acquire operation on the 
same memory address. Your changes broke this semantics.  I advise to move the 
declaration before and keep the assignment in the old place.
 /*
  *  The subtraction is done between two unsigned 32bits value
  * (the result is always modulo 32 bits even if we have @@ -129,11 +131,13 @@ 
__rte_ring_move_cons_head(struct rte_ring *r, int is_sc,

 /* move cons.head atomically */
 do {
+const uint32_t prod_tail = r->prod.tail;
+
 /* Restore n as it may change every loop */
 n = max;
 *old_head = __atomic_load_n(&r->cons.head,
 __ATOMIC_ACQUIRE);
-const uint32_t prod_tail = r->prod.tail;
+
 /* The subtraction is done between two unsigned 32bits value
  * (the result is always modulo 32 bits even if we have
  * cons_head > prod_tail). So 'entries' is always between 0

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

Re: [dpdk-dev] [PATCH 1/2] ring: fix declaration after code

[Andy Green]

On 05/28/2018 04:15 PM, Gavin Hu wrote:


  do {
+const uint32_t cons_tail = r->cons.tail;
+
  /* Reset n to the initial burst count */
  n = max;

  *old_head = __atomic_load_n(&r->prod.head,
  __ATOMIC_ACQUIRE);
-const uint32_t cons_tail = r->cons.tail;
+
[Gavin Hu] The ACQUIRE and RELEASE pair protects anything that between the two 
must be visible to other threads when they perform an acquire operation on the 
same memory address. Your changes broke this semantics.  I advise to move the 
declaration before and keep the assignment in the old place.


I see, thanks for the tip.

How about just get rid of this temp altogether if access to it is locked 
during this sequence anyway?  It's not like we had to sample it after 
the lock then, or it's bringing anything else to the party.


So instead of cons_tail / prod_tail at all, replace directly with 
r->cons.tail / r->prod.tail at the single usage for each.


-Andy

Re: [dpdk-dev] [PATCH 1/2] ring: fix declaration after code

[Gavin Hu]

-Original Message-
From: Andy Green 
Sent: Monday, May 28, 2018 4:47 PM
To: Gavin Hu ; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] ring: fix declaration after code



On 05/28/2018 04:15 PM, Gavin Hu wrote:

>   do {
> +const uint32_t cons_tail = r->cons.tail;
> +
>   /* Reset n to the initial burst count */
>   n = max;
>
>   *old_head = __atomic_load_n(&r->prod.head,
>   __ATOMIC_ACQUIRE);
> -const uint32_t cons_tail = r->cons.tail;
> +
> [Gavin Hu] The ACQUIRE and RELEASE pair protects anything that between the 
> two must be visible to other threads when they perform an acquire operation 
> on the same memory address. Your changes broke this semantics.  I advise to 
> move the declaration before and keep the assignment in the old place.

I see, thanks for the tip.

How about just get rid of this temp altogether if access to it is locked during 
this sequence anyway?  It's not like we had to sample it after the lock then, 
or it's bringing anything else to the party.

So instead of cons_tail / prod_tail at all, replace directly with
r->cons.tail / r->prod.tail at the single usage for each.
[Gavin Hu] I think it is ok.

-Andy

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

[dpdk-dev] [PATCH v2 1/2] ring: fix declaration after code

[Andy Green]

On gcc 5.4.0 / native aarch64 from Ubuntu 16.04:

/home/agreen/lagopus/src/dpdk/build/include/
rte_ring_c11_mem.h: In function
'__rte_ring_move_prod_head':
/home/agreen/lagopus/src/dpdk/build/include/
rte_ring_c11_mem.h:69:3: warning: ISO C90
forbids mixed declarations and code
[-Wdeclaration-after-statement]
   const uint32_t cons_tail = r->cons.tail;
   ^
/home/agreen/lagopus/src/dpdk/build/include/
rte_ring_c11_mem.h: In function
'__rte_ring_move_cons_head':
/home/agreen/lagopus/src/dpdk/build/include/
rte_ring_c11_mem.h:136:3: warning: ISO C90
forbids mixed declarations and code
[-Wdeclaration-after-statement]
   const uint32_t prod_tail = r->prod.tail;
   ^

Signed-off-by: Andy Green 
Fixes: 39368ebfc6 ("ring: introduce C11 memory model barrier option")
---
 lib/librte_ring/rte_ring_c11_mem.h |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/librte_ring/rte_ring_c11_mem.h 
b/lib/librte_ring/rte_ring_c11_mem.h
index cb3f82b1a..94df3c4a6 100644
--- a/lib/librte_ring/rte_ring_c11_mem.h
+++ b/lib/librte_ring/rte_ring_c11_mem.h
@@ -66,14 +66,14 @@ __rte_ring_move_prod_head(struct rte_ring *r, unsigned int 
is_sp,
 
*old_head = __atomic_load_n(&r->prod.head,
__ATOMIC_ACQUIRE);
-   const uint32_t cons_tail = r->cons.tail;
+
/*
 *  The subtraction is done between two unsigned 32bits value
 * (the result is always modulo 32 bits even if we have
 * *old_head > cons_tail). So 'free_entries' is always between 0
 * and capacity (which is < size).
 */
-   *free_entries = (capacity + cons_tail - *old_head);
+   *free_entries = (capacity + r->cons.tail - *old_head);
 
/* check that we have enough room in ring */
if (unlikely(n > *free_entries))
@@ -133,13 +133,13 @@ __rte_ring_move_cons_head(struct rte_ring *r, int is_sc,
n = max;
*old_head = __atomic_load_n(&r->cons.head,
__ATOMIC_ACQUIRE);
-   const uint32_t prod_tail = r->prod.tail;
+
/* The subtraction is done between two unsigned 32bits value
 * (the result is always modulo 32 bits even if we have
 * cons_head > prod_tail). So 'entries' is always between 0
 * and size(ring)-1.
 */
-   *entries = (prod_tail - *old_head);
+   *entries = (r->prod.tail - *old_head);
 
/* Set the actual entries for dequeue */
if (n > *entries)

[dpdk-dev] [PATCH v2 0/2] dpdk header fixes for aarch64

[Andy Green]

On Xenial / 16.04 native aarch64 build with gcc 5.4.0,
lagopus build finds a couple more issues hiding in
dpdk headers.

---

Andy Green (2):
  ring: fix declaration after code
  ring: fix sign conversion warning


 lib/librte_ring/rte_ring.h |2 +-
 lib/librte_ring/rte_ring_c11_mem.h |8 
 2 files changed, 5 insertions(+), 5 deletions(-)

--
Signature

[dpdk-dev] [PATCH v2 2/2] ring: fix sign conversion warning

[Andy Green]

On gcc 5.4.0 / native aarch64 from Ubuntu 16.04:

/home/agreen/lagopus/src/dpdk/build/include/rte_ring.h:
In function '__rte_ring_do_dequeue':
/home/agreen/lagopus/src/dpdk/build/include/rte_ring.h:
 385:35: warning: conversion to 'int' from 'unsigned int'
may change the sign of the result [-Wsign-conversion]
  n = __rte_ring_move_cons_head(r, is_sc, n, behavior,
   ^

Signed-off-by: Andy Green 
Fixes: e8ed5056c8 ("ring: remove signed type flip-flopping")
   ^
---
 lib/librte_ring/rte_ring.h |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
index 124582251..de1a5f366 100644
--- a/lib/librte_ring/rte_ring.h
+++ b/lib/librte_ring/rte_ring.h
@@ -382,7 +382,7 @@ __rte_ring_do_dequeue(struct rte_ring *r, void **obj_table,
uint32_t cons_head, cons_next;
uint32_t entries;
 
-   n = __rte_ring_move_cons_head(r, is_sc, n, behavior,
+   n = __rte_ring_move_cons_head(r, (int)is_sc, n, behavior,
&cons_head, &cons_next, &entries);
if (n == 0)
goto end;

Re: [dpdk-dev] [PATCH] devtools: add script to verify map files

[Bruce Richardson]

On Sun, May 27, 2018 at 10:50:58PM +0200, Thomas Monjalon wrote:
> Sorry for having missed this patch during so long.
> 
> 13/02/2018 11:48, Ferruh Yigit:
> > On 2/12/2018 4:13 PM, Pavan Nikhilesh wrote:
> > > This script checks for the symbols specified in the map files against
> > > the symbols present in the map file directory.
> > > Currently, the script checks for map files in drivers and lib directory.
> > > 
> > > Example:
> > > ./devtools/check-map.py
> > > 
> > > The following symbols are unused :
> > > 
> > > Map file : /home/pavan/Work/clean/dpdk/drivers/mempool/dpaa/...
> > > ['rte_dpaa_pool_table']
> > > 
> > > Map file : /home/pavan/Work/clean/dpdk/drivers/bus/fslmc/...
> > > ['qbman_get_version', 'qbman_swp_send_multiple']
> > > 
> > > ...
> > > 
> > > Signed-off-by: Pavan Nikhilesh 
> > 
> > +1 to improve our tools.
> > 
> > Acked-by: Ferruh Yigit 
> 
> I agree we must have more tools.
> 
> I think this check can be a lot simpler as a shell script,
> instead of Python. It does not need the list features of Python.
> 

While the shell version can be shorter, I always find python scripts to be
far easier to read, understand and therefore maintain than shell scripts.
While power-users of shell, like yourself, Thomas, can come up with some
amazing stuff done in shell, it tends to make them very hard to follow for
us mere mortals.

/Bruce

Re: [dpdk-dev] [PATCH] devtools: add script to verify map files

[Thomas Monjalon]

28/05/2018 11:21, Bruce Richardson:
> On Sun, May 27, 2018 at 10:50:58PM +0200, Thomas Monjalon wrote:
> > Sorry for having missed this patch during so long.
> > 
> > 13/02/2018 11:48, Ferruh Yigit:
> > > On 2/12/2018 4:13 PM, Pavan Nikhilesh wrote:
> > > > This script checks for the symbols specified in the map files against
> > > > the symbols present in the map file directory.
> > > > Currently, the script checks for map files in drivers and lib directory.
> > > > 
> > > > Example:
> > > > ./devtools/check-map.py
> > > > 
> > > > The following symbols are unused :
> > > > 
> > > > Map file : /home/pavan/Work/clean/dpdk/drivers/mempool/dpaa/...
> > > > ['rte_dpaa_pool_table']
> > > > 
> > > > Map file : /home/pavan/Work/clean/dpdk/drivers/bus/fslmc/...
> > > > ['qbman_get_version', 'qbman_swp_send_multiple']
> > > > 
> > > > ...
> > > > 
> > > > Signed-off-by: Pavan Nikhilesh 
> > > 
> > > +1 to improve our tools.
> > > 
> > > Acked-by: Ferruh Yigit 
> > 
> > I agree we must have more tools.
> > 
> > I think this check can be a lot simpler as a shell script,
> > instead of Python. It does not need the list features of Python.
> > 
> 
> While the shell version can be shorter, I always find python scripts to be
> far easier to read, understand and therefore maintain than shell scripts.
> While power-users of shell, like yourself, Thomas, can come up with some
> amazing stuff done in shell, it tends to make them very hard to follow for
> us mere mortals.

Some processing are simpler in Python.
But here, the python script is mostly calling some shell commands and
filtering like grep.

For comparison, python version:
http://dpdk.org/ml/archives/dev/2018-February/090772.html
shell version:
http://dpdk.org/ml/archives/dev/2018-May/102993.html

Re: [dpdk-dev] [PATCH v2] devtools: add test script for meson builds

[Bruce Richardson]

On Sat, May 26, 2018 at 11:32:53AM +0200, Thomas Monjalon wrote:
> 25/05/2018 17:18, Bruce Richardson:
> > On Fri, May 25, 2018 at 04:51:58PM +0200, Thomas Monjalon wrote:
> > > +default_path=$PATH
> > > +
> > > +# Load config options
> > > +. $(dirname $(readlink -e $0))/load-devel-config
> > > +
> > 
> > Why is this needed here, it seems to be called before each individual
> > config anyway.
> 
> Right, it can be removed from here.
> 
> > > +reset_env ()
> > > +{
> > > + export PATH=$default_path
> > > + unset CROSS
> > > + unset ARMV8_CRYPTO_LIB_PATH
> > > + unset FLEXRAN_SDK
> > > + unset LIBMUSDK_PATH
> > > + unset LIBSSO_SNOW3G_PATH
> > > + unset LIBSSO_KASUMI_PATH
> > > + unset LIBSSO_ZUC_PATH
> > > + unset PQOS_INSTALL_PATH
> > 
> > These variables bar PATH are unused by meson build, so should be removed
> > here to avoid giving the impression they are use.
> 
> Actually they should be used when compiling.
> PATH can be used to allow a toolchain which is not in the standard path.
> And dependencies _PATH variables can be specified only for some builds.
> Example: I have libsso only for x86 64-bit, so I do not set it
> for 32-bit or ARM builds. The config file reads DPDK_TARGET to know.
> Note: DPDK_TARGET is not yet set correctly for every builds in this version.
> 

We don't need DPDK_TARGET variable any more, however, environmental vars
can be used by this script for setting up PATH and CFLAGS/LDFLAGS etc. as
needed. However, environmental vars bar those standard ones are ignored by
a meson build, so they would be only for script use. Therefore I'm
suggesting removing only the unused ones.

> > $CROSS is used by the
> > script so perhaps it can be kept. However, the whole point of the
> > cross-files is that you include all the needed details of your compiler
> > there. I think we should move away from using the CROSS value completely,
> > and use the cross-files properly.
> 
> Yes we can remove CROSS if it is redundant with config files in config/arm/.
> But I do not understand why these files cannot be agnostic regarding the
> name (CROSS) of the toolchain.
> To me it is very strange to have the binary names hard-linked in the configs.
> Anyway, this discussion is out of the scope of this script.
> So I am for removing the CROSS variable and use aarch64-linux-gnu-gcc
> as it is hard written in every ARM configs for now.

You can use CROSS in this script to set PATH for each build. Again, though
it would only be for script, not meson use.

> 
> > > +cd $(dirname $(readlink -m $0))/..
> > > +
> > I don't think we should force the builds to be always put into the base
> > directory. Instead of using cd, I think we should instead capture the base
> > directory path and pass that to meson.
> 
> OK to not force the directory.
> You want to build in the current directory?
> If yes, we can just remove this "cd" and no need to pass a base directory
> to meson.

We would need to pass the base to meson, because otherwise meson assumes
the top-level meson.build file is in the current directory, i.e. calling
"meson build-dir" is the same as "meson . build-dir". If we want to allow
using this script from other places on filesystem, we need to either "cd"
to the base dir as you do now, or else explicitly pass in the basedir. The
latter I think is a better option as it would allow building from any
location on the filesystem.

> 
> > > +load_config ()
> > > +{
> > > + reset_env
> > > + . $(dirname $(readlink -e $0))/load-devel-config
> > > + MESON=${MESON:-meson}
> > > +}
> > Why does this need to be done each time?
> 
> Because the config could be different for each build (see above).
> 
How would it be different, it's the same command called with the same
environment each time?

/Bruce

Re: [dpdk-dev] [PATCH v4] devtools: add test script for meson builds

[Bruce Richardson]

On Sat, May 26, 2018 at 01:21:42PM +0200, Thomas Monjalon wrote:
> From: Bruce Richardson 
> 
> To simplify testing with the meson and ninja builds, we can add a script
> to set up and do multiple builds. Currently this script sets up:
> 
> * clang and gcc builds
> * builds using static and shared linkage for binaries (libs are always
>built as both)
> * a build using the lowest instruction-set level for x86 (-march=nehalem)
> * cross-builds for each cross-file listed in config/arm
> 
> Each build is configured in a directory ending in *-build, and then for
> the build stage, we just call ninja in each directory in turn. [i.e. we
> assume every directory starting with "build-" is a meson build, which is
> probably an ok assumption].
> 
> Signed-off-by: Bruce Richardson 
> Signed-off-by: Thomas Monjalon 
> ---
> v2: it is a rework with 3 major changes
>- automatically stop on error thanks to -e
>- directory name starts with "build-"
>- optionally load a config file to get some environment variables
> v3:
>- remove forcing "cd": use current directory
>- remove CROSS: use hard-written aarch64-linux-gnu-gcc
>- remove config load in script start
> v4:
>- remove config file loading (will be improved and sent later)
>- the v4 is closer to what Bruce sent as v1
> ---

Yes, it's closer, but there is also some good material in your v2 that we
probably want to rework into this later on. I suggest in the name of
progress we merge this version and iterate on improving it later.

/Bruce

[dpdk-dev] [PATCH] net/mlx5: clean-up developer logs

[Nelio Laranjeiro]

Split maintainers logs from user logs.

A lot of debug logs are present providing internal information on how
the PMD works to users.  Such logs should not be available for them and
thus should remain available only when the PMD is compiled in debug
mode.

This commits removes some useless debug logs, move the Maintainers ones
under DEBUG and also move dump into debug mode only.

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_mr.c  | 119 +++-
 drivers/net/mlx5/mlx5_mr.h  |   5 +-
 drivers/net/mlx5/mlx5_rxq.c |  36 +-
 drivers/net/mlx5/mlx5_trigger.c |   2 -
 drivers/net/mlx5/mlx5_txq.c |  18 +
 5 files changed, 61 insertions(+), 119 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c
index abb1f5179..9cef988a3 100644
--- a/drivers/net/mlx5/mlx5_mr.c
+++ b/drivers/net/mlx5/mlx5_mr.c
@@ -197,9 +197,8 @@ mlx5_mr_btree_init(struct mlx5_mr_btree *bt, int n, int 
socket)
  0, socket);
if (bt->table == NULL) {
rte_errno = ENOMEM;
-   DRV_LOG(ERR,
-   "failed to allocate memory for btree cache on socket 
%d",
-   socket);
+   DEBUG("failed to allocate memory for btree cache on socket %d",
+ socket);
return -rte_errno;
}
bt->size = n;
@@ -207,8 +206,8 @@ mlx5_mr_btree_init(struct mlx5_mr_btree *bt, int n, int 
socket)
(*bt->table)[bt->len++] = (struct mlx5_mr_cache) {
.lkey = UINT32_MAX,
};
-   DRV_LOG(DEBUG, "initialized B-tree %p with table %p",
-   (void *)bt, (void *)bt->table);
+   DEBUG("initialized B-tree %p with table %p",
+ (void *)bt, (void *)bt->table);
return 0;
 }
 
@@ -223,8 +222,8 @@ mlx5_mr_btree_free(struct mlx5_mr_btree *bt)
 {
if (bt == NULL)
return;
-   DRV_LOG(DEBUG, "freeing B-tree %p with table %p",
-   (void *)bt, (void *)bt->table);
+   DEBUG("freeing B-tree %p with table %p",
+ (void *)bt, (void *)bt->table);
rte_free(bt->table);
memset(bt, 0, sizeof(*bt));
 }
@@ -235,9 +234,10 @@ mlx5_mr_btree_free(struct mlx5_mr_btree *bt)
  * @param bt
  *   Pointer to B-tree structure.
  */
-static void
-mlx5_mr_btree_dump(struct mlx5_mr_btree *bt)
+void
+mlx5_mr_btree_dump(struct mlx5_mr_btree *bt __rte_unused)
 {
+#ifndef NDEBUG
int idx;
struct mlx5_mr_cache *lkp_tbl;
 
@@ -247,11 +247,11 @@ mlx5_mr_btree_dump(struct mlx5_mr_btree *bt)
for (idx = 0; idx < bt->len; ++idx) {
struct mlx5_mr_cache *entry = &lkp_tbl[idx];
 
-   DRV_LOG(DEBUG,
-   "B-tree(%p)[%u],"
-   " [0x%" PRIxPTR ", 0x%" PRIxPTR ") lkey=0x%x",
-   (void *)bt, idx, entry->start, entry->end, entry->lkey);
+   DEBUG("B-tree(%p)[%u],"
+ " [0x%" PRIxPTR ", 0x%" PRIxPTR ") lkey=0x%x",
+ (void *)bt, idx, entry->start, entry->end, entry->lkey);
}
+#endif
 }
 
 /**
@@ -575,11 +575,10 @@ mlx5_mr_create(struct rte_eth_dev *dev, struct 
mlx5_mr_cache *entry,
assert(msl->page_sz == ms->hugepage_sz);
/* Number of memsegs in the range. */
ms_n = len / msl->page_sz;
-   DRV_LOG(DEBUG,
-   "port %u extending %p to [0x%" PRIxPTR ", 0x%" PRIxPTR "),"
-   " page_sz=0x%" PRIx64 ", ms_n=%u",
-   dev->data->port_id, (void *)addr,
-   data.start, data.end, msl->page_sz, ms_n);
+   DEBUG("port %u extending %p to [0x%" PRIxPTR ", 0x%" PRIxPTR "),"
+ " page_sz=0x%" PRIx64 ", ms_n=%u",
+ dev->data->port_id, (void *)addr,
+ data.start, data.end, msl->page_sz, ms_n);
/* Size of memory for bitmap. */
bmp_size = rte_bitmap_get_memory_footprint(ms_n);
mr = rte_zmalloc_socket(NULL,
@@ -588,10 +587,9 @@ mlx5_mr_create(struct rte_eth_dev *dev, struct 
mlx5_mr_cache *entry,
bmp_size,
RTE_CACHE_LINE_SIZE, msl->socket_id);
if (mr == NULL) {
-   DRV_LOG(WARNING,
-   "port %u unable to allocate memory for a new MR of"
-   " address (%p).",
-   dev->data->port_id, (void *)addr);
+   DEBUG("port %u unable to allocate memory for a new MR of"
+ " address (%p).",
+ dev->data->port_id, (void *)addr);
rte_errno = ENOMEM;
goto err_nolock;
}
@@ -605,10 +603,9 @@ mlx5_mr_create(struct rte_eth_dev *dev, struct 
mlx5_mr_cache *entry,
bmp_mem = RTE_PTR_ALIGN_CEIL(mr + 1, RTE_CACHE_LINE_SIZE);
mr->ms_bmp = rte_bitmap_init(ms_n, bmp_mem, bmp_size);
if (mr->ms_bmp == NULL) {
-   DRV_LOG(WARNING,
- 

[dpdk-dev] [DPDK 18.08] ethdev: add flow API to expand RSS flows

[Nelio Laranjeiro]

Introduce an helper for PMD to expand easily flows items list with RSS
action into multiple flow items lists with priority information.

For instance a user items list being "eth / end" with rss action types
"ipv4-udp ipv6-udp end" needs to be expanded into three items lists:

 - eth
 - eth / ipv4 / udp
 - eth / ipv6 / udp

to match the user request.  Some drivers are unable to reach such
request without this expansion, this API is there to help those.
Only PMD should use such API for their internal cooking, the application
will still handle a single flow.

Signed-off-by: Nelio Laranjeiro 
---
 lib/librte_ethdev/rte_flow.c| 404 
 lib/librte_ethdev/rte_flow_driver.h |  32 +++
 2 files changed, 436 insertions(+)

diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
index 7947529da..0c42fc31c 100644
--- a/lib/librte_ethdev/rte_flow.c
+++ b/lib/librte_ethdev/rte_flow.c
@@ -507,3 +507,407 @@ rte_flow_copy(struct rte_flow_desc *desc, size_t len,
}
return 0;
 }
+
+/* Copy the existing items list and expand with new items. */
+static int
+rte_flow_expand_rss_item(void *buf, size_t size,
+const struct rte_flow_item *items,
+const struct rte_flow_item *newitems)
+{
+   void *data = buf;
+   const struct rte_flow_item *item;
+   struct rte_flow_item *dst;
+   size_t data_size = 0;
+
+   dst = data;
+   /* Copy Item structure into buffer. */
+   for (item = items; item->type != RTE_FLOW_ITEM_TYPE_END; ++item) {
+   if (item->type == RTE_FLOW_ITEM_TYPE_VOID)
+   continue;
+   if (data_size + sizeof(*item) <= size) {
+   memcpy(dst, item, sizeof(*item));
+   ++dst;
+   }
+   data_size += sizeof(*item);
+   }
+   item = newitems;
+   do {
+   if (item->type == RTE_FLOW_ITEM_TYPE_VOID) {
+   ++item;
+   continue;
+   }
+   if (data_size + sizeof(*item) <= size) {
+   memcpy(dst, item, sizeof(*item));
+   ++dst;
+   }
+   data_size += sizeof(*item);
+   ++item;
+   } while ((item - 1)->type != RTE_FLOW_ITEM_TYPE_END);
+   /**
+* Copy Item spec, last, mask into buffer and set pointers
+* accordingly.
+*/
+   dst = data;
+   for (item = items; item->type != RTE_FLOW_ITEM_TYPE_END; ++item) {
+   if (item->type == RTE_FLOW_ITEM_TYPE_VOID)
+   continue;
+   if (item->spec) {
+   size_t s = flow_item_spec_copy(NULL, item, ITEM_SPEC);
+   void *addr = (data_size + s) <= size ?
+   (void *)((uintptr_t)data + data_size) :
+   NULL;
+
+   data_size += flow_item_spec_copy(addr, item, ITEM_SPEC);
+   if (addr)
+   dst->spec = addr;
+   }
+   if (item->last) {
+   size_t s = flow_item_spec_copy(NULL, item, ITEM_LAST);
+   void *addr = (data_size + s) <= size ?
+   (void *)((uintptr_t)data + data_size) :
+   NULL;
+
+   data_size += flow_item_spec_copy(addr, item, ITEM_LAST);
+   if (addr)
+   dst->last = addr;
+   }
+   if (item->mask) {
+   size_t s = flow_item_spec_copy(NULL, item, ITEM_MASK);
+   void *addr = (data_size + s) <= size ?
+   (void *)((uintptr_t)data + data_size) :
+   NULL;
+
+   data_size += flow_item_spec_copy(addr, item, ITEM_MASK);
+   if (addr)
+   dst->mask = addr;
+   }
+   if (data_size <= size)
+   ++dst;
+   }
+   return data_size;
+}
+
+/** Verify the expansion is supported by the device. */
+static int
+rte_flow_expand_rss_is_supported(const enum rte_flow_item_type **supported,
+const enum rte_flow_item_type *expand)
+{
+   unsigned int i;
+   unsigned int sidx;
+   unsigned int eidx;
+
+   for (i = 0; supported[i]; ++i) {
+   sidx = 0;
+   eidx = 0;
+   while (1) {
+   if (expand[eidx] != supported[i][sidx]) {
+   break;
+   } else if ((expand[eidx] == RTE_FLOW_ITEM_TYPE_END) &&
+  (supported[i][sidx] ==
+   RTE_FLOW_ITEM_TYPE_END)) {
+   return 1;
+   } else if ((expand[e

Re: [dpdk-dev] [dpdk-stable] 17.11.3 (LTS) patches review and test

[Kevin Traynor]

On 05/27/2018 06:35 AM, Yuanhan Liu wrote:
> Hi all,
> 
> Here is a list of patches targeted for LTS release 17.11.3. Please
> help review and test. The planned date for the final release is 8th,
> Jun. Before that, please let me know if anyone has objections with
> these patches being applied.
> 
> These patches are located at branch 17.11 of dpdk-stable repo:
> http://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
>   --yliu
> 
> ---
> Aaron Conole (2):
>   nfp: unlink the appropriate lock file
>   nfp: allow for non-root user
> 

Hi Yuanhan,

These patches which are stable relevant only, need a small fix which is
here on 18.02 branch:
http://dpdk.org/browse/dpdk-stable/commit/?h=18.02&id=e89e323e4ce58f2cbbc7afcc2d5dc7ce66075e81

thanks,
Kevin.

> Adrien Mazarguil (1):
>   app/testpmd: fix empty list of RSS queues for flow
> 
> Ajit Khaparde (9):
>   net/bnxt: fix LRO disable
>   net/bnxt: fix Rx drop setting
>   net/bnxt: set padding flags in Rx descriptor
>   net/bnxt: fix endianness of flag
>   net/bnxt: fix Rx checksum flags for tunnel frames
>   net/bnxt: free memory allocated for VF filters
>   net/bnxt: avoid invalid vnic id in set L2 Rx mask
>   net/bnxt: fix usage of vnic id
>   net/bnxt: fix Rx checksum flags
> 
> Alejandro Lucero (5):
>   net/nfp: fix assigning port id in mbuf
>   net/nfp: fix barrier location
>   net/nfp: fix link speed capabilities
>   doc: fix NFP NIC guide grammar
>   net/nfp: fix mbufs releasing when stop or close
> 
> Allain Legacy (1):
>   ip_frag: fix double free of chained mbufs
> 
> Anatoly Burakov (4):
>   app/crypto-perf: fix IOVA translation
>   mem: do not use physical addresses in IOVA as VA mode
>   vfio: do not needlessly check for IOVA mode
>   mempool: fix virtual address population
> 
> Andrew Rybchenko (6):
>   net/sfc: add missing defines for SAL annotation
>   net/sfc: fix mbuf data alignment calculation
>   net/sfc/base: fix comparison always true warning
>   mempool: fix leak when no objects are populated
>   test/mempool: fix autotest retry
>   net/sfc: ignore spec bits not covered by mask
> 
> Andy Green (3):
>   net/bnx2x: do not cast function pointers as a policy
>   net/bnx2x: fix KR2 device check
>   net/bnx2x: fix memzone name overrun
> 
> Ashish Jain (1):
>   event/dpaa2: remove link from info structure
> 
> Beilei Xing (3):
>   net/i40e: fix DDP profile DEL operation
>   net/i40e: fix link status update
>   net/i40e: fix failing to disable FDIR Tx queue
> 
> Bin Huang (1):
>   net/mlx5: add packet type index for TCP ack
> 
> Chas Williams (5):
>   net/vmxnet3: set the queue shared buffer at start
>   net/bonding: fix setting VLAN ID on slave ports
>   net/bonding: clear started state if start fails
>   net/ixgbe: fix busy wait during checking link status
>   net/bonding: export mode 4 slave info routine
> 
> Chuhong Yao (1):
>   net/liquidio: fix link state fetching during start
> 
> Ciara Loftus (1):
>   net/vhost: initialise device as inactive
> 
> Dan Gora (1):
>   kni: fix build on CentOS 7.4
> 
> Daniel Shelepov (1):
>   app/testpmd: fix burst stats reporting
> 
> David Hunt (4):
>   mk: fix make defconfig on FreeBSD
>   test/distributor: fix return type of thread function
>   test/pipeline: fix return type of stub miss
>   examples/performance-thread: fix return type of threads
> 
> Fan Zhang (2):
>   net/i40e: fix link update no wait
>   crypto/scheduler: fix possible duplicated ring names
> 
> Ferruh Yigit (4):
>   pci: remove duplicated symbol from map file
>   net/tap: fix icc build
>   drivers/net: fix link autoneg value for virtual PMDs
>   net/i40e: fix shifts of signed values
> 
> Gaetan Rivet (2):
>   bus/fslmc: fix find device start condition
>   bus/pci: fix find device implementation
> 
> Gowrishankar Muthukrishnan (2):
>   eal/ppc: remove braces in SMP memory barrier macro
>   net/bonding: fix primary slave port id storage type
> 
> Harish Patil (1):
>   net/qede: fix multicast filtering
> 
> Hemant Agrawal (6):
>   net/dpaa: fix oob access
>   bus/dpaa: fix resource leak
>   net/dpaa2: fix xstats
>   app/crypto-perf: fix excess crypto device error
>   examples/l2fwd-crypto: fix the default aead assignments
>   crypto/dpaa2_sec: fix HMAC supported digest sizes
> 
> Hyong Youb Kim (1):
>   net/enic: allocate stats DMA buffer upfront during probe
> 
> Ivan Malov (2):
>   net/sfc: add missing Rx fini on RSS setup fail path
>   net/sfc: process RSS settings on Rx configure step
> 
> Jasvinder Singh (1):
>   test/pipeline: fix type of table entry parameter
> 
> Jerin Jacob (2):
>   app/crypto-perf: use strcpy for allocated string
>   app/crypto-perf: fix parameters copy
> 
> John Daley (1):
>   net/enic: fix crash on MTU update with non-

Re: [dpdk-dev] [PATCH v2] devtools: add test script for meson builds

[Thomas Monjalon]

28/05/2018 11:33, Bruce Richardson:
> On Sat, May 26, 2018 at 11:32:53AM +0200, Thomas Monjalon wrote:
> > 25/05/2018 17:18, Bruce Richardson:
> > > On Fri, May 25, 2018 at 04:51:58PM +0200, Thomas Monjalon wrote:
> > > > +cd $(dirname $(readlink -m $0))/..
> > > > +
> > > I don't think we should force the builds to be always put into the base
> > > directory. Instead of using cd, I think we should instead capture the base
> > > directory path and pass that to meson.
> > 
> > OK to not force the directory.
> > You want to build in the current directory?
> > If yes, we can just remove this "cd" and no need to pass a base directory
> > to meson.
> 
> We would need to pass the base to meson, because otherwise meson assumes
> the top-level meson.build file is in the current directory, i.e. calling
> "meson build-dir" is the same as "meson . build-dir". If we want to allow
> using this script from other places on filesystem, we need to either "cd"
> to the base dir as you do now, or else explicitly pass in the basedir. The
> latter I think is a better option as it would allow building from any
> location on the filesystem.

I agree.

I don't understand the meson syntax:
meson [ options ] [ source directory ] [ build directory ]
If there is only one argument, it is the build directory?

I could send a v5 to add the source directory in the meson command.
It would be:
srcdir=$(dirname $(readlink -m $0))/..
$MESON $options $srcdir $builddir


> > > > +load_config ()
> > > > +{
> > > > +   reset_env
> > > > +   . $(dirname $(readlink -e $0))/load-devel-config
> > > > +   MESON=${MESON:-meson}
> > > > +}
> > > Why does this need to be done each time?
> > 
> > Because the config could be different for each build (see above).
> > 
> How would it be different, it's the same command called with the same
> environment each time?

No, the idea is to adapt the environment to the build target.
As an example, the dependencies can be different for 32-bit and 64-bit.

[dpdk-dev] [DPDK 18.08 v1 00/12] net/mlx5: flow rework

[Nelio Laranjeiro]

First version of for the flow engine rework of MLX5 to prepare the
introduction for the ENCAP/DECAP and PUSH/POP actions done via TC
flower/filter.

This first series depends on [1] and is a work in progress, recent work added
on Tunnel RSS are still absent as well as the tunnel support.  Those will be
added in further versions.

Expected for the next 18.08 release:

- same level of features,
- TC flow support for port redirection,
- TC filter support for ENCAP/DECAP and PUSH/POP.

[1] https://dpdk.org/dev/patchwork/patch/40462/

Nelio Laranjeiro (12):
  net/mlx5: remove flow support
  net/mlx5: handle drop queues are regular queues
  net/mlx5: support flow Ethernet item among with drop action
  net/mlx5: add flow queue action
  net/mlx5: add flow stop/start
  net/mlx5: add flow VLAN item
  net/mlx5: add flow IPv4 item
  net/mlx5: add flow IPv6 item
  net/mlx5: add flow UDP item
  net/mlx5: add flow TCP item
  net/mlx5: add mark/flag flow action
  net/mlx5: add RSS flow action

 drivers/net/mlx5/mlx5.c  |9 -
 drivers/net/mlx5/mlx5.h  |3 +-
 drivers/net/mlx5/mlx5_flow.c | 3615 +++---
 drivers/net/mlx5/mlx5_rxq.c  |  221 +++
 drivers/net/mlx5/mlx5_rxtx.h |6 +
 5 files changed, 1388 insertions(+), 2466 deletions(-)

-- 
2.17.0

[dpdk-dev] [DPDK 18.08 v1 04/12] net/mlx5: add flow queue action

[Nelio Laranjeiro]

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_flow.c | 83 +---
 1 file changed, 77 insertions(+), 6 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 85dc5edaf..3e16f67d6 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -53,6 +53,7 @@ extern const struct eth_dev_ops mlx5_dev_ops_isolate;
 
 /* Action fate on the packet. */
 #define MLX5_FLOW_FATE_DROP (1u << 0)
+#define MLX5_FLOW_FATE_QUEUE (1u << 1)
 
 /* Verbs flow priority per layer level. */
 #define MLX5_FLOW_PRIO_L4 0
@@ -83,7 +84,8 @@ struct mlx5_flow_verbs {
 struct rte_flow {
TAILQ_ENTRY(rte_flow) next; /**< Pointer to the next flow structure. */
struct rte_flow_attr attributes; /**< User flow attribute. */
-   struct mlx5_flow_verbs verbs; /* Verbs drop flow. */
+   struct mlx5_flow_verbs verbs; /* Verbs flow. */
+   uint16_t queue; /**< Destination queue to redirect traffic to. */
 };
 
 static const struct rte_flow_ops mlx5_flow_ops = {
@@ -150,6 +152,8 @@ mlx5_flow_print(struct rte_flow *flow __rte_unused)
flow->verbs.layers & MLX5_FLOW_LAYER_L4 ? "l4" : "-");
if (flow->verbs.fate & MLX5_FLOW_FATE_DROP)
fprintf(stdout, " fate: drop queue\n");
+   else if (flow->verbs.fate & MLX5_FLOW_FATE_QUEUE)
+   fprintf(stdout, " fate: target queue %u\n", flow->queue);
if (flow->verbs.attr) {
struct ibv_spec_header *hdr =
(struct ibv_spec_header *)flow->verbs.specs;
@@ -442,6 +446,48 @@ mlx5_flow_action_drop(const struct rte_flow_action 
*actions,
return 0;
 }
 
+/**
+ * Validate action queue provided by the user.
+ *
+ * @param dev
+ *   Pointer to Ethernet device structure.
+ * @param actions
+ *   Pointer to flow actions array.
+ * @param flow
+ *   Pointer to the rte_flow structure.
+ * @param error
+ *   Pointer to error structure.
+ */
+static int
+mlx5_flow_action_queue(struct rte_eth_dev *dev,
+  const struct rte_flow_action *actions,
+  struct rte_flow *flow,
+  struct rte_flow_error *error)
+{
+   struct priv *priv = dev->data->dev_private;
+   const struct rte_flow_action_queue *queue = actions->conf;
+
+   if (flow->verbs.fate)
+   return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ACTION,
+ actions,
+ "multiple fate actions are not"
+ " supported");
+   if (queue->index >= priv->rxqs_n)
+   return rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ACTION_CONF,
+ &queue->index,
+ "queue index out of range");
+   if (!(*priv->rxqs)[queue->index])
+   return rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ACTION_CONF,
+ &queue->index,
+ "queue is not configured");
+   flow->queue = queue->index;
+   flow->verbs.fate |= MLX5_FLOW_FATE_QUEUE;
+   return 0;
+}
+
 /**
  * Validate actions provided by the user.
  *
@@ -455,9 +501,9 @@ mlx5_flow_action_drop(const struct rte_flow_action *actions,
  *   Pointer to error structure.
  */
 static int
-mlx5_flow_actions(struct rte_eth_dev *dev __rte_unused,
+mlx5_flow_actions(struct rte_eth_dev *dev,
  const struct rte_flow_action actions[],
- struct rte_flow *flow __rte_unused,
+ struct rte_flow *flow,
  struct rte_flow_error *error)
 {
int ret;
@@ -469,6 +515,9 @@ mlx5_flow_actions(struct rte_eth_dev *dev __rte_unused,
case RTE_FLOW_ACTION_TYPE_DROP:
ret = mlx5_flow_action_drop(actions, flow, error);
break;
+   case RTE_FLOW_ACTION_TYPE_QUEUE:
+   ret = mlx5_flow_action_queue(dev, actions, flow, error);
+   break;
default:
return rte_flow_error_set(error, ENOTSUP,
  RTE_FLOW_ERROR_TYPE_ACTION,
@@ -581,7 +630,10 @@ mlx5_flow_fate_remove(struct rte_eth_dev *dev, struct 
rte_flow *flow)
}
}
if (flow->verbs.hrxq) {
-   mlx5_hrxq_drop_release(dev, flow->verbs.hrxq);
+   if (flow->verbs.fate & MLX5_FLOW_FATE_DROP)
+   mlx5_hrxq_drop_release(dev, flow->verbs.hrxq);
+   else if (flow->verbs.fate & MLX5_FLOW_FATE_QUEUE)
+   mlx5_hrxq_release(dev, flow->verbs.hrxq);
flow->verbs.hrxq = NULL;
}
 }
@@ -627,7 +679,7 @@ st

[dpdk-dev] [DPDK 18.08 v1 03/12] net/mlx5: support flow Ethernet item among with drop action

[Nelio Laranjeiro]

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_flow.c | 676 ---
 1 file changed, 634 insertions(+), 42 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 6497e99c1..85dc5edaf 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -35,11 +35,62 @@
 extern const struct eth_dev_ops mlx5_dev_ops;
 extern const struct eth_dev_ops mlx5_dev_ops_isolate;
 
+/* Pattern Layer bits. */
+#define MLX5_FLOW_LAYER_L2 (1u << 0)
+#define MLX5_FLOW_LAYER_L3_IPV4 (1u << 1)
+#define MLX5_FLOW_LAYER_L3_IPV6 (1u << 2)
+#define MLX5_FLOW_LAYER_L4_UDP (1u << 3)
+#define MLX5_FLOW_LAYER_L4_TCP (1u << 4)
+#define MLX5_FLOW_LAYER_VLAN (1u << 5)
+/* Masks. */
+#define MLX5_FLOW_LAYER_L3 \
+   (MLX5_FLOW_LAYER_L3_IPV4 | MLX5_FLOW_LAYER_L3_IPV6)
+#define MLX5_FLOW_LAYER_L4 \
+   (MLX5_FLOW_LAYER_L4_UDP | MLX5_FLOW_LAYER_L4_TCP)
+#define MLX5_FLOW_LAYER_OUTER \
+   (MLX5_FLOW_LAYER_L2 | MLX5_FLOW_LAYER_L3 | \
+MLX5_FLOW_LAYER_L4)
+
+/* Action fate on the packet. */
+#define MLX5_FLOW_FATE_DROP (1u << 0)
+
+/* Verbs flow priority per layer level. */
+#define MLX5_FLOW_PRIO_L4 0
+#define MLX5_FLOW_PRIO_L3 1
+#define MLX5_FLOW_PRIO_L2 2
+
+/* Control flow priority. */
+#define MLX5_FLOW_CTRL 0x
+#define MLX5_FLOW_CTRL_PRIO_OFFSET (MLX5_FLOW_PRIO_L2 + 1)
+
+/** Handles information leading to a drop fate. */
+struct mlx5_flow_verbs {
+   unsigned int size; /**< Size of the attribute. */
+   uint32_t layers;
+   /**< Bit-fields of present layers see MLX5_FLOW_ITEMS_*. */
+   uint32_t fate;
+   /**< Bit-fields of present fate see MLX5_FLOW_FATE_*. */
+   struct {
+   struct ibv_flow_attr *attr;
+   /**< Pointer to the Specification buffer. */
+   uint8_t *specs; /**< Pointer to the specifications. */
+   };
+   struct ibv_flow *flow; /**< Verbs flow pointer. */
+   struct mlx5_hrxq *hrxq; /**< Hash Rx queue object. */
+};
+
+/* Flow structure. */
 struct rte_flow {
TAILQ_ENTRY(rte_flow) next; /**< Pointer to the next flow structure. */
+   struct rte_flow_attr attributes; /**< User flow attribute. */
+   struct mlx5_flow_verbs verbs; /* Verbs drop flow. */
 };
 
 static const struct rte_flow_ops mlx5_flow_ops = {
+   .validate = mlx5_flow_validate,
+   .create = mlx5_flow_create,
+   .destroy = mlx5_flow_destroy,
+   .flush = mlx5_flow_flush,
.isolate = mlx5_flow_isolate,
 };
 
@@ -76,12 +127,374 @@ struct ibv_spec_header {
 };
 
 /**
- * Convert a flow.
+ * Flow debug purpose function only used when CONFIG_RTE_LIBRTE_MLX5_DEBUG=y
+ *
+ * @param flow
+ *   Pointer to the flow structure to display.
+ */
+void
+mlx5_flow_print(struct rte_flow *flow __rte_unused)
+{
+#ifndef NDEBUG
+   fprintf(stdout, "-8<\n");
+   fprintf(stdout, "%s: flow information\n", MLX5_DRIVER_NAME);
+   fprintf(stdout, " attributes: group %u priority %u ingress %d egress %d"
+   " transfer %d\n", flow->attributes.group,
+   flow->attributes.priority,
+   flow->attributes.ingress,
+   flow->attributes.egress,
+   flow->attributes.transfer);
+   fprintf(stdout, " layers: %s/%s/%s\n",
+   flow->verbs.layers & MLX5_FLOW_LAYER_L2 ? "l2" : "-",
+   flow->verbs.layers & MLX5_FLOW_LAYER_L3 ? "l3" : "-",
+   flow->verbs.layers & MLX5_FLOW_LAYER_L4 ? "l4" : "-");
+   if (flow->verbs.fate & MLX5_FLOW_FATE_DROP)
+   fprintf(stdout, " fate: drop queue\n");
+   if (flow->verbs.attr) {
+   struct ibv_spec_header *hdr =
+   (struct ibv_spec_header *)flow->verbs.specs;
+   const int n = flow->verbs.attr->num_of_specs;
+   int i;
+
+   fprintf(stdout, " Verbs attributes: priority %u specs_n %u\n",
+   flow->verbs.attr->priority,
+   flow->verbs.attr->num_of_specs);
+   for (i = 0; i != n; ++i) {
+   rte_hexdump(stdout, " ", hdr, hdr->size);
+   hdr = (struct ibv_spec_header *)
+   ((uint8_t *)hdr + hdr->size);
+   }
+   }
+   fprintf(stdout, "->8\n");
+#endif
+}
+
+/**
+ * Validate Attributes provided by the user.
+ *
+ * @param attr
+ *   Pointer to flow attributes
+ * @param flow
+ *   Pointer to the rte_flow structure.
+ * @param error
+ *   Pointer to error structure.
+ */
+static int
+mlx5_flow_attributes(const struct rte_flow_attr *attr,
+struct rte_flow *flow,
+struct rte_flow_error *error)
+{
+   if (attr->group)
+   return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ATTR_GROUP,
+ NULL,
+   

[dpdk-dev] [DPDK 18.08 v1 02/12] net/mlx5: handle drop queues are regular queues

[Nelio Laranjeiro]

Drop queues are essentially used in flows due to Verbs API, the
information if the fate of the flow is a drop or not is already present
in the flow.  Due to this, drop queues can be fully mapped on regular
queues.

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5.c  |   9 --
 drivers/net/mlx5/mlx5.h  |   3 +-
 drivers/net/mlx5/mlx5_flow.c |  26 -
 drivers/net/mlx5/mlx5_rxq.c  | 221 +++
 drivers/net/mlx5/mlx5_rxtx.h |   6 +
 5 files changed, 229 insertions(+), 36 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index f455ea8ea..8188a67e3 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -252,7 +252,6 @@ mlx5_dev_close(struct rte_eth_dev *dev)
priv->txqs_n = 0;
priv->txqs = NULL;
}
-   mlx5_flow_delete_drop_queue(dev);
mlx5_mprq_free_mp(dev);
mlx5_mr_release(dev);
if (priv->pd != NULL) {
@@ -1161,14 +1160,6 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv 
__rte_unused,
mlx5_link_update(eth_dev, 0);
/* Store device configuration on private structure. */
priv->config = config;
-   /* Create drop queue. */
-   err = mlx5_flow_create_drop_queue(eth_dev);
-   if (err) {
-   DRV_LOG(ERR, "port %u drop queue allocation failed: %s",
-   eth_dev->data->port_id, strerror(rte_errno));
-   err = rte_errno;
-   goto port_error;
-   }
/* Supported Verbs flow priority number detection. */
if (verb_priorities == 0)
verb_priorities = mlx5_get_max_verbs_prio(eth_dev);
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index c4c962b92..69f4f7eb6 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -169,7 +169,7 @@ struct priv {
struct rte_intr_handle intr_handle; /* Interrupt handler. */
unsigned int (*reta_idx)[]; /* RETA index table. */
unsigned int reta_idx_n; /* RETA index size. */
-   struct mlx5_hrxq_drop *flow_drop_queue; /* Flow drop queue. */
+   struct mlx5_hrxq *flow_drop_queue; /* Flow drop queue. */
struct mlx5_flows flows; /* RTE Flow rules. */
struct mlx5_flows ctrl_flows; /* Control flow rules. */
struct {
@@ -294,6 +294,7 @@ int mlx5_traffic_restart(struct rte_eth_dev *dev);
 
 /* mlx5_flow.c */
 
+void mlx5_flow_print(struct rte_flow *flow);
 unsigned int mlx5_get_max_verbs_prio(struct rte_eth_dev *dev);
 int mlx5_flow_validate(struct rte_eth_dev *dev,
   const struct rte_flow_attr *attr,
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index a45cb06e1..6497e99c1 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -184,32 +184,6 @@ mlx5_flow_list_flush(struct rte_eth_dev *dev, struct 
mlx5_flows *list)
}
 }
 
-/**
- * Create drop queue.
- *
- * @param dev
- *   Pointer to Ethernet device.
- *
- * @return
- *   0 on success, a negative errno value otherwise and rte_errno is set.
- */
-int
-mlx5_flow_create_drop_queue(struct rte_eth_dev *dev __rte_unused)
-{
-   return 0;
-}
-
-/**
- * Delete drop queue.
- *
- * @param dev
- *   Pointer to Ethernet device.
- */
-void
-mlx5_flow_delete_drop_queue(struct rte_eth_dev *dev __rte_unused)
-{
-}
-
 /**
  * Remove all flows.
  *
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 171ce9e30..7ac9bd000 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -1967,3 +1967,224 @@ mlx5_hrxq_ibv_verify(struct rte_eth_dev *dev)
}
return ret;
 }
+
+/**
+ * Create a drop Rx queue Verbs object.
+ *
+ * @param dev
+ *   Pointer to Ethernet device.
+ *
+ * @return
+ *   The Verbs object initialised, NULL otherwise and rte_errno is set.
+ */
+struct mlx5_rxq_ibv *
+mlx5_rxq_ibv_drop_new(struct rte_eth_dev *dev)
+{
+   struct priv *priv = dev->data->dev_private;
+   struct ibv_cq *cq;
+   struct ibv_wq *wq = NULL;
+   struct mlx5_rxq_ibv *rxq;
+
+   cq = mlx5_glue->create_cq(priv->ctx, 1, NULL, NULL, 0);
+   if (!cq) {
+   DEBUG("port %u cannot allocate CQ for drop queue",
+ dev->data->port_id);
+   rte_errno = errno;
+   goto error;
+   }
+   wq = mlx5_glue->create_wq(priv->ctx,
+&(struct ibv_wq_init_attr){
+   .wq_type = IBV_WQT_RQ,
+   .max_wr = 1,
+   .max_sge = 1,
+   .pd = priv->pd,
+   .cq = cq,
+});
+   if (!wq) {
+   DEBUG("port %u cannot allocate WQ for drop queue",
+ dev->data->port_id);
+   rte_errno = errno;
+   goto error;
+   }
+   rxq = rte_calloc(__fun

[dpdk-dev] [DPDK 18.08 v1 05/12] net/mlx5: add flow stop/start

[Nelio Laranjeiro]

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_flow.c | 24 
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 3e16f67d6..8c6309188 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -857,9 +857,12 @@ mlx5_flow_list_flush(struct rte_eth_dev *dev, struct 
mlx5_flows *list)
  *   Pointer to a TAILQ flow list.
  */
 void
-mlx5_flow_stop(struct rte_eth_dev *dev __rte_unused,
-  struct mlx5_flows *list __rte_unused)
+mlx5_flow_stop(struct rte_eth_dev *dev, struct mlx5_flows *list)
 {
+   struct rte_flow *flow;
+
+   TAILQ_FOREACH_REVERSE(flow, list, mlx5_flows, next)
+   mlx5_flow_fate_remove(dev, flow);
 }
 
 /**
@@ -874,10 +877,23 @@ mlx5_flow_stop(struct rte_eth_dev *dev __rte_unused,
  *   0 on success, a negative errno value otherwise and rte_errno is set.
  */
 int
-mlx5_flow_start(struct rte_eth_dev *dev __rte_unused,
-   struct mlx5_flows *list __rte_unused)
+mlx5_flow_start(struct rte_eth_dev *dev, struct mlx5_flows *list)
 {
+   struct rte_flow *flow;
+   struct rte_flow_error error;
+   int ret = 0;
+
+   TAILQ_FOREACH(flow, list, next) {
+   ret = mlx5_flow_fate_apply(dev, flow, &error);
+   if (ret < 0)
+   goto error;
+   }
return 0;
+error:
+   ret = rte_errno; /* Save rte_errno before cleanup. */
+   mlx5_flow_stop(dev, list);
+   rte_errno = ret; /* Restore rte_errno. */
+   return -rte_errno;
 }
 
 /**
-- 
2.17.0

[dpdk-dev] [DPDK 18.08 v1 01/12] net/mlx5: remove flow support

[Nelio Laranjeiro]

This start a series to re-work the flow engine in mlx5 to easily support
flow conversion to Verbs or TC.  This is necessary to handle both regular
flows and representors flows.

As the full file needs to be clean-up to re-write all items/actions
processing, this patch starts to disable the regular code and only let the
PMD to start in isolated mode.

After this patch flow API will not be usable.

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_flow.c | 2958 +-
 1 file changed, 80 insertions(+), 2878 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index ec6d00f21..a45cb06e1 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -31,2274 +31,49 @@
 #include "mlx5_prm.h"
 #include "mlx5_glue.h"
 
-/* Flow priority for control plane flows. */
-#define MLX5_CTRL_FLOW_PRIORITY 1
-
-/* Internet Protocol versions. */
-#define MLX5_IPV4 4
-#define MLX5_IPV6 6
-#define MLX5_GRE 47
-
-#ifndef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
-struct ibv_flow_spec_counter_action {
-   int dummy;
-};
-#endif
-
-/* Dev ops structure defined in mlx5.c */
-extern const struct eth_dev_ops mlx5_dev_ops;
-extern const struct eth_dev_ops mlx5_dev_ops_isolate;
-
-/** Structure give to the conversion functions. */
-struct mlx5_flow_data {
-   struct rte_eth_dev *dev; /** Ethernet device. */
-   struct mlx5_flow_parse *parser; /** Parser context. */
-   struct rte_flow_error *error; /** Error context. */
-};
-
-static int
-mlx5_flow_create_eth(const struct rte_flow_item *item,
-const void *default_mask,
-struct mlx5_flow_data *data);
-
-static int
-mlx5_flow_create_vlan(const struct rte_flow_item *item,
- const void *default_mask,
- struct mlx5_flow_data *data);
-
-static int
-mlx5_flow_create_ipv4(const struct rte_flow_item *item,
- const void *default_mask,
- struct mlx5_flow_data *data);
-
-static int
-mlx5_flow_create_ipv6(const struct rte_flow_item *item,
- const void *default_mask,
- struct mlx5_flow_data *data);
-
-static int
-mlx5_flow_create_udp(const struct rte_flow_item *item,
-const void *default_mask,
-struct mlx5_flow_data *data);
-
-static int
-mlx5_flow_create_tcp(const struct rte_flow_item *item,
-const void *default_mask,
-struct mlx5_flow_data *data);
-
-static int
-mlx5_flow_create_vxlan(const struct rte_flow_item *item,
-  const void *default_mask,
-  struct mlx5_flow_data *data);
-
-static int
-mlx5_flow_create_vxlan_gpe(const struct rte_flow_item *item,
-  const void *default_mask,
-  struct mlx5_flow_data *data);
-
-static int
-mlx5_flow_create_gre(const struct rte_flow_item *item,
-const void *default_mask,
-struct mlx5_flow_data *data);
-
-struct mlx5_flow_parse;
-
-static void
-mlx5_flow_create_copy(struct mlx5_flow_parse *parser, void *src,
- unsigned int size);
-
-static int
-mlx5_flow_create_flag_mark(struct mlx5_flow_parse *parser, uint32_t mark_id);
-
-static int
-mlx5_flow_create_count(struct rte_eth_dev *dev, struct mlx5_flow_parse 
*parser);
-
-/* Hash RX queue types. */
-enum hash_rxq_type {
-   HASH_RXQ_TCPV4,
-   HASH_RXQ_UDPV4,
-   HASH_RXQ_IPV4,
-   HASH_RXQ_TCPV6,
-   HASH_RXQ_UDPV6,
-   HASH_RXQ_IPV6,
-   HASH_RXQ_ETH,
-   HASH_RXQ_TUNNEL,
-};
-
-/* Initialization data for hash RX queue. */
-struct hash_rxq_init {
-   uint64_t hash_fields; /* Fields that participate in the hash. */
-   uint64_t dpdk_rss_hf; /* Matching DPDK RSS hash fields. */
-   unsigned int flow_priority; /* Flow priority to use. */
-   unsigned int ip_version; /* Internet protocol. */
-};
-
-/* Initialization data for hash RX queues. */
-const struct hash_rxq_init hash_rxq_init[] = {
-   [HASH_RXQ_TCPV4] = {
-   .hash_fields = (IBV_RX_HASH_SRC_IPV4 |
-   IBV_RX_HASH_DST_IPV4 |
-   IBV_RX_HASH_SRC_PORT_TCP |
-   IBV_RX_HASH_DST_PORT_TCP),
-   .dpdk_rss_hf = ETH_RSS_NONFRAG_IPV4_TCP,
-   .flow_priority = 0,
-   .ip_version = MLX5_IPV4,
-   },
-   [HASH_RXQ_UDPV4] = {
-   .hash_fields = (IBV_RX_HASH_SRC_IPV4 |
-   IBV_RX_HASH_DST_IPV4 |
-   IBV_RX_HASH_SRC_PORT_UDP |
-   IBV_RX_HASH_DST_PORT_UDP),
-   .dpdk_rss_hf = ETH_RSS_NONFRAG_IPV4_UDP,
-   .flow_priority = 0,
-   .ip_version = MLX5_IPV4,
-   },
-   [HASH_RXQ_IPV4] = {
-   .hash_fields = (IBV_RX_HASH_SRC_IPV4 |
-  

[dpdk-dev] [DPDK 18.08 v1 07/12] net/mlx5: add flow IPv4 item

[Nelio Laranjeiro]

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_flow.c | 78 
 1 file changed, 78 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index ed27914aa..003c4aadd 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -479,6 +479,81 @@ mlx5_flow_item_vlan(const struct rte_flow_item *item, 
struct rte_flow *flow,
return 0;
 }
 
+/**
+ * Validate IPv4 layer and possibly create the Verbs specification.
+ *
+ * @param item[in]
+ *   Item specification.
+ * @param flow[in, out]
+ *   Pointer to flow structure.
+ * @param error
+ *   Pointer to error structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+static int
+mlx5_flow_item_ipv4(const struct rte_flow_item *item, struct rte_flow *flow,
+   struct rte_flow_error *error)
+{
+   const struct rte_flow_item_ipv4 *spec = item->spec;
+   const struct rte_flow_item_ipv4 *mask = item->mask;
+   const struct rte_flow_item_ipv4 nic_mask = {
+   .hdr = {
+   .src_addr = RTE_BE32(0x),
+   .dst_addr = RTE_BE32(0x),
+   .type_of_service = 0xff,
+   .next_proto_id = 0xff,
+   },
+   };
+   unsigned int size = sizeof(struct ibv_flow_spec_ipv4_ext);
+   struct ibv_flow_spec_ipv4_ext ipv4 = {
+   .type = IBV_FLOW_SPEC_IPV4_EXT,
+   .size = size,
+   };
+   int ret;
+
+   if (flow->verbs.layers & MLX5_FLOW_LAYER_L3)
+   return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ITEM,
+ item,
+ "multiple L3 layers not supported");
+   else if (flow->verbs.layers & MLX5_FLOW_LAYER_L4)
+   return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ITEM,
+ item,
+ "L3 cannot follow an L4 layer.");
+   if (!mask)
+   mask = &rte_flow_item_ipv4_mask;
+   ret = mlx5_flow_item_validate(item, (const uint8_t *)mask,
+ (const uint8_t *)&nic_mask,
+ sizeof(struct rte_flow_item_ipv4), error);
+   if (ret < 0)
+   return ret;
+   if (spec) {
+   ipv4.val = (struct ibv_flow_ipv4_ext_filter){
+   .src_ip = spec->hdr.src_addr,
+   .dst_ip = spec->hdr.dst_addr,
+   .proto = spec->hdr.next_proto_id,
+   .tos = spec->hdr.type_of_service,
+   };
+   ipv4.mask = (struct ibv_flow_ipv4_ext_filter){
+   .src_ip = mask->hdr.src_addr,
+   .dst_ip = mask->hdr.dst_addr,
+   .proto = mask->hdr.next_proto_id,
+   .tos = mask->hdr.type_of_service,
+   };
+   /* Remove unwanted bits from values. */
+   ipv4.val.src_ip &= ipv4.mask.src_ip;
+   ipv4.val.dst_ip &= ipv4.mask.dst_ip;
+   ipv4.val.proto &= ipv4.mask.proto;
+   ipv4.val.tos &= ipv4.mask.tos;
+   }
+   mlx5_flow_spec_verbs_add(flow, &ipv4, size);
+   flow->verbs.layers |= MLX5_FLOW_LAYER_L3_IPV4;
+   return 0;
+}
+
 /**
  * Validate items provided by the user.
  *
@@ -509,6 +584,9 @@ mlx5_flow_items(const struct rte_flow_item items[],
case RTE_FLOW_ITEM_TYPE_VLAN:
ret = mlx5_flow_item_vlan(items, flow, error);
break;
+   case RTE_FLOW_ITEM_TYPE_IPV4:
+   ret = mlx5_flow_item_ipv4(items, flow, error);
+   break;
default:
return rte_flow_error_set(error, ENOTSUP,
  RTE_FLOW_ERROR_TYPE_ITEM,
-- 
2.17.0

[dpdk-dev] [DPDK 18.08 v1 09/12] net/mlx5: add flow UDP item

[Nelio Laranjeiro]

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_flow.c | 55 
 1 file changed, 55 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 6f3e50452..66ebe6d36 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -654,6 +654,58 @@ mlx5_flow_item_ipv6(const struct rte_flow_item *item, 
struct rte_flow *flow,
return 0;
 }
 
+/**
+ * Validate UDP layer and possibly create the Verbs specification.
+ *
+ * @param item[in]
+ *   Item specification.
+ * @param flow[in, out]
+ *   Pointer to flow structure.
+ * @param error
+ *   Pointer to error structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+static int
+mlx5_flow_item_udp(const struct rte_flow_item *item, struct rte_flow *flow,
+  struct rte_flow_error *error)
+{
+   const struct rte_flow_item_udp *spec = item->spec;
+   const struct rte_flow_item_udp *mask = item->mask;
+   unsigned int size = sizeof(struct ibv_flow_spec_tcp_udp);
+   struct ibv_flow_spec_tcp_udp udp = {
+   .type = IBV_FLOW_SPEC_UDP,
+   .size = size,
+   };
+   int ret;
+
+   if (flow->verbs.layers & MLX5_FLOW_LAYER_L4)
+   return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ITEM,
+ item,
+ "L4 layer is already present");
+   if (!mask)
+   mask = &rte_flow_item_udp_mask;
+   ret = mlx5_flow_item_validate(item, (const uint8_t *)mask,
+ (const uint8_t *)&rte_flow_item_udp_mask,
+ sizeof(struct rte_flow_item_udp), error);
+   if (ret < 0)
+   return ret;
+   if (spec) {
+   udp.val.dst_port = spec->hdr.dst_port;
+   udp.val.src_port = spec->hdr.src_port;
+   udp.mask.dst_port = mask->hdr.dst_port;
+   udp.mask.src_port = mask->hdr.src_port;
+   /* Remove unwanted bits from values. */
+   udp.val.src_port &= udp.mask.src_port;
+   udp.val.dst_port &= udp.mask.dst_port;
+   }
+   mlx5_flow_spec_verbs_add(flow, &udp, size);
+   flow->verbs.layers |= MLX5_FLOW_LAYER_L4_UDP;
+   return 0;
+}
+
 /**
  * Validate items provided by the user.
  *
@@ -690,6 +742,9 @@ mlx5_flow_items(const struct rte_flow_item items[],
case RTE_FLOW_ITEM_TYPE_IPV6:
ret = mlx5_flow_item_ipv6(items, flow, error);
break;
+   case RTE_FLOW_ITEM_TYPE_UDP:
+   ret = mlx5_flow_item_udp(items, flow, error);
+   break;
default:
return rte_flow_error_set(error, ENOTSUP,
  RTE_FLOW_ERROR_TYPE_ITEM,
-- 
2.17.0

[dpdk-dev] [DPDK 18.08 v1 10/12] net/mlx5: add flow TCP item

[Nelio Laranjeiro]

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_flow.c | 55 
 1 file changed, 55 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 66ebe6d36..ce1b4e94b 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -706,6 +706,58 @@ mlx5_flow_item_udp(const struct rte_flow_item *item, 
struct rte_flow *flow,
return 0;
 }
 
+/**
+ * Validate TCP layer and possibly create the Verbs specification.
+ *
+ * @param item[in]
+ *   Item specification.
+ * @param flow[in, out]
+ *   Pointer to flow structure.
+ * @param error
+ *   Pointer to error structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+static int
+mlx5_flow_item_tcp(const struct rte_flow_item *item, struct rte_flow *flow,
+  struct rte_flow_error *error)
+{
+   const struct rte_flow_item_tcp *spec = item->spec;
+   const struct rte_flow_item_tcp *mask = item->mask;
+   unsigned int size = sizeof(struct ibv_flow_spec_tcp_udp);
+   struct ibv_flow_spec_tcp_udp tcp = {
+   .type = IBV_FLOW_SPEC_TCP,
+   .size = size,
+   };
+   int ret;
+
+   if (flow->verbs.layers & MLX5_FLOW_LAYER_L4)
+   return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ITEM,
+ item,
+ "L4 layer is already present");
+   if (!mask)
+   mask = &rte_flow_item_tcp_mask;
+   ret = mlx5_flow_item_validate(item, (const uint8_t *)mask,
+ (const uint8_t *)&rte_flow_item_tcp_mask,
+ sizeof(struct rte_flow_item_tcp), error);
+   if (ret < 0)
+   return ret;
+   if (spec) {
+   tcp.val.dst_port = spec->hdr.dst_port;
+   tcp.val.src_port = spec->hdr.src_port;
+   tcp.mask.dst_port = mask->hdr.dst_port;
+   tcp.mask.src_port = mask->hdr.src_port;
+   /* Remove unwanted bits from values. */
+   tcp.val.src_port &= tcp.mask.src_port;
+   tcp.val.dst_port &= tcp.mask.dst_port;
+   }
+   mlx5_flow_spec_verbs_add(flow, &tcp, size);
+   flow->verbs.layers |= MLX5_FLOW_LAYER_L4_TCP;
+   return 0;
+}
+
 /**
  * Validate items provided by the user.
  *
@@ -745,6 +797,9 @@ mlx5_flow_items(const struct rte_flow_item items[],
case RTE_FLOW_ITEM_TYPE_UDP:
ret = mlx5_flow_item_udp(items, flow, error);
break;
+   case RTE_FLOW_ITEM_TYPE_TCP:
+   ret = mlx5_flow_item_tcp(items, flow, error);
+   break;
default:
return rte_flow_error_set(error, ENOTSUP,
  RTE_FLOW_ERROR_TYPE_ITEM,
-- 
2.17.0

[dpdk-dev] [DPDK 18.08 v1 08/12] net/mlx5: add flow IPv6 item

[Nelio Laranjeiro]

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_flow.c | 103 +++
 1 file changed, 103 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 003c4aadd..6f3e50452 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -554,6 +554,106 @@ mlx5_flow_item_ipv4(const struct rte_flow_item *item, 
struct rte_flow *flow,
return 0;
 }
 
+/**
+ * Validate IPv6 layer and possibly create the Verbs specification.
+ *
+ * @param item[in]
+ *   Item specification.
+ * @param flow[in, out]
+ *   Pointer to flow structure.
+ * @param error
+ *   Pointer to error structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+static int
+mlx5_flow_item_ipv6(const struct rte_flow_item *item, struct rte_flow *flow,
+   struct rte_flow_error *error)
+{
+   const struct rte_flow_item_ipv6 *spec = item->spec;
+   const struct rte_flow_item_ipv6 *mask = item->mask;
+   const struct rte_flow_item_ipv6 nic_mask = {
+   .hdr = {
+   .src_addr =
+   "\xff\xff\xff\xff\xff\xff\xff\xff"
+   "\xff\xff\xff\xff\xff\xff\xff\xff",
+   .dst_addr =
+   "\xff\xff\xff\xff\xff\xff\xff\xff"
+   "\xff\xff\xff\xff\xff\xff\xff\xff",
+   .vtc_flow = RTE_BE32(0x),
+   .proto = 0xff,
+   .hop_limits = 0xff,
+   },
+   };
+   unsigned int size = sizeof(struct ibv_flow_spec_ipv6);
+   struct ibv_flow_spec_ipv6 ipv6 = {
+   .type = IBV_FLOW_SPEC_IPV6,
+   .size = size,
+   };
+   int ret;
+
+   if (flow->verbs.layers & MLX5_FLOW_LAYER_L3)
+   return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ITEM,
+ item,
+ "multiple L3 layers not supported");
+   else if (flow->verbs.layers & MLX5_FLOW_LAYER_L4)
+   return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ITEM,
+ item,
+ "L3 cannot follow an L4 layer.");
+   if (!mask)
+   mask = &rte_flow_item_ipv6_mask;
+   ret = mlx5_flow_item_validate(item, (const uint8_t *)mask,
+ (const uint8_t *)&nic_mask,
+ sizeof(struct rte_flow_item_ipv6), error);
+   if (ret < 0)
+   return ret;
+   if (spec) {
+   unsigned int i;
+   uint32_t vtc_flow_val;
+   uint32_t vtc_flow_mask;
+
+   memcpy(&ipv6.val.src_ip, spec->hdr.src_addr,
+  RTE_DIM(ipv6.val.src_ip));
+   memcpy(&ipv6.val.dst_ip, spec->hdr.dst_addr,
+  RTE_DIM(ipv6.val.dst_ip));
+   memcpy(&ipv6.mask.src_ip, mask->hdr.src_addr,
+  RTE_DIM(ipv6.mask.src_ip));
+   memcpy(&ipv6.mask.dst_ip, mask->hdr.dst_addr,
+  RTE_DIM(ipv6.mask.dst_ip));
+   vtc_flow_val = rte_be_to_cpu_32(spec->hdr.vtc_flow);
+   vtc_flow_mask = rte_be_to_cpu_32(mask->hdr.vtc_flow);
+   ipv6.val.flow_label =
+   rte_cpu_to_be_32((vtc_flow_val & IPV6_HDR_FL_MASK) >>
+IPV6_HDR_FL_SHIFT);
+   ipv6.val.traffic_class = (vtc_flow_val & IPV6_HDR_TC_MASK) >>
+IPV6_HDR_TC_SHIFT;
+   ipv6.val.next_hdr = spec->hdr.proto;
+   ipv6.val.hop_limit = spec->hdr.hop_limits;
+   ipv6.mask.flow_label =
+   rte_cpu_to_be_32((vtc_flow_mask & IPV6_HDR_FL_MASK) >>
+IPV6_HDR_FL_SHIFT);
+   ipv6.mask.traffic_class = (vtc_flow_mask & IPV6_HDR_TC_MASK) >>
+ IPV6_HDR_TC_SHIFT;
+   ipv6.mask.next_hdr = mask->hdr.proto;
+   ipv6.mask.hop_limit = mask->hdr.hop_limits;
+   /* Remove unwanted bits from values. */
+   for (i = 0; i < RTE_DIM(ipv6.val.src_ip); ++i) {
+   ipv6.val.src_ip[i] &= ipv6.mask.src_ip[i];
+   ipv6.val.dst_ip[i] &= ipv6.mask.dst_ip[i];
+   }
+   ipv6.val.flow_label &= ipv6.mask.flow_label;
+   ipv6.val.traffic_class &= ipv6.mask.traffic_class;
+   ipv6.val.next_hdr &= ipv6.mask.next_hdr;
+   ipv6.val.hop_limit &= ipv6.mask.hop_limit;
+   }
+   mlx5_flow_spec_verbs_add(flow, &ipv6, size);
+   flow->verbs.layers |= MLX5_FLOW_LAYER_L3_IPV6;

[dpdk-dev] [DPDK 18.08 v1 06/12] net/mlx5: add flow VLAN item

[Nelio Laranjeiro]

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_flow.c | 114 +++
 1 file changed, 114 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 8c6309188..ed27914aa 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -368,6 +368,117 @@ mlx5_flow_item_eth(const struct rte_flow_item *item, 
struct rte_flow *flow,
return 0;
 }
 
+/**
+ * Update the VLAN tag in the Ethernet spec.
+ *
+ * @param attr[in, out]
+ *   Pointer to Verbs attributes structure.
+ * @param eth[in]
+ *   Verbs structure containing the VLAN information to copy.
+ */
+static void
+mlx5_flow_item_vlan_update(struct ibv_flow_attr *attr,
+  struct ibv_flow_spec_eth *eth)
+{
+   unsigned int i;
+   enum ibv_flow_spec_type search = IBV_FLOW_SPEC_ETH;
+   struct ibv_spec_header *hdr = (struct ibv_spec_header *)
+   ((uint8_t *)attr + sizeof(struct ibv_flow_attr));
+
+   for (i = 0; i != attr->num_of_specs; ++i) {
+   if (hdr->type == search) {
+   struct ibv_flow_spec_eth *e =
+   (struct ibv_flow_spec_eth *)hdr;
+
+   e->val.vlan_tag = eth->val.vlan_tag;
+   e->mask.vlan_tag = eth->mask.vlan_tag;
+   break;
+   }
+   hdr = (struct ibv_spec_header *)((uint8_t *)hdr + hdr->size);
+   }
+}
+
+/**
+ * Validate VLAN layer and possibly create/modify the Verbs specification.
+ *
+ * @param item[in]
+ *   Item specification.
+ * @param flow[in, out]
+ *   Pointer to flow structure.
+ * @param error
+ *   Pointer to error structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+static int
+mlx5_flow_item_vlan(const struct rte_flow_item *item, struct rte_flow *flow,
+   struct rte_flow_error *error)
+{
+   const struct rte_flow_item_vlan *spec = item->spec;
+   const struct rte_flow_item_vlan *mask = item->mask;
+   const struct rte_flow_item_vlan nic_mask = {
+   .tci = RTE_BE16(0x0fff),
+   };
+   const unsigned int size = sizeof(struct ibv_flow_spec_eth);
+   struct ibv_flow_spec_eth eth = {
+   .type = IBV_FLOW_SPEC_ETH,
+   .size = size,
+   };
+   int ret;
+   const uint32_t lm = (MLX5_FLOW_LAYER_L3 | MLX5_FLOW_LAYER_L4);
+   const uint32_t vlanm = MLX5_FLOW_LAYER_VLAN;
+   const uint32_t l2m = MLX5_FLOW_LAYER_L2;
+
+   if (flow->verbs.layers & vlanm)
+   return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ITEM,
+ item,
+ "L2 layers already configured");
+   else if ((flow->verbs.layers & lm) != 0)
+   return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ITEM,
+ item,
+ "L2 layer cannot follow L3/L4 layer");
+   if (!mask)
+   mask = &rte_flow_item_vlan_mask;
+   ret = mlx5_flow_item_validate(item, (const uint8_t *)mask,
+ (const uint8_t *)&nic_mask,
+ sizeof(struct rte_flow_item_vlan), error);
+   if (ret)
+   return ret;
+   if (spec) {
+   eth.val.vlan_tag = spec->tci;
+   eth.mask.vlan_tag = mask->tci;
+   eth.val.vlan_tag &= eth.mask.vlan_tag;
+   eth.val.ether_type = spec->inner_type;
+   eth.mask.ether_type = mask->inner_type;
+   eth.val.ether_type &= eth.mask.ether_type;
+   }
+   /*
+* From verbs perspective an empty VLAN is equivalent
+* to a packet without VLAN layer.
+*/
+   if (!eth.mask.vlan_tag)
+   return rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ITEM_SPEC,
+ item->spec,
+ "VLAN cannot be empty");
+   /* Outer TPID cannot be matched. */
+   if (eth.mask.ether_type)
+   return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ITEM_SPEC,
+ item->spec,
+ "VLAN TPID matching is not"
+ " supported");
+   if (!(flow->verbs.layers & l2m))
+   mlx5_flow_spec_verbs_add(flow, ð, size);
+   else
+   mlx5_flow_item_vlan_update(flow->verbs.attr, ð);
+   flow->verbs.layers |= MLX5_FLOW_LAYER_L2 | MLX5_FLOW_LAYER_VLAN;
+   return 0;
+}
+
 /**
  * Validate items provided by the user.
  *
@@ -395,6 +506,9 @@ mlx5_flow_items

[dpdk-dev] [DPDK 18.08 v1 11/12] net/mlx5: add mark/flag flow action

[Nelio Laranjeiro]

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_flow.c | 156 +++
 1 file changed, 156 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index ce1b4e94b..4ef0a3fee 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -55,6 +55,10 @@ extern const struct eth_dev_ops mlx5_dev_ops_isolate;
 #define MLX5_FLOW_FATE_DROP (1u << 0)
 #define MLX5_FLOW_FATE_QUEUE (1u << 1)
 
+/* Modify a packet. */
+#define MLX5_FLOW_MOD_FLAG (1u << 0)
+#define MLX5_FLOW_MOD_MARK (1u << 1)
+
 /* Verbs flow priority per layer level. */
 #define MLX5_FLOW_PRIO_L4 0
 #define MLX5_FLOW_PRIO_L3 1
@@ -69,6 +73,8 @@ struct mlx5_flow_verbs {
unsigned int size; /**< Size of the attribute. */
uint32_t layers;
/**< Bit-fields of present layers see MLX5_FLOW_ITEMS_*. */
+   uint32_t modifier;
+   /**< Bit-fields of present modifier see MLX5_FLOW_MOD_*. */
uint32_t fate;
/**< Bit-fields of present fate see MLX5_FLOW_FATE_*. */
struct {
@@ -893,6 +899,107 @@ mlx5_flow_action_queue(struct rte_eth_dev *dev,
return 0;
 }
 
+/**
+ * Validate action flag provided by the user.
+ *
+ * @param flow
+ *   Pointer to the rte_flow structure.
+ * @param error
+ *   Pointer to error structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+static int
+mlx5_flow_action_flag(struct rte_flow *flow)
+{
+   unsigned int size = sizeof(struct ibv_flow_spec_action_tag);
+   struct ibv_flow_spec_action_tag tag = {
+   .type = IBV_FLOW_SPEC_ACTION_TAG,
+   .size = size,
+   .tag_id = mlx5_flow_mark_set(MLX5_FLOW_MARK_DEFAULT),
+   };
+
+   if (flow->verbs.modifier & MLX5_FLOW_MOD_MARK)
+   return 0;
+   mlx5_flow_spec_verbs_add(flow, &tag, size);
+   flow->verbs.modifier |= MLX5_FLOW_MOD_FLAG;
+   return 0;
+}
+
+/**
+ * Update verbs specification to modify the flag to mark.
+ *
+ * @param flow
+ *   Pointer to the rte_flow structure.
+ * @param mark_id
+ *   Mark identifier to replace the flag.
+ */
+static void
+mlx5_flow_action_mark_fate_queue(struct rte_flow *flow, uint32_t mark_id)
+{
+   int i;
+
+   /* Update Verbs specification. */
+   for (i = 0; i != flow->verbs.attr->num_of_specs; ++i) {
+   struct ibv_spec_header *hdr =
+   (struct ibv_spec_header *)flow->verbs.attr;
+
+   if (hdr->type == IBV_FLOW_SPEC_ACTION_TAG) {
+   struct ibv_flow_spec_action_tag *t =
+   (struct ibv_flow_spec_action_tag *)hdr;
+
+   t->tag_id = mlx5_flow_mark_set(mark_id);
+   }
+   }
+}
+
+/**
+ * Validate action mark provided by the user.
+ *
+ * @param actions
+ *   Pointer to flow actions array.
+ * @param flow
+ *   Pointer to the rte_flow structure.
+ * @param error
+ *   Pointer to error structure.
+ *
+ * @return
+ *   0 on success, a negative errno value otherwise and rte_errno is set.
+ */
+static int
+mlx5_flow_action_mark(const struct rte_flow_action *actions,
+ struct rte_flow *flow,
+ struct rte_flow_error *error)
+{
+   const struct rte_flow_action_mark *mark = actions->conf;
+   unsigned int size = sizeof(struct ibv_flow_spec_action_tag);
+   struct ibv_flow_spec_action_tag tag = {
+   .type = IBV_FLOW_SPEC_ACTION_TAG,
+   .size = size,
+   };
+
+   if (!mark)
+   return rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ACTION,
+ actions,
+ "configuration cannot be null");
+   if (mark->id >= MLX5_FLOW_MARK_MAX)
+   return rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ACTION_CONF,
+ &mark->id,
+ "mark must be between 0 and"
+ " 16777199");
+   if (flow->verbs.modifier & MLX5_FLOW_MOD_FLAG) {
+   mlx5_flow_action_mark_fate_queue(flow, mark->id);
+   } else {
+   tag.tag_id = mlx5_flow_mark_set(mark->id);
+   mlx5_flow_spec_verbs_add(flow, &tag, size);
+   }
+   flow->verbs.modifier |= MLX5_FLOW_MOD_MARK;
+   return 0;
+}
+
 /**
  * Validate actions provided by the user.
  *
@@ -917,6 +1024,18 @@ mlx5_flow_actions(struct rte_eth_dev *dev,
switch (actions->type) {
case RTE_FLOW_ACTION_TYPE_VOID:
break;
+   case RTE_FLOW_ACTION_TYPE_FLAG:
+   if (flow->verbs.modifier & MLX5_FLOW_MOD_MARK)
+   return rte_flow_error_set
+   (error, ENOTSUP,

[dpdk-dev] [DPDK 18.08 v1 12/12] net/mlx5: add RSS flow action

[Nelio Laranjeiro]

Signed-off-by: Nelio Laranjeiro 
---
 drivers/net/mlx5/mlx5_flow.c | 681 +--
 1 file changed, 484 insertions(+), 197 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 4ef0a3fee..27354615f 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -54,6 +54,7 @@ extern const struct eth_dev_ops mlx5_dev_ops_isolate;
 /* Action fate on the packet. */
 #define MLX5_FLOW_FATE_DROP (1u << 0)
 #define MLX5_FLOW_FATE_QUEUE (1u << 1)
+#define MLX5_FLOW_FATE_RSS (1u << 2)
 
 /* Modify a packet. */
 #define MLX5_FLOW_MOD_FLAG (1u << 0)
@@ -68,15 +69,40 @@ extern const struct eth_dev_ops mlx5_dev_ops_isolate;
 #define MLX5_FLOW_CTRL 0x
 #define MLX5_FLOW_CTRL_PRIO_OFFSET (MLX5_FLOW_PRIO_L2 + 1)
 
+#define MLX5_RSS_EXP_SUPP(...) \
+   ((const enum rte_flow_item_type []) \
+{ __VA_ARGS__, RTE_FLOW_ITEM_TYPE_END })
+
+/** Supported expansion of items. */
+static const enum rte_flow_item_type *mlx5_supported_expansion[] = {
+   MLX5_RSS_EXP_SUPP(RTE_FLOW_ITEM_TYPE_ETH),
+   MLX5_RSS_EXP_SUPP(RTE_FLOW_ITEM_TYPE_ETH, RTE_FLOW_ITEM_TYPE_IPV4),
+   MLX5_RSS_EXP_SUPP(RTE_FLOW_ITEM_TYPE_ETH,
+ RTE_FLOW_ITEM_TYPE_IPV4,
+ RTE_FLOW_ITEM_TYPE_UDP),
+   MLX5_RSS_EXP_SUPP(RTE_FLOW_ITEM_TYPE_ETH,
+ RTE_FLOW_ITEM_TYPE_IPV4,
+ RTE_FLOW_ITEM_TYPE_TCP),
+   MLX5_RSS_EXP_SUPP(RTE_FLOW_ITEM_TYPE_ETH, RTE_FLOW_ITEM_TYPE_IPV6),
+   MLX5_RSS_EXP_SUPP(RTE_FLOW_ITEM_TYPE_ETH,
+ RTE_FLOW_ITEM_TYPE_IPV6,
+ RTE_FLOW_ITEM_TYPE_UDP),
+   MLX5_RSS_EXP_SUPP(RTE_FLOW_ITEM_TYPE_ETH,
+ RTE_FLOW_ITEM_TYPE_IPV6,
+ RTE_FLOW_ITEM_TYPE_TCP),
+};
+
 /** Handles information leading to a drop fate. */
 struct mlx5_flow_verbs {
-   unsigned int size; /**< Size of the attribute. */
+   LIST_ENTRY(mlx5_flow_verbs) next;
+   /**< Pointer to the next Verbs flow structure. */
uint32_t layers;
/**< Bit-fields of present layers see MLX5_FLOW_ITEMS_*. */
uint32_t modifier;
/**< Bit-fields of present modifier see MLX5_FLOW_MOD_*. */
uint32_t fate;
/**< Bit-fields of present fate see MLX5_FLOW_FATE_*. */
+   unsigned int size; /**< Size of the attribute. */
struct {
struct ibv_flow_attr *attr;
/**< Pointer to the Specification buffer. */
@@ -84,14 +110,19 @@ struct mlx5_flow_verbs {
};
struct ibv_flow *flow; /**< Verbs flow pointer. */
struct mlx5_hrxq *hrxq; /**< Hash Rx queue object. */
+   uint64_t hash_fields; /**< Verbs hash Rx queue hash fields. */
 };
 
 /* Flow structure. */
 struct rte_flow {
TAILQ_ENTRY(rte_flow) next; /**< Pointer to the next flow structure. */
struct rte_flow_attr attributes; /**< User flow attribute. */
-   struct mlx5_flow_verbs verbs; /* Verbs flow. */
-   uint16_t queue; /**< Destination queue to redirect traffic to. */
+   LIST_HEAD(verbs, mlx5_flow_verbs) verbs; /**< Verbs flows list. */
+   struct mlx5_flow_verbs *cur_verbs;
+   /**< Current Verbs flow structure being filled. */
+   struct rte_flow_action_rss rss;/**< RSS context. */
+   uint8_t key[40]; /**< RSS hash key. */
+   uint16_t (*queue)[]; /**< Destination queues to redirect traffic to. */
 };
 
 static const struct rte_flow_ops mlx5_flow_ops = {
@@ -144,6 +175,8 @@ void
 mlx5_flow_print(struct rte_flow *flow __rte_unused)
 {
 #ifndef NDEBUG
+   struct mlx5_flow_verbs *verbs = LIST_FIRST(&flow->verbs);
+
fprintf(stdout, "-8<\n");
fprintf(stdout, "%s: flow information\n", MLX5_DRIVER_NAME);
fprintf(stdout, " attributes: group %u priority %u ingress %d egress %d"
@@ -152,27 +185,36 @@ mlx5_flow_print(struct rte_flow *flow __rte_unused)
flow->attributes.ingress,
flow->attributes.egress,
flow->attributes.transfer);
-   fprintf(stdout, " layers: %s/%s/%s\n",
-   flow->verbs.layers & MLX5_FLOW_LAYER_L2 ? "l2" : "-",
-   flow->verbs.layers & MLX5_FLOW_LAYER_L3 ? "l3" : "-",
-   flow->verbs.layers & MLX5_FLOW_LAYER_L4 ? "l4" : "-");
-   if (flow->verbs.fate & MLX5_FLOW_FATE_DROP)
+   if (verbs->fate & MLX5_FLOW_FATE_DROP) {
fprintf(stdout, " fate: drop queue\n");
-   else if (flow->verbs.fate & MLX5_FLOW_FATE_QUEUE)
-   fprintf(stdout, " fate: target queue %u\n", flow->queue);
-   if (flow->verbs.attr) {
-   struct ibv_spec_header *hdr =
-   (struct ibv_spec_header *)flow->verbs.specs;
-   const int n = flow->verbs.attr->num_of_specs;
-   int i;
-
-   fprintf(stdout, " Verbs attributes: priority %u specs_n %u\n",
-  

[dpdk-dev] [PATCH] doc: document known issues for multiprocess

[Anatoly Burakov]

Also, reference Bugzilla entry for keeping most current information in
one place.

Signed-off-by: Anatoly Burakov 
---
 doc/guides/rel_notes/release_18_05.rst | 9 +
 1 file changed, 9 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index e8d74f5..032d303 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -568,6 +568,15 @@ Known Issues
   dpdk-pdump example and any other applications using librte_pdump, cannot work
   with older version DPDK primary applications.
 
+* **Secondary process launch is not reliable.**
+
+  Recent memory hotplug patches have made multiprocess startup less reliable
+  than it was in the past. A number of workarounds are known to work depending
+  on the circumstances, all of which are detailed in the Bugzilla entry
+  referenced below.
+
+  Bugzilla entry: https://dpdk.org/tracker/show_bug.cgi?id=50
+
 
 Shared Library Versions
 ---
-- 
2.7.4

[dpdk-dev] [PATCH] doc: document vhost performance regression

[Maxime Coquelin]

Signed-off-by: Maxime Coquelin 
---
 doc/guides/rel_notes/release_18_05.rst | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index e8d74f507..f89ce5658 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -568,6 +568,13 @@ Known Issues
   dpdk-pdump example and any other applications using librte_pdump, cannot work
   with older version DPDK primary applications.
 
+* **Unexpected performance regression in Vhost library.**
+
+  Patches fixing CVE-2018-1059 were expected to introduce a small performance
+  drop. However, in some setups, bigger performance drops have been measured
+  when running micro-benchmarks. More information may be found in the
+  dedicated bugzilla entry: https://dpdk.org/tracker/show_bug.cgi?id=48
+
 
 Shared Library Versions
 ---
-- 
2.14.3

[dpdk-dev] [PATCH] net/thunderx: add support for hardware first skip feature

[rkudurumalla]

This feature is used to create a hole between HEADROOM
and actual data.Size of hole is specified in bytes as
module param to pmd

Signed-off-by: Rakesh Kudurumalla 
---
 doc/guides/nics/thunderx.rst | 26 
 drivers/net/thunderx/base/nicvf_hw.c | 12 ++
 drivers/net/thunderx/base/nicvf_hw.h |  1 +
 drivers/net/thunderx/nicvf_ethdev.c  | 76 +++-
 drivers/net/thunderx/nicvf_ethdev.h  |  1 +
 drivers/net/thunderx/nicvf_struct.h  |  1 +
 6 files changed, 116 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/thunderx.rst b/doc/guides/nics/thunderx.rst
index 2642374..3d68c61 100644
--- a/doc/guides/nics/thunderx.rst
+++ b/doc/guides/nics/thunderx.rst
@@ -30,6 +30,7 @@ Features of the ThunderX PMD are:
 - SR-IOV VF
 - NUMA support
 - Multi queue set support (up to 96 queues (12 queue sets)) per port
+- First skip support
 
 Supported ThunderX SoCs
 ---
@@ -312,6 +313,26 @@ We will choose four secondary queue sets from the ending 
of the list (0002:01:01
 
 The nicvf thunderx driver will make use of attached secondary VFs 
automatically during the interface configuration stage.
 
+
+# Module params
+
+This feature is used to create a hole between HEADROOM and actual data.
+Size of hole is specified in bytes as module param to pmd.
+
+Configuration and Options
+-
+Use ``-w pci_id,skip_data_bytes="number of bytes to skip"`` in the EAL 
options
+Example:
+
+.. code-block:: console
+
+./your_application -w pci_id=skip_data_bytes=bytes_to_skip
+
+Ex: ./build/app/testpmd -w 0001:01:00.1,skip_data_bytes=8 -- --rxq=1 
--txq=1 --nb-cores=1 --port-topology=chained -i -- -c 0x1
+This will create a hole of 8 bytes between HEADROOM and actual data.
+
+Use case: The hole created with first_skip can be used to insert vlan 
header without disturbing HEADROOM
+
 Limitations
 ---
 
@@ -335,3 +356,8 @@ Maximum packet segments
 The ThunderX SoC family NICs support up to 12 segments per packet when working
 in scatter/gather mode. So, setting MTU will result with ``EINVAL`` when the
 frame size does not fit in the maximum number of segments.
+
+First_skip
+~~
+
+Maximum limit on first_skip is 128 bytes and number of bytes should be 
multiple of 8
diff --git a/drivers/net/thunderx/base/nicvf_hw.c 
b/drivers/net/thunderx/base/nicvf_hw.c
index ea8092c..b07a293 100644
--- a/drivers/net/thunderx/base/nicvf_hw.c
+++ b/drivers/net/thunderx/base/nicvf_hw.c
@@ -703,6 +703,18 @@ nicvf_vlan_hw_strip(struct nicvf *nic, bool enable)
 }
 
 void
+nicvf_first_skip_config(struct nicvf *nic, uint8_t num_dwords)
+{
+   uint64_t val;
+
+   val = nicvf_reg_read(nic, NIC_VNIC_RQ_GEN_CFG);
+   val &= ~(0xfULL);
+   val |= (num_dwords & 0xf);
+
+   nicvf_reg_write(nic, NIC_VNIC_RQ_GEN_CFG, val);
+}
+
+void
 nicvf_apad_config(struct nicvf *nic, bool enable)
 {
uint64_t val;
diff --git a/drivers/net/thunderx/base/nicvf_hw.h 
b/drivers/net/thunderx/base/nicvf_hw.h
index 284d0bd..fd13ea8 100644
--- a/drivers/net/thunderx/base/nicvf_hw.h
+++ b/drivers/net/thunderx/base/nicvf_hw.h
@@ -193,6 +193,7 @@ uint32_t nicvf_qsize_sq_roundup(uint32_t val);
 void nicvf_vlan_hw_strip(struct nicvf *nic, bool enable);
 
 void nicvf_apad_config(struct nicvf *nic, bool enable);
+void nicvf_first_skip_config(struct nicvf *nic, uint8_t dwords);
 
 int nicvf_rss_config(struct nicvf *nic, uint32_t  qcnt, uint64_t cfg);
 int nicvf_rss_term(struct nicvf *nic);
diff --git a/drivers/net/thunderx/nicvf_ethdev.c 
b/drivers/net/thunderx/nicvf_ethdev.c
index 99fcd51..466cb86 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -34,6 +34,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include "base/nicvf_plat.h"
 
@@ -1230,6 +1232,7 @@ nicvf_rxq_mbuf_setup(struct nicvf_rxq *rxq)
 {
uintptr_t p;
struct rte_mbuf mb_def;
+   struct nicvf *nic = rxq->nic;
 
RTE_BUILD_BUG_ON(sizeof(union mbuf_initializer) != 8);
RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_off) % 8 != 0);
@@ -1240,7 +1243,7 @@ nicvf_rxq_mbuf_setup(struct nicvf_rxq *rxq)
RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, port) -
offsetof(struct rte_mbuf, data_off) != 6);
mb_def.nb_segs = 1;
-   mb_def.data_off = RTE_PKTMBUF_HEADROOM;
+   mb_def.data_off = RTE_PKTMBUF_HEADROOM + (nic->skip_bytes);
mb_def.port = rxq->port_id;
rte_mbuf_refcnt_set(&mb_def, 1);
 
@@ -1260,9 +1263,19 @@ nicvf_dev_rx_queue_setup(struct rte_eth_dev *dev, 
uint16_t qidx,
struct nicvf_rxq *rxq;
struct nicvf *nic = nicvf_pmd_priv(dev);
uint64_t offloads;
+   uint32_t buffsz;
+   struct rte_pktmbuf_pool_private *mbp_priv;
 
PMD_INIT_FUNC_TRACE();
 
+   /* First skip check */
+   mbp_priv = rte_mempool_get_priv(mp);
+   buffsz = mbp_priv->mbuf_data_room_size - RTE_PKTMBU

Re: [dpdk-dev] [PATCH] devtools: add script to verify map files

[Bruce Richardson]

On Mon, May 28, 2018 at 11:31:31AM +0200, Thomas Monjalon wrote:
> 28/05/2018 11:21, Bruce Richardson:
> > On Sun, May 27, 2018 at 10:50:58PM +0200, Thomas Monjalon wrote:
> > > Sorry for having missed this patch during so long.
> > > 
> > > 13/02/2018 11:48, Ferruh Yigit:
> > > > On 2/12/2018 4:13 PM, Pavan Nikhilesh wrote:
> > > > > This script checks for the symbols specified in the map files against
> > > > > the symbols present in the map file directory.
> > > > > Currently, the script checks for map files in drivers and lib 
> > > > > directory.
> > > > > 
> > > > > Example:
> > > > > ./devtools/check-map.py
> > > > > 
> > > > > The following symbols are unused :
> > > > > 
> > > > > Map file : /home/pavan/Work/clean/dpdk/drivers/mempool/dpaa/...
> > > > > ['rte_dpaa_pool_table']
> > > > > 
> > > > > Map file : /home/pavan/Work/clean/dpdk/drivers/bus/fslmc/...
> > > > > ['qbman_get_version', 'qbman_swp_send_multiple']
> > > > > 
> > > > > ...
> > > > > 
> > > > > Signed-off-by: Pavan Nikhilesh 
> > > > 
> > > > +1 to improve our tools.
> > > > 
> > > > Acked-by: Ferruh Yigit 
> > > 
> > > I agree we must have more tools.
> > > 
> > > I think this check can be a lot simpler as a shell script,
> > > instead of Python. It does not need the list features of Python.
> > > 
> > 
> > While the shell version can be shorter, I always find python scripts to be
> > far easier to read, understand and therefore maintain than shell scripts.
> > While power-users of shell, like yourself, Thomas, can come up with some
> > amazing stuff done in shell, it tends to make them very hard to follow for
> > us mere mortals.
> 
> Some processing are simpler in Python.
> But here, the python script is mostly calling some shell commands and
> filtering like grep.
> 
> For comparison, python version:
>   http://dpdk.org/ml/archives/dev/2018-February/090772.html
> shell version:
>   http://dpdk.org/ml/archives/dev/2018-May/102993.html
> 

Well, the python script does have a call to grep in it, true. I'm not going
to have a problem either way, the python version still reads a little
easier, but the shell version is shorter and looks more natural, I suppose.
I'm happy enough to go along with whatever others (who may care) think.

/Bruce

Re: [dpdk-dev] [PATCH v2] devtools: add test script for meson builds

[Bruce Richardson]

On Mon, May 28, 2018 at 12:26:24PM +0200, Thomas Monjalon wrote:
> 28/05/2018 11:33, Bruce Richardson:
> > On Sat, May 26, 2018 at 11:32:53AM +0200, Thomas Monjalon wrote:
> > > 25/05/2018 17:18, Bruce Richardson:
> > > > On Fri, May 25, 2018 at 04:51:58PM +0200, Thomas Monjalon wrote:
> > > > > +cd $(dirname $(readlink -m $0))/..
> > > > > +
> > > > I don't think we should force the builds to be always put into the base
> > > > directory. Instead of using cd, I think we should instead capture the 
> > > > base
> > > > directory path and pass that to meson.
> > > 
> > > OK to not force the directory.
> > > You want to build in the current directory?
> > > If yes, we can just remove this "cd" and no need to pass a base directory
> > > to meson.
> > 
> > We would need to pass the base to meson, because otherwise meson assumes
> > the top-level meson.build file is in the current directory, i.e. calling
> > "meson build-dir" is the same as "meson . build-dir". If we want to allow
> > using this script from other places on filesystem, we need to either "cd"
> > to the base dir as you do now, or else explicitly pass in the basedir. The
> > latter I think is a better option as it would allow building from any
> > location on the filesystem.
> 
> I agree.
> 
> I don't understand the meson syntax:
>   meson [ options ] [ source directory ] [ build directory ]
> If there is only one argument, it is the build directory?
> 
> I could send a v5 to add the source directory in the meson command.
> It would be:
>   srcdir=$(dirname $(readlink -m $0))/..
>   $MESON $options $srcdir $builddir
> 

Yes, exactly.

> 
> > > > > +load_config () +{ +  reset_env + . $(dirname $(readlink -e
> > > > > $0))/load-devel-config +  MESON=${MESON:-meson} +}
> > > > Why does this need to be done each time?
> > > 
> > > Because the config could be different for each build (see above).
> > > 
> > How would it be different, it's the same command called with the same
> > environment each time?
> 
> No, the idea is to adapt the environment to the build target.  As an
> example, the dependencies can be different for 32-bit and 64-bit.
> 
I would hope that dependency detection should solve that, but since you
already have support for that in existing build script via environment
vars, I have no objection to leveraging that in the meson scripts. Overall,
though, I'd prefer to ensure that the detection works so that everyone only
needs one environment setup in order to get all builds working
simultaneously.

/Bruce

Re: [dpdk-dev] [PATCH v2 1/2] mk: fix cross build errors

[Bruce Richardson]

On Mon, May 28, 2018 at 02:53:47AM -0400, Gavin Hu wrote:
> The "-Wimplicit-fallthrough=2" option was introduced into gcc 7.0, it was
> enabled when the cross compiler gcc is greater than 7.0, but for the host
> side buildtools/pmdinfogen, if the native is older than 7.0, it should not
> be enabled.
> 
> The fix is to differentiate the host gcc Werror options from the cross gcc.
> 
> gcc -Wp,-MD,./.pmdinfogen.o.d.tmp  -W -Wall -Wstrict-prototypes
> -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition
> -Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual
> -Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings -Wdeprecated
> -Werror -Wimplicit-fallthrough=2 -Dbbb -Wno-format-truncation -g
> -I/home/gavin/arm_repo/dpdk/build/include-o pmdinfogen.o -c
> ~/dpdk/buildtools/pmdinfogen/pmdinfogen.c gcc: error:
> unrecognized command line option ‘-Wimplicit-fallthrough=2’
> ~/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'pmdinfogen.o'
> failed make[3]: *** [pmdinfogen.o] Error 1
> 
> Fixes: ced3e6f8 ("mk: adjust gcc flags for new gcc 7 warnings")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Gavin Hu 
> Reviewed-by: Honnappa Nagarahalli 
> Reviewed-by: Steve Capper 
> Reviewed-by: Thomas Monjalon 
> ---

Would a simpler solution for this not be to put "-Wno-implicit-fallthrough"
for pmdinfogen? GCC will not give a warning for an unrecognised "-Wno"
flag when compiling, unless there are other errors. This means we can just
use the flag without bothering with version checks.

/Bruce

Re: [dpdk-dev] [PATCH v2 2/2] doc: add a guide doc for cross compiling from x86

[Bruce Richardson]

On Mon, May 28, 2018 at 02:53:48AM -0400, Gavin Hu wrote:
> This is guild for cross compiling for ARM64 from X86 hosts.
> 
> Signed-off-by: Gavin Hu 
> Reviewed-by: Steve Capper 
> Reviewed-by: Honnappa Nagarahalli 
> Reviewed-by: Marko Kovacevic 
> Reviewed-by: Jerin Jacob 
> Reviewed-by: Thomas Monjalon 
> Reviewed-by: Bruce Richardson 
> ---
Can you also include details of cross-compiling using meson from the meson
build text file too?

/Bruce

Re: [dpdk-dev] [DPDK 18.08 v1 00/12] net/mlx5: flow rework

[Wiles, Keith]

The subject does not have [PATCH ] so it will be missed by patchwork, right?

> On May 28, 2018, at 6:21 AM, Nelio Laranjeiro  
> wrote:
> 
> First version of for the flow engine rework of MLX5 to prepare the
> introduction for the ENCAP/DECAP and PUSH/POP actions done via TC
> flower/filter.
> 
> This first series depends on [1] and is a work in progress, recent work added
> on Tunnel RSS are still absent as well as the tunnel support.  Those will be
> added in further versions.
> 
> Expected for the next 18.08 release:
> 
> - same level of features,
> - TC flow support for port redirection,
> - TC filter support for ENCAP/DECAP and PUSH/POP.
> 
> [1] https://dpdk.org/dev/patchwork/patch/40462/
> 
> Nelio Laranjeiro (12):
>  net/mlx5: remove flow support
>  net/mlx5: handle drop queues are regular queues
>  net/mlx5: support flow Ethernet item among with drop action
>  net/mlx5: add flow queue action
>  net/mlx5: add flow stop/start
>  net/mlx5: add flow VLAN item
>  net/mlx5: add flow IPv4 item
>  net/mlx5: add flow IPv6 item
>  net/mlx5: add flow UDP item
>  net/mlx5: add flow TCP item
>  net/mlx5: add mark/flag flow action
>  net/mlx5: add RSS flow action
> 
> drivers/net/mlx5/mlx5.c  |9 -
> drivers/net/mlx5/mlx5.h  |3 +-
> drivers/net/mlx5/mlx5_flow.c | 3615 +++---
> drivers/net/mlx5/mlx5_rxq.c  |  221 +++
> drivers/net/mlx5/mlx5_rxtx.h |6 +
> 5 files changed, 1388 insertions(+), 2466 deletions(-)
> 
> -- 
> 2.17.0
> 

Regards,
Keith

Re: [dpdk-dev] [DPDK 18.08] ethdev: add flow API to expand RSS flows

[Wiles, Keith]

This one too is missing the [PATCH ] keyword in the subject line.

> On May 28, 2018, at 4:54 AM, Nelio Laranjeiro  
> wrote:
> 
> Introduce an helper for PMD to expand easily flows items list with RSS
> action into multiple flow items lists with priority information.
> 
> For instance a user items list being "eth / end" with rss action types
> "ipv4-udp ipv6-udp end" needs to be expanded into three items lists:
> 
> - eth
> - eth / ipv4 / udp
> - eth / ipv6 / udp
> 
> to match the user request.  Some drivers are unable to reach such
> request without this expansion, this API is there to help those.
> Only PMD should use such API for their internal cooking, the application
> will still handle a single flow.
> 
> Signed-off-by: Nelio Laranjeiro 
> ---
> lib/librte_ethdev/rte_flow.c| 404 
> lib/librte_ethdev/rte_flow_driver.h |  32 +++
> 2 files changed, 436 insertions(+)
> 
> diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
> index 7947529da..0c42fc31c 100644
> --- a/lib/librte_ethdev/rte_flow.c
> +++ b/lib/librte_ethdev/rte_flow.c
> @@ -507,3 +507,407 @@ rte_flow_copy(struct rte_flow_desc *desc, size_t len,
>   }
>   return 0;
> }
> +
> +/* Copy the existing items list and expand with new items. */
> +static int
> +rte_flow_expand_rss_item(void *buf, size_t size,
> +  const struct rte_flow_item *items,
> +  const struct rte_flow_item *newitems)
> +{
> + void *data = buf;
> + const struct rte_flow_item *item;
> + struct rte_flow_item *dst;
> + size_t data_size = 0;
> +
> + dst = data;
> + /* Copy Item structure into buffer. */
> + for (item = items; item->type != RTE_FLOW_ITEM_TYPE_END; ++item) {
> + if (item->type == RTE_FLOW_ITEM_TYPE_VOID)
> + continue;
> + if (data_size + sizeof(*item) <= size) {
> + memcpy(dst, item, sizeof(*item));
> + ++dst;
> + }
> + data_size += sizeof(*item);
> + }
> + item = newitems;
> + do {
> + if (item->type == RTE_FLOW_ITEM_TYPE_VOID) {
> + ++item;
> + continue;
> + }
> + if (data_size + sizeof(*item) <= size) {
> + memcpy(dst, item, sizeof(*item));
> + ++dst;
> + }
> + data_size += sizeof(*item);
> + ++item;
> + } while ((item - 1)->type != RTE_FLOW_ITEM_TYPE_END);
> + /**
> +  * Copy Item spec, last, mask into buffer and set pointers
> +  * accordingly.
> +  */
> + dst = data;
> + for (item = items; item->type != RTE_FLOW_ITEM_TYPE_END; ++item) {
> + if (item->type == RTE_FLOW_ITEM_TYPE_VOID)
> + continue;
> + if (item->spec) {
> + size_t s = flow_item_spec_copy(NULL, item, ITEM_SPEC);
> + void *addr = (data_size + s) <= size ?
> + (void *)((uintptr_t)data + data_size) :
> + NULL;
> +
> + data_size += flow_item_spec_copy(addr, item, ITEM_SPEC);
> + if (addr)
> + dst->spec = addr;
> + }
> + if (item->last) {
> + size_t s = flow_item_spec_copy(NULL, item, ITEM_LAST);
> + void *addr = (data_size + s) <= size ?
> + (void *)((uintptr_t)data + data_size) :
> + NULL;
> +
> + data_size += flow_item_spec_copy(addr, item, ITEM_LAST);
> + if (addr)
> + dst->last = addr;
> + }
> + if (item->mask) {
> + size_t s = flow_item_spec_copy(NULL, item, ITEM_MASK);
> + void *addr = (data_size + s) <= size ?
> + (void *)((uintptr_t)data + data_size) :
> + NULL;
> +
> + data_size += flow_item_spec_copy(addr, item, ITEM_MASK);
> + if (addr)
> + dst->mask = addr;
> + }
> + if (data_size <= size)
> + ++dst;
> + }
> + return data_size;
> +}
> +
> +/** Verify the expansion is supported by the device. */
> +static int
> +rte_flow_expand_rss_is_supported(const enum rte_flow_item_type **supported,
> +  const enum rte_flow_item_type *expand)
> +{
> + unsigned int i;
> + unsigned int sidx;
> + unsigned int eidx;
> +
> + for (i = 0; supported[i]; ++i) {
> + sidx = 0;
> + eidx = 0;
> + while (1) {
> + if (expand[eidx] != supported[i][sidx]) {
> + break;
> + } else if ((expand[eidx] == RTE_FLOW_ITEM_TYPE_END) &&

[dpdk-dev] [Bug 52] Bonding PMD may fail to accept new slaves in certain conditions

[bugzilla]

https://dpdk.org/tracker/show_bug.cgi?id=52

Bug ID: 52
   Summary: Bonding PMD may fail to accept new slaves in certain
conditions
   Product: DPDK
   Version: 18.05
  Hardware: All
OS: All
Status: CONFIRMED
  Severity: minor
  Priority: Normal
 Component: ethdev
  Assignee: dev@dpdk.org
  Reporter: radu.nico...@intel.com
  Target Milestone: ---

When using testpmd to test bonding, the following sequence of commands will
fail as described:

testpmd> port stop all
testpmd> create bonded device 4 0
testpmd> add bonding slave 0 2
testpmd> add bonding slave 1 2

__eth_bond_slave_add_lock_free(352) - Invalid link properties for slave 1 in
bonding mode 4
Failed to add slave 1 to master port = 2


Root cause is a mismatch in port link status caused by testpmd implementation
that does not re-check all ports, but stops at the first port that shows link
down.

To work around the issue insert "show port info all" command after "port stop
all" if using testpmd, or make sure that the application either calls
rte_eth_link_get on all ports that will be bound, or on none of them.

Patch addressing the issue: https://dpdk.org/dev/patchwork/patch/39567/

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [dpdk-dev] [PATCH] net/thunderx: add support for hardware first skip feature

[Ferruh Yigit]

On 5/28/2018 1:57 PM, rkudurumalla wrote:
> This feature is used to create a hole between HEADROOM
> and actual data.Size of hole is specified in bytes as
> module param to pmd

Can't mbuf private area be used? It is between HEADROOM and mbuf header.

> 
> Signed-off-by: Rakesh Kudurumalla 

<...>

Re: [dpdk-dev] [PATCH] net/mlx4: fix crash when configure is not called

[Shahaf Shuler]

Sunday, May 27, 2018 10:05 AM, Yongseok Koh:
> Subject: [PATCH] net/mlx4: fix crash when configure is not called
> 
> Although uncommon, applications may destroy a device immediately after
> probing it without going through dev_configure() first.
> 
> This patch addresses a crash which occurs when mlx4_dev_close() calls
> mlx4_mr_release() due to an uninitialized entry in the private structure.
> 
> And the device's B-tree should be allocated once.
> 
> Fixes: 9797bfcce1c9 ("net/mlx4: add new memory region support")
> 
> Signed-off-by: Adrien Mazarguil 
> Signed-off-by: Xueming Li 
> Signed-off-by: Yongseok Koh 
> ---

Applied to next-net-mlx, thanks. 

Re: [dpdk-dev] [DPDK 18.08 v1 00/12] net/mlx5: flow rework

[Ferruh Yigit]

On 5/28/2018 2:32 PM, Wiles, Keith wrote:
> The subject does not have [PATCH ] so it will be missed by patchwork, right?

Patchwork already have them [1], it seems patchwork doesn't take patch
subject-prefix into account.

[1]
Only I already mark the set as deferred, that is why it may not been seen in new
patches list.
https://dpdk.org/dev/patchwork/patch/40466/

> 
>> On May 28, 2018, at 6:21 AM, Nelio Laranjeiro  
>> wrote:
>>
>> First version of for the flow engine rework of MLX5 to prepare the
>> introduction for the ENCAP/DECAP and PUSH/POP actions done via TC
>> flower/filter.
>>
>> This first series depends on [1] and is a work in progress, recent work added
>> on Tunnel RSS are still absent as well as the tunnel support.  Those will be
>> added in further versions.
>>
>> Expected for the next 18.08 release:
>>
>> - same level of features,
>> - TC flow support for port redirection,
>> - TC filter support for ENCAP/DECAP and PUSH/POP.
>>
>> [1] https://dpdk.org/dev/patchwork/patch/40462/
>>
>> Nelio Laranjeiro (12):
>>  net/mlx5: remove flow support
>>  net/mlx5: handle drop queues are regular queues
>>  net/mlx5: support flow Ethernet item among with drop action
>>  net/mlx5: add flow queue action
>>  net/mlx5: add flow stop/start
>>  net/mlx5: add flow VLAN item
>>  net/mlx5: add flow IPv4 item
>>  net/mlx5: add flow IPv6 item
>>  net/mlx5: add flow UDP item
>>  net/mlx5: add flow TCP item
>>  net/mlx5: add mark/flag flow action
>>  net/mlx5: add RSS flow action
>>
>> drivers/net/mlx5/mlx5.c  |9 -
>> drivers/net/mlx5/mlx5.h  |3 +-
>> drivers/net/mlx5/mlx5_flow.c | 3615 +++---
>> drivers/net/mlx5/mlx5_rxq.c  |  221 +++
>> drivers/net/mlx5/mlx5_rxtx.h |6 +
>> 5 files changed, 1388 insertions(+), 2466 deletions(-)
>>
>> -- 
>> 2.17.0
>>
> 
> Regards,
> Keith
> 

[dpdk-dev] [PATCH] doc: document bonding known issue

[Radu Nicolau]

Signed-off-by: Radu Nicolau 
---
 doc/guides/rel_notes/release_18_05.rst | 5 +
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index e8d74f5..ae14181 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -568,6 +568,11 @@ Known Issues
   dpdk-pdump example and any other applications using librte_pdump, cannot work
   with older version DPDK primary applications.
 
+* **Bonding PMD may fail to accept new slaves in certain conditions.**
+
+  In certain conditions when using tespmd bonding may fail to register new 
slave
+  ports. More information on the Bugzilla entry:
+  https://dpdk.org/tracker/show_bug.cgi?id=52.
 
 Shared Library Versions
 ---
-- 
2.7.5

Re: [dpdk-dev] [DPDK 18.08 v1 00/12] net/mlx5: flow rework

[Nélio Laranjeiro]

Hi Keith,

On Mon, May 28, 2018 at 01:32:34PM +, Wiles, Keith wrote:
> The subject does not have [PATCH ] so it will be missed by patchwork, right?

I see them on the patchwork [1], it seems it uses anything else to
determine if it is a patch or not.

> > On May 28, 2018, at 6:21 AM, Nelio Laranjeiro  
> > wrote:
> > 
> > First version of for the flow engine rework of MLX5 to prepare the
> > introduction for the ENCAP/DECAP and PUSH/POP actions done via TC
> > flower/filter.
> > 
> > This first series depends on [1] and is a work in progress, recent work 
> > added
> > on Tunnel RSS are still absent as well as the tunnel support.  Those will be
> > added in further versions.
> > 
> > Expected for the next 18.08 release:
> > 
> > - same level of features,
> > - TC flow support for port redirection,
> > - TC filter support for ENCAP/DECAP and PUSH/POP.
> > 
> > [1] https://dpdk.org/dev/patchwork/patch/40462/
> > 
> > Nelio Laranjeiro (12):
> >  net/mlx5: remove flow support
> >  net/mlx5: handle drop queues are regular queues
> >  net/mlx5: support flow Ethernet item among with drop action
> >  net/mlx5: add flow queue action
> >  net/mlx5: add flow stop/start
> >  net/mlx5: add flow VLAN item
> >  net/mlx5: add flow IPv4 item
> >  net/mlx5: add flow IPv6 item
> >  net/mlx5: add flow UDP item
> >  net/mlx5: add flow TCP item
> >  net/mlx5: add mark/flag flow action
> >  net/mlx5: add RSS flow action
> > 
> > drivers/net/mlx5/mlx5.c  |9 -
> > drivers/net/mlx5/mlx5.h  |3 +-
> > drivers/net/mlx5/mlx5_flow.c | 3615 +++---
> > drivers/net/mlx5/mlx5_rxq.c  |  221 +++
> > drivers/net/mlx5/mlx5_rxtx.h |6 +
> > 5 files changed, 1388 insertions(+), 2466 deletions(-)
> > 
> > -- 
> > 2.17.0
> > 
> 
> Regards,
> Keith

Thanks,

[1] https://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=243

-- 
Nélio Laranjeiro
6WIND

[dpdk-dev] [PATCH v1] doc: add guides for patch fix issues

[Marko Kovacevic]

Added contribution guideline for adding tags
when sending patches that have been raised on
Bugzilla

Signed-off-by: Marko Kovacevic 
---
 doc/guides/contributing/patches.rst | 48 ++---
 1 file changed, 34 insertions(+), 14 deletions(-)

diff --git a/doc/guides/contributing/patches.rst 
b/doc/guides/contributing/patches.rst
index 7bb5710..0033fd4 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -256,26 +256,46 @@ In addition to the ``Signed-off-by:`` name the commit 
messages can also have
 tags for who reported, suggested, tested and reviewed the patch being
 posted. Please refer to the `Tested, Acked and Reviewed by`_ section.
 
-Coverity Related Patch Fixes
-
+Patch Fix Related Issues
+
 
-`Coverity 
`_
-is a tool for static code analysis.
-It is used as a cloud-based service used to scan the DPDK source code,
-and alert developers of any potential defects in the source code.
-When fixing an issue found by Coverity, the patch must contain a Coverity 
issue ID
-in the body of the commit message. For example::
+  `Coverity 
`_
+   is a tool for static code analysis.
+   It is used as a cloud-based service used to scan the DPDK source code,
+   and alert developers of any potential defects in the source code.
+   When fixing an issue found by Coverity, the patch must contain a Coverity 
issue ID
+   in the body of the commit message. For example::
 
 
- doc: fix some parameter description
+   doc: fix some parameter description
+
+   Update the docs, fixing description of some parameter.
+
+   Coverity issue: 12345
+   Fixes: abcdefgh1234 ("doc: add some parameter")
+   Cc: aut...@example.com
+
+   Signed-off-by: Alex Smith 
+
+
+  `Bugzilla `_
+   is a bug- or issue-tracking system. Bug-tracking
+   systems allow individual or groups of developers effectively to keep track 
of outstanding
+   problems with their product. When fixing an issue raised in Bugzilla, the 
patch must contain
+   a Bugzilla issue ID in the body of the commit message. For example::
+
+   doc: fix some parameter description
+
+   Update the docs, fixing description of some parameter.
+
+   Bugzilla ID: 12345
+   Fixes: abcdefgh1234 ("doc: add some parameter")
+   Cc: aut...@example.com
+
+   Signed-off-by: Alex Smith 
 
- Update the docs, fixing description of some parameter.
 
- Coverity issue: 12345
- Fixes: abcdefgh1234 ("doc: add some parameter")
- Cc: aut...@example.com
 
- Signed-off-by: Alex Smith 
 
 Patch for Stable Releases
 ~
-- 
2.9.5

[dpdk-dev] [Bug 53] rte abort issue on FreeBSD

[bugzilla]

https://dpdk.org/tracker/show_bug.cgi?id=53

Bug ID: 53
   Summary: rte abort issue on FreeBSD
   Product: DPDK
   Version: 18.05
  Hardware: All
OS: FreeBSD
Status: CONFIRMED
  Severity: major
  Priority: Normal
 Component: core
  Assignee: dev@dpdk.org
  Reporter: reshma.pat...@intel.com
  Target Milestone: ---

DPDK processes now allocates a large area of virtual memory address space,
 with this change during rte_abort FreeBSD now dumps the contents of the
 whole reserved memory range, not just the used portion, to a core dump file.
 Write this large core file can take a significant amount of time, causing
 processes to appear hung on the system.

 The work around for the issue is to set the system resource limits for core
 dumps before running any tests e.g."limit coredumpsize 0". This will
 effectively disable core dumps on FreeBSD. If they are not to be completely
 disabled, a suitable limit, e.g. 1G might be specified instead of 0. This
 needs to be run per-shell session, or before every test run. This change
 can also be made persistent by adding "kern.coredump=0" to /etc/sysctl.conf

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: [dpdk-dev] [PATCH v2] doc: add known issue of rte abort on FreeBSD

[Mcnamara, John]

> -Original Message-
> From: Pattan, Reshma
> Sent: Monday, May 21, 2018 11:16 AM
> To: dev@dpdk.org
> Cc: Burakov, Anatoly ; Mcnamara, John
> ; Pattan, Reshma 
> Subject: [PATCH v2] doc: add known issue of rte abort on FreeBSD
> 
> Added known issue of rte_abort taking a long time on FreeBSD due to recent
> memory subsystem rework.
> 
> Signed-off-by: Reshma Pattan 
> Acked-by: Anatoly Burakov 

Could you open an Bugzilla defect for this and add it to the text.

Like this patch: http://dpdk.org/dev/patchwork/patch/40475/

Thanks,

John

Re: [dpdk-dev] [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU attributes read

[Mcnamara, John]

> -Original Message-
> From: Xu, Rosen
> Sent: Wednesday, May 16, 2018 8:29 AM
> To: dev@dpdk.org
> Cc: Burakov, Anatoly ; gaetan.ri...@6wind.com;
> Mcnamara, John ; Xu, Rosen ;
> Pei, Yulong ; sta...@dpdk.org
> Subject: [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU
> attributes read
> 
> Linux kernel 4.10.0 iommu attribute read error
> 
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Rosen Xu 


Could you open an Bugzilla defect for this and add it to the text.

Like this patch: http://dpdk.org/dev/patchwork/patch/40475/

Thanks,

John

Re: [dpdk-dev] [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU attributes read

[Mcnamara, John]

> -Original Message-
> From: stable [mailto:stable-boun...@dpdk.org]
> Sent: Monday, May 28, 2018 4:31 PM
> To: Xu, Rosen ; dev@dpdk.org
> Cc: Burakov, Anatoly ; gaetan.ri...@6wind.com;
> Pei, Yulong ; sta...@dpdk.org; Yigit, Ferruh
> 
> Subject: Re: [dpdk-stable] [PATCH v2] doc/guides/rel_notes: Add known
> issue for IOMMU attributes read
> 
> 
> 
> > -Original Message-
> > From: Xu, Rosen
> > Sent: Wednesday, May 16, 2018 8:29 AM
> > To: dev@dpdk.org
> > Cc: Burakov, Anatoly ;
> > gaetan.ri...@6wind.com; Mcnamara, John ; Xu,
> > Rosen ; Pei, Yulong ;
> > sta...@dpdk.org
> > Subject: [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU
> > attributes read
> >
> > Linux kernel 4.10.0 iommu attribute read error
> >
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Rosen Xu 
> 
> 
> Could you open an Bugzilla defect for this and add it to the text.
> 
> Like this patch: http://dpdk.org/dev/patchwork/patch/40475/

Actually, I changed my mind. This isn't quite the same as the other new, known 
issues, so there is no need to track it in Bugzilla or move it to the release 
note.

It is okay as is.


Acked-by: John McNamara 

[dpdk-dev] [PATCH v3] doc: add known issue of rte abort on FreeBSD

[Reshma Pattan]

Added known issue of rte_abort taking a long time
on FreeBSD due to recent memory subsystem rework.
Also, reference Bugzilla entry for keeping most
current information in one place.

Signed-off-by: Reshma Pattan 
Acked-by: Anatoly Burakov 
---
v3: added bugzilla reference.
---
 doc/guides/rel_notes/release_18_05.rst | 16 
 1 file changed, 16 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index e8d74f507..4d3b00031 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -568,6 +568,22 @@ Known Issues
   dpdk-pdump example and any other applications using librte_pdump, cannot work
   with older version DPDK primary applications.
 
+* **rte_abort takes a long time on FreeBSD.**
+
+  DPDK processes now allocates a large area of virtual memory address space,
+  with this change during rte_abort FreeBSD now dumps the contents of the
+  whole reserved memory range, not just the used portion, to a core dump file.
+  Write this large core file can take a significant amount of time, causing
+  processes to appear hung on the system.
+
+  The work around for the issue is to set the system resource limits for core
+  dumps before running any tests e.g."limit coredumpsize 0". This will
+  effectively disable core dumps on FreeBSD. If they are not to be completely
+  disabled, a suitable limit, e.g. 1G might be specified instead of 0. This
+  needs to be run per-shell session, or before every test run. This change
+  can also be made persistent by adding "kern.coredump=0" to /etc/sysctl.conf
+
+  Bugzilla entry: https://dpdk.org/tracker/show_bug.cgi?id=53
 
 Shared Library Versions
 ---
-- 
2.14.3

Re: [dpdk-dev] [PATCH v1] doc: add guides for patch fix issues

[Ferruh Yigit]

On 5/28/2018 4:23 PM, Marko Kovacevic wrote:
> Added contribution guideline for adding tags
> when sending patches that have been raised on
> Bugzilla
> 
> Signed-off-by: Marko Kovacevic 

Acked-by: Ferruh Yigit 

Re: [dpdk-dev] [PATCH v2 2/2] doc: add a guide doc for cross compiling from x86

[Kovacevic, Marko]

> This is guild for cross compiling for ARM64 from X86 hosts.
> 
> Signed-off-by: Gavin Hu 
> Reviewed-by: Steve Capper 
> Reviewed-by: Honnappa Nagarahalli 
> Reviewed-by: Marko Kovacevic 
> Reviewed-by: Jerin Jacob 
> Reviewed-by: Thomas Monjalon 
> Reviewed-by: Bruce Richardson 
> ---

Hi Gavin,

After reviewing your file in the .rst format it doesn't look good, the whole 
formatting is wrong and
unreadable. As you have the wrong headers and sections. You have code block and 
command line arguments 
added in everywhere making it not look good. Also you have added an index to a 
file in the howto that doesn't exist.

dpdk/doc/guides/howto/index.rst:7: WARNING: toctree contains reference to 
nonexisting document u'howto/cross_compile_sdk_for_arm64'
dpdk/doc/guides/linux_gsg/index.rst:9: WARNING: toctree contains reference to 
nonexisting document u'linux_gsg/cross_build_dpdk_for_arm64'
dpdk/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst: WARNING: document 
isn't included in any toctree

Id advise you go to this link and familiarize yourself with the proper way of 
writing in the rst format.
And also try and view the html version of your file before you send it out to 
make sure it looks ok.

If you adding command line arguments into text use this ``make -j 
CROSS=aarch64-linux-gnu- CONFIG_RTE_KNI_KMOD=n CONFIG_RTE_EAL_IGB_UIO=n``

http://dpdk.org/doc/guides/contributing/documentation.html

Marko K

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Mcnamara, John]

> -Original Message-
> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com]
> Sent: Saturday, May 26, 2018 1:59 PM
> To: Kovacevic, Marko ; Thomas Monjalon
> ; Yigit, Ferruh 
> Cc: dev@dpdk.org; Mcnamara, John 
> Subject: RE: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files
> 
> 
> -Original Message-
> From: Kovacevic, Marko [mailto:marko.kovace...@intel.com]
> Sent: Friday, May 25, 2018 9:00 PM
> To: Thomas Monjalon ; Hemant Agrawal
> ; Yigit, Ferruh 
> Cc: dev@dpdk.org; Mcnamara, John 
> Subject: RE: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files
> 
> >
> >
> > It has been recommended to add SPDX tags to release notes, with a
> > global copyright on behalf of all contributors, or community.
> >
> > We need a v2 of this patch, thanks.
> >
> >
> 
> Hi Thomas,
> 
> What exactly is the global copyright ?
> 
> [Hemant] We discussed with LF foundation lawyers. It was suggested to use
> "Copyright 2018 The DPDK Community"


Hi Hemant,

Is that valid? "The DPDK Community" isn't a single, clear entity.

If that is what has been agreed then we are okay with it but I wanted to
make 100% sure.

John

[dpdk-dev] [PATCH 1/2] doc: add port representor update in release notes

[Mohammad Abdul Awal]

Change-Id: I21f59c0e540577970c2f3bb8fcd6536fb1ccaefb
Signed-off-by: Mohammad Abdul Awal 
---
 doc/guides/rel_notes/release_18_05.rst | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index e8d74f507..511d51908 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -313,6 +313,16 @@ New Features
   on eth devices (right now only via SW RX/TX callbacks).
   It also adds dependency on libelf.
 
+* **Added support for port representors.**
+
+  The DPDK port representors (also known as "VF representors" in the specific
+  context of VFs), which are to DPDK what the Ethernet switch device driver
+  model (**switchdev**) is to Linux, and which can be thought as a software
+  "patch panel" front-end for applications. DPDK port representors are
+  implemented as additional virtual Ethernet device (**ethdev**) instances,
+  spawned on an as needed basis through configuration parameters passed to the
+  driver of the underlying device using devargs.
+
 
 API Changes
 ---
-- 
2.17.0

[dpdk-dev] [PATCH 2/2] doc: add vxlan and nvgre tunnel update in release notes

[Mohammad Abdul Awal]

Change-Id: Ibcb8d2343db7f3ac8346dd2ac73ff93e026e0431
Signed-off-by: Mohammad Abdul Awal 
---
 doc/guides/rel_notes/release_18_05.rst | 17 +
 1 file changed, 17 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index 511d51908..37d102572 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -323,6 +323,15 @@ New Features
   spawned on an as needed basis through configuration parameters passed to the
   driver of the underlying device using devargs.
 
+* **Added support for VXLAN and NVGRE tunnel endpoint.**
+
+  New actions types have been added to support encapsulation and decapsulation
+  operations for a tunnel endpoint. The new action types are
+  RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_ENCAP, 
RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_DECAP,
+  RTE_FLOW_ACTION_TYPE_JUMP. New item type RTE_FLOW_ACTION_TYPE_MARK has been
+  added to match a flow against a previously marked flow. It also introduced 
shared
+  counter to flow API to counte for a group of flows.
+
 
 API Changes
 ---
@@ -457,6 +466,14 @@ API Changes
 redirect matching traffic to a specific physical port.
   * PORT_ID pattern item and actions were added to match and target DPDK
 port IDs at a higher level than PHY_PORT.
+  * RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_ENCAP action items were added to support
+tunnel encapsulation operation for VXLAN and NVGRE type tunnel endpoint.
+  * RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_DECAP action items were added to support
+tunnel decapsulation operation for VXLAN and NVGRE type tunnel endpoint.
+  * RTE_FLOW_ACTION_TYPE_JUMP action item was added to support a matched flow
+to be redirected to the specific group.
+  * RTE_FLOW_ACTION_TYPE_MARK item type has been added to match a flow against
+a previously marked flow.
 
 * ethdev: change flow APIs regarding count action:
   * ``rte_flow_create()`` API count action now requires the ``struct 
rte_flow_action_count``.
-- 
2.17.0

[dpdk-dev] [PATCH v1] doc: postpone devargs genericisation work

[Gaetan Rivet]

Device querying and declaration has been postponed to 18.08.
Additionally, while working on the feature, some changes previously
announced won't be enacted.

Signed-off-by: Gaetan Rivet 
---
 doc/guides/rel_notes/deprecation.rst | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst 
b/doc/guides/rel_notes/deprecation.rst
index 103520cc2..1ce692eac 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -18,13 +18,12 @@ Deprecation Notices
   - if DPDK is not running as root and $XDG_RUNTIME_DIR is not set, path will 
be
 set to ``/tmp/dpdk//config``
 
-* eal: both declaring and identifying devices will be streamlined in v18.05.
+* eal: both declaring and identifying devices will be streamlined in v18.08.
   New functions will appear to query a specific port from buses, classes of
   device and device drivers. Device declaration will be made coherent with the
   new scheme of device identification.
   As such, ``rte_devargs`` device representation will change.
 
-  - removal of ``name`` and ``args`` fields.
   - The enum ``rte_devtype`` was used to identify a bus and will disappear.
   - Functions previously deprecated will change or disappear:
 
-- 
2.11.0

[dpdk-dev] [PATCH 2/2] doc: add vxlan and nvgre tunnel update in release notes

[Mohammad Abdul Awal]

Signed-off-by: Mohammad Abdul Awal 
---
 doc/guides/rel_notes/release_18_05.rst | 17 +
 1 file changed, 17 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index 511d51908..37d102572 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -323,6 +323,15 @@ New Features
   spawned on an as needed basis through configuration parameters passed to the
   driver of the underlying device using devargs.
 
+* **Added support for VXLAN and NVGRE tunnel endpoint.**
+
+  New actions types have been added to support encapsulation and decapsulation
+  operations for a tunnel endpoint. The new action types are
+  RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_ENCAP, 
RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_DECAP,
+  RTE_FLOW_ACTION_TYPE_JUMP. New item type RTE_FLOW_ACTION_TYPE_MARK has been
+  added to match a flow against a previously marked flow. It also introduced 
shared
+  counter to flow API to counte for a group of flows.
+
 
 API Changes
 ---
@@ -457,6 +466,14 @@ API Changes
 redirect matching traffic to a specific physical port.
   * PORT_ID pattern item and actions were added to match and target DPDK
 port IDs at a higher level than PHY_PORT.
+  * RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_ENCAP action items were added to support
+tunnel encapsulation operation for VXLAN and NVGRE type tunnel endpoint.
+  * RTE_FLOW_ACTION_TYPE_[VXLAN/NVGRE]_DECAP action items were added to support
+tunnel decapsulation operation for VXLAN and NVGRE type tunnel endpoint.
+  * RTE_FLOW_ACTION_TYPE_JUMP action item was added to support a matched flow
+to be redirected to the specific group.
+  * RTE_FLOW_ACTION_TYPE_MARK item type has been added to match a flow against
+a previously marked flow.
 
 * ethdev: change flow APIs regarding count action:
   * ``rte_flow_create()`` API count action now requires the ``struct 
rte_flow_action_count``.
-- 
2.17.0

[dpdk-dev] [PATCH 1/2] doc: add port representor update in release notes

[Mohammad Abdul Awal]

Signed-off-by: Mohammad Abdul Awal 
---
 doc/guides/rel_notes/release_18_05.rst | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index e8d74f507..511d51908 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -313,6 +313,16 @@ New Features
   on eth devices (right now only via SW RX/TX callbacks).
   It also adds dependency on libelf.
 
+* **Added support for port representors.**
+
+  The DPDK port representors (also known as "VF representors" in the specific
+  context of VFs), which are to DPDK what the Ethernet switch device driver
+  model (**switchdev**) is to Linux, and which can be thought as a software
+  "patch panel" front-end for applications. DPDK port representors are
+  implemented as additional virtual Ethernet device (**ethdev**) instances,
+  spawned on an as needed basis through configuration parameters passed to the
+  driver of the underlying device using devargs.
+
 
 API Changes
 ---
-- 
2.17.0

[dpdk-dev] [PATCH 0/2] Vhost: unitfy receive paths

[Maxime Coquelin]

Hi,

This series is preliminary work to ease the integration of
packed ring layout support. But even without packed ring
layout, the result is positive.

First patch unify both paths, and second one is a small
optimization to avoid copying batch_copy_nb_elems VQ field
to/from the stack.

With the series applied, I get modest performance gain for
both mergeable and non-mergeable casesi (, and the gain of
about 300 LoC is non negligible maintenance-wise.

Rx-mrg=off benchmarks:

++---+-+-+--+
|Run |  PVP  | Guest->Host | Host->Guest | Loopback |
++---+-+-+--+
| v18.05-rc5 | 14.47 |   16.64 |   17.57 |13.15 |
| + series   | 14.87 |   16.86 |   17.70 |13.30 |
++---+-+-+--+

Rx-mrg=on benchmarks:

++--+-+-+--+
|Run | PVP  | Guest->Host | Host->Guest | Loopback |
++--+-+-+--+
| v18.05-rc5 | 9.38 |   13.78 |   16.70 |12.79 |
| + series   | 9.38 |   13.80 |   17.49 |13.36 |
++--+-+-+--+

Note: Even without my series, the guest->host benchmark with
mergeable buffers enabled looks suspicious as it should in
theory be alsmost identical as when Rx mergeable buffers are
disabled. To be investigated...

Maxime Coquelin (2):
  vhost: unify Rx mergeable and non-mergeable paths
  vhost: improve batched copies performance

 lib/librte_vhost/virtio_net.c | 366 --
 1 file changed, 32 insertions(+), 334 deletions(-)

-- 
2.14.3

[dpdk-dev] [PATCH 2/2] vhost: improve batched copies performance

[Maxime Coquelin]

Instead of copying batch_copy_nb_elems into the stack,
this patch uses it directly.

Small performance gain of 3% is seen when running PVP
benchmark.

Signed-off-by: Maxime Coquelin 
---
 lib/librte_vhost/virtio_net.c | 29 ++---
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index c5237f853..d29c61ff8 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -352,7 +352,6 @@ copy_mbuf_to_desc_mergeable(struct virtio_net *dev, struct 
vhost_virtqueue *vq,
struct rte_mbuf *hdr_mbuf;
struct batch_copy_elem *batch_copy = vq->batch_copy_elems;
struct virtio_net_hdr_mrg_rxbuf tmp_hdr, *hdr = NULL;
-   uint16_t copy_nb = vq->batch_copy_nb_elems;
int error = 0;
 
if (unlikely(m == NULL)) {
@@ -493,7 +492,8 @@ copy_mbuf_to_desc_mergeable(struct virtio_net *dev, struct 
vhost_virtqueue *vq,
 
cpy_len = RTE_MIN(desc_chunck_len, mbuf_avail);
 
-   if (likely(cpy_len > MAX_BATCH_LEN || copy_nb >= vq->size)) {
+   if (likely(cpy_len > MAX_BATCH_LEN ||
+   vq->batch_copy_nb_elems >= vq->size)) {
rte_memcpy((void *)((uintptr_t)(desc_addr +
desc_offset)),
rte_pktmbuf_mtod_offset(m, void *, mbuf_offset),
@@ -503,13 +503,14 @@ copy_mbuf_to_desc_mergeable(struct virtio_net *dev, 
struct vhost_virtqueue *vq,
PRINT_PACKET(dev, (uintptr_t)(desc_addr + desc_offset),
cpy_len, 0);
} else {
-   batch_copy[copy_nb].dst =
+   batch_copy[vq->batch_copy_nb_elems].dst =
(void *)((uintptr_t)(desc_addr + desc_offset));
-   batch_copy[copy_nb].src =
+   batch_copy[vq->batch_copy_nb_elems].src =
rte_pktmbuf_mtod_offset(m, void *, mbuf_offset);
-   batch_copy[copy_nb].log_addr = desc_gaddr + desc_offset;
-   batch_copy[copy_nb].len = cpy_len;
-   copy_nb++;
+   batch_copy[vq->batch_copy_nb_elems].log_addr =
+   desc_gaddr + desc_offset;
+   batch_copy[vq->batch_copy_nb_elems].len = cpy_len;
+   vq->batch_copy_nb_elems++;
}
 
mbuf_avail  -= cpy_len;
@@ -520,7 +521,6 @@ copy_mbuf_to_desc_mergeable(struct virtio_net *dev, struct 
vhost_virtqueue *vq,
}
 
 out:
-   vq->batch_copy_nb_elems = copy_nb;
 
return error;
 }
@@ -766,7 +766,6 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct 
vhost_virtqueue *vq,
/* A counter to avoid desc dead loop chain */
uint32_t nr_desc = 1;
struct batch_copy_elem *batch_copy = vq->batch_copy_elems;
-   uint16_t copy_nb = vq->batch_copy_nb_elems;
int error = 0;
 
desc = &descs[desc_idx];
@@ -905,7 +904,7 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct 
vhost_virtqueue *vq,
mbuf_avail = cpy_len;
} else {
if (likely(cpy_len > MAX_BATCH_LEN ||
-  copy_nb >= vq->size ||
+  vq->batch_copy_nb_elems >= vq->size ||
   (hdr && cur == m) ||
   desc->len != desc_chunck_len)) {
rte_memcpy(rte_pktmbuf_mtod_offset(cur, void *,
@@ -914,14 +913,15 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct 
vhost_virtqueue *vq,
desc_offset)),
   cpy_len);
} else {
-   batch_copy[copy_nb].dst =
+   batch_copy[vq->batch_copy_nb_elems].dst =
rte_pktmbuf_mtod_offset(cur, void *,
mbuf_offset);
-   batch_copy[copy_nb].src =
+   batch_copy[vq->batch_copy_nb_elems].src =
(void *)((uintptr_t)(desc_addr +
 desc_offset));
-   batch_copy[copy_nb].len = cpy_len;
-   copy_nb++;
+   batch_copy[vq->batch_copy_nb_elems].len =
+   cpy_len;
+   vq->batch_copy_nb_elems++;
}
}
 
@@ -1015,7 +1015,6 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct 
vhost_virtqueue *vq,
vhost_dequeue_offload(hdr

[dpdk-dev] [PATCH 1/2] vhost: unify Rx mergeable and non-mergeable paths

[Maxime Coquelin]

This patch reworks the vhost enqueue path so that a single
code path is used for both Rx mergeable or non-mergeable cases.

Signed-off-by: Maxime Coquelin 
---
 lib/librte_vhost/virtio_net.c | 337 +++---
 1 file changed, 18 insertions(+), 319 deletions(-)

diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 76ec5f089..c5237f853 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -25,6 +25,12 @@
 
 #define MAX_BATCH_LEN 256
 
+static  __rte_always_inline bool
+rxvq_is_mergeable(struct virtio_net *dev)
+{
+   return dev->features && (1ULL << VIRTIO_NET_F_MRG_RXBUF);
+}
+
 static bool
 is_valid_virt_queue_idx(uint32_t idx, int is_tx, uint32_t nr_vring)
 {
@@ -154,7 +160,7 @@ do_data_copy_dequeue(struct vhost_virtqueue *vq)
(var) = (val);  \
 } while (0)
 
-static void
+static __rte_always_inline void
 virtio_enqueue_offload(struct rte_mbuf *m_buf, struct virtio_net_hdr *net_hdr)
 {
uint64_t csum_l4 = m_buf->ol_flags & PKT_TX_L4_MASK;
@@ -215,317 +221,6 @@ virtio_enqueue_offload(struct rte_mbuf *m_buf, struct 
virtio_net_hdr *net_hdr)
}
 }
 
-static __rte_always_inline int
-copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,
- struct vring_desc *descs, struct rte_mbuf *m,
- uint16_t desc_idx, uint32_t size)
-{
-   uint32_t desc_avail, desc_offset;
-   uint32_t mbuf_avail, mbuf_offset;
-   uint32_t cpy_len;
-   uint64_t desc_chunck_len;
-   struct vring_desc *desc;
-   uint64_t desc_addr, desc_gaddr;
-   /* A counter to avoid desc dead loop chain */
-   uint16_t nr_desc = 1;
-   struct batch_copy_elem *batch_copy = vq->batch_copy_elems;
-   uint16_t copy_nb = vq->batch_copy_nb_elems;
-   int error = 0;
-
-   desc = &descs[desc_idx];
-   desc_chunck_len = desc->len;
-   desc_gaddr = desc->addr;
-   desc_addr = vhost_iova_to_vva(dev, vq, desc_gaddr,
-   &desc_chunck_len, VHOST_ACCESS_RW);
-   /*
-* Checking of 'desc_addr' placed outside of 'unlikely' macro to avoid
-* performance issue with some versions of gcc (4.8.4 and 5.3.0) which
-* otherwise stores offset on the stack instead of in a register.
-*/
-   if (unlikely(desc->len < dev->vhost_hlen) || !desc_addr) {
-   error = -1;
-   goto out;
-   }
-
-   rte_prefetch0((void *)(uintptr_t)desc_addr);
-
-   if (likely(desc_chunck_len >= dev->vhost_hlen)) {
-   virtio_enqueue_offload(m,
-   (struct virtio_net_hdr *)(uintptr_t)desc_addr);
-   PRINT_PACKET(dev, (uintptr_t)desc_addr, dev->vhost_hlen, 0);
-   vhost_log_cache_write(dev, vq, desc_gaddr, dev->vhost_hlen);
-   } else {
-   struct virtio_net_hdr vnet_hdr;
-   uint64_t remain = dev->vhost_hlen;
-   uint64_t len;
-   uint64_t src = (uint64_t)(uintptr_t)&vnet_hdr, dst;
-   uint64_t guest_addr = desc_gaddr;
-
-   virtio_enqueue_offload(m, &vnet_hdr);
-
-   while (remain) {
-   len = remain;
-   dst = vhost_iova_to_vva(dev, vq, guest_addr,
-   &len, VHOST_ACCESS_RW);
-   if (unlikely(!dst || !len)) {
-   error = -1;
-   goto out;
-   }
-
-   rte_memcpy((void *)(uintptr_t)dst,
-   (void *)(uintptr_t)src, len);
-
-   PRINT_PACKET(dev, (uintptr_t)dst, (uint32_t)len, 0);
-   vhost_log_cache_write(dev, vq, guest_addr, len);
-   remain -= len;
-   guest_addr += len;
-   src += len;
-   }
-   }
-
-   desc_avail  = desc->len - dev->vhost_hlen;
-   if (unlikely(desc_chunck_len < dev->vhost_hlen)) {
-   desc_chunck_len = desc_avail;
-   desc_gaddr = desc->addr + dev->vhost_hlen;
-   desc_addr = vhost_iova_to_vva(dev,
-   vq, desc_gaddr,
-   &desc_chunck_len,
-   VHOST_ACCESS_RW);
-   if (unlikely(!desc_addr)) {
-   error = -1;
-   goto out;
-   }
-
-   desc_offset = 0;
-   } else {
-   desc_offset = dev->vhost_hlen;
-   desc_chunck_len -= dev->vhost_hlen;
-   }
-
-   mbuf_avail  = rte_pktmbuf_data_len(m);
-   mbuf_offset = 0;
-   while (mbuf_avail != 0 || m->next != NULL) {
-   /* done with current mbuf, fetch next */
-   if (mbuf_avail == 0) {
-   m = m->next;
-
-   

Re: [dpdk-dev] [PATCH 1/2] doc: add port representor update in release notes

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mohammad Abdul Awal
> Sent: Monday, May 28, 2018 5:12 PM
> To: dev@dpdk.org
> Cc: Awal, Mohammad Abdul 
> Subject: [dpdk-dev] [PATCH 1/2] doc: add port representor update in
> release notes
> 
> Signed-off-by: Mohammad Abdul Awal 

Acked-by: John McNamara 

Re: [dpdk-dev] [PATCH 2/2] doc: add vxlan and nvgre tunnel update in release notes

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mohammad Abdul Awal
> Sent: Monday, May 28, 2018 5:12 PM
> To: dev@dpdk.org
> Cc: Awal, Mohammad Abdul 
> Subject: [dpdk-dev] [PATCH 2/2] doc: add vxlan and nvgre tunnel update in
> release notes
> 
> Signed-off-by: Mohammad Abdul Awal 

Acked-by: John McNamara 

Re: [dpdk-dev] [PATCH v3] doc: add known issue of rte abort on FreeBSD

[Mcnamara, John]

> -Original Message-
> From: Pattan, Reshma
> Sent: Monday, May 28, 2018 4:40 PM
> To: dev@dpdk.org
> Cc: Burakov, Anatoly ; Mcnamara, John
> ; Pattan, Reshma 
> Subject: [PATCH v3] doc: add known issue of rte abort on FreeBSD
> 
> Added known issue of rte_abort taking a long time on FreeBSD due to recent
> memory subsystem rework.
> Also, reference Bugzilla entry for keeping most current information in one
> place.
> 
> Signed-off-by: Reshma Pattan 
> Acked-by: Anatoly Burakov 

Acked-by: John McNamara 

Re: [dpdk-dev] [PATCH v6] checkpatches.sh: Add checks for ABI symbol addition

[Neil Horman]

On Mon, May 28, 2018 at 12:01:15AM +0200, Thomas Monjalon wrote:
> 27/05/2018 23:00, Neil Horman:
> > On Sun, May 27, 2018 at 09:34:13PM +0200, Thomas Monjalon wrote:
> > > Hi Neil,
> > > 
> > > Sorry, this patch has been forgotten during the whole release cycle.
> > > 
> > Its ok, though that is frustrating, as we now need to re-familiarize 
> > ourselves
> > with how this patch works.
> 
> I understand and apologize.
> 
No worries.

> > > I see an issue about the dependency on filterdiff.
> > > Is there a way to avoid it?
> > > 
> > I suppose, but to do so would require some awk magic.  Is there any 
> > advantage to
> > having an awk dependency rather than a filterdiff dependency?  filterdiff 
> > is a
> > pretty universal tool.
> 
> filterdiff is not installed on my machine.
> I guess it is the same for a lot of people.
> 
My guess is that awk is only installed on your machine because you needed it for
another script (possibly this one).  Neither is commonly installed by default,
but both are readily available.

> I will check how we can replace it.
> 
No need, I know how I can use awk to replace it, the only question is, do we
need to do it?  I suppose there is an implicit advantage in just using ask, as
we already require it.

All thats needed is an awk program like the following:
awk 'BEGIN {startprint=0;} /.*diff.*map.*/ {startprint=1;} \
/.*diff.*[^map].*/ {startprint=0 /.*/ {if (startprint) {print $0}}'

its basically a state machine that prints every line in a file after hitting the
regex diff.*map (i.e. a map file), and stops when it hits the next diff block
that isn't for a map file.  The above isn't exactly right, but its close.

> [...]
> > Fine, at this point, I don't know when I'll get to this though, its pretty 
> > busy
> > here at the moment.
> 
> This delay is my fault, and I want to help.
> If I find a good solution, do you accept I send a version 7 of this patch?
Sure, if you have the time to take care of it, that would be great, thanks.  And
thank you for asking.  If I find time, I'll take a stab at it as well, but I
think given Red Hats schedule, it will be a few weeks before I'm able.

Best
Neil
> 
> 
> 

Re: [dpdk-dev] [PATCH 1/2] vhost: unify Rx mergeable and non-mergeable paths

[Maxime Coquelin]

On 05/28/2018 06:23 PM, Maxime Coquelin wrote:

@@ -602,7 +297,7 @@ reserve_avail_buf_mergeable(struct virtio_net *dev, struct 
vhost_virtqueue *vq,


Just notice I forgot to remove "mergeable" from the functions names here
and below. I'll fix this in next revision after having collected some
feedback.


  {
uint16_t cur_idx;
uint32_t vec_idx = 0;
-   uint16_t tries = 0;
+   uint16_t max_tries, tries = 0;
  
  	uint16_t head_idx = 0;

uint16_t len = 0;
@@ -610,6 +305,11 @@ reserve_avail_buf_mergeable(struct virtio_net *dev, struct 
vhost_virtqueue *vq,
*num_buffers = 0;
cur_idx  = vq->last_avail_idx;
  
+	if (rxvq_is_mergeable(dev))

+   max_tries = vq->size;
+   else
+   max_tries = 1;
+
while (size > 0) {
if (unlikely(cur_idx == avail_head))
return -1;
@@ -630,7 +330,7 @@ reserve_avail_buf_mergeable(struct virtio_net *dev, struct 
vhost_virtqueue *vq,
 * can't get enough buf, it means something abnormal
 * happened.
 */
-   if (unlikely(tries >= vq->size))
+   if (unlikely(tries > max_tries))
return -1;
}
  
@@ -748,7 +448,9 @@ copy_mbuf_to_desc_mergeable(struct virtio_net *dev, struct vhost_virtqueue *vq,
  
  		if (hdr_addr) {

virtio_enqueue_offload(hdr_mbuf, &hdr->hdr);
-   ASSIGN_UNLESS_EQUAL(hdr->num_buffers, num_buffers);
+   if (rxvq_is_mergeable(dev))
+   ASSIGN_UNLESS_EQUAL(hdr->num_buffers,
+   num_buffers);
  
  			if (unlikely(hdr == &tmp_hdr)) {

uint64_t len;
@@ -923,10 +625,7 @@ rte_vhost_enqueue_burst(int vid, uint16_t queue_id,
return 0;
}
  
-	if (dev->features & (1 << VIRTIO_NET_F_MRG_RXBUF))

-   return virtio_dev_merge_rx(dev, queue_id, pkts, count);
-   else
-   return virtio_dev_rx(dev, queue_id, pkts, count);
+   return virtio_dev_merge_rx(dev, queue_id, pkts, count);
  }
  
  static inline bool

-- 2.14.3

Re: [dpdk-dev] [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU attributes read

[Xu, Rosen]

Hi Mcnamara and Kovacevic,

Could you apply this patch? Thanks a lot.

> -Original Message-
> From: Mcnamara, John
> Sent: Monday, May 28, 2018 23:37
> To: Xu, Rosen ; dev@dpdk.org
> Cc: Burakov, Anatoly ;
> gaetan.ri...@6wind.com; Pei, Yulong ;
> sta...@dpdk.org; Yigit, Ferruh 
> Subject: RE: [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU
> attributes read
> 
> 
> 
> > -Original Message-
> > From: stable [mailto:stable-boun...@dpdk.org]
> > Sent: Monday, May 28, 2018 4:31 PM
> > To: Xu, Rosen ; dev@dpdk.org
> > Cc: Burakov, Anatoly ;
> > gaetan.ri...@6wind.com; Pei, Yulong ;
> > sta...@dpdk.org; Yigit, Ferruh 
> > Subject: Re: [dpdk-stable] [PATCH v2] doc/guides/rel_notes: Add known
> > issue for IOMMU attributes read
> >
> >
> >
> > > -Original Message-
> > > From: Xu, Rosen
> > > Sent: Wednesday, May 16, 2018 8:29 AM
> > > To: dev@dpdk.org
> > > Cc: Burakov, Anatoly ;
> > > gaetan.ri...@6wind.com; Mcnamara, John ;
> > > Xu, Rosen ; Pei, Yulong ;
> > > sta...@dpdk.org
> > > Subject: [PATCH v2] doc/guides/rel_notes: Add known issue for IOMMU
> > > attributes read
> > >
> > > Linux kernel 4.10.0 iommu attribute read error
> > >
> > > Cc: sta...@dpdk.org
> > >
> > > Signed-off-by: Rosen Xu 
> >
> >
> > Could you open an Bugzilla defect for this and add it to the text.
> >
> > Like this patch: http://dpdk.org/dev/patchwork/patch/40475/
> 
> Actually, I changed my mind. This isn't quite the same as the other new,
> known issues, so there is no need to track it in Bugzilla or move it to the
> release note.
> 
> It is okay as is.
> 
> 
> Acked-by: John McNamara 
> 

Re: [dpdk-dev] [PATCH v2 1/2] mk: fix cross build errors

[Gavin Hu]

Hi Bruce,

Thanks for your helpful comment, see my inline comments.

Best Regards,
Gavin

-Original Message-
From: Bruce Richardson 
Sent: Monday, May 28, 2018 9:24 PM
To: Gavin Hu 
Cc: dev@dpdk.org; sta...@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] mk: fix cross build errors

On Mon, May 28, 2018 at 02:53:47AM -0400, Gavin Hu wrote:
> The "-Wimplicit-fallthrough=2" option was introduced into gcc 7.0, it
> was enabled when the cross compiler gcc is greater than 7.0, but for
> the host side buildtools/pmdinfogen, if the native is older than 7.0,
> it should not be enabled.
>
> The fix is to differentiate the host gcc Werror options from the cross gcc.
>
> gcc -Wp,-MD,./.pmdinfogen.o.d.tmp  -W -Wall -Wstrict-prototypes
> -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition
> -Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual
> -Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings
> -Wdeprecated -Werror -Wimplicit-fallthrough=2 -Dbbb -Wno-format-truncation -g
> -I/home/gavin/arm_repo/dpdk/build/include-o pmdinfogen.o -c
> ~/dpdk/buildtools/pmdinfogen/pmdinfogen.c gcc: error:
> unrecognized command line option ‘-Wimplicit-fallthrough=2’
> ~/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'pmdinfogen.o'
> failed make[3]: *** [pmdinfogen.o] Error 1
>
> Fixes: ced3e6f8 ("mk: adjust gcc flags for new gcc 7 warnings")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Gavin Hu 
> Reviewed-by: Honnappa Nagarahalli 
> Reviewed-by: Steve Capper 
> Reviewed-by: Thomas Monjalon 
> ---

Would a simpler solution for this not be to put "-Wno-implicit-fallthrough"
for pmdinfogen? GCC will not give a warning for an unrecognised "-Wno"
flag when compiling, unless there are other errors. This means we can just use 
the flag without bothering with version checks.

 [Gavin Hu] I tried your proposal, added "-Wno-implicit-fallthrough" before $( 
WERROR_FLAGS) in the pmdinfo Makefile.
It took precedence and made following " Wimplicit-fallthrough=2" useless, the 
compilation succeeded.

Is this what you mean?
Note the two options must be in this order, otherwise the compiling error still 
hit.

Another option is totally disable WERROR_FLAGS for pmdinfo, but this is not a 
best way as it includes a lot of other options.

toolchain/gcc/rte.vars.mk:46:WERROR_FLAGS := -W -Wall -Wstrict-prototypes 
-Wmissing-prototypes
toolchain/gcc/rte.vars.mk:47:WERROR_FLAGS += -Wmissing-declarations 
-Wold-style-definition -Wpointer-arith
toolchain/gcc/rte.vars.mk:48:WERROR_FLAGS += -Wcast-align -Wnested-externs 
-Wcast-qual
toolchain/gcc/rte.vars.mk:49:WERROR_FLAGS += -Wformat-nonliteral 
-Wformat-security
toolchain/gcc/rte.vars.mk:50:WERROR_FLAGS += -Wundef -Wwrite-strings 
-Wdeprecated
toolchain/gcc/rte.vars.mk:53:WERROR_FLAGS += -Werror
toolchain/gcc/rte.vars.mk:59:WERROR_FLAGS += -Wno-error=cast-align
toolchain/gcc/rte.vars.mk:67:WERROR_FLAGS += -Wno-missing-field-initializers
toolchain/gcc/rte.vars.mk:71:WERROR_FLAGS += -Wno-uninitialized
toolchain/gcc/rte.vars.mk:85:WERROR_FLAGS += -Wimplicit-fallthrough=2
toolchain/gcc/rte.vars.mk:87:WERROR_FLAGS += -Wno-format-truncation

/Bruce
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

Re: [dpdk-dev] [PATCH v2 2/2] doc: add a guide doc for cross compiling from x86

[Gavin Hu]

-Original Message-
From: Bruce Richardson 
Sent: Monday, May 28, 2018 9:25 PM
To: Gavin Hu 
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 2/2] doc: add a guide doc for cross compiling 
from x86

On Mon, May 28, 2018 at 02:53:48AM -0400, Gavin Hu wrote:
> This is guild for cross compiling for ARM64 from X86 hosts.
>
> Signed-off-by: Gavin Hu 
> Reviewed-by: Steve Capper 
> Reviewed-by: Honnappa Nagarahalli 
> Reviewed-by: Marko Kovacevic 
> Reviewed-by: Jerin Jacob 
> Reviewed-by: Thomas Monjalon 
> Reviewed-by: Bruce Richardson 
> ---
Can you also include details of cross-compiling using meson from the meson 
build text file too?
[Gavin Hu] My pleasure, I will work on it, it will be in a separate patch.

/Bruce
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.

Re: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files

[Hemant Agrawal]

HI John,
> 
> -Original Message-
> From: Kovacevic, Marko [mailto:marko.kovace...@intel.com]
> Sent: Friday, May 25, 2018 9:00 PM
> To: Thomas Monjalon ; Hemant Agrawal 
> ; Yigit, Ferruh 
> Cc: dev@dpdk.org; Mcnamara, John 
> Subject: RE: [dpdk-dev] [PATCH v1] doc: add SPDX Licence to doc files
> 
> >
> >
> > It has been recommended to add SPDX tags to release notes, with a 
> > global copyright on behalf of all contributors, or community.
> >
> > We need a v2 of this patch, thanks.
> >
> >
> 
> Hi Thomas,
> 
> What exactly is the global copyright ?
> 
> [Hemant] We discussed with LF foundation lawyers. It was suggested to 
> use "Copyright 2018 The DPDK Community"


Hi Hemant,

Is that valid? "The DPDK Community" isn't a single, clear entity.

If that is what has been agreed then we are okay with it but I wanted to make 
100% sure.

[Hemant] I got following recommendation from the Linux Foundation legal:
"For files that are e.g. release scripts and documentation, these are typically 
understood to consist of contributions that are copyrighted by their 
contributors. So even if there isn't a notice in the file, it would still 
generally be understood to be subject to its contributors' copyrights and to be 
licensed out under an open source license.

As you suggested, adding copyright and license notices can help clarify these 
specifics for downstream uses. We have recommended as best practices that 
projects add something like "Copyright The _ Project" or "Copyright The 
__ contributors". I think your suggestion of "Copyright The DPDK 
Community" is fine. And yes, I'd recommend including the appropriate license 
notice and/or SPDX identifier in these files as well.
Just to be clear, also, we _don't_ recommend removing pre-existing copyright 
notices unless you are the copyright holder in question. It's generally 
understood that it's fine to add general copyright notices where accurate, but 
only the copyright holder should remove or modify their own notices. "

[Hemant] So, "The DPDK Project" or "The DPDK contributors" or "The DPDK 
community" - anything is fine, we have to use just one of these consistently. 

Regards,
Hemant

[dpdk-dev] [PATCH] rte_ring: clarify preemptable nature of ring algorithm

[Honnappa Nagarahalli]

rte_ring implementation is not preemptable only under certain circumstances.
This clarification is helpful for data plane and control plane communication
using rte_ring.

Signed-off-by: Honnappa Nagarahalli 
Reviewed-by: Gavin Hu 
Reviewed-by: Ola Liljedahl 
---
 lib/librte_ring/rte_ring.h | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
index d3d3f7f..2f9c945 100644
--- a/lib/librte_ring/rte_ring.h
+++ b/lib/librte_ring/rte_ring.h
@@ -26,8 +26,13 @@
  * - Bulk dequeue.
  * - Bulk enqueue.
  *
- * Note: the ring implementation is not preemptable. A lcore must not
- * be interrupted by another task that uses the same ring.
+ * Note: the ring implementation can block threads from completing their
+ * operation under the following circumstances.
+ * A preempted thread can block other threads (operating on the same ring)
+ * from completing their operations, only if those threads are performing
+ * the same ring operation (enqueue/dequeue) as the preempted thread.
+ * In other words, a preempted consumer thread will not block any producer
+ * threads and vice versa.
  *
  */
 
-- 
2.7.4

[dpdk-dev] [PATCH v2] rte_ring: clarify preemptible nature of ring algorithm

[Honnappa Nagarahalli]

rte_ring implementation is not preemptible only under certain
circumstances. This clarification is helpful for data plane and
control plane communication using rte_ring.

Signed-off-by: Honnappa Nagarahalli 
Reviewed-by: Gavin Hu 
Reviewed-by: Ola Liljedahl 
---
v2:
* Fixed checkpatch warnings

 lib/librte_ring/rte_ring.h | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
index d3d3f7f..2f9c945 100644
--- a/lib/librte_ring/rte_ring.h
+++ b/lib/librte_ring/rte_ring.h
@@ -26,8 +26,13 @@
  * - Bulk dequeue.
  * - Bulk enqueue.
  *
- * Note: the ring implementation is not preemptable. A lcore must not
- * be interrupted by another task that uses the same ring.
+ * Note: the ring implementation can block threads from completing their
+ * operation under the following circumstances.
+ * A preempted thread can block other threads (operating on the same ring)
+ * from completing their operations, only if those threads are performing
+ * the same ring operation (enqueue/dequeue) as the preempted thread.
+ * In other words, a preempted consumer thread will not block any producer
+ * threads and vice versa.
  *
  */
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH v2] net/i40e: add a specific API to control the LLDP agent

[Zhang, Helin]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zijie Pan
> Sent: Thursday, May 24, 2018 9:33 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei; Zhang, Qi Z; tho...@monjalon.net; Laurent Hardy
> Subject: [dpdk-dev] [PATCH v2] net/i40e: add a specific API to control the 
> LLDP
> agent
> 
> Add a new API rte_pmd_i40e_set_lldp_cmd to control LLDP agent for i40e.
> It supports the following i40e debug lldp commands:
> - start/stop of the LLDP agent.
> - get local/remote of the LLDP MIB (Management Information Base).
> 
> Signed-off-by: Laurent Hardy 
> Signed-off-by: Zijie Pan 
> Acked-by: Qi Zhang 
Applied to dpdk-next-net-intel, thanks!

/Helin

[dpdk-dev] [PATCH v3 1/2] mk: fix cross build errors

[Gavin Hu]

The "-Wimplicit-fallthrough=2" option was introduced into gcc 7.0, it was
enabled when the cross compiler gcc is greater than 7.0, but for the host
side buildtools/pmdinfogen, if the native is older than 7.0, it should not
be enabled.

The fix is to differentiate the host gcc Werror options from the cross gcc.

gcc -Wp,-MD,./.pmdinfogen.o.d.tmp  -W -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations -Wold-style-definition
-Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual
-Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings -Wdeprecated
-Werror -Wimplicit-fallthrough=2 -Dbbb -Wno-format-truncation -g
-I/home/gavin/arm_repo/dpdk/build/include-o pmdinfogen.o -c
~/dpdk/buildtools/pmdinfogen/pmdinfogen.c gcc: error:
unrecognized command line option ‘-Wimplicit-fallthrough=2’
~/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'pmdinfogen.o'
failed make[3]: *** [pmdinfogen.o] Error 1

Fixes: ced3e6f8 ("mk: adjust gcc flags for new gcc 7 warnings")
Cc: sta...@dpdk.org

Signed-off-by: Gavin Hu 
Reviewed-by: Honnappa Nagarahalli 
Reviewed-by: Steve Capper 
Reviewed-by: Thomas Monjalon 
Reviewed-by: Bruce Richardson 
---
 buildtools/pmdinfogen/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/buildtools/pmdinfogen/Makefile b/buildtools/pmdinfogen/Makefile
index bf07b6f..8ee6427 100644
--- a/buildtools/pmdinfogen/Makefile
+++ b/buildtools/pmdinfogen/Makefile
@@ -41,7 +41,7 @@ HOSTAPP = dpdk-pmdinfogen
 #
 SRCS-y += pmdinfogen.c
 
-HOST_CFLAGS += $(WERROR_FLAGS) -g
+HOST_CFLAGS += -Wno-implicit-fallthrough $(WERROR_FLAGS) -g
 HOST_CFLAGS += -I$(RTE_OUTPUT)/include
 
 include $(RTE_SDK)/mk/rte.hostapp.mk
-- 
2.1.4

[dpdk-dev] [PATCH v3 2/2] doc: add a guide doc for cross compiling from x86

[Gavin Hu]

This is the guide for cross compiling ARM64 DPDK from X86 hosts.

Signed-off-by: Gavin Hu 
Reviewed-by: Steve Capper 
Reviewed-by: Honnappa Nagarahalli 
Reviewed-by: Marko Kovacevic 
Reviewed-by: Jerin Jacob 
Reviewed-by: Thomas Monjalon 
Reviewed-by: Bruce Richardson 
---
 .../linux_gsg/cross_build_dpdk_for_arm64.rst   | 125 +
 doc/guides/linux_gsg/index.rst |   1 +
 2 files changed, 126 insertions(+)
 create mode 100644 doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst

diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst 
b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
new file mode 100644
index 000..b603f6e
--- /dev/null
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -0,0 +1,125 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright(c) 2018 ARM Corporation.
+
+Cross compile DPDK for ARM64
+
+This chapter describes how to cross compile DPDK for ARM64 from x86 build 
hosts.
+
+.. note::
+
+   Whilst it is recommended to natively build DPDK on ARM64 (just
+   like with x86), it is also possible to cross-build DPDK for ARM64. An
+   ARM64 cross compile GNU toolchain is used for this.
+
+Obtain the cross tool chain
+---
+The latest cross compile tool chain can be downloaded from:
+https://releases.linaro.org/components/toolchain/binaries/latest/aarch64-linux-gnu/.
+Following is the step to get the version 7.2.1, latest in this writting.
+
+.. code-block:: console
+
+   wget https://releases.linaro.org/components/toolchain/binaries/latest/
+   aarch64-linux-gnu/gcc-linaro-7.2.1-2017.11-x86_64_aarch64-linux-gnu.tar.xz
+
+Unzip and add into the PATH
+---
+
+.. code-block:: console
+
+   tar -xvf gcc-linaro-7.2.1-2017.11-x86_64_aarch64-linux-gnu.tar.xz
+   export PATH=$PATH:/gcc-linaro-7.2.1-2017.11-x86_64
+   _aarch64-linux-gnu/bin
+
+.. note::
+
+   For the host requirements and other info, refer to the release note section:
+   https://releases.linaro.org/components/toolchain/binaries/latest/
+
+Getting the prerequisite library
+
+
+NUMA is required by most modern machines, not needed for non-NUMA archtectures.
+
+.. note::
+
+   For compiling the NUMA lib, run libtool --version to ensure the libtool 
version >= 2.2,
+   otherwise the compilation will fail with errors.
+
+.. code-block:: console
+
+   git clone https://github.com/numactl/numactl.git
+   cd numactl
+   git checkout v2.0.11 -b v2.0.11
+   ./autogen.sh
+   autoconf -i
+   ./configure --host=x86_64 CC=aarch64-linux-gnu-gcc prefix=
+   make install
+
+The numa header files and lib file is generated in the include and lib folder 
respectively under .
+
+.. _augument_the_cross_toolcain_with_numa_support:
+
+Augument the cross toolchain with NUMA support
+--
+
+.. note::
+
+   This way is optional, an alternative is to use extra CFLAGS and LDFLAGS, 
depicted in :ref:`configure_and_cross_compile_dpdk_build` below.
+
+Copy the NUMA header files to the cross compiler's include directory:
+
+.. code-block:: console
+
+   cp /include/numa*.h 
/gcc-linaro-7.2.1-2017.11
+   -x86_64_aarch64-linux-gnu/bin/../aarch64-linux-gnu/libc/usr/include/
+   cp /lib/libnuma.a 
/gcc-linaro-7.2.1-2017.11
+   -x86_64_aarch64-linux-gnu/lib/gcc/aarch64-linux-gnu/7.2.1/
+
+.. _configure_and_cross_compile_dpdk_build:
+
+Configure and cross compile DPDK Build
+--
+To configure a build, choose one of the target configurations, like 
arm64-dpaa2-linuxapp-gcc and arm64-thunderx-linuxapp-gcc.
+
+.. code-block:: console
+
+   make config T=arm64-armv8a-linuxapp-gcc
+
+To cross-compile, without compiling the kernel modules, use the following 
command:
+
+.. code-block:: console
+
+   make -j CROSS=aarch64-linux-gnu- CONFIG_RTE_KNI_KMOD=n 
CONFIG_RTE_EAL_IGB_UIO=n
+
+To cross-compile, including the kernel modules, the kernel source tree needs 
to be specified by setting
+RTE_KERNELDIR:
+
+.. code-block:: console
+
+   make -j CROSS=aarch64-linux-gnu- RTE_KERNELDIR=
+   CROSS_COMPILE=aarch64-linux-gnu-
+
+To compile for non-NUMA targets, without compiling the kernel modules, use the 
following command:
+
+.. code-block:: console
+
+   make -j CROSS=aarch64-linux-gnu- CONFIG_RTE_KNI_KMOD=n 
CONFIG_RTE_EAL_IGB_UIO=n
+   CONFIG_RTE_LIBRTE_VHOST_NUMA=n CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n
+
+.. note::
+
+   1. EXTRA_CFLAGS and EXTRA_LDFLAGS should be added to include the NUMA 
headers and link the library respectively,
+   if the step :ref:`augument_the_cross_toolcain_with_numa_support` was 
skipped therefore the toolchain was not
+   augumented with NUMA support.
+
+   2. RTE_DEVEL_BUILD has to be disabled, otherwise the numa.h file gets
+   a lot of compiling errors of Werror=cast-qual, Werror=strict-prototypes and 
Werror=old-style-definition.
+   An example is given below:
+
+   .. code-block:: console
+
+  m