[dpdk-dev] [PATCH v3 10/10] MAINTAINERS: add librte_bpf related info

[Konstantin Ananyev]

Signed-off-by: Konstantin Ananyev 
---
 MAINTAINERS | 4 
 1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ed3251da7..db7fec362 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -964,6 +964,10 @@ Latency statistics
 M: Reshma Pattan 
 F: lib/librte_latencystats/
 
+BPF
+M: Konstantin Ananyev 
+F: lib/librte_bpf/
+F: doc/guides/prog_guide/bpf_lib.rst
 
 Test Applications
 -
-- 
2.13.6

Re: [dpdk-dev] [PATCH v2 09/15] ethdev: add encap level to RSS flow API action

[Andrew Rybchenko]

On 04/06/2018 04:25 PM, Adrien Mazarguil wrote:

RSS hash types (ETH_RSS_* macros defined in rte_ethdev.h) describe the
protocol header fields of a packet that must be taken into account while
computing RSS.

When facing encapsulated (e.g. tunneled) packets, there is an ambiguity as
to whether these should apply to inner or outer packets. Applications need
the ability to tell exactly "where" RSS must be performed.

This is addressed by adding encapsulation level information to the RSS flow
action. Its default value is 0 and stands for the usual unspecified
behavior. Other values provide a specific encapsulation level.

Contrary to the change announced by commit 676b605182a5 ("doc: announce
ethdev API change for RSS configuration"), this patch does not affect
struct rte_eth_rss_conf but struct rte_flow_action_rss as the former is not
used anymore by the RSS flow action. ABI impact is therefore limited to
rte_flow.

This breaks ABI compatibility for the following public functions:

- rte_flow_copy()
- rte_flow_create()
- rte_flow_query()
- rte_flow_validate()

Signed-off-by: Adrien Mazarguil 
Cc: Xueming Li 
Cc: Ferruh Yigit 
Cc: Thomas Monjalon 
Cc: Wenzhuo Lu 
Cc: Jingjing Wu 
Cc: Beilei Xing 
Cc: Qi Zhang 
Cc: Konstantin Ananyev 
Cc: Nelio Laranjeiro 
Cc: Yongseok Koh 
Cc: Andrew Rybchenko 
Cc: Pascal Mazon 
---
  app/test-pmd/cmdline_flow.c | 13 
  app/test-pmd/config.c   |  1 +
  doc/guides/prog_guide/rte_flow.rst  | 24 ++
  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  2 ++
  drivers/net/e1000/igb_flow.c|  4 
  drivers/net/e1000/igb_rxtx.c|  2 ++
  drivers/net/i40e/i40e_ethdev.c  |  2 ++
  drivers/net/i40e/i40e_flow.c|  4 
  drivers/net/ixgbe/ixgbe_flow.c  |  4 
  drivers/net/ixgbe/ixgbe_rxtx.c  |  2 ++
  drivers/net/mlx4/mlx4_flow.c|  6 ++
  drivers/net/mlx5/mlx5_flow.c| 11 ++
  drivers/net/sfc/sfc_flow.c  |  3 +++
  drivers/net/tap/tap_flow.c  |  6 +-
  lib/librte_ether/rte_flow.c |  1 +
  lib/librte_ether/rte_flow.h | 26 
  16 files changed, 110 insertions(+), 1 deletion(-)


Generic and sfc parts
Acked-by: Andrew Rybchenko 

Re: [dpdk-dev] [PATCH 3/4] mk: allow kernel artifacts to be located in output directory

[Scott Branden]

On 18-04-06 02:31 PM, Ferruh Yigit wrote:

On 4/6/2018 7:10 PM, Scott Branden wrote:

Hi Ferruh,

Somehow I did not receive your other email so Ajit fowarded it to me.  So I am
responding to it here.

Sorry for the previous confusion:  RTE_KERNELDIR_OUT specifies the location of
the output of the kernel artifacts, not the output of the DPDK build artifacts.

Ahh, this makes more sense now J Thanks.


Here is an example to use RTE_KERNELDIR_OUT:

export ARCH=arm64
export CROSS_COMPILE=~/gcc-linaro-aarch64-linux-gnu/bin/aarch64-linux-gnu-
export CROSS=aarch64-linux-gnu-

export RTE_KERNELDIR_OUT=~/test/linux-out
export RTE_KERNELDIR=~/test/linux
cd $RTE_KERNELDIR
make defconfig O=$RTE_KERNELDIR_OUT
make -j 8 O=$RTE_KERNELDIR_OUT

cd ~/test/dpdk
make config T=arm64-stingray-linuxapp-gcc
make

I guess using "~/test/linux-out" as RTE_KERNELDIR also works (because of
"source" link), but your patch looks more proper way.

Actually, you may be correct.
Perhaps all this requires is a documentation change.
Does any of DPDK build system actually require to know where the kernel 
source directory is?
Or, does DPDK only require to know where the kernel artifacts exist (ie. 
generated headers)


Looking at the documentation it is a little confusing.  Each one 
describes something different.

guides/linux_gsg/build_dpdk.rst
99:    the ``RTE_KERNELDIR`` environment variable should be used to 
point the compilation at a copy of the kernel version to be used on the 
target machine.


guides/prog_guide/dev_kit_build_system.rst
297:*   RTE_KERNELDIR: This variable contains the absolute path to the 
kernel sources that will be used to compile the kernel modules.


build-sdk-quick.txt
24:    RTE_KERNELDIR    linux headers path

In guides/prog_guide/dev_kit_build_system.rst.  If "kernel sources" was 
changed to "linux headers" my change may not be needed.  I'm doing some 
more testing now with RTE_KERNELDIR set to linux-out in other DPDK builds.



There are a few documents for build parameters, can you please update them too:
doc/guides/prog_guide/dev_kit_build_system.rst
doc/guides/linux_gsg/build_dpdk.rst <-- not sure about this one, please check
doc/build-sdk-quick.txt  <-- this is "make help" output



Note:

With this example you will likely hit a few compile errors as latest dpdk has
compile bugs with unused variables/type mismatches in the code.

I didn't get the error, if you observe build error please report or better a
patch to fix is always welcome :)
Yes - we have patches being created for 64-bit build warnings/errors 
that we will submit.



Regards,

  Scott


On 18-04-05 11:58 AM, Ajit Khaparde wrote:

Scott, are you looking at this?

-- Forwarded message --
From: *Ferruh Yigit* mailto:ferruh.yi...@intel.com>>
Date: Tue, Apr 3, 2018 at 7:18 AM
Subject: Re: [PATCH 3/4] mk: allow kernel artifacts to be located in output
directory
To: Scott Branden mailto:scott.bran...@broadcom.com>>, Ajit Khaparde
mailto:ajit.khapa...@broadcom.com>>, dev@dpdk.org



On 3/30/2018 7:23 PM, Scott Branden wrote:

Hi Ferruh,


On 18-03-30 03:35 AM, Ferruh Yigit wrote:

On 3/21/2018 6:06 PM, Ajit Khaparde wrote:

From: Scott Branden 
>

Allow kernel artifacts to be located in output directory specific
by RTE_KERNELDIR_OUT.

How to use this variable, I tried following but kernel modules are still in

same

place:

export RTE_KERNELDIR and RTE_KERNELDIR_OUT and it works fine.
RTE_KERNELDIR already exists in Makefile.  Are you able to override it?

Please help me a little more, can you please list your commands?

Before your patch, what I do:

export RTE_KERNELDIR=~/development/linux/linux
make defconfig
make    <--- After this kernel modules in ./build/kmod/*.ko
make DESTDIR=/tmp/for-scott install

kernel modules are installed into /tmp/for-scott/lib/modules/`uname
-r`/extra/dpdk/*.ko

Here `uname -r` is wrong but your patch is not related this.

I am using RTE_KERNELDIR a lot since I am compiling with various kernel
versions, not seen .ko files goes into source folder, what is your command line?



Or _after_ your patch:
export RTE_KERNELDIR=~/development/linux/linux
export RTE_KERNELDIR_OUT=/tmp/kmod
make defconfig
make    <--- After this kernel modules in ./build/kmod/*.ko

Getting following build error:
/bin/sh: scripts/mod/modpost: No such file or directory
make[7]: *** [.../development/linux/linux/scripts/Makefile.modpost:92:
__modpost] Error 127
make[6]: *** [.../development/linux/linux/Makefile:1558: modules] Error 2
make[5]: *** [Makefile:146: sub-make] Error 2
make[4]: *** [../mk/rte.module.mk:54 : igb_uio.ko]
Error 2

Can you please describe how this variable intended to be used?



- make RTE_KERNELDIR_OUT=/tmp/kmod O=ferruh DESTDIR=/tmp/ferruh
- make RTE_KERNELDIR_OUT=/tmp/kmod O=ferruh DESTDIR=/tmp/ferruh install
- make RTE_KERNELDIR_OUT=/tmp/kmod O=ferruh DESTDIR=/tmp/ferruh modules_install

/tmp/kmod not created.

And what we

Re: [dpdk-dev] [PATCH] net/enic: enable overlay offload for VXLAN and GENEVE

[Hyong Youb Kim]

On Fri, Apr 06, 2018 at 05:15:40PM +0100, Ferruh Yigit wrote:
> On 4/5/2018 12:54 AM, John Daley wrote:
> > From: Hyong Youb Kim 
> > 
> > Recent NIC models support overlay offload. The overlay offload
> > feature enables the following on the NIC.
> > - Rx/Tx checksum offloads for both inner and outer packets.
> > - Rx inner packet type classification.
> > - TSO.
> > - Inner RSS.
> > 
> > TX descriptors do not require any changes, except the header length
> > for TSO. The NIC parses outer/inner packets and performs offloads on
> > them as necessary. The header length for tunneled TSO includes both
> > inner and outer headers.
> > 
> > The NIC actually parses and performs the above for NVGRE as well. DPDK
> > currently has no offload flags for NVGRE, and the hardware has no
> > controls to individually enable tunnel types either. So do nothing for
> > now.
> > 
> > Add a config flag to enable overlay offload by default. To disable it,
> > the user should set it to 'n'.
> > 
> > CONFIG_RTE_LIBRTE_ENIC_ENABLE_OVERLAY_OFFLOAD=y
> > 
> > Also update the enic guide doc.
> > 
> > Signed-off-by: Hyong Youb Kim 
> > Reviewed-by: John Daley 
> > ---
> >  config/common_base  |   1 +
> >  doc/guides/nics/enic.rst|  52 ++
> >  drivers/net/enic/base/vnic_dev.c|  33 
> >  drivers/net/enic/base/vnic_dev.h|   5 +-
> >  drivers/net/enic/base/vnic_devcmd.h |  12 +
> >  drivers/net/enic/base/vnic_wq.h |   1 +
> >  drivers/net/enic/enic.h |   6 +++
> >  drivers/net/enic/enic_ethdev.c  |  21 ++--
> >  drivers/net/enic/enic_main.c|  25 +
> >  drivers/net/enic/enic_res.c |  23 
> >  drivers/net/enic/enic_rxtx.c| 104 
> > 
> >  11 files changed, 241 insertions(+), 42 deletions(-)
> > 
> > diff --git a/config/common_base b/config/common_base
> > index c09c7cf88..964e37b6e 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -205,6 +205,7 @@ CONFIG_RTE_LIBRTE_ENA_COM_DEBUG=n
> >  # Compile burst-oriented Cisco ENIC PMD driver
> >  #
> >  CONFIG_RTE_LIBRTE_ENIC_PMD=y
> > +CONFIG_RTE_LIBRTE_ENIC_ENABLE_OVERLAY_OFFLOAD=y
> 
> Hi John,
> 
> We are trying to reduce config options we have, is overlay offload enabling 
> can
> be done via runtime argument or dedicated offload flag?

Hi,

Would you accept a devarg? We would enable overlay offload by default,
and disable it when the app specifies that devarg. This overlay
offload is a bunch of things under one roof, and it does not play
nicely with DPDK offload flags.

Thanks.
-Hyong

Re: [dpdk-dev] [PATCH] net/bnx2x: convert to new Rx offloads API

[Mody, Rasesh]

> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Thursday, April 05, 2018 6:40 AM
> 
> On 4/1/2018 7:03 AM, Rasesh Mody wrote:
> > From: Harish Patil 
> >
> > Ethdev RX offloads API has changed since:
> > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> >
> > This patch makes use of DEV_RX_OFFLOAD_JUMBO_FRAME offload flag to
> > advertise jumbo frame support.
> >
> > Signed-off-by: Harish Patil 
> > ---
> >  drivers/net/bnx2x/bnx2x_ethdev.c |5 -
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c
> > b/drivers/net/bnx2x/bnx2x_ethdev.c
> > index 483d5a1..fada4bd 100644
> > --- a/drivers/net/bnx2x/bnx2x_ethdev.c
> > +++ b/drivers/net/bnx2x/bnx2x_ethdev.c
> > @@ -140,11 +140,13 @@ struct rte_bnx2x_xstats_name_off {
> > bnx2x_dev_configure(struct rte_eth_dev *dev)  {
> > struct bnx2x_softc *sc = dev->data->dev_private;
> > +   struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
> > +
> > int mp_ncpus = sysconf(_SC_NPROCESSORS_CONF);
> >
> > PMD_INIT_FUNC_TRACE();
> >
> > -   if (dev->data->dev_conf.rxmode.jumbo_frame)
> > +   if (rxmode & DEV_RX_OFFLOAD_JUMBO_FRAME)
> 
> I guess you would mean "rxmode->offloads".
> 
> Isn't this caught by automated build?

You are right, will send a v2 with proper offload check.

I do not think this was caught by automated build.

> 
> > sc->mtu = dev->data->dev_conf.rxmode.max_rx_pkt_len;
> >
> > if (dev->data->nb_tx_queues > dev->data->nb_rx_queues) { @@ -
> 454,6
> > +456,7 @@ struct rte_bnx2x_xstats_name_off {
> > dev_info->max_rx_pktlen  = BNX2X_MAX_RX_PKT_LEN;
> > dev_info->max_mac_addrs  = BNX2X_MAX_MAC_ADDRS;
> > dev_info->speed_capa = ETH_LINK_SPEED_10G |
> ETH_LINK_SPEED_20G;
> > +   dev_info->rx_offload_capa = DEV_RX_OFFLOAD_JUMBO_FRAME;
> >  }
> >
> >  static int
> >

Re: [dpdk-dev] [PATCH v2 07/15] ethdev: flatten RSS configuration in flow API

[Andrew Rybchenko]

On 04/06/2018 04:25 PM, Adrien Mazarguil wrote:

Since its inception, the rte_flow RSS action has been relying in part on
external struct rte_eth_rss_conf for compatibility with the legacy RSS API.
This structure lacks parameters such as the hash algorithm to use, and more
recently, a method to tell which layer RSS should be performed on [1].

Given struct rte_eth_rss_conf will never be flexible enough to represent a
complete RSS configuration (e.g. RETA table), this patch supersedes it by
extending the rte_flow RSS action directly.

A subsequent patch will add a field to use a non-default RSS hash
algorithm. To that end, a field named "types" replaces the field formerly
known as "rss_hf" and standing for "RSS hash functions" as it was
confusing. Actual RSS hash function types are defined by enum
rte_eth_hash_function.
This patch updates all PMDs and example applications accordingly.

It breaks ABI compatibility for the following public functions:

- rte_flow_copy()
- rte_flow_create()
- rte_flow_query()
- rte_flow_validate()

[1] commit 676b605182a5 ("doc: announce ethdev API change for RSS
 configuration")

Signed-off-by: Adrien Mazarguil 
Cc: Xueming Li 
Cc: Ferruh Yigit 
Cc: Thomas Monjalon 
Cc: Wenzhuo Lu 
Cc: Jingjing Wu 
Cc: Beilei Xing 
Cc: Qi Zhang 
Cc: Konstantin Ananyev 
Cc: Nelio Laranjeiro 
Cc: Yongseok Koh 
Cc: Andrew Rybchenko 
Cc: Pascal Mazon 
Cc: Radu Nicolau 
Cc: Akhil Goyal 
---
  app/test-pmd/cmdline_flow.c|  59 +-
  app/test-pmd/config.c  |  39 +++
  doc/guides/prog_guide/rte_flow.rst |  22 ++--
  drivers/net/e1000/e1000_ethdev.h   |  13 ++-
  drivers/net/e1000/igb_ethdev.c |   4 +-
  drivers/net/e1000/igb_flow.c   |  31 ++---
  drivers/net/e1000/igb_rxtx.c   |  51 +++--
  drivers/net/i40e/i40e_ethdev.c |  53 +++--
  drivers/net/i40e/i40e_ethdev.h |  15 ++-
  drivers/net/i40e/i40e_flow.c   |  47 
  drivers/net/ixgbe/ixgbe_ethdev.c   |   4 +-
  drivers/net/ixgbe/ixgbe_ethdev.h   |  13 ++-
  drivers/net/ixgbe/ixgbe_flow.c |  30 ++---
  drivers/net/ixgbe/ixgbe_rxtx.c |  51 +++--
  drivers/net/mlx4/mlx4.c|   2 +-
  drivers/net/mlx4/mlx4_flow.c   |  61 +-
  drivers/net/mlx4/mlx4_flow.h   |   2 +-
  drivers/net/mlx4/mlx4_rxq.c|   2 +-
  drivers/net/mlx4/mlx4_rxtx.h   |   2 +-
  drivers/net/mlx5/mlx5_flow.c   | 193 +++-
  drivers/net/mlx5/mlx5_rxq.c|  22 ++--
  drivers/net/mlx5/mlx5_rxtx.h   |  26 +++--
  drivers/net/sfc/sfc_flow.c |  21 ++--
  drivers/net/tap/tap_flow.c |   8 +-
  examples/ipsec-secgw/ipsec.c   |  10 +-
  lib/librte_ether/rte_flow.c|  39 +++
  lib/librte_ether/rte_flow.h|   6 +-
  27 files changed, 473 insertions(+), 353 deletions(-)


<...>


diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c
index 056405515..1a2c0299c 100644
--- a/drivers/net/sfc/sfc_flow.c
+++ b/drivers/net/sfc/sfc_flow.c
@@ -1234,13 +1234,11 @@ sfc_flow_parse_rss(struct sfc_adapter *sa,
struct sfc_rxq *rxq;
unsigned int rxq_hw_index_min;
unsigned int rxq_hw_index_max;
-   const struct rte_eth_rss_conf *rss_conf = rss->rss_conf;
-   uint64_t rss_hf;
-   uint8_t *rss_key = NULL;
+   const uint8_t *rss_key;
struct sfc_flow_rss *sfc_rss_conf = &flow->rss_conf;
unsigned int i;
  
-	if (rss->num == 0)

+   if (rss->queue_num == 0)
return -EINVAL;
  
  	rxq_sw_index = sa->rxq_count - 1;

@@ -1248,7 +1246,7 @@ sfc_flow_parse_rss(struct sfc_adapter *sa,
rxq_hw_index_min = rxq->hw_index;
rxq_hw_index_max = 0;
  
-	for (i = 0; i < rss->num; ++i) {

+   for (i = 0; i < rss->queue_num; ++i) {
rxq_sw_index = rss->queue[i];
  
  		if (rxq_sw_index >= sa->rxq_count)

@@ -1263,15 +1261,14 @@ sfc_flow_parse_rss(struct sfc_adapter *sa,
rxq_hw_index_max = rxq->hw_index;
}
  
-	rss_hf = (rss_conf != NULL) ? rss_conf->rss_hf : SFC_RSS_OFFLOADS;


Here we had a fallback to default rss_hf (now types) if rss_conf is 
unspecified.



-   if ((rss_hf & ~SFC_RSS_OFFLOADS) != 0)
+   if ((rss->types & ~SFC_RSS_OFFLOADS) != 0)
return -EINVAL;
  
-	if (rss_conf != NULL) {

-   if (rss_conf->rss_key_len != sizeof(sa->rss_key))
+   if (rss->key_len) {
+   if (rss->key_len != sizeof(sa->rss_key))
return -EINVAL;
  
-		rss_key = rss_conf->rss_key;

+   rss_key = rss->key;
} else {
rss_key = sa->rss_key;
}
@@ -1280,11 +1277,11 @@ sfc_flow_parse_rss(struct sfc_adapter *sa,
  
  	sfc_rss_conf->rxq_hw_index_min = rxq_hw_index_min;

sfc_rss_conf->rxq_hw_index_max = rxq_hw_index_max;
-   sfc_rss_conf->rss_hash_types = sfc_rte_to_efx_hash_type(rss_hf);
+   sfc_rss_conf->rss_hash_types = sfc_rte_to_efx_hash_type(rss->types);


Now types go direc

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: add error types to flow API

[Andrew Rybchenko]

On 04/06/2018 04:25 PM, Adrien Mazarguil wrote:

These enable more precise reporting of objects responsible for errors.

This breaks ABI compatibility for the following public functions:

- rte_flow_create()
- rte_flow_destroy()
- rte_flow_error_set()
- rte_flow_flush()
- rte_flow_isolate()
- rte_flow_query()
- rte_flow_validate()

Signed-off-by: Adrien Mazarguil 
---
  app/test-pmd/config.c   |  4 
  lib/librte_ether/rte_ethdev_version.map | 20 +---
  lib/librte_ether/rte_flow.h |  4 
  3 files changed, 21 insertions(+), 7 deletions(-)


I think PMD maintainers with flow API support should be additionally
notified and encouraged to refine error reporting.

Re: [dpdk-dev] [PATCH v2 02/15] ethdev: clarify flow API pattern items and actions

[Andrew Rybchenko]

On 04/06/2018 04:25 PM, Adrien Mazarguil wrote:

Although pattern items and actions examples end with "and so on", these
lists include all existing definitions and as a result are updated almost
every time new types are added. This is cumbersome and pointless.

This patch also synchronizes Doxygen and external API documentation wording
with a slight clarification regarding meta pattern items.

No fundamental API change.

Signed-off-by: Adrien Mazarguil 
---
  doc/guides/prog_guide/rte_flow.rst | 23 +++
  lib/librte_ether/rte_flow.h| 23 ++-
  2 files changed, 21 insertions(+), 25 deletions(-)


Acked-by: Andrew Rybchenko 

Re: [dpdk-dev] [PATCH v5 1/4] app/eventdev: add event timer adapter as a producer

[Jerin Jacob]

-Original Message-
> Date: Fri,  6 Apr 2018 20:43:21 +0530
> From: Pavan Nikhilesh 
> To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com,
>  erik.g.carri...@intel.com
> Cc: dev@dpdk.org, Pavan Nikhilesh 
> Subject: [dpdk-dev] [PATCH v5 1/4] app/eventdev: add event timer adapter as
>  a producer
> X-Mailer: git-send-email 2.17.0
> 
> Add event timer adapter as producer option that can be selected by
> passing --prod_type_timerdev.
> 
> Signed-off-by: Pavan Nikhilesh 
> Acked-by: Erik Gabriel Carrillo 
> Acked-by: Jerin Jacob 

Applied this series to dpdk-next-eventdev/master. Thanks.

Re: [dpdk-dev] [PATCH v2 04/15] ethdev: remove DUP action from flow API

[Andrew Rybchenko]

On 04/06/2018 04:25 PM, Adrien Mazarguil wrote:

Upcoming changes in relation to the handling of actions list will make the
DUP action redundant as specifying several QUEUE actions will achieve the
same behavior. Besides, no PMD implements this action.

By removing an entry from enum rte_flow_action_type, this patch breaks ABI
compatibility for the following public functions:

- rte_flow_copy()
- rte_flow_create()
- rte_flow_query()
- rte_flow_validate()

Signed-off-by: Adrien Mazarguil 
---
  app/test-pmd/cmdline_flow.c | 23 ---
  app/test-pmd/config.c   |  1 -
  doc/guides/prog_guide/rte_flow.rst  | 23 ---
  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  8 
  lib/librte_ether/rte_ethdev_version.map |  2 +-
  lib/librte_ether/rte_flow.c |  1 -
  lib/librte_ether/rte_flow.h | 24 
  7 files changed, 1 insertion(+), 81 deletions(-)


Acked-by: Andrew Rybchenko 

Re: [dpdk-dev] [PATCH v2 01/15] ethdev: add error types to flow API

[Andrew Rybchenko]

On 04/07/2018 12:15 PM, Andrew Rybchenko wrote:

On 04/06/2018 04:25 PM, Adrien Mazarguil wrote:

These enable more precise reporting of objects responsible for errors.

This breaks ABI compatibility for the following public functions:

- rte_flow_create()
- rte_flow_destroy()
- rte_flow_error_set()
- rte_flow_flush()
- rte_flow_isolate()
- rte_flow_query()
- rte_flow_validate()

Signed-off-by: Adrien Mazarguil 
---
  app/test-pmd/config.c   |  4 
  lib/librte_ether/rte_ethdev_version.map | 20 +---
  lib/librte_ether/rte_flow.h |  4 
  3 files changed, 21 insertions(+), 7 deletions(-)


I think PMD maintainers with flow API support should be additionally
notified and encouraged to refine error reporting.


Acked-by: Andrew Rybchenko 

Re: [dpdk-dev] [PATCH v2 03/15] doc: remove flow API migration section

[Andrew Rybchenko]

On 04/06/2018 04:25 PM, Adrien Mazarguil wrote:

This section has become less relevant since the flow API (rte_flow) is now
a mature DPDK API with applications developed directly on top of it instead
of an afterthought.

This patch removes it for the following reasons:

- It has never been updated to track the latest changes in the legacy
   filter types and never will.

- Many provided examples are theoretical and misleading since PMDs do not
   implement them. Others are obvious.

- Upcoming work on the flow API will alter the behavior of several pattern
   items, actions and in some cases, flow rules, which will in turn cause
   existing examples to be wrong.

Signed-off-by: Adrien Mazarguil 
---
  doc/guides/prog_guide/rte_flow.rst | 298 
  1 file changed, 298 deletions(-)


Acked-by: Andrew Rybchenko 

Re: [dpdk-dev] [PATCH v2 12/15] ethdev: update behavior of VF/PF in flow API

[Andrew Rybchenko]

On 04/06/2018 04:25 PM, Adrien Mazarguil wrote:

Contrary to all other pattern items, these are inconsistently documented as
affecting traffic instead of simply matching its origin, without provision
for the latter.

This commit clarifies documentation and updates PMDs since the original
behavior now has to be explicitly requested using the new transfer
attribute.

It breaks ABI compatibility for the following public functions:

- rte_flow_create()
- rte_flow_validate()

Impacted PMDs are bnxt and i40e, for which the VF pattern item is now only
supported when a transfer attribute is also present.

Signed-off-by: Adrien Mazarguil 
Cc: Ajit Khaparde 
Cc: Somnath Kotur 
Cc: Beilei Xing 
Cc: Qi Zhang 
---
  app/test-pmd/cmdline_flow.c | 12 +++---
  doc/guides/prog_guide/rte_flow.rst  | 36 +-
  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +++---
  drivers/net/bnxt/bnxt_filter.c  | 22 ++-
  drivers/net/i40e/i40e_flow.c| 23 +++-
  lib/librte_ether/rte_flow.h | 47 ++--
  6 files changed, 77 insertions(+), 75 deletions(-)


<...>


diff --git a/doc/guides/prog_guide/rte_flow.rst 
b/doc/guides/prog_guide/rte_flow.rst
index 735ce6323..beedc713b 100644
--- a/doc/guides/prog_guide/rte_flow.rst
+++ b/doc/guides/prog_guide/rte_flow.rst
@@ -518,15 +518,12 @@ Usage example, matching non-TCPv4 packets only:
  Item: ``PF``
  
  
-Matches packets addressed to the physical function of the device.

+Matches traffic originating from (ingress) or going to (egress) the physical
+function of the current device.


Not sure that I understand above. It looks like ingress and egress are 
misplaced.

There many similar cases below.

<...>

Re: [dpdk-dev] [PATCH v2 14/15] ethdev: add physical port action to flow API

[Andrew Rybchenko]

On 04/06/2018 04:25 PM, Adrien Mazarguil wrote:

This patch adds the missing action counterpart to the PHY_PORT pattern
item, that is, the ability to directly inject matching traffic into a
physical port of the underlying device.


Does it mean that if it is applied on ingress (incoming packet from network)
it will simply send packets back to network (specified physical port)?
And if it is applied on egress (outgoing from device to network) it will
be directed to possibly different physical port and sent to network.


It breaks ABI compatibility for the following public functions:

- rte_flow_copy()
- rte_flow_create()
- rte_flow_query()
- rte_flow_validate()

Signed-off-by: Adrien Mazarguil 
Cc: "Zhang, Qi Z" 
---
  app/test-pmd/cmdline_flow.c | 35 
  app/test-pmd/config.c   |  1 +
  doc/guides/prog_guide/rte_flow.rst  | 20 ++
  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  5 
  lib/librte_ether/rte_flow.c |  1 +
  lib/librte_ether/rte_flow.h | 22 +++
  6 files changed, 84 insertions(+)


<...>

[dpdk-dev] [PATCH v2 3/9] bus/fslmc: keep Tx queues information for DPCI devices too

[Nipun Gupta]

The DPCI devices have oth Tx and Rx queues. Event devices use
DPCI Rx queues only, but CMDIF (AIOP) uses both Tx and Rx queues.
This patch enables Tx queues configuration too.

Signed-off-by: Nipun Gupta 
---
 drivers/bus/fslmc/portal/dpaa2_hw_dpci.c | 57 +---
 drivers/bus/fslmc/portal/dpaa2_hw_pvt.h  |  3 +-
 drivers/event/dpaa2/dpaa2_eventdev.c | 10 +++---
 3 files changed, 52 insertions(+), 18 deletions(-)

diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c 
b/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c
index aee870a..3bf7e7f 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpci.c
@@ -39,6 +39,7 @@
struct dpci_attr attr;
struct dpci_rx_queue_cfg rx_queue_cfg;
struct dpci_rx_queue_attr rx_attr;
+   struct dpci_tx_queue_attr tx_attr;
int ret, i;
 
/* Allocate DPAA2 dpci handle */
@@ -67,17 +68,38 @@
return -1;
}
 
-   /* Set up the Rx Queue */
-   memset(&rx_queue_cfg, 0, sizeof(struct dpci_rx_queue_cfg));
-   ret = dpci_set_rx_queue(&dpci_node->dpci,
-   CMD_PRI_LOW,
-   dpci_node->token,
-   0, &rx_queue_cfg);
-   if (ret) {
-   DPAA2_BUS_ERR("Setting Rx queue failed with err code: %d",
- ret);
-   rte_free(dpci_node);
-   return -1;
+   for (i = 0; i < DPAA2_DPCI_MAX_QUEUES; i++) {
+   struct dpaa2_queue *rxq;
+
+   memset(&rx_queue_cfg, 0, sizeof(struct dpci_rx_queue_cfg));
+   ret = dpci_set_rx_queue(&dpci_node->dpci,
+   CMD_PRI_LOW,
+   dpci_node->token,
+   i, &rx_queue_cfg);
+   if (ret) {
+   DPAA2_BUS_ERR("Setting Rx queue failed with err code: 
%d",
+ ret);
+   rte_free(dpci_node);
+   return -1;
+   }
+
+   /* Allocate DQ storage for the DPCI Rx queues */
+   rxq = &(dpci_node->rx_queue[i]);
+   rxq->q_storage = rte_malloc("dq_storage",
+   sizeof(struct queue_storage_info_t),
+   RTE_CACHE_LINE_SIZE);
+   if (!rxq->q_storage) {
+   DPAA2_BUS_ERR("q_storage allocation failed\n");
+   rte_free(dpci_node);
+   return -ENOMEM;
+   }
+
+   memset(rxq->q_storage, 0, sizeof(struct queue_storage_info_t));
+   if (dpaa2_alloc_dq_storage(rxq->q_storage)) {
+   DPAA2_BUS_ERR("dpaa2_alloc_dq_storage failed\n");
+   rte_free(dpci_node);
+   return -ENOMEM;
+   }
}
 
/* Enable the device */
@@ -101,8 +123,19 @@
rte_free(dpci_node);
return -1;
}
+   dpci_node->rx_queue[i].fqid = rx_attr.fqid;
 
-   dpci_node->queue[i].fqid = rx_attr.fqid;
+   ret = dpci_get_tx_queue(&dpci_node->dpci,
+   CMD_PRI_LOW,
+   dpci_node->token, i,
+   &tx_attr);
+   if (ret != 0) {
+   DPAA2_BUS_ERR("Reading device failed with err code:"
+ " %d",ret);
+   rte_free(dpci_node);
+   return -1;
+   }
+   dpci_node->tx_queue[i].fqid = tx_attr.fqid;
}
 
dpci_node->dpci_id = dpci_id;
diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h 
b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
index 4a19d42..bdc33ea 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
@@ -142,7 +142,8 @@ struct dpaa2_dpci_dev {
uint16_t token;
rte_atomic16_t in_use;
uint32_t dpci_id; /*HW ID for DPCI object */
-   struct dpaa2_queue queue[DPAA2_DPCI_MAX_QUEUES];
+   struct dpaa2_queue rx_queue[DPAA2_DPCI_MAX_QUEUES];
+   struct dpaa2_queue tx_queue[DPAA2_DPCI_MAX_QUEUES];
 };
 
 /*! Global MCP list */
diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c 
b/drivers/event/dpaa2/dpaa2_eventdev.c
index 9d9c8d3..d91254c 100644
--- a/drivers/event/dpaa2/dpaa2_eventdev.c
+++ b/drivers/event/dpaa2/dpaa2_eventdev.c
@@ -87,10 +87,10 @@
const struct rte_event *event = &ev[num_tx + loop];
 
if (event->sched_type != RTE_SCHED_TYPE_ATOMIC)
-   fqid = evq_info->dpci->queue[
+   fqid = evq_info->dpci->rx_queue[
DPAA2_EVENT_DPCI_PARALLEL_QUEUE].fqid;
  

[dpdk-dev] [PATCH v2 4/9] bus/fslmc: add preprocessors to get flc and frc from fd

[Nipun Gupta]

This patch also fixes the typecasting in iova/virt conversion
macros

Fixes: df0011c92312 ("bus/fslmc: add physical-virtual address translation 
helpers")
Cc: sta...@dpdk.org

Signed-off-by: Nipun Gupta 
---
 drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h 
b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
index bdc33ea..1ef9502 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
@@ -189,7 +189,7 @@ enum qbman_fd_format {
((fd)->simple.frc = (0x8000 | (len)))
 #define DPAA2_GET_FD_FRC_PARSE_SUM(fd) \
((uint16_t)(((fd)->simple.frc & 0x) >> 16))
-#define DPAA2_SET_FD_FRC(fd, frc)  ((fd)->simple.frc = frc)
+#define DPAA2_SET_FD_FRC(fd, _frc) ((fd)->simple.frc = _frc)
 #define DPAA2_RESET_FD_CTRL(fd) ((fd)->simple.ctrl = 0)
 
 #defineDPAA2_SET_FD_ASAL(fd, asal) ((fd)->simple.ctrl |= (asal << 
16))
@@ -225,6 +225,9 @@ enum qbman_fd_format {
 #define DPAA2_GET_FD_BPID(fd)  (((fd)->simple.bpid_offset & 0x3FFF))
 #define DPAA2_GET_FD_IVP(fd)   (((fd)->simple.bpid_offset & 0x4000) >> 14)
 #define DPAA2_GET_FD_OFFSET(fd)(((fd)->simple.bpid_offset & 
0x0FFF) >> 16)
+#define DPAA2_GET_FD_FRC(fd)   ((fd)->simple.frc)
+#define DPAA2_GET_FD_FLC(fd) \
+   (((uint64_t)((fd)->simple.flc_hi) << 32) + (fd)->simple.flc_lo)
 #define DPAA2_GET_FLE_OFFSET(fle) (((fle)->fin_bpid_offset & 0x0FFF) >> 16)
 #define DPAA2_SET_FLE_SG_EXT(fle) ((fle)->fin_bpid_offset |= (uint64_t)1 << 29)
 #define DPAA2_IS_SET_FLE_SG_EXT(fle)   \
@@ -328,8 +331,8 @@ static phys_addr_t dpaa2_mem_vtop(uint64_t vaddr)
 
 #define DPAA2_MBUF_VADDR_TO_IOVA(mbuf) ((mbuf)->buf_addr)
 #define DPAA2_OP_VADDR_TO_IOVA(op) (op)
-#define DPAA2_VADDR_TO_IOVA(_vaddr) (_vaddr)
-#define DPAA2_IOVA_TO_VADDR(_iova) (_iova)
+#define DPAA2_VADDR_TO_IOVA(_vaddr) ((phys_addr_t)(_vaddr))
+#define DPAA2_IOVA_TO_VADDR(_iova) ((void *)(_iova))
 #define DPAA2_MODIFY_IOVA_TO_VADDR(_mem, _type)
 
 #endif /* RTE_LIBRTE_DPAA2_USE_PHYS_IOVA */
-- 
1.9.1

[dpdk-dev] [PATCH v2 5/9] raw/dpaa2_cmdif: introduce DPAA2 command interface driver

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 MAINTAINERS|   8 ++
 config/common_base |   1 +
 config/common_linuxapp |   1 +
 drivers/raw/Makefile   |   3 +
 drivers/raw/dpaa2_cmdif/Makefile   |  33 +
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c  | 139 +
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h |  35 ++
 .../dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map|   4 +
 mk/rte.app.mk  |   1 +
 9 files changed, 225 insertions(+)
 create mode 100644 drivers/raw/dpaa2_cmdif/Makefile
 create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
 create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h
 create mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map

diff --git a/MAINTAINERS b/MAINTAINERS
index ed3251d..e97da7f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -726,6 +726,14 @@ F: doc/guides/cryptodevs/zuc.rst
 F: doc/guides/cryptodevs/features/zuc.ini
 
 
+Rawdev Drivers
+--
+
+DPAA2 CMDIF
+M: Nipun Gupta 
+F: drivers/raw/dpaa2_cmdif/
+
+
 Eventdev Drivers
 
 M: Jerin Jacob 
diff --git a/config/common_base b/config/common_base
index c09c7cf..9c4361f 100644
--- a/config/common_base
+++ b/config/common_base
@@ -191,6 +191,7 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y
 #
 CONFIG_RTE_LIBRTE_DPAA2_PMD=n
 CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n
+CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF=n
 
 #
 # Compile burst-oriented Amazon ENA PMD driver
diff --git a/config/common_linuxapp b/config/common_linuxapp
index d0437e5..f25b3ea 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -37,3 +37,4 @@ CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y
 CONFIG_RTE_LIBRTE_DPAA2_PMD=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y
+CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF=y
diff --git a/drivers/raw/Makefile b/drivers/raw/Makefile
index da7c8b4..de3e662 100644
--- a/drivers/raw/Makefile
+++ b/drivers/raw/Makefile
@@ -5,5 +5,8 @@ include $(RTE_SDK)/mk/rte.vars.mk
 
 # DIRS-$() += 
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) += skeleton_rawdev
+ifeq ($(CONFIG_RTE_EAL_VFIO)$(CONFIG_RTE_LIBRTE_FSLMC_BUS),yy)
+DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF) += dpaa2_cmdif
+endif
 
 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/drivers/raw/dpaa2_cmdif/Makefile b/drivers/raw/dpaa2_cmdif/Makefile
new file mode 100644
index 000..1d91d0c
--- /dev/null
+++ b/drivers/raw/dpaa2_cmdif/Makefile
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2018 NXP
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+#
+# library name
+#
+LIB = librte_pmd_dpaa2_cmdif.a
+
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+CFLAGS += -O3
+CFLAGS += $(WERROR_FLAGS)
+
+CFLAGS += -I$(RTE_SDK)/drivers/bus/fslmc
+CFLAGS += -I$(RTE_SDK)/drivers/bus/fslmc/qbman/include
+
+LDLIBS += -lrte_bus_fslmc
+LDLIBS += -lrte_eal
+LDLIBS += -lrte_rawdev
+LDLIBS += -lrte_bus_vdev
+LDLIBS += -lrte_kvargs
+
+EXPORT_MAP := rte_pmd_dpaa2_cmdif_version.map
+
+LIBABIVER := 1
+
+#
+# all source are stored in SRCS-y
+#
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF) += dpaa2_cmdif.c
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c 
b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
new file mode 100644
index 000..0d98d36
--- /dev/null
+++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
@@ -0,0 +1,139 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2018 NXP
+ */
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+#include 
+#include 
+#include "rte_pmd_dpaa2_cmdif.h"
+#include "dpaa2_cmdif_logs.h"
+
+/* Dynamic log type identifier */
+int dpaa2_cmdif_logtype;
+
+/* CMDIF driver name */
+#define DPAA2_CMDIF_PMD_NAME dpaa2_dpci
+
+/* CMDIF driver object */
+static struct rte_vdev_driver dpaa2_cmdif_drv;
+
+static const struct rte_rawdev_ops dpaa2_cmdif_ops = {
+};
+
+static int
+dpaa2_cmdif_create(const char *name,
+  struct rte_vdev_device *vdev,
+  int socket_id)
+{
+   struct rte_rawdev *rawdev;
+   struct dpaa2_dpci_dev *cidev;
+
+   /* Allocate device structure */
+   rawdev = rte_rawdev_pmd_allocate(name, sizeof(struct dpaa2_dpci_dev),
+socket_id);
+   if (!rawdev) {
+   DPAA2_CMDIF_ERR("Unable to allocate rawdevice");
+   return -EINVAL;
+   }
+
+   rawdev->dev_ops = &dpaa2_cmdif_ops;
+   rawdev->device = &vdev->device;
+   rawdev->driver_name = vdev->device.driver->name;
+
+   /* For secondary processes, the primary has done all the work */
+   if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+   return 0;
+
+   cidev = rte_dpaa2_alloc_dpci_dev();
+   if (!cidev) {
+   DPAA2_CMDIF_ERR("Unable to allocate CI device");
+   rte_rawdev_pmd_release(rawdev

[dpdk-dev] [PATCH v2 7/9] raw/dpaa2_cmdif: support enqueue dequeue operations

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 doc/api/doxy-api-index.md |   1 +
 doc/api/doxy-api.conf |   1 +
 drivers/raw/dpaa2_cmdif/Makefile  |   2 +
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 136 ++
 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h |  35 +++
 5 files changed, 175 insertions(+)
 create mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h

diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
index 49fcec4..b9f28be 100644
--- a/doc/api/doxy-api-index.md
+++ b/doc/api/doxy-api-index.md
@@ -64,6 +64,7 @@ The public API headers are grouped by topics:
   [bnxt]   (@ref rte_pmd_bnxt.h),
   [dpaa]   (@ref rte_pmd_dpaa.h),
   [dpaa2]  (@ref rte_dpaa2_mempool.h),
+  [dpaa2_cmdif](@ref rte_pmd_dpaa2_cmdif.h),
   [crypto_scheduler]   (@ref rte_cryptodev_scheduler.h)
 
 - **memory**:
diff --git a/doc/api/doxy-api.conf b/doc/api/doxy-api.conf
index 59cb580..88088d6 100644
--- a/doc/api/doxy-api.conf
+++ b/doc/api/doxy-api.conf
@@ -38,6 +38,7 @@ INPUT   = doc/api/doxy-api-index.md \
   drivers/net/i40e \
   drivers/net/ixgbe \
   drivers/net/softnic \
+  drivers/raw/dpaa2_cmdif \
   lib/librte_eal/common/include \
   lib/librte_eal/common/include/generic \
   lib/librte_acl \
diff --git a/drivers/raw/dpaa2_cmdif/Makefile b/drivers/raw/dpaa2_cmdif/Makefile
index 1d91d0c..c570827 100644
--- a/drivers/raw/dpaa2_cmdif/Makefile
+++ b/drivers/raw/dpaa2_cmdif/Makefile
@@ -30,4 +30,6 @@ LIBABIVER := 1
 #
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF) += dpaa2_cmdif.c
 
+SYMLINK-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF)-include += rte_pmd_dpaa2_cmdif.h
+
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c 
b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
index 9044489..c26fc30 100644
--- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
+++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
@@ -53,8 +53,144 @@
return 0;
 }
 
+static int
+dpaa2_cmdif_enqueue_bufs(struct rte_rawdev *dev,
+struct rte_rawdev_buf **buffers,
+unsigned int count,
+rte_rawdev_obj_t context)
+{
+   struct dpaa2_dpci_dev *cidev = dev->dev_private;
+   struct rte_dpaa2_cmdif_context *cmdif_send_cnxt;
+   struct dpaa2_queue *txq;
+   struct qbman_fd fd;
+   struct qbman_eq_desc eqdesc;
+   struct qbman_swp *swp;
+   int ret;
+
+   DPAA2_CMDIF_FUNC_TRACE();
+
+   RTE_SET_USED(count);
+
+   if (unlikely(!DPAA2_PER_LCORE_DPIO)) {
+   ret = dpaa2_affine_qbman_swp();
+   if (ret) {
+   DPAA2_CMDIF_ERR("Failure in affining portal\n");
+   return 0;
+   }
+   }
+   swp = DPAA2_PER_LCORE_PORTAL;
+
+   cmdif_send_cnxt = (struct rte_dpaa2_cmdif_context *)(context);
+   txq = &(cidev->tx_queue[cmdif_send_cnxt->priority]);
+
+   /* Prepare enqueue descriptor */
+   qbman_eq_desc_clear(&eqdesc);
+   qbman_eq_desc_set_fq(&eqdesc, txq->fqid);
+   qbman_eq_desc_set_no_orp(&eqdesc, 0);
+   qbman_eq_desc_set_response(&eqdesc, 0, 0);
+
+   /* Set some of the FD parameters to i.
+* For performance reasons do not memset
+*/
+   fd.simple.bpid_offset = 0;
+   fd.simple.ctrl = 0;
+
+   DPAA2_SET_FD_ADDR(&fd, DPAA2_VADDR_TO_IOVA(buffers[0]->buf_addr));
+   DPAA2_SET_FD_LEN(&fd, cmdif_send_cnxt->size);
+   DPAA2_SET_FD_FRC(&fd, cmdif_send_cnxt->frc);
+   DPAA2_SET_FD_FLC(&fd, cmdif_send_cnxt->flc);
+
+   /* Enqueue a packet to the QBMAN */
+   do {
+   ret = qbman_swp_enqueue_multiple(swp, &eqdesc, &fd, NULL, 1);
+   if (ret < 0 && ret != -EBUSY)
+   DPAA2_CMDIF_ERR("Transmit failure with err: %d\n", ret);
+   } while (ret == -EBUSY);
+
+   DPAA2_CMDIF_DEBUG("Successfully transmitted a packet\n");
+
+   return 0;
+}
+
+static int
+dpaa2_cmdif_dequeue_bufs(struct rte_rawdev *dev,
+struct rte_rawdev_buf **buffers,
+unsigned int count,
+rte_rawdev_obj_t context)
+{
+   struct dpaa2_dpci_dev *cidev = dev->dev_private;
+   struct rte_dpaa2_cmdif_context *cmdif_rcv_cnxt;
+   struct dpaa2_queue *rxq;
+   struct qbman_swp *swp;
+   struct qbman_result *dq_storage;
+   const struct qbman_fd *fd;
+   struct qbman_pull_desc pulldesc;
+   uint8_t status;
+   int ret;
+
+   DPAA2_CMDIF_FUNC_TRACE();
+
+   RTE_SET_USED(count);
+
+   if (unlikely(!DPAA2_PER_LCORE_DPIO)) {
+   ret = dpaa2_affine_qbman_swp();
+   if (ret) {
+   DPAA2_CMDIF_ERR("Failure in affining portal\n");

[dpdk-dev] [PATCH v2 6/9] raw/dpaa2_cmdif: add attribute get functionality

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 25 +
 1 file changed, 25 insertions(+)

diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c 
b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
index 0d98d36..9044489 100644
--- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
+++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
@@ -29,7 +29,32 @@
 /* CMDIF driver object */
 static struct rte_vdev_driver dpaa2_cmdif_drv;
 
+/*
+ * This API provides the DPCI device ID in 'attr_value'.
+ * The device ID shall be passed by GPP to the AIOP using CMDIF commands.
+ */
+static int
+dpaa2_cmdif_get_attr(struct rte_rawdev *dev,
+const char *attr_name,
+uint64_t *attr_value)
+{
+   struct dpaa2_dpci_dev *cidev = dev->dev_private;
+
+   DPAA2_CMDIF_FUNC_TRACE();
+
+   RTE_SET_USED(attr_name);
+
+   if (!attr_value) {
+   DPAA2_CMDIF_ERR("Invalid arguments for getting attributes");
+   return -EINVAL;
+   }
+   *attr_value = cidev->dpci_id;
+
+   return 0;
+}
+
 static const struct rte_rawdev_ops dpaa2_cmdif_ops = {
+   .attr_get = dpaa2_cmdif_get_attr,
 };
 
 static int
-- 
1.9.1

Re: [dpdk-dev] [PATCH v2 0/9] Introduce DPAA2 Command Interface raw driver

[Nipun Gupta]

Forgot to mention - This patch series is rebased on top of series 
https://dpdk.org/dev/patchwork/patch/37246/


> -Original Message-
> From: Nipun Gupta
> Sent: Saturday, April 07, 2018 20:04
> To: tho...@monjalon.net; Hemant Agrawal ;
> Shreyansh Jain 
> Cc: dev@dpdk.org; Nipun Gupta 
> Subject: [PATCH v2 0/9] Introduce DPAA2 Command Interface raw driver
> 
> This patch set introduces DPAA2 based Command Interface
> device driver.
> 
> This driver is provides communication between the GPP and
> AIOP Firmware.
> 
> Patches 1-4:
>   Makes necessary changes and fixes in the DPAA2 bus and
>   mempool region
> Patches 5-7:
>   Add the DPAA2 CMDIF driver
> Patches 8-9:
>   Update the respective documentation
> 
> Changes in v2:
>   - Move CMDIF compilation to common_linuxapp
>   - Support physical addressing mode
> 
> Nipun Gupta (9):
>   mempool/dpaa2: add functions exposed to DPDK applications
>   bus/fslmc: expose API to free dpci device
>   bus/fslmc: keep Tx queues information for DPCI devices too
>   bus/fslmc: add preprocessors to get flc and frc from fd
>   raw/dpaa2_cmdif: introduce DPAA2 command interface driver
>   raw/dpaa2_cmdif: add attribute get functionality
>   raw/dpaa2_cmdif: support enqueue dequeue operations
>   doc: add DPAA2 CMDIF rawdev guide
>   doc: add dpaa2 command interface rawdev to release notes
> 
>  MAINTAINERS|   9 +
>  config/common_base |   1 +
>  config/common_linuxapp |   1 +
>  doc/api/doxy-api-index.md  |   2 +
>  doc/api/doxy-api.conf  |   2 +
>  doc/guides/rawdevs/dpaa2_cmdif.rst | 132 +
>  doc/guides/rel_notes/release_18_05.rst |   7 +
>  drivers/bus/fslmc/portal/dpaa2_hw_dpci.c   |  57 +++-
>  drivers/bus/fslmc/portal/dpaa2_hw_pvt.h|  12 +-
>  drivers/bus/fslmc/rte_bus_fslmc_version.map|   1 +
>  drivers/event/dpaa2/dpaa2_eventdev.c   |  10 +-
>  drivers/mempool/dpaa2/Makefile |   2 +
>  drivers/mempool/dpaa2/dpaa2_hw_mempool.c   |  30 +++
>  drivers/mempool/dpaa2/rte_dpaa2_mempool.h  |  53 
>  .../mempool/dpaa2/rte_mempool_dpaa2_version.map|   8 +
>  drivers/raw/Makefile   |   3 +
>  drivers/raw/dpaa2_cmdif/Makefile   |  35 +++
>  drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c  | 300
> +
>  drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h |  35 +++
>  drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h  |  35 +++
>  .../dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map|   4 +
>  mk/rte.app.mk  |   1 +
>  22 files changed, 719 insertions(+), 21 deletions(-)
>  create mode 100644 doc/guides/rawdevs/dpaa2_cmdif.rst
>  create mode 100644 drivers/mempool/dpaa2/rte_dpaa2_mempool.h
>  create mode 100644 drivers/raw/dpaa2_cmdif/Makefile
>  create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
>  create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h
>  create mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h
>  create mode 100644
> drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map
> 
> --
> 1.9.1

[dpdk-dev] [PATCH v2 9/9] doc: add dpaa2 command interface rawdev to release notes

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 doc/guides/rel_notes/release_18_05.rst | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index e5fac1c..0aebb18 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -58,6 +58,13 @@ New Features
   * Added support for NVGRE, VXLAN and GENEVE filters in flow API.
   * Added support for DROP action in flow API.
 
+* **Added DPAA2 Command Interface Driver (in rawdev).**
+
+  The DPAA2 CMDIF is an implementation of the rawdev API, that provides
+  communication between the GPP and AIOP (Firmware). This is achieved
+  via using the DPCI devices exposed by MC for GPP <--> AIOP interaction.
+
+  See the :doc:`../rawdevs/dpaa2_cmdif.rst` guide for more details.
 
 API Changes
 ---
-- 
1.9.1

[dpdk-dev] [PATCH 1/8] bus/fslmc: support MC DPDMAI object

[Nipun Gupta]

This patch adds the DPDMAI (Data Path DMA Interface)
object support in MC driver.

Signed-off-by: Cristian Sovaiala 
Signed-off-by: Nipun Gupta 
---
 drivers/bus/fslmc/Makefile  |   3 +-
 drivers/bus/fslmc/mc/dpdmai.c   | 429 
 drivers/bus/fslmc/mc/fsl_dpdmai.h   | 189 
 drivers/bus/fslmc/mc/fsl_dpdmai_cmd.h   | 107 +++
 drivers/bus/fslmc/rte_bus_fslmc_version.map |   9 +
 5 files changed, 736 insertions(+), 1 deletion(-)
 create mode 100644 drivers/bus/fslmc/mc/dpdmai.c
 create mode 100644 drivers/bus/fslmc/mc/fsl_dpdmai.h
 create mode 100644 drivers/bus/fslmc/mc/fsl_dpdmai_cmd.h

diff --git a/drivers/bus/fslmc/Makefile b/drivers/bus/fslmc/Makefile
index 93870ba..072a23a 100644
--- a/drivers/bus/fslmc/Makefile
+++ b/drivers/bus/fslmc/Makefile
@@ -37,7 +37,8 @@ SRCS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += \
 mc/dpio.c \
 mc/mc_sys.c \
mc/dpcon.c \
-   mc/dpci.c
+   mc/dpci.c \
+   mc/dpdmai.c
 
 SRCS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += portal/dpaa2_hw_dpio.c
 SRCS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += portal/dpaa2_hw_dpbp.c
diff --git a/drivers/bus/fslmc/mc/dpdmai.c b/drivers/bus/fslmc/mc/dpdmai.c
new file mode 100644
index 000..03ce2a7
--- /dev/null
+++ b/drivers/bus/fslmc/mc/dpdmai.c
@@ -0,0 +1,429 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2013-2016 Freescale Semiconductor Inc.
+ */
+
+#include 
+#include 
+#include 
+#include 
+
+/**
+ * dpdmai_open() - Open a control session for the specified object
+ * @mc_io: Pointer to MC portal's I/O object
+ * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
+ * @dpdmai_id: DPDMAI unique ID
+ * @token: Returned token; use in subsequent API calls
+ *
+ * This function can be used to open a control session for an
+ * already created object; an object may have been declared in
+ * the DPL or by calling the dpdmai_create() function.
+ * This function returns a unique authentication token,
+ * associated with the specific object ID and the specific MC
+ * portal; this token must be used in all subsequent commands for
+ * this specific object.
+ *
+ * Return: '0' on Success; Error code otherwise.
+ */
+int dpdmai_open(struct fsl_mc_io *mc_io,
+   uint32_t cmd_flags,
+   int dpdmai_id,
+   uint16_t *token)
+{
+   struct dpdmai_cmd_open *cmd_params;
+   struct mc_command cmd = { 0 };
+   int err;
+
+   /* prepare command */
+   cmd.header = mc_encode_cmd_header(DPDMAI_CMDID_OPEN,
+ cmd_flags,
+ 0);
+   cmd_params = (struct dpdmai_cmd_open *)cmd.params;
+   cmd_params->dpdmai_id = cpu_to_le32(dpdmai_id);
+
+   /* send command to mc*/
+   err = mc_send_command(mc_io, &cmd);
+   if (err)
+   return err;
+
+   /* retrieve response parameters */
+   *token = mc_cmd_hdr_read_token(&cmd);
+
+   return 0;
+}
+
+/**
+ * dpdmai_close() - Close the control session of the object
+ * @mc_io: Pointer to MC portal's I/O object
+ * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
+ * @token: Token of DPDMAI object
+ *
+ * After this function is called, no further operations are
+ * allowed on the object without opening a new control session.
+ *
+ * Return: '0' on Success; Error code otherwise.
+ */
+int dpdmai_close(struct fsl_mc_io *mc_io,
+uint32_t cmd_flags,
+uint16_t token)
+{
+   struct mc_command cmd = { 0 };
+
+   /* prepare command */
+   cmd.header = mc_encode_cmd_header(DPDMAI_CMDID_CLOSE,
+ cmd_flags, token);
+
+   /* send command to mc*/
+   return mc_send_command(mc_io, &cmd);
+}
+
+/**
+ * dpdmai_create() - Create the DPDMAI object
+ * @mc_io: Pointer to MC portal's I/O object
+ * @dprc_token:Parent container token; '0' for default container
+ * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
+ * @cfg:   Configuration structure
+ * @obj_id:Returned object id
+ *
+ * Create the DPDMAI object, allocate required resources and
+ * perform required initialization.
+ *
+ * The object can be created either by declaring it in the
+ * DPL file, or by calling this function.
+ *
+ * The function accepts an authentication token of a parent
+ * container that this object should be assigned to. The token
+ * can be '0' so the object will be assigned to the default container.
+ * The newly created object can be opened with the returned
+ * object id and using the container's associated tokens and MC portals.
+ *
+ * Return: '0' on Success; Error code otherwise.
+ */
+int dpdmai_create(struct fsl_mc_io *mc_io,
+ uint16_t dprc_token,
+ uint32_t cmd_flags,
+ const struct dpdmai_cfg *cfg,
+ uint32_t *obj_id)
+{
+   struct dpdmai_cmd_create *cmd_params;
+  

[dpdk-dev] [PATCH v2 8/9] doc: add DPAA2 CMDIF rawdev guide

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 MAINTAINERS|   1 +
 doc/guides/rawdevs/dpaa2_cmdif.rst | 132 +
 2 files changed, 133 insertions(+)
 create mode 100644 doc/guides/rawdevs/dpaa2_cmdif.rst

diff --git a/MAINTAINERS b/MAINTAINERS
index e97da7f..9ef5902 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -732,6 +732,7 @@ Rawdev Drivers
 DPAA2 CMDIF
 M: Nipun Gupta 
 F: drivers/raw/dpaa2_cmdif/
+F: doc/guides/rawdevs/dpaa2_cmdif.rst
 
 
 Eventdev Drivers
diff --git a/doc/guides/rawdevs/dpaa2_cmdif.rst 
b/doc/guides/rawdevs/dpaa2_cmdif.rst
new file mode 100644
index 000..b0aec2a
--- /dev/null
+++ b/doc/guides/rawdevs/dpaa2_cmdif.rst
@@ -0,0 +1,132 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright 2018 NXP
+
+NXP DPAA2 CMDIF Driver
+==
+
+The DPAA2 CMDIF is an implementation of the rawdev API, that provides
+communication between the GPP and AIOP (Firmware). This is achieved
+via using the DPCI devices exposed by MC for GPP <--> AIOP interaction.
+
+More information can be found at `NXP Official Website
+`_.
+
+Features
+
+
+The DPAA2 CMDIF implements following features in the rawdev API;
+
+- Getting the object ID of the device (DPCI) using attributes
+- I/O to and from the AIOP device using DPCI
+
+Supported DPAA2 SoCs
+
+
+- LS2084A/LS2044A
+- LS2088A/LS2048A
+- LS1088A/LS1048A
+
+Prerequisites
+-
+
+There are three main pre-requisities for executing DPAA2 CMDIF on a DPAA2
+compatible board:
+
+1. **ARM 64 Tool Chain**
+
+   For example, the `*aarch64* Linaro Toolchain 
`_.
+
+2. **Linux Kernel**
+
+   It can be obtained from `NXP's Github hosting 
`_.
+
+3. **Rootfile system**
+
+   Any *aarch64* supporting filesystem can be used. For example,
+   Ubuntu 15.10 (Wily) or 16.04 LTS (Xenial) userland which can be obtained
+   from `here 
`_.
+
+As an alternative method, DPAA2 CMDIF can also be executed using images 
provided
+as part of SDK from NXP. The SDK includes all the above prerequisites necessary
+to bring up a DPAA2 board.
+
+The following dependencies are not part of DPDK and must be installed
+separately:
+
+- **NXP Linux SDK**
+
+  NXP Linux software development kit (SDK) includes support for family
+  of QorIQ® ARM-Architecture-based system on chip (SoC) processors
+  and corresponding boards.
+
+  It includes the Linux board support packages (BSPs) for NXP SoCs,
+  a fully operational tool chain, kernel and board specific modules.
+
+  SDK and related information can be obtained from:  `NXP QorIQ SDK  
`_.
+
+- **DPDK Extra Scripts**
+
+  DPAA2 based resources can be configured easily with the help of ready scripts
+  as provided in the DPDK Extra repository.
+
+  `DPDK Extras Scripts `_.
+
+Currently supported by DPDK:
+
+- NXP SDK **2.0+**.
+- MC Firmware version **10.0.0** and higher.
+- Supported architectures:  **arm64 LE**.
+
+- Follow the DPDK :ref:`Getting Started Guide for Linux ` to setup 
the basic DPDK environment.
+
+.. note::
+
+   Some part of fslmc bus code (mc flib - object library) routines are
+   dual licensed (BSD & GPLv2).
+
+Pre-Installation Configuration
+--
+
+Config File Options
+~~~
+
+The following options can be modified in the ``config`` file.
+
+- ``CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF`` (default ``y``)
+
+  Toggle compilation of the ``lrte_pmd_dpaa2_cmdif`` driver.
+
+Driver Compilation
+~~
+
+To compile the DPAA2 CMDIF PMD for Linux arm64 gcc target, run the
+following ``make`` command:
+
+.. code-block:: console
+
+   cd 
+   make config T=arm64-dpaa2-linuxapp-gcc install
+
+Initialization
+--
+
+The DPAA2 CMDIF is exposed as a vdev device which consists of dpci devices.
+On EAL initialization, dpci devices will be probed and then vdev device
+can be created from the application code by
+
+* Invoking ``rte_vdev_init("dpaa2_dpci")`` from the application
+
+* Using ``--vdev="dpaa2_dpci"`` in the EAL options, which will call
+  rte_vdev_init() internally
+
+Example:
+
+.. code-block:: console
+
+./your_cmdif_application --vdev="dpaa2_dpci"
+
+Platform Requirement
+
+
+DPAA2 drivers for DPDK can only work on NXP SoCs as listed in the
+``Supported DPAA2 SoCs``.
-- 
1.9.1

[dpdk-dev] [PATCH 0/8] Introduce DPAA2 QDMA raw driver

[Nipun Gupta]

This patch set introduces DPAA2 based QDMA device driver.

It provide means to initiate a DMA transaction from CPU.
The initiated DMA is performed without CPU being involved
in the actual DMA transaction.

This patch series is based over v2 of DPAA2 CMDIF series -
https://dpdk.org/dev/patchwork/patch/35337/

Patches 1-3:
  Makes necessary changes in the DPAA2 bus
Patches 4-6:
  Add the DPAA2 QDMA driver
Patches 7-8:
  Update the respective documentation

Nipun Gupta (8):
  bus/fslmc: support MC DPDMAI object
  bus/fslmc: support scanning and probing of QDMA devices
  bus/fslmc: add macros required by QDMA for FLE and FD
  raw/dpaa2_qdma: introduce the DPAA2 QDMA driver
  raw/dpaa2_qdma: support configuration APIs
  raw/dpaa2_qdma: support enq and deq operations
  doc: add DPAA2 QDMA rawdev guide
  doc: add dpaa2 qdma rawdev to release notes

 MAINTAINERS|   6 +
 config/common_base |   1 +
 config/common_linuxapp |   1 +
 doc/api/doxy-api-index.md  |   1 +
 doc/api/doxy-api.conf  |   1 +
 doc/guides/rawdevs/dpaa2_qdma.rst  | 140 +++
 doc/guides/rel_notes/release_18_05.rst |   9 +
 drivers/bus/fslmc/Makefile |   3 +-
 drivers/bus/fslmc/fslmc_bus.c  |   2 +
 drivers/bus/fslmc/fslmc_vfio.c |   1 +
 drivers/bus/fslmc/mc/dpdmai.c  | 429 +
 drivers/bus/fslmc/mc/fsl_dpdmai.h  | 189 
 drivers/bus/fslmc/mc/fsl_dpdmai_cmd.h  | 107 +++
 drivers/bus/fslmc/portal/dpaa2_hw_pvt.h|   3 +
 drivers/bus/fslmc/rte_bus_fslmc_version.map|   9 +
 drivers/bus/fslmc/rte_fslmc.h  |   2 +
 drivers/raw/Makefile   |   1 +
 drivers/raw/dpaa2_qdma/Makefile|  36 +
 drivers/raw/dpaa2_qdma/dpaa2_qdma.c| 997 +
 drivers/raw/dpaa2_qdma/dpaa2_qdma.h| 150 
 drivers/raw/dpaa2_qdma/dpaa2_qdma_logs.h   |  33 +
 drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h| 286 ++
 .../raw/dpaa2_qdma/rte_pmd_dpaa2_qdma_version.map  |  20 +
 mk/rte.app.mk  |   1 +
 24 files changed, 2427 insertions(+), 1 deletion(-)
 create mode 100644 doc/guides/rawdevs/dpaa2_qdma.rst
 create mode 100644 drivers/bus/fslmc/mc/dpdmai.c
 create mode 100644 drivers/bus/fslmc/mc/fsl_dpdmai.h
 create mode 100644 drivers/bus/fslmc/mc/fsl_dpdmai_cmd.h
 create mode 100644 drivers/raw/dpaa2_qdma/Makefile
 create mode 100644 drivers/raw/dpaa2_qdma/dpaa2_qdma.c
 create mode 100644 drivers/raw/dpaa2_qdma/dpaa2_qdma.h
 create mode 100644 drivers/raw/dpaa2_qdma/dpaa2_qdma_logs.h
 create mode 100644 drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h
 create mode 100644 drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma_version.map

-- 
1.9.1

[dpdk-dev] [PATCH 2/8] bus/fslmc: support scanning and probing of QDMA devices

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 drivers/bus/fslmc/fslmc_bus.c  | 2 ++
 drivers/bus/fslmc/fslmc_vfio.c | 1 +
 drivers/bus/fslmc/rte_fslmc.h  | 2 ++
 3 files changed, 5 insertions(+)

diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index d6806df..cd27630 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -164,6 +164,8 @@
dev->dev_type = DPAA2_CI;
else if (!strncmp("dpmcp", t_ptr, 5))
dev->dev_type = DPAA2_MPORTAL;
+   else if (!strncmp("dpdmai", t_ptr, 6))
+   dev->dev_type = DPAA2_QDMA;
else
dev->dev_type = DPAA2_UNKNOWN;
 
diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c
index 62499de..6708ad8 100644
--- a/drivers/bus/fslmc/fslmc_vfio.c
+++ b/drivers/bus/fslmc/fslmc_vfio.c
@@ -554,6 +554,7 @@ int rte_dpaa2_intr_disable(struct rte_intr_handle 
*intr_handle, int index)
switch (dev->dev_type) {
case DPAA2_ETH:
case DPAA2_CRYPTO:
+   case DPAA2_QDMA:
ret = fslmc_process_iodevices(dev);
if (ret) {
DPAA2_BUS_DEBUG("Dev (%s) init failed",
diff --git a/drivers/bus/fslmc/rte_fslmc.h b/drivers/bus/fslmc/rte_fslmc.h
index 69d0fec..a454ef5 100644
--- a/drivers/bus/fslmc/rte_fslmc.h
+++ b/drivers/bus/fslmc/rte_fslmc.h
@@ -61,6 +61,7 @@ enum rte_dpaa2_dev_type {
DPAA2_IO,   /**< DPIO type device */
DPAA2_CI,   /**< DPCI type device */
DPAA2_MPORTAL,  /**< DPMCP type device */
+   DPAA2_QDMA, /**< DPDMAI type device */
/* Unknown device placeholder */
DPAA2_UNKNOWN,
DPAA2_DEVTYPE_MAX,
@@ -91,6 +92,7 @@ struct rte_dpaa2_device {
union {
struct rte_eth_dev *eth_dev;/**< ethernet device */
struct rte_cryptodev *cryptodev;/**< Crypto Device */
+   struct rte_rawdev *rawdev;  /**< DPAA2 raw Device */
};
enum rte_dpaa2_dev_type dev_type;   /**< Device Type */
uint16_t object_id; /**< DPAA2 Object ID */
-- 
1.9.1

[dpdk-dev] [PATCH 4/8] raw/dpaa2_qdma: introduce the DPAA2 QDMA driver

[Nipun Gupta]

DPAA2 QDMA driver uses MC DPDMAI object. This driver enables
the user (app) to perform data DMA without involving CPU in
the DMA process

Signed-off-by: Nipun Gupta 
---
 MAINTAINERS|   5 +
 config/common_base |   1 +
 config/common_linuxapp |   1 +
 drivers/raw/Makefile   |   1 +
 drivers/raw/dpaa2_qdma/Makefile|  34 +++
 drivers/raw/dpaa2_qdma/dpaa2_qdma.c| 290 +
 drivers/raw/dpaa2_qdma/dpaa2_qdma.h|  66 +
 drivers/raw/dpaa2_qdma/dpaa2_qdma_logs.h   |  33 +++
 .../raw/dpaa2_qdma/rte_pmd_dpaa2_qdma_version.map  |   4 +
 mk/rte.app.mk  |   1 +
 10 files changed, 436 insertions(+)
 create mode 100644 drivers/raw/dpaa2_qdma/Makefile
 create mode 100644 drivers/raw/dpaa2_qdma/dpaa2_qdma.c
 create mode 100644 drivers/raw/dpaa2_qdma/dpaa2_qdma.h
 create mode 100644 drivers/raw/dpaa2_qdma/dpaa2_qdma_logs.h
 create mode 100644 drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma_version.map

diff --git a/MAINTAINERS b/MAINTAINERS
index 9ef5902..fccf5bb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -772,6 +772,11 @@ F: drivers/event/opdl/
 F: doc/guides/eventdevs/opdl.rst
 
 
+DPAA2 QDMA
+M: Nipun Gupta 
+F: drivers/raw/dpaa2_qdma/
+
+
 Packet processing
 -
 
diff --git a/config/common_base b/config/common_base
index 9c4361f..956fbc1 100644
--- a/config/common_base
+++ b/config/common_base
@@ -192,6 +192,7 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y
 CONFIG_RTE_LIBRTE_DPAA2_PMD=n
 CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n
 CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF=n
+CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA=n
 
 #
 # Compile burst-oriented Amazon ENA PMD driver
diff --git a/config/common_linuxapp b/config/common_linuxapp
index f25b3ea..0c6a1ce 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -38,3 +38,4 @@ CONFIG_RTE_LIBRTE_DPAA2_PMD=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y
 CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF=y
+CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA=y
diff --git a/drivers/raw/Makefile b/drivers/raw/Makefile
index de3e662..7b5dcc3 100644
--- a/drivers/raw/Makefile
+++ b/drivers/raw/Makefile
@@ -7,6 +7,7 @@ include $(RTE_SDK)/mk/rte.vars.mk
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) += skeleton_rawdev
 ifeq ($(CONFIG_RTE_EAL_VFIO)$(CONFIG_RTE_LIBRTE_FSLMC_BUS),yy)
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF) += dpaa2_cmdif
+DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA) += dpaa2_qdma
 endif
 
 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/drivers/raw/dpaa2_qdma/Makefile b/drivers/raw/dpaa2_qdma/Makefile
new file mode 100644
index 000..f81ee08
--- /dev/null
+++ b/drivers/raw/dpaa2_qdma/Makefile
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright 2018 NXP
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+#
+# library name
+#
+LIB = librte_pmd_dpaa2_qdma.a
+
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+CFLAGS += -O3
+CFLAGS += $(WERROR_FLAGS)
+
+CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal
+CFLAGS += -I$(RTE_SDK)/drivers/bus/fslmc
+CFLAGS += -I$(RTE_SDK)/drivers/bus/fslmc/qbman/include
+
+LDLIBS += -lrte_bus_fslmc
+LDLIBS += -lrte_eal
+LDLIBS += -lrte_mempool
+LDLIBS += -lrte_rawdev
+LDLIBS += -lrte_ring
+
+EXPORT_MAP := rte_pmd_dpaa2_qdma_version.map
+
+LIBABIVER := 1
+
+#
+# all source are stored in SRCS-y
+#
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA) += dpaa2_qdma.c
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c 
b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
new file mode 100644
index 000..4b7fa13
--- /dev/null
+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
@@ -0,0 +1,290 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2018 NXP
+ */
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+
+#include "dpaa2_qdma.h"
+#include "dpaa2_qdma_logs.h"
+
+/* Dynamic log type identifier */
+int dpaa2_qdma_logtype;
+
+/* QDMA device */
+static struct qdma_device qdma_dev;
+
+/* QDMA H/W queues list */
+TAILQ_HEAD(qdma_hw_queue_list, qdma_hw_queue);
+static struct qdma_hw_queue_list qdma_queue_list
+   = TAILQ_HEAD_INITIALIZER(qdma_queue_list);
+
+static const struct rte_rawdev_ops dpaa2_qdma_ops = {
+};
+
+static int
+add_hw_queues_to_list(struct dpaa2_dpdmai_dev *dpdmai_dev)
+{
+   struct qdma_hw_queue *queue;
+   int i;
+
+   DPAA2_QDMA_FUNC_TRACE();
+
+   for (i = 0; i < dpdmai_dev->num_queues; i++) {
+   queue = rte_zmalloc(NULL, sizeof(struct qdma_hw_queue), 0);
+   if (!queue) {
+   DPAA2_QDMA_ERR(
+   "Memory allocation failed for QDMA queue\n");
+   return -ENOMEM;
+   }
+
+   queue->dpdmai_dev = dpdmai_dev;
+   queue->queue_id = i;
+
+   TAILQ_I

[dpdk-dev] [PATCH 7/8] doc: add DPAA2 QDMA rawdev guide

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 MAINTAINERS   |   1 +
 doc/guides/rawdevs/dpaa2_qdma.rst | 140 ++
 2 files changed, 141 insertions(+)
 create mode 100644 doc/guides/rawdevs/dpaa2_qdma.rst

diff --git a/MAINTAINERS b/MAINTAINERS
index fccf5bb..6eb6d98 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -775,6 +775,7 @@ F: doc/guides/eventdevs/opdl.rst
 DPAA2 QDMA
 M: Nipun Gupta 
 F: drivers/raw/dpaa2_qdma/
+F: doc/guides/rawdevs/dpaa2_qdma.rst
 
 
 Packet processing
diff --git a/doc/guides/rawdevs/dpaa2_qdma.rst 
b/doc/guides/rawdevs/dpaa2_qdma.rst
new file mode 100644
index 000..211b716
--- /dev/null
+++ b/doc/guides/rawdevs/dpaa2_qdma.rst
@@ -0,0 +1,140 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+Copyright 2018 NXP
+
+NXP DPAA2 QDMA Driver
+=
+
+The DPAA2 QDMA is an implementation of the rawdev API, that provide means
+to initiate a DMA transaction from CPU. The initiated DMA is performed
+without CPU being involved in the actual DMA transaction. This is achieved
+via using the DPDMAI device exposed by MC.
+
+More information can be found at `NXP Official Website
+`_.
+
+Features
+
+
+The DPAA2 QDMA implements following features in the rawdev API;
+
+- Supports issuing DMA of data within memory without hogging CPU while
+  performing DMA operation.
+- Supports configuring to optionally get status of the DMA translation on
+  per DMA operation basis.
+
+Supported DPAA2 SoCs
+
+
+- LS2084A/LS2044A
+- LS2088A/LS2048A
+- LS1088A/LS1048A
+
+Prerequisites
+-
+
+There are three main pre-requisities for executing DPAA2 QDMA on a DPAA2
+compatible board:
+
+1. **ARM 64 Tool Chain**
+
+   For example, the `*aarch64* Linaro Toolchain 
`_.
+
+2. **Linux Kernel**
+
+   It can be obtained from `NXP's Github hosting 
`_.
+
+3. **Rootfile system**
+
+   Any *aarch64* supporting filesystem can be used. For example,
+   Ubuntu 15.10 (Wily) or 16.04 LTS (Xenial) userland which can be obtained
+   from `here 
`_.
+
+As an alternative method, DPAA2 QDMA can also be executed using images provided
+as part of SDK from NXP. The SDK includes all the above prerequisites necessary
+to bring up a DPAA2 board.
+
+The following dependencies are not part of DPDK and must be installed
+separately:
+
+- **NXP Linux SDK**
+
+  NXP Linux software development kit (SDK) includes support for family
+  of QorIQ® ARM-Architecture-based system on chip (SoC) processors
+  and corresponding boards.
+
+  It includes the Linux board support packages (BSPs) for NXP SoCs,
+  a fully operational tool chain, kernel and board specific modules.
+
+  SDK and related information can be obtained from:  `NXP QorIQ SDK  
`_.
+
+- **DPDK Extra Scripts**
+
+  DPAA2 based resources can be configured easily with the help of ready scripts
+  as provided in the DPDK Extra repository.
+
+  `DPDK Extras Scripts `_.
+
+Currently supported by DPDK:
+
+- NXP SDK **2.0+**.
+- MC Firmware version **10.0.0** and higher.
+- Supported architectures:  **arm64 LE**.
+
+- Follow the DPDK :ref:`Getting Started Guide for Linux ` to setup 
the basic DPDK environment.
+
+.. note::
+
+   Some part of fslmc bus code (mc flib - object library) routines are
+   dual licensed (BSD & GPLv2).
+
+Pre-Installation Configuration
+--
+
+Config File Options
+~~~
+
+The following options can be modified in the ``config`` file.
+
+- ``CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA`` (default ``y``)
+
+  Toggle compilation of the ``lrte_pmd_dpaa2_qdma`` driver.
+
+Enabling logs
+-
+
+For enabling logs, use the following EAL parameter:
+
+.. code-block:: console
+
+   ./your_qdma_application  --log-level=pmd.dpaa2.qdma,
+
+Using ``dpaa2.qdma`` as log matching criteria, all Event PMD logs can be
+enabled which are lower than logging ``level``.
+
+Driver Compilation
+~~
+
+To compile the DPAA2 QDMA PMD for Linux arm64 gcc target, run the
+following ``make`` command:
+
+.. code-block:: console
+
+   cd 
+   make config T=arm64-dpaa2-linuxapp-gcc install
+
+Initialization
+--
+
+The DPAA2 QDMA is exposed as a vdev device which consists of dpdmai devices.
+On EAL initialization, dpdmai devices will be probed and populated into the
+rawdevices. The rawdev ID of the device can be obtained using
+
+* Invoking ``rte_rawdev_get_dev_id("dpdmai.x")`` from the application
+  where x is the object ID of the DPDMAI object creat

[dpdk-dev] [PATCH 5/8] raw/dpaa2_qdma: support configuration APIs

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 doc/api/doxy-api-index.md  |   1 +
 doc/api/doxy-api.conf  |   1 +
 drivers/raw/dpaa2_qdma/Makefile|   2 +
 drivers/raw/dpaa2_qdma/dpaa2_qdma.c| 375 +
 drivers/raw/dpaa2_qdma/dpaa2_qdma.h|  63 
 drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h| 216 
 .../raw/dpaa2_qdma/rte_pmd_dpaa2_qdma_version.map  |  12 +
 7 files changed, 670 insertions(+)
 create mode 100644 drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h

diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
index b9f28be..c0b5653 100644
--- a/doc/api/doxy-api-index.md
+++ b/doc/api/doxy-api-index.md
@@ -65,6 +65,7 @@ The public API headers are grouped by topics:
   [dpaa]   (@ref rte_pmd_dpaa.h),
   [dpaa2]  (@ref rte_dpaa2_mempool.h),
   [dpaa2_cmdif](@ref rte_pmd_dpaa2_cmdif.h),
+  [dpaa2_qdma] (@ref rte_pmd_dpaa2_qdma.h),
   [crypto_scheduler]   (@ref rte_cryptodev_scheduler.h)
 
 - **memory**:
diff --git a/doc/api/doxy-api.conf b/doc/api/doxy-api.conf
index 88088d6..0840b34 100644
--- a/doc/api/doxy-api.conf
+++ b/doc/api/doxy-api.conf
@@ -39,6 +39,7 @@ INPUT   = doc/api/doxy-api-index.md \
   drivers/net/ixgbe \
   drivers/net/softnic \
   drivers/raw/dpaa2_cmdif \
+  drivers/raw/dpaa2_qdma \
   lib/librte_eal/common/include \
   lib/librte_eal/common/include/generic \
   lib/librte_acl \
diff --git a/drivers/raw/dpaa2_qdma/Makefile b/drivers/raw/dpaa2_qdma/Makefile
index f81ee08..6711df3 100644
--- a/drivers/raw/dpaa2_qdma/Makefile
+++ b/drivers/raw/dpaa2_qdma/Makefile
@@ -31,4 +31,6 @@ LIBABIVER := 1
 #
 SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA) += dpaa2_qdma.c
 
+SYMLINK-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA)-include += rte_pmd_dpaa2_qdma.h
+
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c 
b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
index 4b7fa13..b5f6bd9 100644
--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
@@ -20,6 +20,7 @@
 
 #include "dpaa2_qdma.h"
 #include "dpaa2_qdma_logs.h"
+#include "rte_pmd_dpaa2_qdma.h"
 
 /* Dynamic log type identifier */
 int dpaa2_qdma_logtype;
@@ -32,6 +33,380 @@
 static struct qdma_hw_queue_list qdma_queue_list
= TAILQ_HEAD_INITIALIZER(qdma_queue_list);
 
+/* QDMA Virtual Queues */
+struct qdma_virt_queue *qdma_vqs;
+
+/* QDMA per core data */
+struct qdma_per_core_info qdma_core_info[RTE_MAX_LCORE];
+
+static struct qdma_hw_queue *
+alloc_hw_queue(uint32_t lcore_id)
+{
+   struct qdma_hw_queue *queue = NULL;
+
+   DPAA2_QDMA_FUNC_TRACE();
+
+   /* Get a free queue from the list */
+   TAILQ_FOREACH(queue, &qdma_queue_list, next) {
+   if (queue->num_users == 0) {
+   queue->lcore_id = lcore_id;
+   queue->num_users++;
+   break;
+   }
+   }
+
+   return queue;
+}
+
+static void
+free_hw_queue(struct qdma_hw_queue *queue)
+{
+   DPAA2_QDMA_FUNC_TRACE();
+
+   queue->num_users--;
+}
+
+
+static struct qdma_hw_queue *
+get_hw_queue(uint32_t lcore_id)
+{
+   struct qdma_per_core_info *core_info;
+   struct qdma_hw_queue *queue, *temp;
+   uint32_t least_num_users;
+   int num_hw_queues, i;
+
+   DPAA2_QDMA_FUNC_TRACE();
+
+   core_info = &qdma_core_info[lcore_id];
+   num_hw_queues = core_info->num_hw_queues;
+
+   /*
+* Allocate a HW queue if there are less queues
+* than maximum per core queues configured
+*/
+   if (num_hw_queues < qdma_dev.max_hw_queues_per_core) {
+   queue = alloc_hw_queue(lcore_id);
+   if (queue) {
+   core_info->hw_queues[num_hw_queues] = queue;
+   core_info->num_hw_queues++;
+   return queue;
+   }
+   }
+
+   queue = core_info->hw_queues[0];
+   /* In case there is no queue associated with the core return NULL */
+   if (!queue)
+   return NULL;
+
+   /* Fetch the least loaded H/W queue */
+   least_num_users = core_info->hw_queues[0]->num_users;
+   for (i = 0; i < num_hw_queues; i++) {
+   temp = core_info->hw_queues[i];
+   if (temp->num_users < least_num_users)
+   queue = temp;
+   }
+
+   if (queue)
+   queue->num_users++;
+
+   return queue;
+}
+
+static void
+put_hw_queue(struct qdma_hw_queue *queue)
+{
+   struct qdma_per_core_info *core_info;
+   int lcore_id, num_hw_queues, i;
+
+   DPAA2_QDMA_FUNC_TRACE();
+
+   /*
+* If this is the last user of the queue free it.
+* Also remove it from QDMA core 

[dpdk-dev] [PATCH 6/8] raw/dpaa2_qdma: support enq and deq operations

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 drivers/raw/dpaa2_qdma/dpaa2_qdma.c| 332 +
 drivers/raw/dpaa2_qdma/dpaa2_qdma.h|  21 ++
 drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h|  70 +
 .../raw/dpaa2_qdma/rte_pmd_dpaa2_qdma_version.map  |   4 +
 4 files changed, 427 insertions(+)

diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c 
b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
index b5f6bd9..5cd18ec 100644
--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
@@ -344,6 +344,338 @@
return i;
 }
 
+static void
+dpaa2_qdma_populate_fle(struct qbman_fle *fle,
+   uint64_t src, uint64_t dest,
+   size_t len, uint32_t flags)
+{
+   struct qdma_sdd *sdd;
+
+   DPAA2_QDMA_FUNC_TRACE();
+
+   sdd = (struct qdma_sdd *)((uint8_t *)(fle) +
+   (DPAA2_QDMA_MAX_FLE * sizeof(struct qbman_fle)));
+
+   /* first frame list to source descriptor */
+   DPAA2_SET_FLE_ADDR(fle, DPAA2_VADDR_TO_IOVA(sdd));
+   DPAA2_SET_FLE_LEN(fle, (2 * (sizeof(struct qdma_sdd;
+
+   /* source and destination descriptor */
+   DPAA2_SET_SDD_RD_COHERENT(sdd); /* source descriptor CMD */
+   sdd++;
+   DPAA2_SET_SDD_WR_COHERENT(sdd); /* dest descriptor CMD */
+
+   fle++;
+   /* source frame list to source buffer */
+   if (flags & RTE_QDMA_JOB_SRC_PHY) {
+   DPAA2_SET_FLE_ADDR(fle, src);
+   DPAA2_SET_FLE_BMT(fle);
+   } else {
+   DPAA2_SET_FLE_ADDR(fle, DPAA2_VADDR_TO_IOVA(src));
+   }
+   DPAA2_SET_FLE_LEN(fle, len);
+
+   fle++;
+   /* destination frame list to destination buffer */
+   if (flags & RTE_QDMA_JOB_DEST_PHY) {
+   DPAA2_SET_FLE_BMT(fle);
+   DPAA2_SET_FLE_ADDR(fle, dest);
+   } else {
+   DPAA2_SET_FLE_ADDR(fle, DPAA2_VADDR_TO_IOVA(dest));
+   }
+   DPAA2_SET_FLE_LEN(fle, len);
+
+   /* Final bit: 1, for last frame list */
+   DPAA2_SET_FLE_FIN(fle);
+}
+
+static int
+dpdmai_dev_enqueue(struct dpaa2_dpdmai_dev *dpdmai_dev,
+  uint16_t txq_id,
+  uint16_t vq_id,
+  struct rte_qdma_job *job)
+{
+   struct qdma_io_meta *io_meta;
+   struct qbman_fd fd = {};
+   struct dpaa2_queue *txq;
+   struct qbman_fle *fle;
+   struct qbman_eq_desc eqdesc;
+   struct qbman_swp *swp;
+   int ret;
+
+   DPAA2_QDMA_FUNC_TRACE();
+
+   if (unlikely(!DPAA2_PER_LCORE_DPIO)) {
+   ret = dpaa2_affine_qbman_swp();
+   if (ret) {
+   DPAA2_QDMA_ERR("Failure in affining portal\n");
+   return 0;
+   }
+   }
+   swp = DPAA2_PER_LCORE_PORTAL;
+
+   txq = &(dpdmai_dev->tx_queue[txq_id]);
+
+   /* Prepare enqueue descriptor */
+   qbman_eq_desc_clear(&eqdesc);
+   qbman_eq_desc_set_fq(&eqdesc, txq->fqid);
+   qbman_eq_desc_set_no_orp(&eqdesc, 0);
+   qbman_eq_desc_set_response(&eqdesc, 0, 0);
+
+   /*
+* Get an FLE/SDD from FLE pool.
+* Note: IO metadata is before the FLE and SDD memory.
+*/
+   ret = rte_mempool_get(qdma_dev.fle_pool, (void **)(&io_meta));
+   if (ret) {
+   DPAA2_QDMA_ERR("Memory alloc failed for FLE\n");
+   return ret;
+   }
+
+   /* Set the metadata */
+   io_meta->cnxt = (size_t)job;
+   io_meta->id = vq_id;
+
+   fle = (struct qbman_fle *)(io_meta + 1);
+
+   /* populate Frame descriptor */
+   DPAA2_SET_FD_ADDR(&fd, DPAA2_VADDR_TO_IOVA(fle));
+   DPAA2_SET_FD_COMPOUND_FMT(&fd);
+   DPAA2_SET_FD_FRC(&fd, QDMA_SER_CTX);
+
+   /* Populate FLE */
+   memset(fle, 0, QDMA_FLE_POOL_SIZE);
+   dpaa2_qdma_populate_fle(fle, job->src, job->dest, job->len, job->flags);
+
+   /* Enqueue the packet to the QBMAN */
+   do {
+   ret = qbman_swp_enqueue_multiple(swp, &eqdesc, &fd, NULL, 1);
+   if (ret < 0 && ret != -EBUSY)
+   DPAA2_QDMA_ERR("Transmit failure with err: %d\n", ret);
+   } while (ret == -EBUSY);
+
+   DPAA2_QDMA_DEBUG("Successfully transmitted a packet\n");
+
+   return ret;
+}
+
+int
+rte_qdma_vq_enqueue_multi(uint16_t vq_id,
+ struct rte_qdma_job **job,
+ uint16_t nb_jobs)
+{
+   int i, ret;
+
+   DPAA2_QDMA_FUNC_TRACE();
+
+   for (i = 0; i < nb_jobs; i++) {
+   ret = rte_qdma_vq_enqueue(vq_id, job[i]);
+   if (ret < 0)
+   break;
+   }
+
+   return i;
+}
+
+int
+rte_qdma_vq_enqueue(uint16_t vq_id,
+   struct rte_qdma_job *job)
+{
+   struct qdma_virt_queue *qdma_vq = &qdma_vqs[vq_id];
+   struct qdma_hw_queue *qdma_pq = qdma_vq->hw_queue;
+   struct dpaa2_dpdmai_dev *dpdmai_dev = qdma_pq->dpdmai_dev;
+   int ret;
+
+   DPAA2_QDMA_

[dpdk-dev] [PATCH 3/8] bus/fslmc: add macros required by QDMA for FLE and FD

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h 
b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
index 1ef9502..b7b98d1 100644
--- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
+++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h
@@ -212,10 +212,12 @@ enum qbman_fd_format {
 } while (0)
 #define DPAA2_SET_FLE_OFFSET(fle, offset) \
((fle)->fin_bpid_offset |= (uint32_t)(offset) << 16)
+#define DPAA2_SET_FLE_LEN(fle, len)((fle)->length = len)
 #define DPAA2_SET_FLE_BPID(fle, bpid) ((fle)->fin_bpid_offset |= (size_t)bpid)
 #define DPAA2_GET_FLE_BPID(fle) ((fle)->fin_bpid_offset & 0x00ff)
 #define DPAA2_SET_FLE_FIN(fle) ((fle)->fin_bpid_offset |= 1 << 31)
 #define DPAA2_SET_FLE_IVP(fle)   (((fle)->fin_bpid_offset |= 0x4000))
+#define DPAA2_SET_FLE_BMT(fle)   (((fle)->fin_bpid_offset |= 0x8000))
 #define DPAA2_SET_FD_COMPOUND_FMT(fd)  \
((fd)->simple.bpid_offset |= (uint32_t)1 << 28)
 #define DPAA2_GET_FD_ADDR(fd)  \
@@ -225,6 +227,7 @@ enum qbman_fd_format {
 #define DPAA2_GET_FD_BPID(fd)  (((fd)->simple.bpid_offset & 0x3FFF))
 #define DPAA2_GET_FD_IVP(fd)   (((fd)->simple.bpid_offset & 0x4000) >> 14)
 #define DPAA2_GET_FD_OFFSET(fd)(((fd)->simple.bpid_offset & 
0x0FFF) >> 16)
+#define DPAA2_GET_FD_ERR(fd)   ((fd)->simple.bpid_offset & 0x00FF)
 #define DPAA2_GET_FD_FRC(fd)   ((fd)->simple.frc)
 #define DPAA2_GET_FD_FLC(fd) \
(((uint64_t)((fd)->simple.flc_hi) << 32) + (fd)->simple.flc_lo)
-- 
1.9.1

[dpdk-dev] [PATCH] vmxnet3: fill in imissed stat with pktsRxOutOfBuf

[Jon DeVree]

This counter comes from a "hardware" register of the vmxnet3 device and
seems to behave like the MPC (Missed Packet Count) register of the Intel
NICs. So I think this data belongs in the imissed field rather than the
rx_nombuf field.

Signed-off-by: Jon DeVree 
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c 
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 426008722..4ef2d7d3b 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1015,7 +1015,7 @@ vmxnet3_dev_stats_get(struct rte_eth_dev *dev, struct 
rte_eth_stats *stats)
 
stats->q_errors[i] = rxStats.pktsRxError;
stats->ierrors += rxStats.pktsRxError;
-   stats->rx_nombuf += rxStats.pktsRxOutOfBuf;
+   stats->imissed += rxStats.pktsRxOutOfBuf;
}
 
return 0;
-- 
2.17.0

Re: [dpdk-dev] [PATCH v5 2/3] app/testpmd: add command for queue setup

[Rosen, Rami]

-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang
Sent: Monday, April 02, 2018 06:00
To: tho...@monjalon.net; Ananyev, Konstantin 
Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing 
; Lu, Wenzhuo ; Zhang, Qi Z 

Subject: [dpdk-dev] [PATCH v5 2/3] app/testpmd: add command for queue setup

Add new command to setup queue:
queue setup (rx|tx) (port_id) (queue_idx) (ring_size) (offloads)

rte_eth_[rx|tx]_queue_setup will be called corresponsively

Signed-off-by: Qi Zhang 
---
v5:
- fix command description.

v4:
- fix missing offload in command line.

v3:
- add offload parameter to queue setup command.
- couple code refactory.

 app/test-pmd/cmdline.c  | 129 
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |   7 ++
 2 files changed, 136 insertions(+)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 
d1dc1de6c..449c7c634 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -774,6 +774,9 @@ static void cmd_help_long_parsed(void *parsed_result,
"port tm hierarchy commit (port_id) (clean_on_fail)\n"
"   Commit tm hierarchy.\n\n"
 
+   "queue setup (rx|tx) (port_id) (queue_idx) (ring_size) 
(offloads)\n"
+   "   setup a rx or tx queue.\n\n"
+
, list_pkt_forwarding_modes()
);
}
@@ -16030,6 +16033,131 @@ cmdline_parse_inst_t cmd_load_from_file = {
},
 };
 
+/* Queue Setup */
+
+/* Common result structure for queue setup */ struct 
+cmd_queue_setup_result {
+   cmdline_fixed_string_t queue;
+   cmdline_fixed_string_t setup;
+   cmdline_fixed_string_t rxtx;
+   portid_t port_id;
+   uint16_t queue_idx;
+   uint16_t ring_size;
+   uint64_t offloads;
+};
+
+/* Common CLI fields for queue setup */ cmdline_parse_token_string_t 
+cmd_queue_setup_queue =
+   TOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, queue, 
+"queue"); cmdline_parse_token_string_t cmd_queue_setup_setup =
+   TOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, setup, 
+"setup"); cmdline_parse_token_string_t cmd_queue_setup_rxtx =
+   TOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, rxtx, 
+"rx#tx"); cmdline_parse_token_num_t cmd_queue_setup_port_id =
+   TOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, port_id, UINT16); 
+cmdline_parse_token_num_t cmd_queue_setup_queue_idx =
+   TOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, queue_idx, 
+UINT16); cmdline_parse_token_num_t cmd_queue_setup_ring_size =
+   TOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, ring_size, 
+UINT16); cmdline_parse_token_num_t cmd_queue_setup_offloads =
+   TOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, offloads, 
+UINT64);
+
+static void
+cmd_queue_setup_parsed(
+   void *parsed_result,
+   __attribute__((unused)) struct cmdline *cl,
+   __attribute__((unused)) void *data)
+{
+   struct cmd_queue_setup_result *res = parsed_result;
+   struct rte_port *port;
+   struct rte_mempool *mp;
+   unsigned int socket_id;
+   uint8_t rx = 1;
+   int ret;
+
+   if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+   return;
+
+   if (!strcmp(res->rxtx, "tx"))
+   rx = 0;
+
+   if (rx && res->ring_size <= rx_free_thresh) {


[Rami Rosen] Nitpick: shouldn't it be: must > rx_free_thresh:  ? 

+   printf("Invalid ring_size, must >= rx_free_thresh: %d\n",
+   rx_free_thresh);
+   return;
+   }
+
+   if (rx && res->queue_idx >= nb_rxq) {
+   printf("Invalid rx queue index, must < nb_rxq: %d\n",
+   nb_rxq);
+   return;
+   }
+
+   if (!rx && res->queue_idx >= nb_txq) {
+   printf("Invalid tx queue index, must < nb_txq: %d\n",
+   nb_txq);
+   return;
+   }
+
+   port = &ports[res->port_id];
+   if (rx) {
+   struct rte_eth_rxconf rxconf = port->rx_conf;
+
+   rxconf.offloads = res->offloads;
+   socket_id = rxring_numa[res->port_id];
+   if (!numa_support || socket_id == NUMA_NO_CONFIG)
+   socket_id = port->socket_id;
+
+   mp = mbuf_pool_find(socket_id);
+   if (mp == NULL) {
+   printf("Failed to setup RX queue: "
+   "No mempool allocation"
+   " on the socket %d\n",
+   rxring_numa[res->port_id]);
+   return;
+   }
+   ret = rte_eth_rx_queue_setup(res->port_id,
+res->queue_idx,
+res->ring_size,
+socket_id,
+

[dpdk-dev] [PATCH 8/8] doc: add dpaa2 qdma rawdev to release notes

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 doc/guides/rel_notes/release_18_05.rst | 9 +
 1 file changed, 9 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_05.rst 
b/doc/guides/rel_notes/release_18_05.rst
index 0aebb18..f2de969 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -66,6 +66,15 @@ New Features
 
   See the :doc:`../rawdevs/dpaa2_cmdif.rst` guide for more details.
 
+* **Added DPAA2 QDMA Driver (in rawdev).**
+
+  The DPAA2 QDMA is an implementation of the rawdev API, that provide means
+  to initiate a DMA transaction from CPU. The initiated DMA is performed
+  without CPU being involved in the actual DMA transaction.
+
+  See the :doc:`../rawdevs/dpaa2_qdma.rst` guide for more details.
+
+
 API Changes
 ---
 
-- 
1.9.1

[dpdk-dev] [PATCH v2 1/9] mempool/dpaa2: add functions exposed to DPDK applications

[Nipun Gupta]

There are two API's which are required by NXP specific Command Interface
Application (AIOP CMDIF). This patch exposes these two API's.

Signed-off-by: Nipun Gupta 
---
 doc/api/doxy-api-index.md  |  1 +
 doc/api/doxy-api.conf  |  1 +
 drivers/mempool/dpaa2/Makefile |  2 +
 drivers/mempool/dpaa2/dpaa2_hw_mempool.c   | 30 
 drivers/mempool/dpaa2/rte_dpaa2_mempool.h  | 53 ++
 .../mempool/dpaa2/rte_mempool_dpaa2_version.map|  8 
 6 files changed, 95 insertions(+)
 create mode 100644 drivers/mempool/dpaa2/rte_dpaa2_mempool.h

diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
index d77f205..49fcec4 100644
--- a/doc/api/doxy-api-index.md
+++ b/doc/api/doxy-api-index.md
@@ -63,6 +63,7 @@ The public API headers are grouped by topics:
   [i40e]   (@ref rte_pmd_i40e.h),
   [bnxt]   (@ref rte_pmd_bnxt.h),
   [dpaa]   (@ref rte_pmd_dpaa.h),
+  [dpaa2]  (@ref rte_dpaa2_mempool.h),
   [crypto_scheduler]   (@ref rte_cryptodev_scheduler.h)
 
 - **memory**:
diff --git a/doc/api/doxy-api.conf b/doc/api/doxy-api.conf
index cda52fd..59cb580 100644
--- a/doc/api/doxy-api.conf
+++ b/doc/api/doxy-api.conf
@@ -31,6 +31,7 @@
 PROJECT_NAME= DPDK
 INPUT   = doc/api/doxy-api-index.md \
   drivers/crypto/scheduler \
+  drivers/mempool/dpaa2 \
   drivers/net/bnxt \
   drivers/net/bonding \
   drivers/net/dpaa \
diff --git a/drivers/mempool/dpaa2/Makefile b/drivers/mempool/dpaa2/Makefile
index f0edb32..6a69114 100644
--- a/drivers/mempool/dpaa2/Makefile
+++ b/drivers/mempool/dpaa2/Makefile
@@ -28,4 +28,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) += dpaa2_hw_mempool.c
 LDLIBS += -lrte_bus_fslmc
 LDLIBS += -lrte_eal -lrte_mempool -lrte_ring
 
+SYMLINK-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL)-include := rte_dpaa2_mempool.h
+
 include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c 
b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
index ce7a4c5..3c603f5 100644
--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include "rte_dpaa2_mempool.h"
 
 #include 
 #include 
@@ -237,6 +238,35 @@
}
 }
 
+uint16_t
+rte_dpaa2_mbuf_pool_bpid(struct rte_mempool *mp)
+{
+   struct dpaa2_bp_info *bp_info;
+
+   bp_info = mempool_to_bpinfo(mp);
+   if (!(bp_info->bp_list)) {
+   RTE_LOG(ERR, PMD, "DPAA2 buffer pool not configured\n");
+   return -ENOMEM;
+   }
+
+   return bp_info->bpid;
+}
+
+struct rte_mbuf *
+rte_dpaa2_mbuf_from_buf_addr(struct rte_mempool *mp, void *buf_addr)
+{
+   struct dpaa2_bp_info *bp_info;
+
+   bp_info = mempool_to_bpinfo(mp);
+   if (!(bp_info->bp_list)) {
+   RTE_LOG(ERR, PMD, "DPAA2 buffer pool not configured\n");
+   return NULL;
+   }
+
+   return (struct rte_mbuf *)((uint8_t *)buf_addr -
+   bp_info->meta_data_size);
+}
+
 int
 rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool,
  void **obj_table, unsigned int count)
diff --git a/drivers/mempool/dpaa2/rte_dpaa2_mempool.h 
b/drivers/mempool/dpaa2/rte_dpaa2_mempool.h
new file mode 100644
index 000..4a22b7c
--- /dev/null
+++ b/drivers/mempool/dpaa2/rte_dpaa2_mempool.h
@@ -0,0 +1,53 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright 2018 NXP
+ */
+
+#ifndef __RTE_DPAA2_MEMPOOL_H__
+#define __RTE_DPAA2_MEMPOOL_H__
+
+/**
+ * @file
+ *
+ * NXP specific mempool related functions.
+ *
+ */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include 
+
+/**
+ * Get BPID corresponding to the packet pool
+ *
+ * @param mp
+ *   memory pool
+ *
+ * @return
+ *   BPID of the buffer pool
+ */
+uint16_t
+rte_dpaa2_mbuf_pool_bpid(struct rte_mempool *mp);
+
+/**
+ * Get MBUF from the corresponding 'buf_addr'
+ *
+ * @param mp
+ *   memory pool
+ * @param buf_addr
+ *   The 'buf_addr' of the mbuf. This is the start buffer address
+ *   of the packet buffer (mbuf).
+ *
+ * @return
+ *   - MBUF pointer for success
+ *   - NULL in case of error
+ */
+struct rte_mbuf *
+rte_dpaa2_mbuf_from_buf_addr(struct rte_mempool *mp, void *buf_addr);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* __RTE_DPAA2_MEMPOOL_H__ */
diff --git a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map 
b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
index a8aa685..b45e7a9 100644
--- a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
+++ b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map
@@ -6,3 +6,11 @@ DPDK_17.05 {
 
local: *;
 };
+
+DPDK_18.05 {
+   global:
+
+   rte_dpaa2_mbuf_from_buf_addr;
+   rte_dpaa2_mbuf_pool_bpid;
+
+} DPDK_17.05;
-- 
1.9.1

[dpdk-dev] [PATCH v2 0/9] Introduce DPAA2 Command Interface raw driver

[Nipun Gupta]

This patch set introduces DPAA2 based Command Interface
device driver.

This driver is provides communication between the GPP and
AIOP Firmware.

Patches 1-4:
  Makes necessary changes and fixes in the DPAA2 bus and
  mempool region
Patches 5-7:
  Add the DPAA2 CMDIF driver
Patches 8-9:
  Update the respective documentation

Changes in v2:
  - Move CMDIF compilation to common_linuxapp
  - Support physical addressing mode

Nipun Gupta (9):
  mempool/dpaa2: add functions exposed to DPDK applications
  bus/fslmc: expose API to free dpci device
  bus/fslmc: keep Tx queues information for DPCI devices too
  bus/fslmc: add preprocessors to get flc and frc from fd
  raw/dpaa2_cmdif: introduce DPAA2 command interface driver
  raw/dpaa2_cmdif: add attribute get functionality
  raw/dpaa2_cmdif: support enqueue dequeue operations
  doc: add DPAA2 CMDIF rawdev guide
  doc: add dpaa2 command interface rawdev to release notes

 MAINTAINERS|   9 +
 config/common_base |   1 +
 config/common_linuxapp |   1 +
 doc/api/doxy-api-index.md  |   2 +
 doc/api/doxy-api.conf  |   2 +
 doc/guides/rawdevs/dpaa2_cmdif.rst | 132 +
 doc/guides/rel_notes/release_18_05.rst |   7 +
 drivers/bus/fslmc/portal/dpaa2_hw_dpci.c   |  57 +++-
 drivers/bus/fslmc/portal/dpaa2_hw_pvt.h|  12 +-
 drivers/bus/fslmc/rte_bus_fslmc_version.map|   1 +
 drivers/event/dpaa2/dpaa2_eventdev.c   |  10 +-
 drivers/mempool/dpaa2/Makefile |   2 +
 drivers/mempool/dpaa2/dpaa2_hw_mempool.c   |  30 +++
 drivers/mempool/dpaa2/rte_dpaa2_mempool.h  |  53 
 .../mempool/dpaa2/rte_mempool_dpaa2_version.map|   8 +
 drivers/raw/Makefile   |   3 +
 drivers/raw/dpaa2_cmdif/Makefile   |  35 +++
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c  | 300 +
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h |  35 +++
 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h  |  35 +++
 .../dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map|   4 +
 mk/rte.app.mk  |   1 +
 22 files changed, 719 insertions(+), 21 deletions(-)
 create mode 100644 doc/guides/rawdevs/dpaa2_cmdif.rst
 create mode 100644 drivers/mempool/dpaa2/rte_dpaa2_mempool.h
 create mode 100644 drivers/raw/dpaa2_cmdif/Makefile
 create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
 create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h
 create mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif.h
 create mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map

-- 
1.9.1

[dpdk-dev] [PATCH v2 2/9] bus/fslmc: expose API to free dpci device

[Nipun Gupta]

Signed-off-by: Nipun Gupta 
---
 drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map 
b/drivers/bus/fslmc/rte_bus_fslmc_version.map
index f519651..3811792 100644
--- a/drivers/bus/fslmc/rte_bus_fslmc_version.map
+++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map
@@ -105,5 +105,6 @@ DPDK_18.05 {
global:
 
dpaa2_affine_qbman_ethrx_swp;
+   rte_dpaa2_free_dpci_dev;
 
 } DPDK_18.02;
-- 
1.9.1

[dpdk-dev] [PATCH v5 2/2] net/bnxt: switch to the new offload API

[Ajit Khaparde]

Update bnxt PMD to new ethdev offloads API.

Signed-off-by: Ajit Khaparde 
--
v1->v2: return an error if requested offload flags do not
match supported offload capabilities.
v2->v3: modify the code based on review comments.
v3->v4: fix compilation for i686 configuration.
v4->v5: remove leftovers of old offload API
---
 drivers/net/bnxt/bnxt_ethdev.c | 94 +-
 drivers/net/bnxt/bnxt_ring.c   |  5 ++-
 drivers/net/bnxt/bnxt_rxq.c|  5 ++-
 3 files changed, 71 insertions(+), 33 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 27a51048a..37585f319 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -118,6 +118,28 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {
ETH_RSS_NONFRAG_IPV6_TCP |  \
ETH_RSS_NONFRAG_IPV6_UDP)
 
+#define BNXT_DEV_TX_OFFLOAD_SUPPORT (DEV_TX_OFFLOAD_VLAN_INSERT | \
+DEV_TX_OFFLOAD_IPV4_CKSUM | \
+DEV_TX_OFFLOAD_TCP_CKSUM | \
+DEV_TX_OFFLOAD_UDP_CKSUM | \
+DEV_TX_OFFLOAD_TCP_TSO | \
+DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | \
+DEV_TX_OFFLOAD_VXLAN_TNL_TSO | \
+DEV_TX_OFFLOAD_GRE_TNL_TSO | \
+DEV_TX_OFFLOAD_IPIP_TNL_TSO | \
+DEV_TX_OFFLOAD_GENEVE_TNL_TSO | \
+DEV_TX_OFFLOAD_MULTI_SEGS)
+
+#define BNXT_DEV_RX_OFFLOAD_SUPPORT (DEV_RX_OFFLOAD_VLAN_FILTER | \
+DEV_RX_OFFLOAD_VLAN_STRIP | \
+DEV_RX_OFFLOAD_IPV4_CKSUM | \
+DEV_RX_OFFLOAD_UDP_CKSUM | \
+DEV_RX_OFFLOAD_TCP_CKSUM | \
+DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | \
+DEV_RX_OFFLOAD_JUMBO_FRAME | \
+DEV_RX_OFFLOAD_CRC_STRIP | \
+DEV_RX_OFFLOAD_TCP_LRO)
+
 static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask);
 static void bnxt_print_link_info(struct rte_eth_dev *eth_dev);
 
@@ -187,10 +209,12 @@ static int bnxt_init_chip(struct bnxt *bp)
rte_intr_disable(intr_handle);
 
if (bp->eth_dev->data->mtu > ETHER_MTU) {
-   bp->eth_dev->data->dev_conf.rxmode.jumbo_frame = 1;
+   bp->eth_dev->data->dev_conf.rxmode.offloads |=
+   DEV_RX_OFFLOAD_JUMBO_FRAME;
bp->flags |= BNXT_FLAG_JUMBO;
} else {
-   bp->eth_dev->data->dev_conf.rxmode.jumbo_frame = 0;
+   bp->eth_dev->data->dev_conf.rxmode.offloads &=
+   ~DEV_RX_OFFLOAD_JUMBO_FRAME;
bp->flags &= ~BNXT_FLAG_JUMBO;
}
 
@@ -261,7 +285,8 @@ static int bnxt_init_chip(struct bnxt *bp)
 
bnxt_hwrm_vnic_plcmode_cfg(bp, vnic);
 
-   if (bp->eth_dev->data->dev_conf.rxmode.enable_lro)
+   if (bp->eth_dev->data->dev_conf.rxmode.offloads &
+   DEV_RX_OFFLOAD_TCP_LRO)
bnxt_hwrm_vnic_tpa_cfg(bp, vnic, 1);
else
bnxt_hwrm_vnic_tpa_cfg(bp, vnic, 0);
@@ -402,21 +427,12 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev 
*eth_dev,
dev_info->min_rx_bufsize = 1;
dev_info->max_rx_pktlen = BNXT_MAX_MTU + ETHER_HDR_LEN + ETHER_CRC_LEN
  + VLAN_TAG_SIZE;
-   dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP |
-   DEV_RX_OFFLOAD_IPV4_CKSUM |
-   DEV_RX_OFFLOAD_UDP_CKSUM |
-   DEV_RX_OFFLOAD_TCP_CKSUM |
-   DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM;
-   dev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT |
-   DEV_TX_OFFLOAD_IPV4_CKSUM |
-   DEV_TX_OFFLOAD_TCP_CKSUM |
-   DEV_TX_OFFLOAD_UDP_CKSUM |
-   DEV_TX_OFFLOAD_TCP_TSO |
-   DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
-   DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
-   DEV_TX_OFFLOAD_GRE_TNL_TSO |
-   DEV_TX_OFFLOAD_IPIP_TNL_TSO |
-   DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+
+   dev_info->rx_offload_capa = BNXT_DEV_RX_OFFLOAD_SUPPORT;
+   if (bp->flags & BNXT_FLAG_PTP_SUPPORTED)
+   dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_TIMESTAMP;
+   dev_info->tx_offload_capa = BNXT_DEV_TX_OFFLOAD_SUPPORT;
+   dev_info-

[dpdk-dev] [PATCH v5 1/2] net/bnxt: fix rx_drop_en setting

[Ajit Khaparde]

If Rx descriptors are not available, pkts are dropped by default.
Fix rx_drop_en setting in bnxt_dev_info_get_op to reflect it.

Fixes: 0a6d2a720078 ("net/bnxt: get device infos")
Cc: sta...@dpdk.org

Signed-off-by: Ajit Khaparde 
--
v1->v2: added fixes to commit message.
---
 drivers/net/bnxt/bnxt_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 7c007c8f9..27a51048a 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -426,7 +426,8 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev 
*eth_dev,
.wthresh = 0,
},
.rx_free_thresh = 32,
-   .rx_drop_en = 0,
+   /* If no descriptors available, pkts are dropped by default */
+   .rx_drop_en = 1,
};
 
dev_info->default_txconf = (struct rte_eth_txconf) {
-- 
2.15.1 (Apple Git-101)

[dpdk-dev] Venky - Urgent Call for Stories

[St Leger, Jim]

Sorry for the very short notice. Forward as appropriate.
https://fd.io/2018/04/in-loving-memory-venky-venkatesan-the-father-of-dpdk/

I will have a chance tomorrow at a memorial service for Venky to share some 
stories. I need YOUR stories!
If you have one about how Venky impacted you, a debate you had with him on a 
call or at an event, or whatever, please write up a summary that I can share.

Please send them to me (not reply all please) ASAP.

The memorial is midday on Sunday. I’ll be flying up in the morning.
Do the best you can.

Thanks,
Jim

P.S. Once we can pause and take a breath we want to set some blog site or 
something f to curate and post these stories. If you are reading this message 
after Sunday morning and have a story, please send it along regardless. We will 
find a way to capture and share it.

Re: [dpdk-dev] Venky - Urgent Call for Stories

[Vincent Jardin]

Thanks Jim...

When I started in 2010 with Venky, when we were reinventing the world of 
software networking it was a pleasure to brainstorm with him, to get his 
prototypes and then use them as foundations to build new librairies for 
packet processing.
In fact Venky was someone who wanted to work with people to build a better 
world using all the best we can get from smart brains and technologies. He 
was everywhere when a new first stone was needed and then we could build 
from it. We will continue to build a better world like he wanted us to do.


He is among the few people I could spend hours till late on the phone and 
we were passionnated on building better solutions. He was always availabe 
to meet and to chat. These conversations will miss me but for sure I will 
keep building passionnated innovations like we were used to do.


I do not know how many people understand friendhsip because we love 
technologies made by collaborations but he was such a friend for me.


Merci,

Re: [dpdk-dev] [PATCH v7] net/virtio-user: add support for server mode

[Tan, Jianfeng]

> -Original Message-
> From: Yang, Zhiyong
> Sent: Friday, April 6, 2018 5:26 PM
> To: dev@dpdk.org
> Cc: Yang, Zhiyong; maxime.coque...@redhat.com; Tan, Jianfeng; Bie, Tiwei;
> Wang, Zhihong; Wang, Dong1; tho...@monjalon.net
> Subject: [PATCH v7] net/virtio-user: add support for server mode
> 
> In a container environment if the vhost-user backend restarts, there's
> no way for it to reconnect to virtio-user. To address this, support for
> server mode is added. In this mode the socket file is created by virtio-
> user, which the backend then connects to. This means that if the backend
> restarts, it can reconnect to virtio-user and continue communications.
> 
> With current implementation, LSC is enabled at virtio-user side to
> support to accept the coming connection.
> 
> Server mode virtio-user only supports to work with vhost-user.
> 
> Release note is updated in this patch.
> 
> Signed-off-by: Zhiyong Yang 

Reviewed-by: Jianfeng Tan 

Thanks for the great work!

> ---
> 
> Cc: maxime.coque...@redhat.com
> Cc: jianfeng@intel.com
> Cc: tiwei@intel.com
> Cc: zhihong.w...@intel.com
> Cc: dong1.w...@intel.com
> Cc: tho...@monjalon.net
> 
> Changes in V7:
> 1. avoid misusing vhost-kernel in server mode virtio-user.
> 2. move the funciton definition is_vhost_user_by_type before
> virtio_user_start_device in order that it can be called.
> 3. add comments in the code to state feature negotiation limit.
> 
> Changes in V6:
> 1. fix report wrong link stauts in server mode.
> 2. fix some code style issues.
> 
> Changes in V5:
> 1. Support server mode virtio-user startup in non-blocking mode.
> 2. rebase on top of dpdk-next-virtio.
> 
> Changes in V4:
> 1. Don't create new pthread any more and use librte_eal interrupt thread
> instead.
> 
> Changes in V3:
> 1. use EAL epoll mechanism instead of vhost events. Cancel to export vhost
> event APIs.
> 2. rebase the code on top of dpdk-next-virtio
> 
> Changes in V2:
> 1. split two patches 1/5 and 2/5 from v1 patchset to fix some existing issues
> which is not strongly related to support for server mode
> 2. move fdset related functions to librte_eal from librte_vhost exposed as
> new APIs.
> 3. release note is added in the patch 5/5.
> 4. squash data structure change patch into 4/5 according to Maxime's
> suggestion.
> 
>  doc/guides/rel_notes/release_18_05.rst   |   6 ++
>  drivers/net/virtio/virtio_user/vhost_user.c  |  45 --
>  drivers/net/virtio/virtio_user/virtio_user_dev.c | 101 --
> -
>  drivers/net/virtio/virtio_user/virtio_user_dev.h |   3 +
>  drivers/net/virtio/virtio_user_ethdev.c  | 101
> ---
>  5 files changed, 209 insertions(+), 47 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_18_05.rst
> b/doc/guides/rel_notes/release_18_05.rst
> index 9cc77f893..f8897b2e9 100644
> --- a/doc/guides/rel_notes/release_18_05.rst
> +++ b/doc/guides/rel_notes/release_18_05.rst
> @@ -58,6 +58,12 @@ New Features
>* Added support for NVGRE, VXLAN and GENEVE filters in flow API.
>* Added support for DROP action in flow API.
> 
> +* **Added support for virtio-user server mode.**
> +  In a container environment if the vhost-user backend restarts, there's no
> way
> +  for it to reconnect to virtio-user. To address this, support for server 
> mode
> +  is added. In this mode the socket file is created by virtio-user, which the
> +  backend connects to. This means that if the backend restarts, it can
> reconnect
> +  to virtio-user and continue communications.
> 
>  API Changes
>  ---
> diff --git a/drivers/net/virtio/virtio_user/vhost_user.c
> b/drivers/net/virtio/virtio_user/vhost_user.c
> index 91c6449bb..a6df97a00 100644
> --- a/drivers/net/virtio/virtio_user/vhost_user.c
> +++ b/drivers/net/virtio/virtio_user/vhost_user.c
> @@ -378,6 +378,30 @@ vhost_user_sock(struct virtio_user_dev *dev,
>   return 0;
>  }
> 
> +#define MAX_VIRTIO_USER_BACKLOG 1
> +static int
> +virtio_user_start_server(struct virtio_user_dev *dev, struct sockaddr_un
> *un)
> +{
> + int ret;
> + int flag;
> + int fd = dev->listenfd;
> +
> + ret = bind(fd, (struct sockaddr *)un, sizeof(*un));
> + if (ret < 0) {
> + PMD_DRV_LOG(ERR, "failed to bind to %s: %s; remove it and
> try again\n",
> + dev->path, strerror(errno));
> + return -1;
> + }
> + ret = listen(fd, MAX_VIRTIO_USER_BACKLOG);
> + if (ret < 0)
> + return -1;
> +
> + flag = fcntl(fd, F_GETFL);
> + fcntl(fd, F_SETFL, flag | O_NONBLOCK);
> +
> + return 0;
> +}
> +
>  /**
>   * Set up environment to talk with a vhost user backend.
>   *
> @@ -405,13 +429,24 @@ vhost_user_setup(struct virtio_user_dev *dev)
>   memset(&un, 0, sizeof(un));
>   un.sun_family = AF_UNIX;
>   snprintf(un.sun_path, sizeof(un.sun_path), "%s", dev->path);
> - if (connect(fd, (struct sockaddr *)&un, sizeof(un)) < 0) {
> - PMD_DRV_LOG

Re: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start

[Zhang, Qi Z]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams
> Sent: Wednesday, February 14, 2018 6:56 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo ; Ananyev, Konstantin
> ; Charles (Chas) Williams 
> Subject: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start
> 
> From: "Charles (Chas) Williams" 
> 
> dev->data->eth_link isn't updated until the first interrupt.  If a
> link is carrier down, then this interrupt may never happen.  Before we
> finished starting the PMD, call ixgbe_dev_link_update() to ensure we have a
> valid status.
> 
> Signed-off-by: Chas Williams 

Acked-by: Qi Zhang 

> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 37eb668..27d29dc 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2666,6 +2666,8 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
>   if (err)
>   goto error;
> 
> + ixgbe_dev_link_update(dev, 0);
> +
>  skip_link_setup:
> 
>   if (rte_intr_allow_others(intr_handle)) { @@ -5033,6 +5035,8 @@
> ixgbevf_dev_start(struct rte_eth_dev *dev)
> 
>   ixgbevf_dev_rxtx_start(dev);
> 
> + ixgbevf_dev_link_update(dev, 0);
> +
>   /* check and configure queue intr-vector mapping */
>   if (rte_intr_cap_multiple(intr_handle) &&
>   dev->data->dev_conf.intr_conf.rxq) {
> --
> 2.9.5

Re: [dpdk-dev] [PATCH v3 01/12] mempool/octeontx: probe timvf PCIe devices

[Jerin Jacob]

-Original Message-
> Date: Tue,  3 Apr 2018 20:35:03 +0530
> From: Pavan Nikhilesh 
> To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com,
>  erik.g.carri...@intel.com
> Cc: dev@dpdk.org, Pavan Nikhilesh 
> Subject: [dpdk-dev] [PATCH v3 01/12] mempool/octeontx: probe timvf PCIe
>  devices
> X-Mailer: git-send-email 2.16.3
> 
> On Octeontx HW, each event timer device is enumerated as separate SRIOV VF
> PCIe device.
> 
> In order to expose as a event timer device:
> On PCIe probe, the driver stores the information associated with the
> PCIe device and later when appliacation requests for a event timer device
> through `rte_event_timer_adapter_create` the driver infrastructure creates
> the timer adapter with earlier probed PCIe VF devices.
> 
> Signed-off-by: Pavan Nikhilesh 
> ---
>  drivers/mempool/octeontx/Makefile  |   1 +
>  drivers/mempool/octeontx/meson.build   |   1 +
>  drivers/mempool/octeontx/octeontx_mbox.h   |   7 +
>  drivers/mempool/octeontx/octeontx_timvf.c  | 145 
> +

Now that, we have driver/common for mailbox. Please move the
octeontx_timvf.c to driver/event/octeontx/timvf_probe.c

>  .../octeontx/rte_mempool_octeontx_version.map  |   3 +
>  5 files changed, 157 insertions(+)
>  create mode 100644 drivers/mempool/octeontx/octeontx_timvf.c
> 
> diff --git a/drivers/mempool/octeontx/Makefile 
> b/drivers/mempool/octeontx/Makefile
> index dfc373e62..a0547437a 100644
> --- a/drivers/mempool/octeontx/Makefile
> +++ b/drivers/mempool/octeontx/Makefile
> @@ -20,6 +20,7 @@ LIBABIVER := 1
>  SRCS-$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL) += octeontx_ssovf.c
>  SRCS-$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL) += octeontx_mbox.c
>  SRCS-$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL) += octeontx_fpavf.c
> +SRCS-$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL) += octeontx_timvf.c
>  SRCS-$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL) += rte_mempool_octeontx.c
>  
>  ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
> diff --git a/drivers/mempool/octeontx/meson.build 
> b/drivers/mempool/octeontx/meson.build
> index 1e894a56b..c938436c9 100644
> --- a/drivers/mempool/octeontx/meson.build
> +++ b/drivers/mempool/octeontx/meson.build
> @@ -4,6 +4,7 @@
>  sources = files('octeontx_ssovf.c',
>   'octeontx_mbox.c',
>   'octeontx_fpavf.c',
> + 'octeontx_timvf.c',
>   'rte_mempool_octeontx.c'
>  )
>  
> diff --git a/drivers/mempool/octeontx/octeontx_mbox.h 
> b/drivers/mempool/octeontx/octeontx_mbox.h
> index 1b056071a..7fcc9950f 100644
> --- a/drivers/mempool/octeontx/octeontx_mbox.h
> +++ b/drivers/mempool/octeontx/octeontx_mbox.h
> @@ -21,6 +21,11 @@ enum octeontx_ssovf_type {
>   OCTEONTX_SSO_HWS,  /* SSO hardware workslot vf */
>  };
>  
> +struct octeontx_timvf_info {
> + uint16_t domain; /* Domain id */
> + uint8_t total_timvfs; /* Total timvf available in domain */
> +};
> +
>  struct octeontx_mbox_hdr {
>   uint16_t vfid;  /* VF index or pf resource index local to the domain */
>   uint8_t coproc; /* Coprocessor id */
> @@ -32,5 +37,7 @@ int octeontx_ssovf_info(struct octeontx_ssovf_info *info);
>  void *octeontx_ssovf_bar(enum octeontx_ssovf_type, uint8_t id, uint8_t bar);
>  int octeontx_ssovf_mbox_send(struct octeontx_mbox_hdr *hdr,
>   void *txdata, uint16_t txlen, void *rxdata, uint16_t rxlen);
> +int octeontx_timvf_info(struct octeontx_timvf_info *info);
> +void *octeontx_timvf_bar(uint8_t id, uint8_t bar);
>  
>  #endif /* __OCTEONTX_MBOX_H__ */
> diff --git a/drivers/mempool/octeontx/octeontx_timvf.c 
> b/drivers/mempool/octeontx/octeontx_timvf.c
> new file mode 100644
> index 0..b20743a33
> --- /dev/null
> +++ b/drivers/mempool/octeontx/octeontx_timvf.c
> @@ -0,0 +1,145 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2017 Cavium, Inc
> + */
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +#include "octeontx_mbox.h"
> +#include "octeontx_pool_logs.h"
> +
> +#ifndef PCI_VENDOR_ID_CAVIUM
> +#define PCI_VENDOR_ID_CAVIUM (0x177D)
> +#endif
> +
> +#define PCI_DEVICE_ID_OCTEONTX_TIM_VF(0xA051)
> +#define TIM_MAX_RINGS(64)
> +
> +struct timvf_res {
> + uint16_t domain;
> + uint16_t vfid;
> + void *bar0;
> + void *bar2;
> + void *bar4;
> +};
> +
> +struct timdev {
> + uint8_t total_timvfs;
> + struct timvf_res rings[TIM_MAX_RINGS];
> +};
> +
> +static struct timdev tdev;
> +
> +int
> +octeontx_timvf_info(struct octeontx_timvf_info *tinfo)
> +{
> + int i;
> + struct octeontx_ssovf_info info;
> +
> + if (tinfo == NULL)
> + return -EINVAL;
> +
> + if (!tdev.total_timvfs)
> + return -ENODEV;
> +
> + if (octeontx_ssovf_info(&info) < 0)
> + return -EINVAL;
> +
> + for (i = 0; i < tdev.total_timvfs; i++) {
> + if (info.domain != tdev.rings[i].domain) {
> + mbox_log_e

Re: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup

[Zhang, Qi Z]

> -Original Message-
> From: Rosen, Rami
> Sent: Saturday, April 7, 2018 3:42 AM
> To: Zhang, Qi Z ; tho...@monjalon.net; Ananyev,
> Konstantin 
> Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing
> ; Lu, Wenzhuo ; Zhang, Qi Z
> 
> Subject: RE: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup
> 
> Hi Qi,
> Thanks for these patches.
> See my comment below.
> 
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang
> Sent: Monday, April 02, 2018 06:00
> To: tho...@monjalon.net; Ananyev, Konstantin
> 
> Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing
> ; Lu, Wenzhuo ; Zhang, Qi Z
> 
> Subject: [dpdk-dev] [PATCH v5 1/3] ether: support runtime queue setup
> 
> The patch let etherdev driver expose the capability flag through
> rte_eth_dev_info_get when it support runtime queue configuraiton, then base
> on the flag rte_eth_[rx|tx]_queue_setup could decide continue to setup the
> queue or just return fail when device already started.
> 
> Signed-off-by: Qi Zhang 
> ---
>  doc/guides/nics/features.rst  |  8   lib/librte_ether/rte_ethdev.c
> | 30 ++  lib/librte_ether/rte_ethdev.h |  7
> +++
>  3 files changed, 33 insertions(+), 12 deletions(-)
> 
> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index
> 1b4fb979f..6983faa4e 100644
> --- a/doc/guides/nics/features.rst
> +++ b/doc/guides/nics/features.rst
> @@ -892,7 +892,15 @@ Documentation describes performance values.
> 
>  See ``dpdk.org/doc/perf/*``.
> 
> +.. _nic_features_queue_runtime_setup_capabilities:
> 
> +Queue runtime setup capabilities
> +-
> +
> +Supports queue setup / release after device started.
> +
> +* **[provides] rte_eth_dev_info**:
> ``runtime_queue_config_capa:DEV_RUNTIME_RX_QUEUE_SETUP,DEV_RUNTI
> ME_TX_QUEUE_SETUP``.
> +* **[related]  API**: ``rte_eth_dev_info_get()``.
> 
>  .. _nic_features_other:
> 
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c 
> index
> 0590f0c10..343b1a6c0 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -1425,12 +1425,6 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t
> rx_queue_id,
>   return -EINVAL;
>   }
> 
> - if (dev->data->dev_started) {
> - RTE_PMD_DEBUG_TRACE(
> - "port %d must be stopped to allow configuration\n", 
> port_id);
> - return -EBUSY;
> - }
> -
>   RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get,
> -ENOTSUP);
>   RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_setup,
> -ENOTSUP);
> 
> @@ -1474,6 +1468,15 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t
> rx_queue_id,
>   return -EINVAL;
>   }
> 
> + if (dev->data->dev_started &&
> + !(dev_info.runtime_queue_setup_capa &
> + DEV_RUNTIME_RX_QUEUE_SETUP))
> + return -EBUSY;
> +
> + if (dev->data->rx_queue_state[rx_queue_id] !=
> + RTE_ETH_QUEUE_STATE_STOPPED)
> + return -EBUSY;
> +
>   rxq = dev->data->rx_queues;
>   if (rxq[rx_queue_id]) {
>   RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release,
> @@ -1573,12 +1576,6 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t
> tx_queue_id,
>   return -EINVAL;
>   }
> 
> - if (dev->data->dev_started) {
> - RTE_PMD_DEBUG_TRACE(
> - "port %d must be stopped to allow configuration\n", 
> port_id);
> - return -EBUSY;
> - }
> -
>   RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get,
> -ENOTSUP);
>   RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_setup,
> -ENOTSUP);
> 
> @@ -1596,6 +1593,15 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t
> tx_queue_id,
>   return -EINVAL;
>   }
> 
> + if (dev->data->dev_started &&
> + !(dev_info.runtime_queue_setup_capa &
> + DEV_RUNTIME_TX_QUEUE_SETUP))
> + return -EBUSY;
> +
> [Rami Rosen] Shouldn't it be here: dev->data->tx_queue_state[...] instead of:
> dev->data->rx_queue_state[...] ? we are dealing
> with the TX queue.

Thanks, will fix.

> 
> + if (dev->data->rx_queue_state[tx_queue_id] !=
> + RTE_ETH_QUEUE_STATE_STOPPED)
> + return -EBUSY;
> +
>   txq = dev->data->tx_queues;
>   if (txq[tx_queue_id]) {
>   RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release,
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h 
> index
> 036153306..4e2088458 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -981,6 +981,11 @@ struct rte_eth_conf {
>   */
>  #define DEV_TX_OFFLOAD_SECURITY 0x0002
> 
> +#define DEV_RUNTIME_RX_QUEUE_SETUP 0x0001 /**< Deferred setup
> rx
> +queue */ #define DEV_RUNTIME_TX_QUEUE_SETUP 0x0002 /**<
> Deferred
> +setup tx queue */
> +
>  /*
>   * If new T

Re: [dpdk-dev] [PATCH v5 2/3] app/testpmd: add command for queue setup

[Zhang, Qi Z]

> -Original Message-
> From: Rosen, Rami
> Sent: Saturday, April 7, 2018 11:50 PM
> To: Zhang, Qi Z ; tho...@monjalon.net; Ananyev,
> Konstantin 
> Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing
> ; Lu, Wenzhuo ; Zhang, Qi Z
> 
> Subject: RE: [dpdk-dev] [PATCH v5 2/3] app/testpmd: add command for queue
> setup
> 
> 
> 
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qi Zhang
> Sent: Monday, April 02, 2018 06:00
> To: tho...@monjalon.net; Ananyev, Konstantin
> 
> Cc: dev@dpdk.org; Xing, Beilei ; Wu, Jingjing
> ; Lu, Wenzhuo ; Zhang, Qi Z
> 
> Subject: [dpdk-dev] [PATCH v5 2/3] app/testpmd: add command for queue
> setup
> 
> Add new command to setup queue:
> queue setup (rx|tx) (port_id) (queue_idx) (ring_size) (offloads)
> 
> rte_eth_[rx|tx]_queue_setup will be called corresponsively
> 
> Signed-off-by: Qi Zhang 
> ---
> v5:
> - fix command description.
> 
> v4:
> - fix missing offload in command line.
> 
> v3:
> - add offload parameter to queue setup command.
> - couple code refactory.
> 
>  app/test-pmd/cmdline.c  | 129
> 
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |   7 ++
>  2 files changed, 136 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> d1dc1de6c..449c7c634 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -774,6 +774,9 @@ static void cmd_help_long_parsed(void
> *parsed_result,
>   "port tm hierarchy commit (port_id) (clean_on_fail)\n"
>   "   Commit tm hierarchy.\n\n"
> 
> + "queue setup (rx|tx) (port_id) (queue_idx) (ring_size)
> (offloads)\n"
> + "   setup a rx or tx queue.\n\n"
> +
>   , list_pkt_forwarding_modes()
>   );
>   }
> @@ -16030,6 +16033,131 @@ cmdline_parse_inst_t cmd_load_from_file = {
>   },
>  };
> 
> +/* Queue Setup */
> +
> +/* Common result structure for queue setup */ struct
> +cmd_queue_setup_result {
> + cmdline_fixed_string_t queue;
> + cmdline_fixed_string_t setup;
> + cmdline_fixed_string_t rxtx;
> + portid_t port_id;
> + uint16_t queue_idx;
> + uint16_t ring_size;
> + uint64_t offloads;
> +};
> +
> +/* Common CLI fields for queue setup */ cmdline_parse_token_string_t
> +cmd_queue_setup_queue =
> + TOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, queue,
> +"queue"); cmdline_parse_token_string_t cmd_queue_setup_setup =
> + TOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, setup,
> +"setup"); cmdline_parse_token_string_t cmd_queue_setup_rxtx =
> + TOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, rxtx,
> +"rx#tx"); cmdline_parse_token_num_t cmd_queue_setup_port_id =
> + TOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, port_id,
> UINT16);
> +cmdline_parse_token_num_t cmd_queue_setup_queue_idx =
> + TOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, queue_idx,
> +UINT16); cmdline_parse_token_num_t cmd_queue_setup_ring_size =
> + TOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, ring_size,
> +UINT16); cmdline_parse_token_num_t cmd_queue_setup_offloads =
> + TOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, offloads,
> +UINT64);
> +
> +static void
> +cmd_queue_setup_parsed(
> + void *parsed_result,
> + __attribute__((unused)) struct cmdline *cl,
> + __attribute__((unused)) void *data)
> +{
> + struct cmd_queue_setup_result *res = parsed_result;
> + struct rte_port *port;
> + struct rte_mempool *mp;
> + unsigned int socket_id;
> + uint8_t rx = 1;
> + int ret;
> +
> + if (port_id_is_invalid(res->port_id, ENABLED_WARN))
> + return;
> +
> + if (!strcmp(res->rxtx, "tx"))
> + rx = 0;
> +
> + if (rx && res->ring_size <= rx_free_thresh) {
> 
> 
> [Rami Rosen] Nitpick: shouldn't it be: must > rx_free_thresh:  ?

Good capture, will fix.

> 
> + printf("Invalid ring_size, must >= rx_free_thresh: %d\n",
> + rx_free_thresh);
> + return;
> + }
> +
> + if (rx && res->queue_idx >= nb_rxq) {
> + printf("Invalid rx queue index, must < nb_rxq: %d\n",
> + nb_rxq);
> + return;
> + }
> +
> + if (!rx && res->queue_idx >= nb_txq) {
> + printf("Invalid tx queue index, must < nb_txq: %d\n",
> + nb_txq);
> + return;
> + }
> +
> + port = &ports[res->port_id];
> + if (rx) {
> + struct rte_eth_rxconf rxconf = port->rx_conf;
> +
> + rxconf.offloads = res->offloads;
> + socket_id = rxring_numa[res->port_id];
> + if (!numa_support || socket_id == NUMA_NO_CONFIG)
> + socket_id = port->socket_id;
> +
> + mp = mbuf_pool_find(socket_id);
> + if (mp == NULL) {
> + printf("Failed to s

[dpdk-dev] [PATCH] doc: fix a typo

[Jerin Jacob]

Cc: sta...@dpdk.org
Fixes: a9bb0c44c775 ("doc: add rawdev library guide and doxygen page")

Signed-off-by: Jerin Jacob 
---
 doc/guides/prog_guide/rawdev.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/prog_guide/rawdev.rst b/doc/guides/prog_guide/rawdev.rst
index 54bffc585..42c195cef 100644
--- a/doc/guides/prog_guide/rawdev.rst
+++ b/doc/guides/prog_guide/rawdev.rst
@@ -43,7 +43,7 @@ Key factors guiding design of the Rawdevice library:
   * Firmware Management - Firmware load/unload/status
 
 2. Application API should be able to pass along arbitrary state information
-   to/fro device driver. This can be achieved by maintaining context
+   to/from device driver. This can be achieved by maintaining context
information through opaque data or pointers.
 
 Figure below outlines the layout of the rawdevice library and device vis-a-vis
-- 
2.17.0

[dpdk-dev] [PATCH v6 1/3] ether: support runtime queue setup

[Qi Zhang]

The patch let etherdev driver expose the capability flag through
rte_eth_dev_info_get when it support runtime queue configuraiton,
then base on the flag rte_eth_[rx|tx]_queue_setup could decide
continue to setup the queue or just return fail when device already
started.

Signed-off-by: Qi Zhang 
Acked-by: Konstantin Ananyev 
---
v6:
- fix tx queue state check in rte_eth_tx_queue_setup 

 doc/guides/nics/features.rst  |  8 
 lib/librte_ether/rte_ethdev.c | 30 ++
 lib/librte_ether/rte_ethdev.h |  7 +++
 3 files changed, 33 insertions(+), 12 deletions(-)

diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 1b4fb979f..6983faa4e 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -892,7 +892,15 @@ Documentation describes performance values.
 
 See ``dpdk.org/doc/perf/*``.
 
+.. _nic_features_queue_runtime_setup_capabilities:
 
+Queue runtime setup capabilities
+-
+
+Supports queue setup / release after device started.
+
+* **[provides] rte_eth_dev_info**: 
``runtime_queue_config_capa:DEV_RUNTIME_RX_QUEUE_SETUP,DEV_RUNTIME_TX_QUEUE_SETUP``.
+* **[related]  API**: ``rte_eth_dev_info_get()``.
 
 .. _nic_features_other:
 
diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 2c74f7e04..8638a2b82 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -1441,12 +1441,6 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t 
rx_queue_id,
return -EINVAL;
}
 
-   if (dev->data->dev_started) {
-   RTE_PMD_DEBUG_TRACE(
-   "port %d must be stopped to allow configuration\n", 
port_id);
-   return -EBUSY;
-   }
-
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_setup, -ENOTSUP);
 
@@ -1490,6 +1484,15 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t 
rx_queue_id,
return -EINVAL;
}
 
+   if (dev->data->dev_started &&
+   !(dev_info.runtime_queue_setup_capa &
+   DEV_RUNTIME_RX_QUEUE_SETUP))
+   return -EBUSY;
+
+   if (dev->data->rx_queue_state[rx_queue_id] !=
+   RTE_ETH_QUEUE_STATE_STOPPED)
+   return -EBUSY;
+
rxq = dev->data->rx_queues;
if (rxq[rx_queue_id]) {
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release,
@@ -1589,12 +1592,6 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t 
tx_queue_id,
return -EINVAL;
}
 
-   if (dev->data->dev_started) {
-   RTE_PMD_DEBUG_TRACE(
-   "port %d must be stopped to allow configuration\n", 
port_id);
-   return -EBUSY;
-   }
-
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_setup, -ENOTSUP);
 
@@ -1612,6 +1609,15 @@ rte_eth_tx_queue_setup(uint16_t port_id, uint16_t 
tx_queue_id,
return -EINVAL;
}
 
+   if (dev->data->dev_started &&
+   !(dev_info.runtime_queue_setup_capa &
+   DEV_RUNTIME_TX_QUEUE_SETUP))
+   return -EBUSY;
+
+   if (dev->data->tx_queue_state[tx_queue_id] !=
+   RTE_ETH_QUEUE_STATE_STOPPED)
+   return -EBUSY;
+
txq = dev->data->tx_queues;
if (txq[tx_queue_id]) {
RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->tx_queue_release,
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 5e13dca6a..6b6208a4b 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -981,6 +981,11 @@ struct rte_eth_conf {
  */
 #define DEV_TX_OFFLOAD_SECURITY 0x0002
 
+#define DEV_RUNTIME_RX_QUEUE_SETUP 0x0001
+/**< Deferred setup rx queue */
+#define DEV_RUNTIME_TX_QUEUE_SETUP 0x0002
+/**< Deferred setup tx queue */
+
 /*
  * If new Tx offload capabilities are defined, they also must be
  * mentioned in rte_tx_offload_names in rte_ethdev.c file.
@@ -1029,6 +1034,8 @@ struct rte_eth_dev_info {
/** Configured number of rx/tx queues */
uint16_t nb_rx_queues; /**< Number of RX queues. */
uint16_t nb_tx_queues; /**< Number of TX queues. */
+   uint64_t runtime_queue_setup_capa;
+   /**< queues can be setup after dev_start (DEV_DEFERRED_). */
 };
 
 /**
-- 
2.13.6

[dpdk-dev] [PATCH v6 3/3] net/i40e: enable runtime queue setup

[Qi Zhang]

Expose the runtime queue configuration capability and enhance
i40e_dev_[rx|tx]_queue_setup to handle the situation when
device already started.

Signed-off-by: Qi Zhang 
Acked-by: Konstantin Ananyev 
---
v5:
- fix first tx queue check.

v4:
- fix rx/tx conflict check.
- no need conflict check for first rx/tx queue at runtime setup.

v3:
- no queue start/stop in setup/release
- return fail when required rx/tx function conflict with
  exist setup

 drivers/net/i40e/i40e_ethdev.c |   4 +
 drivers/net/i40e/i40e_rxtx.c   | 183 +++--
 2 files changed, 164 insertions(+), 23 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index d0bf4e349..9e18ffd4e 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -3240,6 +3240,10 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct 
rte_eth_dev_info *dev_info)
DEV_TX_OFFLOAD_GRE_TNL_TSO |
DEV_TX_OFFLOAD_IPIP_TNL_TSO |
DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+   dev_info->runtime_queue_setup_capa =
+   DEV_RUNTIME_RX_QUEUE_SETUP |
+   DEV_RUNTIME_TX_QUEUE_SETUP;
+
dev_info->hash_key_size = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
sizeof(uint32_t);
dev_info->reta_size = pf->hash_lut_size;
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 1217e5a61..0115ae731 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -1692,6 +1692,75 @@ i40e_dev_supported_ptypes_get(struct rte_eth_dev *dev)
return NULL;
 }
 
+static int
+i40e_dev_first_queue(uint16_t idx, void **queues, int num)
+{
+   uint16_t i;
+
+   for (i = 0; i < num; i++) {
+   if (i != idx && queues[i])
+   return 0;
+   }
+
+   return 1;
+}
+
+static int
+i40e_dev_rx_queue_setup_runtime(struct rte_eth_dev *dev,
+   struct i40e_rx_queue *rxq)
+{
+   struct i40e_adapter *ad =
+   I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
+   int use_def_burst_func =
+   check_rx_burst_bulk_alloc_preconditions(rxq);
+   uint16_t buf_size =
+   (uint16_t)(rte_pktmbuf_data_room_size(rxq->mp) -
+  RTE_PKTMBUF_HEADROOM);
+   int use_scattered_rx =
+   ((rxq->max_pkt_len + 2 * I40E_VLAN_TAG_SIZE) > buf_size);
+
+   if (i40e_rx_queue_init(rxq) != I40E_SUCCESS) {
+   PMD_DRV_LOG(ERR,
+   "Failed to do RX queue initialization");
+   return -EINVAL;
+   }
+
+   if (i40e_dev_first_queue(rxq->queue_id,
+dev->data->rx_queues,
+dev->data->nb_rx_queues)) {
+   /**
+* If it is the first queue to setup,
+* set all flags to default and call
+* i40e_set_rx_function.
+*/
+   ad->rx_bulk_alloc_allowed = true;
+   ad->rx_vec_allowed = true;
+   dev->data->scattered_rx = use_scattered_rx;
+   if (use_def_burst_func)
+   ad->rx_bulk_alloc_allowed = false;
+   i40e_set_rx_function(dev);
+   return 0;
+   }
+
+   /* check bulk alloc conflict */
+   if (ad->rx_bulk_alloc_allowed && use_def_burst_func) {
+   PMD_DRV_LOG(ERR, "Can't use default burst.");
+   return -EINVAL;
+   }
+   /* check scatterred conflict */
+   if (!dev->data->scattered_rx && use_scattered_rx) {
+   PMD_DRV_LOG(ERR, "Scattered rx is required.");
+   return -EINVAL;
+   }
+   /* check vector conflict */
+   if (ad->rx_vec_allowed && i40e_rxq_vec_setup(rxq)) {
+   PMD_DRV_LOG(ERR, "Failed vector rx setup.");
+   return -EINVAL;
+   }
+
+   return 0;
+}
+
 int
 i40e_dev_rx_queue_setup(struct rte_eth_dev *dev,
uint16_t queue_idx,
@@ -1808,25 +1877,6 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev *dev,
 
i40e_reset_rx_queue(rxq);
rxq->q_set = TRUE;
-   dev->data->rx_queues[queue_idx] = rxq;
-
-   use_def_burst_func = check_rx_burst_bulk_alloc_preconditions(rxq);
-
-   if (!use_def_burst_func) {
-#ifdef RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC
-   PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions are "
-"satisfied. Rx Burst Bulk Alloc function will be "
-"used on port=%d, queue=%d.",
-rxq->port_id, rxq->queue_id);
-#endif /* RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC */
-   } else {
-   PMD_INIT_LOG(DEBUG, "Rx Burst Bulk Alloc Preconditions are "
-"not satisfied, Scattered Rx is requested, "
-"or RTE_LIBRTE_I40E_RX_ALLOW_BULK_

[dpdk-dev] [PATCH v5 0/3] runtime queue setup

[Qi Zhang]

v6:
- fix tx queue state check in rte_eth_rx_queue_setup
- fix error message in testpmd.

v5:
- fix first tx queue check in i40e.

v4:
- fix i40e rx/tx funciton conflict handle.
- no need conflict check for first rx/tx queue at runtime setup.
- fix missing offload paramter in testpmd cmdline.

v3:
- not overload deferred start.
- rename deferred setup to runtime setup.
- remove unecessary testpmd parameters (patch 2/4 of v2)
- add offload support to testpmd queue setup command line
- i40e fix: return fail when required rx/tx function conflict with
  exist setup.

v2:
- enhance comment in rte_ethdev.h

According to exist implementation,rte_eth_[rx|tx]_queue_setup will
always return fail if device is already started(rte_eth_dev_start).

This can't satisfied the usage when application want to deferred setup
part of the queues while keep traffic running on those queues already
be setup.

example:
rte_eth_dev_config(nb_rxq = 2, nb_txq =2)
rte_eth_rx_queue_setup(idx = 0 ...)
rte_eth_rx_queue_setup(idx = 0 ...)
rte_eth_dev_start(...) /* [rx|tx]_burst is ready to start on queue 0 */
rte_eth_rx_queue_setup(idx=1 ...) /* fail*/

Basically this is not a general hardware limitation, because for NIC
like i40e, ixgbe, it is not necessary to stop the whole device before
configure a fresh queue or reconfigure an exist queue with no traffic
on it.

The patch let etherdev driver expose the capability flag through
rte_eth_dev_info_get when it support deferred queue configuraiton,
then base on these flag, rte_eth_[rx|tx]_queue_setup could decide
continue to setup the queue or just return fail when device already
started.


Qi Zhang (3):
  ether: support runtime queue setup
  app/testpmd: add command for queue setup
  net/i40e: enable runtime queue setup

 app/test-pmd/cmdline.c  | 129 
 doc/guides/nics/features.rst|   8 ++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |   7 ++
 drivers/net/i40e/i40e_ethdev.c  |   4 +
 drivers/net/i40e/i40e_rxtx.c| 183 
 lib/librte_ether/rte_ethdev.c   |  30 +++--
 lib/librte_ether/rte_ethdev.h   |   7 ++
 7 files changed, 333 insertions(+), 35 deletions(-)

-- 
2.13.6

[dpdk-dev] [PATCH v6 2/3] app/testpmd: add command for queue setup

[Qi Zhang]

Add new command to setup queue:
queue setup (rx|tx) (port_id) (queue_idx) (ring_size) (offloads)

rte_eth_[rx|tx]_queue_setup will be called corresponsively

Signed-off-by: Qi Zhang 
Acked-by: Konstantin Ananyev 
---
v6:
- fix error message for rx_free_thresh check.

v5:
- fix command description.

v4:
- fix missing offload in command line.

v3:
- add offload parameter to queue setup command.
- couple code refactory.

 app/test-pmd/cmdline.c  | 129 
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |   7 ++
 2 files changed, 136 insertions(+)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 40b31ad7e..0752492ea 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -774,6 +774,9 @@ static void cmd_help_long_parsed(void *parsed_result,
"port tm hierarchy commit (port_id) (clean_on_fail)\n"
"   Commit tm hierarchy.\n\n"
 
+   "queue setup (rx|tx) (port_id) (queue_idx) (ring_size) 
(offloads)\n"
+   "   setup a rx or tx queue.\n\n"
+
, list_pkt_forwarding_modes()
);
}
@@ -16030,6 +16033,131 @@ cmdline_parse_inst_t cmd_load_from_file = {
},
 };
 
+/* Queue Setup */
+
+/* Common result structure for queue setup */
+struct cmd_queue_setup_result {
+   cmdline_fixed_string_t queue;
+   cmdline_fixed_string_t setup;
+   cmdline_fixed_string_t rxtx;
+   portid_t port_id;
+   uint16_t queue_idx;
+   uint16_t ring_size;
+   uint64_t offloads;
+};
+
+/* Common CLI fields for queue setup */
+cmdline_parse_token_string_t cmd_queue_setup_queue =
+   TOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, queue, "queue");
+cmdline_parse_token_string_t cmd_queue_setup_setup =
+   TOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, setup, "setup");
+cmdline_parse_token_string_t cmd_queue_setup_rxtx =
+   TOKEN_STRING_INITIALIZER(struct cmd_queue_setup_result, rxtx, "rx#tx");
+cmdline_parse_token_num_t cmd_queue_setup_port_id =
+   TOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, port_id, UINT16);
+cmdline_parse_token_num_t cmd_queue_setup_queue_idx =
+   TOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, queue_idx, UINT16);
+cmdline_parse_token_num_t cmd_queue_setup_ring_size =
+   TOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, ring_size, UINT16);
+cmdline_parse_token_num_t cmd_queue_setup_offloads =
+   TOKEN_NUM_INITIALIZER(struct cmd_queue_setup_result, offloads, UINT64);
+
+static void
+cmd_queue_setup_parsed(
+   void *parsed_result,
+   __attribute__((unused)) struct cmdline *cl,
+   __attribute__((unused)) void *data)
+{
+   struct cmd_queue_setup_result *res = parsed_result;
+   struct rte_port *port;
+   struct rte_mempool *mp;
+   unsigned int socket_id;
+   uint8_t rx = 1;
+   int ret;
+
+   if (port_id_is_invalid(res->port_id, ENABLED_WARN))
+   return;
+
+   if (!strcmp(res->rxtx, "tx"))
+   rx = 0;
+
+   if (rx && res->ring_size <= rx_free_thresh) {
+   printf("Invalid ring_size, must > rx_free_thresh: %d\n",
+   rx_free_thresh);
+   return;
+   }
+
+   if (rx && res->queue_idx >= nb_rxq) {
+   printf("Invalid rx queue index, must < nb_rxq: %d\n",
+   nb_rxq);
+   return;
+   }
+
+   if (!rx && res->queue_idx >= nb_txq) {
+   printf("Invalid tx queue index, must < nb_txq: %d\n",
+   nb_txq);
+   return;
+   }
+
+   port = &ports[res->port_id];
+   if (rx) {
+   struct rte_eth_rxconf rxconf = port->rx_conf;
+
+   rxconf.offloads = res->offloads;
+   socket_id = rxring_numa[res->port_id];
+   if (!numa_support || socket_id == NUMA_NO_CONFIG)
+   socket_id = port->socket_id;
+
+   mp = mbuf_pool_find(socket_id);
+   if (mp == NULL) {
+   printf("Failed to setup RX queue: "
+   "No mempool allocation"
+   " on the socket %d\n",
+   rxring_numa[res->port_id]);
+   return;
+   }
+   ret = rte_eth_rx_queue_setup(res->port_id,
+res->queue_idx,
+res->ring_size,
+socket_id,
+&rxconf,
+mp);
+   if (ret)
+   printf("Failed to setup RX queue\n");
+   } else {
+   struct rte_eth_txconf txconf = port->tx_conf;
+
+   txconf.offloads = res->offloads;
+   socket

Re: [dpdk-dev] [PATCH v3 00/12] event/octeontx: add event timer adapter driver

[Jerin Jacob]

-Original Message-
> Date: Tue,  3 Apr 2018 20:35:02 +0530
> From: Pavan Nikhilesh 
> To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com,
>  erik.g.carri...@intel.com
> Cc: dev@dpdk.org, Pavan Nikhilesh 
> Subject: [dpdk-dev] [PATCH v3 00/12] event/octeontx: add event timer
>  adapter driver
> X-Mailer: git-send-email 2.16.3
> 
> The event timer adapter[1] provides APIs to configure an event timer device
> that allows an application to arm timers which on expiry push events to an
> event device such as OcteonTx SSO.
> The OcteonTx TIM is a co-processor that can be configured as an event timer
> adapter which can be used by an application to manage event timers.
> 
> The TIM co-processor processes the event timers registered and pushes
> expired event timers to SSO based on the event queue, schedule type, flow
> id etc. provided as rte_event while arming the event timer. It maintains
> event timers with high precision and time granularity of 1us (microsecond).
> 
> [1] http://dpdk.org/dev/patchwork/patch/33525/
> 
> This patch set depends on:
> 1. http://dpdk.org/dev/patchwork/bundle/pbhagavatula/event_timerdev_v9
> 2. http://dpdk.org/dev/patchwork/patch/35216/
> 3. http://dpdk.org/dev/patchwork/patch/36089/
> 
> v3 Changes:
> - change datapath function return from int to uint16_t.
> - Add missing state checks while arm/cancel.
> - add stats.
> 
> v2 Changes:
> - Move common code changes to separate patches.
> - Reduce ifdef clutter.
> - fix improper return value (erik).
> - remove redundent ops assignment (erik).
> - update octeontx documentation.

Please check the following :

1) It has build issue with 32bit build(gcc 7.3.1)

2) clang6 shows some crazy link errors, even though following symbol
has been not used. Looks like we need -latomic
undefined reference to `__atomic_fetch_add_8'

3) Fix check-git-log.sh issues
$./devtools/check-git-log.sh 
Wrong headline lowercase:
event/octeontx: add multiproducer timer arm and cancel
event/octeontx: add single producer timer arm variant
event/octeontx: add burst mode for timer arm

Re: [dpdk-dev] [PATCH v3 02/12] usertools: add Cavium TIM as an event device

[Jerin Jacob]

-Original Message-
> Date: Tue,  3 Apr 2018 20:35:04 +0530
> From: Pavan Nikhilesh 
> To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com,
>  erik.g.carri...@intel.com
> Cc: dev@dpdk.org, Pavan Nikhilesh 
> Subject: [dpdk-dev] [PATCH v3 02/12] usertools: add Cavium TIM as an event
>  device
> X-Mailer: git-send-email 2.16.3
> 
> Signed-off-by: Pavan Nikhilesh 
> ---
>  usertools/dpdk-devbind.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index ff4b186e8..d0c420906 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -22,12 +22,14 @@
>'SVendor': None, 'SDevice': None}
>  cavium_pkx = {'Class': '08', 'Vendor': '177d', 'Device': 'a0dd,a049',
>'SVendor': None, 'SDevice': None}
> +cavium_tim = {'Class': '08', 'Vendor': '177d', 'Device': 'a051',
> +  'SVendor': None, 'SDevice': None}
>  avp_vnic = {'Class': '05', 'Vendor': '1af4', 'Device': '1110',
>'SVendor': None, 'SDevice': None}
>  
>  network_devices = [network_class, cavium_pkx, avp_vnic]
>  crypto_devices = [encryption_class, intel_processor_class]
> -eventdev_devices = [cavium_sso]
> +eventdev_devices = [cavium_sso, cavium_tim]
>  mempool_devices = [cavium_fpa]

Cc: tho...@monjalon.net

Acked-by: Jerin Jacob 
> 

Re: [dpdk-dev] [PATCH v3 05/21] net/virtio: dump packed virtqueue data

[Tiwei Bie]

On Thu, Apr 05, 2018 at 12:10:15PM +0200, Jens Freimann wrote:
> Add support to dump packed virtqueue data to the
> VIRTQUEUE_DUMP() macro.
> 
> Signed-off-by: Jens Freimann 
> ---
>  drivers/net/virtio/virtqueue.h | 7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
> index cc2e7c0f6..7e265bf93 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -360,6 +360,13 @@ virtqueue_notify(struct virtqueue *vq)
>  
>  #ifdef RTE_LIBRTE_VIRTIO_DEBUG_DUMP
>  #define VIRTQUEUE_DUMP(vq) do { \
> +   if (vtpci_packed_queue((vq)->hw)) { \
> + PMD_INIT_LOG(DEBUG, \
> + "VQ: - size=%d; free=%d; last_used_idx=%d;" \

You missed the `,` after the format string.

> + (vq)->vq_nentries, (vq)->vq_free_cnt, nused); \

There is no way to make sure that nused (the last param
in PMD_INIT_LOG()) will be defined and have the meaning
of last_used_idx. It's not the right way to use a variable
in MACRO.

> + break; \
> + } \
> + if (vtpci_packed_queue((vq)->hw)) break; \

Why do the check twice?


>   uint16_t used_idx, nused; \
>   used_idx = (vq)->vq_ring.used->idx; \
>   nused = (uint16_t)(used_idx - (vq)->vq_used_cons_idx); \
> -- 
> 2.14.3
> 

Re: [dpdk-dev] [PATCH v3 07/21] net/virtio: implement transmit path for packed queues

[Tiwei Bie]

On Thu, Apr 05, 2018 at 12:10:17PM +0200, Jens Freimann wrote:
[...]
> diff --git a/drivers/net/virtio/virtio_rxtx.c 
> b/drivers/net/virtio/virtio_rxtx.c
> index a8aa87b32..9f9b5a8f8 100644
> --- a/drivers/net/virtio/virtio_rxtx.c
> +++ b/drivers/net/virtio/virtio_rxtx.c
> @@ -38,6 +38,101 @@
>  #define  VIRTIO_DUMP_PACKET(m, len) do { } while (0)
>  #endif
>  
> +#define VIRTIO_SIMPLE_FLAGS ((uint32_t)ETH_TXQ_FLAGS_NOMULTSEGS | \
> + ETH_TXQ_FLAGS_NOOFFLOADS)

Why add this?


> +
> +/* Cleanup from completed transmits. */
> +static void
> +virtio_xmit_cleanup_packed(struct virtqueue *vq)
> +{
> + uint16_t idx;
> + uint16_t size = vq->vq_nentries;
> + struct vring_desc_packed *desc = vq->vq_ring.desc_packed;
> +
> + idx = vq->vq_used_cons_idx & (size - 1);
> + while (desc_is_used(&desc[idx]) &&
> +vq->vq_free_cnt < size) {
> + vq->vq_free_cnt++;
> + idx = ++vq->vq_used_cons_idx & (size - 1);

Driver needs to keep track of the number of descriptors
to be skipped for each used descriptor.


> + }
> +}
> +
> +uint16_t
> +virtio_xmit_pkts_packed(void *tx_queue, struct rte_mbuf **tx_pkts,
> +  uint16_t nb_pkts)
> +{
[...]
> +}
>  int
>  virtio_dev_rx_queue_done(void *rxq, uint16_t offset)
>  {

Please add an empty line between the functions.


> @@ -547,6 +642,10 @@ virtio_dev_tx_queue_setup_finish(struct rte_eth_dev *dev,
>  
>   PMD_INIT_FUNC_TRACE();
>  
> + if (vtpci_packed_queue(hw)) {
> + vq->vq_ring.avail_wrap_counter = 1;

virtio_dev_tx_queue_setup_finish() will be called during a
dev_stop()/dev_start(). The problem is that, the dev_stop()
doesn't really stop the device. So we can't reset the wrap
counter to 1 in dev_start().


> + }
> +
>   if (hw->use_simple_tx) {
>   for (desc_idx = 0; desc_idx < mid_idx; desc_idx++) {
>   vq->vq_ring.avail->ring[desc_idx] =
> @@ -567,7 +666,8 @@ virtio_dev_tx_queue_setup_finish(struct rte_eth_dev *dev,
>   vq->vq_ring.avail->ring[desc_idx] = desc_idx;
>   }
>  
> - VIRTQUEUE_DUMP(vq);
> + if (!vtpci_packed_queue(hw))

The check isn't needed.


> + VIRTQUEUE_DUMP(vq);
>  
>   return 0;
>  }
> -- 
> 2.14.3
> 

[dpdk-dev] [PATCH] net/i40e: fix flow RSS queue index check error

[Wei Zhao]

Ther is a error in queue index check for RSS queue region
configuration.

Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Signed-off-by: Wei Zhao 
Tested-by: Peng Yuan 
---
 drivers/net/i40e/i40e_flow.c | 19 ---
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index f4d08bb..fb7ad51 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4240,6 +4240,14 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
return -rte_errno;
}
}
+
+   if (rss_info->num < rss->num) {
+   rte_flow_error_set(error, EINVAL,
+   RTE_FLOW_ERROR_TYPE_ACTION,
+   act,
+   "no valid queues");
+   return -rte_errno;
+   }
}
 
for (n = 0; n < conf_info->queue_region_number; n++) {
@@ -4264,17 +4272,6 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
return -rte_errno;
}
 
-   if (rss_info->num < rss->num ||
-   rss->queue[0] < rss_info->queue[0] ||
-   (rss->queue[0] + rss->num >
-   rss_info->num + rss_info->queue[0])) {
-   rte_flow_error_set(error, EINVAL,
-   RTE_FLOW_ERROR_TYPE_ACTION,
-   act,
-   "no valid queues");
-   return -rte_errno;
-   }
-
for (i = 0; i < info->queue_region_number; i++) {
if (info->region[i].queue_num == rss->num &&
info->region[i].queue_start_index ==
-- 
2.7.5

Re: [dpdk-dev] [PATCH v3 18/21] net/virtio: add support for mergeable buffers with packed virtqueues

[Tiwei Bie]

On Thu, Apr 05, 2018 at 12:10:28PM +0200, Jens Freimann wrote:
> Implement support for receiving merged buffers in virtio when packed 
> virtqueues
> are enabled.
> 
> Signed-off-by: Jens Freimann 
> ---
>  drivers/net/virtio/virtio_ethdev.c |  10 ++--
>  drivers/net/virtio/virtio_rxtx.c   | 107 
> +
>  drivers/net/virtio/virtqueue.h |   1 +
>  3 files changed, 104 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c 
> b/drivers/net/virtio/virtio_ethdev.c
> index 7367d9c5d..a3c3376d7 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1322,15 +1322,15 @@ set_rxtx_funcs(struct rte_eth_dev *eth_dev)
>  {
>   struct virtio_hw *hw = eth_dev->data->dev_private;
>  
> - /* workarount for packed vqs which don't support mrg_rxbuf at this 
> point */
> - if (vtpci_packed_queue(hw) && vtpci_with_feature(hw, 
> VIRTIO_NET_F_MRG_RXBUF)) {
> - eth_dev->rx_pkt_burst = &virtio_recv_pkts_packed;
> - } else if (hw->use_simple_rx) {
> + if (hw->use_simple_rx) {
>   PMD_INIT_LOG(INFO, "virtio: using simple Rx path on port %u",
>   eth_dev->data->port_id);
>   eth_dev->rx_pkt_burst = virtio_recv_pkts_vec;

The logic isn't right here. It means when hw->use_simple_rx
is true, virtio_recv_pkts_vec() will be selected as the rx
function for packed ring. But virtio_recv_pkts_vec() doesn't
support packed ring now.


>   } else if (vtpci_packed_queue(hw)) {
> - eth_dev->rx_pkt_burst = &virtio_recv_pkts_packed;
> + if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF))
> + eth_dev->rx_pkt_burst = &virtio_recv_mergeable_pkts;
> + else
> + eth_dev->rx_pkt_burst = &virtio_recv_pkts_packed;
>   } else if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {
>   PMD_INIT_LOG(INFO,
>   "virtio: using mergeable buffer Rx path on port %u",
[...]

Re: [dpdk-dev] [PATCH v3 20/21] net/virtio: add support for event suppression

[Tiwei Bie]

On Thu, Apr 05, 2018 at 12:10:30PM +0200, Jens Freimann wrote:
> Signed-off-by: Jens Freimann 
> ---
>  drivers/net/virtio/virtio_ethdev.c |  2 +-
>  drivers/net/virtio/virtio_ethdev.h |  2 +-
>  drivers/net/virtio/virtio_rxtx.c   | 15 +++-
>  drivers/net/virtio/virtqueue.h | 73 
> --
>  4 files changed, 86 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c 
> b/drivers/net/virtio/virtio_ethdev.c
> index a3c3376d7..65a6a9d89 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -727,7 +727,7 @@ virtio_dev_rx_queue_intr_enable(struct rte_eth_dev *dev, 
> uint16_t queue_id)
>   struct virtnet_rx *rxvq = dev->data->rx_queues[queue_id];
>   struct virtqueue *vq = rxvq->vq;
>  
> - virtqueue_enable_intr(vq);
> + virtqueue_enable_intr(vq, 0, 0);
>   return 0;
>  }
>  
> diff --git a/drivers/net/virtio/virtio_ethdev.h 
> b/drivers/net/virtio/virtio_ethdev.h
> index 3aeced4bb..19d3f2617 100644
> --- a/drivers/net/virtio/virtio_ethdev.h
> +++ b/drivers/net/virtio/virtio_ethdev.h
> @@ -37,7 +37,7 @@
>1u << VIRTIO_RING_F_INDIRECT_DESC |\
>1ULL << VIRTIO_F_VERSION_1   | \
>1ULL << VIRTIO_F_RING_PACKED | \
> -  1ULL << VIRTIO_F_IOMMU_PLATFORM)

Why remove this feature bit?


> +  1ULL << VIRTIO_RING_F_EVENT_IDX)

Supporting event suppression doesn't means supporting
F_EVENT_IDX. Event suppression is mandatory and not
a negotiable feature. F_EVENT_IDX is just an optional
enhancement for event suppression.


>  
>  #define VIRTIO_PMD_SUPPORTED_GUEST_FEATURES  \
>   (VIRTIO_PMD_DEFAULT_GUEST_FEATURES |\
> diff --git a/drivers/net/virtio/virtio_rxtx.c 
> b/drivers/net/virtio/virtio_rxtx.c
> index a48ca6aaa..ed65434ce 100644
> --- a/drivers/net/virtio/virtio_rxtx.c
> +++ b/drivers/net/virtio/virtio_rxtx.c
> @@ -127,6 +127,10 @@ virtio_xmit_pkts_packed(void *tx_queue, struct rte_mbuf 
> **tx_pkts,
>  
>   rte_smp_wmb();
>   _set_desc_avail(&desc[head_idx], wrap_counter);
> + if (unlikely(virtqueue_kick_prepare_packed(vq))) {
> + virtqueue_notify(vq);
> + PMD_RX_LOG(DEBUG, "Notified");

The indent isn't right.


> + }
>   }
[...]

[dpdk-dev] [PATCH] net/i40e: change warning log to flow error set

[Wei Zhao]

Ther is a specific error set fucntiong for flow
error configuration, so change to this mode.

Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Signed-off-by: Wei Zhao 
Tested-by: Peng Yuan 
---
 drivers/net/i40e/i40e_flow.c | 22 +-
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index fb7ad51..2068026 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4255,20 +4255,29 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
conf_info->region[n].flowtype_num) {
if (!((rte_is_power_of_2(rss->num)) &&
rss->num <= 64)) {
-   PMD_DRV_LOG(ERR, "The region sizes should be 
any of the following values: 1, 2, 4, 8, 16, 32, 64 as long as the "
-   "total number of queues do not exceed the VSI 
allocation");
+   rte_flow_error_set(error, EINVAL,
+   RTE_FLOW_ERROR_TYPE_ACTION,
+   act,
+   "The region sizes should be any of the 
following values: 1, 2, 4, 8, 16, 32, 64 as long as the "
+   "total number of queues do not exceed 
the VSI allocation");
return -rte_errno;
}
 
if (conf_info->region[n].user_priority[n] >=
I40E_MAX_USER_PRIORITY) {
-   PMD_DRV_LOG(ERR, "the user priority max index 
is 7");
+   rte_flow_error_set(error, EINVAL,
+   RTE_FLOW_ERROR_TYPE_ACTION,
+   act,
+   "the user priority max index is 7");
return -rte_errno;
}
 
if (conf_info->region[n].hw_flowtype[n] >=
I40E_FILTER_PCTYPE_MAX) {
-   PMD_DRV_LOG(ERR, "the hw_flowtype or PCTYPE max 
index is 63");
+   rte_flow_error_set(error, EINVAL,
+   RTE_FLOW_ERROR_TYPE_ACTION,
+   act,
+   "the hw_flowtype or PCTYPE max index is 
63");
return -rte_errno;
}
 
@@ -4281,7 +4290,10 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
 
if (i == info->queue_region_number) {
if (i > I40E_REGION_MAX_INDEX) {
-   PMD_DRV_LOG(ERR, "the queue region max 
index is 7");
+   rte_flow_error_set(error, EINVAL,
+   RTE_FLOW_ERROR_TYPE_ACTION,
+   act,
+   "the queue region max index is 
7");
return -rte_errno;
}
 
-- 
2.7.5