On 04/06/2018 04:25 PM, Adrien Mazarguil wrote:
Contrary to all other pattern items, these are inconsistently documented as
affecting traffic instead of simply matching its origin, without provision
for the latter.
This commit clarifies documentation and updates PMDs since the original
behavior now has to be explicitly requested using the new transfer
attribute.
It breaks ABI compatibility for the following public functions:
- rte_flow_create()
- rte_flow_validate()
Impacted PMDs are bnxt and i40e, for which the VF pattern item is now only
supported when a transfer attribute is also present.
Signed-off-by: Adrien Mazarguil <adrien.mazarg...@6wind.com>
Cc: Ajit Khaparde <ajit.khapa...@broadcom.com>
Cc: Somnath Kotur <somnath.ko...@broadcom.com>
Cc: Beilei Xing <beilei.x...@intel.com>
Cc: Qi Zhang <qi.z.zh...@intel.com>
---
app/test-pmd/cmdline_flow.c | 12 +++---
doc/guides/prog_guide/rte_flow.rst | 36 +++++++++---------
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +++---
drivers/net/bnxt/bnxt_filter.c | 22 ++++++-----
drivers/net/i40e/i40e_flow.c | 23 +++++++-----
lib/librte_ether/rte_flow.h | 47 ++++++++++--------------
6 files changed, 77 insertions(+), 75 deletions(-)
<...>
diff --git a/doc/guides/prog_guide/rte_flow.rst
b/doc/guides/prog_guide/rte_flow.rst
index 735ce6323..beedc713b 100644
--- a/doc/guides/prog_guide/rte_flow.rst
+++ b/doc/guides/prog_guide/rte_flow.rst
@@ -518,15 +518,12 @@ Usage example, matching non-TCPv4 packets only:
Item: ``PF``
^^^^^^^^^^^^
-Matches packets addressed to the physical function of the device.
+Matches traffic originating from (ingress) or going to (egress) the physical
+function of the current device.
Not sure that I understand above. It looks like ingress and egress are
misplaced.
There many similar cases below.
<...>
