[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled
(2014/10/01 19:50), Neil Horman wrote: > I'm not sure why thats necesecary. We add a --start-group/--end-group pair > halfway through this makefile. If we just encompassed the entire set of > libraries in that group, order would be irrelevant. I haven't known the options. Thanks. Anyway, I understand I shouldn't change link order, but should check why '--start-group/--end-group' doesn't work on my environment. I will describe more in the email for Thomas. Regards, Tetsuya > Neil > >> Signed-off-by: Tetsuya Mukawa >> --- >> mk/rte.app.mk | 16 >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk >> index 34dff2a..172ba4d 100644 >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -121,10 +121,6 @@ endif >> >> LDLIBS += --start-group >> >> -ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y) >> -LDLIBS += -lrte_kvargs >> -endif >> - >> ifeq ($(CONFIG_RTE_LIBRTE_MBUF),y) >> LDLIBS += -lrte_mbuf >> endif >> @@ -137,6 +133,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_ETHER),y) >> LDLIBS += -lethdev >> endif >> >> +ifeq ($(CONFIG_RTE_LIBRTE_EAL),y) >> +LDLIBS += -lrte_eal >> +endif >> + >> ifeq ($(CONFIG_RTE_LIBRTE_MALLOC),y) >> LDLIBS += -lrte_malloc >> endif >> @@ -158,10 +158,6 @@ ifeq ($(CONFIG_RTE_LIBGLOSS),y) >> LDLIBS += -lgloss >> endif >> >> -ifeq ($(CONFIG_RTE_LIBRTE_EAL),y) >> -LDLIBS += -lrte_eal >> -endif >> - >> ifeq ($(CONFIG_RTE_LIBRTE_CMDLINE),y) >> LDLIBS += -lrte_cmdline >> endif >> @@ -174,6 +170,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_BOND),y) >> LDLIBS += -lrte_pmd_bond >> endif >> >> +ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y) >> +LDLIBS += -lrte_kvargs >> +endif >> + >> ifeq ($(CONFIG_RTE_LIBRTE_PMD_XENVIRT),y) >> LDLIBS += -lrte_pmd_xenvirt >> LDLIBS += -lxenstore >> -- >> 1.9.1 >> >>
[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit
> Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in
> recv/xmit
>
> On Wed, Oct 01, 2014 at 11:33:23PM +, Hiroshi Shimamoto wrote:
> > > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in
> > > recv/xmit
> > >
> > > On Wed, Oct 01, 2014 at 09:12:44AM +, Hiroshi Shimamoto wrote:
> > > > > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in
> > > > > recv/xmit
> > > > >
> > > > > On Tue, Sep 30, 2014 at 11:52:00PM +, Hiroshi Shimamoto wrote:
> > > > > > Hi,
> > > > > >
> > > > > > > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch
> > > > > > > hint in recv/xmit
> > > > > > >
> > > > > > > On Tue, Sep 30, 2014 at 11:14:40AM +, Hiroshi Shimamoto wrote:
> > > > > > > > From: Hiroshi Shimamoto
> > > > > > > >
> > > > > > > > To reduce instruction cache miss, add branch condition hints
> > > > > > > > into
> > > > > > > > recv/xmit functions. This improves a bit performance.
> > > > > > > >
> > > > > > > > We can see performance improvements with memnic-tester.
> > > > > > > > Using Xeon E5-2697 v2 @ 2.70GHz, 4 vCPU.
> > > > > > > > size | before | after
> > > > > > > >64 | 5.54Mpps | 5.55Mpps
> > > > > > > > 128 | 5.46Mpps | 5.44Mpps
> > > > > > > > 256 | 5.21Mpps | 5.22Mpps
> > > > > > > > 512 | 4.50Mpps | 4.52Mpps
> > > > > > > > 1024 | 3.71Mpps | 3.73Mpps
> > > > > > > > 1280 | 3.21Mpps | 3.22Mpps
> > > > > > > > 1518 | 2.92Mpps | 2.93Mpps
> > > > > > > >
> > > > > > > > Signed-off-by: Hiroshi Shimamoto
> > > > > > > > Reviewed-by: Hayato Momma
> > > > > > > > ---
> > > > > > > > pmd/pmd_memnic.c | 18 +-
> > > > > > > > 1 file changed, 9 insertions(+), 9 deletions(-)
> > > > > > > >
> > > > > > > > diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
> > > > > > > > index 7fc3093..875d3ea 100644
> > > > > > > > --- a/pmd/pmd_memnic.c
> > > > > > > > +++ b/pmd/pmd_memnic.c
> > > > > > > > @@ -289,26 +289,26 @@ static uint16_t memnic_recv_pkts(void
> > > > > > > > *rx_queue,
> > > > > > > > int idx, next;
> > > > > > > > struct rte_eth_stats *st =
> > > > > > > > &adapter->stats[rte_lcore_id()];
> > > > > > > >
> > > > > > > > - if (!adapter->nic->hdr.valid)
> > > > > > > > + if (unlikely(!adapter->nic->hdr.valid))
> > > > > > > > return 0;
> > > > > > > >
> > > > > > > > pkts = bytes = errs = 0;
> > > > > > > > idx = adapter->up_idx;
> > > > > > > > for (nr = 0; nr < nb_pkts; nr++) {
> > > > > > > > p = &data->packets[idx];
> > > > > > > > - if (p->status != MEMNIC_PKT_ST_FILLED)
> > > > > > > > + if (unlikely(p->status != MEMNIC_PKT_ST_FILLED))
> > > > > > > > break;
> > > > > > > > /* prefetch the next area */
> > > > > > > > next = idx;
> > > > > > > > - if (++next >= MEMNIC_NR_PACKET)
> > > > > > > > + if (unlikely(++next >= MEMNIC_NR_PACKET))
> > > > > > > > next = 0;
> > > > > > > > rte_prefetch0(&data->packets[next]);
> > > > > > > > - if (p->len > framesz) {
> > > > > > > > + if (unlikely(p->len > framesz)) {
> > > > > > > > errs++;
> > > > > > > > goto drop;
> > > > > > > > }
> > > > > > > > mb = rte_pktmbuf_alloc(adapter->mp);
> > > > > > > > - if (!mb)
> > > > > > > > + if (unlikely(!mb))
> > > > > > > > break;
> > > > > > > >
> > > > > > > > rte_memcpy(rte_pktmbuf_mtod(mb, void *),
> > > > > > > > p->data, p->len);
> > > > > > > > @@ -350,7 +350,7 @@ static uint16_t memnic_xmit_pkts(void
> > > > > > > > *tx_queue,
> > > > > > > > uint64_t pkts, bytes, errs;
> > > > > > > > uint32_t framesz = adapter->framesz;
> > > > > > > >
> > > > > > > > - if (!adapter->nic->hdr.valid)
> > > > > > > > + if (unlikely(!adapter->nic->hdr.valid))
> > > > > > > > return 0;
> > > > > > > >
> > > > > > > > pkts = bytes = errs = 0;
> > > > > > > > @@ -360,7 +360,7 @@ static uint16_t memnic_xmit_pkts(void
> > > > > > > > *tx_queue,
> > > > > > > > struct rte_mbuf *sg;
> > > > > > > > void *ptr;
> > > > > > > >
> > > > > > > > - if (pkt_len > framesz) {
> > > > > > > > + if (unlikely(pkt_len > framesz)) {
> > > > > > > > errs++;
> > > > > > > > break;
> > > > > > > > }
> > > > > > > > @@ -379,7 +379,7 @@ retry:
> > > > > > > > goto retry;
> > > > > > > > }
> > > > > > > >
> > > > > > > > - if (idx != ACCESS_ONCE(adapter->down_idx)) {
> > > > > > > > + if (unlikely(idx !=
> > > > > > > > ACCESS_ONCE(adapter->down_idx))) {
> > > > > > > Why are you u
[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled
(2014/10/01 20:56), Thomas Monjalon wrote: > 2014-10-01 06:50, Neil Horman: >> On Wed, Oct 01, 2014 at 01:27:03PM +0900, mukawa at igel.co.jp wrote: >>> When CONFIG_RTE_BUILD_SHARED_LIB is enabled, linking errors occured >>> while compiling. It seems those errors are caused by wrong link order >>> of some libraries. The patch fixes it like following. >>> >>> 1. librte_eal >>> 2. librte_malloc >>> 3. librte_mempool >>> 4. librte_ring >>> 5. librte_pmd_bond >>> 6. librte_kvargs >>> >> I'm not sure why thats necesecary. We add a --start-group/--end-group pair >> halfway through this makefile. If we just encompassed the entire set of >> libraries in that group, order would be irrelevant. > I don't see any error. > Please Tetsuya, could you describe how you test and what is the error message? > > Thanks Thank you for testing. I have confirmed '--start-group/--end-groups' is specified while compiling, but I am still seeing the error. Here is what I actually did. -- << Show my environment >> $ uname -a Linux eris 3.13.0-29-generic #53-Ubuntu SMP Wed Jun 4 21:00:20 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux $ lsb_release -a No LSB modules are available. Distributor ID:Ubuntu Description:Ubuntu 14.04.1 LTS Release:14.04 Codename:trusty $ gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Ubuntu 4.8.2-19ubuntu1' --with-bugurl=file:///usr/share/doc/gcc-4.8/README.Bugs --enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.8 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.8 --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-gnu-unique-object --disable-libmudflap --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.8-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu Thread model: posix gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) << Compile DPDK >> $ git clone git://dpdk.org/dpdk $ cd dpdk $ vi config/common_linuxapp CONFIG_RTE_BUILD_SHARED_LIB=y $ T=x86_64-native-linuxapp-gcc make install V=1 ... == Build app/test-acl gcc -Wp,-MD,./.main.o.d.tmp -m64 -pthread -fPIC -march=native -DRTE_MACHINE_CPUFLAG_SSE -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MACHINE_CPUFLAG_SSE3 -DRTE_MACHINE_CPUFLAG_SSSE3 -DRTE_MACHINE_CPUFLAG_SSE4_1 -DRTE_MACHINE_CPUFLAG_SSE4_2 -DRTE_MACHINE_CPUFLAG_AES -DRTE_MACHINE_CPUFLAG_PCLMULQDQ -DRTE_MACHINE_CPUFLAG_AVX -DRTE_MACHINE_CPUFLAG_F16C -DRTE_COMPILE_TIME_CPUFLAGS=RTE_CPUFLAG_SSE,RTE_CPUFLAG_SSE2,RTE_CPUFLAG_SSE3,RTE_CPUFLAG_SSSE3,RTE_CPUFLAG_SSE4_1,RTE_CPUFLAG_SSE4_2,RTE_CPUFLAG_AES,RTE_CPUFLAG_PCLMULQDQ,RTE_CPUFLAG_AVX,RTE_CPUFLAG_F16C -I/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include -include /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include/rte_config.h -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings -o main.o -c /home/mukawa/tmp/dpdk/app/test-acl/main.c gcc -m64 -pthread -fPIC -march=native -DRTE_MACHINE_CPUFLAG_SSE -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MACHINE_CPUFLAG_SSE3 -DRTE_MACHINE_CPUFLAG_SSSE3 -DRTE_MACHINE_CPUFLAG_SSE4_1 -DRTE_MACHINE_CPUFLAG_SSE4_2 -DRTE_MACHINE_CPUFLAG_AES -DRTE_MACHINE_CPUFLAG_PCLMULQDQ -DRTE_MACHINE_CPUFLAG_AVX -DRTE_MACHINE_CPUFLAG_F16C -DRTE_COMPILE_TIME_CPUFLAGS=RTE_CPUFLAG_SSE,RTE_CPUFLAG_SSE2,RTE_CPUFLAG_SSE3,RTE_CPUFLAG_SSSE3,RTE_CPUFLAG_SSE4_1,RTE_CPUFLAG_SSE4_2,RTE_CPUFLAG_AES,RTE_CPUFLAG_PCLMULQDQ,RTE_CPUFLAG_AVX,RTE_CPUFLAG_F16C -I/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include -include /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include/rte_config.h -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings -Wl,-Map=testacl.map,--cref -o testacl main.o -Wl,-export-dynamic -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib -Wl,--whole-archive -Wl,-lrte_distributor -Wl,-lrte_kni -Wl,-
[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled
(2014/10/02 11:46), Matthew Hall wrote: > On Thu, Oct 02, 2014 at 10:43:52AM +0900, Tetsuya Mukawa wrote: > It's worth pointing out that you're likely better off using > COMBINE_LIBS to make one big static lib rather than using a shared lib > or you're facing a performance loss from the dynamic linking overhead. > Matthew. Thanks. I will go over it Regards, Tetsuya
[dpdk-dev] [PATCH v2] rte_mempool_dump() crashes with NULL rte_mempool pointer.
2014-10-01 17:05, Bruce Richardson: > On Wed, Oct 01, 2014 at 12:01:10PM -0400, Neil Horman wrote: > > On Wed, Oct 01, 2014 at 04:43:10PM +0100, Bruce Richardson wrote: > > > On Wed, Oct 01, 2014 at 11:02:27AM -0400, Neil Horman wrote: > > > > On Wed, Oct 01, 2014 at 03:36:45PM +0200, Thomas Monjalon wrote: > > > > > 2014-09-28 08:27, Neil Horman: > > > > > > On Sun, Sep 28, 2014 at 05:28:44AM +, Wiles, Roger Keith wrote: > > > > > > > Check the FILE *f and rte_mempool *mp pointers for NULL and > > > > > > > return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is > > > > > > > enabled. > > > > > > > > > > > > > > Signed-off-by: Keith Wiles > > > > > > > > > > > > I'm fine with this, as I think passing in a NULL mempool is clearly > > > > > > a bug here, > > > > > > thats worth panicing over, though I wouldnt mind if we did a > > > > > > RTE_VERIFY_WARN > > > > > > macro here instead using what I suggested in my other note > > > > > > > > > > Passing a NULL mempool to rte_mempool_dump() is a bug in the > > > > > application. > > > > > If you look elsewhere in the DPDK code, you'll see that it's not > > > > > common to do > > > > > such check on input parameters. > > > > > A similar discussion already happened few months ago: > > > > > http://dpdk.org/ml/archives/dev/2014-June/003900.html > > > > > > > > > Not sure what your point is here Thomas. I think we're all in > > > > agreement that > > > > NULL is a bad value to pass in here. Are you asserting that we > > > > shouldn't bother > > > > with a NULL check at all and just accept the crash as it is? > > > > > > > > > > In the general case: > > > * Code in the datapath should not have things like NULL checks > > > * However, datapath code should generally have a debug option which turns > > > these checks on to help debugging if needed. > > > * Code not in the datapath probably should have these checks. > > > > > Ok, I can understand that, but I would hope that rte_mempool_dump isn't in > > the > > datapath, its rather by definition a debug function, isn't it? > > Neil > > Yes, agreed. [So it probably should have the NULL check]. I have many arguments to not do this check: 1) If it was a coding rule to do this kind of check, it should be done in almost every functions. 2) It's quite common to not do this check, e.g. what happen with memcpy(NULL,NULL)? 3) Why check only NULL value? 1 and 2 are also some invalid values... -- Thomas
[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled
On Thu, Oct 02, 2014 at 11:48:37AM +0900, Tetsuya Mukawa wrote: > (2014/10/01 20:56), Thomas Monjalon wrote: > > 2014-10-01 06:50, Neil Horman: > >> On Wed, Oct 01, 2014 at 01:27:03PM +0900, mukawa at igel.co.jp wrote: > >>> When CONFIG_RTE_BUILD_SHARED_LIB is enabled, linking errors occured > >>> while compiling. It seems those errors are caused by wrong link order > >>> of some libraries. The patch fixes it like following. > >>> > >>> 1. librte_eal > >>> 2. librte_malloc > >>> 3. librte_mempool > >>> 4. librte_ring > >>> 5. librte_pmd_bond > >>> 6. librte_kvargs > >>> > >> I'm not sure why thats necesecary. We add a --start-group/--end-group pair > >> halfway through this makefile. If we just encompassed the entire set of > >> libraries in that group, order would be irrelevant. > > I don't see any error. > > Please Tetsuya, could you describe how you test and what is the error > > message? > > > > Thanks > Thank you for testing. > I have confirmed '--start-group/--end-groups' is specified while > compiling, but I am still seeing the error. > > Here is what I actually did. > > -- > > << Show my environment >> > $ uname -a > Linux eris 3.13.0-29-generic #53-Ubuntu SMP Wed Jun 4 21:00:20 UTC 2014 > x86_64 x86_64 x86_64 GNU/Linux > $ lsb_release -a > No LSB modules are available. > Distributor ID:Ubuntu > Description:Ubuntu 14.04.1 LTS > Release:14.04 > Codename:trusty > $ gcc -v > Using built-in specs. > COLLECT_GCC=gcc > COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper > Target: x86_64-linux-gnu > Configured with: ../src/configure -v --with-pkgversion='Ubuntu > 4.8.2-19ubuntu1' --with-bugurl=file:///usr/share/doc/gcc-4.8/README.Bugs > --enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr > --program-suffix=-4.8 --enable-shared --enable-linker-build-id > --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix > --with-gxx-include-dir=/usr/include/c++/4.8 --libdir=/usr/lib > --enable-nls --with-sysroot=/ --enable-clocale=gnu > --enable-libstdcxx-debug --enable-libstdcxx-time=yes > --enable-gnu-unique-object --disable-libmudflap --enable-plugin > --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk > --enable-gtk-cairo > --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64/jre > --enable-java-home > --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64 > --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.8-amd64 > --with-arch-directory=amd64 > --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc > --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 > --with-multilib-list=m32,m64,mx32 --with-tune=generic > --enable-checking=release --build=x86_64-linux-gnu > --host=x86_64-linux-gnu --target=x86_64-linux-gnu > Thread model: posix > gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) > > << Compile DPDK >> > $ git clone git://dpdk.org/dpdk > $ cd dpdk > $ vi config/common_linuxapp > CONFIG_RTE_BUILD_SHARED_LIB=y > $ T=x86_64-native-linuxapp-gcc make install V=1 > > ... > > == Build app/test-acl > gcc -Wp,-MD,./.main.o.d.tmp -m64 -pthread -fPIC -march=native > -DRTE_MACHINE_CPUFLAG_SSE -DRTE_MACHINE_CPUFLAG_SSE2 > -DRTE_MACHINE_CPUFLAG_SSE3 -DRTE_MACHINE_CPUFLAG_SSSE3 > -DRTE_MACHINE_CPUFLAG_SSE4_1 -DRTE_MACHINE_CPUFLAG_SSE4_2 > -DRTE_MACHINE_CPUFLAG_AES -DRTE_MACHINE_CPUFLAG_PCLMULQDQ > -DRTE_MACHINE_CPUFLAG_AVX -DRTE_MACHINE_CPUFLAG_F16C > -DRTE_COMPILE_TIME_CPUFLAGS=RTE_CPUFLAG_SSE,RTE_CPUFLAG_SSE2,RTE_CPUFLAG_SSE3,RTE_CPUFLAG_SSSE3,RTE_CPUFLAG_SSE4_1,RTE_CPUFLAG_SSE4_2,RTE_CPUFLAG_AES,RTE_CPUFLAG_PCLMULQDQ,RTE_CPUFLAG_AVX,RTE_CPUFLAG_F16C > > -I/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include -include > /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include/rte_config.h -W > -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes > -Wmissing-declarations -Wold-style-definition -Wpointer-arith > -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral > -Wformat-security -Wundef -Wwrite-strings -o main.o -c > /home/mukawa/tmp/dpdk/app/test-acl/main.c > gcc -m64 -pthread -fPIC -march=native -DRTE_MACHINE_CPUFLAG_SSE > -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MACHINE_CPUFLAG_SSE3 > -DRTE_MACHINE_CPUFLAG_SSSE3 -DRTE_MACHINE_CPUFLAG_SSE4_1 > -DRTE_MACHINE_CPUFLAG_SSE4_2 -DRTE_MACHINE_CPUFLAG_AES > -DRTE_MACHINE_CPUFLAG_PCLMULQDQ -DRTE_MACHINE_CPUFLAG_AVX > -DRTE_MACHINE_CPUFLAG_F16C > -DRTE_COMPILE_TIME_CPUFLAGS=RTE_CPUFLAG_SSE,RTE_CPUFLAG_SSE2,RTE_CPUFLAG_SSE3,RTE_CPUFLAG_SSSE3,RTE_CPUFLAG_SSE4_1,RTE_CPUFLAG_SSE4_2,RTE_CPUFLAG_AES,RTE_CPUFLAG_PCLMULQDQ,RTE_CPUFLAG_AVX,RTE_CPUFLAG_F16C > > -I/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include -include > /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include/rte_config.h -W > -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes > -Wmissing-declarations -Wold-style-definition -Wpointer-arith > -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral
[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled
(2014/10/02 17:12), Sergio Gonzalez Monroy wrote: > On Thu, Oct 02, 2014 at 11:48:37AM +0900, Tetsuya Mukawa wrote: > >> $ gcc -m64 -pthread -fPIC -march=native -DRTE_MACHINE_CPUFLAG_SSE >> -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MACHINE_CPUFLAG_SSE3 >> -DRTE_MACHINE_CPUFLAG_SSSE3 -DRTE_MACHINE_CPUFLAG_SSE4_1 >> -DRTE_MACHINE_CPUFLAG_SSE4_2 -DRTE_MACHINE_CPUFLAG_AES >> -DRTE_MACHINE_CPUFLAG_PCLMULQDQ -DRTE_MACHINE_CPUFLAG_AVX >> -DRTE_MACHINE_CPUFLAG_F16C >> -DRTE_COMPILE_TIME_CPUFLAGS=RTE_CPUFLAG_SSE,RTE_CPUFLAG_SSE2,RTE_CPUFLAG_SSE3,RTE_CPUFLAG_SSSE3,RTE_CPUFLAG_SSE4_1,RTE_CPUFLAG_SSE4_2,RTE_CPUFLAG_AES,RTE_CPUFLAG_PCLMULQDQ,RTE_CPUFLAG_AVX,RTE_CPUFLAG_F16C >> -I/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include -include >> /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include/rte_config.h >> -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes >> -Wmissing-declarations -Wold-style-definition -Wpointer-arith >> -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral >> -Wformat-security -Wundef -Wwrite-strings -Wl,-Map=testacl.map,--cref >> -o testacl main.o -Wl,-export-dynamic >> -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib >> -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib >> -Wl,--whole-archive -Wl,-lrte_distributor -Wl,-lrte_kni >> -Wl,-lrte_pipeline -Wl,-lrte_table -Wl,-lrte_port -Wl,-lrte_timer >> -Wl,-lrte_hash -Wl,-lrte_lpm -Wl,-lrte_power -Wl,-lrte_acl >> -Wl,-lrte_meter -Wl,-lrte_sched -Wl,-lm -Wl,-lrt -Wl,--start-group >> -Wl,-lrte_kvargs -Wl,-lrte_mbuf -Wl,-lrte_ip_frag -Wl,-lethdev >> -Wl,-lrte_malloc -Wl,-lrte_mempool -Wl,-lrte_ring -Wl,-lrte_eal >> -Wl,-lrte_cmdline -Wl,-lrte_cfgfile -Wl,-lrte_pmd_bond -Wl,-lrt >> -Wl,-lm -Wl,-lgcc_s -Wl,-ldl -Wl,--end-group -Wl,--no-whole-archive >> /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib/librte_eal.so: >> undefined reference to `rte_mempool_lookup' >> /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib/librte_eal.so: >> undefined reference to `rte_mempool_create' collect2: error: ld >> returned 1 exit status > Hi Tetsuya, > > Would you mind posting the output of the last command adding the option '-v'? Sure, here is. $ gcc -m64 -pthread -fPIC -march=native -DRTE_MACHINE_CPUFLAG_SSE -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MACHINE_CPUFLAG_SSE3 -DRTE_MACHINE_CPUFLAG_SSSE3 -DRTE_MACHINE_CPUFLAG_SSE4_1 -DRTE_MACHINE_CPUFLAG_SSE4_2 -DRTE_MACHINE_CPUFLAG_AES -DRTE_MACHINE_CPUFLAG_PCLMULQDQ -DRTE_MACHINE_CPUFLAG_AVX -DRTE_MACHINE_CPUFLAG_F16C -DRTE_COMPILE_TIME_CPUFLAGS=RTE_CPUFLAG_SSE,RTE_CPUFLAG_SSE2,RTE_CPUFLAG_SSE3,RTE_CPUFLAG_SSSE3,RTE_CPUFLAG_SSE4_1,RTE_CPUFLAG_SSE4_2,RTE_CPUFLAG_AES,RTE_CPUFLAG_PCLMULQDQ,RTE_CPUFLAG_AVX,RTE_CPUFLAG_F16C -I/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include -include /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include/rte_config.h -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings -Wl,-Map=testacl.map,--cref -o testacl main.o -Wl,-export-dynamic -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib -Wl,--whole-archive -Wl,-lrte_distributor -Wl,-lrte_kni -Wl,-lrte_pipeline -Wl,-lrte_table -Wl,-lrte_port -Wl,-lrte_timer -Wl,-lrte_hash -Wl,-lrte_lpm -Wl,-lrte_power -Wl,-lrte_acl -Wl,-lrte_meter -Wl,-lrte_sched -Wl,-lm -Wl,-lrt -Wl,--start-group -Wl,-lrte_kvargs -Wl,-lrte_mbuf -Wl,-lrte_ip_frag -Wl,-lethdev -Wl,-lrte_malloc -Wl,-lrte_mempool -Wl,-lrte_ring -Wl,-lrte_eal -Wl,-lrte_cmdline -Wl,-lrte_cfgfile -Wl,-lrte_pmd_bond -Wl,-lrt -Wl,-lm -Wl,-lgcc_s -Wl,-ldl -Wl,--end-group -Wl,--no-whole-archive -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Ubuntu 4.8.2-19ubuntu1' --with-bugurl=file:///usr/share/doc/gcc-4.8/README.Bugs --enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-4.8 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.8 --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-gnu-unique-object --disable-libmudflap --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.8-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linu
[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled
On Thu, Oct 02, 2014 at 05:28:04PM +0900, Tetsuya Mukawa wrote: > (2014/10/02 17:12), Sergio Gonzalez Monroy wrote: > > On Thu, Oct 02, 2014 at 11:48:37AM +0900, Tetsuya Mukawa wrote: > > > >> $ gcc -m64 -pthread -fPIC -march=native -DRTE_MACHINE_CPUFLAG_SSE > >> -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MACHINE_CPUFLAG_SSE3 > >> -DRTE_MACHINE_CPUFLAG_SSSE3 -DRTE_MACHINE_CPUFLAG_SSE4_1 > >> -DRTE_MACHINE_CPUFLAG_SSE4_2 -DRTE_MACHINE_CPUFLAG_AES > >> -DRTE_MACHINE_CPUFLAG_PCLMULQDQ -DRTE_MACHINE_CPUFLAG_AVX > >> -DRTE_MACHINE_CPUFLAG_F16C > >> -DRTE_COMPILE_TIME_CPUFLAGS=RTE_CPUFLAG_SSE,RTE_CPUFLAG_SSE2,RTE_CPUFLAG_SSE3,RTE_CPUFLAG_SSSE3,RTE_CPUFLAG_SSE4_1,RTE_CPUFLAG_SSE4_2,RTE_CPUFLAG_AES,RTE_CPUFLAG_PCLMULQDQ,RTE_CPUFLAG_AVX,RTE_CPUFLAG_F16C > >> -I/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include -include > >> /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include/rte_config.h > >> -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes > >> -Wmissing-declarations -Wold-style-definition -Wpointer-arith > >> -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral > >> -Wformat-security -Wundef -Wwrite-strings -Wl,-Map=testacl.map,--cref > >> -o testacl main.o -Wl,-export-dynamic > >> -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib > >> -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib > >> -Wl,--whole-archive -Wl,-lrte_distributor -Wl,-lrte_kni > >> -Wl,-lrte_pipeline -Wl,-lrte_table -Wl,-lrte_port -Wl,-lrte_timer > >> -Wl,-lrte_hash -Wl,-lrte_lpm -Wl,-lrte_power -Wl,-lrte_acl > >> -Wl,-lrte_meter -Wl,-lrte_sched -Wl,-lm -Wl,-lrt -Wl,--start-group > >> -Wl,-lrte_kvargs -Wl,-lrte_mbuf -Wl,-lrte_ip_frag -Wl,-lethdev > >> -Wl,-lrte_malloc -Wl,-lrte_mempool -Wl,-lrte_ring -Wl,-lrte_eal > >> -Wl,-lrte_cmdline -Wl,-lrte_cfgfile -Wl,-lrte_pmd_bond -Wl,-lrt > >> -Wl,-lm -Wl,-lgcc_s -Wl,-ldl -Wl,--end-group -Wl,--no-whole-archive > >> /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib/librte_eal.so: > >> undefined reference to `rte_mempool_lookup' > >> /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib/librte_eal.so: > >> undefined reference to `rte_mempool_create' collect2: error: ld > >> returned 1 exit status > > Hi Tetsuya, > > > > Would you mind posting the output of the last command adding the option > > '-v'? > Sure, here is. > > $ gcc -m64 -pthread -fPIC -march=native -DRTE_MACHINE_CPUFLAG_SSE > -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MACHINE_CPUFLAG_SSE3 > -DRTE_MACHINE_CPUFLAG_SSSE3 -DRTE_MACHINE_CPUFLAG_SSE4_1 > -DRTE_MACHINE_CPUFLAG_SSE4_2 -DRTE_MACHINE_CPUFLAG_AES > -DRTE_MACHINE_CPUFLAG_PCLMULQDQ -DRTE_MACHINE_CPUFLAG_AVX > -DRTE_MACHINE_CPUFLAG_F16C > -DRTE_COMPILE_TIME_CPUFLAGS=RTE_CPUFLAG_SSE,RTE_CPUFLAG_SSE2,RTE_CPUFLAG_SSE3,RTE_CPUFLAG_SSSE3,RTE_CPUFLAG_SSE4_1,RTE_CPUFLAG_SSE4_2,RTE_CPUFLAG_AES,RTE_CPUFLAG_PCLMULQDQ,RTE_CPUFLAG_AVX,RTE_CPUFLAG_F16C > > -I/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include -include > /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include/rte_config.h -W > -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes > -Wmissing-declarations -Wold-style-definition -Wpointer-arith > -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral > -Wformat-security -Wundef -Wwrite-strings -Wl,-Map=testacl.map,--cref > -o testacl main.o -Wl,-export-dynamic > -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib > -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib > -Wl,--whole-archive -Wl,-lrte_distributor -Wl,-lrte_kni > -Wl,-lrte_pipeline -Wl,-lrte_table -Wl,-lrte_port -Wl,-lrte_timer > -Wl,-lrte_hash -Wl,-lrte_lpm -Wl,-lrte_power -Wl,-lrte_acl > -Wl,-lrte_meter -Wl,-lrte_sched -Wl,-lm -Wl,-lrt -Wl,--start-group > -Wl,-lrte_kvargs -Wl,-lrte_mbuf -Wl,-lrte_ip_frag -Wl,-lethdev > -Wl,-lrte_malloc -Wl,-lrte_mempool -Wl,-lrte_ring -Wl,-lrte_eal > -Wl,-lrte_cmdline -Wl,-lrte_cfgfile -Wl,-lrte_pmd_bond -Wl,-lrt -Wl,-lm > -Wl,-lgcc_s -Wl,-ldl -Wl,--end-group -Wl,--no-whole-archive -v > Using built-in specs. > COLLECT_GCC=gcc > COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper > Target: x86_64-linux-gnu > Configured with: ../src/configure -v --with-pkgversion='Ubuntu > 4.8.2-19ubuntu1' --with-bugurl=file:///usr/share/doc/gcc-4.8/README.Bugs > --enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr > --program-suffix=-4.8 --enable-shared --enable-linker-build-id > --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix > --with-gxx-include-dir=/usr/include/c++/4.8 --libdir=/usr/lib > --enable-nls --with-sysroot=/ --enable-clocale=gnu > --enable-libstdcxx-debug --enable-libstdcxx-time=yes > --enable-gnu-unique-object --disable-libmudflap --enable-plugin > --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk > --enable-gtk-cairo > --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64/jre > --enable-java-home > --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64 > --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.8-amd64 > --with-arch-directory=amd64 > --with-ecj-jar=/usr/sha
[dpdk-dev] [PATCH v3] distributor_app: new sample app
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, October 01, 2014 4:38 PM > To: Neil Horman > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] distributor_app: new sample app > > On Wed, Oct 01, 2014 at 10:56:20AM -0400, Neil Horman wrote: > > On Wed, Oct 01, 2014 at 02:47:00PM +, Pattan, Reshma wrote: > > > > > > > > > > -Original Message- > > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > > > Sent: Tuesday, September 30, 2014 2:40 PM > > > > To: Richardson, Bruce > > > > Cc: Pattan, Reshma; dev at dpdk.org > > > > Subject: Re: [dpdk-dev] [PATCH v3] distributor_app: new sample app > > > > > > > > On Tue, Sep 30, 2014 at 01:18:28PM +0100, Bruce Richardson wrote: > > > > > On Tue, Sep 30, 2014 at 07:34:45AM -0400, Neil Horman wrote: > > > > > > On Tue, Sep 30, 2014 at 11:39:37AM +0100, reshmapa wrote: > > > > > > > From: Reshma Pattan > > > > > > > > > > > > > > A new sample app that shows the usage of the distributor library. > > > > > > > This app works as follows: > > > > > > > > > > > > > > * An RX thread runs which pulls packets from each ethernet port > > > > > > > in turn > > > > > > > and passes those packets to worker using a distributor > > > > > > > component. > > > > > > > * The workers take the packets in turn, and determine the output > > > > > > > port > > > > > > > for those packets using basic l2forwarding doing an xor on the > > > > > > > source > > > > > > > port id. > > > > > > > * The RX thread takes the returned packets from the workers and > > > > > > > enqueue > > > > > > > those packets into an rte_ring structure. > > > > > > > * A TX thread pulls the packets off the rte_ring structure and > > > > > > > then > > > > > > > sends each packet out the output port specified previously by > > > > > > > the worker > > > > > > > * Command-line option support provided only for portmask. > > > > > > > > > > > > > > Signed-off-by: Bruce Richardson > > > > > > > Signed-off-by: Reshma Pattan > > > > > > > --- > > > > > > > examples/Makefile |1 + > > > > > > > examples/distributor_app/Makefile | 57 > > > > > > > examples/distributor_app/main.c | 600 > > > > + > > > > > > > examples/distributor_app/main.h | 46 +++ > > > > > > > 4 files changed, 704 insertions(+), 0 deletions(-) create mode > > > > > > > 100644 examples/distributor_app/Makefile create mode 100644 > > > > > > > examples/distributor_app/main.c create mode 100644 > > > > > > > examples/distributor_app/main.h > > > > > > > > > > > > > > diff --git a/examples/Makefile b/examples/Makefile index > > > > > > > 6245f83..2ba82b0 100644 > > > > > > > --- a/examples/Makefile > > > > > > > +++ b/examples/Makefile > > > > > > > @@ -66,5 +66,6 @@ DIRS-y += vhost > > > > > > > DIRS-$(CONFIG_RTE_LIBRTE_XEN_DOM0) += vhost_xen DIRS-y += vmdq > > > > > > > DIRS-y += vmdq_dcb > > > > > > > +DIRS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += distributor_app > > > > > > > > > > > > > > include $(RTE_SDK)/mk/rte.extsubdir.mk diff --git > > > > > > > a/examples/distributor_app/Makefile > > > > > > > b/examples/distributor_app/Makefile > > > > > > > new file mode 100644 > > > > > > > index 000..6a5bada > > > > > > > --- /dev/null > > > > > > > +++ b/examples/distributor_app/Makefile > > > > > > > @@ -0,0 +1,57 @@ > > > > > > > +# BSD LICENSE > > > > > > > +# > > > > > > > +# Copyright(c) 2010-2014 Intel Corporation. All rights > > > > > > > reserved. > > > > > > > +# All rights reserved. > > > > > > > +# > > > > > > > +# Redistribution and use in source and binary forms, with or > > > > > > > without > > > > > > > +# modification, are permitted provided that the following > > > > > > > conditions > > > > > > > +# are met: > > > > > > > +# > > > > > > > +# * Redistributions of source code must retain the above > > > > > > > copyright > > > > > > > +# notice, this list of conditions and the following > > > > > > > disclaimer. > > > > > > > +# * Redistributions in binary form must reproduce the above > > > > > > > copyright > > > > > > > +# notice, this list of conditions and the following > > > > > > > disclaimer in > > > > > > > +# the documentation and/or other materials provided with > > > > > > > the > > > > > > > +# distribution. > > > > > > > +# * Neither the name of Intel Corporation nor the names of > > > > > > > its > > > > > > > +# contributors may be used to endorse or promote products > > > > > > > derived > > > > > > > +# from this software without specific prior written > > > > > > > permission. > > > > > > > +# > > > > > > > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND > > > > CONTRIBUTORS > > > > > > > +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT > > > > NOT > > > > > > > +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled
(2014/10/02 17:53), Sergio Gonzalez Monroy wrote: > On Thu, Oct 02, 2014 at 05:28:04PM +0900, Tetsuya Mukawa wrote: >> (2014/10/02 17:12), Sergio Gonzalez Monroy wrote: >>> On Thu, Oct 02, 2014 at 11:48:37AM +0900, Tetsuya Mukawa wrote: >>> $ gcc -m64 -pthread -fPIC -march=native -DRTE_MACHINE_CPUFLAG_SSE -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MACHINE_CPUFLAG_SSE3 -DRTE_MACHINE_CPUFLAG_SSSE3 -DRTE_MACHINE_CPUFLAG_SSE4_1 -DRTE_MACHINE_CPUFLAG_SSE4_2 -DRTE_MACHINE_CPUFLAG_AES -DRTE_MACHINE_CPUFLAG_PCLMULQDQ -DRTE_MACHINE_CPUFLAG_AVX -DRTE_MACHINE_CPUFLAG_F16C -DRTE_COMPILE_TIME_CPUFLAGS=RTE_CPUFLAG_SSE,RTE_CPUFLAG_SSE2,RTE_CPUFLAG_SSE3,RTE_CPUFLAG_SSSE3,RTE_CPUFLAG_SSE4_1,RTE_CPUFLAG_SSE4_2,RTE_CPUFLAG_AES,RTE_CPUFLAG_PCLMULQDQ,RTE_CPUFLAG_AVX,RTE_CPUFLAG_F16C -I/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include -include /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include/rte_config.h -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings -Wl,-Map=testacl.map,--cref -o testacl main.o -Wl,-export-dynamic -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib -Wl,--whole-archive -Wl,-lrte_distributor -Wl,-lrte_kni -Wl,-lrte_pipeline -Wl,-lrte_table -Wl,-lrte_port -Wl,-lrte_timer -Wl,-lrte_hash -Wl,-lrte_lpm -Wl,-lrte_power -Wl,-lrte_acl -Wl,-lrte_meter -Wl,-lrte_sched -Wl,-lm -Wl,-lrt -Wl,--start-group -Wl,-lrte_kvargs -Wl,-lrte_mbuf -Wl,-lrte_ip_frag -Wl,-lethdev -Wl,-lrte_malloc -Wl,-lrte_mempool -Wl,-lrte_ring -Wl,-lrte_eal -Wl,-lrte_cmdline -Wl,-lrte_cfgfile -Wl,-lrte_pmd_bond -Wl,-lrt -Wl,-lm -Wl,-lgcc_s -Wl,-ldl -Wl,--end-group -Wl,--no-whole-archive /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib/librte_eal.so: undefined reference to `rte_mempool_lookup' /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib/librte_eal.so: undefined reference to `rte_mempool_create' collect2: error: ld returned 1 exit status >>> Hi Tetsuya, >>> >>> Would you mind posting the output of the last command adding the option >>> '-v'? >> Sure, here is. >> >> $ gcc -m64 -pthread -fPIC -march=native -DRTE_MACHINE_CPUFLAG_SSE >> -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MACHINE_CPUFLAG_SSE3 >> -DRTE_MACHINE_CPUFLAG_SSSE3 -DRTE_MACHINE_CPUFLAG_SSE4_1 >> -DRTE_MACHINE_CPUFLAG_SSE4_2 -DRTE_MACHINE_CPUFLAG_AES >> -DRTE_MACHINE_CPUFLAG_PCLMULQDQ -DRTE_MACHINE_CPUFLAG_AVX >> -DRTE_MACHINE_CPUFLAG_F16C >> -DRTE_COMPILE_TIME_CPUFLAGS=RTE_CPUFLAG_SSE,RTE_CPUFLAG_SSE2,RTE_CPUFLAG_SSE3,RTE_CPUFLAG_SSSE3,RTE_CPUFLAG_SSE4_1,RTE_CPUFLAG_SSE4_2,RTE_CPUFLAG_AES,RTE_CPUFLAG_PCLMULQDQ,RTE_CPUFLAG_AVX,RTE_CPUFLAG_F16C >> >> -I/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include -include >> /home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/include/rte_config.h -W >> -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes >> -Wmissing-declarations -Wold-style-definition -Wpointer-arith >> -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral >> -Wformat-security -Wundef -Wwrite-strings -Wl,-Map=testacl.map,--cref >> -o testacl main.o -Wl,-export-dynamic >> -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib >> -L/home/mukawa/tmp/dpdk/x86_64-native-linuxapp-gcc/lib >> -Wl,--whole-archive -Wl,-lrte_distributor -Wl,-lrte_kni >> -Wl,-lrte_pipeline -Wl,-lrte_table -Wl,-lrte_port -Wl,-lrte_timer >> -Wl,-lrte_hash -Wl,-lrte_lpm -Wl,-lrte_power -Wl,-lrte_acl >> -Wl,-lrte_meter -Wl,-lrte_sched -Wl,-lm -Wl,-lrt -Wl,--start-group >> -Wl,-lrte_kvargs -Wl,-lrte_mbuf -Wl,-lrte_ip_frag -Wl,-lethdev >> -Wl,-lrte_malloc -Wl,-lrte_mempool -Wl,-lrte_ring -Wl,-lrte_eal >> -Wl,-lrte_cmdline -Wl,-lrte_cfgfile -Wl,-lrte_pmd_bond -Wl,-lrt -Wl,-lm >> -Wl,-lgcc_s -Wl,-ldl -Wl,--end-group -Wl,--no-whole-archive -v >> Using built-in specs. >> COLLECT_GCC=gcc >> COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper >> Target: x86_64-linux-gnu >> Configured with: ../src/configure -v --with-pkgversion='Ubuntu >> 4.8.2-19ubuntu1' --with-bugurl=file:///usr/share/doc/gcc-4.8/README.Bugs >> --enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr >> --program-suffix=-4.8 --enable-shared --enable-linker-build-id >> --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix >> --with-gxx-include-dir=/usr/include/c++/4.8 --libdir=/usr/lib >> --enable-nls --with-sysroot=/ --enable-clocale=gnu >> --enable-libstdcxx-debug --enable-libstdcxx-time=yes >> --enable-gnu-unique-object --disable-libmudflap --enable-plugin >> --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk >> --enable-gtk-cairo >> --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64/jre >> --enable-java-home >> --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64 >> --with-jvm-jar-dir=/us
[dpdk-dev] [PATCH v3 0/3] Get default RX/TX configuration
On Wed, Oct 1, 2014 at 11:54 AM, De Lara Guarch, Pablo < pablo.de.lara.guarch at intel.com> wrote: > > > > -Original Message- > > From: De Lara Guarch, Pablo > > Sent: Wednesday, October 01, 2014 10:49 AM > > To: dev at dpdk.org > > Cc: De Lara Guarch, Pablo > > Subject: [PATCH v3 0/3] Get default RX/TX configuration > > > > These patches modified the dev info structure to include optimal values > > for the RX/TX configuration structures (rte_eth_rxconf and > rte_eth_txconf), > > so users can get these configurations and modify or use them directly, > > to set up RX/TX queues. Besides, most of the apps that were modifying > little > > or none of the default values of the structures, have been modified to > get > > these values to simplify the code and avoid duplication. > > > > Pablo de Lara (3): > > ether: Reset whole dev info structure > > pmd: Modified dev_info structure to include default RX/TX > > configuration > > app: Used default RX/TX configuration got from dev info in apps > > Changes in V3: > > - Separated dev info reset in different patch > - Deleted unnecessary local variables > - Added extra documentation for RX/TX queue setup functions. > > Series Acked-by: David Marchand Thanks Pablo. -- David Marchand
[dpdk-dev] [PATCH v2] rte_mempool_dump() crashes with NULL rte_mempool pointer.
On Thu, Oct 02, 2014 at 09:47:19AM +0200, Thomas Monjalon wrote: > 2014-10-01 17:05, Bruce Richardson: > > On Wed, Oct 01, 2014 at 12:01:10PM -0400, Neil Horman wrote: > > > On Wed, Oct 01, 2014 at 04:43:10PM +0100, Bruce Richardson wrote: > > > > On Wed, Oct 01, 2014 at 11:02:27AM -0400, Neil Horman wrote: > > > > > On Wed, Oct 01, 2014 at 03:36:45PM +0200, Thomas Monjalon wrote: > > > > > > 2014-09-28 08:27, Neil Horman: > > > > > > > On Sun, Sep 28, 2014 at 05:28:44AM +, Wiles, Roger Keith > > > > > > > wrote: > > > > > > > > Check the FILE *f and rte_mempool *mp pointers for NULL and > > > > > > > > return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is > > > > > > > > enabled. > > > > > > > > > > > > > > > > Signed-off-by: Keith Wiles > > > > > > > > > > > > > > I'm fine with this, as I think passing in a NULL mempool is > > > > > > > clearly a bug here, > > > > > > > thats worth panicing over, though I wouldnt mind if we did a > > > > > > > RTE_VERIFY_WARN > > > > > > > macro here instead using what I suggested in my other note > > > > > > > > > > > > Passing a NULL mempool to rte_mempool_dump() is a bug in the > > > > > > application. > > > > > > If you look elsewhere in the DPDK code, you'll see that it's not > > > > > > common to do > > > > > > such check on input parameters. > > > > > > A similar discussion already happened few months ago: > > > > > > http://dpdk.org/ml/archives/dev/2014-June/003900.html > > > > > > > > > > > Not sure what your point is here Thomas. I think we're all in > > > > > agreement that > > > > > NULL is a bad value to pass in here. Are you asserting that we > > > > > shouldn't bother > > > > > with a NULL check at all and just accept the crash as it is? > > > > > > > > > > > > > In the general case: > > > > * Code in the datapath should not have things like NULL checks > > > > * However, datapath code should generally have a debug option which > > > > turns > > > > these checks on to help debugging if needed. > > > > * Code not in the datapath probably should have these checks. > > > > > > > Ok, I can understand that, but I would hope that rte_mempool_dump isn't > > > in the > > > datapath, its rather by definition a debug function, isn't it? > > > Neil > > > > Yes, agreed. [So it probably should have the NULL check]. > > I have many arguments to not do this check: > 1) If it was a coding rule to do this kind of check, it should be done in > almost every functions. Only if NULL is an invalid value, and we spot check for NULL all the time (see eal_parse_coremask as an example from a quick search). > 2) It's quite common to not do this check, e.g. what happen with > memcpy(NULL,NULL)? Its also quite common to do the check. I think this is more about if it makes sense to do it here (i.e. is it a common error to pass a NULL pointer into mempool_dump?). If so, an extra check with its own specific panic might be nice. > 3) Why check only NULL value? 1 and 2 are also some invalid values... > Because NULL is the common case. Neil > -- > Thomas >
[dpdk-dev] [dpdk-announce] patchwork available
Hi all, A tool is now available to check state of the patches: http://dpdk.org/dev/patchwork It also helps to download patches for testing/review. Some explanations can be found in the dev page: http://dpdk.org/dev#patchwork Mails are automatically added to patchwork's database but every other actions are manual. It is possible to setup some scripts to automate more things but it would fail in many cases and would make it unreliable. So, in order to ease the maintenance of this database, developers are now responsible of obsoleting patches when they send a new version of a patch. In other words, please set your v1 patch as "Superseded" when sending a v2. Thanks -- Thomas
[dpdk-dev] [PATCH 1/4] Link combined shared library using CC
It adds override definition of LD when linking using CC. Also it adds muldefs option to the linker when building shared libraries (same as building individual libraries). Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.sharelib.mk | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk index c0a811a..942671d 100644 --- a/mk/rte.sharelib.mk +++ b/mk/rte.sharelib.mk @@ -40,12 +40,20 @@ LIB_ONE := lib$(RTE_LIBNAME).a endif endif +ifeq ($(LINK_USING_CC),1) +# Override the definition of LD here, since we're linking with CC +LD := $(CC) +LD_MULDEFS := $(call linkerprefix,-z$(comma)muldefs) +CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS)) +endif + .PHONY:sharelib sharelib: $(LIB_ONE) FORCE OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o) -O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) +O_TO_S = $(LD) $(CPU_LDFLAGS) $(LD_MULDEFS) -shared $(OBJS)\ + -o $(RTE_OUTPUT)/lib/$(LIB_ONE) O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)") O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)" -- 1.9.3
[dpdk-dev] [PATCH 2/4] Do not generate individual libs when configured with RTE_BUILD_COMBINE_LIBS=y
When RTE_BUILD_COMBINE_LIBS=y is configured, there won't be individual shared libraries to copy over. Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.lib.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index f458258..d594692 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -158,9 +158,11 @@ endif # install lib in $(RTE_OUTPUT)/lib # $(RTE_OUTPUT)/lib/$(LIB): $(LIB) +ifneq ($(RTE_BUILD_COMBINE_LIBS),y) @echo " INSTALL-LIB $(LIB)" @[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib $(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib +endif # # Clean all generated files -- 1.9.3
[dpdk-dev] [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y
When building DPDK with CONFIG_RTE_BUILD_COMBINE_LIBS=y, the result is not the expected behavior. - It does link the combine library using LD instead of CC which results in application linking errors. - It creates both individual libraries and combine library, then linking applications against all of them. This patch set aims to fix those issues. The last patch 'cleanup', in my opinion, simplifies and removes duplication of rules. It is not required for fixing the issues mentioned above. Sergio Gonzalez Monroy (4): Link combined shared library using CC Do not generate individual libs when configured with RTE_BUILD_COMBINE_LIBS=y Link apps only against combined lib or individual libs, not both Cleanup mk/rte.app.mk | 13 +--- mk/rte.lib.mk | 90 +- mk/rte.sharelib.mk | 47 ++-- 3 files changed, 54 insertions(+), 96 deletions(-) Signed-off-by: Sergio Gonzalez Monroy -- 1.9.3
[dpdk-dev] [PATCH 3/4] Link apps only against combined lib or individual libs, not both
Link only against combined library or individual libraries. Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.app.mk | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 34dff2a..6f752dd 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -59,6 +59,13 @@ LDLIBS += -L$(RTE_SDK_BIN)/lib # ifeq ($(NO_AUTOLIBS),) +ifeq ($(RTE_BUILD_COMBINE_LIBS),y) +LDLIBS += --start-group +LDLIBS += -l$(RTE_LIBNAME) +LDLIBS += $(EXECENV_LDLIBS) +LDLIBS += --end-group +else + LDLIBS += --whole-archive ifeq ($(CONFIG_RTE_LIBRTE_DISTRIBUTOR),y) @@ -218,6 +225,8 @@ LDLIBS += --end-group LDLIBS += --no-whole-archive +endif # ifeq ($(RTE_BUILD_COMBINE_LIBS),y) + endif # ifeq ($(NO_AUTOLIBS),) LDLIBS += $(CPU_LDLIBS) @@ -235,10 +244,6 @@ build: _postbuild exe2cmd = $(strip $(call dotfile,$(patsubst %,%.cmd,$(1 -ifeq ($(RTE_BUILD_COMBINE_LIBS),y) -LDLIBS += -l$(RTE_LIBNAME) -endif - ifeq ($(LINK_USING_CC),1) LDLIBS := $(call linkerprefix,$(LDLIBS)) LDFLAGS := $(call linkerprefix,$(LDFLAGS)) -- 1.9.3
[dpdk-dev] [PATCH 4/4] Cleanup
Reduce code duplication. This patch is not required for the patch set to work. Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.lib.mk | 88 +- mk/rte.sharelib.mk | 39 ++-- 2 files changed, 35 insertions(+), 92 deletions(-) diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index d594692..84f5a64 100644 --- a/mk/rte.lib.mk +++ b/mk/rte.lib.mk @@ -66,93 +66,45 @@ LD_MULDEFS := $(call linkerprefix,-z$(comma)muldefs) CPU_LDFLAGS := $(call linkerprefix,$(CPU_LDFLAGS)) endif -O_TO_A = $(AR) crus $(LIB) $(OBJS-y) -O_TO_A_STR = $(subst ','\'',$(O_TO_A)) #'# fix syntax highlight -O_TO_A_DISP = $(if $(V),"$(O_TO_A_STR)"," AR $(@)") -O_TO_A_CMD = "cmd_$@ = $(O_TO_A_STR)" -O_TO_A_DO = @set -e; \ - echo $(O_TO_A_DISP); \ - $(O_TO_A) && \ - echo $(O_TO_A_CMD) > $(call exe2cmd,$(@)) - -O_TO_S = $(LD) $(CPU_LDFLAGS) $(LD_MULDEFS) -shared $(OBJS-y) -o $(LIB) -O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight -O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)"," LD $(@)") -O_TO_S_DO = @set -e; \ - echo $(O_TO_S_DISP); \ - $(O_TO_S) && \ - echo $(O_TO_S_CMD) > $(call exe2cmd,$(@)) - -ifeq ($(RTE_BUILD_SHARED_LIB),n) -O_TO_C = $(AR) crus $(LIB_ONE) $(OBJS-y) -O_TO_C_STR = $(subst ','\'',$(O_TO_C)) #'# fix syntax highlight -O_TO_C_DISP = $(if $(V),"$(O_TO_C_STR)"," AR_C $(@)") -O_TO_C_DO = @set -e; \ - $(lib_dir) \ - $(copy_obj) +ifeq ($(RTE_BUILD_COMBINE_LIBS),y) +O_TO_L_DO = @set -e; \ + cp -f $(OBJS-y) $(RTE_OUTPUT)/build/lib; +else +ifeq ($(RTE_BUILD_SHARED_LIB),y) +O_TO_L = $(LD) $(CPU_LDFLAGS) $(LD_MULDEFS) -shared $(OBJS-y) -o $(LIB) +L_DISP=LD else -O_TO_C = $(LD) $(LD_MULDEFS) -shared $(OBJS-y) -o $(LIB_ONE) -O_TO_C_STR = $(subst ','\'',$(O_TO_C)) #'# fix syntax highlight -O_TO_C_DISP = $(if $(V),"$(O_TO_C_STR)"," LD_C $(@)") -O_TO_C_DO = @set -e; \ - $(lib_dir) \ - $(copy_obj) +O_TO_L = $(AR) crus $(LIB) $(OBJS-y) +L_DISP=AR +endif +O_TO_L_STR = $(subst ','\'',$(O_TO_L)) #') # fix syntax highlight +O_TO_L_DISP = $(if $(V),"$(O_TO_L_STR)"," $(L_DISP) $(@)") +O_TO_L_CMD = "cmd_$@ = $(O_TO_L_STR)" +O_TO_L_DO = @set -e; \ + echo $(O_TO_L_DISP); \ + $(O_TO_L) && \ + echo $(O_TO_L_CMD) > $(call exe2cmd,$(@)) endif -copy_obj = cp -f $(OBJS-y) $(RTE_OUTPUT)/build/lib; -lib_dir = [ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib; -include .$(LIB).cmd # # Archive objects in .a file if needed # -ifeq ($(RTE_BUILD_SHARED_LIB),y) $(LIB): $(OBJS-y) $(DEP_$(LIB)) FORCE @[ -d $(dir $@) ] || mkdir -p $(dir $@) $(if $(D),\ @echo -n "$< -> $@ " ; \ echo -n "file_missing=$(call boolean,$(file_missing)) " ; \ - echo -n "cmdline_changed=$(call boolean,$(call cmdline_changed,$(O_TO_S_STR))) " ; \ + echo -n "cmdline_changed=$(call boolean,$(call cmdline_changed,$(O_TO_L_STR))) " ; \ echo -n "depfile_missing=$(call boolean,$(depfile_missing)) " ; \ echo "depfile_newer=$(call boolean,$(depfile_newer)) ") $(if $(or \ - $(file_missing),\ - $(call cmdline_changed,$(O_TO_S_STR)),\ - $(depfile_missing),\ - $(depfile_newer)),\ - $(O_TO_S_DO)) -ifeq ($(RTE_BUILD_COMBINE_LIBS),y) - $(if $(or \ -$(file_missing),\ -$(call cmdline_changed,$(O_TO_C_STR)),\ -$(depfile_missing),\ -$(depfile_newer)),\ -$(O_TO_C_DO)) -endif -else -$(LIB): $(OBJS-y) $(DEP_$(LIB)) FORCE - @[ -d $(dir $@) ] || mkdir -p $(dir $@) - $(if $(D),\ - @echo -n "$< -> $@ " ; \ - echo -n "file_missing=$(call boolean,$(file_missing)) " ; \ - echo -n "cmdline_changed=$(call boolean,$(call cmdline_changed,$(O_TO_A_STR))) " ; \ - echo -n "depfile_missing=$(call boolean,$(depfile_missing)) " ; \ - echo "depfile_newer=$(call boolean,$(depfile_newer)) ") - $(if $(or \ $(file_missing),\ - $(call cmdline_changed,$(O_TO_A_STR)),\ + $(call cmdline_changed,$(O_TO_L_STR)),\ $(depfile_missing),\ $(depfile_newer)),\ - $(O_TO_A_DO)) -ifeq ($(RTE_BUILD_COMBINE_LIBS),y) - $(if $(or \ -$(file_missing),\ -$(call cmdline_changed,$(O_TO_C_STR)),\ -$(depfile_missing),\ -$(depfile_newer)),\ -$(O_TO_C_DO)) -endif -endif + $(O_TO_L_DO)) # # install lib in $(RTE_OUTPUT)/lib diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk index 942671d..0efa0b7 100644 --- a/mk/rte.sharelib.mk +++ b/mk/rte.sharelib.mk @@ -52,37 +52,28 @@ sharelib: $(LIB_ONE) FORCE OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o) -O_TO_S = $(LD) $(CPU_LDFLAGS) $(LD_MULDEFS) -shared $(OBJS)\ +ifeq ($(RTE_BUILD_SHARED_LIB),y) +O_TO_L = $(LD) $(CPU_LDFLAGS) $(LD_MULDEFS) -shared $(OBJS)\ -o $(RTE_OUTPUT)/lib/$(LIB_ONE) -O_TO_S_STR = $(su
[dpdk-dev] [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y
On Thu, Oct 02, 2014 at 04:56:22PM +0100, Sergio Gonzalez Monroy wrote: > When building DPDK with CONFIG_RTE_BUILD_COMBINE_LIBS=y, the result is not > the expected behavior. > > - It does link the combine library using LD instead of CC which results > in application linking errors. > > - It creates both individual libraries and combine library, then linking > applications against all of them. > > This patch set aims to fix those issues. > > The last patch 'cleanup', in my opinion, simplifies and removes duplication of > rules. > It is not required for fixing the issues mentioned above. > > Sergio Gonzalez Monroy (4): > Link combined shared library using CC > Do not generate individual libs when configured with > RTE_BUILD_COMBINE_LIBS=y > Link apps only against combined lib or individual libs, not both > Cleanup > > mk/rte.app.mk | 13 +--- > mk/rte.lib.mk | 90 > +- > mk/rte.sharelib.mk | 47 ++-- > 3 files changed, 54 insertions(+), 96 deletions(-) > > Signed-off-by: Sergio Gonzalez Monroy > > -- > 1.9.3 > > Just out of curiosity, whats the impetus behind a single shared library here? Is it just to ease application linking operations? If so, it almost seems to me that we should abandon the individual linking method and just use this as the default output (and do simmilarly for the static linking build) Neil
[dpdk-dev] [PATCH 2/4] Do not generate individual libs when configured with RTE_BUILD_COMBINE_LIBS=y
On Thu, Oct 02, 2014 at 04:56:24PM +0100, Sergio Gonzalez Monroy wrote: > When RTE_BUILD_COMBINE_LIBS=y is configured, there won't be individual shared > libraries to copy over. As a user of RTE_BUILD_COMBINE_LIBS, disabling the ability to use the individual libs after the option is enabled is not helpful. It would be more helpful if all libs are kept available, so when working with multiple DPDK apps which might prefer combined or uncombined, everything will still work. Thanks, Matthew.
[dpdk-dev] [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y
On Thu, Oct 02, 2014 at 01:26:34PM -0400, Neil Horman wrote: > Just out of curiosity, whats the impetus behind a single shared library here? > Is it just to ease application linking operations? If so, it almost seems to > me > that we should abandon the individual linking method and just use this as the > default output (and do simmilarly for the static linking build) > > Neil Not clear if you wrote "single shared library" on purpose instead of "single static library". But for me the objective of COMBINE_LIBS usage would be getting a "single static library" for my app, which just works, and eliminates need of start-group, end-group, weird library ordering issues, etc. I'm not interested personally in a "shared library" because it'd run slower. Personally my preference would be to do both the single libs and multiple libs in static format by default. Disk space is cheap, let's maximize user freedom and flexibility. But shared lib, since it performs less well, should be discouraged by default, although allowed if needed... some people prefer it because it's easier to patch security vulns if you can replace a buggy library for all the code on a system. Matthew.
[dpdk-dev] [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y
On Thu, Oct 02, 2014 at 01:04:20PM -0700, Matthew Hall wrote: > On Thu, Oct 02, 2014 at 01:26:34PM -0400, Neil Horman wrote: > > Just out of curiosity, whats the impetus behind a single shared library > > here? > > Is it just to ease application linking operations? If so, it almost seems > > to me > > that we should abandon the individual linking method and just use this as > > the > > default output (and do simmilarly for the static linking build) > > > > Neil > > Not clear if you wrote "single shared library" on purpose instead of "single > static library". But for me the objective of COMBINE_LIBS usage would be > getting a "single static library" for my app, which just works, and > eliminates > need of start-group, end-group, weird library ordering issues, etc. I'm not > interested personally in a "shared library" because it'd run slower. > Actually I do need to revise my question, thank you. you're right, doing a single archive for static builds makes the most sense, because you wind up with a static binary anyway, and as such, theres really no need for multiple dpdk archives. We should just create a single dpdk.a file and be done with it. The shared libraries are a different story. While at first it made sense to me to merge them all, it actually doesn't because PMD's might be built independently and shipped separate from the core library. > Personally my preference would be to do both the single libs and multiple > libs > in static format by default. Disk space is cheap, let's maximize user freedom > and flexibility. But shared lib, since it performs less well, should be > discouraged by default, although allowed if needed... some people prefer it > because it's easier to patch security vulns if you can replace a buggy > library > for all the code on a system. > This seems somewhat irrelevant to the patch. The default configuration is already the way you want it to be, shared library performance is actually very close to static performance, and yes, people can choose how they want to build. Not sure what point your trying to make here. Neil > Matthew. >
[dpdk-dev] [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y
On Thu, Oct 02, 2014 at 04:24:51PM -0400, Neil Horman wrote: > This seems somewhat irrelevant to the patch. The default configuration is > already the way you want it to be, shared library performance is actually very > close to static performance, and yes, people can choose how they want to > build. > Not sure what point your trying to make here. > Neil According to my reading, one of the subpatches threatened to disable the single static libs when the grouped one is built. If you are working with multiple DPDK apps, and one expects COMBINE_LIBS and the other does not, you can't use both with the same copy of DPDK anymore if that subpatch gets committed. Matthew.
[dpdk-dev] [PATCH v3] Clang compile error with RTE_LIBRTE_MEMPOOL_DEBUG enabled.
Resend as it is missing in patchwork.
When enabling RTE_LIBRTE_MEMPOOL_DEBUG and compiling with clang
compiler an error occurs, because ifdefed code now includes GCC pragmas.
GCC 4.4 is when push_options and pop_options pragma show up.
Rework to include Thomas?s suggestion to drop push/pop pragma directives for
ignore/error directives.
Signed-off-by: Keith Wiles
---
lib/librte_mempool/rte_mempool.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 95f19f9..163de86 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -313,7 +313,6 @@ static inline void __mempool_write_trailer_cookie(void *obj)
*/
#ifdef RTE_LIBRTE_MEMPOOL_DEBUG
#ifndef __INTEL_COMPILER
-#pragma GCC push_options
#pragma GCC diagnostic ignored "-Wcast-qual"
#endif
static inline void __mempool_check_cookies(const struct rte_mempool *mp,
@@ -380,7 +379,7 @@ static inline void __mempool_check_cookies(const struct
rte_mempool *mp,
}
}
#ifndef __INTEL_COMPILER
-#pragma GCC pop_options
+#pragma GCC diagnostic error "-Wcast-qual"
#endif
#else
#define __mempool_check_cookies(mp, obj_table_const, n, free) do {} while(0)
--
2.1.0
Keith Wiles, Principal Technologist with CTO office, Wind River mobile
972-213-5533
[dpdk-dev] [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y
On Thu, Oct 02, 2014 at 02:10:55PM -0700, Matthew Hall wrote: > On Thu, Oct 02, 2014 at 04:24:51PM -0400, Neil Horman wrote: > > This seems somewhat irrelevant to the patch. The default configuration is > > already the way you want it to be, shared library performance is actually > > very > > close to static performance, and yes, people can choose how they want to > > build. > > Not sure what point your trying to make here. > > Neil > > According to my reading, one of the subpatches threatened to disable the > single static libs when the grouped one is built. If you are working with > multiple DPDK apps, and one expects COMBINE_LIBS and the other does not, you > can't use both with the same copy of DPDK anymore if that subpatch gets > committed. > Ah, sorry, I misread, and thought you were advoating for making static builds the default over dynamic builds, which made no sense to me, as that was already the case. Neil > Matthew. >
